--- Log opened Wed Jan 03 00:00:05 2018
--- Day changed Wed Jan 03 2018
20180103 00:00:05-!- irker569 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20180103 00:00:05< irker569> wesnoth/wesnoth:close-connection-on-cancel Jyrki Vesterinen 87e7738d03 Addon client: close connection if the pl AppVeyor: All builds passed
20180103 00:01:41-!- Appleman1234 [~quassel@124x38x163x22.ap124.ftth.ucom.ne.jp] has quit [Ping timeout: 260 seconds]
20180103 01:00:07-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 268 seconds]
20180103 01:16:32-!- Bonobo [~Bonobo@60-241-159-43.tpgi.com.au] has joined #wesnoth-dev
20180103 01:21:09-!- Greg-Boggs [~greg_bogg@c-73-11-32-127.hsd1.or.comcast.net] has joined #wesnoth-dev
20180103 01:25:21-!- Greg-Boggs [~greg_bogg@c-73-11-32-127.hsd1.or.comcast.net] has quit [Ping timeout: 248 seconds]
20180103 01:25:41-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20180103 01:31:43-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20180103 01:36:43-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180103 01:36:46< Ravana_> I continued with Lua inspect, https://vgy.me/R9Dth8.png so far
20180103 01:36:53-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20180103 01:38:06< celticminstrel> That looks... extremely ugly. >_>
20180103 01:38:40< celticminstrel> How does it work exactly? I mean for the person using it, not how it's implemented.
20180103 01:39:36< Ravana_> currently just :lua to open it, will be menu item
20180103 01:39:58< celticminstrel> Are you implying there's no interaction whatsoever?
20180103 01:40:04< Ravana_> allows selecting subtables to inspect
20180103 01:40:29< celticminstrel> Okay, so you select a subtable and... does it automatically expand it or do you click OK or that crossed swords thing...?
20180103 01:40:45< celticminstrel> I guess probably not the crossed swords thing (what's that even for though)
20180103 01:40:49< Ravana_> with OK it recursively goes deeper
20180103 01:41:11< Ravana_> that swords thing is not needed, but dialog code is not easy to modify, so haven't removed it yet
20180103 01:41:12< celticminstrel> Hmm.
20180103 01:41:34< celticminstrel> In that case, I'd say you should have a back button.
20180103 01:41:51< celticminstrel> Or "up one level".
20180103 01:42:21< celticminstrel> But back is probably a bit better because it's more consistent in the event of cross-references.
20180103 01:42:44< celticminstrel> Are you implementing this in Lua?
20180103 01:43:23< Ravana_> yes
20180103 01:44:43< celticminstrel> I feel like it could be a bit more useful if implemented in C++, though the Lua debug module (...which is apparently shown in your screenshot, oddly) does expose most of the things you'd need. The only problem is that Wesnoth deliberately nils them out because they're a security hazard.
20180103 01:44:57< Ravana_> that is not Lua debug
20180103 01:45:08< celticminstrel> Hmm?
20180103 01:45:13< Ravana_> _G["debug"] I marked to not be displayed
20180103 01:45:31< celticminstrel> I guess its contents do look a little different than I'd expect for _G.debug.
20180103 01:45:32< Ravana_> for first call I have local excluded = {"_G","debug","H","helper","math","os","string","T","table","wesnoth",""}
20180103 01:46:06< celticminstrel> Might want to add "wml" to that.
20180103 01:46:14< Ravana_> https://pastebin.com/eXPfggLG I have ORM.debug containing some functions, that is what was visible
20180103 01:46:26< celticminstrel> (It's not officially documented yet though.)
20180103 01:47:14< celticminstrel> Wait, are you working in 1.12 or 1.13 here?
20180103 01:47:18< Ravana_> 1.12
20180103 01:47:23< celticminstrel> Oh, okay then.
20180103 01:47:34< celticminstrel> There are definitely a few more you'd want to exclude in 1.13.
20180103 01:48:28< Ravana_> I started by showing all, there removed those that seemed not useful
20180103 01:50:17< celticminstrel> ?
20180103 02:00:41< Ravana_> not sure how to add back button.. just duplicating cancel definition and changing id did not work
20180103 02:01:02< celticminstrel> You need to attach a callback.
20180103 02:01:22< celticminstrel> I'd actually do that for what's currently the OK button, too.
20180103 02:01:53< celticminstrel> And morph the cancel button into a Done button, which I think would have id=okay
20180103 02:02:40< celticminstrel> (Or id=ok or whatever)
20180103 02:02:47< celticminstrel> (Maybe id=done has the same effect, not sure)
20180103 02:07:01< Ravana_> how to return value from button callback function?
20180103 02:07:18< celticminstrel> Eh, I guess you'd assign it to an upvalue?
20180103 02:07:41< celticminstrel> You can't directly return an arbitrary value.
20180103 02:07:59< celticminstrel> I don't quite remember, maybe you can return an integer.
20180103 02:08:56< Ravana_> currently pressing back button remembers it has been used, but dialog is closed only from other buttons
20180103 02:09:37< celticminstrel> While you can certainly implement it by re-showing the dialog every time you change the contents, I don't think that's what I would recommend...
20180103 02:12:02< Ravana_> added stackbased back using return_value attribute
20180103 02:20:30< Ravana_> I plan to add modifying scalar values, maybe calling functions as well, but anything further should not be needed for me currently
20180103 02:21:46< celticminstrel> You'd need C++ to obtain the requirements for calling functions (basically how many arguments are needed).
20180103 02:22:10< celticminstrel> I suppose you can just let people use any number and give an error if it's the wrong number though.
20180103 02:22:53< Ravana_> I only plan to use it as developing tool, so against my own Lua code
20180103 02:23:20< celticminstrel> It's only functions defined in Lua that have actual defined limits on the number of arguments.
20180103 02:23:55< celticminstrel> But you can totally call it with the wrong number in a protected context, catch the error, and recover from it.
20180103 02:25:15< Ravana_> I already have menu item that implements :lua command, that should be good enough for calling functions
20180103 03:00:51-!- irker569 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20180103 03:09:03-!- syrma[m] [syrmamatri@gateway/shell/matrix.org/x-onpxdqsbmofofwjn] has joined #wesnoth-dev
20180103 03:34:31-!- vultraz [uid24821@wesnoth/developer/vultraz] has joined #wesnoth-dev
20180103 03:34:40-!- irker479 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20180103 03:34:40< irker479> wesnoth/wesnoth:master Jyrki Vesterinen 90ea7b9769 Addon client: close connection if the pl AppVeyor: All builds passed
20180103 03:50:10-!- Greg-Boggs [~greg_bogg@2601:1c2:1a80:1c20:addf:ebd4:891:5c3c] has joined #wesnoth-dev
20180103 04:09:27-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180103 04:09:38-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20180103 04:14:52-!- Greg-Boggs [~greg_bogg@2601:1c2:1a80:1c20:addf:ebd4:891:5c3c] has quit [Remote host closed the connection]
20180103 04:15:31-!- Greg-Boggs [~greg_bogg@2601:1c2:1a80:1c20:addf:ebd4:891:5c3c] has joined #wesnoth-dev
20180103 04:19:51-!- Greg-Boggs [~greg_bogg@2601:1c2:1a80:1c20:addf:ebd4:891:5c3c] has quit [Ping timeout: 265 seconds]
20180103 04:35:59-!- Greg-Boggs [~greg_bogg@2601:1c2:1a80:1c20:addf:ebd4:891:5c3c] has joined #wesnoth-dev
20180103 04:49:09-!- Greg-Boggs [~greg_bogg@2601:1c2:1a80:1c20:addf:ebd4:891:5c3c] has quit [Remote host closed the connection]
20180103 04:56:11-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: KABOOM! It seems that I have exploded. Please wait while I reinstall the universe.]
20180103 05:30:01-!- APic [apic@apic.name] has quit [Ping timeout: 250 seconds]
20180103 05:39:54-!- APic [apic@apic.name] has joined #wesnoth-dev
20180103 05:41:26-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has joined #wesnoth-dev
20180103 06:30:53-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has quit [Quit: .]
20180103 06:36:02-!- irker479 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20180103 07:21:15-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180103 07:21:29-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20180103 07:23:57-!- JyrkiVesterinen [~JyrkiVest@195-192-251-124.s1networks.fi] has joined #wesnoth-dev
20180103 07:41:23-!- vultraz [uid24821@wesnoth/developer/vultraz] has quit [Quit: Connection closed for inactivity]
20180103 08:51:52-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20180103 09:02:25-!- Appleman1234 [~quassel@124x38x163x22.ap124.ftth.ucom.ne.jp] has joined #wesnoth-dev
20180103 09:14:02-!- Oebele [~quassel@143.177.58.202] has joined #wesnoth-dev
20180103 09:45:06-!- Bonobo [~Bonobo@60-241-159-43.tpgi.com.au] has quit [Ping timeout: 272 seconds]
20180103 09:54:44-!- Sigyn [sigyn@freenode/utility-bot/sigyn] has quit [Quit: People always have such a hard time believing that robots could do bad things.]
20180103 09:55:23-!- Sigyn [sigyn@freenode/utility-bot/sigyn] has joined #wesnoth-dev
20180103 10:13:48-!- atarocch [~atarocch@31.157.151.96] has quit [Remote host closed the connection]
20180103 11:07:30-!- JyrkiVesterinen [~JyrkiVest@195-192-251-124.s1networks.fi] has quit [Quit: .]
20180103 11:44:24-!- Bonobo [~Bonobo@61.68.155.207] has joined #wesnoth-dev
20180103 12:10:16-!- JyrkiVesterinen [~JyrkiVest@195-192-251-124.s1networks.fi] has joined #wesnoth-dev
20180103 12:29:09-!- vladimirslavik [vslavik@nat/redhat/x-kisxhjtnoarwhxde] has joined #wesnoth-dev
20180103 12:31:50-!- vslavik__ [vslavik@nat/redhat/x-aykhxxoufjtgygdj] has quit [Ping timeout: 260 seconds]
20180103 12:33:36-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20180103 13:57:49-!- vladimirslavik [vslavik@nat/redhat/x-kisxhjtnoarwhxde] has quit [Changing host]
20180103 13:57:49-!- vladimirslavik [vslavik@wesnoth/translator/VladimirSlavik] has joined #wesnoth-dev
20180103 14:02:18-!- atarocch [~atarocch@93.56.164.28] has joined #wesnoth-dev
20180103 14:23:27-!- Bonobo [~Bonobo@61.68.155.207] has quit [Ping timeout: 248 seconds]
20180103 14:30:27-!- irker743 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20180103 14:30:27< irker743> wesnoth/wesnoth:master josteph 3d7f0f5349 Game Display: Show correct defense modif AppVeyor: All builds passed
20180103 14:46:10-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20180103 15:29:15-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20180103 15:36:57-!- JyrkiVesterinen [~JyrkiVest@195-192-251-124.s1networks.fi] has quit [Quit: .]
20180103 16:10:26-!- vladimirslavik [vslavik@wesnoth/translator/VladimirSlavik] has quit [Quit: Leaving]
20180103 17:07:06-!- Greg-Boggs [~greg_bogg@c-73-11-32-127.hsd1.or.comcast.net] has joined #wesnoth-dev
20180103 17:18:27-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180103 17:18:36-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20180103 17:22:09-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has joined #wesnoth-dev
20180103 17:30:58-!- irker743 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20180103 17:40:33-!- Oebele [~quassel@143.177.58.202] has quit [Remote host closed the connection]
20180103 17:55:45-!- Bonobo [~Bonobo@61.68.155.207] has joined #wesnoth-dev
20180103 18:15:08-!- vultraz [uid24821@wesnoth/developer/vultraz] has joined #wesnoth-dev
20180103 18:22:10-!- irker462 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20180103 18:22:10< irker462> wesnoth/wesnoth:master josteph 35294b37d0 Game Display: Show correct defense modif AppVeyor: All builds passed
20180103 18:22:47-!- Greg-Boggs [~greg_bogg@c-73-11-32-127.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20180103 18:26:49-!- Greg-Boggs [~greg_bogg@2601:1c2:1a80:1c20:4911:2a53:4898:65dd] has joined #wesnoth-dev
20180103 19:04:13< irker462> wesnoth: josteph wesnoth:master e135517393a5 / src/game_display.cpp: Game Display: Show correct defense modifier for unreachable terrain. https://github.com/wesnoth/wesnoth/commit/e135517393a527f6c717a7669e5bf3d506a01b50
20180103 19:14:55-!- uprego [~uprego@130.red-88-3-143.dynamicip.rima-tde.net] has joined #wesnoth-dev
20180103 20:38:19-!- Greg-Boggs [~greg_bogg@2601:1c2:1a80:1c20:4911:2a53:4898:65dd] has quit [Remote host closed the connection]
20180103 20:43:21-!- atarocch [~atarocch@93.56.164.28] has quit [Quit: Leaving]
20180103 20:43:39-!- atarocch [~atarocch@93.56.164.28] has joined #wesnoth-dev
20180103 20:47:57-!- Greg-Boggs [~greg_bogg@2601:1c2:1a80:1c20:4911:2a53:4898:65dd] has joined #wesnoth-dev
20180103 21:04:01-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180103 21:04:12-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20180103 21:52:16-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20180103 22:05:25-!- irker462 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20180103 22:26:51-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has quit [Quit: .]
20180103 22:31:23-!- Greg-Boggs [~greg_bogg@2601:1c2:1a80:1c20:4911:2a53:4898:65dd] has quit [Remote host closed the connection]
20180103 22:42:48-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20180103 22:48:08-!- irker651 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20180103 22:48:08< irker651> wesnoth/wesnoth:master josteph e135517393 Game Display: Show correct defense modif AppVeyor: All builds passed
20180103 22:52:13-!- Greg-Boggs [~greg_bogg@c-73-11-32-127.hsd1.or.comcast.net] has joined #wesnoth-dev
20180103 22:55:01-!- vultraz [uid24821@wesnoth/developer/vultraz] has quit [Quit: Connection closed for inactivity]
20180103 23:02:52-!- Greg-Boggs [~greg_bogg@c-73-11-32-127.hsd1.or.comcast.net] has quit [Ping timeout: 268 seconds]
20180103 23:23:24-!- Greg-Boggs [~greg_bogg@c-73-11-32-127.hsd1.or.comcast.net] has joined #wesnoth-dev
20180103 23:28:15-!- Greg-Boggs [~greg_bogg@c-73-11-32-127.hsd1.or.comcast.net] has quit [Ping timeout: 265 seconds]
20180103 23:28:45-!- sigurdfd [sigurdfd@dynamic-acs-72-23-110-196.zoominternet.net] has joined #wesnoth-dev
20180103 23:31:45-!- TadCarlucci [~lundberg@74.193.219.119] has quit [Ping timeout: 248 seconds]
20180103 23:32:54-!- TadCarlucci [~lundberg@74.193.219.119] has joined #wesnoth-dev
20180103 23:40:29-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20180103 23:41:27-!- Greg-Boggs [~greg_bogg@2601:1c2:1a80:1c20:c5b7:b0e9:4d41:d954] has joined #wesnoth-dev
20180103 23:42:55-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 248 seconds]
20180103 23:47:20-!- Greg-Boggs [~greg_bogg@2601:1c2:1a80:1c20:c5b7:b0e9:4d41:d954] has quit [Remote host closed the connection]
20180103 23:48:07< irker651> wesnoth: sigurdfdragon wesnoth:master a9e035ab2512 / changelog players_changelog: Update changelogs https://github.com/wesnoth/wesnoth/commit/a9e035ab25121279e9d620b1bac446ca22b58fea
20180103 23:50:43-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20180103 23:57:30-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
--- Log closed Thu Jan 04 00:00:28 2018