--- Log opened Tue Jan 16 00:00:44 2018
20180116 00:05:08-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180116 00:05:14-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20180116 00:17:25-!- Appleman1234 [~quassel@124x38x163x22.ap124.ftth.ucom.ne.jp] has joined #wesnoth-dev
20180116 00:56:22-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20180116 01:17:39-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20180116 02:05:34< aeth> Is scons broken in the latest stable on git? I get this: "AttributeError: 'module' object has no attribute 'config_checks'"
20180116 02:06:28< aeth> (1.12 branch)
20180116 02:07:05< aeth> master compiles
20180116 02:33:44< loonycyborg> aeth: Are you using newer version of scons with py3?
20180116 02:34:19< loonycyborg> that required porting and only is supported on master branch atm
20180116 02:35:08< aeth> Probably
20180116 02:41:40< aeth> I'm a bit surprised that Python 3 is still causing problems in 2018, though
20180116 02:41:46< aeth> What a mess of an upgrade
20180116 05:20:42-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: KABOOM! It seems that I have exploded. Please wait while I reinstall the universe.]
20180116 05:54:08-!- molgrum [~molgrum@unaffiliated/molgrum] has quit [Ping timeout: 255 seconds]
20180116 05:57:42-!- molgrum [~molgrum@databur.st] has joined #wesnoth-dev
20180116 05:57:42-!- molgrum [~molgrum@databur.st] has quit [Changing host]
20180116 05:57:42-!- molgrum [~molgrum@unaffiliated/molgrum] has joined #wesnoth-dev
20180116 06:13:21-!- molgrum [~molgrum@unaffiliated/molgrum] has quit [Ping timeout: 248 seconds]
20180116 07:26:05-!- JyrkiVesterinen [~JyrkiVest@195-192-251-124.s1networks.fi] has joined #wesnoth-dev
20180116 08:27:56-!- vultraz [uid24821@wesnoth/developer/vultraz] has joined #wesnoth-dev
20180116 08:28:27-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20180116 08:33:06-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 265 seconds]
20180116 08:34:56-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20180116 09:27:55< vn971> UPD: was able to solve my task "+2 movement on turn 1"  on wesnoth-1.12.
20180116 09:27:55< vn971> It consists of these steps: 1. give an object with duration="turn" with a text-only ability/description 2. Add a object with duration="forever" to increase movement. 3. At start of turn 1 for each side (event), for each unit, set unit.moves = unit.max_moves  4. At start of turn 2, add an object with duration="forever" to decrease movement.
20180116 09:31:35< vn971> step 2 is needed because replays will break if I just set movement+2 from Lua. Somewhy, when I play a game, Lua works, but when a replay is happening, such changes are not respected, wesnoth says OOS. Step 3 is needed because wesnoth apparently has a bug of not really applying movement increase on turn 1. BUT, contrary to that, replays will _accept_ the movement then. So if you modify from Lua, then game works, replays don't. If you
20180116 09:31:35< vn971>  use duration="turn" then replays work, but the game itself won't. OK, and step 4 is needed to decrease the movement back, because it was previously set with duration="forever", as I already explained why.
20180116 09:34:58-!- kallaballa [~amir@193-81-172-246.hdsl.highway.telekom.at] has joined #wesnoth-dev
20180116 09:36:57-!- kallaballa [~amir@193-81-172-246.hdsl.highway.telekom.at] has quit [Client Quit]
20180116 09:45:10< vn971> I wonder if some of those steps reveal actual wesnoth bugs ^
20180116 09:46:35< vn971> For example, allowing writing legit Lua code that will work in game but will not work in replays feels like a bug. Object with duration=turn that increases movement and does not work feels like a bug too.
20180116 09:54:45-!- molgrum [~molgrum@databur.st] has joined #wesnoth-dev
20180116 09:54:45-!- molgrum [~molgrum@databur.st] has quit [Changing host]
20180116 09:54:45-!- molgrum [~molgrum@unaffiliated/molgrum] has joined #wesnoth-dev
20180116 09:55:17< Ravana_> that should be the cause of my current oos then
20180116 09:59:44< Ravana_> https://forums.wesnoth.org/viewtopic.php?f=58&t=47715&p=622161#p622161
20180116 10:02:27-!- molgrum [~molgrum@unaffiliated/molgrum] has quit [Ping timeout: 240 seconds]
20180116 10:11:03-!- molgrum [~molgrum@databur.st] has joined #wesnoth-dev
20180116 10:11:03-!- molgrum [~molgrum@databur.st] has quit [Changing host]
20180116 10:11:03-!- molgrum [~molgrum@unaffiliated/molgrum] has joined #wesnoth-dev
20180116 10:16:20-!- molgrum [~molgrum@unaffiliated/molgrum] has quit [Ping timeout: 276 seconds]
20180116 10:33:45-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20180116 10:34:26-!- vladimirslavik [vslavik@nat/redhat/x-apciejjrerbxyqbw] has joined #wesnoth-dev
20180116 10:45:01-!- JyrkiVesterinen [~JyrkiVest@195-192-251-124.s1networks.fi] has quit [Quit: .]
20180116 11:25:53< vn971> Ravana_: further testing shows it's actually being fixed on 1.13. You can just use Lua on 1.13 and it will be replays-safe.
20180116 11:32:17< Ravana_> when I test it myself it works on 1.12 as well, for my 3 (2 different) different clients, but when choco hosts game, then there is oos
20180116 11:33:21-!- JyrkiVesterinen [~JyrkiVest@195-192-251-124.s1networks.fi] has joined #wesnoth-dev
20180116 11:42:24< vn971> Ravana_: do you test online or do you save as replay and open replay?
20180116 11:42:56< vn971> The only thing I need to repro the bad behavior is just use 1 client, an offline game, a replay save and a replay load.
20180116 11:43:01< Ravana_> I did both, online game with 3(2) clients and then local replay on one of them
20180116 11:44:37< vn971> well, at least it's fixed in 1.13. We can't do anything about 1.12 anymore, but at least whoray to 1.13 and all developers participated.
20180116 11:46:03< vn971> the work-around of increasing max_moves via [object] works for me, tested numerous times by now. Replays is then OK with such movements, and you can (should) control available movement from Lua to make it work in-game.
20180116 11:47:08< Ravana_> Im still waiting for the player who could make oos happen log in and play one game now that I added debug message after movement change
20180116 11:48:27< Ravana_> I have effect to multiply movement (https://github.com/ProditorMagnus/OrociaRandomMod/blob/master/lua/data_spawn_bonuses.lua#L116), but then I would need to add callback to counter that effect after that turn
20180116 12:14:08-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20180116 12:39:42-!- irker374 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20180116 12:39:42< irker374> wesnoth: Alexander van Gessel wesnoth:master 65dd884b50e1 / src/serialization/preprocessor.cpp: Store pointers in unique_ptr https://github.com/wesnoth/wesnoth/commit/65dd884b50e1ff47cb194f31dad6529e6eb26912
20180116 12:39:42< irker374> wesnoth: Alexander van Gessel wesnoth:master f453f1422b37 / src/serialization/preprocessor.cpp: Indicate ownership transfer using unique_ptr argument https://github.com/wesnoth/wesnoth/commit/f453f1422b37332ce1c185093468c98c933a0f7d
20180116 13:09:59< Soliton> vn971: the duration=turn thing sounds like a bug.
20180116 13:26:08-!- vslavik [vslavik@nat/redhat/x-ofcvprkqncxtiyao] has joined #wesnoth-dev
20180116 13:28:30< vn971> Soliton: further tests shows that it's specific to turn1. Here is a full descriptive issue (not chat-like): https://github.com/wesnoth/wesnoth/issues/2374
20180116 13:28:30-!- vultraz [uid24821@wesnoth/developer/vultraz] has quit [Quit: Connection closed for inactivity]
20180116 13:28:35-!- vladimirslavik [vslavik@nat/redhat/x-apciejjrerbxyqbw] has quit [Ping timeout: 240 seconds]
20180116 15:01:18-!- Oebele [~quassel@143.177.58.202] has joined #wesnoth-dev
20180116 15:13:16-!- JyrkiVesterinen [~JyrkiVest@195-192-251-124.s1networks.fi] has quit [Quit: .]
20180116 16:10:35-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20180116 16:24:22< irker374> wesnoth/wesnoth:master Alexander van Gessel f453f1422b Indicate ownership transfer using unique AppVeyor: All builds passed
20180116 16:49:38-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has joined #wesnoth-dev
20180116 17:02:11< vn971> I wonder how should I report an issue.. When I play my "Creep Wars" map, the save files I get are not loadable. On both 1.12 and 1.13. Can somebody help investigate? Or how should I handle it? AFAIK it's a scenario that does not even require the add-on to be downloaded.
20180116 17:02:42< vn971> In console I get:  20180116 19:58:59 error general: The file you have tried to load is corrupt: '
20180116 17:03:43< Soliton> presumably the interesting stuff comes on the next lines.
20180116 17:04:22< Soliton> provide simple steps to reproduce and then someone else can investigate.
20180116 17:04:23< vn971> Soliton: I would expect that because of the opening single quote, but no, there is nothing after it.
20180116 17:04:36< vn971> * would expect that too
20180116 17:04:39< Soliton> aww
20180116 17:05:32< vn971> I can share a save file. Or an instruction "download Creep Wars latest version, start game, save and load". Which would be better (if any of those are OK at all)?
20180116 17:07:08< Soliton> both!
20180116 17:07:44< Soliton> to test a fix only the latter is useful.
20180116 17:12:59-!- vultraz [uid24821@wesnoth/developer/vultraz] has joined #wesnoth-dev
20180116 17:27:29< vn971> Documented all I know about the save/load bug: https://github.com/wesnoth/wesnoth/issues/2375
20180116 17:44:00-!- mkdroid [~null@unaffiliated/matthiaskrgr] has joined #wesnoth-dev
20180116 18:13:13-!- vslavik [vslavik@nat/redhat/x-ofcvprkqncxtiyao] has quit [Quit: Leaving]
20180116 18:47:48-!- sigurdfd [sigurdfd@dynamic-acs-72-23-110-196.zoominternet.net] has joined #wesnoth-dev
20180116 19:01:29-!- mkdr0id [~null@unaffiliated/matthiaskrgr] has joined #wesnoth-dev
20180116 19:04:43-!- mkdroid [~null@unaffiliated/matthiaskrgr] has quit [Read error: No route to host]
20180116 19:04:54-!- mkdr0id [~null@unaffiliated/matthiaskrgr] has quit [Client Quit]
20180116 19:10:56-!- sigurdfd [sigurdfd@dynamic-acs-72-23-110-196.zoominternet.net] has quit []
20180116 19:25:22-!- irker374 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20180116 19:42:46-!- vultraz [uid24821@wesnoth/developer/vultraz] has quit [Quit: Connection closed for inactivity]
20180116 19:54:26-!- vultraz [uid24821@wesnoth/developer/vultraz] has joined #wesnoth-dev
20180116 20:05:19-!- galegosimpatico [~uprego@unaffiliated/ushiu] has quit [Ping timeout: 248 seconds]
20180116 20:06:32-!- galegosimpatico [~uprego@130.red-88-3-143.dynamicip.rima-tde.net] has joined #wesnoth-dev
20180116 21:14:56< AI0867> TadCarlucci: what is the exact text of the current codacy leak warning?
20180116 21:16:06< TadCarlucci> In the block text. I did a copy-and-paste.  "Memory leak" line number and line content just "}" 
20180116 21:21:23< AI0867> line 1509? That's currently an empty line
20180116 21:30:08-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has quit [Quit: .]
20180116 21:50:09-!- mkdroid [~null@unaffiliated/matthiaskrgr] has joined #wesnoth-dev
20180116 21:57:22-!- irker345 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20180116 21:57:22< irker345> wesnoth/wesnoth:master V N 375e127c7d changing scope to `wml` AppVeyor: All builds passed
20180116 21:59:54< irker345> wesnoth: Alexander van Gessel wesnoth:master 5df406869a1f / src/serialization/preprocessor.cpp: Clarify lifetime of defines maps https://github.com/wesnoth/wesnoth/commit/5df406869a1f774b2b8043f09ac81ca84a2ae1f2
20180116 22:00:07< AI0867> TadCarlucci: I think codacy might have found this instead ^
20180116 22:08:21-!- mkdroid [~null@unaffiliated/matthiaskrgr] has quit [Quit: I'll be back!]
20180116 22:14:48< TadCarlucci> @AI0867, 1506 is a close-curly. cppcheck detected at that end-of-scope for https://github.com/wesnoth/wesnoth/blob/master/src/serialization/preprocessor.cpp#L1485-L1506 and I'll be honest, reading that block my eyes glaze trying to decide what goes where. Someone else suggested just ignoring the messages. I hate being an Ostrich but my headache says maybe Codacy is not the tool for us.
20180116 22:19:41< AI0867> you said 1509 in the "the warnings are still there" comment
20180116 22:25:22< AI0867> according to local cppcheck runs, this should be fixed now
20180116 22:39:28-!- Oebele [~quassel@143.177.58.202] has quit [Remote host closed the connection]
20180116 22:57:44-!- vn971 [~vasya@94.158.103.15] has quit [Quit: Leaving.]
20180116 23:10:56< TadCarlucci> AI0867, cool. Codacy assigns a letter grade based on size, complexity, number of issues it found, etc. All *.cpp files were graded "A". *.hpp files were mostly grade "A", 6 grade "B", src/utils/name_generator_factor.hpp grade "C" src/server/game.hpp grade "D", no grade "E" or "F" C/C++ files. I have another tool which says we should refactor src/display.cpp and src/scripting/game_lua_kernel.cpp based upon coupling, change frequency, size, 
20180116 23:10:56< TadCarlucci> complexity. I'm still evaluating these tools to decide if they're really helping or just blowing smoke up our rear-ends because someone needed a thesis subject
20180116 23:22:42< AI0867> it's right about name_generator_factory, but it's quite wrong about the server
20180116 23:23:01< AI0867> maybe it doesn't see the typedef, but it's suggesting passing a shared_ptr by const reference
20180116 23:24:56< AI0867> though passing a shared_ptr isn't the best idea when you don't intend to share ownership
20180116 23:31:37-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 265 seconds]
20180116 23:40:28-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180116 23:40:36-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20180116 23:42:47-!- vultraz [uid24821@wesnoth/developer/vultraz] has quit [Quit: Connection closed for inactivity]
--- Log closed Wed Jan 17 00:00:46 2018