--- Log opened Sun Jan 21 00:00:51 2018
20180121 00:04:53-!- travis-ci [~travis-ci@ec2-54-145-43-235.compute-1.amazonaws.com] has joined #wesnoth-dev
20180121 00:04:54< travis-ci> wesnoth/wesnoth#16163 (master - 220ac5f : Jyrki Vesterinen): The build passed.
20180121 00:04:54< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/331226952
20180121 00:04:54-!- travis-ci [~travis-ci@ec2-54-145-43-235.compute-1.amazonaws.com] has left #wesnoth-dev []
20180121 00:06:32-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20180121 00:17:15-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180121 00:17:22-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20180121 00:27:24< pydsigner> Ravana_: nice font for the Knal.ga heading
20180121 00:35:19< Ravana_> while I have been promoting it, gnombat created that page
20180121 00:35:41< vultraz> what page?
20180121 00:42:51-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180121 00:42:57-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20180121 01:10:23-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 248 seconds]
20180121 01:18:07-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20180121 01:44:23-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20180121 01:46:41-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 248 seconds]
20180121 01:46:41-!- wedge010 is now known as wedge009
20180121 02:07:41-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 268 seconds]
20180121 02:38:55-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20180121 02:39:05< pydsigner> vultraz: http://knal.ga
20180121 02:39:39< vultraz> Huh
20180121 02:55:46< irker078> wesnoth: Charles Dang wesnoth:master deee52ce19e9 / src/global.hpp: Added condition to define HAVE_CXX17 macro https://github.com/wesnoth/wesnoth/commit/deee52ce19e953e2052ca8e6407430b10bae54a1
20180121 02:55:49< irker078> wesnoth: Charles Dang wesnoth:master ba5ddc4bcbc1 / src/utils/general.hpp: Use std::clamp with C++17 https://github.com/wesnoth/wesnoth/commit/ba5ddc4bcbc18e88dfb2f8d6a8c82c8276238d40
20180121 02:55:52< irker078> wesnoth: Charles Dang wesnoth:master eb52503934b6 / src/ (buffered_istream.hpp serialization/tokenizer.hpp utils/general.hpp): Remove use of __builtin_expect when building with GCC https://github.com/wesnoth/wesnoth/commit/eb52503934b65ee1a434c4055a42b4d2ff18b370
20180121 02:55:55< irker078> wesnoth: Charles Dang wesnoth:master d3e2ab9d22b4 / src/utils/general.hpp: Formatting cleanup of utils::contains impl https://github.com/wesnoth/wesnoth/commit/d3e2ab9d22b45a07ba6a052a74ba8ea0870829c4
20180121 03:01:32< celticminstrel> Uhh, vultraz, that's wrong.
20180121 03:02:00< vultraz> Hm?
20180121 03:03:03< irker078> wesnoth: Celtic Minstrel wesnoth:master 6fac83d3ad74 / src/global.hpp: Fix C++14 and C++17 detection https://github.com/wesnoth/wesnoth/commit/6fac83d3ad74caf3ff006cf8d9f60a243566a5ed
20180121 03:03:03< celticminstrel> ^
20180121 03:03:29< celticminstrel> If you have C++17, then you also have C++14 (with maybe minor exceptions).
20180121 03:05:20< vultraz> Ah
20180121 03:05:53< vultraz> Thanks
20180121 03:05:58< celticminstrel> (But any minor exceptions would be handled via "#ifdef HAVE_CXX17 ... #elif HAVE_CXX14 ..." or whatever.)
20180121 03:27:14< irker078> wesnoth/wesnoth:master Charles Dang acbc0d8975 Made more use of std::isalnum and std::i AppVeyor: 1/6 builds failed
20180121 03:27:15< irker078> Details vs2013/Debug: https://ci.appveyor.com/project/wesnoth/wesnoth/build/Wesnoth-VS2013-master-1108
20180121 04:06:00< irker078> wesnoth: vgaming wesnoth:master 8ba6e5f40eb1 / data/lua/ (10 files): fix code problems found by luacheck (#2380) https://github.com/wesnoth/wesnoth/commit/8ba6e5f40eb1bdd8c164448cd6ea47f00877b2e5
20180121 05:37:33-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180121 05:37:39-!- janebot_ [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20180121 05:37:43-!- janebot_ is now known as janebot
20180121 05:48:11-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The computer falls into a deep sleep, to awake again some other day!]
20180121 05:49:42-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20180121 05:50:03-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Client Quit]
20180121 06:33:45-!- travis-ci [~travis-ci@ec2-54-226-18-110.compute-1.amazonaws.com] has joined #wesnoth-dev
20180121 06:33:46< travis-ci> wesnoth/wesnoth#16168 (master - 8ba6e5f : vgaming): The build passed.
20180121 06:33:46< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/331369544
20180121 06:33:46-!- travis-ci [~travis-ci@ec2-54-226-18-110.compute-1.amazonaws.com] has left #wesnoth-dev []
20180121 07:06:35-!- irker078 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20180121 07:12:37-!- irker833 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20180121 07:12:37< irker833> wesnoth: Charles Dang wesnoth:master ecbb15e1c6d1 / src/ (gui/widgets/slider.cpp terrain/terrain.hpp tod_manager.cpp utils/math.hpp): Minor cleanups to math utils https://github.com/wesnoth/wesnoth/commit/ecbb15e1c6d1106ff2f8e540c584523481426c04
20180121 07:46:55< irker833> wesnoth/wesnoth:master Charles Dang ecbb15e1c6 Minor cleanups to math utils AppVeyor: vs2013/Release Failed
20180121 07:46:56< irker833> Details: https://ci.appveyor.com/project/wesnoth/wesnoth/build/Wesnoth-VS2013-master-1112
20180121 08:44:47-!- Oebele [~quassel@143.177.58.202] has joined #wesnoth-dev
20180121 08:57:43-!- travis-ci [~travis-ci@ec2-54-145-43-235.compute-1.amazonaws.com] has joined #wesnoth-dev
20180121 08:57:44< travis-ci> wesnoth/wesnoth#16169 (master - ecbb15e : Charles Dang): The build was broken.
20180121 08:57:44< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/331389865
20180121 08:57:44-!- travis-ci [~travis-ci@ec2-54-145-43-235.compute-1.amazonaws.com] has left #wesnoth-dev []
20180121 08:58:02< vultraz> broken, you say?
20180121 08:58:18< vultraz> how is this possible!
20180121 08:58:46< vultraz> oh my
20180121 09:01:05< irker833> wesnoth/wesnoth:master Charles Dang ecbb15e1c6 Minor cleanups to math utils AppVeyor: 3/6 builds failed
20180121 09:01:06< irker833> Details vs2013/Release: https://ci.appveyor.com/project/wesnoth/wesnoth/build/Wesnoth-VS2013-master-1112
20180121 09:01:07< irker833> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-1101
20180121 09:01:08< irker833> Details vs2017/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-master-805
20180121 09:12:16< vultraz> really not sure why that's happening
20180121 09:15:09-!- Bhoren [~Bhoren_wh@2a01:e0a:c:2150:89b8:6e34:a51:c0f4] has joined #wesnoth-dev
20180121 09:29:20-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20180121 09:35:30< zookeeper> Bhoren, i never posted about it in the thread, but: https://github.com/wesnoth/wesnoth/commit/80829106
20180121 09:36:03< zookeeper> want the credit entry written differently?
20180121 09:40:31< irker833> wesnoth/wesnoth:master Charles Dang f152a97a02 Made more use of std::isalnum and std::i AppVeyor: vs2017/Release Failed
20180121 09:40:32< irker833> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-master-807
20180121 10:08:49< irker833> wesnoth/wesnoth:master vgaming 8ba6e5f40e fix code problems found by luacheck (#23 AppVeyor: All builds passed
20180121 10:13:46-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20180121 10:20:01< irker833> wesnoth/wesnoth:master Charles Dang f152a97a02 Made more use of std::isalnum and std::i AppVeyor: 3/6 builds failed
20180121 10:20:02< irker833> Details vs2017/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-master-807
20180121 10:20:03< irker833> Details vs2013/Release: https://ci.appveyor.com/project/wesnoth/wesnoth/build/Wesnoth-VS2013-master-1114
20180121 10:20:04< irker833> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-1103
20180121 10:50:20-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has joined #wesnoth-dev
20180121 11:04:47< irker833> wesnoth/wesnoth:master V N 97e53eece9 fix code problems found by luacheck AppVeyor: vs2017/Release Failed
20180121 11:04:48< irker833> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-master-808
20180121 11:04:59-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20180121 11:05:40< JyrkiVesterinen> vultraz: the unit tests are failing because you completely disabled time-of-day bonuses.
20180121 11:06:07< JyrkiVesterinen> If a terrain doesn't specify min_light and max_light, the variables will be set to zero.
20180121 11:06:24< JyrkiVesterinen> Thus, your clamp() always zeroes the light_bonus.
20180121 11:06:43< JyrkiVesterinen> (Except for terrains where non-default lighting is used.)
20180121 11:06:49< vultraz> oh. How is it you always catch these things and I don't despite carefully considering the code :|
20180121 11:07:11< JyrkiVesterinen> I had the unit test output to work with (in Travis logs).
20180121 11:10:48< vultraz> hmmmmmmmmmmmmm............
20180121 11:13:52< Bhoren> zookeeper: Glad to see it's in the game! You can keep Bhoren as credit. If one day I start posting art under my real name I guess it'll be changeable, but it's fine for now! :)
20180121 11:14:43< Bhoren> And if I find more idea and motivation for new pictures, I'll happily draw them for Wesnoth
20180121 11:25:31< zookeeper> Bhoren, okay, cool. and as you might guess, i'm always available for discussing campaign art ideas.
20180121 11:55:04-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has quit [Quit: .]
20180121 12:17:55< irker833> wesnoth/wesnoth:master V N 97e53eece9 fix code problems found by luacheck AppVeyor: 3/6 builds failed
20180121 12:17:56< irker833> Details vs2017/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-master-808
20180121 12:17:57< irker833> Details vs2013/Release: https://ci.appveyor.com/project/wesnoth/wesnoth/build/Wesnoth-VS2013-master-1115
20180121 12:17:58< irker833> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-1104
20180121 13:18:10-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20180121 13:23:27-!- Oebele [~quassel@143.177.58.202] has quit [Remote host closed the connection]
20180121 13:23:46-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has joined #wesnoth-dev
20180121 14:09:01-!- mkdroid [~null@unaffiliated/matthiaskrgr] has joined #wesnoth-dev
20180121 14:39:03-!- mkdr0id [~null@unaffiliated/matthiaskrgr] has joined #wesnoth-dev
20180121 14:39:41-!- mkdroid [~null@unaffiliated/matthiaskrgr] has quit [Ping timeout: 265 seconds]
20180121 14:56:02-!- vultraz [uid24821@wesnoth/developer/vultraz] has quit [Quit: Connection closed for inactivity]
20180121 15:00:51-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20180121 15:18:47-!- irker833 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20180121 15:28:16-!- irker443 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20180121 15:28:16< irker443> wesnoth: Jyrki Vesterinen wesnoth:master 0db553ef36bc / src/ (terrain/terrain.hpp tod_manager.cpp utils/math.hpp): Restore bounded_add() https://github.com/wesnoth/wesnoth/commit/0db553ef36bc7d4d1ec10a7521a2c061d9234805
20180121 16:02:57-!- atarocch [~atarocch@93.56.164.28] has quit [Ping timeout: 240 seconds]
20180121 17:03:27-!- mkdr0id [~null@unaffiliated/matthiaskrgr] has quit [Quit: I'll be back!]
20180121 17:30:09-!- atarocch [~atarocch@93.56.164.28] has joined #wesnoth-dev
20180121 18:02:12-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 246 seconds]
20180121 18:28:23-!- irker443 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20180121 18:39:31-!- irker516 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20180121 18:39:31< irker516> wesnoth/wesnoth:master Jyrki Vesterinen 0db553ef36 Restore bounded_add() AppVeyor: 1/6 builds failed
20180121 18:39:31< irker516> Details vs2015/Debug: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-1105
20180121 19:00:06-!- Oebele [~quassel@143.177.58.202] has joined #wesnoth-dev
20180121 19:49:18-!- atarocch [~atarocch@93.56.164.28] has quit [Ping timeout: 246 seconds]
20180121 19:57:29-!- atarocch [~atarocch@93.56.164.28] has joined #wesnoth-dev
20180121 20:01:54-!- atarocch [~atarocch@93.56.164.28] has quit [Ping timeout: 246 seconds]
20180121 20:08:05-!- travis-ci [~travis-ci@54.144.8.11] has joined #wesnoth-dev
20180121 20:08:06< travis-ci> wesnoth/wesnoth#16173 (master - 0db553e : Jyrki Vesterinen): The build was fixed.
20180121 20:08:06< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/331480381
20180121 20:08:06-!- travis-ci [~travis-ci@54.144.8.11] has left #wesnoth-dev []
20180121 20:26:53-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20180121 20:28:22-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20180121 20:35:57-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180121 20:36:05-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20180121 21:17:30-!- atarocch [~atarocch@93.56.164.28] has joined #wesnoth-dev
20180121 21:25:25-!- atarocch [~atarocch@93.56.164.28] has quit [Ping timeout: 260 seconds]
20180121 21:39:50-!- atarocch [~atarocch@93.56.164.28] has joined #wesnoth-dev
20180121 21:39:58-!- irker516 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20180121 21:40:23-!- vultraz [uid24821@wesnoth/developer/vultraz] has joined #wesnoth-dev
20180121 21:47:54-!- atarocch [~atarocch@93.56.164.28] has quit [Read error: Connection reset by peer]
20180121 21:48:32-!- atarocch [~atarocch@93.56.164.28] has joined #wesnoth-dev
20180121 22:09:40-!- Oebele [~quassel@143.177.58.202] has quit [Remote host closed the connection]
20180121 22:13:15-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has quit [Quit: .]
20180121 22:49:53-!- Bhoren [~Bhoren_wh@2a01:e0a:c:2150:89b8:6e34:a51:c0f4] has quit [Quit: Leaving]
20180121 23:11:02< celticminstrel> vultraz: Is it currently possible to specify an icon for custom races?
20180121 23:11:11< celticminstrel> https://forums.wesnoth.org/viewtopic.php?p=622488#p622488
20180121 23:11:14< vultraz> of course
20180121 23:11:28< celticminstrel> Maybe point him in the right direction then?
20180121 23:12:17< vultraz> the race iconoriate image folder
20180121 23:12:21< vultraz> ou just place them in the aproriate image folder
20180121 23:12:28< celticminstrel> Ugh.
20180121 23:12:36< celticminstrel> We really need to do away with that.
20180121 23:12:41< vultraz> why?
20180121 23:12:47< celticminstrel> Most of the editor stuff uses that method too.
20180121 23:12:49< vultraz> it means we don't need another goddamn key
20180121 23:12:52< celticminstrel> It's difficult to work with.
20180121 23:13:04< celticminstrel> It's easier to just have another key.
20180121 23:14:14< vultraz> I don't see one as being that much better than the other
20180121 23:14:16< celticminstrel> I wonder if it's easy to build a list of places where image paths are built from an ID or something?
20180121 23:15:22< celticminstrel> Switching topics, there was an implementation for a [defense] ability tag that was disabled because it was too slow, right? I wonder if we should enabled it and test it more thoroughly to see if that slowness can be fixed.
20180121 23:15:26< celticminstrel> ^enable
20180121 23:15:39< vultraz> I don'r remember
20180121 23:16:20< vultraz> Did you look at the new Lua fix PR?
20180121 23:16:37< celticminstrel> Did you?
20180121 23:16:53< vultraz> I did. But you know the code better than I
20180121 23:17:09< celticminstrel> Um, if you looked at it, then how do you not know that I looked at it.
20180121 23:17:22< vultraz> I looked at it last night
20180121 23:17:27< celticminstrel> Hmm.
20180121 23:17:34< celticminstrel> Maybe that could explain it?
20180121 23:19:19< vultraz> yes. you were asleep
20180121 23:28:45< celticminstrel> https://forums.wesnoth.org/viewtopic.php?f=58&t=47728
20180121 23:29:58-!- atarocch_ [~atarocch@46.29.219.220] has joined #wesnoth-dev
20180121 23:33:45-!- atarocch [~atarocch@93.56.164.28] has quit [Ping timeout: 260 seconds]
20180121 23:38:14-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20180121 23:38:57< vultraz> Interesting
20180121 23:43:57-!- atarocch_ [~atarocch@46.29.219.220] has quit [Ping timeout: 240 seconds]
20180121 23:44:23-!- atarocch_ [~atarocch@93.56.164.28] has joined #wesnoth-dev
20180121 23:44:50< vultraz> very interesting
20180121 23:45:34< vultraz> I'm not sure I entirely like using WML for a new UMC UI API
20180121 23:45:42< vultraz> I'd prefer we stuck to Lua
20180121 23:46:19< vultraz> and improved the API
20180121 23:46:25< vultraz> celticminstrel: which is something you wanted to do anyway
--- Log closed Mon Jan 22 00:00:36 2018