--- Log opened Tue Jan 23 00:00:04 2018
20180123 00:07:14-!- TadCarlucci [~lundberg@74.193.219.119] has quit [Quit: Leaving]
20180123 00:14:40-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20180123 00:58:28-!- TadCarlucci [~lundberg@74.193.219.119] has joined #wesnoth-dev
20180123 01:09:26-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20180123 01:39:21-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180123 01:39:27-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20180123 01:51:59-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Ping timeout: 248 seconds]
20180123 01:58:48-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20180123 02:15:51-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20180123 02:20:55-!- vultraz [uid24821@wesnoth/developer/vultraz] has quit [Quit: Connection closed for inactivity]
20180123 02:23:51-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity]
20180123 03:55:55-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180123 03:56:02-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20180123 04:17:34-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The computer falls into a deep sleep, to awake again some other day!]
20180123 04:44:14-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has joined #wesnoth-dev
20180123 06:04:44-!- vultraz [uid24821@wesnoth/developer/vultraz] has joined #wesnoth-dev
20180123 06:13:08-!- irker529 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20180123 06:13:08< irker529> wesnoth: Charles Dang wesnoth:master 2e7b041eb5f0 / src/display.cpp: Fixed map labels jumping around the map on scroll (fixes #2333) https://github.com/wesnoth/wesnoth/commit/2e7b041eb5f09ffb50def47213eea826bf6ccb99
20180123 06:13:11< irker529> wesnoth: Charles Dang wesnoth:master e34341145f86 / data/gui/window/campaign_dialog.cfg: Campaign Selection: removed excess borders around sort buttons https://github.com/wesnoth/wesnoth/commit/e34341145f8619923ea08afa72054294f06925cb
20180123 06:15:45< irker529> wesnoth/wesnoth:master Charles Dang e34341145f Campaign Selection: removed excess borde AppVeyor: vs2017/Release Failed
20180123 06:15:46< irker529> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-master-829
20180123 06:36:12-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has quit [Quit: .]
20180123 07:23:43-!- JyrkiVesterinen [~JyrkiVest@195-192-251-124.s1networks.fi] has joined #wesnoth-dev
20180123 08:07:56-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20180123 08:35:25< irker529> wesnoth/wesnoth:master Charles Dang e34341145f Campaign Selection: removed excess borde AppVeyor: 1/6 builds failed
20180123 08:35:26< irker529> Details vs2017/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-master-829
20180123 09:05:07-!- atarocch [~atarocch@93.56.164.28] has quit [Quit: Leaving]
20180123 09:05:25-!- atarocch [~atarocch@93.56.164.28] has joined #wesnoth-dev
20180123 10:06:49-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20180123 10:09:09-!- vladimirslavik [vslavik@nat/redhat/x-hnetrkhiobhuctlq] has joined #wesnoth-dev
20180123 10:27:05-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20180123 10:28:02-!- JyrkiVesterinen [~JyrkiVest@195-192-251-124.s1networks.fi] has quit [Quit: .]
20180123 10:36:06-!- atarocch [~atarocch@93.56.164.28] has quit [Quit: Leaving]
20180123 10:36:29-!- atarocch [~atarocch@93.56.164.28] has joined #wesnoth-dev
20180123 10:41:38-!- atarocch [~atarocch@93.56.164.28] has quit [Quit: Leaving]
20180123 10:42:26-!- atarocch [~atarocch@93.56.164.28] has joined #wesnoth-dev
20180123 10:50:26-!- vn971 [~vasya@94.158.103.15] has quit [Quit: Leaving.]
20180123 11:02:33-!- vn971 [~vasya@94.158.103.15] has joined #wesnoth-dev
20180123 11:07:33-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180123 11:07:39-!- janebot_ [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20180123 11:07:41-!- janebot_ is now known as janebot
20180123 11:21:29-!- JyrkiVesterinen [~JyrkiVest@195-192-251-124.s1networks.fi] has joined #wesnoth-dev
20180123 11:23:46< irker529> wesnoth/wesnoth:master pentarctagon 2603f603a0 Have cmake not copy over everything for  AppVeyor: vs2017/Release Failed
20180123 11:23:47< irker529> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-master-830
20180123 11:54:02< irker529> wesnoth/wesnoth:master pentarctagon 2603f603a0 Have cmake not copy over everything for  AppVeyor: 1/6 builds failed
20180123 11:54:03< irker529> Details vs2017/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-master-830
20180123 11:56:47-!- vladimirslavik [vslavik@nat/redhat/x-hnetrkhiobhuctlq] has quit [Quit: Leaving]
20180123 12:22:05-!- new_one [~new_one@2604:a880:1:20::22e:d001] has quit [Ping timeout: 276 seconds]
20180123 12:35:16-!- JyrkiVesterinen [~JyrkiVest@195-192-251-124.s1networks.fi] has quit [Quit: Rebooting]
20180123 12:53:39-!- new_one [~new_one@2604:a880:1:20::22e:d001] has joined #wesnoth-dev
20180123 13:02:58-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Read error: Connection reset by peer]
20180123 13:03:12-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20180123 13:03:45-!- JyrkiVesterinen [~JyrkiVest@195-192-251-124.s1networks.fi] has joined #wesnoth-dev
20180123 13:27:39-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180123 13:27:47-!- travis-ci [~travis-ci@ec2-54-234-146-189.compute-1.amazonaws.com] has joined #wesnoth-dev
20180123 13:27:48< travis-ci> wesnoth/wesnoth#16193 (master - 2e7b041 : Charles Dang): The build passed.
20180123 13:27:49< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/332155504
20180123 13:27:49-!- travis-ci [~travis-ci@ec2-54-234-146-189.compute-1.amazonaws.com] has left #wesnoth-dev []
20180123 13:27:49-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20180123 13:30:55-!- vn971 [~vasya@94.158.103.15] has quit [Quit: Leaving.]
20180123 13:35:09-!- vn971 [~vasya@94.158.103.15] has joined #wesnoth-dev
20180123 13:57:40-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20180123 14:54:18-!- irker529 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20180123 15:02:53-!- JyrkiVesterinen [~JyrkiVest@195-192-251-124.s1networks.fi] has quit [Quit: .]
20180123 15:16:13-!- travis-ci [~travis-ci@ec2-54-197-67-98.compute-1.amazonaws.com] has joined #wesnoth-dev
20180123 15:16:14< travis-ci> wesnoth/wesnoth#16192 (master - 32119a5 : Alexander van Gessel): The build passed.
20180123 15:16:14< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/331892323
20180123 15:16:14-!- travis-ci [~travis-ci@ec2-54-197-67-98.compute-1.amazonaws.com] has left #wesnoth-dev []
20180123 15:17:23-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer]
20180123 15:19:15-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20180123 15:24:09-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20180123 15:24:22-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20180123 15:38:09-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer]
20180123 15:38:18-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20180123 15:41:11-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Client Quit]
20180123 15:41:13-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20180123 16:04:14-!- vultraz [uid24821@wesnoth/developer/vultraz] has quit [Quit: Connection closed for inactivity]
20180123 16:21:54-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20180123 16:22:09-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20180123 16:24:57-!- vn971 [~vasya@94.158.103.15] has quit [Ping timeout: 264 seconds]
20180123 16:34:39-!- Oebele [~quassel@143.177.58.202] has joined #wesnoth-dev
20180123 17:01:34-!- stikonas_ is now known as stikonas
20180123 17:27:36-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has joined #wesnoth-dev
20180123 17:35:19-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20180123 17:35:49-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20180123 17:54:49-!- Oebele [~quassel@143.177.58.202] has quit [Remote host closed the connection]
20180123 18:21:04-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20180123 18:39:31< JyrkiVesterinen> OK, the best way to fix #2372 would involve quite big refactoring.
20180123 18:39:42< JyrkiVesterinen> Specifically, the AI manager should stop being static.
20180123 18:40:10< JyrkiVesterinen> Instead, it should be owned by game state, and destroying the game state should also destroy the AI manager.
20180123 18:40:35< JyrkiVesterinen> That way, AI wouldn't be able to keep dangling references to the old Lua state.
20180123 18:50:33-!- vn971 [~vasya@94.158.103.15] has joined #wesnoth-dev
20180123 18:51:35< JyrkiVesterinen> vn971: Did you see in the logs what I just said in this channel?
20180123 18:52:11< vn971> JyrkiVesterinen: nope, sorry (though I've seen issue comments). I'll re-read logs now.
20180123 18:54:04< vn971> JyrkiVesterinen: oh.. Sounds pretty serious.
20180123 19:08:43< vn971> Having ArchLinux makes almost any user a capable tester, it seems. Everything is up-to-date, you can build an install a "master" version of almost any package with a single command in terminal (via AUR).  Quite a number of delays on 1.14 have I already caused.:D
20180123 19:15:53< Soliton> much better to have delays than a broken release.
20180123 19:26:12-!- Bhoren [~Bhoren_wh@2a01:e0a:c:2150:1c1:19af:a96f:3326] has joined #wesnoth-dev
20180123 19:26:44-!- irker305 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20180123 19:26:44< irker305> wesnoth: pentarctagon wesnoth:master 729b2984f75e / CMakeLists.txt: Have cmake not copy over everything for server-only installs. https://github.com/wesnoth/wesnoth/commit/729b2984f75eb58feb9a492d7cea5cb08c39fa8d
20180123 19:35:06< irker305> wesnoth: vgaming wesnoth:master 728204665c28 / data/lua/wml/ (11 files): fix code problems found by luacheck (#2388) https://github.com/wesnoth/wesnoth/commit/728204665c284be137c11ded387913cb1e76fc54
20180123 20:13:47-!- vn971 [~vasya@94.158.103.15] has quit [Quit: Leaving.]
20180123 20:35:07-!- vultraz [uid24821@wesnoth/developer/vultraz] has joined #wesnoth-dev
20180123 21:16:05-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180123 21:16:12-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20180123 21:32:32< irker305> wesnoth: Jyrki Vesterinen wesnoth:singleton-ai cf6cb0780cd3 / src/ (23 files in 9 dirs): Make AI manager a singleton https://github.com/wesnoth/wesnoth/commit/cf6cb0780cd36cfb0cd9f1c26d6d88d02cdff1b4
20180123 21:39:01-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180123 21:39:07-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20180123 21:42:02< AI0867> JyrkiVesterinen: looks good to me
20180123 21:42:35< AI0867> at least as a fix so 1.14 won't segfault
20180123 21:43:01< AI0867> but the "keeping references to another object's internal state" bit worries me
20180123 21:44:17< JyrkiVesterinen> Wesnoth codebase is so large that it's hard to avoid.
20180123 21:44:57< JyrkiVesterinen> It's fairly understandable that lua_ai_context keeps a reference to lua_State, rather than fetching it through game_state and then lua_kernel.
20180123 21:49:24< AI0867> true, but if you do something like this, you should ensure your reference doesn't outlive the referenced bit, or use something equivalent to a weak pointer
20180123 21:50:22< JyrkiVesterinen> That's exactly what my commit does.
20180123 21:50:38< AI0867> yep
20180123 21:50:55< AI0867> though the singleton method does require that extra reset line
20180123 21:51:15< AI0867> but this is about as minimal as you could make the change
20180123 21:52:33< JyrkiVesterinen> It would be nice if AI classes kept a reference to the owning manager instead of fetching it through the singleton. That way, they wouldn't need to care about the singleton pointer temporarily pointing to a different manager for a bit.
20180123 21:52:46< JyrkiVesterinen> But indeed, that would be a much larger and more risky change.
20180123 21:53:14< JyrkiVesterinen> At least the singleton isn't any worse than the current approach with a *global* variable.
20180123 21:57:28-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20180123 21:59:14-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has quit [Quit: Going to bed]
20180123 22:00:41-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20180123 22:28:15-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 248 seconds]
20180123 22:56:17-!- Bhoren [~Bhoren_wh@2a01:e0a:c:2150:1c1:19af:a96f:3326] has quit [Quit: Leaving]
20180123 23:03:28-!- vultraz [uid24821@wesnoth/developer/vultraz] has quit [Quit: Connection closed for inactivity]
20180123 23:08:18-!- vultraz [uid24821@wesnoth/developer/vultraz] has joined #wesnoth-dev
20180123 23:32:43-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20180123 23:40:11< irker305> wesnoth: Charles Dang wesnoth:master e432ec335836 / src/gui/dialogs/drop_down_menu.cpp: GUI2/Drop Down Menu: fixed row toggle callback not firing when selecting row https://github.com/wesnoth/wesnoth/commit/e432ec335836dab4f0488b8c18f00476cf2409bf
20180123 23:43:46-!- mode/#wesnoth-dev [+o vultraz] by ChanServ
20180123 23:44:00-!- vultraz changed the topic of #wesnoth-dev to: 1.13.11 (1.14 Beta  3) scheduled for Sunday, February 4th 00:01 UTC | Wesnoth Developers Channel | >>> Want to help? Go here: https://r.wesnoth.org/t42911 (and thanks!) <<< | Discord Server: https://discord.gg/battleforwesnoth | Logs: http://irclogs.wesnoth.org | Bug tracker: https://bugs.wesnoth.org
20180123 23:44:08-!- mode/#wesnoth-dev [-o vultraz] by vultraz
20180123 23:55:16< irker305> wesnoth: Gregory A Lundberg wesnoth:singleton-ai 51793a9fb0d3 / src/ai/manager.cpp: fix wreorder variable initialized before other https://github.com/wesnoth/wesnoth/commit/51793a9fb0d37cba88fe54cae8776aee1482ee8e
--- Log closed Wed Jan 24 00:00:36 2018