--- Log opened Wed Jan 24 00:00:36 2018
20180124 00:09:09-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180124 00:09:15-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20180124 00:50:02-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20180124 01:00:37< irker305> wesnoth: Charles Dang wesnoth:master 671cebe03542 / data/campaigns/The_South_Guard/_main.cfg: TSG: tweak description slightly https://github.com/wesnoth/wesnoth/commit/671cebe0354244dfe162066cb54184cb8906f8a1
20180124 01:00:41< vultraz> celticminstrel: I got that `[lua]` conditional working
20180124 01:09:12-!- TheJJ [~rofl@ipb21b7932.dynamic.kabel-deutschland.de] has quit [Ping timeout: 256 seconds]
20180124 01:21:03-!- travis-ci [~travis-ci@ec2-54-204-238-54.compute-1.amazonaws.com] has joined #wesnoth-dev
20180124 01:21:04< travis-ci> wesnoth/wesnoth#16197 (singleton-ai - cf6cb07 : Jyrki Vesterinen): The build failed.
20180124 01:21:04< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/332510755
20180124 01:21:04-!- travis-ci [~travis-ci@ec2-54-204-238-54.compute-1.amazonaws.com] has left #wesnoth-dev []
20180124 01:27:33-!- higgins [~higgins@68.ip-149-56-14.net] has quit [Quit: Leaving]
20180124 01:30:45-!- higgins [~higgins@68.ip-149-56-14.net] has joined #wesnoth-dev
20180124 01:55:11< irker305> wesnoth/wesnoth:master vgaming 728204665c fix code problems found by luacheck (#23 AppVeyor: All builds passed
20180124 03:27:56< irker305> wesnoth/wesnoth:singleton-ai Jyrki Vesterinen cf6cb0780c Make AI manager a singleton AppVeyor: All builds passed
20180124 03:29:04< irker305> wesnoth: Jyrki Vesterinen wesnoth:master c8b0833b1a92 / src/ (23 files in 9 dirs): Make AI manager a singleton https://github.com/wesnoth/wesnoth/commit/c8b0833b1a9293fc9b7b56ff362bc4aad49a54ad
20180124 03:29:06< irker305> wesnoth: Gregory A Lundberg wesnoth:master e9e22f30b70d / src/ai/manager.cpp: fix wreorder variable initialized before other https://github.com/wesnoth/wesnoth/commit/e9e22f30b70d8185514d84b84ba90f6808422c6b
20180124 03:44:33< celticminstrel> vultraz: Nice.
20180124 03:45:53-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20180124 03:57:54-!- sigurdfd [sigurdfd@dynamic-acs-72-23-110-196.zoominternet.net] has joined #wesnoth-dev
20180124 04:25:56-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Quit: wedge009]
20180124 04:26:12-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20180124 04:31:34-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20180124 04:32:27-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 240 seconds]
20180124 04:32:28-!- wedge010 is now known as wedge009
20180124 04:34:38-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The computer falls into a deep sleep, to awake again some other day!]
20180124 04:38:03-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Quit: wedge009]
20180124 05:04:26-!- sigurdfd [sigurdfd@dynamic-acs-72-23-110-196.zoominternet.net] has quit []
20180124 05:11:03-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20180124 05:17:09-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Quit: wedge009]
20180124 05:25:16< irker305> wesnoth: Charles Dang wesnoth:master 3dc8617ec939 / src/team.cpp: Fixup c8b0833 (crash when creating scenario in Editor) https://github.com/wesnoth/wesnoth/commit/3dc8617ec9396d5d0612ef9fda626d45d12e54dc
20180124 05:25:19< irker305> wesnoth: Charles Dang wesnoth:master 8903ea944698 / src/tod_manager.cpp: ToD Manager: don't write stub ToD to scenario file (fixes #2302) https://github.com/wesnoth/wesnoth/commit/8903ea94469883fa1796bce565e7f7975d0146e4
20180124 06:02:48-!- JyrkiVesterinen [~JyrkiVest@85.23.197.3] has joined #wesnoth-dev
20180124 06:20:45-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20180124 06:43:32-!- JyrkiVesterinen [~JyrkiVest@85.23.197.3] has quit [Quit: .]
20180124 06:48:24< wedge009> Just checking: is wesnoth.org down?
20180124 06:53:01< wedge009> Hmm, it's back now.
20180124 07:24:51-!- JyrkiVesterinen [~JyrkiVest@195-192-251-124.s1networks.fi] has joined #wesnoth-dev
20180124 07:41:22-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20180124 08:39:56-!- Gambit [~derek@wesnoth/developer/grickit] has quit [Quit: No Ping reply in 180 seconds.]
20180124 08:41:02-!- Gambit [~derek@wesnoth/developer/grickit] has joined #wesnoth-dev
20180124 08:58:21< irker305> wesnoth/wesnoth:master Charles Dang 8903ea9446 ToD Manager: don't write stub ToD to sce AppVeyor: All builds passed
20180124 09:32:45-!- vladimirslavik [vslavik@nat/redhat/x-hkbqbexiwpqdasme] has joined #wesnoth-dev
20180124 09:37:08< irker305> wesnoth/wesnoth:master Gregory A Lundberg e9e22f30b7 fix wreorder variable initialized before AppVeyor: All builds passed
20180124 10:28:51-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180124 10:28:57-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20180124 10:32:22-!- JyrkiVesterinen [~JyrkiVest@195-192-251-124.s1networks.fi] has quit [Quit: .]
20180124 11:39:41-!- JyrkiVesterinen [~JyrkiVest@195-192-251-124.s1networks.fi] has joined #wesnoth-dev
20180124 12:37:32-!- irker305 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20180124 12:54:31-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20180124 13:11:02-!- irker483 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20180124 13:11:02< irker483> wesnoth: Charles Dang wesnoth:master 207e763401a1 / src/ (4 files in 3 dirs): Improved handling of race icons (fixes #2030) https://github.com/wesnoth/wesnoth/commit/207e763401a11e86c6c8ad3602efa514812bf902
20180124 13:16:09-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180124 13:16:17-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20180124 14:14:48-!- TadCarlucci [~lundberg@74.193.219.119] has quit [Remote host closed the connection]
20180124 14:15:07-!- TadCarlucci [~lundberg@74.193.219.119] has joined #wesnoth-dev
20180124 15:08:14-!- vn971 [~vasya@94.158.103.15] has joined #wesnoth-dev
20180124 15:14:39< irker483> wesnoth: Gregory A Lundberg wesnoth:master b5f6e43efd35 / src/ai/manager.cpp: Fix Coverity 1385374 uninitialized member https://github.com/wesnoth/wesnoth/commit/b5f6e43efd3598b30680fdbb459acafae057f451
20180124 15:17:35< AI0867> ugh, I had just done that locally
20180124 15:18:27< irker483> wesnoth: Alexander van Gessel wesnoth:master 45a61de23825 / src/ai/manager.cpp: Initialize all members https://github.com/wesnoth/wesnoth/commit/45a61de238256f17a7ec424dba5f059f3e852ba7
20180124 15:18:29< irker483> wesnoth: Alexander van Gessel wesnoth:master 09fe1f4106e4 / : Merge branch 'master' of github.com:wesnoth/wesnoth https://github.com/wesnoth/wesnoth/commit/09fe1f4106e43b2d36adbed2cb5233b5601e2c95
20180124 15:18:34< AI0867> with 2 extra members
20180124 15:19:24< JyrkiVesterinen> Explicitly initializing those two isn't necessary because they are objects. The compiler will call their default constructors for you anyway.
20180124 15:25:39< vn971> Can I force a [message] to be shown, even if user had discarded a [message] via Esc previously?
20180124 15:26:03-!- JyrkiVesterinen [~JyrkiVest@195-192-251-124.s1networks.fi] has quit [Quit: Going home]
20180124 15:26:22< vn971> * sorry for typos. Hope the question itself is clear.
20180124 15:26:23< TadCarlucci> Oh the times I've had to rerun the scenario just to read a message too-hastily dismissed.
20180124 15:27:19< TadCarlucci> I think you need a Feature Request: implement [message] history .. allow going over messages already seen and dismissed. 
20180124 15:27:43< DeFender1031> I already put in that feature request ages ago.
20180124 15:27:55< DeFender1031> But I don't think that's what vn971 is asking
20180124 15:28:42< DeFender1031> I think vn971 is asking "is there a way to turn message skipping off at a given point if the user has hit escape and turned it on"
20180124 15:28:45< vn971> indeed, that might be a useful feature by itself, but it's a different thing than I ask now.
20180124 15:29:14< TadCarlucci> Ah. Break into a new [event]
20180124 15:29:18< vn971> DeFender1031: exactly.
20180124 15:29:23< DeFender1031> IIRC, lua gives you access to whether messages are skipping, though I don't remember if it's read/write access or read-only
20180124 15:29:55< vn971> TadCarlucci: any solution w/o this?
20180124 15:30:17< TadCarlucci> Not that I know of. But, yeah, it probably should be possible with Lua.
20180124 15:30:32< vn971> DeFender1031: yeah, I was trying to find it, but I could not find anything in e.g. https://wiki.wesnoth.org/LuaWML:Misc#wesnoth.current
20180124 15:31:58< vn971> UPD: it's a separate call indeed: https://wiki.wesnoth.org/LuaWML:Display#wesnoth.skip_messages    So, question solved. Thx for pointing to the solution DeFender1031!
20180124 15:32:32< TadCarlucci> It should be an attribute `[message]do_not_skip=yes`
20180124 15:33:04< TadCarlucci> If it's not, add the Issue and mark as Good First Issue.
20180124 15:34:14< vn971> TadCarlucci: well IDK, it doesn't affect me really because I was actually solving a 1.12-only problem. On 1.13, I use a different thing and do not need [message]
20180124 15:34:27< vn971> I guess I won't be the right man to raise such issue.
20180124 15:34:39< TadCarlucci> kk
20180124 15:41:27-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180124 15:41:38-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20180124 15:45:12< DeFender1031> vn971, sure.
20180124 15:54:31-!- TheJJ [~rofl@ipbcc08bab.dynamic.kabel-deutschland.de] has joined #wesnoth-dev
20180124 16:18:45-!- vladimirslavik [vslavik@nat/redhat/x-hkbqbexiwpqdasme] has quit [Quit: Leaving]
20180124 16:28:58-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20180124 16:29:05-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20180124 16:30:54-!- stikonas_ is now known as stikonas
20180124 16:55:40-!- TadCarlucci [~lundberg@74.193.219.119] has quit [Quit: Leaving]
20180124 16:55:59-!- TadCarlucci [~lundberg@74.193.219.119] has joined #wesnoth-dev
20180124 17:08:21-!- Oebele [~quassel@143.177.58.202] has joined #wesnoth-dev
20180124 17:08:21< irker483> wesnoth: Gregory A Lundberg wesnoth:master 4a6042a3c95a / src/scripting/lua_unit_type.cpp: fix crash on #wesnoth.unit_types https://github.com/wesnoth/wesnoth/commit/4a6042a3c95a14695279d090acf6cfd295899b0e
20180124 17:13:54-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has joined #wesnoth-dev
20180124 17:43:29-!- vultraz [uid24821@wesnoth/developer/vultraz] has quit [Quit: Connection closed for inactivity]
20180124 17:47:48-!- atarocch [~atarocch@93.56.164.28] has quit [Read error: Connection reset by peer]
20180124 17:51:08-!- atarocch [~atarocch@93.56.164.28] has joined #wesnoth-dev
20180124 18:17:05-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180124 18:17:15-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20180124 18:24:31-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180124 18:24:37-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20180124 18:25:22-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20180124 18:55:33< AI0867> TadCarlucci: does the iterator really need to be convertible to/from string to make it work?
20180124 18:55:57-!- Bhoren [~Bhoren_wh@2a01:e0a:c:2150:7b:c2b5:3119:8fb3] has joined #wesnoth-dev
20180124 18:58:17< AI0867> And does anyone actually use the variations-related stuff? If not, we should rip that out too
20180124 18:59:35< vn971> AI0867: variations themselves are obviously used in Default Era & plague (zombie). Not sure if that was the question tho.
20180124 19:00:08< AI0867> no, this is related to #2381
20180124 19:00:14< AI0867> lua wesnoth.unit_types
20180124 19:00:30< AI0867> it does not return unit_types, it returns all the variations of all unit_types
20180124 19:01:10< vn971> AI0867: and you propose we could be good with just returning unit_types, right?
20180124 19:01:26< vn971> * you propose to just returning unit_types, right?
20180124 19:01:52< AI0867> I'm proposing partially implementing https://github.com/wesnoth/wesnoth/issues/2381#issuecomment-359138811
20180124 19:03:56< AI0867> TadCarlucci just implemented step 1
20180124 19:07:45< JyrkiVesterinen> I just commented: https://github.com/wesnoth/wesnoth/issues/2339#issuecomment-360240098
20180124 19:09:45< AI0867> that might work
20180124 19:23:58< TadCarlucci> AI0867, Depends. If nobody has ever used pairs() then no, not really. But I expect a programmer would expect a string key being the unit type name so convertible to string would be expected. The indexer ([k]) would need to accept the iterator userdata (O(1)) or search for the string key (O(log n)) etc need to think it all out
20180124 19:25:44< TadCarlucci> AI0867, I counted and got 240, with matched # count so I'm thinking the pairs junk is a pile of crap doing nothing and just returning unit types .. 
20180124 19:28:33< TadCarlucci> AI0867, vn971 I was planning on a PR for both issues. But vultraz ticked the crash last night so I pushed it separate. I'm still planning on working the exposed additional issues when I work on the pairs() speedup.
20180124 19:29:36< vn971> TadCarlucci: I don't really understand the C++ - Lua interaction, but people _definitely_ use the fact that k,v is a string and a unit type information when doing pairs(wesnoth.unit_types).
20180124 19:29:47< vn971> * gtg offline
20180124 19:29:55-!- vn971 [~vasya@94.158.103.15] has quit [Quit: Leaving.]
20180124 19:30:02-!- Oebele [~quassel@143.177.58.202] has quit [Remote host closed the connection]
20180124 19:38:46-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit []
20180124 19:41:49-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20180124 19:59:40-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has quit [Quit: .]
20180124 20:02:20< irker483> wesnoth/wesnoth:master Charles Dang 207e763401 Improved handling of race icons (fixes # AppVeyor: All builds passed
20180124 20:35:48-!- Bhoren [~Bhoren_wh@2a01:e0a:c:2150:7b:c2b5:3119:8fb3] has quit [Quit: Leaving]
20180124 20:43:03-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180124 20:43:11-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20180124 20:51:53< irker483> wesnoth/wesnoth:master Gregory A Lundberg 4a6042a3c9 fix crash on #wesnoth.unit_types AppVeyor: All builds passed
20180124 21:36:38< irker483> wesnoth/wesnoth:master Alexander van Gessel 09fe1f4106 Merge branch 'master' of github.com:wesn AppVeyor: All builds passed
20180124 23:09:55-!- vultraz [uid24821@wesnoth/developer/vultraz] has joined #wesnoth-dev
20180124 23:26:18-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20180124 23:29:26-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20180124 23:47:22-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 268 seconds]
--- Log closed Thu Jan 25 00:00:44 2018