--- Log opened Tue Jan 30 00:00:46 2018
20180130 00:01:38-!- Appleman1234 [~quassel@124x38x163x22.ap124.ftth.ucom.ne.jp] has joined #wesnoth-dev
20180130 00:26:05-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180130 00:26:11-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20180130 00:33:22< irker090> wesnoth: sigurdfdragon wesnoth:master 7a6c39380ed5 / data/campaigns/Secrets_of_the_Ancients/ (5 files in 3 dirs): SotA S04: Update files to match faction renaming https://github.com/wesnoth/wesnoth/commit/7a6c39380ed5972f0fc059a00bc2c42e910fffa4
20180130 00:43:59-!- sigurdfd [sigurdfd@dynamic-acs-72-23-110-196.zoominternet.net] has quit []
20180130 01:05:04-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20180130 01:33:43< irker090> wesnoth/wesnoth:master sigurdfdragon 7a6c39380e SotA S04: Update files to match faction  AppVeyor: vs2017/Release Failed
20180130 01:33:44< irker090> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-master-887
20180130 01:40:37-!- travis-ci [~travis-ci@ec2-54-158-8-132.compute-1.amazonaws.com] has joined #wesnoth-dev
20180130 01:40:38< travis-ci> wesnoth/wesnoth#16251 (master - 7a6c393 : sigurdfdragon): The build has errored.
20180130 01:40:38< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/334959291
20180130 01:40:38-!- travis-ci [~travis-ci@ec2-54-158-8-132.compute-1.amazonaws.com] has left #wesnoth-dev []
20180130 02:03:46< vultraz> celticminstrel: essentially, this is Discord Rich Presence: https://1drv.ms/i/s!As9hRC_GxjKKqFy532xquqaZBHWY
20180130 02:04:52< vultraz> you can also allow people to join/spectate games via discord (it launches your game, of course), but that's more complex and requires approval from Discord
20180130 02:05:15< vultraz> right now I'm just implementing the basic "show more info about the game" bit
20180130 02:05:42< vultraz> but of course, you need to have your Discord client running locally to have it work
20180130 02:05:47< vultraz> you don't use Discord :P
20180130 02:09:52< vultraz> This *will* be in 1.14
20180130 02:11:36< celticminstrel> I'm not sure how you consider that to be even remotely acceptable.
20180130 02:11:54< celticminstrel> Unless it's an extremely small feature that touches less than 1% of the code.
20180130 02:12:14< celticminstrel> Obviously it would also need to be optional, which significantly complicates things IIUC.
20180130 02:13:00< celticminstrel> (By which I mean you can't just link against the Discord libraries, they need to be dynamically tested for at runtime and loaded if present. I think MSVC does have options to set that up for you automatically, mind you...)
20180130 02:14:05< celticminstrel> Also, I apparently can't view your OneDrive.
20180130 02:14:17< celticminstrel> (And no I'm not gonna log into my Skype account just to view it.)
20180130 02:15:10< celticminstrel> Also, do you have to tag me in giant commit messages all the time... >_>
20180130 02:15:36< celticminstrel> ...wait, "some virtual specifiers were also applied/added", what does that even mean...
20180130 02:19:08< celticminstrel> Anyway, even if it is a tiny feature that touches less than 1% of the code, it's still suspect to be introducing it close to release.
20180130 02:27:05-!- Bonobo [~Bonobo@220-244-89-194.tpgi.com.au] has joined #wesnoth-dev
20180130 03:01:50< vultraz> celticminstrel: it doesn't need to be checked for
20180130 03:01:57< vultraz> it just does nothing if it can't establish a connection
20180130 03:02:06< vultraz> really, they made this API quite well
20180130 03:02:31< vultraz> and yes, i assume you can build it yourself
20180130 03:02:34< vultraz> here's the source: https://github.com/discordapp/discord-rpca
20180130 03:02:39< vultraz> there's even a cmake htingy
20180130 03:02:41< vultraz> thingy
20180130 03:03:28< vultraz> there's an issue about MinGW builds
20180130 03:03:46< vultraz> so building on MinGW is unsupported
20180130 03:03:53< vultraz> also just dismiss that login window and you can view the thing
20180130 03:04:03< vultraz> and yes this is a very small change
20180130 03:05:06< celticminstrel> Ah. But anyway, if building on MinGW is unsupported, then there's probably no point adding it anyway.
20180130 03:06:10< vultraz> we'll figure something out
20180130 03:06:34< celticminstrel> You should really be focusing on more important things for 1.14.
20180130 03:06:47< vultraz> This is important
20180130 03:07:20< vultraz> I'm aiming to improve Discord integration to make it easier for players to coordinate
20180130 03:07:40< vultraz> This is towards that
20180130 03:08:02< celticminstrel> It's not important.
20180130 03:08:12< vultraz> I deem it so
20180130 03:08:16< celticminstrel> Maybe it's useful for some people, but it's not important.
20180130 03:09:39< vultraz> *shrug*
20180130 03:10:05< vultraz> I think its important to leverage the Discord server for more than just chat
20180130 03:10:58< vultraz> You don't think anything to do with Discord is beneficial
20180130 03:11:55< celticminstrel> It doesn't benefit me, but I won't deny that it benefits some people. My complaint is primarily about feature creep.
20180130 03:12:03< vultraz> feature creep?
20180130 03:12:45< celticminstrel> And the inability to place or enforce a code freeze.
20180130 03:13:09< celticminstrel> When you're getting close to a new release, you don't start adding new features or refactoring code.
20180130 03:13:12< vultraz> 1.13.11 isn't out yet
20180130 03:13:28< celticminstrel> Doing so will just push the release back further and further, potentially indefinitely.
20180130 03:13:51< celticminstrel> There have been a ton of bugfixes recently, which is great, but you're still doing refactoring work.
20180130 03:14:08< vultraz> I'm doing non-intrusive refactoring
20180130 03:14:18< celticminstrel> There's no such thing as non-intrusive refactoring.
20180130 03:27:18< celticminstrel> ...oh yeah, we still need to fix the regressions in the storyscreen before 1.14, too... :|
20180130 03:27:24< vultraz> not really
20180130 03:27:33< celticminstrel> Yes we do, because they're regressions.
20180130 03:27:35< vultraz> likely no one will miss them
20180130 03:27:53< celticminstrel> I don't know what you're basing your conclusion on.
20180130 03:28:02< celticminstrel> But I doubt it's a correct one.
20180130 03:28:45< celticminstrel> It's probably not even that hard to fix them TBH.
20180130 03:29:04< vultraz> it is very hard
20180130 03:29:10< celticminstrel> ISTR someone offering to do it, but then they moved onto something else instead... might've been vgaming? Maybe not though...
20180130 03:29:30< celticminstrel> Why would it be "very hard"? The code to do the work is there and has been there forever. You just need a way to wire it into GUi2.
20180130 03:29:45< vultraz> I can do it
20180130 03:29:50< vultraz> but the behavior would be different from before
20180130 03:29:55< vultraz> is that acceptable?
20180130 03:30:40< celticminstrel> Different how?
20180130 03:31:34< celticminstrel> Just FTR, to make sure we're really on the same page, I'm talking about the various stretch and tiling options.
20180130 03:31:48< vultraz> IIRC, old scaling was out from the center in a row/column....
20180130 03:32:00< vultraz> GUI2 functions from the top-left in some day
20180130 03:32:06< vultraz> i can't really remember the difference
20180130 03:32:33< celticminstrel> Well, if you can get it to at least support all the different modes, I'd say it's a good start.
20180130 03:48:48< irker090> wesnoth/wesnoth:master sigurdfdragon 7a6c39380e SotA S04: Update files to match faction  AppVeyor: 1/6 builds failed
20180130 03:48:49< irker090> Details vs2017/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-master-887
20180130 03:53:59-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The computer falls into a deep sleep, to awake again some other day!]
20180130 04:18:57-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20180130 05:22:47< irker090> wesnoth/wesnoth:master sigurdfdragon e288be9302 MP: Simplify Dunefolk faction and era de AppVeyor: All builds passed
20180130 06:16:10-!- Bonobo [~Bonobo@220-244-89-194.tpgi.com.au] has quit [Ping timeout: 256 seconds]
20180130 06:16:37-!- Bonobo [~Bonobo@220-244-89-194.tpgi.com.au] has joined #wesnoth-dev
20180130 06:32:38-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20180130 06:43:20-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20180130 06:43:43-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 248 seconds]
20180130 06:43:44-!- wedge010 is now known as wedge009
20180130 06:44:56-!- aeth [~Michael@wesnoth/umc-dev/developer/aethaeryn] has quit [Ping timeout: 276 seconds]
20180130 07:19:40-!- JyrkiVesterinen [~JyrkiVest@195-192-251-124.s1networks.fi] has joined #wesnoth-dev
20180130 07:34:02-!- aeth [~Michael@wesnoth/umc-dev/developer/aethaeryn] has joined #wesnoth-dev
20180130 08:54:34-!- vn971 [~vasya@94.158.103.15] has joined #wesnoth-dev
20180130 09:30:48-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180130 09:30:55-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20180130 09:45:41-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20180130 10:33:14< zookeeper> vn971, my guess would be that underscores are allowed as the first character and perhaps you just didn't quote the string so the parser thought the underscore denoted the rest of the string as translatable.
20180130 10:33:59< zookeeper> as in, may be that variable=_abc just got treated as variable=_"abc" and not as variable="_abc".
20180130 10:34:46-!- JyrkiVesterinen [~JyrkiVest@195-192-251-124.s1networks.fi] has quit [Quit: .]
20180130 10:35:27-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20180130 10:36:48< vn971> zookeeper: I've done it from Lua, I avoid WML whenever I can. Here is the code I used:  `wesnoth.set_variable("_a", 1)`   And this code to check:  wesnoth.get_variable("_a")
20180130 10:37:01< zookeeper> ah, okay then.
20180130 10:38:59< zookeeper> as it happens, i did just set and use a variable named _abc, but yes that was from WML... :p
20180130 10:48:55-!- pydsigner [~pydsigner@unaffiliated/pydsigner] has quit [Ping timeout: 260 seconds]
20180130 10:51:08-!- pydsigner [~pydsigner@unaffiliated/pydsigner] has joined #wesnoth-dev
20180130 10:56:12-!- vladimirslavik [vslavik@nat/redhat/x-pwfqismgpiwdktct] has joined #wesnoth-dev
20180130 10:58:17< vn971> that's weird though, [set_variable] is implemented in Lua in 1.13. Did you use that on 1.13 BTW?
20180130 10:59:20< vn971> Also there's a chance that variable _is_ set when you do wesnoth.set_variable. It just isn't being read when you do wesnoth.get_variable. Dunno how to test that easily.
20180130 11:01:37< zookeeper> yeah, it was on 1.13 but the build is about two months old.
20180130 11:02:16< vn971> UPD: I know how to test that. I can check out the savegame file. But, the savegame does not have the variable I've set. I'm confused, will have to re-read wml_actions.set_variable.
20180130 11:02:55-!- irker090 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20180130 11:04:54< vn971> zookeeper: I use this code   `wesnoth.wml_actions.set_variable {name="_deleteme", value=1}`  and the savegame file does not have "deleteme" text inside. Would be interesting if you could make your WML test on the latest build of wesnoth. If behavior changed, we have a user-facing regression.
20180130 11:06:51< zookeeper> shouldn't take you more than a minute to test whether {VARIABLE "_a" foobar} produces a different result.
20180130 11:13:16< vn971> zookeeper: not a minute, but didn't take too much time to figure out we indeed have a regression.
20180130 11:20:48< vn971> zookeeper: https://github.com/wesnoth/wesnoth/issues/2418
20180130 12:49:43-!- JyrkiVesterinen [~JyrkiVest@195-192-251-124.s1networks.fi] has joined #wesnoth-dev
20180130 13:21:53-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20180130 13:43:05-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180130 13:43:11-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20180130 14:03:22-!- vslavik [vslavik@nat/redhat/x-cdbwkzontpteuevg] has joined #wesnoth-dev
20180130 14:05:53-!- vladimirslavik [vslavik@nat/redhat/x-pwfqismgpiwdktct] has quit [Ping timeout: 248 seconds]
20180130 15:01:54-!- vslavik__ [vslavik@nat/redhat/x-pfeczewngicgcdye] has joined #wesnoth-dev
20180130 15:04:05-!- vslavik [vslavik@nat/redhat/x-cdbwkzontpteuevg] has quit [Ping timeout: 240 seconds]
20180130 15:13:01-!- JyrkiVesterinen [~JyrkiVest@195-192-251-124.s1networks.fi] has quit [Quit: .]
20180130 15:17:25-!- vslavik [vslavik@nat/redhat/x-wmtstkpfquiwcoqp] has joined #wesnoth-dev
20180130 15:19:58-!- vslavik__ [vslavik@nat/redhat/x-pfeczewngicgcdye] has quit [Ping timeout: 268 seconds]
20180130 15:42:23-!- vslavik__ [vslavik@nat/redhat/x-puthduoqqtdofcli] has joined #wesnoth-dev
20180130 15:45:05-!- vslavik [vslavik@nat/redhat/x-wmtstkpfquiwcoqp] has quit [Ping timeout: 248 seconds]
20180130 15:50:46-!- Bonobo [~Bonobo@220-244-89-194.tpgi.com.au] has quit [Ping timeout: 256 seconds]
20180130 16:48:39-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has joined #wesnoth-dev
20180130 17:18:35-!- vultraz [uid24821@wesnoth/developer/vultraz] has quit [Quit: Connection closed for inactivity]
20180130 17:32:07-!- Oebele [~quassel@143.177.58.202] has joined #wesnoth-dev
20180130 18:06:10-!- atarocch [~atarocch@93.56.164.28] has quit [Ping timeout: 240 seconds]
20180130 18:15:06-!- atarocch [~atarocch@93.56.164.28] has joined #wesnoth-dev
20180130 18:34:13-!- vslavik__ [vslavik@nat/redhat/x-puthduoqqtdofcli] has quit [Quit: Leaving]
20180130 18:40:52-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20180130 18:44:47-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 248 seconds]
20180130 18:44:48-!- wedge010 is now known as wedge009
20180130 19:43:22-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180130 19:43:28-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20180130 20:25:53-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has quit [Quit: .]
20180130 21:41:01-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20180130 21:44:18-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20180130 21:53:40-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20180130 22:43:25-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180130 22:43:31-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20180130 22:48:47-!- Oebele [~quassel@143.177.58.202] has quit [Remote host closed the connection]
20180130 23:33:57-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
--- Log closed Wed Jan 31 00:00:47 2018