--- Log opened Sat Feb 03 00:00:51 2018
20180203 00:05:14-!- Bhoren [~Bhoren_wh@2a01:e0a:c:2150:28d9:965d:453e:ac83] has quit [Quit: Leaving]
20180203 00:07:37< irker308> wesnoth/wesnoth:master doofus-01 39f203340e update to lvl1 sprite AppVeyor: vs2013/Debug Failed
20180203 00:07:38< irker308> Details: https://ci.appveyor.com/project/wesnoth/wesnoth/build/Wesnoth-VS2013-master-1213
20180203 00:52:16< irker308> wesnoth/wesnoth:master josteph d3d0998cfc pofix: Update for HttT changes in previo AppVeyor: All builds passed
20180203 01:07:44-!- vultraz [uid24821@wesnoth/developer/vultraz] has quit [Quit: Connection closed for inactivity]
20180203 01:20:22-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20180203 02:06:21< irker308> wesnoth/wesnoth:master josteph ff828346c0 pofix: Update for HttT changes in previo AppVeyor: All builds passed
20180203 02:33:29-!- vultraz [uid24821@wesnoth/developer/vultraz] has joined #wesnoth-dev
20180203 02:42:57-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180203 02:43:03-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20180203 02:47:13-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20180203 02:54:07< vultraz> celticminstrel: ah sorry
20180203 02:54:09< vultraz> i couldn't find it
20180203 02:56:20< celticminstrel> ???
20180203 02:56:25< celticminstrel> Couldn't find what?
20180203 02:56:34< vultraz> wesnoth.deprecation_message
20180203 02:56:46< celticminstrel> Were you maybe looking only in the C++? >_>
20180203 02:56:51< vultraz> yes
20180203 02:57:01< vultraz> I thought that's where all the global table members needed to be registered
20180203 02:57:11< celticminstrel> It's not strictly needed, but.
20180203 02:57:12< celticminstrel> ...
20180203 02:57:42< celticminstrel> Wait, did jyrki recently add a metatable on the wesnoth table, or was that in the closed unit_types PR...?
20180203 03:02:43< vultraz> I dunno
20180203 03:03:00< celticminstrel> Anyway it's totally possible to add functions to wesnoth in Lua code.
20180203 03:03:11< celticminstrel> I mean to the wesnoth table.
20180203 03:04:26< vultraz> ahh
20180203 03:04:28< vultraz> the more you know
20180203 03:04:45< irker308> wesnoth: josteph wesnoth:master 4ac110b8b50b / data/core/ (help.cfg units.cfg): core: Fix grammar and punctuation https://github.com/wesnoth/wesnoth/commit/4ac110b8b50b1dc8399065bb7e6360a8376a83f0
20180203 03:04:47< irker308> wesnoth: josteph wesnoth:master a83a7cabda1a / data/core/units/undead/Necro_Lich.cfg: core: Fix grammar in Lich description. https://github.com/wesnoth/wesnoth/commit/a83a7cabda1aaa581af064a7f87012ba6dd13acb
20180203 03:04:49< irker308> wesnoth: josteph wesnoth:master e48964fa1b41 / utils/pofix.py: pofix: Add wesnoth-help fixes from previous commit. https://github.com/wesnoth/wesnoth/commit/e48964fa1b41d7ec5e8fc1508f27f7c85f2015ac
20180203 03:25:12< irker308> wesnoth: Steve Cotton wesnoth:master 07054112b050 / src/scripting/game_lua_kernel.cpp: Make [cancel_action] set_action_canceled (fixes #2430) https://github.com/wesnoth/wesnoth/commit/07054112b050fa747c592f75023f19197412f13c
20180203 03:40:31-!- celticminstrel is now known as celmin|sleep
20180203 04:27:40< irker308> wesnoth/wesnoth:master doofus-01 39f203340e update to lvl1 sprite AppVeyor: 1/4 builds failed
20180203 04:27:41< irker308> Details vs2013/Debug: https://ci.appveyor.com/project/wesnoth/wesnoth/build/Wesnoth-VS2013-master-1213
20180203 05:02:16-!- sigurdfd [sigurdfd@dynamic-acs-72-23-110-196.zoominternet.net] has quit []
20180203 05:17:36-!- travis-ci [~travis-ci@ec2-54-157-203-113.compute-1.amazonaws.com] has joined #wesnoth-dev
20180203 05:17:37< travis-ci> Pentarctagon/wesnoth#5 (dunefolk-unit-renaming - b9db79a : pentarctagon): The build passed.
20180203 05:17:37< travis-ci> Build details : https://travis-ci.org/Pentarctagon/wesnoth/builds/336831282
20180203 05:17:37-!- travis-ci [~travis-ci@ec2-54-157-203-113.compute-1.amazonaws.com] has left #wesnoth-dev []
20180203 05:58:55< irker308> wesnoth/wesnoth:master catagent101 c23a1fa958 Take 2 AppVeyor: vs2017/Debug Failed
20180203 05:58:55< irker308> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-master-916
20180203 06:39:15< irker308> wesnoth/wesnoth:master Steve Cotton aad3c0181b tips: add tips that villages can be lure AppVeyor: All builds passed
20180203 07:07:45-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180203 07:07:52-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20180203 08:10:27< irker308> wesnoth/wesnoth:master catagent101 c23a1fa958 Take 2 AppVeyor: 1/6 builds failed
20180203 08:10:28< irker308> Details vs2017/Debug: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-master-916
20180203 08:57:35-!- Oebele [~quassel@143.177.58.202] has joined #wesnoth-dev
20180203 09:36:13-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Quit: Caught sigterm, terminating...]
20180203 09:36:56-!- Ivanovic [~ivanovic@p579FBDD9.dip0.t-ipconnect.de] has joined #wesnoth-dev
20180203 09:36:56-!- Ivanovic [~ivanovic@p579FBDD9.dip0.t-ipconnect.de] has quit [Changing host]
20180203 09:36:56-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev
20180203 09:52:26-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Quit: Caught sigterm, terminating...]
20180203 09:52:59-!- Ivanovic [~ivanovic@p579FBDD9.dip0.t-ipconnect.de] has joined #wesnoth-dev
20180203 09:53:06-!- Ivanovic [~ivanovic@p579FBDD9.dip0.t-ipconnect.de] has quit [Changing host]
20180203 09:53:06-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev
20180203 09:55:38-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Read error: Connection reset by peer]
20180203 09:59:14-!- Ivanovic [~ivanovic@p579FBDD9.dip0.t-ipconnect.de] has joined #wesnoth-dev
20180203 09:59:25-!- Ivanovic [~ivanovic@p579FBDD9.dip0.t-ipconnect.de] has quit [Changing host]
20180203 09:59:25-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev
20180203 10:19:06< irker308> wesnoth: Jyrki Vesterinen wesnoth:master a67e13b4c5c2 / src/tests/gui/test_gui2.cpp: Fix C++ unit tests https://github.com/wesnoth/wesnoth/commit/a67e13b4c5c2f8f6565bd792c99af4bfa919aa0d
20180203 10:19:08< irker308> wesnoth: Jyrki Vesterinen wesnoth:master f40a4966bcd0 / .travis.yml: Travis CI: enable C++ unit tests https://github.com/wesnoth/wesnoth/commit/f40a4966bcd0c03a63ac06a0bb0c3b5bc88e242f
20180203 10:32:33-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20180203 10:34:18< vultraz> zookeeper: when do you intend to remove the old utbs?
20180203 10:35:31< zookeeper> oh right, release tomorrow. i guess i should do it before that.
20180203 10:35:49< vultraz> release in ~13 hours
20180203 10:36:01< vultraz> I think..
20180203 10:36:11< vultraz> oh, yes
20180203 10:36:15< vultraz> looking at the wrong clock here
20180203 10:37:13-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has joined #wesnoth-dev
20180203 10:37:59< zookeeper> i'll put it on my luckily empty tonight's todo list.
20180203 10:40:02-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Quit: Caught sigterm, terminating...]
20180203 10:40:40-!- Ivanovic [~ivanovic@p579FBDD9.dip0.t-ipconnect.de] has joined #wesnoth-dev
20180203 10:40:56-!- Ivanovic [~ivanovic@p579FBDD9.dip0.t-ipconnect.de] has quit [Changing host]
20180203 10:40:56-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev
20180203 10:43:24-!- Ivanovic_ [~ivanovic@p579FBDD9.dip0.t-ipconnect.de] has joined #wesnoth-dev
20180203 10:43:24-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Read error: Connection reset by peer]
20180203 10:43:41-!- Ivanovic_ [~ivanovic@p579FBDD9.dip0.t-ipconnect.de] has quit [Changing host]
20180203 10:43:41-!- Ivanovic_ [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev
20180203 10:45:30-!- Ivanovic_ is now known as Ivanovic
20180203 10:51:39< vn971> strange, why cannot I alter "canrecruit" from Lua?
20180203 10:53:22< vn971> Also I wonder if I can alter it in any way at all.
20180203 10:56:26< vultraz> huh
20180203 10:56:30< vultraz> odd
20180203 11:06:09< vn971> UPD: seems I can do it via store_ unstore_ unit. I'll raise a feature request then.
20180203 11:09:52< vn971> BTW, I'd tag new issues (at least mine) if you give github access to it. Anyway: https://github.com/wesnoth/wesnoth/issues/2432
20180203 11:15:36-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20180203 11:23:52< vultraz> vn971: does it raise an error of any kind when you modify it?
20180203 11:24:18< vn971> vultraz: yes, it raises a Lua error (I tried).
20180203 11:24:40< vultraz> please add the error to the report
20180203 11:26:05< vn971> vultraz: oh damn, I tested on 1.12 again.(( Shaming. Closing issue.
20180203 11:26:17< vultraz> heh
20180203 11:26:22< vultraz> ok, no harm done
20180203 11:41:14-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Quit: Caught sigterm, terminating...]
20180203 11:42:05-!- Oebele [~quassel@143.177.58.202] has quit [Remote host closed the connection]
20180203 11:42:06-!- Ivanovic [~ivanovic@p579FBDD9.dip0.t-ipconnect.de] has joined #wesnoth-dev
20180203 11:42:36-!- Ivanovic [~ivanovic@p579FBDD9.dip0.t-ipconnect.de] has quit [Changing host]
20180203 11:42:36-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev
20180203 11:50:56-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has left #wesnoth-dev []
20180203 11:51:36< irker308> wesnoth: Jyrki Vesterinen wesnoth:master 7ca5a0df6449 / docker_run.sh: Attempt to get the backtrace from the C++ unit test executable https://github.com/wesnoth/wesnoth/commit/7ca5a0df6449b4b895842566d33a38872f1f507e
20180203 11:55:22-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has quit [Quit: .]
20180203 12:09:47-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Quit: Caught sigterm, terminating...]
20180203 12:10:13-!- Ivanovic [~ivanovic@p579FBDD9.dip0.t-ipconnect.de] has joined #wesnoth-dev
20180203 12:10:23-!- Ivanovic [~ivanovic@p579FBDD9.dip0.t-ipconnect.de] has quit [Changing host]
20180203 12:10:23-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev
20180203 12:19:29-!- Oebele_ [~quassel@143.177.58.202] has joined #wesnoth-dev
20180203 12:25:48-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 256 seconds]
20180203 12:32:48-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20180203 12:43:31< vn971> vultraz: changing `id` is not possible though. Which makes `copy_unit` always produce a warning if you indeed duplicate the unit:
20180203 12:43:31< vn971> 20180203 15:41:58 error engine: Trying to add Anonymous player 1 - Trapper-1 - 1 (15,4) over Anonymous player 1 - Trapper-1 - 1 (16,4).
20180203 12:43:31< vn971> 20180203 15:41:58 warning unit: assigning new id to clone of generic unit Trapper-1
20180203 12:43:31< vn971> 20180203 15:41:58 error engine: The new unit was assigned underlying_id=9223372036854775809 to prevent duplicate id conflicts.
20180203 12:44:04< vultraz> vn971: and this is 1.13?
20180203 12:44:15< vn971> vultraz: this time, yes.
20180203 12:44:31< vultraz> please report
20180203 12:52:50< vn971> tried to explain it all here: https://github.com/wesnoth/wesnoth/issues/2433
20180203 13:10:24-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has joined #wesnoth-dev
20180203 13:24:44< irker308> wesnoth: Steve Cotton wesnoth:master bf754a8a8e64 / data/tips.cfg: tips: add tips that villages can be lures, and losses are necessary https://github.com/wesnoth/wesnoth/commit/bf754a8a8e64971cfd31a62b8dc3f9abf1e786ab
20180203 13:29:51-!- octalot [~steve@77.119.130.91.wireless.dyn.drei.com] has joined #wesnoth-dev
20180203 13:35:27< octalot> I'm updating the wiki, and wondering whether [cancel_action] goes in DirectActionsWML or InterfaceActionsWML. I think InterfaceActionsWML fits better, because the event that it's used in should have given the player new information, and it's now up to the player to decide whether they're still going to make that move
20180203 13:41:04< Soliton> sounds like something that affects gameplay to me.
20180203 13:41:05< Ravana_> not sure what that tag does exactly, but sounds like direct action
20180203 13:41:23< vultraz> probably directactionswml
20180203 13:42:43< Soliton> vultraz: https://github.com/wesnoth/wesnoth/commit/d11b625  seen my comment?
20180203 13:42:56< vultraz> I did
20180203 13:43:00< vultraz> haven't gotten around to it
20180203 13:43:12< Soliton> alright.
20180203 13:43:19< vultraz> not sure if get_singleton should return a pointer or i should add a has_manager function
20180203 13:43:27< vultraz> which do you think is better
20180203 13:44:42< JyrkiVesterinen> I think a has_manager() function would be a better option.
20180203 13:44:48< vultraz> 'k
20180203 13:45:48< Soliton> pointer would make it clearer that it can be null. probably lots more places to change then though.
20180203 13:46:57< JyrkiVesterinen> I had expected the "can be null" situation to be rare.
20180203 13:47:00< Soliton> i was thinking of a new function to check as well though.
20180203 13:47:18< JyrkiVesterinen> (I had no idea that Wesnoth attempts to access the AI manager even in the editor.)
20180203 13:47:39< vultraz> it creates teams
20180203 13:47:44< vultraz> that accesses the ai manager
20180203 13:47:53< vultraz> perhaps that code could be moved elsewhere..
20180203 13:51:08< vultraz> editor::map_context::new_side()
20180203 13:53:46-!- fabi [~fabi@wesnoth/developer/fendrin] has quit [Quit: Konversation terminated!]
20180203 14:00:36< irker308> wesnoth: josteph wesnoth:master e1d192becf77 / data/campaigns/Heir_To_The_Throne/ (13 files in 2 dirs): HttT: Fix English grammar and punctuation https://github.com/wesnoth/wesnoth/commit/e1d192becf77c9874a0394bb32062542799668a5
20180203 14:00:38< irker308> wesnoth: josteph wesnoth:master b802d85a920f / data/campaigns/Heir_To_The_Throne/scenarios/18_A_Choice_Must_Be_Made.cfg: HttT S18: Rearrange the merman's message. https://github.com/wesnoth/wesnoth/commit/b802d85a920f6492bb61b4cd9a44d9fccae25665
20180203 14:00:40< irker308> wesnoth: josteph wesnoth:master 6b703fd93c3c / utils/pofix.py: pofix: Update for HttT changes in previous commit. https://github.com/wesnoth/wesnoth/commit/6b703fd93c3c0af8d9fb696b178bdac317816c14
20180203 14:01:35-!- vn971 [~vasya@94.158.103.15] has quit [Ping timeout: 248 seconds]
20180203 14:17:19< irker308> wesnoth/wesnoth:master Steve Cotton 07054112b0 Make [cancel_action] set_action_canceled AppVeyor: All builds passed
20180203 14:25:33-!- vn971 [~vasya@94.158.103.15] has joined #wesnoth-dev
20180203 14:29:43-!- celmin|sleep is now known as celticminstrel
20180203 14:39:34 * vultraz pokes celticminstrel 
20180203 14:40:50 * celticminstrel pokes vultraz 
20180203 14:41:03< vultraz> celticminstrel: https://github.com/wesnoth/wesnoth/issues/2433
20180203 14:41:19< vultraz> I can fix the main part easily
20180203 14:41:31< vultraz> but the message about the underlying id is a different matter
20180203 14:41:44< vultraz> it seems wesnoth.copy_unit uses the `unit` copy ctor which doesn't set a new id
20180203 14:41:47< vultraz> underlying id
20180203 14:41:48< vultraz> that is
20180203 14:41:51< vultraz> should it?
20180203 14:41:57< vultraz> copy_unit
20180203 14:42:00< vultraz> not the copy ctor
20180203 14:43:07< celticminstrel> Gimme a minute, looking at the dunefolk PR first.
20180203 14:45:58-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Quit: Caught sigterm, terminating...]
20180203 14:46:57< celticminstrel> Okay, so there's two parts to this.
20180203 14:47:08< celticminstrel> 1. Should unit.id be writable? The obvious answer is no.
20180203 14:47:10< celticminstrel> BUT
20180203 14:47:12< vultraz> uh
20180203 14:47:13< vultraz> why no?
20180203 14:47:22< vultraz> it seems perfectly reasonable
20180203 14:47:26< celticminstrel> If it's an extracted unit, it should be reasonable.
20180203 14:47:32< vultraz> id is not an underlying id
20180203 14:48:02< celticminstrel> IOW I think it makes sense to allow writing the ID only if the unit is neither on the map nor the recall list.
20180203 14:48:32< vultraz> I disagree
20180203 14:48:39< celticminstrel> On the other hand, the core issue here is actually with copy_unit, which should probably be assigning a new ID anyway.
20180203 14:48:41< vultraz> let the umc authors decide when they want to write it
20180203 14:48:52< celticminstrel> And if it did that, there would be no need to change a unit's ID.
20180203 14:49:09< vultraz> it needs to change the underlying id
20180203 14:49:22< celticminstrel> It should probably be changing both.
20180203 14:49:29< vultraz> there's no logical default for a new id
20180203 14:49:40< celticminstrel> The logical default is old_id + "-1"
20180203 14:49:53< celticminstrel> With extra logic so that if the old ID ends with a number it increments that number instead.
20180203 14:50:18< vultraz> it makes no sense whatsoever to assign a new default id and then force people to place it to map and use [modify_unit] to change the id
20180203 14:50:31< vultraz> so
20180203 14:50:35< celticminstrel> [modify_unit] can change the ID?
20180203 14:50:37< celticminstrel> Ugh...
20180203 14:50:37< vultraz> perhaps we can give it a new id and u_id
20180203 14:50:50< vultraz> but we should make unit.id modifiable
20180203 14:50:53< vultraz> there's no reason not to
20180203 14:50:56< celticminstrel> I guess that would make sense, since it literally destroys the unit and places a new one...
20180203 14:51:10< vultraz> why do you think it's a bad idea to do so?
20180203 14:51:13-!- Ivanovic [~ivanovic@p579FBDD9.dip0.t-ipconnect.de] has joined #wesnoth-dev
20180203 14:51:14-!- Ivanovic [~ivanovic@p579FBDD9.dip0.t-ipconnect.de] has quit [Changing host]
20180203 14:51:14-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev
20180203 14:52:28< celticminstrel> I'm not sure what the consequences would be if an ID is changed...
20180203 14:53:38< vultraz> it's just a string. it's the u_id that's important
20180203 14:53:59< celticminstrel> Allowing the change only on Lua-local units is definitely safe. Allowing it on arbitrary units... I'd first like to see proof that it's safe.
20180203 14:54:48< vultraz> so... you don't want me to push this change to add id to impl_unit_set?
20180203 14:55:00< vultraz> I really see *no* reason it wouldn't be safe
20180203 14:55:16< vultraz> I mean, sure, it could fuck up some storage
20180203 14:55:20< celticminstrel> If you want to push the change without testing, please make it work only when the unit is Lua-local.
20180203 14:55:23< vultraz> but that's for the umc author to deal with
20180203 14:56:01< celticminstrel> What's this?
20180203 14:56:12< celticminstrel> What kind of storage are you thinking of?
20180203 14:56:15< vultraz> (ot: I think it'd be cool if one could move a unit just by assigning x and y to different values)
20180203 14:56:19< vultraz> (why can't that be done?)
20180203 14:56:30-!- travis-ci [~travis-ci@ec2-54-205-98-76.compute-1.amazonaws.com] has joined #wesnoth-dev
20180203 14:56:30< celticminstrel> Good question! Feel free to add that too while you're at it.
20180203 14:56:31< travis-ci> wesnoth/wesnoth#16287 (master - bf754a8 : Steve Cotton): The build has errored.
20180203 14:56:31< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/336931884
20180203 14:56:31-!- travis-ci [~travis-ci@ec2-54-205-98-76.compute-1.amazonaws.com] has left #wesnoth-dev []
20180203 14:56:43< vultraz> you can already set x and y
20180203 14:56:45< celticminstrel> And assigning... loc I think it was?
20180203 14:56:46< vultraz> if the unit is not on the mp
20180203 14:56:48< vultraz> map
20180203 14:58:11< vultraz> ah, because this just changes data...
20180203 14:58:35< vultraz> celticminstrel: anyway, about the id, i was thinking if someone had variables named after a unit id or something
20180203 14:58:35< celticminstrel> Yeah, to move a unit you need to do more internally than just assigning x and y.
20180203 14:58:42< celticminstrel> Ah.
20180203 14:59:02< vultraz> so... do you want me to make id not-on-map only?
20180203 14:59:23< celticminstrel> For now, at least.
20180203 14:59:34< vultraz> blah
20180203 14:59:35< celticminstrel> IMO it needs more testing to decide if it's okay generally.
20180203 14:59:45< vultraz> again, I can't think of how it could not be
20180203 14:59:56< vultraz> the id is arbitrary
20180203 14:59:58< vultraz> used for filtering
20180203 15:01:01< celticminstrel> Can you prove it's used only for filtering?
20180203 15:01:14< celticminstrel> (Not counting whatever addon devs do with it.)
20180203 15:01:43< vultraz> what else could it be used for!
20180203 15:02:04< vultraz> even theoretically!
20180203 15:02:16< celticminstrel> If you want to talk theoretically, almost anything!
20180203 15:02:27< vultraz> underlying_id is used internally
20180203 15:04:50< vultraz> as for modify_unit
20180203 15:04:58< vultraz> the wiki makes no mention the id key doesn't work
20180203 15:05:13< vultraz> so if that can do it, why should we not allow it from lua
20180203 15:05:59< celticminstrel> ...oh come on. why does everyone always forget to label the issues! ><
20180203 15:07:29< celticminstrel> Well, modify_unit destroys the unit and creates a new one. Does it even preserve the underlying_id? I wouldn't be at all surprised if it doesn't.
20180203 15:10:08< celticminstrel> Why was the canrecruit issue made invalid? Is it not actually an issue after all, or...?
20180203 15:10:27< irker308> wesnoth: Charles Dang wesnoth:master a003633c5a2e / src/ (4 files in 3 dirs): Removed trailing tabs and whitespaces from C++ source https://github.com/wesnoth/wesnoth/commit/a003633c5a2e793f6cc79a2a13e76a1794986d1a
20180203 15:10:30< irker308> wesnoth: Charles Dang wesnoth:master 1478f21a770a / src/ (ai/manager.hpp team.cpp): Added ai::manager::has_manager function https://github.com/wesnoth/wesnoth/commit/1478f21a770ad4047dea6ed7177dcdf64fb93c43
20180203 15:10:33< irker308> wesnoth: Charles Dang wesnoth:master 64b1ff2292c1 / changelog: Added changelog note about missing [event] name= raising error https://github.com/wesnoth/wesnoth/commit/64b1ff2292c1f4e248523a01aac6657a985d7697
20180203 15:10:36< irker308> wesnoth: Charles Dang wesnoth:master a012e7f0c38b / changelog src/scripting/lua_unit.cpp: Lua/Unit: allow modifying of id field for Lua-only units (fixes #2433) https://github.com/wesnoth/wesnoth/commit/a012e7f0c38ba9ec2ae18e76a9d12e6be1c8caaa
20180203 15:10:39< irker308> wesnoth: Charles Dang wesnoth:master ae3300688d5e / data/campaigns/Heir_To_The_Throne/scenarios/04_The_Bay_of_Pearls.cfg: HttT S4: minor grammar fix (fixes #2435) https://github.com/wesnoth/wesnoth/commit/ae3300688d5e57a36472fea7d92a32dd7682a796
20180203 15:10:43< vultraz> celticminstrel: he was testing on 1.12.
20180203 15:10:52< celticminstrel> Ah.
20180203 15:14:30-!- Oebele_ [~quassel@143.177.58.202] has quit [Remote host closed the connection]
20180203 15:15:34< vultraz> celticminstrel: copy_unit still needs to change the underlying_id
20180203 15:15:45< celticminstrel> Yes,
20180203 15:15:47< irker308> wesnoth: Charles Dang wesnoth:master fe23166a312e / utils/pofix.py: Updated pofix for ae33006 https://github.com/wesnoth/wesnoth/commit/fe23166a312ef0b98965b66c19abd25d4caed210
20180203 15:15:48< celticminstrel> ^.
20180203 15:16:10< vn971> vultraz: celticminstrel: did you decide to fix the underlying `wesnoth.copy_unit`? Does it auto-create id ?
20180203 15:16:29< celticminstrel> Pretty sure a duplicate underlying_id is a soft error though (it detects it, fixes it, and moves on).
20180203 15:16:36< vultraz> I'm leaving that to celticminstrel to fix
20180203 15:16:41< celticminstrel> ...
20180203 15:16:45< vn971> Regarding id. Actually it seems a reasonable wesnoth guarantee that unit never changes ID (otherwise you can't track it). So I'd indeed forbid changing it.
20180203 15:16:49< celticminstrel> Well maybe I can look into it.
20180203 15:17:32< vn971> This is a bit contradictory to my own issue, but if we can separate on-the-map and off-the-map states, I'd limit id changes.
20180203 15:18:04< celticminstrel> We can, vultraz just did.
20180203 15:18:19< celticminstrel> He also allowed changing the ID of recall list units, which isn't quite what I wanted, but whatever...
20180203 15:18:29< vn971> celticminstrel: yeah-yeah, I've seen just now.
20180203 15:19:06< celticminstrel> Was vn971 on github?
20180203 15:19:47< vn971> I'm the one who raised the issue https://github.com/wesnoth/wesnoth/issues/2434
20180203 15:19:51< vn971> (and the previous)
20180203 15:20:26< celticminstrel> Ah okay, so that's you.
20180203 15:27:35-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Quit: Caught sigterm, terminating...]
20180203 15:28:01-!- Ivanovic [~ivanovic@p579FBDD9.dip0.t-ipconnect.de] has joined #wesnoth-dev
20180203 15:28:09-!- Ivanovic [~ivanovic@p579FBDD9.dip0.t-ipconnect.de] has quit [Changing host]
20180203 15:28:09-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev
20180203 15:28:49< vn971> celticminstrel: regarding id. What I meant to say is that I'd leave `id` to be immutable on purpose. Even if it's 100% safe to change it. As part of a sane API.
20180203 15:29:21-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Read error: Connection reset by peer]
20180203 15:29:22-!- Ivanovic_ [~ivanovic@p579FBDD9.dip0.t-ipconnect.de] has joined #wesnoth-dev
20180203 15:31:21-!- Ivanovic_ [~ivanovic@p579FBDD9.dip0.t-ipconnect.de] has quit [Changing host]
20180203 15:31:21-!- Ivanovic_ [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev
20180203 15:31:28-!- Ivanovic_ is now known as Ivanovic
20180203 15:31:50< vultraz> celticminstrel: why do the alignment and advancement setters exit the function early?
20180203 15:31:52< vultraz> in impl_unit_set
20180203 15:32:21< celticminstrel> All the setters exit the function early IIRC.
20180203 15:32:37< vultraz> ah
20180203 15:32:42< vultraz> ok, that makes sense
20180203 15:33:16< celticminstrel> vultraz, please label issues whenever you see an unlabelled one. :(
20180203 15:34:20< vultraz> oh my
20180203 15:34:58< vultraz> oh my oh my
20180203 15:35:10< celticminstrel> ???
20180203 15:35:30< vultraz> oh wait
20180203 15:35:33< vultraz> that might be me..
20180203 15:35:38< vultraz> or rather, my changes
20180203 15:36:06< vultraz> celticminstrel: strcmp, what does it return if stuff matches?
20180203 15:36:11< celticminstrel> 0
20180203 15:36:20< vultraz> gah
20180203 15:36:25< vultraz> why are we using strcmp anyway
20180203 15:36:32< celticminstrel> No clue.
20180203 15:36:42< celticminstrel> Maybe it's faster to not construct a std::string?
20180203 15:36:47< vultraz> possibly?
20180203 15:36:48< vultraz> no idea
20180203 16:08:45< irker308> wesnoth: Charles Dang wesnoth:master 13cacd1d1edb / changelog src/scripting/lua_unit.cpp: Allow moving on-map units by setting unit.x an unit.y fields. https://github.com/wesnoth/wesnoth/commit/13cacd1d1edbac36db3082846556e087146a9b47
20180203 16:08:47< vultraz> vn971: something you might be interested in ^
20180203 16:09:34< vultraz> celticminstrel: too
20180203 16:10:04< vn971> nice
20180203 16:17:01< vultraz> basically this is now an even easier way to move a unit
20180203 16:17:07< vultraz> instead of wesnoth.put_unit
20180203 16:18:35< vn971> vultraz: hmm, I wonder what'll happen if I e.g. set x to a meaningful coordinate, and y not.
20180203 16:19:16< vn971> vultraz: or what's worse, what'll happen if I need to move unit from 1,1 to 10,10, and there _are_ other units on 1,10 and 10,1.
20180203 16:19:41< vultraz> good question, good question
20180203 16:19:46< vn971> vultraz: from this perspective, `put_unit` is safer and more intuitive.
20180203 16:19:46< vultraz> hmmmm
20180203 16:19:51< vultraz> true
20180203 16:20:58< vultraz>  I can probably make the argument a table
20180203 16:23:42< vn971> vultraz: well IDK, the current method is OK enough by me. Also I really copy units, not move them. So I need to "teleport" it right from off-map to on-map.
20180203 16:35:56-!- DeFender1031 [~DeFender1@93-173-53-24.bb.netvision.net.il] has joined #wesnoth-dev
20180203 16:44:21-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180203 16:44:27-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20180203 16:59:14-!- sigurdfd [sigurdfd@dynamic-acs-72-23-110-196.zoominternet.net] has joined #wesnoth-dev
20180203 17:10:55< vn971> hmm.. Getting errors while trying to build: https://gist.github.com/vgaming/89d56b505d5e863f13aaf5342608e819
20180203 17:11:16< vn971> boost version is  1.66.0
20180203 17:11:44< vultraz>  something must be wrong with your boost install
20180203 17:14:36< vn971> vultraz: indeed. Re-installed boost, all normal now. Wondering what might went wrong. Hopefully not disk errors, but cannot imagine anything else.(
20180203 17:14:53< vultraz> :/
20180203 17:15:03< vultraz> or perhaps something in your build system. bad cache or something
20180203 17:15:07< vultraz> anything's possible
20180203 17:15:25< vn971> hope so. Anyway, build is running normally, thx.
20180203 17:19:25< irker308> wesnoth/wesnoth:master pentarctagon 59eaa100a4 Renames the Dunefolk(formerly Khalifate) AppVeyor: All builds passed
20180203 17:21:31-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Quit: Caught sigterm, terminating...]
20180203 17:22:03-!- Ivanovic [~ivanovic@p579FBDD9.dip0.t-ipconnect.de] has joined #wesnoth-dev
20180203 17:22:04-!- Ivanovic [~ivanovic@p579FBDD9.dip0.t-ipconnect.de] has quit [Changing host]
20180203 17:22:04-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev
20180203 17:22:17< irker308> wesnoth: Charles Dang wesnoth:master 40da35d8de11 / src/ (5 files in 4 dirs): Made use of std::tie for certain unit_map operations https://github.com/wesnoth/wesnoth/commit/40da35d8de112114e7b894a17760acfa88f93d49
20180203 17:22:20< irker308> wesnoth: Charles Dang wesnoth:master 7c4999598147 / src/scripting/lua_unit.cpp: Fixup 13cacd1 (use luaL_checkinteger over luaL_checknumber) https://github.com/wesnoth/wesnoth/commit/7c499959814726a017799f38bb228b0eab9fa917
20180203 17:22:46< vultraz> celticminstrel: are we doing anything baout https://github.com/wesnoth/wesnoth/pull/2365 
20180203 17:24:26-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Read error: Connection reset by peer]
20180203 17:35:47-!- octalot [~steve@77.119.130.91.wireless.dyn.drei.com] has quit [Ping timeout: 276 seconds]
20180203 17:39:30< irker308> wesnoth: sigurdfdragon wesnoth:master 264167edcff4 / data/core/macros/deprecated-utils.cfg: Macros: Fixup DEPRECATE_ACTION_MACRO https://github.com/wesnoth/wesnoth/commit/264167edcff47396cf90825f36c46a45e57d11d8
20180203 17:44:14-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev
20180203 17:45:41< irker308> wesnoth/wesnoth:master doofus-01 c9c5f3d09a including revised antelope rider sprites AppVeyor: All builds passed
20180203 18:03:32-!- vn971 [~vasya@94.158.103.15] has quit [Quit: Leaving.]
20180203 18:25:57-!- Nobun [~user@5.170.243.183] has joined #wesnoth-dev
20180203 18:26:24-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Quit: Caught sigterm, terminating...]
20180203 18:26:45-!- Ivanovic [~ivanovic@p579FBDD9.dip0.t-ipconnect.de] has joined #wesnoth-dev
20180203 18:27:03-!- Ivanovic [~ivanovic@p579FBDD9.dip0.t-ipconnect.de] has quit [Changing host]
20180203 18:27:03-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev
20180203 18:27:31-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Client Quit]
20180203 18:27:53-!- Ivanovic [~ivanovic@p579FBDD9.dip0.t-ipconnect.de] has joined #wesnoth-dev
20180203 18:27:56-!- Ivanovic [~ivanovic@p579FBDD9.dip0.t-ipconnect.de] has quit [Changing host]
20180203 18:27:56-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev
20180203 18:28:47-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Client Quit]
20180203 18:29:07-!- Ivanovic [~ivanovic@p579FBDD9.dip0.t-ipconnect.de] has joined #wesnoth-dev
20180203 18:29:26-!- Ivanovic [~ivanovic@p579FBDD9.dip0.t-ipconnect.de] has quit [Changing host]
20180203 18:29:26-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev
20180203 18:34:06< Soliton> vultraz: https://github.com/wesnoth/wesnoth/commit/fe23166  you need to use shorter strings that actually match what's in the po files.
20180203 18:35:01< Soliton> probably not useful to use pofix currently anyway. rather when 1.14 is translated and a typo fix is needed.
20180203 18:35:26< Soliton> (a typo fix that should not invalidate translations.)
20180203 18:43:06-!- sigurdfd [sigurdfd@dynamic-acs-72-23-110-196.zoominternet.net] has quit []
20180203 18:43:18< celticminstrel> vultraz: Next up, support unit.loc = 3, 4
20180203 18:43:41< celticminstrel> Well... if that's possible.
20180203 18:43:50< celticminstrel> If not, unit.loc = {3, 4} would suffice.
20180203 18:44:34< celticminstrel> I have no idea on PR 2365. I guess I'd ask mattsc if he were here.
20180203 18:44:50< celticminstrel> Though I'm not sure, it might not be quite his thing...
20180203 18:45:48< Soliton> i doubt it is.
20180203 18:46:46< Soliton> shouldn't be that difficult to check whether that pr fixes the linked issue.
20180203 18:47:20< irker308> wesnoth/wesnoth:master doofus-01 3169908fbb including revised antelope rider sprites AppVeyor: All builds passed
20180203 18:50:56-!- Ivanovic_ [~ivanovic@p579FBDD9.dip0.t-ipconnect.de] has joined #wesnoth-dev
20180203 18:50:56-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Read error: Connection reset by peer]
20180203 18:51:04-!- Ivanovic_ [~ivanovic@p579FBDD9.dip0.t-ipconnect.de] has quit [Changing host]
20180203 18:51:04-!- Ivanovic_ [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev
20180203 18:53:02-!- Ivanovic_ is now known as Ivanovic
20180203 18:58:20< zookeeper> eh, can't even build right now, visual studio complains about some pointless credentials stuff.
20180203 18:58:39< zookeeper> i guess it doesn't matter, old ones seem to work just fine...
20180203 19:15:01< irker308> wesnoth: ln-zookeeper wesnoth:master 461e2aab2640 / data/campaigns/Under_the_Burning_Suns/ (_main.cfg utils/storytxt.cfg): UtBS: Disabled choice of old elf units, although old saves still work https://github.com/wesnoth/wesnoth/commit/461e2aab2640241d291190026fe1e04b88a72093
20180203 19:16:10< zookeeper> not so nice to suddenly break saves, so i left the old files in at least until we're about to have a RC.
20180203 19:25:35< irker308> wesnoth/wesnoth:master kallaballa 072f694f1a implemented dropout to observer on surre AppVeyor: vs2017/Release Failed
20180203 19:25:36< irker308> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-master-931
20180203 19:44:43-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180203 19:44:51-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20180203 19:45:01-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Quit: Caught sigterm, terminating...]
20180203 19:45:22-!- Ivanovic [~ivanovic@p579FBDD9.dip0.t-ipconnect.de] has joined #wesnoth-dev
20180203 19:45:40-!- Ivanovic [~ivanovic@p579FBDD9.dip0.t-ipconnect.de] has quit [Changing host]
20180203 19:45:40-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev
20180203 19:50:46-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Ping timeout: 256 seconds]
20180203 20:01:57-!- Ivanovic [~ivanovic@p579FBDD9.dip0.t-ipconnect.de] has joined #wesnoth-dev
20180203 20:01:57-!- Ivanovic [~ivanovic@p579FBDD9.dip0.t-ipconnect.de] has quit [Changing host]
20180203 20:01:57-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev
20180203 20:06:03-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Client Quit]
20180203 20:06:25-!- Ivanovic [~ivanovic@p579FBDD9.dip0.t-ipconnect.de] has joined #wesnoth-dev
20180203 20:06:43-!- Ivanovic [~ivanovic@p579FBDD9.dip0.t-ipconnect.de] has quit [Changing host]
20180203 20:06:43-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev
20180203 20:27:45-!- vultraz [uid24821@wesnoth/developer/vultraz] has quit [Quit: Connection closed for inactivity]
20180203 20:42:19-!- octalot [~steve@77.119.130.91.wireless.dyn.drei.com] has joined #wesnoth-dev
20180203 20:46:34-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has quit [Quit: .]
20180203 21:17:22-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180203 21:17:28-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20180203 21:24:48-!- DeFender [~DeFender1@46.116.218.0] has joined #wesnoth-dev
20180203 21:26:38-!- DeFender1031 [~DeFender1@93-173-53-24.bb.netvision.net.il] has quit [Ping timeout: 265 seconds]
20180203 21:33:47-!- DoctorFender1031 [~DeFender1@89-139-100-33.bb.netvision.net.il] has joined #wesnoth-dev
20180203 21:36:25-!- DeFender [~DeFender1@46.116.218.0] has quit [Ping timeout: 268 seconds]
20180203 21:53:10-!- Nobun [~user@5.170.243.183] has quit [Ping timeout: 260 seconds]
20180203 21:59:03-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20180203 22:02:41-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20180203 22:26:18-!- irker308 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20180203 23:25:35-!- irker754 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20180203 23:25:35< irker754> wesnoth/wesnoth:master kallaballa 8d2e009ec3 implemented dropout to observer on surre AppVeyor: All builds passed
20180203 23:55:47-!- octalot [~steve@77.119.130.91.wireless.dyn.drei.com] has quit [Ping timeout: 268 seconds]
--- Log closed Sun Feb 04 00:00:02 2018