--- Log opened Sun Feb 04 00:00:02 2018
--- Day changed Sun Feb 04 2018
20180204 00:00:02< celticminstrel> zookeeper: I'd suggest going back to VS 2013 for the time being.
20180204 00:00:19< celticminstrel> And then switching to something not VS once 2013 support is dropped.
20180204 00:00:29< zookeeper> well, that's what i have :p
20180204 00:00:39< celticminstrel> Eh, 2013 is complaining about credentials too?
20180204 00:00:43< celticminstrel> Still...
20180204 00:01:19< celticminstrel> Microsoft's "free" IDEs aren't really free, they're "free as long as you log in once a month", so for my part I'm probably just going to stay permanently on VS 2013.
20180204 00:01:47< celticminstrel> Even when Wesnoth drops support for it... at that point I'll probably clone the projects and switch them to use clang for building.
20180204 00:02:28< celticminstrel> Maybe if you spend $600 for the Pro edition, it might stop trying to force you to log in, but I'm not convinced this is worth the price tag.
20180204 00:02:34< zookeeper> i'm sure i can resolve that obnoxicity (is that a word?) in a minute by setting up one of those ms accounts or whatever it wanted, but meh.
20180204 00:02:43< celticminstrel> Also, I've heard rumours that it still requires it.
20180204 00:03:03< celticminstrel> So I'd want to make quite sure it's not required before even considering spending money on it...
20180204 00:07:21< zookeeper> so, release time?
20180204 00:10:42< irker754> wesnoth/wesnoth:master pentarctagon 2029da4c0f Renames the Dunefolk(formerly Khalifate) AppVeyor: All builds passed
20180204 00:17:00< celticminstrel> Wait, already?
20180204 00:17:16< celticminstrel> We can't release before the dunefolk PR is merged though.
20180204 00:25:35< irker754> wesnoth/wesnoth:master kallaballa 072f694f1a implemented dropout to observer on surre AppVeyor: 1/2 builds failed
20180204 00:25:36< irker754> Details vs2017/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-master-931
20180204 00:39:09< zookeeper> oh well, i guess not then, seeing how vultraz is remaining absent.
20180204 00:46:07-!- vultraz [uid24821@wesnoth/developer/vultraz] has joined #wesnoth-dev
20180204 00:46:37< vultraz> zookeeper: we're not removing the old utbs files entirely?
20180204 00:46:54< irker754> wesnoth: pentarctagon wesnoth:master dc21c4268329 / data/ (101 files in 5 dirs): Renames the Dunefolk(formerly Khalifate) units based on forum discussions. https://github.com/wesnoth/wesnoth/commit/dc21c42683292dd43d8c514df40e851a0cc43a2c
20180204 00:46:56< irker754> wesnoth: pentarctagon wesnoth:master 697609162667 / / (32 files in 4 dirs): Renames the Dunefolk(formerly Khalifate) units based on forum discussions. https://github.com/wesnoth/wesnoth/commit/697609162667ed4a26951eeaa327284477f6629f
20180204 00:47:39< zookeeper> vultraz, well not right now, there's no reason to break savefiles using them without a short grace period.
20180204 00:47:59< zookeeper> it's not like they take up a lot of disk space or anything.
20180204 00:48:35< vultraz> eh
20180204 00:48:42< vultraz> I wouldn't mind breaking savefiles but alright
20180204 00:51:45< irker754> wesnoth: Charles Dang wesnoth:master 419568dad5db / data/core/units/elves/Outrider.cfg: Tweaked Elvish Outrider description (closes #2429) https://github.com/wesnoth/wesnoth/commit/419568dad5dbbc855870da16b7b66c5c5ec1ecbd
20180204 00:51:46-!- octalot [~steve@77.119.130.91.wireless.dyn.drei.com] has joined #wesnoth-dev
20180204 01:01:07< zookeeper> (just in case anyone might think otherwise, #2414 is incomplete and should _not_ be merged for the release as it is)
20180204 01:02:18-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit []
20180204 01:02:26< vultraz> of course
20180204 01:07:01< vultraz> 20180203 18:43:50< celticminstrel> If not, unit.loc = {3, 4} would suffice.
20180204 01:07:12< vultraz> celticminstrel: i wanted to do that. how, though?
20180204 01:07:14< vultraz> is that a table?
20180204 01:07:32-!- octalot [~steve@77.119.130.91.wireless.dyn.drei.com] has quit [Ping timeout: 276 seconds]
20180204 01:29:52< vultraz> celticminstrel: nevermind, I figured it out ^
20180204 01:29:55< irker754> wesnoth: Charles Dang wesnoth:master 883b4f1856a8 / changelog src/scripting/lua_unit.cpp: Expand 13cacd1d1edb by allowing unit.loc = {x, y} https://github.com/wesnoth/wesnoth/commit/883b4f1856a835173ce61b774a0e54ecd26c5b60
20180204 01:30:01< vultraz> or, ^ rather
20180204 01:31:21< celticminstrel> It is indeed a table.
20180204 01:31:29< celticminstrel> I'd prefer unit.loc = x, y
20180204 01:31:43< celticminstrel> However I'm not sure if Lua will pass spare values to the __newindex function.
20180204 01:32:23< celticminstrel> TBH I wouldn't've recommended doing it that way, though.
20180204 01:32:43< celticminstrel> I would've recommended instead using the function Wesnoth added to specifically get a location off the stack.
20180204 01:32:54< celticminstrel> That would also have two benefits:
20180204 01:33:02< celticminstrel> unit.loc = {x = 1, y = 2} would work
20180204 01:33:14< celticminstrel> If the Lua engine supports it, unit.loc = x, y would work.
20180204 01:33:41< celticminstrel> IIRC it was luaW_checklocation
20180204 01:34:58-!- octalot [~steve@213-225-14-152.nat.highway.a1.net] has joined #wesnoth-dev
20180204 01:35:02< vultraz> hmm
20180204 01:35:11< vultraz> would {x, y} also work?
20180204 01:35:23< celticminstrel> Yeah
20180204 01:35:35< celticminstrel> luaW_checklocation supports three different formats
20180204 01:36:02< vultraz> and it handles all error-checking?
20180204 01:36:09< celticminstrel> I think so? Take a look for yourself.
20180204 01:38:19< vultraz> so wait, all I need to do is dst = luaW_checklocation(L, 3);
20180204 01:38:20< vultraz> ?
20180204 01:38:24< celticminstrel> IIRC
20180204 01:38:27< vultraz> damn
20180204 01:38:29< vultraz> simple
20180204 01:38:31< celticminstrel> :P
20180204 01:39:39< irker754> wesnoth: Severin Glöckner wesnoth:master 762ec56e06a3 / data/multiplayer/scenarios/2p_Dark_Forecast.cfg: Dark Forcast: reanable solo playmode https://github.com/wesnoth/wesnoth/commit/762ec56e06a379fd54adfb43e5a426c4d1c49f3d
20180204 01:40:03< vultraz> = x,y doesn't work
20180204 01:40:11< vultraz> "location expected, got number"
20180204 01:41:45< celticminstrel> Ah well. That would just mean Lua doesn't support multiple arguments to __newindex.
20180204 01:54:04-!- travis-ci [~travis-ci@ec2-54-81-88-207.compute-1.amazonaws.com] has joined #wesnoth-dev
20180204 01:54:05< travis-ci> wesnoth/wesnoth#16299 (master - 6976091 : pentarctagon): The build has errored.
20180204 01:54:05< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/337083681
20180204 01:54:05-!- travis-ci [~travis-ci@ec2-54-81-88-207.compute-1.amazonaws.com] has left #wesnoth-dev []
20180204 01:57:21< irker754> wesnoth: Charles Dang wesnoth:master cfd0f774e4d7 / changelog src/scripting/lua_unit.cpp: Rework 883b4f1856a8 (*much* simpler method) https://github.com/wesnoth/wesnoth/commit/cfd0f774e4d7a275f4ca963bcfd90a584827c1d8
20180204 01:57:24< irker754> wesnoth: Charles Dang wesnoth:master c1cfcdb47206 / src/scripting/lua_unit.cpp: Lua: don't allow setting a unit's x,y coordinated to an off-map location https://github.com/wesnoth/wesnoth/commit/c1cfcdb47206b87cbee1edd82e650c48867b7d95
20180204 01:57:27< irker754> wesnoth: Charles Dang wesnoth:master b6a5341ec43b / Doxyfile changelog players_changelog projectfiles/Xcode/Info.plist src/wesconfig.h: Pre-release version bump https://github.com/wesnoth/wesnoth/commit/b6a5341ec43b7a6313190627de89403862fbc483
20180204 01:58:07< vultraz> celticminstrel: anything else?
20180204 01:59:27< vultraz> Gonna make sure b6a5341ec43b passes travis and then tag
20180204 02:01:34< celticminstrel> Uh.
20180204 02:01:47< celticminstrel> Yes, definitely something else. Your pre-release version bump was a little premature there.
20180204 02:02:33< celticminstrel> Ah, hmm, I was wrong. You did merge the dunefolk.
20180204 02:02:53< celticminstrel> We do need to figure out why the deprecation message isn't showing, but... that's not a blocker to this release IMO.
20180204 02:04:22< celticminstrel> And while I really wanted my preprocessor deprecation thing to get into this version, it's also not a blocker because it just uses the same strings as the Lua deprecation stuff.
20180204 02:04:42< celticminstrel> Lemme look over the commit list quickly...
20180204 02:04:59< celticminstrel> ...well, maybe not that quickly, I guess. The commit count is frankly staggering.
20180204 02:06:24< vultraz> yes, please do your usual pre-release changelog check
20180204 02:06:31< celticminstrel> vultraz: Just quick check, unit.loc = {x,y} works and is not off-by-one?
20180204 02:07:30< vultraz> indeed
20180204 02:08:05< celticminstrel> The changelog is 4121 lines ATM.
20180204 02:08:19< celticminstrel> And just keeps on growing and growing.
20180204 02:08:47< celticminstrel> I think at some point we should consider splitting it up... not right now though.
20180204 02:08:57< celticminstrel> ANYWAY. Back to checking and stuff.
20180204 02:10:55< celticminstrel> Yeah, gonna have to switch to Windows for this, the github web interface won't show more than 250 commits.
20180204 02:18:40< celticminstrel> vultraz: Oh yeah, the unit.id modifying should probably be disabled for recall list units too?
20180204 02:18:47< vultraz> forget it
20180204 02:19:38< vultraz> I still don't think it should even be off-map only
20180204 02:43:55< celticminstrel> Oh yeah, is singalen around?
20180204 02:44:03< celticminstrel> It'd be good to get an Xcode project update before tagging.
20180204 02:44:10< celticminstrel> Not crucial, but good to have.
20180204 02:44:21< celticminstrel> IIRC we also need to run pot-update before tagging, right?
20180204 02:44:33< vultraz> we do?
20180204 02:44:37< vultraz> ah, yes..
20180204 02:44:40< vultraz> loonycyborg: *ping*
20180204 02:52:51-!- celmin [461b1dae@gateway/web/freenode/ip.70.27.29.174] has joined #wesnoth-dev
20180204 02:53:17< celmin> Maybe remind tad about this? https://github.com/wesnoth/wesnoth/commit/b7881a0e6e49d5a78f79625e11d916f745185ffd#commitcomment-26160654
20180204 02:53:36< celmin> I didn't see it get addressed anywhere since then, though I could've missed something.
20180204 02:58:06-!- travis-ci [~travis-ci@ec2-54-81-88-207.compute-1.amazonaws.com] has joined #wesnoth-dev
20180204 02:58:07< travis-ci> wesnoth/wesnoth#16301 (master - b6a5341 : Charles Dang): The build passed.
20180204 02:58:07< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/337096468
20180204 02:58:07-!- travis-ci [~travis-ci@ec2-54-81-88-207.compute-1.amazonaws.com] has left #wesnoth-dev []
20180204 02:59:00< celmin> And yeah, if singalen is around on Discord or whatever, definitely as for the Xcode update if possible? Or if mattsc shows up we could ask him, I guess.
20180204 02:59:34< celmin> FTR I've just reached November in the commits list. When was 1.13.10 released?
20180204 03:00:16< celmin> Surprisingly I haven't found much of interest that was missing in the changelogs. That's partly good (lots of bugfixes) and partly not-so-good (lots of refactoring).
20180204 03:00:31< celmin> Mind you, bugfixes _could_ be mentioned in changelogs, but I can
20180204 03:00:38< celmin> 't be bothered to do so.
20180204 03:03:10< celmin> Quote from ivanovic: 'fixed syntax error in pofix and "problem"   note: please do only enter "Part of the string", not the full strings.  The text in the po files is broken into parts and full strings, with  missing newlines, will not cause matches for the string.'
20180204 03:03:30< celmin> We should double-check all recent pofixes updates to ensure they're done properly.
20180204 03:03:47< celmin> And that information should probably be put somewhere easy-to-find BTW.
20180204 03:04:54-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20180204 03:07:29< celmin> BTW vultraz, please don't do this in future: https://github.com/wesnoth/wesnoth/commit/f2b31ba082e1ff47443120469e06b89318f37284#commitcomment-26160654
20180204 03:07:52< celmin> The unnecessarily long "bars" between sections.
20180204 03:08:05< celmin> If you need a "bar" just do about five or six hyphens.
20180204 03:16:05< celmin> (Why am I the only one talking. >_> )
20180204 03:18:02< celmin> ...oy vultraz, I was working on the widescreen theme. Why'd you remove it?
20180204 03:18:07< celmin> Unitbox I can understand.
20180204 03:18:31< celmin> Widescreen was fixable.
20180204 03:18:47< vultraz> Too broke, bad design
20180204 03:18:49< vultraz> Broken
20180204 03:19:13< celmin> But I said I was working on it.
20180204 03:19:57< celmin> On another topic, could this use a changelog entry?
20180204 03:19:59< celmin> https://github.com/wesnoth/wesnoth/commit/fcb62858f31f59e6c2af021300b315dd3c7c9fa2#commitcomment-26160654
20180204 03:23:43< vultraz> Even if you completely fixed it it’s still an awkward design
20180204 03:24:04< vultraz> As for that commit... ehh
20180204 03:24:11< vultraz> Up to you
20180204 03:24:13< vultraz> I’m not sure
20180204 03:24:23-!- octalot [~steve@213-225-14-152.nat.highway.a1.net] has quit []
20180204 03:31:59< celmin> Just tried building Wesnoth in MSVC with clang. It, uh... didn't work at all. 80 errors, and some of those are "too many errors emitted, stopping"
20180204 03:32:16< celmin> It might be sufficient to simply upgrade clang, not sure.
20180204 03:33:00< celmin> vultraz: When was 1.13.10 release BTW?
20180204 03:33:23< vultraz> Uhhhh
20180204 03:33:24< vultraz> Can’t remember
20180204 03:33:27< vultraz> Check the tag?
20180204 03:33:37< celmin> ^+d
20180204 03:33:50< celmin> Was it earlier than October?
20180204 03:34:05< vultraz> Possibly?
20180204 03:34:24< celmin> https://github.com/wesnoth/wesnoth/tree/1.13.10
20180204 03:34:34< celmin> Looks like it was October, so I guess I'm almost done with this.
20180204 03:35:06< vultraz> october 12th
20180204 03:35:58< vultraz> please add anything relevant you find to the changelog
20180204 03:36:24< celmin> Ironically the only missing thing I found was something I added myself. >_>
20180204 03:36:29< vultraz> :P
20180204 03:36:46< celmin> As far as I can tell, all _your_ commits were either bugfixes (which I can't be bothered to log) or refactoring (which needs not log entry)
20180204 03:36:54< celmin> ^no
20180204 03:37:19< vultraz> are you accusing me of never adding features :P
20180204 03:37:24< celmin> Oh wait, this might be worth mentioning... unless it already is... *checks*
20180204 03:38:07< celmin> ...then again this is a campaignd change, so maybe it doesn't belong in the changelog?
20180204 03:39:33< vultraz> we still need the pot-update before I can tag
20180204 03:39:34< vultraz> :/
20180204 03:39:55< celmin> Yeah. And it'd be best if we also have the Xcode project update before then, too.
20180204 03:43:48-!- mode/#wesnoth-dev [+o vultraz] by ChanServ
20180204 03:44:10-!- vultraz changed the topic of #wesnoth-dev to: 1.13.11 (1.14 Beta  3) scheduled for Monday, February 5th 00:01 UTC | Wesnoth Developers Channel | >>> Want to help? Go here: https://r.wesnoth.org/t42911 (and thanks!) <<< | Discord Server: https://discord.gg/battleforwesnoth | Logs: http://irclogs.wesnoth.org | Bug tracker: https://bugs.wesnoth.org
20180204 03:44:22<@vultraz> postponing the release 1 day to get those things done
20180204 03:47:52< celmin> BTW, shiki and sevu are the same person, right?
20180204 03:48:02<@vultraz> IIRC
20180204 03:48:09-!- mode/#wesnoth-dev [-o vultraz] by vultraz
20180204 03:49:37 * celmin is now perusing git log --format=format:"%h %an <%ae>" 1.13.10...master
20180204 03:50:07< celmin> Which translates to a list of commit hashes followed by the committer and their email.
20180204 03:50:15< vultraz> huh
20180204 03:56:57< celmin> Whoa, this is jetryl? https://github.com/wesnoth/wesnoth/commit/b969940
20180204 03:57:24< vultraz> it's jetrel now, and yes, that is jetrel, but those frames were done by someone else
20180204 03:57:42< vultraz> which reminds me those shadows are wrong
20180204 03:57:42< vultraz> :/
20180204 03:59:20< celmin> vn971's commit email seems to be pretty inconsistent. I've seen him under at least three different names.
20180204 04:09:10< irker754> wesnoth: Celtic Minstrel wesnoth:master 54f8b3446de3 / changelog: Update changelog https://github.com/wesnoth/wesnoth/commit/54f8b3446de3313355beb2b93af3fbdfe25bcb04
20180204 04:09:12< irker754> wesnoth: Celtic Minstrel wesnoth:master 61aad57dbd80 / data/core/about.cfg: Add new contributors to credits https://github.com/wesnoth/wesnoth/commit/61aad57dbd80bb2565f289c26fd1c953ed1b1179
20180204 04:09:32-!- celmin [461b1dae@gateway/web/freenode/ip.70.27.29.174] has quit [Quit: Page closed]
20180204 04:09:36< vultraz> ty ty
20180204 04:09:54< celticminstrel> Well that took forever. >_>
20180204 04:11:36< vultraz> many thousands of commits
20180204 04:12:01< vultraz> or
20180204 04:12:02< vultraz> well
20180204 04:12:03< vultraz> 768
20180204 04:12:36< vultraz> I still don't know the damn difference between an annotated and a lightweight tag
20180204 04:13:01< vultraz> celticminstrel: do you happen to know
20180204 04:13:13< vultraz> does it just say who made the tag>
20180204 04:13:14< vultraz> ?
20180204 04:15:15< celticminstrel> I have no idea.
20180204 04:15:25< celticminstrel> I know you make an annotated tag with something like -a
20180204 04:15:46< celticminstrel> I've never bothered with annotated tags (on eg BoE or DruSi).
20180204 04:15:59< vultraz> I just use whatever TGit gives me
20180204 04:16:00< celticminstrel> But Wesnoth has, so I presume they have some reason for it.
20180204 04:16:20< celticminstrel> If you're using a GUI I wouldn't be surprised if annotated is the default...
20180204 04:16:31< celticminstrel> But I really have no idea.
20180204 04:17:06< vultraz> apparently i fucked it up last time
20180204 04:17:30< celticminstrel> Oh? Did someone "fix" it?
20180204 04:17:35< vultraz> shadow m
20180204 04:17:37< vultraz> retagged
20180204 04:25:57< celticminstrel> Oh yeah, the pofix changes...
20180204 04:29:06< celticminstrel> It looks like jostephd did it correctly, but I'm not so sure about your commit.
20180204 04:30:21< celticminstrel> vultraz: Yeah I'm pretty sure you did pofix wrong. It was this string, right?
20180204 04:30:23< vultraz> :(
20180204 04:30:29< celticminstrel> https://github.com/wesnoth/wesnoth/blob/master/po/wesnoth-httt/wesnoth-httt.pot#L1213
20180204 04:31:43< celticminstrel> IIUC, it should be included in pofix as if it were two strings, broken as you see there.
20180204 04:32:03< vultraz> uhhhhh.....
20180204 04:32:09< vultraz> yes
20180204 05:54:07-!- vn971 [~vasya@94.158.103.15] has joined #wesnoth-dev
20180204 05:54:14-!- celticminstrel is now known as celmin|sleep
20180204 05:58:48-!- DoctorFender1031 is now known as DeFender1031
20180204 06:13:40-!- minbonbon [~min@meta23.net] has joined #wesnoth-dev
20180204 06:15:50-!- Netsplit *.net <-> *.split quits: minzbonbon
20180204 06:33:57-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has joined #wesnoth-dev
20180204 06:36:44< irker754> wesnoth: Sofartin wesnoth:master 3431976cbd29 / data/core/about.cfg: Update about.cfg https://github.com/wesnoth/wesnoth/commit/3431976cbd293648af9291422c8cd884e37905b4
20180204 07:15:34-!- travis-ci [~travis-ci@ec2-107-20-40-247.compute-1.amazonaws.com] has joined #wesnoth-dev
20180204 07:15:35< travis-ci> Pentarctagon/wesnoth#9 (mtime-cache - b4889be : pentarctagon): The build failed.
20180204 07:15:35< travis-ci> Build details : https://travis-ci.org/Pentarctagon/wesnoth/builds/337135976
20180204 07:15:35-!- travis-ci [~travis-ci@ec2-107-20-40-247.compute-1.amazonaws.com] has left #wesnoth-dev []
20180204 07:30:36-!- travis-ci [~travis-ci@ec2-107-20-40-247.compute-1.amazonaws.com] has joined #wesnoth-dev
20180204 07:30:37< travis-ci> Pentarctagon/wesnoth#11 (mtime-cache - 4ea5ca6 : pentarctagon): The build failed.
20180204 07:30:37< travis-ci> Build details : https://travis-ci.org/Pentarctagon/wesnoth/builds/337138025
20180204 07:30:37-!- travis-ci [~travis-ci@ec2-107-20-40-247.compute-1.amazonaws.com] has left #wesnoth-dev []
20180204 07:56:55< vn971> interesting. I've just observed unit healing (trolls & villages) when doing :give_control.  On wesnoth-1.12. Need to test that on 1.13.
20180204 08:12:54< irker754> wesnoth/wesnoth:master Charles Dang b6a5341ec4 Pre-release version bump AppVeyor: All builds passed
20180204 08:14:51-!- travis-ci [~travis-ci@ec2-54-81-88-207.compute-1.amazonaws.com] has joined #wesnoth-dev
20180204 08:14:52< travis-ci> Pentarctagon/wesnoth#12 (mtime-cache - 462797f : pentarctagon): The build was fixed.
20180204 08:14:52< travis-ci> Build details : https://travis-ci.org/Pentarctagon/wesnoth/builds/337138999
20180204 08:14:52-!- travis-ci [~travis-ci@ec2-54-81-88-207.compute-1.amazonaws.com] has left #wesnoth-dev []
20180204 08:32:26< irker754> wesnoth/wesnoth:master doofus-01 35fa41d2d9 another squashable sprite update AppVeyor: vs2013/Debug Failed
20180204 08:32:27< irker754> Details: https://ci.appveyor.com/project/wesnoth/wesnoth/build/Wesnoth-VS2013-master-1252
20180204 08:48:29-!- Oebele [~quassel@143.177.58.202] has joined #wesnoth-dev
20180204 09:04:25-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20180204 09:19:06< vn971> hmm, interesting. I've uploaded an add-on without any password whatsoever, via wesnoth_addon_manager.
20180204 09:19:31< vn971> with no visible complaints from the server, and no password written to _server.pbl
20180204 09:20:09< vn971> pushing updates seems to work too.
20180204 09:32:51< loonycyborg> vultraz: you want pot-update right now? or still some more stuff pending?
20180204 09:33:09< irker754> wesnoth/wesnoth:master doofus-01 35fa41d2d9 another squashable sprite update AppVeyor: 1/6 builds failed
20180204 09:33:10< irker754> Details vs2013/Debug: https://ci.appveyor.com/project/wesnoth/wesnoth/build/Wesnoth-VS2013-master-1252
20180204 09:37:46-!- travis-ci [~travis-ci@ec2-54-83-126-159.compute-1.amazonaws.com] has joined #wesnoth-dev
20180204 09:37:47< travis-ci> Pentarctagon/wesnoth#14 (mtime-cache - 9adaa3d : pentarctagon): The build was broken.
20180204 09:37:47< travis-ci> Build details : https://travis-ci.org/Pentarctagon/wesnoth/builds/337156070
20180204 09:37:47-!- travis-ci [~travis-ci@ec2-54-83-126-159.compute-1.amazonaws.com] has left #wesnoth-dev []
20180204 09:37:53< vn971> UPD: it seems that add-on updates are actually rejected, but `wesnoth_addon_manager` doesn't see that, and thinkgs updates work.
20180204 09:38:48< vn971> Where can I ask for add-on password reset? I've published my first version w/o password and seems I'm in trouble now.
20180204 09:39:25< JyrkiVesterinen> Soliton: can you reset add-on passwords? See messages above.
20180204 09:40:08< vn971> The add-on in question is named "Afterlife", with me (vasya) stated as the author, first published a couple of hours ago.
20180204 10:11:45< irker754> wesnoth/wesnoth:master Celtic Minstrel 61aad57dbd Add new contributors to credits AppVeyor: All builds passed
20180204 10:15:47-!- travis-ci [~travis-ci@ec2-54-83-126-159.compute-1.amazonaws.com] has joined #wesnoth-dev
20180204 10:15:48< travis-ci> Pentarctagon/wesnoth#15 (mtime-cache - 8f1c964 : pentarctagon): The build was fixed.
20180204 10:15:48< travis-ci> Build details : https://travis-ci.org/Pentarctagon/wesnoth/builds/337157426
20180204 10:15:48-!- travis-ci [~travis-ci@ec2-54-83-126-159.compute-1.amazonaws.com] has left #wesnoth-dev []
20180204 10:15:58< vultraz> loonycyborg: now is fine
20180204 11:20:05-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has quit [Quit: .]
20180204 11:55:44-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20180204 12:10:00 * Soliton is looking into the add-on password thing...
20180204 12:10:26 * vultraz is also looking into a bug the fix for which he hopes to get into the release
20180204 12:15:56< Soliton> vn971: from what i can tell all uploads succeeded. i was also able to change your passphrase with wesnoth_addon_manager.
20180204 12:16:18< Soliton> i'll tell you the new passphrase in private.
20180204 12:17:41< Soliton> perhaps we should enforce some minimum passphrase length. everything seems to work regardless though.
20180204 12:19:09< Soliton> actually there was one error about unordered attributes in the log: "error config: attributes: 'description' < 'description'"
20180204 12:19:26< Soliton> not sure how you managed that, looks odd.
20180204 12:19:34< vn971> Soliton: it was a leater attempt with an indeed bad description IIRC.
20180204 12:19:35< vultraz> what even does that mean
20180204 12:22:28< Soliton> vn971: just to be clear, i did not use any admin powers to change your passphrase. i did it normally with wesnoth_addon_manager, giving the addon id and the old passphrase.
20180204 12:38:27< vn971> Soliton: the problem is (was) that I didn't know the password. Normally, wesnoth sends a new password back if you hadn't any IIRC.
20180204 12:40:19< vn971> wesnoth_addon_manager didn't make any changes in _server.pbl (as well as it didn't log anything), so I just didn't knew the auto-generated password.
20180204 12:40:58< vn971> ah, actually I'm wrong, sorry. Maybe it _did_ change _server.pbl. My script just erases _server.pbl because it wants _server.pbl to be place-able in git...
20180204 12:41:03< Soliton> that's not a server feature. the server just uses what you give it.
20180204 12:41:35< vn971> So it adds volatile stuff before uploading. Then uploads. Then erases _server.pbl back to clean state.
20180204 12:41:55< Soliton> if wesnoth generates a password for you you could make a feature request that wesnoth_addon_manager does as well.
20180204 12:41:57< vn971> anyway, it's probably my fault.
20180204 12:42:45< vn971> Soliton: wesnoth_addon_manager maybe does this too. I just don't give it the chance because I erase. Anyway, all OK as far as I'm concerned.
20180204 12:48:09< irker754> wesnoth: loonycyborg wesnoth:master e00ed07a658e / / (1508 files in 31 dirs): pot-update and regenerate doc files https://github.com/wesnoth/wesnoth/commit/e00ed07a658ebd0c8a7bf2d6bcaf0dac29a2a362
20180204 12:48:20< loonycyborg> vultraz: done
20180204 12:48:29< vultraz> thanks :)
20180204 12:48:49< vultraz> I've fixed this bug, so release will be i ~10 hours as expected
20180204 12:48:54< vultraz> in*
20180204 12:50:35< Soliton> celmin|sleep: i'm assuming you did not ask all the people you've added to the credits? i'd say we should do that in case they do not want to appear there at all and so they can say how they want to be mentioned there.
20180204 12:50:59-!- Nobun1 [~user@5.170.240.83] has joined #wesnoth-dev
20180204 12:51:43< vultraz> someone did add their real name
20180204 12:51:46< Soliton> celmin|sleep, vultraz: description on how pofix.py works is at the top of the script.
20180204 12:52:00< Nobun1> loonycyborg: https://github.com/wesnoth/wesnoth/issues/2420: what do you think about the idea I suggested (see what I wrote in my last reply after bolded "EDIT")
20180204 12:52:23< Nobun1> Soliton: what is pofix.py ?
20180204 12:53:04< vultraz> black magic
20180204 12:53:06< Soliton> a tool to fix po files of all translations in case minor changes have been done to the original strings. (like typo fixes.)
20180204 12:53:26< Nobun1> ah ok
20180204 12:53:41< Soliton> mostly just a search and replace.
20180204 12:54:03< Nobun1> but doesn't msgmerge do it by itself? (however it is a nice idea to have a tool that guarantee to manage that scenario)=
20180204 12:56:07< Soliton> the standard tools will rightfully mark the translations as outdated and might suggest the old translation.
20180204 12:57:11< Soliton> so each translator will at least have to use whatever tool to mark the translation as uptodate again.
20180204 12:57:31< Soliton> with pofix they don't.
20180204 12:58:20< Nobun1> ah ok... so it works like msgmerge, but removing the #,fuzzy tag
20180204 12:58:31< Nobun1> it is very interesting
20180204 12:59:01< loonycyborg> Nobun1: I don't think any warning is needed. Entering a large file list from console is a pain anyway and people are unlikely to do that
20180204 12:59:24< Nobun1> loonycyborg: probably you are right
20180204 12:59:31< loonycyborg> and script writers already should know how to deal with command line limits
20180204 12:59:48< Nobun1> well... so all is fine like is it now, except for deciding where to put wmlxgettext... cool :)
20180204 13:00:01< irker754> wesnoth: Charles Dang wesnoth:master ae48811ba43f / src/ (6 files in 6 dirs): Cleaned up cases of ;; https://github.com/wesnoth/wesnoth/commit/ae48811ba43ff9eb9d599e1f4488f40e416fc6f4
20180204 13:00:04< irker754> wesnoth: Charles Dang wesnoth:master 39069c1afa2a / src/gui/widgets/menu_button.hpp: GUI2/Menu Button: added getter for selected row config https://github.com/wesnoth/wesnoth/commit/39069c1afa2aef65603d54b75463f0db382d329c
20180204 13:00:06-!- Oebele [~quassel@143.177.58.202] has quit [Remote host closed the connection]
20180204 13:00:07< irker754> wesnoth: Charles Dang wesnoth:master 77a06e2812b0 / src/ (3 files in 2 dirs): MP Staging: fixed team setting issue when some sides were hidden (fixes #2436) https://github.com/wesnoth/wesnoth/commit/77a06e2812b095393c84b342a91d4daf2f798889
20180204 13:00:39< Nobun1> loonycyborg: and for those UMC devs who don't know it, and who will use GUI, they surely use --recursive, so also no problem for them
20180204 13:00:59< Nobun1> it seems to me a nice solution
20180204 13:12:53-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has joined #wesnoth-dev
20180204 13:17:53-!- Ravana_ [~Ravana@unaffiliated/ravana/x-2327071] has quit [Ping timeout: 248 seconds]
20180204 13:25:23-!- Bonobo [~Bonobo@220-244-89-194.tpgi.com.au] has joined #wesnoth-dev
20180204 13:48:06-!- hrubymar10 [~textual@255.ip-217-182-72.eu] has joined #wesnoth-dev
20180204 13:49:00-!- travis-ci [~travis-ci@ec2-54-83-126-159.compute-1.amazonaws.com] has joined #wesnoth-dev
20180204 13:49:01< travis-ci> wesnoth/wesnoth#16306 (master - e00ed07 : loonycyborg): The build passed.
20180204 13:49:01< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/337194089
20180204 13:49:01-!- travis-ci [~travis-ci@ec2-54-83-126-159.compute-1.amazonaws.com] has left #wesnoth-dev []
20180204 14:25:00-!- travis-ci [~travis-ci@ec2-54-81-88-207.compute-1.amazonaws.com] has joined #wesnoth-dev
20180204 14:25:01< travis-ci> wesnoth/wesnoth#16307 (master - 77a06e2 : Charles Dang): The build failed.
20180204 14:25:01< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/337196231
20180204 14:25:01-!- travis-ci [~travis-ci@ec2-54-81-88-207.compute-1.amazonaws.com] has left #wesnoth-dev []
20180204 14:28:31< Soliton> hmm, isn't there a graphical thing to give control of a side in mp? where do i find that?
20180204 14:28:33< vultraz> agh, what now..
20180204 14:28:51< vultraz> Soliton: uhh... there's some command.. I can't remember it now
20180204 14:29:52< Soliton> there's, :control side nick  i thought there's a gui version of that nowadays.
20180204 14:30:21< Soliton> i don't see it in the menu though.
20180204 14:30:43< vultraz> pretty sure there is..
20180204 14:30:57< vultraz> :give_control maybe?
20180204 14:31:18< Soliton> ah, indeed.
20180204 14:31:29< Soliton> why is it not in the menu?
20180204 14:31:37< vultraz> no idea
20180204 14:31:47< vultraz> feel free to add it
20180204 14:33:22< Soliton> should probably make a fr for it with easy first issue or whatever the tag is.
20180204 14:33:55< Soliton> i was wondering whether it can be used similarly for surrender.
20180204 14:34:23< Soliton> since i think the big thing missing in the surrender PR is a way to surrender to a side of your choosing.
20180204 14:34:57< vultraz> why not just let the host deal with it
20180204 14:35:17< Soliton> they can deal with it any time they want anyway.
20180204 14:35:51< Soliton> but the logical thing IMO is that the one surrendering decides who gets his side. if he cares...
20180204 14:36:17< Soliton> if the remaining players disagree they can shuffle sides around however they want anyway.
20180204 14:36:21< irker754> wesnoth: Charles Dang wesnoth:master 22087f47d327 / src/game_initialization/connect_engine.hpp: Connect Engine: make team_ unsigned since it's never less than 0 https://github.com/wesnoth/wesnoth/commit/22087f47d32703bfcb388e7e9d52b2269c82197e
20180204 14:37:20< Soliton> still tempted to leave that as a future enhancement and commit right now...
20180204 14:37:47< irker754> wesnoth/wesnoth:master Charles Dang 22087f47d3 Connect Engine: make team_ unsigned sinc AppVeyor: vs2013/Release Failed
20180204 14:37:48< irker754> Details: https://ci.appveyor.com/project/wesnoth/wesnoth/build/Wesnoth-VS2013-master-1257
20180204 14:37:52-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20180204 14:38:06< Soliton> that was quick.
20180204 14:38:20< JyrkiVesterinen> "Error while copying content to a stream."
20180204 14:38:22-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20180204 14:38:25< JyrkiVesterinen> Just a random failure.
20180204 14:38:45< Soliton> is travis supposed to succeed currently, btw?
20180204 14:38:59< JyrkiVesterinen> Yes.
20180204 14:39:00< vultraz> it should
20180204 14:39:07< vultraz> above commit should fix it
20180204 14:39:16< vultraz> was failing bc of signed-unsigned comparison
20180204 14:39:36< Soliton> i see. was wondering why it didn't for the surrender PR but that was a bit ago.
20180204 14:41:52< Soliton> hmm, observers allowed and observer button is greyed out.
20180204 14:42:35< Soliton> anyone else got that for the game currently on the trunk server?
20180204 14:45:13< celmin|sleep> Regarding the credits, I prefer to err on the side of inclusion; if they don't want to be included they can tell us and we can remove them.
20180204 14:45:50< celmin|sleep> Also I chose in most cases to not put in real names even when they were obvious from the commit information, just in case anyone is sensitive about that.
20180204 14:46:17< Soliton> no way to remove them from the history.
20180204 14:46:20< celmin|sleep> (I figure it's unlikely they are, but I decided to err on the side of caution.)
20180204 14:46:41< celmin|sleep> Yeah, but they were already in the history.
20180204 14:47:06< celmin|sleep> That's how I found them in the first place.
20180204 14:47:09< Soliton> if you just used that info, yes.
20180204 14:47:36< Soliton> ok, let's just say that i wouldn't do that then.
20180204 14:47:46< Soliton> i agree it's not a big deal.
20180204 14:48:28< Soliton> hmm, as moderator i should even be allowed to observe no matter what.
20180204 14:49:42< JyrkiVesterinen> Soliton: can reproduce. The Obseve button is grayed out.
20180204 14:49:51< JyrkiVesterinen> And the game is marked observable.
20180204 14:49:58< Soliton> ok, thanks.
20180204 14:51:16< Soliton> works for the new game i started though.
20180204 14:51:39< Soliton> that other game is from ios so perhaps not worth investigating.
20180204 14:53:08< Soliton> ok, observing a game as moderator works as well. though just with double clicking the game entry.
20180204 14:54:22< Soliton> not sure how that works in 1.12.
20180204 14:55:40< Soliton> ah, with the other game there is this add-on check error when i double click.
20180204 14:56:42< Soliton> vultraz: you probably want the same checks on double click as for the observe button. also note that mp server moderators are allowed to observe any game.
20180204 14:58:09< vultraz> If someone contributes it seems perfectly reasonable to add them to the credits
20180204 14:58:30< vultraz> Soliton: double click is join
20180204 14:58:41< Soliton> they get aasked that when they contribute their first patch.
20180204 14:58:56< Soliton> used to anyway.
20180204 14:59:41< Soliton> vultraz: i just double clicked a game and observed.
20180204 14:59:56< vultraz> Hmm
20180204 14:59:59< vultraz> Oh wait, yes
20180204 15:00:01< vultraz> Sorry
20180204 15:00:02< Soliton> the point though is that not the same checks are done like the buttons.
20180204 15:00:11< vultraz> What checks
20180204 15:00:20< Soliton> which is good atm so moderators have a chance to observe any game.
20180204 15:01:01< vultraz> Again, what checks
20180204 15:01:09< Soliton> the checks that activate or deativate the buttons...
20180204 15:01:47< Soliton> either don't check like you do on double click or do that same checks.
20180204 15:01:56< Soliton> s/that/the/
20180204 15:02:29< vultraz> Hmmmmm
20180204 15:03:36< Soliton> and just to repeat... if you add the checks account for moderators being allowed to observe any game.
20180204 15:03:50< vultraz> I should just remove the inline buttons
20180204 15:04:50< Soliton> those at least have the same logic as the sidebar buttons.
20180204 15:05:26< vultraz> Which also reminds me I received much criticism of my Lobby game display redesign
20180204 15:05:36< vultraz> Was gonna address it before this release but meh
20180204 15:05:42< vultraz> People can live with it
20180204 15:05:54< Soliton> that's the spirit!
20180204 15:06:40< vultraz> Indeed
20180204 15:07:04< Soliton> when i hear these things i wonder why i even think about not committing the surrender pr.
20180204 15:09:34< vultraz> If you don’t commit it in the next 9 hours, it will have to sit until April
20180204 15:10:11< JyrkiVesterinen> Isn't 1.14 development supposed to go to a branch soon?
20180204 15:10:21< JyrkiVesterinen> (Whcih would make master the 1.15 branch.)
20180204 15:10:36< Soliton> once 1.14 is released it can be branched off, yes.
20180204 15:11:05< vultraz> If we branch off now no one will fix bugs
20180204 15:12:31< hrubymar10> Hi, Sorry to disturb you but I am working on translations and after last .pot update wesnoth.po looks really strange at least for Czech (cs) translation
20180204 15:12:55< hrubymar10> Everything after line 4926 is commented https://github.com/wesnoth/wesnoth/blob/master/po/wesnoth/cs.po#L4926
20180204 15:14:20< Soliton> probably all the strings that are fuzzy now.
20180204 15:14:37< Soliton> any string in particular you think shouldn't be there?
20180204 15:16:19< hrubymar10> not shouldn't be there but should. Basically everything what is commented after last commit existed before and was translated
20180204 15:16:51< celmin|sleep> "used to" indeed... it's usually forgotten now.
20180204 15:16:54< hrubymar10> Is it possible that so many strings were removed? And where they get lost?
20180204 15:16:56< Soliton> fine, any string in particular you think shouldn't be commented?
20180204 15:17:28< Soliton> it's possible that no one ran a pot update in quite a while.
20180204 15:17:49< Soliton> and it's even more likely no one ran pofix.
20180204 15:18:26< vultraz> Looks like those strings have to do with the Unitbox and widescreeen themes
20180204 15:18:28< vultraz> Which were removed
20180204 15:18:48< vultraz> Though at least some of those strings should be the same in other themes..maybe they appear elsewhere
20180204 15:19:20< celmin|sleep> I dunno, there are definitely some strings there related to the two themes, but...
20180204 15:19:24-!- celmin|sleep is now known as celticminstrel
20180204 15:19:37< celticminstrel> Most of those look like error messages which shouldn't be theme-dependent?
20180204 15:19:45< celticminstrel> Or other general status things.
20180204 15:20:47< celticminstrel> BTW vultraz, speaking of pofix, I think you need to fix the entry you added still?
20180204 15:21:00< vultraz> Can you
20180204 15:21:06< celticminstrel> Maybe.
20180204 15:21:14< celticminstrel> But anyway, about these seemingly removed strings...
20180204 15:21:22< celticminstrel> Are they actually removed?
20180204 15:21:37< hrubymar10> It is not only cs problem, it is same in danish translation.
20180204 15:21:39< vultraz> The pot says so apparently
20180204 15:21:56< celticminstrel> I'm just thinking maybe there's a bug in the pot-update.
20180204 15:22:00< Soliton> it's going to be the same for every translation.
20180204 15:22:37< hrubymar10> #~ msgid "addon_type^MP scenario"
20180204 15:22:37< hrubymar10> #~ msgstr "Scénář hry pro více hráčů"
20180204 15:22:37< hrubymar10> #~ msgid "addon_type^MP campaign"
20180204 15:22:37< hrubymar10> #~ msgstr "Tažení pro více hráčů"
20180204 15:22:37< hrubymar10> #~ msgid "addon_type^MP modification"
20180204 15:22:38< hrubymar10> #~ msgstr "Frakce MP"
20180204 15:22:50< hrubymar10> is MP moved under other language file?
20180204 15:23:12< vultraz> Those strings were changed
20180204 15:23:24< vultraz> Now it says “multiplayer scenario” or something
20180204 15:23:42< celticminstrel> Then add them to pofix?
20180204 15:24:20< Soliton> i don't think that's going to help anything by now.
20180204 15:24:30< celticminstrel> Maybe...
20180204 15:24:34< Soliton> nobody ran pofix anyway, right?
20180204 15:24:51< celticminstrel> The string "You do not have a leader to recall with." exists in src/actions/create.cpp
20180204 15:25:11< celticminstrel> So I think something must've gone wrong in the pot-update.
20180204 15:26:44< irker754> wesnoth: Severin Glöckner wesnoth:master 02c79cf17695 / data/multiplayer/scenarios/2p_Dark_Forecast.cfg: Dark Forecast: lock team selection https://github.com/wesnoth/wesnoth/commit/02c79cf17695047fb473893eda87e3748a6234f6
20180204 15:27:35< Soliton> it does look like only data/ is in the pot now.
20180204 15:28:12< vultraz> Soliton: you just reverted a change sevu made yesterday
20180204 15:28:46< celticminstrel> What are you talking about, vultraz 
20180204 15:28:47< Soliton> can you elaborate? i didn't commit anything.
20180204 15:28:58< celticminstrel> If you mean that commit that just came in, that's sevu.
20180204 15:29:11< vultraz> OOS
20180204 15:29:13< vultraz> Oops
20180204 15:29:15< vultraz> Wrong person
20180204 15:29:19< vultraz> Sorry
20180204 15:29:23< vultraz> Misread the author
20180204 15:29:37< Soliton> loonycyborg: how did you run the pot update?
20180204 15:30:12< hrubymar10> You maybe already know that, but wesnoth-lib is also affected with strings like #~ msgid "Edit Scenario"
20180204 15:30:27< loonycyborg> scos pot-update update-po4a manual
20180204 15:30:48< Soliton> any idea why it might not have included src?
20180204 15:31:32< Soliton> where can i see what it does on pot-update?
20180204 15:31:46< loonycyborg> it will print exact command lines
20180204 15:32:11< Soliton> i don't want to run it.
20180204 15:32:48< Soliton> though if you can paste the output you got in your run that'd probably help.
20180204 15:33:21< hrubymar10> I am running it right now
20180204 15:33:23< celticminstrel> I think this is it: https://github.com/wesnoth/wesnoth/blob/master/po/SConscript#L56
20180204 15:34:06< Soliton> thanks.
20180204 15:34:18< loonycyborg> I can pastebin my output
20180204 15:34:19< loonycyborg> sec
20180204 15:36:28< JyrkiVesterinen> There has been this commit after the previous pot-update run: https://github.com/wesnoth/wesnoth/commit/a180e09bb600e97094deaa41f11a0ca0194c3e76#diff-deee8e1eaca587ce8e33c36d14775d84
20180204 15:36:50< JyrkiVesterinen> I wonder if the Python 3 code actually behaves differently than the previous Python 2 code.
20180204 15:37:13< JyrkiVesterinen> The change from os.path.walk() to os.walk() looks suspicious, in particular.
20180204 15:38:19< Soliton> and that's the part where src is searched...
20180204 15:38:26-!- travis-ci [~travis-ci@ec2-107-20-40-247.compute-1.amazonaws.com] has joined #wesnoth-dev
20180204 15:38:27< travis-ci> wesnoth/wesnoth#16308 (master - 22087f4 : Charles Dang): The build was fixed.
20180204 15:38:27< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/337216459
20180204 15:38:27-!- travis-ci [~travis-ci@ec2-107-20-40-247.compute-1.amazonaws.com] has left #wesnoth-dev []
20180204 15:38:55< celticminstrel> BTW, the cfg search part finds all cfg and lua files under data, right?
20180204 15:39:59< hrubymar10> Mine out.log https://filedrop.si/file/get/a241a383fc74ec319f387989372cc9fe2255d36e
20180204 15:40:09< loonycyborg> https://gist.github.com/loonycyborg/50d14e0ffbe0bfe30da04d9aab4c2506
20180204 15:40:31< hrubymar10> I don't have doc gen related utilities so I got error in the end, but after pot generating
20180204 15:40:35< Soliton> celticminstrel: yes.
20180204 15:41:12< Soliton> loonycyborg: see what JyrkiVesterinen said about os.walk() can you see if you can verify/fix that?
20180204 15:41:51< loonycyborg> I can have a look 
20180204 15:42:47< celticminstrel> https://docs.python.org/3/library/os.html#os.walk
20180204 15:42:56< celticminstrel> Looks like it doesn't do what the committer thought it does.
20180204 15:43:02< celticminstrel> See the example usage.3
20180204 15:45:56< celticminstrel> So rather than os.walk("../src", fill_source_list, None) I think we want for arg, dir, files in os.walk("../src"): fill_source_list(arg, dir, files) -- or just replace line 33 with that for header.
20180204 15:46:58< Soliton> loonycyborg: probably best to locally revert the last pot-update commit and do it all over again. (once the python is fixed)
20180204 15:47:12< loonycyborg> wow those functions totally have different meanings of its arguments
20180204 15:50:59< vultraz> Good thing the error was found
20180204 15:51:14< vultraz> hrubymar10: thanks for reporting
20180204 15:51:32< hrubymar10> np :)
20180204 15:55:03< celticminstrel> Still no sign of mattsc or singalen, huh?
20180204 15:55:22< celticminstrel> Or even ancestral.
20180204 16:02:44< loonycyborg> I'm working on fixing this python code atm
20180204 16:05:54-!- octalot [~steve@213-225-14-152.nat.highway.a1.net] has joined #wesnoth-dev
20180204 16:07:14< vultraz> hrubymar10 said he’d take a look at the Xcode project
20180204 16:07:20< vultraz> Ancestral is frequently on Discord
20180204 16:07:27< vultraz> If you’d JOIN DISCORD
20180204 16:08:10< vultraz> (Celmin that is)
20180204 16:12:17< Soliton> btw, another issue with discord for development talk. no way to reference a discussion in a commit message or so.
20180204 16:14:02< JyrkiVesterinen> Pretty much no one is referencing IRC discussions either.
20180204 16:14:29< Soliton> it's certainly happened multiple times.
20180204 16:15:15< Soliton> with discord you can't even be sure there will be logs in the future.
20180204 16:16:08< loonycyborg> I remember people did links to irc discussions in the past
20180204 16:16:16< loonycyborg> to irclogs
20180204 16:20:22< irker754> wesnoth/wesnoth:master Sofartin 3431976cbd Update about.cfg AppVeyor: All builds passed
20180204 16:31:26-!- tad_carlucci [~lundberg@74.193.219.119] has joined #wesnoth-dev
20180204 16:35:44-!- Bonobo [~Bonobo@220-244-89-194.tpgi.com.au] has quit [Ping timeout: 256 seconds]
20180204 16:50:34< loonycyborg> Soliton: btw who's responsible for running pofix anyway?
20180204 16:51:09-!- travis-ci [~travis-ci@ec2-54-83-126-159.compute-1.amazonaws.com] has joined #wesnoth-dev
20180204 16:51:10< travis-ci> Pentarctagon/wesnoth#16 (mtime-cache - 28fddd0 : pentarctagon): The build has errored.
20180204 16:51:10< travis-ci> Build details : https://travis-ci.org/Pentarctagon/wesnoth/builds/337248971
20180204 16:51:10-!- travis-ci [~travis-ci@ec2-54-83-126-159.compute-1.amazonaws.com] has left #wesnoth-dev []
20180204 16:53:15-!- travis-ci [~travis-ci@ec2-54-83-126-159.compute-1.amazonaws.com] has joined #wesnoth-dev
20180204 16:53:16< travis-ci> Pentarctagon/wesnoth#17 (mtime-cache - b59a12b : pentarctagon): The build has errored.
20180204 16:53:16< travis-ci> Build details : https://travis-ci.org/Pentarctagon/wesnoth/builds/337249550
20180204 16:53:16-!- travis-ci [~travis-ci@ec2-54-83-126-159.compute-1.amazonaws.com] has left #wesnoth-dev []
20180204 16:55:28< loonycyborg> seems the chief translation maintainer is responsible for running it
20180204 16:56:01< Soliton> yes, and anyone that commits a change to it.
20180204 16:56:25< Soliton> it seems no one reads the top of that script though.
20180204 16:56:55< irker754> wesnoth: loonycyborg wesnoth:master aa294390caf1 / / (1508 files in 31 dirs): Revert "pot-update and regenerate doc files" https://github.com/wesnoth/wesnoth/commit/aa294390caf155da890fb3a9210c0d7ad723c8da
20180204 16:56:57< irker754> wesnoth: loonycyborg wesnoth:master 83c5b5c5b39d / po/SConscript: Fix incorrect port of os.path.walk to os.walk https://github.com/wesnoth/wesnoth/commit/83c5b5c5b39d8a40012b835d2da190fbff382a9d
20180204 16:56:59< irker754> wesnoth: loonycyborg wesnoth:master 240d9d995d87 / / (1508 files in 31 dirs): pot-update and regenerate doc files https://github.com/wesnoth/wesnoth/commit/240d9d995d87c505efbe9c29a5ab1c08967ae04b
20180204 16:56:59-!- octalot [~steve@213-225-14-152.nat.highway.a1.net] has quit [Ping timeout: 268 seconds]
20180204 16:57:18-!- travis-ci [~travis-ci@ec2-54-83-126-159.compute-1.amazonaws.com] has joined #wesnoth-dev
20180204 16:57:19< travis-ci> Pentarctagon/wesnoth#18 (mtime-cache - 45676eb : pentarctagon): The build has errored.
20180204 16:57:19< travis-ci> Build details : https://travis-ci.org/Pentarctagon/wesnoth/builds/337250425
20180204 16:57:19-!- travis-ci [~travis-ci@ec2-54-83-126-159.compute-1.amazonaws.com] has left #wesnoth-dev []
20180204 16:57:37< loonycyborg> hrubymar10: Soliton: this should fix it. xgettext is called properly now
20180204 16:58:01< Soliton> loonycyborg: you realise your the chief translation maintainer when you do a pot update, right? :-P
20180204 16:58:20< loonycyborg> I thought it's still ivanovic
20180204 16:58:31< loonycyborg> pot-update is merely part of release process
20180204 16:58:40< vultraz> Ivanovic only commits translation updates that he somehow gets ahold of
20180204 16:59:00< Soliton> as i said though it's not that important now since lots has to be re-translated anyway surely.
20180204 16:59:08< vultraz> he hasn't had anything to do with the release process or translation maintenance in a long time
20180204 16:59:55< Soliton> more important once most translations are near 100% again. though i have no idea if some have kept up with 1.13...
20180204 17:00:50< irker754> wesnoth: Charles Dang wesnoth:master 1b79cb65f2d7 / data/multiplayer/scenarios/4p_A_New_Land.cfg: ANL: removed a bunch of duplicate allow_player= keys https://github.com/wesnoth/wesnoth/commit/1b79cb65f2d7308db32c03ce8748c60d8b1c69fc
20180204 17:00:53< irker754> wesnoth: Charles Dang wesnoth:master 36bd8dba8a71 / data/multiplayer/scenarios/2p_Tombs_of_Kesorak.cfg: Multiplayer: wmlindent run https://github.com/wesnoth/wesnoth/commit/36bd8dba8a718e155fb215e453fb76ae7e383407
20180204 17:02:03< vultraz> alright
20180204 17:02:12< vultraz> gonna grab some sleep
20180204 17:02:22< hrubymar10> Thank you Ioonycyborg , I'll try merge my translations asap. (Newly translated translations)
20180204 17:02:46< Soliton> loonycyborg: afaiui when you do a pot update it'll mark strings as fuzzy or worse. so if pofix wasn't run before to not make strings fuzzy it's not going to use much.
20180204 17:02:48< vultraz> if there're any last-minute bigfixes or maintenance tasks you want to commit, now's the time
20180204 17:03:11< hrubymar10> Well, I am going to PR Xcode fixes
20180204 17:03:13< hrubymar10> now
20180204 17:03:30< vultraz> perfect
20180204 17:03:32< vultraz> thanks :)
20180204 17:04:32< vultraz> celticminstrel: please take a look at https://github.com/wesnoth/wesnoth/pull/2438
20180204 17:04:35< hrubymar10> I verified it myself but you can also try it celticminstrel or someone
20180204 17:05:06< vultraz> (I agreed with the change to c++14 for the xcode proj)
20180204 17:05:13-!- travis-ci [~travis-ci@ec2-54-83-126-159.compute-1.amazonaws.com] has joined #wesnoth-dev
20180204 17:05:14< travis-ci> Pentarctagon/wesnoth#19 (mtime-cache - f1e3706 : pentarctagon): The build has errored.
20180204 17:05:14< travis-ci> Build details : https://travis-ci.org/Pentarctagon/wesnoth/builds/337252173
20180204 17:05:14-!- travis-ci [~travis-ci@ec2-54-83-126-159.compute-1.amazonaws.com] has left #wesnoth-dev []
20180204 17:05:19< irker754> wesnoth: Sofartin wesnoth:master 2935b6a18654 / projectfiles/Xcode/Wesnoth.xcodeproj/project.pbxproj: Fix and Upgrade Xcode project https://github.com/wesnoth/wesnoth/commit/2935b6a186549065d51f853f6b626dc9a0bafc27
20180204 17:05:21< irker754> wesnoth: Sofartin wesnoth:master 09bc22bac87a / projectfiles/Xcode/Info.plist: Upgrade Info.plist https://github.com/wesnoth/wesnoth/commit/09bc22bac87a187d5528bc3640cab500b3e2b80e
20180204 17:05:37< vultraz> or, he got to it
20180204 17:07:07< hrubymar10> I upgraded it
20180204 17:07:53-!- travis-ci [~travis-ci@ec2-54-81-88-207.compute-1.amazonaws.com] has joined #wesnoth-dev
20180204 17:07:54< travis-ci> Pentarctagon/wesnoth#20 (mtime-cache - 73d9d68 : pentarctagon): The build has errored.
20180204 17:07:54< travis-ci> Build details : https://travis-ci.org/Pentarctagon/wesnoth/builds/337253002
20180204 17:07:54-!- travis-ci [~travis-ci@ec2-54-81-88-207.compute-1.amazonaws.com] has left #wesnoth-dev []
20180204 17:11:38-!- travis-ci [~travis-ci@ec2-54-81-88-207.compute-1.amazonaws.com] has joined #wesnoth-dev
20180204 17:11:39< travis-ci> Pentarctagon/wesnoth#21 (mtime-cache - da6e86d : pentarctagon): The build has errored.
20180204 17:11:39< travis-ci> Build details : https://travis-ci.org/Pentarctagon/wesnoth/builds/337253968
20180204 17:11:39-!- travis-ci [~travis-ci@ec2-54-81-88-207.compute-1.amazonaws.com] has left #wesnoth-dev []
20180204 17:14:49-!- travis-ci [~travis-ci@ec2-54-83-126-159.compute-1.amazonaws.com] has joined #wesnoth-dev
20180204 17:14:50< travis-ci> Pentarctagon/wesnoth#22 (mtime-cache - 9be0a9a : pentarctagon): The build has errored.
20180204 17:14:50< travis-ci> Build details : https://travis-ci.org/Pentarctagon/wesnoth/builds/337254579
20180204 17:14:50-!- travis-ci [~travis-ci@ec2-54-83-126-159.compute-1.amazonaws.com] has left #wesnoth-dev []
20180204 17:23:30-!- travis-ci [~travis-ci@ec2-107-20-40-247.compute-1.amazonaws.com] has joined #wesnoth-dev
20180204 17:23:31< travis-ci> Pentarctagon/wesnoth#24 (mtime-cache - a6a1790 : pentarctagon): The build has errored.
20180204 17:23:31< travis-ci> Build details : https://travis-ci.org/Pentarctagon/wesnoth/builds/337256878
20180204 17:23:31-!- travis-ci [~travis-ci@ec2-107-20-40-247.compute-1.amazonaws.com] has left #wesnoth-dev []
20180204 17:34:16-!- travis-ci [~travis-ci@ec2-54-83-126-159.compute-1.amazonaws.com] has joined #wesnoth-dev
20180204 17:34:17< travis-ci> Pentarctagon/wesnoth#26 (mtime-cache - f017375 : pentarctagon): The build has errored.
20180204 17:34:17< travis-ci> Build details : https://travis-ci.org/Pentarctagon/wesnoth/builds/337259411
20180204 17:34:17-!- travis-ci [~travis-ci@ec2-54-83-126-159.compute-1.amazonaws.com] has left #wesnoth-dev []
20180204 17:53:56-!- octalot [~steve@213-225-14-152.nat.highway.a1.net] has joined #wesnoth-dev
20180204 18:04:01-!- Ravana_ [~Ravana@unaffiliated/ravana/x-2327071] has joined #wesnoth-dev
20180204 18:42:49< zookeeper> oh righty, the tentacle of the deep resistances.
20180204 18:51:29< Soliton> what's wrong with them?
20180204 18:52:46< zookeeper> they were just kind of random...ish: https://forums.wesnoth.org/viewtopic.php?f=12&t=46922
20180204 18:57:28< Soliton> sounds good.
20180204 19:01:48< zookeeper> also, after that all the water monsters will have the same resistances (besides varying arcane), except the water serpent that has 0% to everything.
20180204 19:02:28< zookeeper> err... arcane _and_ blade, of course, since the tentacle will have a vulnerability.
20180204 19:03:52-!- travis-ci [~travis-ci@ec2-54-81-88-207.compute-1.amazonaws.com] has joined #wesnoth-dev
20180204 19:03:53< travis-ci> Pentarctagon/wesnoth#31 (mtime-cache - 7e8599f : pentarctagon): The build passed.
20180204 19:03:53< travis-ci> Build details : https://travis-ci.org/Pentarctagon/wesnoth/builds/337277006
20180204 19:03:53-!- travis-ci [~travis-ci@ec2-54-81-88-207.compute-1.amazonaws.com] has left #wesnoth-dev []
20180204 19:09:11< irker754> wesnoth/wesnoth:master Charles Dang 77a06e2812 MP Staging: fixed team setting issue whe AppVeyor: All builds passed
20180204 19:29:58< celticminstrel> Ah, I didn't know hrubymar10 was on Mac?
20180204 19:30:53< celticminstrel> I don't really approve of the C++14 update, but I suppose it's not super-important.
20180204 19:31:30< celticminstrel> It does allow Mac devs to accidentally commit bad code, but uh... we don't even really have that many Mac devs right now...
20180204 19:32:07< celticminstrel> Travis should at least complain if someone accidentally commited code that doesn't work in C++11.
20180204 19:32:16< celticminstrel> Its Mac build runs scons.
20180204 19:32:29< irker754> wesnoth: ln-zookeeper wesnoth:master c7bbb809b86d / changelog data/core/units/monsters/Tentacle.cfg: Changed resistances and hitpoints for Tentacle of the Deep https://github.com/wesnoth/wesnoth/commit/c7bbb809b86dd777aa1b9bcd74dc407d91f07dce
20180204 19:32:35< celticminstrel> Just wondering, should loonycyborg have run pofix before pot-update?
20180204 19:32:50< celticminstrel> Or is it supposed to be run after pot-update?
20180204 19:32:59< zookeeper> sadly, it's such a widely used unit that it's practically impossible to check whether any UMC rely on the exact old values for anything.
20180204 19:33:35< Soliton> pretty sure you need to run it before to be useful. afterwards stuff will be marked fuzzy and pofix does not revert that or anything.
20180204 19:34:43< Soliton> there isn't too much in it though and i'm guessing most translation have lots to do for 1.14 anyway.
20180204 19:37:15< zookeeper> urgh, the water serpent has movement_type=naga which gives it completely different kinds of moves/defenses than the sea serpent.
20180204 19:37:47< irker754> wesnoth/wesnoth:master Charles Dang 22087f47d3 Connect Engine: make team_ unsigned sinc AppVeyor: 1/2 builds failed
20180204 19:37:48< irker754> Details vs2013/Release: https://ci.appveyor.com/project/wesnoth/wesnoth/build/Wesnoth-VS2013-master-1257
20180204 19:37:50< celticminstrel> Well, we could always re-revert the pot-update, run it, and re-run the pot-update.
20180204 19:37:57< celticminstrel> I dunno if that's worthwhile or not.
20180204 19:38:33< celticminstrel> zookeeper: I would expect the water serpent to be rather different than the sea serpent, at least in terms of movement. Maybe similar in resistances.
20180204 19:38:50< celticminstrel> The sea serpent is a deep sea creature; the water serpent is not (probably).
20180204 19:42:52< celticminstrel> vultraz, zookeeper: Should we change the dunefolk description to this for 1.14? (Though it would require a rerun of pot-update.) "The Dunefolk are one of a many diverse Human cultures. They inhabit the dry deserts in the south region of the Great Continent."
20180204 19:43:19< celticminstrel> Oh, but fix the grammar error "a many"
20180204 19:43:30< celticminstrel> I suppose I can poke loonycyborg too.
20180204 19:44:17< celticminstrel> IIRC it's currently an obvious placeholder, this is more of a not-so-obvious placeholder.
20180204 19:44:23< hrubymar10> celticminstrel I updated Xcode project to C++14 because CodeBlocks project was updated recently so I expected that source should be C++14 by default
20180204 19:44:37< celticminstrel> hrubymar10: The source is C++11 until post-1.14.
20180204 19:44:53< celticminstrel> Due to still supporting MSVC 2013.
20180204 19:45:09< hrubymar10> Well
20180204 19:45:51< hrubymar10> I guess that it will be ok. Otherwise you can downgrade it back to C++11 I don't have problem with it
20180204 19:46:13< hrubymar10> It's up to you
20180204 19:46:16< celticminstrel> (I mean, I guess instead of actually rerunning pot-update you could do a sed of all the po / pot the files for that one string. >_> )
20180204 19:46:33< celticminstrel> I doubt I can even open the Xcode project now...
20180204 19:46:38< celticminstrel> Given that I have Xcode 4...
20180204 19:47:42< hrubymar10> And what mac machine do you have? Project should be compatible with Xcode 6 and higher I can't test it
20180204 19:47:58< hrubymar10> I am using newest Xcode 9
20180204 19:48:03< celticminstrel> It's old. It runs OSX 10.7.
20180204 19:48:13< celticminstrel> IIRC it's from 2006.
20180204 19:48:18< celticminstrel> It had 10.4 when I bought it.
20180204 19:48:23< zookeeper> celticminstrell, well, there's not many diverse human cultures, so that part sounds a bit... fake.
20180204 19:49:33< celticminstrel> zookeeper: Well, I dunno about that... first, there could be human cultures that are unknown, and second, I'd say even in the Wesnoth area you can find at least four distinct cultures? They may not be great distinctions, mind you, since they all share history, but still...
20180204 19:50:02< celticminstrel> Elensefar, Wesnoth proper, horse clans, and Knalgan Alliance.
20180204 19:57:14< zookeeper> well, the description you pasted is still really clunky. i don't know what alternatives have been suggested in the thread so far.
20180204 20:00:14< Soliton> celticminstrel: "sed of all the po / pot files" is pretty much what pofix does.
20180204 20:01:26< zookeeper> anyway, i'll be afk for an hour...
20180204 20:03:41< matthiaskrgr> hmm, I tried to build using llvm/clang,  when building, however cmake tries to use gcc-ar (instead of llvm-ar) and the gcc-ar crashes
20180204 20:04:15< matthiaskrgr> setting -DCMAKE_AR=/full/path   does not seem to help a bit 
20180204 20:14:15< celticminstrel> zookeeper: I was just thinking it's likely better than what's currently there, which IIRC is something like "Insert description here"
20180204 20:22:02-!- Nobun1 [~user@5.170.240.83] has quit [Quit: idle is fun]
20180204 20:30:33< irker754> wesnoth: Sofartin wesnoth:master 4f798e812163 / projectfiles/Xcode/Wesnoth.xcodeproj/project.pbxproj: Downgrade Xcode project back to C++11 (#2439) https://github.com/wesnoth/wesnoth/commit/4f798e812163953f7f769c092d71396461fef1d1
20180204 20:45:18< celticminstrel> Soliton: So, if pofix needs to be run before a pot-update in order to be useful, why not add it to the pot-update scons/CMake targets.
20180204 20:45:21< celticminstrel> Just a thought.
20180204 20:45:30< celticminstrel> ^?
20180204 20:46:27< Soliton> i suppose that would make sense.
20180204 20:46:58< celticminstrel> Also, now that pot-update has been run, should pofix be cleared out?
20180204 20:47:04< Soliton> at least with scons there is the python dependency anyway. not sure about cmake.
20180204 20:48:20< Soliton> it still might be useful for incoming translation updates but something like that, yes.
20180204 20:48:32< celticminstrel> Ah, so maybe wait a bit.
20180204 20:50:39< celticminstrel> Also, it seems to me that it would be really easy to make the textdomain not be just a hint, since each textdomain is a separate subdirectory under po/
20180204 20:52:51-!- Oebele [~quassel@143.177.58.202] has joined #wesnoth-dev
20180204 21:05:17-!- vultraz [uid24821@wesnoth/developer/vultraz] has quit [Quit: Connection closed for inactivity]
20180204 21:14:32-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20180204 21:20:12-!- travis-ci [~travis-ci@ec2-54-81-88-207.compute-1.amazonaws.com] has joined #wesnoth-dev
20180204 21:20:13< travis-ci> wesnoth/wesnoth#16314 (master - c7bbb80 : ln-zookeeper): The build was broken.
20180204 21:20:13< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/337289334
20180204 21:20:13-!- travis-ci [~travis-ci@ec2-54-81-88-207.compute-1.amazonaws.com] has left #wesnoth-dev []
20180204 21:23:15-!- travis-ci [~travis-ci@ec2-54-81-88-207.compute-1.amazonaws.com] has joined #wesnoth-dev
20180204 21:23:16< travis-ci> Pentarctagon/wesnoth#32 (mtime-cache - d890749 : pentarctagon): The build has errored.
20180204 21:23:16< travis-ci> Build details : https://travis-ci.org/Pentarctagon/wesnoth/builds/337316027
20180204 21:23:16-!- travis-ci [~travis-ci@ec2-54-81-88-207.compute-1.amazonaws.com] has left #wesnoth-dev []
20180204 21:26:54< Soliton> "Window 'surrender_quit' registered but not tested."  is that a unit test failure?
20180204 21:27:01< Soliton> or just a warning?
20180204 21:27:41< celticminstrel> That's someone adding a GUI2 dialog but not updating the unit tests. Is that in master, or in a PR build?
20180204 21:27:54< celticminstrel> I didn't think the surrender feature branch had been merged?
20180204 21:28:12-!- travis-ci [~travis-ci@ec2-54-83-126-159.compute-1.amazonaws.com] has joined #wesnoth-dev
20180204 21:28:13< travis-ci> Pentarctagon/wesnoth#33 (mtime-cache - 5de506f : pentarctagon): The build has errored.
20180204 21:28:13< travis-ci> Build details : https://travis-ci.org/Pentarctagon/wesnoth/builds/337316686
20180204 21:28:13-!- travis-ci [~travis-ci@ec2-54-83-126-159.compute-1.amazonaws.com] has left #wesnoth-dev []
20180204 21:29:53< Soliton> not merged yet but i'd like to.
20180204 21:30:31< celticminstrel> Ah. Well. updating the GUI2 unit tests should be relatively simple. IIRC you just need to add one line to the test function and possibly a template specialization.
20180204 21:31:33< Soliton> i'll try to figure it out. more specific hints appreciated.
20180204 21:33:20< irker754> wesnoth/wesnoth:master Severin Glöckner 02c79cf176 Dark Forecast: lock team selection AppVeyor: All builds passed
20180204 21:33:52< celticminstrel> I think merging that would also require a pot-update rerun...
20180204 21:33:53< Soliton> what script do i start for that test? mp_tests?
20180204 21:34:00< celticminstrel> No
20180204 21:34:30< celticminstrel> The unit test code is in src/test/test_gui2.cpp IIRC; possibly src/test/gui/test_gui2.cpp
20180204 21:34:53< celticminstrel> You shouldn't need to fiddle with shell-scripts.
20180204 21:35:12< Soliton> sure, i'd like to run the tests though.
20180204 21:35:23< celticminstrel> Ah.
20180204 21:35:33-!- travis-ci [~travis-ci@ec2-54-83-126-159.compute-1.amazonaws.com] has joined #wesnoth-dev
20180204 21:35:34< travis-ci> Pentarctagon/wesnoth#34 (mtime-cache - b5bd3d0 : pentarctagon): The build failed.
20180204 21:35:34< travis-ci> Build details : https://travis-ci.org/Pentarctagon/wesnoth/builds/337318484
20180204 21:35:34-!- travis-ci [~travis-ci@ec2-54-83-126-159.compute-1.amazonaws.com] has left #wesnoth-dev []
20180204 21:35:37< celticminstrel> I think they're a target in scons/cmake and produce a "test" executable.
20180204 21:36:03< Soliton> hrm, that's going to take a while...
20180204 21:42:47-!- travis-ci [~travis-ci@ec2-107-20-40-247.compute-1.amazonaws.com] has joined #wesnoth-dev
20180204 21:42:48< travis-ci> Pentarctagon/wesnoth#35 (mtime-cache - d9131aa : pentarctagon): The build is still failing.
20180204 21:42:48< travis-ci> Build details : https://travis-ci.org/Pentarctagon/wesnoth/builds/337320230
20180204 21:42:48-!- travis-ci [~travis-ci@ec2-107-20-40-247.compute-1.amazonaws.com] has left #wesnoth-dev []
20180204 21:45:45< Soliton> the target is boost_unit_tests.
20180204 21:53:43-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20180204 21:55:07-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20180204 21:57:04-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has quit [Quit: .]
20180204 22:01:55< irker754> wesnoth: Severin Glöckner wesnoth:master e260fe95432f / data/multiplayer/scenarios/6p_Team_Survival.cfg: 6p Team Survival: fix terrain mask https://github.com/wesnoth/wesnoth/commit/e260fe95432fe5587242f0d67e47f2d23f6d50ec
20180204 22:04:06< Soliton> celticminstrel: http://ix.io/FfT  that should be enough?
20180204 22:04:26< celticminstrel> Looks about right.
20180204 22:04:59< celticminstrel> Looks like I was also too late on that issue comment. >_>
20180204 22:12:24< Soliton> 20 minutes to link the unit test binary. :-/
20180204 22:15:56-!- hrubymar10 [~textual@255.ip-217-182-72.eu] has quit [Quit: hrubymar10]
20180204 22:22:20-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180204 22:22:26-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20180204 22:39:09-!- Oebele [~quassel@143.177.58.202] has quit [Remote host closed the connection]
20180204 22:41:16-!- sevu [~Shiki@141.57.57.83] has joined #wesnoth-dev
20180204 22:43:53-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20180204 22:45:34-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20180204 23:03:36< irker754> wesnoth/wesnoth:master doofus-01 c0efb2c3f8 more sprite edits AppVeyor: All builds passed
20180204 23:06:38< irker754> wesnoth: Severin Glöckner wesnoth:master 9cdd0242d5e2 / data/multiplayer/scenarios/4p_A_New_Land.cfg: ANL: disallow observers for AI sides https://github.com/wesnoth/wesnoth/commit/9cdd0242d5e225f6cb51933a808326d6606acfed
20180204 23:22:53< irker754> wesnoth/wesnoth:master Sofartin 09bc22bac8 Upgrade Info.plist AppVeyor: All builds passed
20180204 23:25:21-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20180204 23:27:15 * mattsc is rately around and has essentially no time for Wesnoth at the moment
20180204 23:27:33< mattsc> Not by choice, it’s just how it is at the moment.
20180204 23:29:42-!- octalot [~steve@213-225-14-152.nat.highway.a1.net] has quit []
20180204 23:32:12< mattsc> celticminstrel: I don’t know anything about PR 2365 either.  As far as I can tell, it doesn’t have anything to do with the AI per se.
20180204 23:35:37< irker754> wesnoth: kallaballa wesnoth:master 024b2e7e9b8d / / (14 files in 8 dirs): Implement a surrender dialog https://github.com/wesnoth/wesnoth/commit/024b2e7e9b8d9b6cc3b1ea4f541d2b3a14eb6775
20180204 23:35:39< irker754> wesnoth: kallaballa wesnoth:master 4f1a7a9faaca / / (6 files in 2 dirs): Introduce surrender hotkey https://github.com/wesnoth/wesnoth/commit/4f1a7a9faacaf0d5bc8ce5daae79a8cdd7eb6353
20180204 23:35:41< irker754> wesnoth: kallaballa wesnoth:master 78dff47bd331 / / (6 files in 4 dirs): Implemented dropout to observer on surrender https://github.com/wesnoth/wesnoth/commit/78dff47bd331ee472abea69081e1beb517eda192
20180204 23:35:43< irker754> wesnoth: Gunter Labes wesnoth:master 72e19851abf9 / src/tests/gui/test_gui2.cpp: Add minimal unit test for surrender_quit dialog https://github.com/wesnoth/wesnoth/commit/72e19851abf9fbdb9c01b9a1a6a93c7f80bd5368
20180204 23:36:12< celticminstrel> mattsc: Okay, thanks.
20180204 23:36:29< Soliton> i hope the unit test works. i didn't have time to link and run it... i'll fix it asap if it's not.
20180204 23:36:31< celticminstrel> Soliton: So uh, that adds strings, right? Meaning a new pot-update is required?
20180204 23:36:42< Soliton> yes.
20180204 23:37:47< sevu> if that's the case... I have there sth too
20180204 23:38:29< irker754> wesnoth: Celtic Minstrel wesnoth:master d106dfb75018 / data/core/units.cfg: Add a very basic race description for the dunefolk https://github.com/wesnoth/wesnoth/commit/d106dfb75018422958b793af09ae8b22edc373bc
20180204 23:38:51< Soliton> heh.
20180204 23:39:14< Soliton> loonycyborg: can you re-run the pot update in a bit?
20180204 23:39:36< zookeeper> if there's actually going to be a release now/soon, then i guess #2414 is ready for squash-merging now. otherwise i'll give them a more thorough look tomorrow, first.
20180204 23:39:48< loonycyborg> ok
20180204 23:40:04< Soliton> topic says in ~20 minutes.
20180204 23:40:33< Soliton> no idea if what caused the delay is done though.
20180204 23:41:19< sevu> loonycyborg, can you update a bit? I look thought the mp maps currently and have a few strings added there too
20180204 23:41:44< Soliton> s/update/wait/ i guess
20180204 23:42:07< loonycyborg> hmm ok
20180204 23:42:28-!- travis-ci [~travis-ci@ec2-54-234-36-74.compute-1.amazonaws.com] has joined #wesnoth-dev
20180204 23:42:29< travis-ci> Pentarctagon/wesnoth#41 (mtime-cache - e8dd6a7 : pentarctagon): The build passed.
20180204 23:42:29< travis-ci> Build details : https://travis-ci.org/Pentarctagon/wesnoth/builds/337344051
20180204 23:42:29-!- travis-ci [~travis-ci@ec2-54-234-36-74.compute-1.amazonaws.com] has left #wesnoth-dev []
20180204 23:42:35< celticminstrel> zookeeper: It's not strings, so it can wait if necessary.
20180204 23:43:18-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: So long and thanks for all the fish.]
20180204 23:43:23< Soliton> loonycyborg: if you're bored you could also run pofix as described at the top of the script and see if it even does any changes currently... :-P
20180204 23:47:46-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20180204 23:57:01< irker754> wesnoth: Severin Glöckner wesnoth:master 12039f3bfc8b / data/multiplayer/scenarios/ (5 files): MP: added some keys to scenarios with AI sides https://github.com/wesnoth/wesnoth/commit/12039f3bfc8b0c8fb53fb210f3cb8d0bb0457ea2
20180204 23:57:30< sevu> loonycyborg, I'm done
20180204 23:57:53< sevu> Is everybody fine with calling the 4 captured units "Prisoners" in ANL?
20180204 23:58:13< sevu> Or would there be a better fitting name
20180204 23:58:28< Soliton> what are they called now? no name?
20180204 23:58:31< sevu> 2
20180204 23:58:33< sevu> just 2
--- Log closed Mon Feb 05 00:00:43 2018