--- Log opened Tue Feb 06 00:00:56 2018
20180206 00:06:57-!- vultraz [uid24821@wesnoth/developer/vultraz] has joined #wesnoth-dev
20180206 00:10:58-!- sigurdfd [sigurdfd@dynamic-acs-72-23-110-196.zoominternet.net] has quit []
20180206 00:32:37-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 268 seconds]
20180206 00:37:11-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20180206 00:37:34< celticminstrel> :(
20180206 00:38:10< vultraz> hm?
20180206 00:38:17< celticminstrel> It's not finished!
20180206 00:38:32< vultraz> indeed
20180206 00:41:24< vultraz> celticminstrel: take a look at https://github.com/wesnoth/wesnoth/pull/2450 please
20180206 01:03:05< irker025> wesnoth: Charles Dang wesnoth:master 35ae5c4ec85e / src/synced_user_choice.cpp: Synced User Choice: fixed side= not being adjusted in unsynced contexts (fixes # https://github.com/wesnoth/wesnoth/commit/35ae5c4ec85ecbd12fb8a81df3adffa4aa51956d
20180206 01:33:23< irker025> wesnoth: Charles Dang wesnoth:master bd9e423a692d / src/variable_info_private.hpp: Fixed regression where variables with leading _ were considered invalid (fixes # https://github.com/wesnoth/wesnoth/commit/bd9e423a692d0925e9302d271cd0f1a6736ad339
20180206 01:35:47< celticminstrel> Technically they should be valid only for scalars...
20180206 01:46:36< irker025> wesnoth: Charles Dang wesnoth:master 40706a8837ee / changelog src/menu_events.cpp: Added confirmation when clearing map labels (fixes #2371) https://github.com/wesnoth/wesnoth/commit/40706a8837eec30bc24559d3c3de5a104961dcd7
20180206 02:02:14-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20180206 02:16:46-!- travis-ci [~travis-ci@ec2-54-226-47-211.compute-1.amazonaws.com] has joined #wesnoth-dev
20180206 02:16:47< travis-ci> Pentarctagon/wesnoth#61 (scons-caching - e8b23f0 : pentarctagon): The build was broken.
20180206 02:16:47< travis-ci> Build details : https://travis-ci.org/Pentarctagon/wesnoth/builds/337825006
20180206 02:16:47-!- travis-ci [~travis-ci@ec2-54-226-47-211.compute-1.amazonaws.com] has left #wesnoth-dev []
20180206 02:28:53< celticminstrel> ..
20180206 02:28:55< celticminstrel> ..
20180206 02:28:58< celticminstrel> ...
20180206 02:29:57< vultraz> What?
20180206 02:30:28< celticminstrel> Build broken
20180206 02:31:40< vultraz> Not master
20180206 02:31:53< celticminstrel> Ah, okay.
20180206 02:31:58< celticminstrel> Guess I missed that.
20180206 02:32:14< celticminstrel> BTW, does anyone know why it was decided to forbid WML tags from beginning with an underscore?
20180206 02:32:16-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20180206 02:32:26< vultraz> Who the hell just posted to the thread..
20180206 02:32:31< celticminstrel> Maybe Jyrki would know...
20180206 02:32:34< celticminstrel> Hm?
20180206 02:32:51< vultraz> Someone just posted after you
20180206 02:32:55< celticminstrel> ...
20180206 02:34:09< vultraz> I’m deleting it
20180206 03:19:08< celticminstrel> BTW, has it been decided to mainline OoA eventually, or is this still an open question?
20180206 03:19:57-!- travis-ci [~travis-ci@ec2-54-226-47-211.compute-1.amazonaws.com] has joined #wesnoth-dev
20180206 03:19:58< travis-ci> Pentarctagon/wesnoth#62 (scons-caching - ed3c972 : pentarctagon): The build was fixed.
20180206 03:19:58< travis-ci> Build details : https://travis-ci.org/Pentarctagon/wesnoth/builds/337837617
20180206 03:19:58-!- travis-ci [~travis-ci@ec2-54-226-47-211.compute-1.amazonaws.com] has left #wesnoth-dev []
20180206 04:11:24-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity]
20180206 04:21:57-!- Coffee_irc [~david@220-244-89-194.tpgi.com.au] has quit [Ping timeout: 264 seconds]
20180206 04:29:27-!- Coffee_irc [~david@61.68.153.194] has joined #wesnoth-dev
20180206 04:41:50< vultraz> oh
20180206 04:41:50< vultraz> hmm
20180206 04:41:59< vultraz> hadn't thought about that in awhile
20180206 04:47:24< celticminstrel> ?
20180206 04:47:35< vultraz> OoA
20180206 04:47:51-!- irker025 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20180206 04:51:36< vultraz> celticminstrel: ya know I don't really see the point of "wml.variable.proxy"
20180206 04:52:47< celticminstrel> It's a thing that already existed.
20180206 04:54:51< vultraz> then i don't know what they thought
20180206 04:55:06< vultraz> suggest deprecating it in favor of wml.variables[]
20180206 04:57:52< celticminstrel> So you suggest deprecating the one with more features in favour of the one with fewer features. I see.
20180206 04:58:16< vultraz> what other features does it have?
20180206 05:00:48< celticminstrel> It's the variable proxy stuff from helper.lua.
20180206 05:01:05< celticminstrel> helper.get_wml_variable_proxy or something
20180206 05:01:26< celticminstrel> Supposed to allow you to access a WML variable like a Lua one.
20180206 05:01:29< vultraz> what's that do again?
20180206 05:01:41< celticminstrel> I don't recall all the details, but you should be able to find it on the wiki.
20180206 05:02:13< celticminstrel> Suppose you have a WML variable some_variable with keys thing=2 stuff=4
20180206 05:02:27< celticminstrel> You want to get at the 4
20180206 05:02:43< celticminstrel> With wml.variables you do wml.variables["some_variable.stuff"].
20180206 05:02:59< celticminstrel> With the proxy you do wml.variable.proxy.some_variable.stuff.
20180206 05:03:14< celticminstrel> IIRC it's missing some features though, like array access (but that could be added).
20180206 05:04:48< celticminstrel> The only real downside to the proxy is that if you do 'local some_variable = wml.variable.proxy.some_variable", then you can do some_variable.stuff = 6 and it works, but you can't do some_variable = {some_new_stuff} and expect the WML variable to be updated. That's just a Lua limitation.
20180206 05:05:28< celticminstrel> I think I wouldn't mind removing wml.variable.get/set though, TBH.
20180206 05:05:43< celticminstrel> wml.variables is actually a much better interface to that mechanism IMO.
20180206 05:05:52< vultraz> (should we name the __metatable for wml.variables?
20180206 05:05:54< vultraz> )
20180206 05:05:56< celticminstrel> Even if you have to do wml.variables["some_variable.stuff"].
20180206 05:05:59< celticminstrel> Yes we should.
20180206 05:06:12< vultraz> just "__metatable = "WML variables","?
20180206 05:06:17< celticminstrel> Lemme see...
20180206 05:06:30< vultraz> that's what the proxy table does
20180206 05:07:00< celticminstrel> Yeah, sure, that'll do.
20180206 05:08:53< vultraz> what does __metatable do anyway
20180206 05:10:19< celticminstrel> If present, it's returned by the getmetatable() function instead of the actual metatable.
20180206 05:10:51-!- irker238 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20180206 05:10:51< irker238> wesnoth: Charles Dang wesnoth:master 5134033e3055 / data/lua/core.lua: Name __metatable for wml.variables https://github.com/wesnoth/wesnoth/commit/5134033e30555c9d6317da7869a48eb15ceda82d
20180206 05:11:23< celticminstrel> I'm considering removing get, set, and get_all, now...
20180206 05:12:14< vultraz> isn;t get all useful
20180206 05:12:47< celticminstrel> Maybe? I was thinking it could be somehow merged into the wesnoth.variables syntax though.
20180206 05:12:56< celticminstrel> Then again, there's no set_all, hmm...
20180206 05:13:32< celticminstrel> get_all basically returns the config that would be stored in the saved game.
20180206 05:13:52< celticminstrel> So a hypothetical set_all would wipe all your variables and replace them with the contents of an input config.
20180206 05:14:20< celticminstrel> Ah, maybe I was wrong and the proxy does implement array access.
20180206 05:15:23< irker238> wesnoth: Celtic Minstrel wesnoth:master 4b58a52140ff / data/lua/core.lua: Shouldn't have the same __metatable for two metatables https://github.com/wesnoth/wesnoth/commit/4b58a52140ffe4948b4f54431c06b65df25746fb
20180206 05:15:38< celticminstrel> (Just happened to notice that. >_> )
20180206 05:16:04< vultraz> now we have ""WML variable proxy"" and ""WML variables proxy"
20180206 05:16:19< celticminstrel> Yup. Not ideal, I guess, but better than actual duplicates.
20180206 05:18:36< celticminstrel> I do think all this different variable stuff is kinda messy, but we can't just remove any of it (and it is more or less all useful, in any case).
20180206 05:28:30< celticminstrel> Either sevu broke the build or Travis is on strike. Builds have been failing recently.
20180206 05:28:57< celticminstrel> I guess the latter isn't unlikely given how there's a couple green builds in a string of otherwise red ones...
20180206 05:31:46< celticminstrel> ...or it could be AppVeyor's fault.
20180206 05:32:42< vultraz> it's AppVeyor
20180206 05:32:59< celticminstrel> Meh. Anyway, need to sleep.
20180206 05:34:58-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The computer falls into a deep sleep, to awake again some other day!]
20180206 05:51:21-!- TC01 [~quassel@venus.arosser.com] has quit [Ping timeout: 264 seconds]
20180206 05:51:45< irker238> wesnoth/wesnoth:master Severin Glöckner 4c8b3edd6d MP: 2p Silverhead Crossing - minor adjus AppVeyor: All builds passed
20180206 05:56:08-!- TC01 [~quassel@venus.arosser.com] has joined #wesnoth-dev
20180206 08:29:34< irker238> wesnoth: Charles Dang wesnoth:master 4e42be184c64 / src/gui/dialogs/story_viewer.cpp: Re-implement tiling options in the storyscreen (fixes #1027) https://github.com/wesnoth/wesnoth/commit/4e42be184c643d25d5c391a3905b8f88fa39e160
20180206 08:31:07< vultraz> AI0867: ^
20180206 08:31:26< vultraz> I don't know where that commit is where you partially reimplemented them, because I can't find it
20180206 08:48:19-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20180206 08:50:00< irker238> wesnoth: Jyrki Vesterinen wesnoth:master eb974afa151a / src/tests/test_serialization.cpp: Fix signed/unsigned comparisons in text serialization unit tests https://github.com/wesnoth/wesnoth/commit/eb974afa151a5e1fe359e088d84ffccfd7fff1d0
20180206 08:53:31< irker238> wesnoth/wesnoth:master Charles Dang 40706a8837 Added confirmation when clearing map lab AppVeyor: All builds passed
20180206 08:57:52-!- Oebele [~quassel@143.177.58.202] has joined #wesnoth-dev
20180206 09:22:52-!- Bhoren [~Bhoren_wh@2a01:e0a:c:2150:981d:4fff:4d3b:d628] has joined #wesnoth-dev
20180206 10:00:58-!- vladimirslavik [vslavik@nat/redhat/x-wbahvitpyzbsobks] has joined #wesnoth-dev
20180206 10:29:33-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20180206 10:35:39-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20180206 10:44:46-!- Oebele [~quassel@143.177.58.202] has quit [Remote host closed the connection]
20180206 11:22:17< irker238> wesnoth/wesnoth:master Celtic Minstrel 4b58a52140 Shouldn't have the same __metatable for  AppVeyor: All builds passed
20180206 11:37:01-!- Bhoren [~Bhoren_wh@2a01:e0a:c:2150:981d:4fff:4d3b:d628] has quit [Remote host closed the connection]
20180206 11:37:47< irker238> wesnoth/wesnoth:master pentarctagon 037b31d07e Enables travis to cache scons' build/ di AppVeyor: 1/6 builds failed
20180206 11:37:48< irker238> Details vs2017/Debug: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-master-987
20180206 11:51:11-!- travis-ci [~travis-ci@ec2-54-226-47-211.compute-1.amazonaws.com] has joined #wesnoth-dev
20180206 11:51:12< travis-ci> matthiaskrgr/wesnoth#5 (codespell_data - 1a72f74 : Matthias Krüger): The build has errored.
20180206 11:51:12< travis-ci> Build details : https://travis-ci.org/matthiaskrgr/wesnoth/builds/337957911
20180206 11:51:12-!- travis-ci [~travis-ci@ec2-54-226-47-211.compute-1.amazonaws.com] has left #wesnoth-dev []
20180206 11:51:21< matthiaskrgr> :(
20180206 11:52:00< matthiaskrgr> oh it's probably because I force pushed
20180206 11:56:44-!- Oebele [~quassel@143.177.58.202] has joined #wesnoth-dev
20180206 11:59:38< irker238> wesnoth: Charles Dang wesnoth:master c795b316c737 / src/ (game_initialization/connect_engine.cpp gui/dialogs/multiplayer/mp_join_game.cpp): Fixed user_team_name displaying incorrectly after leaving and rejoining a game https://github.com/wesnoth/wesnoth/commit/c795b316c737a404f8bfc445f5674fbee4a39e24
20180206 11:59:41< irker238> wesnoth: Charles Dang wesnoth:master d1dd0013d893 / src/gui/dialogs/multiplayer/mp_join_game.cpp: MP Join Game: don't show "null" as gender tooltip https://github.com/wesnoth/wesnoth/commit/d1dd0013d893279fe5f3708a779f31c23e06e066
20180206 12:00:10-!- vslavik [vslavik@nat/redhat/x-nyvoekzyhuevkmwn] has joined #wesnoth-dev
20180206 12:02:35-!- vladimirslavik [vslavik@nat/redhat/x-wbahvitpyzbsobks] has quit [Ping timeout: 240 seconds]
20180206 12:03:09< irker238> wesnoth: Matthias Krüger wesnoth:master b11d3fdcbef2 / data/ (44 files in 24 dirs): fix a bunch of typos found by codespell in data directory. https://github.com/wesnoth/wesnoth/commit/b11d3fdcbef2c964f2b1b8298f86eb42dcc3feef
20180206 12:03:11< irker238> wesnoth: Matthias Krüger wesnoth:master 1a09ba1c75f8 / doc/ (design/umcd/introduction.tex doxygen/doxygen.cpp man/wesnoth.6): doc: fix some typos https://github.com/wesnoth/wesnoth/commit/1a09ba1c75f8bb0b04163d3409cd21b8a6f98710
20180206 12:03:13< irker238> wesnoth: Matthias Krüger wesnoth:master dc33cf7cebaa / / (3 files in 3 dirs): pofix: add fixes of previous commits. https://github.com/wesnoth/wesnoth/commit/dc33cf7cebaaa0fe187b34a73a6a7ea77a27fea3
20180206 12:03:26< vultraz> matthiaskrgr: thanks for running that :)
20180206 12:03:37< matthiaskrgr> np
20180206 12:14:41< matthiaskrgr> wow 44 files, I didn't realizes it were that many
20180206 12:15:02< matthiaskrgr> also only 243 findings in src directory to go through >.< 
20180206 12:27:43-!- vslavik__ [vslavik@nat/redhat/x-jflmpmdzwsjigavh] has joined #wesnoth-dev
20180206 12:31:02-!- vslavik [vslavik@nat/redhat/x-nyvoekzyhuevkmwn] has quit [Ping timeout: 268 seconds]
20180206 12:36:14-!- travis-ci [~travis-ci@ec2-54-226-47-211.compute-1.amazonaws.com] has joined #wesnoth-dev
20180206 12:36:15< travis-ci> matthiaskrgr/wesnoth#6 (codespell_data - b03a7d7 : Matthias Krüger): The build was broken.
20180206 12:36:15< travis-ci> Build details : https://travis-ci.org/matthiaskrgr/wesnoth/builds/337967628
20180206 12:36:15-!- travis-ci [~travis-ci@ec2-54-226-47-211.compute-1.amazonaws.com] has left #wesnoth-dev []
20180206 12:39:19< Soliton> nobody ever reads the documentation of pofix.
20180206 12:52:30< matthiaskrgr> reading docs is for noobs. real programmers just bruteforce-modify their code until it works!!
20180206 12:53:39-!- travis-ci [~travis-ci@ec2-54-221-64-245.compute-1.amazonaws.com] has joined #wesnoth-dev
20180206 12:53:40< travis-ci> wesnoth/wesnoth#16343 (master - dc33cf7 : Matthias Krüger): The build was broken.
20180206 12:53:40< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/337978637
20180206 12:53:40-!- travis-ci [~travis-ci@ec2-54-221-64-245.compute-1.amazonaws.com] has left #wesnoth-dev []
20180206 12:57:00< Soliton> well, coincidentally that's pretty much the gist of said documentation. :-P
20180206 12:57:51< Soliton> the issue is that the strings in po files are broken up. so to match them properly you have to adjust the search string based on that.
20180206 12:58:46< Soliton> easiest for stuff like the auxilliaries entry would be to look just for that word.
20180206 12:59:19< Soliton> even if you'd match that somewhere you didn't expect you'd just fix a spelling error there, too...
20180206 13:06:29-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20180206 13:19:37-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180206 13:19:43-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20180206 13:43:22-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has joined #wesnoth-dev
20180206 13:47:13< JyrkiVesterinen> I finished the implementation of config pooling.
20180206 13:47:26< JyrkiVesterinen> Unfortunately, my tests show that loading times didn't improve at all.
20180206 13:47:33< JyrkiVesterinen> https://github.com/jyrkive/wesnoth/commit/46d0daead486995f40a9d057227365fe5094d417
20180206 14:00:41-!- vslavik [vslavik@nat/redhat/x-seuqfonqoycwlliv] has joined #wesnoth-dev
20180206 14:01:37-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20180206 14:03:21-!- vslavik__ [vslavik@nat/redhat/x-jflmpmdzwsjigavh] has quit [Ping timeout: 264 seconds]
20180206 14:04:29-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20180206 14:12:31< loonycyborg> JyrkiVesterinen: I'm suprised it's not making it slower
20180206 14:13:09< JyrkiVesterinen> Why would it be slower?
20180206 14:13:11< loonycyborg> making an unique_ptr could easily cost more than a malloc
20180206 14:13:47< JyrkiVesterinen> I don't follow. Unique_ptr just stores the pointer and deleter function.
20180206 14:15:22< loonycyborg> malloc returns only a pointer, and might have very little stuff to do depending on implementation
20180206 14:16:11< loonycyborg> an unique_ptr is light but if it can compete with plain pointer then it's quite an achievement
20180206 14:16:37< JyrkiVesterinen> Malloc needs to grab a mutex and manage the heap. It's fairly slow, no matter what you do.
20180206 14:18:04< JyrkiVesterinen> Most lightweight unique_ptr implementation imaginable (without a deleter function) needs to only store the pointer. It's literally zero overhead.
20180206 14:19:10< loonycyborg> config_pool::allocate() doesn't end up holding a mutex?
20180206 14:19:21< loonycyborg> does it mean it can't be used from multiple threads?
20180206 14:19:38< JyrkiVesterinen> Yes, my implementation isn't thread-safe.
20180206 14:21:12< loonycyborg> I think we're using wml from multiple threads somewhere atm
20180206 14:22:16< JyrkiVesterinen> Well, in any case I was only benchmarking at this point. And since pooling doesn't improve performance, there is no reason to improve it further.
20180206 14:33:07< loonycyborg> Did you consider plugging in this thing instead: http://www.boost.org/doc/libs/1_66_0/libs/pool/doc/html/index.html ?
20180206 14:35:50< JyrkiVesterinen> No, I didn't. My custom pool was just 56 lines after all.
20180206 14:36:08< loonycyborg> seems config class itself contains no data other than three stl containers
20180206 14:37:25< loonycyborg> I wonder if it's small enough to make pool allocation advantageous
20180206 14:38:58< loonycyborg> attribute names and values aren't contained in config object itself
20180206 14:39:05< loonycyborg> they're allocated by container
20180206 14:39:05-!- travis-ci [~travis-ci@ec2-54-221-64-245.compute-1.amazonaws.com] has joined #wesnoth-dev
20180206 14:39:06< travis-ci> matthiaskrgr/wesnoth#7 (master - dc33cf7 : Matthias Krüger): The build was broken.
20180206 14:39:06< travis-ci> Build details : https://travis-ci.org/matthiaskrgr/wesnoth/builds/338026311
20180206 14:39:06-!- travis-ci [~travis-ci@ec2-54-221-64-245.compute-1.amazonaws.com] has left #wesnoth-dev []
20180206 14:40:19< loonycyborg> I don't know config class very well. Can it share strings?
20180206 14:40:39< JyrkiVesterinen> No, every config object has its own private strings.
20180206 14:40:51< loonycyborg> like can it reuse names of tags that match
20180206 14:41:40-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has quit [Quit: Rebooting]
20180206 14:41:47< loonycyborg> We probably can save a lot of memory if it's made reuse strings that match
20180206 14:41:56< loonycyborg> since many tag names are repeated many times
20180206 14:42:13< loonycyborg> if they're stored as pointer to shared string in memory that gonna save a lot
20180206 14:46:19-!- JyrkiVesterinen [~jyrki@85-23-197-3.bb.dnainternet.fi] has joined #wesnoth-dev
20180206 14:55:07-!- JyrkiVesterinen [~jyrki@85-23-197-3.bb.dnainternet.fi] has quit [Quit: Rebooting]
20180206 14:59:16-!- JyrkiVesterinen [~jyrki@85-23-197-3.bb.dnainternet.fi] has joined #wesnoth-dev
20180206 15:04:20-!- irker238 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20180206 15:10:53-!- irker861 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20180206 15:10:53< irker861> wesnoth: Jyrki Vesterinen wesnoth:master ba22daf02941 / src/game_initialization/connect_engine.cpp: Fix build with GCC and Clang https://github.com/wesnoth/wesnoth/commit/ba22daf029414bb22dfea6c29076ac3423dc0141
20180206 15:11:24-!- JyrkiVesterinen [~jyrki@85-23-197-3.bb.dnainternet.fi] has quit [Quit: Rebooting]
20180206 15:14:41-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has joined #wesnoth-dev
20180206 15:50:15-!- vslavik__ [vslavik@nat/redhat/x-xuxrumqmbqnlptds] has joined #wesnoth-dev
20180206 15:53:02-!- vslavik [vslavik@nat/redhat/x-seuqfonqoycwlliv] has quit [Ping timeout: 256 seconds]
20180206 16:01:22-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has quit [Quit: .]
20180206 16:07:55< irker861> wesnoth: Charles Dang wesnoth:master 01105cc92435 / / (3 files in 2 dirs): MP Staging/MP Join Game: always draw leader sprite at 72x72 (fixes #1981) https://github.com/wesnoth/wesnoth/commit/01105cc924351b4ba8170fa8a8681f2073c805ee
20180206 16:21:34-!- travis-ci [~travis-ci@ec2-54-226-47-211.compute-1.amazonaws.com] has joined #wesnoth-dev
20180206 16:21:35< travis-ci> wesnoth/wesnoth#16344 (master - ba22daf : Jyrki Vesterinen): The build was fixed.
20180206 16:21:35< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/338050590
20180206 16:21:35-!- travis-ci [~travis-ci@ec2-54-226-47-211.compute-1.amazonaws.com] has left #wesnoth-dev []
20180206 16:31:24< AI0867> 09:31 < vultraz> I don't know where that commit is where you partially reimplemented them, because I can't find it ← it was on a branch on my own fork. I referred to it in the issue
20180206 16:31:40< vultraz> ah
20180206 16:32:22< AI0867> it did less than your implementation
20180206 16:32:33< vultraz> indeed
20180206 16:32:38< vultraz> but it was partial
20180206 16:35:43< AI0867> yes. It didn't do any size calculations, it just switched from scale to tile_center
20180206 16:36:10< AI0867> which works well enough if you don't specify any sizes, which is frequently the case for story backgrounds
20180206 16:37:51< vultraz> sizes?
20180206 16:57:00-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has joined #wesnoth-dev
20180206 17:26:48-!- pydsigner [~pydsigner@unaffiliated/pydsigner] has quit [Ping timeout: 240 seconds]
20180206 17:26:58-!- pydsigner [~pydsigner@unaffiliated/pydsigner] has joined #wesnoth-dev
20180206 18:10:03< irker861> wesnoth/wesnoth:master Matthias Krüger dc33cf7ceb pofix: add fixes of previous commits. AppVeyor: All builds passed
20180206 18:13:24< irker861> wesnoth: Charles Dang wesnoth:master fd70e888619d / src/game_initialization/connect_engine.cpp: Connect Engine: don't send faction description over the network https://github.com/wesnoth/wesnoth/commit/fd70e888619d00c565bf99e61206a74b472f83fa
20180206 18:37:01-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20180206 19:28:00-!- vslavik__ [vslavik@nat/redhat/x-xuxrumqmbqnlptds] has quit [Quit: Leaving]
20180206 19:57:21-!- nore [~ncourant@sas.eleves.ens.fr] has quit [Ping timeout: 248 seconds]
20180206 20:59:36-!- Oebele [~quassel@143.177.58.202] has quit [Remote host closed the connection]
20180206 21:03:09-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has quit [Quit: .]
20180206 21:04:35< vn971> wow. It seems there is unit.id, and there is unit.underlying_id. Discovered that while copying units. The underlying_id can be seen in WML dump (store_unit).
20180206 21:05:26< vn971> UPD: on wesnoth-1.12, didn't check 1.13 yet.
20180206 21:07:01< vultraz> please check 1.13
20180206 21:07:06< vultraz> that shouldn't be user-visible
20180206 21:13:48-!- irker861 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20180206 21:20:58< vn971> vultraz: will do. BTW, if something is diverged in 1.12 and 1.13, can I mention 1.12 behavior on the wiki, too? Or is it kinda deprecated (even though last stable)?
20180206 21:21:20< vultraz> i suppose you should
20180206 21:25:26< vn971> Not sure if there's some beautiful tag for it, inlined "1.12" and "1.13" words as raw text: https://wiki.wesnoth.org/ScenarioWML#The_.5Bscenario.5D_tag   [scenario].turns
20180206 21:28:07< vn971> vultraz: `underlying_id` is not visible on 1.13.
20180206 21:28:12< vultraz> ok, good
20180206 21:30:26-!- irker131 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20180206 21:30:26< irker131> wesnoth: Severin Glöckner wesnoth:master 3eb2ccac53e4 / data/multiplayer/scenarios/2p_Tombs_of_Kesorak.cfg: MP: fix the recently added map Tombs_of_Kesorak https://github.com/wesnoth/wesnoth/commit/3eb2ccac53e42c34a46bed2ec113e32247c29589
20180206 21:30:26< irker131> wesnoth: Severin Glöckner wesnoth:master 7bf479817edc / data/multiplayer/scenarios/2p_Tombs_of_Kesorak.cfg: MP: refactor time schedules in Tombs_of_Kesorak https://github.com/wesnoth/wesnoth/commit/7bf479817edcb0aaaba380a7db857288ce11962c
20180206 22:18:25< irker131> wesnoth/wesnoth:master Charles Dang 01105cc924 MP Staging/MP Join Game: always draw lea AppVeyor: All builds passed
20180206 23:04:24-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20180206 23:05:42-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20180206 23:32:56-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
--- Log closed Wed Feb 07 00:00:57 2018