--- Log opened Sat Feb 10 00:00:01 2018
20180210 00:05:07-!- travis-ci [~travis-ci@ec2-54-166-128-254.compute-1.amazonaws.com] has joined #wesnoth-dev
20180210 00:05:08< travis-ci> Pentarctagon/wesnoth#73 (cmake-mtime-md5 - 5386dbc : pentarctagon): The build passed.
20180210 00:05:08< travis-ci> Build details : https://travis-ci.org/Pentarctagon/wesnoth/builds/339694249
20180210 00:05:08-!- travis-ci [~travis-ci@ec2-54-166-128-254.compute-1.amazonaws.com] has left #wesnoth-dev []
20180210 00:45:42-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit []
20180210 00:51:31-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20180210 01:01:05< irker659> wesnoth/wesnoth:master lundberg 7ba6c80a24 Fix variable hides local variable warnin AppVeyor: All builds passed
20180210 02:36:27-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180210 02:36:33-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20180210 02:52:39-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20180210 04:02:13-!- irker659 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20180210 04:34:38-!- irker736 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20180210 04:34:38< irker736> wesnoth/wesnoth:master Sofartin 6179feb971 Some fixes and improvements AppVeyor: All builds passed
20180210 05:23:14-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180210 05:23:23-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20180210 05:31:35-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has joined #wesnoth-dev
20180210 05:57:28< vn971> pydsigner: separate license list for code and resources looks to be a proper approach IMO.
20180210 05:57:47< vn971> Is there a formal non-chat issue that I can subscribe to?
20180210 05:59:42< celticminstrel> ???
20180210 06:04:53< vultraz> they're discussing a license field in the pbl
20180210 06:05:48< celticminstrel> Oh hey shadow m has a new avatar.
20180210 06:06:10< celticminstrel> Anyway, if we're talking about pbl stuff, https://forums.wesnoth.org/viewtopic.php?f=2&t=42966
20180210 06:06:44< vultraz> You wanted to do that
20180210 06:06:57< celticminstrel> I assume hrubymar added kallaballa's real name at his request?
20180210 06:07:05< celticminstrel> ^their
20180210 06:07:20< vultraz> i assume so
20180210 06:07:32< celticminstrel> JyrkiVesterinen?
20180210 06:07:42< vultraz> what?
20180210 06:07:50< celticminstrel> Since he was the one who merged it.
20180210 06:08:17< vultraz> if someone opens a PR for something to add their name then we must assume they want it there
20180210 06:09:10< celticminstrel> But the author was hrubymar, not kallaballa.
20180210 06:10:13< vultraz> if they complain, we can remove it
20180210 06:10:18< celticminstrel> Ah, I found it.
20180210 06:10:25< celticminstrel> https://github.com/wesnoth/wesnoth/commit/61aad57dbd80bb2565f289c26fd1c953ed1b1179#commitcomment-27419732
20180210 06:12:28< vultraz> celticminstrel: how can i deprecate unit.portrait in favor of unit.profile?
20180210 06:12:50< celticminstrel> I personally think that portrait is the better name, but... gimme a moment to look it up...
20180210 06:13:05< vultraz> it is
20180210 06:13:09< vultraz> but the key is profile=
20180210 06:13:16< vultraz> portrait is better
20180210 06:13:19< celticminstrel> True...
20180210 06:13:26< vultraz> let's deprecate profile= then
20180210 06:14:06< celticminstrel> We'd need to merge in my deprecation PR first.
20180210 06:14:23< celticminstrel> But that can't be ATM because it'll break $(...) syntax.
20180210 06:14:30< vultraz> why?
20180210 06:14:48< celticminstrel> (Well, that would be the ideal way, at least.)
20180210 06:15:01< celticminstrel> (Obviously you could also just do it the old-fashioned way by manually logging a message.)
20180210 06:15:35< celticminstrel> Still, deprecating a WML key is kinda harder than deprecating a Lua key...
20180210 06:15:53< vultraz> oh, fuck it. just leave it
20180210 06:16:40< celticminstrel> Oh, wait, I don't think the Lua deprecation API could be used to deprecate portrait, because units are a userdata... hmm...
20180210 06:17:26< celticminstrel> Oh, and it doesn't even allow for deprecating variables in the first place.
20180210 06:17:43< celticminstrel> And I don't think that's even reasonably addable, unfortunately. It'd require putting a metatable on the containing table...
20180210 06:18:16< celticminstrel> Deprecating portrait in the C++ would be relatively easy though. Especially if the deprecation PR were merged, but even without that you could just duplicate the portrait line and add a message or something.
20180210 06:18:27< celticminstrel> Is it worth it though?
20180210 06:18:38< celticminstrel> There's certainly something to be said for consistency...
20180210 06:21:40< vultraz> celticminstrel: I really wish you would fix this
20180210 06:21:41< vultraz> https://github.com/wesnoth/wesnoth/issues/2247
20180210 06:22:01< celticminstrel> Hmm.
20180210 06:25:17< celticminstrel> I really should be able to find the time to do stuff tomorrow, provided I don't get too absorbed into Etrian Odyssey or Chrono Trigger again... >_>
20180210 06:27:22< celticminstrel> Oh yeah, JyrkiVesterinen, do you know the reason for disallowing tag names beginning with an underscore?
20180210 06:27:51< JyrkiVesterinen> In the WML tokenizer, an underscore is a token by itself.
20180210 06:28:10< JyrkiVesterinen> [_tagname] is tokenized as [, _, string, and ].
20180210 06:28:15< celticminstrel> Hmm.
20180210 06:28:20< celticminstrel> But what about _var=?
20180210 06:28:26< JyrkiVesterinen> And the tokenizer complains that [ must be followed by a string, not an underscore.
20180210 06:28:50< JyrkiVesterinen> I don't know what happens with attribute names.
20180210 06:28:57< vultraz> wait. does my change treating $ as a string mean [$tag] is valid?
20180210 06:29:06< celticminstrel> I hope not.
20180210 06:29:55< vultraz> I'm gonna pretend it's all fine
20180210 06:30:27< JyrkiVesterinen> Actually, I think it does make [$tag] valid in the parser level.
20180210 06:30:30< celticminstrel> So basically the restriction of initial underscores is due to a limitation of the preprocessor... if possible I think it'd be better to try and lift that restriction so that attribtues and tag name share the same restrictions... though I guess you could also go the opposite way on that, but then you'd need to change some other things where underscore-initial attributes are already used.
20180210 06:30:43< JyrkiVesterinen> There might be more checks higher up, though.
20180210 06:32:13< celticminstrel> What was the problem you were fixing again, Vultraz?
20180210 06:32:36< vultraz> the parser incorrectly dropped the space in an unquoted string with a variable name
20180210 06:32:37< vultraz> ie
20180210 06:32:41< vultraz> name=turn $var
20180210 06:32:55< vultraz> it became
20180210 06:32:56< celticminstrel> Well, it should consider these to be the same IIUC:
20180210 06:32:59< vultraz> name=turn$var
20180210 06:33:00< celticminstrel> name=turn $var
20180210 06:33:09< celticminstrel> name  = turn    $var
20180210 06:33:16< vultraz> it does AFAIK
20180210 06:33:21< celticminstrel> But it shouldn't be dropping the space altogether...
20180210 06:33:33< vultraz> see explanation on the bug
20180210 06:33:37< vultraz> or the commit message
20180210 06:33:46< celticminstrel> Saw the commit message earlier.
20180210 06:33:53< vultraz> gud 
20180210 06:33:54< celticminstrel> Looking at bug now.
20180210 06:34:28< celticminstrel> Does that bug affect 1.12? I think I've used that sort of thing before...
20180210 06:34:37< vultraz> it's been there for years
20180210 06:34:39< vultraz> as you can see
20180210 06:34:47< vultraz> the original report is from 2010
20180210 06:35:05< celticminstrel> Yeah...
20180210 06:35:23< vultraz> obviously name="turn $var" worked
20180210 06:35:34< vultraz> though why the original thread said it didn't
20180210 06:35:35< vultraz> idk
20180210 06:35:43< vultraz> it did last i checked a few weeks ago
20180210 06:35:50< celticminstrel> The preprocessor code is kinda ugly TBH.
20180210 06:35:58< vultraz> yes
20180210 06:36:01< vultraz> but this is the parser
20180210 06:36:04< celticminstrel> Or wait, right.
20180210 06:36:34< celticminstrel> Considering underscore to be a token on its own is really weird.
20180210 06:36:52< vultraz> sometimes i wish we used a lib like https://github.com/nlohmann/json
20180210 06:37:02< vultraz> so we didn't have to handle le parsing code
20180210 06:37:04< celticminstrel> I guess it's related to the detection of translatable strings, but why did it have to be a special token...
20180210 06:37:18< celticminstrel> Well, too late to switch to JSON now though. :P
20180210 06:37:54< vultraz> also whatever this lib is it sounds more efficient than our config class
20180210 06:37:55< vultraz> "Each JSON object has an overhead of one pointer (the maximal size of a union) and one enumeration element (1 byte)."
20180210 06:38:32< celticminstrel> That sounds pretty similar to the attribute_value?
20180210 06:38:46< celticminstrel> Though Boost's variant may be a little more heavyweight than that, I suppose.
20180210 06:39:23< celticminstrel> But of course config is more than just attribute values.
20180210 06:42:13< vultraz> also this lib is 10x feature-ful from an API perspective
20180210 06:44:07< JyrkiVesterinen> OK, I tested it.
20180210 06:44:17< JyrkiVesterinen> The parser now accepts [$tagname].
20180210 06:45:03< vultraz> oh dear
20180210 06:45:14< JyrkiVesterinen> However, if such tags are present in game state, my save validation blocks the game from being saved (because config::valid_id doesn't know that $ is allowed in tagnames).
20180210 06:45:23< vultraz> ahh
20180210 06:45:27< vultraz> nice
20180210 06:45:47< celticminstrel> Should probably still do something about it, but eh, probably not high priority?
20180210 06:46:27-!- travis-ci [~travis-ci@ec2-54-196-239-12.compute-1.amazonaws.com] has joined #wesnoth-dev
20180210 06:46:28< travis-ci> Pentarctagon/wesnoth#79 (cmake-mtime-md5 - 495b2ba : pentarctagon): The build passed.
20180210 06:46:28< travis-ci> Build details : https://travis-ci.org/Pentarctagon/wesnoth/builds/339766764
20180210 06:46:28-!- travis-ci [~travis-ci@ec2-54-196-239-12.compute-1.amazonaws.com] has left #wesnoth-dev []
20180210 06:46:40< JyrkiVesterinen> I'll add a unit test to explicitly check that Lua API rejects $ in tag names. It's not much effort.
20180210 06:52:47< celticminstrel> BTW, you should stop attempting to use Markdown in commit messages IMO.
20180210 06:52:52< celticminstrel> ^ vultraz 
20180210 06:52:58< vultraz> why?
20180210 06:53:06< celticminstrel> Because github doesn't parse it.
20180210 06:53:10< vultraz> I see
20180210 06:53:46< celticminstrel> Also because commit messages will often be seen in the command prompt where markup can't be parsed.
20180210 06:54:40< irker736> wesnoth: Jyrki Vesterinen wesnoth:master 4500fa641297 / data/test/scenarios/test_lua_wml_tagnames.cfg: Add a unit test to ensure that Lua API rejects dollar signs in tag names https://github.com/wesnoth/wesnoth/commit/4500fa64129765ec22372c48b5b11699690363af
20180210 07:14:50-!- celticminstrel is now known as celmin|sleep
20180210 07:36:37-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20180210 07:54:55< irker736> wesnoth/wesnoth:master Jyrki Vesterinen 4500fa6412 Add a unit test to ensure that Lua API r AppVeyor: vs2017/Release Failed
20180210 07:54:56< irker736> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-master-1035
20180210 08:26:44-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20180210 08:41:05-!- travis-ci [~travis-ci@ec2-54-242-66-123.compute-1.amazonaws.com] has joined #wesnoth-dev
20180210 08:41:06< travis-ci> Pentarctagon/wesnoth#86 (cmake-mtime-md5 - 0c19581 : pentarctagon): The build passed.
20180210 08:41:06< travis-ci> Build details : https://travis-ci.org/Pentarctagon/wesnoth/builds/339779456
20180210 08:41:06-!- travis-ci [~travis-ci@ec2-54-242-66-123.compute-1.amazonaws.com] has left #wesnoth-dev []
20180210 09:50:56< Soliton> apart from "code" is there anything besides images and music/sounds in an addon?
20180210 09:54:54< JyrkiVesterinen> Well, there is the script, locations, characters and so on, but I think they fall under code as well.
20180210 09:58:56< Soliton> yeah, basically i'm asking what resource types can be licensed in our new model.
20180210 09:59:25< Soliton> story/characters etc. are in WML so i guess you can't put them under a different license.
20180210 10:00:19< Soliton> so if it's just images and audio perhaps we could make that into two pbl keys for the license of each.
20180210 10:00:41< Soliton> if it's expected that they often differ anyway.
20180210 10:01:33< JyrkiVesterinen> Sounds good to me.
20180210 10:03:42-!- vultraz [uid24821@wesnoth/developer/vultraz] has quit [Quit: Connection closed for inactivity]
20180210 10:11:16< Soliton> ok, i opened an issue: https://github.com/wesnoth/wesnoth/issues/2468
20180210 10:12:09-!- vultraz [uid24821@wesnoth/developer/vultraz] has joined #wesnoth-dev
20180210 10:12:56< Soliton> what i would like to nail down is the specific new license key name(s) and the entries in the license list.
20180210 10:13:42< irker736> wesnoth: Sofartin wesnoth:master 34635aa28118 / data/core/about.cfg: Reorder names after last PR https://github.com/wesnoth/wesnoth/commit/34635aa28118f7718ab36c89659112a8c0d820a6
20180210 10:25:22< matthiaskrgr> 20180210 11:24:59 error lobby: Error while applying the gamelist diff: 'error in diff: could not find element 'game'' Getting a new gamelist.
20180210 10:25:25< matthiaskrgr> 20180210 11:24:59 error lobby: process_gamelist_diff failed!
20180210 10:25:28< matthiaskrgr> is this bad?
20180210 10:25:57< vultraz> huh
20180210 10:26:04< vultraz> I saw that too recently
20180210 10:26:07< vultraz> no idea what it mean
20180210 10:26:09< vultraz> s
20180210 10:26:15< vultraz> well, I know what it technically means
20180210 10:26:19< vultraz> but why it happens I don't know
20180210 10:26:27< matthiaskrgr> I was doing a me vs me online match 
20180210 10:26:51< matthiaskrgr> (being the only game on that server apparently)
20180210 10:27:09< Soliton> was that in the pre-game lobby?
20180210 10:27:11< irker736> wesnoth: Charles Dang wesnoth:master c75ca8751774 / / (76 files in 6 dirs): GUI2/Addon List: improved a bunch of stuff related to inline control buttons https://github.com/wesnoth/wesnoth/commit/c75ca8751774369397bd51aa6df687cd86cf5168
20180210 10:27:34< matthiaskrgr> yes
20180210 10:27:48< matthiaskrgr> right after I finished the game
20180210 10:27:59< matthiaskrgr> when it dropped me back into the lobby
20180210 10:28:02< vultraz> oh?
20180210 10:28:13< Soliton> pre-game means before the game. :-P
20180210 10:28:30< matthiaskrgr> oh it was after the game
20180210 10:28:45< vultraz> prolly a result of this
20180210 10:28:46< vultraz> https://github.com/wesnoth/wesnoth/commit/8ad14255e119725e77a0a054beeb6f9b11768b81
20180210 10:28:46< matthiaskrgr> Soliton: well, after the game is before the game AM I RIGHT?!?
20180210 10:28:59< vultraz> i will punch wesnothd if that is so
20180210 10:29:06-!- Oebele [~quassel@143.177.58.202] has joined #wesnoth-dev
20180210 10:29:42< matthiaskrgr> yeah its easy to repo 
20180210 10:29:49< matthiaskrgr> just drop ouf of the game
20180210 10:29:55< vultraz> eh
20180210 10:29:58< vultraz> it's minor
20180210 10:30:10< Soliton> well, no game being in the list seems fine. why is the client complaining?
20180210 10:30:12< matthiaskrgr> aka "please dont make a ticket about that" ok 
20180210 10:30:25< matthiaskrgr> :P
20180210 10:30:41< vultraz> probably some stupid shit about it looking for the game in the outdated list that was sent so it could then be removed
20180210 10:49:15< Soliton> matthiaskrgr: could you repeat that with --log-debug=log_lobby?
20180210 10:50:01< matthiaskrgr> unknown log domain: log_lobby
20180210 10:50:14< matthiaskrgr> ah its's just lobby
20180210 10:50:26< Soliton> ah, thanks.
20180210 10:51:14< Soliton> interesting would be the "prediff" entry before the error.
20180210 10:51:36< matthiaskrgr> https://pastebin.com/4TKGt73r  
20180210 10:52:10< Soliton> that's a short diff.
20180210 10:53:08-!- hrubymar10 [~textual@86.49.9.122] has joined #wesnoth-dev
20180210 10:55:42< Soliton> ah, that isn't even the diff data..
20180210 10:56:19< Soliton> no useful log message on the client side it seems.
20180210 11:00:38< matthiaskrgr> :/
20180210 11:01:17-!- Bhoren [~Bhoren_wh@2a01:e0a:c:2150:ece3:223d:f588:8d55] has joined #wesnoth-dev
20180210 11:06:40< Soliton> well, the basic issue seems to be that client and server do not agree on the gamelist.
20180210 11:07:26< Soliton> the server apparently sent a diff to the games list, probably removing the game you just ended, and the client for some reason has nothing in its gamelist.
20180210 11:08:12< matthiaskrgr> would make sense since the client was hosting the game and terminated it already, no?
20180210 11:09:02< Soliton> if the client that ended the game removes it for itself already that would be an explanation, yes.
20180210 11:10:25< Soliton> i'm not aware of such a change though. maybe vultraz is.
20180210 11:10:59< vultraz> The Lobby isn’t left often during games
20180210 11:11:01< vultraz> It’s closed
20180210 11:11:04< vultraz> Then reopened
20180210 11:11:38< vultraz> So likely what happens is the server is trying to remove a game from a list that the Lobby needed to request in order to have the game removed
20180210 11:12:16< vultraz> When debugging the issue that prompted the change in the commit above I noticed that the client got the game list twice after closing a game
20180210 11:12:22< Soliton> ah, so the client requests the full list on game end? ok.
20180210 11:12:30< vultraz> And the first had the expired game
20180210 11:12:39< vultraz> Which caused it to flash briefly in the game list
20180210 11:12:53< vultraz> I guess what happened is since it no longer gets sent that first outdated game list
20180210 11:12:59< vultraz> But rather a correct game list
20180210 11:13:09< vultraz> It’s trying to apply a bad diff
20180210 11:14:12< matthiaskrgr> is this literally a diff as in  "diff -u a b" ? 
20180210 11:14:15< Soliton> seems like a bad workaround then. no idea how you would fix that now.
20180210 11:14:28< Soliton> matthiaskrgr: something like that, yes.
20180210 11:14:35< matthiaskrgr> mmh
20180210 11:15:41< vultraz> There is literally no damn reason to send the client a game list with a game that just closed
20180210 11:15:44< vultraz> No reason at all
20180210 11:17:36< Soliton> so the solution is to figure out why that happens.
20180210 11:18:11< Soliton> and not to request the full list and then wonder why the next diff is bad.
20180210 11:19:20< vultraz> Well we need to full list
20180210 11:19:25< vultraz> To repopulate the Lobby
20180210 11:22:08-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20180210 11:22:36< Soliton> so there is no way around forgetting the gamelist?
20180210 11:22:39-!- travis-ci [~travis-ci@ec2-54-159-247-54.compute-1.amazonaws.com] has joined #wesnoth-dev
20180210 11:22:40< travis-ci> wesnoth/wesnoth#16382 (master - c75ca87 : Charles Dang): The build was broken.
20180210 11:22:40< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/339805797
20180210 11:22:40-!- travis-ci [~travis-ci@ec2-54-159-247-54.compute-1.amazonaws.com] has left #wesnoth-dev []
20180210 11:22:54< Soliton> then we need to change the server side accordingly.
20180210 11:23:29< Soliton> hopefully there is a good reason for such a protocol change.
20180210 11:24:27< vultraz> I don’t know
20180210 11:24:30< Soliton> i suppose it's backwards compatible at least.
20180210 11:24:30< vultraz> Whatever works works
20180210 11:25:18< Soliton> you do know why the client side changed though, no?
20180210 11:25:28< vultraz> What do you mean
20180210 11:25:46< Soliton> why does it forget the gamelist and requests the full one now?
20180210 11:26:13< vultraz> Because the damn Lobby object is destroyed
20180210 11:26:44< vultraz> Gfgtdf made that change I think because it didn’t make sense to leave game creation screens open under a game
20180210 11:26:51< vultraz> At least not with our engine
20180210 11:27:05< vultraz> Really, what does it matter
20180210 11:27:25< vultraz> You’re doing that thing again where you make a huge deal about a random client or server change
20180210 11:28:50< Soliton> so you're saying we should just ignore the errors wesnoth outputs and move on, yes?
20180210 11:29:42< vultraz> Though I will note the bug I fixed with that commit had been a problem for years
20180210 11:29:47< vultraz> Ever since 1.8 I believe
20180210 11:29:59< Soliton> i doubt it's that new.
20180210 11:30:04< vultraz> New??
20180210 11:30:14< Soliton> it's how it worked since forever i'd guess.
20180210 11:30:33< Soliton> it's based on the principle of sending diffs.
20180210 11:31:09< vultraz> Yes
20180210 11:31:30< vultraz> Client side handling isn’t that clean
20180210 11:33:00< Soliton> so if we want to change it properly the question is how to figure out which diff the server should send and which it should not to certain clients.
20180210 11:34:37-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has quit [Quit: .]
20180210 11:35:32< Soliton> well, actually we only send the gamelist diff to clients in the lobby. so i guess the issue might not be so old after all.
20180210 11:36:14< Soliton> so presumably the clients in the game that is about to end are added to the lobby too early.
20180210 11:36:39< Soliton> if they'd be added after the gamelist diff was sent it should be fine.
20180210 11:36:40< vultraz> I don't know
20180210 11:37:13< vultraz> i seem to recall my test only went as far as the game creation screen
20180210 11:37:20< vultraz> and that the issue might have only popped up for hosts
20180210 11:37:36< vultraz> well, i suppose, obviously, since them leaving closes the game
20180210 11:38:26< vultraz> and I remember it was receiving a gamelist with the just-closed game in it
20180210 11:38:42< vultraz> and then one without
20180210 11:39:36< vultraz> really, though, there are more pressing issues to fix
20180210 11:40:23< vultraz> there are other lobby log warnings like
20180210 11:40:42< vultraz> stuff about invalid game ids
20180210 11:40:50< vultraz> doesn't seem to actually affect anything though
20180210 11:41:08< irker736> wesnoth: Charles Dang wesnoth:master 0100e3a9f7a9 / src/gui/widgets/addon_list.cpp: Fixup c75ca87 https://github.com/wesnoth/wesnoth/commit/0100e3a9f7a95872cd7f9a1f44e4c9c14a6a0c0f
20180210 11:48:20< Soliton> if there are more pressing issue to fix those should be reported. and if you specifically want them fixed quickly you could suggest them to whoever.
20180210 11:53:20-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20180210 11:56:13-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20180210 11:57:32-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20180210 11:58:10-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20180210 11:59:26-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Client Quit]
20180210 12:00:07-!- hrubymar10 [~textual@86.49.9.122] has quit [Quit: hrubymar10]
20180210 12:00:17-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20180210 12:12:20< irker736> wesnoth: doofus-01 wesnoth:master ce363f491d8c / data/campaigns/Under_the_Burning_Suns/images/units/quenoth/ (10 files): [UtBS] - New Quenoth sprites (#2414) https://github.com/wesnoth/wesnoth/commit/ce363f491d8c5f47476d91aa709c2dc56ea97c0b
20180210 12:17:31-!- hrubymar10 [~textual@ip-86-49-9-122.net.upcbroadband.cz] has joined #wesnoth-dev
20180210 12:31:11-!- Bhoren [~Bhoren_wh@2a01:e0a:c:2150:ece3:223d:f588:8d55] has quit [Quit: Leaving]
20180210 12:39:15-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has joined #wesnoth-dev
20180210 12:52:37-!- travis-ci [~travis-ci@ec2-54-242-66-123.compute-1.amazonaws.com] has joined #wesnoth-dev
20180210 12:52:38< travis-ci> wesnoth/wesnoth#16385 (master - 0100e3a : Charles Dang): The build was fixed.
20180210 12:52:38< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/339818043
20180210 12:52:38-!- travis-ci [~travis-ci@ec2-54-242-66-123.compute-1.amazonaws.com] has left #wesnoth-dev []
20180210 12:54:54< irker736> wesnoth/wesnoth:master Jyrki Vesterinen 4500fa6412 Add a unit test to ensure that Lua API r AppVeyor: 1/4 builds failed
20180210 12:54:56< irker736> Details vs2017/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-master-1035
20180210 12:59:12< JyrkiVesterinen> I just noticed: in the test scenario (--test), "Quit to Titlescreen" quits to desktop instead.
20180210 12:59:25< JyrkiVesterinen> Is it known/desired?
20180210 13:00:48< Soliton> i think that it quits to desktop is probably expected. the menu entry doesn't fit though.
20180210 13:02:15< Soliton> at least i'm not sure it's easy to "return" to the titlescreen when you start directly into a test scenario.
20180210 13:02:56< JyrkiVesterinen> I'm not convinced that it even skips the titlescreen, to be honest.
20180210 13:04:02< Soliton> well, if it's easy to get it to return to the title screen then that'd be better.
20180210 13:04:34< JyrkiVesterinen> I don't have time to work on it, unfortunately. I'm working on #1747.
20180210 13:05:17< Soliton> could just open an issue so it's not forgotten.
20180210 13:09:23< Soliton> too man shared_ptrs in the server after loonycyborg's rewrite. makes it hard to figure out where stuff is really deleted.
20180210 13:09:52< JyrkiVesterinen> Shared_ptr is too easy a solution for object lifetime management.
20180210 13:09:57< JyrkiVesterinen> It should be the last resort.
20180210 13:10:03 * Soliton nods.
20180210 13:13:47< loonycyborg> what you're trying to figure out exactly? is there some resource leak?
20180210 13:14:16< Soliton> no, just stuff happens in the wrong order.
20180210 13:15:03< Soliton> delete_game() is called before cleanup_game() and the latter then sends stuff to the lobby which already includes the players in the ending game.
20180210 13:15:33< Soliton> the gamelist stuff should be sent before the players are put back into the lobby.
20180210 13:15:53-!- travis-ci [~travis-ci@ec2-54-159-247-54.compute-1.amazonaws.com] has joined #wesnoth-dev
20180210 13:15:54< travis-ci> wesnoth/wesnoth#16386 (master - ce363f4 : doofus-01): The build was fixed.
20180210 13:15:54< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/339823714
20180210 13:15:54-!- travis-ci [~travis-ci@ec2-54-159-247-54.compute-1.amazonaws.com] has left #wesnoth-dev []
20180210 13:16:54< Soliton> can't just switch stuff around though since cleanup_game() is registered as the deleter of games.
20180210 13:17:30< Soliton> feel free to look into that if you like. i'm out of time now. will be back later...
20180210 13:20:32-!- travis-ci [~travis-ci@ec2-54-196-239-12.compute-1.amazonaws.com] has joined #wesnoth-dev
20180210 13:20:33< travis-ci> Pentarctagon/wesnoth#90 (cmake-mtime-md5 - 6883f42 : pentarctagon): The build has errored.
20180210 13:20:33< travis-ci> Build details : https://travis-ci.org/Pentarctagon/wesnoth/builds/339828470
20180210 13:20:33-!- travis-ci [~travis-ci@ec2-54-196-239-12.compute-1.amazonaws.com] has left #wesnoth-dev []
20180210 13:39:58-!- travis-ci [~travis-ci@ec2-54-242-66-123.compute-1.amazonaws.com] has joined #wesnoth-dev
20180210 13:39:59< travis-ci> Pentarctagon/wesnoth#91 (cmake-mtime-md5 - 809c736 : pentarctagon): The build has errored.
20180210 13:39:59< travis-ci> Build details : https://travis-ci.org/Pentarctagon/wesnoth/builds/339829519
20180210 13:39:59-!- travis-ci [~travis-ci@ec2-54-242-66-123.compute-1.amazonaws.com] has left #wesnoth-dev []
20180210 13:44:52< loonycyborg> Soliton: so the issue is cleanup_game sends diff to players that just left the game right? why is it a bad thing?
20180210 13:45:43< loonycyborg> It might be little redundant because they know it already, but that's the only issue I see
20180210 13:50:20< loonycyborg> that is players that left game get full userlist with their past game in it and then immediately a diff to remove that game
20180210 13:59:20< loonycyborg> I kinda don't remember already why cleanup_game and delete_game are split up like this
20180210 13:59:59< loonycyborg> maybe network sends should be moved from cleanup_game to delete_game
20180210 14:00:39-!- travis-ci [~travis-ci@ec2-54-159-247-54.compute-1.amazonaws.com] has joined #wesnoth-dev
20180210 14:00:40< travis-ci> Pentarctagon/wesnoth#92 (cmake-mtime-md5 - 2cc0a2d : pentarctagon): The build has errored.
20180210 14:00:40< travis-ci> Build details : https://travis-ci.org/Pentarctagon/wesnoth/builds/339832576
20180210 14:00:40-!- travis-ci [~travis-ci@ec2-54-159-247-54.compute-1.amazonaws.com] has left #wesnoth-dev []
20180210 14:42:26-!- hrubymar10 [~textual@ip-86-49-9-122.net.upcbroadband.cz] has quit [Ping timeout: 276 seconds]
20180210 14:47:36-!- hrubymar10 [~textual@ip-86-49-9-122.net.upcbroadband.cz] has joined #wesnoth-dev
20180210 14:53:43-!- vultraz [uid24821@wesnoth/developer/vultraz] has quit [Quit: Connection closed for inactivity]
20180210 15:07:57< celmin|sleep> JyrkiVesterinen: I think when running a test scenario the titlescreen loop is never even entered, so in a sense there's no titlescreen to quit to. If it's possible, what I'd recommend is just hiding the option in a test scenario, though if you can get it to actually go to the titlescreen that'd be great too.
20180210 15:08:23< JyrkiVesterinen> As I said, I'm *not* going to work on it.
20180210 15:09:59< celmin|sleep> I was scanning the log, so I probably missed that part. >_>
20180210 15:10:33-!- celmin|sleep is now known as celticminstrel
20180210 15:29:41-!- hrubymar10 [~textual@ip-86-49-9-122.net.upcbroadband.cz] has quit [Quit: hrubymar10]
20180210 15:30:30-!- hrubymar10 [~textual@ip-86-49-9-122.net.upcbroadband.cz] has joined #wesnoth-dev
20180210 15:55:24-!- irker736 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20180210 16:07:03-!- irker280 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20180210 16:07:03< irker280> wesnoth: Jyrki Vesterinen wesnoth:master 3b88de6cbc47 / / (9 files in 4 dirs): Add sort order dropdown to add-on manager (#1747) https://github.com/wesnoth/wesnoth/commit/3b88de6cbc474a0e29f2b87d29a556bb3e200aa6
20180210 16:12:03-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180210 16:12:11-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20180210 16:14:52-!- DeFender1031 [~DeFender1@93-172-141-41.bb.netvision.net.il] has joined #wesnoth-dev
20180210 16:23:27-!- Bonobo [~Bonobo@61.68.156.44] has quit [Ping timeout: 248 seconds]
20180210 16:24:47< irker280> wesnoth/wesnoth:master Sofartin af22bcd9c2 Some fixes and improvements AppVeyor: All builds passed
20180210 16:26:15-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20180210 16:28:23-!- hrubymar10 [~textual@ip-86-49-9-122.net.upcbroadband.cz] has quit [Remote host closed the connection]
20180210 16:28:59-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20180210 16:37:39-!- hrubymar10 [~textual@ip-86-49-9-122.net.upcbroadband.cz] has joined #wesnoth-dev
20180210 16:49:45< irker280> wesnoth/wesnoth:master Sofartin 7226f80717 Reorder names after last PR AppVeyor: All builds passed
20180210 16:55:16-!- travis-ci [~travis-ci@54.242.66.123] has joined #wesnoth-dev
20180210 16:55:17< travis-ci> wesnoth/wesnoth#16390 (master - 3b88de6 : Jyrki Vesterinen): The build was broken.
20180210 16:55:17< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/339875120
20180210 16:55:17-!- travis-ci [~travis-ci@54.242.66.123] has left #wesnoth-dev []
20180210 17:01:38-!- vultraz [uid24821@wesnoth/developer/vultraz] has joined #wesnoth-dev
20180210 17:03:34-!- hrubymar10 [~textual@ip-86-49-9-122.net.upcbroadband.cz] has quit [Quit: hrubymar10]
20180210 17:05:21-!- hrubymar10 [~textual@ip-86-49-9-122.net.upcbroadband.cz] has joined #wesnoth-dev
20180210 17:07:10< Soliton> loonycyborg: they get the full list and an invalid diff. the latter perhaps just after vultraz tried to fix it.
20180210 17:07:43< loonycyborg> is it really invalid?
20180210 17:08:01< Soliton> yes, because the full list does not contain the game that just ended.
20180210 17:08:15< Soliton> as said perhaps just since the recent change there.
20180210 17:08:34< vultraz> I told you, it used to be sent twice.
20180210 17:11:53< vultraz> just don't send a diff or whatever 
20180210 17:11:55< Soliton> not as far as i can see.
20180210 17:12:00< loonycyborg> cleanup_game is responsible for removing that game from games_and_users_list_
20180210 17:12:33< loonycyborg> so if there is send done of full list of games then it would still contain removed game
20180210 17:12:46< loonycyborg> before cleanup_game
20180210 17:13:00< Soliton> that is the issue, yes.
20180210 17:13:57-!- Ravana_ [~Ravana@unaffiliated/ravana/x-2327071] has quit []
20180210 17:17:31< Soliton> so as far as i can tell the full list is not sent to the leaving players at all anymore.
20180210 17:17:50< vultraz> is that a problem
20180210 17:17:59< vultraz> they'll get it in 4 seconds anyway
20180210 17:18:38< Soliton> your approach to software development is getting a tad frustrating.
20180210 17:19:23< vultraz> I'm getting frustrated because you won't seem to acknowledge that the original issue was an issue
20180210 17:19:49< Soliton> i have no idea how you come to that conclusion.
20180210 17:20:12< Soliton> there is certainly an issue and it's not fixed yet.
20180210 17:21:23< Soliton> so what is this about 4 seconds anyway? are you telling me the client requests the full list every 4 seconds?
20180210 17:22:52< vultraz> it polls for network updates every 100 MS and updates the gamelist or gamelist diff every 4000 MS
20180210 17:23:18< Soliton> which means nothing if it is not sent a gamelist.
20180210 17:23:55< loonycyborg> iirc clients are always sent full gamelist when they rejoin lobby
20180210 17:24:07< Soliton> sure, that's fine.
20180210 17:24:11< vultraz> wait
20180210 17:24:14< loonycyborg> otherwise they wouldn't be able to show a list at all
20180210 17:24:36< vultraz> no, actually, it processes a gamelist or diff every time it comes in
20180210 17:24:39< vultraz> but also every 4 seconds
20180210 17:24:44< loonycyborg> because they don't get update diffs while in game
20180210 17:25:12< Soliton> that is all fine and how it should be.
20180210 17:25:55-!- Ravana_ [~Ravana@unaffiliated/ravana/x-2327071] has joined #wesnoth-dev
20180210 17:26:04< Soliton> that means though that right now clients exiting a game will not get the full list afaict and they won't understand any of the diffs.
20180210 17:26:32< vultraz> perhaps
20180210 17:26:51< loonycyborg> yeah iirc it would be quite noticeable if it did something wrong with diffs
20180210 17:27:17< vultraz> hard to test that on the 1.13 server
20180210 17:27:35< Soliton> and useless to test on 1.12.
20180210 17:28:03< loonycyborg> does client report any error if it gets invalid diff?
20180210 17:28:17< Soliton> yes. that's what started this investigation.
20180210 17:28:54< Soliton> so 8ad1425 needs to be reverted and the gamelist sent at the right time to leaving players.
20180210 17:29:15< vultraz> then we need to delete the game earlier
20180210 17:29:38< vultraz> because again, we do not want to send a gamelist with the game they're leaving
20180210 17:29:43< Soliton> something like that, yes.
20180210 17:30:19< vultraz> because the game popping up for a second
20180210 17:30:21< vultraz> is annoying
20180210 17:30:39< Soliton> sure. that is definitely a bug.
20180210 17:30:44< vultraz> good, good.
20180210 17:31:07< Soliton> it is new in 1.13 though. i compared to 1.12.
20180210 17:31:27< vultraz> it's relevant to the "new" lobby
20180210 17:31:53< vultraz> the 10 years old 'new' lobby
20180210 17:32:05< Soliton> sure, it's a server side issue. it's relevant to any lobby.
20180210 17:32:59< Soliton> loonycyborg: are you interested in fixing it? otherwise i'll get to it later.
20180210 17:33:37< vultraz> looks like the release will be delayed
20180210 17:33:38< vultraz> again.
20180210 17:33:43< loonycyborg> I'll inspect this code better later, but I could use a test case to repro it
20180210 17:34:24< vultraz> revert code. open game. don't even need to start it. close. you'll see it pop up in the lobby for a second then vanish.
20180210 17:34:33< Soliton> vultraz: btw, that is exactly the issue i have with bug fixes/workarounds without understanding the problem. the resulting changes are quite unlikely to be the right thing to do. i know you mean well but that's not always helping. :-/
20180210 17:35:10< vultraz> better to have that than no fix at all
20180210 17:35:42< JyrkiVesterinen> Besides, one should debug the issues instead of just shooting in the dark and hoping that some random change will improve the situation.
20180210 17:35:43< Soliton> and notice when people actually use 1.13 that they can't see anything after leaving a game, sure...
20180210 17:35:56< loonycyborg> revert which code? can you link that commit?
20180210 17:36:07< Soliton> testing is the other issue i have... :-P
20180210 17:36:21< Soliton> 8ad1425
20180210 17:36:32< vultraz> i haven't confirmed it was the case
20180210 17:36:35< Soliton> https://github.com/wesnoth/wesnoth/commit/8ad1425
20180210 17:36:41< vultraz> that they see nothing
20180210 17:37:06< Soliton> unless the client requests the full list sometime that's bound to be what's happening.
20180210 17:37:36< loonycyborg> ah yes
20180210 17:37:36< Soliton> and the client should definitely not do that randomly or on a timer.
20180210 17:37:49< loonycyborg> I don't think it's bad if it briefly shows old game
20180210 17:38:01< loonycyborg> at least not release blockingly bad
20180210 17:38:05< Soliton> i agree with vultraz that it is.
20180210 17:38:12< Soliton> well, that may be.
20180210 17:38:22< Soliton> it's a regresssion though.
20180210 17:38:43< Soliton> and since we've identified the issue now it shouldn't be difficult to fix...
20180210 17:38:58< loonycyborg> I think this commit should be reverted and and I'll need to think how to fix it properly
20180210 17:39:08< vultraz> but do fix it.
20180210 17:39:30< loonycyborg> ok
20180210 18:31:11-!- travis-ci [~travis-ci@ec2-54-159-247-54.compute-1.amazonaws.com] has joined #wesnoth-dev
20180210 18:31:12< travis-ci> Pentarctagon/wesnoth#93 (cmake-mtime-md5 - 05828be : pentarctagon): The build passed.
20180210 18:31:12< travis-ci> Build details : https://travis-ci.org/Pentarctagon/wesnoth/builds/339907946
20180210 18:31:12-!- travis-ci [~travis-ci@ec2-54-159-247-54.compute-1.amazonaws.com] has left #wesnoth-dev []
20180210 18:59:18< loonycyborg> error general: Mandatory WML child missing yet untested for. Please report.
20180210 18:59:34< loonycyborg> this is what I get at master when trying to start a game on local wesnothd
20180210 19:03:17< loonycyborg> Soliton: vultraz: https://gist.github.com/loonycyborg/ac5ce06036482beda4a16dc40d8af87a
20180210 19:03:25< loonycyborg> that's my proposed fix that I can't test
20180210 19:05:25< loonycyborg> the diff is based on master with 8ad1425 reverted
20180210 19:09:26< Soliton> i'm not really sure what that should help.
20180210 19:10:05< loonycyborg> it would send diff not containing the deleted game
20180210 19:10:17< loonycyborg> so it no longer will flash in list for a bit
20180210 19:10:27< loonycyborg> issue vultraz seeks to address
20180210 19:10:42< loonycyborg> I mean not diff but full gamelist
20180210 19:12:02< Soliton> i don't see how your diff does that.
20180210 19:12:10< loonycyborg> I just moved sending of gamelist after the game is removed from the multi-index
20180210 19:12:26< loonycyborg> and thus it happens after cleanup_game
20180210 19:13:41< Soliton> it's removed from games_and_users_list_ in cleanup_game() afaict.
20180210 19:14:52< Soliton> and cleanup_game() will also still send its diff to the leaving players which we want to avoid.
20180210 19:17:28< Soliton> before games_and_users_list_ is sent to the leaving players the game needs to be removed from there and before that happens of course the lobby diff needs to be made and sent.
20180210 19:18:37< loonycyborg> cleanup_game() only sends diff to lobby, not to leaving players
20180210 19:18:57< Soliton> they're in the lobby at that point so yes it does.
20180210 19:19:35< loonycyborg> hmm I'm not sure what'll happen if client gets full list after diff
20180210 19:20:06< Soliton> you can compare to delete_game() from 1.12 it was all done in there in the right order.
20180210 19:20:44< loonycyborg> but you got any idea about this mandatory wml child missing error?
20180210 19:21:11< Soliton> no, it means that some code tried to access a config child which was not there.
20180210 19:21:21< Soliton> hard to say which and where unfortunately.
20180210 19:21:38< loonycyborg> do you get it yourself with latest master?
20180210 19:21:45< Soliton> sounds like it must be a very recent change though.
20180210 19:22:18< Soliton> i'm currently rebuilding but i have a very slow computer here.
20180210 19:30:41< vultraz> can't repro 
20180210 19:36:49< celticminstrel> BTW, the release is scheduled for the 10th, right?
20180210 19:36:57< celticminstrel> ie today
20180210 19:38:22< JyrkiVesterinen> [19:33:38] <vultraz> looks like the release will be delayed
20180210 19:38:22< JyrkiVesterinen> [19:33:39] <vultraz> again.
20180210 19:38:36< vultraz> *nods*
20180210 19:38:42< celticminstrel> :(
20180210 19:39:04< celticminstrel> Well, I guess it does however mean I can slack off a bit more today and still have a chance of getting my stuff together in time. >_>
20180210 19:40:01< JyrkiVesterinen> Meanwhile a certain someone didn't slack off. *points at 3b88de6c* ;)
20180210 19:40:39< celticminstrel> Nice.
20180210 19:40:52< vultraz> celticminstrel: the release would be in 4 hours anyway, so you wouldn't have time regardless
20180210 19:41:15< celticminstrel> 4 hours might've been enough time to scrape together the deprecation PR into something mergeable.
20180210 19:44:58< vultraz> also there's a very pesky bug I found that I found in the addon manager
20180210 19:45:11< irker280> wesnoth: Charles Dang wesnoth:master 8b9ebdaa0fb8 / src/gui/widgets/addon_list.cpp: GUI2/Addon List: fixed regression from c75ca875177 (fixes #2472) https://github.com/wesnoth/wesnoth/commit/8b9ebdaa0fb8043929bf12d66ed950d695b88ec6
20180210 19:46:16< Soliton> loonycyborg: can't repro either.
20180210 19:46:42< loonycyborg> I'm trying to build without lto
20180210 19:47:40< loonycyborg> Soliton: you have lto enabled? it recently got enabled by default
20180210 19:47:54< Soliton> yes, i think so.
20180210 19:48:04< loonycyborg> hmm that could be some local setting here too
20180210 19:48:18< vultraz> i have a fast LTO build via MSVS
20180210 19:48:37< loonycyborg> what's the proper way to run wesnoth without any local settings?
20180210 19:48:44< JyrkiVesterinen> Clang can also make fast LTO builds.
20180210 19:49:13< JyrkiVesterinen> loonycyborg: run Wesnoth with --userdata-dir=/any/directory
20180210 19:50:03 * vultraz idly wonders what would happen if you tried to set the userdata dir to dev/null
20180210 19:50:20< Soliton> /dev/null is not a dir.
20180210 19:50:32< JyrkiVesterinen> How about /dev/urandom? :P
20180210 19:51:01< loonycyborg> seems it works with empty userdata dir
20180210 19:51:10< Soliton> also not a dir. if we have an option to just specify the config file that could work though.
20180210 19:51:33< matthiaskrgr> 20180210 20:51:24 error filesystem: Failed to check existence of file /dev/urandom/images/icons/icon-game.png: Not a directory
20180210 19:51:36< matthiaskrgr> boring 
20180210 19:53:42< Soliton> you could link preferences to /dev/null.
20180210 19:54:58< JyrkiVesterinen> Wesnoth would likely just treat it like an empty preferences file (i.e. defaults).
20180210 19:55:20< Soliton> yeah, that's what i'd expect.
20180210 19:58:52-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20180210 20:03:57-!- Bhoren [~Bhoren_wh@2a01:e0a:c:2150:49f3:9cc9:99b1:75d5] has joined #wesnoth-dev
20180210 20:15:49-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit []
20180210 20:17:40-!- doofus-01 [~aristede@2601:647:5680:1530:c654:44ff:fe28:1054] has joined #wesnoth-dev
20180210 20:31:17< irker280> wesnoth: Charles Dang wesnoth:master c1841e3fe84f / src/ (addon/info.cpp gui/dialogs/addon/manager.cpp): Addon Manager: serialize local_only info key https://github.com/wesnoth/wesnoth/commit/c1841e3fe84fcffd896b282b3596a696b5a717b7
20180210 20:32:17-!- travis-ci [~travis-ci@ec2-54-196-239-12.compute-1.amazonaws.com] has joined #wesnoth-dev
20180210 20:32:18< travis-ci> wesnoth/wesnoth#16393 (master - 8b9ebda : Charles Dang): The build was fixed.
20180210 20:32:18< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/339930633
20180210 20:32:18-!- travis-ci [~travis-ci@ec2-54-196-239-12.compute-1.amazonaws.com] has left #wesnoth-dev []
20180210 21:07:29< doofus-01> Commit c820009 "Fixes LTO/PGO options not being..." makes me no longer able to compile, I assume no one else has trouble
20180210 21:07:42< doofus-01> I must have something set wrong?
20180210 21:07:50< vultraz> well what is the error
20180210 21:08:54< doofus-01> can't find "ld" ... I've lost it, let me recreate.
20180210 21:09:08< vultraz> ftr, you can also ping us on discord
20180210 21:10:03< vultraz> in #development
20180210 21:10:44< JyrkiVesterinen> It would be best if you posted the entire compiler/linker output.
20180210 21:10:54< JyrkiVesterinen> Upload it to GitHub Gist or something.
20180210 21:11:32< doofus-01> @vultraz - Both are awkward for me.
20180210 21:11:52< vultraz> hm?
20180210 21:13:32< doofus-01> IRC and discord.  Well, it looks like I dropped by prematurely, I will ask again when I have the output.
20180210 21:13:39< doofus-01> bye
20180210 21:13:55-!- doofus-01 [~aristede@2601:647:5680:1530:c654:44ff:fe28:1054] has quit [Quit: Konversation terminated!]
20180210 21:14:17< vultraz> well that's odd
20180210 21:14:25< vultraz> since he does use discord...
20180210 21:14:56< JyrkiVesterinen> IRC was awkward to me at first as well (especially as a non-native English speaker - I was much worse in English back then).
20180210 21:15:22< vultraz> really? I didn't notice
20180210 21:15:40< JyrkiVesterinen> By "at first", I meant around 2010, when I originally started to use IRC.
20180210 21:15:48< vultraz> oh
20180210 21:20:04-!- travis-ci [~travis-ci@ec2-54-159-247-54.compute-1.amazonaws.com] has joined #wesnoth-dev
20180210 21:20:05< travis-ci> wesnoth/wesnoth#16394 (master - c1841e3 : Charles Dang): The build was fixed.
20180210 21:20:05< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/339941758
20180210 21:20:05-!- travis-ci [~travis-ci@ec2-54-159-247-54.compute-1.amazonaws.com] has left #wesnoth-dev []
20180210 21:28:48< irker280> wesnoth: Charles Dang wesnoth:master 84c0d2c9761e / src/addon/client.cpp: Addon/Client: use std::move instead of copying addon server response https://github.com/wesnoth/wesnoth/commit/84c0d2c9761e6373633f987eb098da1b6da135d0
20180210 21:28:51< irker280> wesnoth: Charles Dang wesnoth:master 98604a4c21d1 / src/ (4 files in 2 dirs): Campaignd: rename addon list response config tags https://github.com/wesnoth/wesnoth/commit/98604a4c21d1222634f69acd088b83c0e3c5c618
20180210 21:29:44< irker280> wesnoth/wesnoth:master pentarctagon 996d284231 Adding a file test. AppVeyor: vs2017/Release Failed
20180210 21:29:45< irker280> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-master-1051
20180210 21:31:32-!- Bhoren [~Bhoren_wh@2a01:e0a:c:2150:49f3:9cc9:99b1:75d5] has quit [Remote host closed the connection]
20180210 21:37:43-!- Netsplit *.net <-> *.split quits: boucman
20180210 21:37:58-!- Netsplit *.net <-> *.split quits: vn971
20180210 21:38:03-!- Netsplit *.net <-> *.split quits: nurupo
20180210 21:38:26-!- Netsplit *.net <-> *.split quits: syrma[m], new_one
20180210 21:40:05-!- Oebele [~quassel@143.177.58.202] has quit [Remote host closed the connection]
20180210 21:42:16-!- Netsplit over, joins: syrma[m], new_one
20180210 21:44:33-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has quit [Quit: .]
20180210 21:45:28-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20180210 21:45:28-!- vn971 [~vasya@94.158.103.15] has joined #wesnoth-dev
20180210 21:45:28-!- nurupo [~nurupo.ga@unaffiliated/nurupo] has joined #wesnoth-dev
20180210 21:45:33-!- syrma[m] [syrmamatri@gateway/shell/matrix.org/x-osslvpcnsjpjwcgh] has quit [Ping timeout: 256 seconds]
20180210 21:46:37-!- zacklocx[m] [zacklocxma@gateway/shell/matrix.org/x-uphgjivqrrfkfuhe] has quit [Ping timeout: 260 seconds]
20180210 21:46:40-!- nurupo [~nurupo.ga@unaffiliated/nurupo] has quit [Max SendQ exceeded]
20180210 21:46:59-!- nurupo [~nurupo.ga@unaffiliated/nurupo] has joined #wesnoth-dev
20180210 21:46:59-!- madmax28 [madmax28ma@gateway/shell/matrix.org/x-mesbdhrnepasjjrg] has quit [Ping timeout: 276 seconds]
20180210 21:47:00-!- ChipmunkV[m] [chipmunkvm@gateway/shell/matrix.org/x-oxuozvjkrttcuycq] has quit [Ping timeout: 276 seconds]
20180210 21:54:35-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer]
20180210 21:54:45-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20180210 22:16:15-!- travis-ci [~travis-ci@ec2-54-196-239-12.compute-1.amazonaws.com] has joined #wesnoth-dev
20180210 22:16:16< travis-ci> Pentarctagon/wesnoth#96 (cmake-mtime-md5 - 37b379b : pentarctagon): The build was fixed.
20180210 22:16:16< travis-ci> Build details : https://travis-ci.org/Pentarctagon/wesnoth/builds/339964299
20180210 22:16:16-!- travis-ci [~travis-ci@ec2-54-196-239-12.compute-1.amazonaws.com] has left #wesnoth-dev []
20180210 22:39:29-!- doofus-01 [~aristede@2601:647:5680:1530:c654:44ff:fe28:1054] has joined #wesnoth-dev
20180210 22:42:40< doofus-01> jyrkiVesterinen - I put the output in a gist link in a comment for c820009.  Not sure if all the needed info is there, probably not.
20180210 22:45:31< doofus-01> Running scons with --config=force doesn't change anything, aside from the '(cached)' note. 
20180210 22:47:42< doofus-01> Any suggestions appreciated.  Thanks.
20180210 22:47:49-!- doofus-01 [~aristede@2601:647:5680:1530:c654:44ff:fe28:1054] has quit [Quit: Konversation terminated!]
20180210 22:59:40-!- travis-ci [~travis-ci@ec2-54-159-247-54.compute-1.amazonaws.com] has joined #wesnoth-dev
20180210 22:59:41< travis-ci> Pentarctagon/wesnoth#97 (gcc-clang-fix - 67978fe : pentarctagon): The build passed.
20180210 22:59:41< travis-ci> Build details : https://travis-ci.org/Pentarctagon/wesnoth/builds/339970073
20180210 22:59:41-!- travis-ci [~travis-ci@ec2-54-159-247-54.compute-1.amazonaws.com] has left #wesnoth-dev []
20180210 23:03:08< irker280> wesnoth/wesnoth:master pentarctagon e0e7c56d93 Implement workaround for cmake using mti AppVeyor: All builds passed
20180210 23:07:45-!- syrma[m] [syrmamatri@gateway/shell/matrix.org/x-houmpdjxpovemfkn] has joined #wesnoth-dev
20180210 23:20:35< irker280> wesnoth: Charles Dang wesnoth:master b5b67830b367 / src/ (4 files in 2 dirs): Revert "Campaignd: rename addon list response config tags" https://github.com/wesnoth/wesnoth/commit/b5b67830b367b221c074028c297d08f29d9f80fc
20180210 23:20:38< irker280> wesnoth: Charles Dang wesnoth:master 782f68ca651c / src/addon/client.cpp: Fixup 84c0d2c9761e https://github.com/wesnoth/wesnoth/commit/782f68ca651c6cd8969a81a82d61a12908bba315
20180210 23:23:11-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 248 seconds]
20180210 23:27:45< irker280> wesnoth: Jyrki Vesterinen wesnoth:master a1e821fb953f / SConstruct: Fix release builds with Clang and SCons https://github.com/wesnoth/wesnoth/commit/a1e821fb953f401b5d7f23a7a5d4fa80cd367866
20180210 23:28:15-!- madmax28 [madmax28ma@gateway/shell/matrix.org/x-uaxjupynlofqrtqn] has joined #wesnoth-dev
20180210 23:28:15-!- ChipmunkV[m] [chipmunkvm@gateway/shell/matrix.org/x-bgdtlqspzipqrdfa] has joined #wesnoth-dev
20180210 23:28:16-!- zacklocx[m] [zacklocxma@gateway/shell/matrix.org/x-nxlnbhlzzoqpryko] has joined #wesnoth-dev
20180210 23:32:19< vultraz> celticminstrel: what's that >> thing?
20180210 23:32:22< vultraz> again
20180210 23:32:23< vultraz> the symbol
20180210 23:36:11< matthiaskrgr> bitwise right shift? 
20180210 23:36:30< vultraz> no the unicode character
20180210 23:36:35< matthiaskrgr> :( 
20180210 23:36:37< vultraz> >> text <<
20180210 23:36:39< matthiaskrgr> ooh
20180210 23:36:50< matthiaskrgr> bitwise quotes? :> 
20180210 23:36:51< vultraz> or perhaps <<text>>
20180210 23:37:27< irker280> wesnoth: Charles Dang wesnoth:master cb83a2234621 / changelog: Updated changelog https://github.com/wesnoth/wesnoth/commit/cb83a22346217d8c51f10e5fef2ad35e001cdb6e
20180210 23:37:30< irker280> wesnoth: Charles Dang wesnoth:master 7a7744c943c1 / data/gui/window/game_load.cfg: Game Load: some UI tweaks https://github.com/wesnoth/wesnoth/commit/7a7744c943c142265224a004f691f4c92fe05194
20180210 23:37:33< irker280> wesnoth: Charles Dang wesnoth:master b4c220260e4a / data/gui/window/mp_join_game.cfg: MP Join Game: increase gold icon and text size https://github.com/wesnoth/wesnoth/commit/b4c220260e4acbc66c5a06108a060543452ef00d
20180210 23:37:35< matthiaskrgr> aha!
20180210 23:37:36< matthiaskrgr> Guillemet 
20180210 23:37:38< matthiaskrgr> https://en.wikipedia.org/wiki/Guillemet 
20180210 23:37:53< matthiaskrgr> (or angle quotes)
20180210 23:37:59< vultraz> ah yes
20180210 23:38:00< vultraz> thanks
20180210 23:42:19< irker280> wesnoth: Nils Kneuper wesnoth:master 20d9735aa32f / / (18 files in 17 dirs): updated British English translation https://github.com/wesnoth/wesnoth/commit/20d9735aa32fdab44a264101317ecc23f305fb9d
20180210 23:46:37< vultraz> british english must be the easiest translation 
20180210 23:51:37-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180210 23:52:03-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
--- Log closed Sun Feb 11 00:00:03 2018