--- Log opened Sun Feb 11 00:00:03 2018
20180211 00:21:18-!- shadowm [~ignacio@wesnoth/developer/shadowm] has joined #wesnoth-dev
20180211 00:22:49< shadowm> elias: I'm having issues when trying to upload an add-on on Debian buster (Python 3.6.4) using wesnoth_addon_manager: https://pastebin.com/1BrQC1kW
20180211 00:23:14< shadowm> The .pbl file contains perfectly valid WML that the C++ client can read and successfully send to the server without any issues.
20180211 00:23:52< shadowm> elias: Okay, turns out this happens if I try to upload using . as the directory, instead of a named directory.
20180211 00:31:09-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180211 00:31:11-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20180211 00:31:15-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20180211 00:38:49< celticminstrel> vultraz: You mean » ?
20180211 00:39:08< celticminstrel> Pretty sure it's guillemot not guillemet...
20180211 00:39:51< celticminstrel> But why're you asking?
20180211 00:40:59< vultraz> was considering using it
20180211 00:41:07< celticminstrel> Not as quotes I hope
20180211 00:41:36< vultraz> no
20180211 00:41:39< vultraz> in place of bullets
20180211 00:41:45< celticminstrel> I see.
20180211 00:52:03< irker280> wesnoth: Charles Dang wesnoth:master f5a268d65f1b / src/hotkey/hotkey_handler_mp.cpp: MP: don't display both Pause and Continue Network Game menu entries at the same  https://github.com/wesnoth/wesnoth/commit/f5a268d65f1bf9b2c77e9fc65a4d275852fdbff7
20180211 01:02:58< irker280> wesnoth: Charles Dang wesnoth:master 7e00c618d2ee / src/gui/widgets/addon_list.cpp: GUI2/Addon List: don't assert if invalid id is passed to select_addon https://github.com/wesnoth/wesnoth/commit/7e00c618d2eede5400c79ac29b8a85c3c557bc3d
20180211 01:03:28-!- Bonobo [~Bonobo@61.68.156.44] has joined #wesnoth-dev
20180211 01:06:28-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer]
20180211 01:06:34-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20180211 01:09:56< irker280> wesnoth: Celtic Minstrel wesnoth:deprecation 04684fe697ca / / (6 files in 4 dirs): WIP deprecation stuff https://github.com/wesnoth/wesnoth/commit/04684fe697cadb7c1ceb1244ec92919f5571f097
20180211 01:09:58< irker280> wesnoth: Celtic Minstrel wesnoth:deprecation cf403a0d06fd / / (8 files in 4 dirs): Move deprecation to wesnoth-lib since the preprocessor will depend on it https://github.com/wesnoth/wesnoth/commit/cf403a0d06fd1e9a88a9cf46f2b44309e989c850
20180211 01:10:00< irker280> wesnoth: Celtic Minstrel wesnoth:deprecation 9c4890de2c00 / / (3 files in 2 dirs): Add #deprecated preprocessor directive for marking macros deprecated https://github.com/wesnoth/wesnoth/commit/9c4890de2c00f99c05e14014b450c587be75d6c9
20180211 01:10:02< irker280> wesnoth: Celtic Minstrel wesnoth:deprecation 763d741fbe06 / data/lua/core.lua src/deprecation.cpp: Add comment regarding the duplication of strings https://github.com/wesnoth/wesnoth/commit/763d741fbe06f1699370f9500a46eb47cca46298
20180211 01:10:04< irker280> wesnoth: Celtic Minstrel wesnoth:deprecation 5692e60819e0 / src/serialization/preprocessor.hpp: Fix potentially uninitialized deprecation level https://github.com/wesnoth/wesnoth/commit/5692e60819e05e78de27ee6f31ffde9088c32f03
20180211 01:10:06< irker280> wesnoth: Celtic Minstrel wesnoth:deprecation 0c9bc4b2d47f / src/formula/ (formula.cpp string_utils.cpp string_utils.hpp): Implement crude dynamic linking of the formula evaluation function https://github.com/wesnoth/wesnoth/commit/0c9bc4b2d47ff44891b6d9142a1fe57eec3c6eda
20180211 01:11:41-!- travis-ci [~travis-ci@ec2-54-145-38-152.compute-1.amazonaws.com] has joined #wesnoth-dev
20180211 01:11:42< travis-ci> shikadilord/wesnoth#23 (feature/campaignd-no-empty-pass - 802ef6a : Ignacio R. Morelle): The build has errored.
20180211 01:11:42< travis-ci> Build details : https://travis-ci.org/shikadilord/wesnoth/builds/340009417
20180211 01:11:42-!- travis-ci [~travis-ci@ec2-54-145-38-152.compute-1.amazonaws.com] has left #wesnoth-dev []
20180211 01:13:07< shadowm> Travis, can you not?
20180211 01:13:59< shadowm> Oh, maybe that job is for the original commit I pushed and then overwrote before submitting the pull request.
20180211 01:14:06-!- travis-ci [~travis-ci@ec2-54-145-38-152.compute-1.amazonaws.com] has joined #wesnoth-dev
20180211 01:14:07< travis-ci> shikadilord/wesnoth#21 (1.10 - c5b2b8a : Ignacio R. Morelle): The build passed.
20180211 01:14:07< travis-ci> Build details : https://travis-ci.org/shikadilord/wesnoth/builds/340009318
20180211 01:14:07-!- travis-ci [~travis-ci@ec2-54-145-38-152.compute-1.amazonaws.com] has left #wesnoth-dev []
20180211 01:14:19< celticminstrel> ...1.10?
20180211 01:14:43< shadowm> Eh, my fork was really far behind so I pushed all commits into it.
20180211 01:15:06< shadowm> I guess that means there was at least one commit to oldstable that wasn't in it.
20180211 01:22:13-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180211 01:22:19-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20180211 01:48:50< irker280> wesnoth/wesnoth:master pentarctagon d4d6d2d2e3 Add python3 package to the base docker i AppVeyor: All builds passed
20180211 02:17:15-!- travis-ci [~travis-ci@54.196.239.12] has joined #wesnoth-dev
20180211 02:17:16< travis-ci> shikadilord/wesnoth#24 (master - 20d9735 : Nils Kneuper): The build passed.
20180211 02:17:16< travis-ci> Build details : https://travis-ci.org/shikadilord/wesnoth/builds/340009831
20180211 02:17:16-!- travis-ci [~travis-ci@54.196.239.12] has left #wesnoth-dev []
20180211 02:29:43< irker280> wesnoth/wesnoth:master pentarctagon 996d284231 Adding a file test. AppVeyor: 1/2 builds failed
20180211 02:29:44< irker280> Details vs2017/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-master-1051
20180211 02:30:36< vultraz> celticminstrel: ping
20180211 02:31:40< celticminstrel> Pong.
20180211 02:31:58< vultraz> should we deprecate lua_function?
20180211 02:32:30< celticminstrel> Huh?
20180211 02:33:38< vultraz> https://wiki.wesnoth.org/StandardUnitFilter
20180211 02:33:52< vultraz> I was looking at https://github.com/wesnoth/wesnoth/issues/1374
20180211 02:34:01< vultraz> the issue reported no longer happens with the save given
20180211 02:34:03< vultraz> so i closed it
20180211 02:34:24< vultraz> but looking at the inspector, I saw that lua_code was used in [have_unit]
20180211 02:35:25< vultraz> (seems it's a valid SLF key too)
20180211 02:35:37< vultraz> but honestly, since we can now have custom conditional tags
20180211 02:35:43< celticminstrel> We shouldn't deprecate lua_function if there's something to take its place.
20180211 02:35:45< vultraz> and [lua] is accepted as a conditional tag
20180211 02:35:51< vultraz> is this necessary?
20180211 02:36:00< vultraz> to have?
20180211 02:36:07< celticminstrel> Custom conditional tags do you no good here.
20180211 02:36:18< celticminstrel> Conditional tags go in [if], [while], etc.
20180211 02:36:24< celticminstrel> This is a filter, not a conditional.
20180211 02:36:46< vultraz> hmmmmmm
20180211 02:36:47< vultraz> true...
20180211 02:37:23-!- travis-ci [~travis-ci@ec2-54-145-38-152.compute-1.amazonaws.com] has joined #wesnoth-dev
20180211 02:37:24< travis-ci> wesnoth/wesnoth#16408 (deprecation - 0c9bc4b : Celtic Minstrel): The build is still failing.
20180211 02:37:24< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/340012309
20180211 02:37:24-!- travis-ci [~travis-ci@ec2-54-145-38-152.compute-1.amazonaws.com] has left #wesnoth-dev []
20180211 02:37:24< vultraz> I dunno, the whole idea of `lua_function` just seems bad
20180211 02:37:40< vultraz> especially "Note that this is not actually interpreted as Lua code even though it superficially resembles it"
20180211 02:37:41< celticminstrel> If it's not broken, don't fix it?
20180211 02:37:48< celticminstrel> The major issue with it was already resolved.
20180211 02:38:05< celticminstrel> (That issue being that you could only reference functions directly from the global scope.)
20180211 02:38:19< vultraz> oh well
20180211 02:39:08< celticminstrel> It's true that there's a slight weirdness in the fact that it's split on "." and turned into a path, rather than being evaluated as Lua code, but someone (probably gfgtdf) felt that requiring it to be evaluated as Lua code would be a performance problem, so I went with this instead.
20180211 02:39:26< vultraz> I see
20180211 02:40:54< celticminstrel> It's super-low priority, but it'd be nice to support lua_function in side and weapon filters as well, to be consistent.
20180211 02:41:10< celticminstrel> All filters support formula, but only location and unit filters support lua_function.
20180211 02:41:10-!- hrubymar10 [~textual@ip-86-49-9-122.net.upcbroadband.cz] has quit [Ping timeout: 240 seconds]
20180211 02:43:22-!- travis-ci [~travis-ci@ec2-54-145-38-152.compute-1.amazonaws.com] has joined #wesnoth-dev
20180211 02:43:23< travis-ci> shikadilord/wesnoth#25 (feature/campaignd-no-empty-pass - a10e459 : Ignacio R. Morelle): The build passed.
20180211 02:43:23< travis-ci> Build details : https://travis-ci.org/shikadilord/wesnoth/builds/340010072
20180211 02:43:23-!- travis-ci [~travis-ci@ec2-54-145-38-152.compute-1.amazonaws.com] has left #wesnoth-dev []
20180211 02:47:29-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer]
20180211 02:47:42-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20180211 02:49:42-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20180211 02:50:11-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20180211 02:51:08-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20180211 02:53:42-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20180211 02:54:44< irker280> wesnoth: Charles Dang wesnoth:master 298b4486cd55 / changelog src/units/unit.cpp: Unit: serialize hidden= attribute https://github.com/wesnoth/wesnoth/commit/298b4486cd55b799c301461ed8e0e2da0858726c
20180211 02:59:28< vultraz> celticminstrel: this looks like something that might be problematic..was it fixed? https://github.com/wesnoth/wesnoth/issues/1405
20180211 02:59:42< vultraz> I seem to recall something about it?
20180211 03:00:54< celticminstrel> No idea.
20180211 03:00:59< celticminstrel> Test it and see?
20180211 03:03:16< vultraz> hm
20180211 03:03:19< vultraz> still seems to be an issue
20180211 03:03:24< vultraz> you made a commit addressing it
20180211 03:03:25< vultraz> https://github.com/wesnoth/wesnoth/commit/89e6aeee1627217ead8923f1a11c632d671ec53c
20180211 03:03:29< vultraz> doesn't seem to have worked :P
20180211 03:04:30< celticminstrel> You tested it? What did you test with?
20180211 03:04:47< vultraz> moveto event with [filter]id=""[/filter]
20180211 03:08:33< celticminstrel> Ah, that would be why.
20180211 03:08:43< celticminstrel> id="" and id= mean two different things.
20180211 03:08:54< celticminstrel> Or, wait, no.
20180211 03:09:16< vultraz> no?
20180211 03:09:17< celticminstrel> Whether they do or not, it's id="" that's supposed to match nothing...
20180211 03:09:36< celticminstrel> I can't remember whether id= means "empty string" or "blank value" though.
20180211 03:09:36< vultraz> std::string::empty() is true for ""
20180211 03:09:41< celticminstrel> Blank values are ignored.
20180211 03:09:53< vultraz> config_attribute_value::empty returns true for blank or empty values
20180211 03:09:57< vultraz> according to the docs
20180211 03:10:07< celticminstrel> In other words, blank() should return false in the case of id=""
20180211 03:10:18< vultraz> but the code checks empty()
20180211 03:10:27< celticminstrel> Which should mean the game searches for a unit with an ID that's the empty string.
20180211 03:10:46< celticminstrel> Um, the code used to check empty(), I changed it to blank() in that commit.
20180211 03:10:54< vultraz> now it checks empty again
20180211 03:11:00< vultraz> gfgtdf refactored the whole system
20180211 03:11:09< vultraz> 5/22/17
20180211 03:11:13< vultraz> you made your change
20180211 03:11:18< vultraz> 8/18/17
20180211 03:11:23< vultraz> gfgtdf refactors the unit filter system
20180211 03:11:24< celticminstrel> ...
20180211 03:11:29< celticminstrel> Well then put it back to blank.
20180211 03:11:56< vultraz> is that really the proper fix?
20180211 03:12:00< celticminstrel> Yes?
20180211 03:12:26< vultraz> this is now in common code used for many attributes
20180211 03:12:49< celticminstrel> Yes, all attributes should be ignored if blank().
20180211 03:13:02< vultraz> but they should try to match if empty?
20180211 03:13:08< celticminstrel> blank() generally means the attribute is not present at all.
20180211 03:13:53< celticminstrel> If empty, it likely means the attribute is present but had no value, which implies either that the designer did that deliberately or that a variable substitution failed.
20180211 03:14:01< vultraz> ok, switching it to blank() works
20180211 03:19:29< vultraz> good thing I noticed this
20180211 03:20:24< celticminstrel> Yup.
20180211 03:23:58< irker280> wesnoth: Charles Dang wesnoth:master edd6b8d31cb7 / changelog src/units/filter.cpp: Fixed most SUF keys matching all units if given "" as a value https://github.com/wesnoth/wesnoth/commit/edd6b8d31cb730a892308c745605c30dcaa804ce
20180211 03:24:01< irker280> wesnoth: Charles Dang wesnoth:master c5e95d3b2454 / src/gui/dialogs/multiplayer/lobby.cpp: MP Lobby: avoid unnecessary cache rebuild if no required addons were installed https://github.com/wesnoth/wesnoth/commit/c5e95d3b245411dfa5a8d722e0bd61f9d9635db5
20180211 03:26:08< celticminstrel> I kinda want to change the orc and goblin race descriptions a bit.
20180211 03:26:16< vultraz> do
20180211 03:26:33< celticminstrel> I'll open a PR, then.
20180211 03:27:18< celticminstrel> Ugh, github's editor is ridiculous.
20180211 03:28:00< celticminstrel> It wraps long lines, but you can't click in the wrapped section, and up/down navigates only through logical lines, so the only way to get into that wrapped section is with left/right keys...
20180211 03:32:17-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20180211 03:32:55-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 265 seconds]
20180211 03:33:17< irker280> wesnoth: Celtic Minstrel wesnoth:orc-descriptions ce73bf6cfc55 / data/core/units.cfg: Tweak the race descriptions of orcs and goblins https://github.com/wesnoth/wesnoth/commit/ce73bf6cfc558eb44164ca41b37376326d01e464
20180211 03:35:11< celticminstrel> ...why is the diff for the goblins not highlighting the changed words. :|
20180211 03:37:45< irker280> wesnoth: Sofartin wesnoth:master 90e693fdce5a / / (3 files in 3 dirs): Fixed Xcode project (#2450) https://github.com/wesnoth/wesnoth/commit/90e693fdce5a9be6d105c4e893d7f5740cf771af
20180211 03:38:35< celticminstrel> Oh, AI's gender branch was never merged, huh...
20180211 03:40:46< vultraz> we didn't like it 
20180211 03:40:58< celticminstrel> Really? Okay then.
20180211 03:41:19< celticminstrel> I can't really remember what I thought f it, but I definitely made a bunch of comments.
20180211 03:41:39< celticminstrel> But, y'know, if you've decided it's not gonna be merged for sure, you should at least close it.
20180211 03:42:43< vultraz> I hope I'm correct that strings handled via t_string::to/from_serialized are translated on the other side over the network..
20180211 03:43:08< celticminstrel> I have no idea...
20180211 03:43:23< vultraz> because I'm seeing that teamname^North bug again
20180211 03:43:27< vultraz> when observing a game
20180211 03:43:36< vultraz> i fixed that in MP Join Game by using the serialized stuff
20180211 03:43:40< vultraz> so, should probably do that here
20180211 03:43:43< celticminstrel> You should never send a translated string across the network.
20180211 03:44:04< celticminstrel> Send only what's needed for the remote client to look up the translated string.
20180211 03:44:09< vultraz> it doesn't work anyway
20180211 03:44:12< vultraz> sending translated strings
20180211 03:44:15< celticminstrel> ...of course, that's assuming the remote client can look up the translated string.
20180211 03:49:01-!- travis-ci [~travis-ci@ec2-23-20-101-24.compute-1.amazonaws.com] has joined #wesnoth-dev
20180211 03:49:02< travis-ci> wesnoth/wesnoth#16410 (master - 298b448 : Charles Dang): The build was broken.
20180211 03:49:02< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/340027649
20180211 03:49:02-!- travis-ci [~travis-ci@ec2-23-20-101-24.compute-1.amazonaws.com] has left #wesnoth-dev []
20180211 03:49:56-!- travis-ci [~travis-ci@ec2-23-20-101-24.compute-1.amazonaws.com] has joined #wesnoth-dev
20180211 03:49:57< travis-ci> wesnoth/wesnoth#16412 (orc-descriptions - ce73bf6 : Celtic Minstrel): The build was canceled.
20180211 03:49:57< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/340032637
20180211 03:49:57-!- travis-ci [~travis-ci@ec2-23-20-101-24.compute-1.amazonaws.com] has left #wesnoth-dev []
20180211 03:50:05< vultraz> looks like a travis issue
20180211 04:12:23< irker280> wesnoth: ancestral wesnoth:fix_map_trackpad_scrolling_on_unix 5ee034b14e8c / src/controller_base.cpp: Fixes event scrolling per issue #2218. UNIXes (namely, Linux and other non-Windo https://github.com/wesnoth/wesnoth/commit/5ee034b14e8c362dc1eaa4cbdb09811879635d1a
20180211 04:26:02< irker280> wesnoth: ancestral wesnoth:master 5ee034b14e8c / src/controller_base.cpp: Fixes event scrolling per issue #2218. UNIXes (namely, Linux and other non-Windo https://github.com/wesnoth/wesnoth/commit/5ee034b14e8c362dc1eaa4cbdb09811879635d1a
20180211 04:26:04< irker280> wesnoth: ancestral wesnoth:master 4bc437351b69 / src/controller_base.cpp: Merge pull request #2481 from wesnoth/fix_map_trackpad_scrolling_on_unix https://github.com/wesnoth/wesnoth/commit/4bc437351b69d52e920e1b7a335f87353ed83e01
20180211 04:40:30-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20180211 04:46:26-!- doofus-01 [~aristede@2601:647:5680:1530:c654:44ff:fe28:1054] has joined #wesnoth-dev
20180211 04:49:51< irker280> wesnoth: Charles Dang wesnoth:master 3496b1a6054a / src/ (team.cpp team.hpp): Team: save user_team_name as serialized https://github.com/wesnoth/wesnoth/commit/3496b1a6054a765e4f6b5a88af29649ce718dc42
20180211 04:51:11-!- travis-ci [~travis-ci@ec2-23-20-101-24.compute-1.amazonaws.com] has joined #wesnoth-dev
20180211 04:51:12< travis-ci> Pentarctagon/wesnoth#102 (master - 90e693f : Sofartin): The build was broken.
20180211 04:51:12< travis-ci> Build details : https://travis-ci.org/Pentarctagon/wesnoth/builds/340037197
20180211 04:51:12-!- travis-ci [~travis-ci@ec2-23-20-101-24.compute-1.amazonaws.com] has left #wesnoth-dev []
20180211 05:10:50-!- travis-ci [~travis-ci@ec2-23-20-101-24.compute-1.amazonaws.com] has joined #wesnoth-dev
20180211 05:10:51< travis-ci> wesnoth/wesnoth#16416 (fix_map_trackpad_scrolling_on_unix - 5ee034b : ancestral): The build failed.
20180211 05:10:51< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/340037830
20180211 05:10:51-!- travis-ci [~travis-ci@ec2-23-20-101-24.compute-1.amazonaws.com] has left #wesnoth-dev []
20180211 05:11:28-!- travis-ci [~travis-ci@ec2-54-163-186-22.compute-1.amazonaws.com] has joined #wesnoth-dev
20180211 05:11:29< travis-ci> wesnoth/wesnoth#16414 (master - 90e693f : Sofartin): The build was broken.
20180211 05:11:29< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/340033209
20180211 05:11:29-!- travis-ci [~travis-ci@ec2-54-163-186-22.compute-1.amazonaws.com] has left #wesnoth-dev []
20180211 05:22:25-!- travis-ci [~travis-ci@ec2-23-20-101-24.compute-1.amazonaws.com] has joined #wesnoth-dev
20180211 05:22:26< travis-ci> Pentarctagon/wesnoth#103 (gcc-clang-fix - d94b8a9 : pentarctagon): The build was broken.
20180211 05:22:26< travis-ci> Build details : https://travis-ci.org/Pentarctagon/wesnoth/builds/340037619
20180211 05:22:26-!- travis-ci [~travis-ci@ec2-23-20-101-24.compute-1.amazonaws.com] has left #wesnoth-dev []
20180211 05:29:53< irker280> wesnoth: Charles Dang wesnoth:master 8cc12a45798e / src/gui/dialogs/multiplayer/lobby.cpp: MP Lobby: fixed broken formatting in Incompatible UMC prompt (fixes #2483) https://github.com/wesnoth/wesnoth/commit/8cc12a45798e12ca30b6296f3dfd0d83c4b483a1
20180211 06:45:21-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has joined #wesnoth-dev
20180211 07:14:07-!- travis-ci [~travis-ci@ec2-54-163-186-22.compute-1.amazonaws.com] has joined #wesnoth-dev
20180211 07:14:08< travis-ci> wesnoth/wesnoth#16421 (master - 8cc12a4 : Charles Dang): The build failed.
20180211 07:14:08< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/340046964
20180211 07:14:08-!- travis-ci [~travis-ci@ec2-54-163-186-22.compute-1.amazonaws.com] has left #wesnoth-dev []
20180211 07:24:16< JyrkiVesterinen> We have 13 WML unit tests failing.
20180211 07:24:26< JyrkiVesterinen> We can't release the beta at this state.
20180211 07:26:02< JyrkiVesterinen> Regressing commit. https://github.com/wesnoth/wesnoth/commit/298b4486cd55b799c301461ed8e0e2da0858726c
20180211 07:45:10< celticminstrel> Well, one thing I can see wrong with that commit (which might be the cause of the test failures) is that Vultraz did not add the new key to the list of known unit keys.
20180211 07:47:40-!- celticminstrel is now known as celmin|sleep
20180211 08:22:27-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20180211 08:29:58< JyrkiVesterinen> 20180211 10:25:53 warning unit: Unknown attribute 'hidden' discarded.
20180211 08:30:05< JyrkiVesterinen> Looks like that's indeed the cause.
20180211 08:30:06-!- irker280 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20180211 08:30:24< JyrkiVesterinen> (Travis runs WML unit tests with --log-strict=warning.)
20180211 08:31:07-!- irker505 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20180211 08:31:07< irker505> wesnoth: Charles Dang wesnoth:master 286415a403e1 / src/ (team.cpp team.hpp): Revert "Team: save user_team_name as serialized" https://github.com/wesnoth/wesnoth/commit/286415a403e1d611e62785b972fcd43a8b65d8f3
20180211 08:31:08< irker505> wesnoth: Charles Dang wesnoth:master e826dc70040b / src/units/unit.cpp: Fixup 298b448 (format valid key list and added hidden to it) https://github.com/wesnoth/wesnoth/commit/e826dc70040b91048dc0b35dc7d43a72d71d7887
20180211 08:31:09< vultraz> fixed
20180211 08:33:13-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has quit [Quit: Rebooting]
20180211 08:37:41-!- JyrkiVesterinen [~jyrki@85-23-197-3.bb.dnainternet.fi] has joined #wesnoth-dev
20180211 08:46:13< irker505> wesnoth: pentarctagon wesnoth:master bdd5089dd74d / SConstruct: CC should be checked for gcc, not CXX. https://github.com/wesnoth/wesnoth/commit/bdd5089dd74d7429a1bf045c7d1dc38f6cbc1c31
20180211 08:47:43-!- JyrkiVesterinen [~jyrki@85-23-197-3.bb.dnainternet.fi] has quit [Quit: Rebooting]
20180211 08:49:21-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has joined #wesnoth-dev
20180211 09:10:37-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20180211 09:14:49-!- hrubymar10 [~textual@ip-86-49-9-122.net.upcbroadband.cz] has joined #wesnoth-dev
20180211 09:18:26-!- travis-ci [~travis-ci@ec2-23-20-101-24.compute-1.amazonaws.com] has joined #wesnoth-dev
20180211 09:18:27< travis-ci> wesnoth/wesnoth#16422 (master - e826dc7 : Charles Dang): The build was fixed.
20180211 09:18:28< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/340070137
20180211 09:18:28-!- travis-ci [~travis-ci@ec2-23-20-101-24.compute-1.amazonaws.com] has left #wesnoth-dev []
20180211 09:47:57< irker505> wesnoth: Charles Dang wesnoth:master 5684b7fd43ed / src/gui/dialogs/multiplayer/mp_staging.cpp: MP Staging: adjust gold and income slider bounds if side-given value falls outsi https://github.com/wesnoth/wesnoth/commit/5684b7fd43ed788ca5025162478bbe00af4d68b8
20180211 09:49:53-!- travis-ci [~travis-ci@ec2-54-145-38-152.compute-1.amazonaws.com] has joined #wesnoth-dev
20180211 09:49:54< travis-ci> wesnoth/wesnoth#16423 (master - bdd5089 : pentarctagon): The build was fixed.
20180211 09:49:54< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/340071960
20180211 09:49:54-!- travis-ci [~travis-ci@ec2-54-145-38-152.compute-1.amazonaws.com] has left #wesnoth-dev []
20180211 10:06:23< irker505> wesnoth: Sofartin wesnoth:master 940cd3a781e8 / projectfiles/Xcode/Wesnoth.xcodeproj/project.pbxproj: Remove duplicated headers search path https://github.com/wesnoth/wesnoth/commit/940cd3a781e896c609c0d7e8cf2bdf7b74df6a9c
20180211 10:31:31-!- Oebele [~quassel@143.177.58.202] has joined #wesnoth-dev
20180211 10:56:11-!- hrubymar10 [~textual@ip-86-49-9-122.net.upcbroadband.cz] has quit [Quit: hrubymar10]
20180211 11:24:09-!- Nobun [~user@5.170.243.254] has joined #wesnoth-dev
20180211 11:31:38-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has quit [Quit: .]
20180211 11:49:18-!- DeFender1031 [~DeFender1@93-172-141-41.bb.netvision.net.il] has quit [Ping timeout: 265 seconds]
20180211 12:10:15-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20180211 12:10:58-!- doofus-01 [~aristede@2601:647:5680:1530:c654:44ff:fe28:1054] has quit [Remote host closed the connection]
20180211 12:22:39< irker505> wesnoth: Ignacio R. Morelle wesnoth:master 5ed3810bd588 / changelog src/campaign_server/campaign_server.cpp: campaignd: Reject empty passphrases https://github.com/wesnoth/wesnoth/commit/5ed3810bd588ef7162ffad6ca5128100525f4542
20180211 12:45:41-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has joined #wesnoth-dev
20180211 13:33:31-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer]
20180211 13:33:37-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20180211 14:19:39-!- stikonas_ is now known as stikonas
20180211 14:40:25< loonycyborg> Soliton: about that my last patch: is sending diff about the game to players that were in game the only issue with it?
20180211 14:41:48< loonycyborg> I think it will be kinda hard to avoid it
20180211 14:42:03< loonycyborg> without adding third multi-index state for some somehow
20180211 14:42:12< loonycyborg> that they're not in game nor in lobby
20180211 14:43:14< loonycyborg> because the way constraints in multi-index work would prevent triggering cleanup while there are still players in the game
20180211 14:43:38< loonycyborg> maybe it's better to make the client expect that diff?
20180211 15:07:59-!- Nobun [~user@5.170.243.254] has quit [Quit: see you later... perhaps...]
20180211 15:09:37< irker505> wesnoth: loonycyborg wesnoth:master 8fd4e61bde7f / src/server/server.cpp: Revert "Wesnothd: fixed outdated game list being erroneously sent to clients on  https://github.com/wesnoth/wesnoth/commit/8fd4e61bde7fe3e3c232fe56cbc7a65a9ecfb472
20180211 15:09:39< irker505> wesnoth: loonycyborg wesnoth:master 7e5ee60282ad / src/server/server.cpp: Attempted to fix outdated game list issue in a different way https://github.com/wesnoth/wesnoth/commit/7e5ee60282ad0483eae8ea48fcaceed708b097b0
20180211 15:09:52< loonycyborg> vultraz: ^^
20180211 15:10:20< vultraz> I’ll test tomorrow
20180211 15:10:26< loonycyborg> I tested that using many clients connected to local server
20180211 15:10:42< loonycyborg> but perhaps I didn't catch some use cases still
20180211 15:11:07< loonycyborg> also I got non-fatal error about invalid diff
20180211 15:11:18< loonycyborg> so probably will need more work yet
20180211 15:12:21< vultraz> As long as the flash doesn’t show up it’s fine
20180211 15:21:01< JyrkiVesterinen> Errors showing up in the logs are NOT fine.
20180211 15:32:08< Soliton> loonycyborg: that is still the same change you showed yesterday, no?
20180211 15:32:44< Soliton> a little frustrating to see when i explained the issue at length.
20180211 15:36:27< Soliton> slightly less frustrating than the treatment of issue 2473 though.
20180211 15:41:33-!- DeFender1031 [~DeFender1@46-116-68-9.bb.netvision.net.il] has joined #wesnoth-dev
20180211 15:41:47< loonycyborg> well it's all I got atm, committed it mostly to let vultraz to test it
20180211 15:42:18< Soliton> i don't need to test that to see that it's not going to change anything.
20180211 15:42:57< Soliton> you're not changing games_and_users_list_ and just do the sending in a for loop instead of via the game which is basically the same thing.
20180211 15:43:55< loonycyborg> the change here is that deleter of game is invoked before those loops
20180211 15:44:25< loonycyborg> I changed them to loops to eliminate game in variable
20180211 15:44:56< Soliton> well, perhaps i'm blind but i cannot see that.
20180211 15:45:07< loonycyborg> that deleter removes the game from games_and_users_list
20180211 15:45:44< Soliton> because you're not copying the shared_ptr?
20180211 15:46:31< loonycyborg> that too
20180211 15:46:34< loonycyborg> https://github.com/wesnoth/wesnoth/blob/7e5ee60282ad0483eae8ea48fcaceed708b097b0/src/server/server.cpp#L2700
20180211 15:46:47< loonycyborg> this removes all references to that game 
20180211 15:46:54< loonycyborg> and causes it to be destructed
20180211 15:47:00< loonycyborg> and cleanup_game to be called
20180211 15:47:13< Soliton> and that's so obvious you didn't think it'd need some kind of comment?
20180211 15:50:37< loonycyborg> I'm not sure, which comment and where?
20180211 15:51:51< loonycyborg> // Put the remaining users back in the lobby.
20180211 15:52:19< Soliton> the line you posted above. who's going to understand that it somehow deletes a game?
20180211 15:56:54< loonycyborg> I can extend this comment
20180211 15:58:30< Soliton> it's quite unfortunate if one has to be intimately familier with boost::multi_index and shared_ptr abuse to understand how the server works now. :-(
20180211 16:00:41< loonycyborg> yeah, but at least some constraints about users and games are automatically enforced now
20180211 16:01:59< Soliton> that's certainly great but it's not dependent on writing difficult to maintain code.
20180211 16:03:23< irker505> wesnoth: loonycyborg wesnoth:master e22c812efe7d / src/server/server.cpp: Extend comment to clarify delete_game() https://github.com/wesnoth/wesnoth/commit/e22c812efe7d74629033d851df7a494bfb8fa360
20180211 16:04:36< Soliton> so players own games now, yes?
20180211 16:05:05< loonycyborg> hmm not exactly
20180211 16:05:14< Soliton> oh boy.
20180211 16:05:40< loonycyborg> that multi-index is basically triplets of socket<->player<->shared_pointer to game
20180211 16:06:08< Soliton> please write some overview description on how the multi_index stuff works now.
20180211 16:06:12< irker505> wesnoth: mattsc wesnoth:master 85b46f34b066 / data/ai/micro_ais/cas/ca_fast_combat.lua: Fast Micro AI: make code robust against events removing units https://github.com/wesnoth/wesnoth/commit/85b46f34b066580aab1e8fb3b6e9ea7ba108ad8c
20180211 16:06:39< loonycyborg> thus deleting a game is basically making all records point to lobby instead of that game
20180211 16:06:42< Soliton> perhaps in the server class description or whereever you think it fits and people will find it.
20180211 16:06:49< loonycyborg> and it automatically takes care of cleaning it up
20180211 16:07:19< loonycyborg> probably somewhere in player_connections.?pp
20180211 16:08:58< Soliton> i'm not a fan but i guess it's where it belongs currently.
20180211 16:11:41< Soliton> do you have to use the modify() function there btw? can that not be written with a much more obvious function call?
20180211 16:16:57-!- Bonobo [~Bonobo@61.68.156.44] has quit [Ping timeout: 240 seconds]
20180211 16:18:00< loonycyborg> nope, having it done from modify is the only way to get writeable copy
20180211 16:18:07< loonycyborg> so it could enforce contraints
20180211 16:22:57< Soliton> can we at least not hide the multi_index stuff in player_connection.?pp?
20180211 16:24:50< Soliton> well, just hpp. there is nothing of it in the cpp.
20180211 16:26:56< loonycyborg> you mean it should be in server.cpp or hpp?
20180211 16:26:58< loonycyborg> or where?
20180211 16:27:12< Soliton> server.hpp, yes.
20180211 16:29:45< loonycyborg> I already forgot details but iirc I made it in part to break some #include loops
20180211 16:48:27-!- celmin|sleep is now known as celticminstrel
20180211 16:49:34-!- Ivanovic_ [~ivanovic@p579FBA67.dip0.t-ipconnect.de] has joined #wesnoth-dev
20180211 16:49:34-!- Ivanovic_ [~ivanovic@p579FBA67.dip0.t-ipconnect.de] has quit [Changing host]
20180211 16:49:34-!- Ivanovic_ [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev
20180211 16:51:21-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Ping timeout: 263 seconds]
20180211 16:51:32-!- Ivanovic_ is now known as Ivanovic
20180211 16:53:11< irker505> wesnoth: Celtic Minstrel wesnoth:orc-descriptions 2eda1c0a3c91 / data/core/units.cfg: Further tweak to orc description https://github.com/wesnoth/wesnoth/commit/2eda1c0a3c9116e8a262641f7e1fb876396f89eb
20180211 17:00:47-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180211 17:00:59-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20180211 17:20:58-!- vultraz [uid24821@wesnoth/developer/vultraz] has quit [Quit: Connection closed for inactivity]
20180211 17:42:01-!- travis-ci [~travis-ci@ec2-54-163-186-22.compute-1.amazonaws.com] has joined #wesnoth-dev
20180211 17:42:02< travis-ci> wesnoth/wesnoth#16433 (orc-descriptions - 2eda1c0 : Celtic Minstrel): The build failed.
20180211 17:42:02< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/340175942
20180211 17:42:02-!- travis-ci [~travis-ci@ec2-54-163-186-22.compute-1.amazonaws.com] has left #wesnoth-dev []
20180211 17:44:11-!- octalot [~steve@91.141.0.93.wireless.dyn.drei.com] has joined #wesnoth-dev
20180211 18:30:09-!- TadCarlucci [~lundberg@74.193.219.119] has quit [Remote host closed the connection]
20180211 18:31:19-!- TadCarlucci [~lundberg@74.193.219.119] has joined #wesnoth-dev
20180211 19:29:53< zookeeper> celticminstrel, side from that typo fix, what's with the other changes in that branch? why would you change the expressive original wordings to... well, to something much more bland and sterile?
20180211 19:29:57< zookeeper> s/side/aside
20180211 19:30:55< zookeeper> i mean, how is "orcs resemble humans but with some bestial features" better than "orcs are half men and half beasts"?
20180211 19:33:12< celticminstrel> Calling them half beast sounds both demeaning and misleading.
20180211 19:34:07< celticminstrel> To be fair, I'm not entirely satisfied with my replacement, either.
20180211 19:34:27< celticminstrel> Did you have problems with the goblin description change?
20180211 19:34:42< zookeeper> how is it misleading? i have no idea what's the problem with being demeaning.
20180211 19:35:07< celticminstrel> It could lead someone to believe they're actually half beast.
20180211 19:35:10< celticminstrel> Which isn't the case.
20180211 19:36:09< zookeeper> so what exactly do you take "half beast" to mean, then?
20180211 19:37:07< celticminstrel> I'm not even entirely sure, which perhaps is also a problem.
20180211 19:37:21< zookeeper> maybe! :D
20180211 19:39:52< zookeeper> well, i do think that "true orcs" is a bit more expressive and flavorful than "standard orcs"
20180211 19:40:54< celticminstrel> But it implies that the archers are not true orcs, which is just bizarre.
20180211 19:45:51< zookeeper> it's not supposed to be taken scientifically and literally
20180211 19:49:03< zookeeper> it's not saying that taxonomically they're not orcs, it's saying that they're relatively weak and insignificant and certainly not as feared and respected as the big ones.
20180211 19:51:29-!- vultraz [uid24821@wesnoth/developer/vultraz] has joined #wesnoth-dev
20180211 19:53:37-!- irker505 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20180211 20:09:50< vultraz> celticminstrel: i actually prefer one-per-line formatting in those cases
20180211 20:15:55< celticminstrel> Oh right I had to respond to zookeeper 
20180211 20:16:33< celticminstrel> I get the general idea of what you're saying, but IMO "standard" conveys this jsut as well as "true" but without the implication that the others aren't really orcs.
20180211 20:16:42< celticminstrel> ^just
20180211 20:20:11< vultraz> careful, talk like that would trigger the alt-right :P
20180211 20:21:35< celticminstrel> I have no idea what you're talking about.
20180211 20:23:50< vultraz> I got the impression your changes to the description were to avoid implications of certain possibly troubling identity and/or racial parallels
20180211 20:24:30< celticminstrel> Something like that?
20180211 20:24:55< vultraz> you know the alt-right hates that "SJW crap" :P
20180211 20:25:31< vultraz> (and for the record for anyone that doesn't get it, pissing off the alt-right is good)
20180211 20:25:39< celticminstrel> Well, I don't really care about triggering them. It's not possible to avoid, anyway.
20180211 20:25:44< celticminstrel> Unless you're one of them obviously.
20180211 20:26:11< celticminstrel> Whether openly or not.
20180211 20:26:22< JyrkiVesterinen> A video game isn't the right place to be intentionally triggering political groups.
20180211 20:26:34< JyrkiVesterinen> Decisions should be made from the POV of entertainment alone.
20180211 20:26:49< celticminstrel> Yeah, I wouldn't intentionally trigger them.
20180211 20:26:57< celticminstrel> But nor would I worry about accidentally triggering them.
20180211 20:27:04< JyrkiVesterinen> Agreed.
20180211 21:02:39< zookeeper> point is, "true orcs" _also_ subtly tells you something about how orcs (or other races too) think about them[selves], whereas "standard orcs" doesn't.
20180211 21:06:46< zookeeper> it hints at common in-universe attitudes, which is good.
20180211 21:12:53< celticminstrel> Hmm.
20180211 21:13:42< celticminstrel> The only other possibility I can think of right now is "normal orcs"...
20180211 21:14:51< zookeeper> i mean, if you have in-game lore like race descriptions, you want it to have at least a slightly in-universe tone to it, doubly so when it's a fantasy setting.
20180211 21:18:33< octalot> "strong orcs"?
20180211 21:19:27< zookeeper> i really don't understand how you can consider the words "true orcs" to be potentially genuinely confusing to someone (for any other reason than them just not understanding english perfectly). it seems like a very simple and straightforward metaphorical expression to me.
20180211 21:20:01< celticminstrel> IIRC it was the other thing I changed that I found to be misleading.
20180211 21:20:09< celticminstrel> What was it again...
20180211 21:20:35< zookeeper> oh, "half-orcs" -> "smaller orcs"
20180211 21:20:37< celticminstrel> Oh yeah, the reference to "half-orcs".
20180211 21:20:46< celticminstrel> Yeah.
20180211 21:25:03< octalot> Among other races, descriptions of orcs generally come from soldiers who fought against them, and so the description of the strongest warriors becomes the stereotype of the race; a fact which pleases any orc who is strong enough to be included in that definition.
20180211 21:26:31-!- irker407 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20180211 21:26:31< irker407> wesnoth: Celtic Minstrel wesnoth:orc-descriptions 839366ca913f / data/core/units.cfg: Revert true->standard change https://github.com/wesnoth/wesnoth/commit/839366ca913fba4e53b4514402639bce1839cdc6
20180211 21:26:47< irker407> wesnoth: Celtic Minstrel wesnoth:deprecation cbd72e937d95 / src/scripting/ (lua_common.cpp lua_common.hpp): Utility function that I didn't end up using but which could be useful elsewhere https://github.com/wesnoth/wesnoth/commit/cbd72e937d95eafc188601bf50de7eb29d8c6cf0
20180211 21:26:49< irker407> wesnoth: Celtic Minstrel wesnoth:deprecation 8d88d6bf8883 / data/lua/core.lua src/formula/formula.cpp: Fix deprecation messages not being logged https://github.com/wesnoth/wesnoth/commit/8d88d6bf8883303881a9835688f030406aa207cb
20180211 21:26:51< irker407> wesnoth: Celtic Minstrel wesnoth:deprecation d94c9fb78678 / data/campaigns/ (27 files in 2 dirs): Remove MAGENTA_IS_THE_TEAM_COLOR from UtBS units and Dwarvish Witness line https://github.com/wesnoth/wesnoth/commit/d94c9fb786784ebb0d839582aa43153f049a31bd
20180211 21:26:53< irker407> wesnoth: Celtic Minstrel wesnoth:deprecation 37bf0e005e3e / src/serialization/preprocessor.cpp: Fix deprecated macro messages being incorrectly registered https://github.com/wesnoth/wesnoth/commit/37bf0e005e3e16d20cc851854fc879b94c56e68a
20180211 21:28:45< celticminstrel> Those interested, please review PR 2297 (the deprecation stuff).
20180211 21:28:50< celticminstrel> DeFender1031: ^
20180211 21:29:13< celticminstrel> (Not asking for a review specifically from you, just pointing it out in case you want to take a look.)
20180211 21:37:16< DeFender1031> Thanks, celticminstrel 
20180211 21:38:40< DeFender1031> At the moment, I'm more interested in what they do than the actual code for doing them. I assume it's just simple functions in each language that takes some kind of message, deprecation level like the ones I wrote up a while ago, and version since when whatever the thing is has been deprecated?
20180211 21:38:52< celticminstrel> That PR adds:
20180211 21:39:11< celticminstrel> - a deprecated_message() function to C++ which basically does the same as the Lua wesnoth.deprecated_message() function
20180211 21:39:35< celticminstrel> - a #deprecate preprocessor directive which can be used to deprecate macros or files.
20180211 21:41:24< DeFender1031> and the parameters that each of them take?
20180211 21:41:36< vultraz> "Remove MAGENTA_IS_THE_TEAM_COLOR from UtBS units and Dwarvish Witness line" can be cherry picked regardles
20180211 21:43:09< celticminstrel> True.
20180211 21:43:31< celticminstrel> DeFender1031: #deprecate <level> [<version>] <message>
20180211 21:43:57< celticminstrel> The version should be included for level 2 or 3 and omitted for 1 or 4 (if included in that case, it's treated as part of the message).
20180211 21:43:57< DeFender1031> celticminstrel, yeah, then that sounds about right.
20180211 21:44:15< celticminstrel> I think the arguments to the C++ function were the same as for the Lua function.
20180211 21:44:17< vultraz> in fact I'll do it now
20180211 21:44:24< celticminstrel> vultraz: Sure whatever.
20180211 21:44:32 * DeFender1031 has to go back to his writeup to see why that makes sense...
20180211 21:46:30< DeFender1031> Ah, right.
20180211 21:46:31< irker407> wesnoth: Celtic Minstrel wesnoth:master e0e1f7ac6b17 / data/campaigns/ (27 files in 2 dirs): Remove MAGENTA_IS_THE_TEAM_COLOR from UtBS units and Dwarvish Witness line https://github.com/wesnoth/wesnoth/commit/e0e1f7ac6b1790d3c1ae2ea991f6f152914b8e26
20180211 21:47:41< DeFender1031> Well, level 4 probably won't really be used in practice, since it means "the thing is actually gone", though if we're keeping skeletons of removed features that do nothing but report that they're gone and then error out, then I suppose that it could make some amount of sense.
20180211 21:48:17< DeFender1031> And level 1 doesn't need a version because they'll never be removed without something else of level 2 significance overriding them anyway.
20180211 21:48:20< celticminstrel> True, level 4 will be rarely used.
20180211 21:48:24< DeFender1031> level 2 or higher.
20180211 21:48:32< celticminstrel> Hm?
20180211 21:48:38< celticminstrel> Oh.
20180211 21:48:41< DeFender1031> **
20180211 21:48:46< celticminstrel> "something else of level 2 or higher significance"
20180211 21:48:49< DeFender1031> right
20180211 21:49:11< DeFender1031> that "level 2" was supposed to be "level 2 or higher" and then than "." was supposed to be a "*".
20180211 21:49:52< celticminstrel> ...I have no idea what you mean by the . -> * bit.
20180211 21:51:54< DeFender1031> I am typing the wrong thing.
20180211 21:51:56< DeFender1031> right thing*
20180211 21:52:05< DeFender1031> ^^^like that
20180211 21:52:15< Soliton> typo fixception
20180211 21:52:17< DeFender1031> I meant it to be a correction, not a standalone sentence.
20180211 21:52:51< DeFender1031> (When DID people who use chat decide that * means typo correction anyway?)
20180211 21:52:57< Soliton> sometimes it's more confusing to try to correct a typo. :-P
20180211 21:53:11< DeFender1031> Soliton, only if you typo the correction too :P
20180211 21:53:55< celticminstrel> Oh, now I see what you mean.
20180211 21:54:16< celticminstrel> I don't know why people use * to correct typos. I generally use ^ instead.
20180211 22:00:46< DeFender1031> that usually means "look up there" though...
20180211 22:01:11< celticminstrel> It also resembles the "insertion" mark used by copy-editors though?
20180211 22:01:21< DeFender1031> hmm... legit.
20180211 22:01:45< celticminstrel> Admittedly the corrections aren't always an insertion, but whatever.
20180211 22:07:55-!- Oebele [~quassel@143.177.58.202] has quit [Remote host closed the connection]
20180211 22:09:23-!- octalot [~steve@91.141.0.93.wireless.dyn.drei.com] has quit [Ping timeout: 276 seconds]
20180211 22:11:57-!- octalot [~steve@178.165.130.195.wireless.dyn.drei.com] has joined #wesnoth-dev
20180211 22:12:41-!- travis-ci [~travis-ci@ec2-54-145-38-152.compute-1.amazonaws.com] has joined #wesnoth-dev
20180211 22:12:42< travis-ci> wesnoth/wesnoth#16435 (orc-descriptions - 839366c : Celtic Minstrel): The build is still failing.
20180211 22:12:42< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/340256877
20180211 22:12:42-!- travis-ci [~travis-ci@ec2-54-145-38-152.compute-1.amazonaws.com] has left #wesnoth-dev []
20180211 22:20:49< Soliton> TadCarlucci: how does the codacy stuff work, do you need to trigger it manually or does it automatically run on all PRs or so?
20180211 22:53:59< vn971> If build server is slow, you may skip tests for this one. https://github.com/wesnoth/wesnoth/pull/2490
20180211 22:56:03-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has quit [Quit: .]
20180211 22:56:32< TadCarlucci> Soliton, It runs automatically. It triggers for PRs and direct pushes to my personal fork. It can take an hour or four to notice a direct push to wesnoth/master
20180211 22:57:13-!- travis-ci [~travis-ci@ec2-54-163-186-22.compute-1.amazonaws.com] has joined #wesnoth-dev
20180211 22:57:14< travis-ci> wesnoth/wesnoth#16437 (deprecation - 37bf0e0 : Celtic Minstrel): The build is still failing.
20180211 22:57:14< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/340256978
20180211 22:57:14-!- travis-ci [~travis-ci@ec2-54-163-186-22.compute-1.amazonaws.com] has left #wesnoth-dev []
20180211 22:57:43< Soliton> alright, great.
20180211 23:11:28< irker407> wesnoth: V N wesnoth:master 019330284728 / data/tools/wesnoth_addon_manager: addon_manager: fix default ign file https://github.com/wesnoth/wesnoth/commit/0193302847280777a4ece763ae44b0b5db2990cb
20180211 23:24:24-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 260 seconds]
20180211 23:31:30< TadCarlucci> Soliton, I consider Coverity still "under test". We don't do much which it dislikes. Most of the current problems are in the Python and Java parts. So I'm waiting for people who do things it comments on, to see if it helps or they ignore it.
20180211 23:32:35< vultraz> celticminstrel: ETA on deprecation stuff?
20180211 23:33:12< celticminstrel> vultraz: I can probably merge it whenever you want it, but I was sorta hoping for some code review first.
20180211 23:33:21< vultraz> also, https://github.com/wesnoth/wesnoth/pull/993
20180211 23:33:26< vultraz> (Lua generator)
20180211 23:33:31< celticminstrel> Basically all I need to do is rebase it to squash some of the commits.
20180211 23:34:06< celticminstrel> The Lua map generator PR still has a lot of problems (as noted in Sigurd's comment), so I wouldn't be confident about merging it.
20180211 23:34:12< vultraz> alright
20180211 23:34:15< vultraz> postpone to 1.15?
20180211 23:34:32< vultraz> or 1.14.1
20180211 23:34:39< celticminstrel> Hmm.
20180211 23:35:09< celticminstrel> Well, first of all, I wouldn't mark it as postponed until 1.13.11 is actually released.
20180211 23:35:29< celticminstrel> Once 1.13.11 is released, we're on string freeze, right? So that would mean it can't be merged until after 1.14.0.
20180211 23:35:31< vultraz> I'm not going to hold off 1.13.11 for it
20180211 23:35:39< celticminstrel> Of course not.
20180211 23:35:40< vultraz> unless it's done now
20180211 23:35:47< vultraz> or within a day
20180211 23:36:06< celticminstrel> Yeah, it's not likely to be done within a day, I guess. If I got back to it it'd be most likely next weekend.
20180211 23:36:11-!- travis-ci [~travis-ci@ec2-54-163-186-22.compute-1.amazonaws.com] has joined #wesnoth-dev
20180211 23:36:12< travis-ci> Pentarctagon/wesnoth#104 (master - 0193302 : V N): The build was canceled.
20180211 23:36:12< travis-ci> Build details : https://travis-ci.org/Pentarctagon/wesnoth/builds/340285720
20180211 23:36:12-!- travis-ci [~travis-ci@ec2-54-163-186-22.compute-1.amazonaws.com] has left #wesnoth-dev []
20180211 23:36:54< vultraz> some stuff could maybe be cherrypicked
20180211 23:36:56< vultraz> like "Lua GUI2: Support sliders in set_dialog_callback"
20180211 23:36:57< celticminstrel> (At the earliest, I mean.)
20180211 23:37:14< celticminstrel> That might've actually been cherry-picked already.
20180211 23:37:56-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20180211 23:38:06< vultraz> doesn't seem to be
20180211 23:38:16< celticminstrel> In my opinion it could probably go in 1.14.1, but I'd like to get a second opinion on that as well.
20180211 23:38:39< vultraz> ok. postponing it
20180211 23:39:33< vultraz> get deprecation in
20180211 23:39:40< vultraz> deal with those orc/gobo descriptions
20180211 23:41:49-!- Bonobo [~Bonobo@61.68.156.44] has joined #wesnoth-dev
20180211 23:47:44< irker407> wesnoth: pentarctagon wesnoth:master acc0b6a1f1f3 / cmake_mtime_crc.py docker/Dockerfile-travis docker_run.sh: Implement workaround for cmake using mtime to determine what to rebuild. https://github.com/wesnoth/wesnoth/commit/acc0b6a1f1f3292f9bc899d47160c457cc0e91da
20180211 23:47:46< irker407> wesnoth: pentarctagon wesnoth:master cbc14f553b1f / cmake_mtime_crc.py docker/Dockerfile-base docker/Dockerfile-travis: Add python3 package to the base docker image. https://github.com/wesnoth/wesnoth/commit/cbc14f553b1f1aa369a269ccfcfbf0b0c5a68090
--- Log closed Mon Feb 12 00:00:04 2018