--- Log opened Mon Feb 12 00:00:04 2018
20180212 00:08:03< irker407> wesnoth: Charles Dang wesnoth:master 942a9d876a1c / src/ (chat_command_handler.hpp chat_events.cpp): Removed /red, /yellow, and /green chat commands https://github.com/wesnoth/wesnoth/commit/942a9d876a1c7526845700a9824b4204d8dbf0c8
20180212 00:08:55< celticminstrel> XD What
20180212 00:09:15< vultraz> yup
20180212 00:13:31< vn971> BTW, if you don't think I'll bring chaos, it'd really be more convenient to have basic GH access. Like self-assigning to tasks and labelling my issues.
20180212 00:13:31< vn971> Dunno how gradual it can be technically, but at least I'd do actions above.
20180212 00:14:00< vultraz> what's your github account again?
20180212 00:14:04< celticminstrel> Huh. Someone's actually asking before we got a chance to offer.
20180212 00:14:10< celticminstrel> I'm not sure how to feel about this.
20180212 00:14:16< vn971> vultraz: vgaming
20180212 00:15:03< vultraz> invite sent
20180212 00:15:55< vn971> thanks!
20180212 00:17:40-!- travis-ci [~travis-ci@ec2-23-20-101-24.compute-1.amazonaws.com] has joined #wesnoth-dev
20180212 00:17:41< travis-ci> Pentarctagon/wesnoth#105 (travis-lto - 587eead : pentarctagon): The build was canceled.
20180212 00:17:41< travis-ci> Build details : https://travis-ci.org/Pentarctagon/wesnoth/builds/340286356
20180212 00:17:41-!- travis-ci [~travis-ci@ec2-23-20-101-24.compute-1.amazonaws.com] has left #wesnoth-dev []
20180212 00:19:19-!- octalot [~steve@178.165.130.195.wireless.dyn.drei.com] has quit []
20180212 00:22:27< irker407> wesnoth: Gregory A Lundberg wesnoth:master b91f3a6cf890 / src/tests/gui/test_gui2.cpp: Disable two gui2 unit tests https://github.com/wesnoth/wesnoth/commit/b91f3a6cf89032c4f8887dcfac0c95e1cd0d9bfe
20180212 00:51:43< vultraz> celticminstrel: what do you think should have keyboard focus when you enter the lobby
20180212 00:51:49< vultraz> the gamelist the filter box or the chat?
20180212 00:52:06< celticminstrel> Hmm...
20180212 00:52:14< celticminstrel> That's a surprisingly hard question.
20180212 00:52:37< vultraz> it's the gamelist right now but im thinking it should be chat
20180212 00:53:05< celticminstrel> Chat's probably better than the gamelist, but not sure if it's better than the filter box.
20180212 00:54:23< irker407> wesnoth: loonycyborg wesnoth:bcrypt_auth 330a04d99446 / / (18 files in 5 dirs): Implemented support for forum auth using bcrypt as per #1761 https://github.com/wesnoth/wesnoth/commit/330a04d99446d0cab29b1daf96a40204b645453f
20180212 00:54:25< irker407> wesnoth: loonycyborg wesnoth:bcrypt_auth 0387359c541a / src/ (game_initialization/multiplayer.cpp server/forum_user_handler.cpp): Do comparison to substring using dedicated overload of std::string https://github.com/wesnoth/wesnoth/commit/0387359c541a4c77df49dee2360ec13c2d1527f1
20180212 00:54:27< irker407> wesnoth: loonycyborg wesnoth:bcrypt_auth cfa34ad9d97a / src/ (4 files in 3 dirs): Put bcrypt handling behind an abstraction and improved error handling https://github.com/wesnoth/wesnoth/commit/cfa34ad9d97abb19addd525da6025c284309cabb
20180212 00:54:29< irker407> wesnoth: loonycyborg wesnoth:bcrypt_auth a9bfb8f3c757 / src/hash.cpp: Remove redundant size check https://github.com/wesnoth/wesnoth/commit/a9bfb8f3c757c69ea9afc608b4b1dd7753b23181
20180212 00:54:31< irker407> wesnoth: loonycyborg wesnoth:bcrypt_auth 8523871740fe / src/game_initialization/multiplayer.cpp: Change possibly problematic use of extended initialization syntax https://github.com/wesnoth/wesnoth/commit/8523871740fea8f990e0315ee97e04d35c8831eb
20180212 00:54:33< irker407> wesnoth: loonycyborg wesnoth:bcrypt_auth 3772697ec1c4 / src/ (hash.cpp hash.hpp): Implement base64_digest() method in bcrypt class https://github.com/wesnoth/wesnoth/commit/3772697ec1c4b83c586d21a64119c7597ecc9829
20180212 01:22:29-!- travis-ci [~travis-ci@ec2-54-163-186-22.compute-1.amazonaws.com] has joined #wesnoth-dev
20180212 01:22:30< travis-ci> Pentarctagon/wesnoth#106 (travis-lto - d44ddaa : pentarctagon): The build was canceled.
20180212 01:22:30< travis-ci> Build details : https://travis-ci.org/Pentarctagon/wesnoth/builds/340303741
20180212 01:22:30-!- travis-ci [~travis-ci@ec2-54-163-186-22.compute-1.amazonaws.com] has left #wesnoth-dev []
20180212 01:23:49< irker407> wesnoth: stevecotton wesnoth:orc-descriptions 8f92119a127f / data/core/units.cfg: Update the description of orcs to include goblins (#2489) https://github.com/wesnoth/wesnoth/commit/8f92119a127f5f9e19bae11ca783f52879517264
20180212 01:54:31< irker407> wesnoth: Charles Dang wesnoth:master 7c29cbe89e5d / src/gui/widgets/ (chatbox.cpp chatbox.hpp): GUI2/Chatbox: allow keyboard focus https://github.com/wesnoth/wesnoth/commit/7c29cbe89e5d262f69030a1964a428777901202d
20180212 01:54:34< irker407> wesnoth: Charles Dang wesnoth:master ca06517f1054 / src/gui/dialogs/multiplayer/lobby.cpp: MP Lobby: start with keyboard focus on chat, not the game list https://github.com/wesnoth/wesnoth/commit/ca06517f105482d214ab924c049a38d116824c7b
20180212 02:06:58-!- 17WAAPGJY [~travis-ci@ec2-54-234-205-100.compute-1.amazonaws.com] has joined #wesnoth-dev
20180212 02:06:59< 17WAAPGJY> Pentarctagon/wesnoth#107 (master - b91f3a6 : Gregory A Lundberg): The build passed.
20180212 02:06:59< 17WAAPGJY> Build details : https://travis-ci.org/Pentarctagon/wesnoth/builds/340307704
20180212 02:06:59-!- 17WAAPGJY [~travis-ci@ec2-54-234-205-100.compute-1.amazonaws.com] has left #wesnoth-dev []
20180212 02:09:56-!- travis-ci [~travis-ci@ec2-23-20-52-66.compute-1.amazonaws.com] has joined #wesnoth-dev
20180212 02:09:57< travis-ci> wesnoth/wesnoth#16448 (master - b91f3a6 : Gregory A Lundberg): The build passed.
20180212 02:09:57< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/340296638
20180212 02:09:57-!- travis-ci [~travis-ci@ec2-23-20-52-66.compute-1.amazonaws.com] has left #wesnoth-dev []
20180212 02:28:27-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180212 02:28:37-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20180212 02:34:59-!- travis-ci [~travis-ci@ec2-54-234-205-100.compute-1.amazonaws.com] has joined #wesnoth-dev
20180212 02:35:00< travis-ci> wesnoth/wesnoth#16449 (bcrypt_auth - 3772697 : loonycyborg): The build was broken.
20180212 02:35:00< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/340303070
20180212 02:35:00-!- travis-ci [~travis-ci@ec2-54-234-205-100.compute-1.amazonaws.com] has left #wesnoth-dev []
20180212 02:51:29< vultraz>  celticminstrel poke
20180212 02:51:35< vultraz> celticminstrel: you said you wanted to split the changelog?
20180212 02:55:25< vultraz> celticminstrel: I intend to turn the changelog into a markdown file:
20180212 02:55:26< vultraz> https://github.com/Vultraz/wesnoth/blob/master/changelog.md
20180212 02:55:36< vultraz> (1.13.11 section formatted only)
20180212 02:56:03-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20180212 02:57:57< vultraz> wondering if it's a good time to split it
20180212 03:07:06-!- travis-ci [~travis-ci@ec2-23-20-52-66.compute-1.amazonaws.com] has joined #wesnoth-dev
20180212 03:07:07< travis-ci> wesnoth/wesnoth#16450 (orc-descriptions - 8f92119 : stevecotton): The build is still failing.
20180212 03:07:07< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/340307596
20180212 03:07:07-!- travis-ci [~travis-ci@ec2-23-20-52-66.compute-1.amazonaws.com] has left #wesnoth-dev []
20180212 03:12:45< celticminstrel> Turning the changelog into a markdown file is kinda...
20180212 03:13:14< celticminstrel> Slightly questionable?
20180212 03:13:16< vultraz> I'm thinking splitting all 1.13.x entries into a single file, making that markdown, and leaving the rest this legacy format
20180212 03:13:37< vultraz> i mean, you can't deny it looks good
20180212 03:14:19< celticminstrel> My suggestion is, wait until 1.13.12 and use the extra time to determine how the change will affect pre-existing uses of the changelog.
20180212 03:14:34< vultraz> such as?
20180212 03:14:47< celticminstrel> I'm not sure, which is why I'm a little worried.
20180212 03:14:50< vultraz> the website redirect will need to be changed, that's it
20180212 03:14:55< celticminstrel> Where is the changelog linked from, for example?
20180212 03:15:17< celticminstrel> Do the Linux packagers use the changelog for anything?
20180212 03:15:39< celticminstrel> If we keep the current format but simply slap a .md suffix on it, will that look good in markdown?
20180212 03:15:44< vultraz> no
20180212 03:15:50< vultraz> look down past the 1.13.11 section
20180212 03:15:57< celticminstrel> I suspected as much, and that's the problem.
20180212 03:15:59< celticminstrel> Hmm?
20180212 03:16:11< vultraz> I formatted the 1.13.11 section properly
20180212 03:16:14< vultraz> i left the rest default
20180212 03:16:28< vultraz> basically, we just need to make the version headers #, and the main entries ##
20180212 03:16:39< vultraz> category entries*
20180212 03:16:41< celticminstrel> I'd suggest not doing that.
20180212 03:16:51< celticminstrel> But generally speaking, I'm not opposed to it.
20180212 03:17:04< celticminstrel> I simply prefer the other Markdown headers format - it looks better in plaintext.
20180212 03:17:14< vultraz> sure
20180212 03:17:24< vultraz> but it's more work to convert
20180212 03:17:37< celticminstrel> (It only supports two levels, but we only need two levels anyway.)
20180212 03:17:47< celticminstrel> (In fact, we really only need one level.)
20180212 03:17:59< vultraz> two
20180212 03:19:00< vultraz> we could not split the file, and just link to different version headers
20180212 03:19:05< vultraz> that'dbe interesting
20180212 03:19:07< vultraz> so, say
20180212 03:19:23< vultraz> changelog.wesnoth.org/1.13.11 would go to wesnoth/blob/master/changelog.md#version-11311
20180212 03:21:12< celticminstrel> I just tested the idea of keeping the same format we have right now but interpreting it as Markdown.
20180212 03:21:30< celticminstrel> By simply adding a line break after each version header, it looks pretty decent.
20180212 03:21:43< vultraz> did you look at my version
20180212 03:21:48< celticminstrel> I couldn't find it.
20180212 03:22:00< celticminstrel> Ah, you linked it.
20180212 03:22:01< vultraz> it?
20180212 03:22:03< celticminstrel> Missed that.
20180212 03:22:04< vultraz> i linked it
20180212 03:22:51< celticminstrel> Whoa it's huge.
20180212 03:23:53< vultraz> 14382 lines 
20180212 03:24:06< celticminstrel> No, I mean physically huge on the screen.
20180212 03:24:16< celticminstrel> I think my way of making it markdown may be better after all.
20180212 03:24:21< celticminstrel> It's also less work.
20180212 03:24:36< vultraz> but does it look better
20180212 03:24:45< celticminstrel> I'll demonstrate briefly.
20180212 03:26:09< celticminstrel> https://github.com/CelticMinstrel/wesnoth/blob/master/changelog.md
20180212 03:26:17< celticminstrel> I think that looks a lot better than your version.
20180212 03:26:17-!- travis-ci [~travis-ci@ec2-54-234-205-100.compute-1.amazonaws.com] has joined #wesnoth-dev
20180212 03:26:18< travis-ci> wesnoth/wesnoth#16452 (master - ca06517 : Charles Dang): The build passed.
20180212 03:26:18< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/340312135
20180212 03:26:18-!- travis-ci [~travis-ci@ec2-54-234-205-100.compute-1.amazonaws.com] has left #wesnoth-dev []
20180212 03:26:59< celticminstrel> I guess you could also bold the section headers if you wanted.
20180212 03:27:14< celticminstrel> But on the other hand that'll uglify the plaintext.
20180212 03:27:15< vultraz> ehhh
20180212 03:27:18< vultraz> I disagree
20180212 03:27:24< vultraz> I like having the distinct section headers
20180212 03:27:38< celticminstrel> Yours takes exessive space.
20180212 03:27:40< celticminstrel> ^excessive
20180212 03:27:54< vultraz> so?
20180212 03:28:14< vultraz> I mean, who is going to care about the space
20180212 03:28:24< celticminstrel> In my version, I can see down to "Delfador's Memoirs". In yours, I can only just see the start of the campaigns section.
20180212 03:29:45< vultraz> fair enough
20180212 03:29:58< vultraz> but we're not trying to cram as much into one screen as possible
20180212 03:30:19< vultraz> having the distinct sections also makes it look less like a textwall
20180212 03:30:55< vultraz> which is part of the point
20180212 03:32:02< celticminstrel> I don't think there's much point in trying to make it not a text wall. It's a changelog. A wall of text is basically what it is. Okay, so maybe it could be spread out a little more than what I did, but yours on the other hand is really excessive.
20180212 03:32:15< celticminstrel> What if you use ## and ### instead of # and ##?
20180212 03:32:36< vultraz> ### treats stuff under it as code
20180212 03:32:41< celticminstrel> ...
20180212 03:34:03< vultraz> oh wait
20180212 03:34:04< vultraz> no?
20180212 03:34:12< celticminstrel> Are you getting confused with ```
20180212 03:34:13< vultraz> why was it doing that before..
20180212 03:34:18< celticminstrel> ### should be <h3>
20180212 03:34:27< celticminstrel> #### should be <h4>
20180212 03:34:29< vultraz> https://github.com/Vultraz/wesnoth/blob/master/changelog.md
20180212 03:34:35< vultraz> how's this look
20180212 03:34:35< celticminstrel> ##### should be <h5>
20180212 03:34:39< celticminstrel> and ###### should be <h6>
20180212 03:34:49< vultraz> I think this is a good compromise
20180212 03:35:24< celticminstrel> It's definitely better; still a little excessive, but maybe I can live with this much.
20180212 03:35:29< celticminstrel> Also, drop the colons.
20180212 03:35:34< celticminstrel> Headers shouldn't really have colons.
20180212 03:35:58< celticminstrel> This is also better in that github doesn't render a line beneath ### as it does with ## and #
20180212 03:36:28< celticminstrel> Anyway, I still think we need to consider places the changelogs are used.
20180212 03:36:46< celticminstrel> There was probably a reason the changelog was done the way it was.
20180212 03:37:10< celticminstrel> I don't know what the reason is, but I'd like to know that before changing how the changelog is done.
20180212 03:37:32< vultraz> tad tells me it's just convention
20180212 03:37:43< vultraz> an ancient unix convention
20180212 03:37:45< celticminstrel> tad_carlucci: Can you elaborate on this?
20180212 03:38:08< vultraz> he said
20180212 03:38:10< celticminstrel> Another question is, do the Linux packagers rely on the changelog being in this format.
20180212 03:38:11< vultraz> "Old convention. I think it dates back to before the advent of the WWW. Probably back to the original BSD.
20180212 03:38:11< vultraz> README CHANGES INSTALL the lack of extension usually meant a text file. The all-caps also. Back in the day it was easier to just type on the KSR or ASR Teletype, so caps it was. Same for 80-col cards"
20180212 03:39:58< vultraz> I'm not sure what they would rely on it for
20180212 03:40:15< celticminstrel> But you're not them, so it's best to ask them directly.
20180212 03:42:23< celticminstrel> So anyway, about the deprecation, do you want it merged tonight?
20180212 03:42:28< vultraz> and we need to figure out if we want to split the changelog
20180212 03:42:51< celticminstrel> I think splitting the changelog and changing the format are two separate things.
20180212 03:42:51< vultraz> celticminstrel: merge it expediently, but make sure it works
20180212 03:43:15< celticminstrel> I did some testing earlier today (and fixed some issues I found), so I'm pretty confident it does indeed work.
20180212 03:43:43< celticminstrel> (One of those issues was actually preventing any deprecation messages from being printed, which explains the problem Pentarctagon has... which reminds me, wasn't there an issue about that?)
20180212 03:44:08< vultraz> yes
20180212 03:44:13< vultraz> https://github.com/wesnoth/wesnoth/issues/2425
20180212 03:45:02< celticminstrel> I really need to fix my setup so I can go back to using ssl instead of https authentication and not have to type in the full URL every time... >_>
20180212 03:47:11< vultraz> oh my
20180212 04:15:20-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180212 04:15:28-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20180212 04:18:55< shadowm> Soliton: Any additional comments on https://github.com/wesnoth/wesnoth/pull/2491 ?
20180212 04:19:06< shadowm> (I'd ask elias but he's... rather unresponsive atm it seems.)
20180212 04:24:41< shadowm> Soliton: ALso on https://github.com/wesnoth/wesnoth/pull/2488 ? I feel like it's a lateral change rather than a tangible improvement.
20180212 04:32:02-!- mode/#wesnoth-dev [+o vultraz] by ChanServ
20180212 04:32:23<@vultraz> ok who marked the topic immutable 
20180212 04:33:35< shadowm> I assumed that was you?
20180212 04:33:45< shadowm> I've not been here in ages so I wouldn't know.
20180212 04:34:44<@vultraz> if so I did it intentionally 
20180212 04:39:28< elias> shadowm: I would not use assert
20180212 04:39:41< shadowm> elias: OH. Good, you're alive. Could you post that there?
20180212 04:39:42< elias> that's for debugging, not for checking user input
20180212 04:39:55< elias> I suppose
20180212 04:40:02< shadowm> ALso did you see what I posted here yesterday¡
20180212 04:40:07< shadowm> ?
20180212 04:41:55< elias> yes
20180212 04:42:07< elias> I thought you said it was a user error
20180212 04:42:25< shadowm> How is using . as the directory to upload a user error?
20180212 04:42:31< irker407> wesnoth: Celtic Minstrel wesnoth:deprecation b4b54405a914 / / (12 files in 5 dirs): Some fixes to the Lua deprecation API, and extend it to C++ https://github.com/wesnoth/wesnoth/commit/b4b54405a9147c16fa7ac691f0a5619ade79a46e
20180212 04:42:33< irker407> wesnoth: Celtic Minstrel wesnoth:deprecation 117ddc09cc87 / / (3 files in 2 dirs): Add #deprecated preprocessor directive for marking macros deprecated https://github.com/wesnoth/wesnoth/commit/117ddc09cc87d5bf4f356c4959c162ec26f3d848
20180212 04:42:35< irker407> wesnoth: Celtic Minstrel wesnoth:deprecation fc3c693662e2 / src/scripting/ (lua_common.cpp lua_common.hpp): Utility function that I didn't end up using but which could be useful elsewhere https://github.com/wesnoth/wesnoth/commit/fc3c693662e27d2653aeed81ea5d0eecfe540607
20180212 04:42:39< shadowm> . is as much a directory as any other named directory.
20180212 04:42:48< shadowm> By definition.
20180212 04:44:39< elias> I agree
20180212 04:44:59< elias> but all I read was "using . fixes it" :)
20180212 04:45:04< elias> or not using .
20180212 04:45:09< shadowm> *Not* using .
20180212 04:45:31< shadowm> It's not a user error if the program can't deal with a perfectly valid edge case.
20180212 04:45:33< elias> but yeah, the easy fix would be to simply use os.path.abspath(x) or something
20180212 04:45:52< elias> the better fix would be to research why . fails and make it work with .
20180212 04:46:02< elias> (in case you are in a symlinked directory or other special edge cases)
20180212 04:46:26< elias> I can create a github issue if you want me to
20180212 04:46:28-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has joined #wesnoth-dev
20180212 04:50:33< elias> shadowm: https://github.com/wesnoth/wesnoth/issues/2494
20180212 04:50:53< elias> I'll try and fix it this week if nobody else does first
20180212 04:56:14< shadowm> Okay, thanks. Added the backtrace I got to the issue.
20180212 04:58:30< elias> thanks
20180212 05:03:12< irker407> wesnoth: Celtic Minstrel wesnoth:master 80b4ed51fa65 / data/core/units.cfg: Tweak the race descriptions of orcs and goblins https://github.com/wesnoth/wesnoth/commit/80b4ed51fa657939179742a17fea558cfdec4197
20180212 05:03:14< irker407> wesnoth: stevecotton wesnoth:master c50554fef41a / data/core/units.cfg: Update the description of orcs to include goblins (#2489) https://github.com/wesnoth/wesnoth/commit/c50554fef41a01119267e2c3905faaaa8c3b448e
20180212 05:03:58< celticminstrel> ...argh, I forgot to fix the typo.
20180212 05:04:30-!- travis-ci [~travis-ci@ec2-54-234-205-100.compute-1.amazonaws.com] has joined #wesnoth-dev
20180212 05:04:31< travis-ci> wesnoth/wesnoth#16453 (deprecation - fc3c693 : Celtic Minstrel): The build is still failing.
20180212 05:04:31< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/340340357
20180212 05:04:31-!- travis-ci [~travis-ci@ec2-54-234-205-100.compute-1.amazonaws.com] has left #wesnoth-dev []
20180212 05:05:08-!- travis-ci [~travis-ci@ec2-54-234-205-100.compute-1.amazonaws.com] has joined #wesnoth-dev
20180212 05:05:09< travis-ci> wesnoth/wesnoth#16455 (master - c50554f : stevecotton): The build was canceled.
20180212 05:05:09< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/340343302
20180212 05:05:09-!- travis-ci [~travis-ci@ec2-54-234-205-100.compute-1.amazonaws.com] has left #wesnoth-dev []
20180212 05:05:29< celticminstrel> Why was it cancelled? Because it touches no source files?
20180212 05:06:07<@vultraz> yes
20180212 05:06:14<@vultraz> so i canceled it
20180212 05:06:17< celticminstrel> Okay, makes sense.
20180212 05:06:24<@vultraz> you forgot [ci skip]
20180212 05:06:27<@vultraz> anyway
20180212 05:06:33<@vultraz> since i can't set the topic, release is TOMORROW
20180212 05:06:50< celticminstrel> Maybe you should figure out how to make it not immutable.
20180212 05:08:02< celticminstrel> Oh, looks like Steve Cotton actually fixed the typo, alright then.
20180212 05:08:28<@vultraz> "The TOPICLOCK flag is not set for channel #wesnoth-dev."
20180212 05:08:30<@vultraz> ugh
20180212 05:08:34<@vultraz> this is why I hate IRC sometimes
20180212 05:09:07< celticminstrel> ...did my merge go through or not? Where's irker?
20180212 05:09:07<@vultraz> whatever
20180212 05:09:15<@vultraz> up?
20180212 05:09:19<@vultraz> look up
20180212 05:09:24< celticminstrel> It did not go through. Okay then.
20180212 05:09:32<@vultraz> no it did..
20180212 05:09:42< celticminstrel> No it didn't.
20180212 05:09:50<@vultraz> merge of what?
20180212 05:09:50< irker407> wesnoth: Celtic Minstrel wesnoth:master 3440546f2de5 / / (12 files in 5 dirs): Some fixes to the Lua deprecation API, and extend it to C++ https://github.com/wesnoth/wesnoth/commit/3440546f2de56b426058f709eff3a6625b6d57ca
20180212 05:09:52< irker407> wesnoth: Celtic Minstrel wesnoth:master ae50be5bbe83 / / (3 files in 2 dirs): Add #deprecated preprocessor directive for marking macros deprecated https://github.com/wesnoth/wesnoth/commit/ae50be5bbe83be856742bef97a3a52423eb65091
20180212 05:09:54<@vultraz> oh
20180212 05:09:54< celticminstrel> Ah I just forgot to press confirm.
20180212 05:09:54< irker407> wesnoth: Celtic Minstrel wesnoth:master d9d65e61b47d / src/scripting/ (lua_common.cpp lua_common.hpp): Utility function that I didn't end up using but which could be useful elsewhere https://github.com/wesnoth/wesnoth/commit/d9d65e61b47d0dab4bac5e42b3f0bde463822dd4
20180212 05:09:55<@vultraz> there
20180212 05:15:50<@vultraz> celticminstrel: so https://github.com/wesnoth/wesnoth/issues/1866 close?
20180212 05:16:44<@vultraz> celticminstrel: could you explain https://github.com/wesnoth/wesnoth/issues/2034 more?
20180212 05:17:22< celticminstrel> Give me a few minutes to kill my browser...
20180212 05:18:38< celticminstrel> TextEdit also randomly hung too...
20180212 05:18:45< celticminstrel> While I was trying to save something. :/
20180212 05:22:16< celticminstrel> BTW I also added a bunch more uses of the #deprecated directive before merging.
20180212 05:22:28< celticminstrel> Also fixed one little TODO in the Lua section.
20180212 05:24:31< celticminstrel> vultraz: 2034 is like faction lock, but for the AI algorithm.
20180212 05:24:54<@vultraz> why did you say `[multiplayer]`, then
20180212 05:24:57< celticminstrel> It means the user is not permitted to change the AI algorithm.
20180212 05:25:06< celticminstrel> Uh. What do you mean?
20180212 05:25:07<@vultraz> wouldn't it go in side
20180212 05:25:10<@vultraz> [side]
20180212 05:25:23< celticminstrel> Sure, but [side] within [multiplayer].
20180212 05:25:25<@vultraz> and be called ai_lock or something?
20180212 05:25:39< celticminstrel> You can call it whatever you want, I guess.
20180212 05:25:51<@vultraz> I can probably implement this by tomorrow
20180212 05:25:56<@vultraz> ok
20180212 05:26:00<@vultraz> what about the other three things?
20180212 05:26:01<@vultraz> https://github.com/wesnoth/wesnoth/issues?q=is%3Aopen+is%3Aissue+milestone%3A1.13.11
20180212 05:26:57< celticminstrel> If AI override isn't allowed it should probably be equivalent to selecting a null AI - or more specifically, no AI. In other words, only the AI specified in the [side] is used.
20180212 05:27:37<@vultraz> hmmm
20180212 05:27:52< celticminstrel> Normally the AI algorithm is injected into the side tag by the create engine or something.
20180212 05:28:17< celticminstrel> So it'll use the default information for that algorithm, plus anything specified in [side], but it'll ignore the ai_algorithm key in [side].
20180212 05:29:03< celticminstrel> I'm not sure about 1947, but it should be simple to test.
20180212 05:29:17< celticminstrel> Go into the Lua console and execute the following command:
20180212 05:29:46< irker407> wesnoth: Jyrki Vesterinen wesnoth:master 1703029bc3e7 / projectfiles/VC12/wesnoth.vcxproj: Visual Studio: disable warning C4351 (#2492) https://github.com/wesnoth/wesnoth/commit/1703029bc3e7b8804e438fa6b34398f16af44ea9
20180212 05:29:59< celticminstrel> wesnoth.format("$(reduce(list, concatenate(a, ' ',b) where list = ['foo', 'bar'])")
20180212 05:30:09< celticminstrel> Uh, I think I missed a paren
20180212 05:30:15< celticminstrel> wesnoth.format("$(reduce(list, concatenate(a, ' ',b)) where list = ['foo', 'bar'])")
20180212 05:30:41< celticminstrel> It should output the string "foobar".
20180212 05:30:53< celticminstrel> Oh, sorry. "foo bar"
20180212 05:31:20<@vultraz> says
20180212 05:31:21<@vultraz> ``
20180212 05:31:26< celticminstrel> Hmm?
20180212 05:31:32<@vultraz> it returns
20180212 05:31:33<@vultraz> ''
20180212 05:31:34<@vultraz> just
20180212 05:31:36< celticminstrel> I see.
20180212 05:31:40<@vultraz> ''
20180212 05:31:43< celticminstrel> So it is indeed an issue, huh...
20180212 05:34:45<@vultraz> is it a simple fix?
20180212 05:35:13< celticminstrel> I'm gonna test a fix in formula/string-utils.cpp. If that works, great, if not, probably better to postpone.
20180212 05:37:05-!- travis-ci [~travis-ci@ec2-54-234-205-100.compute-1.amazonaws.com] has joined #wesnoth-dev
20180212 05:37:06< travis-ci> wesnoth/wesnoth#16456 (master - d9d65e6 : Celtic Minstrel): The build failed.
20180212 05:37:06< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/340344089
20180212 05:37:06-!- travis-ci [~travis-ci@ec2-54-234-205-100.compute-1.amazonaws.com] has left #wesnoth-dev []
20180212 05:39:37-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has quit [Quit: Rebooting]
20180212 05:44:05-!- travis-ci [~travis-ci@ec2-23-20-52-66.compute-1.amazonaws.com] has joined #wesnoth-dev
20180212 05:44:06< travis-ci> wesnoth/wesnoth#16457 (master - 1703029 : Jyrki Vesterinen): The build failed.
20180212 05:44:06< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/340347126
20180212 05:44:06-!- travis-ci [~travis-ci@ec2-23-20-52-66.compute-1.amazonaws.com] has left #wesnoth-dev []
20180212 05:44:15-!- JyrkiVesterinen [~jyrki@85-23-197-3.bb.dnainternet.fi] has joined #wesnoth-dev
20180212 05:55:05-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180212 05:55:11-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20180212 06:00:38-!- JyrkiVesterinen [~jyrki@85-23-197-3.bb.dnainternet.fi] has quit [Quit: Rebooting]
20180212 06:05:17-!- JyrkiVesterinen [~jyrki@85-23-197-3.bb.dnainternet.fi] has joined #wesnoth-dev
20180212 06:06:44< celticminstrel> vultraz: Looks like the poster is correct about it being an issue in the WFL parser, rather than in the $(...) parser.
20180212 06:07:04< celticminstrel> I don't know how to fix it; I'd have to dive into the WFL code and figure it out.
20180212 06:08:00< celticminstrel> As for the other two issues, the preferences thing is basically "when you click the close button, save the preferences to disk".
20180212 06:08:00<@vultraz> sadness
20180212 06:08:25< celticminstrel> And the sound one is "apply changes to the sound preferences immediately when they're changed in the prefs dialog".
20180212 06:08:38< celticminstrel> The reason for that is so that you can hear the volume changes as you're adjusting it.
20180212 06:09:13< celticminstrel> For the two non-music sliders you might also want to play a sound effect on the appropriate channel.
20180212 06:09:49< celticminstrel> Otherwise it's difficult to get the volume level to where you want it to be.
20180212 06:19:52< irker407> wesnoth: Jyrki Vesterinen wesnoth:master a5a9f6ab1977 / SConstruct: Revert "Fix release builds with Clang and SCons" https://github.com/wesnoth/wesnoth/commit/a5a9f6ab1977237c49737d929748f5480a3970df
20180212 06:19:54< irker407> wesnoth: Jyrki Vesterinen wesnoth:master 1d47c23efe21 / .travis.yml CMakeLists.txt SConstruct docker_run.sh: Revert "Enable LTO by default." https://github.com/wesnoth/wesnoth/commit/1d47c23efe218b01010ab399707ca8d1f00da75c
20180212 06:33:07-!- travis-ci [~travis-ci@ec2-54-234-205-100.compute-1.amazonaws.com] has joined #wesnoth-dev
20180212 06:33:08< travis-ci> wesnoth/wesnoth#16458 (master - 1d47c23 : Jyrki Vesterinen): The build is still failing.
20180212 06:33:08< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/340355088
20180212 06:33:08-!- travis-ci [~travis-ci@ec2-54-234-205-100.compute-1.amazonaws.com] has left #wesnoth-dev []
20180212 06:39:14-!- JyrkiVesterinen [~jyrki@85-23-197-3.bb.dnainternet.fi] has quit [Quit: Going to work']
20180212 06:50:53-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The computer falls into a deep sleep, to awake again some other day!]
20180212 06:53:48-!- mode/#wesnoth-dev [-o vultraz] by ChanServ
20180212 07:23:20-!- JyrkiVesterinen [~JyrkiVest@195-192-251-124.s1networks.fi] has joined #wesnoth-dev
20180212 07:34:21-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20180212 08:05:11< Soliton> TadCarlucci: surely you meant codacy. yeah, i noticed it mostly knows python but that looked useful from what i saw.
20180212 08:08:08< Soliton> shadowm: 2488 is good IMO. it's more consistent with the --change-passphrase parameter. before you could thing the password is used for more operations than just removing addons. (which is what the author did.)
20180212 08:09:45< Soliton> shadowm: so assuming you're fine with it i'll merge. what about backporting so we don't need to remember the different interface between versions?
20180212 08:58:12-!- Oebele [~quassel@143.177.58.202] has joined #wesnoth-dev
20180212 08:59:20-!- vultraz [uid24821@wesnoth/developer/vultraz] has quit [Quit: Connection closed for inactivity]
20180212 09:20:00-!- irker407 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20180212 09:23:04-!- vladimirslavik [vslavik@nat/redhat/x-jmgmlghvnmwmfhvo] has joined #wesnoth-dev
20180212 09:45:09< zookeeper> i just randomly saw a forum post that mentioned that the current intended release date is in a discord channel header. i hope someone just forgot to update the topic here accordingly.
20180212 09:46:15-!- mode/#wesnoth-dev [+o Soliton] by ChanServ
20180212 09:46:34-!- Soliton changed the topic of #wesnoth-dev to: 1.13.11 (1.14 Beta  3) scheduled for February 13th 00:01 UTC | Wesnoth Developers Channel | >>> Want to help? Go here: https://r.wesnoth.org/t42911 (and thanks!) <<< | Discord Server: https://discord.gg/battleforwesnoth | Logs: http://irclogs.wesnoth.org | Bug tracker: https://bugs.wesnoth.org
20180212 09:46:48-!- mode/#wesnoth-dev [-o Soliton] by Soliton
20180212 09:46:48< JyrkiVesterinen> Vultraz said that he simply couldn't change the topic because it's locked.
20180212 09:47:11< Soliton> it's not locked.
20180212 09:47:35< Soliton> i think he was rather trying to use the topic lock feature to set the new topic.
20180212 09:47:48< vn971> hm-hm, so it's still 1.13.* right? It's not the stage where I test my add-ons and upload them to add-ons server, right?
20180212 09:48:12< Soliton> why not? 1.14 isn't too far away.
20180212 09:48:12< JyrkiVesterinen> Yes, the version number is 1.13.11.
20180212 09:48:41< Soliton> i don't think we'll reset the addons server, not 100% sure though.
20180212 09:48:42< vn971> Soliton: I mean, I shouldn't upload them to 1.14 server, yet.
20180212 09:49:14< Soliton> i think we've usually just turned the dev server into the stable one for campaignd.
20180212 09:49:18< vn971> I heard add-ons will be reset (from 1.13) as there could be lots of testing stuff there, and also things that broke since the very first 1.13 release.
20180212 09:49:29< Soliton> and perhaps reset it if there were breaking changes or so.
20180212 09:50:01< Soliton> yeah, that might happen. haven't looked at how much cruft is on there.
20180212 09:50:06< vn971> Someone's gotta confirm.
20180212 09:50:13< Soliton> shadowm: ^
20180212 10:13:27< zookeeper> it's not nice to have years-old cruft on the add-on server for 1.14, but neither is it nice to force everyone to re-upload. would it be possible to purge everything _except_ add-ons uploaded for example during the beta/RC phase?
20180212 10:14:24< zookeeper> or if there's some other cutoff that would make sense from a "older than this is unlikely to still work in 1.14" POV.
20180212 10:14:46-!- Nobun [~user@5.170.240.84] has joined #wesnoth-dev
20180212 10:41:42-!- vultraz [uid24821@wesnoth/developer/vultraz] has joined #wesnoth-dev
20180212 10:42:11< vultraz> Soliton: backporting makes no sense since there won't be another 1.12 release
20180212 10:42:25-!- JyrkiVesterinen [~JyrkiVest@195-192-251-124.s1networks.fi] has quit [Quit: .]
20180212 10:48:47< Soliton> wesnoth_addon_manager is not really bound by a release. it'd be to make it easier for shadowm and me and whoever else might help some user do stuff on an old campaignd instance.
20180212 10:55:57< vultraz> well, up to you
20180212 10:59:00-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20180212 11:01:23< vultraz> but please merge them in the next 13 hours
20180212 11:18:49-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20180212 11:25:53< loonycyborg> celticminstrel: seems your deprecated macro stuff broke compilation for me. Also in travis
20180212 11:26:58< vultraz> Did he add deprecated.cpp to the sources lists
20180212 11:49:09-!- JyrkiVesterinen [~JyrkiVest@195-192-251-124.s1networks.fi] has joined #wesnoth-dev
20180212 11:51:59< loonycyborg> seems yes
20180212 11:54:48< loonycyborg> maybe it's added to wrong place though
20180212 11:55:31< JyrkiVesterinen> Is it in libwesnoth-core?
20180212 11:55:44< JyrkiVesterinen> That's the library that fails to build according to your log.
20180212 12:10:24< loonycyborg> seems he added it to libwesnoth
20180212 12:10:33< loonycyborg> so libwesnoth-core can't use it
20180212 12:10:54< loonycyborg> not sure if he'd want to prevent use from core
20180212 12:11:01< loonycyborg> or add it to core
20180212 12:11:38< JyrkiVesterinen> It should be in core given that the linker attempts to link to it.
20180212 13:21:53-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20180212 13:23:17-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 276 seconds]
20180212 13:23:18-!- wedge010 is now known as wedge009
20180212 13:24:42< loonycyborg> JyrkiVesterinen: if I add it to core more linker errors appear
20180212 13:24:48< loonycyborg> because it's using yet more stuff
20180212 13:25:16< JyrkiVesterinen> I see.
20180212 13:25:23< JyrkiVesterinen> This is a mess... :(
20180212 13:25:52< loonycyborg> maybe celmin needs to make that func inline or something
20180212 13:49:28-!- irker578 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20180212 13:49:28< irker578> wesnoth: loonycyborg wesnoth:bcrypt_auth 565d2d2c9cf4 / src/server/forum_user_handler.cpp: Don't eat error message if retrying https://github.com/wesnoth/wesnoth/commit/565d2d2c9cf415856fa386d1d94985df9ad8a6e8
20180212 13:49:28< irker578> wesnoth: loonycyborg wesnoth:bcrypt_auth b28da00e432a / src/server/mysql_prepared_statement.ipp: Properly report MYSQL_DATA_TRUNCATED error https://github.com/wesnoth/wesnoth/commit/b28da00e432a8eb331cdb6b378450042d6a2b4f9
20180212 14:07:33-!- vultraz [uid24821@wesnoth/developer/vultraz] has quit [Quit: Connection closed for inactivity]
20180212 14:10:54-!- travis-ci [~travis-ci@ec2-54-162-219-217.compute-1.amazonaws.com] has joined #wesnoth-dev
20180212 14:10:55< travis-ci> wesnoth/wesnoth#16461 (bcrypt_auth - b28da00 : loonycyborg): The build is still failing.
20180212 14:10:55< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/340491952
20180212 14:10:55-!- travis-ci [~travis-ci@ec2-54-162-219-217.compute-1.amazonaws.com] has left #wesnoth-dev []
20180212 14:30:53-!- vladimirslavik [vslavik@nat/redhat/x-jmgmlghvnmwmfhvo] has quit [Quit: Leaving]
20180212 14:51:12-!- tad_carlucci [~lundberg@74.193.219.119] has quit [Quit: Leaving]
20180212 14:51:52-!- TadCarlucci [~lundberg@74.193.219.119] has quit [Quit: Leaving]
20180212 14:52:22-!- TadCarlucci [~lundberg@74.193.219.119] has joined #wesnoth-dev
20180212 15:16:33-!- JyrkiVesterinen [~JyrkiVest@195-192-251-124.s1networks.fi] has quit [Quit: .]
20180212 15:33:39< irker578> wesnoth: Gregory A Lundberg wesnoth:master 82648f114b95 / src/ (campaign_server/campaign_server.cpp formula/formula.cpp server/server.cpp): Fix bad design with a slimy hack https://github.com/wesnoth/wesnoth/commit/82648f114b95c40a588443bb267ea27436f2288c
20180212 15:36:32< TadCarlucci> loonycyborg, That should get us compiling again with the deprecation stuff merged.
20180212 15:37:09< loonycyborg> cool
20180212 15:37:46< Soliton> you're excellent at writing feel good commit messages. :-P
20180212 15:38:39< Soliton> we need to remove the preprocessor dependency from the servers some time... i don't think it's really needed.
20180212 15:48:39< TadCarlucci> Agreed
20180212 16:16:44-!- iceiceice [~chris@unaffiliated/iceiceice] has quit [Quit: Leaving]
20180212 16:27:29< irker578> wesnoth: loonycyborg wesnoth:bcrypt_auth 12d0ebe16a92 / src/server/mysql_prepared_statement.ipp: MYSQL_DATA_TRUNCATED was in fact success result in this context https://github.com/wesnoth/wesnoth/commit/12d0ebe16a922c9f8274746938ae8acfdcd946ae
20180212 16:30:51-!- vultraz [uid24821@wesnoth/developer/vultraz] has joined #wesnoth-dev
20180212 16:32:00-!- travis-ci [~travis-ci@ec2-23-20-52-66.compute-1.amazonaws.com] has joined #wesnoth-dev
20180212 16:32:01< travis-ci> wesnoth/wesnoth#16464 (master - 82648f1 : Gregory A Lundberg): The build has errored.
20180212 16:32:01< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/340537853
20180212 16:32:01-!- travis-ci [~travis-ci@ec2-23-20-52-66.compute-1.amazonaws.com] has left #wesnoth-dev []
20180212 16:40:20< vultraz> Soliton: please look at https://github.com/wesnoth/wesnoth/issues/2494 too
20180212 16:49:10< shadowm> vn971 Soliton : The 1.14 add-ons server will replace the 1.13 server once RC 1 is released.
20180212 16:50:21< shadowm> The one time we didn't do that (1.9 was used for 1.10) in recent history it didn't make for a very good user experience because of a number of add-ons from early in the development cycle that became broken by 1.10.0.
20180212 16:50:57< shadowm> (And also it caused us to have to make some exceptions to treat 1.9 as 1.10 on the server side.)
20180212 16:50:58< irker578> wesnoth: Charles Dang wesnoth:master 7e09a34edfb5 / data/core/images/units/dwarves/stalwart/ (9 files): Fixed opaque shadows in Dwarvish Stalwart ne attack anim https://github.com/wesnoth/wesnoth/commit/7e09a34edfb508657f782038dfc940d83e271b32
20180212 16:52:17-!- travis-ci [~travis-ci@ec2-23-20-52-66.compute-1.amazonaws.com] has joined #wesnoth-dev
20180212 16:52:18< travis-ci> wesnoth/wesnoth#16465 (bcrypt_auth - 12d0ebe : loonycyborg): The build was fixed.
20180212 16:52:18< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/340563404
20180212 16:52:18-!- travis-ci [~travis-ci@ec2-23-20-52-66.compute-1.amazonaws.com] has left #wesnoth-dev []
20180212 16:52:34< vultraz> zookeeper: might be worth a pre-release optipng run?
20180212 16:53:39< zookeeper> maybe?
20180212 16:54:11< zookeeper> vultraz, don't you think the new wood bg looks a bit too sharp and coarse?
20180212 16:54:42< vultraz> well, slightly. But only because the of the contrast with the map.
20180212 16:54:42< shadowm> Soliton: On my side I just use the master version of wesnoth_addon_manager always, and also had to make the add-ons.w.o web build script do the same last year so that I wouldn't have to keep backporting all the website redesign changes to 1.12 (and 1.10) every time an issue came up.
20180212 16:55:00< vultraz> (also keepin mind your screen probably scales it down)
20180212 16:55:04< irker578> wesnoth: loonycyborg wesnoth:bcrypt_auth 5f6a449d81a7 / src/server/mysql_prepared_statement.ipp: Add call to mysql_stmt_store_result() to work around a mysql issue https://github.com/wesnoth/wesnoth/commit/5f6a449d81a7a59091c84661743e2de4ed0b2344
20180212 16:55:17< shadowm> So I don't feel backporting a command line syntax change is particularly beneficial.
20180212 16:55:39< vultraz> zookeeper: you must admit it's better than the old one at least?
20180212 16:55:43< loonycyborg> shall I run pot-update right now?
20180212 16:55:49< loonycyborg> or some string changes still pending?
20180212 16:55:54< zookeeper> vultraz, yeah it's very nice otherwise.
20180212 16:56:11< vultraz> now if we only we could display the really sharp logo too...
20180212 16:56:14< vultraz> but :(
20180212 16:56:57< shadowm> Soliton: Regard #2488, what about --upload?
20180212 16:57:01< shadowm> *regarding
20180212 16:57:25< zookeeper> vultraz, i immediately wondered why LB has used such a heavy amount of emboss/relief/whatever on it, maybe it could be toned down a bit.
20180212 16:57:36< zookeeper> is he on discord?
20180212 16:58:00< vultraz> yes. but once again I seem to have forgotten to invite him to our server?
20180212 16:58:04< vultraz> i speak to him in PM
20180212 16:58:11< vultraz> I recall i did
20180212 16:58:18< vultraz> but then there was something..
20180212 16:58:21< vultraz> and then it didn't...
20180212 16:58:24< vultraz> agh, I can't remember
20180212 16:58:37< shadowm> wut
20180212 16:59:08< vultraz> I remember I sent him an invite to our server once
20180212 16:59:18< shadowm> Then do it again.
20180212 16:59:22< vultraz> But he doesn't appear to be there
20180212 16:59:29< vultraz> I'll talk to him next time he's online
20180212 16:59:31< shadowm> Unpopular opinion here: the new background looks fine to me on 1080p.
20180212 16:59:54< vultraz> zookeeper: BTW, I'd say the bg looks perfect for me at 4K
20180212 16:59:59< shadowm> The only problem with it is that it highlights the fact that the map itself is designed for a smaller resolution and it's thus upscaled instead.
20180212 17:00:14< vultraz> yeah ^
20180212 17:00:24< vultraz> it does look a bit sharp and highlights the map
20180212 17:00:34< shadowm> Oh also respect his decision to not join the server if that's his decision.
20180212 17:00:53< shadowm> I shouldn't need to say that but I might as well say it.
20180212 17:01:52< vultraz> JESUS CHRIST O_O Deprecation message spam
20180212 17:03:34< zookeeper> yes, of course i'm talking about how the bg works with the maps (and interface art, etc), not what it'd look like in isolation. no matter what resolution you have, they don't really match in style.
20180212 17:03:51< vultraz> the solution is to make better maps, not worse backgrounds
20180212 17:04:16< zookeeper> that's an irrelevant statement
20180212 17:04:45< vultraz> Not really.
20180212 17:05:08< vultraz> You're proposing making it lower res in order to match styles
20180212 17:05:18< zookeeper> i'm not, stop playing stupid.
20180212 17:07:57< vultraz> anyway, if someone could run optipng, that would be great
20180212 17:08:03< shadowm> Soliton: Oh, I understand now. The intention is to use the pbl option added by #2491 instead to specify a passphrase for uploads. #2488 seems okay to me then.
20180212 17:08:57< vultraz> shadowm: does #2495 also look good?
20180212 17:09:19< shadowm> I'll assign that one to elias.
20180212 17:10:17< irker578> wesnoth: loonycyborg wesnoth:master 6724a696e664 / / (1092 files in 23 dirs): pot-update and regenerate doc files https://github.com/wesnoth/wesnoth/commit/6724a696e6648eea8a203bb6486b66d8095609b3
20180212 17:11:21< Soliton> shadowm: yeah, the -P option was not used for uploads anyway that was part of what triggered #2488.
20180212 17:12:36< Soliton> no need to backport then i'm fine with using the master version everywhere.
20180212 17:22:09-!- Bonobo [~Bonobo@61.68.156.44] has quit [Ping timeout: 248 seconds]
20180212 17:22:15< TadCarlucci> I am getting WML test issues for pathfinding
20180212 17:24:22< vultraz> :|
20180212 17:24:25< vultraz> pls no
20180212 17:25:10< TadCarlucci> And C++ unit tests are failing again with a segfault very early one. I **know** that was not happening last night after I eliminated the offending code.
20180212 17:35:48< vultraz> Blah
20180212 17:36:00< vultraz> will we be able to release
20180212 17:46:01< TadCarlucci> Sure. Just need to be sure LTO is not enabled.
20180212 17:46:38< TadCarlucci> I have it on and I'm upset because I had it working last night even with LTO enabled.
20180212 17:47:30< TadCarlucci> MAybe it's an artifact. I'm going to wipe and start fresh and see if that solves it
20180212 17:50:10< zookeeper> btw, if you'll be releasing in ~6h, i might be afk until then so don't count on me for last-minute fixes.
20180212 17:50:15-!- vladimirslavik [~vslavik@95.82.135.184] has joined #wesnoth-dev
20180212 17:53:54-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has joined #wesnoth-dev
20180212 17:54:05< TadCarlucci> vultraz, Confirmed that LTO is *disabled* by default. So if the C++ unit tests segfault with LTO we can label it a known problem and release
20180212 17:57:01< shadowm> Tell loonycyborg to include it in the email for packagers as well.
20180212 17:57:10< shadowm> The warning against using LTO, that is.
20180212 17:58:21< JyrkiVesterinen> Why? As far as I can see, segfaulting of *unit tests* shouldn't be a problem for packagers.
20180212 17:59:07< TadCarlucci> Still seems better to warn them about that then have them complain
20180212 17:59:56< shadowm> Is it only the unit tests or a global issue that's just non-deterministic enough to have a sufficiently high chance of *not* coming up during normal usage?
20180212 18:00:19< DeFender1031> Shouldn't the copyright at the bottom of the website be updated to read "2003–2018"? It still says "2017" for me...
20180212 18:00:23< shadowm> Also it's worth warning them anyway in case any packagers run the unit tests as part of the package build process.
20180212 18:00:58< shadowm> e.g. to verify that the software works as intended by the devs on different environments and toolchains.
20180212 18:01:20< shadowm> DeFender1031: Remind me later. I'm having an existential crisis right now.
20180212 18:02:10< TadCarlucci> we have no evidence of a problem in the wesnoth target, only boost_unit_tests and there it is 100% consistent: revert that old commit for 100% success or keep it for 100% failure in the loading screen
20180212 18:02:11< DeFender1031> shadowm, will do, and I wish you much luck with confronting existence.
20180212 18:03:35< DeFender1031> (Also, I'd recommend having the software just generate the current year behind the scenes rather than having to manually update it every jan-er-february.)
20180212 18:05:05< shadowm> Nah.
20180212 18:09:05-!- travis-ci [~travis-ci@ec2-54-162-219-217.compute-1.amazonaws.com] has joined #wesnoth-dev
20180212 18:09:06< travis-ci> wesnoth/wesnoth#16467 (master - 6724a69 : loonycyborg): The build has errored.
20180212 18:09:06< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/340583402
20180212 18:09:06-!- travis-ci [~travis-ci@ec2-54-162-219-217.compute-1.amazonaws.com] has left #wesnoth-dev []
20180212 18:11:59< TadCarlucci> Travis agrees on the failing WML tests. Its showing them all to be deprecation messages. My system doesn't show that.
20180212 18:20:15< vultraz> Ah
20180212 18:20:22< vultraz> Ok so we’re using deprecated wml
20180212 18:20:25< vultraz> Need to fix that
20180212 18:21:37< JyrkiVesterinen> I recommend delaying the beta release further to get time to fix it.
20180212 18:21:49< JyrkiVesterinen> (And we could delay the stable release too while we're at it.)
20180212 18:22:50< vultraz> God dammit.
20180212 18:23:24< vultraz> alright
20180212 18:24:32< TadCarlucci> Seems to me it should be quick to fix. Don't commit to a delay just yet and work the problem 
20180212 18:25:39< shadowm> You two are tearing poor vultraz apart.
20180212 18:25:56< vultraz> Maybe I should just work on my essay about public election funding
20180212 18:26:11< vultraz> >_>
20180212 18:26:51< JyrkiVesterinen> Replacing deprecated code may not be that easy.
20180212 18:27:16< JyrkiVesterinen> The old tags are deprecated for a reason - automatic conversion from old to new WML isn't possible.
20180212 18:27:34< JyrkiVesterinen> (Otherwise we'd just be able to reimplement the old via the new and continue to support it forever.)
20180212 18:27:50< vultraz> these are all warnings about the Khalifate...
20180212 18:28:04< zookeeper> exactly what deprecations are you referring to anyway?
20180212 18:28:36< vultraz> 20180212 17:22:16 error wml: Batal has been deprecated and will be removed in the next version (1.15).
20180212 18:28:36< vultraz>   This unit has been renamed to: Dune Ranger
20180212 18:28:37< vultraz> etc
20180212 18:28:57< vultraz> doesn't tell you where it's used though
20180212 18:28:59< zookeeper> oh. so the renaming just missed some things? seems straightforward enough to fix.
20180212 18:29:28< vultraz> where is this deprecated message
20180212 18:30:30< zookeeper> in data\core\units\dunefolk\deprecated.cfg
20180212 18:30:57< zookeeper> ...where someone also put a macro/argument call in a translatable string, it seems.
20180212 18:31:15< zookeeper> so better fix that too :p
20180212 18:31:41< vultraz> ... I think these warnings literally exist because the khalifate are still registered unit....
20180212 18:31:58< vultraz> the parser just sees the code and spits out the warning
20180212 18:32:11< TadCarlucci> data\test\maps\pathfind-1.cfg line 1312
20180212 18:33:15< vultraz> oh wait, the khalifate thing is an event
20180212 18:33:15< vultraz> ok
20180212 18:33:59< vultraz> TadCarlucci: anywhere else?
20180212 18:34:06< vultraz> any of the khalifate names
20180212 18:34:55< TadCarlucci> For "batal" no. Looks like they're all there.
20180212 18:35:49< TadCarlucci> I don't know them off the top of my head so I'm having to look, search, check for each.
20180212 18:36:28< vultraz> We need to look for: Batal, Hadaf, Jawal, Mighwar, Khalid, Tabib, Shuja, Mufariq, Rasikh, Tineen, Qanas, Rami, Naffat, Muharib, Faris, Hakim, Saree, Ghazi, Monawish, Mudafi, Qatif_al_nar, Jundi, Khaiyal, Arif
20180212 18:36:37< vultraz> TadCarlucci: please grep for ANY of those in data/
20180212 18:37:10< vultraz> (I don't have grep)
20180212 18:37:40< vultraz> give me a list on discord
20180212 18:45:59< irker578> wesnoth: Charles Dang wesnoth:master 91e0bb491179 / data/ (core/macros/deprecated-utils.cfg test/maps/pathfind_1.cfg): Fixed some remaining uses of deprecated Khalifate names https://github.com/wesnoth/wesnoth/commit/91e0bb4911797ccf4d429cbdebf2917f20862c4a
20180212 18:46:09< vultraz> oh, fuck me. I used [ci skip] on a commit that's supposed to fix the tests
20180212 18:50:18< matthiaskrgr> lol
20180212 18:52:04< zookeeper> going afk, good luck this time.
20180212 18:52:38< irker578> wesnoth: Charles Dang wesnoth:master f5aad72889d5 / data/core/ (units.cfg units/dunefolk/deprecated.cfg): wmlindent run https://github.com/wesnoth/wesnoth/commit/f5aad72889d51411a13619da0f3aba9a37562c43
20180212 19:05:00< irker578> wesnoth: Gregory A Lundberg wesnoth:master 9c1a80043c9d / data/core/units.cfg: One last Khalifate change https://github.com/wesnoth/wesnoth/commit/9c1a80043c9d652584f76a8a7f6ca71519ea6b03
20180212 19:07:22< TadCarlucci> See, crisis averted WML tests run, C++ tests run w/o LTO. Are there any more show-stoppers?
20180212 19:08:17< JyrkiVesterinen> Fortunately it was just unit renaming. :)
20180212 19:09:24< TadCarlucci> What about that exception from resizing the window or whatever Ravana just reported? /q something or other? Can it reproduce?
20180212 19:09:47< Ravana_> I mentioned in report that I can't reproduce it
20180212 19:09:48< JyrkiVesterinen> Ravana couldn't reproduce it. I'm not trying.
20180212 19:11:15< TadCarlucci> vultraz Sounds to me like you simply need to await Travis and Appveyor and we're good to go for a tag.
20180212 19:22:02-!- octalot [~steve@178.165.130.195.wireless.dyn.drei.com] has joined #wesnoth-dev
20180212 19:24:26-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20180212 19:26:12< TadCarlucci> My systems say Travis and AppVeyor will both run to completion with no issues. Like AppVeyor I get a random failure on WML test_return timeout due to system load. Non-LTO C++ tests pass, no longer complain about deprecation. WML tests all pass. I have a green board.
20180212 19:50:13-!- travis-ci [~travis-ci@ec2-54-234-205-100.compute-1.amazonaws.com] has joined #wesnoth-dev
20180212 19:50:14< travis-ci> wesnoth/wesnoth#16468 (master - f5aad72 : Charles Dang): The build has errored.
20180212 19:50:14< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/340626283
20180212 19:50:14-!- travis-ci [~travis-ci@ec2-54-234-205-100.compute-1.amazonaws.com] has left #wesnoth-dev []
20180212 19:56:16-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has quit [Quit: .]
20180212 20:00:58< irker578> wesnoth: V N wesnoth:master ae048467ede4 / data/tools/wesnoth_addon_manager: addon_manager: simplify usage https://github.com/wesnoth/wesnoth/commit/ae048467ede441c358fd5a9193e34a570a7b57c2
20180212 20:16:40< irker578> wesnoth: loonycyborg wesnoth:bcrypt_auth 3db8cb2ae704 / src/ (game_initialization/multiplayer.cpp hash.cpp hash.hpp): Only check salt for having correct prefix rather being full hash https://github.com/wesnoth/wesnoth/commit/3db8cb2ae704c67fe2c23a35cad085f4203a700f
20180212 20:18:29-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20180212 20:18:40-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20180212 20:24:43-!- travis-ci [~travis-ci@ec2-54-234-205-100.compute-1.amazonaws.com] has joined #wesnoth-dev
20180212 20:24:44< travis-ci> wesnoth/wesnoth#16469 (master - 9c1a800 : Gregory A Lundberg): The build has errored.
20180212 20:24:44< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/340631476
20180212 20:24:44-!- travis-ci [~travis-ci@ec2-54-234-205-100.compute-1.amazonaws.com] has left #wesnoth-dev []
20180212 21:24:04-!- Nobun [~user@5.170.240.84] has quit [Quit: WeeChat 2.1-dev]
20180212 21:37:45-!- vladimirslavik [~vslavik@95.82.135.184] has quit [Quit: Leaving]
20180212 21:59:01-!- Oebele [~quassel@143.177.58.202] has quit [Remote host closed the connection]
20180212 22:09:24-!- octalot [~steve@178.165.130.195.wireless.dyn.drei.com] has quit [Ping timeout: 260 seconds]
20180212 22:21:39-!- octalot [~steve@178.115.128.248.wireless.dyn.drei.com] has joined #wesnoth-dev
20180212 22:36:26-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20180212 23:06:24-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180212 23:06:30-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20180212 23:07:58-!- DeFender [~DeFender1@dsl217-132-38-129.bb.netvision.net.il] has joined #wesnoth-dev
20180212 23:10:20-!- DeFender1031 [~DeFender1@46-116-68-9.bb.netvision.net.il] has quit [Ping timeout: 256 seconds]
20180212 23:17:46-!- irker578 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20180212 23:45:05-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 248 seconds]
20180212 23:45:48-!- irker706 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20180212 23:45:48< irker706> wesnoth: Celtic Minstrel wesnoth:master 0e9935593d54 / changelog src/scripting/lua_gui2.cpp: Lua GUI2: Support sliders in set_dialog_callback https://github.com/wesnoth/wesnoth/commit/0e9935593d54a66974ce43a4feefbbbcc11e1999
20180212 23:45:48< irker706> wesnoth: Charles Dang wesnoth:master b1dbee0a2d40 / data/core/units/dunefolk/deprecated.cfg: Don't have macro in translatable string https://github.com/wesnoth/wesnoth/commit/b1dbee0a2d40ea08591b87803d11dfb347a4f79f
20180212 23:50:10-!- mode/#wesnoth-dev [+o vultraz] by ChanServ
20180212 23:50:44-!- stikonas_ is now known as stikonas
20180212 23:51:11<@vultraz> still can't set the topic
--- Log closed Tue Feb 13 00:00:06 2018