--- Log opened Fri Feb 16 00:00:10 2018
20180216 00:08:26-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180216 00:08:32-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20180216 01:04:56< irker416> wesnoth/wesnoth:master pentarctagon 1d9aac0de1 Fixes cmake's cache getting corrupted in AppVeyor: 1/6 builds failed
20180216 01:04:57< irker416> Details vs2017/Debug: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-master-1160
20180216 01:09:55-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20180216 01:42:16-!- shadowm [~iris@wesnoth/developer/shadowm] has joined #wesnoth-dev
20180216 02:15:12-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20180216 02:33:49-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180216 02:33:57-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20180216 02:50:23< irker416> wesnoth: Charles Dang wesnoth:master ac42387aac82 / RELEASE_NOTES: Updated RELEASE_NOTES https://github.com/wesnoth/wesnoth/commit/ac42387aac82e26ffbf644a6ce4468a3d13cce96
20180216 02:51:53< celticminstrel> Ooh.
20180216 03:05:05-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180216 03:05:15-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20180216 03:26:35< irker416> wesnoth: Charles Dang wesnoth:master a8bc737c011d / changelog: Updated changelog https://github.com/wesnoth/wesnoth/commit/a8bc737c011d1654d3b44993fef53174a427af78
20180216 03:27:41< vultraz> there, saves celticminstrel effort later
20180216 03:28:06 * celticminstrel thumbs-up
20180216 03:39:20-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180216 03:39:26-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20180216 03:53:17-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180216 03:53:25-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20180216 04:21:09-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The computer falls into a deep sleep, to awake again some other day!]
20180216 04:42:10-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180216 04:42:15-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20180216 05:25:19-!- higgins [~higgins@68.ip-149-56-14.net] has quit [Ping timeout: 268 seconds]
20180216 05:37:12-!- higgins [~higgins@68.ip-149-56-14.net] has joined #wesnoth-dev
20180216 06:03:30-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has joined #wesnoth-dev
20180216 06:28:03-!- irker416 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20180216 06:35:44-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has quit [Quit: .]
20180216 07:19:07-!- Oebele [~quassel@143.177.58.202] has joined #wesnoth-dev
20180216 07:23:11-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20180216 07:25:14-!- JyrkiVesterinen [~JyrkiVest@195-192-251-124.s1networks.fi] has joined #wesnoth-dev
20180216 08:09:55-!- atarocch [~atarocch@93.56.164.28] has joined #wesnoth-dev
20180216 08:45:26-!- irker776 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20180216 08:45:26< irker776> wesnoth/wesnoth:master Charles Dang a8bc737c01 Updated changelog AppVeyor: All builds passed
20180216 08:58:26< irker776> wesnoth/wesnoth:master pentarctagon 3f8a049b75 Fixes cmake's cache getting corrupted in AppVeyor: All builds passed
20180216 10:12:35< irker776> wesnoth: Charles Dang wesnoth:master f773996a937b / src/ (preferences/general.cpp video.cpp): Minor cleanups to some resolution/window size code https://github.com/wesnoth/wesnoth/commit/f773996a937b976a8c6982da6bafea1dc7bf67c5
20180216 10:12:38< irker776> wesnoth: Charles Dang wesnoth:master 5c9380e58ae3 / src/preferences/general.cpp: Default to fullscreen on, tweak default window res https://github.com/wesnoth/wesnoth/commit/5c9380e58ae370230754673153d67ad460e59667
20180216 10:28:01-!- vladimirslavik [vslavik@nat/redhat/x-oxkgucxlcgtgjtmx] has joined #wesnoth-dev
20180216 10:28:51< Soliton> vultraz: i guess your assumption is that the reason why fullscreen defaults to false is not an issue anymore?
20180216 10:29:11< JyrkiVesterinen> What was the reason anyway?
20180216 10:29:39< Soliton> commit b45809a33e8 explains it.
20180216 10:29:50< vultraz> I am not aware of this reason. *looks*.
20180216 10:30:22< vultraz> Soliton: very likely not an issue anymore
20180216 10:30:29< JyrkiVesterinen> "Om my LCD fullscreen results in an invalid mode and gives a black screen and I need to use ctrl-F to see something again."
20180216 10:30:35< JyrkiVesterinen> Indeed, not an issue any more.
20180216 10:30:47< Soliton> excellent.
20180216 10:30:56< JyrkiVesterinen> With SDL2, we use borderless fullscreen: in other words, we do NOT enter fullscreen mode.
20180216 10:31:14< JyrkiVesterinen> Instead, we just disable window borders and draw a window that covers the entire screen.
20180216 10:33:41< Soliton> i think it's usually useful to write such reasons into the commit message.
20180216 10:34:18< JyrkiVesterinen> Well, vultraz didn't know that fullscreen had been disabled by default because true fullscreen misbehaved for some users.
20180216 10:48:29< irker776> wesnoth: Charles Dang wesnoth:master 3b13a4bd496d / changelog: Updated changelog https://github.com/wesnoth/wesnoth/commit/3b13a4bd496d21761bbcb403ae644ed4ef981f81
20180216 10:49:51< irker776> wesnoth/wesnoth:master Charles Dang 3b13a4bd49 Updated changelog AppVeyor: vs2013/Release Failed
20180216 10:49:52< irker776> Details: https://ci.appveyor.com/project/wesnoth/wesnoth/build/Wesnoth-VS2013-master-1473
20180216 10:51:56-!- JyrkiVesterinen [~JyrkiVest@195-192-251-124.s1networks.fi] has quit [Quit: .]
20180216 10:57:18-!- travis-ci [~travis-ci@ec2-54-167-157-129.compute-1.amazonaws.com] has joined #wesnoth-dev
20180216 10:57:19< travis-ci> wesnoth/wesnoth#16504 (master - 5c9380e : Charles Dang): The build has errored.
20180216 10:57:19< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/342271550
20180216 10:57:19-!- travis-ci [~travis-ci@ec2-54-167-157-129.compute-1.amazonaws.com] has left #wesnoth-dev []
20180216 11:21:58< vultraz> Soliton: did I do this correctly https://github.com/Vultraz/wesnoth/commit/6a0809b4f81cddb8c9a1b25d75b31040654da560
20180216 11:23:01< vultraz> (ah, I do see one mistake, key name mismatch)
20180216 11:23:27< vultraz> or wait, no, nvm, it's right
20180216 11:23:30< vultraz> was looking at slots
20180216 11:25:29-!- vn971 [~vasya@94.158.103.15] has quit [Ping timeout: 255 seconds]
20180216 11:30:20-!- vn971 [~vasya@94.158.103.15] has joined #wesnoth-dev
20180216 11:49:54< Soliton> what's the idea? if you want to change the format just change how it's displayed on the client?
20180216 11:52:37-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20180216 11:54:27< vultraz> Just think it makes more sense to handle the formatting client side
20180216 11:54:47< vultraz> Instead of taking the server data, formatting it, sending it, the splitting it
20180216 11:54:56< vultraz> Then
20180216 12:01:04-!- JyrkiVesterinen [~JyrkiVest@195-192-251-124.s1networks.fi] has joined #wesnoth-dev
20180216 12:03:50< JyrkiVesterinen> vultraz: At least use set_attr_int().
20180216 12:04:13< JyrkiVesterinen> Not that it's any more efficient, but at least it would hide some boilerplate.
20180216 12:04:17< vultraz> See, that’s why I didn’t just commit it
20180216 12:04:49-!- Nobun [~user@5.170.243.0] has joined #wesnoth-dev
20180216 12:28:20< Soliton> ok, so you've split the turn key into [turn_data] current,max and the slot key into [slot_data] vacant,max.
20180216 12:28:44< vultraz> yes
20180216 12:29:24< Soliton> sounds good. just needs some compatibility code so you can still join old servers.
20180216 12:30:49< vultraz> I haven't added any compatibility code for any of my other changed. You're not supposed to be able to join older servers.
20180216 12:31:07< vultraz> The fact that 1.13.11+dev can join the 1.12 server is a special case
20180216 12:31:15< vultraz> that's specially allowed 
20180216 12:31:36< Soliton> what other changes?
20180216 12:32:09< vultraz> modification names and studd
20180216 12:32:11< vultraz> stuff
20180216 12:33:06< Soliton> so you did not find it useful that you could join 1.12 with the dev version? you do not want that convenience in the future?
20180216 12:34:16< Soliton> please point out the commits with your changes you're referring to.
20180216 12:36:19< vultraz> 002b1a3c871ff8f782d1a1449fc2b4ee9b7f6b29, 1bfa170856edacb235a35f5b6c3d874ff925f655 ... guess those are it?
20180216 12:39:06< Soliton> seems to me like in both commits you've just added attributes. that's already compatible.
20180216 12:41:06< Soliton> well, assuming the client does not crash or whatever if an attribute is missing. i did not check that in detail.
20180216 12:41:50< vultraz> nah
20180216 12:42:03< vultraz> that only happens if config::child is used
20180216 12:42:47< Soliton> perhaps it can be made automatically compatible if we don't add a new tag but just add another attribute?
20180216 12:43:13< Soliton> like change slots into slots and max_slots or so.
20180216 12:46:26< Soliton> backwards compatibility doesn't need to be perfect as far as i'm concerned but it should not crash the client/server and be somewhat usable.
20180216 13:02:30-!- Nobun [~user@5.170.243.0] has quit [Ping timeout: 265 seconds]
20180216 13:08:16-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 256 seconds]
20180216 13:14:15-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20180216 13:18:37-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20180216 13:50:28-!- irker776 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20180216 13:53:37< celticminstrel> Just FTR vultraz, we should add some stuff to the Lua/WML section before actually posting the release notes.
20180216 13:53:39-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The computer falls into a deep sleep, to awake again some other day!]
20180216 13:55:59-!- JyrkiVesterinen [~JyrkiVest@195-192-251-124.s1networks.fi] has quit [Ping timeout: 256 seconds]
20180216 13:57:24-!- JyrkiVesterinen [~JyrkiVest@195-192-251-124.s1networks.fi] has joined #wesnoth-dev
20180216 14:12:59-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180216 14:13:05-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20180216 14:47:10-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 240 seconds]
20180216 14:47:15-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20180216 14:50:33< Ravana_> will this release start 1.14 addons server?
20180216 14:53:18< Soliton> "The 1.14 add-ons server will replace the 1.13 server once RC 1 is released."
20180216 15:07:18-!- DeFender [~DeFender1@dsl217-132-38-129.bb.netvision.net.il] has quit [Quit: I'm not back now.]
20180216 15:13:06-!- JyrkiVesterinen [~JyrkiVest@195-192-251-124.s1networks.fi] has quit [Quit: .]
20180216 15:22:19-!- Bonobo [~Bonobo@61.68.156.44] has quit [Ping timeout: 256 seconds]
20180216 15:44:20-!- vultraz [uid24821@wesnoth/developer/vultraz] has quit [Quit: Connection closed for inactivity]
20180216 15:49:56-!- irker552 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20180216 15:49:56< irker552> wesnoth/wesnoth:master Charles Dang 3b13a4bd49 Updated changelog AppVeyor: 1/2 builds failed
20180216 15:49:56< irker552> Details vs2013/Release: https://ci.appveyor.com/project/wesnoth/wesnoth/build/Wesnoth-VS2013-master-1473
20180216 17:27:52-!- stikonas_ is now known as stikonas
20180216 17:49:31-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has joined #wesnoth-dev
20180216 17:58:45-!- vladimirslavik [vslavik@nat/redhat/x-oxkgucxlcgtgjtmx] has quit [Quit: Leaving]
20180216 18:50:43-!- irker552 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20180216 19:00:24-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20180216 19:01:01-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer]
20180216 19:32:29-!- vultraz [uid24821@wesnoth/developer/vultraz] has joined #wesnoth-dev
20180216 19:37:39-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has quit [Quit: .]
20180216 19:53:26-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 256 seconds]
20180216 19:57:48-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 240 seconds]
20180216 19:59:01-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20180216 20:00:24-!- stikonas_ is now known as stikonas
20180216 21:44:48-!- irker512 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20180216 21:44:48< irker512> wesnoth: Iris Morelle wesmere:master 12b2514d41df / wesmere/sass/_version.scss: sass: Fix weird version number https://github.com/wesnoth/wesmere/commit/12b2514d41df67c056ff622908cac00ddcc4577c
20180216 22:30:33-!- sigurdfd [sigurdfd@dynamic-acs-72-23-110-196.zoominternet.net] has joined #wesnoth-dev
20180216 22:39:56-!- Oebele [~quassel@143.177.58.202] has quit [Remote host closed the connection]
20180216 22:51:26< irker512> wesnoth: sigurdfdragon wesnoth:master dfdf8ccacdbe / data/test/maps/pathfind_1.cfg: Update ids to match type changes in 91e0bb491179 https://github.com/wesnoth/wesnoth/commit/dfdf8ccacdbeca63598ef003644fac5c7d8a2c42
20180216 23:03:59< irker512> wesnoth: Iris Morelle wesnoth:master 8413b1014ed1 / data/tools/ (addon_manager/html.py helptrailer.html unit_tree/html_output.py): wesmere: Copyright/attribution update https://github.com/wesnoth/wesnoth/commit/8413b1014ed18e489fd7000b51087f42dff56fa0
20180216 23:04:02< irker512> wesnoth: Iris Morelle wesnoth:master c9eee2d3519d / / (86 files in 13 dirs): Copyright/attribution update https://github.com/wesnoth/wesnoth/commit/c9eee2d3519dc3af43a9b1d04c14709719db005e
20180216 23:04:05< irker512> wesnoth: Iris Morelle website:master 401fdc2ae70d / gettext.wesnoth.org/includes/wesmere.php: New Year copyright update + attribution update https://github.com/wesnoth/website/commit/401fdc2ae70d7d585fe8489f81c7ffdda0c50f6e
20180216 23:04:09< irker512> wesnoth: Iris Morelle wesmere:master 6a6791919486 / / (40 files in 11 dirs): Copyright/attribution/link updates https://github.com/wesnoth/wesmere/commit/6a6791919486aed31316de0aad72e043f52d14c5
20180216 23:11:33< irker512> wesnoth: Iris Morelle wesmere:master 8929b2b9f23d / / (44 files in 12 dirs): Copyright/attribution/link updates https://github.com/wesnoth/wesmere/commit/8929b2b9f23d2f30248ced4b3200d48baf8efa87
20180216 23:17:31< irker512> wesnoth: Iris Morelle wesnoth:master 8549e93a1313 / data/campaigns/ (4 files in 4 dirs): Copyright/attribution update https://github.com/wesnoth/wesnoth/commit/8549e93a13136036640527bd2461feea83fa5039
--- Log closed Sat Feb 17 00:00:11 2018