--- Log opened Mon Feb 19 00:00:14 2018
20180219 00:34:59-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 260 seconds]
20180219 00:45:01-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180219 00:45:10-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20180219 00:50:45< irker062> wesnoth/wesnoth:master Celtic Minstrel ae0ba18f96 Tutorial: Fix flag tooltip reading "Konr AppVeyor: All builds passed
20180219 01:11:41-!- Bonobo [~Bonobo@61.68.156.44] has joined #wesnoth-dev
20180219 01:24:47< vultraz> celticminstrel: does that get successfully translated
20180219 01:24:55< vultraz> the side name i mean
20180219 01:25:07< celticminstrel> According to wedge009, yes it does.
20180219 01:25:15< vultraz> then we can closethebug
20180219 01:25:25< celticminstrel> Yeah, someone did already. Possibly wedge009.
20180219 01:26:41< vultraz> sweet
20180219 01:26:53< vultraz> there's another one
20180219 01:27:06< vultraz> oh
20180219 01:27:08< vultraz> also closed
20180219 01:27:08< vultraz> damn
20180219 01:30:55< celticminstrel> XD
20180219 01:31:00< celticminstrel> Which one is that?
20180219 01:31:08< vultraz> https://github.com/wesnoth/wesnoth/issues/1302
20180219 01:31:21< celticminstrel> Ah, right.
20180219 02:28:08< vultraz> oh, fucking hell. I need to refactor the *unit* storage of ability data too....
20180219 02:28:29< vultraz> GDI
20180219 02:31:48< vultraz> y u do dis game
20180219 02:34:09< vultraz> celticminstrel: 
20180219 02:34:11< vultraz> "_("<header>text='Units with this ability'</header>")"
20180219 02:34:22< vultraz> does this mean the help markup is in the translatable string...
20180219 02:43:57-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180219 02:44:03-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20180219 03:59:54-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180219 04:00:00-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20180219 04:07:00-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 265 seconds]
20180219 04:44:25< vultraz> why does a unit keep a config of the abilities it has
20180219 04:44:40< vultraz> this makes everything infinitely harder
20180219 05:23:43-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has joined #wesnoth-dev
20180219 05:36:05< celticminstrel> vultraz: Pretty sure the help markup is in the translatable string.
20180219 05:36:12< vultraz> @(*#(*#(*(*&@(*!()@(!_)(
20180219 05:36:14< celticminstrel> So don't touch that.
20180219 05:36:16< vultraz> and we can't fix it!
20180219 05:36:27< celticminstrel> Well we weren't planning to anyway, so...
20180219 05:36:33< vultraz> one million years dungeon on whoever did that
20180219 05:36:52< celticminstrel> That said, I think we can still fix typos in translatable strings as long as it's put in pofix and applied to everything.
20180219 05:37:08< celticminstrel> But IIUC that doesn't apply here.
20180219 05:37:56< vultraz> we can't pofix this away?
20180219 05:39:10< JyrkiVesterinen> Too large change for pofix IMHO.
20180219 05:42:40< celticminstrel> I have no idea what the change is.
20180219 05:42:52< celticminstrel> I have no idea what's wrong with the help string you pasted.
20180219 05:43:08< JyrkiVesterinen> Original string: <header>text='Units with this ability'</header>
20180219 05:43:19< JyrkiVesterinen> Presumed final string: Units with this ability
20180219 05:43:38< celticminstrel> So just factoring the markup out of the string?
20180219 05:43:51< celticminstrel> Eh, I kinda don't think that's even worth it.
20180219 05:44:00< celticminstrel> It's not like you can do it in the general case for help strings.
20180219 05:50:27< vultraz> what?
20180219 06:33:16-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has quit [Quit: .]
20180219 07:09:48< irker062> wesnoth: Iris Morelle wesmere:develop 410c376818bf / wesmere/sass/forums.scss: sass/forums: Eliminate extra margin from prosilver https://github.com/wesnoth/wesmere/commit/410c376818bff2949879813b15a6c4722b6edd7b
20180219 07:15:30-!- JyrkiVesterinen [~JyrkiVest@195-192-251-124.s1networks.fi] has joined #wesnoth-dev
20180219 08:03:29-!- celticminstrel is now known as celmin|sleep
20180219 08:04:54< celmin|sleep> BTW (before I sleep) it'd be nice if the reorganized Lua API could be ready for 1.14...
20180219 08:05:41< JyrkiVesterinen> IMO, it's too late for API changes.
20180219 08:06:04< celmin|sleep> Well, it'd be mainly adding aliases to existing things rather than anything genuinely new.
20180219 08:07:30< celmin|sleep> (Marking the old versions deprecated too, I guess, but that shouldn't be a problem as long as deprecation spam isn't a thing, right?)
20180219 08:07:59< celmin|sleep> Main point is it wouldn't break anything.
20180219 08:08:13< celmin|sleep> Deprecation step could even be put off until after 1.14 if that's an issue.
20180219 08:08:22< irker062> wesnoth: Iris Morelle wesmere:develop 115fd165f36e / wesmere/sass/forums.scss: sass/forums: Remove negative horizontal margin from AcidTech navbars https://github.com/wesnoth/wesmere/commit/115fd165f36e556d45ef573f557607f603b41a3a
20180219 08:08:24< irker062> wesnoth: Iris Morelle wesmere:develop 71cf8593fd0a / wesmere/sass/forums.scss: sass/forums: AcidTech also needs the content overflow fix on small viewports https://github.com/wesnoth/wesmere/commit/71cf8593fd0a69fdcdbbe6938f79b8778b1de1ff
20180219 08:08:26< irker062> wesnoth: Iris Morelle wesmere:develop cde54402d1c0 / wesmere/sass/forums.scss: sass/forums: Remove the negative AcidTech navbar margin on large viewports only https://github.com/wesnoth/wesmere/commit/cde54402d1c0bf6e05b116fce73099fa068d1506
20180219 08:13:21< irker062> wesnoth: Iris Morelle wesmere:develop 0fffa2e97dc3 / wesmere/sass/forums.scss: sass/forums: Formatting/typo fix https://github.com/wesnoth/wesmere/commit/0fffa2e97dc3be48d0e652ad1022c616e6825f3e
20180219 08:45:37< Soliton> pofix can do anything that does not need some translator to look over it.
20180219 08:46:26< Soliton> so that translatable string with (for the translation) useless markup in it can be adjusted with pofix.
20180219 08:46:36< JyrkiVesterinen> I see. That's good, then. :)
20180219 08:48:25< Soliton> as said though in general it is not an issue to have markup in translatable strings. just when the only thing translators can do is accidentally break it then it's not useful.
20180219 08:52:17< Soliton> i wonder if it'd be useful to give the translators a hint that this string is in single quotes so it's going to break should they use a single quote in their translation. not sure how likely that is to be a problem in general, not specifically for this case.
20180219 09:15:28-!- vladimirslavik [vslavik@nat/redhat/x-ulfleklshzzjbdyd] has joined #wesnoth-dev
20180219 09:34:43-!- Coffee_irc [~david@61.68.156.44] has joined #wesnoth-dev
20180219 09:52:10-!- vn971 [~vasya@94.158.103.15] has joined #wesnoth-dev
20180219 10:15:01-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20180219 10:21:11-!- JyrkiVesterinen [~JyrkiVest@195-192-251-124.s1networks.fi] has quit [Quit: .]
20180219 10:24:46< vultraz> zookeeper: https://forums.wesnoth.org/viewtopic.php?p=623574#p623574
20180219 10:37:59-!- travis-ci [~travis-ci@ec2-54-226-190-62.compute-1.amazonaws.com] has joined #wesnoth-dev
20180219 10:38:00< travis-ci> hrubymar10/wesnoth#5 (add_xcode_travis - bf16f20 : Sofartin): The build was fixed.
20180219 10:38:00< travis-ci> Build details : https://travis-ci.org/hrubymar10/wesnoth/builds/343303156
20180219 10:38:00-!- travis-ci [~travis-ci@ec2-54-226-190-62.compute-1.amazonaws.com] has left #wesnoth-dev []
20180219 10:45:47< zookeeper> vultraz, hard to say, seeing as doofus's thing doesn't seem to be working at all on my build. or it works for like one orc village, not the others.
20180219 10:45:59< vultraz> oh dear
20180219 10:46:05-!- travis-ci [~travis-ci@ec2-54-161-62-69.compute-1.amazonaws.com] has joined #wesnoth-dev
20180219 10:46:06< vultraz> perhaps he implemented it wrong?
20180219 10:46:06< travis-ci> hrubymar10/wesnoth#6 (add_xcode_travis - 900d661 : Sofartin): The build was broken.
20180219 10:46:06< travis-ci> Build details : https://travis-ci.org/hrubymar10/wesnoth/builds/343306938
20180219 10:46:06-!- travis-ci [~travis-ci@ec2-54-161-62-69.compute-1.amazonaws.com] has left #wesnoth-dev []
20180219 10:48:49< Soliton> "we'll be updating this page in the coming days with new reporting protocols"  what does that mean? that note seems to be there since a while.
20180219 10:49:02< irker062> wesnoth: Charles Dang wesnoth:master dec677f2c549 / src/ (9 files in 4 dirs): Refactor unit type ability metadata storage https://github.com/wesnoth/wesnoth/commit/dec677f2c549d954af5f52ee86ea1d52bc594492
20180219 10:49:05< irker062> wesnoth: Charles Dang wesnoth:master b477f40a7f05 / src/image.cpp: Removed direct use of boost::hash_value https://github.com/wesnoth/wesnoth/commit/b477f40a7f05acb97603921e05272521e240c96e
20180219 10:49:10< vultraz> Soliton: what page?
20180219 10:49:36< Soliton> ReportingBugs in the wiki.
20180219 10:49:46< vultraz> ah
20180219 10:50:03< vultraz> yeah, was there from the bug tracker trasition
20180219 10:50:25< zookeeper> okay, i bothered to solve VS's stupid license/login thingy so i can actually try and start compiling again...
20180219 10:50:28< Soliton> looks like that note can just be removed now.
20180219 10:52:46-!- travis-ci [~travis-ci@ec2-54-205-26-29.compute-1.amazonaws.com] has joined #wesnoth-dev
20180219 10:52:47< travis-ci> hrubymar10/wesnoth#7 (add_xcode_travis - e442f6a : Sofartin): The build has errored.
20180219 10:52:47< travis-ci> Build details : https://travis-ci.org/hrubymar10/wesnoth/builds/343308509
20180219 10:52:47-!- travis-ci [~travis-ci@ec2-54-205-26-29.compute-1.amazonaws.com] has left #wesnoth-dev []
20180219 10:57:26-!- travis-ci [~travis-ci@ec2-54-161-62-69.compute-1.amazonaws.com] has joined #wesnoth-dev
20180219 10:57:27< travis-ci> hrubymar10/wesnoth#8 (add_xcode_travis - f9cfbd9 : Sofartin): The build has errored.
20180219 10:57:27< travis-ci> Build details : https://travis-ci.org/hrubymar10/wesnoth/builds/343311187
20180219 10:57:27-!- travis-ci [~travis-ci@ec2-54-161-62-69.compute-1.amazonaws.com] has left #wesnoth-dev []
20180219 11:01:11-!- travis-ci [~travis-ci@ec2-54-205-26-29.compute-1.amazonaws.com] has joined #wesnoth-dev
20180219 11:01:12< travis-ci> hrubymar10/wesnoth#9 (add_xcode_travis - c635d7b : Sofartin): The build has errored.
20180219 11:01:12< travis-ci> Build details : https://travis-ci.org/hrubymar10/wesnoth/builds/343312279
20180219 11:01:12-!- travis-ci [~travis-ci@ec2-54-205-26-29.compute-1.amazonaws.com] has left #wesnoth-dev []
20180219 11:06:34-!- travis-ci [~travis-ci@ec2-54-161-62-69.compute-1.amazonaws.com] has joined #wesnoth-dev
20180219 11:06:35< travis-ci> hrubymar10/wesnoth#10 (add_xcode_travis - 06b19f3 : Sofartin): The build has errored.
20180219 11:06:35< travis-ci> Build details : https://travis-ci.org/hrubymar10/wesnoth/builds/343313931
20180219 11:06:35-!- travis-ci [~travis-ci@ec2-54-161-62-69.compute-1.amazonaws.com] has left #wesnoth-dev []
20180219 11:15:32-!- travis-ci [~travis-ci@ec2-54-205-26-29.compute-1.amazonaws.com] has joined #wesnoth-dev
20180219 11:15:33< travis-ci> wesnoth/wesnoth#16520 (master - b477f40 : Charles Dang): The build was broken.
20180219 11:15:33< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/343309256
20180219 11:15:33-!- travis-ci [~travis-ci@ec2-54-205-26-29.compute-1.amazonaws.com] has left #wesnoth-dev []
20180219 11:22:55-!- JyrkiVesterinen [~JyrkiVest@195-192-251-124.s1networks.fi] has joined #wesnoth-dev
20180219 12:19:35-!- travis-ci [~travis-ci@ec2-54-205-26-29.compute-1.amazonaws.com] has joined #wesnoth-dev
20180219 12:19:36< travis-ci> hrubymar10/wesnoth#11 (add_xcode_travis - 9f736d6 : Sofartin): The build has errored.
20180219 12:19:36< travis-ci> Build details : https://travis-ci.org/hrubymar10/wesnoth/builds/343337611
20180219 12:19:36-!- travis-ci [~travis-ci@ec2-54-205-26-29.compute-1.amazonaws.com] has left #wesnoth-dev []
20180219 12:22:29-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20180219 12:24:16-!- travis-ci [~travis-ci@ec2-54-205-26-29.compute-1.amazonaws.com] has joined #wesnoth-dev
20180219 12:24:17< travis-ci> hrubymar10/wesnoth#12 (add_xcode_travis - 3f68c93 : Sofartin): The build has errored.
20180219 12:24:17< travis-ci> Build details : https://travis-ci.org/hrubymar10/wesnoth/builds/343338959
20180219 12:24:17-!- travis-ci [~travis-ci@ec2-54-205-26-29.compute-1.amazonaws.com] has left #wesnoth-dev []
20180219 12:29:19-!- travis-ci [~travis-ci@ec2-54-161-62-69.compute-1.amazonaws.com] has joined #wesnoth-dev
20180219 12:29:20< travis-ci> hrubymar10/wesnoth#13 (add_xcode_travis - a969620 : Sofartin): The build passed.
20180219 12:29:20< travis-ci> Build details : https://travis-ci.org/hrubymar10/wesnoth/builds/343340402
20180219 12:29:20-!- travis-ci [~travis-ci@ec2-54-161-62-69.compute-1.amazonaws.com] has left #wesnoth-dev []
20180219 12:30:01< Soliton> perhaps we should turn off notices about PR builds here.
20180219 12:34:39-!- travis-ci [~travis-ci@ec2-54-226-190-62.compute-1.amazonaws.com] has joined #wesnoth-dev
20180219 12:34:40< travis-ci> hrubymar10/wesnoth#14 (add_xcode_travis - 46c1ecc : Sofartin): The build has errored.
20180219 12:34:40< travis-ci> Build details : https://travis-ci.org/hrubymar10/wesnoth/builds/343341993
20180219 12:34:40-!- travis-ci [~travis-ci@ec2-54-226-190-62.compute-1.amazonaws.com] has left #wesnoth-dev []
20180219 12:35:27< JyrkiVesterinen> https://docs.travis-ci.com/user/notifications/
20180219 12:35:35< JyrkiVesterinen> "Pull Request builds do not trigger IRC notifications."
20180219 12:35:46< JyrkiVesterinen> Apparently those notices are not from PRs...
20180219 12:35:51< JyrkiVesterinen> They are from forks.
20180219 12:36:17< Soliton> ah, well same thing. would be nice if we can turn that off.
20180219 12:36:20< irker062> wesnoth/wesnoth:master Charles Dang b477f40a7f Removed direct use of boost::hash_value AppVeyor: vs2017/Debug Failed
20180219 12:36:21< irker062> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-master-1185
20180219 12:36:39< JyrkiVesterinen> Forks are under control of people who maintain them.
20180219 12:37:00< JyrkiVesterinen> We have no way to directly block forks from sending notifications to our channel.
20180219 12:37:12< JyrkiVesterinen> I'll try to talk to hrubymar privately.
20180219 12:37:28< Soliton> sure, but we can probably add something that checks that this build is wesnoth master or whatever and then people will have to explicitely change the config to enable it.
20180219 12:37:50< matthiaskrgr> https://github.com/wesnoth/wesnoth/blob/master/.travis.yml#L78  
20180219 12:37:54< JyrkiVesterinen> AFAIK, it isn't possible.
20180219 12:38:15< JyrkiVesterinen> If a fork has Travis CI configured, it operates with our .travis.yml.
20180219 12:38:23< JyrkiVesterinen> Which has IRC notifications enabled.
20180219 12:38:51< Soliton> and there is no way to check in our travis.yml that this is wesnoth master or so?
20180219 12:41:19-!- travis-ci [~travis-ci@ec2-54-226-190-62.compute-1.amazonaws.com] has joined #wesnoth-dev
20180219 12:41:20< travis-ci> hrubymar10/wesnoth#15 (add_xcode_travis - a0c5d9b : Sofartin): The build passed.
20180219 12:41:20< travis-ci> Build details : https://travis-ci.org/hrubymar10/wesnoth/builds/343342932
20180219 12:41:20-!- travis-ci [~travis-ci@ec2-54-226-190-62.compute-1.amazonaws.com] has left #wesnoth-dev []
20180219 12:41:29< JyrkiVesterinen> YAML isn't a scripting language. There are no "checks".
20180219 12:41:48< JyrkiVesterinen> "I didn't comment irc thing... I'll comment it in next commit. Sorry"
20180219 12:41:59< JyrkiVesterinen> He'll disable the notifications in his next commit.
20180219 12:42:00< Soliton> there's shell script parts in it.
20180219 12:42:32< JyrkiVesterinen> From YAML's perspective, they are just strings. Travis then runs those scripts as shell scripts.
20180219 12:50:05-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180219 12:50:11-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20180219 12:53:37< Soliton> looks like there is some way to do this with encryption: https://github.com/mozilla/build-tools/commit/c13a297  not sure how that'd translate to us yet.
20180219 12:56:21< JyrkiVesterinen> I can't find documentation for the "secure" key.
20180219 12:56:29< JyrkiVesterinen> I can't follow how it would help, either.
20180219 13:00:25< Soliton> i don't understand either so far. perhaps encrypt with some repo based token so it won't work for other repos/forks. don't have time to figure out more atm.
20180219 13:03:35-!- mkdroid [~null@unaffiliated/matthiaskrgr] has joined #wesnoth-dev
20180219 13:10:05-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180219 13:10:11-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20180219 13:28:27-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180219 13:28:33-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20180219 14:04:31-!- vultraz [uid24821@wesnoth/developer/vultraz] has quit [Quit: Connection closed for inactivity]
20180219 14:04:40-!- mkdroid [~null@unaffiliated/matthiaskrgr] has quit [Quit: I'll be back!]
20180219 14:44:25-!- vladimirslavik [vslavik@nat/redhat/x-ulfleklshzzjbdyd] has quit [Ping timeout: 256 seconds]
20180219 15:02:30< irker062> wesnoth/wesnoth:master Charles Dang b477f40a7f Removed direct use of boost::hash_value AppVeyor: 1/6 builds failed
20180219 15:02:31< irker062> Details vs2017/Debug: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-master-1185
20180219 15:03:15-!- vladimirslavik [vslavik@nat/redhat/x-bylrwwdwjtiqrtjj] has joined #wesnoth-dev
20180219 15:05:10-!- TadCarlucci [~lundberg@74.193.219.119] has quit [Remote host closed the connection]
20180219 15:12:12-!- JyrkiVesterinen [~JyrkiVest@195-192-251-124.s1networks.fi] has quit [Quit: .]
20180219 15:20:57-!- celmin|sleep is now known as celticminstrel
20180219 15:23:37-!- hrubymar10 [~textual@78.108.103.216] has joined #wesnoth-dev
20180219 15:25:17< irker062> wesnoth: Sofartin wesnoth:master dcd2123026f3 / projectfiles/Xcode/Fix_Xcode_Dependencies: Add missing pango dependence https://github.com/wesnoth/wesnoth/commit/dcd2123026f3750a823cba57c36b64faab77de08
20180219 15:37:33< celticminstrel> BTW, is there any reason to add extra_defines to [modification] or [resource]?
20180219 15:37:53< celticminstrel> For example, that could allow you to define a modification that enables the optional advancements in multiplayer.
20180219 15:38:29< Ravana_> I believe such changes are not synced properly
20180219 15:39:38< celticminstrel> But I'd think it would still work if you set require_modification=yes? Because in order to sync properly all that's really needed is that both sides have the same data.
20180219 15:42:49-!- travis-ci [~travis-ci@ec2-54-161-62-69.compute-1.amazonaws.com] has joined #wesnoth-dev
20180219 15:42:50< travis-ci> wesnoth/wesnoth#16522 (master - dcd2123 : Sofartin): The build is still failing.
20180219 15:42:51< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/343413164
20180219 15:42:51-!- travis-ci [~travis-ci@ec2-54-161-62-69.compute-1.amazonaws.com] has left #wesnoth-dev []
20180219 15:46:46-!- hrubymar10 [~textual@78.108.103.216] has quit [Quit: hrubymar10]
20180219 15:49:09-!- hrubymar10 [~textual@78.108.103.216] has joined #wesnoth-dev
20180219 15:54:49-!- hrubymar10 [~textual@78.108.103.216] has quit [Quit: hrubymar10]
20180219 15:57:34< irker062> wesnoth: Gregory A Lundberg wesnoth:master a3b513e8b800 / src/units/types.cpp: Fix compile errors https://github.com/wesnoth/wesnoth/commit/a3b513e8b800ebede7e8a61c57c48b1549005b68
20180219 16:01:44-!- TadCarlucci [~lundberg@74.193.219.119] has joined #wesnoth-dev
20180219 16:01:57-!- gfgtdf [~chatzilla@x4e363b81.dyn.telefonica.de] has joined #wesnoth-dev
20180219 16:03:30-!- gfgtdf [~chatzilla@x4e363b81.dyn.telefonica.de] has quit [Client Quit]
20180219 16:14:03-!- hrubymar10 [~textual@78.108.103.216] has joined #wesnoth-dev
20180219 16:21:04-!- travis-ci [~travis-ci@ec2-54-226-190-62.compute-1.amazonaws.com] has joined #wesnoth-dev
20180219 16:21:05< travis-ci> wesnoth/wesnoth#16523 (master - a3b513e : Gregory A Lundberg): The build was fixed.
20180219 16:21:05< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/343428468
20180219 16:21:05-!- travis-ci [~travis-ci@ec2-54-226-190-62.compute-1.amazonaws.com] has left #wesnoth-dev []
20180219 16:43:31-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has joined #wesnoth-dev
20180219 16:43:39-!- hrubymar10 [~textual@78.108.103.216] has quit [Quit: hrubymar10]
20180219 16:44:16-!- hrubymar10 [~textual@78.108.103.216] has joined #wesnoth-dev
20180219 16:47:52-!- hrubymar10 [~textual@78.108.103.216] has quit [Client Quit]
20180219 16:50:51-!- hrubymar10 [~textual@78.108.103.216] has joined #wesnoth-dev
20180219 16:55:38-!- hrubymar10 [~textual@78.108.103.216] has quit [Ping timeout: 256 seconds]
20180219 16:59:22-!- vladimirslavik [vslavik@nat/redhat/x-bylrwwdwjtiqrtjj] has quit [Quit: Leaving]
20180219 17:02:23-!- Oebele [~quassel@143.177.58.202] has joined #wesnoth-dev
20180219 17:02:29-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20180219 17:03:00-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 256 seconds]
20180219 17:21:20< irker062> wesnoth: Jyrki Vesterinen wesnoth:master dfbfd924fb0a / src/hotkey/hotkey_handler_sp.cpp: Don't allow returning to playing mode until the replay finishes (#2508) https://github.com/wesnoth/wesnoth/commit/dfbfd924fb0aabf4c7f5e080db48b6eb0cd336c5
20180219 17:26:16< irker062> wesnoth: Jyrki Vesterinen wesnoth:master 77edec6048e7 / projectfiles/VC12/wesnothlib.vcxproj: Visual Studio: disable C4351 in wesnothlib https://github.com/wesnoth/wesnoth/commit/77edec6048e78234d0e4f92114dd0139f5a53d09
20180219 17:35:11< celticminstrel> Who was it who made the AI manager a singleton again?
20180219 17:35:20< celticminstrel> Where is it constructed? Where is it destructed?
20180219 17:35:29< JyrkiVesterinen> I did that.
20180219 17:35:43< JyrkiVesterinen> It's a part of game_state now. It lives and dies with the game state.
20180219 17:35:45-!- Bonobo [~Bonobo@61.68.156.44] has quit [Ping timeout: 264 seconds]
20180219 17:35:48< celticminstrel> Getting a crash seemingly related to it when trying to create a new scenario in the editor.
20180219 17:35:53< celticminstrel> Okay.
20180219 17:36:18< JyrkiVesterinen> AFAIK, there isn't any active game_state in the editor.
20180219 17:36:43< celticminstrel> My initial suspicion is the singleton was destroyed but not reset to null.
20180219 17:37:32< JyrkiVesterinen> That's on purpose. :(
20180219 17:37:33< JyrkiVesterinen> https://github.com/wesnoth/wesnoth/blob/master/src/ai/manager.hpp#L143-L145
20180219 17:38:43< celticminstrel> Hmm, then maybe we need a bool is_valid flag?
20180219 17:39:29< celticminstrel> I guess the crash occurs if you enter a game, then return to titlescreen and go to the editor and make a new scenario.
20180219 17:40:25< JyrkiVesterinen> Maybe it would be possible to explicitly *clear* ai::manager::singleton_ when entering the editor.
20180219 17:44:10< celticminstrel> Quick test seems to confirm. Launch game, go to editor, new scenario -> no problem. Return to title, click tutorial, return to title, go to editor, new scenario -> crash.
20180219 17:44:25< celticminstrel> I guess you mean just assign null in the editor startup function or something?
20180219 17:44:38< JyrkiVesterinen> Yes, something like that.
20180219 17:52:49< Soliton> that comment about accessing the singleton after destruction sounds like UB.
20180219 17:54:00< shadowm> Definitely. :\
20180219 18:21:31< celticminstrel> For some reason that fix didn't work. I guess I'll open an issue for now and go back to what I was doing before.
20180219 18:56:47< vn971> weird, wesnoth.org went suddenly dead, and also a completely unrelated site went dead. Wonder if it's the same "hoster".
20180219 18:57:19< JyrkiVesterinen> Probably a router somewhere in the path.
20180219 18:57:29< JyrkiVesterinen> I can access wesnoth.org just fine.
20180219 18:59:18< vn971> JyrkiVesterinen: wow, that makes it even more strange for me. (Other sites open fine by me.) But I guess it's not really wesnoth-specific as it works for others.
20180219 19:03:32< vn971> * back alive for me.
20180219 19:12:08-!- vultraz [uid24821@wesnoth/developer/vultraz] has joined #wesnoth-dev
20180219 19:28:53-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180219 19:29:00-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20180219 20:25:02-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20180219 20:26:31-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer]
20180219 20:26:46-!- irker062 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20180219 20:31:47-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180219 20:31:56-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20180219 21:06:05< celticminstrel> Shall I merge PR 2521?
20180219 21:06:14< celticminstrel> vultraz, JyrkiVesterinen, TadCarlucci?
20180219 21:06:27< celticminstrel> Travis Xcode in case you don't feel like looking it up.
20180219 21:06:48< vultraz> if it works
20180219 21:07:11< celticminstrel> I assume this counts as working? https://travis-ci.org/wesnoth/wesnoth/jobs/343482084
20180219 21:07:40< vultraz> yes
20180219 21:07:49< JyrkiVesterinen> I'm fine with merging it.
20180219 21:10:22-!- irker961 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20180219 21:10:22< irker961> wesnoth: Sofartin wesnoth:master 893674d4837e / .travis.yml: Add Xcode Travis build https://github.com/wesnoth/wesnoth/commit/893674d4837eed1efb7bca7ccbc3947f1fb5e5a4
20180219 21:12:03< celticminstrel> I unassigned myself from a bunch of issues BTW. Still 25 assigned to me though. :|
20180219 21:12:32< celticminstrel> Oh, I could unassign that one too, I guess.
20180219 21:12:48< vultraz> fix fix fix fix fix! :P
20180219 21:13:30< celticminstrel> ???
20180219 21:14:32< celticminstrel> I also feel like some of my fixes have been inadvertently reverted or something.
20180219 21:14:40< celticminstrel> For example, tabbing between fields in dialogs.
20180219 21:14:48< celticminstrel> I definitely implemented that, yet it doesn't work on master.
20180219 21:14:59< celticminstrel> It was working at some point around 1.13.9.
20180219 21:15:39< celticminstrel> Possibly also issues 1601 and 1736 (which IIUC are symptoms of the same thing).
20180219 21:15:51< JyrkiVesterinen> Most likely they have just broken by accident at some point, rather than reverted.
20180219 21:16:05< celticminstrel> Yeah, well, it comes out to the same thing on the surface.
20180219 21:20:53< JyrkiVesterinen> Most likely, 1601 and 1736 broke in this commit: https://github.com/wesnoth/wesnoth/commit/45c8c256cccb299eab861d4e6f5712b72f200ada
20180219 21:21:07< JyrkiVesterinen> It seems to revert the commit where you originally fixed them.
20180219 21:21:22< celticminstrel> Ah.
20180219 21:22:23< celticminstrel> More worried about the tab thing though TBH.
20180219 21:42:42-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has quit [Quit: .]
20180219 21:54:17-!- travis-ci [~travis-ci@ec2-54-166-201-245.compute-1.amazonaws.com] has joined #wesnoth-dev
20180219 21:54:18< travis-ci> wesnoth/wesnoth#16527 (master - 893674d : Sofartin): The build was broken.
20180219 21:54:18< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/343556821
20180219 21:54:18-!- travis-ci [~travis-ci@ec2-54-166-201-245.compute-1.amazonaws.com] has left #wesnoth-dev []
20180219 21:54:42< celticminstrel> XD
20180219 21:55:15< celticminstrel> That failure is nothing to do with Xcode though.
20180219 21:56:14-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Quit: Caught sigterm, terminating...]
20180219 21:56:36-!- Ivanovic [~ivanovic@p579FBA67.dip0.t-ipconnect.de] has joined #wesnoth-dev
20180219 21:56:37-!- Ivanovic [~ivanovic@p579FBA67.dip0.t-ipconnect.de] has quit [Changing host]
20180219 21:56:37-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev
20180219 22:12:33-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Quit: Caught sigterm, terminating...]
20180219 22:13:53-!- Ivanovic [~ivanovic@p579FBA67.dip0.t-ipconnect.de] has joined #wesnoth-dev
20180219 22:14:02-!- Ivanovic [~ivanovic@p579FBA67.dip0.t-ipconnect.de] has quit [Changing host]
20180219 22:14:02-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev
20180219 22:21:56-!- Oebele [~quassel@143.177.58.202] has quit [Remote host closed the connection]
20180219 22:40:14< irker961> wesnoth: Nils Kneuper wesnoth:master 736dfb6a54b7 / / (11 files in 11 dirs): updated British English translation https://github.com/wesnoth/wesnoth/commit/736dfb6a54b775aa60a506714632bb179f5dced7
20180219 22:42:21< Soliton> Ivanovic: we're in string freeze now, btw.
20180219 22:42:43< Ivanovic> uhm, okay
20180219 22:43:11< Ivanovic> sadly pofix seems to create a false "fix" on wesnoth-nr for en_GB
20180219 22:44:01< Soliton> probably best to clear out pofix. i've tried to explain how to add stuff to it but...
20180219 22:44:45< Soliton> hopefully we'll do better for new stuff now that the string freeze is in effect.
20180219 22:47:31< Ivanovic> lovely... a "fix" from httt might be required for nr as well...
20180219 22:47:34< Ivanovic> ("Onward men!", "Onward, men!"),
20180219 22:48:57< Ivanovic> hmm, since pofix is already applying this fix creating false fuzzy, should i "fix" this string in data/campaigns/Northern_Rebirth/scenarios/10a_Stolen_Gold.cfg:1034 or remove the pofix entry?
20180219 22:49:37< Ivanovic> Soliton: what do you think is the better approach?
20180219 22:50:52< Soliton> good question.
20180219 22:51:35< Soliton> well, sounds like we might as well fix it and leave it in pofix then.
20180219 22:55:12< irker961> wesnoth: Nils Kneuper wesnoth:master bac3ab530aa8 / / (60 files in 2 dirs): applied fix that pofix.py already applies https://github.com/wesnoth/wesnoth/commit/bac3ab530aa84093d8bf463adc09fe20233aaf3f
20180219 22:55:44< Ivanovic> fixed and applied pofix on the domain and the po files (also rerunning the update for the en_GB files)
20180219 22:56:47< Soliton> do you remember how we used to implement the check for complete or more than x% translations?
20180219 22:56:59< Soliton> was that a manual thing?
20180219 22:57:18< Ivanovic> that was manual vs g.w.o
20180219 22:57:32< Ivanovic> but we only did that for 1.0 IIRC and not the other stable releases
20180219 22:57:54< Soliton> did we display the percentage at least?
20180219 22:57:59< Ivanovic> nope
20180219 22:58:16< Ivanovic> nothing that sophisticated
20180219 22:58:37< Ivanovic> in fact i fear that most translations got rather slow regarding updates and changes these days
20180219 22:58:58< Ivanovic> at least the number of changes i receive are extremely limited and also looking at g.w.o things are rather incomplete for dev
20180219 22:59:25< Soliton> i'm not sure most translators are aware of the string freeze honestly.
20180219 22:59:40< Ivanovic> in the past we had a mailing list for things like this
20180219 22:59:59< Soliton> yeah, was that a real ml or just a bunch of email addresses?
20180219 23:00:04< Ivanovic> but since gna no longer exists i guess we have no information medium like this anymore that pushes the info out to the hopefully interested parties
20180219 23:00:10< Ivanovic> that was a real ml on gn
20180219 23:00:13< Ivanovic> gna
20180219 23:00:25< Ivanovic> wesnoth-i18n@gna.org
20180219 23:00:41< Ivanovic> the only case of a "hand kept list" was the release message I sent
20180219 23:01:00< Soliton> well, we do have some lists still: http://wesnoth.org:1580/admin
20180219 23:01:35< Soliton> so maybe we just need the emails from the old list and establish that list again...
20180219 23:01:41< Ivanovic> that is why I state that I am inactive these days... I got no idea what is happening and going on
20180219 23:03:20< Soliton> i think we might have saved the ml stuff from gna so we probably have the addresses somewhere.
20180219 23:03:41< Soliton> zookeeper: do you know something about that?
20180219 23:04:14< zookeeper> yeah, i have the addresses
20180219 23:04:37< vultraz>  translators is the one list we actually need
20180219 23:04:42< vultraz> yet the one list we don't have
20180219 23:04:53< zookeeper> Soliton, and IIRC you even uploaded them to the server somewhere :P or maybe that wasn't... the translators list
20180219 23:04:57< vultraz> instead we have... commits (useless!) and dev (even more useless!)
20180219 23:05:02 * zookeeper checks
20180219 23:06:12< zookeeper> ok, who wants it in a query?
20180219 23:06:30< Soliton> ai, but he vanished a while ago.
20180219 23:07:24 * Ivanovic does not want that
20180219 23:07:25< Ivanovic> ;)
20180219 23:07:27< Soliton> i guess you can tell me. i'll try to remember to get ai to re-establish that list.
20180219 23:07:28< Ivanovic> anyway, off to bed
20180219 23:07:33< Ivanovic> n8
20180219 23:07:55< Soliton> Ivanovic: thanks for the help. good night.
20180219 23:08:25< Ivanovic> that is the only thing I do these days: commit a hand full of translations every now and then and crosscheck the messages I see
20180219 23:08:27< Ivanovic> ;)
20180219 23:10:09< vultraz> can these be applied via pofix? https://wiki.wesnoth.org/SpellingMistakes
20180219 23:20:32-!- Appleman1234 [~quassel@124x38x163x22.ap124.ftth.ucom.ne.jp] has quit [Ping timeout: 256 seconds]
20180219 23:23:36-!- travis-ci [~travis-ci@ec2-54-166-201-245.compute-1.amazonaws.com] has joined #wesnoth-dev
20180219 23:23:37< travis-ci> wesnoth/wesnoth#16528 (master - 736dfb6 : Nils Kneuper): The build was fixed.
20180219 23:23:37< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/343587429
20180219 23:23:37-!- travis-ci [~travis-ci@ec2-54-166-201-245.compute-1.amazonaws.com] has left #wesnoth-dev []
20180219 23:27:45< vultraz> celticminstrel: what was that again
20180219 23:27:48< vultraz> the thing
20180219 23:27:54< celticminstrel> ?
20180219 23:28:08< vultraz> you said you only need to implement operator== and <
20180219 23:28:17< celticminstrel> Oh, about t_string?
20180219 23:28:21< vultraz> no in general
20180219 23:28:25< celticminstrel> No, you need to implement all of them.
20180219 23:28:35-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 256 seconds]
20180219 23:28:37< celticminstrel> But == and < do the actual work.
20180219 23:28:39< vultraz> no I mean the others get implemented in terms of those two
20180219 23:28:46< vultraz> so != is !==
20180219 23:28:48< celticminstrel> != just calls == and > >= <= just call <
20180219 23:28:56< vultraz> then > is... !< || !==
20180219 23:29:11< celticminstrel> a!=b <=> !(a==b)
20180219 23:29:19< celticminstrel> a>b <=> b<a
20180219 23:29:43< celticminstrel> a>=b <=> ~(a<b)
20180219 23:29:50< celticminstrel> ! not ~
20180219 23:30:03< celticminstrel> a<=b <=> !(b<a)
20180219 23:32:30< vultraz> got it
20180219 23:32:38 * vultraz is prepping a general code cleanups PR
20180219 23:34:02< TadCarlucci> For each of those three (== !=) (> <) and (>= <=) if you do one you should do the other. There are some cases where order is meaningless, and some cases where equality is meaninless.
20180219 23:34:29< TadCarlucci> In general, though, unless you can show those special cases, do all six.
20180219 23:35:31< celticminstrel> Theoretically there could also be cases where the equivalences I mentioned don't apply, but I don't know of any such that are practically useful in a game.
20180219 23:36:34< celticminstrel> An example of where order is meaningless is for points or vectors. (You can still define an order, such as lexicographic order, but it doesn't really mean anything useful to the concept of a point or vector.)
20180219 23:36:56< TadCarlucci> Those cases are number systems which do not follow commutative rule and are few and far between in computing.
20180219 23:37:25< celticminstrel> Like octonions, right?
20180219 23:37:53< celticminstrel> Matrices are non-commutative and useful in commuting, but for them order doesn't really make sense.
20180219 23:39:01< TadCarlucci> Right.
20180219 23:39:34< celticminstrel> Quaternions have uses in computing but I can't recall if they're commutative.
20180219 23:39:56< TadCarlucci> The point is that the comparison operators are usually all-or-nothing, similar to the rule of zero vs the rule of four/six for ctors
20180219 23:41:30< TadCarlucci> I didn't say no useful. I said few and far between. You're talking matrix which is an example. You'll need that in 3D modelling.
20180219 23:41:38< vultraz> is there a reason some config stuff has both operator== and != doing the same thing...
20180219 23:41:44< celticminstrel> ...what?
20180219 23:41:56< vultraz> 		bool operator==(const const_attribute_iterator &i) const { return i == *this; }
20180219 23:41:56< vultraz> 		bool operator!=(const const_attribute_iterator &i) const { return i == *this; }
20180219 23:42:17< celticminstrel> Uhh. I bet that's a typo.
20180219 23:42:22< vultraz> will fix
20180219 23:43:03< TadCarlucci> `inline bool T::operator !=(T a, Tb) { return ! T::operator==(a, b); }` (sic) and if you do anything else you best have a damned good reason
20180219 23:43:58< irker961> wesnoth/wesnoth:master Jyrki Vesterinen 77edec6048 Visual Studio: disable C4351 in wesnothl AppVeyor: All builds passed
20180219 23:44:03< celticminstrel> Indeed.
20180219 23:44:14< celticminstrel> Actually I can't think of any reason not to implement != in terms of ==
20180219 23:44:41< celticminstrel> Any reasons for violating the equivalences I mentioned would lie in the order operators, not == and !=
20180219 23:48:58< TadCarlucci> Yes. Like I said, you best has a damned good reason why (a!=b) is not the same as !(a==b).
20180219 23:50:10< TadCarlucci> The reason you can define them separately is because C++ wants to let you do optimizations. For example, it is possible your profiler will lead you to realize the == should be !!= rather than the common != being !==
20180219 23:50:45-!- travis-ci [~travis-ci@ec2-54-205-49-211.compute-1.amazonaws.com] has joined #wesnoth-dev
20180219 23:50:46< travis-ci> wesnoth/wesnoth#16529 (master - bac3ab5 : Nils Kneuper): The build was fixed.
20180219 23:50:46< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/343592762
20180219 23:50:46-!- travis-ci [~travis-ci@ec2-54-205-49-211.compute-1.amazonaws.com] has left #wesnoth-dev []
20180219 23:50:46< TadCarlucci> Or even to do them each separately
20180219 23:55:32< vultraz> which is the preferred syntax: !operator==(a, b) or !(a == b)
20180219 23:56:11< celticminstrel> I kinda prefer the second ATM. I think my opinions on that have bounced back and forth over time though, so I guess, pick whichever you like?
20180219 23:56:37< vultraz> hm
20180219 23:59:36< irker961> wesnoth: Charles Dang wesnoth:code_cleanups 515dbdd96b57 / src/ (32 files in 13 dirs): Use std::array for adjacent map_location arrays https://github.com/wesnoth/wesnoth/commit/515dbdd96b5733e0a9db436ec5c3726cdd8af34a
20180219 23:59:39< irker961> wesnoth: Charles Dang wesnoth:code_cleanups 4ccb962cd0ad / src/ (26 files in 14 dirs): Used std::distance instead of iterator arithmetic when possible https://github.com/wesnoth/wesnoth/commit/4ccb962cd0adf4f3afdd26da45904dfdedec7e35
20180219 23:59:42< irker961> wesnoth: Charles Dang wesnoth:code_cleanups dbedb67aa5fc / src/editor/action/mouse/mouse_action_unit.cpp: Fixup the loc array commit https://github.com/wesnoth/wesnoth/commit/dbedb67aa5fc9c02a0a08519bf2291bb262dcdb7
20180219 23:59:45< irker961> wesnoth: Charles Dang wesnoth:code_cleanups 7f7d4ab978e7 / src/ (8 files in 7 dirs): Simplify some implementations of operator< using tuple comparison https://github.com/wesnoth/wesnoth/commit/7f7d4ab978e7c0c4f981c148e25b5bafa283a51f
20180219 23:59:48< irker961> wesnoth: Charles Dang wesnoth:code_cleanups 600dc9a9c904 / src/ (8 files in 3 dirs): [WIP] Implement various operators in terms of == or < https://github.com/wesnoth/wesnoth/commit/600dc9a9c9048f34056ee1865893e2615a3690c9
--- Log closed Tue Feb 20 00:00:15 2018