--- Log opened Tue Feb 20 00:00:15 2018
20180220 00:03:58-!- Appleman1234 [~quassel@124x38x163x22.ap124.ftth.ucom.ne.jp] has joined #wesnoth-dev
20180220 00:07:52< celticminstrel> vultraz: IMO there's a downside to std::distance, which is that it works even if the iterator is not random-access.
20180220 00:08:02< celticminstrel> That can also be an upside, of course.
20180220 00:09:20< celticminstrel> So std::distance used on vector or (pretty sure) deque iterators is a simple subtraction.
20180220 00:09:44< celticminstrel> But std::distance used on list iterators is incrementing a until it is equal to b.
20180220 00:09:59< celticminstrel> While counting the number of steps taken.
20180220 00:10:29< celticminstrel> I'm not necessarily against using std::distance though.
20180220 00:10:55< celticminstrel> Ooh, replacing a map_location* with an std::array&, nice.
20180220 00:10:59< celticminstrel> Much safer.
20180220 00:12:35< celticminstrel> (I also have a feeling that std::distance(b, a) isn't safe? With vector iterators it could probably just return a negative number, but with list iterators I feel like it'd increment b past the end...?)
20180220 00:12:43< vultraz> celticminstrel: the function still takes a map_location*
20180220 00:13:05< celticminstrel> What are you talking about
20180220 00:13:17< vultraz> get_adjacent_loc
20180220 00:13:17< vultraz> s
20180220 00:13:21< celticminstrel> I'm talking about do_attack_analysis.
20180220 00:13:23< vultraz> oh
20180220 00:13:25< vultraz> ok
20180220 00:13:34< vultraz> yes, that I could make take the array
20180220 00:13:46< celticminstrel> Shouldn't get_adjacent_locs take a map_location& instead of a map_location*?
20180220 00:14:33-!- travis-ci [~travis-ci@ec2-54-205-49-211.compute-1.amazonaws.com] has joined #wesnoth-dev
20180220 00:14:34< travis-ci> wesnoth/wesnoth#16530 (code_cleanups - 600dc9a : Charles Dang): The build failed.
20180220 00:14:34< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/343614051
20180220 00:14:34-!- travis-ci [~travis-ci@ec2-54-205-49-211.compute-1.amazonaws.com] has left #wesnoth-dev []
20180220 00:15:51< vultraz> celticminstrel: impossible
20180220 00:16:00< vultraz> celticminstrel: in two cases the loc is in a vector
20180220 00:16:06< vultraz> and in one case the array is 7 long and not 6
20180220 00:16:45< celticminstrel> Oh nice, that use of the tuple operator is kinda convenient. And using tie() instead of tuple() ensures the values aren't copied in order to compare them.
20180220 00:17:05< celticminstrel> ^tuple operator<
20180220 00:17:16< vultraz> will probably use it in a few cases for == too
20180220 00:17:25< celticminstrel> Maybe I should start doing that for all my lexicographical compare operations in all projects.
20180220 00:17:32< celticminstrel> IIRC there are a couple in BoE for example.
20180220 00:18:06< vultraz> though it confuses me how one can do lexicographical comparison on numbers
20180220 00:18:16< celticminstrel> ISTR also that there was something in formula?
20180220 00:18:22< celticminstrel> Why does that confuse you?
20180220 00:18:31< celticminstrel> Lexicographical comparison is an operation on general sequences.
20180220 00:18:39< celticminstrel> Strings are sequences of characters, so it works there.
20180220 00:18:44< vultraz> I thought lexicographical sorting meant "alphabetical"
20180220 00:18:57< celticminstrel> No, alphabetical is just one use of lexicographical sorting.
20180220 00:19:04-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20180220 00:19:09< celticminstrel> Lexicographical is more general than alphabetical.
20180220 00:20:01< vultraz> i see
20180220 00:23:38< celticminstrel> Your last commit somehow seems largely pointless...
20180220 00:24:38< vultraz> perhaps
20180220 00:24:42< vultraz> except for version.cpp
20180220 00:24:54< celticminstrel> Yeah, that's the only case where it seems like it might be useful, but uh...
20180220 00:25:15< vultraz> maybe I'll just drop the commit
20180220 00:25:26< celticminstrel> In that case they're all implemented in terms of that internal function, so I dunno...
20180220 00:25:52< celticminstrel> That said, I bet version_numbers_comparison_internal is another lexicographical comparison.
20180220 00:26:07< celticminstrel> So maybe it could be implemented with the tie method.
20180220 00:26:11< vultraz> not really
20180220 00:26:15< celticminstrel> No?
20180220 00:26:17< celticminstrel> Well whatever.
20180220 00:26:19< vultraz> it's very complex
20180220 00:26:49< celticminstrel> Okay lemme see now...
20180220 00:26:54< vultraz> https://github.com/wesnoth/wesnoth/blob/master/src/version.cpp#L183-L235
20180220 00:27:04< celticminstrel> Yeah looking at it already.
20180220 00:27:53< celticminstrel> Hmm, so in case of differing lengths, it pads instead of auto-failing an equality test.
20180220 00:28:20< celticminstrel> So that 1.12 and 1.12.0 are entirely equivalent for comparison purposes.
20180220 00:28:54< celticminstrel> The (not-)equal comparison looks lexicographic.
20180220 00:30:00< vultraz> eh
20180220 00:30:07< vultraz> I think maybe I'll just drop the last commit
20180220 00:30:12< vultraz> expand the tuple one
20180220 00:30:51< celticminstrel> Whoa, the < > version is recursive.
20180220 00:31:05< celticminstrel> But basically...
20180220 00:31:42< celticminstrel> "if(a < b) return true; else if(a == b) recurse on next element"
20180220 00:31:47< celticminstrel> Pretty sure that's also lexicographic?
20180220 00:32:15< celticminstrel> But you can't use tuple compare there, because this is operating on vectors. I don't recall whether vectors support order operators.
20180220 00:32:24< celticminstrel> std::valarray does, IIRC
20180220 00:33:00< vultraz> the hell is that
20180220 00:33:01< vultraz> O_O
20180220 00:34:51< celticminstrel> It's a weird container that defines vector-based overloads of all the mathematical operators.
20180220 00:35:05< celticminstrel> So you can add and subtract and divide them, component-wise.
20180220 00:35:25 * vultraz is just gonna drop the last commit
20180220 00:36:35< shadowm> Hi
20180220 00:36:41< shadowm> I see someone mentioned version_info.
20180220 00:36:48< celticminstrel> Yeah.
20180220 00:37:01< vultraz> celticminstrel: any point in using tuple comparion for operator==?
20180220 00:37:05< vultraz> comparison
20180220 00:37:08< celticminstrel> Just that the comparison function looks absurdly complicated.
20180220 00:37:08< shadowm> If you have any questions about it I probably still remember some things.
20180220 00:37:29< celticminstrel> shadowm: It looks like "pad to same length, then compare lexicographically", does that sound accurate?
20180220 00:37:35< shadowm> Oh yeah, certainly. I'm not a good coder and I was terrible at the time (Q4 2008).
20180220 00:37:44< celticminstrel> vultraz: Uhh, well, as much point as there is in using it for operator<?
20180220 00:38:05< vultraz> celticminstrel: well, for < is gets rid of the logic where you have to consider equal cases
20180220 00:38:17< shadowm> celticminstrel: Yes. The version numbers have to be exactly as long with the missing values replaced with 0s.
20180220 00:38:31< celticminstrel> vultraz: What?
20180220 00:38:40< celticminstrel> Oh, right, I see what you mean.
20180220 00:39:05< shadowm> That means 1.2.3 == 1.2.3.0.0.0.0.0.0.0.0.0.0.
20180220 00:39:23< shadowm> If you check the unit tests it'll become more obvious why that is a thing.
20180220 00:39:37< shadowm>     version_info right_zero("1.2.0"); version_info no_right_zero("1.2"); BOOST_CHECK( right_zero == no_right_zero );
20180220 00:40:19< shadowm> For a while there was some inconsistent usage of 2 vs. 3 numbers in mainline versions, and thus we ended up with a 1.6 tag (superseded by 1.6a) *AND* a 1.6 branch.
20180220 00:40:48< vultraz> celticminstrel: eh, I think I will use it. It's easier tor ead
20180220 00:44:13< vultraz> or maybe not!
20180220 00:44:18< vultraz> can't really decide..
20180220 00:44:33< vultraz> maybe I'll get these changes done and then do that later
20180220 01:11:33< irker961> wesnoth: Charles Dang wesnoth:code_cleanups ae53a388354e / src/ (32 files in 13 dirs): Use std::array for adjacent map_location arrays https://github.com/wesnoth/wesnoth/commit/ae53a388354ed68e2c41ee060f29163d1a8a0b08
20180220 01:11:36< irker961> wesnoth: Charles Dang wesnoth:code_cleanups a77652986a0b / src/ (26 files in 14 dirs): Used std::distance instead of iterator arithmetic when possible https://github.com/wesnoth/wesnoth/commit/a77652986a0b3df9a9f5cf7a454dbb3c9215a13d
20180220 01:11:39< irker961> wesnoth: Charles Dang wesnoth:code_cleanups ea4b67462b2a / src/ (8 files in 7 dirs): Simplify some implementations of operator< using lexicographical tuple compariso https://github.com/wesnoth/wesnoth/commit/ea4b67462b2a4766e66b2219f773d5ebb39ac2ee
20180220 01:11:42< irker961> wesnoth: Charles Dang wesnoth:code_cleanups b14fdc88a0d3 / src/config.hpp: Config: fixed two cases of operator!= operating the same as operator== https://github.com/wesnoth/wesnoth/commit/b14fdc88a0d321cf0c37f7bfcf441ee82fea3f81
20180220 01:19:52< shadowm> I'm concerned that that last one was never caught by unit tests.
20180220 01:19:59< shadowm> Or anything else for that matter.
20180220 01:20:30< celticminstrel> Yeah...
20180220 01:20:35< shadowm> You'd think that something like that would be the source of a myriad of inexplicable bugs.
20180220 01:20:38-!- TadCarlucci [~lundberg@74.193.219.119] has quit [Remote host closed the connection]
20180220 01:21:07< shadowm> Like element iteration loops never running.
20180220 01:22:02< celticminstrel> I guess it only comes into play if you compare a const iterator to a non-const, maybe that's why it was never noticed? At least it looks like that's what it is.
20180220 01:25:01-!- TadCarlucci [~lundberg@74.193.219.119] has joined #wesnoth-dev
20180220 01:27:13< celticminstrel> Anyway I should get those commits finished and pushed around now...
20180220 01:35:57-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180220 01:36:35-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20180220 01:39:11-!- Bonobo [~Bonobo@61.68.156.44] has joined #wesnoth-dev
20180220 01:47:47< vultraz> celticminstrel: what commits?
20180220 01:48:45< vultraz> ah fuck
20180220 01:48:47< vultraz> wml tests failing
20180220 01:50:39< vultraz> gonna try without the last commit...
20180220 01:55:55< vultraz> if the tests pass without it i will be very disappoint
20180220 01:56:09< shadowm> And I'd not be surprised in the least.
20180220 01:56:47< shadowm> Unit tests don't really protect your software from bogus assumptions in the unit tests themselves.
20180220 01:59:04< celticminstrel> Oh my.
20180220 01:59:16< celticminstrel> That said...
20180220 01:59:22< celticminstrel> It's the WML tests failing?
20180220 01:59:26< celticminstrel> Not the Boost tests?
20180220 01:59:40< celticminstrel> vultraz: One for 2247, one for deprecation spam.
20180220 01:59:50< vultraz> yes
20180220 01:59:52< vultraz> the wml tests
20180220 02:00:04< vultraz> some variables don't have the expected value
20180220 02:17:36-!- travis-ci [~travis-ci@ec2-54-166-201-245.compute-1.amazonaws.com] has joined #wesnoth-dev
20180220 02:17:37< travis-ci> wesnoth/wesnoth#16532 (code_cleanups - b14fdc8 : Charles Dang): The build is still failing.
20180220 02:17:37< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/343633359
20180220 02:17:37-!- travis-ci [~travis-ci@ec2-54-166-201-245.compute-1.amazonaws.com] has left #wesnoth-dev []
20180220 02:18:59< vultraz> nope
20180220 02:19:02< vultraz> still broken
20180220 02:20:37< celticminstrel> Aw, I wanted to use NORETURN on luaW_type_error, but that just leads to more warnings because it looks like it does return something because the noreturn function that it relies on can't be proven not to return and isn't annotated and blehhhh...
20180220 02:22:55< vultraz> wait i see it
20180220 02:23:04< vultraz> celticminstrel: some fuckup in the pathfind code..
20180220 02:23:14< vultraz> old
20180220 02:23:27< vultraz> bool operator<(const findroute_node& o) const { return turns_left > o.turns_left || (turns_left == o.turns_left && moves_left > o.moves_left); }
20180220 02:23:33< vultraz> celticminstrel: why is < in terms of >
20180220 02:23:46< celticminstrel> No particular reason?
20180220 02:24:05< celticminstrel> What I described is the typical equivalency, but in fact you can choose any of those four and express the other three in terms of it.
20180220 02:24:17< celticminstrel> Alternatively...
20180220 02:24:42< celticminstrel> The other possible reason is that a reversal of the native sort order is desired.
20180220 02:25:09< celticminstrel> In fact, that's actually probably what this is...
20180220 02:26:12< vultraz> so i replaced it with return std::tie(turns_left, moves_left) < std::tie(o.turns_left, o.moves_left);
20180220 02:26:15< vultraz> do i want
20180220 02:26:20< vultraz> return std::tie(turns_left, moves_left) > std::tie(o.turns_left, o.moves_left);
20180220 02:26:41< vultraz> or would you suggest i flip it to o first
20180220 02:26:47< vultraz> it just seems illogical 
20180220 02:26:56< vultraz> that the < operator is testing >
20180220 02:28:22< celticminstrel> Well, flipping it to o first is 100% equivalent, but IMO using > makes it clearer that the intent is to get descending order.
20180220 02:28:34< vultraz> ok
20180220 02:29:26< irker961> wesnoth: Charles Dang wesnoth:code_cleanups b14fdc88a0d3 / src/config.hpp: Config: fixed two cases of operator!= operating the same as operator== https://github.com/wesnoth/wesnoth/commit/b14fdc88a0d321cf0c37f7bfcf441ee82fea3f81
20180220 02:29:29< irker961> wesnoth: Charles Dang wesnoth:code_cleanups 150ded6f2664 / src/pathfind/pathfind.cpp: foo https://github.com/wesnoth/wesnoth/commit/150ded6f26645cce4fa1cd09dd34ea6cb5c01c7b
20180220 02:29:40< vultraz> oh, well if that other one is going in...
20180220 02:30:50< irker961> wesnoth: Charles Dang wesnoth:code_cleanups ccb5d8f7955c / src/ (8 files in 7 dirs): Simplify some implementations of operator< using lexicographical tuple compariso https://github.com/wesnoth/wesnoth/commit/ccb5d8f7955cf579aa15d5c42da00f342bc6e92a
20180220 02:30:53< irker961> wesnoth: Charles Dang wesnoth:code_cleanups f45cd3eeb8f1 / src/config.hpp: Config: fixed two cases of operator!= operating the same as operator== https://github.com/wesnoth/wesnoth/commit/f45cd3eeb8f119ed49431f497e76497098a4e230
20180220 02:30:54-!- travis-ci [~travis-ci@ec2-54-205-49-211.compute-1.amazonaws.com] has joined #wesnoth-dev
20180220 02:30:55< travis-ci> wesnoth/wesnoth#16536 (code_cleanups - 150ded6 : Charles Dang): The build was canceled.
20180220 02:30:55< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/343651252
20180220 02:30:55-!- travis-ci [~travis-ci@ec2-54-205-49-211.compute-1.amazonaws.com] has left #wesnoth-dev []
20180220 02:37:36-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity]
20180220 02:45:01< irker961> wesnoth/wesnoth:master Nils Kneuper bac3ab530a applied fix that pofix.py already applie AppVeyor: All builds passed
20180220 02:54:51< irker961> wesnoth: Charles Dang wesnoth:master ae53a388354e / src/ (32 files in 13 dirs): Use std::array for adjacent map_location arrays https://github.com/wesnoth/wesnoth/commit/ae53a388354ed68e2c41ee060f29163d1a8a0b08
20180220 02:54:54< irker961> wesnoth: Charles Dang wesnoth:master a77652986a0b / src/ (26 files in 14 dirs): Used std::distance instead of iterator arithmetic when possible https://github.com/wesnoth/wesnoth/commit/a77652986a0b3df9a9f5cf7a454dbb3c9215a13d
20180220 02:54:57< irker961> wesnoth: Charles Dang wesnoth:master ccb5d8f7955c / src/ (8 files in 7 dirs): Simplify some implementations of operator< using lexicographical tuple compariso https://github.com/wesnoth/wesnoth/commit/ccb5d8f7955cf579aa15d5c42da00f342bc6e92a
20180220 02:55:00< irker961> wesnoth: Charles Dang wesnoth:master f45cd3eeb8f1 / src/config.hpp: Config: fixed two cases of operator!= operating the same as operator== https://github.com/wesnoth/wesnoth/commit/f45cd3eeb8f119ed49431f497e76497098a4e230
20180220 03:03:54< irker961> wesnoth: Celtic Minstrel wesnoth:fix_2247 9556d2b1e4e3 / src/ (5 files in 4 dirs): Don't assume unit is on the map when testing ability active https://github.com/wesnoth/wesnoth/commit/9556d2b1e4e3732ac8a023d4a93d55a3dec153fa
20180220 03:39:42< irker961> wesnoth: Charles Dang wesnoth:master 88e5c49f5d3d / src/ (game_initialization/lobby_data.cpp gui/widgets/window.cpp server/game.cpp): MP Lobby: moved turn/slot data formatting from server to client https://github.com/wesnoth/wesnoth/commit/88e5c49f5d3d300ea453e28da7c2e8fc9d440591
20180220 03:39:45< irker961> wesnoth: Charles Dang wesnoth:master 3dc4d3398372 / src/game_initialization/create_engine.cpp: Create Engine: minor simplification https://github.com/wesnoth/wesnoth/commit/3dc4d33983727a7ae6108d0f559c8b38521c0501
20180220 03:40:36< irker961> wesnoth/wesnoth:fix_2247 Celtic Minstrel 9556d2b1e4 Don't assume unit is on the map when tes AppVeyor: vs2015/Release Failed
20180220 03:40:37< irker961> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-fix_2247-1498
20180220 04:01:26-!- travis-ci [~travis-ci@ec2-54-145-158-139.compute-1.amazonaws.com] has joined #wesnoth-dev
20180220 04:01:27< travis-ci> wesnoth/wesnoth#16540 (master - f45cd3e : Charles Dang): The build was broken.
20180220 04:01:27< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/343656804
20180220 04:01:27-!- travis-ci [~travis-ci@ec2-54-145-158-139.compute-1.amazonaws.com] has left #wesnoth-dev []
20180220 04:02:29< irker961> wesnoth: Charles Dang wesnoth:master a86bd3149fb1 / src/game_initialization/lobby_data.cpp: MP Lobby: allowed observing a game even if you don't have all prerequisites https://github.com/wesnoth/wesnoth/commit/a86bd3149fb156a7c772d50addcd934de087aad1
20180220 04:05:28< vultraz> Soliton: btw, you've said in the past that doubleclicking the game to join doesn't respect the same constraints as the buttons
20180220 04:05:30< vultraz> in the lobby
20180220 04:05:37< vultraz> right?
20180220 04:09:50-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20180220 04:13:36< irker961> wesnoth: Charles Dang wesnoth:master 38477ee23bf1 / data/gui/window/lobby_main.cfg: MP Lobby: ensure turn/slots text always has enough space https://github.com/wesnoth/wesnoth/commit/38477ee23bf16c9e5c5c02285215cb6d0e248b11
20180220 04:17:58< vultraz> Soliton: ah, I see the problem
20180220 04:34:29-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180220 04:34:35-!- janebot_ [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20180220 04:34:38-!- janebot_ is now known as janebot
20180220 04:39:26-!- travis-ci [~travis-ci@ec2-54-205-49-211.compute-1.amazonaws.com] has joined #wesnoth-dev
20180220 04:39:27< travis-ci> wesnoth/wesnoth#16541 (fix_2247 - 9556d2b : Celtic Minstrel): The build passed.
20180220 04:39:27< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/343659057
20180220 04:39:27-!- travis-ci [~travis-ci@ec2-54-205-49-211.compute-1.amazonaws.com] has left #wesnoth-dev []
20180220 04:43:39-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 256 seconds]
20180220 04:43:39-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20180220 04:46:03-!- wedge010 is now known as wedge009
20180220 05:00:42-!- vn971 [~vasya@94.158.103.15] has quit [Quit: Leaving.]
20180220 05:16:32-!- vn971 [~vasya@94.158.103.15] has joined #wesnoth-dev
20180220 05:38:56-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180220 05:39:05-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20180220 05:52:56-!- travis-ci [~travis-ci@ec2-54-145-158-139.compute-1.amazonaws.com] has joined #wesnoth-dev
20180220 05:52:57< travis-ci> wesnoth/wesnoth#16544 (master - a86bd31 : Charles Dang): The build was fixed.
20180220 05:52:57< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/343669670
20180220 05:52:57-!- travis-ci [~travis-ci@ec2-54-145-158-139.compute-1.amazonaws.com] has left #wesnoth-dev []
20180220 05:58:36-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has joined #wesnoth-dev
20180220 06:02:23< irker961> wesnoth/wesnoth:fix_2247 Celtic Minstrel 9556d2b1e4 Don't assume unit is on the map when tes AppVeyor: 1/6 builds failed
20180220 06:02:24< irker961> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-fix_2247-1498
20180220 06:20:02-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The computer falls into a deep sleep, to awake again some other day!]
20180220 06:39:09-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180220 06:39:15-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20180220 06:40:07< vultraz> Soliton: https://github.com/wesnoth/wesnoth/issues/2527
20180220 06:40:39-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has quit [Quit: .]
20180220 07:24:25< irker961> wesnoth: Charles Dang wesnoth:master b5b06f3bf202 / src/playturn_network_adapter.cpp: Removed side_drop key handling https://github.com/wesnoth/wesnoth/commit/b5b06f3bf20226730af264afa42fa87960d17ccc
20180220 07:24:28< irker961> wesnoth: Charles Dang wesnoth:master 68d5a8dd5775 / src/units/ (unit.cpp unit.hpp): Unit: removed unused member https://github.com/wesnoth/wesnoth/commit/68d5a8dd5775a0235e26689f527f167ddb1d722d
20180220 07:42:52-!- JyrkiVesterinen [~JyrkiVest@195-192-251-124.s1networks.fi] has joined #wesnoth-dev
20180220 09:42:35-!- vladimirslavik [vslavik@nat/redhat/x-vzcpeysleaipdvwu] has joined #wesnoth-dev
20180220 09:45:40-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20180220 10:31:00-!- JyrkiVesterinen [~JyrkiVest@195-192-251-124.s1networks.fi] has quit [Quit: .]
20180220 10:41:44< vn971> can I merge this issue already?: https://github.com/wesnoth/wesnoth/pull/2495  I started needing the functionality, too (originally it was a GH issue fix).
20180220 11:02:16< vultraz> Soliton: 
20180220 11:18:00-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20180220 11:24:12-!- irker961 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20180220 11:35:51-!- JyrkiVesterinen [~JyrkiVest@195-192-251-124.s1networks.fi] has joined #wesnoth-dev
20180220 11:36:14< Soliton> vn971: since elias hasn't reacted so far i think it's ok to just merge it. if he's got a better idea that can be improved later.
20180220 11:41:17< JyrkiVesterinen> Got it.
20180220 11:41:39-!- irker518 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20180220 11:41:39< irker518> wesnoth: V N wesnoth:master f7b31e79c9ff / data/tools/wesnoth_addon_manager: addon_manager: allow uploading . dir https://github.com/wesnoth/wesnoth/commit/f7b31e79c9ff072e50236deb81ba14c2d034c239
20180220 11:43:42< irker518> wesnoth/wesnoth:master pentarctagon ddd5032cd4 Touch-up for xcode build. AppVeyor: vs2013/Release Failed
20180220 11:43:43< irker518> Details: https://ci.appveyor.com/project/wesnoth/wesnoth/build/Wesnoth-VS2013-master-1515
20180220 12:00:54-!- vslavik [vslavik@nat/redhat/x-easmkzwtleipejgs] has joined #wesnoth-dev
20180220 12:02:17-!- vladimirslavik [vslavik@nat/redhat/x-vzcpeysleaipdvwu] has quit [Ping timeout: 260 seconds]
20180220 12:03:53< vn971> Thanks.)
20180220 12:03:58-!- vladimirslavik [vslavik@nat/redhat/x-rfrczfmwdleqfifu] has joined #wesnoth-dev
20180220 12:05:30-!- vladimirslavik [vslavik@nat/redhat/x-rfrczfmwdleqfifu] has quit [Client Quit]
20180220 12:10:45< irker518> wesnoth/wesnoth:master Celtic Minstrel d95db659d1 Don't assume unit is on the map when tes AppVeyor: All builds passed
20180220 12:22:20-!- vslavik__ [vslavik@nat/redhat/x-iafavglhlkejrgcu] has joined #wesnoth-dev
20180220 12:24:27-!- vslavik [vslavik@nat/redhat/x-easmkzwtleipejgs] has quit [Ping timeout: 240 seconds]
20180220 12:28:32-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20180220 13:03:44-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20180220 13:15:27-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20180220 13:16:44-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20180220 13:29:27< irker518> wesnoth/wesnoth:master pentarctagon 2794228eef Touch-up for xcode build. AppVeyor: vs2017/Release Failed
20180220 13:29:28< irker518> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-master-1208
20180220 13:45:20< irker518> wesnoth: pentarctagon wesnoth:master 98a788e8055b / .travis.yml: Touch-up for xcode build. https://github.com/wesnoth/wesnoth/commit/98a788e8055ba885378c3a5b527b9784dd4c5cef
20180220 14:34:18-!- vslavik [vslavik@nat/redhat/x-ekuheizzaeehzxdj] has joined #wesnoth-dev
20180220 14:36:57-!- vslavik__ [vslavik@nat/redhat/x-iafavglhlkejrgcu] has quit [Ping timeout: 256 seconds]
20180220 14:38:34< Soliton> vultraz: any reason none of my suggestions ended up in https://github.com/wesnoth/wesnoth/commit/88e5c49 ?
20180220 14:41:09-!- vultraz [uid24821@wesnoth/developer/vultraz] has quit [Quit: Connection closed for inactivity]
20180220 14:50:02-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180220 14:50:08-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20180220 14:56:44-!- travis-ci [~travis-ci@ec2-54-166-176-157.compute-1.amazonaws.com] has joined #wesnoth-dev
20180220 14:56:45< travis-ci> wesnoth/wesnoth#16548 (master - 98a788e : pentarctagon): The build has errored.
20180220 14:56:45< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/343833565
20180220 14:56:45-!- travis-ci [~travis-ci@ec2-54-166-176-157.compute-1.amazonaws.com] has left #wesnoth-dev []
20180220 15:14:51-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180220 15:14:58-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20180220 15:15:04-!- JyrkiVesterinen [~JyrkiVest@195-192-251-124.s1networks.fi] has quit [Quit: .]
20180220 15:25:20-!- vslavik__ [vslavik@nat/redhat/x-phyndmyxphixryhb] has joined #wesnoth-dev
20180220 15:27:52-!- vslavik [vslavik@nat/redhat/x-ekuheizzaeehzxdj] has quit [Ping timeout: 265 seconds]
20180220 15:45:42-!- AI0867 [~ai@wesnoth/developer/ai0867] has joined #wesnoth-dev
20180220 16:17:51< irker518> wesnoth/wesnoth:master Charles Dang 68d5a8dd57 Unit: removed unused member AppVeyor: All builds passed
20180220 16:18:21-!- vultraz [uid24821@wesnoth/developer/vultraz] has joined #wesnoth-dev
20180220 16:19:00< vultraz> Soliton: you were worried about crashes, I ensures there would be none
20180220 16:25:39< Soliton> i suggested to add another attribute instead of turning one attribute into a tag with two attributes.
20180220 16:26:57< Soliton> i guess the bug you reported already happened before your commit?
20180220 16:29:30-!- Bhoren [~Bhoren_wh@2a01:e0a:c:2150:105f:f68e:6425:dac0] has joined #wesnoth-dev
20180220 16:36:47< vultraz> Soliton: in some form, yes
20180220 16:37:07< vultraz> I hadn't figured out the exact steps to repro it
20180220 16:37:47< vultraz> Soliton: I think it's just because game::update_game isn't called. I *could* send an "update_game" signal, but not sure if that's the right fix
20180220 16:39:02< vultraz> I suppose i could still use the two-attribute suggestion.
20180220 16:39:18< vultraz> it is a bit easier to check emptiness if it's a tag though
20180220 16:40:49-!- vn971 [~vasya@94.158.103.15] has quit [Remote host closed the connection]
20180220 16:41:41-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has joined #wesnoth-dev
20180220 16:41:50< vultraz> Soliton: i'm more curious why the hell the bug only happens for people joining the game.
20180220 16:43:42< irker518> wesnoth/wesnoth:master pentarctagon ddd5032cd4 Touch-up for xcode build. AppVeyor: 1/2 builds failed
20180220 16:43:43< irker518> Details vs2013/Release: https://ci.appveyor.com/project/wesnoth/wesnoth/build/Wesnoth-VS2013-master-1515
20180220 16:59:03< irker518> wesnoth/wesnoth:master pentarctagon 98a788e805 Touch-up for xcode build. AppVeyor: vs2017/Debug Failed
20180220 16:59:04< irker518> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-master-1210
20180220 17:17:16< Soliton> vultraz: if you have more hints please add them to the bug report. i'm unlikely to get to it before the weekend. it's quite possible there are still server-side regressions from the rewrite.
20180220 17:17:47< Soliton> perhaps easiest to compare to how it worked in 1.12.
20180220 17:20:18-!- Oebele [~quassel@143.177.58.202] has joined #wesnoth-dev
20180220 17:37:46< vultraz> I could probably fix it but you'd say it's The Wrong Fix
20180220 17:38:24< Soliton> you could show it before committing. ;-)
20180220 17:38:49< Soliton> making the client request an update certainly sounds wrong.
20180220 17:39:50< vultraz> there's one instance in which the client does request an update
20180220 17:39:56< vultraz> it's odd
20180220 17:42:06< vultraz> it's before sending new level data
20180220 17:42:16< vultraz> when transitioning scenarios
20180220 17:43:42< Soliton> that's probably the only place where it should be used.
20180220 17:45:01< Soliton> i don't think the issue is that update_game is not called but describe_slots.
20180220 17:45:13< vultraz> yes
20180220 17:45:19< Soliton> update_game is fairly specific for scenario transitions.
20180220 17:45:20< vultraz> that's only called by update_game
20180220 17:45:29< vultraz> I think
20180220 17:45:35< Soliton> no, it's often called in server.cpp.
20180220 17:46:05< vultraz> well, whatever it is, it's not getting sent to the lobby when the player rejoins it
20180220 17:46:18< Soliton> either one call is missing or the corresponding lobby diff sending.
20180220 17:49:02< Soliton> so if there is an issue with players leaving the game you could check where leave_game is processed and see if there is something wrong there.
20180220 17:50:50< irker518> wesnoth: Jyrki Vesterinen wesnoth:master 1ab31bfcea52 / src/ (playsingle_controller.cpp playsingle_controller.hpp): Remove explicit destructor from playsingle_controller https://github.com/wesnoth/wesnoth/commit/1ab31bfcea520200e31b893e2bbff6c014168838
20180220 17:50:52< irker518> wesnoth: Jyrki Vesterinen wesnoth:master 5b89aaf780a6 / src/ (ai/manager.hpp game_launcher.cpp): Reset AI manager singleton pointer when exiting the game (fixes #2523) https://github.com/wesnoth/wesnoth/commit/5b89aaf780a63932a3c3f8467be639b0c547e716
20180220 17:51:04< Soliton> if there isn't anymore for things like this it helps to have some debug mode where all the WML sent and received from server or client side is printed.
20180220 17:51:31< Soliton> then you should be able to just see where stuff is missing and go from there.
20180220 17:58:14< Soliton> vultraz: btw, if you would want to update https://wiki.wesnoth.org/MultiplayerServerWML with your changes that'd be splendid. if you can be bothered even marking since what version things changed...
20180220 17:58:31< vultraz> heh
20180220 17:58:36< vultraz> probably won't happen
20180220 17:59:06< vultraz> unless I actually sit down and figure out what's what
20180220 18:00:26< vultraz> and I don't have time for that
20180220 18:00:47< vultraz> (I'm not being snarky, I really am busy with a lot of things)
20180220 18:01:26< Soliton> oh well, i understand.
20180220 18:02:33< vultraz> there's so much stuff
20180220 18:02:39< vultraz> especially in the game section
20180220 18:03:16< vultraz> the room stuff is probably irrevelant since rooms don't work
20180220 18:03:59< JyrkiVesterinen> Being busy in late beta is a bad sign, BTW...
20180220 18:04:08< vultraz> JyrkiVesterinen: life?
20180220 18:04:20< vultraz> :P
20180220 18:04:28< JyrkiVesterinen> If it's RL stuff, then it's fine.
20180220 18:04:48< JyrkiVesterinen> But your messages gave the picture that the problem is that there are too many bugs to fix.
20180220 18:04:51< vultraz> I have school stuff to do.
20180220 18:04:54< vultraz> well, that too
20180220 18:04:59< vultraz> many many bugs to fix
20180220 18:05:11< JyrkiVesterinen> As I have said, bug fixes are risky.
20180220 18:05:21< JyrkiVesterinen> By their nature, they alter behavior of existing code.
20180220 18:05:55< JyrkiVesterinen> Stabilization involves, among other things, simply leaving bugs there if fixing them is too risky.
20180220 18:06:38< JyrkiVesterinen> I recall one bug in particular in Angry Birds that I had caused and which was found shortly before the 4.1.0 release.
20180220 18:07:01< JyrkiVesterinen> I evaluated multiple ways to fix them, but determined that all ways to fix it were too risky at that point.
20180220 18:07:11< JyrkiVesterinen> Angry Birds v4.1.0 shipped with the bug present.
20180220 18:07:36< JyrkiVesterinen> Moreover, right after that we were reassigned to Angry Birds Stella. I wasn't even allowed to fix it.
20180220 18:07:48< JyrkiVesterinen> In the end, it took almost a year until they finally fixed that bug.
20180220 18:11:34< vultraz> the joys of corporate programming
20180220 18:12:04< JyrkiVesterinen> That's just responsible development.
20180220 18:12:36< JyrkiVesterinen> High-risk or even medium-risk changes should not be made right before a release. Not even if they are bug fixes.
20180220 18:12:47-!- vslavik__ [vslavik@nat/redhat/x-phyndmyxphixryhb] has quit [Quit: Leaving]
20180220 18:25:57-!- Bonobo [~Bonobo@61.68.156.44] has quit [Ping timeout: 240 seconds]
20180220 18:29:27< irker518> wesnoth/wesnoth:master pentarctagon 2794228eef Touch-up for xcode build. AppVeyor: 1/2 builds failed
20180220 18:29:28< irker518> Details vs2017/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-master-1208
20180220 18:34:46-!- travis-ci [~travis-ci@ec2-54-167-169-20.compute-1.amazonaws.com] has joined #wesnoth-dev
20180220 18:34:47< travis-ci> wesnoth/wesnoth#16549 (master - 5b89aaf : Jyrki Vesterinen): The build failed.
20180220 18:34:48< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/343947699
20180220 18:34:48-!- travis-ci [~travis-ci@ec2-54-167-169-20.compute-1.amazonaws.com] has left #wesnoth-dev []
20180220 18:39:08-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has quit [Quit: .]
20180220 18:50:58-!- vn971 [~vasya@94.158.103.15] has joined #wesnoth-dev
20180220 18:55:41< vn971> I wonder, was it discussed in wesnoth community to use Lua _functions_ in "WML"? Take, for example, wesnoth.wml_actions.event. Could we allow the following code to work?:  wesnoth.wml_actions.event {name="something", {"lua_function", { function() end }}}
20180220 18:56:18< DeFender1031> you can create custom tags, yes.
20180220 18:57:08< vn971> This is totally NOT translatable to real WML as WML cannot contain Lua functions. On the other hand, it is technically possible to support those kind of things because many tags are actually implemented in Lua already.
20180220 18:58:02< DeFender1031> There is a raw lua tag as well. I'm not sure what else you want.
20180220 18:58:27< vn971> DeFender1031: Agree. But since that would be an actual concept/ideology shift, I guess it needs some discussion before starting PR those kind of things.
20180220 18:58:44< vn971> DeFender1031: what raw lua tag?
20180220 18:59:08< DeFender1031> i have to run, I'll dig it up when I get back if you haven't found it by then.
20180220 18:59:19< vn971> There is {"lua", { code = "STRING"}}  but string is totally not the same as a function.
20180220 19:07:46-!- JyrkiVesterinen [~jyrki@85-23-197-3.bb.dnainternet.fi] has joined #wesnoth-dev
20180220 19:17:43-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20180220 19:17:43< vn971> I also wonder if it's feasible/possible for wesnoth to accept Lua functions at all.
20180220 19:18:14< vn971> (I mean things those type is "function", not just "string".)
20180220 19:19:08-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20180220 19:20:51< irker518> wesnoth: Jyrki Vesterinen wesnoth:master c1fed7cc87b7 / src/ai/manager.hpp: Fix build with GCC and Clang https://github.com/wesnoth/wesnoth/commit/c1fed7cc87b7601effac03c995fe1ae6d052f505
20180220 19:47:23-!- JyrkiVesterinen [~jyrki@85-23-197-3.bb.dnainternet.fi] has quit [Quit: .]
20180220 19:56:25< DeFender1031> how is that any different thasn a function?
20180220 19:56:47< DeFender1031> also, it's frustrating when you talk about wml tags in lua syntax.
20180220 19:58:32< irker518> wesnoth/wesnoth:master pentarctagon 98a788e805 Touch-up for xcode build. AppVeyor: 1/4 builds failed
20180220 19:58:33< irker518> Details vs2017/Debug: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-master-1210
20180220 19:59:49< Ravana_> I think it could be useful, but I don't think parser can easily support it - and workaround is good enough
20180220 20:07:34< irker518> wesnoth: V N wesnoth:master f387eea78f54 / src/actions/advancement.cpp: disable unit advancement dialog for droided side https://github.com/wesnoth/wesnoth/commit/f387eea78f5457abb97e019a5ba31c7479d35316
20180220 20:09:59< Soliton> is that really the only place where such a check is needed?
20180220 20:12:44-!- travis-ci [~travis-ci@ec2-54-166-176-157.compute-1.amazonaws.com] has joined #wesnoth-dev
20180220 20:12:45< travis-ci> wesnoth/wesnoth#16550 (master - c1fed7c : Jyrki Vesterinen): The build is still failing.
20180220 20:12:45< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/343986801
20180220 20:12:45-!- travis-ci [~travis-ci@ec2-54-166-176-157.compute-1.amazonaws.com] has left #wesnoth-dev []
20180220 20:15:16< vn971> DeFender1031: for example, here is a situation where difference is obvious:
20180220 20:15:16< vn971> local i = 10
20180220 20:15:16< vn971> wesnoth.wml_actions.event {name="whatever", {"lua", {code = "print(\"i\")"}}}
20180220 20:15:16< vn971> In the code above, you see: 1. more escaping. Which will get very ugly for multi-line body. 2. broken code as `i` is not defined in the scope where it's intended to be used. 3. The "nested" string-as-function does not allow changing variable `i` either.
20180220 20:16:29< vn971> Soliton: I tested the commit, it allowed droiding a side and let it pick advance on its own without crashes. There may be other subtle things I'm not aware of. I was basically following what gfgh*** wrote.
20180220 20:17:27< vn971> gfgtdf.  (Sorry, this nick is hard to remember.)
20180220 20:18:17< DeFender1031> vn971, what are you even doing? you're using lua to run the wml event which calls lua? why would you do that when you're already in lua?
20180220 20:19:27< vn971> DeFender1031: I'm registering an event. I want my custom code to be triggered when an event like "side turn" happens.
20180220 20:20:05< vn971> ( DeFender1031: don't mistake it with `fire_event`, which indeed fires an event, not registers it. )
20180220 20:20:34< DeFender1031> ah, you want a way to register an event handler which will run some lua code.
20180220 20:20:53< DeFender1031> from within lua already
20180220 20:20:57< DeFender1031> got it.
20180220 20:20:57< vn971> DeFender1031: yes, exactly.
20180220 20:22:05< DeFender1031> https://wiki.wesnoth.org/LuaWML/Events#wesnoth.add_event_handler
20180220 20:22:31< DeFender1031> that also takes a cfg though
20180220 20:22:46< vn971> DeFender1031: yup, it takes cfg (WML)..
20180220 20:24:16< DeFender1031> I'd support an addition to the function of an optional second parameter which is a lua callback which, if present, runs that function instead of (or maybe in addition to? though whether before or after would need to be decided on) any action wml in the cfg.
20180220 20:24:35< DeFender1031> (The cfg would still be necessary to define and filter the event, obviously)
20180220 20:24:43< DeFender1031> anyway, out again for a bit.
20180220 20:25:17< vn971> Ravana_: the parser does not need to support it actually. Only wesnoth engine has to. If you're in a WML file, there is no real significant difference between a Lua function and a string for you. But if you're in Lua, wesnoth doesn't have to parse anything, it just has to accept a certain call from Lua where an argument is a function (not string).
20180220 20:28:22< vn971> DeFender1031: to the `wesnoth.add_event_handler` function? Sounds interesting.  Have to AFK myself now tho (sleep).
20180220 20:30:58-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20180220 20:35:43< vn971> DeFender1031: I still wonder if wesnoth engine could really support Lua functions as arguments. I guess this can be a bit tricky. Functions capture their scopes, have (?) tricky life times etc.
20180220 20:37:25< Ravana_> such function would also need to be saveable
20180220 20:37:46< Ravana_> so I guess if ever, depends on the lua state issue
20180220 20:49:56-!- travis-ci [~travis-ci@ec2-54-167-169-20.compute-1.amazonaws.com] has joined #wesnoth-dev
20180220 20:49:57< travis-ci> wesnoth/wesnoth#16552 (master - f387eea : V N): The build was fixed.
20180220 20:49:57< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/344005071
20180220 20:49:57-!- travis-ci [~travis-ci@ec2-54-167-169-20.compute-1.amazonaws.com] has left #wesnoth-dev []
20180220 21:01:33< DeFender1031> Ravana_, ah right, the lua state issue. damn, forgot to consider that. So yeah, vn971's whole approach of trying to do everything in lua is currently highly flawed...
20180220 21:08:03-!- vultraz [uid24821@wesnoth/developer/vultraz] has quit [Quit: Connection closed for inactivity]
20180220 21:20:12-!- Bhoren [~Bhoren_wh@2a01:e0a:c:2150:105f:f68e:6425:dac0] has quit [Quit: Leaving]
20180220 21:31:49-!- vultraz [uid24821@wesnoth/developer/vultraz] has joined #wesnoth-dev
20180220 21:57:44-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180220 21:57:55-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20180220 22:50:25-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180220 22:50:31-!- janebot_ [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20180220 22:50:34-!- janebot_ is now known as janebot
20180220 22:55:34-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180220 22:55:39-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20180220 23:01:36-!- Oebele [~quassel@143.177.58.202] has quit [Remote host closed the connection]
20180220 23:07:14-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20180220 23:08:16-!- gfgtdf [~chatzilla@x4e36826d.dyn.telefonica.de] has joined #wesnoth-dev
20180220 23:09:04-!- irker518 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20180220 23:10:29< gfgtdf> vn971: if you want to register a lua event handler you can also use wesnoth.game_events.on_event https://github.com/wesnoth/wesnoth/blob/master/data/lua/feeding.lua#L8
20180220 23:10:50< gfgtdf> vn971: it is not as powerful as wml events tohugh as it for exmapel doesn't support onje-time events
20180220 23:12:23-!- gfgtdf [~chatzilla@x4e36826d.dyn.telefonica.de] has quit [Client Quit]
20180220 23:13:54-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Quit: Disconnecting from stoned server.]
20180220 23:14:10-!- Ivanovic [~ivanovic@p579FBA67.dip0.t-ipconnect.de] has joined #wesnoth-dev
20180220 23:36:25-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 256 seconds]
20180220 23:46:27-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180220 23:46:27-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
--- Log closed Wed Feb 21 00:00:17 2018