--- Log opened Sat Feb 24 00:00:37 2018
20180224 00:43:43-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20180224 00:49:15-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20180224 00:53:01< irker891> wesnoth: Severin Glöckner wesnoth:master b5ec7b832e34 / packaging/systemd/wesnothd.service.in: enhancements to the systemd unit file https://github.com/wesnoth/wesnoth/commit/b5ec7b832e345bb95ca94ef378713219a4263371
20180224 00:58:54-!- gfgtdf [~chatzilla@x4e36357a.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.93 [Firefox 52.6.0/20180118122319]]
20180224 00:58:54-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20180224 01:02:23-!- octalot [~steve@91.141.0.252.wireless.dyn.drei.com] has quit []
20180224 01:44:43< irker891> wesnoth/wesnoth:master Alexander van Gessel 77e966b763 Add support for data URIs as images AppVeyor: All builds passed
20180224 02:18:41-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180224 02:18:51-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20180224 02:28:53-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180224 02:28:59-!- janebot_ [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20180224 02:29:01-!- janebot_ is now known as janebot
20180224 03:50:21-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180224 03:50:27-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20180224 04:03:32< irker891> wesnoth: shikadiqueen wesmere: 71dc37b05854 tagged as v1.1.3
20180224 04:03:34< irker891> wesnoth: Iris Morelle wesmere:master e56c047cc05f / static/docroot/index.php wesmere/mw/skin.json wesmere/sass/_version.scss: Bump version https://github.com/wesnoth/wesmere/commit/e56c047cc05fc644fbacdfc1bc636df556d486dc
20180224 04:03:36< irker891> wesnoth: Iris Morelle wesmere:master bf282eea8373 / static/docroot/index.php: Merge branch 'master' into develop https://github.com/wesnoth/wesmere/commit/bf282eea8373ee8e5986aaa5408e7adb76d69d86
20180224 04:03:38< irker891> wesnoth: Iris Morelle wesmere:master db711a80fe3b / wesmere/sass/forums.scss: sass/forums: Apply phpBB 3.2 responsive styles https://github.com/wesnoth/wesmere/commit/db711a80fe3baff85a5964008c70bfceb0bab337
20180224 04:03:40< irker891> wesnoth: Iris Morelle wesmere:master da4285341d20 / wesmere/sass/forums.scss: sass/forums: Remove prosilver's search button on small viewports https://github.com/wesnoth/wesmere/commit/da4285341d20fb7c1864c06913bd442f3b7facb6
20180224 04:03:42< irker891> wesnoth: Iris Morelle wesmere:master e75d499438aa / wesmere/sass/forums.scss: sass/forums: Fix whitespace handling issues with the phpBB 3.2 text parser https://github.com/wesnoth/wesmere/commit/e75d499438aa1c0ff825fc5b469a28c9aa94f1fc
20180224 04:03:44< irker891> wesnoth: Iris Morelle wesmere:master 410c376818bf / wesmere/sass/forums.scss: sass/forums: Eliminate extra margin from prosilver https://github.com/wesnoth/wesmere/commit/410c376818bff2949879813b15a6c4722b6edd7b
20180224 04:03:46< irker891> wesnoth: Iris Morelle wesmere:master 115fd165f36e / wesmere/sass/forums.scss: sass/forums: Remove negative horizontal margin from AcidTech navbars https://github.com/wesnoth/wesmere/commit/115fd165f36e556d45ef573f557607f603b41a3a
20180224 04:03:48< irker891> wesnoth: Iris Morelle wesmere:master 71cf8593fd0a / wesmere/sass/forums.scss: sass/forums: AcidTech also needs the content overflow fix on small viewports https://github.com/wesnoth/wesmere/commit/71cf8593fd0a69fdcdbbe6938f79b8778b1de1ff
20180224 04:03:50< irker891> wesnoth: Iris Morelle wesmere:master cde54402d1c0 / wesmere/sass/forums.scss: sass/forums: Remove the negative AcidTech navbar margin on large viewports only https://github.com/wesnoth/wesmere/commit/cde54402d1c0bf6e05b116fce73099fa068d1506
20180224 04:03:52< irker891> wesnoth: Iris Morelle wesmere:master 0fffa2e97dc3 / wesmere/sass/forums.scss: sass/forums: Formatting/typo fix https://github.com/wesnoth/wesmere/commit/0fffa2e97dc3be48d0e652ad1022c616e6825f3e
20180224 04:03:54< irker891> wesnoth: Iris Morelle wesmere:master 31439098f706 / wesmere/sass/forums.scss: sass/forums: Fix giant copyright footer on prosilver Special Edition https://github.com/wesnoth/wesmere/commit/31439098f7067dcd3515f64ffbd71a0180f8c6f7
20180224 04:03:56< irker891> wesnoth: Iris Morelle wesmere:master 28faded742d9 / wesmere/sass/forums.scss: sass/forums: Trivial refactoring that was kinda supposed to be already there https://github.com/wesnoth/wesmere/commit/28faded742d988949c4918fdce383f4796f6d3d0
20180224 04:03:58< irker891> wesnoth: Iris Morelle wesmere:master 0ee632871258 / wesmere/sass/ (forums.scss gettext.scss mini.scss wesmere.scss wmlunits.scss): Include repo link in all stylesheets now that Wesmere has a permanent home https://github.com/wesnoth/wesmere/commit/0ee632871258a5f2ec621712f7a692427fdc0725
20180224 04:04:00< irker891> wesnoth: Iris Morelle wesmere:master 71dc37b05854 / static/docroot/index.php wesmere/mw/skin.json: Wesmere 1.1.3 https://github.com/wesnoth/wesmere/commit/71dc37b05854a25e86f792699e48ab2bb27c1d2a
20180224 04:04:12-!- shadowm [~iris@wesnoth/developer/shadowm] has joined #wesnoth-dev
20180224 04:13:41< irker891> wesnoth: Iris Morelle wesmere:master 3afd4ba94c47 / wesmere/sass/home/_download.scss: sass/home: Fix colour op deprecation warnings https://github.com/wesnoth/wesmere/commit/3afd4ba94c472df760a27699fe9d5c395ed0c992
20180224 04:35:18< celticminstrel> I'm getting confused in the schema of AnimationWML... it's not clear what's allowed in [frame] and what's allowed in [animation]...
20180224 04:39:05< celticminstrel> Maybe everything in [frame] is also allowed in [animation], optionally with a prefix?
20180224 04:46:44< vultraz> no idea
20180224 04:46:54< vultraz> I'm not surprised you're confused
20180224 05:10:21-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180224 05:10:32-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20180224 05:10:36< irker891> wesnoth/wesnoth:master Severin Glöckner b5ec7b832e enhancements to the systemd unit file AppVeyor: All builds passed
20180224 05:20:27< celticminstrel> I think maybe I've managed to figure it out?
20180224 05:20:43< celticminstrel> Though my interpretation may be a little more liberal than what's actually accepted by the engine.
20180224 05:23:18< celticminstrel> https://forums.wesnoth.org/viewtopic.php?p=623708#p623708
20180224 05:23:26< celticminstrel> vultraz, zookeeper: ^
20180224 05:24:10< vultraz>  Thanks, but we’ve both seen it
20180224 05:24:25< celticminstrel> Well that's good to know.
20180224 06:12:54-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has joined #wesnoth-dev
20180224 06:21:27-!- vn971 [~vasya@94.158.103.15] has quit [Ping timeout: 240 seconds]
20180224 06:26:43< celticminstrel> Blargh, I seem to be running into problems with the wildcards...
20180224 06:27:03< celticminstrel> I guess "*" comes before "a,b" or something.
20180224 06:27:33< celticminstrel> I need to check all the possible patterns and figure out which is the best match...
20180224 06:27:39< celticminstrel> Maybe I need Levenshtein?
20180224 06:29:22< celticminstrel> Suppose you have the patterns "*", "*ed", "bed,led". If you're matching it against "bed", it should pick the third one. If you're matching it agaist "red", it should pick the second.
20180224 06:30:05 * celticminstrel is using comma to separate alternating patterns, because that's how shell glob does it (albeit with added braces) and Wesnoth's wildcard match function doesn't encode this functionality.
20180224 06:35:19< celticminstrel> Or I could just go back to not supporting alternation.
20180224 06:35:36< celticminstrel> Requiring separate tag declarations for "bed" and "led" in the preceding sample.
20180224 06:35:42-!- celticminstrel is now known as celmin|sleep
20180224 06:54:18-!- vn971 [~vasya@94.158.103.15] has joined #wesnoth-dev
20180224 07:57:21< irker891> wesnoth: Charles Dang wesnoth:master 4b6a74b6f58e / src/gui/dialogs/preferences_dialog.cpp: Preferences Dialog: consolidate helpers together and apply minor cleanup https://github.com/wesnoth/wesnoth/commit/4b6a74b6f58e9eae030298d7a04dd19df89dde36
20180224 07:57:24< irker891> wesnoth: Charles Dang wesnoth:master f722a0973011 / src/gui/dialogs/ (preferences_dialog.cpp preferences_dialog.hpp): Preferences Dialog: made sound setting changes apply immediately (fixes #1766) https://github.com/wesnoth/wesnoth/commit/f722a09730118ef0c51896b0d2ec95c37f8dfc49
20180224 07:57:27< irker891> wesnoth: Charles Dang wesnoth:master cc3d73621a7d / data/gui/window/preferences/01_general.cfg src/gui/dialogs/preferences_dialog.cpp: Preferences Dialog: avoid offset-by-one handling for accl speeds https://github.com/wesnoth/wesnoth/commit/cc3d73621a7d064b7d50b3526b7b41167ec1dafa
20180224 08:21:42-!- travis-ci [~travis-ci@ec2-54-198-187-196.compute-1.amazonaws.com] has joined #wesnoth-dev
20180224 08:21:43< travis-ci> wesnoth/wesnoth#16594 (master - cc3d736 : Charles Dang): The build was broken.
20180224 08:21:43< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/345580165
20180224 08:21:43-!- travis-ci [~travis-ci@ec2-54-198-187-196.compute-1.amazonaws.com] has left #wesnoth-dev []
20180224 08:26:56-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180224 08:27:03< vultraz> offff course
20180224 08:27:07-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20180224 08:38:26-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has quit [Quit: .]
20180224 09:02:33-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180224 09:02:44-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20180224 09:05:16-!- nurupo [~nurupo.ga@unaffiliated/nurupo] has quit [Quit: nurupo]
20180224 09:06:25-!- nurupo [~nurupo.ga@unaffiliated/nurupo] has joined #wesnoth-dev
20180224 09:07:41-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20180224 09:13:42-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20180224 09:26:20-!- Oebele [~quassel@143.177.58.202] has joined #wesnoth-dev
20180224 09:41:45-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has joined #wesnoth-dev
20180224 09:47:51< irker891> wesnoth/wesnoth:master Charles Dang cc3d73621a Preferences Dialog: avoid offset-by-one  AppVeyor: vs2013/Release Failed
20180224 09:47:51< irker891> Details: https://ci.appveyor.com/project/wesnoth/wesnoth/build/Wesnoth-VS2013-master-1573
20180224 10:02:04< Soliton> celmin|sleep: levenshtein would help. not sure what the context is. if you're just doing globbing (which does not include alternation) then maybe the patterns just need to be in the right order?
20180224 10:13:59< irker891> wesnoth: Charles Dang wesnoth:master a5c230444ab2 / src/editor/editor_main.cpp: Editor: fixed button overlays being missing when loading a map from the cl https://github.com/wesnoth/wesnoth/commit/a5c230444ab2647a7ab851cc0a1496496b44b8c7
20180224 10:14:02< irker891> wesnoth: Charles Dang wesnoth:master 106a1d5c0527 / src/editor/map/ (context_manager.cpp context_manager.hpp): Editor/Context Manager: no need to use an rvalue reference just to swap https://github.com/wesnoth/wesnoth/commit/106a1d5c0527b7623b0f169322aed6335519bc17
20180224 10:20:13< irker891> wesnoth: Jyrki Vesterinen wesnoth:master dfa8682598df / src/editor/map/ (context_manager.cpp context_manager.hpp): Revert "Editor/Context Manager: no need to use an rvalue reference just to swap" https://github.com/wesnoth/wesnoth/commit/dfa8682598dfdf2e8cb0972bbd22a560b72eff15
20180224 10:35:33-!- travis-ci [~travis-ci@ec2-54-198-187-196.compute-1.amazonaws.com] has joined #wesnoth-dev
20180224 10:35:34< travis-ci> wesnoth/wesnoth#16595 (master - 106a1d5 : Charles Dang): The build is still failing.
20180224 10:35:34< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/345603461
20180224 10:35:34-!- travis-ci [~travis-ci@ec2-54-198-187-196.compute-1.amazonaws.com] has left #wesnoth-dev []
20180224 10:36:02-!- Oebele [~quassel@143.177.58.202] has quit [Remote host closed the connection]
20180224 10:58:04< irker891> wesnoth: Charles Dang wesnoth:master 028401518b85 / src/ (editor/map/editor_map.cpp map/map.hpp): Editor: fixed village counter possibly being incorrect after resizing map (fixes https://github.com/wesnoth/wesnoth/commit/028401518b85c5e40058f29b58569d9fe675519a
20180224 11:07:57< irker891> wesnoth: Jyrki Vesterinen wesnoth:master 1742166de003 / src/hotkey/command_executor.cpp: Rudimentary logging for hotkey events https://github.com/wesnoth/wesnoth/commit/1742166de003fc1042464df173a4abdaf2e89fb4
20180224 11:09:25< irker891> wesnoth/wesnoth:master Jyrki Vesterinen 1742166de0 Rudimentary logging for hotkey events AppVeyor: vs2013/Release Failed
20180224 11:09:27< irker891> Details: https://ci.appveyor.com/project/wesnoth/wesnoth/build/Wesnoth-VS2013-master-1577
20180224 11:12:18-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20180224 11:16:32-!- Oebele [~quassel@143.177.58.202] has joined #wesnoth-dev
20180224 11:46:59< irker891> wesnoth: Jyrki Vesterinen wesnoth:master fbeba25315e3 / src/hotkey/command_executor.cpp: Move hotkey event logging to a more useful place https://github.com/wesnoth/wesnoth/commit/fbeba25315e37d341913d6a980a1a17970b96051
20180224 11:48:42-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has quit [Quit: .]
20180224 11:52:58< irker891> wesnoth: Charles Dang wesnoth:master 9c8309961334 / data/gui/window/lobby_main.cfg: MP Lobby: increased chatbox height on standard resolution https://github.com/wesnoth/wesnoth/commit/9c830996133446e8b3c6b5771cce5f603d828af1
20180224 11:53:09< vultraz> Bonobo: ^
20180224 11:53:43< vultraz> Bonobo: FTR, I *strongly recommend* you DO NOT touch the GUI WML in any way besides the most minor of changes
20180224 11:54:49< vultraz> can't stop you if you do, but I very much recommend you do not. The change of breakage is very high.
20180224 11:54:53< Soliton> i'd strongly recommend not telling people to not try to change wesnoth in the way they like. they might accidentally become developers...
20180224 11:55:44 * vultraz is a strong believer in controlling the end user experience
20180224 11:56:10< Soliton> that's a really weird attitude for an open source project.
20180224 11:56:18< vultraz> indeed
20180224 11:57:39< vultraz> Being able to control the end user experience reduces the number of variables when it comes to design
20180224 11:58:19< vultraz> Options Are (Sometimes) Bad
20180224 11:59:27< vultraz> I don't really subscribe to the unixian philosophy that software is a sandbox for you to customize in any way you please.
20180224 11:59:31< vultraz> At least, not all software
20180224 11:59:43< Soliton> sure, you don't have to tell people to not touch anything and not get involved for that though.
20180224 12:00:00< vultraz> He will very likely break it if he touches it.
20180224 12:00:34< Soliton> you seem to have very low expectations of people.
20180224 12:00:52< Soliton> where would you be now if you followed that attitude?
20180224 12:01:25< wedge009> That kind of attitude sounds a lot like Apple.
20180224 12:01:34< vultraz> I like Apple
20180224 12:01:48< vultraz> Soliton: I'm simply warning him that it's Dangerous Territory
20180224 12:02:38< vultraz> GUI2 WML is not as simple to work with as it looks.
20180224 12:02:44< Soliton> maybe a better way would be to tell him to ask here if he has trouble.
20180224 12:03:11< Soliton> you know encourage people to learn how stuff works and perhaps hepl us in the future...
20180224 12:05:33< vultraz> perhaps, yes.
20180224 12:05:48-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20180224 12:08:05-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 256 seconds]
20180224 12:08:05-!- wedge010 is now known as wedge009
20180224 12:36:18< irker891> wesnoth: gfgtdf wesnoth:master 289ec41e86a3 / src/playmp_controller.cpp: fix skip_replay beeing active when mp_info->current_turn  is 0 https://github.com/wesnoth/wesnoth/commit/289ec41e86a30da61d908a558fad10ee1a512a88
20180224 12:38:03-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has joined #wesnoth-dev
20180224 13:46:48-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20180224 13:46:59-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 252 seconds]
20180224 13:46:59-!- wedge010 is now known as wedge009
20180224 13:53:40< Bonobo> I'll keep that in mind, vultraz :)
20180224 13:55:13-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 240 seconds]
20180224 13:56:32-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20180224 13:57:21< Bonobo> it's just the default layout for the full window size on my screen resolution isn't great
20180224 13:58:30< vultraz> what is your resolution
20180224 14:01:29-!- TheJJ_ [~rofl@ipbcc08bab.dynamic.kabel-deutschland.de] has joined #wesnoth-dev
20180224 14:01:52< Bonobo> 1366x705
20180224 14:02:15< vultraz> quite low..
20180224 14:02:48< Bonobo> wesnoth feels built for square screens (which it probably was)
20180224 14:05:06< shadowm> Back in 2003 most screens were 4:3 or 5:4, so yes.
20180224 14:05:35< shadowm> (Not a square, but it comes across as such for most people so good enough.)
20180224 14:08:09 * shadowm fondly remembers the times when vultraz would constantly send her and zookeeper private messages on IRC asking WML questions during his tinkering sessions and wonders what happened to that version of vultraz.
20180224 14:09:01< vultraz> It became the guy who constantly sent JyrkiVesterinen and celticminstrel messages asking c++ questions during his programming sessions :P
20180224 14:09:33-!- nurupo_ [~nurupo.ga@unaffiliated/nurupo] has joined #wesnoth-dev
20180224 14:09:59-!- TheJJ [~rofl@ipbcc08bab.dynamic.kabel-deutschland.de] has quit [Ping timeout: 264 seconds]
20180224 14:10:00-!- nurupo [~nurupo.ga@unaffiliated/nurupo] has quit [Ping timeout: 264 seconds]
20180224 14:10:00-!- irker891 [~irker@uruz.ai0867.net] has quit [Ping timeout: 264 seconds]
20180224 14:10:18< shadowm> Same guy who apparently wants to hold a monopoly on GUI stuff, yeah.
20180224 14:10:39-!- nurupo_ is now known as nurupo
20180224 14:16:05< vultraz>  Mine. All mine!
20180224 14:23:29-!- atarocch [~atarocch@93.56.164.28] has quit [Ping timeout: 248 seconds]
20180224 14:25:36< shadowm> If any of you needs to use the forums right now, you have about 4 minutes.
20180224 14:26:18< JyrkiVesterinen> Will the wiki stay up?
20180224 14:26:57< shadowm> Most of the time, yes.
20180224 14:32:52-!- atarocch [~atarocch@93.56.164.28] has joined #wesnoth-dev
20180224 14:47:11-!- irker312 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20180224 14:47:11< irker312> wesnoth/wesnoth:master Charles Dang cc3d73621a Preferences Dialog: avoid offset-by-one  AppVeyor: 1/4 builds failed
20180224 14:47:11< irker312> Details vs2013/Release: https://ci.appveyor.com/project/wesnoth/wesnoth/build/Wesnoth-VS2013-master-1573
20180224 15:02:47< irker312> wesnoth: Jyrki Vesterinen wesnoth:master 726b1be0d012 / src/hotkey/command_executor.cpp: Also log the text for SDL_TEXTINPUT events https://github.com/wesnoth/wesnoth/commit/726b1be0d0123d39ce4c202d09d9f64bdcbbdbc8
20180224 15:03:16< irker312> wesnoth: Jyrki Vesterinen wesnoth:no_implicit_hotkey_repeat 998e87a451b1 / / (12 files in 5 dirs): Don't consider input events as keypresses without release in between https://github.com/wesnoth/wesnoth/commit/998e87a451b19ad7cc7e5d2b2c514f547c195847
20180224 15:26:57-!- Bonobo [~Bonobo@61.68.207.231] has quit [Ping timeout: 240 seconds]
20180224 15:34:34< celmin|sleep> Soliton: Keeping them in order would definitely help... but the validator is storing them in a map.
20180224 15:56:59-!- travis-ci [~travis-ci@ec2-54-211-35-252.compute-1.amazonaws.com] has joined #wesnoth-dev
20180224 15:57:00< travis-ci> wesnoth/wesnoth#16602 (no_implicit_hotkey_repeat - 998e87a : Jyrki Vesterinen): The build failed.
20180224 15:57:00< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/345660076
20180224 15:57:00-!- travis-ci [~travis-ci@ec2-54-211-35-252.compute-1.amazonaws.com] has left #wesnoth-dev []
20180224 15:57:50-!- celmin|sleep is now known as celticminstrel
20180224 16:09:25< irker312> wesnoth/wesnoth:master Jyrki Vesterinen 1742166de0 Rudimentary logging for hotkey events AppVeyor: 1/2 builds failed
20180224 16:09:26< irker312> Details vs2013/Release: https://ci.appveyor.com/project/wesnoth/wesnoth/build/Wesnoth-VS2013-master-1577
20180224 16:29:48-!- Oebele [~quassel@143.177.58.202] has quit [Remote host closed the connection]
20180224 16:41:47< celticminstrel> ...come to think of it, I guess it's actually too late to do something like moving Quenoth to core.
20180224 16:41:52< celticminstrel> That would be a string change. :(
20180224 16:47:03< zookeeper> "come to think of it"? you say that as if it was seriously suggested somewhere.
20180224 16:47:20< zookeeper> or maybe i've just missed it.
20180224 16:48:13< celticminstrel> I've probably suggested it at some point, but not recently.
20180224 16:56:08< irker312> wesnoth: pentarctagon wesnoth:master b71f7cdc3cfc / / (6 files in 3 dirs): Moves the ccache clang wrapper scripts to utils/travis/. https://github.com/wesnoth/wesnoth/commit/b71f7cdc3cfc3a41d4a3ac79c5117186c2fa6599
20180224 16:56:09-!- vultraz [uid24821@wesnoth/developer/vultraz] has quit [Quit: Connection closed for inactivity]
20180224 16:57:11< celticminstrel> Another thing I think could be added to core is the Elvish Hunter.
20180224 16:57:24< celticminstrel> Obviously not with the string freeze though.
20180224 17:21:03-!- TadCarlucci [~lundberg@74.193.219.119] has quit [Quit: Leaving]
20180224 17:21:21-!- TadCarlucci [~lundberg@74.193.219.119] has joined #wesnoth-dev
20180224 17:22:22< celticminstrel> shadowm: would it be difficult to implement something like a "show spoiler units" option on units.wesnoth.org? Like a button where you click it and the units marked "spoiler" in the config show up in their proper locations.
20180224 17:22:37< celticminstrel> (Should I open an issue for it?)
20180224 17:22:56< celticminstrel> (And if so on which repo?)
20180224 17:30:40-!- Ravana_ [~Ravana@unaffiliated/ravana/x-2327071] has quit [Ping timeout: 240 seconds]
20180224 17:31:42-!- Ravana_ [~Ravana@unaffiliated/ravana/x-2327071] has joined #wesnoth-dev
20180224 17:54:39< shadowm> celticminstrel: If by spoiler units you mean those that have hide_unit=yes (or do_not_list=yes, which is specific to wmlunits and it's ignored by wesnoth), those are excluded from parsing entirely.
20180224 17:55:57< celticminstrel> shadowm: I'm aware of that, yes, but I'm proposing an additional wmlunits-specific key which doesn't prevent parsing but omits them from display on the website unless the user elects to show spoilers.
20180224 17:58:16< shadowm> Yay, more options.
20180224 17:58:25< shadowm> That's a ticket for wmlunits (part of wesnoth/wesnoth).
20180224 17:58:50< shadowm> I really don't see the advantage in that, to be honest.
20180224 17:59:36< celticminstrel> I just feel that using do_not_list for spoiler units kinda defeats the intent of the units database.
20180224 17:59:48< celticminstrel> But at the same time I understand the desire to avoid spoilers.
20180224 18:00:09< Soliton> what units do you have in mind?
20180224 18:00:13< shadowm> I really don't know what the intent of the units database is besides spying on my campaigns' unit tree.
20180224 18:00:49< shadowm> Not my area, anyway. All I did with wmlunits was to clean it up a little and make sure it worked with the new website and viceversa. :)
20180224 18:02:02< celticminstrel> Soliton: The aliens and Eloh
20180224 18:02:28< Soliton> i see, makes sense.
20180224 18:04:12< celticminstrel> Currently they're marked do_not_list which gave some people the impression that they had been removed.
20180224 18:39:29< irker312> wesnoth/wesnoth:master gfgtdf 289ec41e86 fix skip_replay beeing active when mp_in AppVeyor: All builds passed
20180224 18:45:53-!- octalot [~steve@178.165.131.89.wireless.dyn.drei.com] has joined #wesnoth-dev
20180224 18:59:10-!- gfgtdf [~chatzilla@x4e3631de.dyn.telefonica.de] has joined #wesnoth-dev
20180224 18:59:44< gfgtdf> does anyone knows the point if this side defintion? https://github.com/wesnoth/wesnoth/blob/master/data/campaigns/Northern_Rebirth/scenarios/09b_Judgment.cfg#L41 it has no_lodeader=yes and canrecruit=yes whic doesnt makse sense.
20180224 19:00:36< gfgtdf> similar this side https://github.com/wesnoth/wesnoth/blob/master/data/campaigns/Son_Of_The_Black_Eye/scenarios/07_The_Desert_of_Death.cfg#L93
20180224 19:00:52< celticminstrel> Doesn't no_leader=yes mean the unit attributes are ignored?
20180224 19:01:19< celticminstrel> Which is in fact everything except the side number and the flag.
20180224 19:02:03< celticminstrel> Similarly in the second case.
20180224 19:02:05< gfgtdf> yes that's why it doesnt make sense to me. 
20180224 19:02:27< gfgtdf> i mean you don't sepcify attribute just to explicitly ingnore thme
20180224 19:02:32< celticminstrel> I also need to extend the schema validator for this...
20180224 19:02:40< celticminstrel> Like a conditional super-tag...
20180224 19:02:51< celticminstrel> And a switch tag...
20180224 19:08:30< gfgtdf> so you are working on the schema?
20180224 19:08:56< gfgtdf> i just looked at data/schema.cfg to what [side] says and i think side= and controller= shodul really be not optional there
20180224 19:09:26< celticminstrel> Yeah, so far I've added the ability to have wildcards in key/tag names and tags that accept any child tag without further validation.
20180224 19:09:38< celticminstrel> I'm working with [wml_schema] though, not the older(?) schema format.
20180224 19:09:53< celticminstrel> So basically I'm rebuilding the entire schema in the same format as the current GUI2 schema.
20180224 19:10:06< celticminstrel> I'll keep that in mind when I get to [side].
20180224 19:10:38< gfgtdf> ah ok, so we can remove the odl schema then?
20180224 19:10:57< celticminstrel> I removed it in my local copy, both schema.cfg and schema-gui.cfg.
20180224 19:11:17< celticminstrel> I was actually considering adding a schema folder and moving gui/schema.cfg to schema/gui2.cfg.
20180224 19:12:44-!- octalot [~steve@178.165.131.89.wireless.dyn.drei.com] has quit [Ping timeout: 260 seconds]
20180224 19:12:52< gfgtdf> am i right in assuming that he old scema was never used by wensoth ittself but onyl by external tools ?
20180224 19:13:11< celticminstrel> I think so. The external tools should also be either updated or removed.
20180224 19:16:09-!- octalot [~steve@178.165.131.89.wireless.dyn.drei.com] has joined #wesnoth-dev
20180224 19:27:07< zookeeper> gfgtdf, yes, clearly those look like mistakes
20180224 19:28:17< celticminstrel> Is this valid? https://github.com/wesnoth/wesnoth/blob/master/data/core/units/dwarves/Thunderer.cfg#L185
20180224 19:28:23< celticminstrel> IIUC it should be in a [filter_attack]
20180224 19:28:35< celticminstrel> (Found by my schema validator that I'm working on.)
20180224 19:29:58< zookeeper> no idea. your checking it up is as fast as mine.
20180224 19:34:29< gfgtdf> zookeeper: coudl you please fix them?
20180224 19:34:59< celticminstrel> Just tested killing a Goblin Spearman with a Dwarvish Thunderer using the dagger. After the spearman died, the victory animation played.
20180224 19:35:10< celticminstrel> So yay, this work actually yielded something useful! \o/
20180224 19:35:18< celticminstrel> (IOW yes, it's an error.)
20180224 19:35:36< celticminstrel> Feel free to fix it. If not, I'll get to it once I'm finished getting the actual schema together.
20180224 19:36:38< gfgtdf> celticminstrel: commented on your pr.
20180224 19:37:08< celticminstrel> Use of generate_name=no in [unit_type] is not documented. I assume it does work?
20180224 19:45:00< zookeeper> gfgtdf, umm, yeah i guess
20180224 19:45:36< gfgtdf> zookeeper: thx
20180224 19:45:37-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20180224 19:45:38< zookeeper> celticminstrel, create a wolf and see?
20180224 19:53:08< celticminstrel> Plan to.
20180224 19:53:58< irker312> wesnoth: Lari Nieminen wesnoth:master 577af1e377cd / data/campaigns/Son_Of_The_Black_Eye/scenarios/07_The_Desert_of_Death.cfg: SotBE S07: Removed redundant leader keys from the leaderless side https://github.com/wesnoth/wesnoth/commit/577af1e377cd7ae1f45dbd215bb1e91c9017b697
20180224 19:54:42< celticminstrel> I assume the giant scorpion is somehow placed elsewhere, right? Assuming its presence is desired.
20180224 19:54:56< celticminstrel> Similarly in the other case in NR.
20180224 19:56:23< irker312> wesnoth: Lari Nieminen wesnoth:master 9cad2926eef6 / data/campaigns/Northern_Rebirth/scenarios/09b_Judgment.cfg: NR S09b: Removed redundant leader keys from the leaderless side https://github.com/wesnoth/wesnoth/commit/9cad2926eef6200cfcb5dfe40d4d12e9e16b947f
20180224 19:57:13< shadowm> I need everyone with mod access (that includes you devs) to log into the forums and look for anything that may be wrong or out of place.
20180224 19:57:50< celticminstrel> I'm getting the maintenance message.
20180224 19:57:59< shadowm> Log into the forums with your credentials.
20180224 19:58:31< shadowm> (I *believe* mods are also allowed during maintenance, I don't remember.)
20180224 19:58:41< gfgtdf> zookeeper: hmm afaik name=_ "Rakshas" is also used in the sides description (scenario overview flag tooltip etc. ) maybe we shodul keep that one
20180224 19:59:03< celticminstrel> Oh now it works.
20180224 19:59:18< celticminstrel> All the forums are locked. Is that intentional?
20180224 19:59:40< shadowm> Yeah, they've been locked since 30 minutes before the start.
20180224 20:00:00< zookeeper> gfgtdf, it's a cutscene scenario.
20180224 20:00:05< shadowm> Also, whoever can find a broken bbcode gets a cookie.
20180224 20:00:05< gfgtdf> ah ok
20180224 20:01:00< celticminstrel> I hope the maintenance URL will redirect back to the real one once they're back up again...
20180224 20:01:13< zookeeper> shadowm, everything seems to work for me.
20180224 20:01:30< zookeeper> ...well, i didn't try literally everything.
20180224 20:02:00< Soliton> what kind of cookie?
20180224 20:02:09< shadowm> celticminstrel: Can't do that because it's a 302 redirect.
20180224 20:02:50< shadowm> The redirect is already disabled FWIW but if you've ended up there you are supposed to refetch the original URL instead.
20180224 20:04:11< JyrkiVesterinen> I don't see anything obviously broken, either.
20180224 20:04:39< celticminstrel> ><
20180224 20:09:16< gfgtdf> the code in the last part of this post looks soemhow bad https://forums.wesnoth.org/viewtopic.php?f=5&p=623812#p623812
20180224 20:10:34< zookeeper> could that be because of the [C] in the post?
20180224 20:10:47< zookeeper> yeah, looks like it.
20180224 20:11:17< gfgtdf> ye probably, iirc the old forum would just ahve ignored tags without correpsoning closing tags 
20180224 20:11:36< gfgtdf> not treated them as bbcodes i mean
20180224 20:11:58< shadowm> I can't change that, unfortunately, we'll just have to get used to it.
20180224 20:12:16< celticminstrel> gfgtdf: [lua] and [event] are both valid in all "addon" tags, right? By which I mean [era] [campaign] [modification] [resource] and scenario tags (test/tutorial/scenario/multiplayer).
20180224 20:13:01< celticminstrel> FWIW I'm trying to determine what allowed keys and tags those all have in common, for the schema.
20180224 20:13:16< gfgtdf> i dont' think they are allowed in [campaign]
20180224 20:13:22< gfgtdf> or wait they are
20180224 20:13:36< celticminstrel> Well, [event] is listed on the wiki but [lua] isn't, I think?
20180224 20:14:21< celticminstrel> BTW, the wiki implies that [resource] and [modification] are absolutely identical in structure, is that correct?
20180224 20:15:11< celticminstrel> A lot of the keys listed for [modification] wouldn't really make sense for a [resource] though.
20180224 20:15:12< gfgtdf> lua is alloowed in cmpaign too, its handled by the same function https://github.com/wesnoth/wesnoth/blob/master/src/saved_game.cpp#L334
20180224 20:15:19< celticminstrel> Okay.
20180224 20:16:00< gfgtdf> hmm ye resoruces are somehow 'hidden modifications' that other things add by demand withotu the user having an influence on it.
20180224 20:17:02< celticminstrel> Which IMO means all the compatibility-related keys don't make sense in [resource], eg allow_scenario
20180224 20:17:11< gfgtdf> yes
20180224 20:17:18< celticminstrel> Unless loading a resouce means literally merging tags.
20180224 20:17:27< celticminstrel> ^resource
20180224 20:17:46< gfgtdf> hmm nto it just adds events, lua and load_reource.
20180224 20:17:58< gfgtdf> also this happen long after the depcheck is run afaik.
20180224 20:18:18< celticminstrel> gfgtdf: I suggest making it also add [ai] then.
20180224 20:18:50< celticminstrel> gfgtdf: You could also consider making it add [options].
20180224 20:18:54< gfgtdf> i don'T really know about the [ai] structure, actuall i always thought [ai] isa  subtag of [side] ?
20180224 20:19:15< celticminstrel> It works in [era] and (apparently) [modification] too.
20180224 20:19:23< celticminstrel> You don't need to worry about the structure.
20180224 20:19:30< celticminstrel> You can just "append_children"
20180224 20:20:03< celticminstrel> That is, take the [ai] tags and just add them to the target addon config.
20180224 20:20:11< celticminstrel> Presumably the same way you handle events and Lua.
20180224 20:20:51< gfgtdf> current that merging happens at the start of the mp_connect scren, in particular it happens after the create_game dialog was closed.
20180224 20:21:23< gfgtdf> so i don't think we can make it add options without 'risky refactors'
20180224 20:21:37< celticminstrel> Yeah, okay. I wasn't sure on options.
20180224 20:22:04< gfgtdf> celticminstrel: what does [ai] do on scenario toplevel?
20180224 20:22:22< celticminstrel> Hmm, not sure it actually works at scenario toplevel...
20180224 20:22:42< celticminstrel> [ai] in [era] or [modification] is just merged into the AI config for all AI sides in the scenario.
20180224 20:26:06-!- vultraz [uid24821@wesnoth/developer/vultraz] has joined #wesnoth-dev
20180224 20:28:10< irker312> wesnoth/wesnoth:no_implicit_hotkey_repeat Jyrki Vesterinen 998e87a451 Don't consider input events as keypresse AppVeyor: All builds passed
20180224 20:29:25< gfgtdf> celticminstrel: hmm by doing a stingsearch for "ai" i couldn't find any code that looks like it'd do such a thing. Are you sure it works that way?
20180224 20:30:07< celticminstrel> If it doesn't it's probably a regression...?
20180224 20:32:33< celticminstrel> Looks like the common bits for the "addon" tags boil down to just id, name, type, maybe description, [event], [lua], maybe [ai].
20180224 20:32:51< gfgtdf> oh i juist found it, it's https://github.com/wesnoth/wesnoth/blob/1.13.11/src/game_initialization/connect_engine.cpp#L98
20180224 20:37:04< gfgtdf> i don't think [resource] used name= or type?
20180224 20:37:41-!- octalot [~steve@178.165.131.89.wireless.dyn.drei.com] has quit [Ping timeout: 245 seconds]
20180224 20:38:24< vultraz> celticminstrel: you didn't need to reopen that...
20180224 20:39:18< celticminstrel> Well, the alternative IMO was creating a new issue.
20180224 20:39:37< vultraz> could have just left it alone :(
20180224 20:39:44< celticminstrel> gfgtdf: Really? That's a bit annoying, but okay. I guess I can work with that.
20180224 20:40:41< JyrkiVesterinen> I think creating a new issue is the right action when there is a different but related bug.
20180224 20:40:52< JyrkiVesterinen> Vultraz fixed one bug. The remaining bug is distinct.
20180224 20:41:09< celticminstrel> Fair enough.
20180224 20:41:16< celticminstrel> Feel free to do just that.
20180224 20:41:26< celticminstrel> Or maybe we should get wedge009 to do it I guess.
20180224 20:42:04< vultraz> maybe I'll fix it before then
20180224 20:44:49< gfgtdf> celticminstrel: also note that [scenario] can probably contain custom tags then are then loaded via lua wesnoth.game_events.on_load
20180224 20:45:32< celticminstrel> ...really? Well that's just great. :|
20180224 20:45:48< celticminstrel> I can easily do that mind you, it's just... slightly annoying that I have to.
20180224 20:48:41< gfgtdf> celticminstrel: are you also going to do all the known actionwml tags now ?
20180224 20:49:18< celticminstrel> No. I intend to do them eventually, but for now I'm just going to label [event] as being allowed to contain absolutely anything.
20180224 20:49:31< gfgtdf> ok
20180224 20:49:56< celticminstrel> FTR I've also done the same with [effect] and will likely also do it for ConditionWML.
20180224 20:50:18< celticminstrel> For [effect] currently I'm enforcing the presence of apply_to and that's it.
20180224 20:50:27< celticminstrel> I guess perhaps I could also validate times.
20180224 20:51:16< gfgtdf> [unit_type] can also contain custom wml, in particular since it is currently the most common way to store wml in the game config and load them then via lua.
20180224 20:51:50< celticminstrel> ...
20180224 20:51:53< gfgtdf> also [object]
20180224 20:52:08< celticminstrel> I would really prefer in most of these cases if the "absolutely everything" were restricted to an additional subtag.
20180224 20:52:29< gfgtdf> celticminstrel: hmm yes we coudl do that but it woudl break complability  a bit.
20180224 20:52:58< gfgtdf> celticminstrel: here is an example of a custom attribute in [object] https://github.com/wesnoth/wesnoth/blob/master/data/lua/feeding.lua#L38
20180224 20:53:36< celticminstrel> I don't mind so much with [object] though.
20180224 20:58:36< gfgtdf> [item] at scenario toplevel is also custom ina  sense that its read/written by lua code. I have no problems with requiring custom wml in unit_type to be in some [variables] subtype though (other then that we are in a feature freeze).
20180224 21:01:02< vultraz> *soft* feature freeze
20180224 21:01:53< celticminstrel> I think it would actually be a good idea to deprecate and remove all these on_xyz functions.
20180224 21:02:02< JyrkiVesterinen> I'd say that even soft feature freeze rules out most compatibility changes.
20180224 21:02:10< celticminstrel> Instead, add some sort of wesnoth.register_event function to replace them.
20180224 21:02:51< celticminstrel> That way people overriding them wouldn't need to ensure they call the previous version.
20180224 21:03:07< gfgtdf> celticminstrel: sounds leiak samll gain for breaking coability
20180224 21:03:13< gfgtdf> like a small*
20180224 21:03:27< celticminstrel> I think it's a pretty big gain.
20180224 21:03:44< celticminstrel> But certainly can't be done now.
20180224 21:03:54-!- octalot [~steve@178.165.131.89.wireless.dyn.drei.com] has joined #wesnoth-dev
20180224 21:03:54< celticminstrel> I agree with Jyrki.
20180224 21:04:18< celticminstrel> Adding new small features now is one thing, adding big things or breaking compatibility though is right out.
20180224 21:04:32< gfgtdf> JyrkiVesterinen: maybe you could look into https://github.com/wesnoth/wesnoth/issues/2507 It's probably just droppsing some mutexes in gettext_boost.cpp
20180224 21:05:18< JyrkiVesterinen> gfgtdf: No, not really. Bugs which can't be consistently reproduced are almost impossible to investigate.
20180224 21:08:28< gfgtdf> JyrkiVesterinen: he gave a really useful stacktrace though
20180224 21:08:59< JyrkiVesterinen> I still wouldn't be able to test whether the "fix" worked.
20180224 21:16:18< gfgtdf> by this logic all unreproducable crash would never be fixed.... I mean a fix that fixes it with a 50% is better than no fix.
20180224 21:16:26< gfgtdf> ok i'll try it
20180224 21:19:39< JyrkiVesterinen> I disagree. A "fix" you can't test is no better than shooting in the dark.
20180224 21:20:05< JyrkiVesterinen> At work, I have never, not even once, committed a "fix" I haven't been able to test.
20180224 21:20:13< JyrkiVesterinen> I simply refse to do that.
20180224 21:20:16< JyrkiVesterinen> *refuse
20180224 21:23:57< gfgtdf> JyrkiVesterinen: we are not shooting in the dark. We analyze the problem and then fix it, and we have quite good ionformation.
20180224 21:24:33< JyrkiVesterinen> Without testing, you don't know whether you have fixed it.
20180224 21:25:22< JyrkiVesterinen> In extreme cases, I have created modified builds of games in order to make bugs easier to reproduce, then fixed the bug, and verified the fix with a build with the modification still active.
20180224 21:26:17< JyrkiVesterinen> For me, being able to verify a fix is an absolute requirement. I don't want my name to be associated with any "speculative" fix.
20180224 21:26:23< gfgtdf> JyrkiVesterinen: we probably donj't have the reources to du such things here.
20180224 21:27:10< JyrkiVesterinen> Hard-to-reproduce bugs, fortunately, are not important.
20180224 21:27:20< JyrkiVesterinen> By definition, they occur extremely rarely.
20180224 21:27:30< JyrkiVesterinen> We can just ignore them.
20180224 21:27:35< gfgtdf> JyrkiVesterinen: i mean probaly yes assing somw sleeps in the bad code to amke sure both thread are there is probalby not too hard.
20180224 21:28:08< JyrkiVesterinen> Indeed, if you can make the bug 100% reproducible by fiddling with thread timing, then you can likely fix it easily.
20180224 21:28:37< gfgtdf> JyrkiVesterinen: we already ahve 2 or 3 bugtrpoert abouts that bug, considering that a  lot of people don't even bother to create reports we can assume tha it did already happened quite some time.
20180224 21:28:43< JyrkiVesterinen> In any case, I don't want to look into that bug. it's unimportant, and I'm not at all sure whether I'd be able to reproduce it.
20180224 21:39:48< irker312> wesnoth: gfgtdf wesnoth:master b780da48e70e / src/gettext_boost.cpp: add locks around gettext calls https://github.com/wesnoth/wesnoth/commit/b780da48e70e1139075890256bb089e40368b363
20180224 21:42:49-!- Bonobo [~Bonobo@61.68.207.231] has joined #wesnoth-dev
20180224 21:47:42< irker312> wesnoth/wesnoth:master Jyrki Vesterinen 726b1be0d0 Also log the text for SDL_TEXTINPUT even AppVeyor: All builds passed
20180224 21:54:44-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity]
20180224 22:00:48< Soliton> so the loading screen threading now pessimizes random code that might be called in a threaded context.
20180224 22:01:16< Soliton> so the code is now lots more complicated and potentially slower.
20180224 22:01:20< JyrkiVesterinen> And from what I can tell, gfg didn't even verify that the change fixes the crash to begin with...
20180224 22:04:09-!- travis-ci [~travis-ci@ec2-23-20-183-37.compute-1.amazonaws.com] has joined #wesnoth-dev
20180224 22:04:10< travis-ci> wesnoth/wesnoth#16608 (master - b780da4 : gfgtdf): The build was broken.
20180224 22:04:10< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/345754885
20180224 22:04:10-!- travis-ci [~travis-ci@ec2-23-20-183-37.compute-1.amazonaws.com] has left #wesnoth-dev []
20180224 22:04:46< celticminstrel> And he closed the issue(s). And broke the build.
20180224 22:05:06< JyrkiVesterinen> He didn't break the build. Just a random build failure.
20180224 22:05:12< celticminstrel> Ah okay.
20180224 22:05:36< gfgtdf> JyrkiVesterinen: no in fact i currently cannot even build wesnoth (that's wha i wanted someone else to do it) and did that commit on the githuib web interface. But i think it's quite clear that there is a bug, even if not all of the 3 ports are instance of that one.
20180224 22:05:57< JyrkiVesterinen> Sure, no one is denying the existence of the bug.
20180224 22:06:00-!- gfgtdf [~chatzilla@x4e3631de.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.93 [Firefox 52.6.0/20180118122319]]
20180224 22:06:20< JyrkiVesterinen> It's just that I, at least, have a policy of never committing fixes without verifying them.
20180224 22:06:44< celticminstrel> IMO that should've been done on a branch, as well. Just in case it did turn out to introduce some trivial syntax error or something.
20180224 22:07:22< JyrkiVesterinen> I have ended up observing people committing syntax errors even at work.
20180224 22:07:46< JyrkiVesterinen> Someone from Operations committed Lua code that had "if condition" instead of "if condition then".
20180224 22:07:57-!- gfgtdf [~chatzilla@x4e3631de.dyn.telefonica.de] has joined #wesnoth-dev
20180224 22:08:11< JyrkiVesterinen> One should always at least run the program before committing code. Always.
20180224 22:08:29< JyrkiVesterinen> (That case caused a crash on startup, impossible to miss.)
20180224 22:16:24< celticminstrel> Wait, do the forums no longer support "egosearch"?
20180224 22:16:37< celticminstrel> Oh found it, never mind.
20180224 22:16:51< celticminstrel> Ugh, this takes up almost twice as much space as before.
20180224 22:17:10< celticminstrel> At least it gives off that impression, I could be imagining it I guess.
20180224 22:19:25< gfgtdf> Soliton: well the way it is supposed to work is that the display code does actuall very little (rendering the loadingscreen and recating to clicking on close button), so there shouldn't be many overlaps (this one was actually known for quite some time). 
20180224 22:20:24< JyrkiVesterinen> I have spotted while developing Wesnoth that the loading screen appears to spend a significant amount of time redrawing the text over and over.
20180224 22:20:38< irker312> wesnoth: Charles Dang wesnoth:master fa3b7df80c1f / src/cursor.cpp: Cleaned up cursor handling code https://github.com/wesnoth/wesnoth/commit/fa3b7df80c1ff0433e637c5d1b03a6339ea9ae25
20180224 22:20:50< JyrkiVesterinen> It hasn't been important enough to warrant further investigation.
20180224 22:20:51< gfgtdf> Soliton: and it if clearly faster then the only alterntive considered singletraded solution which would recreate the dialog object over and over.
20180224 22:21:10< JyrkiVesterinen> But it has likely amplified problems with the race condition.
20180224 22:21:35< Soliton> i prefer code that works to code that is fast.
20180224 22:22:31< gfgtdf> it does work.
20180224 22:23:05< Soliton> perhaps now it does. let's hope you're right.
20180224 22:25:03< gfgtdf> an alternative fix shoudl probably be to 'send' translated versions of the state string form the worker thread to the drawing thread instead of the enum, but i didn't want to rely only no other trnqslatable string beeing involved in the loadingscreen.
20180224 22:25:23< vultraz> JyrkiVesterinen: that possibly has to do with the animation
20180224 22:26:29< gfgtdf> but that 'animation' isn't translated also it afaik doesnt change it's size
20180224 22:27:15< vultraz> we really need a proper animation there :(
20180224 22:27:37< celticminstrel> It's the text that's translated, not the dots.
20180224 22:31:03< gfgtdf> vultraz: anmiations or even embedded videos would be really nice in gui2 in particluar for umc.
20180224 22:31:25< celticminstrel> ...I don't think I really like how all the post buttons are now just images. I can probably get used it it, but...
20180224 22:32:10< gfgtdf> oh th forum is back on.
20180224 22:33:10< celticminstrel> The profile section seems unnecessarily wide...
20180224 22:33:19< celticminstrel> I mean for each post.
20180224 22:33:58< gfgtdf> vultraz: any optinion on clising https://github.com/wesnoth/wesnoth/issues/2508 ? It migth not be fixed but it doesnt contain any valuable information eigher.
20180224 22:34:50< vultraz> uhhhh...
20180224 22:36:01< celticminstrel> Looks like Jyrki has a possible fix?
20180224 22:36:13< celticminstrel> Oh, wait, guess not.
20180224 22:36:35< JyrkiVesterinen> I already committed my "fix".
20180224 22:36:36< JyrkiVesterinen> https://github.com/wesnoth/wesnoth/commit/dfbfd924fb0aabf4c7f5e080db48b6eb0cd336c5
20180224 22:36:40< JyrkiVesterinen> See the commit message.
20180224 22:37:29< celticminstrel> Yeah, it says it doesn't actually fix it.
20180224 22:37:42< irker312> wesnoth: gfgtdf wesnoth:gfgtdf-patch-1 890d2e4a59e9 / src/playsingle_controller.hpp: fix reset_gamestate_exception not inheriting from std::exception https://github.com/wesnoth/wesnoth/commit/890d2e4a59e92ccb7d73ec93b3a084d008ff7044
20180224 22:38:47< gfgtdf> i noticed travis is much faster now that's quite nice.
20180224 22:39:08< irker312> wesnoth: Charles Dang wesnoth:master 4cb067171d8f / src/cursor.cpp: Minor simplification of fa3b7df https://github.com/wesnoth/wesnoth/commit/4cb067171d8f8debcc438c561e6d81994e281075
20180224 22:39:20< vultraz> gfgtdf: yes it uses a cache now
20180224 22:39:29< vultraz> thank pent
20180224 22:42:36-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has quit [Quit: Going to bed]
20180224 23:08:18-!- travis-ci [~travis-ci@ec2-23-20-183-37.compute-1.amazonaws.com] has joined #wesnoth-dev
20180224 23:08:19< travis-ci> wesnoth/wesnoth#16610 (gfgtdf-patch-1 - 890d2e4 : gfgtdf): The build was broken.
20180224 23:08:19< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/345769407
20180224 23:08:19-!- travis-ci [~travis-ci@ec2-23-20-183-37.compute-1.amazonaws.com] has left #wesnoth-dev []
20180224 23:08:24< vultraz>  celticminstrel the comment said macOS wants 16x16 cursors exactly no idea why or if it’s still rkv ant
20180224 23:08:55< celticminstrel> I can confirm that MacOS supports cursors of arbitrary sizes.
20180224 23:09:05< celticminstrel> I'm using... IIRC 24x24 cursors in BoE.
20180224 23:09:19-!- TadCarlucci [~lundberg@74.193.219.119] has quit [Quit: Leaving]
20180224 23:11:03< irker312> wesnoth: gfgtdf wesnoth:master 890d2e4a59e9 / src/playsingle_controller.hpp: fix reset_gamestate_exception not inheriting from std::exception https://github.com/wesnoth/wesnoth/commit/890d2e4a59e92ccb7d73ec93b3a084d008ff7044
20180224 23:11:05< irker312> wesnoth: gfgtdf wesnoth:master f978c2c5dc79 / src/playsingle_controller.hpp: fix reset_gamestate_exception not inheriting from std::exception https://github.com/wesnoth/wesnoth/commit/f978c2c5dc7907d974bdb49f9859da4451319b4c
20180224 23:11:32< gfgtdf> accidnetly pressed merge instead of sqashandmerge
20180224 23:11:46< gfgtdf> rebaseandmerge i meant
20180224 23:13:22-!- TadCarlucci [~lundberg@74.193.219.119] has joined #wesnoth-dev
20180224 23:17:19< celticminstrel> I wonder if boost::regex supports intersection... I assume not, but it'd be cool if it does.
20180224 23:17:51< celticminstrel> Not in syntax, just like... you have two regexes and can intersect them to get a new regex.
20180224 23:18:37< celticminstrel> Mind you... most of the regex flavours are actually non-regular so I'm not sure how "safe" that would be...
20180224 23:24:46< gfgtdf> what are you trying to do ?
20180224 23:25:17< celticminstrel> Well I don't actually need union, only intersection.
20180224 23:25:26< celticminstrel> I mean the other way around, I need union.
20180224 23:25:30< celticminstrel> Which is supported in the syntax.
20180224 23:25:43< celticminstrel> But anyway, I want to extend [type] so that they can basically reference each other.
20180224 23:26:19< celticminstrel> So you can have a [type] which says "a valid value of type Q is one that matches type C or type D or this additional pattern".
20180224 23:26:43< gfgtdf> ok
20180224 23:41:13< wedge009> JyrkiVesterinen: vultraz: celticminstrel: My interpretation was that it's one issue, and while one half is resolved, the other still isn't. But if you want me to create a new report, I can do that.
20180224 23:42:28< Soliton> i understood it as still the same bug as well.
20180224 23:44:41< irker312> wesnoth: Iris Morelle website:master 501645fed9cd / gettext.wesnoth.org/index.php: gettext.w.o: Use total count instead of fuzzy+translated count in language view https://github.com/wesnoth/website/commit/501645fed9cd3e60e74c716519602e40b2345b3b
20180224 23:47:25-!- travis-ci [~travis-ci@ec2-23-20-183-37.compute-1.amazonaws.com] has joined #wesnoth-dev
20180224 23:47:26< travis-ci> wesnoth/wesnoth#16613 (master - f978c2c : gfgtdf): The build was broken.
20180224 23:47:26< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/345776359
20180224 23:47:26-!- travis-ci [~travis-ci@ec2-23-20-183-37.compute-1.amazonaws.com] has left #wesnoth-dev []
20180224 23:56:01< vultraz> it is the same bug, i guess
20180224 23:58:46< irker312> wesnoth/wesnoth:master Jyrki Vesterinen c66f5c5274 Don't consider input events as keypresse AppVeyor: All builds passed
--- Log closed Sun Feb 25 00:00:38 2018