--- Log opened Tue Feb 27 00:00:41 2018
20180227 00:02:47-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20180227 00:46:02-!- Bhoren [~Bhoren_wh@2a01:e0a:c:2150:14c2:4837:ca41:e9c3] has quit [Quit: Leaving]
20180227 00:55:27< irker683> wesnoth: Gregory A Lundberg wesnoth:master f0f3e99e86e0 / src/server/mysql_prepared_statement.ipp: Fix error missing brackets https://github.com/wesnoth/wesnoth/commit/f0f3e99e86e0235f9d6b4c39308707c941a212d8
20180227 01:00:01-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20180227 01:15:40< celticminstrel> Random thought... is there any way for a filter to match a ring around a focal point?
20180227 01:15:57< celticminstrel> Similar to radius, but excluding the interior (which includes the focal point).
20180227 01:16:15< celticminstrel> ...maybe radius=n [not]radius=n-1?
20180227 01:18:08< celticminstrel> Huh, it appears that some old quote markup is broken?
20180227 01:19:27< celticminstrel> Okay, I think I might've actually found a bug on the forum. o.o
20180227 01:19:56< celticminstrel> It seems to be possible for markup to work in the preview but not when submitting.
20180227 01:24:38< celticminstrel> shadowm: Oh yeah, does the forum upgrade allow us to support the WML syntax hiliting? (Speaking of which, I keep noticing WML snippets on the wiki that aren't hilited, is it even working right now? Or am I just imagining that it's not working?)
20180227 01:25:12< celticminstrel> Also, FTR, the broken BBCode case I noticed was a [quote=name] where name was not quoted.
20180227 01:30:13-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180227 01:30:19-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20180227 01:37:04-!- Bonobo [~Bonobo@61.68.207.231] has joined #wesnoth-dev
20180227 01:57:24< DeFender1031> celticminstrel, a ring would probably be "radius=3[not]radius=2[/not]", no?
20180227 01:57:45< celticminstrel> So my guess is probably correct huh.
20180227 01:58:37< DeFender1031> oh, I missed that line
20180227 02:15:40< shadowm> celticminstrel: Unquoted names didn't work with [quote] before so that doesn't sound like news to me.
20180227 02:16:49< shadowm> As for the wiki, maybe I upgraded it since the last time I had to fix the internal table of allowed languages that it uses and it got clobbered in the process, but I doubt that because I'm pretty sure last time I used a patch?
20180227 02:16:54< shadowm> May check later anyway.
20180227 02:16:57< shadowm> As for the forums, no.
20180227 02:17:56< celticminstrel> I thought I remembered unquoted names working in [quote]...
20180227 02:18:28< celticminstrel> I do recall you saying a forum upgrade would be needed before WML syntax hiliting could be enabled on the forums.
20180227 03:27:37< shadowm> The only thing I know is that I haven't found any syntax highlight extensions for phpBB 3.2 or even 3.1.
20180227 03:57:04-!- irker683 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20180227 04:29:01< celticminstrel> Ah.
20180227 04:29:14< celticminstrel> Mildly unfortunate.
20180227 04:40:21-!- irker839 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20180227 04:40:21< irker839> wesnoth/wesnoth:master Gregory A Lundberg f0f3e99e86 Fix error missing brackets AppVeyor: All builds passed
20180227 05:03:27< shadowm> celticminstrel: I see the wml and wfl lexers in the MW extension's lexers list. Any specific pages with issues?
20180227 05:04:38< celticminstrel> Okay, the first one I saw is one that actually isn't set to use hiliting...
20180227 05:06:09< celticminstrel> LuaWML does appear to be working, apart from some missing CSS classes (eg [event] isn't coloured because I gave it a non-standard class).
20180227 05:07:00< celticminstrel> Wesnoth_Formula_Language also seems fine, so I guess it was likely a false alarm where I saw ones that haven't been set to use hiliting.
20180227 05:07:08< celticminstrel> That said, the missing classes could still be fixed, right?
20180227 05:07:40< celticminstrel> https://github.com/CelticMinstrel/wml-pygments/blob/master/wesnoth.py#L76
20180227 05:08:19< celticminstrel> Basically nte, nta, and nti need to be defined.
20180227 05:16:43< shadowm> Where, exactly?
20180227 05:17:09< celticminstrel> In the stylesheet?
20180227 05:17:25< shadowm> The Wesmere stylesheet doesn't define any rules for syntax highlighting.
20180227 05:17:35< celticminstrel> So where are those rules coming from then...
20180227 05:17:38< shadowm> So that sounds like it's the extension's responsibility somehow?
20180227 05:18:30< celticminstrel> According to inspector it comes from "load.php:1". So helpful. :|
20180227 05:18:38< shadowm> It's the extension.
20180227 05:18:44< celticminstrel> (I guess the CSS is concatenated and minified or something?)
20180227 05:18:56< shadowm> There is a "script to update Pygments CSS" in it.
20180227 05:19:17< shadowm> Yes, MW's CSS is coalesced and minified by the resource loader API.
20180227 05:19:48< celticminstrel> So it wasn't you who defined the syntax hiliting colours, huh.
20180227 05:19:53< celticminstrel> It's just the defaults.
20180227 05:19:57< shadowm> https://pastebin.com/9kwiWzBJ
20180227 05:20:07< shadowm> This is the stylesheet right now.
20180227 05:20:25< shadowm> I'll check what happens if I use the bundled updater script.
20180227 05:21:20< celticminstrel> I guess my extension doesn't actually define default colours for those classes...
20180227 05:22:00< shadowm> The updater script doesn't make any changes.
20180227 05:22:10< shadowm> That's probably why?
20180227 05:23:44< celticminstrel> I do define colours but they're in a whole separate custom style...
20180227 05:27:37< celticminstrel> The documentation says that Name.Tag.Event should inherit from Name.Tag, but I guess that only works if it knows that Name.Tag.Event is a thing that exists...
20180227 05:32:04< celticminstrel> My module does add the custom tokens to the dictionary of known tokens (the line I linked earlier), but maybe it's not being loaded when updating the CSS?
20180227 05:34:04< shadowm> It runs $wgPygmentizePath though.
20180227 05:34:26< shadowm> Which is set to /home/wesnoth/mw-wesnoth-pygmentize/Pygments-2.1.3/pygmentize, which can see your lexer.
20180227 05:35:15< shadowm> The parameters it uses are -f html -S default -a .mw-highlight
20180227 05:38:21< celticminstrel> Okay, so that outputs the CSS.
20180227 05:43:12< celticminstrel> I guess it's not possible to use -S wml or anything like that, because I never registered my custom style properly.
20180227 05:44:28< celticminstrel> In fact, to be registered properly it would need to be a separate module... but it's not even a complete style, really, so I don't think that's a great idea anyway.
20180227 05:47:28< celticminstrel> I think I basically understand why it's not seeing the custom classes - it loads formatters as needed with __import__.
20180227 05:47:43< celticminstrel> Which means it'll only know about the custom classes if it loads the wml module.
20180227 05:48:29< celticminstrel> I can't think of a solution other than editing token.py... which obviously isn't a great solution... :|
20180227 05:49:18< celticminstrel> The other alternative is to use standard token types, which means losing the inheritance between Name.Tag and the special tags. Maybe that inheritance isn't that important though?
20180227 05:50:55< celticminstrel> I think I've been saying formatter where I meant lexer.
20180227 05:51:21 * shadowm doesn't follow but approves of whatever solution doesn't involve modifying Pygments or MW.
20180227 05:51:53< shadowm> *MW's syntax highlighting extesion
20180227 05:51:57< shadowm> **extension
20180227 05:54:13< celticminstrel> Likewise.
20180227 05:54:48< celticminstrel> It doesn't look possible to load a lexer with the -S option though, which I think means the only workable option would be to define a full custom style module.
20180227 05:55:12< celticminstrel> IOW, take my custom style and define all the token types that my lexer doesn't use.
20180227 05:56:34< celticminstrel> So then you could run something like "pygmentize -f html -S custom-style -a .mw-highlight" instead of -S default, and it would work, I'm pretty sure.
20180227 05:57:16< celticminstrel> That means someone needs to decide on a colour scheme.
20180227 05:57:20< shadowm> Actually, there should be another alternative.
20180227 05:57:24< celticminstrel> Oh?
20180227 05:57:34< celticminstrel> Did you think of something?
20180227 05:58:05< shadowm> https://wiki.wesnoth.org/MediaWiki:Common.css
20180227 05:58:56< celticminstrel> Ah yes, that would work. The CSS classes are in the generated HTML, they're just not defined anywhere.
20180227 05:59:13< shadowm> You decide what the colour scheme should be. :p
20180227 05:59:32< shadowm> I'm guessing .nte should be bold at least?
20180227 06:00:03< shadowm> I see it's used for [event]. Don't know anything about the other classes.
20180227 06:00:11< celticminstrel> Well, all tags are bold, so I'd say both nte and nta should be bold. I could maybe see an exception for nti since that's variable expansion.
20180227 06:00:40< celticminstrel> Let's see, general tags are green...
20180227 06:01:12< celticminstrel> Maybe blue for events?
20180227 06:02:05< shadowm> Like this? https://pastebin.com/7S190GGc
20180227 06:02:27< celticminstrel> Sure.
20180227 06:02:39< shadowm> What's .nta for again?
20180227 06:02:43< celticminstrel> Animation tags.
20180227 06:03:05< celticminstrel> Hmm, $xyz syntax is currently bold #BB6688 (no idea what colour that is).
20180227 06:03:25< celticminstrel> I could see an argument for colouring [insert_tag] (nti) the same colour though.
20180227 06:03:27< shadowm> <insert screenshot here>
20180227 06:04:03< celticminstrel> And animation tags, uhh...
20180227 06:04:15< shadowm> Purple, definitely.
20180227 06:04:21< celticminstrel> Okay sure. I like purple/
20180227 06:04:47< shadowm> So what is .nti?
20180227 06:04:50< shadowm> Oh I see.
20180227 06:04:53< celticminstrel> [insert_tag]
20180227 06:07:06-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Quit: wedge009]
20180227 06:07:33< shadowm> I believe just F5 on a relevant page should be enough, otherwise CTRL+F5.
20180227 06:08:09< celticminstrel> \o/
20180227 06:08:18< celticminstrel> [event] is in blue!
20180227 06:10:23-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20180227 06:40:38< celticminstrel> It looks like I actually need to update wml-pygments. It doesn't recognize #arg or #deprecated.
20180227 06:40:48< shadowm> What's #arg?
20180227 06:41:02 * shadowm checks PreprocessorRef.
20180227 06:41:06< celticminstrel> Used for Zookeeper's implementation of optional macro arguments.
20180227 06:41:26< celticminstrel> And yeah it's in PreprocessorRef.
20180227 06:41:50< shadowm> {FOO bar=baz} is still treated as usual if there's no #arg bar in the macro definition, right?
20180227 06:41:58< celticminstrel> I think so?
20180227 06:42:18< celticminstrel> I haven't really used it so you'd have to ask zookeeper.
20180227 06:42:44< shadowm> I'm going to assume yes since he's not exactly one of the people who like breaking backwards compat here.
20180227 06:42:50< celticminstrel> True, true.
20180227 06:42:59< celticminstrel> I also seem to recall some discussion on how to handle that point.
20180227 06:47:49< celticminstrel> Is this even a real thing? I've never seen it before in any actual files. https://wiki.wesnoth.org/LocaleWML
20180227 06:59:14-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The computer falls into a deep sleep, to awake again some other day!]
20180227 07:07:33-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20180227 07:13:26< shadowm> celticminstrel: data/languages/ in mainline.
20180227 07:13:41< celticminstrel> I see.
20180227 07:14:02< celticminstrel> I suppose it's probably one of those files that are loaded explicitly rather than implicitly through the _main.cfg.
20180227 07:15:09< shadowm> No, it's loaded from data/hardwired/language.cfg (which in turn *is* actually hardwired into the engine).
20180227 07:16:01< celticminstrel> Well, close enough... but anyway I need to sleep.
20180227 07:16:13< shadowm> Okay, have a good night o/
20180227 07:16:21< celticminstrel> G'night
20180227 07:19:03-!- JyrkiVesterinen [~JyrkiVest@195-192-251-124.s1networks.fi] has joined #wesnoth-dev
20180227 07:23:18-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The computer falls into a deep sleep, to awake again some other day!]
20180227 07:40:29-!- irker839 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20180227 08:41:05< AI0867> zookeeper: done
20180227 08:46:23< Soliton> AI0867: the ipf you just append to the end?
20180227 08:52:35< Soliton> nevermind, downloaded the example.
20180227 10:15:37-!- JyrkiVesterinen [~JyrkiVest@195-192-251-124.s1networks.fi] has quit [Quit: .]
20180227 10:19:52-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20180227 10:57:44< zookeeper> AI0867, oh, awesome.
20180227 11:25:10-!- Gambit [~derek@wesnoth/developer/grickit] has quit [Ping timeout: 256 seconds]
20180227 11:25:17-!- Gambit [~derek@wesnoth/developer/grickit] has joined #wesnoth-dev
20180227 11:28:46-!- vladimirslavik [vslavik@nat/redhat/x-xbsryeasolkzepev] has joined #wesnoth-dev
20180227 11:35:46-!- JyrkiVesterinen [~JyrkiVest@195-192-251-124.s1networks.fi] has joined #wesnoth-dev
20180227 12:00:58-!- irker425 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20180227 12:00:59< irker425> wesnoth: gfgtdf wesnoth:master fbf9223e8690 / src/server/game.cpp: remove outdated comment https://github.com/wesnoth/wesnoth/commit/fbf9223e8690d14a15d7ba170c7d9d2313aa36d4
20180227 12:05:04< irker425> wesnoth: gfgtdf wesnoth:master dee8a4a582b5 / src/server/game.cpp: fix illegal is_invalid_filename_char list https://github.com/wesnoth/wesnoth/commit/dee8a4a582b5666e75ce3e6f5abd30c5a3f022e6
20180227 12:49:25-!- vslavik [vslavik@nat/redhat/x-ruyykdwmubyilrmn] has joined #wesnoth-dev
20180227 12:51:52-!- vladimirslavik [vslavik@nat/redhat/x-xbsryeasolkzepev] has quit [Ping timeout: 240 seconds]
20180227 13:28:33-!- Bonobo [~Bonobo@61.68.207.231] has quit [Ping timeout: 240 seconds]
20180227 13:51:02< zookeeper> AI0867, any idea whether it'd be feasible to allow that in place of normal image paths everywhere?
20180227 14:05:58< JyrkiVesterinen> Data URIs everywhere in the engine should *not* be allowed.
20180227 14:07:10< JyrkiVesterinen> I have been thinking about implementation of hardware rendering, and one problem with it is how the engine allows images to be loaded with just the path string in all over the place.
20180227 14:07:38< JyrkiVesterinen> I'm planning to put a stop to it, and store direct references to sprites wherever possible.
20180227 14:07:53< irker425> wesnoth: gfgtdf wesnoth:master 7cc7f228e5d9 / src/server/game.cpp: remove outdated comment https://github.com/wesnoth/wesnoth/commit/7cc7f228e5d949d85f654ebbc57e89165b4ef752
20180227 14:08:33< JyrkiVesterinen> gfgtdf: Could you use [ci skip] for commits where you just change comments?
20180227 14:15:36< zookeeper> JyrkiVesterinen, what exactly do you mean by storing direct references?
20180227 14:15:55< JyrkiVesterinen> opengl::sprite& sprite;
20180227 14:19:39< zookeeper> okay, but... what does that have to do with images being loaded with just the path string everywhere? if you're just talking about internal implementation only, then i don't need to do know if it's hard to explain, i'm just curious. :p
20180227 14:20:33< JyrkiVesterinen> I am indeed talking about the internal implementation.
20180227 14:21:53< JyrkiVesterinen> While debugging the graphics pipeline, I have noted that we're storing images almost everywhere as strings, and loading them with the image cache manager. This allows images to be loaded and new IPFs to be run anywhere, which is terrible for hardware rendering.
20180227 14:22:43< JyrkiVesterinen> The underlying problem is that our API, in general, is too lenient.
20180227 14:23:08< JyrkiVesterinen> You can load new images in [event] without warning.
20180227 14:23:46< JyrkiVesterinen> There are time areas, which means that the engine needs to support rendering things with different ToDs at the same time.
20180227 14:24:32< JyrkiVesterinen> The direction where we need to go is making the APIs stricter and allowing *less* stuff, until we figure out what is feasible to support with hardware rendering.
20180227 14:26:39-!- octalot [~steve@178.165.128.59.wireless.dyn.drei.com] has quit [Ping timeout: 252 seconds]
20180227 14:35:26< zookeeper> JyrkiVesterinen, right, okay. this is probably too obvious to work (for whatever reasons), but couldn't you more or less keep the path strings but use them as keys to a hashmap (containing direct sprite references) or something?
20180227 14:35:50< zookeeper> well, maybe just a map.
20180227 14:37:39< zookeeper> or wait, is there even such a thing as a non-hash map? maybe not. anyway, you get the idea.
20180227 14:42:27< JyrkiVesterinen> I have also thought about that.
20180227 14:43:03< JyrkiVesterinen> I'll need to investigate in practice where I need to retain support for image path strings, and where I can remove it.
20180227 14:44:06< JyrkiVesterinen> And I plan to make it possible to still fetch images with a path string. But with the caveat that, in the future, it will be necessary to know in which texture atlas it is.
20180227 14:44:50< JyrkiVesterinen> So that one can no longer use e.g. a unit image as a map terrain.
20180227 14:55:35< zookeeper> sounds like a pretty radical change even on the WML API side.
20180227 15:00:30-!- vslavik__ [vslavik@nat/redhat/x-oogqtphetglslkgr] has joined #wesnoth-dev
20180227 15:03:14-!- vslavik [vslavik@nat/redhat/x-ruyykdwmubyilrmn] has quit [Ping timeout: 260 seconds]
20180227 15:12:14-!- JyrkiVesterinen [~JyrkiVest@195-192-251-124.s1networks.fi] has quit [Quit: .]
20180227 15:25:19< AI0867> 15:37 < zookeeper> or wait, is there even such a thing as a non-hash map? maybe not. anyway, you get the idea. ← you can implement a map as a tree with depth log(n)
20180227 15:26:30< AI0867> in fact std::map is such a map. std::unordered_map is a hashmap, and was only added in C++11
20180227 15:28:55-!- vslavik [vslavik@nat/redhat/x-vwfiewdgovavbktf] has joined #wesnoth-dev
20180227 15:31:10-!- vslavik__ [vslavik@nat/redhat/x-oogqtphetglslkgr] has quit [Ping timeout: 240 seconds]
20180227 15:34:59-!- vslavik__ [vslavik@nat/redhat/x-owhqtvvkdoarxsrp] has joined #wesnoth-dev
20180227 15:37:25-!- vslavik [vslavik@nat/redhat/x-vwfiewdgovavbktf] has quit [Ping timeout: 252 seconds]
20180227 15:58:59< irker425> wesnoth: Charles Dang website:develop 9cf32b02799b / eclipse.wesnoth.org/ (css/main.css img/decor.png index.html): E.W.O: some initial work to update site from Glamdrol to Wesmere https://github.com/wesnoth/website/commit/9cf32b02799b7daca0f20f7e20ed66e192e62d85
20180227 16:36:43-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has joined #wesnoth-dev
20180227 16:51:20-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180227 16:51:26-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20180227 17:04:53< irker425> wesnoth: Jyrki Vesterinen wesnoth:master ecc0dca66573 / / (12 files in 5 dirs): Don't consider input events as keypresses without release in between https://github.com/wesnoth/wesnoth/commit/ecc0dca665737bcb411fbd355edd37df8a9038b8
20180227 17:23:36-!- Oebele [~quassel@143.177.58.202] has joined #wesnoth-dev
20180227 17:58:05-!- travis-ci [~travis-ci@ec2-54-145-192-226.compute-1.amazonaws.com] has joined #wesnoth-dev
20180227 17:58:06< travis-ci> wesnoth/wesnoth#16654 (master - ecc0dca : Jyrki Vesterinen): The build was broken.
20180227 17:58:06< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/346877106
20180227 17:58:06-!- travis-ci [~travis-ci@ec2-54-145-192-226.compute-1.amazonaws.com] has left #wesnoth-dev []
20180227 18:01:14-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20180227 18:19:34-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20180227 18:36:04< irker425> wesnoth/wesnoth:master Jyrki Vesterinen ecc0dca665 Don't consider input events as keypresse AppVeyor: vs2015/Release Failed
20180227 18:36:05< irker425> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-1621
20180227 18:37:30< irker425> wesnoth/wesnoth:master gfgtdf dee8a4a582 fix illegal is_invalid_filename_char lis AppVeyor: All builds passed
20180227 19:09:34-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20180227 19:20:51-!- vslavik__ [vslavik@nat/redhat/x-owhqtvvkdoarxsrp] has quit [Quit: Leaving]
20180227 19:21:51-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20180227 19:43:07< irker425> wesnoth/wesnoth:master Jyrki Vesterinen ecc0dca665 Don't consider input events as keypresse AppVeyor: 1/6 builds failed
20180227 19:43:08< irker425> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-1621
20180227 20:08:12-!- octalot [~steve@77.119.128.7.wireless.dyn.drei.com] has joined #wesnoth-dev
20180227 20:17:12-!- galegosimpatico [~ec2-user@unaffiliated/ushiu] has left #wesnoth-dev ["WeeChat 1.9.1"]
20180227 20:17:28-!- galegosimpatico [~ec2-user@unaffiliated/ushiu] has joined #wesnoth-dev
20180227 20:24:01-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 248 seconds]
20180227 20:28:10< shadowm> How does one bring up the Lua console?
20180227 20:28:21< shadowm> Oh wait duh I just remembered it's through :inspect.
20180227 20:43:44-!- gfgtdf [~chatzilla@x4e32b59e.dyn.telefonica.de] has joined #wesnoth-dev
20180227 20:44:13< gfgtdf> shadowm: you can assign a hotkey to it it it doesnt have hotkey assigned yet.
20180227 20:44:24< shadowm> What is it called?
20180227 20:44:37< gfgtdf> shadowm: lua console i think
20180227 20:44:49< shadowm> Because I assigned F8 to "Lua" and nothing happens.
20180227 20:45:20< gfgtdf> shadowm: 'Show Lua Console'
20180227 20:45:23< shadowm> I guess the correct command is "Show Lua Console", which appears to have grave (`) assigned already. But then what does "Lua" do?
20180227 20:45:25< gfgtdf> https://github.com/wesnoth/wesnoth/blob/master/src/hotkey/hotkey_command.cpp#L280
20180227 20:45:46< gfgtdf> not sure
20180227 20:45:59< gfgtdf> i cannot find it (lua) on that list.
20180227 20:46:19< gfgtdf> or maybe it is a custom wml hotkey?
20180227 20:46:20< shadowm> It is in the full list.
20180227 20:46:47< gfgtdf> if you have a a addon installed that creates wml menu item named lua that might be it, 
20180227 20:47:04< shadowm> Yeah that's it. No add-ons, though, just the test scenario.
20180227 20:47:41< shadowm> There is a menu item that's called something with "Lua" in it but for some reason it shows up on the hotkeys list as just "Lua", assuming it's even the same thing.
20180227 20:47:51< JyrkiVesterinen> The test scenario injects such a command, IIRC.
20180227 20:53:57-!- Nobun [~user@5.170.243.237] has joined #wesnoth-dev
20180227 21:07:29-!- travis-ci [~travis-ci@ec2-174-129-123-178.compute-1.amazonaws.com] has joined #wesnoth-dev
20180227 21:07:29< travis-ci> shikadiqueen/wesnoth#27 (bugfix/2434 - 1f904bc : Iris Morelle): The build has errored.
20180227 21:07:30< travis-ci> Build details : https://travis-ci.org/shikadiqueen/wesnoth/builds/346971005
20180227 21:07:30-!- travis-ci [~travis-ci@ec2-174-129-123-178.compute-1.amazonaws.com] has left #wesnoth-dev []
20180227 21:39:56-!- travis-ci [~travis-ci@ec2-54-145-192-226.compute-1.amazonaws.com] has joined #wesnoth-dev
20180227 21:39:57< travis-ci> shikadiqueen/wesnoth#28 (bugfix/2434 - 5b5523d : Iris Morelle): The build failed.
20180227 21:39:58< travis-ci> Build details : https://travis-ci.org/shikadiqueen/wesnoth/builds/346972254
20180227 21:39:58-!- travis-ci [~travis-ci@ec2-54-145-192-226.compute-1.amazonaws.com] has left #wesnoth-dev []
20180227 21:43:15-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has quit [Quit: .]
20180227 21:48:37< irker425> wesnoth: Iris Morelle wesmere:develop 3afd4ba94c47 / wesmere/sass/home/_download.scss: sass/home: Fix colour op deprecation warnings https://github.com/wesnoth/wesmere/commit/3afd4ba94c472df760a27699fe9d5c395ed0c992
20180227 21:48:39< irker425> wesnoth: Iris Morelle wesmere:develop fb951010fc43 / static/docroot/index.php wesmere/mw/skin.json wesmere/sass/_version.scss: Bump version https://github.com/wesnoth/wesmere/commit/fb951010fc439e0a7bc1ca16bf6fb0e97ab57855
20180227 21:49:54< shadowm> This isn't even English: https://travis-ci.org/shikadiqueen/wesnoth/jobs/346972258#L2409
20180227 21:50:02< shadowm> What about the command? WHAT IS IT, TRAVIS??
20180227 21:55:14< gfgtdf> i think the coloring is just wrong, te sentence ends a few lines below
20180227 21:55:38< gfgtdf> shadowm: 'exited with 1.'
20180227 21:56:16< shadowm> That's a huge command.
20180227 21:56:55< shadowm> No idea how you're supposed to be able to tell what went wrong when it's all one single multi-statement command.
20180227 22:06:21< gfgtdf> shadowm: don't ask me, but afaik our travis build currently has a >50 chance to randomly fail unrelated to the commit, so my first attempot would be to just restart it (unless your ambition is to improve our travis build).
20180227 22:07:06< gfgtdf> shadowm: a textsdearch in the travis uotput for things like 'fail' 'error' or similar is another option
20180227 22:07:34< Nobun> I cannot be helpful either, I don't know how build system work on mac. However the problem seems to me to be located at  the "docker run" command
20180227 22:08:35< shadowm> I'm just an occasional contributor here these days so nope, not going to look into it.
20180227 22:10:13< Nobun> the lastest lines (where 'docker run'... is located) returns error1 too, this why the problem could be located there. But I don't know what docker run is, so I cannot say nothing more
20180227 22:11:09< gfgtdf> that is actually part of the huge commang mentione dabive
20180227 22:12:26< gfgtdf> above*
20180227 22:12:33< Nobun> however usually if 'error 1' happens and you cannot see a useful error message probably can be a dependency problem (for example you are using a library command that require sub-dependency non resolved?)
20180227 22:13:07< Nobun> usually this happens related on linking errors
20180227 22:13:33< shadowm> Everyone and their dog returns 1 if something happens.
20180227 22:13:40< gfgtdf> Nobun: soem or our builds begin with W: Failed to fetch http://ppa.launchpad.net/chris-lea/redis-server/ubuntu/dists/trusty/main/i18n/Translation-en  Unable to connect to ppa.launchpad.net:http:
20180227 22:13:41< gfgtdf> W: Some index files failed to download. They have been ignored, or old ones used instead. and" fail then, so it coudlbe related
20180227 22:14:14< shadowm> My complain is mostly directed at the fact that it is a long multi-statement command line so you can't easily tell which one of all the statements in it is the one that failed.
20180227 22:14:45< shadowm> It's not my issue but I could see it becoming a source of many a headache for whoever maintains the CI deployment recipe.
20180227 22:20:04-!- travis-ci [~travis-ci@ec2-54-145-192-226.compute-1.amazonaws.com] has joined #wesnoth-dev
20180227 22:20:05< travis-ci> shikadiqueen/wesnoth#28 (bugfix/2434 - 5b5523d : Iris Morelle): The build passed.
20180227 22:20:05< travis-ci> Build details : https://travis-ci.org/shikadiqueen/wesnoth/builds/346972254
20180227 22:20:05-!- travis-ci [~travis-ci@ec2-54-145-192-226.compute-1.amazonaws.com] has left #wesnoth-dev []
20180227 22:20:13< shadowm> \o/
20180227 22:36:27-!- Nobun [~user@5.170.243.237] has quit [Quit: good night everyone]
20180227 22:48:21-!- Oebele [~quassel@143.177.58.202] has quit [Remote host closed the connection]
20180227 22:54:00-!- TadCarlucci [~lundberg@74.193.219.119] has quit [Remote host closed the connection]
20180227 22:57:26-!- TadCarlucci [~lundberg@74.193.219.119] has joined #wesnoth-dev
20180227 23:04:10-!- Bonobo [~Bonobo@61.68.207.231] has joined #wesnoth-dev
20180227 23:05:20-!- TadCarlucci [~lundberg@74.193.219.119] has quit [Remote host closed the connection]
20180227 23:05:50-!- TadCarlucci [~lundberg@74.193.219.119] has joined #wesnoth-dev
20180227 23:49:00-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20180227 23:57:06-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
--- Log closed Wed Feb 28 00:00:42 2018