--- Log opened Sat Mar 03 00:00:33 2018
20180303 00:23:03-!- irker355 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20180303 00:46:02-!- esr [~esr@wesnoth/developer/esr] has quit [Read error: Connection reset by peer]
20180303 00:47:43-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20180303 00:47:43-!- irker520 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20180303 00:47:43< irker520> wesnoth: Charles Dang website:develop 6bd110180fb3 / eclipse.wesnoth.org/index.html: eclipse.w.o: small text tweak https://github.com/wesnoth/website/commit/6bd110180fb33faf19beb43112a6fc08db5259c8
20180303 00:51:31-!- esr [~esr@static-71-162-243-5.phlapa.fios.verizon.net] has joined #wesnoth-dev
20180303 00:51:31-!- esr [~esr@static-71-162-243-5.phlapa.fios.verizon.net] has quit [Changing host]
20180303 00:51:31-!- esr [~esr@wesnoth/developer/esr] has joined #wesnoth-dev
20180303 00:53:11< irker520> wesnoth: Charles Dang website:develop 301a51c4ca53 / eclipse.wesnoth.org/index.html: eclipse.w.o: further text tweaks https://github.com/wesnoth/website/commit/301a51c4ca53c34919607dc72e21760e72eee064
20180303 01:07:09< irker520> wesnoth/wesnoth:master Gregory A Lundberg bdb729d2ec Fix missing static keyword, remove dead  AppVeyor: All builds passed
20180303 01:26:05-!- Yaiyan [~yaiyan@46.101.48.31] has quit [Ping timeout: 240 seconds]
20180303 01:32:40-!- yaiyan [~yaiyan@46.101.48.31] has joined #wesnoth-dev
20180303 01:36:38-!- aeth_ [~Michael@wesnoth/umc-dev/developer/aethaeryn] has joined #wesnoth-dev
20180303 01:37:33-!- aeth [~Michael@wesnoth/umc-dev/developer/aethaeryn] has quit [Ping timeout: 240 seconds]
20180303 02:11:28< irker520> wesnoth/wesnoth:master pentarctagon 68f8055807 Add building the servers with mysql supp AppVeyor: All builds passed
20180303 02:28:28-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20180303 03:49:47-!- vn971 [~vasya@94.158.103.15] has quit [Ping timeout: 276 seconds]
20180303 04:05:34< celticminstrel> Random thought... is it possible to list a mainline campaign as a dependency for an addon?
20180303 04:06:02< celticminstrel> Since some distributions don't automatically include the campaigns, that ability could be useful.
20180303 04:06:35< celticminstrel> It'd save addons from having to duplicate campaign units and stuff.
20180303 04:07:00< celticminstrel> (Though I still think that the most reusable campaign units, including the entire Quenoth, should just be moved into core.)
20180303 04:25:07-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180303 04:25:16-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20180303 04:52:32-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180303 04:52:38-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20180303 05:19:54< shadowm> No, the dependency system only checks add-ons server entries.
20180303 05:22:31< celticminstrel> I see.
20180303 05:23:15< celticminstrel> Speaking of the Quenoth, I still want to see the moon shydes used. >_> Even if it's only for some particular character or something.
20180303 05:23:27-!- Bonobo [~Bonobo@61.68.207.231] has quit [Ping timeout: 268 seconds]
20180303 05:23:41-!- Bonobo [~Bonobo@61.68.207.231] has joined #wesnoth-dev
20180303 05:34:11-!- vn971 [~vasya@94.158.103.15] has joined #wesnoth-dev
20180303 06:25:53-!- celticminstrel is now known as celmin|sleep
20180303 06:33:59-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has joined #wesnoth-dev
20180303 08:22:47-!- Oebele [~quassel@143.177.58.202] has joined #wesnoth-dev
20180303 08:36:12-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20180303 08:51:37-!- Oebele [~quassel@143.177.58.202] has quit [Remote host closed the connection]
20180303 08:55:12< irker520> wesnoth: Charles Dang wesnoth:master fc6018bb064f / src/gui/dialogs/multiplayer/faction_select.cpp: Faction Select: handle legacy DescriptionWML in [multiplayer_side] name= https://github.com/wesnoth/wesnoth/commit/fc6018bb064f374fd5c23ad296d99289d85858b0
20180303 08:55:15< irker520> wesnoth: Charles Dang wesnoth:master a986ca1fc2b9 / src/gui/dialogs/campaign_difficulty.cpp: Campaign Difficulty: some code cleanup https://github.com/wesnoth/wesnoth/commit/a986ca1fc2b9a7f5cf89d75c3140ccd655a42e10
20180303 08:55:18< irker520> wesnoth: Charles Dang wesnoth:master 7bb4977ceeba / src/gui/ (6 files in 3 dirs): GUI2/Listbox: added select_last_row wrapper https://github.com/wesnoth/wesnoth/commit/7bb4977ceeba2fe5e0c0615422ec84be536ece35
20180303 09:36:13-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has quit [Quit: .]
20180303 09:44:33-!- Oebele [~quassel@143.177.58.202] has joined #wesnoth-dev
20180303 09:57:16-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180303 09:57:22-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20180303 09:57:41< irker520> wesnoth: Charles Dang wesnoth:master a3a9697d1482 / src/ (14 files in 7 dirs): Cleaned up unnecessary inclusion of formula/string_utils.hpp https://github.com/wesnoth/wesnoth/commit/a3a9697d14820d15353f5558d4cb3b8dc9f84ac6
20180303 09:57:44< irker520> wesnoth: Charles Dang wesnoth:master b2ad732f7538 / src/map/ (location.cpp location.hpp): Map/Location: removed explicit inlining of various functions https://github.com/wesnoth/wesnoth/commit/b2ad732f75382afd516c91a7bf9fd97c9b85ed3e
20180303 10:13:43< Ivanovic> wedge009: I am seeing some conversions in pofix.py applied that were never added to the strings in the cfg files
20180303 10:13:48< Ivanovic> resulting in fuzzy strings that should not be
20180303 10:13:59< Ivanovic> e.g. this one from two brothers:
20180303 10:14:00< Ivanovic> ("try to force him off of his keep", "try to force him off his keep"),
20180303 10:14:26< Ivanovic> the same for this one on -units:
20180303 10:14:28< Ivanovic> ("Their remedies cannot only heal wounds", "Their remedies can not only heal wounds"),
20180303 10:14:38< Ivanovic> you are aware that you have to do the following things:
20180303 10:14:50< Ivanovic> 1) add change to correct config file in the data dir
20180303 10:14:55< Ivanovic> 2) add small diff to pofix
20180303 10:15:32< Ivanovic> 3) apply pofix on all *pot files and crosscheck that no "false positives" were changed, if "false positives" occured either replace the search term or completely remove it
20180303 10:15:56< Ivanovic> 4) once no more false positives occur, apply pofix.py on all po files in all textdomains
20180303 10:22:42< irker520> wesnoth: Nils Kneuper wesnoth:master 88e2da74afe5 / utils/pofix.py: Revert "Minor corrections to Dunefolk and Two Brothers text." https://github.com/wesnoth/wesnoth/commit/88e2da74afe5fe4fc72479662088c0e31f158066
20180303 10:22:44< irker520> wesnoth: Nils Kneuper wesnoth:master 27f54fcdc40b / / (31 files in 30 dirs): updated Spanish translation https://github.com/wesnoth/wesnoth/commit/27f54fcdc40bfadb6ea123968bcb6cb6b7ee8c44
20180303 10:22:46< irker520> wesnoth: Nils Kneuper wesnoth:master 8b80fa6635a1 / utils/pofix.py: add a word of caution that pofix.py does not alter source strings https://github.com/wesnoth/wesnoth/commit/8b80fa6635a1abe02e8bc578d18853a23e6f6ef8
20180303 10:27:41< irker520> wesnoth: Charles Dang wesnoth:master 044dedb43a8c / data/core/help.cfg src/help/help_impl.cpp src/help/help_impl.hpp: Removed Credits section from help browser (fixes #2555) https://github.com/wesnoth/wesnoth/commit/044dedb43a8c3d86a805d73af98d43e44aff867d
20180303 10:34:39-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has joined #wesnoth-dev
20180303 10:39:56< irker520> wesnoth: Charles Dang wesnoth:master 7ba6c060d521 / changelog src/playmp_controller.cpp: Disable 'Turn Changed' desktop notifications for AI sides (fixes #2567) https://github.com/wesnoth/wesnoth/commit/7ba6c060d521df904e0354c49b803207e826b468
20180303 10:40:34-!- travis-ci [~travis-ci@ec2-54-161-202-86.compute-1.amazonaws.com] has joined #wesnoth-dev
20180303 10:40:35< travis-ci> wesnoth/wesnoth#16686 (master - 044dedb : Charles Dang): The build was canceled.
20180303 10:40:35< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/348599313
20180303 10:40:35-!- travis-ci [~travis-ci@ec2-54-161-202-86.compute-1.amazonaws.com] has left #wesnoth-dev []
20180303 10:55:21< irker520> wesnoth: Jyrki Vesterinen wesnoth:master e56812e3bd62 / src/ (playmp_controller.cpp playmp_controller.hpp): Remove playmp_controller::play_side_impl() https://github.com/wesnoth/wesnoth/commit/e56812e3bd62090553151ebebe7f268327495c25
20180303 11:06:33-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has quit [Quit: .]
20180303 11:15:38-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20180303 11:20:57-!- nurupo [~nurupo.ga@unaffiliated/nurupo] has quit [Quit: nurupo]
20180303 11:23:39-!- nurupo [~nurupo.ga@unaffiliated/nurupo] has joined #wesnoth-dev
20180303 11:29:16-!- travis-ci [~travis-ci@ec2-54-161-202-86.compute-1.amazonaws.com] has joined #wesnoth-dev
20180303 11:29:17< travis-ci> wesnoth/wesnoth#16688 (master - e56812e : Jyrki Vesterinen): The build passed.
20180303 11:29:17< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/348604780
20180303 11:29:17-!- travis-ci [~travis-ci@ec2-54-161-202-86.compute-1.amazonaws.com] has left #wesnoth-dev []
20180303 11:34:34-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180303 11:34:40-!- janebot_ [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20180303 11:34:42-!- janebot_ is now known as janebot
20180303 11:51:39-!- Oebele [~quassel@143.177.58.202] has quit [Remote host closed the connection]
20180303 12:19:00< wedge009> Ivanovic: I take it I've done something wrong. I don't think I ever really had pofix explained to me properly. I was told to make corrections there rather than in the source cfg file to avoid unnecessarily triggering notifications for translators. Are you saying I'm supposed to add the change to *both* pofix and the source cfg file?
20180303 12:19:20< Ivanovic> correct
20180303 12:19:48< wedge009> Great. All right, I'll keep that in mind for next time. Do you need me to add my previous changes to the cfg files?
20180303 12:22:28< Ivanovic> I reverted the po fix change for the moment and added a comment at the top of pofix
20180303 12:22:56< Ivanovic> so if you want the correct in, you should fix it in the cfg and add the change to the pofix plus follow the steps listed at the top of pofix
20180303 12:22:57< Ivanovic> :)
20180303 12:27:20< wedge009> All right.
20180303 12:55:26-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has joined #wesnoth-dev
20180303 13:04:39-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20180303 13:05:26-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20180303 13:20:33-!- timotei_ [~timotei@wesnoth/developer/timotei] has quit [Ping timeout: 248 seconds]
20180303 13:29:25-!- timotei_ [~timotei@wesnoth/developer/timotei] has joined #wesnoth-dev
20180303 13:41:14< JyrkiVesterinen> Updating the manual.
20180303 13:41:16< JyrkiVesterinen> "You cannot carry over units in multiplayer from one scenario to the next, so building up your army’s strength is possible only within the scenario."
20180303 13:41:22< JyrkiVesterinen> Is that still true?
20180303 13:41:54< JyrkiVesterinen> Looking at the changelog, the earliest mention of MP campaigns is at version 1.3.14.
20180303 13:42:01< irker520> wesnoth: Wedge009 wesnoth:master 1a3a28c59cc7 / / (3 files in 3 dirs): Re-attempting e4730ef1 (Minor corrections to Dunefolk and Two Brothers text) as  https://github.com/wesnoth/wesnoth/commit/1a3a28c59cc7ba709b82df4ab49f26c82b785fa2
20180303 13:43:49< wedge009> I thought the MP version of Legend of Wesmere (the only official MP campaign so far, right?) allows for recall of veteran units.
20180303 13:47:57< JyrkiVesterinen> OK, I'll update the manual.
20180303 13:48:33< JyrkiVesterinen> Looks like the change was missed for the 1.12 manual update. Changelog says that MP version of LoW arrived in v1.11.7.
20180303 14:06:26< Ivanovic> wedge009: please don't forget to run pofix against all translation files (.pot as well as .po)
20180303 14:35:52< celmin|sleep> Speaking of updating the manual, can we like, make sure it's absolutely up-to-date with everything 1.13.x?
20180303 14:36:30-!- celmin|sleep is now known as celticminstrel
20180303 14:36:56< JyrkiVesterinen> That's what I'm doing.
20180303 14:37:17< celticminstrel> Okay, so basically addressing the issue I opened.
20180303 14:37:19< JyrkiVesterinen> Looks like it doesn't go into much detail, which is good. 1.13 hasn't changed the core game that much.
20180303 14:37:28< celticminstrel> IIRC there might be new screenshots needed too?
20180303 14:37:53< JyrkiVesterinen> You marked it as a blocker, and I wanted to deal with this as quickly as possible to save effort from translators.
20180303 14:38:00< JyrkiVesterinen> I already captured new screenshots.
20180303 14:38:18< celticminstrel> Yeah, IMO it's very important.
20180303 14:43:07< zookeeper> note that the map editor section of the help is _very_ incomplete and has TODO notes and whatnot in it.
20180303 14:43:10-!- vultraz [uid24821@wesnoth/developer/vultraz] has joined #wesnoth-dev
20180303 14:43:22< vultraz> celticminstrel: why did you add image handling to [credits_group]?
20180303 14:43:55< JyrkiVesterinen> zookeeper: doesn't matter to me. The manual barely even mentions that the editor exists.
20180303 14:45:07< zookeeper> sure, just saying that it's one section that might benefit from things simply being removed while at it.
20180303 14:46:05< celticminstrel> vultraz: What?
20180303 14:46:55< vultraz> celticminstrel: https://github.com/wesnoth/wesnoth/commit/238d70ee22bcfaaaa22bb31ceebe6d8b478e3a7b You added a `gather_images` call for [credits_group]
20180303 14:47:00< vultraz> implying images= is allowed there
20180303 14:47:03< vultraz> mind if i remove it?
20180303 14:47:08< celticminstrel> Why?
20180303 14:47:19< celticminstrel> What's wrong with it?
20180303 14:47:37< vultraz> nothing
20180303 14:47:47< vultraz> but images= isn't supposed to be there
20180303 14:47:51< vultraz> it's supposed ot be in [about]
20180303 14:47:51< celticminstrel> Why?
20180303 14:48:48< vultraz> I mean, it could be there
20180303 14:48:56< vultraz> I suppose
20180303 14:50:22 * vultraz is refactoring his refactoring of the credits storage from back in 2016
20180303 14:50:22< celticminstrel> Given that presumably no-one has actually used [credits_group] yet, it's probably fine to remove; but isn't it cleaner if you want the same image list for all your [about]s to put it in the [credits_group] instead?
20180303 14:50:32< vultraz> t'was just somethng I noticed
20180303 14:50:41< vultraz> that's true
20180303 14:50:57< celticminstrel> (Looking at that code I'm kinda confused about the fact that all images from everywhere other than the campaigns are just dumped into images_default...)
20180303 14:51:11< vultraz> indeed
20180303 14:51:12< vultraz> that is odd
20180303 14:56:00-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 256 seconds]
20180303 14:57:32< vultraz> heh. my refactoring has apparently increased credits parsing time from 2 ms to 18 ms :P
20180303 14:57:40< vultraz> (parsing on config refresh)
20180303 14:59:56< celticminstrel> Heh.
20180303 15:00:06< celticminstrel> Not really a big change mind you.
20180303 15:00:10-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20180303 15:00:22< celticminstrel> How many addons do you have installed?
20180303 15:01:06< vultraz> most likely due to the use of nested vectors, resulting in an inside-out situation where stuff needs to be moved around a lot 
20180303 15:09:13< irker520> wesnoth: Charles Dang wesnoth:master ec34ed950dda / src/ (about.cpp about.hpp gui/dialogs/end_credits.cpp): Refactored storage of credits data https://github.com/wesnoth/wesnoth/commit/ec34ed950dda8958d15ae5e8800f606f8c0006ce
20180303 15:09:30< vultraz> also means the credits aren't sorted every time you open the end credits dialog
20180303 15:10:12< celticminstrel> I assume you mean re-sorted.
20180303 15:10:33< vultraz> I mean the thing you added to sort by language
20180303 15:10:44< vultraz> er
20180303 15:10:44< JyrkiVesterinen> I mean, sorting them when opening the dialog (instead of when launching Wesnoth) may be better.
20180303 15:10:52< celticminstrel> I mean, I assume they are still sorted.
20180303 15:10:55< vultraz> yes.
20180303 15:10:58< JyrkiVesterinen> You can assume launching Wesnoth to be more common than opening the credits dialog.
20180303 15:11:10< celticminstrel> They'll need to be re-sorted anytime the language changes.
20180303 15:12:04< vultraz> that happens.
20180303 15:17:15< irker520> wesnoth: Charles Dang wesnoth:master 0d0bb91d9913 / data/core/ (about.cfg macros/utils.cfg): Added a CREDITS_SEPARATOR macro https://github.com/wesnoth/wesnoth/commit/0d0bb91d9913cb0ef49d2733ebac10d933668f14
20180303 15:17:49< celticminstrel> That reminds me, credits need updating.
20180303 15:18:05< celticminstrel> Some people are still in Misc who should probably be in the main credits.
20180303 15:20:06< vultraz> anyway, im still technically on break, just figured id do a few things since it's the weekend
20180303 15:20:24< celticminstrel> So you no longer gather images from toplevel about tags, huh...
20180303 15:20:32< celticminstrel> Oh wait.
20180303 15:20:35< vultraz> no, I do
20180303 15:20:35< celticminstrel> I see what you did.
20180303 15:20:56< vultraz> ahhh fuck bad indent htere
20180303 15:21:03< celticminstrel> Where?
20180303 15:21:15< vultraz> operator<
20180303 15:21:25< celticminstrel> Ah.
20180303 15:22:17< irker520> wesnoth: Charles Dang wesnoth:master d3a51fe44b25 / src/about.hpp: Fixup ec34ed9 (bad indent) https://github.com/wesnoth/wesnoth/commit/d3a51fe44b256d1fcb22d7e61e29e2bc93f8c2ea
20180303 15:23:39< vultraz> do we need to keep the handling of toplevel [about] tags i wonder
20180303 15:24:34< celticminstrel> Probably, for compatibility.
20180303 15:24:49< celticminstrel> And it doesn't hurt anything to support it either.
20180303 15:29:13-!- Bonobo [~Bonobo@61.68.207.231] has quit [Ping timeout: 240 seconds]
20180303 15:29:47-!- Bonobo [~Bonobo@61.68.207.231] has joined #wesnoth-dev
20180303 15:46:36< irker520> wesnoth: Jyrki Vesterinen wesnoth:master fe9729e8c6f9 / doc/manual/ (13 files in 2 dirs): Manual update part 1: update manual text and create new screenshots https://github.com/wesnoth/wesnoth/commit/fe9729e8c6f9838c59648d1d02f8a3211014d373
20180303 15:47:27-!- Bonobo [~Bonobo@61.68.207.231] has quit [Ping timeout: 256 seconds]
20180303 15:48:42-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has quit [Quit: Rebooting]
20180303 15:50:38< celticminstrel> This reminds me, does loonycyborg have whatever it is that parses that file?
20180303 15:51:26< celticminstrel> ISTR him saying he doesn't have docbook or something, but not sure if that's related.
20180303 15:54:29-!- JyrkiVesterinen [~jyrki@85-23-197-3.bb.dnainternet.fi] has joined #wesnoth-dev
20180303 15:55:58< JyrkiVesterinen> The tool is called asciidoc. I'll try to install it locally.
20180303 15:59:33< celticminstrel> I also seem to recall some people editing the HTML instead of the source text...
20180303 16:02:33-!- JyrkiVesterinen [~jyrki@85-23-197-3.bb.dnainternet.fi] has quit [Quit: Rebooting]
20180303 16:06:39-!- JyrkiVesterinen [~jyrki@85-23-197-3.bb.dnainternet.fi] has joined #wesnoth-dev
20180303 16:07:47< vultraz> that stylesheettje manualuses
20180303 16:07:51< vultraz> is there a newer version of it?
20180303 16:07:59< celticminstrel> Good question.
20180303 16:08:25< vultraz> I tried looking for one today but couldnt really find anything solid?
20180303 16:08:30< vultraz> I think i found the docbook repo on gh but..
20180303 16:11:48< vultraz> celticminstrel: perhaps you can help me look. The one that's there was checked in in 2007....very ancient.
20180303 16:18:57< JyrkiVesterinen> Whoa. Asciidoc and all its dependencies want 600 MB of disk space.
20180303 16:19:36< celticminstrel> o.o
20180303 16:20:40< vultraz> P_P
20180303 16:26:35< JyrkiVesterinen> warning: failed to load external entity "/usr/share/asciidoc/docbook-xsl/xhtml.xsl"
20180303 16:26:45< JyrkiVesterinen> Building the HTML manual fails because of that...
20180303 16:28:39< celticminstrel> Well then.
20180303 16:30:13 * vultraz idly contemplates moving the entire manual to our repo's GH wiki. Or our own wiki.
20180303 16:30:26< vultraz> I also wonder if any updates to Help have been synced with the manual...
20180303 16:30:58< celticminstrel> A downloadable version of the manual is valuable IMO.
20180303 16:31:13< celticminstrel> Also, we already have a wiki.
20180303 16:31:27< celticminstrel> No need to use GH wiki.
20180303 16:31:40< vultraz> I've never seen us offer a download of the manual. 
20180303 16:31:49< vultraz> I've seen the manual.wesnoth.org link to it
20180303 16:31:58< vultraz> and presumably it's shipped with the game packages 
20180303 16:32:35< vultraz> but why anyone would read it when we have in-game help also puzzles me.
20180303 16:32:42< vultraz> perhaps the manual has more info
20180303 16:33:08< JyrkiVesterinen> No, the manual has quite limited info. It's essentially just a quick overview of the game.
20180303 16:33:45< celticminstrel> It does have some info not in help.
20180303 16:34:21< vultraz> What info?
20180303 16:34:23< JyrkiVesterinen> Any examples? I don't recall anything, and I just read through the whole thing.
20180303 16:34:24< vultraz> Perhaps it should be in help
20180303 16:34:30< celticminstrel> Hotkeys for example.
20180303 16:34:47< JyrkiVesterinen> Oh, the default hotkeys.
20180303 16:34:51< celticminstrel> There's an issue about adding them to help IIRC.
20180303 16:35:07< vultraz> ah, true, the hotkeys
20180303 16:35:11< JyrkiVesterinen> Still, you can see them in preferences. (And that's where I use to go to view key bindings in games.)
20180303 16:35:13< vultraz> except now we have
20180303 16:35:15< celticminstrel> I dunno, that could be the only thing.
20180303 16:35:17< vultraz> yeah what tjyrki said
20180303 16:35:21< vultraz> ...where did that come from
20180303 16:35:23< vultraz> jyrki*
20180303 16:36:04< celticminstrel> I could imagine someone finding the manual more convenient than in-game help.
20180303 16:37:08 * celticminstrel wonders what it would take to support movable windows in GUI2... suspects not that much...
20180303 16:37:51< vultraz> movable windows?
20180303 16:37:54< vultraz> by user input?
20180303 16:38:03< celticminstrel> Like you can drag them around within the window.
20180303 16:38:12< vultraz> that's... very odd game UI design
20180303 16:38:17< celticminstrel> Is not.
20180303 16:38:21< celticminstrel> It's perfectly normal?
20180303 16:38:34< vultraz> I can't think of one game that allows you to reposition windows
20180303 16:38:35< celticminstrel> Pretty sure I've seen it in more than one game.
20180303 16:38:44< celticminstrel> The first one that comes to mind is Ultima Online.
20180303 16:38:57< vultraz> now, if you mean animating windows to move 
20180303 16:39:02< vultraz> then yes we 100% want that
20180303 16:39:03< celticminstrel> I guess Exile III and Blades of Exile also sort of count since they have a movable minimap.
20180303 16:39:23< celticminstrel> Pretty sure I've seen games more like Wesnoth too that have it (ie strategy games).
20180303 16:39:32< celticminstrel> Oh yeah, I think SimAnt had movable windows?
20180303 16:39:57< vultraz>  Don’t think it’s worth it
20180303 16:39:58< celticminstrel> Castle of the Winds IIRC
20180303 16:40:03< vultraz> Better to focus in window animations
20180303 16:40:05< celticminstrel> I think it could be worth it for certain windows.
20180303 16:40:17< celticminstrel> With help actually being the biggest one.
20180303 16:40:23< celticminstrel> But also things like the attack window.
20180303 16:40:40< celticminstrel> It's probably not worth it for most windows.
20180303 16:40:49< celticminstrel> Definitely not for things like confirm().
20180303 16:41:21< celticminstrel> And obviously not for ones that are fullscreen or don't even have a border (eg message) or are clearly modal (objectives / object popup).
20180303 16:42:15< celticminstrel> I'm not even sure what you mean by "animating windows to move".
20180303 16:44:55< irker520> wesnoth: Jyrki Vesterinen wesnoth:master 8f8a7b7585e2 / doc/manual/ (SConscript manual.en.html): Manual update part 2: convert manual to XHTML https://github.com/wesnoth/wesnoth/commit/8f8a7b7585e287ad3cf8322351bca3015b4010a5
20180303 16:57:44-!- DeFender1031 [~DeFender1@dsl217-132-38-129.bb.netvision.net.il] has joined #wesnoth-dev
20180303 17:01:46< vultraz> celticminstrel: ell for example windows that slide off to the side and fade out
20180303 17:01:53< vultraz> Or windows that fade out in place
20180303 17:02:01< vultraz> Just animated elements inbenera,
20180303 17:02:10< vultraz> I geek risk
20180303 17:02:22< vultraz> Ralingeneral
20180303 17:02:25< vultraz> In general
20180303 17:02:29< celticminstrel> Ah, so like the genie effect when I minimize a window.
20180303 17:02:41< celticminstrel> TBH I don't think we need that.
20180303 17:02:46< vultraz> Well not exactly
20180303 17:03:16< vultraz> Unless the genie effect changed since I last saw it
20180303 17:03:17< celticminstrel> Well you can't minimize windows in Wesnoth so obviously it's not exact.
20180303 17:03:33< vultraz> But more like what dota 2 has
20180303 17:03:48< vultraz> Essentially we need more elements that move around and make the UI feel fluid
20180303 17:03:48< celticminstrel> (I actually disabled the genie effect; I get the more straight-forward zoom effect instead when I minimize a window.)
20180303 17:03:52< vultraz> Right now it doesn’t feel fluid
20180303 17:04:01< celticminstrel> I think that might actually make the UI feel slower.
20180303 17:04:18< celticminstrel> I don't think it should be done in general. Perhaps for messages, I guess.
20180303 17:04:23< vultraz> For example we could have the Lobby slide out of the way to the left and mp create slide in from the right
20180303 17:04:33< celticminstrel> Ehhh...
20180303 17:04:39< celticminstrel> This isn't a slide-show!
20180303 17:05:03< celticminstrel> That sort of effect is nice but I don't really think it applies here.
20180303 17:05:21< vultraz> Well Dota does stuff like that and it looks very nice
20180303 17:08:06< celticminstrel> On an unrelated note, can you view unit descriptions in current Wesnoth? I mean a description defined in [unit].
20180303 17:08:39< Ravana_> only if they are short enough
20180303 17:08:42< irker520> wesnoth/wesnoth:master Jyrki Vesterinen e56812e3bd Remove playmp_controller::play_side_impl AppVeyor: All builds passed
20180303 17:10:49< celticminstrel> Ravana_: What do you mean?
20180303 17:11:10< Ravana_> it is visible when hovering on unit type
20180303 17:11:19< vultraz> Why would you put a description in a unit
20180303 17:11:35< Ravana_> because you can't define unit types during game
20180303 17:12:18< celticminstrel> "when hovering on unit type" --> you mean when the mouse is over the name of the unit type?
20180303 17:12:25< Ravana_> yes
20180303 17:12:40< vultraz> No I mean why would a specific unit need a description
20180303 17:12:43< celticminstrel> Hmm, okay.
20180303 17:13:00< celticminstrel> vultraz: Why wouldn't a specific unit need a description
20180303 17:13:49< vultraz> Because if it’s a campaign soecidic u it it’s given its own h it type
20180303 17:14:18< celticminstrel> There's no need to always give campaign units a custom type.
20180303 17:14:24< vultraz> And if it’s a generic unit used for a special camaptsher then it doesn’t need a description especially since you can’t view it anywhere
20180303 17:14:35< celticminstrel> A special what?
20180303 17:15:05< Ravana_> its use case is as virtual unit type
20180303 17:15:33< vultraz> Character
20180303 17:15:36< celticminstrel> vultraz: What if you want a unique unit type in an MP scenario.
20180303 17:15:51< Ravana_> unit types aren't synced, so with 1.12 there is no better way
20180303 17:16:10< vultraz> This literally makes no sense
20180303 17:16:17< vultraz> We’re talking about one unit
20180303 17:16:23< vultraz> You can’t make a type out of a unit
20180303 17:16:29< vultraz> Because it’s just one unit
20180303 17:16:47< vultraz> Unless you’re saying you then clone that unit and modify the clones
20180303 17:16:56< celticminstrel> Tell that to all the campaigns that use a unique unit type for the hero.
20180303 17:16:59< Ravana_> sure you can, internal type being fog clearer, but every relevant attribute changed
20180303 17:17:31< celticminstrel> You can easily take an existing type and apply an [object] to modify it and add a custom description.
20180303 17:17:55< celticminstrel> And if you want multiple of the same type, you can just add the object to all of them.
20180303 17:18:55< vultraz> ....huh
20180303 17:19:01< vultraz> That is... odd
20180303 17:19:20< vultraz> I guess that works
20180303 17:19:26< vultraz> Since types are just prototypes
20180303 17:19:29< vultraz> Interesting
20180303 17:19:33< vultraz> Very interesting
20180303 17:19:37< vultraz> Also visit eryhadky
20180303 17:19:49< vultraz> Very hacks and I hope you don’t have ro do it in a.q3
20180303 17:20:06< celticminstrel> Don't have to do it in where?
20180303 17:20:37< celticminstrel> It honestly doesn't seem all that hacky to me though. Maybe a little.
20180303 17:25:11< vultraz> 1.13
20180303 17:25:37< vultraz> Which reminds me why do we need the fog clearer again
20180303 17:25:43< celticminstrel> To clear fog.
20180303 17:25:53< celticminstrel> Pretty sure you do need to do it in 1.13?
20180303 17:25:54< vultraz> But we have a tag for that
20180303 17:26:04< vultraz> [lift_fog]
20180303 17:26:06< celticminstrel> The fog clearer may no longer be necessary, I guess.
20180303 17:26:16< vultraz> Deprecation!!!!!!!!!!!!!
20180303 17:26:22< celticminstrel> Unless it's used internally by [lift_fog].
20180303 17:26:38< celticminstrel> Which I doubt, but who knows.
20180303 17:28:31< Ravana_> I recall fog clearer last had functional need in 1.10
20180303 17:30:12< vultraz> If it was used internally by lift fog I would flip
20180303 17:30:45< celticminstrel> XD
20180303 17:30:47-!- gfgtdf [~chatzilla@x4e368416.dyn.telefonica.de] has joined #wesnoth-dev
20180303 17:31:07< DeFender1031> Just make sure to use the appropriate deprecation mode
20180303 17:31:19< irker520> wesnoth: Jyrki Vesterinen wesnoth:master b24b127ad3f9 / data/core/images/help/ (hpxp.png moving1.png moving2.png recruit.png tooltip.png): Update some screenshots in help https://github.com/wesnoth/wesnoth/commit/b24b127ad3f90ed657600ea4cc0e33c5cc814972
20180303 17:31:31< DeFender1031> (AKA, probably level 1)
20180303 17:31:50< celticminstrel> Yeah, fog clearer should probably be level 1 deprecation only.
20180303 17:33:26< vultraz> But then it will sit around forge ev
20180303 17:33:50< JyrkiVesterinen> And? Having it sit around causes no harm.
20180303 17:33:51-!- Oebele [~quassel@143.177.58.202] has joined #wesnoth-dev
20180303 17:34:33< zookeeper> i _think_ it's pretty often used in UMC as a generic dummy unit when there's need for a physical (even if temporary) unit for some reason.
20180303 17:35:13< vultraz> The need for scuba t hung is even less now that we have defuses dondition
20180303 17:35:21< zookeeper> ...what
20180303 17:35:27< vultraz> GID DAMMIT THIS IPAD
20180303 17:35:45-!- JyrkiVesterinen [~jyrki@85-23-197-3.bb.dnainternet.fi] has quit [Quit: rebooting]
20180303 17:36:09< zookeeper> what sort of autocorrect doesn't let you see what it does before you press the proverbial enter?
20180303 17:36:18< vultraz> the need for such a thing is even less now that we Hagen defeat_conditioj
20180303 17:36:25< zookeeper> :D
20180303 17:37:13< zookeeper> oh wait i guess it's not autocorrect but just typoing.
20180303 17:37:21< zookeeper> or a bit of both?
20180303 17:38:06-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has joined #wesnoth-dev
20180303 17:38:48< gfgtdf> i actualyl see no usecases for such a generic unit in 1.13. In 1.12 some mp umc used it to prevent requireing download, but this does nto apply to 1.13 which can automaticially downlaod the needed addons.
20180303 17:40:18< Ravana_> yes, thats why deprecated 1
20180303 17:40:42< zookeeper> how do you even deprecate a unit type?
20180303 17:40:47< zookeeper> like, technically.
20180303 17:41:10< Ravana_> dunefolk thread had some proposals
20180303 17:41:33< zookeeper> oh right, yeah. you could use a unit placed event, that's one.
20180303 17:42:01< zookeeper> anyway, can we now print deprecation messages that don't show up except in debug mode or in other optional circumstances?
20180303 17:42:36< zookeeper> because deprecating stuff like that is of course a whole lot less invasive than deprecating so that the messages are always in everyone's face.
20180303 17:44:59< celticminstrel> We could promote the dunefolk deprecation macro to core/macros/deprecation-utils.cfg.
20180303 17:45:52< celticminstrel> zookeeper: Currently deprecation messages printed with deprecation_message() never show up IIRC. My PR fixes that so they show up in the log, and I want to add some way of enabling dumping them to chat.
20180303 17:46:04< gfgtdf> celticminstrel: are you going to finish #2562 and #2526 soon? Also i asusme you are  no longer planning to work on #993 before 1.15 ?
20180303 17:47:25< JyrkiVesterinen> For the record, I don't want #2562 to 1.14.0.
20180303 17:47:44< JyrkiVesterinen> Since I'm in charge until RC1, it's not going in, unless vultraz wants it.
20180303 17:48:00< celticminstrel> Eh, fine.
20180303 17:48:10< celticminstrel> But we should at least fix the errors it uncovers.
20180303 17:48:17< gfgtdf> ye
20180303 17:48:54< celticminstrel> I'll try to work on 2526 this weekend. Shouldn't have any issues, unless I get distracted by something. >_>
20180303 17:49:15< celticminstrel> 993 I'm probably not gonna get back to for awhile.
20180303 17:49:41< vultraz> JyrkiVesterinen: it's not a necessity
20180303 17:49:59< celticminstrel> 2533 is the other one I should work on this weekend. Not sure if I can get to both.
20180303 18:50:11-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180303 18:50:22-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20180303 19:16:58-!- gfgtdf [~chatzilla@x4e368416.dyn.telefonica.de] has quit [Read error: Connection reset by peer]
20180303 20:10:15-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180303 20:10:22-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20180303 20:11:07-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20180303 20:12:51-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20180303 20:25:03-!- trewe [~trewe@78.130.12.20.rev.optimus.pt] has joined #wesnoth-dev
20180303 21:02:34-!- vultraz [uid24821@wesnoth/developer/vultraz] has quit [Quit: Connection closed for inactivity]
20180303 21:06:32< irker520> wesnoth/wesnoth:master Jyrki Vesterinen b24b127ad3 Update some screenshots in help AppVeyor: All builds passed
20180303 21:12:29-!- gfgtdf [~chatzilla@x4e368416.dyn.telefonica.de] has joined #wesnoth-dev
20180303 21:12:35-!- gfgtdf [~chatzilla@x4e368416.dyn.telefonica.de] has quit [Client Quit]
20180303 21:37:02-!- trewe [~trewe@78.130.12.20.rev.optimus.pt] has quit [Quit: quit]
20180303 21:43:55< irker520> wesnoth: Gregory A Lundberg wesnoth:master 8c6895d17fb2 / src/ (about.cpp about.hpp): Mark operator<() const https://github.com/wesnoth/wesnoth/commit/8c6895d17fb2ff8e647012cbf5c79bc22c2cb353
20180303 22:07:00-!- travis-ci [~travis-ci@ec2-54-80-248-14.compute-1.amazonaws.com] has joined #wesnoth-dev
20180303 22:07:01< travis-ci> wesnoth/wesnoth#16694 (master - 8c6895d : Gregory A Lundberg): The build was fixed.
20180303 22:07:01< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/348754638
20180303 22:07:01-!- travis-ci [~travis-ci@ec2-54-80-248-14.compute-1.amazonaws.com] has left #wesnoth-dev []
20180303 22:16:47-!- travis-ci [~travis-ci@ec2-54-80-248-14.compute-1.amazonaws.com] has joined #wesnoth-dev
20180303 22:16:48< travis-ci> Pentarctagon/wesnoth#257 (cmake-osx-returncode - 11f8241 : pentarctagon): The build has errored.
20180303 22:16:48< travis-ci> Build details : https://travis-ci.org/Pentarctagon/wesnoth/builds/348752057
20180303 22:16:48-!- travis-ci [~travis-ci@ec2-54-80-248-14.compute-1.amazonaws.com] has left #wesnoth-dev []
20180303 22:18:29-!- aeth_ is now known as aeth
20180303 22:35:30-!- travis-ci [~travis-ci@ec2-54-221-102-157.compute-1.amazonaws.com] has joined #wesnoth-dev
20180303 22:35:31< travis-ci> Pentarctagon/wesnoth#258 (cmake-osx-returncode - a924968 : pentarctagon): The build has errored.
20180303 22:35:31< travis-ci> Build details : https://travis-ci.org/Pentarctagon/wesnoth/builds/348757516
20180303 22:35:31-!- travis-ci [~travis-ci@ec2-54-221-102-157.compute-1.amazonaws.com] has left #wesnoth-dev []
20180303 22:44:11-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has quit [Quit: .]
20180303 22:46:09< irker520> wesnoth: pentarctagon wesnoth:master 2a783b0df2f9 / utils/travis/ (docker_run.sh steps/script.sh): Fix for failed ccache builds being considered successful. https://github.com/wesnoth/wesnoth/commit/2a783b0df2f9d8a75922fbde50419a809e372325
20180303 23:04:18-!- octalot [~steve@178.115.129.13.wireless.dyn.drei.com] has joined #wesnoth-dev
20180303 23:15:13-!- Oebele [~quassel@143.177.58.202] has quit [Remote host closed the connection]
20180303 23:27:23< irker520> wesnoth/wesnoth:master pentarctagon 2a783b0df2 Fix for failed ccache builds being consi AppVeyor: vs2015/Release Failed
20180303 23:27:24< irker520> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-1672
--- Log closed Sun Mar 04 00:00:34 2018