--- Log opened Sun Mar 04 00:00:34 2018
20180304 00:36:52< irker520> wesnoth: Sofartin wesnoth:master 30f78cc2db0e / projectfiles/Xcode/Fix_Xcode_Dependencies: Update Fix_Xcode_Dependencies https://github.com/wesnoth/wesnoth/commit/30f78cc2db0ece06e90a9a0e9c680dd28f47ee36
20180304 00:37:14< celticminstrel> Oh someone else beat me to it.
20180304 00:40:33-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 248 seconds]
20180304 00:55:22-!- Bonobo [~Bonobo@61.68.207.231] has joined #wesnoth-dev
20180304 01:45:03-!- vultraz [uid24821@wesnoth/developer/vultraz] has joined #wesnoth-dev
20180304 02:47:34< irker520> wesnoth/wesnoth:master Sofartin 30f78cc2db Update Fix_Xcode_Dependencies AppVeyor: vs2013/Debug Failed
20180304 02:47:35< irker520> Details: https://ci.appveyor.com/project/wesnoth/wesnoth/build/Wesnoth-VS2013-master-1685
20180304 03:23:54< shadowm> celticminstrel: Opinions on this approach? <https://github.com/shikadiqueen/wesnoth/commit/435a4ab97f911f1d4b94e7923fd496038dc15c0f>
20180304 03:24:06< shadowm> (Probably vultraz as well, idk if he wants to look at it.)
20180304 03:25:16< vultraz> Acceptable
20180304 03:25:24< shadowm> (I forgot to add the new field to the class constructors. I'll do that later.)
20180304 03:25:52< shadowm> (And assignment op.)
20180304 03:48:38< irker520> wesnoth/wesnoth:master Sofartin 30f78cc2db Update Fix_Xcode_Dependencies AppVeyor: 1/6 builds failed
20180304 03:48:39< irker520> Details vs2013/Debug: https://ci.appveyor.com/project/wesnoth/wesnoth/build/Wesnoth-VS2013-master-1685
20180304 04:03:53-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20180304 04:23:13-!- travis-ci [~travis-ci@ec2-54-156-157-235.compute-1.amazonaws.com] has joined #wesnoth-dev
20180304 04:23:13< travis-ci> shikadiqueen/wesnoth#29 (feature/campaignd-addon-tags - 435a4ab : Iris Morelle): The build failed.
20180304 04:23:14< travis-ci> Build details : https://travis-ci.org/shikadiqueen/wesnoth/builds/348818319
20180304 04:23:14-!- travis-ci [~travis-ci@ec2-54-156-157-235.compute-1.amazonaws.com] has left #wesnoth-dev []
20180304 04:27:23< irker520> wesnoth/wesnoth:master pentarctagon 2a783b0df2 Fix for failed ccache builds being consi AppVeyor: 1/2 builds failed
20180304 04:27:24< irker520> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-1672
20180304 04:33:49-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180304 04:33:55-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20180304 05:09:20-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180304 05:09:29-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20180304 05:24:54< celticminstrel> shadowm: Looks good to me.
20180304 05:41:49-!- midzer_ [~quassel@p5B312805.dip0.t-ipconnect.de] has joined #wesnoth-dev
20180304 05:42:57-!- midzer [~quassel@p4FFAF724.dip0.t-ipconnect.de] has quit [Ping timeout: 248 seconds]
20180304 05:58:55< shadowm> I think there was a proper FR from years ago for this.
20180304 06:06:10-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has joined #wesnoth-dev
20180304 06:15:36-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180304 06:15:42-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20180304 06:31:51< irker520> wesnoth: Charles Dang wesnoth:master 77e6a4279a46 / src/variable.cpp: Don't reference config_attribute_value class directly https://github.com/wesnoth/wesnoth/commit/77e6a4279a46e8c7087f43dc042181e8edd65cb0
20180304 06:31:54< irker520> wesnoth: Charles Dang wesnoth:master a0199c73f91e / src/units/frame.cpp: units/frame_builder: simplify color_t assignment https://github.com/wesnoth/wesnoth/commit/a0199c73f91eac64f97aa37982678a9649900c86
20180304 06:38:14-!- celticminstrel is now known as celmin|sleep
20180304 07:19:05< irker520> wesnoth/wesnoth:master Steve Cotton 488e5fcb33 LoW S14 Objectives and edit repetitive d AppVeyor: All builds passed
20180304 07:51:05-!- travis-ci [~travis-ci@ec2-54-80-248-14.compute-1.amazonaws.com] has joined #wesnoth-dev
20180304 07:51:06< travis-ci> shikadiqueen/wesnoth#30 (feature/campaignd-addon-tags - 7f0cfa5 : Iris Morelle): The build was fixed.
20180304 07:51:06< travis-ci> Build details : https://travis-ci.org/shikadiqueen/wesnoth/builds/348852387
20180304 07:51:06-!- travis-ci [~travis-ci@ec2-54-80-248-14.compute-1.amazonaws.com] has left #wesnoth-dev []
20180304 08:31:02-!- Oebele [~quassel@143.177.58.202] has joined #wesnoth-dev
20180304 08:41:00-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20180304 08:50:48-!- travis-ci [~travis-ci@ec2-54-221-102-157.compute-1.amazonaws.com] has joined #wesnoth-dev
20180304 08:50:49< travis-ci> Pentarctagon/wesnoth#268 (readd-ccache-stats - f4eb2da : pentarctagon): The build passed.
20180304 08:50:49< travis-ci> Build details : https://travis-ci.org/Pentarctagon/wesnoth/builds/348858951
20180304 08:50:49-!- travis-ci [~travis-ci@ec2-54-221-102-157.compute-1.amazonaws.com] has left #wesnoth-dev []
20180304 09:12:09-!- octalot [~steve@178.115.129.13.wireless.dyn.drei.com] has quit [Ping timeout: 260 seconds]
20180304 09:40:09-!- Bhoren [~Bhoren_wh@2a01:e0a:c:2150:3c8b:23a9:6d4c:2e94] has joined #wesnoth-dev
20180304 09:59:29< vultraz> zookeeper: poke
20180304 09:59:37< zookeeper> ?
20180304 09:59:52< vultraz> why did you change from -1 to 0 here? https://github.com/wesnoth/wesnoth/commit/478c75bdb5bc914fcd71469a2ae6967cadc99e11
20180304 10:00:50< zookeeper> i can't possibly remember. what's the difference?
20180304 10:02:01< vultraz> so I'm looking into this "items don't get color adjust" bug. Ok, simple enough, but if I keep the use of 0 instead of -1 as he first argument to get_light_string, it seems the items remain a bit out of sync with the rest of the screen when it comes to color adjust
20180304 10:05:35< zookeeper> and if you change it back to -1, does ToD lighting break?
20180304 10:05:49< vultraz> no
20180304 10:08:23< zookeeper> does it fix all problems then? :p
20180304 10:09:53< vultraz> yes
20180304 10:10:44< zookeeper> well... in that case i can't see/recall any reason not to do so
20180304 10:13:51< irker520> wesnoth: Charles Dang wesnoth:master f14481ba23fd / src/display.cpp: Fixed color_adjust not applying to map items (fixes #2588) https://github.com/wesnoth/wesnoth/commit/f14481ba23fd1917a2f5b07329a12fa1577038be
20180304 10:26:01-!- midzer_ is now known as midzer
20180304 10:27:21< irker520> wesnoth/wesnoth:master doofus-01 bec097c743 adding sun-shyde and generalizing fire a AppVeyor: All builds passed
20180304 11:03:54< irker520> wesnoth/wesnoth:master Victor Sergienko aa9ca62043 Enable translator's tools on MacPorts AppVeyor: vs2013/Debug Failed
20180304 11:03:55< irker520> Details: https://ci.appveyor.com/project/wesnoth/wesnoth/build/Wesnoth-VS2013-master-1691
20180304 11:31:39< irker520> wesnoth: Charles Dang wesnoth:master 5c6ca7cfb3a0 / / (6 files in 2 dirs): Updated a few interface sounds https://github.com/wesnoth/wesnoth/commit/5c6ca7cfb3a0ccabd8badd5f29cb402530241cec
20180304 11:40:36-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has quit [Quit: .]
20180304 11:46:09-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20180304 12:26:48-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20180304 12:48:10-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has joined #wesnoth-dev
20180304 13:16:20< irker520> wesnoth/wesnoth:master Victor Sergienko aa9ca62043 Enable translator's tools on MacPorts AppVeyor: 1/6 builds failed
20180304 13:16:21< irker520> Details vs2013/Debug: https://ci.appveyor.com/project/wesnoth/wesnoth/build/Wesnoth-VS2013-master-1691
20180304 13:33:13-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180304 13:33:19-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20180304 13:35:18-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20180304 14:14:36-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20180304 14:24:23< irker520> wesnoth: Charles Dang wesnoth:master 574bfbca188b / src/gui/dialogs/multiplayer/mp_join_game.cpp: MP Join Game: removed unnecessary event context when prompting faction selection https://github.com/wesnoth/wesnoth/commit/574bfbca188b4536e0ac368fdb315508a14ec955
20180304 14:44:30-!- TadCarlucci [~lundberg@74.193.219.119] has quit [Quit: Leaving]
20180304 14:44:48-!- TadCarlucci [~lundberg@74.193.219.119] has joined #wesnoth-dev
20180304 15:47:55-!- Bonobo [~Bonobo@61.68.207.231] has quit [Ping timeout: 252 seconds]
20180304 16:06:02-!- celmin|sleep is now known as celticminstrel
20180304 16:35:41< irker520> wesnoth/wesnoth:master pentarctagon 9510a210f5 Don't source steps/script.sh. AppVeyor: All builds passed
20180304 16:48:50< vultraz> celticminstrel: poke
20180304 16:49:30< celticminstrel> ?
20180304 16:49:37< vultraz> celticminstrel: any thoughts on what I should do about [set_menu_item] description= and possible old DescriptionWML?
20180304 16:49:59< celticminstrel> Same as in [multiplayer_side], I guess - if there are two strings, join them into one.
20180304 16:50:00< vultraz> I don't intend to do anything about the ancient legacy markup posted in the example in 2004
20180304 16:50:09< celticminstrel> What example?
20180304 16:50:18< vultraz> "description="~supposed bold text=&units/elves-wood/fighter.png~SCALE(25,25)""
20180304 16:50:24< celticminstrel> Oh that.
20180304 16:50:54< celticminstrel> That ancient legacy markup hasn't been current for a number of stable releases, though.
20180304 16:50:54< vultraz> I think in this instance the image is supposed to go in column 2..
20180304 16:51:06< vultraz> I'm really considering just doing nothing about this
20180304 16:51:07< celticminstrel> Yeah, that's interesting, I didn't even know that was allowed.
20180304 16:51:16< vultraz> the wiki doesn't advertise this as featured
20180304 16:51:31< vultraz> (descriptionwml in menu items)
20180304 16:51:34< celticminstrel> Where did you get that example from?
20180304 16:51:38< vultraz> https://github.com/wesnoth/wesnoth/issues/2004
20180304 16:52:37< vultraz> the wiki doesn't say anything about DescriptionWML in [set_menu_item]
20180304 16:52:43< vultraz> so I'm thinking we just ignore that usecase
20180304 16:53:43< celticminstrel> I don't see what's the problem with doing the same as in [multiplayer_side]? Admittedly it won't handle that specific example, but...
20180304 16:54:26< vultraz> I don't know if the legacy parser handles cases where people tried to stuff images into cols 2 and 3
20180304 16:54:29< vultraz> I don't think it does
20180304 16:54:43< vultraz> then again, no on should have ever done such a thing
20180304 16:54:48< celticminstrel> Yeah, I wouldn't be surprised if it doesn't.
20180304 16:55:05< celticminstrel> But IMO it should handle it and just swap the image back to the first column.
20180304 16:55:16< celticminstrel> I can deal with this if you can't be bothered?
20180304 16:55:42< vultraz> FTR, if added, this should not be added in the main drop down menu parsing code..
20180304 16:56:00< celticminstrel> What?
20180304 16:56:08< vultraz> it should be in the menu item setup code
20180304 16:56:12< vultraz> game_events/menu_item.*pp
20180304 16:56:25< vultraz> we don't want to introduce legacy support into the dropdown dialog itself
20180304 16:56:30< celticminstrel> Does the drop down menu setup code handle the legacy_menu_item stuff?
20180304 16:56:35< vultraz> it oes not
20180304 16:56:36< vultraz> does
20180304 16:57:02< vultraz> hm
20180304 16:57:07< vultraz> I guess you wouldn't need any swapping
20180304 16:57:14< celticminstrel> ?
20180304 16:57:21< vultraz> as long as it knew to assign the image member to the appropriate data
20180304 16:58:14< vultraz> but really, is it worth it? I don't see the point in supporting something we never advertised as supported 
20180304 16:58:41< vultraz> the image key definitely isn't a 1.13 addition
20180304 16:59:47< celticminstrel> You know, it could be handy if there were a ~CONCAT() IPF.
20180304 17:00:00< celticminstrel> Or I guess... separate ~HCONCAT() and ~VCONCAT().
20180304 17:00:05< vultraz> eh?
20180304 17:00:22< celticminstrel> Just take two images and join them together. No need to worry about the size of either image.
20180304 17:14:40-!- octalot [~steve@91.141.1.158.wireless.dyn.drei.com] has joined #wesnoth-dev
20180304 17:26:37-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180304 17:26:43-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20180304 17:49:39< irker520> wesnoth: Jyrki Vesterinen wesnoth:master beed7bfe7231 / src/terrain/translation.hpp: Use std::map::at() in ter_map::get() https://github.com/wesnoth/wesnoth/commit/beed7bfe7231f3dc6d4f0b1553222ca09ab20912
20180304 18:02:29-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20180304 18:04:01-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20180304 18:06:26-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Client Quit]
20180304 18:08:09-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20180304 18:41:16< irker520> wesnoth: Celtic Minstrel wesnoth:fix_deprecation_spam 1fe16360a4ed / / (8 files in 3 dirs): Fix deprecation spam https://github.com/wesnoth/wesnoth/commit/1fe16360a4eddb77a0d287b7ae72727ce90958f3
20180304 18:41:18< irker520> wesnoth: Celtic Minstrel wesnoth:fix_deprecation_spam 3b215b5ccb9a / src/gui/dialogs/log_settings.cpp: Fix crash in logging prefs due to deprecation's default -1 severity https://github.com/wesnoth/wesnoth/commit/3b215b5ccb9a1742b5ab4890386bbcf83716e6b4
20180304 18:41:20< irker520> wesnoth: Celtic Minstrel wesnoth:fix_deprecation_spam ce6c9fec1beb / src/commandline_options.cpp: Add --log-none command line option to disable ALL output from a logdomain https://github.com/wesnoth/wesnoth/commit/ce6c9fec1beb8ae3b95509017ae85ed23ace4223
20180304 18:41:22< irker520> wesnoth: Celtic Minstrel wesnoth:fix_deprecation_spam 6df942ff57ef / src/ (7 files in 2 dirs): Boost deprecation logdomain severity when debug mode is enabled https://github.com/wesnoth/wesnoth/commit/6df942ff57ef3864e0747c8abe3a89ffecf1c10a
20180304 18:41:24< irker520> wesnoth: Celtic Minstrel wesnoth:fix_deprecation_spam 3c383ed45bec / data/advanced_preferences.cfg src/deprecation.cpp: Add hidden preference to show deprecation messages in chat area https://github.com/wesnoth/wesnoth/commit/3c383ed45bec06bcb8dc1ca1e6382ed02f41d46d
20180304 19:16:28-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180304 19:16:37-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20180304 19:27:26-!- octalot [~steve@91.141.1.158.wireless.dyn.drei.com] has quit [Ping timeout: 255 seconds]
20180304 19:31:29< irker520> wesnoth: Celtic Minstrel wesnoth:fix_2247 96f69a34ba13 / src/ (5 files in 4 dirs): Don't assume unit is on the map when testing ability active https://github.com/wesnoth/wesnoth/commit/96f69a34ba1370bb948bddc4a97e54134190ba5d
20180304 19:31:31< irker520> wesnoth: Celtic Minstrel wesnoth:fix_2247 6b4aef9b7517 / src/units/ (abilities.cpp attack_type.hpp): Don't construct an intrusive pointer from a raw pointer https://github.com/wesnoth/wesnoth/commit/6b4aef9b751701eb7ed7516e6a800c32527337db
20180304 19:33:58-!- vultraz [uid24821@wesnoth/developer/vultraz] has quit [Quit: Connection closed for inactivity]
20180304 19:44:56-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180304 19:45:02-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20180304 19:52:40-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180304 19:52:46-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20180304 20:01:25-!- travis-ci [~travis-ci@ec2-54-166-45-253.compute-1.amazonaws.com] has joined #wesnoth-dev
20180304 20:01:26< travis-ci> wesnoth/wesnoth#16710 (fix_deprecation_spam - 3c383ed : Celtic Minstrel): The build is still failing.
20180304 20:01:26< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/348999050
20180304 20:01:26-!- travis-ci [~travis-ci@ec2-54-166-45-253.compute-1.amazonaws.com] has left #wesnoth-dev []
20180304 20:21:34-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180304 20:21:40-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20180304 20:26:44-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180304 20:26:51-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20180304 21:05:24< irker520> wesnoth/wesnoth:master Jyrki Vesterinen beed7bfe72 Use std::map::at() in ter_map::get() AppVeyor: All builds passed
20180304 21:20:56-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has quit [Quit: .]
20180304 21:30:06< irker520> wesnoth: gfgtdf wesnoth:master 18ee8b767c15 / src/playmp_controller.cpp: don't assert on network input https://github.com/wesnoth/wesnoth/commit/18ee8b767c155999e0160f3d4bfd88f603796d32
20180304 21:43:14-!- travis-ci [~travis-ci@ec2-54-163-124-70.compute-1.amazonaws.com] has joined #wesnoth-dev
20180304 21:43:15< travis-ci> wesnoth/wesnoth#16713 (fix_2247 - 6b4aef9 : Celtic Minstrel): The build was broken.
20180304 21:43:16< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/349012223
20180304 21:43:16-!- travis-ci [~travis-ci@ec2-54-163-124-70.compute-1.amazonaws.com] has left #wesnoth-dev []
20180304 21:48:03< irker520> wesnoth: pentarctagon wesnoth:master abf93216acd7 / .travis.yml utils/travis/docker_run.sh utils/travis/steps/script.sh: Don't source steps/script.sh. https://github.com/wesnoth/wesnoth/commit/abf93216acd73a507d3edab87469056d7dbd480a
20180304 22:21:58-!- vultraz [uid24821@wesnoth/developer/vultraz] has joined #wesnoth-dev
20180304 22:41:27< irker520> wesnoth: Celtic Minstrel wesnoth:fix_deprecation_spam 9fe567e9508f / / (10 files in 4 dirs): Fix deprecation spam https://github.com/wesnoth/wesnoth/commit/9fe567e9508f28b7f8523998a7aff13759216d5b
20180304 22:41:29< irker520> wesnoth: Celtic Minstrel wesnoth:fix_deprecation_spam 91ec565dce30 / src/gui/dialogs/log_settings.cpp: Fix crash in logging prefs due to deprecation's default -1 severity https://github.com/wesnoth/wesnoth/commit/91ec565dce309a409cb863fee6229addf271e339
20180304 22:41:31< irker520> wesnoth: Celtic Minstrel wesnoth:fix_deprecation_spam ace85be0d571 / src/commandline_options.cpp: Add --log-none command line option to disable ALL output from a logdomain https://github.com/wesnoth/wesnoth/commit/ace85be0d5710fa70411a2f31a49df286cdeee52
20180304 22:41:33< irker520> wesnoth: Celtic Minstrel wesnoth:fix_deprecation_spam e72ecc5049f9 / src/ (7 files in 2 dirs): Boost deprecation logdomain severity when debug mode is enabled https://github.com/wesnoth/wesnoth/commit/e72ecc5049f9662ad923121bc47125b82ef0297d
20180304 22:41:35< irker520> wesnoth: Celtic Minstrel wesnoth:fix_deprecation_spam a290fe8cc1f0 / data/advanced_preferences.cfg src/deprecation.cpp: Add hidden preference to show deprecation messages in chat area https://github.com/wesnoth/wesnoth/commit/a290fe8cc1f0e9a9f444f4b7f77e183cbfce745c
20180304 23:03:45-!- Oebele [~quassel@143.177.58.202] has quit [Remote host closed the connection]
20180304 23:10:39< vultraz> celticminstrel: I wonder if it's possible to automatically fix certain deprecated code
20180304 23:13:19< celticminstrel> What do you mean?
20180304 23:14:40-!- travis-ci [~travis-ci@ec2-54-166-45-253.compute-1.amazonaws.com] has joined #wesnoth-dev
20180304 23:14:41< travis-ci> wesnoth/wesnoth#16719 (fix_deprecation_spam - a290fe8 : Celtic Minstrel): The build is still failing.
20180304 23:14:41< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/349064876
20180304 23:14:41-!- travis-ci [~travis-ci@ec2-54-166-45-253.compute-1.amazonaws.com] has left #wesnoth-dev []
20180304 23:17:52< vultraz> well
20180304 23:18:30< vultraz> it's kinda complicated since we have a preprocessor and macros, but essentially, if the parser sees some deprecated code, if it's a simple fix such as swapping a tag name or removing a macro inclusion, it does so and writes the result back to disk
20180304 23:18:40< irker520> wesnoth: Celtic Minstrel wesnoth:fix_2247 19cd31e6fd15 / src/ (5 files in 4 dirs): Don't assume unit is on the map when testing ability active https://github.com/wesnoth/wesnoth/commit/19cd31e6fd15587f5119541e16c958bcd00126be
20180304 23:18:42< irker520> wesnoth: Celtic Minstrel wesnoth:fix_2247 00b93054c996 / src/ (5 files in 4 dirs): Use RAII for weapon specials context to ensure no dangling pointers https://github.com/wesnoth/wesnoth/commit/00b93054c996e9e02646759e106741a3e74e71f1
20180304 23:18:44< irker520> wesnoth: Celtic Minstrel wesnoth:fix_2247 2c8b90521c87 / src/actions/attack.cpp: Fix an obvious-looking error in attack action https://github.com/wesnoth/wesnoth/commit/2c8b90521c87e6d247ef8df5721bf39d06fb3e2c
20180304 23:19:11< vultraz> so like it's parsing some unit files, and it sees the MAGENTA_IS_THE_TEAM_COLOR macro
20180304 23:19:17< vultraz> so it just strips it out
20180304 23:19:32< vultraz> and writes the clean file to disk
20180304 23:21:06< vultraz> though that reminds me, have we updated wmllint for all the deprecated stuff?
20180304 23:21:26< celticminstrel> I think that's asking for trouble TBH.
20180304 23:21:30< celticminstrel> And some of it, yeah.
20180304 23:22:13< vultraz> why is it asking for trouble?
20180304 23:22:14< celticminstrel> I have a commit coming soon that switches to deprecated_message() everywhere, so you should be able to easily check once that's pushed.
20180304 23:22:22-!- travis-ci [~travis-ci@ec2-54-166-97-214.compute-1.amazonaws.com] has joined #wesnoth-dev
20180304 23:22:23< travis-ci> Pentarctagon/wesnoth#282 (mp-test-fix-attempt - 824261c : pentarctagon): The build passed.
20180304 23:22:23< travis-ci> Build details : https://travis-ci.org/Pentarctagon/wesnoth/builds/349054893
20180304 23:22:23-!- travis-ci [~travis-ci@ec2-54-166-97-214.compute-1.amazonaws.com] has left #wesnoth-dev []
20180304 23:22:25< celticminstrel> Because you're asking the computer to guess at how to fix something.
20180304 23:22:40< vultraz> it would only be for simple fixes
20180304 23:22:48< irker520> wesnoth: Celtic Minstrel wesnoth:fix_deprecation_spam 0f9c5ede16c5 / src/gui/dialogs/log_settings.cpp: Fix crash in logging prefs due to deprecation's default -1 severity https://github.com/wesnoth/wesnoth/commit/0f9c5ede16c55caa7a3e37dfbae77652a39c3266
20180304 23:22:50< irker520> wesnoth: Celtic Minstrel wesnoth:fix_deprecation_spam 322713dab140 / src/commandline_options.cpp: Add --log-none command line option to disable ALL output from a logdomain https://github.com/wesnoth/wesnoth/commit/322713dab140591bec44b819b18f93eefc8b8cd5
20180304 23:22:52< irker520> wesnoth: Celtic Minstrel wesnoth:fix_deprecation_spam edb50cc3ee62 / src/ (7 files in 2 dirs): Boost deprecation logdomain severity when debug mode is enabled https://github.com/wesnoth/wesnoth/commit/edb50cc3ee6229db9ebecec5019d45398c93b680
20180304 23:22:54< irker520> wesnoth: Celtic Minstrel wesnoth:fix_deprecation_spam e7c10701bc32 / data/advanced_preferences.cfg src/deprecation.cpp: Add hidden preference to show deprecation messages in chat area https://github.com/wesnoth/wesnoth/commit/e7c10701bc32ed57d7a3d45e45223b7a38b57c10
20180304 23:23:05< vultraz> but anyway, could you go through and add any missing stuff to wmllint?
20180304 23:23:21< vultraz> such as MAGENTA_IS_THE_TEAM_COLOR?
20180304 23:23:21< celticminstrel> I dunno...
20180304 23:23:30< celticminstrel> That one is probably already there though.
20180304 23:23:45< vultraz> it isn't
20180304 23:23:47< vultraz> just checked
20180304 23:25:38-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20180304 23:25:42< vultraz> the only reason I suggested we look to implementing some of that in-game is most people won't use wmllint
20180304 23:26:02< celticminstrel> I suggest instead recommending that they use wmllint.
20180304 23:26:07< celticminstrel> Especially since there's now a nice GUI for it.
20180304 23:26:32< vultraz> there's been a nice GUI since 1.12
20180304 23:27:03< vultraz> I intend to make an even nicer GUI myself eventually to work around the shortcomings of tkinter on high-DPI screens....but I haven't gotten to it yet
20180304 23:30:26 * celticminstrel impatiently waiting for Travis to finish... >_>
20180304 23:32:27< vultraz> celticminstrel: we should use an enum for the deprecation levels
20180304 23:32:36< vultraz> not just an int
20180304 23:33:43< vultraz> and possibly provide wrapper functions for each one
20180304 23:34:17< vultraz> but at least some enums
20180304 23:35:01< vultraz> also you keep forgetting to put the leading { on a new line :(
20180304 23:35:18< celticminstrel> Well duh, it's a waste of space.
20180304 23:35:27< celticminstrel> But I do try, since you like it so much.
20180304 23:35:40< vultraz> eh, it doesn't matter much
20180304 23:35:42< celticminstrel> I mean I've definitely remembered for some cases.
20180304 23:35:48< vultraz> but please add an enum
20180304 23:35:54< vultraz> for the deprecation levels
20180304 23:35:56< celticminstrel> I can't really add an enum.
20180304 23:36:04< celticminstrel> Unless we have actual names for the levels.
20180304 23:36:15< vultraz> we do, don't we
20180304 23:36:25< celticminstrel> Not to my knowledge. DeFender1031?
20180304 23:36:41< DeFender1031> Yeah
20180304 23:36:54< vultraz> I could have sworn we came up with names!
20180304 23:37:06< DeFender1031> https://wiki.wesnoth.org/CompatibilityStandards#Depreca
20180304 23:37:14< DeFender1031> The words before the dash on each one
20180304 23:37:43< vultraz> whole link https://wiki.wesnoth.org/CompatibilityStandards#Deprecation_levels_-_When_to_remove_deprecated_features
20180304 23:37:56< DeFender1031> ack
20180304 23:37:59< DeFender1031> no idea how that happened.
20180304 23:38:51< DeFender1031> and yes, that's the correct link
20180304 23:39:19< vultraz> you could call the enum something like INDEFINITELY, PREEMPTIVELY, STANDARD, and REMOVED 
20180304 23:39:28< vultraz> second probably isn't great
20180304 23:39:43< vultraz> maybe SOFT
20180304 23:49:34< DeFender1031> uh... I'd not call that one "standard"
20180304 23:49:45< DeFender1031> 1 or 2 should be standard.
20180304 23:50:15< vultraz> not really?
20180304 23:50:34< vultraz> deprecated-for-removal seems more like standard behavior
20180304 23:50:59< vultraz> deprecated-and-around-indefinitely is definitely not standard 
20180304 23:51:04< vultraz> 2, *possibly*
20180304 23:51:07< vultraz> but I'm prefer 3
20180304 23:51:16< DeFender1031> that's... not what was agreed and not what that page says.
20180304 23:51:28 * vultraz reads again
20180304 23:51:36< DeFender1031> but I'm too tired to have this argument yet again.
20180304 23:51:37< vultraz> oh
20180304 23:51:41< vultraz> I misread the page
20180304 23:51:45< DeFender1031> hmm?
20180304 23:51:59< vultraz> I thought the page said level 3 was the "aim for most of the time" one
20180304 23:52:04< DeFender1031> ah
20180304 23:52:40< vultraz> sorry
20180304 23:52:42< vultraz> nevermind :P
20180304 23:52:43< DeFender1031> no, the point is to deprecate so that things are in a deprecated state and can then be removed as necessary
20180304 23:53:15< DeFender1031> 3 is "we have decreed its definite removal" rather than its indefinite removal
20180304 23:53:26< DeFender1031> so something like "CONDEMNED" or something
20180304 23:53:39< vultraz> I'd be more likely to use 3 most of the time anyway
20180304 23:53:41< vultraz> :P
20180304 23:53:46< vultraz> even if I should use 2.
20180304 23:53:58< vultraz> but yeah, I guess 2 should be STANDARD
20180304 23:54:10< DeFender1031> that's exactly why we had these discussions, yes.
20180304 23:54:20< vultraz> so... maybe SOFT,  STANDARD, CONDEMNED, REMOVED
20180304 23:54:42< DeFender1031> I'd not name any "STANDARD"
20180304 23:54:46< DeFender1031> or maybe as an alias
20180304 23:55:05< vultraz> then what would you name level 2
20180304 23:55:09< DeFender1031> but i'd say "INDEFINITE", "PREEMPTIVE", "CONDEMNED", and "REMOVED"
20180304 23:55:49< vultraz> good enough
20180304 23:55:51< vultraz> celticminstrel: ^
20180304 23:56:24< DeFender1031> there might be a better word for "condemned" but it's ass-o'clock and I need to be in bed.
20180304 23:56:44< shadowm> Gotta love it when it's ass o'clock.
20180304 23:57:03< shadowm> Best time of the day to ogle them asses.
20180304 23:58:32< DeFender1031> it's what a different little niche in the internet calls like 2-6 in the morning.
20180304 23:59:04< DeFender1031> (carlsagan42, a mario maker twitch streamer, if you're really curious)
20180304 23:59:35< DeFender1031> anyway, point is, I might come back tomorrow with a somewhat better word for "condemned", but right now i'm heading to bed.
20180304 23:59:37< shadowm> I was expecting something entirely different. Colour me underwhelmed.
20180304 23:59:50< shadowm> And more than a little disappointed.
--- Log closed Mon Mar 05 00:00:07 2018