--- Log opened Mon Mar 05 00:00:07 2018
--- Day changed Mon Mar 05 2018
20180305 00:00:07< DeFender1031> eh, it's one of those "you have to be part of it things" I guess.
20180305 00:00:57< DeFender1031> anyway, i'm off.
20180305 00:07:14< celticminstrel> ...oh, in that case I'll hold off on the enum for now.
20180305 00:08:27< celticminstrel> I'll do an enum maybe tomorrow evening?
20180305 00:09:07< celticminstrel> vultraz: Alright to merge today and then add the enum later?
20180305 00:09:53< celticminstrel> ...it's be over half an hour and the PR build hasn't even started. :/
20180305 00:09:58< celticminstrel> ^been
20180305 00:10:16< celticminstrel> Nor the push build. :/
20180305 00:10:40-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 256 seconds]
20180305 00:11:08-!- Bhoren [~Bhoren_wh@2a01:e0a:c:2150:3c8b:23a9:6d4c:2e94] has quit [Quit: Leaving]
20180305 00:13:55-!- travis-ci [~travis-ci@ec2-54-166-97-214.compute-1.amazonaws.com] has joined #wesnoth-dev
20180305 00:13:56< travis-ci> wesnoth/wesnoth#16721 (fix_2247 - 2c8b905 : Celtic Minstrel): The build is still failing.
20180305 00:13:56< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/349073527
20180305 00:13:56-!- travis-ci [~travis-ci@ec2-54-166-97-214.compute-1.amazonaws.com] has left #wesnoth-dev []
20180305 00:14:16< vultraz> celticminstrel: why not add the enum and we can rename it later
20180305 00:14:16< celticminstrel> Pretty sure that failure isn't actually related to the PR.
20180305 00:14:27< vultraz>  or how about
20180305 00:14:28< celticminstrel> I think it's better not to have to rename it later, though.
20180305 00:14:29< vultraz> FOR_REMOVAL
20180305 00:14:53< celticminstrel> Because when it's added we'll have to update every place that uses it, and changing the name will have the same problem.
20180305 00:14:54< vultraz> good parity with REMOVED
20180305 00:15:36< celticminstrel> Though at least we can grep for deprecated_message to find every instance that would need updating.
20180305 00:15:57< celticminstrel> (Well, not necessarily grep, but some kind of search.)
20180305 00:17:09< vultraz> changing the name would be easy
20180305 00:17:18< vultraz> but really, what do you think of FOR_REMOVAL
20180305 00:17:31< celticminstrel> Maybe.
20180305 00:17:56< celticminstrel> Keep in mind that this'll be used in WML too.
20180305 00:18:00< celticminstrel> for_removal probably?
20180305 00:18:13< celticminstrel> Maybe for-removal.
20180305 00:18:19< celticminstrel> That's probably better actually.
20180305 00:18:54< celticminstrel> I mean you could also go with 4removal but why the heck would you.
20180305 00:19:25< vultraz> the - seems inconsistent with other enum names
20180305 00:19:59< celticminstrel> IMO - is generally better, but okay, consistency is good too.
20180305 00:20:56< vultraz> if you want to assign a wml name, perhaps MAKE_ENUM is good here
20180305 00:22:05< celticminstrel> Yeah, was planning on that.
20180305 00:22:20< celticminstrel> ...oh, I guess that does mean I need to qualify the names in C++... oh well.
20180305 00:22:38< vultraz> oh, true
20180305 00:22:56< celticminstrel> The solution to that is to use a shorter type name, right? :P
20180305 00:23:04< celticminstrel> Instead of DEPRECATION_LEVEL, DEP_LVL. :P
20180305 00:23:04< vultraz> dep_level?
20180305 00:23:16< celticminstrel> Or that, sure.
20180305 00:23:29 * celticminstrel was assuming the established convention of MAKE_ENUM type names being all-caps though.
20180305 00:23:41< vultraz> I wasn't accounting for that
20180305 00:24:02< vultraz> DEP_LEVEL is fine
20180305 00:24:14< celticminstrel> So you'd prefer I do it before merge?
20180305 00:24:30< vultraz> yes
20180305 00:24:30< celticminstrel> Not gonna wait for yet another Travis build if this current one succeeds though...
20180305 00:24:40< vultraz> and possibly add wrappers
20180305 00:24:58< celticminstrel> Eh.
20180305 00:25:05< vultraz> if not it's fine
20180305 00:29:48< irker520> wesnoth/wesnoth:master Steve Cotton 5a063fd7c2 LoW S14 Objectives, reinforcements, edit AppVeyor: All builds passed
20180305 01:08:02-!- Bonobo [~Bonobo@61.68.207.231] has joined #wesnoth-dev
20180305 01:11:58< celticminstrel> Converting the preprocessor stuff to an enum is a bit troublesome...
20180305 01:13:06-!- travis-ci [~travis-ci@ec2-54-163-124-70.compute-1.amazonaws.com] has joined #wesnoth-dev
20180305 01:13:07< travis-ci> wesnoth/wesnoth#16723 (fix_deprecation_spam - e7c1070 : Celtic Minstrel): The build is still failing.
20180305 01:13:07< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/349074627
20180305 01:13:07-!- travis-ci [~travis-ci@ec2-54-163-124-70.compute-1.amazonaws.com] has left #wesnoth-dev []
20180305 01:13:18< celticminstrel> Because I use std::max on the deprecation level, and use invalid values 0 and -1.
20180305 01:13:52< celticminstrel> Which, come to think of it, kinda both mean the same thing in a way?
20180305 01:14:05< celticminstrel> Basically "the macro isn't deprecated".
20180305 01:14:25< celticminstrel> Though -1 is "no deprecation directive" and 0 is "deprecation directive with invalid level".
20180305 01:14:35< celticminstrel> Something like that.
20180305 01:16:26< vultraz> you can use std::max on an enum
20180305 01:16:38< vultraz> oh, but I guess not the make enum enum
20180305 01:16:46< vultraz> perhaps don't use a make enum enum?
20180305 01:17:18< celticminstrel> I could do an enum for C++ but (at least for now) stick with 1.4 for Lua/WML?
20180305 01:17:24< celticminstrel> 1-4
20180305 01:17:28< vultraz> sure
20180305 01:17:38< vultraz> the deprecated thing is really for devs anyway
20180305 01:25:51< vultraz> celticminstrel: what's the difference between vgettext and VGETTEXT?
20180305 01:26:19< celticminstrel> IIRC vgettext is the function and VGETTEXT is the macro.
20180305 01:26:25< vultraz> right
20180305 01:26:29< vultraz> but which is one supposed to use
20180305 01:26:40< celticminstrel> Meaning that VGETTEXT honours the declared textdomain, whereas vgettext requires you to explicitly pass the textdomain.
20180305 01:26:54< vultraz> ah
20180305 01:26:59< vultraz> so we should use VGETTEXT everywhere?
20180305 01:27:00< celticminstrel> So IOW you should use VGETTEXT unless you're looking up a string from a textdomain other than the main one for that file.
20180305 01:27:05< celticminstrel> I think,
20180305 01:30:07< vultraz> I wonder if we should move VGETTEXT to gettext.hpp
20180305 01:30:37< celticminstrel> Although you could do that, it wouldn't prevent you from needing to include formula/string-utils
20180305 01:30:49< celticminstrel> Since that's where the function is defined, and you can't move the function.
20180305 01:31:27< vultraz> why not? I could implement it in gettext_boost.cpp
20180305 01:31:40< celticminstrel> No, you couldn't.
20180305 01:31:57< shadowm> The function in question requires the formula code to perform variable interpolation.
20180305 01:32:21< celticminstrel> ...though admittedly it doesn't actually require the formula code anymore...
20180305 01:32:22< shadowm> It's not as simple as you think, otherwise I wouldn't have needed to roll my own tiny interpolator for campaignd's URL code.
20180305 01:32:29< shadowm> It doesn't?
20180305 01:32:59< celticminstrel> I stored a function pointer to the formula evaluation code which is set at static init time, and if it's not set it just deletes any formula substitutions.
20180305 01:33:15< celticminstrel> It's a little hacky, but it works.
20180305 01:33:20< vultraz> so that's what that is...
20180305 01:33:42< celticminstrel> Now why the heck am I getting a link error on preferences::get(string, bool)?
20180305 01:34:04< vultraz> o-O
20180305 01:35:17< vultraz> celticminstrel: could std::function be used there?
20180305 01:35:19< vultraz> i'm curious
20180305 01:35:25< vultraz> for evaluate_formula
20180305 01:35:33< celticminstrel> In theory, yeah, but I didn't see the point.
20180305 01:35:59< vultraz> would make it clearer exactly what `evaluate_formula` is
20180305 01:36:16< celticminstrel> So would a comment. Or a typedef (which for some reason I didn't bother with).
20180305 01:36:53< vultraz> does this mean we can't remove the light interpolator in campaignd?
20180305 01:37:12< shadowm> I mean, it serves its purpose.
20180305 01:37:43< vultraz> huh. That is a VERY simple one.
20180305 01:37:44< shadowm> It doesn't hurt anyone other than those annoying perfectionists who have no business writing programs in the real world.
20180305 01:37:46< celticminstrel> I guess you could remove it. Pretty sure the main one is currently being compiled into campaignd anyway.
20180305 01:38:02< celticminstrel> But shadowm has a point too.
20180305 01:38:29< vultraz> maybe we should move the light one to global...
20180305 01:38:43< shadowm> Why?
20180305 01:38:57< celticminstrel> Yeah that's a very good question.
20180305 01:39:01< vultraz> might be more efficient.
20180305 01:39:05< shadowm> Nothing else needs it and it has issues (documented in the function's documentation).
20180305 01:39:25< shadowm> Meaning it's not suitable for general usage.
20180305 01:41:33< vultraz> ah
20180305 01:42:10< celticminstrel> I might've figured out why I get a link error.
20180305 01:42:30< celticminstrel> I think MSVC is (wrongly) linking deprecation.cpp into the campaignd which doesn't include preferences.
20180305 01:43:00< celticminstrel> (And possibly wesnothd too.)
20180305 01:43:25< vultraz> is it in the file list for those projects?
20180305 01:43:36< celticminstrel> It's in the file list for wesnothlib.
20180305 01:43:48< vultraz> ah
20180305 01:50:04< celticminstrel> O_O
20180305 01:50:21< celticminstrel> VSCode lets you easily solve merge conflicts!
20180305 01:50:30< celticminstrel> You can click "accept current" or "accept incoming"!
20180305 01:50:42< vultraz> it seemed a bit clunky last time I tried, but yeah
20180305 01:50:49< vultraz> perhaps I just have nfi how to work with merge conflicts
20180305 01:56:57< irker520> wesnoth: Charles Dang wesnoth:master 5517063fb9cb / src/help/help_browser.cpp: Help: disable Unknown Topic popup (fixes #2587) https://github.com/wesnoth/wesnoth/commit/5517063fb9cb1673b0a148e11a6eb50dbc00086d
20180305 02:01:15< vultraz> celticminstrel: travis is fine with your pr
20180305 02:01:46< celticminstrel> I'm putting that other commit I mentioned into the PR before merging.
20180305 02:01:55< celticminstrel> The one where I actually use deprecated_message() all over the place.
20180305 02:01:59< celticminstrel> That, plus the enum.
20180305 02:03:23< vultraz> please make the thing in [multiplayer_side] level 3
20180305 02:03:38< celticminstrel> I've made DescriptionWML everywhere level 3.
20180305 02:03:52< vultraz> *yes*
20180305 02:03:53< celticminstrel> You can see what I did soon, in any case.
20180305 02:04:01< vultraz> *happy dance*
20180305 02:04:14< celticminstrel> I demoted a few to level two a few minutes ago, but nothing DescriptionWML-related.
20180305 02:04:42< celticminstrel> (I mean demoted relative to my original value which you will never see. >_> )
20180305 02:07:48< vultraz> I wonder if it was wise to deprecate [option] message=
20180305 02:08:28< celticminstrel> I think I rated that level 2 actually.
20180305 02:08:42< celticminstrel> The DescriptionWML is level 3, but using message instead of label is only level 2.
20180305 02:09:05< vultraz> It occurs to me we might not have handled the whole thing with [option] very well
20180305 02:11:35< vultraz> celticminstrel: just throwing this out there
20180305 02:11:43< vultraz> is it too late to get rid of label and just retain message
20180305 02:12:05< vultraz> because, thinking about it
20180305 02:12:09< vultraz> *why* did we use label?
20180305 02:12:39< vultraz> I probably should never have used it for the difficulty dialog either
20180305 02:19:19< celticminstrel> I think the choice of label is because of how it's used in the difficulty dialog - the first string is a label, the second a description.
20180305 02:19:48< vultraz> name= probably would have been better there
20180305 02:21:08< irker520> wesnoth: Celtic Minstrel wesnoth:fix_deprecation_spam 7db71e9316aa / / (21 files in 12 dirs): Use new deprecated_message() function wherever possible (C++) https://github.com/wesnoth/wesnoth/commit/7db71e9316aa2a89028dea60814b3d82f9e2f771
20180305 02:21:10< irker520> wesnoth: Celtic Minstrel wesnoth:fix_deprecation_spam 7b365e14c8e7 / data/lua/wml-tags.lua: Honour the regular deprecation message settings for WML deprecation messages https://github.com/wesnoth/wesnoth/commit/7b365e14c8e7c0c22a7c2f21d8e8a0e7d7abb58b
20180305 02:21:12< irker520> wesnoth: Celtic Minstrel wesnoth:fix_deprecation_spam f5c3eb9d64e8 / src/ (16 files in 11 dirs): Use an enum for deprecation levels (C++ only) https://github.com/wesnoth/wesnoth/commit/f5c3eb9d64e815cc837b1cc9b6c7077c0026512e
20180305 02:21:14< irker520> wesnoth: Celtic Minstrel wesnoth:fix_deprecation_spam 697f59d32dc6 / / (7 files in 3 dirs): Fix wesnothd and campaignd link errors https://github.com/wesnoth/wesnoth/commit/697f59d32dc6b1027445f06e6071f44ad7d0757d
20180305 02:21:35< irker520> wesnoth: Celtic Minstrel wesnoth:master dabf09fce1d7 / / (10 files in 4 dirs): Fix deprecation spam https://github.com/wesnoth/wesnoth/commit/dabf09fce1d71fbac4b0b798df1f4c8ea9dc9487
20180305 02:21:37< irker520> wesnoth: Celtic Minstrel wesnoth:master 401f88d0e0c0 / src/gui/dialogs/log_settings.cpp: Fix crash in logging prefs due to deprecation's default -1 severity https://github.com/wesnoth/wesnoth/commit/401f88d0e0c0ac96ecfedf2037739d3143d629b6
20180305 02:21:39< irker520> wesnoth: Celtic Minstrel wesnoth:master 624d8e03e182 / src/commandline_options.cpp: Add --log-none command line option to disable ALL output from a logdomain https://github.com/wesnoth/wesnoth/commit/624d8e03e182083760de4530aa3c227755fc0ca4
20180305 02:21:41< irker520> wesnoth: Celtic Minstrel wesnoth:master dc0d6474e888 / src/ (7 files in 2 dirs): Boost deprecation logdomain severity when debug mode is enabled https://github.com/wesnoth/wesnoth/commit/dc0d6474e888dddafbd9995857bb9cdbe5efa20b
20180305 02:21:43< irker520> wesnoth: Celtic Minstrel wesnoth:master 32b6a3de4534 / data/advanced_preferences.cfg src/deprecation.cpp: Add hidden preference to show deprecation messages in chat area https://github.com/wesnoth/wesnoth/commit/32b6a3de4534a8f5bff8ab97fe8d722313596d39
20180305 02:21:45< irker520> wesnoth: Celtic Minstrel wesnoth:master 5fc9d8d17395 / / (21 files in 12 dirs): Use new deprecated_message() function wherever possible (C++) https://github.com/wesnoth/wesnoth/commit/5fc9d8d1739576302fc6da9c90c13cbffd0f023b
20180305 02:21:47< irker520> wesnoth: Celtic Minstrel wesnoth:master 1e2512a67220 / data/lua/wml-tags.lua: Honour the regular deprecation message settings for WML deprecation messages https://github.com/wesnoth/wesnoth/commit/1e2512a67220195d1c0ae366013d97e1106b0d23
20180305 02:21:49< irker520> wesnoth: Celtic Minstrel wesnoth:master b0559eb0bf20 / src/ (16 files in 11 dirs): Use an enum for deprecation levels (C++ only) https://github.com/wesnoth/wesnoth/commit/b0559eb0bf20e45b4b7482dabd302b5df4662e62
20180305 02:21:51< irker520> wesnoth: Celtic Minstrel wesnoth:master b02e73535e9a / / (7 files in 3 dirs): Fix wesnothd and campaignd link errors https://github.com/wesnoth/wesnoth/commit/b02e73535e9aeede609b9393158b6600f2013964
20180305 02:23:54-!- travis-ci [~travis-ci@ec2-54-166-97-214.compute-1.amazonaws.com] has joined #wesnoth-dev
20180305 02:23:55< travis-ci> wesnoth/wesnoth#16726 (fix_deprecation_spam - 697f59d : Celtic Minstrel): The build is still failing.
20180305 02:23:55< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/349111940
20180305 02:23:55-!- travis-ci [~travis-ci@ec2-54-166-97-214.compute-1.amazonaws.com] has left #wesnoth-dev []
20180305 02:24:45< vultraz> do close that bug
20180305 02:26:08< celticminstrel> Which one?
20180305 02:26:25< vultraz> no deprecation reporting for descirptionwml
20180305 02:26:26< vultraz> 2004
20180305 02:27:53< vultraz> if we want to change the thing with [option] message/label we need to do it now
20180305 02:28:16< vultraz> I remember some complaint about having to update to label...
20180305 02:28:37< vultraz> though if we change it back, we might make people undo some works
20180305 02:28:38< vultraz> work
20180305 02:29:10< celticminstrel> I don't really see a reason to change it TBH; label makes sense to me.
20180305 02:29:18< celticminstrel> But you could demote it to level 1 if there are people complaining.
20180305 02:29:31< vultraz> what about label -> name in the difficulty wml
20180305 02:29:53< vultraz> (and we should update the wiki to make note that the description wml keys are not universal... )
20180305 02:30:12< celticminstrel> You want to use name in [difficulty] but label in [option]?
20180305 02:30:40< vultraz> or we could in both.
20180305 02:30:47< celticminstrel> I suppose label makes more sense in the one case than in the other, but it's not nonsensical for [difficulty], and I think a little consistency is good.
20180305 02:31:09< celticminstrel> I think label makes a bit more sense in option, but I guess name isn't nonsensical there either...
20180305 02:31:36< celticminstrel> I think label is better in option by a greater margin than name is better in difficulty.
20180305 02:31:42< celticminstrel> If that makes any sense?
20180305 02:31:56< celticminstrel> So if it were up to me, I'd stick with label.
20180305 02:32:09< celticminstrel> But I wouldn't mind if it's changed to name as long as it's done in both places.
20180305 02:32:56< celticminstrel> ...heh, of the two travis builds for 2526, one passed and one faild.
20180305 02:32:59< celticminstrel> ^faied
20180305 02:33:01< celticminstrel> ^failed
20180305 02:39:50< vultraz> anyway, thanks for working on all that
20180305 02:40:02< celticminstrel> Next week I suppose I'll go back to schema stuff.
20180305 02:40:04< vultraz> oh, did you remove log macros where appropriate?
20180305 02:40:09< celticminstrel> No.
20180305 02:40:13< vultraz> blah
20180305 02:40:18< celticminstrel> I doubt there are many places where it's appropriate though.
20180305 02:40:25< celticminstrel> I did remove them from faction_select.cpp.
20180305 02:40:28< vultraz> good, good
20180305 02:40:46< vultraz> no need to get back to the schema
20180305 02:40:49< celticminstrel> Feel free to peruse the diff and decide if there are other places they should be removed.
20180305 02:40:52< vultraz> it's a 1.15 target
20180305 02:41:03< celticminstrel> Eh, I'd disagree rather strongly with that.
20180305 02:41:18< celticminstrel> Despite it being a 1.15 target, I think there are good reasons to get it done before 1.14 is released.
20180305 02:42:14< vultraz> I'd rather you finished the backstab issue
20180305 02:42:22< vultraz> and decided what to do about the heal unit text
20180305 02:42:25< vultraz> first
20180305 02:42:31< celticminstrel> Uh. You do realize that I did the first of those today.
20180305 02:42:40< vultraz> yes
20180305 02:42:43< vultraz> but it's not merged
20180305 02:42:44< celticminstrel> Well okay, there's one small thing left, but it'll be done today in any case.
20180305 02:56:52< vultraz> celticminstrel: assert on startup
20180305 02:57:05< celticminstrel> Yeah, was about to push the fix.
20180305 02:57:14< irker520> wesnoth: Charles Dang wesnoth:master 0089357edb0c / data/gui/window/wml_message.cfg: Message Dialog: make all option rows have the same height https://github.com/wesnoth/wesnoth/commit/0089357edb0c3900c5645a138520391bb0f09626
20180305 02:57:17< irker520> wesnoth: Charles Dang wesnoth:master e117e2cede59 / src/config.cpp: Config: fixup 5fc9d8d1739576302fc6da9c90c13cbffd0f023b https://github.com/wesnoth/wesnoth/commit/e117e2cede59075b32f6227c958dd59d9ae46bf0
20180305 02:57:25< vultraz> (not the fix to that, that's a compilation fix)
20180305 02:58:00< celticminstrel> That should be fine for compiling, but whatever, doesn't make a difference to me.
20180305 02:58:10< vultraz> It did not compile for me...
20180305 02:58:12< vultraz> :|
20180305 02:58:23< celticminstrel> Oh, because your build uses string_view and mine doesn't, probably.
20180305 02:58:29< vultraz> yes
20180305 02:58:31< vultraz> exactly
20180305 03:01:01 * vultraz awaits the assert fix
20180305 03:03:26< irker520> wesnoth: Celtic Minstrel wesnoth:master aa0a3bebd18c / changelog data/lua/wml/set_variable.lua: Add suffix= and prefix= operations to [set_variable] https://github.com/wesnoth/wesnoth/commit/aa0a3bebd18c549115aec7232316c5e073af3642
20180305 03:03:28< irker520> wesnoth: Celtic Minstrel wesnoth:master 84d21428b6cd / src/serialization/ (preprocessor.cpp preprocessor.hpp): fixup boost::optional assert https://github.com/wesnoth/wesnoth/commit/84d21428b6cde371a81695e2ee3073ab91edc4ad
20180305 03:03:30< irker520> wesnoth: Celtic Minstrel wesnoth:master f4b031b7acf7 / data/lua/wml-tags.lua: fixup [deprecated_messag] https://github.com/wesnoth/wesnoth/commit/f4b031b7acf72be98f4ebb1933587d03eefd9027
20180305 03:03:32< irker520> wesnoth: Celtic Minstrel wesnoth:master 1cbe8d917017 / data/core/ (3 files in 3 dirs): Generalize the deprecated unit macro used for the khalifate https://github.com/wesnoth/wesnoth/commit/1cbe8d9170173501009e26b122a27bd942354812
20180305 03:03:57< vultraz> celticminstrel: why add prefix and suffix
20180305 03:04:24< vultraz> people could just use formula and concat themselves
20180305 03:04:28< vultraz> could they not
20180305 03:04:56< celticminstrel> I guess, but this allows the use of VARIABLE_OP in an intuitive way.
20180305 03:05:05< celticminstrel> I used prefix in the DEPRECATED_UNIT macro.
20180305 03:05:29< vultraz> blah
20180305 03:05:44< vultraz> I don't particularly like adding more operation keys
20180305 03:07:15< vultraz> it seems clunky
20180305 03:28:22-!- travis-ci [~travis-ci@ec2-54-166-45-253.compute-1.amazonaws.com] has joined #wesnoth-dev
20180305 03:28:23< travis-ci> wesnoth/wesnoth#16728 (master - b02e735 : Celtic Minstrel): The build was broken.
20180305 03:28:23< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/349112060
20180305 03:28:23-!- travis-ci [~travis-ci@ec2-54-166-45-253.compute-1.amazonaws.com] has left #wesnoth-dev []
20180305 03:28:51< irker520> wesnoth: Celtic Minstrel wesnoth:fix_2247 5cb20485f05b / src/units/ (abilities.cpp attack_type.hpp): Address edge-case where copy elision doesn't occur https://github.com/wesnoth/wesnoth/commit/5cb20485f05b723eb248196a00d4235ddae62ea1
20180305 03:28:53< irker520> wesnoth: Celtic Minstrel wesnoth:fix_2247 b86efb8747a9 / src/actions/attack.cpp: Ensure a weapon specials context is active when attack events are fired https://github.com/wesnoth/wesnoth/commit/b86efb8747a9fa0f45eb0d5406913da8a34fa79f
20180305 03:30:34-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20180305 03:34:06< irker520> wesnoth: Charles Dang wesnoth:master fef068034f7b / src/carryover.cpp: Reset unit hidden status between scenarios (fixes #2590) https://github.com/wesnoth/wesnoth/commit/fef068034f7b06fb6b2365eede82dd253c25ba3e
20180305 03:43:25< irker520> wesnoth/wesnoth:master Iris Morelle 78209194a0 campaignd: Add support for free-form tag AppVeyor: All builds passed
20180305 03:44:59-!- travis-ci [~travis-ci@ec2-54-166-97-214.compute-1.amazonaws.com] has joined #wesnoth-dev
20180305 03:45:00< travis-ci> wesnoth/wesnoth#16730 (master - 1cbe8d9 : Celtic Minstrel): The build was broken.
20180305 03:45:00< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/349119937
20180305 03:45:00-!- travis-ci [~travis-ci@ec2-54-166-97-214.compute-1.amazonaws.com] has left #wesnoth-dev []
20180305 03:57:06< vultraz> celticminstrel: segfault in your branch
20180305 03:59:09< celticminstrel> ?
20180305 03:59:19< vultraz> fix_2247
20180305 03:59:22< vultraz> travis
20180305 03:59:25< vultraz> segfault running tests
20180305 03:59:36< celticminstrel> It hasn't reported yet though.
20180305 03:59:42< vultraz> i canceled it
20180305 03:59:45< celticminstrel> Ah.
20180305 03:59:54< celticminstrel> Why?
20180305 04:00:07< vultraz> because one build segfaulted in tests
20180305 04:00:16< celticminstrel> And?
20180305 04:00:23< vultraz> No need to let it run the other
20180305 04:00:24< vultraz> s
20180305 04:00:29< celticminstrel> ...
20180305 04:07:00< celticminstrel> Oh, I see what I did wrong. I used the defender's weapon for the attacker and vice versa, which means segfault if you don't have both.
20180305 04:13:34< irker520> wesnoth: Celtic Minstrel wesnoth:fix_2247 e1cf4f9684e2 / src/actions/attack.cpp: Ensure a weapon specials context is active when attack events are fired https://github.com/wesnoth/wesnoth/commit/e1cf4f9684e2a5ad248d149d110cc67859008c1d
20180305 04:16:09< celticminstrel> I cancelled the other build for my branch just now, since this push supercedes it.
20180305 04:22:05< celticminstrel> vultraz: What was the heal thing you wanted me to look at, again?
20180305 04:22:26< vultraz> https://github.com/wesnoth/wesnoth/issues/2530
20180305 04:23:20< vultraz> src/game_config.cpp:49:77: error: operator '?:' has lower precedence than '+'; '+' will be evaluated first [-Werror,-Wparentheses]
20180305 04:23:24< vultraz> blahh
20180305 04:23:43< celticminstrel> ...oops.
20180305 04:23:53< celticminstrel> Well, fortunately that's dead code, though.
20180305 04:24:08< celticminstrel> You could just remove it if you don't think it's useful.
20180305 04:24:15< celticminstrel> Or put parentheses around the ?:
20180305 04:24:41< vultraz> dead code, you say
20180305 04:24:45< celticminstrel> (I added it intending to use it in deprecated_message. Then I realized that would defeat the point of providing a version to deprecated_message.)
20180305 04:24:54< celticminstrel> We're talking about next_dev_version, right?
20180305 04:25:02< vultraz> yes
20180305 04:25:06< celticminstrel> It's not even declared in the header, so... yeah, dead code.
20180305 04:25:12< vultraz> why would it defeat the purpose?
20180305 04:25:35< celticminstrel> Because then the version in which it can be removed would never be reached because it would always be the next dev version.
20180305 04:25:40< vultraz> oh
20180305 04:25:41< vultraz> duh
20180305 04:25:42< vultraz> xD
20180305 04:25:45< celticminstrel> :P
20180305 04:26:32< celticminstrel> Hmm. I don't think I'll manage to do anymore programming tonight. Maybe I'll look at heal tomorrow before checking out the schema branch again.
20180305 04:26:57< vultraz> the fix is very simple
20180305 04:27:01< irker520> wesnoth: Charles Dang wesnoth:master b6dcffa48a51 / src/game_config.cpp: Bye bye dead code https://github.com/wesnoth/wesnoth/commit/b6dcffa48a51c0636c6ed4e4aea0ed55d5433cdd
20180305 04:27:05< vultraz> you just need to decide what behavior we want
20180305 04:27:05< celticminstrel> XD
20180305 04:27:42< celticminstrel> There's also the fact that I need to change branches to do it which typically means like ten minutes (maybe only five?) rebuilding everything.
20180305 04:28:04< celticminstrel> Unless I wait my active branch to be merged first.
20180305 04:28:04< vultraz> I can commit it
20180305 04:28:30< vultraz> if you want the no-heal-no-animation-at-all fix
20180305 04:28:30< celticminstrel> Then I can force-reset master to origin/master (after a fetch), check it out, and only rebuild whatever hadn't yet been merged.
20180305 04:28:40< celticminstrel> Anyway, uh...
20180305 04:29:20< celticminstrel> I forget, does it have an animate=yes option?
20180305 04:29:26< vultraz> yes
20180305 04:29:26< celticminstrel> Ah, yeah, it does.
20180305 04:29:44< celticminstrel> Is it default yes or default no?
20180305 04:30:03< vultraz> does it matter?
20180305 04:30:12< celticminstrel> Not sure?
20180305 04:30:14< celticminstrel> Maybe?
20180305 04:30:22< vultraz> the code just says
20180305 04:30:22< vultraz> if cfg.animate then
20180305 04:30:29< vultraz> my proposes fix is
20180305 04:30:32< celticminstrel> So that means default no.
20180305 04:30:38< vultraz> if cfg.animate and heal_amount > 0 then
20180305 04:31:00< celticminstrel> Doesn't that fix also mean your healer won't be animated? That doesn't seem right.
20180305 04:31:30< vultraz> well if there's no healing to be performed why would the healer heal
20180305 04:31:34< vultraz> visually
20180305 04:32:01< vultraz> but to allow the healer's anim to play is simple
20180305 04:32:36< vultraz> which do you prefer
20180305 04:33:12< celticminstrel> Hmmmm...
20180305 04:33:33< celticminstrel> Since animate defaults to "no", passing animate=yes implies an animation is desired...
20180305 04:33:48< celticminstrel> Also, the issue was about a change in behaviour from old versions.
20180305 04:34:06< vultraz> on second though im kinda leaning to the second option
20180305 04:34:08< vultraz> play healer anim
20180305 04:34:36< celticminstrel> I think the simplest fix for the issue would be to leave everything the way it is, EXCEPT
20180305 04:34:47< vultraz> all fixes are simple
20180305 04:34:55< celticminstrel> if heal_amount = 0 then text = ''
20180305 04:35:08< vultraz> ehhh
20180305 04:35:20< vultraz> ...can we just do the healer anim no heal solution :P
20180305 04:35:23< celticminstrel> From what I understand, Kwandulin(?) was expecting both animations to play, but no floating text.
20180305 04:35:58< vultraz> If we want it to play it should have text
20180305 04:36:28< celticminstrel> But it does make some sense to omit the text if it's 0.
20180305 04:36:47< vultraz> but why would you play a healing animation if you're not being healed
20180305 04:37:36< vultraz> imagine a theoretical scenario wih a unit with a fancy healed animation....it plays, but there's no healing! 
20180305 04:38:00< celticminstrel> But maybe you're doing this because you want a healed animation even though there's no actual healing.
20180305 04:38:32< vultraz> then they can use the animator
20180305 04:38:58< celticminstrel> That requires Lua. Or... I guess [animate_unit] works too, never mind.
20180305 04:39:08< vultraz> indeed!
20180305 04:39:09< vultraz> :P
20180305 04:39:18< vultraz> so... healer-but-not-healed?
20180305 04:39:52< celticminstrel> I'm going to make a post on the issue.
20180305 04:40:58< vultraz> I don't think we should decide based on one usecase
20180305 04:41:15< vultraz> so, how baout I commit, then if he wants tweaks we consider the tweaks
20180305 04:41:24< celticminstrel> At least wait for my post?
20180305 04:41:44< vultraz> k
20180305 04:44:07< celticminstrel> Gah! I accidentally wrote latter instead of former! Fixed now.
20180305 04:45:00< irker520> wesnoth: Charles Dang wesnoth:master 3489dac6420c / data/lua/wml/heal_unit.lua: [heal_unit]: don't play healed animation if no healing is done https://github.com/wesnoth/wesnoth/commit/3489dac6420c41a51ed0caf5b84c106b235fd73a
20180305 04:45:07< vultraz> didn't close the issue
20180305 04:45:48< vultraz> your unit thingy fix is passing
20180305 04:45:54< celticminstrel> Yay!
20180305 04:48:31< vultraz> should i merge if it passes?
20180305 04:49:48< irker520> wesnoth: pentarctagon wesnoth:master 900a159c8bca / utils/travis/ (mp_test_executor.sh steps/script.sh): Attempt to fix suspected race condition when running MP tests. https://github.com/wesnoth/wesnoth/commit/900a159c8bca57eb6c0efe903e6be1609ff46973
20180305 05:09:09< celticminstrel> I guess you could.
20180305 05:09:21< celticminstrel> Was hoping mattsc would get a chance to look at it, but I guess he's not around.
20180305 05:10:03< irker520> wesnoth: Celtic Minstrel wesnoth:master 5ece2cc0892f / src/ (5 files in 4 dirs): Don't assume unit is on the map when testing ability active https://github.com/wesnoth/wesnoth/commit/5ece2cc0892f835c7589366f85627cf0de762b08
20180305 05:10:03-!- travis-ci [~travis-ci@ec2-54-166-97-214.compute-1.amazonaws.com] has joined #wesnoth-dev
20180305 05:10:04< travis-ci> wesnoth/wesnoth#16735 (fix_2247 - e1cf4f9 : Celtic Minstrel): The build passed.
20180305 05:10:04< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/349132910
20180305 05:10:04-!- travis-ci [~travis-ci@ec2-54-166-97-214.compute-1.amazonaws.com] has left #wesnoth-dev []
20180305 05:10:05< irker520> wesnoth: Celtic Minstrel wesnoth:master c3f64e59f063 / src/ (5 files in 4 dirs): Use RAII for weapon specials context to ensure no dangling pointers https://github.com/wesnoth/wesnoth/commit/c3f64e59f063305fec0b92049433148c4a7d86fd
20180305 05:10:07< irker520> wesnoth: Celtic Minstrel wesnoth:master 2f7704dab9a1 / src/actions/attack.cpp: Fix an obvious-looking error in attack action https://github.com/wesnoth/wesnoth/commit/2f7704dab9a1a249cb9194a5fbc533267299fe4a
20180305 05:10:09< irker520> wesnoth: Celtic Minstrel wesnoth:master b02e6749d050 / src/units/ (abilities.cpp attack_type.hpp): Address edge-case where copy elision doesn't occur https://github.com/wesnoth/wesnoth/commit/b02e6749d050b3e6f106c317a12bf7fb403b05e3
20180305 05:10:11< irker520> wesnoth: Celtic Minstrel wesnoth:master 579bbc464ff0 / src/actions/attack.cpp: Ensure a weapon specials context is active when attack events are fired https://github.com/wesnoth/wesnoth/commit/579bbc464ff0e6f31c9c8d219878b256710d088a
20180305 05:10:44< vultraz> lot of work done today
20180305 05:14:28< celticminstrel> Could you reformat serialization/tag.?pp?
20180305 05:14:40< celticminstrel> Possibly also serialization/schema_validator.?pp
20180305 05:14:46< vultraz> \o/
20180305 05:14:51< celticminstrel> ?
20180305 05:14:52< vultraz> R E F O R M A T T I N G
20180305 05:14:54< celticminstrel> XD
20180305 05:17:37< celticminstrel> Separate from reformatting, I'm wondering if we should move them to a subfolder and split tag.?pp in two (since it contains both tag and key).
20180305 05:18:18< celticminstrel> But, maybe that's better left until after schema, ie waiting until 1.15. Those merge conflicts would be quite a bit harder to fix, I suspect.
20180305 05:18:46< celticminstrel> (For reformatting conflicts all I have to to is take my version for each conflict, then reformat it. :P )
20180305 05:20:07< vultraz> what is printl...
20180305 05:20:13< celticminstrel> ...?
20180305 05:20:20< vultraz> there's a printl call
20180305 05:20:21< vultraz> here
20180305 05:20:40< celticminstrel> Is it defined elsewhere in the file?
20180305 05:20:56< vultraz> oh
20180305 05:20:57< vultraz> yes
20180305 05:20:58< vultraz> nevermind
20180305 05:30:02-!- APic [apic@apic.name] has quit [Ping timeout: 260 seconds]
20180305 05:36:56-!- APic [apic@apic.name] has joined #wesnoth-dev
20180305 06:06:36< irker520> wesnoth: Charles Dang wesnoth:master 596edaac0053 / src/serialization/ (schema_validator.cpp schema_validator.hpp tag.cpp tag.hpp): Some schema code reformatting as requested by @celticminstrel https://github.com/wesnoth/wesnoth/commit/596edaac0053d62c0beba49685a8a34029980e67
20180305 06:06:39< irker520> wesnoth: Charles Dang wesnoth:master 8309ba63c121 / src/serialization/ (schema_validator.cpp tag.cpp tag.hpp): Serialization/Schema: deployed range-for and auto https://github.com/wesnoth/wesnoth/commit/8309ba63c1215fcb3823083edb5100ed94c6288f
20180305 06:06:41< vultraz> celticminstrel: ^^^
20180305 06:06:57< celticminstrel> Oh huh, range-for and auto.
20180305 06:07:06< celticminstrel> Okay, rebase time.
20180305 06:08:24< vultraz> range-for is so awesome
20180305 06:14:27-!- travis-ci [~travis-ci@ec2-54-163-124-70.compute-1.amazonaws.com] has joined #wesnoth-dev
20180305 06:14:28< travis-ci> wesnoth/wesnoth#16739 (master - 579bbc4 : Celtic Minstrel): The build passed.
20180305 06:14:28< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/349141973
20180305 06:14:28-!- travis-ci [~travis-ci@ec2-54-163-124-70.compute-1.amazonaws.com] has left #wesnoth-dev []
20180305 06:33:34-!- travis-ci [~travis-ci@ec2-54-166-45-253.compute-1.amazonaws.com] has joined #wesnoth-dev
20180305 06:33:35< travis-ci> wesnoth/wesnoth#16740 (master - 8309ba6 : Charles Dang): The build passed.
20180305 06:33:35< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/349153374
20180305 06:33:35-!- travis-ci [~travis-ci@ec2-54-166-45-253.compute-1.amazonaws.com] has left #wesnoth-dev []
20180305 06:56:13< celticminstrel> Merge went pretty well, I think. Should be able to resume working on it soon, maybe tomorrow. I'll try to focus on actually fixing the bugs it finds.
20180305 06:57:42< celticminstrel> So probably what'll happen is that I push things to the PR, and then the fix commits are cherry-picked.
20180305 06:58:46< celticminstrel> (I can probably do the cherry-picking.)
20180305 06:59:21< celticminstrel> (Because we might actually want to cherry-pick-and-squash, which is a little more involved.)
20180305 07:02:31 * celticminstrel pokes wedge009 about 1736.
20180305 07:08:11< irker520> wesnoth: Charles Dang website:develop ad15dfb4c550 / eclipse.wesnoth.org/index.html: eclipse.w.o: replaced Google Analytics script with updated version from Wesmere https://github.com/wesnoth/website/commit/ad15dfb4c550d408ce5c7cf0da3c1a7545154495
20180305 07:09:10< vultraz> nevermind
20180305 07:09:15< irker520> wesnoth: Charles Dang website:develop f4e6b76d8fab / eclipse.wesnoth.org/index.html: eclipse.w.o: dropped Google Analytics script https://github.com/wesnoth/website/commit/f4e6b76d8fabf481631aa420757b58b60091b31c
20180305 07:15:03< wedge009> Yeah, I'd already seen it, was just waiting for compilation.
20180305 07:19:05< irker520> wesnoth: Charles Dang website:develop cdb327992500 / eclipse.wesnoth.org/index.html: eclipse.w.o: restored navbar links to be consistent with our other sites https://github.com/wesnoth/website/commit/cdb3279925008f845cbea3269a459674f31bbafc
20180305 07:20:26-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The computer falls into a deep sleep, to awake again some other day!]
20180305 07:27:06-!- JyrkiVesterinen [~JyrkiVest@195-192-251-124.s1networks.fi] has joined #wesnoth-dev
20180305 07:40:40-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20180305 07:57:02-!- vladimirslavik [~vslavik@83.240.61.16] has joined #wesnoth-dev
20180305 09:19:24-!- vladimirslavik [~vslavik@83.240.61.16] has quit [Remote host closed the connection]
20180305 09:19:24-!- vladimirslavik [~vslavik@83.240.61.16] has joined #wesnoth-dev
20180305 09:19:24-!- vladimirslavik [~vslavik@83.240.61.16] has quit [Changing host]
20180305 09:19:24-!- vladimirslavik [~vslavik@wesnoth/translator/VladimirSlavik] has joined #wesnoth-dev
20180305 09:55:22-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180305 09:55:29-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20180305 10:01:04< irker520> wesnoth: Charles Dang website:develop 2d06f8a4f17e / eclipse.wesnoth.org/ (css/main.css index.html): eclipse.w.o: addressed most semantic feedback from @shikadiqueen https://github.com/wesnoth/website/commit/2d06f8a4f17ec9343164c2b7fc733d789a6d8386
20180305 10:11:26-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Read error: Connection reset by peer]
20180305 10:26:27< irker520> wesnoth/wesnoth:master Charles Dang 8309ba63c1 Serialization/Schema: deployed range-for AppVeyor: All builds passed
20180305 10:30:11-!- JyrkiVesterinen [~JyrkiVest@195-192-251-124.s1networks.fi] has quit [Quit: .]
20180305 10:39:01-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20180305 10:53:50-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20180305 10:58:36< irker520> wesnoth/wesnoth:master doofus-01 5dc96b4306 defense animation for Quenoth Warrior (w AppVeyor: All builds passed
20180305 11:21:53-!- vladimirslavik [~vslavik@wesnoth/translator/VladimirSlavik] has quit [Quit: Leaving]
20180305 11:39:16-!- JyrkiVesterinen [~JyrkiVest@195-192-251-124.s1networks.fi] has joined #wesnoth-dev
20180305 12:11:16-!- vultraz [uid24821@wesnoth/developer/vultraz] has quit [Quit: Connection closed for inactivity]
20180305 12:18:19-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20180305 13:08:44-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20180305 13:36:18-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20180305 13:59:11-!- irker520 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20180305 14:03:38-!- octalot [~steve@91.141.1.158.wireless.dyn.drei.com] has joined #wesnoth-dev
20180305 14:24:25-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20180305 14:26:49-!- octalot [~steve@91.141.1.158.wireless.dyn.drei.com] has quit [Ping timeout: 260 seconds]
20180305 14:41:03< DeFender1031> retired.
20180305 14:41:20< DeFender1031> oh, neither celmin or vult are here.
20180305 14:56:35-!- atarocch_ [~atarocch@93.56.164.28] has joined #wesnoth-dev
20180305 14:57:35-!- atarocch [~atarocch@93.56.164.28] has quit [Excess Flood]
20180305 15:23:43-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20180305 15:24:25-!- JyrkiVesterinen [~JyrkiVest@195-192-251-124.s1networks.fi] has quit [Quit: .]
20180305 15:42:25-!- octalot [~steve@178.165.130.90.wireless.dyn.drei.com] has joined #wesnoth-dev
20180305 16:13:46-!- irker531 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20180305 16:13:46< irker531> wesnoth/wesnoth:master Gregory A Lundberg 5c21886926 Fix missing explicit keyword AppVeyor: vs2015/Release Failed
20180305 16:13:46< irker531> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-1710
20180305 16:28:35< irker531> wesnoth/wesnoth:master Gregory A Lundberg 5c21886926 Fix missing explicit keyword AppVeyor: 3/6 builds failed
20180305 16:28:36< irker531> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-1710
20180305 16:28:37< irker531> Details vs2017/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-master-1415
20180305 16:28:38< irker531> Details vs2013/Release: https://ci.appveyor.com/project/wesnoth/wesnoth/build/Wesnoth-VS2013-master-1722
20180305 16:52:50-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has joined #wesnoth-dev
20180305 17:01:53-!- Bonobo [~Bonobo@61.68.207.231] has quit [Ping timeout: 252 seconds]
20180305 17:22:19-!- octalot [~steve@178.165.130.90.wireless.dyn.drei.com] has quit [Ping timeout: 268 seconds]
20180305 17:51:10< irker531> wesnoth: Gregory A Lundberg wesnoth:master 019ca259b19c / src/server/server_base.cpp: Fix duplicate declaration https://github.com/wesnoth/wesnoth/commit/019ca259b19cadcea6c748c9ae5e6e9b84105b19
20180305 17:59:10< Soliton> TadCarlucci: that's not a duplicate declaration. one is the declaration the other is the definition. depending on warning/error settings compilers might not be happy with the missing declaration now.
20180305 18:00:01< TadCarlucci> Yes it is. Look in the .hpp
20180305 18:00:08< JyrkiVesterinen> Declaration and definition were identical, and definition is also implicitly a declaration. There was no need for an explicit declaration.
20180305 18:01:19< Soliton> i don't see a declaration in the header.
20180305 18:01:20< TadCarlucci> The explicit declaration is in the hpp. The declaration in the cpp was the dupliate. The definition in the cpp is to avoid the linker dragging in a bunch of unneeded stuff.
20180305 18:01:30< TadCarlucci> gcc did
20180305 18:01:58< TadCarlucci> The error was -Wredundant-declaration and it noted previous was in the header
20180305 18:02:11< TadCarlucci> Actuall messages are long gone from my console
20180305 18:02:32< Soliton> perhaps it's in some include.
20180305 18:02:47< TadCarlucci> Yes. deprecation.hpp IIRC
20180305 18:03:26< Soliton> ah, ok.
20180305 18:03:54< TadCarlucci> I would not have pushed the change unless I had an actual error and had checked it supressed the error. :)
20180305 18:05:30< Soliton> well, i assumed something like that. no explanation in the commit message though. that's as far as i was looking, sorry.
20180305 18:07:39< TadCarlucci> No. My personal rule is to only direct-push when it's a trivial change to get a clean run on my systems, Travis or AppVeyor. I do scons/cmake gcc/clang debug/release and VS 2017 locally although most days I just do a quick check instead of the full matrix
20180305 18:08:35< TadCarlucci> s/No/NP
20180305 18:37:18-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20180305 20:31:27-!- Oebele [~quassel@143.177.58.202] has joined #wesnoth-dev
20180305 20:56:50-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180305 20:56:57-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20180305 21:21:36-!- Bhoren [~Bhoren_wh@2a01:e0a:c:2150:29ba:c617:4a85:b25f] has joined #wesnoth-dev
20180305 21:23:05-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 256 seconds]
20180305 21:40:06-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20180305 21:49:25< irker531> wesnoth/wesnoth:master Gregory A Lundberg 019ca259b1 Fix duplicate declaration AppVeyor: All builds passed
20180305 21:58:13-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has quit [Quit: .]
20180305 22:49:39< irker531> wesnoth: Charles Dang wesnoth:master 61cd444fa1ea / src/units/ (abilities.cpp animation_component.cpp drawer.cpp map.cpp types.cpp): Units: range-for https://github.com/wesnoth/wesnoth/commit/61cd444fa1ea0d223f32cd55d01893b40830b93b
20180305 23:04:27-!- Oebele [~quassel@143.177.58.202] has quit [Remote host closed the connection]
20180305 23:47:24-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 260 seconds]
20180305 23:58:05-!- Bhoren [~Bhoren_wh@2a01:e0a:c:2150:29ba:c617:4a85:b25f] has quit [Remote host closed the connection]
--- Log closed Tue Mar 06 00:00:37 2018