--- Log opened Tue Mar 06 00:00:37 2018 20180306 00:08:46-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev 20180306 00:16:56< irker531> wesnoth: Charles Dang website:develop 1a7776fe8eb6 / eclipse.wesnoth.org/ (css/main.css img/decor.png index.html): eclipse.w.o: redesigned main page in the new Wesmere style https://github.com/wesnoth/website/commit/1a7776fe8eb6513120fabe2fd75f84f8525d35fd 20180306 00:16:58< irker531> wesnoth: Charles Dang website:develop ec6a16dd5b8d / eclipse.wesnoth.org/ (download.html features.html): eclipse.w.o: removed unused sub-pages https://github.com/wesnoth/website/commit/ec6a16dd5b8df7bcc17306c0e6a421904987c91c 20180306 00:17:00< irker531> wesnoth: Charles Dang website:develop e3745e950856 / eclipse.wesnoth.org/index.html: eclipse.w.o: dropped Google Analytics script https://github.com/wesnoth/website/commit/e3745e950856eb8ac589e115d3c178acefbe6946 20180306 00:21:13< irker531> wesnoth: Charles Dang website:master 1a7776fe8eb6 / eclipse.wesnoth.org/ (css/main.css img/decor.png index.html): eclipse.w.o: redesigned main page in the new Wesmere style https://github.com/wesnoth/website/commit/1a7776fe8eb6513120fabe2fd75f84f8525d35fd 20180306 00:21:15< irker531> wesnoth: Charles Dang website:master ec6a16dd5b8d / eclipse.wesnoth.org/ (download.html features.html): eclipse.w.o: removed unused sub-pages https://github.com/wesnoth/website/commit/ec6a16dd5b8df7bcc17306c0e6a421904987c91c 20180306 00:21:17< irker531> wesnoth: Charles Dang website:master e3745e950856 / eclipse.wesnoth.org/index.html: eclipse.w.o: dropped Google Analytics script https://github.com/wesnoth/website/commit/e3745e950856eb8ac589e115d3c178acefbe6946 20180306 00:21:19< irker531> wesnoth: Charles Dang website:master c23eb2ee15d8 / eclipse.wesnoth.org/ (css/main.css download.html features.html img/decor.png index.html): Merge pull request #2 from wesnoth/develop https://github.com/wesnoth/website/commit/c23eb2ee15d841502a4ddaad54bc3a2a81743848 20180306 00:24:32< irker531> wesnoth: Charles Dang website:master 495666d57538 / README.md gettext.wesnoth.org/includes/wesmere.php: https two things https://github.com/wesnoth/website/commit/495666d575386efefca63671e0ae723d4ad59755 20180306 00:33:37< irker531> wesnoth: Iris Morelle website:master 94e5583d1ae8 / eclipse.wesnoth.org/css/main.css: eclipse.w.o: CSS cleanup https://github.com/wesnoth/website/commit/94e5583d1ae83c97cbba44ea3064769cdd2c73a9 20180306 00:33:40< irker531> wesnoth: Iris Morelle website:master 977579cb1a32 / eclipse.wesnoth.org/index.html: eclipse.w.o: Better img alt-text https://github.com/wesnoth/website/commit/977579cb1a320ba877b284ee3e273e8c58390a4f 20180306 00:49:32-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev 20180306 00:54:37-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180306 00:54:46-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180306 00:58:28< irker531> wesnoth: Iris Morelle wesnoth:master 0220cb00f701 / data/core/ (about.cfg about_i18n.cfg): Renamed my wiki account the other day https://github.com/wesnoth/wesnoth/commit/0220cb00f70156535535c016eff9aa6ca0569b3a 20180306 00:58:37-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection] 20180306 01:03:10< shadowm> Is #2592 acceptable for 1.14 or did it miss the train? 20180306 01:04:26< celticminstrel> IMO it's acceptable. 20180306 01:06:56< shadowm> Anything else that might be needed before merging? 20180306 01:08:02< celticminstrel> I can't think of anything. It looks pretty simple and straightforward. 20180306 01:08:14< irker531> wesnoth/wesnoth:master Gregory A Lundberg d24521989d Fix missing explicit keyword AppVeyor: 1/6 builds failed 20180306 01:08:15< irker531> Details vs2015/Debug: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-1712 20180306 01:14:18-!- Bonobo [~Bonobo@61.68.207.231] has joined #wesnoth-dev 20180306 01:21:19-!- Ravana_ [~Ravana@unaffiliated/ravana/x-2327071] has quit [Ping timeout: 260 seconds] 20180306 01:26:38< irker531> wesnoth: Iris Morelle wesnoth:master 957fdc8bbd7c / src/campaign_server/campaign_server.cpp: campaignd: Allow overwriting add-on attributes through the control FIFO https://github.com/wesnoth/wesnoth/commit/957fdc8bbd7c5999b65c2de388c9098faaf151af 20180306 01:27:50-!- sevu [~Shiki@p5485478D.dip0.t-ipconnect.de] has joined #wesnoth-dev 20180306 01:30:04-!- Ravana_ [~Ravana@unaffiliated/ravana/x-2327071] has joined #wesnoth-dev 20180306 01:31:23< shadowm> Eh. 20180306 01:31:29< shadowm> Why is my game cache dir full of directories? 20180306 01:31:42< sevu> was a bug 20180306 01:32:07< shadowm> This? https://pastebin.com/WJswfxSq 20180306 01:32:26< sevu> test 20180306 01:32:46< shadowm> It makes the cache manager dialog sad since I don't think I wrote the cleanup/purge code with subdirectories in mind. 20180306 01:32:46< sevu> ahh I can't start senctences with / in irc of 20180306 01:33:12< shadowm> (Probably on purpose since I mightn't have wanted to destroy user files that could somehow end up moved there.) 20180306 01:33:21< sevu> / could have been part of the random generated name at some point in 1.13 20180306 01:33:22< shadowm> / is how you start commands on IRC, yeah. 20180306 01:33:28< shadowm> Ahh. 20180306 01:35:04< shadowm> Ohhhh yes, new UI sounds that don't feel like someone's drilling into my ear drums. 20180306 01:35:19< shadowm> ty vul 20180306 01:35:26< shadowm> vul... 20180306 01:36:21-!- vultraz [uid24821@wesnoth/developer/vultraz] has joined #wesnoth-dev 20180306 01:36:23< vultraz> *returns* 20180306 01:36:30< shadowm> Ohhhh yes, new UI sounds that don't feel like someone's drilling into my ear drums. 20180306 01:37:47< DeFender1031> vultraz, celticminstrel, "retired" for level 3? 20180306 01:37:51< celticminstrel> Since when were there new UI sounds... o.o 20180306 01:37:59< vultraz> I just committed a few new ones the other day 20180306 01:38:07< celticminstrel> DeFender1031: I went with for_removal but we could still change it. 20180306 01:38:12< vultraz> new turn bell, click sounds, and help expand/contract sounds 20180306 01:38:13< celticminstrel> "the other day" 20180306 01:38:20< celticminstrel> Yeah that tells precisely nothing. :P 20180306 01:38:25< celticminstrel> I see... 20180306 01:39:08< vultraz> tun bell still seems rather loud 20180306 01:39:19< vultraz> but maybe i just have my volume too high 20180306 01:40:43< DeFender1031> IIRC, in 1.12 the turn bell didn't respect any of the volume controls other than the master one 20180306 01:40:51< DeFender1031> I dunno if that was ever fixed 20180306 01:41:02< shadowm> Haven't checked out the new turn bell yet. 20180306 01:46:05< vultraz> it's more of a frooom than a boom 20180306 01:46:11< vultraz> now 20180306 01:47:40< shadowm> I don't know how I feel about it. 20180306 01:48:06< shadowm> It wasn't actually a bell before, but it was closer to the term than the new sound. 20180306 01:55:19< vultraz> "1.15. Rename Turn Bell "Turn Gong"" :P 20180306 01:58:39< shadowm> It's not a gong either. 20180306 01:58:51< shadowm> It used to be, though. 20180306 01:59:14< irker531> wesnoth: Charles Dang wesnoth:master 8ef639d60c61 / src/editor/palette/tristate_button.cpp: Editor/Tristate Button: don't try to draw text, this widget has no text https://github.com/wesnoth/wesnoth/commit/8ef639d60c614fb522cd77d4a8926fcd39942ea2 20180306 01:59:17< irker531> wesnoth: Charles Dang wesnoth:master e35916ffd02b / src/help/help_topic_generators.cpp: Help Browser: ensure space under portraits if text overflows under them https://github.com/wesnoth/wesnoth/commit/e35916ffd02bf57fcd45ce40a83fab68be1b5067 20180306 02:00:48< irker531> wesnoth: Iris Morelle wesnoth:master 8c642e204495 / / (4 files in 3 dirs): campaignd: Add support for free-form tags on add-ons https://github.com/wesnoth/wesnoth/commit/8c642e2044956fe962019255cdbdc059d25accfa 20180306 02:03:11< irker531> wesnoth: Iris Morelle wesnoth:master f2f3377e11d9 / changelog: Update changelog https://github.com/wesnoth/wesnoth/commit/f2f3377e11d9dcc833a6075635fc5d9fa20f6405 20180306 02:07:43< irker531> wesnoth: Charles Dang wesnoth:master 79cf3c4785f6 / src/editor/palette/ (tristate_button.cpp tristate_button.hpp): Fixup 8ef639d60c61 (removed unused variables/members) https://github.com/wesnoth/wesnoth/commit/79cf3c4785f6abeabd79615155c6549ca6c0c202 20180306 02:19:13-!- travis-ci [~travis-ci@54.224.23.145] has joined #wesnoth-dev 20180306 02:19:14< travis-ci> wesnoth/wesnoth#16747 (master - e35916f : Charles Dang): The build was broken. 20180306 02:19:14< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/349609706 20180306 02:19:14-!- travis-ci [~travis-ci@54.224.23.145] has left #wesnoth-dev [] 20180306 02:21:26-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!] 20180306 02:32:03< irker531> wesnoth: Charles Dang wesnoth:master f6cb0f314f83 / src/editor/palette/tristate_button.cpp: Fixup 8ef639d60c61 again https://github.com/wesnoth/wesnoth/commit/f6cb0f314f83d26f30d2583fd2234c9b4be2bd30 20180306 02:34:00< shadowm> AI0867: Don't forget to update https://wiki.wesnoth.org/PblWML#icon with anything you have to say about the feature you just added and merged. 20180306 02:34:25< shadowm> And https://wiki.wesnoth.org/ImagePathFunctionWML , probably. I haven't read the finalized specifics yet. 20180306 02:35:37< irker531> wesnoth: Iris Morelle wesnoth:master 390df50ebc92 / RELEASE_NOTES: Update release notes https://github.com/wesnoth/wesnoth/commit/390df50ebc92a07918a57dbc8316a752941c76ba 20180306 02:35:41-!- travis-ci [~travis-ci@ec2-54-227-87-168.compute-1.amazonaws.com] has joined #wesnoth-dev 20180306 02:35:42< travis-ci> wesnoth/wesnoth#16749 (master - 79cf3c4 : Charles Dang): The build was broken. 20180306 02:35:42< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/349612047 20180306 02:35:42-!- travis-ci [~travis-ci@ec2-54-227-87-168.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180306 02:52:20-!- travis-ci [~travis-ci@ec2-54-224-23-145.compute-1.amazonaws.com] has joined #wesnoth-dev 20180306 02:52:21< travis-ci> wesnoth/wesnoth#16750 (master - f6cb0f3 : Charles Dang): The build failed. 20180306 02:52:21< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/349617711 20180306 02:52:21-!- travis-ci [~travis-ci@ec2-54-224-23-145.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180306 02:53:23< irker531> wesnoth: Celtic Minstrel wesnoth:schema c8ab199ad344 / / (44 files in 10 dirs): Implement validation of the core game config WML https://github.com/wesnoth/wesnoth/commit/c8ab199ad344ff3ce90694d844bf0ff24d27c6b6 20180306 02:53:25< irker531> wesnoth: Celtic Minstrel wesnoth:schema 520ee2d1d7b6 / data/schema/core/addons.cfg: Address some feedback https://github.com/wesnoth/wesnoth/commit/520ee2d1d7b64995dae6ddd3fe077b9220003e18 20180306 02:53:27< irker531> wesnoth: Celtic Minstrel wesnoth:schema 67fd5d75aaa5 / data/schema/ (core/config.cfg game_config.cfg terrain/graphics.cfg): Address a few TODO notes https://github.com/wesnoth/wesnoth/commit/67fd5d75aaa549337d7e7d073cd0c8b43b47ae25 20180306 02:53:29< irker531> wesnoth: Celtic Minstrel wesnoth:schema 5d39e30f954b / data/gui/schema.cfg data/schema/gui.cfg src/gui/gui.cpp: Move GUI2 schema into the schema directory https://github.com/wesnoth/wesnoth/commit/5d39e30f954b08061cb17dfd1f566064bb51c093 20180306 02:53:31< irker531> wesnoth: Celtic Minstrel wesnoth:schema 5049c570445f / / (5 files in 3 dirs): Get game config and schema to use some common types https://github.com/wesnoth/wesnoth/commit/5049c570445f4ad180a59881f273e5d04872da1a 20180306 02:53:33< irker531> wesnoth: Celtic Minstrel wesnoth:schema 615388792fb6 / data/core/units/ (dwarves/Thunderer.cfg monsters/Water_Serpent.cfg): Fix incorrect filter for Thunderer victory animation https://github.com/wesnoth/wesnoth/commit/615388792fb69f4bf72cd375a339faf4ccfba3ba 20180306 03:11:00< celticminstrel> Apparently the forum will delete half of your post if it discovers mismatched or too-deeply-nested tags. 20180306 03:11:37< celticminstrel> That seems like a pretty obvious bug. It should probably give you an error (not allowing the post through) and give back the markup you used. 20180306 03:12:00< celticminstrel> I guess it's probably not something we can do anything about besides filing a bug with phpbb though... 20180306 03:13:22< vultraz> shadowm would know what to do 20180306 03:26:16< shadowm> celticminstrel: Can you pastebin an example? 20180306 03:26:37< celticminstrel> I'll try to contruct something. 20180306 03:29:25< celticminstrel> shadowm: With this, if I click preview the second quote is gone. https://pastebin.com/Utj1N4MC 20180306 03:29:37< celticminstrel> (Of course, clicking post has the same effect too.) 20180306 03:29:48< celticminstrel> s/post/submit/ 20180306 03:32:49-!- travis-ci [~travis-ci@ec2-54-224-23-145.compute-1.amazonaws.com] has joined #wesnoth-dev 20180306 03:32:50< travis-ci> wesnoth/wesnoth#16751 (schema - 6153887 : Celtic Minstrel): The build failed. 20180306 03:32:50< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/349622499 20180306 03:32:50-!- travis-ci [~travis-ci@ec2-54-224-23-145.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180306 03:32:59< celticminstrel> Aww. 20180306 03:33:28< celticminstrel> Oh -Wreorder. 20180306 03:33:37< celticminstrel> That's pretty minor then. 20180306 03:33:45< celticminstrel> (Will fix eventually of course.) 20180306 03:33:57< vultraz> last should be cherry-picked 20180306 03:34:31< shadowm> celticminstrel: The new parser is a bit funny about closing tags and it will assume their presence in some cases even when they aren't actually there. 20180306 03:34:35< celticminstrel> That's what I said too. 20180306 03:34:47< shadowm> As for the quotes disappearing, it's because the maximum quote nesting is currently set to 2. 20180306 03:35:08< celticminstrel> shadowm: Well, in this case I'd say the issue is that it strips out the too-deep quotes rather than informing the user about them. 20180306 03:35:19< shadowm> I believe this has always been the case. 20180306 03:35:32< celticminstrel> Pretty sure it used to give an error message at some point in the past. 20180306 03:35:53< celticminstrel> In any case it shouldn't do it until submit. Preview should leave your text unchanged. 20180306 03:37:29< shadowm> Mhm. 20180306 03:37:58< vultraz> it always always the case 20180306 03:38:04< shadowm> Can't test your theory without rolling back my test database and firing up a VM celmin. 20180306 03:38:13< vultraz> there was never any error 20180306 03:38:19 * celticminstrel could possibly be remembering phpbb2. 20180306 03:39:04< shadowm> I can at least confirm from looking at an old dump I have on my desktop that max_quote_depth has never stopped being 2. 20180306 03:39:23< celticminstrel> Though I think it's more likely that I'm remembering whatever it was at before the recent upgrade. 20180306 03:39:51< shadowm> phpBB 3.0.14. 20180306 03:39:53< DeFender1031> is there a reason to disallow deeper quotes? 20180306 03:40:06< celticminstrel> They clutter posts up a lot. 20180306 03:40:18< celticminstrel> Maybe there are other reasons too. 20180306 03:41:15< shadowm> I'll ask Pent what he thinks about raising the nesting limit. 20180306 03:41:43< celticminstrel> Well, raising the limit won't solve this issue; only removing it would. And I assume there are good reasons not to do that. 20180306 03:42:32< shadowm> I could send you a PM with million nested quotes if you want. :P 20180306 03:42:37< shadowm> *with a 20180306 03:42:45< celticminstrel> XD 20180306 03:43:19< shadowm> Also anything about the text parser is beyond my control. Or beyond phpBB's really, since it's not even strictly part of phpBB. 20180306 03:43:23< celticminstrel> I mean, I guess making it a high limit like 10 or so would also more or less eliminate the issue, but I assume there are also reasons not to make it that high. 20180306 03:43:30< shadowm> They use s9y\TextFormatter these days. 20180306 03:44:00< shadowm> *s9e\TextFormatter 20180306 03:44:20< shadowm> s9y is an entirely different thing that I use on my own website, mechanical memory at work right there. 20180306 03:53:56-!- sevu [~Shiki@p5485478D.dip0.t-ipconnect.de] has quit [Remote host closed the connection] 20180306 04:27:55< irker531> wesnoth/wesnoth:master sigurdfdragon 987ab24453 NR S12a & 13a: Fix Sisal handling AppVeyor: All builds passed 20180306 04:48:15-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The computer falls into a deep sleep, to awake again some other day!] 20180306 05:12:39-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180306 05:12:45-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180306 05:34:43< shadowm> On 1.12 [objective][show_if] can take more than one conditional statement and implicitly AND them all, right? 20180306 05:35:29< shadowm> The code just says wesnoth.eval_conditional(show_if). 20180306 05:36:14< shadowm> The documentation seems to indicate it'll evaluate the contents like I said... 20180306 06:11:54-!- vladimirslavik [~vslavik@95.82.135.184] has joined #wesnoth-dev 20180306 06:38:08< irker531> wesnoth: Charles Dang wesnoth:master a46ddf9bcd99 / src/game_events/manager.cpp: Game Events: don't write disabled events to config https://github.com/wesnoth/wesnoth/commit/a46ddf9bcd991b13c1c6ca19985b84b76a660ce8 20180306 06:58:03-!- travis-ci [~travis-ci@ec2-54-227-87-168.compute-1.amazonaws.com] has joined #wesnoth-dev 20180306 06:58:04< travis-ci> wesnoth/wesnoth#16753 (master - a46ddf9 : Charles Dang): The build is still failing. 20180306 06:58:05< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/349673773 20180306 06:58:05-!- travis-ci [~travis-ci@ec2-54-227-87-168.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180306 07:40:24-!- JyrkiVesterinen [~JyrkiVest@195-192-251-124.s1networks.fi] has joined #wesnoth-dev 20180306 07:48:06-!- Oebele [~quassel@143.177.58.202] has joined #wesnoth-dev 20180306 07:51:59< irker531> wesnoth/wesnoth:master Celtic Minstrel 5944294164 Fix incorrect filter for Thunderer victo AppVeyor: vs2017/Release Failed 20180306 07:52:00< irker531> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-master-1428 20180306 08:06:50< shadowm> https://cdn.discordapp.com/attachments/312332571834843137/420490693572689920/unknown.png 20180306 08:07:07< shadowm> This is a fun thing I'll have to watch out for *if* I ever get around to porting my add-ons to 1.14. 20180306 08:08:04< shadowm> I hope there's a way to get the old behaviour somehow. 20180306 08:08:44< shadowm> Neither UnitTypeWML nor AnimationWML make me particularly optimistic about the situation. 20180306 08:25:03< AI0867> shadowm: the data URI isn't really an IPF. It replaces the non-IPF part of the path. I'm not really sure where I in the wiki I should put it 20180306 08:25:24< shadowm> PblWML then or something. 20180306 08:25:54< shadowm> At the very least it requires a pointer from there to wherever it'll be properly documented, since that's going to be its primary use case for now. 20180306 08:27:42-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20180306 08:41:48-!- EliDupree [~quassel@2604:a880:400:d0::9bb:2001] has quit [Quit: No Ping reply in 180 seconds.] 20180306 08:43:36-!- EliDupree [~quassel@2604:a880:400:d0::9bb:2001] has joined #wesnoth-dev 20180306 08:57:32< irker531> wesnoth/wesnoth:master Celtic Minstrel 5944294164 Fix incorrect filter for Thunderer victo AppVeyor: 2/6 builds failed 20180306 08:57:33< irker531> Details vs2017/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-master-1428 20180306 08:57:34< irker531> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-1723 20180306 09:37:02< irker531> wesnoth/wesnoth:master Charles Dang a46ddf9bcd Game Events: don't write disabled events AppVeyor: vs2013/Debug Failed 20180306 09:37:03< irker531> Details: https://ci.appveyor.com/project/wesnoth/wesnoth/build/Wesnoth-VS2013-master-1736 20180306 10:31:30< irker531> wesnoth/wesnoth:master Iris Morelle 390df50ebc Update release notes AppVeyor: All builds passed 20180306 10:32:18-!- JyrkiVesterinen [~JyrkiVest@195-192-251-124.s1networks.fi] has quit [Quit: .] 20180306 10:46:24-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev 20180306 11:13:25-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180306 11:26:35-!- JyrkiVesterinen [~JyrkiVest@195-192-251-124.s1networks.fi] has joined #wesnoth-dev 20180306 12:14:23< irker531> wesnoth/wesnoth:master Charles Dang a46ddf9bcd Game Events: don't write disabled events AppVeyor: 1/6 builds failed 20180306 12:14:24< irker531> Details vs2013/Debug: https://ci.appveyor.com/project/wesnoth/wesnoth/build/Wesnoth-VS2013-master-1736 20180306 12:55:01-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity] 20180306 14:19:43-!- Oebele [~quassel@143.177.58.202] has quit [Remote host closed the connection] 20180306 14:34:13< irker531> wesnoth: Gregory A Lundberg wesnoth:master eb39fa302232 / src/editor/palette/tristate_button.cpp: Remove ununsed const variable https://github.com/wesnoth/wesnoth/commit/eb39fa3022324b96fbee2aef1cd25e9597e28641 20180306 14:55:28-!- Oebele [~quassel@143.177.58.202] has joined #wesnoth-dev 20180306 14:56:06-!- vultraz [uid24821@wesnoth/developer/vultraz] has quit [Quit: Connection closed for inactivity] 20180306 15:06:10-!- JyrkiVesterinen [~JyrkiVest@195-192-251-124.s1networks.fi] has quit [Quit: .] 20180306 15:46:52-!- Bonobo [~Bonobo@61.68.207.231] has quit [Ping timeout: 260 seconds] 20180306 16:02:28-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180306 16:02:34-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180306 16:15:07-!- mkdroid [~null@unaffiliated/matthiaskrgr] has joined #wesnoth-dev 20180306 16:35:27-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!] 20180306 16:40:35< irker531> wesnoth/wesnoth:master Gregory A Lundberg eb39fa3022 Remove ununsed const variable AppVeyor: vs2015/Release Failed 20180306 16:40:36< irker531> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-1725 20180306 16:42:59-!- mkdroid [~null@unaffiliated/matthiaskrgr] has quit [Quit: I'll be back!] 20180306 16:50:53-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180306 16:51:27-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180306 16:58:51-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180306 16:59:28-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180306 17:23:18-!- vultraz [uid24821@wesnoth/developer/vultraz] has joined #wesnoth-dev 20180306 17:50:11-!- atarocch_ [~atarocch@93.56.164.28] has quit [Ping timeout: 245 seconds] 20180306 18:05:30< irker531> wesnoth/wesnoth:master Gregory A Lundberg eb39fa3022 Remove ununsed const variable AppVeyor: 1/6 builds failed 20180306 18:05:31< irker531> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-1725 20180306 18:20:28-!- atarocch_ [~atarocch@93.56.164.28] has joined #wesnoth-dev 20180306 18:33:27-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180306 18:33:37-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180306 18:35:17-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180306 18:43:51< irker531> wesnoth/wesnoth:master lundberg 827ccaae03 Update VS projectfile for crypt_blowfish AppVeyor: vs2013/Release Failed 20180306 18:43:52< irker531> Details: https://ci.appveyor.com/project/wesnoth/wesnoth/build/Wesnoth-VS2013-master-1739 20180306 18:45:52-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!] 20180306 18:51:32-!- sevu [~Shiki@p54855CB4.dip0.t-ipconnect.de] has joined #wesnoth-dev 20180306 18:52:43< irker531> wesnoth: Jyrki Vesterinen wesnoth:master 67e292704400 / changelog src/network_asio.cpp: Network_asio: split upload buffer to 4kB chunks https://github.com/wesnoth/wesnoth/commit/67e292704400901e66720b269d45094a7351251c 20180306 18:53:41-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has joined #wesnoth-dev 20180306 18:56:44-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev 20180306 19:16:32-!- vladimirslavik [~vslavik@95.82.135.184] has quit [Quit: Leaving] 20180306 19:17:50< irker531> wesnoth: Charles Dang wesnoth:master 078f61c412d7 / / (5 files in 3 dirs): Removed unused GUI1 label widget https://github.com/wesnoth/wesnoth/commit/078f61c412d770af984d13378cede51184fe6424 20180306 19:24:13-!- gfgtdf [~chatzilla@x4e363548.dyn.telefonica.de] has joined #wesnoth-dev 20180306 19:25:38< gfgtdf> shadowm: that was discussed and changed quite some time ago https://forums.wesnoth.org/viewtopic.php?f=12&t=40862 20180306 19:30:02< shadowm> Bleh. 20180306 19:31:31< shadowm> I might look into it following lipkab's lead at the end, since otherwise this is going to be a royal PITA in AtS E3. 20180306 19:32:39< shadowm> Alternatively I hope it's possible to cheat the engine by using an empty 72x72 baseframe with a larger secondary frame serving as the real one. 20180306 19:33:32< gfgtdf> you mean you want to implement the wml configurable bar position as lipk said the his past post ? 20180306 19:33:45< shadowm> Yeah. 20180306 19:41:23< vultraz> the code you want is in `unit/drawer.cpp` if you do 20180306 20:10:33-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev 20180306 20:22:46< irker531> wesnoth/wesnoth:master lundberg 827ccaae03 Update VS projectfile for crypt_blowfish AppVeyor: 3/6 builds failed 20180306 20:22:47< irker531> Details vs2013/Release: https://ci.appveyor.com/project/wesnoth/wesnoth/build/Wesnoth-VS2013-master-1739 20180306 20:22:48< irker531> Details vs2017/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-master-1432 20180306 20:22:49< irker531> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-1727 20180306 21:01:23-!- octalot [~steve@178.115.128.147.wireless.dyn.drei.com] has joined #wesnoth-dev 20180306 21:05:53-!- Oebele [~quassel@143.177.58.202] has quit [Remote host closed the connection] 20180306 21:13:17< irker531> wesnoth: gfgtdf wesnoth:gfgtdf-fix_2604 150cfe085c5c / src/game_initialization/create_engine.cpp: don't generate [side]s if the [multiplayer] has at least one [side] defined. https://github.com/wesnoth/wesnoth/commit/150cfe085c5c10925b5605b3f47f21e70beda664 20180306 21:14:41< gfgtdf> anyone an opinion on #2605 ? i don't really know why we generate [side]s in the first place there so i'm not 100% sure on this change. 20180306 21:21:39< zookeeper> you mean aside from the reason in the preceding comment? 20180306 21:22:14-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has quit [Quit: .] 20180306 21:36:07< irker531> wesnoth: gfgtdf wesnoth:gfgtdf-fix_2604-2 00ac604e395d / src/game_initialization/flg_manager.cpp: fix no_leader having no effect https://github.com/wesnoth/wesnoth/commit/00ac604e395d1868a262d8e4722fc596cee8252e 20180306 21:36:21-!- travis-ci [~travis-ci@ec2-54-197-141-236.compute-1.amazonaws.com] has joined #wesnoth-dev 20180306 21:36:22< travis-ci> wesnoth/wesnoth#16758 (master - 078f61c : Charles Dang): The build was broken. 20180306 21:36:22< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/349973700 20180306 21:36:22-!- travis-ci [~travis-ci@ec2-54-197-141-236.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180306 21:40:26< gfgtdf> zookeeper: that comment just said what it does (which it obvious) not why it does that. 20180306 21:42:22< zookeeper> presumably so that you don't need to hardcode the number of sides in the scenario WML and match them with the map data, if all you want is a reasonably generic scenario? 20180306 21:42:55< zookeeper> might be that creating a game from a map (and not a scenario) ends up going through that code, too. 20180306 21:44:51< gfgtdf> zookeeper: hmm the later woudl be untouched by my commit, the first woudl be changed though 20180306 21:45:19< gfgtdf> on the other hand the old code prevent people fro reouing the same mapdate in multiple scenarios as noted in the bugreport 20180306 21:46:12< gfgtdf> and look at this, these boolena parmater names don't matcn the functionaity at all https://github.com/wesnoth/wesnoth/blob/master/src/game_initialization/flg_manager.hpp#L31 , https://github.com/wesnoth/wesnoth/blob/master/src/game_initialization/flg_manager.cpp#L33 20180306 21:47:35< zookeeper> yeah i don't know anything, just guessing. 20180306 21:49:34< gfgtdf> any opinion on deprecating no_leader? omiting type= and setting leader_lock=yes has probably the same effect . 20180306 21:51:13< irker531> wesnoth: gfgtdf wesnoth:gfgtdf-fix_2604-2 0b89dac7f60b / src/game_initialization/flg_manager.hpp: fix parmaeternames and remove some useless const. https://github.com/wesnoth/wesnoth/commit/0b89dac7f60bbb0257fa155ba1c8656077e80729 20180306 21:53:03< gfgtdf> does c++ have a &&= operator (a &&=b woudl be equivalent to a = a &&b), it would make sense but i have never seen it. 20180306 21:55:24< zookeeper> gfgtdf, no_leader=yes is a whole lot clearer than leader_lock=yes 20180306 21:56:39< gfgtdf> zookeeper: but the whole thing apples only to mp anyways, in sp no_leader has no effect. (just omit type=) 20180306 21:56:51< zookeeper> ...it doesn't? 20180306 21:56:58< zookeeper> this is new to me 20180306 21:59:36< irker531> wesnoth: gfgtdf wesnoth:gfgtdf-fix_2604-2 d141be47ea81 / src/game_initialization/flg_manager.cpp: preserve leader_lock if no type= is given https://github.com/wesnoth/wesnoth/commit/d141be47ea815b49352a9243d06c8fa9ae69c892 20180306 22:01:57< gfgtdf> zookeeper: yes it was changed somewhere in 1.13 20180306 22:12:36-!- travis-ci [~travis-ci@ec2-54-81-184-141.compute-1.amazonaws.com] has joined #wesnoth-dev 20180306 22:12:37< travis-ci> wesnoth/wesnoth#16759 (gfgtdf-fix_2604 - 150cfe0 : gfgtdf): The build failed. 20180306 22:12:37< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/350023393 20180306 22:12:37-!- travis-ci [~travis-ci@ec2-54-81-184-141.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180306 22:21:17-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180306 22:21:23-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180306 22:53:14-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection] 20180306 23:04:07-!- gfgtdf [~chatzilla@x4e363548.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.93 [Firefox 52.6.0/20180118122319]] 20180306 23:06:02-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev 20180306 23:07:12< mattsc> Hi, All. 20180306 23:08:07< mattsc> celmin: yeah, unfortunately I am barely around these days. I did just check the backstab bug #2247 though and it looks fixed. 20180306 23:08:38-!- travis-ci [~travis-ci@ec2-54-196-183-40.compute-1.amazonaws.com] has joined #wesnoth-dev 20180306 23:08:39< travis-ci> wesnoth/wesnoth#16765 (gfgtdf-fix_2604-2 - d141be4 : gfgtdf): The build failed. 20180306 23:08:39< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/350043206 20180306 23:08:39-!- travis-ci [~travis-ci@ec2-54-196-183-40.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180306 23:09:11< mattsc> Besides that, to those of you who fixed the Xcode build and set up the dependencies script: thank you, that’s really nice! 20180306 23:09:14-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity] 20180306 23:09:52< mattsc> I do now get the following “look” though: https://imgur.com/a/eRdOc 20180306 23:10:10< mattsc> with most text being largely grayed out 20180306 23:10:57< mattsc> Is this something that’s been seen? Sorry if it’s been discussed, as I said, I’ve not been around and I don’t have time to check the logs. 20180306 23:13:23< mattsc> I don’t know if this is a problem with my build (and the libraries I am now using after using the new script for the first time), or a more general problem. The official 1.13.11 build doesn’t have this issue. 20180306 23:17:55< mattsc> (I also get an error, followed by Wesnoth shutting down, when starting the test scenario from the CL, but I assume that one is known.) 20180306 23:40:20-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180306 23:40:27-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180306 23:44:27-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: So long and thanks for all the fish.] --- Log closed Wed Mar 07 00:00:38 2018