--- Log opened Fri Mar 09 00:00:29 2018
20180309 00:05:12-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180309 00:05:22-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20180309 00:37:26< irker845> wesnoth: Charles Dang wesnoth:master 33725add8fa3 / data/ai/ (6 files in 3 dirs): Data/AI: wmlindent run https://github.com/wesnoth/wesnoth/commit/33725add8fa3a4fb2c4de149a03c67376a5bd0a1
20180309 00:37:29< irker845> wesnoth: Charles Dang wesnoth:master 0cb9f0d622cd / data/test/ (18 files in 6 dirs): Data/Test: wmlindent run https://github.com/wesnoth/wesnoth/commit/0cb9f0d622cd776fc6fc8ee581e0b84bf019a46b
20180309 00:37:32< irker845> wesnoth: Charles Dang wesnoth:master 471c9e876a1f / / (138 files in 65 dirs): Addressed a large chunk of the whitespace issues from #2613 https://github.com/wesnoth/wesnoth/commit/471c9e876a1f25a29d0f8f791efa1c3d7ae82e83
20180309 00:59:44-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20180309 02:07:08-!- octalot [~steve@77.119.130.132.wireless.dyn.drei.com] has quit [Ping timeout: 256 seconds]
20180309 02:18:15-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20180309 03:38:18-!- irker845 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20180309 03:47:53-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180309 03:47:59-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20180309 03:59:03-!- irker575 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20180309 03:59:03< irker575> wesnoth/wesnoth:master Charles Dang 471c9e876a Addressed a large chunk of the whitespac AppVeyor: All builds passed
20180309 04:02:47-!- Bonobo [~Bonobo@203.111.185.228] has quit [Ping timeout: 268 seconds]
20180309 04:15:56-!- deathisundead [~quassel@2601:40a:c380:462:744f:9a29:9fa:e0f1] has joined #wesnoth-dev
20180309 04:18:49-!- deathisundead_ [~quassel@2601:40a:c380:462:744f:9a29:9fa:e0f1] has quit [Ping timeout: 252 seconds]
20180309 04:23:28-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The computer falls into a deep sleep, to awake again some other day!]
20180309 04:25:55< shadowm> Let's say I have the following code: { config& cfg = parent.find_child("node", "attrkey", "attrvalue"); /* ... */ parent.remove_child("node", n); }
20180309 04:26:14< shadowm> Where n is the correct index for cfg in its parent.
20180309 04:26:24< shadowm> Exactly what happens if cfg is accessed afterwards?
20180309 04:27:01< shadowm> Does this make cfg a dangling reference?
20180309 04:28:07< shadowm> (My gut feeling is, yes, it does become a dangling reference, but I'm not 100% sure if there's some special magic going on behind the scenes for config objects.)
20180309 04:30:33< vultraz> Very likely yes, it becomes a dangling reference
20180309 04:30:49< vultraz> The does does nothing especially special 
20180309 04:31:26< shadowm> I found this pattern in campaignd::server::handle_delete(), which I'm trying to refactor to enable deleting add-ons using the control FIFO.
20180309 04:32:13< shadowm> But technically the dangling reference is never used after it becomes such, so I *believe* it does not count as UB?
20180309 04:33:15< shadowm> I'm somewhat concerned because it'll cross a function call boundary after the refactoring, though.
20180309 04:33:58< shadowm> At least the way I was originally going to go about it, anyway.
20180309 04:34:45< vultraz> What about using a pointer
20180309 04:35:54< shadowm> You know I'm not a fan of gratuitous pointer usage.
20180309 04:36:19< vultraz> I do not know this.
20180309 04:36:29< shadowm> Uhhhh yes you do.
20180309 04:36:36-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20180309 04:36:43< shadowm> I made it very clear back when I was "teaching" you C++.
20180309 04:37:10< shadowm> (Note: using a very loose definition of the term here.)
20180309 04:37:24< vultraz> But in this case, it does't seem gratuitous at all
20180309 04:40:54< vultraz> or if you really need to preserve the remove campaign's data after removal, swap it into anew config
20180309 04:41:34< shadowm> That's the thing, the whole point is that it needs to be discarded.
20180309 04:41:46< shadowm> But I need to pass the config into the method.
20180309 04:42:36< vultraz> local scope?
20180309 04:42:40< shadowm> Maybe I need to rethink this so that the config doesn't need to be known to the caller.
20180309 04:42:40< vultraz> use*
20180309 04:42:52< shadowm> But the flipping authentication system gets in the way.
20180309 04:43:19< shadowm> One caller needs the config to authenticate the user, the other won't need it because the command comes from a trusted source.
20180309 04:47:30-!- Bonobo [~Bonobo@129.127.113.140] has joined #wesnoth-dev
20180309 05:31:27-!- Bonobo [~Bonobo@129.127.113.140] has quit [Ping timeout: 240 seconds]
20180309 06:24:46-!- deathisundead_ [~quassel@2601:40a:c380:462:6846:845c:b57a:4b9a] has joined #wesnoth-dev
20180309 06:26:51-!- deathisundead [~quassel@2601:40a:c380:462:744f:9a29:9fa:e0f1] has quit [Ping timeout: 245 seconds]
20180309 06:45:40-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity]
20180309 07:01:14-!- irker575 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20180309 07:32:38-!- JyrkiVesterinen [~JyrkiVest@195-192-251-124.s1networks.fi] has joined #wesnoth-dev
20180309 08:04:30< Soliton> you could make the scope so that the config ref goes out of scope right after the remove_child.
20180309 08:04:45< vultraz> That's what I suggested.
20180309 08:11:52-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Quit: Caught sigterm, terminating...]
20180309 08:12:14-!- Ivanovic [~ivanovic@p579FBA67.dip0.t-ipconnect.de] has joined #wesnoth-dev
20180309 08:12:15-!- Ivanovic [~ivanovic@p579FBA67.dip0.t-ipconnect.de] has quit [Changing host]
20180309 08:12:15-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev
20180309 09:06:26-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20180309 09:38:18-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20180309 10:27:58-!- EliDupree [~quassel@2604:a880:400:d0::9bb:2001] has quit [Quit: No Ping reply in 180 seconds.]
20180309 10:30:05-!- EliDupree [~quassel@2604:a880:400:d0::9bb:2001] has joined #wesnoth-dev
20180309 10:30:46-!- JyrkiVesterinen [~JyrkiVest@195-192-251-124.s1networks.fi] has quit [Quit: .]
20180309 10:39:34-!- vladimirslavik [vslavik@nat/redhat/x-njuxrbkrkciyodzg] has joined #wesnoth-dev
20180309 11:03:09< vn971> hmm, can I create a unit without having any user-visible Era ?
20180309 11:03:23< vultraz> what?
20180309 11:04:45< vn971> vultraz: I want to create a unit in a "scenario" add-on, without polluting user-s Era list with an Era consisting of 1 unit.
20180309 11:05:22< vultraz> just include the [unit_type] under [units] in your _main.cfg
20180309 11:05:31< vn971> vultraz: thanks!
20180309 11:26:09-!- JyrkiVesterinen [~JyrkiVest@195-192-251-124.s1networks.fi] has joined #wesnoth-dev
20180309 12:59:02< zookeeper> vultraz, new strings required for #1677 how? for the temporary filenames?
20180309 12:59:23< vultraz> I wanted to add a confirmation popup
20180309 13:00:08< zookeeper> to warn of current behavior?
20180309 13:00:48< vultraz> yes
20180309 13:03:06< zookeeper> mmkay
20180309 13:03:58< vultraz> We could implement a full, proper solution with temp filenames and all that but honestly, we need to pick our battles and time and manpower is short.
20180309 13:04:24< vultraz> yaknowwhaimsayin
20180309 13:11:02-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20180309 13:11:51-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20180309 13:54:44-!- Bonobo [~Bonobo@203.111.185.228] has joined #wesnoth-dev
20180309 14:07:10-!- Bonobo [~Bonobo@203.111.185.228] has quit [Ping timeout: 240 seconds]
20180309 14:10:29< vn971> sorry, I'll ask a half-UMC question here. On wesnoth-1.12, how early can I invoke `helper.rand("1..100")` for it to be OOS-safe? Can I do it in "preload"?
20180309 14:11:38< vultraz> I don't know.
20180309 14:11:40< Ravana_> preload is not synchronizable
20180309 14:11:45< Soliton> https://wiki.wesnoth.org/EventWML#Multiplayer_safety
20180309 14:12:43< vn971> Soliton: Ravana_ vultraz: thanks a lot! Forgot about this wiki section.
20180309 14:27:14-!- vslavik [vslavik@nat/redhat/x-ftlwtddbtvecadxs] has joined #wesnoth-dev
20180309 14:29:32-!- vladimirslavik [vslavik@nat/redhat/x-njuxrbkrkciyodzg] has quit [Ping timeout: 240 seconds]
20180309 14:31:57-!- Nobun [~user@51.179.106.37] has joined #wesnoth-dev
20180309 14:32:32< Nobun> new PR for wmlxgettext: new release with very minor help text fix
20180309 14:34:25< Soliton> By default sentences are NOT setted as fuzzy. -> By default sentences are NOT set as fuzzy.
20180309 14:38:31< Soliton> looks like setted is used several times.
20180309 14:53:04< Nobun> Soliton: damn. I had put the tag in my repo... well the version will be 2018.03.10 (regardless of the fact that today is 9 :P)
20180309 14:53:37< Nobun> thank for marking me the error. My english, sometimes, is lacking :P
20180309 14:53:56-!- DeFender1031 [~DeFender1@dsl217-132-38-129.bb.netvision.net.il] has quit [Quit: I'm not back now.]
20180309 14:54:01< Nobun> now I will fix it immediately
20180309 14:57:05< Nobun> ok added the commit with all "setted" replaced with "set"
20180309 14:57:13< Nobun> thank for report
20180309 14:58:31< Nobun> I will wait 1-2 days before committing also to my repo those fix, in order to be sure that 2018.03.10 shold contain all help text fixes
20180309 14:58:43< Nobun> should *
20180309 14:59:17< Nobun> if you see any other errors, you are wellcomed to report them. Thank you again.
20180309 15:06:47-!- vslavik__ [vslavik@nat/redhat/x-rvktgumpiepzmkfj] has joined #wesnoth-dev
20180309 15:09:07-!- JyrkiVesterinen [~JyrkiVest@195-192-251-124.s1networks.fi] has quit [Quit: .]
20180309 15:09:27-!- vslavik [vslavik@nat/redhat/x-ftlwtddbtvecadxs] has quit [Ping timeout: 256 seconds]
20180309 15:12:49< vultraz> zookeeper: prestart is not supposed to fire when loading saves, right? only preload?
20180309 15:13:11< zookeeper> correct
20180309 16:28:43< Nobun> prestart and start will trigger before turn 1 starts. Saves, instead, should save the situation at the turn where you arrived (so, at least, turn 1)
20180309 16:28:59< Nobun> if I understood correctly
20180309 16:35:25-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180309 16:35:31-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20180309 17:26:29< vn971> Nobun: yes absolutely.
20180309 17:33:24-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180309 17:33:34-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20180309 17:34:56-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has joined #wesnoth-dev
20180309 17:42:32-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20180309 17:51:36-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20180309 17:55:25-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20180309 17:57:41-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20180309 18:03:03-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180309 18:03:11-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20180309 18:35:13-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180309 18:35:19-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20180309 18:45:04-!- octalot [~steve@178.115.130.165.wireless.dyn.drei.com] has joined #wesnoth-dev
20180309 18:51:21-!- irker853 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20180309 18:51:21< irker853> wesnoth/wesnoth:master Nobun ef53de930e help text fix2 AppVeyor: All builds passed
20180309 18:55:18< irker853> wesnoth: gfgtdf wesnoth:master 9e8220022a20 / src/game_initialization/create_engine.cpp: don't generate [side]s if the [multiplayer] has at least one [side] defined. https://github.com/wesnoth/wesnoth/commit/9e8220022a20c81f0d8e2da3d4b9e5f4c834ec1e
20180309 18:57:33-!- vslavik__ [vslavik@nat/redhat/x-rvktgumpiepzmkfj] has quit [Quit: Leaving]
20180309 19:30:19-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180309 19:30:28-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20180309 19:31:08< irker853> wesnoth: Nobun wesnoth:master 11d48f163902 / utils/wmlxgettext: help text fixes (#2617) https://github.com/wesnoth/wesnoth/commit/11d48f16390266eddb290e1c728959269dcc3026
20180309 19:40:08< irker853> wesnoth/wesnoth:master Nobun 42a1b778fe help messages fix AppVeyor: All builds passed
20180309 19:45:03-!- octalot [~steve@178.115.130.165.wireless.dyn.drei.com] has quit [Ping timeout: 268 seconds]
20180309 19:58:24-!- vultraz [uid24821@wesnoth/developer/vultraz] has quit [Quit: Connection closed for inactivity]
20180309 20:03:34-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has quit [Quit: .]
20180309 20:08:48-!- octalot [~steve@178.115.130.165.wireless.dyn.drei.com] has joined #wesnoth-dev
20180309 20:30:22-!- TadCarlucci [~lundberg@74.193.219.119] has quit [Remote host closed the connection]
20180309 20:40:50-!- TadCarlucci [~lundberg@74.193.219.119] has joined #wesnoth-dev
20180309 20:47:10-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20180309 21:10:33-!- Nobun [~user@51.179.106.37] has quit [Quit: good night everyone]
20180309 21:19:35-!- octalot [~steve@178.115.130.165.wireless.dyn.drei.com] has quit [Ping timeout: 240 seconds]
20180309 21:27:47-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Quit: Caught sigterm, terminating...]
20180309 21:28:08-!- Ivanovic [~ivanovic@p579FBA67.dip0.t-ipconnect.de] has joined #wesnoth-dev
20180309 21:28:09-!- Ivanovic [~ivanovic@p579FBA67.dip0.t-ipconnect.de] has quit [Changing host]
20180309 21:28:09-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev
20180309 21:30:14-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20180309 21:44:27-!- Ravana_ [~Ravana@unaffiliated/ravana/x-2327071] has quit [Read error: Connection reset by peer]
20180309 21:51:03-!- Ravana_ [~Ravana@unaffiliated/ravana/x-2327071] has joined #wesnoth-dev
20180309 21:58:53-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180309 21:59:06-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20180309 22:13:41-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 256 seconds]
20180309 22:40:16-!- octalot [~steve@178.115.130.165.wireless.dyn.drei.com] has joined #wesnoth-dev
20180309 22:45:22-!- irker853 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20180309 23:05:12-!- irker918 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20180309 23:05:12< irker918> wesnoth/wesnoth:master Nobun 11d48f1639 help text fixes (#2617) AppVeyor: All builds passed
20180309 23:16:16-!- Bonobo [~Bonobo@203.111.185.228] has joined #wesnoth-dev
20180309 23:46:49< irker918> wesnoth/wesnoth:master Gregory A Lundberg 00736e920e Use standard names AppVeyor: vs2015/Release Failed
20180309 23:46:50< irker918> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-1768
--- Log closed Sat Mar 10 00:00:30 2018