--- Log opened Sat Mar 10 00:00:30 2018
20180310 00:02:04-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer]
20180310 00:39:31-!- sigurdfd [sigurdfd@dynamic-acs-72-23-110-196.zoominternet.net] has joined #wesnoth-dev
20180310 00:43:12< irker918> wesnoth: sigurdfdragon wesnoth:master 40119cc0f6dc / data/campaigns/Northern_Rebirth/ (maps/14a_Epilogue.map scenarios/13a_Showdown.cfg scenarios/14a_Epilogue.cfg): [WIP] NR S13a & S14a: Appearance improvements https://github.com/wesnoth/wesnoth/commit/40119cc0f6dcd76b801b879065795b1ded671ef9
20180310 00:56:45-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20180310 01:01:58< irker918> wesnoth/wesnoth:master Gregory A Lundberg 00736e920e Use standard names AppVeyor: 3/6 builds failed
20180310 01:01:59< irker918> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-1768
20180310 01:02:00< irker918> Details vs2017/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-master-1472
20180310 01:02:01< irker918> Details vs2013/Release: https://ci.appveyor.com/project/wesnoth/wesnoth/build/Wesnoth-VS2013-master-1781
20180310 01:38:45-!- sigurdfd [sigurdfd@dynamic-acs-72-23-110-196.zoominternet.net] has quit []
20180310 02:16:25< irker918> wesnoth: Celtic Minstrel wesnoth:fix_2615 15552341e09a / src/scripting/game_lua_kernel.cpp: [WIP] Attempted fix for memory corruption in #2615 https://github.com/wesnoth/wesnoth/commit/15552341e09ac3fa24ad2bae0f896dd856fecd88
20180310 02:18:17< celticminstrel> (Might be an idea to cancel the appveyor build for that. I haven't even tested it'll compile, it's more to show the concept ATM.)
20180310 02:18:35< celticminstrel> Okay so, that aside, I have two things I want to bring up.
20180310 02:19:43< celticminstrel> First is something that jyrki or tad or vultraz or zookeeper may want input on. There exists a package manager for MSVC which seems quite decent and could replace our use of aquileia/external.
20180310 02:19:50< celticminstrel> It can be found here. https://github.com/Microsoft/vcpkg
20180310 02:20:11< celticminstrel> It requires VS2015 or higher to build it but can be used with VS2013.
20180310 02:21:35< celticminstrel> The only downside I can think of is that for someone wanting to build it's a little more complicated, but that could probably be alleviated with a batch file.
20180310 02:21:52< celticminstrel> ---
20180310 02:23:07< celticminstrel> The second thing is about Lua events hooks; maybe gfgtdf would like to comment. The current way events are handled is quite fragile and can be easily broken. The problem is essentially that anyone who want to install an event handler needs to call the previous event handler.
20180310 02:23:34< celticminstrel> I think it would be better to instead store a list of event handlers. When the event occurs, the engine would call all the handlers in the list, in order.
20180310 02:24:15< celticminstrel> It could be difficult to do while maintaining backwards compatibility, though, and I'm pretty sure some of these event hooks were already present in 1.12, so compatibility would be a must.
20180310 02:24:33< celticminstrel> You'd also want a way to unregister an event handler.
20180310 02:25:27< celticminstrel> So basically, the current idiom is "local old = wesnoth.on_xxx; function wesnoth.on_xxx(...) old(xxx) do_stuff() end"
20180310 02:25:50< celticminstrel> (With a slight variation if the handler returns a value.)
20180310 02:27:39< celticminstrel> My proposal could maintain full backwards compatibility at the cost of being a little unintuitive; basically there would be a custom metatable on the "wesnoth" table which catches reads and writes to the on_xxx field. A write would install a new handler; a read would return a list of all the handlers which can then be manipulated, and the list would also implement a call operator which does nothing (for compatibility).
20180310 02:29:19 * celticminstrel should probably open an issue and/or a forum thread about the second thing... maybe a bit later.
20180310 02:33:34< celticminstrel> Another idea for compatibility would be to install the new hooks at a different location (eg wesnoth_hooks.on_xxx instead of wesnoth.on_xxx).
20180310 02:45:07-!- vultraz [uid24821@wesnoth/developer/vultraz] has joined #wesnoth-dev
20180310 03:42:21-!- octalot [~steve@178.115.130.165.wireless.dyn.drei.com] has quit [Ping timeout: 256 seconds]
20180310 04:05:21-!- Bonobo [~Bonobo@203.111.185.228] has quit [Ping timeout: 248 seconds]
20180310 04:06:16-!- Bonobo [~Bonobo@203.111.185.228] has joined #wesnoth-dev
20180310 04:09:15< irker918> wesnoth: Iris Morelle wesnoth:master 84427644353a / utils/mp-server/new_campaignd: Add script for creating a new campaignd instance https://github.com/wesnoth/wesnoth/commit/84427644353a570acaeeaa56feaeff04341ce4d8
20180310 04:14:29< irker918> wesnoth: Iris Morelle valen:master 25d8859d521e / bin/valen.pl: valen: Add 1.14 campaignd port https://github.com/wesnoth/valen/commit/25d8859d521e52d6e559597299604ce0c80127ab
20180310 04:22:23-!- Bonobo [~Bonobo@203.111.185.228] has quit [Ping timeout: 252 seconds]
20180310 04:23:04-!- Bonobo [~Bonobo@203.111.185.228] has joined #wesnoth-dev
20180310 04:38:07< irker918> wesnoth/wesnoth:fix_2615 Celtic Minstrel 15552341e0 [WIP] Attempted fix for memory corruptio AppVeyor: vs2017/Release Failed
20180310 04:38:08< irker918> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-fix_2615-1474
20180310 04:57:00< celticminstrel> Yeah just ignore that.
20180310 04:57:31 * celticminstrel pokes vultraz towards the things I said a bit before he showed up.
20180310 05:05:01< vultraz> What?
20180310 05:05:58< vultraz> celticminstrel: what did you say
20180310 05:06:08< celticminstrel> It was somewhat long...
20180310 05:06:15< celticminstrel> No-one else has said anything since.
20180310 05:06:24< celticminstrel> I can paste it into a PM if you really want though.
20180310 05:11:28< wedge009> I find it funny to see Microsoft in GitHub, if only because I'm used to it producing largely closed-source stuff. What sort of libraries would that packager be able to pull in, I wonder. It does note it's in a 'preview' state, but maybe that's just their way of saying 'don't blame us if it doesn't work properly yet'.
20180310 05:12:20< celticminstrel> There are closed-source things on github though.
20180310 05:12:31< wedge009> How does that work?
20180310 05:12:33< celticminstrel> Unreal Engine is on github, for example.
20180310 05:12:45< celticminstrel> They aren't publically visible.
20180310 05:13:00< wedge009> ...but still publicly available?
20180310 05:13:00< celticminstrel> You need to specifically get access to them in some way.
20180310 05:13:16< wedge009> Oh, source code but restricted.
20180310 05:13:30< celticminstrel> Exactly how would depend on the project, I guess. From the sounds of it, UE is really easy to get access to.
20180310 05:14:02< celticminstrel> That said, most of the UE source is part of the actual engine release anyway...
20180310 05:15:43< vultraz> celticminstrel: alright I see what you said
20180310 05:16:21< vultraz> I don’t know what you mean by calling he previous event handler
20180310 05:16:48< celticminstrel> The "current idiom" that I quoted.
20180310 05:17:07< celticminstrel> In order to override the event handler while playing nice, you need to ensure that you call whatever was previously assigned to it.
20180310 05:17:36< celticminstrel> And Wesnoth uses these hooks in the core Lua files too, so if you don't do that, some built-in things won't work.
20180310 05:18:36< vultraz> What do you mean by override the event handler
20180310 05:18:59< vultraz> Oh I see
20180310 05:19:24< vultraz> ....We have lua on_xxx event handlers?
20180310 05:19:50< celticminstrel> Yes.
20180310 05:19:54< vultraz> Huh
20180310 05:20:00< celticminstrel> Currently xxx is one of: mouse_action, load, event.
20180310 05:20:07< celticminstrel> I think there's also one other.
20180310 05:20:40< celticminstrel> "event" means "WML event", so that'll handle everything currently handled by [event] in one handler, which... isn't ideal either.
20180310 05:21:13< vultraz> Those seem weirdly arbitrary
20180310 05:21:25< celticminstrel> ?
20180310 05:22:34< vultraz> That mouse_action and load are separate
20180310 05:22:47< celticminstrel> Because those are non-WML events.
20180310 05:23:41< vultraz> Preload is an event..
20180310 05:23:53< celticminstrel> Sure, but that's different.
20180310 05:25:08< celticminstrel> TBH we probably don't need preload anymore...
20180310 05:27:57< celticminstrel> There's no WML equivalent for on_load.
20180310 05:28:39< celticminstrel> on_load pretty much takes in the raw savegame WML (or possibly the scenario WML within the savegame) and lets you do whatever you want with it.
20180310 05:29:17< celticminstrel> Oh yeah, there's on_save too I guess... pretty sure there's still one other that I'm forgetting though, something that makes a pair with on_mouse_action...
20180310 05:29:32< irker918> wesnoth/wesnoth:fix_2615 Celtic Minstrel 15552341e0 [WIP] Attempted fix for memory corruptio AppVeyor: 3/6 builds failed
20180310 05:29:33< irker918> Details vs2017/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-fix_2615-1474
20180310 05:29:34< irker918> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-fix_2615-1770
20180310 05:29:35< irker918> Details vs2013/Release: https://ci.appveyor.com/project/wesnoth/wesnoth/build/Wesnoth-VS2013-fix_2615-1783
20180310 05:29:41< celticminstrel> ...yeah ignore that.
20180310 05:30:49< vultraz> Honestly, 1.15 is going to be a lot of breaking changes
20180310 05:31:01< celticminstrel> Does Appveyor not have an equivalent to [ci skip]?
20180310 05:31:10< vultraz> So probably breaking something without compatibility is fine.
20180310 05:31:11< vultraz> and no
20180310 05:31:12< vultraz> it doesn't
20180310 05:31:33< celticminstrel> I disagree, but whatever.
20180310 05:32:38< vultraz> we do have level 4 :P
20180310 05:32:52< celticminstrel> Level 4 should never be used unless absolutely necessary.
20180310 05:34:41< vultraz> Very likely I will use it on ThemeWML
20180310 05:35:16< celticminstrel> I think that's unlikely to be necessary TBH.
20180310 05:35:36< celticminstrel> Though did we check if people are using custom themes other than a cutscene theme?
20180310 05:35:40< vultraz> It's more about having a clean slate.
20180310 05:35:42< celticminstrel> On the addon server I mean.
20180310 05:36:17< celticminstrel> You can have a clean slate and still maintain compatibility.
20180310 05:36:47< vultraz> We'll see.
20180310 05:37:52-!- celticminstrel is now known as celmin|sleep
20180310 05:42:01< irker918> wesnoth: Gregory A Lundberg wesnoth:master 1c745befa8de / src/units/abilities.cpp: Fix doccomment. https://github.com/wesnoth/wesnoth/commit/1c745befa8de4804e28adac567b4a4115b94a7c8
20180310 05:57:04-!- travis-ci [~travis-ci@ec2-54-204-169-171.compute-1.amazonaws.com] has joined #wesnoth-dev
20180310 05:57:05< travis-ci> shikadiqueen/wesnoth#31 (feature/campaignd-1.14-port - 2152dc6 : Iris Morelle): The build passed.
20180310 05:57:05< travis-ci> Build details : https://travis-ci.org/shikadiqueen/wesnoth/builds/351602716
20180310 05:57:05-!- travis-ci [~travis-ci@ec2-54-204-169-171.compute-1.amazonaws.com] has left #wesnoth-dev []
20180310 06:45:17-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20180310 07:12:41< irker918> wesnoth/wesnoth:master sigurdfdragon 40119cc0f6 [WIP] NR S13a & S14a: Appearance improve AppVeyor: All builds passed
20180310 07:46:39-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has joined #wesnoth-dev
20180310 08:49:49-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20180310 08:52:29< irker918> wesnoth/wesnoth:master Iris Morelle 9740f73e0e campaignd: Set port allocation for versi AppVeyor: All builds passed
20180310 08:59:51< vn971> By the way, would it make sense for helper.rand() to produce an error instead of "unsynched" result during preload and other unsynched events?
20180310 09:01:41< vn971> Otherwise you may develop something thinking it's OOS-safe, but it's not. First time you check it online, it may break, with non-trivial to understand user-facing results.
20180310 09:03:36< vn971> Thoughts?
20180310 09:10:34< irker918> wesnoth: Lari Nieminen wesnoth:master b6fa4740f37f / data/campaigns/Sceptre_of_Fire/scenarios/7_Outriding_the_Outriders.cfg: SoF S7: Fixed the castle moveto event terrain filter https://github.com/wesnoth/wesnoth/commit/b6fa4740f37f8a07ef74044cc6258ea89c0f1b60
20180310 09:10:45< zookeeper> yay, i remembered to use [ci skip] for once.
20180310 09:16:49< AI0867> I dislike the idea of using a permanent thing (like a commit message) to achieve a temporary end (skipping a CI build)
20180310 09:17:20< AI0867> it gets my history polluted with implementation details of the build chain
20180310 09:21:37< zookeeper> i don't disagree.
20180310 09:23:38-!- Oebele [~quassel@143.177.58.202] has joined #wesnoth-dev
20180310 09:49:56< irker918> wesnoth: Jyrki Vesterinen wesnoth:master 45cab78cfb67 / src/game_events/ (manager.cpp manager.hpp): Mark game_events::manager::execute_on_events() as noexcept https://github.com/wesnoth/wesnoth/commit/45cab78cfb67441dff36826162e36c980a72a222
20180310 09:58:45-!- vn971 [~vasya@94.158.103.15] has quit [Quit: Leaving.]
20180310 10:16:36-!- octalot [~steve@178.115.130.165] has joined #wesnoth-dev
20180310 10:49:03-!- Bonobo [~Bonobo@203.111.185.228] has quit [Ping timeout: 256 seconds]
20180310 10:49:42-!- Bonobo [~Bonobo@203.111.185.228] has joined #wesnoth-dev
20180310 11:49:30-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has quit [Quit: .]
20180310 12:09:34-!- Nobun [~user@51.179.106.37] has joined #wesnoth-dev
20180310 12:31:34-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20180310 12:49:25-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has joined #wesnoth-dev
20180310 12:50:13-!- irker918 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20180310 12:59:22-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has quit [Quit: .]
20180310 13:02:06-!- irker117 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20180310 13:02:06< irker117> wesnoth/wesnoth:master Jyrki Vesterinen 45cab78cfb Mark game_events::manager::execute_on_ev AppVeyor: All builds passed
20180310 13:09:35-!- octalot [~steve@178.115.130.165] has quit [Ping timeout: 256 seconds]
20180310 13:17:45-!- octalot [~steve@178.165.131.159.wireless.dyn.drei.com] has joined #wesnoth-dev
20180310 13:21:09-!- Bonobo [~Bonobo@203.111.185.228] has quit [Quit: Leaving]
20180310 13:40:26-!- travis-ci [~travis-ci@ec2-54-166-8-119.compute-1.amazonaws.com] has joined #wesnoth-dev
20180310 13:40:27< travis-ci> gfgtdf/wesnoth#1020 (unit_ptr - 7f21fe3 : gfgtdf): The build failed.
20180310 13:40:27< travis-ci> Build details : https://travis-ci.org/gfgtdf/wesnoth/builds/351693012
20180310 13:40:27-!- travis-ci [~travis-ci@ec2-54-166-8-119.compute-1.amazonaws.com] has left #wesnoth-dev []
20180310 13:58:19-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has joined #wesnoth-dev
20180310 13:59:56-!- travis-ci [~travis-ci@ec2-54-234-33-111.compute-1.amazonaws.com] has joined #wesnoth-dev
20180310 13:59:57< travis-ci> gfgtdf/wesnoth#1021 (unit_ptr - 3dccd16 : gfgtdf): The build is still failing.
20180310 13:59:59< travis-ci> Build details : https://travis-ci.org/gfgtdf/wesnoth/builds/351697575
20180310 13:59:59-!- travis-ci [~travis-ci@ec2-54-234-33-111.compute-1.amazonaws.com] has left #wesnoth-dev []
20180310 14:15:53-!- gfgtdf [~chatzilla@x4e3689d9.dyn.telefonica.de] has joined #wesnoth-dev
20180310 14:20:32-!- gfgtdf [~chatzilla@x4e3689d9.dyn.telefonica.de] has quit [Client Quit]
20180310 14:40:22-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity]
20180310 14:47:43-!- Oebele [~quassel@143.177.58.202] has quit [Remote host closed the connection]
20180310 14:49:55< TadCarlucci> [ci skip] is also a half-solution since it only skips Travis/CI. For me, it works better to not bother with it and hand-cancel the runs I don't want. Or, better yet, just ignore it and let them all run, anyway.
20180310 14:55:11-!- celmin|sleep is now known as celticminstrel
20180310 14:55:29< celticminstrel> Still no responses to last night huh. (Other than Vultraz.)
20180310 15:02:43< Ravana_> I agree that current situation with on_event is not good for general use, adding listeners is what developer usually would want
20180310 15:11:38-!- gfgtdf [~chatzilla@x4e3689d9.dyn.telefonica.de] has joined #wesnoth-dev
20180310 15:11:59< gfgtdf> well i agree that it's not as good as it coudl be but i don't think it's really a problem
20180310 15:12:17< celticminstrel> ???
20180310 15:12:18< gfgtdf> it's celarly not something that should be changed before 1.14
20180310 15:12:27< gfgtdf> the on_event i'm talking about
20180310 15:12:28< celticminstrel> Oh, you're talking about the Lua event hooks?
20180310 15:12:33< celticminstrel> Okay.
20180310 15:12:42< celticminstrel> But I think it's a problem.
20180310 15:13:34< celticminstrel> gfgtdf: What about #2615?
20180310 15:18:15< gfgtdf> commented
20180310 15:23:31< celticminstrel> gfgtdf: Is the pull finished or do you have more commits to add?
20180310 15:24:08< gfgtdf> it's not finished yet,it probably won't guild due to erros, will wait for travis and then fix them
20180310 15:26:41< irker117> wesnoth: Jyrki Vesterinen wesnoth:master 97183e37c8c3 / src/game_events/ (manager.cpp manager.hpp): Revert "Mark game_events::manager::execute_on_events() as noexcept" https://github.com/wesnoth/wesnoth/commit/97183e37c8c36b167af956d9004d5b1b71b075cf
20180310 15:26:43< irker117> wesnoth: Jyrki Vesterinen wesnoth:master 857f5a9e7101 / src/ (game_events/manager.cpp game_events/manager.hpp play_controller.cpp): Use a RAII class to block game event handler cleanup https://github.com/wesnoth/wesnoth/commit/857f5a9e7101d673c711d70655fc941a75eb23ad
20180310 15:26:45< irker117> wesnoth: Jyrki Vesterinen wesnoth:master 7637a36c3f82 / src/game_events/manager.cpp: Assert that there are no disabled event handlers when saving https://github.com/wesnoth/wesnoth/commit/7637a36c3f82cea8854baf89196cfae194631e05
20180310 15:29:35< gfgtdf> build*
20180310 15:30:28< vultraz> gfgtdf: does your PR mean it would be safe to use a shared_ptr instead of an intrusive_ptr for `unit_ptr` at some point?
20180310 15:31:23< gfgtdf> well it bsicially means that if some function is passed a 'unit*' you can now always create a unit_ptr out of it.
20180310 15:31:25< celticminstrel> It does indeed.
20180310 15:31:31< celticminstrel> ^ vultraz 
20180310 15:31:40< vultraz> \o/
20180310 15:31:57< celticminstrel> More precisely it's the prerequisite for unit inheriting from std::enable_shared_from_this.
20180310 15:32:17< gfgtdf> iirc the main reason why we use unit_ptr over shared_ptr was just performance ?
20180310 15:32:28< vultraz> because you can only call shared_from_this on an object already managed by a shared_ptr?
20180310 15:32:35< gfgtdf> yes
20180310 15:32:43< celticminstrel> It's only safe to call it in that case.
20180310 15:32:48< celticminstrel> Of course you can call it on any object.
20180310 15:32:51< vultraz> gfgtdf: celticminstrel told me it was because we couldn't guarantee the unit was always managed by a smart ptr
20180310 15:32:58< vultraz> or something
20180310 15:32:59< vultraz> like that
20180310 15:37:45< gfgtdf> hmm wait i think the main reason why it uses intrusive_ptr is that iceiceice's plan was that at some point we can get rid of this refcount: https://github.com/wesnoth/wesnoth/blob/master/src/units/map.hpp#L112
20180310 15:38:07< gfgtdf> becasue currently both unit and unit_pod do seperate refcounting.
20180310 15:38:27< vultraz> I thought we could do that if we used shared_ptr?
20180310 15:42:40< gfgtdf> hmm i currently don't know.
20180310 15:44:17< celticminstrel> BTW I just noticed wesnoth.remove_modification seems to be undocumented?
20180310 15:44:31< vultraz> that was all your effort
20180310 15:47:34< celticminstrel> I think in order to remove that refcount you'd need to somehow conflate the iterator with the pointer?
20180310 15:48:13< celticminstrel> The unit iterator is actually a double-indirection ATM.
20180310 15:48:19< vultraz> I don't even understand the unit_map
20180310 15:48:26< vultraz> ftr
20180310 15:48:29< celticminstrel> So unit_pod is the refcount for the iterator.
20180310 15:48:31< vultraz> it seems so complicated
20180310 15:48:35< celticminstrel> While unit has its own refcount.
20180310 15:50:12< vultraz> why do you need to refcount iterators
20180310 15:51:02< celticminstrel> Same reason you need to refcount pointers, I suppose.
20180310 15:51:25< celticminstrel> Don't forget that iterators are sort of a generalization of pointers with respect to their application to arrays.
20180310 15:52:24< vultraz> what about arrays?
20180310 15:52:49< celticminstrel> The iterator for a plain C array is a pointer.
20180310 16:13:06-!- octalot [~steve@178.165.131.159.wireless.dyn.drei.com] has quit []
20180310 16:26:04< celticminstrel> I wonder if anyone has tested mid-scenario storyscreen yet.
20180310 16:27:31< celticminstrel> Oh huh I forgot about this. https://wiki.wesnoth.org/User:Celtic_Minstrel/UnitBehaviourProposal
20180310 16:27:58< celticminstrel> Hmm.
20180310 16:28:09< celticminstrel> I guess that page isn't in Defender's userspace...
20180310 16:28:45-!- DeFender1031 [~DeFender1@dsl217-132-38-129.bb.netvision.net.il] has joined #wesnoth-dev
20180310 16:29:18< celticminstrel> Ah there it is. https://wiki.wesnoth.org/LuaWML/Reorganization
20180310 16:29:27< celticminstrel> vultraz: Any objections to me starting to implement more of that? ^
20180310 16:29:57< celticminstrel> For now, just as tables referencing the old versions.
20180310 16:32:24< celticminstrel> Though I disagree with some of it, too.
20180310 16:32:37< celticminstrel> Like location_set, I don't see any point in changing it at all.
20180310 16:33:41< vultraz>  Well we decided to do away with some like variable.get and .set right
20180310 16:37:40< celticminstrel> DeFender1031: On a related note, what do you think of a "wesnoth.hooks" table which contains the following: wml_actions, conditional_actions, effects, on_event, on_mouse_action, on_mous_move, on_load, on_save... possibly also theme_items though that's probably better placed somewhere else... maybe also micro_ais?
20180310 16:38:17< gfgtdf> i don't think it's a good idea to add such things shortly before a release, in paticular since we then have no option to chage it withotu brekaing compability.
20180310 16:41:08< celticminstrel> gfgtdf: If it's just the parts that are uncontested though...
20180310 16:41:24< celticminstrel> vultraz: I don't recall. I do remember talking about it but don't remember the conclusion.
20180310 16:42:28< celticminstrel> Also, looks like I was slightly wrong. It's currently wesnoth.game_events.on_xxx, not wesnoth.on_xxx.
20180310 16:42:45< DeFender1031> celticminstrel, i'd be cool with it if those things are ALSO available in the API section in whose domain those things appear as well
20180310 16:42:45< celticminstrel> Is that the only thing that the game_events table is used for?
20180310 16:43:10< DeFender1031> (I'm a big fan of putting aliases to things in multiple places where it makes sense.)
20180310 16:43:33< celticminstrel> I think most of those are kinda "standalone".
20180310 16:43:52< celticminstrel> Though I guess for conditional_actions you also have eval_conditional.
20180310 16:43:54< DeFender1031> isn't there an events section?
20180310 16:44:11< celticminstrel> And I suppose you have fire and the action metatable for wml_actions.
20180310 16:44:22< celticminstrel> Oh yeah, there is an event section.
20180310 16:44:59< celticminstrel> on_event is for handling an event with a Lua function, it's a bit different from installing an event handler (and IIRC less safe).
20180310 16:45:07< DeFender1031> hmm
20180310 16:45:15< DeFender1031> so then it may not belng there
20180310 16:45:52< celticminstrel> gfgtdf: BTW it looks like on_mouse_action is documented but on_mouse_move is not, can you fix this? https://wiki.wesnoth.org/LuaWML/Events#wesnoth.game_events
20180310 16:46:30< DeFender1031> by the way, if those "on*" things are still setting them to equal a single function, you may want to consider switching to a model more like javascript's addEventListener
20180310 16:47:02< celticminstrel> DeFender1031: Yeah that's what I was talking about last night. :P
20180310 16:47:10< DeFender1031> (I.E. a function passed scallback that add or remove the function to/from a collection of handers which all run)
20180310 16:47:28< celticminstrel> Though I had UE's multicast delegates system when suggesting it.
20180310 16:47:40< celticminstrel> ^system in mind
20180310 16:47:47< celticminstrel> Apparently on_event is called before event handlers are triggered, so it can install an event handler for the event it's handling.
20180310 16:49:11< DeFender1031> interesting.
20180310 16:49:27< DeFender1031> you might want to also add an "after event" for the opposite
20180310 16:49:37< celticminstrel> Might be an idea.
20180310 16:49:43< celticminstrel> on_event_completed or something.
20180310 16:50:20< celticminstrel> I think I'll open an issue (milestone 1.15) for the event handlers.
20180310 16:51:32< shadowm> 1.15.0 you mean? :p
20180310 16:52:09< celticminstrel> Same thing, is it not?
20180310 16:52:20< shadowm> 1.15.0 is the first development version for 1.16.
20180310 16:52:52< shadowm> I avoid referring to X.Y as a version unless I mean a stable branch.
20180310 16:53:21< shadowm> And milestones are supposed to be labeled after concrete targets I believe.
20180310 16:53:51< DeFender1031> also, for backwards compatibility with the on* API, I'd suggest a metatable that makes setting on* call the add function along with setting what the current one set to is, so that changing it later can remove it and retrieving it later can know what it is.
20180310 16:53:55< shadowm> There's also the fact that you'll have milestones for 1.15.0, 1.15.1, 1.15.2 and so on later on.
20180310 16:56:12< celticminstrel> DeFender1031: I pretty much suggested the same thing last night. :P
20180310 16:56:30< celticminstrel> Though...
20180310 16:56:39< celticminstrel> Actually your suggestion goes a bit further.
20180310 16:56:51< celticminstrel> Remembering the most-recently-set handler wasn't in my suggestion.
20180310 16:57:15< celticminstrel> Ah, wait, what you're saying is that if you assign it should replace the handler?
20180310 16:57:48< celticminstrel> On second thoughts, my proposal for compatibility was a bit different.
20180310 16:59:02< celticminstrel> Also shadowm has a good point, can we rename the milestone marker?
20180310 17:00:48< DeFender1031> well, yeah. otherwise, it doesn't have the same semantic
20180310 17:00:49< DeFender1031> s
20180310 17:01:04< DeFender1031> basically, there's ONE handler that was added by that, and the rest which are free agents.
20180310 17:01:13< DeFender1031> the one added by that has different rules
20180310 17:01:23< DeFender1031> (such as no longer being there if it is re-assigned)
20180310 17:01:34< celticminstrel> I wasn't too worried about having the same semantics, but I guess... in your opinion, the second proposal for compatibility is preferable.
20180310 17:05:25< DeFender1031> I mean, if it doesn't have the same semantics, it's not backward compatible
20180310 17:05:50< DeFender1031> I can think of alternate semantics that would be compatible with most sane usage, but it's simple enough to have identical semantics, so why not?
20180310 17:05:55< celticminstrel> It could be though if users didn't make full use of the old version's capabilities.
20180310 17:05:58< celticminstrel> But sure.
20180310 17:06:37< celticminstrel> https://github.com/wesnoth/wesnoth/issues/2623
20180310 17:08:54< celticminstrel> No-one commented on the other thing I talked about last night, either. Except wedge technically.
20180310 17:09:25< vultraz> i dunno about the msvc thing
20180310 17:23:08-!- atarocch_ [~atarocch@93.56.164.28] has quit [Ping timeout: 268 seconds]
20180310 17:44:53-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180310 17:44:59-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20180310 17:47:54-!- travis-ci [~travis-ci@ec2-54-198-116-185.compute-1.amazonaws.com] has joined #wesnoth-dev
20180310 17:47:55< travis-ci> gfgtdf/wesnoth#1032 (unit_ptr - a3ca7f6 : gfgtdf): The build passed.
20180310 17:47:55< travis-ci> Build details : https://travis-ci.org/gfgtdf/wesnoth/builds/351741803
20180310 17:47:55-!- travis-ci [~travis-ci@ec2-54-198-116-185.compute-1.amazonaws.com] has left #wesnoth-dev []
20180310 17:58:40< celticminstrel> Oh yeah, it'd be great if Wesnoth was also on the Mac app store.
20180310 17:59:00-!- travis-ci [~travis-ci@ec2-54-198-116-185.compute-1.amazonaws.com] has joined #wesnoth-dev
20180310 17:59:01< travis-ci> gfgtdf/wesnoth#1033 (unit_ptr - a23b905 : gfgtdf): The build passed.
20180310 17:59:01< travis-ci> Build details : https://travis-ci.org/gfgtdf/wesnoth/builds/351745457
20180310 17:59:01-!- travis-ci [~travis-ci@ec2-54-198-116-185.compute-1.amazonaws.com] has left #wesnoth-dev []
20180310 17:59:17< celticminstrel> Singalen has put it on the ios store right? Can the same credentials be used for the Mac store?
20180310 18:09:07< Soliton> i would assume so.
20180310 18:10:03< gfgtdf> celticminstrel: any opinion on #2624 ?
20180310 18:13:20< celticminstrel> Short answer: It doesn't make sense.
20180310 18:13:30< gfgtdf> explain more
20180310 18:13:34< celticminstrel> Will do.
20180310 18:22:49< vultraz> It’s the same store isn’t it
20180310 18:23:00< celticminstrel> Not really?
20180310 18:23:12< celticminstrel> I mean, things that run on the Mac can't run on iOS and vice versa.
20180310 18:23:30< celticminstrel> So it wouldn't make sense for them to share one store.
20180310 18:23:40< celticminstrel> I guess it could be all handled by one system on Apple's side.
20180310 18:23:49< vultraz> Oh it’s not yet one store
20180310 18:24:01< vultraz> https://www.theverge.com/2017/12/20/16800834/apple-mac-ios-combined-apps
20180310 18:24:06< celticminstrel> "yet"
20180310 18:26:58-!- irker117 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20180310 18:27:12< vultraz> Yes
20180310 18:34:31-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180310 18:34:37-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20180310 18:37:25-!- octalot [~steve@178.165.131.159.wireless.dyn.drei.com] has joined #wesnoth-dev
20180310 18:54:33-!- TC01 [~quassel@venus.arosser.com] has joined #wesnoth-dev
20180310 18:59:32-!- irker660 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20180310 18:59:32< irker660> wesnoth/wesnoth:master Jyrki Vesterinen 7637a36c3f Assert that there are no disabled event  AppVeyor: All builds passed
20180310 19:17:10-!- travis-ci [~travis-ci@ec2-54-224-151-168.compute-1.amazonaws.com] has joined #wesnoth-dev
20180310 19:17:11< travis-ci> gfgtdf/wesnoth#1035 (fix_2615 - 4a7a6b0 : gfgtdf): The build failed.
20180310 19:17:11< travis-ci> Build details : https://travis-ci.org/gfgtdf/wesnoth/builds/351758308
20180310 19:17:11-!- travis-ci [~travis-ci@ec2-54-224-151-168.compute-1.amazonaws.com] has left #wesnoth-dev []
20180310 19:28:37-!- vn971 [~vasya@94.158.103.15] has joined #wesnoth-dev
20180310 19:49:05< Soliton> i've setup #wesnoth-commits to receive notifications from github. anyone interested can join there.
20180310 19:50:26< vn971> Soliton: there won't be notifications right in this chat then anymore? (Good..)
20180310 19:50:51< Soliton> that is perhaps part of the plan, yes.
20180310 19:51:07< Soliton> so far i just want to see how it goes and what other people think.
20180310 19:51:44< Soliton> i do think it does get a bit noise here at times and splitting that off to a different channel might be a good idea.
20180310 19:51:51< Soliton> noisy*
20180310 19:53:15< celticminstrel> FTR irker also seems to be noiser than Github's built-in IRC notifications, which don't post a message for every single commit in large pushes.
20180310 19:54:22-!- Nobun [~user@51.179.106.37] has quit [Quit: good night everyone]
20180310 19:54:39< Soliton> i've setup https://github.com/janikrabe/codebot now. hoping it is more configurable/has more features.
20180310 19:55:31< celticminstrel> The built-in notifications are fairly basic though and IIRC not really configurable.
20180310 20:09:57-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180310 20:10:03-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20180310 20:15:43-!- zacklocx[m] [zacklocxma@gateway/shell/matrix.org/x-mkfoezzcxmahobxe] has left #wesnoth-dev ["Kicked by @appservice-irc:matrix.org  : removing from IRC because user idle on matrix for 30+ days"]
20180310 20:33:19-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20180310 20:43:48-!- vultraz [uid24821@wesnoth/developer/vultraz] has quit [Quit: Connection closed for inactivity]
20180310 20:48:29-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20180310 21:01:27-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180310 21:01:33-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20180310 21:03:35< irker660> wesnoth: gfgtdf wesnoth:gfgtdf-patch-1 64897d0fef5c / src/actions/attack.cpp: make [cancel_action] work in attack related events https://github.com/wesnoth/wesnoth/commit/64897d0fef5c26adc93f6b6f936ecf85f3683178
20180310 21:10:42-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has quit [Quit: .]
20180310 21:28:49-!- gfgtdf [~chatzilla@x4e3689d9.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.93 [Firefox 52.6.0/20180118122319]]
20180310 21:29:18-!- travis-ci [~travis-ci@ec2-54-91-142-64.compute-1.amazonaws.com] has joined #wesnoth-dev
20180310 21:29:19< travis-ci> wesnoth/wesnoth#16812 (gfgtdf-patch-1 - 64897d0 : gfgtdf): The build was fixed.
20180310 21:29:19< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/351800872
20180310 21:29:19-!- travis-ci [~travis-ci@ec2-54-91-142-64.compute-1.amazonaws.com] has left #wesnoth-dev []
20180310 21:31:34-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20180310 21:50:40-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20180310 21:51:01-!- travis-ci [~travis-ci@ec2-54-91-142-64.compute-1.amazonaws.com] has joined #wesnoth-dev
20180310 21:51:02< travis-ci> gfgtdf/wesnoth#1036 (fix_2615 - 01522c3 : gfgtdf): The build was fixed.
20180310 21:51:03< travis-ci> Build details : https://travis-ci.org/gfgtdf/wesnoth/builds/351801983
20180310 21:51:03-!- travis-ci [~travis-ci@ec2-54-91-142-64.compute-1.amazonaws.com] has left #wesnoth-dev []
20180310 21:57:48-!- Oebele [~quassel@143.177.58.202] has joined #wesnoth-dev
20180310 22:10:15-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20180310 22:11:36-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20180310 22:32:40< celticminstrel> Okay so of DeFender1031's reorganization proposal so far only wml and variable have been implemented...
20180310 22:32:59< celticminstrel> But as global table wml with subtable variable or something like that.
20180310 22:33:38< celticminstrel> And IIRC I renamed wesnoth.debug to wml.tostring instead of wml.debug.
20180310 22:33:50< DeFender1031> okay
20180310 22:33:52< celticminstrel> The proposed interface module...
20180310 22:34:20< celticminstrel> Kinda don't like the name "interface", but other than that it seems good and easily done...
20180310 22:34:43< DeFender1031> you have a better name?
20180310 22:34:45< celticminstrel> On the other hand, "ui" doesn't quite fit either...
20180310 22:34:55< celticminstrel> If there were a "ui" module I'd expect it to be the dialogs.
20180310 22:34:55< DeFender1031> Also, I assume you're leaving aliases where they were for back-compat?
20180310 22:35:06< DeFender1031> (With appropriate deprecation notices if used)
20180310 22:35:07< celticminstrel> Technically it's the new ones that are aliases ATM.
20180310 22:35:10< DeFender1031> ah
20180310 22:35:21< celticminstrel> And then the old replaced with wrappers that print deprecation notices.
20180310 22:35:36< DeFender1031> Right. That's what I mean. Sounds good.
20180310 22:35:50< celticminstrel> At some point that'll have to swap around so the old can be removed. I mean, assuming we ever want to remove the old.
20180310 22:36:23< DeFender1031> Well, point is to be able to if they interfere, or once no one is usuing them anymore
20180310 22:36:36< celticminstrel> Any objection to calling the dialog module "gui" or maybe "gui2" instead of "wesnoth.dialog"?
20180310 22:37:29< celticminstrel> Kinda want the units module to be a global table, but calling it "units" is not a good idea then...
20180310 22:38:50< celticminstrel> I think tomorrow I'll do interface, dialog/gui, and units, and see how that goes...
20180310 22:39:09< DeFender1031> gui works, I suppose.
20180310 22:39:15< celticminstrel> Might do map too.
20180310 22:39:26< DeFender1031> When I came up with the name, I think I didn't realize that GUI2 was more than just the dialog system
20180310 22:39:46-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: So long and thanks for all the fish.]
20180310 22:39:48< celticminstrel> It's the whole user interface toolkit.
20180310 22:39:54< DeFender1031> Right. I know that now.
20180310 22:39:54< celticminstrel> Oh huh mattsc was around.
20180310 22:40:58< DeFender1031> So gui is fine. I'd not call it gui2, because the name of the gui framework doesn't really affect the API itself
20180310 22:42:31< DeFender1031> for example, if we named the unit framework "jerry", I'd still think that things should be unit.whatever rather than jerry.whatever.
20180310 22:42:35< DeFender1031> gui2 just happens to be a name that's similar to the target domain
20180310 22:43:10< celticminstrel> I think it's not documented yet, but there's wesnoth.confirm() and wesnoth.alert() behaving just like the JS counterparts, should that also be moved to gui? They're aliases to an underlying message dialog function that would definitely be in gui.
20180310 22:43:31< celticminstrel> But I could see the aliases being left just in wesnoth for convenience or something, I dunno.
20180310 22:43:31< DeFender1031> absolutely
20180310 22:43:34< celticminstrel> Okay.
20180310 22:43:49 * celticminstrel assumes based on timing that the "absolutely" was not related to my additional line there.
20180310 22:44:02< DeFender1031> I'd put any canned dialogs in gui along with the direct gui functions
20180310 22:44:15< irker660> wesnoth/wesnoth:master gfgtdf c799cd2a7f make sure units are always stored in uni AppVeyor: All builds passed
20180310 22:44:19< celticminstrel> (Would be cool if we could also add the third canned dialog that JS supports.)
20180310 22:44:30< celticminstrel> (The one that asks for text input. I forget what it's called.)
20180310 22:44:41< DeFender1031> if there are enough canned dialogs, I might support a subtable for them, but yeah.
20180310 22:44:52< celticminstrel> I think there are ... four or five?
20180310 22:44:59< celticminstrel> I don't think there'll really be any more.
20180310 22:45:04< celticminstrel> Except maybe the one I just mentioned.
20180310 22:45:05< DeFender1031> There's a js dialog that asks for text input? I've never used it
20180310 22:45:21< DeFender1031> Even back before people realized that using the JS dialogs are a bad idea.
20180310 22:45:22< celticminstrel> TBH if there's a subtable I'd think it should be the core dialog stuff that goes there, not the canned dialogs.
20180310 22:45:33< DeFender1031> hmm
20180310 22:45:49< celticminstrel> Heh, I used JS dialogs for my roguelike. Then I went through and replaced them with CSS popups.
20180310 22:45:53< DeFender1031> you's have gui.whatevercannedthing and gui.core.underlyingfunction?
20180310 22:45:57< DeFender1031> I could get behind that.
20180310 22:46:05< celticminstrel> Something like that, or maybe gui.dialog.whatever.
20180310 22:46:19< DeFender1031> another option would be splitting them and having dialog.whatevercannedthing and gui.underlyingfunction
20180310 22:46:22< celticminstrel> TBH the whole "general dialog API" is really bad IMO.
20180310 22:46:27< celticminstrel> True.
20180310 23:26:07-!- Oebele [~quassel@143.177.58.202] has quit [Remote host closed the connection]
20180310 23:40:34-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 264 seconds]
20180310 23:47:02-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
--- Log closed Sun Mar 11 00:00:31 2018