--- Log opened Sun Mar 11 00:00:31 2018
20180311 00:36:10-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 240 seconds]
20180311 01:14:29< irker660> wesnoth/wesnoth:gfgtdf-patch-1 gfgtdf 64897d0fef make [cancel_action] work in attack rela AppVeyor: 1/6 builds failed
20180311 01:14:30< irker660> Details vs2013/Release: https://ci.appveyor.com/project/wesnoth/wesnoth/build/Wesnoth-VS2013-gfgtdf-patch-1-1796
20180311 01:48:04-!- vultraz [uid24821@wesnoth/developer/vultraz] has joined #wesnoth-dev
20180311 02:20:06< vultraz> celticminstrel: I'd say that's loti's problem. it's obviously using a massively-oversized image
20180311 02:20:09< vultraz> in the list
20180311 02:58:10< vultraz> celticminstrel: well, since they provided a reasonable non-loti example, I guess i need to revert it...
20180311 02:58:44< octalot> sorry
20180311 02:58:52< vultraz> though it does remind me that the default list width is ridiculously narrow 
20180311 02:58:55< vultraz> as well
20180311 02:59:57< vultraz> tbf, the SXc example doesn't look that bad.
20180311 03:00:02< vultraz> but i can't make it an option
20180311 03:00:03< vultraz> so.
20180311 03:02:34< irker660> wesnoth: Charles Dang wesnoth:master 5fc4dcf5fabe / data/gui/window/wml_message.cfg: Revert "Message Dialog: make all option rows have the same height" https://github.com/wesnoth/wesnoth/commit/5fc4dcf5fabe57c90d6cd4bf75c11d7c4039e940
20180311 03:06:44< octalot> thanks :)
20180311 03:12:58-!- octalot [~steve@178.165.131.159.wireless.dyn.drei.com] has quit []
20180311 03:17:44< vultraz> celticminstrel: poke poke poke
20180311 04:23:06< irker660> wesnoth: Charles Dang wesnoth:master 950a156712b6 / / (137 files in 43 dirs): Addressed most of the remaining whitespace issues from #2613 https://github.com/wesnoth/wesnoth/commit/950a156712b66d70c530872a638463671f13c8fb
20180311 04:24:00< vultraz> ....*shit*
20180311 04:24:08< vultraz> accidentally committed something I didn't want to
20180311 04:26:55< irker660> wesnoth: Charles Dang wesnoth:master 7ed2e57ebcbe / src/display.cpp: Fixup 950a156 (revert unintended changes) https://github.com/wesnoth/wesnoth/commit/7ed2e57ebcbe277801825464c405aa381772ace2
20180311 04:41:22< irker660> wesnoth/wesnoth:master gfgtdf c8f0e37b1b make [cancel_action] work in attack rela AppVeyor: All builds passed
20180311 04:46:45< celticminstrel> vultraz: No it's not LotI's problem, it's your narrow-mindedness.
20180311 04:47:04< vultraz> Hey, I reverted it after a sensible example was provided.
20180311 04:47:09< celticminstrel> Why can't you make it an option? I mean I'm okay with inverting it, too, but.
20180311 04:47:39< vultraz> Because as far as I know, there's no way to set a widget's linked group 
20180311 04:47:42< vultraz> dynamically
20180311 04:47:52< celticminstrel> And what's the triple-quote about?
20180311 04:47:59< celticminstrel> Uh. Since when?
20180311 04:48:04< celticminstrel> ^triple-pke
20180311 04:48:07< celticminstrel> ^poke
20180311 04:48:21< vultraz> I mean, there is a function to set the linked group, yes
20180311 04:48:44< vultraz> but it's used by the grid builder, and I don't know if using it elsewhere is safe
20180311 04:49:02< vultraz> celticminstrel: other thing was about  https://github.com/wesnoth/wesnoth/issues/2621 but gfgtdf says it's not a bug
20180311 04:49:02< celticminstrel> You could try it instead of guessing.
20180311 04:49:41< celticminstrel> I've no idea about 2621.
20180311 04:57:15< celticminstrel> (In case you haven't noticed, it always bugs me when someone says something is "impossible". It's nearly always false.)
20180311 04:59:33< celticminstrel> "If an elderly but distinguished scientist says that something is possible, he is almost certainly right; but if he says that it is impossible, he is very probably wrong."
20180311 05:23:49-!- travis-ci [~travis-ci@ec2-54-198-116-185.compute-1.amazonaws.com] has joined #wesnoth-dev
20180311 05:23:50< travis-ci> wesnoth/wesnoth#16816 (master - 7ed2e57 : Charles Dang): The build has errored.
20180311 05:23:50< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/351880515
20180311 05:23:51-!- travis-ci [~travis-ci@ec2-54-198-116-185.compute-1.amazonaws.com] has left #wesnoth-dev []
20180311 06:36:55< irker660> wesnoth: gfgtdf wesnoth:master b2cb4be47d24 / src/ (5 files in 4 dirs): Fix #2615 https://github.com/wesnoth/wesnoth/commit/b2cb4be47d245f3baafaf447e862d8cd67c22b38
20180311 06:36:57< irker660> wesnoth: gfgtdf wesnoth:master a32f6aaf649f / src/ (27 files in 13 dirs): make sure units are always stored in unit_ptr step2 https://github.com/wesnoth/wesnoth/commit/a32f6aaf649fdab306a3024034a0e8212901e91e
20180311 06:36:59< irker660> wesnoth: Celtic Minstrel wesnoth:master a8f250077336 / src/ (reports.cpp units/abilities.cpp units/attack_type.hpp): Use unit_ptr in a few more places for increased consistency https://github.com/wesnoth/wesnoth/commit/a8f2500773368555f5592862107e53566dceb9e2
20180311 06:37:01< irker660> wesnoth: Celtic Minstrel wesnoth:master afc60b9cc6b5 / src/ (15 files in 8 dirs): Rename the unit copy function (and make it non-static) https://github.com/wesnoth/wesnoth/commit/afc60b9cc6b5d929445e02b8d82b5524d6a2b1a8
20180311 06:37:03< irker660> wesnoth: Celtic Minstrel wesnoth:master 6bda3a9b6f31 / src/reports.cpp: Re-indent attack_info report function https://github.com/wesnoth/wesnoth/commit/6bda3a9b6f319e4010ab4aa663710264f99f7762
20180311 06:44:13-!- celticminstrel is now known as celmin|sleep
20180311 07:21:53-!- travis-ci [~travis-ci@ec2-54-91-142-64.compute-1.amazonaws.com] has joined #wesnoth-dev
20180311 07:21:54< travis-ci> wesnoth/wesnoth#16817 (master - 6bda3a9 : Celtic Minstrel): The build passed.
20180311 07:21:54< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/351895568
20180311 07:21:54-!- travis-ci [~travis-ci@ec2-54-91-142-64.compute-1.amazonaws.com] has left #wesnoth-dev []
20180311 07:44:31-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20180311 08:35:27-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has joined #wesnoth-dev
20180311 08:36:54-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20180311 08:50:13-!- Bonobo [~Bonobo@203.111.185.228] has joined #wesnoth-dev
20180311 09:10:27-!- Oebele [~quassel@143.177.58.202] has joined #wesnoth-dev
20180311 09:57:57< irker660> wesnoth/wesnoth:master doofus-01 85edfe051f sun-singer healing anim, and change of d AppVeyor: All builds passed
20180311 10:41:43< irker660> wesnoth/wesnoth:master gfgtdf 97e99f45fe fix build AppVeyor: All builds passed
20180311 10:48:57< irker660> wesnoth: Charles Dang wesnoth:master 4ba33d464e8a / src/ (14 files in 5 dirs): Cleaned up text rendering-related includes https://github.com/wesnoth/wesnoth/commit/4ba33d464e8a9674c36151f2509a2606b60e9490
20180311 10:59:43-!- Bonobo [~Bonobo@203.111.185.228] has quit [Quit: Leaving]
20180311 11:04:07-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has quit [Quit: .]
20180311 12:04:16-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20180311 12:22:30< irker660> wesnoth: Charles Dang wesnoth:master a7f6862210c1 / src/ (41 files in 19 dirs): More include cleanups https://github.com/wesnoth/wesnoth/commit/a7f6862210c158a18917d9283a4bf59210e636ab
20180311 12:59:25-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has joined #wesnoth-dev
20180311 13:04:25-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180311 13:04:35-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20180311 13:36:05-!- Oebele [~quassel@143.177.58.202] has quit [Remote host closed the connection]
20180311 13:49:14-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 260 seconds]
20180311 14:08:54-!- gfgtdf [~chatzilla@x4e36325c.dyn.telefonica.de] has joined #wesnoth-dev
20180311 15:18:29-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180311 15:18:35-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20180311 15:21:05-!- minzbonbon [~min@meta23.net] has quit [Ping timeout: 240 seconds]
20180311 15:23:07-!- irker660 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20180311 15:35:44-!- minzbonbon [~min@2a02:1b8:10:22:216:3eff:fe7b:f338] has joined #wesnoth-dev
20180311 15:47:09-!- irker481 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20180311 15:47:09< irker481> wesnoth/wesnoth:master Sofartin b285e153ce Fix for DEBUG_WINDOW_LAYOUT_GRAPHS macro AppVeyor: All builds passed
20180311 15:51:17< irker481> wesnoth: Sofartin wesnoth:master 733b76241d2e / src/ (game_launcher.cpp gui/widgets/debug.cpp): Fix for DEBUG_WINDOW_LAYOUT_GRAPHS macro https://github.com/wesnoth/wesnoth/commit/733b76241d2e1cd180f5f1f0ffb139dcbd3d4222
20180311 15:52:58-!- celmin|sleep is now known as celticminstrel
20180311 16:07:18-!- minzbonbon [~min@2a02:1b8:10:22:216:3eff:fe7b:f338] has quit [Ping timeout: 256 seconds]
20180311 16:07:48-!- minzbonbon [~min@meta23.net] has joined #wesnoth-dev
20180311 16:08:22< irker481> wesnoth: Celtic Minstrel wesnoth:master 9712147eed70 / data/core/units/ (dwarves/Thunderer.cfg monsters/Water_Serpent.cfg): Fix incorrect filter for Thunderer victory animation https://github.com/wesnoth/wesnoth/commit/9712147eed703add8259c104efef8e62d24f437b
20180311 16:48:16-!- vn971 [~vasya@94.158.103.15] has quit [Quit: Leaving.]
20180311 16:49:20< irker481> wesnoth: Charles Dang wesnoth:master 3a90f866746c / / (94 files in 38 dirs): Addressed more whitespace issues from #2613 https://github.com/wesnoth/wesnoth/commit/3a90f866746cf6d2a2bbfd213f803cdfec1c4df1
20180311 17:00:08< celticminstrel> DeFender1031: We have "wesnoth.show_message_dialog" which is the dialog typically used for talking and narration; and "wesnoth.show_message_box", which shows a dialog like the quit confirmation. What should these be called in the gui module?
20180311 17:00:15< celticminstrel> They can't both be "show_message".
20180311 17:07:38-!- octalot [~steve@178.115.128.212.wireless.dyn.drei.com] has joined #wesnoth-dev
20180311 17:19:36< irker481> wesnoth: gfgtdf wesnoth:master 30e863e74adb / src/actions/attack.cpp: make [cancel_action] work in attack related events (#2625) https://github.com/wesnoth/wesnoth/commit/30e863e74adb972690b13c4c39a6e6dd6a487323
20180311 17:23:43< vultraz> Show message and show prompt
20180311 17:34:26-!- atarocch [~atarocch@93.56.164.28] has joined #wesnoth-dev
20180311 17:35:26< DeFender1031> celticminstrel, 1. those would both be canned dialogs, I think. 2. I think probably something like "story message" and "confirm" maybe?
20180311 17:35:49< celticminstrel> confirm and alert are wrappers for that function.
20180311 17:36:18< celticminstrel> Confirm and alert let you specify a message and an optional title.
20180311 17:36:40< celticminstrel> show_message_box additionally lets you specify a button style, which IIRC can be one of yes_no, ok_cancel, ok
20180311 17:36:45< celticminstrel> Might be one or two other options too.
20180311 17:37:04< celticminstrel> Note that we also have show_story.
20180311 17:37:15< celticminstrel> So with your proposal we'd have show_story and show_story_message.
20180311 17:37:31< celticminstrel> What do you think of vultraz's proposal?
20180311 17:38:45< celticminstrel> The other button options are close and cancel.
20180311 17:38:55< celticminstrel> alert() uses ok; confirm IIRC uses yes_no.
20180311 17:39:24< celticminstrel> The only other extra option you get when using show_message_box is to enable markup.
20180311 17:41:05< celticminstrel> Oh right, with show_message_box I think you can also specify any other string and it'll use that as the name of the single button... though this is slightly broken right now because it converts it to lowercase...
20180311 17:41:55< irker481> wesnoth: gfgtdf wesnoth:master 4943e6dbcf10 / src/editor/map/map_context.cpp: avoid unnecessary copying of units in editor https://github.com/wesnoth/wesnoth/commit/4943e6dbcf1087c9a164a98346368d26340be84b
20180311 17:41:58< DeFender1031> hmm
20180311 17:42:17< DeFender1031> story message and dialog message?
20180311 17:42:21< DeFender1031> or... hmm...
20180311 17:42:43< DeFender1031> dialogue message and dialog message :P
20180311 17:42:58< DeFender1031> that won't be confusing at alllllll!
20180311 17:44:49< celticminstrel> Oh, and with show_message_box you can pass an empty string as the button and it'll have no buttons and close automatically...
20180311 17:45:08< DeFender1031> hmm
20180311 17:46:12< DeFender1031> well, the core difference between them is that one is designed for in-universe messages, and one is designed for user interaction messages
20180311 17:46:27< DeFender1031> so whatever the names are, they should indicate that difference
20180311 17:46:55< celticminstrel> Do you think it's a problem to have both show_story_message and show_story?
20180311 17:47:01< DeFender1031> (though, occasionally [message]s are used for player information as well, so...)
20180311 17:47:08< celticminstrel> I think I like vultraz's idea of show_prompt for show_message_box.
20180311 17:47:22< celticminstrel> Another possibility for the in-universe one is show_narration, I suppose.
20180311 17:47:34< DeFender1031> hmmm
20180311 17:47:36< DeFender1031> narration works
20180311 17:48:44< gfgtdf> does "turns=0" ever make sense in any scneario ?
20180311 17:50:59< irker481> wesnoth: Celtic Minstrel wesnoth:master ab354737ef6b / src/scripting/lua_gui2.cpp: Fix wesnoth.show_message_box ignoring user-specified case for button label https://github.com/wesnoth/wesnoth/commit/ab354737ef6bea42d439671752435f0166f0e004
20180311 17:51:50< irker481> wesnoth: Celtic Minstrel wesnoth:lua_reorg 5000cd105a7b / data/lua/helper.lua: Rewrite helper.move_unit_fake to not use a WML variable https://github.com/wesnoth/wesnoth/commit/5000cd105a7bbbc6ae9bd66de4c6fd016f79d4b1
20180311 17:51:52< irker481> wesnoth: Celtic Minstrel wesnoth:lua_reorg 267b7f859fad / data/lua/ (core.lua helper.lua wml/items.lua): Lua API reorganization: interface module https://github.com/wesnoth/wesnoth/commit/267b7f859fad648591d63efcb92bc34a2598a698
20180311 17:51:54< irker481> wesnoth: Celtic Minstrel wesnoth:lua_reorg 8ab218547255 / data/lua/ (core.lua helper.lua wml/items.lua): Lua API reorganization: interface module deprecations https://github.com/wesnoth/wesnoth/commit/8ab2185472558420c2446267e61fcec053121dae
20180311 17:51:56< irker481> wesnoth: Celtic Minstrel wesnoth:lua_reorg c32c095f3b1a / data/lua/helper.lua: Use wml.tag in helper.get_user_choice https://github.com/wesnoth/wesnoth/commit/c32c095f3b1a1ad74317908e7858500061ec3634
20180311 17:51:58< irker481> wesnoth: Celtic Minstrel wesnoth:lua_reorg 141e00492013 / data/lua/ (core.lua helper.lua): Lua API reorganization: GUI module https://github.com/wesnoth/wesnoth/commit/141e00492013df93764a4018fc710293fa8680d2
20180311 17:52:00< irker481> wesnoth: Celtic Minstrel wesnoth:lua_reorg 2f30e5acb82d / data/lua/ (core.lua helper.lua): Lua API reorganization: GUI module deprecations https://github.com/wesnoth/wesnoth/commit/2f30e5acb82d5c782de30fc96567504eee84ba05
20180311 17:52:02< irker481> wesnoth: Celtic Minstrel wesnoth:lua_reorg 08e086dd239e / data/lua/helper.lua: Rewrite helper.modify_unit to not use a WML variable https://github.com/wesnoth/wesnoth/commit/08e086dd239e466d68587ed34a93ae31bda46ede
20180311 17:52:04< irker481> wesnoth: Celtic Minstrel wesnoth:lua_reorg ba56a647d3d5 / data/lua/ (core.lua helper.lua): Lua API reorganization: units module https://github.com/wesnoth/wesnoth/commit/ba56a647d3d562e20eae3cdeb42556ac92086c34
20180311 17:52:06< irker481> wesnoth: Celtic Minstrel wesnoth:lua_reorg cb5fb172481e / data/lua/ (core.lua helper.lua): Lua API reorganization: units module deprecations https://github.com/wesnoth/wesnoth/commit/cb5fb172481e9b6cd10b9da9c414d9903f86ef66
20180311 17:52:11< celticminstrel> gfgtdf: I doubt it, unless maybe a cutscene scenario?
20180311 17:57:28-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20180311 17:58:45< irker481> wesnoth: Sofartin wesnoth:accelerated_rendering 7633ebc0be06 / projectfiles/Xcode/Wesnoth.xcodeproj/project.pbxproj: Fixed Xcode Project https://github.com/wesnoth/wesnoth/commit/7633ebc0be06457eae4d36b47bd51181ea280b85
20180311 17:59:24< irker481> wesnoth: Celtic Minstrel wesnoth:lua_reorg 9d6c54518c99 / data/lua/core.lua: Lua GUI module: minor fix, plus name changes from discussions https://github.com/wesnoth/wesnoth/commit/9d6c54518c99457c9c7c9e6f63fa19b2b5e321f1
20180311 17:59:59< octalot> shadowm (and esr): should instances of "shadow master" in misc/fortunes/wesnoth be updated?
20180311 18:00:30< celticminstrel> DeFender1031: If you want to take a look, it's at https://github.com/wesnoth/wesnoth/pull/2635
20180311 18:05:57< zookeeper> gfgtdf, if/since -1 denotes no turn limit, i don't see what 0 could be used for...
20180311 18:07:54< esr> octalot: I have no objection.
20180311 18:23:33< irker481> wesnoth/wesnoth:master Gregory A Lundberg 21f022576a Use standard names AppVeyor: vs2017/Release Failed
20180311 18:23:34< irker481> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-master-1503
20180311 18:57:30-!- octalot [~steve@178.115.128.212.wireless.dyn.drei.com] has quit []
20180311 18:59:05< celticminstrel> BTW vultraz, those whitespace changes, are they basically all trailing whitespace?
20180311 19:01:58< celticminstrel> Maybe some mixed tab/space in leading indentation?
20180311 19:24:27-!- octalot [~steve@178.115.128.212.wireless.dyn.drei.com] has joined #wesnoth-dev
20180311 19:31:30< shadowm> octalot: I actually looked at it a couple of nights ago in fact.
20180311 19:31:46< shadowm> Are you the author of PR #2636?
20180311 19:39:40< irker481> wesnoth/wesnoth:master Gregory A Lundberg 21f022576a Use standard names AppVeyor: 3/6 builds failed
20180311 19:39:41< irker481> Details vs2017/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-master-1503
20180311 19:39:42< irker481> Details vs2013/Release: https://ci.appveyor.com/project/wesnoth/wesnoth/build/Wesnoth-VS2013-master-1811
20180311 19:39:43< irker481> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-1799
20180311 19:46:51-!- vultraz [uid24821@wesnoth/developer/vultraz] has quit [Quit: Connection closed for inactivity]
20180311 19:51:16< DeFender1031> celticminstrel, btw, I want to thank you that despite my flakiness of having promised to work on stuff and then having life circumstances change such that I couldn't, you're still taking a bunch of my ideas and working on them.
20180311 19:51:50< celticminstrel> Well, they were good ideas, so.
20180311 19:54:48< DeFender1031> still, a lot of people's attitude would be "why should we listen to this guy? he makes demands, promises to work, and then gives nothing back" and I'm gratified that that's not how you work
20180311 19:55:48< celticminstrel> Any chance still that you'll do the string utils updates that you've talked about?
20180311 19:56:03< celticminstrel> Because that's one thing that I'm not really interested in doing even though I think it's a good idea. >_>
20180311 19:56:56< octalot> shadowm: yes, I'm stevecotton on Github
20180311 19:58:58< DeFender1031> celticminstrel, well, it's definitely something I'm still INTERESTED in doing, for sure, which makes it something for which there's a chance.
20180311 20:06:13< shadowm> octalot: Changing references in the data/campaigns/*/HISTORY files seems off-limits to me since they are VCS logs and they're supposed to be faithful to the source.
20180311 20:07:19< octalot> shadowm: I'm happy to drop those changes. The whole PR is because I was looking at LoW's macros and thought "ooh, will fix that"
20180311 20:08:31< shadowm> The same applies to the fortunes. Several people in them have changed their nick's spelling slightly over time and I've never felt like that's a thing that needs to be fixed unless they required it. In my case I switched to shadowm about 5 years ago and I don't feel like it's an issue that needs to be fixed.
20180311 20:09:21-!- Oebele [~quassel@143.177.58.202] has joined #wesnoth-dev
20180311 20:09:32< shadowm> I don't have a strong opinion wrt the code comments and documentation since they are for most intents and purposes invisible.
20180311 20:10:10< shadowm> (By all means umcd is a failed experimental project that only got us grants from Google for Summer of Code twice in a row.)
20180311 20:11:12< octalot> In that case, I should have waited for you to respond instead of just doing it.
20180311 20:11:34< shadowm> (There was absolutely no traction behind it and while some of the ideas might have been good, if someone's going to rewrite the add-ons server now they can probably do a far better job with fresh ideas.)
20180311 20:12:56< shadowm> I'll repost this in the PR for reference.
20180311 20:13:08< octalot> ty, and sorry for the noise
20180311 20:13:15< APic> Never mind.
20180311 20:14:01< shadowm> octalot: Don't worry about it, it's okay. :)
20180311 20:14:50 * celticminstrel is confused by APic's sudden "never mind".
20180311 20:17:45< APic> celticminstrel: Never mind.
20180311 20:25:55< celticminstrel> What a great way to not dispel the confusion.
20180311 20:26:22< DeFender1031> "Never mind, donkey."
20180311 20:26:47< celticminstrel> I don't even know how to react to that.
20180311 20:39:55< DeFender1031> It's a shrek reference... never mind.
20180311 20:40:13< DeFender1031> You have to read it in the scottish accent.
20180311 20:49:40-!- travis-ci [~travis-ci@ec2-54-147-44-1.compute-1.amazonaws.com] has joined #wesnoth-dev
20180311 20:49:41< travis-ci> wesnoth/wesnoth#16831 (accelerated_rendering - 7633ebc : Sofartin): The build is still failing.
20180311 20:49:41< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/352034746
20180311 20:49:41-!- travis-ci [~travis-ci@ec2-54-147-44-1.compute-1.amazonaws.com] has left #wesnoth-dev []
20180311 21:12:14< celticminstrel> Oh shrek, been awhile since I saw that.
20180311 21:16:25< octalot> Has anyone tried multiplayer LoW on 1.13.x recently? It doesn't seem to create the persistent storage for restarting the campaign from a later chapter with characters from the previous chapter (and yes, I'm playing it in multiplayer mode).
20180311 21:18:53< gfgtdf> but you can still just reload the start-of-scenario save right ?
20180311 21:19:33< gfgtdf> instead of starting form a later chapter i mean.
20180311 21:21:46< octalot> yes
20180311 21:23:23< octalot> I'm actually looking at this to unblock PR #2585, which I said that I hadn't tested with persistent saves.
20180311 21:25:38-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20180311 21:26:01< gfgtdf> how did you test it? did you look at the persistencewml file to chack that there is no data, or did you just test that it didn't work when startiong the next chaper?
20180311 21:27:22< gfgtdf> check*
20180311 21:27:57-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20180311 21:29:00< octalot> I looked in the "persist" directory (testing on Linux). The persistent data for AE and 1.12.6's LoW is saved to the respective version's persist directory; but for 1.13 only AE's settings are saved there.
20180311 21:30:33< gfgtdf> hmm
20180311 21:31:02< octalot> I'll file a bug
20180311 21:32:34< celticminstrel> Argh I accidentally hit rebuild instead of build :(
20180311 21:34:04< gfgtdf> ok i triee to test it and i got  mean lua error
20180311 21:34:08< gfgtdf> tried
20180311 21:34:24< gfgtdf> range check failure in set_village_owner
20180311 21:34:50< gfgtdf> i'm testign on 1.13.11 rlease though
20180311 21:34:55< gfgtdf> maybe this is known and fixed ?
20180311 21:34:56< octalot> are you testing with the tagged 1.13.11? That's been fixed since then
20180311 21:36:10< octalot> it's #2505
20180311 21:36:43< gfgtdf> ok then i'll wait for appveyor fo finish and download a newer wesnoth.exe to test
20180311 21:37:51-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20180311 21:38:09< gfgtdf> octalot: here is the codle that handled these persuistent storage iof ou want to take a look https://github.com/wesnoth/wesnoth/blob/master/data/campaigns/Legend_of_Wesmere/lua/wml_tags.lua#L62
20180311 21:39:15-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20180311 21:39:44-!- travis-ci [~travis-ci@ec2-54-147-44-1.compute-1.amazonaws.com] has joined #wesnoth-dev
20180311 21:39:45< travis-ci> wesnoth/wesnoth#16832 (lua_reorg - 9d6c545 : Celtic Minstrel): The build has errored.
20180311 21:39:45< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/352034833
20180311 21:39:45-!- travis-ci [~travis-ci@ec2-54-147-44-1.compute-1.amazonaws.com] has left #wesnoth-dev []
20180311 21:41:45< Soliton> any opinions on moving most/all of the bot messages over to #wesnoth-commits (or some other channel name if someone has a better one) leaving here just for dev chat?
20180311 21:42:50< JyrkiVesterinen> I'd prefer that.
20180311 21:43:10< JyrkiVesterinen> I use both IRC and Discord, and I'd prefer seeing commit notifications only in one place.
20180311 21:46:00< zookeeper> but then it means everyone (who wants to be able to spot interesting commits) needs to stay on and monitor another channel as well.
20180311 21:46:37< celticminstrel> Is #wesnoth-commits logged? That might be relevant to this discussion.
20180311 21:46:40< zookeeper> i guess i don't object myself, but it might lead to people missing commits they would otherwise have remarks/questions/whatever about
20180311 21:46:59< JyrkiVesterinen> Is it a problem? Any IRC client supports joining multiple channels, and many have automatic join.
20180311 21:47:12< zookeeper> not a technical problem
20180311 21:47:31< Soliton> celticminstrel: it can easily be logged if we decide to use it in earnest.
20180311 21:48:02< gfgtdf> octalot: ok i tried again on 1.13.11 bny just :n-ing 3 times and it correctly genered the persistent storage for me, even with the range check failure in set_village_owner thing
20180311 21:48:09< Soliton> i think that the discussion benefits from commits being announced is exceedingly rare.
20180311 21:48:11< celticminstrel> It's technically already harder to spot interesting commits in #wesnoth-commits right?
20180311 21:48:27< celticminstrel> Since if there's a large push it only shows the count and the first few commits.
20180311 21:48:45< Soliton> currently it shows all of them afaict.
20180311 21:48:54< octalot> gfgtdf: thanks, will check that locally too and see if it's my setup or a change in the code
20180311 21:49:07< celticminstrel> I guess we'll find out when I push this next schema update.
20180311 21:49:42< Soliton> your lua_reorg was 9 commits and it showed each.
20180311 21:49:57< gfgtdf> octalot: tested the scenario 3-4 transition,  (chapter 1-2)
20180311 21:50:04< celticminstrel> Oh, you're right. Okay then.
20180311 21:51:28< zookeeper> i think this is the first time i hear the suggestion to move commit echoing off of this channel where they've always been before, so it's hard to say right away.
20180311 21:54:22< Soliton> IMO the advantage is that it's much easier to see what other devs said even if it's already been a while with no actual chatting in between.
20180311 21:55:09< Soliton> i think it's much rarer that you benefit from some random commit announcement to discuss that.
20180311 21:55:37< Soliton> and for the most part commits are better discussed on github nowadays.
20180311 21:56:57< Soliton> (and of course it'll still be possible to discuss commits here even if they might be announced in a different channel.)
20180311 21:59:15< octalot> gfgtdf: thanks, it seems the chapter 1-2 transition does work for me too
20180311 21:59:33-!- Oebele [~quassel@143.177.58.202] has quit [Remote host closed the connection]
20180311 22:00:01< gfgtdf> so which one doesn't work ?
20180311 22:01:42< zookeeper> Soliton, yeah, i guess the only drawback is essentially just the fact that then there's two channels. two channels to monitor for stuff, to remember to check the logs of, to get everyone (who should) to stay on.
20180311 22:02:07< zookeeper> of course, it's not like that's a huge problem.
20180311 22:03:15< octalot> gfgtdf the 2-3 transition (sorry, thought I'd typed the earlier, but I didn't)
20180311 22:09:42< Soliton> #wesnoth-commits is now logged as well.
20180311 22:11:58< Soliton> if anyone has a better name feel free to suggest it though.
20180311 22:19:02-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has quit [Quit: .]
20180311 22:25:11-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20180311 22:25:53-!- gfgtdf [~chatzilla@x4e36325c.dyn.telefonica.de] has quit [Read error: Connection reset by peer]
20180311 22:26:27< mattsc> Hey celticminstrel 
20180311 22:41:48-!- irker481 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20180311 23:00:01-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20180311 23:26:47< celticminstrel> Hi.
20180311 23:29:54-!- vultraz [uid24821@wesnoth/developer/vultraz] has joined #wesnoth-dev
20180311 23:30:00< vultraz> celticminstrel: no, there are also “space before tab indent” and excessive new lines at EOF
20180311 23:31:22< vultraz> Admittedly I’ve messed up indent a bit fixing a few cases of the former
20180311 23:31:24-!- irker201 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20180311 23:31:24< irker201> wesnoth/wesnoth:lua_reorg Celtic Minstrel cb5fb17248 Lua API reorganization: units module dep AppVeyor: vs2017/Release Failed
20180311 23:31:24< irker201> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-lua_reorg-1507
20180311 23:33:05< celticminstrel> Well this is a bit more tricky than I expected, so for now I guess I'll just push the rebase with a commit that can be cherry-picked.
20180311 23:33:39< irker201> wesnoth: Celtic Minstrel wesnoth:schema 3d1de07ca735 / / (44 files in 10 dirs): Implement validation of the core game config WML https://github.com/wesnoth/wesnoth/commit/3d1de07ca7355fe33a49636cd1ac007d56a18a66
20180311 23:33:41< irker201> wesnoth: Celtic Minstrel wesnoth:schema 28297c088be3 / data/schema/core/addons.cfg: Address some feedback https://github.com/wesnoth/wesnoth/commit/28297c088be33f4374c5fc8e05ba0618821a0177
20180311 23:33:43< irker201> wesnoth: Celtic Minstrel wesnoth:schema 8128614bb6d1 / data/schema/ (core/config.cfg game_config.cfg terrain/graphics.cfg): Address a few TODO notes https://github.com/wesnoth/wesnoth/commit/8128614bb6d13ceb0ba71c19b6dd9ced691cf402
20180311 23:33:45< irker201> wesnoth: Celtic Minstrel wesnoth:schema 19cdacfb6f3f / data/gui/schema.cfg data/schema/gui.cfg src/gui/gui.cpp: Move GUI2 schema into the schema directory https://github.com/wesnoth/wesnoth/commit/19cdacfb6f3f147bbb3ddbc7da7cd1ccc6d52254
20180311 23:33:47< irker201> wesnoth: Celtic Minstrel wesnoth:schema d4eeef0d416d / / (5 files in 3 dirs): Get game config and schema to use some common types https://github.com/wesnoth/wesnoth/commit/d4eeef0d416d7b9c1cc12e4c65e95e263e513c98
20180311 23:33:49< irker201> wesnoth: Celtic Minstrel wesnoth:schema 79c7c29d221d / src/ (commandline_options.cpp wesnoth.cpp): Make --report imply --wconsole on Windows https://github.com/wesnoth/wesnoth/commit/79c7c29d221ddc9c1fe6ae7635847fa99af41203
20180311 23:33:51< irker201> wesnoth: Celtic Minstrel wesnoth:schema edc73ba637b5 / src/build_info.cpp: WIP sanitizing build info to omit username https://github.com/wesnoth/wesnoth/commit/edc73ba637b51eed09159ebfae48ccad8260774e
20180311 23:33:53< irker201> wesnoth: Celtic Minstrel wesnoth:schema d80f279d223f / / (5 files in 2 dirs): Enable nesting of [type] tags https://github.com/wesnoth/wesnoth/commit/d80f279d223ff48d7ee2885776fd13cc9c796c8f
20180311 23:33:55< irker201> wesnoth: Celtic Minstrel wesnoth:schema b4199b6a1289 / src/serialization/tag.hpp: Super-rudimentary documentation... https://github.com/wesnoth/wesnoth/commit/b4199b6a1289577a0c12d6f6f2565efb63bb7e42
20180311 23:33:57< irker201> wesnoth: Celtic Minstrel wesnoth:schema 63ae3576becf / changelog src/units/attack_type.cpp: Add set_range in [effect]apply_to=attack https://github.com/wesnoth/wesnoth/commit/63ae3576becff3922c65aea5811389b48c3c40c4
20180311 23:34:01< celticminstrel> Interesting, the other bot is much faster at announcing commits.
20180311 23:34:17< celticminstrel> vultraz: That last commit is cherry-pickable IMO.
20180311 23:35:36-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20180311 23:35:42< vultraz> omit username, eh
20180311 23:35:49< celticminstrel> ?
20180311 23:35:56< vultraz> just looking at one of your commit
20180311 23:35:57< vultraz> s
20180311 23:36:03< celticminstrel> Which one?
20180311 23:36:13< celticminstrel> Oh the WIP one.
20180311 23:36:13< vultraz> WIP sanitizing build info to omit username 
20180311 23:36:25< celticminstrel> That might be also cherry-pickable, but needs more testing IMO.
20180311 23:36:42< celticminstrel> Also doesn't work on my computer because I broke my Windows awhile back.
20180311 23:36:54< vultraz> Not sure why it's necessary
20180311 23:37:09< celticminstrel> So my "official" user folder is not the folder all my stuff is in.
20180311 23:37:11< vultraz> I guess for people pasting logs?
20180311 23:37:16< celticminstrel> It's privacy concerns, yeah.
20180311 23:37:23< celticminstrel> Apple does this automatically in crash reports now.
20180311 23:37:30< vultraz> ah
20180311 23:37:34< celticminstrel> (It replaces your username with "USERNAME" IIRC.)
20180311 23:37:40< vultraz> ok, if it's an industry standard
20180311 23:37:45< vultraz> even better
20180311 23:38:03< celticminstrel> (That method is also easily implemented instead of the home-dir method I used, if you prefer that.)
20180311 23:38:29< celticminstrel> IIRC I can get a free crash report by launching Blades of Exile...
20180311 23:38:35< vultraz> lol
20180311 23:38:48< celticminstrel> Or maybe it was my personal project. One or both crashes on exit.
20180311 23:38:57< vultraz> ...man, a lone "lol" seems very out-of-place
20180311 23:39:24< celticminstrel> I've set my IRC client to replace "lol" with an emoticon that looks like XD
20180311 23:39:36< celticminstrel> So I never have to see "lol", yay!
20180311 23:39:50< vultraz> :P
20180311 23:40:04< vultraz> I usually say lmao
20180311 23:40:19< celticminstrel> What's that one stand for again?
20180311 23:40:54< vultraz> laughing my ass off
20180311 23:41:04-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 256 seconds]
20180311 23:41:13< vultraz> it's usually said whilst one is gazing at their phone with a blank expression
20180311 23:41:21< vultraz> in response to something that's amusing 
20180311 23:41:34< vultraz> now, if you say "LMAO", that means you're actually laughing
20180311 23:42:01< celticminstrel> Maybe I should set my client to replace "rofl" and "lmao" with XD too.
20180311 23:42:34< vultraz> ecks dee
20180311 23:45:05-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Remote host closed the connection]
20180311 23:45:34-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20180311 23:45:55 * celticminstrel also wonders if mattsc wanted something.
20180311 23:48:02< celticminstrel> Okay, found the free crash report (it was the personal project, not BoE), and what it does is simply replace all instances of your username with the string "USER".
20180311 23:48:32< celticminstrel> I don't think Windows has any such sanitization (at least based on my experience with UE which IIUC uses OS-provided info for its crash-report dialog).
20180311 23:48:35< vultraz> not bad
20180311 23:49:10< celticminstrel> So anyway, if you prefer I do that instead of replacing all instances of their home directory with %USERDIR% or $HOME, then I'll do it.
20180311 23:49:13-!- deathisundead_ [~quassel@2601:40a:c380:462:6846:845c:b57a:4b9a] has quit [Read error: Connection reset by peer]
20180311 23:50:00< vultraz> I guess it makes more sense
20180311 23:50:05< vultraz> maybe a bit less secure?
20180311 23:50:13< vultraz> but if apple does it its fine
20180311 23:50:29-!- deathisundead [~quassel@2601:40a:c380:462:6846:845c:b57a:4b9a] has joined #wesnoth-dev
20180311 23:50:34< celticminstrel> I don't think there's any difference in the level of security between the two approaches.
20180311 23:51:03< celticminstrel> I suppose maybe one approach might (on Windows) leak whether you store your userdata on a different drive, but I doubt that really matters.
20180311 23:51:18< vultraz> but yeah, I'm fine with the USER approach
20180311 23:51:26< celticminstrel> (It wouldn't leak that information on Unix because you'd just have a mount-point for /home or /Users)
--- Log closed Mon Mar 12 00:00:33 2018