--- Log opened Mon Mar 12 00:00:33 2018
20180312 00:03:49< mattsc> celticminstrel: no, just letting you know I am here.  Since you had pinged me a couple times over the last week or so.  So just wondering if you wanted something.
20180312 00:04:33< octalot> never mind :D
20180312 00:04:33< vultraz> someone mentioned micro ais not working?
20180312 00:04:35< celticminstrel> mattsc: The only thing I recall pinging you for recently was that issue about the simulate_combat something something.
20180312 00:04:42< celticminstrel> vultraz: Wait what?
20180312 00:04:47< vultraz> on discord
20180312 00:04:51< vultraz> in general
20180312 00:04:58< vultraz> so you should have seen it on irc
20180312 00:05:02< mattsc> celticminstrel: right, you did.  And I replied to that.
20180312 00:05:10< celticminstrel> mattsc: Wait, you did?
20180312 00:05:12< vultraz> oh wait
20180312 00:05:23< vultraz> no, it was something about the goto mai not handling tunnels
20180312 00:05:26< celticminstrel> vultraz: I do have 3 unread posts in the general channel.
20180312 00:05:36< mattsc> But then you mentioned me again yesterday.  I guess that you didn’t ping me directly, but I get pinged when somebody mentiones my nick.
20180312 00:05:39< vultraz> "Ah, alright. So I wanted the [micro_ai] to maneuver a leader unit to a place, that can only be reached via [tunnel]. Apparently, the AI does not really like that. I removed the tunnel and it is working as expected now"
20180312 00:05:52< vultraz> "well, from a purely cursory glance it looks like maybe function ca_goto:execution(cfg, data) does some manual pathfinding of its own first (which then wouldn't take tunnels into account)."
20180312 00:05:54< celticminstrel> mattsc: IIRC that was just me noticing you had been around?
20180312 00:05:59< vultraz> (latter is zookeeper)
20180312 00:06:01< celticminstrel> I can't remember.
20180312 00:06:18< celticminstrel> vultraz: Well, I don't see that in #wesnoth, at least.
20180312 00:06:19< mattsc> celticminstrel: yep.  So this time I saved you the noticing.  ;)
20180312 00:06:30< mattsc> Anyways, if there’s nothing new, we’re good.
20180312 00:06:38< mattsc> vultraz: I’ll have a look.
20180312 00:07:30< vultraz> OT: being able to forward-declare enum classes is effing *awesome*
20180312 00:08:14< celticminstrel> What about regular enums?
20180312 00:08:21< vultraz> don't think so
20180312 00:08:38< celticminstrel> Well that's not very useful then.
20180312 00:08:54< mattsc> celticminstrel: FYI:
20180312 00:08:55< mattsc> 20180306 23:08:07< mattsc> celmin: yeah, unfortunately I am barely around these days.  I did just check the backstab bug #2247 though and it looks fixed.  
20180312 00:10:17< vultraz> I think I'll just include th eheader in window.hpp tho
20180312 00:12:10< vultraz> or maybe not!
20180312 00:12:21< vultraz> 100% ponder
20180312 00:14:05< octalot> yup, you can forward declare enums, but you have to define the underlying type
20180312 00:14:51< celticminstrel> In the forward declaration?
20180312 00:15:13< octalot> for a scoped enum, a forward declaration defaults to having underlying type int; for a non-scoped enum not specifying the type is a compile error
20180312 00:15:22< celticminstrel> Ah.
20180312 00:15:31< celticminstrel> So "enum thing : char;" for example.
20180312 00:15:50< octalot> should work
20180312 00:15:58< vultraz> celticminstrel: I'm splitting the default revals into their own file with an enum class
20180312 00:16:03< vultraz> im debating including that file in window.hpp or ot
20180312 00:16:05< vultraz> not
20180312 00:17:20< irker201> wesnoth: Celtic Minstrel wesnoth:schema e333aef03eeb / / (5 files in 2 dirs): Enable nesting of [type] tags https://github.com/wesnoth/wesnoth/commit/e333aef03eebcab3582e524b68a5982df28ce668
20180312 00:17:22< irker201> wesnoth: Celtic Minstrel wesnoth:schema 818d85261a60 / src/serialization/tag.hpp: Super-rudimentary documentation... https://github.com/wesnoth/wesnoth/commit/818d85261a601acc7f660da08775d4e853edc762
20180312 00:17:24< irker201> wesnoth: Celtic Minstrel wesnoth:schema cc9f9e917f10 / changelog src/units/attack_type.cpp: Add set_range in [effect]apply_to=attack https://github.com/wesnoth/wesnoth/commit/cc9f9e917f1057e82451c40521f1457bad6c5f83
20180312 00:17:26< irker201> wesnoth: Celtic Minstrel wesnoth:schema c1602ab77b41 / src/ (commandline_options.cpp wesnoth.cpp): Make --report imply --wconsole on Windows https://github.com/wesnoth/wesnoth/commit/c1602ab77b4192e7889b2ecfbc09df6f088b8332
20180312 00:17:28< irker201> wesnoth: Celtic Minstrel wesnoth:schema 339059f4bae8 / src/ (build_info.cpp filesystem.hpp filesystem_boost.cpp wesnoth.cpp): Sanitize the build info report to blank out the user's name https://github.com/wesnoth/wesnoth/commit/339059f4bae8bc35dc5faf2e66032cbd28b0cb67
20180312 00:17:32< vultraz> celticminstrel: giff thoughts
20180312 00:17:36< celticminstrel> vultraz: Last three commits can be cherry-picked.
20180312 00:18:03< mattsc> vultraz: the Goto Micro AI uses custom pathfinding for some parameter settings.  In other words, it uses wesnoth.find_path() with a custom cost function.  Apparently find_path does not take tunnels into account when using a custom cost function.
20180312 00:18:26< celticminstrel> mattsc: That actually kinda makes sense, since tunnels are part of the cost function.
20180312 00:18:41< celticminstrel> The cost function is something like "steps from here to there".
20180312 00:19:12< mattsc> celticminstrel: yes, but isn’t it the job of the wrapper function to determine which hexes are “adjacent”?
20180312 00:19:19< celticminstrel> vultraz: As for the enum, if you have a file containing only enums, I don't see any reason not to just include the file. IMO the best reason to forward-declare an enum is because it's declared in a heavy-weight header that defines a bunch of classes or includes a bunch of things.
20180312 00:19:50< mattsc> The cost function just says how much it takes to enter a hex, not from where you can get there.
20180312 00:19:51< celticminstrel> mattsc: I'm not sure, but I don't think so? I think "adjacent" tiles would be defined as ones where the cost from the current tile to that tile is 1.
20180312 00:20:05< mattsc> celticminstrel: nope, definitely not.
20180312 00:20:15< celticminstrel> I might be misunderstanding this, let me look at the code.
20180312 00:20:25< mattsc> The cost, in the default setting, is the terrain movement cost for the tile.
20180312 00:20:34< celticminstrel> Hmm.
20180312 00:21:18< celticminstrel> Do you know where the default cost function is defined?
20180312 00:21:23< mattsc> So if this interpretation is correct (it also comes just from a cursory look at the code, just as zookeeper’s), then this is arguable not caused by the MAI, but by the A* search algorithm.
20180312 00:21:28< mattsc> But I might be wrong ...
20180312 00:23:16< celticminstrel> Do you know where the default cost function is defined?
20180312 00:24:57< celticminstrel> I think I might've found it.
20180312 00:25:06-!- travis-ci [~travis-ci@ec2-54-224-175-3.compute-1.amazonaws.com] has joined #wesnoth-dev
20180312 00:25:07< travis-ci> wesnoth/wesnoth#16836 (schema - 63ae357 : Celtic Minstrel): The build is still failing.
20180312 00:25:07< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/352119148
20180312 00:25:07-!- travis-ci [~travis-ci@ec2-54-224-175-3.compute-1.amazonaws.com] has left #wesnoth-dev []
20180312 00:26:20< celticminstrel> For example, here: https://github.com/wesnoth/wesnoth/blob/master/src/pathfind/pathfind.cpp#L723
20180312 00:28:50< celticminstrel> So I guess you're right, it returns the cost to enter a tile without reference to a source tile.
20180312 00:28:58< mattsc> celticminstrel: yes, but the teleport map is not built in the cost function.
20180312 00:29:16< mattsc> Sorry, posts crossed in the irc ether
20180312 00:32:25< celticminstrel> Looks like wesnoth.find_path() is set up to consider the teleport map if requested.
20180312 00:32:39< celticminstrel> In fact, it seems to consider it by default.
20180312 00:33:06< mattsc> Yes, it is.  Right
20180312 00:33:14< celticminstrel> In fact, it's not set up to ignore it when you use a custom cost function...
20180312 00:33:50< celticminstrel> Which seems like a significant shortcoming, but isn't really relevant here.
20180312 00:34:08< mattsc> Okay; maybe that’s not the cause of the problen then.
20180312 00:34:28< mattsc> I’ll have to have a closer look at it sometime then.
20180312 00:34:45< mattsc> And maybe Kwandulin can provide the exact settings used when he encountered the problem.
20180312 00:38:05-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 240 seconds]
20180312 00:39:30< vultraz> aw, crap
20180312 00:39:43< vultraz> enum class not implicitly convertible to its base type. oh well.
20180312 00:40:52< celticminstrel> Just cast it. int(e)
20180312 00:40:53< vultraz> turns out that's the idea of the enum class :P
20180312 00:40:58< celticminstrel> Yeah, exactly. :P
20180312 00:41:21< celticminstrel> This could also be a case where you don't want an enum class. I dunno.
20180312 00:41:27< vultraz> well, I used a class since I didn't want to just do gui2::OK
20180312 00:42:18< celticminstrel> FTR, you can still use a qualified name for a standard enum, it's just optional.
20180312 00:42:19< vultraz> I guess it could be acceptable?
20180312 00:42:25< vultraz> oh?
20180312 00:42:31< vultraz> well then!
20180312 00:42:48< celticminstrel> I dunno if that's relevant.
20180312 00:42:54< vultraz> very relevant 
20180312 00:42:56< vultraz> thanks!
20180312 00:44:44< vultraz> the reason the implict conversion is needed is these are only the standard enums
20180312 00:45:12< vultraz> retvals*
20180312 00:45:27< vultraz> I can't add an enum entry for every retval a dialog may want
20180312 00:45:31< celticminstrel> Of course the return value should remain int rather than an enum.
20180312 00:50:11< vultraz> I've set the enum type to int specifically
20180312 00:57:11-!- travis-ci [~travis-ci@ec2-54-147-44-1.compute-1.amazonaws.com] has joined #wesnoth-dev
20180312 00:57:12< travis-ci> wesnoth/wesnoth#16838 (schema - 339059f : Celtic Minstrel): The build is still failing.
20180312 00:57:12< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/352127789
20180312 00:57:12-!- travis-ci [~travis-ci@ec2-54-147-44-1.compute-1.amazonaws.com] has left #wesnoth-dev []
20180312 01:09:09-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity]
20180312 01:09:50-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: So long and thanks for all the fish.]
20180312 01:21:08< irker201> wesnoth: Charles Dang wesnoth:master 26e8c148b176 / / (72 files in 16 dirs): GUI2: split default return value enum into its own file https://github.com/wesnoth/wesnoth/commit/26e8c148b176fe71337ba09ebfea688b5b30d94c
20180312 01:21:11< irker201> wesnoth: Celtic Minstrel wesnoth:master 500a7def2eff / changelog src/units/attack_type.cpp: Add set_range in [effect]apply_to=attack https://github.com/wesnoth/wesnoth/commit/500a7def2eff3ba25cdedfdfa5163655c5d473c6
20180312 01:21:13< irker201> wesnoth: Celtic Minstrel wesnoth:master 296f8b091bf5 / src/ (commandline_options.cpp wesnoth.cpp): Make --report imply --wconsole on Windows https://github.com/wesnoth/wesnoth/commit/296f8b091bf591852f5b5058157895681fb940a4
20180312 01:21:15< irker201> wesnoth: Celtic Minstrel wesnoth:master 3bececed7cc2 / src/ (5 files): Sanitize the build info report to blank out the user's name https://github.com/wesnoth/wesnoth/commit/3bececed7cc2c4ff81f223afb715bf59b7fed019
20180312 01:21:18< vultraz> celticminstrel: I fixed a few cases you missed 
20180312 01:21:25< vultraz> (game_launcher.cpp)
20180312 01:26:51< irker201> wesnoth: Charles Dang wesnoth:master 09d3f31b48a4 / src/gui/widgets/ (button.cpp menu_button.cpp multimenu_button.cpp toggle_button.cpp): GUI2: use NONE retval where applicable https://github.com/wesnoth/wesnoth/commit/09d3f31b48a4b3fd8ec50202d9cc2ff81d2689cd
20180312 01:47:44< irker201> wesnoth/wesnoth:master Gregory A Lundberg 793a703895 Fix missing explicit keyword AppVeyor: All builds passed
20180312 01:56:29< celticminstrel> vultraz: I probably ignored them because I thought they were irrelevant to --report which was the intended use-case, but I won't object to that function being used in a few more cases. Just note that for things like --path it shouldn't be used, since the intention of that is to tell the user where something is.
20180312 01:59:21< vultraz> celticminstrel: the xcode commit
20180312 02:00:18-!- travis-ci [~travis-ci@ec2-54-224-175-3.compute-1.amazonaws.com] has joined #wesnoth-dev
20180312 02:00:19< travis-ci> wesnoth/wesnoth#16840 (master - 3becece : Celtic Minstrel): The build was broken.
20180312 02:00:19< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/352139484
20180312 02:00:19-!- travis-ci [~travis-ci@ec2-54-224-175-3.compute-1.amazonaws.com] has left #wesnoth-dev []
20180312 02:01:13< vultraz> I'll deal with it
20180312 02:01:17< vultraz> if it's a thng
20180312 02:01:34< celticminstrel> Probably is since I think it also failed in the schema branch.
20180312 02:01:35< vultraz> it is indeed
20180312 02:01:57< celticminstrel> Oh it's actually your fault though not mine, I guess.
20180312 02:02:02< vultraz> huh
20180312 02:02:04< vultraz> but why
20180312 02:02:07< vultraz> :/
20180312 02:02:44< celticminstrel> Because at that point, retval refers to the class member, not the type. Either use ::retval::NONE or rename the class member.
20180312 02:03:06< celticminstrel> (ie, retval refers to the variable you're initializing on that line)
20180312 02:03:16< vultraz> ah
20180312 02:09:32< irker201> wesnoth: Charles Dang wesnoth:master eabd3743f898 / src/gui/dialogs/ (5 files in 2 dirs): GUI2: convert remaining uses of dialog_callback to std::bind https://github.com/wesnoth/wesnoth/commit/eabd3743f89876eb9942c333fc320e98c78a009c
20180312 02:09:35< irker201> wesnoth: Charles Dang wesnoth:master e8da0d67cbad / / (31 files in 5 dirs): GUI2: removed now-unused dialog_callback helper https://github.com/wesnoth/wesnoth/commit/e8da0d67cbadb727a9596fb41255620d38786703
20180312 02:09:38< irker201> wesnoth: Charles Dang wesnoth:master 007c5b7473fe / src/gui/widgets/ (widget.cpp widget.hpp): GUI2/Widget: removed dialog() getter https://github.com/wesnoth/wesnoth/commit/007c5b7473fe2b28e9f2007ac5622155f6a8e7c7
20180312 02:09:41< irker201> wesnoth: Charles Dang wesnoth:master 61e9acec7cf1 / src/gui/dialogs/message.cpp: Fixup 26e8c148b176 for Travis https://github.com/wesnoth/wesnoth/commit/61e9acec7cf1d67956c9f0b83ff0fd71e08a1986
20180312 02:10:31-!- travis-ci [~travis-ci@ec2-54-147-44-1.compute-1.amazonaws.com] has joined #wesnoth-dev
20180312 02:10:32< travis-ci> wesnoth/wesnoth#16841 (master - 09d3f31 : Charles Dang): The build was broken.
20180312 02:10:32< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/352140731
20180312 02:10:32-!- travis-ci [~travis-ci@ec2-54-147-44-1.compute-1.amazonaws.com] has left #wesnoth-dev []
20180312 02:16:38< vultraz> It occurs to me I could massively simplify code by making window_ a protected member of modal_dialog
20180312 02:17:07< vultraz> and stop binding 10,000 window references
20180312 02:17:36< vultraz> the window reference gets passed around from pre_show
20180312 02:18:02< vultraz> and pre_show is really just passed *window_
20180312 02:18:16< vultraz> the window didn't used to be a class member, it used to be local to show
20180312 02:18:19< vultraz> so that made sense
20180312 02:18:39< vultraz> but since it's a member, no reason to not just use it
20180312 02:18:44< vultraz> a member now*
20180312 02:29:41< celticminstrel> vultraz: Think the path sanitization deserves a changelog entry?
20180312 02:29:52< vultraz> sure
20180312 02:30:24< celticminstrel> Your proposal seems like it would be a semantic change.
20180312 02:30:34< irker201> wesnoth: Charles Dang wesnoth:master 7eff742fbaca / src/gui/dialogs/ (modal_dialog.hpp modeless_dialog.hpp): GUI2/Modal Dialog, Modeless Dialog: made window_ a protected class member https://github.com/wesnoth/wesnoth/commit/7eff742fbaca7c7b029ed185dd85ba3ca9051709
20180312 02:30:35< celticminstrel> Currently the window is rebuilt with every call to show, right?
20180312 02:30:49< vultraz> yes.
20180312 02:30:56< celticminstrel> Oh wait, I see what you mean.
20180312 02:31:12< celticminstrel> You mean you can use it from the dialog instance classes, instead of passing the window to all the callbacks?
20180312 02:31:18< vultraz> yes
20180312 02:31:25< vultraz> or using get_window()
20180312 02:31:27< celticminstrel> Hmm.
20180312 02:32:06< vultraz> which is redundant for use in find_widget, since you're essentially doing find_widget<T>(&*window_, ...
20180312 02:32:51 * celticminstrel is looking over the modal dialog API.
20180312 02:33:09< celticminstrel> So we have the register field functions which aren't overridable and don't care about the window...
20180312 02:33:13< vultraz> oh wait, get_window returns a pointer
20180312 02:33:14< vultraz> nvm
20180312 02:33:33< vultraz> celticminstrel: yeah, the field API needs a refactor too
20180312 02:33:41< vultraz> so it doesn't rely on window references
20180312 02:33:47< celticminstrel> I thought it didn't?
20180312 02:33:48< vultraz> for everything
20180312 02:33:51< vultraz> it does
20180312 02:34:13< celticminstrel> Okay, we also have post_build, pre_show, and post_show. We know for a fact that the window exists in each of these functions.
20180312 02:34:34< celticminstrel> There's also init_fields, but... you're not really supposed to override that, are you? Why the heck is that virtual?
20180312 02:34:41< celticminstrel> Similarly finalize_fields.
20180312 02:34:45< celticminstrel> Anyway...
20180312 02:34:58< celticminstrel> Removing the window paramater to those functions seems reasonable.
20180312 02:35:07< celticminstrel> ^parameter
20180312 02:35:40< celticminstrel> (Including init_fields and finalize_fields, which IMO probably shouldn't be virtual, though if you're making them non-virtual you should make sure first that no-one overrides them.)
20180312 02:35:56< celticminstrel> The fields API could probably be factored out into a dialog_base class so that the modeless dialogs can share it.
20180312 02:36:28< celticminstrel> I suppose that could be a reason to leave init_fields and finalize_fields virtual (but make them final in modal_dialog and modeless_dialog).
20180312 02:36:48< irker201> wesnoth: Charles Dang wesnoth:master dfe53378bda7 / src/gui/ (6 files in 2 dirs): GUI2: made more use of retval::NONE over 0 https://github.com/wesnoth/wesnoth/commit/dfe53378bda7dd05a8f9eba8d8cc09ba54851c35
20180312 02:37:27< celticminstrel> Making the window pointer protected seems a little pointless when you have public get_window() anyway, particularly since the unique_ptr is actually a bit less convenient to work with (unless you add a unique_ptr overload for find_widget).
20180312 02:37:42< vultraz> oh
20180312 02:37:43< vultraz> ...
20180312 02:37:45< vultraz> right...
20180312 02:38:11< celticminstrel> Also, exposing only get_window() ensures that a child class can't as easily destroy the window (though I guess they could do "delete window" which is dangerous, so maybe it should really return a reference instead and throw if there's no window)...
20180312 02:38:12< vultraz> I was also considering possibly adding some sort of find_widget wrapper to the dialog classes 
20180312 02:38:33< celticminstrel> So a wrapper that automatically passes the window as the widget argument?
20180312 02:38:38< vultraz> yes
20180312 02:38:55< vultraz> that would account for 90% of the usecases of window in dialog class member function
20180312 02:39:15< celticminstrel> modeless_dialog has only post_build and pre_show, no post_show... which would be a problem if you're adding the fields API to it...
20180312 02:39:34< celticminstrel> There's really no reason why it can't have post_show though, is there? It'd be called by hide() in this case?
20180312 02:39:42< vultraz> perhaps?
20180312 02:40:11< celticminstrel> It does seem like there's a good reason to consolidate some functionality from modal_dialog and modeless_dialog into a dialog_base class though.
20180312 02:40:13< vultraz> what would a class wrapper for find_widget be called?
20180312 02:40:16< celticminstrel> Maybe better to wait for 1.15 on that though.
20180312 02:40:28< celticminstrel> Uh. Is there something wrong with "find_widget"?
20180312 02:40:42< vultraz> oh right, the signatures would be different
20180312 02:40:46< vultraz> so that's fine
20180312 02:40:49< celticminstrel> ...hopefully...
20180312 02:41:01< celticminstrel> Provided the class one doesn't hide the global one.
20180312 02:41:06< celticminstrel> Which might be the case. I forget.
20180312 02:41:26< celticminstrel> (Of course you could still use the global one as ::find_widget, but that's ugly and I'd prefer to minimize cases where it's done.)
20180312 02:42:02< celticminstrel> Actually, 90% of the API of modal_dialog and modeless_dialog is actually identical, isn't it?
20180312 02:42:26< vultraz> maybe?
20180312 02:42:36< vultraz> there used to be some differences..
20180312 02:42:44< vultraz> like IIRC the modeless dialog had the window as a class member..
20180312 02:42:46< vultraz> modal didn't
20180312 02:42:47< vultraz> but I changed that
20180312 02:42:50< celticminstrel> Like, pretty much everything except show(), hide(), and maybe build_window() is common (and the fields API, which could still be applied for modeless_dialog even though it's currently not available).
20180312 02:43:05< celticminstrel> Modeless needs it as a class member, modal technically doesn't.
20180312 02:43:23< vultraz> modal was to allow for get_window
20180312 02:44:11< celticminstrel> Sure, but I'm just saying it's not required. It can easily work without window as a class member (obviously, since it already did before you changed it).
20180312 02:47:08< celticminstrel> (Does anyone know how to make github embed a code snippet in a comment? I've gotten it to work before by accident, but I've also failed to get it to work before when trying to, and AFAICT I did the same thing both times.)
20180312 02:47:28< celticminstrel> (I mean a code snippet reference, not the ``` thing.)
20180312 02:47:43< irker201> wesnoth: Charles Dang wesnoth:master 43de036fa6fd / src/gui/widgets/toggle_panel.cpp: GUI2/Toggle Panel: removed outdated comment https://github.com/wesnoth/wesnoth/commit/43de036fa6fdc45d9a027405c6fa71dad5aca94e
20180312 02:50:13< irker201> wesnoth: Steve Cotton wesnoth:master 981dd1396598 / data/campaigns/Legend_of_Wesmere/scenarios/chapter2/ (07_Elves_Last_Stand.cfg 08_Council_of_Hard_Choices.cfg): LoW save the persistent multiplayer data for chapter 2 (fixes #2637) https://github.com/wesnoth/wesnoth/commit/981dd139659849e954ad46e19ac233dbb6c985fe
20180312 02:51:44-!- travis-ci [~travis-ci@ec2-54-92-138-3.compute-1.amazonaws.com] has joined #wesnoth-dev
20180312 02:51:45< travis-ci> wesnoth/wesnoth#16842 (master - 61e9ace : Charles Dang): The build is still failing.
20180312 02:51:45< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/352147967
20180312 02:51:45-!- travis-ci [~travis-ci@ec2-54-92-138-3.compute-1.amazonaws.com] has left #wesnoth-dev []
20180312 02:55:32< irker201> wesnoth: Severin Glöckner wesnoth:master 733f40f40f2e / data/multiplayer/scenarios/2p_The_Walls_of_Pyrennis.cfg: correct side names in on of the new MP maps (the last of them) https://github.com/wesnoth/wesnoth/commit/733f40f40f2e8c29606557820fc11527d9a2053d
20180312 02:58:05< vultraz> celticminstrel: I've been wondering... why don't we have a wml tag metatable defined by default?
20180312 02:58:08< vultraz> that T thing, that is
20180312 02:58:14< celticminstrel> We do now!
20180312 02:58:17< celticminstrel> wml.tag
20180312 02:58:36< vultraz> on your branch?
20180312 02:59:02< vultraz> or, no, it's in master?
20180312 02:59:33< vultraz> ah, yes
20180312 03:00:06-!- EliDupree [~quassel@2604:a880:400:d0::9bb:2001] has quit [Remote host closed the connection]
20180312 03:00:09-!- deathisundead [~quassel@2601:40a:c380:462:6846:845c:b57a:4b9a] has quit [Changing host]
20180312 03:00:09-!- deathisundead [~quassel@unaffiliated/the-unforgiven/x-8713611] has joined #wesnoth-dev
20180312 03:00:34< vultraz> so we need wml.tag.foo { key = value } ?
20180312 03:00:38< celticminstrel> Yeah.
20180312 03:00:46< vultraz> seems a little verbose
20180312 03:00:56< celticminstrel> The wml module is the one part of Lua API reorganization that actually gets to go in 1.14, I guess.
20180312 03:00:57-!- EliDupree [~quassel@2604:a880:400:d0::9bb:2001] has joined #wesnoth-dev
20180312 03:01:11< celticminstrel> It's a little verbose, sure, but you can always local T = wml.tag
20180312 03:01:29< vultraz> wonder if we could do wml[foo] { key = value }
20180312 03:01:32< vultraz> just curous
20180312 03:01:34< vultraz> not saying we should
20180312 03:01:57< celticminstrel> Totally could, but then you wouldn't be able to make keys that have the same name as one of the wml module functions.
20180312 03:02:01< celticminstrel> Which IMO is not a good thing.
20180312 03:02:09< celticminstrel> Tags not keys.
20180312 03:05:22< vultraz> is there a cl switch to disable deprecation warnings even in debug mode?
20180312 03:06:16< celticminstrel> cl as in the C/C++ compiler?
20180312 03:06:43< vultraz> no, cmd.exe
20180312 03:07:10< celticminstrel> Oh, right.
20180312 03:07:28< celticminstrel> So the Wesnoth API deprecation warnings?
20180312 03:07:33< vultraz> yes
20180312 03:07:36< celticminstrel> Hmm. I guess there isn't, actually.
20180312 03:08:15< celticminstrel> Unless --log-none=deprecation is processed after --debug.
20180312 03:09:03-!- Bonobo [~Bonobo@203.111.185.228] has joined #wesnoth-dev
20180312 03:09:17< vultraz> doesn't work, no
20180312 03:12:36< celticminstrel> Where was set_debug called for --debug... :|
20180312 03:12:52< celticminstrel> ...oh hey I just noticed a typo on line 849 of wesnoth.cpp.
20180312 03:14:11< celticminstrel> Ah, it's in game_launcher.
20180312 03:14:40< celticminstrel> I think the logging options might be processed instantly?
20180312 03:15:46< celticminstrel> Maybe not?
20180312 03:16:06< celticminstrel> Log strictness is, but not logdomain severity flags.
20180312 03:17:07-!- travis-ci [~travis-ci@ec2-54-224-175-3.compute-1.amazonaws.com] has joined #wesnoth-dev
20180312 03:17:08< travis-ci> wesnoth/wesnoth#16843 (master - 7eff742 : Charles Dang): The build is still failing.
20180312 03:17:08< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/352152246
20180312 03:17:08-!- travis-ci [~travis-ci@ec2-54-224-175-3.compute-1.amazonaws.com] has left #wesnoth-dev []
20180312 03:18:19< celticminstrel> Okay, so --log-none=deprecation is processed at https://github.com/wesnoth/wesnoth/blob/3bececed7cc2c4ff81f223afb715bf59b7fed019/src/wesnoth.cpp#L436
20180312 03:18:56< celticminstrel> And --debug is processed at https://github.com/wesnoth/wesnoth/blob/master/src/game_launcher.cpp#L170
20180312 03:19:02< celticminstrel> I guess that's later than the other.
20180312 03:19:20< irker201> wesnoth: Charles Dang wesnoth:master aeee185391a8 / src/gui/widgets/toggle_button.cpp: Fixup 26e8c14 further https://github.com/wesnoth/wesnoth/commit/aeee185391a8af9d763794ca1d1d1322602c9ac1
20180312 03:19:56< celticminstrel> I think it would be good if the order of those two were reversed (ie, explicitly specifying --log-none=deprecation should override the standard behaviour of --debug promoting the deprecation severity), but I'm not sure what's the best way to do it.
20180312 03:20:29< celticminstrel> Maybe a special check in wesnoth.cpp to set a flag if you have --log-none=deprecation, so that the set_debug call doesn't touch the severity? I dunno.
20180312 03:21:06< celticminstrel> (That would also mean an explicit --log-none=deprecation prevents the deprecation severity from being promoted if you enable debug mode with :debug)
20180312 03:21:31< celticminstrel> Alternatively, a separate flag --no-deprecation, which would actually be a lot easier to do probably.
20180312 03:22:03< celticminstrel> Or maybe a better name, if its actual function is disabling the default behaviour of debug mode promoting the severity of deprecation messages.
20180312 03:29:34< irker201> wesnoth/wesnoth:master Celtic Minstrel 45abefaa25 Sanitize the build info report to blank  AppVeyor: vs2015/Release Failed
20180312 03:29:35< irker201> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-1810
20180312 03:31:02< irker201> wesnoth/wesnoth:master Celtic Minstrel ab354737ef Fix wesnoth.show_message_box ignoring us AppVeyor: All builds passed
20180312 03:43:00-!- travis-ci [~travis-ci@ec2-54-224-175-3.compute-1.amazonaws.com] has joined #wesnoth-dev
20180312 03:43:01< travis-ci> wesnoth/wesnoth#16849 (master - aeee185 : Charles Dang): The build failed.
20180312 03:43:01< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/352160950
20180312 03:43:01-!- travis-ci [~travis-ci@ec2-54-224-175-3.compute-1.amazonaws.com] has left #wesnoth-dev []
20180312 03:56:09< vultraz> unit tests failing..
20180312 03:56:45< vultraz> Caught general 'St11logic_error' exception:
20180312 03:56:46< vultraz> basic_string::_M_construct null not valid
20180312 03:56:47< vultraz> the hell
20180312 04:00:26< vultraz> celticminstrel: t'is very odd
20180312 04:02:27< vultraz> could it be the sanitize commit?
20180312 04:03:36< celticminstrel> Well, I had no issues when I tested it with --report.
20180312 04:03:59< vultraz> absolutely everything is failing
20180312 04:04:01< vultraz> wml and unit tests
20180312 04:04:36< celticminstrel> I also don't see how that commit would raise an std::logic_error.
20180312 04:04:44< celticminstrel> Unless boost::replace_all can?
20180312 04:06:24< vultraz> https://stackoverflow.com/questions/35143293/basic-string-m-construct-null-not-valid-after-constructing-subvector-of-string
20180312 04:14:23< irker201> wesnoth: Charles Dang wesnoth:master 06e3c8ad7d38 / src/filesystem_boost.cpp: Don't try to sanitize path if getenv returns null https://github.com/wesnoth/wesnoth/commit/06e3c8ad7d38fcca15cb63ed6e45f3d4750f1225
20180312 04:14:23< vultraz> just a random see if it works commit...
20180312 04:29:47< celticminstrel> Hmm, maybe.
20180312 04:30:22< vultraz> celticminstrel: looks like that's fixing it
20180312 04:31:17< irker201> wesnoth/wesnoth:lua_reorg Celtic Minstrel cb5fb17248 Lua API reorganization: units module dep AppVeyor: 1/2 builds failed
20180312 04:31:18< irker201> Details vs2017/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-lua_reorg-1507
20180312 04:35:24-!- travis-ci [~travis-ci@ec2-54-92-138-3.compute-1.amazonaws.com] has joined #wesnoth-dev
20180312 04:35:26< travis-ci> wesnoth/wesnoth#16851 (master - 06e3c8a : Charles Dang): The build was fixed.
20180312 04:35:26< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/352169860
20180312 04:35:26-!- travis-ci [~travis-ci@ec2-54-92-138-3.compute-1.amazonaws.com] has left #wesnoth-dev []
20180312 04:35:28< vultraz> \o/
20180312 04:36:38< vultraz> celticminstrel: do you think sinda's pr can go in?
20180312 04:38:20< celticminstrel> Grrr, codacy...
20180312 04:40:14< irker201> wesnoth: Celtic Minstrel wesnoth:schema 618d0a4c4181 / / (44 files in 10 dirs): Implement validation of the core game config WML https://github.com/wesnoth/wesnoth/commit/618d0a4c4181dbd6961da473a8d8c5384b9b4609
20180312 04:40:16< irker201> wesnoth: Celtic Minstrel wesnoth:schema 1821fac99cfe / data/schema/core/addons.cfg: Address some feedback https://github.com/wesnoth/wesnoth/commit/1821fac99cfedd8c5547eb7ec845a89839a1b2f4
20180312 04:40:18< irker201> wesnoth: Celtic Minstrel wesnoth:schema 69f937cb8c04 / data/schema/ (core/config.cfg game_config.cfg terrain/graphics.cfg): Address a few TODO notes https://github.com/wesnoth/wesnoth/commit/69f937cb8c04d7551be478e05b1771bb8f12ae9a
20180312 04:40:20< irker201> wesnoth: Celtic Minstrel wesnoth:schema 0bd30de98c5e / data/gui/schema.cfg data/schema/gui.cfg src/gui/gui.cpp: Move GUI2 schema into the schema directory https://github.com/wesnoth/wesnoth/commit/0bd30de98c5e880c1e592b6820ae13c65584b008
20180312 04:40:22< irker201> wesnoth: Celtic Minstrel wesnoth:schema 69e3cde91005 / / (5 files in 3 dirs): Get game config and schema to use some common types https://github.com/wesnoth/wesnoth/commit/69e3cde910052ac73427acab9459a7aa55a46dc6
20180312 04:40:24< irker201> wesnoth: Celtic Minstrel wesnoth:schema 8f5275d550d2 / / (5 files in 2 dirs): Enable nesting of [type] tags https://github.com/wesnoth/wesnoth/commit/8f5275d550d201d86b842c213420baa98cdbafef
20180312 04:40:26< irker201> wesnoth: Celtic Minstrel wesnoth:schema d99b625c4f26 / src/serialization/tag.hpp: Super-rudimentary documentation... https://github.com/wesnoth/wesnoth/commit/d99b625c4f2660c66586d235982095598c005fff
20180312 04:41:30< celticminstrel> (Feel free to cancel the builds for that push. Don't forget that there's two, one for the push and one for the PR.)
20180312 04:47:52< celticminstrel> vultraz: Which PR is sinda's?
20180312 04:48:04< vultraz> https://github.com/wesnoth/wesnoth/pull/2552
20180312 04:48:27< celticminstrel> Oh singalen.
20180312 04:48:52< vultraz> actually doesn't look like it can go in
20180312 04:48:56< celticminstrel> Wait, really?
20180312 04:49:05< vultraz> codacy issues
20180312 04:49:07< celticminstrel> I was about to say "yes but it does need a command-line option to ignore all this".
20180312 04:49:23< celticminstrel> The two codacy comments I can see are irrelevant.
20180312 04:49:42< vultraz> ah
20180312 04:50:10< celticminstrel> They're basically saying "check that this is safe" and ISTR singalen saying (in a response to them) that he did check.
20180312 04:52:34< celticminstrel> I suppose a command-line option could be done after merge too.
20180312 04:53:05< vultraz> btw, i wonder if we can merge all those language files into one
20180312 04:53:47< vultraz> data/languages/* that is
20180312 05:11:29-!- travis-ci [~travis-ci@ec2-54-147-44-1.compute-1.amazonaws.com] has joined #wesnoth-dev
20180312 05:11:30< travis-ci> wesnoth/wesnoth#16852 (schema - d99b625 : Celtic Minstrel): The build is still failing.
20180312 05:11:31< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/352173541
20180312 05:11:31-!- travis-ci [~travis-ci@ec2-54-147-44-1.compute-1.amazonaws.com] has left #wesnoth-dev []
20180312 05:11:44< celticminstrel> Oh, they weren't cancelled. Ah well.
20180312 05:16:16< vultraz> yeah, figured it best to let them go through
20180312 06:07:50-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The computer falls into a deep sleep, to awake again some other day!]
20180312 06:18:16< irker201> wesnoth/wesnoth:master Steve Cotton 1b25d7f93c LoW save the persistent multiplayer data AppVeyor: All builds passed
20180312 06:33:30-!- matth1askrgr [matthiaskr@gateway/shell/panicbnc/x-cvmlqrtcqpunguhs] has joined #wesnoth-dev
20180312 06:33:53-!- matth1askrgr is now known as Guest82249
20180312 06:34:56-!- Netsplit *.net <-> *.split quits: matthiaskrgr, aidanhs
20180312 06:36:57-!- minzbonbon [~min@meta23.net] has quit [Ping timeout: 240 seconds]
20180312 06:40:38-!- minzbonbon [~min@meta23.net] has joined #wesnoth-dev
20180312 06:40:56-!- Netsplit over, joins: aidanhs
20180312 07:04:37-!- ancestral [~anonymous@97-116-178-242.mpls.qwest.net] has joined #wesnoth-dev
20180312 07:20:52-!- JyrkiVesterinen [~JyrkiVest@195-192-251-124.s1networks.fi] has joined #wesnoth-dev
20180312 07:22:17-!- ancestral [~anonymous@97-116-178-242.mpls.qwest.net] has quit [Quit: ancestral]
20180312 07:26:52-!- ancestral [~anonymous@97-116-178-242.mpls.qwest.net] has joined #wesnoth-dev
20180312 07:37:43< irker201> wesnoth: Severin Glöckner wesnoth:master c17e47cfd01a / packaging/wesnoth.desktop: Add a way to lauch the map editor with the same dsektop file https://github.com/wesnoth/wesnoth/commit/c17e47cfd01a18ab6f7bff5c0e7cc4d6623c16a0
20180312 07:37:45< irker201> wesnoth: Sergey Popov wesnoth:master 0a0156660ae3 / packaging/wesnoth.desktop: Merge pull request #2640 from sevu/desktop-action-pr https://github.com/wesnoth/wesnoth/commit/0a0156660ae3328e8b2bda86f7f17b6578c0f876
20180312 08:06:26-!- vn971 [~vasya@94.158.103.15] has joined #wesnoth-dev
20180312 08:10:20< irker201> wesnoth/wesnoth:master doofus-01 2cc131cf9d harmonized sprite file naming scheme for AppVeyor: All builds passed
20180312 08:29:36< irker201> wesnoth/wesnoth:master Celtic Minstrel 45abefaa25 Sanitize the build info report to blank  AppVeyor: 2/4 builds failed
20180312 08:29:37< irker201> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-1810
20180312 08:29:38< irker201> Details vs2017/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-master-1513
20180312 08:33:22-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20180312 09:17:26-!- ancestral [~anonymous@97-116-178-242.mpls.qwest.net] has quit [Quit: ancestral]
20180312 09:45:13-!- vn971 [~vasya@94.158.103.15] has quit [Remote host closed the connection]
20180312 09:49:07-!- Guest82249 [matthiaskr@gateway/shell/panicbnc/x-cvmlqrtcqpunguhs] has quit [Changing host]
20180312 09:49:07-!- Guest82249 [matthiaskr@unaffiliated/matthiaskrgr] has joined #wesnoth-dev
20180312 09:49:07-!- Guest82249 [matthiaskr@unaffiliated/matthiaskrgr] has quit [Changing host]
20180312 09:49:07-!- Guest82249 [matthiaskr@gateway/shell/panicbnc/x-cvmlqrtcqpunguhs] has joined #wesnoth-dev
20180312 09:49:25-!- Guest82249 is now known as matthiaskrgr
20180312 10:01:25< irker201> wesnoth/wesnoth:master Severin Glöckner 11e7624324 add a translation hint AppVeyor: vs2013/Debug Failed
20180312 10:01:26< irker201> Details: https://ci.appveyor.com/project/wesnoth/wesnoth/build/Wesnoth-VS2013-master-1835
20180312 10:55:34-!- JyrkiVesterinen [~JyrkiVest@195-192-251-124.s1networks.fi] has quit [Quit: .]
20180312 11:06:26-!- vladimirslavik [vslavik@nat/redhat/x-qwjstmnnlsxblxvz] has joined #wesnoth-dev
20180312 11:20:20< irker201> wesnoth/wesnoth:master Severin Glöckner 11e7624324 add a translation hint AppVeyor: 1/6 builds failed
20180312 11:20:21< irker201> Details vs2013/Debug: https://ci.appveyor.com/project/wesnoth/wesnoth/build/Wesnoth-VS2013-master-1835
20180312 11:38:56-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180312 11:39:02-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20180312 11:58:18< irker201> wesnoth/wesnoth:master Celtic Minstrel f0f98dfdc0 Super-rudimentary documentation... AppVeyor: vs2013/Release Failed
20180312 11:58:19< irker201> Details: https://ci.appveyor.com/project/wesnoth/wesnoth/build/Wesnoth-VS2013-master-1837
20180312 12:03:07-!- vslavik [vslavik@nat/redhat/x-ieojkqdezsnpczlp] has joined #wesnoth-dev
20180312 12:05:39-!- vladimirslavik [vslavik@nat/redhat/x-qwjstmnnlsxblxvz] has quit [Ping timeout: 260 seconds]
20180312 12:33:27-!- octalot [~steve@178.115.128.212.wireless.dyn.drei.com] has quit [Ping timeout: 240 seconds]
20180312 12:54:30-!- JyrkiVesterinen [~JyrkiVest@195-192-251-124.s1networks.fi] has joined #wesnoth-dev
20180312 12:59:39-!- vslavik__ [vslavik@nat/redhat/x-dczvtwdtqvkwvqhk] has joined #wesnoth-dev
20180312 13:01:53-!- vslavik [vslavik@nat/redhat/x-ieojkqdezsnpczlp] has quit [Ping timeout: 248 seconds]
20180312 13:06:53-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180312 13:06:59-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20180312 13:49:05-!- vultraz [uid24821@wesnoth/developer/vultraz] has quit [Quit: Connection closed for inactivity]
20180312 14:05:52< irker201> wesnoth/wesnoth:master Celtic Minstrel f0f98dfdc0 Super-rudimentary documentation... AppVeyor: 2/6 builds failed
20180312 14:05:53< irker201> Details vs2013/Release: https://ci.appveyor.com/project/wesnoth/wesnoth/build/Wesnoth-VS2013-master-1837
20180312 14:05:54< irker201> Details vs2017/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-master-1528
20180312 14:06:43-!- vultraz [uid24821@wesnoth/developer/vultraz] has joined #wesnoth-dev
20180312 14:20:59-!- pydsigner [~pydsigner@unaffiliated/pydsigner] has quit [Ping timeout: 255 seconds]
20180312 14:21:10-!- pydsigner [~pydsigner@unaffiliated/pydsigner] has joined #wesnoth-dev
20180312 14:42:03< irker201> wesnoth: Charles Dang wesnoth:master 2cb98bfc5ab4 / src/gui/ (dialogs/multiplayer/lobby.cpp dialogs/title_screen.cpp widgets/window.cpp): GUI2: allow use of the fullscreen hotkey in any dialog https://github.com/wesnoth/wesnoth/commit/2cb98bfc5ab46f3588439bbbc9b2620d1f2d1c17
20180312 14:47:46-!- jrabe [jrabe@janikrabe.com] has joined #wesnoth-dev
20180312 14:53:04< irker201> wesnoth: Charles Dang wesnoth:master 7477b585e8d8 / changelog: changelog entry for 2cb98bf https://github.com/wesnoth/wesnoth/commit/7477b585e8d8cf457675d550349d65f4b0a8b147
20180312 15:05:37< irker201> wesnoth: Charles Dang wesnoth:master 376f0f446b7e / changelog: More changelog updates https://github.com/wesnoth/wesnoth/commit/376f0f446b7e88d85cd7f299f1f265d85a48990a
20180312 15:26:05-!- Bonobo [~Bonobo@203.111.185.228] has quit [Ping timeout: 240 seconds]
20180312 15:33:42-!- JyrkiVesterinen [~JyrkiVest@195-192-251-124.s1networks.fi] has quit [Quit: .]
20180312 16:11:17-!- jrabe is now known as upmime
20180312 16:16:43< irker201> wesnoth: Charles Dang wesnoth:master c0244dc4e15e / src/gui/dialogs/addon/manager.cpp: Addon Manager: quick fix for the stack button having the wrong text https://github.com/wesnoth/wesnoth/commit/c0244dc4e15e7850e4523fa528a80c9c68524351
20180312 16:19:53-!- vslavik__ [vslavik@nat/redhat/x-dczvtwdtqvkwvqhk] has quit [Quit: Leaving]
20180312 16:44:33-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20180312 16:44:58-!- Oebele [~quassel@143.177.58.202] has joined #wesnoth-dev
20180312 17:05:17-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20180312 17:09:22< irker201> wesnoth/wesnoth:master Gregory A Lundberg b41268b865 Use standard names AppVeyor: vs2015/Release Failed
20180312 17:09:23< irker201> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-1827
20180312 17:12:27< irker201> wesnoth: Charles Dang wesnoth:master 1340c005b3be / data/ (4 files in 4 dirs): Fixed minor text errors reported on the wiki https://github.com/wesnoth/wesnoth/commit/1340c005b3beb992aef09a86bf2c7d62862bcef7
20180312 17:12:47< vultraz> agh!
20180312 17:13:35-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has joined #wesnoth-dev
20180312 17:13:39< irker201> wesnoth: Charles Dang wesnoth:master beec27f778b1 / utils/pofix.py: pofix entries for 1340c005b3be https://github.com/wesnoth/wesnoth/commit/beec27f778b10d22e386088981f8b7f131c423fb
20180312 17:43:16-!- vn971 [~vasya@94.158.103.15] has joined #wesnoth-dev
20180312 17:45:21-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 264 seconds]
20180312 18:00:18< irker201> wesnoth: Charles Dang wesnoth:master 4f2073ae2e5a / changelog changelog.md: Made the changelog a Markdown file https://github.com/wesnoth/wesnoth/commit/4f2073ae2e5ab5d48ceb925fa53d1faac42ff6c5
20180312 18:00:21< irker201> wesnoth: Charles Dang wesnoth:master 47359c8c65bd / changelog.md: Reformatted 1.13 changelog entry headers for Markdown https://github.com/wesnoth/wesnoth/commit/47359c8c65bd9fb3adf5e636e1425cd4a71802ad
20180312 18:00:29-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20180312 18:33:03-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20180312 18:38:11< irker201> wesnoth/wesnoth:master Gregory A Lundberg b41268b865 Use standard names AppVeyor: 3/6 builds failed
20180312 18:38:12< irker201> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-1827
20180312 18:38:13< irker201> Details vs2013/Release: https://ci.appveyor.com/project/wesnoth/wesnoth/build/Wesnoth-VS2013-master-1839
20180312 18:38:14< irker201> Details vs2017/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-master-1530
20180312 18:43:22< vultraz> For the record, the changelog formatting change also means no one need continue wrapping at 80 characters
20180312 18:43:29< vultraz> s/formatting/format
20180312 18:43:54< JyrkiVesterinen> Wrong.
20180312 18:44:09< JyrkiVesterinen> There are probably still people who view the changelog as a text file.
20180312 18:44:33< JyrkiVesterinen> Indeed, the Markdown format has been *designed* so that it looks good when viewed as plain text.
20180312 18:45:06< Soliton> do you plan to reformat the complete changelog?
20180312 18:45:29< vultraz> shadow m said he could run through the rest with  quick script. Else, no.
20180312 18:45:41< JyrkiVesterinen> *she
20180312 18:45:55< vultraz> Right. Apologies.
20180312 18:47:49< Soliton> might be unfortunate to lose the ability to figure out when changes were done from the changelog.
20180312 18:48:08< Soliton> or always having to skip the reformatting commit then.
20180312 18:48:08< vultraz> I don't follow.
20180312 18:48:35< vultraz> Can't you just use the web interface for git blame and view changes before reformatting?
20180312 18:50:08< Soliton> doesn't matter how you look at git blame. you'll have to always check before the reformatting commit for older changes.
20180312 18:50:27< vultraz> well, yes. But how often might one do that.
20180312 18:51:50< Soliton> how often are you going to look at old changelog entries on github and marvel at the formatting?
20180312 18:52:21< vultraz> That's why I didn't bother formatting anything before 1.13.0
20180312 19:01:34-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180312 19:01:44-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20180312 19:12:58< irker201> wesnoth: Charles Dang wesnoth:master 443339d8a066 / data/core/images/misc/time-schedules/default/ (6 files): Updated default schedule ToD images https://github.com/wesnoth/wesnoth/commit/443339d8a066c33927b7123fd13d9720ff91974e
20180312 19:34:06 * vn971 wanted to share opinion on git history being good and useful, but un-intrusive code style being even more important (like no spaces at end of line, proper spaces with parenthesis and commas). ...But remembered I don't really write cpp code, so who cares, practically speaking.
20180312 19:40:23< zookeeper> what's an md file and what are you supposed to view it if not a text editor?
20180312 19:40:33< zookeeper> because it looks awfully plaintextish to me.
20180312 19:41:27< zookeeper> oh, the github formatting thing.
20180312 19:41:42< JyrkiVesterinen> Easiest way is GitHub's own file preview, which has a Markdown parser.
20180312 19:42:19< JyrkiVesterinen> But Markdown is also designed to be viewed in a regular text editor. It looks good when viewed that way, unlike, say, HTML.
20180312 19:44:19< vn971> zookeeper: it's called "markdown". There are also some markdown editors out there, but many people probably use pure text editors.
20180312 19:59:26< vultraz> zookeeper: did you get to take a look at that Jevyan sprite and decide about adding it?
20180312 19:59:52< vultraz> and ravanalalalalalal
20180312 20:05:11< vultraz> zookeeper: it'd be nice to get them in for the release
20180312 20:05:17< vultraz> (which will be in a few days)
20180312 20:11:29< irker201> wesnoth: Charles Dang wesnoth:master 93731f6afce1 / players_changelog players_changelog.md: Made players_changelog also a Markdown file https://github.com/wesnoth/wesnoth/commit/93731f6afce12395b77d5786b6ed65b676a2a786
20180312 20:11:32< irker201> wesnoth: Charles Dang wesnoth:master 8a0d697eec8b / changelog.md: Changelog entry for 443339d https://github.com/wesnoth/wesnoth/commit/8a0d697eec8b447ca6291b30588c06e9de5e35a3
20180312 20:39:45-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180312 20:39:55-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20180312 21:06:39< irker201> wesnoth: Charles Dang wesnoth:master b92ee187b87e / data/campaigns/ (5 files in 5 dirs): Cleaned up use of deprecated APIs in campaign Lua https://github.com/wesnoth/wesnoth/commit/b92ee187b87ed3a306e4bdc2e24be8c25a39dca4
20180312 21:07:09< vultraz> need to talk to celmin about the wml.tag thing again..
20180312 21:14:24-!- upmime is now known as jrabe
20180312 21:19:45< shadowm> It's just Mal-Ravanal, no need for the extra als.
20180312 21:26:17-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20180312 21:26:46< irker201> wesnoth: Iris Morelle wesnoth:master 66e82ffc4ad7 / changelog.md: Convert the rest of the changelog to Markdown https://github.com/wesnoth/wesnoth/commit/66e82ffc4ad7f2848a93e076d544f690a9101dc8
20180312 21:42:36< irker201> wesnoth: Iris Morelle wesnoth:master 0d855608c314 / players_changelog.md: Convert the rest of players_changelog to Markdown https://github.com/wesnoth/wesnoth/commit/0d855608c31478273d92c882a4b7c590ff20fac9
20180312 21:47:49-!- nurupo [~nurupo.ga@unaffiliated/nurupo] has quit [Ping timeout: 260 seconds]
20180312 21:48:16-!- oldlaptop [~quassel@45.63.78.126] has quit [Quit: No Ping reply in 180 seconds.]
20180312 21:50:01-!- oldlaptop [~quassel@45.63.78.126] has joined #wesnoth-dev
20180312 21:50:51-!- nurupo [~nurupo.ga@unaffiliated/nurupo] has joined #wesnoth-dev
20180312 22:16:57-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has quit [Quit: .]
20180312 22:27:49-!- heirecka [~heirecka@exherbo/developer/heirecka] has quit [Quit: Bye]
20180312 22:31:57-!- heirecka [~heirecka@exherbo/developer/heirecka] has joined #wesnoth-dev
20180312 22:34:08-!- Oebele [~quassel@143.177.58.202] has quit [Remote host closed the connection]
20180312 22:39:06-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit []
20180312 23:08:32-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20180312 23:23:12-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20180312 23:33:47< irker201> wesnoth: Severin Glöckner wesnoth:master f97329a110d9 / data/tips.cfg: add a translation hint https://github.com/wesnoth/wesnoth/commit/f97329a110d90541b84cb00ce817228ebbd71f01
20180312 23:51:54-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
--- Log closed Tue Mar 13 00:00:34 2018