--- Log opened Fri Mar 16 00:00:06 2018 --- Day changed Fri Mar 16 2018 20180316 00:00:06< vultraz> i see no wml.vars field? 20180316 00:00:22< celticminstrel> There is some module with a name that's easily confused with wml.variables. 20180316 00:00:25< celticminstrel> Maybe wml.var? 20180316 00:00:29< vultraz> you mean wml.variable 20180316 00:00:45< celticminstrel> ...is that what it's called? That's even worse than I thought. 20180316 00:00:49< vultraz> so we have wml.variable, the module, and wml.variables, the metatable 20180316 00:00:58< celticminstrel> Yeah that's really bad. 20180316 00:01:47-!- irker134 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout] 20180316 00:01:50< celticminstrel> Okay, so what's in wml.variable so far... 20180316 00:02:02< celticminstrel> get, set, get_all... proxy... 20180316 00:02:14< vultraz> get and set can be removed 20180316 00:02:19< celticminstrel> get_array, set_array... 20180316 00:02:24-!- travis-ci [~travis-ci@ec2-54-166-35-223.compute-1.amazonaws.com] has joined #wesnoth-dev 20180316 00:02:25< celticminstrel> get_proxy_array 20180316 00:02:25< travis-ci> gfgtdf/wesnoth#1037 (no_syncedcommand - 2ce99ae : gfgtdf): The build failed. 20180316 00:02:25< travis-ci> Build details : https://travis-ci.org/gfgtdf/wesnoth/builds/354098682 20180316 00:02:25-!- travis-ci [~travis-ci@ec2-54-166-35-223.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180316 00:02:32< gfgtdf> if it about manipulting wml tables we coudl call it wml.table 20180316 00:02:35< celticminstrel> That's it, huh. 20180316 00:02:35< vultraz> still don't know what the proxy stuff does 20180316 00:03:00< vultraz> celticminstrel: so, that aside, which would be the better local wml.variable*s* alias? 20180316 00:03:18< celticminstrel> I have a slight preference for V because it's shorter. 20180316 00:03:34< Soliton> gfgtdf: strings have to be marked translatable otherwise the tool to extract the strings will just ignore them. 20180316 00:04:05< gfgtdf> Soliton: i know 20180316 00:04:11< vultraz> it took me a while to remember that T, as an alias of wml.tag, was not a list of all available tags 20180316 00:04:18< celticminstrel> (Re: vgettext making strings translatable... technically it does but only if it's a literal string.) 20180316 00:05:01< Soliton> gfgtdf: well, it sounded like you thought those debug notifications are translatable. 20180316 00:05:17< celticminstrel> So basically there's get, set, get_array, set_array, get_all, proxy, get_array_proxy. 20180316 00:05:18< gfgtdf> Soliton: i said they should be trasnlatable 20180316 00:05:31< vultraz> I think maybe I'll go with vars, since it's clearer on read 20180316 00:05:33< gfgtdf> Soliton: but we currently cannot fix that becsue we are in a string freeze 20180316 00:05:40< celticminstrel> vultraz: Fine with me. 20180316 00:05:56< zookeeper> it wouldn't violate the spirit of a string freeze to mark translatable something that's already user-visible but accidentally non-translatable. 20180316 00:06:01< zookeeper> just saying... 20180316 00:06:11< celticminstrel> I don't see how? 20180316 00:06:23< celticminstrel> Marking it translatable means new strings are added. 20180316 00:06:29< gfgtdf> zookeeper: i thought the main reason of the string freeze is not to annoy translators? 20180316 00:06:35< gfgtdf> zookeeper: actuall i don't know 20180316 00:06:39< vultraz> the wml module is automatically loaded right? 20180316 00:06:47< Soliton> it also does not violate the spirit of the string freeze to fix ridiculous features. 20180316 00:06:56< celticminstrel> vultraz: Yes, because it's defined in core.lua. 20180316 00:07:13 * celticminstrel wonders what Soliton means. 20180316 00:07:32< zookeeper> well, true, it might be annoying to have a 99.9% translation instead of a nice clean 100%... 20180316 00:07:37< celticminstrel> vultraz: So, we have wml.variable, right? 20180316 00:07:42< vultraz> yes 20180316 00:07:57< celticminstrel> Any objection to adding something like wml.variables which works with arrays instead of scalars? 20180316 00:07:58< Soliton> celticminstrel: a few seconds visible message you need to notice to see that another player cheated. 20180316 00:08:26< celticminstrel> Basically identical to wml.variable but wrapping get_variable_array and set_variable_array instead of get_variable and set_variable. 20180316 00:08:41< vultraz> no objection 20180316 00:08:44< vultraz> but what would you call it 20180316 00:09:02< celticminstrel> wml.variables? 20180316 00:09:09< celticminstrel> If you have a better name I'll listen. 20180316 00:10:00< vultraz> that's the name of the variables metatable!! 20180316 00:11:04< celticminstrel> Oh right. Duh. 20180316 00:11:23< celticminstrel> wml.array_variables? wml.container_variables? wml.tag_variables? 20180316 00:11:33-!- travis-ci [~travis-ci@ec2-54-161-229-116.compute-1.amazonaws.com] has joined #wesnoth-dev 20180316 00:11:34< travis-ci> gfgtdf/wesnoth#1038 (no_syncedcommand - 4ad1d75 : gfgtdf): The build failed. 20180316 00:11:34< travis-ci> Build details : https://travis-ci.org/gfgtdf/wesnoth/builds/354099002 20180316 00:11:34-!- travis-ci [~travis-ci@ec2-54-161-229-116.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180316 00:11:41< vultraz> would be nice if they could be accessed from the same metatable 20180316 00:11:59< vultraz> ie, if wml.variables.foo[1] = bar DID work. 20180316 00:13:05< celticminstrel> That's what the proxy metatable is supposed to do (don't remember how well it works). 20180316 00:13:59 * celticminstrel wonders what happens if you wesnoth.set_variable("x", nil) when x is a container variable... 20180316 00:14:17< gfgtdf> it probably erases the container 20180316 00:14:50< vultraz> or instead of something like wml.variable.get_array("bandit_villages") you could do wml.variables.bandit_villages[] 20180316 00:15:30< celticminstrel> That's impossible. 20180316 00:15:35< zookeeper> aren't you supposed to not do API redesigns right now? 20180316 00:15:49< vultraz> :( 20180316 00:15:57< celticminstrel> zookeeper: This API wml module is non-finalized anyway. 20180316 00:16:03< celticminstrel> It's not even officially documented yet. 20180316 00:16:18< celticminstrel> Or possibly not documented at all, I forget. 20180316 00:17:56< zookeeper> right 20180316 00:20:35< vultraz> celticminstrel: vars.container.something is valid right? 20180316 00:20:40< vultraz> or no 20180316 00:20:42< vultraz> im confused 20180316 00:20:50< celticminstrel> No. 20180316 00:20:53< celticminstrel> Well. 20180316 00:21:02< celticminstrel> It's not explicitly supported, at least. 20180316 00:21:26< celticminstrel> It might actually work, since vars.container should return a WML table. 20180316 00:22:54< celticminstrel> ...oh, hmm. I think this is not as good an idea as I initially thought. 20180316 00:23:02< celticminstrel> I mean, it's a great idea, but there's a flaw. 20180316 00:23:19< celticminstrel> It does a fine job of replacing wesnoth.get_array_variable("var"). 20180316 00:23:48-!- irker713 [~irker@uruz.ai0867.net] has joined #wesnoth-dev 20180316 00:23:48< irker713> wesnoth: Charles Dang wesnoth:master 3783693cbe95 / data/campaigns/ (8 files in 7 dirs): Campaigns: cleaned up more cases of deprecated Lua API usage https://github.com/wesnoth/wesnoth/commit/3783693cbe95be6c51553dfa71bf0ecd5ed8116f 20180316 00:23:49< celticminstrel> But it does nothing to replace wesnoth.get_array_variable("var", unit) or wesnoth.get_array_variable("var", side). 20180316 00:24:00< celticminstrel> (Maybe it was get_variable_array, I forget.) 20180316 00:24:03-!- travis-ci [~travis-ci@ec2-54-161-229-116.compute-1.amazonaws.com] has joined #wesnoth-dev 20180316 00:24:04< travis-ci> gfgtdf/wesnoth#1039 (no_syncedcommand - 501a585 : gfgtdf): The build failed. 20180316 00:24:04< travis-ci> Build details : https://travis-ci.org/gfgtdf/wesnoth/builds/354102180 20180316 00:24:04-!- travis-ci [~travis-ci@ec2-54-161-229-116.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180316 00:24:10< celticminstrel> (Also it might've been in helper, not wesnoth?) 20180316 00:25:20< zookeeper> vultraz, since when do you use ; in lua? 20180316 00:25:21< zookeeper> vars.boss_found = true; 20180316 00:25:28< vultraz> oops? 20180316 00:25:28< celticminstrel> zookeeper: It's optional. 20180316 00:25:35< celticminstrel> Perfectly valid. 20180316 00:25:37< vultraz> sorry 20180316 00:25:39< zookeeper> oh? cool. 20180316 00:25:43< vultraz> c++ ism 20180316 00:26:00< gfgtdf> you usually onyl use it if you want to put multiople statements on one line 20180316 00:26:13< gfgtdf> might be useful in the lua console 20180316 00:26:38< irker713> wesnoth: Charles Dang wesnoth:master 79b7e0857336 / data/campaigns/Eastern_Invasion/lua/bandits.lua: Fixup 3783693cbe95 (removed a C++-ism) https://github.com/wesnoth/wesnoth/commit/79b7e0857336c8cf44f69c6db8224019b38dec97 20180316 00:27:33< gfgtdf> can can also add a c++ version of get/set variable that returns arrays on unspecified tables 'get("a.b")' and tables on explcit indexes 'get("a.b[0]")' 20180316 00:27:57< celticminstrel> ??? 20180316 00:29:10< gfgtdf> meanign that get("a.b") will always return scalars or (posible 1-elemented) arrays of tags and get("a.b[n]") will always returns singel tags 20180316 00:30:30< irker713> wesnoth: Celtic Minstrel wesnoth:luawml 41b46ce7ca6a / data/lua/core.lua: Lua API: Some tweaks of the experimental wml module https://github.com/wesnoth/wesnoth/commit/41b46ce7ca6ad2f5d2fbdb6445f30dd4ed6bd56a 20180316 00:30:34< celticminstrel> vultraz: Thoughts? ^ 20180316 00:30:42< celticminstrel> gfgtdf too I guess. 20180316 00:31:40< irker713> wesnoth: Celtic Minstrel wesnoth:luawml 9ac301d23d4a / data/lua/core.lua: Lua API: Some tweaks of the experimental wml module https://github.com/wesnoth/wesnoth/commit/9ac301d23d4abfd6ba80117b1d29dca067cc5425 20180316 00:32:54< vultraz> so now we have 3 metatables? 20180316 00:33:07< celticminstrel> There's a bunch of them. 20180316 00:33:18< vultraz> wml.variables.foo, wml.variables_proxy.foo, and wml.array_variables.foo? 20180316 00:33:54< vultraz> if you're going with that, definitely name the last on variables_array 20180316 00:34:14-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20180316 00:34:49< celticminstrel> I do think array_variables better describes what it does though... 20180316 00:35:03< celticminstrel> But I suppose there's a nice symmetry with the others in variables_array... 20180316 00:35:19< vultraz> true 20180316 00:35:21< celticminstrel> There's also a new metatable on wml itself that handles wml.all_variables. 20180316 00:35:39< celticminstrel> And the variable access functions are now in wml.array_access instead of wml.variable (which now no longer exists). 20180316 00:35:57< celticminstrel> The reason they're still there is because the metatable only covers one-third of their potential use. 20180316 00:35:59< vultraz> t'is seems confusing 20180316 00:36:05< vultraz> this 20180316 00:36:28< celticminstrel> Because you can use the functions to get an array from a unit variable or a side variable. 20180316 00:36:51< vultraz> is there really no way we can make wml.variables.foo.bar or wml.variables.foo[1].bar work? 20180316 00:37:08< celticminstrel> IIRC unit.variables and side.variables actually have the same interface as wml.variables now does. 20180316 00:37:15< celticminstrel> ... 20180316 00:37:43< celticminstrel> I'm pretty sure my response every time you ask that has been "THAT IS BASICALLY WHAT THE VARIABLE PROXY ALREADY DOES". 20180316 00:38:06< vultraz> I mean WITHOUT the separate table 20180316 00:38:29< vultraz> it's confusing to remember "ok, do I want proxy, plain, or array access... or all variables?" 20180316 00:38:37< celticminstrel> Well, obviously you could get that effect by simply assigning that metatable to wml.variables instead of to wml.variables_proxy. 20180316 00:39:11< vultraz> I'm saying we should consolidate as much functionality as possible 20180316 00:39:17 * celticminstrel recommends not cherry-picking that commit right now, since we're still not exactly in agreement here. 20180316 00:39:38< gfgtdf> which commit ? 20180316 00:39:45< celticminstrel> I think in order to fully consolidate we need to expose the unit and side tables. 20180316 00:39:52< celticminstrel> ^metatables 20180316 00:40:09< celticminstrel> Or something similar. 20180316 00:40:13< celticminstrel> I'm not entirely sure TBH. 20180316 00:40:40< celticminstrel> It's almost certainly possible to collapse the entire variable thing down to just wml.variables without really losing functionality. 20180316 00:40:51< celticminstrel> (Though that does exclude get_all_variables, I guess.) 20180316 00:41:47< celticminstrel> But then you'll have a different interface for global WML variables than you have for unit and side variables. 20180316 00:42:05< celticminstrel> The metatables for unit and side variables are internal to the engine, so they can't be modified from Lua ATM. 20180316 00:42:57< celticminstrel> gfgtdf: Do you think there are any downsides to using the variable proxy? 20180316 00:43:08< celticminstrel> (As for which commit, it's the one that was most recently announced.) 20180316 00:44:59< gfgtdf> celticminstrel: well yes, first of it's somehow slow: proxy.a.b.c.d calls get_variable 4 times: get_variable("a"), get_variable("a.b"),get_variable("a.b.c"),get_variable("a.b.c.d") 20180316 00:45:34< celticminstrel> ... 20180316 00:45:36< celticminstrel> Uh. What? 20180316 00:45:38< gfgtdf> and proxy.a will no longer return a table but some reference to the actual wml varaible, which might be uexpected 20180316 00:47:06< celticminstrel> Is that really true though? 20180316 00:47:16< gfgtdf> i don't think it's bad but i'd always use the the wml.rariables object that is simply syntax surgor for get_variable, simple becasue it is easier to understand and thus gived me a smaller chance to produce bugs. 20180316 00:47:21< celticminstrel> Hmm, I guess it is, actually. 20180316 00:47:33-!- travis-ci [~travis-ci@ec2-54-234-144-117.compute-1.amazonaws.com] has joined #wesnoth-dev 20180316 00:47:34< travis-ci> gfgtdf/wesnoth#1040 (no_syncedcommand - 36d9872 : gfgtdf): The build is still failing. 20180316 00:47:34< travis-ci> Build details : https://travis-ci.org/gfgtdf/wesnoth/builds/354107470 20180316 00:47:34-!- travis-ci [~travis-ci@ec2-54-234-144-117.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180316 00:48:38< celticminstrel> So basically it's implemented so that you can iterate over the returned proxy as if it were a regular WML table, which covers both the keys and the tags; but you can also access tags via dot syntax. 20180316 00:48:46< celticminstrel> Or via [n]. 20180316 00:48:58< celticminstrel> ...no, that's probably not quite true, actually. 20180316 00:49:20< celticminstrel> ... 20180316 00:49:34< celticminstrel> Come to think of it, wouldn't the former actually override the latter? 20180316 00:49:54< celticminstrel> That is, the tag in table format is represented as {name, contents}. 20180316 00:50:10< celticminstrel> So you can access the first tag regardless of name as proxy.a[1]. 20180316 00:50:28< celticminstrel> It wouldn't even call the __index metamethod. 20180316 00:51:42< celticminstrel> I think a better implementation would be one where the proxy stores nothing but the variable path. 20180316 00:52:16< gfgtdf> i actuall thought it does that? not sure though 20180316 00:52:17< celticminstrel> Or the path to the container at least, it wouldn't include scalar keys. 20180316 00:52:22< celticminstrel> It does do that, yes. 20180316 00:52:33< celticminstrel> But it also stores the entire content of the variable. 20180316 00:52:53< irker713> wesnoth/wesnoth:master grz0 3b384b7e17 Use xBRZ in unit preview widget and fact AppVeyor: All builds passed 20180316 00:53:05< celticminstrel> ...wait, no. 20180316 00:53:15< irker713> wesnoth/wesnoth:master Alexander van Gessel f2c6cb5f23 Switch to standard base64 AppVeyor: vs2015/Release Failed 20180316 00:53:16< irker713> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-1910 20180316 00:53:27< celticminstrel> I misinterpreted. It actually calls get_variable but then ignores the result if it was a table. 20180316 00:53:46< celticminstrel> So basically what would be needed to make it efficient is a function that can determine whether a given variable is a container. 20180316 00:55:09-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 246 seconds] 20180316 00:55:11< celticminstrel> gfgtdf: Actually I think it'd be totally possible to have a metatable where any of the following are valid and equivalent: 20180316 00:55:20< celticminstrel> variables.my_var[0].my_key 20180316 00:55:27< celticminstrel> variables.my_var.my_key 20180316 00:55:39< celticminstrel> variables["my_var[0].my_key"] 20180316 00:55:47< celticminstrel> variables["my_var.my_key"] 20180316 00:56:07< vultraz> Wait, aren’t arrays 1-indexed? 20180316 00:56:14< celticminstrel> (Could replace 0 with 1 if you want to be more Lua-y, but personally I would prefer if WML variables are 1-indexed even when working in Lua.) 20180316 00:56:20< celticminstrel> ^0-indexed 20180316 00:56:26< vultraz> Ah 20180316 00:56:28< vultraz> Ok 20180316 00:56:32< gfgtdf> threre was sucha function once but we (yo) 20180316 00:56:35< celticminstrel> vultraz: Since it's a metatable, you can easily make it 0-indexed if you so desire. 20180316 00:56:40< vultraz> Ahhh 20180316 00:57:03< vultraz> Is container.foo valid wml? 20180316 00:57:06< celticminstrel> Because you just receive the key (which is 0 or "my_var" or whatever) and decide what to do with it from there. 20180316 00:57:08< vultraz> I haven’t done wml for a long time 20180316 00:57:21< celticminstrel> vultraz: Should be, it'd access the first element of an array. 20180316 00:58:36< celticminstrel> Also, if we want a metatable such as I just described at some point in the future, we could just drop the old proxy (leaving it in helper only) and later extent the existing wml.variables to support the proxy format. 20180316 00:58:59< vultraz> Can’t we add it now? 20180316 00:59:27< celticminstrel> Probably, I'm just saying we don't have to. 20180316 00:59:48< gfgtdf> celticminstrel: assuming that my_key is realyl ascalar and not a child, tthen yes that is hot varaibel proxy is supposed to work. 20180316 00:59:49< vultraz> I think it would be good to to avoid making people do another conversion 20180316 01:00:09< gfgtdf> celticminstrel: note that there was once suhca function but you removed it becasue it didn't work https://github.com/wesnoth/wesnoth/commit/9f0c677d02c89a81cc960f9277a0bc40f1a5805e#diff-0372c7df0024028834bb3824eca4fde1 20180316 01:00:52< celticminstrel> What was it supposed to do again? 20180316 01:01:09< celticminstrel> But that said, it shouldn't be an argument to get_variable, it should be a separate function. 20180316 01:04:21< vultraz> celticminstrel: btw Ravana wanted you to move the resistance tags in the dunefolk pr next to the attack tag and not in the middle of the tag list 20180316 01:04:38< vultraz> Key list 20180316 01:04:39< celticminstrel> I put them there because it's right after the movetype key. :/ 20180316 01:05:03< Ravana_> that makes sense too, but last I looked some had there, and some next to attacks 20180316 01:05:24< celticminstrel> Well, it doesn't really matter that much to me, so I guess I can move them. 20180316 01:20:49-!- travis-ci [~travis-ci@ec2-54-161-229-116.compute-1.amazonaws.com] has joined #wesnoth-dev 20180316 01:20:50< travis-ci> wesnoth/wesnoth#16928 (luawml - 41b46ce : Celtic Minstrel): The build has errored. 20180316 01:20:50< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/354112516 20180316 01:20:50-!- travis-ci [~travis-ci@ec2-54-161-229-116.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180316 01:23:34-!- gfgtdf [~chatzilla@x4e363044.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.93 [Firefox 52.7.0/20180307131617]] 20180316 01:24:33< irker713> wesnoth/wesnoth:master Alexander van Gessel a3f560c66e Switch to standard base64 AppVeyor: vs2017/Release Failed 20180316 01:24:34< irker713> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-master-1614 20180316 01:31:06< vultraz> celticminstrel: probably can just merge it then 20180316 01:31:11< vultraz> But don’t forget changelog entries 20180316 01:31:55< vultraz> Also, what about adding the dunefolk to the default era? 20180316 01:34:47-!- travis-ci [~travis-ci@ec2-54-166-35-223.compute-1.amazonaws.com] has joined #wesnoth-dev 20180316 01:34:48< travis-ci> gfgtdf/wesnoth#1041 (no_syncedcommand - 9a99efc : gfgtdf): The build was fixed. 20180316 01:34:48< travis-ci> Build details : https://travis-ci.org/gfgtdf/wesnoth/builds/354114243 20180316 01:34:48-!- travis-ci [~travis-ci@ec2-54-166-35-223.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180316 01:42:49-!- Ravana_ [~Ravana@unaffiliated/ravana/x-2327071] has quit [Read error: Connection reset by peer] 20180316 01:43:24-!- Ravana_ [~Ravana@unaffiliated/ravana/x-2327071] has joined #wesnoth-dev 20180316 01:51:14< celticminstrel> vultraz: Well, adding them to default has that translatable string issue. 20180316 01:51:20< celticminstrel> I guess it depends on how serious that's seen to be. 20180316 01:51:47< celticminstrel> But it can't be pofixed. 20180316 01:52:00< celticminstrel> So either it's wrong for everyone or we don't add it until 1.15. 20180316 01:52:50-!- travis-ci [~travis-ci@ec2-54-234-144-117.compute-1.amazonaws.com] has joined #wesnoth-dev 20180316 01:52:51< travis-ci> gfgtdf/wesnoth#1042 (no_syncedcommand - bad1ba2 : gfgtdf): The build was fixed. 20180316 01:52:51< travis-ci> Build details : https://travis-ci.org/gfgtdf/wesnoth/builds/354124386 20180316 01:52:51-!- travis-ci [~travis-ci@ec2-54-234-144-117.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180316 02:10:49-!- travis-ci [~travis-ci@ec2-54-166-35-223.compute-1.amazonaws.com] has joined #wesnoth-dev 20180316 02:10:50< travis-ci> wesnoth/wesnoth#16929 (luawml - 9ac301d : Celtic Minstrel): The build has errored. 20180316 02:10:50< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/354112833 20180316 02:10:50-!- travis-ci [~travis-ci@ec2-54-166-35-223.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180316 02:14:57-!- octalot [~steve@91.141.3.130.wireless.dyn.drei.com] has quit [Ping timeout: 240 seconds] 20180316 02:54:14-!- Bonobo [~Bonobo@203.63.93.247] has joined #wesnoth-dev 20180316 03:13:29< irker713> wesnoth/wesnoth:master grz0 e6e142cc42 Use xBRZ in unit preview widget and fact AppVeyor: All builds passed 20180316 03:16:41< celticminstrel> IT WORKS! \o/ 20180316 03:16:41< irker713> wesnoth: Celtic Minstrel wesnoth:schema 09469e4af035 / src/config.cpp: Accept [and] and [or] in [filter_wml] https://github.com/wesnoth/wesnoth/commit/09469e4af0357b8d2d4870716f819527fd92ca2b 20180316 03:16:43< irker713> wesnoth: Celtic Minstrel wesnoth:schema 3fa10c817a22 / / (9 files in 3 dirs): Support [switch] and [if] in [tag] https://github.com/wesnoth/wesnoth/commit/3fa10c817a2256c5690fd1014e8be2d038eb3c0a 20180316 03:17:06< celticminstrel> BTW vultraz, if you want you could probably cherry-pick 09469e4a. 20180316 03:17:25< celticminstrel> Though of course it'd also need a changelog entry. 20180316 03:17:36< celticminstrel> Also use of [or] gets slightly weird. 20180316 03:18:00< celticminstrel> To be specific, if you want it to make sense, you can't have anything outside the [or] tag. 20180316 03:19:02< celticminstrel> ie, [filter_wml]thing=2 [or]thing=3[/or][/filter_wml] will never match if thing=3, but [filter_wml][or]thing=2[/or][or]thing=3[/or][/filter_wml] would. 20180316 03:20:01< celticminstrel> Naturally, [and] doesn't have this problem. Similarly, [not] doesn't have it because it's actually "and not". 20180316 03:20:45< celticminstrel> (I needed [or] and added [and] just because I could; I'm not sure if it has any actual use TBH.) 20180316 03:21:31< celticminstrel> (Certainly it's useless if you're only filtering on keys, because there's no situation where a key can have two values. It might be useful when filtering on tags, or if your filter covers both tags and keys.) 20180316 03:21:54< celticminstrel> (But again I can't think of a use.) 20180316 03:22:55-!- ShikadiQueen is now known as shadowm 20180316 03:34:51-!- vultraz [uid24821@wesnoth/developer/vultraz] has quit [Quit: Connection closed for inactivity] 20180316 03:39:05-!- travis-ci [~travis-ci@ec2-54-161-229-116.compute-1.amazonaws.com] has joined #wesnoth-dev 20180316 03:39:06< travis-ci> wesnoth/wesnoth#16932 (schema - 3fa10c8 : Celtic Minstrel): The build is still failing. 20180316 03:39:06< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/354146681 20180316 03:39:06-!- travis-ci [~travis-ci@ec2-54-161-229-116.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180316 04:01:22-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has joined #wesnoth-dev 20180316 04:05:25< celticminstrel> So I've discovered an interesting and interaction between two schema features that I'm not sure how to deal with. 20180316 04:05:59< celticminstrel> A tag can be derived from another tag (ie, declaring it as a "super" tag). In that case, any properties of the derived tag take priority in the case of conflicts. 20180316 04:06:29< celticminstrel> A tag can also contain conditional properties. In that case, if the condition matches, these conditional properties take priority over any non-conditional properties of the base tag. 20180316 04:06:43< celticminstrel> It's possible to make the "super" property conditional. 20180316 04:07:26< celticminstrel> This ends up making properties from the super tag override those of the derived tag in the event of conflicts, if the condition matches. 20180316 04:07:59< celticminstrel> Which is the opposite of what I want, but I'm not sure how I can fix it. Or indeed if I can fix it. 20180316 04:08:34< celticminstrel> I suppose one way might be to ensure the pseudo-tags representing the conditions actually contain all the properties of the base tag... 20180316 04:13:44< celticminstrel> ^interesting and undesirable 20180316 04:15:18< celticminstrel> ...ooooookay that makes it crash with bad_alloc. Fun! Guess I'll have to look at it more tomorrow. 20180316 04:22:48-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The computer falls into a deep sleep, to awake again some other day!] 20180316 04:28:35< irker713> wesnoth/wesnoth:master Charles Dang c723ca4a48 Tweaked wording, and shortened duration, AppVeyor: All builds passed 20180316 04:43:42< irker713> wesnoth/wesnoth:master Charles Dang 79b7e08573 Fixup 3783693cbe95 (removed a C++-ism) AppVeyor: All builds passed 20180316 05:14:33-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180316 05:14:43-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180316 05:40:06-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has quit [Quit: .] 20180316 05:40:24-!- vultraz [uid24821@wesnoth/developer/vultraz] has joined #wesnoth-dev 20180316 05:44:05< irker713> wesnoth/wesnoth:luawml Celtic Minstrel 9ac301d23d Lua API: Some tweaks of the experimental AppVeyor: vs2017/Release Failed 20180316 05:44:06< irker713> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-luawml-1621 20180316 05:53:15< irker713> wesnoth/wesnoth:master Alexander van Gessel f2c6cb5f23 Switch to standard base64 AppVeyor: 1/2 builds failed 20180316 05:53:16< irker713> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-1910 20180316 06:11:33< irker713> wesnoth: Celtic Minstrel wesnoth:master 82fd82d53403 / changelog.md src/config.cpp: Accept [and] and [or] in [filter_wml] https://github.com/wesnoth/wesnoth/commit/82fd82d53403b8173d234b8a3abef6a1e3ef39c9 20180316 06:24:33< irker713> wesnoth/wesnoth:master Alexander van Gessel a3f560c66e Switch to standard base64 AppVeyor: 2/4 builds failed 20180316 06:24:34< irker713> Details vs2017/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-master-1614 20180316 06:24:35< irker713> Details vs2013/Release: https://ci.appveyor.com/project/wesnoth/wesnoth/build/Wesnoth-VS2013-master-1924 20180316 06:25:51-!- JyrkiVesterinen [~JyrkiVest@195-192-251-124.s1net20180316 07:27:16< vultraz> ok wow, i messed up that second commit message :| 20180316 07:59:41< irker713> wesnoth/wesnoth:master Celtic Minstrel e8992d76df Support [switch] and [if] in [tag] AppVeyor: vs2017/Release Failed 20180316 07:59:42< irker713> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-master-1624 20180316 08:01:12< Soliton> vultraz: as i told celmin: if you want to make default+dunefolk default i suggest getting some expert players together to try to balance that new default as well as current default is. if that can even be done then it'd be fine to make it the new default era. 20180316 08:01:59< vultraz> I guess that's reasonable... 20180316 08:33:17< vultraz> I expect it would take a long time though 20180316 08:58:03< Soliton> probably. perhaps it would be better to think about adding an era for new factions that do not need to be as well balanced as default. 20180316 08:58:54< Soliton> the problem with extending default is that it gets exponentially more difficult to balance with every new faction. 20180316 08:59:34< Soliton> and balance is not only about unit stats. you'd likely also need to tweak the standard maps. 20180316 09:06:21< vn9711> By the way, is Drakes-Undead considered balanced? I'd personally be more interested in balancing that first, if we agree that Undead is stronger than Drakes considerably enough. 20180316 09:06:21< vn9711> P.S. I had my own thoughts in adding a basic melee-impact weapon to Drake Clasher, in the same line as the Thrasher upgrade, but weaker than other Clasher weapons so to only have effect against Undead. 20180316 09:07:02< vn9711> * Undead is stronger than Drakes -> strong *against* Drakes 20180316 09:07:59-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20180316 09:08:51< Soliton> undead vs drakes is certainly a volatile match-up but default is considered balanced. there might be reasonable slight tweaks still possible but it's going to be very difficult to verify these. 20180316 09:09:59-!- vladimirslavik [vslavik@nat/redhat/x-zpcziqycheqsknjl] has joined #wesnoth-dev 20180316 09:10:48< Soliton> as mentioned above you need to also consider the balance in the context of the default maps. the matchups will not be balanced on every map. (which is probably obvious though.) 20180316 09:13:49< irker713> wesnoth/wesnoth:master Celtic Minstrel e8992d76df Support [switch] and [if] in [tag] AppVeyor: 3/6 builds failed 20180316 09:13:50< irker713> Details vs2017/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-master-1624 20180316 09:13:51< irker713> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-1920 20180316 09:13:52< irker713> Details vs2013/Release: https://ci.appveyor.com/project/wesnoth/wesnoth/build/Wesnoth-VS2013-master-1934 20180316 09:14:42< vn9711> Soliton: yes, it is obvious enough. The good news about adding "impact" weapon to Clasher is that it'd be weaker than "blade" and "pierce" weapons against everyone but skeletons. Only skeletons are prone to "impact" weapons. That being said, it's of course more complex than that too. You have to make all or many units by playable in a matchup. Etc etc, can be expanded forever. Which is why we need strong players and an agreement to 20180316 09:14:43< vn9711> discuss this, which is hard. 20180316 09:15:11< vn9711> * be playable 20180316 09:16:46< Soliton> well, the agreement to discuss is not difficult but usually replays speak louder than words in this case. 20180316 09:17:15< Soliton> i wouldn't think that skeletons are an issue in undead vs drakes. 20180316 09:18:11< Soliton> you might have the odd skeleton archer but the bulk will be dark adepts. 20180316 09:19:21< vn9711> also true. 20180316 09:23:22-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180316 09:35:08-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20180316 09:42:19< Bonobo> in 1v1 drakes definitely lose the drake vs undead matchup 20180316 09:57:21-!- higgins [~higgins@68.ip-149-56-14.net] has quit [Quit: Leaving] 20180316 10:01:20-!- higgins [~higgins@68.ip-149-56-14.net] has joined #wesnoth-dev 20180316 10:07:40< Soliton> what would you change then? 20180316 10:10:44< Bonobo> hmm. the main problem drakes have in 1v1 is that retreating off of your own villages is not a good idea, but they're forced to do it by adepts 20180316 10:12:02< Bonobo> and on bigger maps, drakes are also bad since they can't cover all of their villages even with retreating and retaking, so they're strapped for gold most of the time 20180316 10:12:26< irker713> wesnoth/wesnoth:master gfgtdf 32adc489ab fix [do_command] AppVeyor: vs2013/Release Failed 20180316 10:12:27< irker713> Details: https://ci.appveyor.com/project/wesnoth/wesnoth/build/Wesnoth-VS2013-master-1935 20180316 10:14:09< Bonobo> more 5mp adepts would be good for drakes since the undead couldn't push as far at night, but the undead need 6mp(quick) adepts in other matchups since their mobility is so poor 20180316 10:15:58< Bonobo> the only things I would possibly suggest is making burners 20g, increasing the cold resistance of saurians or buffing the gliders in some way 20180316 10:18:29< Bonobo> giving the clasher a melee impact weapon would not help much since most of the time drakes don't want to recruit clashers anyway since they're slower and quick adepts outrun them 20180316 10:37:47-!- octalot [~steve@91.141.3.130.wireless.dyn.drei.com] has joined #wesnoth-dev 20180316 10:40:09-!- JyrkiVesterinen [~JyrkiVest@195-192-251-124.s1networks.fi] has quit [Quit: .] 20180316 11:18:02< irker713> wesnoth: Charles Dang wesnoth:master 2a7b8885a521 / src/gui/core/canvas.cpp: GUI2/Canvas: add missing ctor entries for drawn_shapes_ https://github.com/wesnoth/wesnoth/commit/2a7b8885a52168e29ca666cd4cfb20151b42c287 20180316 11:18:05< irker713> wesnoth: Charles Dang wesnoth:master 55866694ff44 / data/core/ (images/terrain/fake-shroud-editor.png terrain-graphics.cfg): Editor: added overlay to Fake Shroud terrain https://github.com/wesnoth/wesnoth/commit/55866694ff444b75723e6c1133b5e89c603a7417 20180316 11:18:08< irker713> wesnoth: Charles Dang wesnoth:master 85f98fc4d40a / data/core/terrain-graphics/borders.cfg: Bump map border layers https://github.com/wesnoth/wesnoth/commit/85f98fc4d40a31d409c3a0eb17a1b1d1ff2a9c07 20180316 11:18:28< vultraz> zookeeper: ^ 20180316 11:55:48-!- octalot [~steve@91.141.3.130.wireless.dyn.drei.com] has quit [] 20180316 11:58:34< irker713> wesnoth/wesnoth:master gfgtdf 32adc489ab fix [do_command] AppVeyor: 1/6 builds failed 20180316 11:58:35< irker713> Details vs2013/Release: https://ci.appveyor.com/project/wesnoth/wesnoth/build/Wesnoth-VS2013-master-1935 20180316 12:07:27-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180316 12:33:02< irker713> wesnoth/wesnoth:master Alexander van Gessel c800bb9be8 Switch to standard base64 AppVeyor: vs2017/Release Failed 20180316 12:33:03< irker713> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-master-1627 20180316 12:43:43-!- rdnyaomi [~mnqzgu@201-130-209-178-cable.cybercable.net.mx] has joined #wesnoth-dev 20180316 12:43:44-!- rdnyaomi [~mnqzgu@201-130-209-178-cable.cybercable.net.mx] has quit [Client Quit] 20180316 12:48:25< irker713> wesnoth: gfgtdf wesnoth:master e752a172d1b9 / src/game_events/action_wml.cpp: fix [do_command] https://github.com/wesnoth/wesnoth/commit/e752a172d1b915808f714fd3ec73bb233cb9c1de 20180316 12:48:27< irker713> wesnoth: gfgtdf wesnoth:master fef953a48e25 / / (15 files in 13 dirs): remove ai.synced_command https://github.com/wesnoth/wesnoth/commit/fef953a48e258e5b07ff4559eeff5571103d58c1 20180316 12:48:29< irker713> wesnoth: gfgtdf wesnoth:master 10a3ef1dac2b / / (15 files in 13 dirs): Merge pull request #2663 from gfgtdf/no_syncedcommand https://github.com/wesnoth/wesnoth/commit/10a3ef1dac2bb485ecb0d0a80d45334bc34d3103 20180316 12:48:55-!- JyrkiVesterinen [~JyrkiVest@195-192-251-124.s1networks.fi] has joined #wesnoth-dev 20180316 13:03:40< irker713> wesnoth/wesnoth:master Alexander van Gessel 33548ff530 Switch to standard base64 AppVeyor: vs2015/Release Failed 20180316 13:03:41< irker713> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-1923 20180316 13:41:24-!- hrubymar10 [~textual@78.108.103.216] has joined #wesnoth-dev 20180316 13:43:37< irker713> wesnoth: Charles Dang wesnoth:master 134353f863a6 / data/ (7 files in 5 dirs): Further cleanup of deprecated Lua API usecases (inc. ones from fef953a) https://github.com/wesnoth/wesnoth/commit/134353f863a65cb5cd97ddc9c890029b0cdcac8c 20180316 13:43:40< irker713> wesnoth: Charles Dang wesnoth:master 95d9eb7f1b3d / data/gui/window/unit_attack.cfg: Unit Attack: removed the Choose Weapon text https://github.com/wesnoth/wesnoth/commit/95d9eb7f1b3df9953e6f9170c26371348b026a9f 20180316 13:43:43< irker713> wesnoth: Charles Dang wesnoth:master 6a175d1bbc30 / src/ai/ (actions.cpp lua/core.cpp): Removed commented out stuff from fef953a48e25 https://github.com/wesnoth/wesnoth/commit/6a175d1bbc30d421d8775f579fbfdf6b3692c2d4 20180316 13:55:42-!- gfgtdf [~chatzilla@x4e3686cc.dyn.telefonica.de] has joined #wesnoth-dev 20180316 13:55:53< gfgtdf> there coudl actaully be more code removed, but i don't knwo that ai code that well 20180316 14:14:09-!- JyrkiVesterinen [~JyrkiVest@195-192-251-124.s1networks.fi] has quit [Quit: .] 20180316 14:22:27-!- Bonobo [~Bonobo@203.63.93.247] has quit [Ping timeout: 240 seconds] 20180316 14:40:05-!- vladimirslavik [vslavik@nat/redhat/x-zpcziqycheqsknjl] has quit [Remote host closed the connection] 20180316 14:40:30-!- vladimirslavik [vslavik@nat/redhat/x-qpwxwjzrnjblaaui] has joined #wesnoth-dev 20180316 14:44:34-!- vladimirslavik [vslavik@nat/redhat/x-qpwxwjzrnjblaaui] has quit [Read error: Connection reset by peer] 20180316 14:44:43< irker713> wesnoth: Alexander van Gessel wesnoth:master 0ed7ff100a00 / / (7 files in 4 dirs): Factor out base64 and crypt {en,de}coding https://github.com/wesnoth/wesnoth/commit/0ed7ff100a00bb837df7060a0f18e101e6ded0ae 20180316 14:44:44< irker713> wesnoth: Alexander van Gessel wesnoth:master b753b33239cb / src/tests/test_serialization.cpp: Add unit tests for base64 and crypt64 https://github.com/wesnoth/wesnoth/commit/b753b33239cbdd89cc4173f7cdf1d623d6fe01fe 20180316 14:44:46< irker713> wesnoth: Alexander van Gessel wesnoth:master 9932ed09995a / src/server/user_handler.cpp: Use common crypt64::encode in server https://github.com/wesnoth/wesnoth/commit/9932ed09995af3c8b2a280b3995876ea8db29df7 20180316 14:44:49< irker713> wesnoth: Alexander van Gessel wesnoth:master 4e11f6b46f18 / src/server/user_handler.cpp: Switch to standard base64 https://github.com/wesnoth/wesnoth/commit/4e11f6b46f18d494d92fb2d322c23ef56d058b88 20180316 14:44:50< irker713> wesnoth: Alexander van Gessel wesnoth:master 0f3d1c4a36ef / / (9 files in 6 dirs): Merge pull request #2647 from AI0867/base64-refactor https://github.com/wesnoth/wesnoth/commit/0f3d1c4a36effb0f138fc1a83f769ccea51ec32c 20180316 14:45:05-!- vladimirslavik [vslavik@nat/redhat/x-elvpjilvqsdchtql] has joined #wesnoth-dev 20180316 15:00:01-!- mkdroid [~null@unaffiliated/matthiaskrgr] has joined #wesnoth-dev 20180316 15:02:23-!- mkdroid [~null@unaffiliated/matthiaskrgr] has quit [Client Quit] 20180316 15:02:43-!- mkdroid [~null@unaffiliated/matthiaskrgr] has joined #wesnoth-dev 20180316 15:05:13-!- DeFender1031 [~DeFender1@dsl217-132-38-129.bb.netvision.net.il] has quit [Quit: I'm not back now.] 20180316 15:12:36-!- mkdroid [~null@unaffiliated/matthiaskrgr] has quit [Quit: I'll be back!] 20180316 15:29:22< irker713> wesnoth: Charles Dang wesnoth:master 2a6ba6924b58 / projectfiles/VC12/ (wesnothlib.vcxproj wesnothlib.vcxproj.filters): Updated VS projectfile https://github.com/wesnoth/wesnoth/commit/2a6ba6924b58ce1e1a0643735f825f61e5f2855e 20180316 15:29:40-!- hrubymar10 [~textual@78.108.103.216] has quit [Read error: Connection reset by peer] 20180316 15:57:33-!- vn971 [~vasya@94.158.103.15] has joined #wesnoth-dev 20180316 16:03:07-!- Netsplit *.net <-> *.split quits: vn9711 20180316 16:23:53-!- travis-ci [~travis-ci@ec2-54-166-253-186.compute-1.amazonaws.com] has joined #wesnoth-dev 20180316 16:23:54< travis-ci> holius-fr/wesnoth#1 (liminal_bonus - ec1c7cb : fsd): The build passed. 20180316 16:23:54< travis-ci> Build details : https://travis-ci.org/holius-fr/wesnoth/builds/354357581 20180316 16:23:54-!- travis-ci [~travis-ci@ec2-54-166-253-186.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180316 16:49:35-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 240 seconds] 20180316 17:07:02-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180316 17:33:02< irker713> wesnoth/wesnoth:master Alexander van Gessel c800bb9be8 Switch to standard base64 AppVeyor: 2/4 builds failed 20180316 17:33:03< irker713> Details vs2017/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-master-1627 20180316 17:33:04< irker713> Details vs2013/Release: https://ci.appveyor.com/project/wesnoth/wesnoth/build/Wesnoth-VS2013-master-1937 20180316 17:42:52-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has joined #wesnoth-dev 20180316 17:43:10-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20180316 17:51:43< irker713> wesnoth: Sofartin wesnoth:master 84ce193ef8dd / projectfiles/Xcode/Wesnoth.xcodeproj/project.pbxproj: Fixed Xcode project after #2647 https://github.com/wesnoth/wesnoth/commit/84ce193ef8ddca91c7b961a1aa47615b746187c8 20180316 18:03:41< irker713> wesnoth/wesnoth:master Alexander van Gessel 33548ff530 Switch to standard base64 AppVeyor: 1/2 builds failed 20180316 18:03:42< irker713> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-1923 20180316 18:07:32< irker713> wesnoth: Jyrki Vesterinen wesnoth:master b3f2169ca707 / src/serialization/string_view.hpp: Fix build with Visual Studio 2013 https://github.com/wesnoth/wesnoth/commit/b3f2169ca70757da0ddb059d97b8a63ceaf76563 20180316 18:18:12-!- mkdroid [~null@unaffiliated/matthiaskrgr] has joined #wesnoth-dev 20180316 18:50:26< irker713> wesnoth/wesnoth:master Hironori Fujimoto 5bc918b3fe text_box_base: Fix segfault when type ch AppVeyor: All builds passed 20180316 18:53:41< irker713> wesnoth: gfgtdf wesnoth:master f6428edabddb / RELEASE_NOTES: Update RELEASE_NOTES https://github.com/wesnoth/wesnoth/commit/f6428edabddba4db7cf5c48fbf82df967b340f1e 20180316 19:05:04-!- mkdroid [~null@unaffiliated/matthiaskrgr] has quit [Quit: I'll be back!] 20180316 19:10:06-!- vultraz [uid24821@wesnoth/developer/vultraz] has quit [Quit: Connection closed for inactivity] 20180316 19:12:23-!- octalot [~steve@77.119.129.12.wireless.dyn.drei.com] has joined #wesnoth-dev 20180316 19:25:04< irker713> wesnoth/wesnoth:master fsd 8467d605c3 adjust liminal unit stats after liminal AppVeyor: All builds passed 20180316 19:28:29< irker713> wesnoth/wesnoth:master fsd 95f3f59fbf use has_attribute(liminal_bonus) as sugg AppVeyor: vs2017/Release Failed 20180316 19:28:30< irker713> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-master-1636 20180316 19:30:38-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180316 19:45:10-!- Kawa[m] [kawamatrix@gateway/shell/matrix.org/x-fkqipdxqmwnxsqfc] has joined #wesnoth-dev 20180316 19:51:17-!- vladimirslavik [vslavik@nat/redhat/x-elvpjilvqsdchtql] has quit [Quit: Leaving] 20180316 20:01:57< irker713> wesnoth/wesnoth:master fsd 0521ab8b0f use has_attribute(liminal_bonus) as sugg AppVeyor: vs2015/Release Failed 20180316 20:01:58< irker713> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-1932 20180316 21:24:23< shadowm> Just got an email concerning the Coverity Scan downtime, btw. 20180316 21:28:24< loonycyborg> really? that's interesting 20180316 21:34:04< TadCarlucci> Coverity is back online. They request anyone with passwors there to reset them. 20180316 21:39:08< shadowm> https://pastebin.com/jUMPBTnr 20180316 21:45:52< irker713> wesnoth: Jyrki Vesterinen wesnoth:master 267510ea076c