20180317 05:51:29< vultraz> or 2
20180317 05:51:29< celticminstrel> That doesn't mean they can't be removed! Just means we won't be cleaning them out in a batch.
20180317 05:51:44< celticminstrel> Which stuff?
20180317 05:52:40< vultraz> set_*_metatable 
20180317 05:52:44< vultraz> tag, var
20180317 05:52:53< vultraz> we should also do something about wesnoth.fire
20180317 05:53:03< vultraz> and the wml metatable
20180317 05:53:07< vultraz> it's incredibly confusing
20180317 05:54:04< vultraz> I'd like to remove wesnoth.fire completely
20180317 05:54:21< celticminstrel> It does have a valid use-case.
20180317 05:54:34< celticminstrel> As the comment explains.
20180317 05:55:00< vultraz> sadly
20180317 05:56:05< vultraz> but what's confusing it it looks like there are 3 ways to call tags
20180317 05:56:21< vultraz> do you use fire(action)? wml_actions.action? metatable.action?
20180317 05:57:07< JyrkiVesterinen> And? Having multiple ways to do the same thing isn't a bad thing.
20180317 05:57:34< JyrkiVesterinen> programming/scripting languages (especially Ruby) often have similar stuff.
20180317 06:07:31< vultraz> because it's not clear when each should be used.
20180317 06:07:47< celticminstrel> It's largely a matter of preference.
20180317 06:08:03< celticminstrel> But wml_actions.action is slightly different semantically.
20180317 06:08:43< vultraz> it's not a matter of preference since there is the side affect of the vconfig translation when using 2/3 of those models
20180317 06:08:47< vultraz> modes*
20180317 06:09:56< vultraz> I remember how confused I was when trying to figure out which you were supposed to use
20180317 06:11:13-!- travis-ci [~travis-ci@ec2-54-205-233-71.compute-1.amazonaws.com] has joined #wesnoth-dev
20180317 06:11:14< travis-ci> wesnoth/wesnoth#16955 (lua_stuff - 893f71b : Celtic Minstrel): The build failed.
20180317 06:11:14< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/354630304
20180317 06:11:14-!- travis-ci [~travis-ci@ec2-54-205-233-71.compute-1.amazonaws.com] has left #wesnoth-dev []
20180317 06:12:25< celticminstrel> :(
20180317 06:13:41< celticminstrel> Looks like it's just tests though, so I guess if there's nothing else for that branch you could go ahead and merge it.
20180317 06:14:12< irker713> wesnoth: Celtic Minstrel wesnoth:lua_stuff 54425cd90243 / data/lua/helper.lua: Bump up a couple of deprecation levels at @vultraz's request https://github.com/wesnoth/wesnoth/commit/54425cd90243a201e6d36ed41d2ea2ee7ee482f9
20180317 06:14:23< celticminstrel> Almost forgot to push that, whoops. >_>
20180317 06:14:50< vultraz> ..wait a sec. in at least one case I replaced set_wml_var_metatable with just wml.variables...
20180317 06:15:00< vultraz> I think i was only in LoW
20180317 06:15:34< celticminstrel> wml.variables is still fine, wml.variable is gone.
20180317 06:16:06< vultraz> but it stil says to use 'wml.variable.proxy'
20180317 06:16:29< celticminstrel> Oh yeah, I forgot to update comments. And, I guess, the deprecation reference.
20180317 06:18:58< irker713> wesnoth: Celtic Minstrel wesnoth:lua_stuff 11646fb7ae89 / data/lua/ (core.lua helper.lua): fixup comment/deprecation references https://github.com/wesnoth/wesnoth/commit/11646fb7ae891911cac5e8057ce7253369ff2939
20180317 06:25:09-!- celticminstrel is now known as celmin|sleep
20180317 06:25:59< celmin|sleep> But yeah, wml.variables is not a replacement for set_wml_var_metatable, though it's good enough if they weren't doing anything too complicated.
20180317 06:26:50< irker713> wesnoth/wesnoth:master Celtic Minstrel a04bcf0b27 Fix matching of list types with limits AppVeyor: 3/6 builds failed
20180317 06:26:51< irker713> Details vs2017/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-master-1645
20180317 06:26:52< irker713> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-1941
20180317 06:26:53< irker713> Details vs2013/Release: https://ci.appveyor.com/project/wesnoth/wesnoth/build/Wesnoth-VS2013-master-1955
20180317 06:37:00< vultraz> GAH
20180317 06:37:04< vultraz> :(
20180317 06:37:10< vultraz> Alright, I’ll double check LoW...
20180317 06:37:21< vultraz> I think that was the only case
20180317 06:37:50< vultraz>  Or I’ll just change it to variablesprodxy
20180317 07:01:15-!- travis-ci [~travis-ci@ec2-54-198-163-69.compute-1.amazonaws.com] has joined #wesnoth-dev
20180317 07:01:16< travis-ci> wesnoth/wesnoth#16957 (lua_stuff - de743f3 : Celtic Minstrel): The build has errored.
20180317 07:01:16< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/354631934
20180317 07:01:16-!- travis-ci [~travis-ci@ec2-54-198-163-69.compute-1.amazonaws.com] has left #wesnoth-dev []
20180317 07:26:56< irker713> wesnoth/wesnoth:lua_stuff Celtic Minstrel 11646fb7ae fixup comment/deprecation references AppVeyor: vs2013/Release Failed
20180317 07:26:57< irker713> Details: https://ci.appveyor.com/project/wesnoth/wesnoth/build/Wesnoth-VS2013-lua_stuff-1960
20180317 07:57:03-!- travis-ci [~travis-ci@ec2-54-166-25-229.compute-1.amazonaws.com] has joined #wesnoth-dev
20180317 07:57:04< travis-ci> wesnoth/wesnoth#16959 (lua_stuff - 11646fb : Celtic Minstrel): The build has errored.
20180317 07:57:04< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/354635872
20180317 07:57:04-!- travis-ci [~travis-ci@ec2-54-166-25-229.compute-1.amazonaws.com] has left #wesnoth-dev []
20180317 08:02:09-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20180317 08:31:13-!- hrubymar10 [~textual@78.108.103.216] has joined #wesnoth-dev
20180317 08:53:00-!- Oebele [~quassel@143.177.58.202] has joined #wesnoth-dev
20180317 09:00:13-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20180317 09:03:14-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20180317 09:27:19< irker713> wesnoth/wesnoth:lua_stuff Celtic Minstrel 11646fb7ae fixup comment/deprecation references AppVeyor: 3/6 builds failed
20180317 09:27:20< irker713> Details vs2013/Release: https://ci.appveyor.com/project/wesnoth/wesnoth/build/Wesnoth-VS2013-lua_stuff-1960
20180317 09:27:21< irker713> Details vs2017/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-lua_stuff-1650
20180317 09:27:22< irker713> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-lua_stuff-1946
20180317 09:39:03< JyrkiVesterinen> ...what is this. Looks like utils::wildcard_string_match() is completely broken for strings which contain question marks but not asterisks.
20180317 09:39:04< JyrkiVesterinen> https://github.com/wesnoth/wesnoth/blob/master/src/serialization/string_utils.cpp#L705-L710
20180317 09:39:41< vultraz> hm? what is the context?
20180317 09:39:54< JyrkiVesterinen> If there aren't any asterisks, have_solids is false and the function proceeds to the "simple case" branch where it simply checks if the pattern and string are identical.
20180317 09:40:02< vultraz> oh
20180317 09:40:05< vultraz> i got it
20180317 09:41:38< JyrkiVesterinen> There are unit tests, but none of them test the "question mark should match any character in a pattern with question marks and without asterisks" case.
20180317 09:41:40< JyrkiVesterinen> https://github.com/wesnoth/wesnoth/blob/master/src/tests/test_serialization.cpp#L104
20180317 09:48:29< JyrkiVesterinen> Actually, on second thought, the code is fine.
20180317 09:48:49< JyrkiVesterinen> have_solids is about whether there are any characters *other than* asterisks.
20180317 09:49:28< JyrkiVesterinen> Thefroe, have_solids is false only if 1) the pattern is empty or 2) the match consists entirely of asterisks.
20180317 09:49:54< JyrkiVesterinen> And in the second case, wild_matching is true, and the function returns true as expected.
20180317 10:14:21< irker713> wesnoth: RatArmy wesnoth:master 16c822cbb448 / src/ (font/text.cpp font/text.hpp gui/widgets/text_box_base.cpp): text_box_base: Fix segfault when type characters more than limit by IME (#2666) https://github.com/wesnoth/wesnoth/commit/16c822cbb4485b22eecf483699686ab325357521
20180317 10:24:38-!- Oebele [~quassel@143.177.58.202] has quit [Remote host closed the connection]
20180317 10:37:19-!- hrubymar10 [~textual@78.108.103.216] has quit [Quit: hrubymar10]
20180317 10:42:13-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20180317 10:50:24< JyrkiVesterinen> I opted to make one bevahior change to utils::wildcard_string_match().
20180317 10:50:50< JyrkiVesterinen> Previously, utils::wildcard_string_match("", "*foo") returned true.
20180317 10:51:19< JyrkiVesterinen> In other words, a pattern that begins with an asterisk matched empty strings, even if there were other characters.
20180317 10:51:30< JyrkiVesterinen> It no longer does that.
20180317 10:51:52< JyrkiVesterinen> * even if there were other characters in the pattern (to clarify)
20180317 11:02:46-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20180317 11:03:30-!- travis-ci [~travis-ci@ec2-54-198-163-69.compute-1.amazonaws.com] has joined #wesnoth-dev
20180317 11:03:31< travis-ci> wesnoth/wesnoth#16960 (master - 16c822c : RatArmy): The build failed.
20180317 11:03:31< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/354675779
20180317 11:03:31-!- travis-ci [~travis-ci@ec2-54-198-163-69.compute-1.amazonaws.com] has left #wesnoth-dev []
20180317 11:09:23-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20180317 11:21:14-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20180317 11:26:14-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180317 11:26:20-!- janebot_ [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20180317 11:26:22-!- janebot_ is now known as janebot
20180317 12:01:46< irker713> wesnoth: Jyrki Vesterinen wesnoth:master eed3927d12e9 / src/ (addon/manager.cpp filesystem.hpp): Move default filename ignore list to filesystem.hpp https://github.com/wesnoth/wesnoth/commit/eed3927d12e98a2c6381b2a72b3e1d67d2900d98
20180317 12:01:48< irker713> wesnoth: Jyrki Vesterinen wesnoth:master c5e972b8b4b2 / src/ (7 files in 4 dirs): Disallow accessing files whose names are in the default ignore list https://github.com/wesnoth/wesnoth/commit/c5e972b8b4b2dc0355dd05f2527c90c985de40a9
20180317 12:11:35< irker713> wesnoth: Jyrki Vesterinen wesnoth:master 19ac9c9560f8 / changelog.md players_changelog.md: Changelog entry for commit c5e972b8b4b2dc0355dd05f2527c90c985de40a9 https://github.com/wesnoth/wesnoth/commit/19ac9c9560f86cc87058a0d791893e58db7020e7
20180317 12:15:34-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has quit [Quit: .]
20180317 12:41:19-!- vultraz [uid24821@wesnoth/developer/vultraz] has quit [Quit: Connection closed for inactivity]
20180317 12:53:25-!- travis-ci [~travis-ci@ec2-54-198-163-69.compute-1.amazonaws.com] has joined #wesnoth-dev
20180317 12:53:26< travis-ci> wesnoth/wesnoth#16961 (master - c5e972b : Jyrki Vesterinen): The build is still failing.
20180317 12:53:26< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/354698804
20180317 12:53:26-!- travis-ci [~travis-ci@ec2-54-198-163-69.compute-1.amazonaws.com] has left #wesnoth-dev []
20180317 12:55:58-!- JyrkiVesterinen [~jyrki@85-23-197-3.bb.dnainternet.fi] has joined #wesnoth-dev
20180317 13:01:52-!- vn971 [~vasya@94.158.103.15] has quit [Quit: Leaving.]
20180317 13:10:56-!- travis-ci [~travis-ci@ec2-54-198-163-69.compute-1.amazonaws.com] has joined #wesnoth-dev
20180317 13:10:57< travis-ci> wesnoth/wesnoth#16962 (master - 19ac9c9 : Jyrki Vesterinen): The build is still failing.
20180317 13:10:57< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/354700820
20180317 13:10:57-!- travis-ci [~travis-ci@ec2-54-198-163-69.compute-1.amazonaws.com] has left #wesnoth-dev []
20180317 13:15:41-!- hrubymar10 [~textual@ip-86-49-9-122.net.upcbroadband.cz] has joined #wesnoth-dev
20180317 13:29:10< irker713> wesnoth: Jyrki Vesterinen wesnoth:master 81d965cdc399 / src/ (display.cpp gui/dialogs/screenshot_notification.cpp tests/test_filesystem.cpp): Fix C++ unit test failures https://github.com/wesnoth/wesnoth/commit/81d965cdc399300f55dcebda37c49c51aa27906d
20180317 13:44:03-!- celmin|sleep is now known as celticminstrel
20180317 13:47:47< irker713> wesnoth: Celtic Minstrel wesnoth:lua_stuff a9c757b4afe0 / / (8 files in 7 dirs): Cleanup of fef953a48e258e5b07ff4559eeff5571103d58c1 https://github.com/wesnoth/wesnoth/commit/a9c757b4afe0c8dd2afb998f653bafe09d4dec2e
20180317 13:47:49< irker713> wesnoth: Celtic Minstrel wesnoth:lua_stuff 835e58bff070 / data/lua/core.lua: Lua API: Some tweaks of the experimental wml module https://github.com/wesnoth/wesnoth/commit/835e58bff070eb24e9546f66dd2d1e1e8c0e1ffe
20180317 13:47:51< irker713> wesnoth: Celtic Minstrel wesnoth:lua_stuff 4f4166403b83 / data/lua/helper.lua: Bump up a couple of deprecation levels at @vultraz's request https://github.com/wesnoth/wesnoth/commit/4f4166403b8317a3462144a75164246181e4e54b
20180317 13:47:53< irker713> wesnoth: Celtic Minstrel wesnoth:lua_stuff a5fa553921b2 / data/lua/ (core.lua helper.lua): fixup comment/deprecation references https://github.com/wesnoth/wesnoth/commit/a5fa553921b27cfb1bcd54c91f401d3be2251156
20180317 13:55:03-!- JyrkiVesterinen [~jyrki@85-23-197-3.bb.dnainternet.fi] has quit [Quit: .]
20180317 13:56:14-!- travis-ci [~travis-ci@ec2-54-198-163-69.compute-1.amazonaws.com] has joined #wesnoth-dev
20180317 13:56:15< travis-ci> wesnoth/wesnoth#16963 (master - 81d965c : Jyrki Vesterinen): The build was fixed.
20180317 13:56:15< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/354718603
20180317 13:56:15-!- travis-ci [~travis-ci@ec2-54-198-163-69.compute-1.amazonaws.com] has left #wesnoth-dev []
20180317 14:08:57-!- kristinamillona9 [~cuaiqgse@168.0.194.38] has joined #wesnoth-dev
20180317 14:09:00-!- kristinamillona9 [~cuaiqgse@168.0.194.38] has quit [Client Quit]
20180317 14:19:33-!- Bonobo [~Bonobo@203.63.93.247] has quit [Ping timeout: 264 seconds]
20180317 14:47:15-!- gfgtdf [~chatzilla@x4e36820d.dyn.telefonica.de] has joined #wesnoth-dev
20180317 14:48:26-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has joined #wesnoth-dev
20180317 15:06:16-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20180317 15:27:38< irker713> wesnoth: gfgtdf wesnoth:gfgtdf-patch-1 e37d511d2fa0 / src/units/drawer.cpp: add bar_offset_x/y to [unit_type] https://github.com/wesnoth/wesnoth/commit/e37d511d2fa06d5aa1854c334d46cdbd898fa550
20180317 15:28:01< gfgtdf> zookeeper, shadowm, vultrazt: an opinion? ^
20180317 15:29:07< gfgtdf> (untested might need an update later)
20180317 15:34:11< zookeeper> so bar_offset_x,bar_offset_y=-20,-10 means the top left corner of the bar will be offset -20,-10 from the usual position? but what _is_ the current logic, anyway (for >72x72 sprites)?
20180317 15:37:34< zookeeper> i'm guessing it's something like "14,14 from the top left corner of the sprite".
20180317 15:40:08< gfgtdf> yes, offset form the usual position. 
20180317 15:40:46< gfgtdf> i didn't test how it haes with zoom though
20180317 15:41:00< gfgtdf> behvaes*
20180317 15:41:39< gfgtdf> behaves*
20180317 16:02:43-!- vultraz [uid24821@wesnoth/developer/vultraz] has joined #wesnoth-dev
20180317 16:03:24< vultraz> zookeeper: heads up, I'm tagging 1.13.12 in about 8 hours if there's anything else you want to get in that release
20180317 16:03:45< zookeeper> oh, huh, yeah. almost forgot.
20180317 16:04:20< vultraz> celticminstrel: you too. Please merge anyting from lua_stuff that's applicable
20180317 16:05:21< vultraz> celticminstrel: and decide if you want the dunefolk stuff in
20180317 16:19:41< vultraz> pondering if i should commit my new DiD S1 and 6 map.
20180317 16:20:43< zookeeper> what's new about it?
20180317 16:21:20-!- travis-ci [~travis-ci@ec2-54-198-163-69.compute-1.amazonaws.com] has joined #wesnoth-dev
20180317 16:21:21< travis-ci> wesnoth/wesnoth#16965 (gfgtdf-patch-1 - e37d511 : gfgtdf): The build was broken.
20180317 16:21:21< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/354747870
20180317 16:21:21-!- travis-ci [~travis-ci@ec2-54-198-163-69.compute-1.amazonaws.com] has left #wesnoth-dev []
20180317 16:22:50< irker713> wesnoth: gfgtdf wesnoth:gfgtdf-patch-1 57648cf4e932 / src/units/drawer.cpp: fixup https://github.com/wesnoth/wesnoth/commit/57648cf4e932a6bf23bb9d2b29367ecbda7522c3
20180317 16:40:08-!- DeFender1031 [~DeFender1@dsl217-132-38-129.bb.netvision.net.il] has joined #wesnoth-dev
20180317 16:41:45< vultraz> zookeeper: it's ... new. I redrew it
20180317 16:45:14< irker713> wesnoth/wesnoth:master Jyrki Vesterinen 81d965cdc3 Fix C++ unit test failures AppVeyor: All builds passed
20180317 16:45:35< zookeeper> vultraz, yes... that's what you said.
20180317 16:45:49< vultraz> it looks better
20180317 16:46:07< zookeeper> if it's so different you can't explain the differences, then maybe you want to paste the map data or a screenshot or something.
20180317 16:47:05< vultraz> see discord
20180317 16:51:07< zookeeper> sure, it looks nice, but it also has non-minor gameplay implications you'd also have to adjust for, no?
20180317 16:51:31< vultraz> not really
20180317 16:51:46< vultraz> the scenario is short (15 turns) and i tested you can still win within that time
20180317 16:54:20< zookeeper> the difficulty isn't affected by the enemy camp being so much further away and behind a forest?
20180317 16:55:03< vultraz> It didn't seem to
20180317 16:55:12< vultraz> well
20180317 16:55:16< vultraz> i didn't play the old map
20180317 16:55:19< vultraz> so, possibly
20180317 16:57:59< zookeeper> anyway, as said i think it looks fine aesthetics-wise, although i think the stone bridge is a mistake. it's a little frontier town and it's literally the "ford of parthyn" so having a big fancy stone bridge and a road leading north to pretty much nowhere doesn't make much sense.
20180317 16:58:36< vultraz> Pretty sure any town would have a stone bridge
20180317 16:58:57< zookeeper> in fact the cobbled roads are a bit fancy too
20180317 16:59:16< vultraz> small town doesn't mean poor or recently-established town
20180317 16:59:39-!- travis-ci [~travis-ci@ec2-54-198-163-69.compute-1.amazonaws.com] has joined #wesnoth-dev
20180317 16:59:40< travis-ci> wesnoth/wesnoth#16967 (gfgtdf-patch-1 - 57648cf : gfgtdf): The build was fixed.
20180317 16:59:40< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/354762899
20180317 16:59:40-!- travis-ci [~travis-ci@ec2-54-198-163-69.compute-1.amazonaws.com] has left #wesnoth-dev []
20180317 17:00:45< vultraz> keep in mind I do my maps primarily with aesthetics in mind
20180317 17:02:12< zookeeper> uh, how should that knowledge affect my feedback on them..?
20180317 17:02:26< celticminstrel> ^
20180317 17:02:51< celticminstrel> I also don't think this comment makes any sense:
20180317 17:02:52< celticminstrel> [Mar 17@12:58:36pm] vultraz: Pretty sure any town would have a stone bridge
20180317 17:03:10< vultraz> hm. point taken i guess
20180317 17:03:27< celticminstrel> Even this is questionable:
20180317 17:03:28< celticminstrel> [Mar 17@12:59:16pm] vultraz: small town doesn't mean poor or recently-established town
20180317 17:05:35< celticminstrel> I'll give you the recently-established part; but there is at the very least a strong correlation between town size and town wealth.
20180317 17:06:04< celticminstrel> (Actually if you plot size, wealth, and age, I suppose the correlation between size and wealth would become weaker as age increases.)
20180317 17:06:28< zookeeper> orcs regularly attacking from the north over the ford is kind of a major thing in the campaign, and you'd think they wouldn't build a nice big bridge plus a road to make that easier.
20180317 17:06:38< celticminstrel> Still, the main point is... if it's small, it very likely is poor unless there's a good reason otherwise.
20180317 17:07:08< celticminstrel> Zookeeper has a good point too. Especially if the river's quite shallow (the ford terrain), which means you don't even really need a bridge to cross.
20180317 17:07:38< zookeeper> for sure it's not explicitly stated in the text that parthyn is a small and kind of poor backwater town, but it's clearly the intent of the old maps to portray it that way.
20180317 17:07:56< celticminstrel> gfgtdf: No complaints on the patch, but I really think you should at least test it first.
20180317 17:08:14< vultraz> hm
20180317 17:08:18< vultraz> well, i kinda spruced it up
20180317 17:08:30< celticminstrel> vultraz: Further on this topic... the reason the correlation exists is largely because wealthier towns attract people and thus grow in size.
20180317 17:09:26< vultraz> Hmm.. Yes, make sense.
20180317 17:10:05< vultraz> There's also the opposite correlation, that towns can grow wealthier as they grow larger.
20180317 17:10:47< celticminstrel> If they grow larger due to some other reason, sure.
20180317 17:10:57< celticminstrel> But in that case there's something else to attract people to them.
20180317 17:11:25< vultraz> Resources, usually
20180317 17:11:29< celticminstrel> And note that by "attract" I don't necessarily mean people want to go there, it could equally well be that they're forced to.
20180317 17:11:32< celticminstrel> Not just resources.
20180317 17:11:44< vultraz> Location too
20180317 17:11:59< vultraz> London, for example.
20180317 17:12:03< zookeeper> the old map has a clear aesthetic "message"; it's a small backwater town with crappy roads and wooden fortifications without anything much built beyond the river (sure, there's a couple of villages). your version tells us that it's as healthy and thriving a place as any, nice roads, masonry and all that.
20180317 17:12:23< vultraz> (did we both take human geography?)
20180317 17:15:55< celticminstrel> I dunno if you're asking me, but... I did study some geography, but only in high school.
20180317 17:23:08< celticminstrel> BTW zookeeper, did you have any thoughts on the Dunefolk PR?
20180317 17:24:48< zookeeper> making adjustments for aesthetics is great, but you might want to consider more what sort of things the original's aesthetic choices communicate and build on that.
20180317 17:25:06< celticminstrel> For the balance PR?
20180317 17:25:22< zookeeper> celticminstrel, umm, no not really, i don't have any balancing proficiency.
20180317 17:27:34 * celticminstrel blinks.
20180317 17:27:40< celticminstrel> WAIT WHY IS THE TOD IMAGE BROKEN
20180317 17:27:55< vultraz> hm?
20180317 17:28:09< celticminstrel> It looks like it's zoomed in and cut off.
20180317 17:29:26< vultraz> ah, you're noticing the new ToD images for the default schedule
20180317 17:29:27< zookeeper> uh...
20180317 17:29:53< celticminstrel> Link the images for me?
20180317 17:30:08< zookeeper> surely you're looking at them
20180317 17:30:20< celticminstrel> I don't know. Maybe.
20180317 17:30:31< zookeeper> you can tell they're not zoomed in, so what else would they be
20180317 17:30:32< vultraz> https://github.com/wesnoth/wesnoth/commit/443339d8a066c33927b7123fd13d9720ff91974e
20180317 17:31:32< celticminstrel> Because they look loke zoomed-in versions of the old so I wasn't sure.
20180317 17:31:38< celticminstrel> TBH I think I like the old ones better.
20180317 17:31:46< vultraz> *blinks*
20180317 17:31:54< vultraz> :|
20180317 17:32:31< celticminstrel> This change is going to break anyone who uses a semi-custom schedule, as well.
20180317 17:32:47< vultraz> they'll just have to live with it
20180317 17:32:51< celticminstrel> "break" meaning "their ToD images don't match"
20180317 17:32:56< celticminstrel> That's the wrong attitude to have.
20180317 17:34:13< celticminstrel> IMO this change should be reverted and postponed to 1.15.
20180317 17:34:16< vultraz> i didn't update the 24h schedule, btw
20180317 17:34:20< vultraz> NO
20180317 17:34:23< celticminstrel> So that the other schedules can also be updated to match.
20180317 17:34:28< celticminstrel> Not just 24h but also two-suns.
20180317 17:34:37< vultraz> for fuck's sake. 
20180317 17:35:43< celticminstrel> People using default schedules are going to have mismatching ToD images.
20180317 17:36:14< celticminstrel> Anyone who uses {SUMMER_SCHEDULE} or {WINTER_SCHEDULE}.
20180317 17:36:40< celticminstrel> IOW if you're updating the default schedule you need to also update the 24h schedule. If you can commit to doing that for 1.14, then I'd be okay with not postponing it.
20180317 17:36:52< vultraz> Both of those use the default [time] definitions!
20180317 17:37:09< celticminstrel> {MIDNIGHT} and {MIDDAY} use images from the 24h schedule.
20180317 17:37:27< celticminstrel> {SUMMER_SCHEDULE} uses {MIDDAY}. {WINTER_SCHEDULE} uses {MIDNIGHT}.
20180317 17:37:38< vultraz> Also, in 1.15 the theme is going to change and all current ToD images are going to be thrown out for larger versions.
20180317 17:37:59< celticminstrel> Well in that case I don't really see why you're doing this at all, but whatever.
20180317 17:38:13< vultraz> To make it look better in 90% of the cases
20180317 17:38:31< celticminstrel> Okay, then update the 24h schedule too.
20180317 17:38:47< vultraz> Why don't you do it yourself if it's such a big deal
20180317 17:38:54< celticminstrel> Do I look like an artist?
20180317 17:39:11< vultraz> HAH
20180317 17:39:13< vultraz> you think I drew these?
20180317 17:39:20< celticminstrel> I know you didn't.
20180317 17:39:26< celticminstrel> Your commit message says as much.
20180317 17:39:45< vultraz> Crop out the relevant image, shrink it to 125w while preserving aspect ratio, crop to layer size, optinally add some clouds
20180317 17:40:55< vultraz> We have to prioritize what we work on. 
20180317 17:41:05< vultraz> I don't CARE if the mismatch
20180317 17:41:08< vultraz> they*
20180317 17:41:19< celticminstrel> That's funny coming from you, the aesthetics guy.
20180317 17:41:46< vultraz> The improved aesthetics are worth the mismatch
20180317 17:41:57< celticminstrel> They don't look all that much better TBH.
20180317 17:42:05< celticminstrel> Maybe a little better on average.
20180317 17:42:15< vultraz> well, that's because they're still tiny
20180317 17:42:24< celticminstrel> No, it's not because they're tiny...
20180317 17:44:12< vultraz> I'll admit the purely day ones look a bit sparse, but I had no land overlays to work with.
20180317 17:44:35< vultraz> But they certainly look better
20180317 17:45:36< irker713> wesnoth/wesnoth:lua_stuff Celtic Minstrel a5fa553921 fixup comment/deprecation references AppVeyor: vs2017/Release Failed
20180317 17:45:37< irker713> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-lua_stuff-1655
20180317 17:45:42< celticminstrel> The one I like the least is dawn. It looks definitely worse than the old IMO (and the moon is barely even visible). I'm also not a fan of the cloud cover.
20180317 17:46:01< celticminstrel> Morning and afternoon aren't so great for the latter reason.
20180317 17:46:15< celticminstrel> The clouds in dawn and dusk are pretty nice though.
20180317 17:46:20< vultraz> the moon is barely visible a dawn!
20180317 17:46:28< celticminstrel> Shows what you know.
20180317 17:46:40< celticminstrel> It's commonly well above the horizon at dawn.
20180317 17:47:06< celticminstrel> The old image represents this reasonably well.
20180317 17:47:41< celticminstrel> I think it'd actually be less likely to be visible at dusk than dawn? Not sure though, it could be more that some days it's more visible at dawn and others it's more visible at dusk.
20180317 17:47:43< vultraz> perhaps it depends on where you are
20180317 17:47:48< celticminstrel> Oh, certainly.
20180317 17:48:02< vultraz> You live far north
20180317 17:48:07< vultraz> I live 7 degrees off the equator
20180317 17:48:12< celticminstrel> Not that far north.
20180317 17:49:31-!- vn971 [~vasya@94.158.103.15] has joined #wesnoth-dev
20180317 17:50:19< irker713> wesnoth: doofus-01 wesnoth:master 003942410f95 / data/campaigns/Under_the_Burning_Suns/ (34 files in 7 dirs): [UtBS] Quenoth Mystic and Sun Singer line animations (#2579) https://github.com/wesnoth/wesnoth/commit/003942410f95d21dd82cf9d58117505fbf7bacf3
20180317 17:50:41< vn971> Is it a known problem? This page gives 500 internal server error: http://replays.wesnoth.org/1.12/20180316/
20180317 17:51:27-!- mkdroid [~null@unaffiliated/matthiaskrgr] has joined #wesnoth-dev
20180317 17:51:31< vn971> It started from 16-th of March. 15-th is okay. 17-th is broken too.
20180317 17:52:52< vultraz> dunno
20180317 17:54:59< shadowm> gfgtdf: I can't give you an opinion, I'm in bed, recovering from surgery, can't build Wesnoth, and I can't download it either without it eating up a bunch of my monthly data.
20180317 17:59:32< vn971> shadowm: wishing you fastest recovery!
20180317 18:02:40-!- mkdroid [~null@unaffiliated/matthiaskrgr] has quit [Quit: I'll be back!]
20180317 18:16:08< zookeeper> gfgtdf, remind me, did we end up having a behavioral change WRT something about die events, [kill] and the dying unit?
20180317 18:16:42< gfgtdf> zookeeper: yes the 'changes in 1.13' forum tread also mention them iirc.
20180317 18:17:51< zookeeper> gfgtdf, oh right, the one related to [endlevel]
20180317 18:18:23< zookeeper> yeah, i just found a die event loop in SoF that happens because of that.
20180317 18:18:42< gfgtdf> zookeeper: which scenario ?
20180317 18:18:45< zookeeper> last one
20180317 18:19:48< gfgtdf> zookeeper: i'm currently playing/testing SoF but im only at scenrio 6
20180317 18:21:02< irker713> wesnoth/wesnoth:master Jyrki Vesterinen 19ac9c9560 Changelog entry for commit c5e972b8b4b2d AppVeyor: All builds passed
20180317 18:22:44< gfgtdf> zookeeper: i first wanted to play hammor of thurdistan, but then decided to do SoF instead after it seemed to me that hammer of thurgistan only contains 'kill all enemy leader' scenarios,
20180317 18:23:15< JyrkiVesterinen> It's Hammer of Thursagan.
20180317 18:23:39< JyrkiVesterinen> "thurdistan" sounds like a mid-Asian country.
20180317 18:27:32< irker713> wesnoth: Celtic Minstrel wesnoth:master ee8077ea14c6 / data/core/units/dunefolk/ (16 files): Dunefolk balancing tweaks https://github.com/wesnoth/wesnoth/commit/ee8077ea14c69dede06a2646ff2a619e50cf4649
20180317 18:27:33< zookeeper> well at least it has that h...
20180317 18:27:34< irker713> wesnoth: Celtic Minstrel wesnoth:master c8f95b1bf563 / data/core/units/dunefolk/Piercer.cfg: Simplify Piercer resistance definition by only listing those that differ from th https://github.com/wesnoth/wesnoth/commit/c8f95b1bf563fcfe57567b27483e323af02e7387
20180317 18:27:36< irker713> wesnoth: Celtic Minstrel wesnoth:master 5c3f04518d82 / data/core/units/dunefolk/ (Marauder.cfg Raider.cfg): Attempt to address RIPLIB violations in Raider -> Marauder advancement https://github.com/wesnoth/wesnoth/commit/5c3f04518d822bf0ac780e4d18edf90d7f5c58ab
20180317 18:28:58< irker713> wesnoth: loonycyborg wesnoth:master 45311b2b0e0e / changelog.md po/wesnoth-lib/cs.po po/wesnoth-sota/cs.po: Updated Czech translation https://github.com/wesnoth/wesnoth/commit/45311b2b0e0e645fb15bbc25e5dd60a4895695e9
20180317 18:29:00< irker713> wesnoth: loonycyborg wesnoth:master 828aee9416ae / doc/manual/SConscript: Changed docbook xsl path back so it works for me https://github.com/wesnoth/wesnoth/commit/828aee9416aed9d23b77211bc383b9ab906aed2a
20180317 18:32:04< gfgtdf> i actuall thought it woudl be the name of a country when  i read that titlte first, that's probably why i assumed it would spell thurdistan.
20180317 18:32:32 * zookeeper blinks
20180317 18:32:52< gfgtdf> not of  a real county i mean
20180317 18:33:31< gfgtdf> a wesnothian country.
20180317 18:34:56< zookeeper> i hate this scenario... so awkward to try to fix the end sequence
20180317 18:35:41< gfgtdf> the create unit dialog no longer shows th units image, is this intentional ?
20180317 18:35:45< gfgtdf> the*
20180317 18:36:28< vultraz> hm?
20180317 18:37:54< vultraz> celticminstrel: please add changelog entries for all the dunefolk changes
20180317 18:42:10< irker713> wesnoth: loonycyborg wesnoth:master cdd1cb692bbb / / (1002 files in 17 dirs): pot-update and regenerate doc files https://github.com/wesnoth/wesnoth/commit/cdd1cb692bbb121a1650a45789b7f9e9059cd06d
20180317 18:42:36< Soliton> preferably in the same format of all other balancing changes.
20180317 18:44:56< gfgtdf> celticminstrel: do you know why in https://github.com/wesnoth/wesnoth/commit/2d7d6a0dde2a7426f99d3502f959cf82b2fda93f#diff-1def2299340fc64a36461f85acc71b65 you choose 'hex_size_by_2 ' instead of of 0 ?
20180317 18:46:27< irker713> wesnoth: gfgtdf wesnoth:gfgtdf-patch-1 a4314ac8ee9e / src/units/drawer.cpp: f https://github.com/wesnoth/wesnoth/commit/a4314ac8ee9e73ed43fb227de34e8580b6961a7d
20180317 18:47:22< vultraz> blah, that's going to cause serious merge conflicts on a_r..
20180317 18:47:32< irker713> wesnoth: gfgtdf wesnoth:master ff31a99aa2cd / src/units/drawer.cpp: add bar_offset_x/y to [unit_type] https://github.com/wesnoth/wesnoth/commit/ff31a99aa2cd49219a58ff3b4963ae6e156cd3e0
20180317 18:47:57< gfgtdf> my commit ?
20180317 18:48:22< zookeeper> i can't fix this dumb scenario code right now, so you can only win by waiting for the lava, not by killing all the elves.
20180317 18:48:33< vultraz> gfgtdf: please document it
20180317 18:48:39< vultraz> in changelog
20180317 18:48:44< vultraz> and yes
20180317 18:48:45< gfgtdf> what, which scenario do you mean ?
20180317 18:49:01< zookeeper> the only one i've mentioned
20180317 18:49:02< vultraz> though i might get lucky
20180317 18:50:15< gfgtdf> vultraz: as said in the commitmessage we might want to change it later for optimisation, basicially type_cfg["bar_offset_x"] shodul be moves to the type class shodul become type.get_bar_offset() or similar
20180317 18:50:38< vultraz> yes
20180317 18:50:43< vultraz> but please add a changeloog entry
20180317 18:53:27< irker713> wesnoth: stevecotton wesnoth:master 29e3468b9140 / data/campaigns/Legend_of_Wesmere/scenarios/chapter4/14_Human_Alliance.cfg: LoW S14 Objectives, reinforcements, edit repetitive dialog (ok for string freeze https://github.com/wesnoth/wesnoth/commit/29e3468b91400678a99a8bd25136b0f2578da4e1
20180317 18:53:58< zookeeper> i don't think i have anything else to push. i'll even keep the quenoth warrior defense anim PR waiting for more stuff.
20180317 18:54:09< vultraz> what about those unit types?
20180317 18:54:12< vultraz> for jevyan and ravanal?
20180317 18:55:53< gfgtdf> changelog.md isthe new changelog file
20180317 18:55:54< gfgtdf> ?
20180317 18:55:59< JyrkiVesterinen> Yes.
20180317 18:57:00< zookeeper> vultraz, i'm not writing one up for ravanal right now, nor try to think of if/when jevyan should change between those two sprites. or whether the whole deal makes enough sense, since i still haven't figured it out.
20180317 18:57:18< vultraz> what makes enough sense?
20180317 18:57:30< vultraz> but ok, it can go in for 1.13.13/1.14.0
20180317 18:57:31< zookeeper> custom sprites for a character
20180317 18:57:44< zookeeper> yes, since there wouldn't be any string changes needed.
20180317 18:57:47< vultraz> IMO it makes perfect sense
20180317 18:59:26-!- hrubymar10 [~textual@ip-86-49-9-122.net.upcbroadband.cz] has quit [Quit: hrubymar10]
20180317 19:01:16< zookeeper> i'll probably also go offline until after the release so if there's something you really need me to look at, now would be a good time
20180317 19:01:28-!- vn971 [~vasya@94.158.103.15] has quit [Quit: Leaving.]
20180317 19:02:45< irker713> wesnoth: gfgtdf wesnoth:master 8acb78b60969 / changelog.md: Update changelog.md https://github.com/wesnoth/wesnoth/commit/8acb78b609694a74f8cf2b68e873a8aba9fe03df
20180317 19:03:07< vultraz> I was hoping you could fix that walls layering issue
20180317 19:03:08< gfgtdf> "Add side_name to unit proxy" this sounds wrong, it'S probably to side proxy.
20180317 19:03:38< zookeeper> vultraz, what, with the gate?
20180317 19:03:43< vultraz> yes
20180317 19:03:56< zookeeper> that's probably gonna be awkward, so it'd take more time than i have
20180317 19:05:02< vultraz> alight
20180317 19:05:03< vultraz> alright
20180317 19:05:29< irker713> wesnoth: gfgtdf wesnoth:master 214e46c895d2 / changelog.md: Update changelog.md https://github.com/wesnoth/wesnoth/commit/214e46c895d215f5c54363712c39ffa99e885566
20180317 19:10:11< irker713> wesnoth: Jyrki Vesterinen wesnoth:master 9609281711d3 / changelog.md: Remove outdated changelog entry https://github.com/wesnoth/wesnoth/commit/9609281711d33069fbe52a4a93bd50e1aa2a34ae
20180317 19:13:40< vultraz> it needs be mentioned you CAN now save them as JPGs
20180317 19:16:43< irker713> wesnoth: Jyrki Vesterinen wesnoth:master 107fed1dc714 / changelog.md: Add ability to save screenshots as JPEG to changelog https://github.com/wesnoth/wesnoth/commit/107fed1dc714372cb7f58fd4ef0192fc4a9f7e4e
20180317 19:16:50< JyrkiVesterinen> ^ Does that look good?
20180317 19:17:08< vultraz> sure.
20180317 19:44:06< celticminstrel> Still working on Lua stuff.
20180317 19:44:21< celticminstrel> gfgtdf: Can you comment on this for me? (One moment, let me push it.)
20180317 19:45:01< irker713> wesnoth: Celtic Minstrel wesnoth:lua_stuff 91265a3371b6 / data/lua/backwards-compatibility.lua: Deprecate wesnoth.set_music https://github.com/wesnoth/wesnoth/commit/91265a3371b60f24ff04071438dc85f85c76b801
20180317 19:45:03< irker713> wesnoth: Celtic Minstrel wesnoth:lua_stuff d68dba909205 / data/lua/core.lua: fixup array_access https://github.com/wesnoth/wesnoth/commit/d68dba909205b075ae22498cb62aa6c7ab5a3935
20180317 19:45:05< irker713> wesnoth: Celtic Minstrel wesnoth:lua_stuff e71b3c7fb75a / data/lua/helper.lua: fixup helper deprecations https://github.com/wesnoth/wesnoth/commit/e71b3c7fb75afd7ded1e670b89647730efe8b305
20180317 19:45:07< irker713> wesnoth: Celtic Minstrel wesnoth:lua_stuff 02339a738694 / data/ (core/_main.cfg lua/backwards-compatibility.lua): fixup set_music https://github.com/wesnoth/wesnoth/commit/02339a7386949dee51963bc6010c07c7a4f332e4
20180317 19:45:09< irker713> wesnoth: Celtic Minstrel wesnoth:lua_stuff 76da32741de8 / data/lua/helper.lua: Clear up redundancies in helper compatibility and deprecate the array functions https://github.com/wesnoth/wesnoth/commit/76da32741de808ee3f2266da61bc7610c49b27f3
20180317 19:45:11< irker713> wesnoth: Celtic Minstrel wesnoth:lua_stuff ff342a03b5cd / data/ (5 files in 3 dirs): fixup array_access https://github.com/wesnoth/wesnoth/commit/ff342a03b5cd4f9799aa46ed4f0d108f527b0659
20180317 19:45:13< irker713> wesnoth: Celtic Minstrel wesnoth:lua_stuff 4ab12cf8622d / data/lua/on_event.lua: Fix missing return in on_event() https://github.com/wesnoth/wesnoth/commit/4ab12cf8622de78972047959b6e76ca93bdeab7e
20180317 19:45:15< irker713> wesnoth: Celtic Minstrel wesnoth:lua_stuff 20a6e0c209b1 / data/lua/core.lua: Experimental new hook registration system based on on_event() https://github.com/wesnoth/wesnoth/commit/20a6e0c209b16cb3844cda7447855d803597c586
20180317 19:45:17< irker713> wesnoth: Celtic Minstrel wesnoth:lua_stuff 3fab85c20a17 / data/lua/core.lua: Add a couple more WML utility functions https://github.com/wesnoth/wesnoth/commit/3fab85c20a1788b251c208fd7dd20973233d6134
20180317 19:45:19< irker713> wesnoth: Celtic Minstrel wesnoth:lua_stuff 24d3ccada686 / data/lua/core.lua: Forgot the unregister function https://github.com/wesnoth/wesnoth/commit/24d3ccada686051c1d2d8d4bccf2bc40425a1bf3
20180317 19:45:19< celticminstrel> gfgtdf: This one: https://github.com/wesnoth/wesnoth/commit/20a6e0c209b16cb3844cda7447855d803597c586
20180317 19:45:21< irker713> wesnoth: Celtic Minstrel wesnoth:lua_stuff f173fd46caa4 / data/lua/core.lua: Hooks fixup https://github.com/wesnoth/wesnoth/commit/f173fd46caa467866ecd1803933c8d09b65931d7
20180317 19:46:33< gfgtdf> what is the usecase for it ?
20180317 19:46:46< celticminstrel> Basically same as on_event()
20180317 19:46:54< celticminstrel> But for the game_events things.
20180317 19:48:59< gfgtdf> 'ret' is unused it seems
20180317 19:49:30< celticminstrel> Yeah, getting an error because of that in on_save.
20180317 19:49:42< celticminstrel> Do any of the events return anything other than a config?
20180317 19:49:50< celticminstrel> I mean the game_events.on_xxx events.
20180317 19:50:01< gfgtdf> hmm not sure
20180317 19:50:47< celticminstrel> on_event, on_save, on_load, on_mouse_action are all documented and only on_save is said to return anything.
20180317 19:52:59< gfgtdf> i think that this code is not that helpful for on_load/on_save, you still have to 'search' your tags in the passed table. It be better to haev an interface like 'function register_persistent_tag(tagname, reader, writer)'
20180317 19:53:49< celticminstrel> Hmm, that's an idea.
20180317 19:55:27< celticminstrel> [Mar 17@2:42:37pm] Soliton: preferably in the same format of all other balancing changes.
20180317 19:55:28< celticminstrel> What's that format?
20180317 19:55:41< celticminstrel> I'll get to changelog entries soon™.
20180317 19:57:46< gfgtdf> celticminstrel: it would do something like this https://pastebin.com/0uSwBAvA . The only problem i see with that is that some people might want to use arrays instead of single tags (in particular thats what [item] does)
20180317 20:00:08< gfgtdf> we codul add a foruth parmater 'use array' register_persistent_tag(tagname, use_array, reader, writer)
20180317 20:03:05< celticminstrel> gfgtdf: I think actually your version (at least on load) wouldn't have any problems with arrays, as the reader would be called for each element.
20180317 20:03:22< celticminstrel> I guess it wouldn't work with arrays on save, though.
20180317 20:04:44-!- travis-ci [~travis-ci@ec2-54-163-86-203.compute-1.amazonaws.com] has joined #wesnoth-dev
20180317 20:04:45< travis-ci> wesnoth/wesnoth#16980 (master - 107fed1 : Jyrki Vesterinen): The build passed.
20180317 20:04:45< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/354805976
20180317 20:04:45-!- travis-ci [~travis-ci@ec2-54-163-86-203.compute-1.amazonaws.com] has left #wesnoth-dev []
20180317 20:06:09< gfgtdf> celticminstrel: yes i meanst the writer, one coudl try to write a function detect_array, but that wodul not work as a simple '{}' coudl be both an empty array of wml table and an empty wml table.
20180317 20:09:00< gfgtdf> technicially there is no need to support arrays as one coudl easily store an array of childtags in a singe wml table, but it woudl be nice if we coudl use it in the [item] implementation.
20180317 20:19:45< irker713> wesnoth: Celtic Minstrel wesnoth:lua_stuff 6830d8ac5215 / data/ (6 files in 3 dirs): Lua API: Some tweaks of the experimental wml module https://github.com/wesnoth/wesnoth/commit/6830d8ac52154faa3ffde72ba88d0a47ea90ba9b
20180317 20:19:47< irker713> wesnoth: Celtic Minstrel wesnoth:lua_stuff ae4800340618 / data/lua/helper.lua: Bump up a couple of deprecation levels at @vultraz's request https://github.com/wesnoth/wesnoth/commit/ae4800340618eec7beb572f7475deb672515759b
20180317 20:19:49< irker713> wesnoth: Celtic Minstrel wesnoth:lua_stuff 202f86d17593 / data/ (core/_main.cfg lua/backwards-compatibility.lua): Deprecate wesnoth.set_music https://github.com/wesnoth/wesnoth/commit/202f86d17593cbf58de8b49162f086082301fbc8
20180317 20:19:51< irker713> wesnoth: Celtic Minstrel wesnoth:lua_stuff d3713de8867f / data/lua/helper.lua: Clear up redundancies in helper compatibility and deprecate the array functions https://github.com/wesnoth/wesnoth/commit/d3713de8867f37792f4cecaef081939192b52b86
20180317 20:19:53< irker713> wesnoth: Celtic Minstrel wesnoth:lua_stuff 96c5a1c41e9b / data/lua/on_event.lua: Fix missing return in on_event() https://github.com/wesnoth/wesnoth/commit/96c5a1c41e9b934e370db6788765a2a7e9428361
20180317 20:19:55< irker713> wesnoth: Celtic Minstrel wesnoth:lua_stuff f83609ad3363 / data/lua/core.lua: Experimental new hook registration system based on on_event() https://github.com/wesnoth/wesnoth/commit/f83609ad33630c95f13c2539b01f67623a74e01c
20180317 20:19:57< irker713> wesnoth: Celtic Minstrel wesnoth:lua_stuff 21def91059c1 / data/lua/core.lua: Add a couple more WML utility functions https://github.com/wesnoth/wesnoth/commit/21def91059c1ba66e8f7e025f51b86d7c064be38
20180317 20:19:59< irker713> wesnoth: Celtic Minstrel wesnoth:lua_stuff ba8042426ddc / data/ai/micro_ais/mai-defs/animals.lua: Fix rabbits AI being broken by save-load https://github.com/wesnoth/wesnoth/commit/ba8042426ddca6848877dcfd542a85cee59b47e5
20180317 20:20:01< irker713> wesnoth: Celtic Minstrel wesnoth:lua_stuff ea410b182865 / data/lua/core.lua: Revert "Experimental new hook registration system based on on_event()" https://github.com/wesnoth/wesnoth/commit/ea410b182865af89126ec8f7b5031c6e878d6f47
20180317 20:20:03< irker713> wesnoth: Celtic Minstrel wesnoth:lua_stuff 1f2d131153c0 / data/lua/core.lua: Add a more convenient way of registering custom saved game data https://github.com/wesnoth/wesnoth/commit/1f2d131153c0aab710b208ac7cf2b8806ac7acef
20180317 20:20:06< celticminstrel> gfgtdf: How does that implementation look? ^
20180317 20:24:09< gfgtdf> iirrc on_load has to remove the configs that were read from the passed table. also you are not calling old_on_read/save
20180317 20:24:41< celticminstrel> The latter is intentional. There is now old_on_read/save at this point (unless one is registered in the C++?)
20180317 20:24:45< celticminstrel> ^no
20180317 20:25:19< gfgtdf> well there is this one
20180317 20:25:31< gfgtdf> and both claim to be the 'first' (don't call parent)
20180317 20:25:33< gfgtdf> https://github.com/wesnoth/wesnoth/blob/0103959c369d7a84a28c4d4140b529df69972dbd/data/lua/wml-tags.lua#L7
20180317 20:26:01< celticminstrel> Oh huh.
20180317 20:26:30< gfgtdf> you ncna replace that one, but then you prorbla y have to implement the warning thing in your implementation
20180317 20:26:32< celticminstrel> Well, I'll need to update that one then, because the one in core.lua is definitely the first one, because core.lua is loaded in the Lua kernel constructor.
20180317 20:26:50< celticminstrel> Or yeah I guess I could actually move that warning into my implementation.
20180317 20:28:38< celticminstrel> Oh but wait, this somehow doesn't quite make sense...
20180317 20:29:04< gfgtdf> it'd be nice if a umc author coudl simply write "function wesnoth.persistent_tags.mytag.write" but with your implementation this will probably give you an erro because mytag is nil
20180317 20:29:08< celticminstrel> Oh right, I guess it's traditional for overridden ones to call the previous handler at the end, I guess that does work out then.
20180317 20:29:16< celticminstrel> gfgtdf: Yeah I noticed, I'm trying to make that work.
20180317 20:29:38< gfgtdf> maybe add some 'create on demand' in __newindex of wesnoth.persistent_tags
20180317 20:29:47< celticminstrel> So basically I don't actually have to remove tags, I just need to warn about those that aren't registered.
20180317 20:30:06< celticminstrel> gfgtdf: Pretty sure I want __index not __newindex, but I guess I'll find out.
20180317 20:30:24< gfgtdf> right, __index it is
20180317 20:36:49-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180317 20:36:55-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20180317 20:40:18-!- octalot [~steve@91.141.0.65.wireless.dyn.drei.com] has joined #wesnoth-dev
20180317 20:40:19-!- travis-ci [~travis-ci@ec2-54-196-238-25.compute-1.amazonaws.com] has joined #wesnoth-dev
20180317 20:40:20< travis-ci> wesnoth/wesnoth#16981 (lua_stuff - f173fd4 : Celtic Minstrel): The build has errored.
20180317 20:40:20< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/354812559
20180317 20:40:20-!- travis-ci [~travis-ci@ec2-54-196-238-25.compute-1.amazonaws.com] has left #wesnoth-dev []
20180317 20:44:49< irker713> wesnoth: loonycyborg wesnoth:master f80b7c40f285 / po/wesnoth-sota/cs.po: Updated Czech translation https://github.com/wesnoth/wesnoth/commit/f80b7c40f285d92d6b0d9f72aa20a5efce497a1a
20180317 20:53:31-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has quit [Quit: .]
20180317 21:02:26< celticminstrel> Push coming as soon as I verify I didn't break items.
20180317 21:02:43< celticminstrel> BTW, items could be changed to use a location_set if I'm not mistaken. (Not gonna do that now, though.)
20180317 21:16:28< irker713> wesnoth: Celtic Minstrel wesnoth:master 23aac4f72faf / / (8 files in 7 dirs): Cleanup of fef953a48e258e5b07ff4559eeff5571103d58c1 https://github.com/wesnoth/wesnoth/commit/23aac4f72fafc8c8a0991a614255b9532b3615a1
20180317 21:16:30< irker713> wesnoth: Celtic Minstrel wesnoth:master 08ec9017b544 / data/ (6 files in 3 dirs): Lua API: Some tweaks of the experimental wml module https://github.com/wesnoth/wesnoth/commit/08ec9017b5442668645511d2a9b5fd2c84c6c4e5
20180317 21:16:32< irker713> wesnoth: Celtic Minstrel wesnoth:master 6e4d09d2a547 / data/lua/helper.lua: Bump up a couple of deprecation levels at @vultraz's request https://github.com/wesnoth/wesnoth/commit/6e4d09d2a547eb6622585024ebb8aa4e2a758ae6
20180317 21:16:34< irker713> wesnoth: Celtic Minstrel wesnoth:master 4b08a40181d9 / data/ (core/_main.cfg lua/backwards-compatibility.lua): Deprecate wesnoth.set_music https://github.com/wesnoth/wesnoth/commit/4b08a40181d913f2c3f035daaafa6ce1c4948dde
20180317 21:16:36< irker713> wesnoth: Celtic Minstrel wesnoth:master e77663502319 / data/lua/helper.lua: Clear up redundancies in helper compatibility and deprecate the array functions https://github.com/wesnoth/wesnoth/commit/e7766350231980cda8ce3734c6c093f6fb81fbf7
20180317 21:16:38< irker713> wesnoth: Celtic Minstrel wesnoth:master d4e08359dd1a / data/lua/on_event.lua: Fix missing return in on_event() https://github.com/wesnoth/wesnoth/commit/d4e08359dd1ad1db97619f7c01c661c287adab2f
20180317 21:16:40< irker713> wesnoth: Celtic Minstrel wesnoth:master 68d545c3be0a / data/lua/core.lua: Add a couple more WML utility functions https://github.com/wesnoth/wesnoth/commit/68d545c3be0a1556cadf31b7a444179cc142b035
20180317 21:16:42< irker713> wesnoth: Celtic Minstrel wesnoth:master ddcbb4cb5005 / data/lua/ (core.lua wml-tags.lua): Add a more convenient way of registering custom saved game data https://github.com/wesnoth/wesnoth/commit/ddcbb4cb50051ec46ca975a9aa56da638bebdc16
20180317 21:16:44< irker713> wesnoth: Celtic Minstrel wesnoth:master c266b355281b / data/ai/micro_ais/mai-defs/animals.lua: Fix rabbits AI being broken by save-load https://github.com/wesnoth/wesnoth/commit/c266b355281bdc26241767bf7c9f08f83291a9ef
20180317 21:16:46< irker713> wesnoth: Celtic Minstrel wesnoth:master 9d81146919bd / changelog.md: Update changelog https://github.com/wesnoth/wesnoth/commit/9d81146919bd193b3970b7c0e65419fb925b5c35
20180317 21:16:48< irker713> wesnoth: Celtic Minstrel wesnoth:master a314876bf2e4 / data/lua/wml/ (items.lua object.lua objectives.lua): Use new persistent tags interface for [object] [objectives] [item] https://github.com/wesnoth/wesnoth/commit/a314876bf2e41d3c387e74077399e2522ea21070
20180317 21:19:01< gfgtdf> that return in on_event looks wrong
20180317 21:19:16< celticminstrel> Hmm.
20180317 21:19:43< gfgtdf> on_event("recruit,recall") shodul add a handler for both reruit and recall, with that returns it stops after the first match
20180317 21:20:13< celticminstrel> Oh whoops I put it in the wrong place. Lines 23 and 24 should be swapped.
20180317 21:21:25< irker713> wesnoth: Celtic Minstrel wesnoth:master 8d74b7203111 / data/lua/on_event.lua: fixup! Fix missing return in on_event() https://github.com/wesnoth/wesnoth/commit/8d74b72031118c09ec20c203b590c763e4e0d3d6
20180317 21:38:06-!- travis-ci [~travis-ci@ec2-54-163-86-203.compute-1.amazonaws.com] has joined #wesnoth-dev
20180317 21:38:07< travis-ci> wesnoth/wesnoth#16982 (lua_stuff - 1f2d131 : Celtic Minstrel): The build has errored.
20180317 21:38:07< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/354821702
20180317 21:38:07-!- travis-ci [~travis-ci@ec2-54-163-86-203.compute-1.amazonaws.com] has left #wesnoth-dev []
20180317 21:38:47< gfgtdf> celticminstrel: when the the inislisation code for the animals ai now run ?
20180317 21:38:57< gfgtdf> registering the synced commands i mean
20180317 21:40:43< gfgtdf> celticminstrel: it looks to me liek it is now _always_ run even if the ai is not used
20180317 21:41:16< celticminstrel> Uh, how so?
20180317 21:41:58< gfgtdf> celticminstrel: that would be bad since you can now always execute rabbit_spawn to create any units in mp games
20180317 21:42:11< celticminstrel> No I mean, what makes you think it's always registered?
20180317 21:42:48< gfgtdf> the code seems to be sopemhwo moved out of forest_animals and be exeucted at the top of that file
20180317 21:43:08< gfgtdf> ah wait, it's just the functiosn definitiosn that moved ther
20180317 21:43:14< gfgtdf> its fine then
20180317 21:43:21< celticminstrel> The commands are registered in register_rabbit_commands(), which is called in wesnoth.persistent_tags.micro_ai_rabbits.read adnd in wesnoth.micro_ais.forest_animals.
20180317 21:45:18< irker713> wesnoth/wesnoth:lua_stuff Celtic Minstrel 1f2d131153 Add a more convenient way of registering AppVeyor: vs2015/Release Failed
20180317 21:45:19< irker713> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-lua_stuff-1967
20180317 21:47:54< octalot> whoever's editing the changelog next: it should say "being", not "beeing"
20180317 21:48:11< celticminstrel> Oh, I guess I missed that.
20180317 21:48:25< celticminstrel> Though it wasn't in the entries I added, was it?
20180317 21:48:56< octalot> wasn't you :)
20180317 22:01:25-!- travis-ci [~travis-ci@ec2-54-90-67-32.compute-1.amazonaws.com] has joined #wesnoth-dev
20180317 22:01:26< travis-ci> wesnoth/wesnoth#16985 (master - 8d74b72 : Celtic Minstrel): The build passed.
20180317 22:01:26< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/354837809
20180317 22:01:26-!- travis-ci [~travis-ci@ec2-54-90-67-32.compute-1.amazonaws.com] has left #wesnoth-dev []
20180317 22:11:43< irker713> wesnoth: Celtic Minstrel wesnoth:master 709ecedad7cd / src/scripting/lua_gui2.cpp: Lua show_menu: allow specifying markup but not initial selection https://github.com/wesnoth/wesnoth/commit/709ecedad7cd772417ed0707cef4549e881efa24
20180317 22:11:47< Soliton> celticminstrel: basically in-/decreased unit type's stat X from A to B
20180317 22:12:18< celticminstrel> I couldn't find anything in the changelog talking about unit type stats...
20180317 22:12:21< Soliton> and that should go into the player's changelog as well, of course.
20180317 22:12:31< celticminstrel> I was wondering about that, yeah.
20180317 22:13:01< Soliton> well, there's not many balancing changes anymore. most changes are quite a while back.
20180317 22:13:13< celticminstrel> Well, I searched pretty much the entire changelog though?
20180317 22:13:33< celticminstrel> Maybe I used the wrong search terms.
20180317 22:14:18< Soliton> balancing would be a reasonable search term.
20180317 22:32:04< irker713> wesnoth: Celtic Minstrel wesnoth:master 15c32923b79d / changelog.md players_changelog.md: Expand on dunefolk balancing changes in greater detail and mirror to players_cha https://github.com/wesnoth/wesnoth/commit/15c32923b79d5788d77cc5a4973dcda3b5aa48ff
20180317 22:32:14< celticminstrel> Soliton: How's that? Pretty sure it's accurate.
20180317 22:32:35< celticminstrel> Though writing that made be question the blade resist change.
20180317 22:32:38< celticminstrel> ^made me
20180317 22:32:58< celticminstrel> I wonder if it should be reverted? It doesn't seem to fit the intent of avoiding RIPLIB.
20180317 22:34:11< Soliton> well, why was it done?
20180317 22:34:30< Soliton> the format looks good, yes. thank you.
20180317 22:34:32< celticminstrel> It's possible I got confused when ironing out the RIPLIB fixes.
20180317 22:34:56< celticminstrel> Maybe I thought the Marauder was the lower-level unit for a moment, I dunno.
20180317 22:35:21< celticminstrel> But basically all the changes to Marauder and Raider were intended to avoid RIPLIB violations.
20180317 22:35:28< celticminstrel> That was the intent behind those changes, at least.
20180317 22:36:31< Soliton> fixing riplib violations sounds good. it seemed like that was an oversight anyway.
20180317 22:37:06< celticminstrel> Right, but when I looked at the change just now, it seemed like the old value of the blade resistance didn't actually violate RIPLIB after all.
20180317 22:38:27< Soliton> well, if it was done unintentionally or for the wrong reasons it's probably best to revert that part.
20180317 22:38:33< celticminstrel> Okay.
20180317 22:38:58< Soliton> i'm not too familiar with the dunefolk and that's a level 3 anyway so...
20180317 22:42:16< celticminstrel> Okay, previously it went from 10% to 30%, now it goes from 10% to 20%; so there is still an increase, at least.
20180317 22:42:51< celticminstrel> And the Marauder is very much visibly armoured whereas the Raider isn't.
20180317 22:43:00< Soliton> yeah, just looked. so maybe the question is rather why the raider goes down to 10%.
20180317 22:43:50< celticminstrel> Well, if you mean from L1, the raider isn't the RIPLIB-satifying level-up.
20180317 22:44:05< celticminstrel> RIPLIB means at least one upgrade must not be worse in any way.
20180317 22:44:23< celticminstrel> So a decrease there is technically allowed, though maybe still a bit weird.
20180317 22:44:24< Soliton> sure, still seems weird. especially if the l3 then goes up to 30%.
20180317 22:44:43< celticminstrel> The raider also levels up from two different L1s which complicates this a bit.
20180317 22:45:12< celticminstrel> One with no blade resist, one with 20%.
20180317 22:45:36< irker713> wesnoth/wesnoth:lua_stuff Celtic Minstrel a5fa553921 fixup comment/deprecation references AppVeyor: 1/2 builds failed
20180317 22:45:37< irker713> Details vs2017/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-lua_stuff-1655
20180317 22:45:55< Soliton> rider has 10%.
20180317 22:48:13< Soliton> human horseman has 20% without being armored so i think 20% would fit well with the raider.
20180317 22:48:41< Soliton> so perhaps rather raise its blade resistance as well.
20180317 22:48:47< celticminstrel> Okay, sure.
20180317 22:52:35< irker713> wesnoth: Celtic Minstrel wesnoth:master 7fcc813438ed / / (4 files in 2 dirs): One more dunefolk tweak https://github.com/wesnoth/wesnoth/commit/7fcc813438edd2a50338869037ad346dee05c1a1
20180317 22:54:42< celticminstrel> Someone should probably test the auto-close version of wesnoth.show_message_box...
20180317 23:20:28< Soliton> gfgtdf: any plans to fix the debug notification message?
20180317 23:20:54< Soliton> or rather turn it into something that you cannot miss.
20180317 23:22:28-!- vultraz [uid24821@wesnoth/developer/vultraz] has quit [Quit: Connection closed for inactivity]
20180317 23:22:52< Soliton> i'm still not sure what the use case of synced debug commands is.
20180317 23:28:58< gfgtdf> Soliton: probably debugging mp scenarios, 
20180317 23:29:44< gfgtdf> Soliton: i currently have no plans for that
20180317 23:30:11< gfgtdf> Soliton: showing a dialogbox or disabling them on our official mp server are both options
20180317 23:30:18< gfgtdf> Soliton: the main problem is probably the string freeze
20180317 23:30:57< Soliton> there is no problem with the string freeze to fix something so you can release 1.14.
20180317 23:32:10< Soliton> so when we disable those command on the official mp server would they work like before, unsynced?
20180317 23:32:38< Soliton> to me it seems like if you want to debug something an unsynced command would be more helpful.
20180317 23:34:35< gfgtdf> Soliton: not sure, they'd give you 'ignoring illegal command ...' server messages the same as othre illegal commands
20180317 23:35:14< gfgtdf> Soliton: i think both can be useful, alsi it's not completey impossible to do unsynced stuf, for example the lua console is still unsynced.
20180317 23:35:16< Soliton> i'm wondering about how the clients would react. i know what the server does.
20180317 23:35:46< gfgtdf> Soliton: they'd print that message in the chat area.
20180317 23:36:24< gfgtdf> what they do exactly might depend on the command
20180317 23:36:44< gfgtdf> for example :unit will probably require a random number for the units traits
20180317 23:37:32< gfgtdf> which it will demand from the server
20180317 23:37:39< Soliton> well, that request will not be blocked now will it?
20180317 23:38:28< gfgtdf> the random request? no it won't but it will prtobably casue OOS for all other players who will then get an unexpected random number response.
20180317 23:39:12< Soliton> so just like before, no?
20180317 23:39:30< Soliton> or was it a local random number before?
20180317 23:39:54< gfgtdf> it was a local random number before.
20180317 23:40:34< Soliton> well, no more debugging oos, i guess.
20180317 23:40:50< Soliton> unless you know however you do that with lua.
20180317 23:41:14< gfgtdf> vultraz: do we have a dialog with a chatbox (iknow & dontaskmeagain)  ?
20180317 23:41:37-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20180317 23:41:47-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20180317 23:45:36< irker713> wesnoth/wesnoth:lua_stuff Celtic Minstrel 1f2d131153 Add a more convenient way of registering AppVeyor: 3/6 builds failed
20180317 23:45:37< irker713> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-lua_stuff-1967
20180317 23:45:38< irker713> Details vs2017/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-lua_stuff-1671
20180317 23:45:39< irker713> Details vs2013/Release: https://ci.appveyor.com/project/wesnoth/wesnoth/build/Wesnoth-VS2013-lua_stuff-1981
20180317 23:49:55< irker713> wesnoth: Gregory A Lundberg wesnoth:master ef436639ae1f / src/scripting/game_lua_kernel.cpp: Fix missing static keyword https://github.com/wesnoth/wesnoth/commit/ef436639ae1f6e5210b7348abb54cff8c38219e6
--- Log closed Sun Mar 18 00:00:40 2018