--- Log opened Sun Mar 18 00:00:40 2018
20180318 00:05:34-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 260 seconds]
20180318 00:23:58-!- gfgtdf [~chatzilla@x4e36820d.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.93 [Firefox 52.7.2/20180315163333]]
20180318 00:37:37-!- Bonobo [~Bonobo@203.63.93.247] has joined #wesnoth-dev
20180318 00:49:49-!- octalot [~steve@91.141.0.65.wireless.dyn.drei.com] has quit [Read error: Connection reset by peer]
20180318 00:50:03-!- octalot [~steve@91.141.0.65.wireless.dyn.drei.com] has joined #wesnoth-dev
20180318 01:01:38-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20180318 01:01:47-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20180318 01:33:24-!- octalot [~steve@91.141.0.65.wireless.dyn.drei.com] has quit []
20180318 02:06:18< irker713> wesnoth: doofus-01 wesnoth:master f2cf0f1e5ae7 / data/campaigns/Under_the_Burning_Suns/ (4 files in 2 dirs): defense animation for Quenoth Warrior (will add Champion later) (#2595) https://github.com/wesnoth/wesnoth/commit/f2cf0f1e5ae765aa6db52c23bedf03623514db64
20180318 02:09:45-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 256 seconds]
20180318 02:18:49< irker713> wesnoth: loonycyborg wesnoth:master 12f522ada448 / po/wesnoth-sota/cs.po: Czech translation fixup https://github.com/wesnoth/wesnoth/commit/12f522ada44816ff53de572e4e5baad015581a5e
20180318 03:20:07< irker713> wesnoth/wesnoth:master Sofartin c549e308f4 Pre-release version bump AppVeyor: All builds passed
20180318 03:34:05-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180318 03:34:11-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20180318 04:25:45< celticminstrel> Huh, the tagging is nowhere in sight and it's already Sunday.
20180318 05:20:56< celticminstrel> Oh yeah, we should add wml.error() to replace helper.wml_error()...
20180318 05:21:15< celticminstrel> Also it should probably only be used from WML tag definitions.
20180318 05:29:40-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has joined #wesnoth-dev
20180318 05:32:32-!- vultraz [uid24821@wesnoth/developer/vultraz] has joined #wesnoth-dev
20180318 05:38:40< irker713> wesnoth: Celtic Minstrel wesnoth:master 5008c72a22c6 / data/lua/core.lua: Fixup wml.all_variables https://github.com/wesnoth/wesnoth/commit/5008c72a22c6bef5b3f33f395b528f066fdaadd7
20180318 05:47:08< vultraz> I'm late!
20180318 05:47:11< vultraz> bah!
20180318 05:47:13< celticminstrel> You're late!
20180318 05:47:43< vultraz> Soliton: I know what the solution to the debug message dilemma is: make the desktop notifications for everyone but the person who used them. Then they're guaranteed visible.
20180318 05:47:49< vultraz> them*
20180318 05:48:49< celticminstrel> So that would mean they no longer show up when playing a local MP game?
20180318 05:49:12< vultraz> kinda doesn'tmatter? Since it's local
20180318 05:49:27< vultraz> They would of course show up if hosting your own server
20180318 05:49:43< celticminstrel> Well that's the thing about them that annoys me, so if they don't show up in local MP games then I'm all for it.
20180318 05:49:58< JyrkiVesterinen> celticminstrel: You accidentally incremented minimum required version of Boost to 1.56.0 in https://github.com/wesnoth/wesnoth/commit/c3f64e59f063305fec0b92049433148c4a7d86fd
20180318 05:50:10< JyrkiVesterinen> That's when boost::optional::emplace() was introduced.
20180318 05:50:11< celticminstrel> Apparently...
20180318 05:50:35< celticminstrel> So what are we going to do about it? Bump the minimum or somehow implement that without emplace?
20180318 05:50:54< vultraz> when was 56 released?
20180318 05:50:54< JyrkiVesterinen> Up to you.
20180318 05:51:08< JyrkiVesterinen> August 7, 2014.
20180318 05:51:13< vultraz> sounds reasonable
20180318 05:51:22< celticminstrel> I imagine you could hack around it with something like opp_ctx.~optional(); new(&opp_ctx) optional(...)
20180318 05:51:32< celticminstrel> But that's super-ugly.
20180318 05:51:36< vultraz> just bump it
20180318 05:51:59< celticminstrel> That means editing the README, correct?
20180318 05:52:05< vultraz> INSTALL
20180318 05:52:10< vultraz> and cmakefiles
20180318 05:52:14< vultraz> and sconsscript
20180318 05:52:20< celticminstrel> Oh.
20180318 05:52:51< celticminstrel> Is this in the global CMakeLists and SConstruct or one of the subsidiary CMakeLists and SConscript?
20180318 05:52:58< vultraz> former iirc
20180318 05:53:44< vultraz> did you add dunefolk changws to the changelog
20180318 05:53:45< vultraz> ?
20180318 05:55:05< celticminstrel> Yup.
20180318 05:59:43< irker713> wesnoth: Celtic Minstrel wesnoth:master c82c1ff9059a / CMakeLists.txt INSTALL.md SConstruct: Bump min Boost version to 1.56.0 https://github.com/wesnoth/wesnoth/commit/c82c1ff9059aa19adda6a527f41595a18b8c0a1f
20180318 06:00:47< vultraz> :(
20180318 06:00:52< vultraz> *rebases again*
20180318 06:00:55< celticminstrel> XD
20180318 06:01:16< celticminstrel> ...I shouldn't laugh too much, you've done the same to me too. >_>
20180318 06:01:42< vultraz> :P
20180318 06:01:46< irker713> wesnoth: Charles Dang wesnoth:master a18522acb816 / data/gui/window/file_dialog.cfg: File Dialog: removed label keys with empty values https://github.com/wesnoth/wesnoth/commit/a18522acb8169abe4ed852ac29eab0ccf0de31c6
20180318 06:01:49< irker713> wesnoth: Charles Dang wesnoth:master f5effa03f399 / src/tooltips.cpp: Tooltips: increased bg opacity to match GUI2 ones https://github.com/wesnoth/wesnoth/commit/f5effa03f39995a6d627c6792b9e345be8c0eb3a
20180318 06:01:52< irker713> wesnoth: Charles Dang wesnoth:master a43623ff2d2b / / (2 files in 2 dirs): Screenshot Notification: cleaned up and tweaked a few things https://github.com/wesnoth/wesnoth/commit/a43623ff2d2b341dd3290039d38a3bb9c1dff151
20180318 06:02:15< vultraz> is everything in?
20180318 06:02:43< celticminstrel> Everything I know of, unless doofus thinks the sun shyde is ready.
20180318 06:02:50< celticminstrel> But I think it's still marked WIP.+
20180318 06:02:50< vultraz> That can go in 1.13.13
20180318 06:02:54< celticminstrel> So yeah.
20180318 06:04:25< vultraz> "* Fixed no leader having no effect"
20180318 06:04:27< vultraz> what does this mean?
20180318 06:04:33< vultraz> no_leader?
20180318 06:04:45< celticminstrel> Something in the changelog?
20180318 06:04:54< celticminstrel> Ask gfgtdf I guess.
20180318 06:04:59< celticminstrel> But he's not around so...
20180318 06:05:12< celticminstrel> You could also search the commit log for clues?
20180318 06:06:33< vultraz> getting nothing :(
20180318 06:07:45< JyrkiVesterinen> https://github.com/wesnoth/wesnoth/pull/2606
20180318 06:07:47< TadCarlucci> the noleader thing was a bugfix for a side with noleader
20180318 06:08:17< vultraz> ah
20180318 06:11:17< vultraz> ... oh dear
20180318 06:11:54< vultraz> I just noticed there's a mismatch between the completion amounts reported on https://www.wesnoth.org/gettext/?version=master&package=alloff&order=trans and the stats generated with that script
20180318 06:12:42< vultraz> g.w.o, for example, notes French is 84.58% translated, while sinda's script flagged in 70% :/
20180318 06:13:40< irker713> wesnoth: Charles Dang wesnoth:master 3760b2a356cf / changelog.md: Few changelog fixups https://github.com/wesnoth/wesnoth/commit/3760b2a356cf7be75c53522240da55399a994165
20180318 06:14:44< JyrkiVesterinen> In that case we should disable blocking of incomplete translations.
20180318 06:15:09< JyrkiVesterinen> AFAIK, English knowledge in France is quite poor, and therefore the French translation is important.
20180318 06:15:54< vultraz> Yes. We'll have to look into this for the next release
20180318 06:18:56< celticminstrel> Starting positions tool is still broken in the map editor.
20180318 06:19:09< celticminstrel> To be more specific, it's not populated with the list of locations when you load a map.
20180318 06:19:25< irker713> wesnoth: Charles Dang wesnoth:master 5c86dc81be0c / changelog.md src/language.cpp: Temporarily re-enabled display of all languages, regardless of completeness https://github.com/wesnoth/wesnoth/commit/5c86dc81be0ce2139a60c82db6bc329d23a31134
20180318 06:19:27< celticminstrel> You can see pre-existing locations on the map but AFAIK cannot edit them.
20180318 06:19:39< vultraz> what do you mean?
20180318 06:20:16< irker713> wesnoth: Sofartin wesnoth:master f1865e0ed589 / projectfiles/Xcode/Info.plist: Pre-release version bump https://github.com/wesnoth/wesnoth/commit/f1865e0ed58912f9925c922ce51a4666f6ff8115
20180318 06:20:27< vultraz> (that's just for xcode)
20180318 06:20:30< celticminstrel> vultraz: When you have the location tool active, the palette is replaced by a list of all the locations.
20180318 06:20:35< vultraz> yes
20180318 06:20:40< celticminstrel> If you add a new custom location, it shows up there.
20180318 06:20:57< vultraz> oh
20180318 06:20:59< celticminstrel> But then if you reload the map, it's gone. The location is still there, and you can see it labelled on the map, but it's not listed in the palette.
20180318 06:21:02< vultraz> thats' not starting positions?
20180318 06:21:03< vultraz> that's*
20180318 06:21:12< celticminstrel> It's related to starting positions. Same tool.
20180318 06:21:18< vultraz> no?
20180318 06:21:21< celticminstrel> Yes?
20180318 06:21:24< vultraz> oh?
20180318 06:21:28< celticminstrel> The tool with the flag icon?
20180318 06:21:31< vultraz> oh
20180318 06:21:31< vultraz> huh
20180318 06:23:58< irker713> wesnoth: Charles Dang wesnoth:master 28d35f4d8c8d / Doxyfile changelog.md players_changelog.md src/wesconfig.h: Pre-release version bump for the rest of the things https://github.com/wesnoth/wesnoth/commit/28d35f4d8c8d12591b2f9d2a2c058d2da6c84c49
20180318 06:24:13< celticminstrel> I think it's likely the fix is pretty simple, though obviously not something to be done in the middle of a release.
20180318 06:24:30< vultraz> I don't think i Have anything else..
20180318 06:24:36< vultraz> anything else can go in after release
20180318 06:24:48< vultraz> would like a clean travis build thouhg
20180318 06:25:07< celticminstrel> Then I guess if it errors, restart it until it doesn't?
20180318 06:25:26< irker713> wesnoth: Iris Morelle wesnoth:master 0b3f14d63e29 / data/tools/wesnoth/campaignserver_client.py src/addon/validation.cpp: campaignd: Set port allocation for version 1.14 https://github.com/wesnoth/wesnoth/commit/0b3f14d63e29944d3d10a3fcc5335a165f7c08ef
20180318 06:25:29< celticminstrel> I guess you can just restart the errored build rather than the whole build set.
20180318 06:26:10< vultraz> Going to let that last commit run through
20180318 06:29:01< vultraz> then tag
20180318 06:29:03< vultraz> then branch
20180318 06:29:40< vultraz> not sure how one successfully pushes a branch without a commit on it, though
20180318 06:29:55< vultraz> oh, right
20180318 06:29:56< celticminstrel> There's no such thing as a branch without a commit on it.
20180318 06:30:06< celticminstrel> But wait, we branch in the RC cycle?
20180318 06:30:06< vultraz> the version bumps are different
20180318 06:30:20< vultraz> celticminstrel: i decided to branch with 1.13.12
20180318 06:30:33< vultraz> so master will henceforth become 1.15.0-dev
20180318 06:30:44< vultraz> and 1.14 will become 1.13.12+dev
20180318 06:30:46< celticminstrel> To me it makes the most sense to start the 1.14 branch with 1.14.0, but...
20180318 06:31:31< celticminstrel> I guess branching now means that henceforth we can push anything to master? :P Such as the new dunefolk description, and merging dunefolk into the default era?
20180318 06:31:47< vultraz> eh, not sure after all if we should do the last thing
20180318 06:31:48< vultraz> but yes
20180318 06:32:00< vultraz> the first thing we do is bump everything toc++14
20180318 06:32:06< celticminstrel> I think we should, because it in effect forces the issue.
20180318 06:32:22< celticminstrel> As long as it's a separate era, it can just be put off and put off and put off.
20180318 06:32:23< vultraz> drop the vs2013 av build, throw out everything global.hpp
20180318 06:32:34< vultraz> drop bind_void
20180318 06:32:51< vultraz> then  megre accelerated_rendering
20180318 06:33:23< celticminstrel> This gives off the impression that you're telling me to stop contributing.
20180318 06:33:33< vultraz> why?
20180318 06:33:44< celticminstrel> Because what am I supposed to use if not VS 2013?
20180318 06:33:53< vultraz> you said months ago that wouldn't be a problem
20180318 06:33:54< vultraz> :(
20180318 06:34:22< celticminstrel> Well, it's a problem. It's a solvable problem, mind you (or at least I'm pretty sure it is). But it is a problem.
20180318 06:34:33< vultraz> you could just install 2017 
20180318 06:34:36< celticminstrel> I did.
20180318 06:34:41< vultraz> well there you go!
20180318 06:34:41< celticminstrel> It decided to expire on me.
20180318 06:34:48< vultraz> ...um... 2017 is free?
20180318 06:34:50< celticminstrel> So I decided never to use it again.
20180318 06:34:55< celticminstrel> Yeah, that's what they want you to think.
20180318 06:34:57< JyrkiVesterinen> In any case, VS2013 is holding us back, and Wesnoth 1.16.0 definitely won't be buildable with it.
20180318 06:35:07< vultraz> at least the community edition
20180318 06:35:14< vultraz> if you got enterprise or something, I dunno
20180318 06:35:21< celticminstrel> What I had been considering doing was continuing to use VS2013 but building with clang instead of cl.
20180318 06:35:36< vultraz> I don't understand how it can "expire"
20180318 06:35:38< vultraz> :/
20180318 06:35:43< celticminstrel> vultraz: No, it's the community version that's the problem; I imagine enterprise wouldn't share the problem (though I can't be certain).
20180318 06:36:08< JyrkiVesterinen> AFAIK, Visual Studio requires being signed in with a Microsoft Account.
20180318 06:36:12< celticminstrel> ^
20180318 06:36:19< JyrkiVesterinen> Otherwise it will expire (even the Community Edition).
20180318 06:36:22< vultraz> ...you don't have a microsoft account?
20180318 06:36:31< celticminstrel> I do have one. That's entirely beside the point.
20180318 06:36:48< vultraz> so... log in with it?
20180318 06:36:52< celticminstrel> No.
20180318 06:37:27< celticminstrel> It's utterly unacceptable to require an Internet login to use a local application (except of course if the sole purpose of the application is to connect to an online service).
20180318 06:37:48< celticminstrel> So if it's going to do that, I won't use it.
20180318 06:37:54< vultraz> Look, you can't expect us to keep supporting 2013 just because you don't want to log in to 2017.
20180318 06:38:06< celticminstrel> I never said I expected that.
20180318 06:38:35< celticminstrel> I can think of two options, one of which is VS2013+clang like I already mentioned, the other of which is VSCode with the msvc2017 tools.
20180318 06:38:59< vultraz> FTR, I don't find it objectionable at all to require a login to use VS
20180318 06:39:01< celticminstrel> But the reason it's a problem is that it'll probably take me some time to get it set up.
20180318 06:39:08< celticminstrel> Well, that's your prerogative.
20180318 06:40:03< vultraz> which remidns me i should change my microsoft password
20180318 06:40:11< celticminstrel> (The login issue only affects the IDE, I can use the compiler and stuff no problem.)
20180318 06:40:11< vultraz> haven't changed it in several years...
20180318 06:40:12< vultraz> not good
20180318 06:40:37< celticminstrel> Well, it's up to you, but I don't think changing your password frequently matters that much if you use a good, memorable password.
20180318 06:40:51< vultraz> it's not that long either
20180318 06:40:52< vultraz> :P
20180318 06:41:06< vultraz> ie, not the 20 characters or something a Really Secure password would be
20180318 06:41:07< celticminstrel> Some of my passwords are even full sentences!
20180318 06:41:21< celticminstrel> ...most aren't, mind you, but still.
20180318 06:41:28< vultraz> sentences?
20180318 06:41:34< vultraz> that's... an interesting idea, actually
20180318 06:41:51< celticminstrel> Caused problems with Apple though.
20180318 06:42:37< celticminstrel> At the time I set it, Apple didn't allow spaces in passwords, but instead of telling you that, they just stripped them out, so basically setting the password to a spaceless version and thus making it impossible to log in with the spaces version. I have no idea if they ever fixed that.
20180318 06:43:09< irker713> wesnoth/wesnoth:master doofus-01 a896348adf sun-shyde standing animations, draft AppVeyor: All builds passed
20180318 06:45:02< celticminstrel> Ooh, someone had the interesting idea of giving the dunefolk healers a poison attack. I think I like this idea.
20180318 06:46:20< celticminstrel> Also they implied (probably unintentionally) that the scorpion should be liminal.
20180318 06:46:47< celticminstrel> Well, a desert scorpion at least; the core one might be more of a jungle scorpion.
20180318 06:47:48< vultraz> anyway
20180318 06:47:59< vultraz> no, I don't want you to stop contributing
20180318 06:48:02< vultraz> you do very good work
20180318 06:48:28< vultraz> and less altruistically, you're also one of the few devs remaining :P
20180318 06:48:35< celticminstrel> FTR I tried setting up vs2013+clang a few weeks back. IIRC it worked up to the link stage.
20180318 06:48:43< celticminstrel> That is, compilation was successful but it couldn't link.
20180318 06:49:01< celticminstrel> Oh yeah, another thing if we're merging accelerated_rendering...
20180318 06:49:14< celticminstrel> I still have that work on IPFs as shaders.
20180318 06:49:25< celticminstrel> Maybe I should get back to it and finish it.
20180318 06:49:32< vultraz> JyrkiVesterinen said we won't be doing that initially
20180318 06:49:40< vultraz> unless you already did it?
20180318 06:49:43< celticminstrel> Even so, it'll be happening at some point.
20180318 06:49:48< celticminstrel> Yeah, I have it working.
20180318 06:49:54< celticminstrel> But it doesn't support all the IPFs.
20180318 06:50:15< celticminstrel> Specifically, it doesn't support any of the IPFs that take an additional image as a parameter. I think it supports all of the other ones.
20180318 06:50:57< JyrkiVesterinen> Nice. I have nothing against IPF-to-shader conversion if someone else implements it. :P
20180318 06:51:11< celticminstrel> I got stuck on the image parameter part. :P
20180318 06:51:21< celticminstrel> But yeah, the rest works IIRC.
20180318 06:51:48< JyrkiVesterinen> And for passwords, I recommend using fully randomly generated passwords and storing them in a password manager.
20180318 06:51:54< JyrkiVesterinen> I use Password Safe: https://pwsafe.org/
20180318 06:52:18< celticminstrel> I have never used randomly-generated passwords and probably never will.
20180318 06:52:30< celticminstrel> As a result, I can remember about 60% of my passwords.
20180318 06:53:04< celticminstrel> And a lot of them are also quite strong to boot.
20180318 06:55:58< celticminstrel> ...
20180318 06:56:28< celticminstrel> I accidentally edited post instead of quoting it. :(
20180318 06:56:32< celticminstrel> ^a post
20180318 06:58:33< celticminstrel> Fortunately I was able to revert it thanks to the power of browser undo, though.
20180318 07:02:42< celticminstrel> Was starting the 1.14 branch now something that was discussed on Discord?
20180318 07:03:25< JyrkiVesterinen> Yes.
20180318 07:03:36< JyrkiVesterinen> In my opinion, it should even have been started earlier.
20180318 07:04:04< JyrkiVesterinen> IMO, RC1 is the absolute *ast* acceptable time to branch off the stable branch.
20180318 07:04:07< JyrkiVesterinen> *last
20180318 07:04:42< JyrkiVesterinen> Ideally it should be done at beta 1.
20180318 07:04:51< celticminstrel> Well, it seems a bit weird to me, but I don't exactly care that much either.
20180318 07:05:11< celticminstrel> So I'm not gonna complain about it.
20180318 07:06:25-!- travis-ci [~travis-ci@ec2-54-196-238-25.compute-1.amazonaws.com] has joined #wesnoth-dev
20180318 07:06:26< travis-ci> wesnoth/wesnoth#17001 (master - 0b3f14d : Iris Morelle): The build passed.
20180318 07:06:26< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/354925942
20180318 07:06:26-!- travis-ci [~travis-ci@ec2-54-196-238-25.compute-1.amazonaws.com] has left #wesnoth-dev []
20180318 07:09:00-!- celticminstrel is now known as celmin|sleep
20180318 07:16:16-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Read error: Connection reset by peer]
20180318 07:16:17-!- matthiaskrgr [matthiaskr@gateway/shell/panicbnc/x-cvmlqrtcqpunguhs] has quit [Ping timeout: 240 seconds]
20180318 07:16:18-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20180318 07:18:41-!- wedge010 is now known as wedge009
20180318 07:18:47-!- midzer [~quassel@p5B312805.dip0.t-ipconnect.de] has quit [Quit: No Ping reply in 180 seconds.]
20180318 07:19:14-!- midzer_ [~quassel@p5B312805.dip0.t-ipconnect.de] has joined #wesnoth-dev
20180318 07:19:14-!- matthiaskrgr [matthiaskr@gateway/shell/panicbnc/x-htzrtgjsghetfiug] has joined #wesnoth-dev
20180318 07:19:22-!- matthiaskrgr is now known as Guest95010
20180318 07:24:19< vultraz> yay!
20180318 07:26:16< shadowm> vultraz, Soliton: desltop notifications are not guaranteed to be visible or persist for long enough (especially if you've disabled them).
20180318 07:27:18< shadowm> Plasma 5.8 LTS in particular doesn't have a notification history.
20180318 07:51:55< irker713> wesnoth: Charles Dang wesnoth:master 0094a19e8550 / Doxyfile changelog.md players_changelog.md src/wesconfig.h: Post-release version bump https://github.com/wesnoth/wesnoth/commit/0094a19e8550f354e2fcdd80700a8a2cb74f0ed3
20180318 07:51:58< irker713> wesnoth: Vultraz wesnoth: 0b3f14d63e29 tagged as 1.13.12
20180318 07:52:42< irker713> wesnoth: Charles Dang wesnoth:1.14 22ec9d055a03 / Doxyfile changelog.md players_changelog.md src/wesconfig.h: Post-release version bump https://github.com/wesnoth/wesnoth/commit/22ec9d055a039f82dbbd60fc3561ce037a538712
20180318 07:58:57< irker713> wesnoth: Charles Dang wesnoth:1.14 ba68d52aa135 / players_changelog.md: Updated main changelog link to point to 1.14 branch https://github.com/wesnoth/wesnoth/commit/ba68d52aa135fff6d279e1486a70b6a1952fefa7
20180318 08:01:21-!- vultraz changed the topic of #wesnoth-dev to: 1.13.12 (1.14 RC1) tagged, announcing soon | Wesnoth Developers Channel | >>> Want to help? Go here: https://r.wesnoth.org/t42911 (and thanks!) <<< | Discord Server: https://discord.gg/battleforwesnoth | Logs: http://irclogs.wesnoth.org | Bug tracker: https://bugs.wesnoth.org
20180318 08:21:30-!- midzer_ is now known as midzer
20180318 08:56:56-!- travis-ci [~travis-ci@ec2-54-163-86-203.compute-1.amazonaws.com] has joined #wesnoth-dev
20180318 08:56:56< travis-ci> wesnoth/wesnoth#17003 (1.13.12 - 0b3f14d : Iris Morelle): The build passed.
20180318 08:56:57< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/354937196
20180318 08:56:57-!- travis-ci [~travis-ci@ec2-54-163-86-203.compute-1.amazonaws.com] has left #wesnoth-dev []
20180318 09:05:52-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20180318 09:26:13-!- travis-ci [~travis-ci@ec2-54-196-238-25.compute-1.amazonaws.com] has joined #wesnoth-dev
20180318 09:26:14< travis-ci> wesnoth/wesnoth#17004 (1.14 - 22ec9d0 : Charles Dang): The build passed.
20180318 09:26:14< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/354937290
20180318 09:26:14-!- travis-ci [~travis-ci@ec2-54-196-238-25.compute-1.amazonaws.com] has left #wesnoth-dev []
20180318 09:57:40< irker713> wesnoth: Jyrki Vesterinen wesnoth:master 3555b6278c21 / / (35 files in 3 dirs): Update Visual Studio project file to VS2015 toolset https://github.com/wesnoth/wesnoth/commit/3555b6278c2103391214e1da303d6c3e652387dc
20180318 10:03:22-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180318 10:03:32-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20180318 10:43:44-!- hrubymar10 [~textual@ip-86-49-9-122.net.upcbroadband.cz] has joined #wesnoth-dev
20180318 10:44:48-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20180318 10:49:37-!- mmmonkke [~xhsfjw@24-155-20-57.dyn.grandenetworks.net] has joined #wesnoth-dev
20180318 10:49:38-!- mmmonkke [~xhsfjw@24-155-20-57.dyn.grandenetworks.net] has quit [Client Quit]
20180318 10:50:35-!- TadCarlucci [~lundberg@74.193.219.119] has quit [Remote host closed the connection]
20180318 10:50:59-!- TadCarlucci [~lundberg@74.193.219.119] has joined #wesnoth-dev
20180318 11:01:21-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has quit [Quit: .]
20180318 11:02:44-!- hrubymar10 [~textual@ip-86-49-9-122.net.upcbroadband.cz] has quit [Quit: hrubymar10]
20180318 11:06:52-!- hrubymar10 [~textual@ip-86-49-9-122.net.upcbroadband.cz] has joined #wesnoth-dev
20180318 11:16:34-!- gfgtdf [~chatzilla@x4e36370b.dyn.telefonica.de] has joined #wesnoth-dev
20180318 11:19:34< gfgtdf> vultraz: if you want to require c++14, which i apprechiate, you might want to require even msvc 2017, this page https://en.cppreference.com/w/cpp/compiler_support suggested that some c++14 features, "Extended constexpr" are onyl available available on msvc2017
20180318 11:20:16< gfgtdf> vultraz: also you want to require GCC 5  or Clang 3.34
20180318 11:26:08-!- octalot [~steve@91.141.0.65.wireless.dyn.drei.com] has joined #wesnoth-dev
20180318 11:38:04-!- gfgtdf [~chatzilla@x4e36370b.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.93 [Firefox 52.7.2/20180315163333]]
20180318 12:32:39< irker713> wesnoth: ln-zookeeper wesnoth:master 3cea4790b872 / data/campaigns/Under_the_Burning_Suns/units/quenoth/Sun_Singer.cfg: UtBS: Corrected Sun Singer movetype from float to foot https://github.com/wesnoth/wesnoth/commit/3cea4790b872803063854e28bffa40999ae00258
20180318 12:33:10< zookeeper> well that was something i forgot to do earlier...
20180318 12:33:20< vultraz> zookeeper: 1.14 has diverged, please backport such changes to that branch
20180318 12:34:23< zookeeper> yeah, after i set up another clone for it...
20180318 12:34:37< vultraz> set up another clone?
20180318 12:34:38< vultraz> o-O
20180318 12:37:12< loonycyborg> I prefer git worktree
20180318 12:37:51-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has joined #wesnoth-dev
20180318 12:42:15< zookeeper> when i end to have hundreds of random uncommitted files lying around and dozens of uncommitted local changes and files open in notepad++, i don't want to be switching branches all the time as it's super annoying.
20180318 12:42:31< vultraz> o-O
20180318 12:43:08< JyrkiVesterinen> It would be better to stash those changes...
20180318 12:43:21< JyrkiVesterinen> https://git-scm.com/book/en/v1/Git-Tools-Stashing
20180318 12:43:55< loonycyborg> I have separate workdirs for master branch, for mingw crossbuild and for previous stable versions
20180318 12:44:19< vultraz> I have only 1 workdir for master
20180318 12:44:26< loonycyborg> separate workdir for stable branch is really nice
20180318 12:44:33< JyrkiVesterinen> I also use only one workdir.
20180318 12:44:44< loonycyborg> since you don't need to do full rebuild if you want to test something on stable
20180318 12:45:07< zookeeper> i don't trust stash for anything except "stash everything, pull, immediately apply stash back", and even that results in all the physical files changing which naturally makes notepad++ ask me for each one whether i want to reload it.
20180318 12:46:52< zookeeper> much nicer to have different clones for master and 1.14, at least after i manage to clean up some diskspace for that...
20180318 12:49:28< zookeeper> oh that was fast, just had to uninstall one game.
20180318 12:54:39< zookeeper> can i somehow create a new pristine clone from an existing one, if i'd prefer to not just copy the whole clone directory and then clean up all the local files i didn't actually want to copy?
20180318 12:55:02< vultraz> look into git new workdir
20180318 12:55:54< JyrkiVesterinen> zookeeper: git clone C:\original_repo new_repo
20180318 12:56:23< JyrkiVesterinen> When you pass a local path, git uses hard links by default instead of copying the files.
20180318 12:58:42< zookeeper> ah, thanks
20180318 13:05:28< zookeeper> JyrkiVesterinen, well, i did that but i can't switch branches on the new clone. or at least it can only see a couple of branches.
20180318 13:06:08< JyrkiVesterinen> Do "git fetch origin branch-name" in the new clone.
20180318 13:08:32< zookeeper> no change
20180318 13:09:32< JyrkiVesterinen> After the fetch, checking out the branch should succeed (even if "git branch" doesn't show it).
20180318 13:09:57-!- octalot [~steve@91.141.0.65.wireless.dyn.drei.com] has quit [Ping timeout: 240 seconds]
20180318 13:13:28< zookeeper> "Switched to a new branch '1.14'" well yeah but now it's apparently just some local branch and i can't even push because can't find remote ref bla bla.
20180318 13:13:38< zookeeper> s/push/pull
20180318 13:14:13< JyrkiVesterinen> Ah. I think I know what the problem is.
20180318 13:14:27< JyrkiVesterinen> You didn't fetch the 1.14 branch to your original clone first.
20180318 13:14:38< JyrkiVesterinen> Thus the second clone couldn't fetch it from first clone.
20180318 13:14:56< zookeeper> i did, but that didn't help the second clone to fetch it
20180318 13:15:21< JyrkiVesterinen> Maybe because it now has a branch of the same name?
20180318 13:15:28< zookeeper> nah, it was earlier
20180318 13:15:59< JyrkiVesterinen> Well, what exactly happened when you tried to fetch 1.14 from first clone?
20180318 13:16:02< zookeeper> although it was after i had copied the second clone
20180318 13:16:16< JyrkiVesterinen> Git should make it clear if the fetch fails.
20180318 13:16:53< zookeeper> the fetch didn't fail. it just doesn't change anything.
20180318 13:16:57< JyrkiVesterinen> $ git fetch origin jfhzkjfehz
20180318 13:16:57< JyrkiVesterinen> fatal: Couldn't find remote ref jfhzkjfehz
20180318 13:17:10< zookeeper> anyway, i'll redo the whole thing
20180318 13:21:07< zookeeper> nah, no luck. should have known, though.
20180318 13:22:08< zookeeper> i suppose the only branches the second clone sees are the ones the first clone has at some point been switched to.
20180318 13:22:39< JyrkiVesterinen> Ah, indeed.
20180318 13:23:18< JyrkiVesterinen> Fetching a branch from a remote just adds the information about it locally, but doesn't implicitly create a local branch of the same name.
20180318 13:23:37< JyrkiVesterinen> (Yet another example of Git's over-complex design.)
20180318 13:24:08< loonycyborg> It's not called "git" for nothing
20180318 13:24:35< zookeeper> oh, so if i "created" the 1.14 branch (after fetching) in the first clone (but without switching to it), then that would help the second clone see it?
20180318 13:24:50< loonycyborg> I think you should do something like "git checkout origin/somebranch -b somebranch"
20180318 13:25:16< loonycyborg> git branch doesn't see remote branches by default
20180318 13:25:21< loonycyborg> git branch -r does
20180318 13:26:14< zookeeper> yay, now it's okay
20180318 13:27:07< zookeeper> so, uh, if i pull on the second clone, surely it doesn't merely give me what i've already pulled into the first clone..?
20180318 13:28:01< zookeeper> well, i guess i'll find out in a minute...
20180318 13:28:25< irker713> wesnoth: Lari Nieminen wesnoth:1.14 b6702d616fdf / data/campaigns/Under_the_Burning_Suns/units/quenoth/Sun_Singer.cfg: UtBS: Corrected Sun Singer movetype from float to foot https://github.com/wesnoth/wesnoth/commit/b6702d616fdf709d83fb864d19fb557e24c014b3
20180318 13:29:25< zookeeper> yep, it won't pull that. fine, i'll just skip all these fancy solutions and just filecopy the whole clone directory instead...
20180318 13:30:22< vultraz> what's the problem?
20180318 13:32:02-!- octalot [~steve@91.141.2.105.wireless.dyn.drei.com] has joined #wesnoth-dev
20180318 13:34:00< Soliton> huh, didn't think RC1 was serious after that many changes.
20180318 13:40:05-!- Ivanovic [~ivanovic@p4FC53D61.dip0.t-ipconnect.de] has quit [Changing host]
20180318 13:40:05-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev
20180318 13:40:37< octalot> Will the 1.13 addons server become the 1.14 addons server, or will all existing 1.13 addons have to be uploaded again?
20180318 13:41:03< vultraz> latter
20180318 13:42:13< octalot> ok, will use the opportunity to give it more testing before the next upload :D
20180318 13:56:54< irker713> wesnoth: Charles Dang wesnoth:master 8120843b2ef6 / src/ (23 files in 7 dirs): Used constexpr and noexcept keywords directly https://github.com/wesnoth/wesnoth/commit/8120843b2ef6ff2348d76e962d40d8f4d83d9ca6
20180318 13:56:57< irker713> wesnoth: Charles Dang wesnoth:master 80c2d1a40511 / src/ (8 files in 4 dirs): Used std::put time everywhere https://github.com/wesnoth/wesnoth/commit/80c2d1a405111f4cd2f3cb7a50768e9ffdc8ee5b
20180318 13:57:00< irker713> wesnoth: Charles Dang wesnoth:master a57192db2844 / src/ (config.hpp config_attribute_value.hpp formatter.hpp global.hpp): Removed HAVE_REF_QUALIFERS, HAVE_INHERITING_CTORS, and USE_HETEROGENOUS_LOOKUPS https://github.com/wesnoth/wesnoth/commit/a57192db284452dc0a7ef8b83b256058e0a17219
20180318 13:57:03< irker713> wesnoth: Charles Dang wesnoth:master c1fcba17b753 / src/ (12 files in 6 dirs): Removed the type trait alias wrappers https://github.com/wesnoth/wesnoth/commit/c1fcba17b75362d1639361fdd4ade7b1a85c0575
20180318 13:57:06< irker713> wesnoth: Charles Dang wesnoth:master aa09dec0f397 / src/ (global.hpp utils/functional.hpp): Cleaned up one remaining use of HAVE_CXX14 and removed the macro altogether https://github.com/wesnoth/wesnoth/commit/aa09dec0f397d010f2cb13c8bf50d6f13d94705a
20180318 14:10:53-!- octalot [~steve@91.141.2.105.wireless.dyn.drei.com] has quit [Ping timeout: 240 seconds]
20180318 14:25:29-!- Guest95010 [matthiaskr@gateway/shell/panicbnc/x-htzrtgjsghetfiug] has quit [Changing host]
20180318 14:25:29-!- Guest95010 [matthiaskr@unaffiliated/matthiaskrgr] has joined #wesnoth-dev
20180318 14:25:29-!- Guest95010 [matthiaskr@unaffiliated/matthiaskrgr] has quit [Changing host]
20180318 14:25:29-!- Guest95010 [matthiaskr@gateway/shell/panicbnc/x-htzrtgjsghetfiug] has joined #wesnoth-dev
20180318 14:25:33-!- Guest95010 is now known as matthiaskrgr
20180318 14:37:58-!- travis-ci [~travis-ci@ec2-54-90-67-32.compute-1.amazonaws.com] has joined #wesnoth-dev
20180318 14:37:59< travis-ci> wesnoth/wesnoth#17009 (master - aa09dec : Charles Dang): The build was broken.
20180318 14:37:59< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/355007555
20180318 14:37:59-!- travis-ci [~travis-ci@ec2-54-90-67-32.compute-1.amazonaws.com] has left #wesnoth-dev []
20180318 14:38:27-!- Bonobo [~Bonobo@203.63.93.247] has quit [Ping timeout: 240 seconds]
20180318 14:38:51< vultraz> indeed
20180318 14:44:34< Soliton> loonycyborg: any chance to get the wesnothd multi index stuff documented some time?
20180318 14:46:06< irker713> wesnoth/wesnoth:1.13.12 Iris Morelle 0b3f14d63e campaignd: Set port allocation for versi AppVeyor: All builds passed
20180318 14:46:12< celmin|sleep> vultraz: Are you sure it was okay to remove USE_HETEROGENOUS_LOOKUPS? It's not C++17, and is supported in VS2015?
20180318 14:46:31< vultraz> it was under a c++14 check
20180318 14:46:37< celmin|sleep> Hmm, okay.
20180318 14:46:50< vultraz> please no one commit anything for about 20 mins
20180318 14:47:02< vultraz> a_r merge coming
20180318 14:47:20< celmin|sleep> :|
20180318 14:47:34< celmin|sleep> Someone please mute irker
20180318 14:47:38< celmin|sleep> Soliton can, right?
20180318 14:47:52< Soliton> anyone with a dev cloak can.
20180318 14:48:01< loonycyborg> Soliton: hmm yes. I still remember about it
20180318 14:48:10< loonycyborg> you got any particular question?
20180318 14:48:15< celmin|sleep> I don't have a dev cloak which is why I'm asking someone.
20180318 14:48:29< irker713> wesnoth: Jyrki Vesterinen wesnoth:master 750d558cd9c7 / src/hotkey/command_executor.cpp: Fix #2681: minimap buttons don't do anything https://github.com/wesnoth/wesnoth/commit/750d558cd9c771a7d2dae528f8e25a2b5d534fc6
20180318 14:48:33< celmin|sleep> I'm surprised there was an alias for enable_if? C++1 already had that.
20180318 14:48:42< irker713> wesnoth: Jyrki Vesterinen wesnoth:1.14 5fa0581bc08e / changelog.md players_changelog.md src/hotkey/command_executor.cpp: Fix #2681: minimap buttons don't do anything https://github.com/wesnoth/wesnoth/commit/5fa0581bc08ec3e5d3f8b1992bf981a64b5e1ca0
20180318 14:49:06< vultraz> :(
20180318 14:49:22< vultraz> oh well. merge commit it is
20180318 14:49:28< celmin|sleep> Although it's enable_if_t, not sure what difference that makes,
20180318 14:49:38< celmin|sleep> vultraz: Yeah I think this is a place where a merge is advisable.
20180318 14:49:52< vultraz> well, i rebased a_r to master first
20180318 14:50:03< vultraz> fixed conflicts and stuff
20180318 14:50:07< vultraz> then merged a_r to master
20180318 14:50:12< vultraz> i guess that's not the preferred method
20180318 14:50:25< vultraz> one should merge to master and fix conflicts at the same time, i guess
20180318 14:50:50< celmin|sleep> Ohhh, I see, the _t means an implicit ::type.
20180318 14:52:48< vultraz> looks like i messed up the players_changelog header in 1.14
20180318 14:54:22-!- celmin|sleep is now known as celticminstrel
20180318 14:54:40< celticminstrel> Then fix it!
20180318 14:55:11< celticminstrel> Yay, the auto return type now works.
20180318 14:55:31< vultraz> can someone else fix it.
20180318 14:55:39< celticminstrel> 9_9
20180318 14:55:51< JyrkiVesterinen> Sure, I'll do it.
20180318 14:56:08< vultraz> or I could do a web commit
20180318 14:56:10< celticminstrel> Shall I open an issue for the location palette problem?
20180318 14:56:29< vultraz> there already is one assigned to you
20180318 14:56:30< vultraz> iirc
20180318 14:56:39< celticminstrel> XD
20180318 14:56:48 * celticminstrel checks
20180318 14:57:34< irker713> wesnoth: Jyrki Vesterinen wesnoth:1.14 0ab238ab76b8 / players_changelog.md: Fix heading in players_changelog.md https://github.com/wesnoth/wesnoth/commit/0ab238ab76b84712566e415551c2999acf2a4c1e
20180318 14:57:39< celticminstrel> I don't see one assigned to me.
20180318 14:59:37< celticminstrel> Ah, there is one though.
20180318 14:59:43< celticminstrel> https://github.com/wesnoth/wesnoth/issues/1023
20180318 14:59:50< celticminstrel> Just not assigned to me.
20180318 15:00:59< celticminstrel> It's actually assigned to you. :P 
20180318 15:01:03< celticminstrel> Also to gfgtdf.
20180318 15:02:50-!- travis-ci [~travis-ci@ec2-54-163-86-203.compute-1.amazonaws.com] has joined #wesnoth-dev
20180318 15:02:51< travis-ci> wesnoth/wesnoth#17010 (master - 750d558 : Jyrki Vesterinen): The build is still failing.
20180318 15:02:51< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/355020047
20180318 15:02:51-!- travis-ci [~travis-ci@ec2-54-163-86-203.compute-1.amazonaws.com] has left #wesnoth-dev []
20180318 15:04:57-!- Oebele [~quassel@143.177.58.202] has joined #wesnoth-dev
20180318 15:06:05< vultraz> oh :P
20180318 15:10:47< celticminstrel> Setting up a new git worktree for 1.14.
20180318 15:12:44< irker713> wesnoth: Celtic Minstrel wesnoth:master b27c4c651273 / .gitignore: Update gitignore for VC project file update https://github.com/wesnoth/wesnoth/commit/b27c4c651273a8eed8a029be7bfe374dff03b35e
20180318 15:15:21< Soliton> loonycyborg: ideally move the multi index map to server.hpp and at least document the invariants this is supposed to enforce.
20180318 15:16:44< irker713> wesnoth: Charles Dang wesnoth:master e558044855fb / src/sdl/window.cpp: SDL/Window: set render scaling method to linear https://github.com/wesnoth/wesnoth/commit/e558044855fb7aaecdf2b1dd9cac0264aac2dad5
20180318 15:16:46< irker713> wesnoth: Charles Dang wesnoth:master 1a24fd5872dc / src/video.cpp: Video: enabled accelerated rendering with texture target access https://github.com/wesnoth/wesnoth/commit/1a24fd5872dc27426f8d26e1f0a9a58c29ce04c8
20180318 15:16:50-!- mode/#wesnoth-dev [+q *!*@uruz.ai0867.net] by ChanServ
20180318 15:16:56< celticminstrel> No-one muted irker...
20180318 15:17:16< celticminstrel> Or I guess they did just now..
20180318 15:17:34< Soliton> nobody gave a proper heads-up earlier.
20180318 15:17:52< celticminstrel> vultraz: How did IPFs work in a_r? Or did they work?
20180318 15:17:59< vultraz> they do
20180318 15:18:03< vultraz> just using surfaces
20180318 15:18:10< celticminstrel> So same as before.
20180318 15:18:29< celticminstrel> IIRC you're also not actually using OpenGL yet, right?
20180318 15:18:32< vultraz> no
20180318 15:19:27< celticminstrel> Looks like the other bot in the other channel has finished notifying; but IIRC irker is slower...
20180318 15:20:26< vultraz> what other bot?
20180318 15:20:33< vultraz> you're not on discord
20180318 15:20:43< celticminstrel> I was wrong, it hadn't finished.
20180318 15:20:55< celticminstrel> Now it has, though.
20180318 15:22:37-!- mode/#wesnoth-dev [-q *!*@uruz.ai0867.net] by ChanServ
20180318 15:22:37< irker713> wesnoth: Charles Dang wesnoth:master 7f81fba11ac8 / src/display.cpp: Fixup build again https://github.com/wesnoth/wesnoth/commit/7f81fba11ac8f036ef8dc43c4e49450de961b462
20180318 15:22:40< irker713> wesnoth: Charles Dang wesnoth:master 61f653f91aed / .gitignore src/hotkey/command_executor.cpp: Merge branch 'master' of github.com:wesnoth/wesnoth https://github.com/wesnoth/wesnoth/commit/61f653f91aed0e5375412ba2992213f1910b1db4
20180318 15:22:43-!- mode/#wesnoth-dev [+q *!*@uruz.ai0867.net] by ChanServ
20180318 15:22:48< vultraz> hey, it was done!
20180318 15:22:59< vultraz> that was the last commit!
20180318 15:23:04< celticminstrel> Gaspitude!
20180318 15:23:06< Soliton> ah, indeed.
20180318 15:23:12-!- mode/#wesnoth-dev [-q *!*@uruz.ai0867.net] by ChanServ
20180318 15:24:11< Soliton> what's the idea to get people to fix 1.14 now that they can enjoy twice the work, btw?
20180318 15:25:06< JyrkiVesterinen> Commit the change, cherry-pick, and push.
20180318 15:25:18< JyrkiVesterinen> It doesn't get anywhere near doubling the workload.
20180318 15:25:26 * celticminstrel tests build in VS2103...
20180318 15:25:32< celticminstrel> 2013
20180318 15:25:39< loonycyborg> I've uploaded tarball and installer for 1.13.12
20180318 15:25:46< Soliton> with all the changes that have already been pushed i can only hope that is true.
20180318 15:25:50< celticminstrel> I mean I'm sure VS2103 will be great, but I'd need to dust off my time machine for that.
20180318 15:25:58< JyrkiVesterinen> celticminstrel: VS2013 + clang?
20180318 15:26:01< vultraz> almost 130 new commits on master already :P
20180318 15:26:02< celticminstrel> Yeah.
20180318 15:26:11< Soliton> the question remains either way though.
20180318 15:26:25< loonycyborg> there won't be any more 1.13 releases?
20180318 15:26:35< celticminstrel> I think there'll be a few?
20180318 15:26:57< celticminstrel> Well, depending on how stable 1.13.12 turns out to be, I guess.
20180318 15:27:00< loonycyborg> I mean won't master branch be 1.15?
20180318 15:27:03< vultraz> yes
20180318 15:27:08< vultraz> it's already 1.15.0-dev
20180318 15:27:12< loonycyborg> because 1.14 was already forked off
20180318 15:27:34< celticminstrel> Can we merge 1033 or does it need more work?
20180318 15:30:08< vultraz> i dunno if we want that
20180318 15:30:28< celticminstrel> Okay it's giving me a ton of preprocessor errors for some reason. :/
20180318 15:30:56< celticminstrel> You don't know if we want a virtual sandboxed filesystem for addons?
20180318 15:32:44< vultraz> there wre some security concerns
20180318 15:33:02< vultraz> anyway, gonna get some sleep
20180318 15:33:21< celticminstrel> Obviously there are security concerns, but the idea of the PR is to address them at the same time.
20180318 15:47:49-!- sigurdfd [sigurdfd@dynamic-acs-72-23-110-196.zoominternet.net] has joined #wesnoth-dev
20180318 16:06:46< irker713> wesnoth: Sofartin wesnoth:master 4764dcaf5e84 / projectfiles/Xcode/Wesnoth.xcodeproj/project.pbxproj: Fixed Xcode Project for new Wesnoth 1.15 https://github.com/wesnoth/wesnoth/commit/4764dcaf5e84d1bcf30d64d0cd6624d2d3c72bce
20180318 16:18:11-!- travis-ci [~travis-ci@ec2-54-90-67-32.compute-1.amazonaws.com] has joined #wesnoth-dev
20180318 16:18:12< travis-ci> wesnoth/wesnoth#17014 (master - 61f653f : Charles Dang): The build is still failing.
20180318 16:18:12< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/355027418
20180318 16:18:12-!- travis-ci [~travis-ci@ec2-54-90-67-32.compute-1.amazonaws.com] has left #wesnoth-dev []
20180318 16:29:25< irker713> wesnoth: Gregory A Lundberg wesnoth:master 2a17ecccfcbf / CMakeLists.txt SConstruct: Change SCons and CMake to C++14 https://github.com/wesnoth/wesnoth/commit/2a17ecccfcbf30f0d966db74c176cae87648c6d6
20180318 16:35:21< celticminstrel> ...I bet that's why the builds have been failing.
20180318 16:36:19< JyrkiVesterinen> One reason, but there is more.
20180318 16:36:21< JyrkiVesterinen> "I'm getting various other errors when I use C++14"
20180318 16:39:07< irker713> wesnoth/wesnoth:1.14 Charles Dang ba68d52aa1 Updated main changelog link to point to  AppVeyor: All builds passed
20180318 16:40:11< vultraz> Keep in mind the game is not fully playable with a_r merged. The tests were crashing, and currently you can’t enter the editor without crashing. Half of the in-game theme items don’t appear either.
20180318 16:45:48< celticminstrel> Is GUI1 still present?
20180318 16:46:09< vultraz> Yes
20180318 16:46:19< vultraz> Lot of work to do
20180318 16:46:22< celticminstrel> Are we going to prioritize removing it?
20180318 16:46:30< vultraz> Yes.
20180318 16:46:45< celticminstrel> I have that branch with a possible GUI2 floating textbox, but it needs GUI2 game UI to work.
20180318 16:46:46< vultraz> I have a lot of stuff I need to throw out
20180318 16:47:06< celticminstrel> Unless the floating textbox is already GUI2?
20180318 16:47:07< vultraz> I already implemented a GUI 2 command console (well,a box)
20180318 16:47:13< celticminstrel> Hm, okay.
20180318 16:47:19< vultraz> It’s merged
20180318 16:47:21< celticminstrel> Does it look about the same?
20180318 16:47:27< vultraz> Yes
20180318 16:47:28< celticminstrel> And have the checkbox?
20180318 16:47:30< vultraz> Does that matter?
20180318 16:47:35< celticminstrel> It does, yes.
20180318 16:47:36< vultraz> No it doesn’t have a checkbox yet
20180318 16:47:45< vultraz> But it doesn’t matter if it looks different
20180318 16:48:14< celticminstrel> But the checkbox middling priority, I guess? Because you can probably choose whether to team or global chat at the moment you open the chatbox.
20180318 16:48:20< celticminstrel> ^checkbox is
20180318 16:48:29< vultraz> I’ll get to it
20180318 16:48:35< vultraz> Right now the game crashes if you use it
20180318 16:48:41< vultraz> The new command box
20180318 16:48:43< celticminstrel> That's... quite bad. :P
20180318 16:48:45< vultraz> It didn’t before ftr
20180318 16:48:53< celticminstrel> Oh.
20180318 16:48:55< vultraz> Lot of new crashes cropped up since last August
20180318 16:49:39< vultraz> I’ll get around to fixing
20180318 16:50:30< celticminstrel> I guess maybe I'll back away for a week or two (apart from continuing the schema work on the 1.14 branch).
20180318 16:51:42< vultraz> Probably best
20180318 16:52:02< vultraz> I think at this point I’m just going to remove a whole bunch of stuff and then we can rework it from the ground up
20180318 16:52:33< celticminstrel> My suggestion is to open an issue for each thing that's removed and needs to be reimplemented.
20180318 16:52:44< celticminstrel> You can probably merge the GUI2 help if you're planning to just remove GUI1 stuff.
20180318 16:52:53< celticminstrel> It's not at feature-parity with GUI1, but it is functional.
20180318 16:53:41< celticminstrel> It even handles the old help markup abotu 90% IIRC.
20180318 16:53:44< celticminstrel> ^about
20180318 16:54:01< vultraz> Hm, yes
20180318 16:54:18< vultraz> Might just do both of those
20180318 16:54:26< irker713> wesnoth: pentarctagon wesnoth:master 503e921d2ffa / .travis.yml: Set travis use c++14. https://github.com/wesnoth/wesnoth/commit/503e921d2ffa0ed3991e037dfa38de7dfe926277
20180318 16:54:31< celticminstrel> I think the PR is a little misleading actually?
20180318 16:55:06< celticminstrel> It says all but two things work, but jump and IIRC ref are not implemented.
20180318 16:55:13< celticminstrel> (Those are tab-stops and links, respectively.)
20180318 16:56:00< celticminstrel> Jump is just replaced with a literal tab, so the tables aren't going to be aligned anymore.
20180318 16:56:12-!- travis-ci [~travis-ci@ec2-54-196-238-25.compute-1.amazonaws.com] has joined #wesnoth-dev
20180318 16:56:13< travis-ci> wesnoth/wesnoth#17016 (master - 4764dca : Sofartin): The build failed.
20180318 16:56:13< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/355041629
20180318 16:56:13-!- travis-ci [~travis-ci@ec2-54-196-238-25.compute-1.amazonaws.com] has left #wesnoth-dev []
20180318 16:56:32< celticminstrel> I think there were two forms of jump actually, one was the tab stop ref and one was jumping to the tab stop.
20180318 16:59:44-!- octalot [~steve@91.141.2.105.wireless.dyn.drei.com] has joined #wesnoth-dev
20180318 17:00:20< celticminstrel> Besides schema stuff, this gives me a good excuse to work on my addon instead. :P
20180318 17:07:21< celticminstrel> I thought I'd opened an issue for the rich text widget, but I guess not.
20180318 17:07:32< celticminstrel> Maybe what I was remembering was adding it to (NotSo)EasyCoding.
20180318 17:08:06< irker713> wesnoth: Gregory A Lundberg wesnoth:master 5b371161a7ed / src/display.hpp: Add missing override specifier. https://github.com/wesnoth/wesnoth/commit/5b371161a7ed9273cd857ad78492636fd5b0a702
20180318 17:20:09-!- sigurdfd [sigurdfd@dynamic-acs-72-23-110-196.zoominternet.net] has quit []
20180318 17:25:23-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has quit [Quit: .]
20180318 17:26:01-!- TadCarlucci [~lundberg@74.193.219.119] has quit [Remote host closed the connection]
20180318 17:31:11-!- TadCarlucci [~lundberg@74.193.219.119] has joined #wesnoth-dev
20180318 17:32:27-!- TadCarlucci [~lundberg@74.193.219.119] has quit [Client Quit]
20180318 17:32:49-!- TadCarlucci [~lundberg@74.193.219.119] has joined #wesnoth-dev
20180318 17:34:11< celticminstrel> Oh yeah, does Wesnoth still use the 1.13 data folder or has it switched to the 1.14 data folder?
20180318 17:34:14< celticminstrel> Userdata, that is.
20180318 17:34:32< celticminstrel> For that matter, does 1.15 already use the 1.15 userdata folder?
20180318 17:34:50< celticminstrel> If it's based on the actual version number, I assume it all works as you'd expect already...
20180318 17:36:20< irker713> wesnoth/wesnoth:master Gregory A Lundberg 5b371161a7 Add missing override specifier. AppVeyor: vs2015/Release Failed
20180318 17:36:21< irker713> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-2008
20180318 17:38:08-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer]
20180318 17:39:46-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20180318 17:41:39< celticminstrel> vcpkg is pretty handy. I had errors because openssl/rand.h didn't exist and just installing openssl through vcpkg fixed it.
20180318 17:42:03< celticminstrel> So I guess it's already using the vcpkg libs rather than the external libs, where those exist.
20180318 17:42:23< celticminstrel> (I guess it's using external for glib and cairo and co since I don't have those installed in vcpkg AFAIK.)
20180318 17:42:50< celticminstrel> ...this also explains how I accidentally bumped up the minimum Boost requirement, I think.
20180318 17:47:41-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20180318 17:49:32-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20180318 17:54:32-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180318 17:54:38-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20180318 17:56:45-!- gfgtdf [~chatzilla@x4e36370b.dyn.telefonica.de] has joined #wesnoth-dev
20180318 17:57:40-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has joined #wesnoth-dev
20180318 17:58:00< gfgtdf> celticminstrel: i also had my msvc 2015 community version expireing, it was very annoying in particular since it worked flawless for about a year already, but after simply following the instructions the 'expired' window gave it just worked again.
20180318 17:58:54< celticminstrel> If those instructions involve "log into your Microsoft account", then they are unacceptable and I will not follow them.
20180318 18:00:10< celticminstrel> On the other hand if someone has a way for me to "fix" the expired VS2015 Community without logging into a Microsoft account, then I would consider it.
20180318 18:00:16< gfgtdf> i don't remember them but probably they do. But i'd think you also needed that when installing it for the first time? So why is doing it again a greater problem ?
20180318 18:00:32< celticminstrel> Uh, no? You don't need it to install.
20180318 18:00:41< celticminstrel> I know this because I did install it and didn't log in.
20180318 18:01:39< gfgtdf> hmm ok
20180318 18:04:17< TadCarlucci> What's the problem with a microsoft account? Create one, do what you need, then abandon it. If it needs a real email, create a random gmail and close it when you're done.
20180318 18:05:00< gfgtdf> ye i also made that microsoft account soley for that porpose.
20180318 18:05:34< gfgtdf> but i think creatign emails might not be that easy anmore? nowdays many email providers require ponoe verification or similar.
20180318 18:06:21< celticminstrel> I don't think Tad's solution would work.
20180318 18:06:35< celticminstrel> What do you do when the verifiction expires again in a year or whatever?
20180318 18:06:41< celticminstrel> ^verification
20180318 18:06:52< celticminstrel> ...verifiction sounds like an oxymoron. XD
20180318 18:08:08< gfgtdf> well if that really happens you probably need to log in again. your borswer probably still remembers your password.
20180318 18:08:15< gfgtdf> or create  new account
20180318 18:08:26< JyrkiVesterinen> In that case, keep the password for your Microsoft account that you only use for VS.
20180318 18:08:44< JyrkiVesterinen> You don't even need access for that email.
20180318 18:08:50< octalot> verifiction - proving that the false name you're using today matches the false name you used yesterday
20180318 18:09:10< JyrkiVesterinen> (So you can also use a temporary email address service such as 10minutemail.)
20180318 18:09:23< celticminstrel> gfgtdf: Which is why using a throwaway account doesn't work.
20180318 18:09:37< celticminstrel> But yeah, I'd rather just use VS2013 or VSCode.
20180318 18:10:21< celticminstrel> I'm not sure how much setup would be needed to compile Wesnoth from VSCode.
20180318 18:10:41< celticminstrel> If it can just invoke MSBuild on the VC14 project files, that would be best...
20180318 18:11:50< celticminstrel> I don't know how to solve the Boost.Preprocessor errors I'm getting on VS2013+clang. They actually don't make any sense. The only thing I can think of is maybe upgrading my clang; if that doesn't work I'll probably have to use VSCode (which is a bit annoying because its Intellisense seems to be quite a bit worse).
20180318 18:13:35< JyrkiVesterinen> Could it be some sort of ABI incompatibility?
20180318 18:14:27< celticminstrel> It didn't even get that far.
20180318 18:14:36< celticminstrel> These are compile errors.
20180318 18:14:57< celticminstrel> But I don't think there'd be an ABI incompatibility, as clang is set up to work with Microsoft's ABI.
20180318 18:16:35< JyrkiVesterinen> You know that VS2013 and VS2015 are even incompatible with each other...
20180318 18:19:44< irker713> wesnoth: Gregory A Lundberg wesnoth:master ab36c8bcc2fd / src/gui/core/event/handler.cpp: More missing override specifiers. https://github.com/wesnoth/wesnoth/commit/ab36c8bcc2fd23c760e83a506f26a72de263889d
20180318 18:19:46< irker713> wesnoth: Gregory A Lundberg wesnoth:master f97a617a2684 / src/ (display.hpp gui/widgets/window.hpp): Fix doccomments. https://github.com/wesnoth/wesnoth/commit/f97a617a2684c804c491cb7068874b9f448146a8
20180318 18:23:18< irker713> wesnoth/wesnoth:master Gregory A Lundberg f97a617a26 Fix doccomments. AppVeyor: vs2015/Release Failed
20180318 18:23:19< irker713> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-2009
20180318 18:32:51< celticminstrel> Upgrading to clang 6 did not help. Basically some of the Boost headers won't compile.
20180318 18:33:12< celticminstrel> I'm getting -Winvalid-token-paste for example.
20180318 18:33:27< celticminstrel> And too many arguments to macro.
20180318 18:33:35< celticminstrel> I suppose I could paste the errors.
20180318 18:33:37< celticminstrel> ^pastebin
20180318 18:36:20< irker713> wesnoth: Jyrki Vesterinen wesnoth:master 950d4f86e5c4 / .appveyor.vs2015.yml: Attempted fix for AppVeyor build failures on VS2015 https://github.com/wesnoth/wesnoth/commit/950d4f86e5c4878c9a73bf06bd70aa46c16d84f5
20180318 18:40:06< celticminstrel> Oh, it was using the wrong Boost headers. Now I'm getting errors in config about the map::find function.
20180318 18:40:23< celticminstrel> It says something about "can't convert from basic_string_ref to basic_string" if I understand this correctly.
20180318 18:41:56< gfgtdf> which boost version are you using ?
20180318 18:43:00< celticminstrel> I have 1.66 installed, but I think the issue was probably that it was using the aquleia/external headers instead of the 1.66 headers.
20180318 18:43:14< celticminstrel> Now I need to figure out the config error.
20180318 18:43:41< gfgtdf> the code shodul only use string_ref for boost <=1.61 https://github.com/wesnoth/wesnoth/blob/aa09dec0f397d010f2cb13c8bf50d6f13d94705a/src/config_attribute_value.hpp#L55
20180318 18:44:02< celticminstrel> And I'm using 1.66, so...
20180318 18:44:07< celticminstrel> Or, wait.
20180318 18:44:21< celticminstrel> Hmm.
20180318 18:45:00< gfgtdf> it it does not work with string_ref maybe we shodul rewuire boost 1.62?
20180318 18:47:18< gfgtdf> hmm shouldn't matter actually
20180318 18:47:51-!- midzer [~quassel@p5B312805.dip0.t-ipconnect.de] has quit [Quit: No Ping reply in 180 seconds.]
20180318 18:48:57-!- midzer [~quassel@p5B312805.dip0.t-ipconnect.de] has joined #wesnoth-dev
20180318 18:52:54< celticminstrel> (Turns out I wasn't using 1.66 after all; I have three different versions of Boost on my computer.)
20180318 18:53:59< gfgtdf> you should propbably delete at least one.
20180318 18:54:27< celticminstrel> The one that was being used intially was aquileia/external; then it switched to 1.58.
20180318 18:54:37< celticminstrel> (I have no idea what aquileia/external has.)
20180318 18:58:29< irker713> wesnoth/wesnoth:master Sofartin aaf2cd888f Updated changelog style AppVeyor: All builds passed
20180318 18:58:45< irker713> wesnoth: Gregory A Lundberg wesnoth:master c7416ae7d931 / src/minimap.hpp: Un-deprecate getMinimap https://github.com/wesnoth/wesnoth/commit/c7416ae7d931af647af2a05d15681f8c5b3d828c
20180318 18:58:47< irker713> wesnoth: Gregory A Lundberg wesnoth:master 54b3f51a248f / src/gui/core/canvas.cpp: Fix more doccomments https://github.com/wesnoth/wesnoth/commit/54b3f51a248f2eabd8af5ec2b6e6379707ee03fd
20180318 19:00:42< Soliton> is it expected that closing the wesnoth window immediately exits with no confirmation dialog?
20180318 19:01:04< gfgtdf> unless you ahve soemthing worth saveing (an ongoing game) then yes
20180318 19:01:10< celticminstrel> Yeah.
20180318 19:01:25< celticminstrel> Unless you're in a game or in the editor, or I guess in the lobby, it's expected.
20180318 19:01:31< Soliton> i was logged into multiplayer.
20180318 19:01:57< Soliton> pretty sure that's not how it used to be but i'd have to check.
20180318 19:02:31< gfgtdf> i don't think 1.12 had any confirmation message at all, even in games.
20180318 19:03:07< celticminstrel> I think there's supposed to be a confirmation message in that case.
20180318 19:03:14< celticminstrel> But 1.12 never had one, true.
20180318 19:04:09< Soliton> hmm, indeed no confirmation in 1.12 either.
20180318 19:04:30< celticminstrel> Which version are you seeing it on?
20180318 19:06:38< gfgtdf> ok now i see my last login on the mp server (unless someone else uses the nick 'b4')
20180318 19:07:11< Soliton> i just remember it used to be that way but probably longer ago then.
20180318 19:09:18< irker713> wesnoth: Gunter Labes wesnoth:l1.14 7ca7ed0e4f1b / src/server/server.cpp: Enable lobby message logging again https://github.com/wesnoth/wesnoth/commit/7ca7ed0e4f1bc3fe9aeaabc01a3a17ac4a89b8a8
20180318 19:10:19< Soliton> hrm, that did not go as planned.
20180318 19:10:37< gfgtdf> what ios that "l1.14" branch ?
20180318 19:10:39< gfgtdf> is*
20180318 19:10:51< Soliton> that's my local branch name.
20180318 19:11:05< gfgtdf> ok
20180318 19:11:19< gfgtdf> are you going to do a pull request ?
20180318 19:11:43< Soliton> that wasn't the idea, no.
20180318 19:12:25< gfgtdf> did you intend to push to wesnoth:1.14  ?
20180318 19:12:35< irker713> wesnoth: Gunter Labes wesnoth:1.14 7ca7ed0e4f1b / src/server/server.cpp: Enable lobby message logging again https://github.com/wesnoth/wesnoth/commit/7ca7ed0e4f1bc3fe9aeaabc01a3a17ac4a89b8a8
20180318 19:14:01< vultraz> please delete that l1.14 branch
20180318 19:14:15< Soliton> already done.
20180318 19:14:31< vultraz> sweet
20180318 19:16:41< irker713> wesnoth: Gunter Labes wesnoth:master b115be99e15d / src/server/server.cpp: Enable lobby message logging again https://github.com/wesnoth/wesnoth/commit/b115be99e15d01506cbff6a78d823a02dba63ac2
20180318 19:38:33< shadowm> Just disabled read-only mode on the 1.14 add-ons server.
20180318 19:39:34< gfgtdf> nice, let's upload addons
20180318 19:40:26< vultraz> *imperial march*
20180318 19:40:40< shadowm> What.
20180318 19:40:49< shadowm> How is that apropos music for the occasion, vultraz?
20180318 19:41:14< vultraz> well I imagine a horde of addons marching towards to the server
20180318 19:41:34< gfgtdf> i see no addons at http://add-ons.wesnoth.org/1.14 though
20180318 19:42:09< shadowm> Yeha I need to set that up.
20180318 19:42:16< shadowm> Also, the server is currently empty anyway.
20180318 19:42:56< gfgtdf> i just uploaded na addon
20180318 19:42:59< Soliton> gfgtdf already uploaded one add-on.
20180318 19:45:40< shadowm> ...
20180318 19:45:44< shadowm> You people are fast.
20180318 19:45:53< shadowm> I see Ageless_Era was uploaded as well.
20180318 19:46:00< vultraz> now you see why it's apropos :P
20180318 19:46:23< Ravana_> too fast though
20180318 19:46:33< Ravana_> I accidentally uploaded version compiled for 1.12 there
20180318 19:50:08-!- travis-ci [~travis-ci@ec2-54-91-126-162.compute-1.amazonaws.com] has joined #wesnoth-dev
20180318 19:50:09< travis-ci> wesnoth/wesnoth#17024 (master - 54b3f51 : Gregory A Lundberg): The build has errored.
20180318 19:50:09< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/355086350
20180318 19:50:09-!- travis-ci [~travis-ci@ec2-54-91-126-162.compute-1.amazonaws.com] has left #wesnoth-dev []
20180318 19:50:38< irker713> wesnoth: Iris Morelle wesmere:master a79cc1243763 / static/docroot/addons/index.xml: static: Add 1.14 add-ons index entry https://github.com/wesnoth/wesmere/commit/a79cc1243763d730565649d02ac11df980b78a54
20180318 19:52:04< shadowm> The index gen appears to be stalled on Ageless Era.
20180318 19:52:33< shadowm> Somehow.
20180318 19:53:02< shadowm> 100% CPU from wesnoth_addon_manager for the past few minutes.
20180318 19:53:55< shadowm> Is there a way to force it to spit its backtrace to console?
20180318 19:56:13< shadowm> Oh joy.
20180318 19:56:22< Soliton> ctrl+c? but that's also going to abort it. :-P
20180318 19:57:02< shadowm> So it did work after an absurd amount of time, but: https://pastebin.com/eJCtsAGj
20180318 19:57:26< shadowm> Oh wait, that's because there's no 1.14 clone yet.
20180318 19:57:55< Soliton> indeed i can take care of that if you like.
20180318 19:57:56< shadowm> Can you sort that out? I don't know if you use git-new-workdir or the official workdir thing that I've not had the time to read up on yet.
20180318 19:59:55< irker713> wesnoth: pentarctagon wesnoth:master 983045718aa1 / CMakeLists.txt utils/travis/docker_run.sh: Stop hard-coding cmake's -std version. https://github.com/wesnoth/wesnoth/commit/983045718aa13a2b7b1b45bb37baa76a88a1d47e
20180318 20:03:13< zookeeper> i hope someone remembers to change the userdata dir from "Wesnoth1.13" to "Wesnoth1.14" at some point.
20180318 20:03:18< Soliton> it's done, used git-new-workdir.
20180318 20:03:49< octalot> zookeeper: it's generated from the version number
20180318 20:03:51< Soliton> zookeeper: pretty sure that's automatic based on the version.
20180318 20:04:11< zookeeper> ah, okay.
20180318 20:04:49< octalot> get_version_path_suffix() in boost_filesystem.cpp
20180318 20:05:32< shadowm> Thanks Soliton 
20180318 20:05:43< shadowm> gfgtdf: https://addons.wesnoth.org/1.14/
20180318 20:05:57< gfgtdf> shadowm: thx
20180318 20:06:12< vultraz> shadowm: can you make "MP Modification" just say "Modification"?
20180318 20:06:50< vultraz> since that was the client-side change 
20180318 20:07:43< irker713> wesnoth/wesnoth:master Sofartin 823a1b19a8 Updated changelog style AppVeyor: All builds passed
20180318 20:11:35< shadowm> vultraz: Can you link me to the commit?
20180318 20:11:42< shadowm> Oh wait.
20180318 20:11:49< shadowm> vultraz: Forget it, that'll have to wait.
20180318 20:12:10< shadowm> I'm not downloading 2.1 GB to make a single commit.
20180318 20:12:24< vultraz> ?
20180318 20:12:29< vultraz> eh?
20180318 20:13:22< shadowm> wesnoth_addon_manager
20180318 20:13:55< vultraz> that's where it gets its values?
20180318 20:15:43< Soliton> that's what builds the html.
20180318 20:18:56< Soliton> if you want to rename it you also need to provide a new description.
20180318 20:20:48-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has quit [Quit: .]
20180318 20:21:36< shadowm> You could submit an issue and I'll tend to it as soon as I can sit at my desktop.
20180318 20:21:51< shadowm> (That kinda goes without saying though.)
20180318 20:42:04-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180318 20:42:10-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20180318 20:46:17< celticminstrel> Giving up on VS2013+clang for now. Might try hacking at it again next weekend or something.
20180318 20:48:31< TadCarlucci> What's the problem with just upgrading to VS2015 or VS2017?
20180318 20:48:45< celticminstrel> I've gone over this like three times already.
20180318 20:48:52< celticminstrel> My VS2015 has expired and wants me to sign in.
20180318 20:50:15< TadCarlucci> So do that. If you're that concerned about Microsoft leaking the email address, just use a cut-out and close it when you're done with it.
20180318 20:50:27< celticminstrel> No.
20180318 20:51:39< vultraz> TadCarlucci: celticminstrel objects to the idea of having to log in at all
20180318 20:52:53< TadCarlucci> So use VS Code and download the VS 2014 build tools kit. Now that we don't support VS 2013, you'll have all the supported compiler toolsets ('15 and '17) and never need to speak to Microsoft again unless you want to download a fresh toolset for patches.
20180318 20:53:05< celticminstrel> I may indeed elect to do that.
20180318 20:53:06< TadCarlucci> s/2014/2017
20180318 20:53:22< celticminstrel> I don't know how much setup will be needed to use VSCode though.
20180318 20:53:31< vultraz> In my own opinion there's absolutely no reason NOT to log in, but whatever
20180318 20:53:34< vultraz> to each their own...
20180318 20:53:36< TadCarlucci> I have VS 2017 but it's a pain in the butt. VS Code is lightyears faster. 
20180318 20:54:23< TadCarlucci> And with the toolsets, if I want to hassle with switching the external kit I can test 2015 and 2017 without having to change projects.
20180318 20:54:41< gfgtdf> vultraz: you saw my comment earileir about requireing gcc5/clang3.4 ?
20180318 20:55:02< vultraz> requiring gcc 5 or 6 was always a given
20180318 20:55:09< vultraz> i have no idea how clang versions work
20180318 20:55:10< irker713> wesnoth: Celtic Minstrel wesnoth:master 49ad25fc6961 / doc/man/wesnoth.6: Document --log-none command line option https://github.com/wesnoth/wesnoth/commit/49ad25fc696112aaa8f7b840abeded7d0660aaaa
20180318 20:55:12< irker713> wesnoth: Celtic Minstrel wesnoth:master 9902a2df31aa / data/advanced_preferences.cfg: Add the advanced prefs entry for the deprecation setting https://github.com/wesnoth/wesnoth/commit/9902a2df31aaa0755c10d2dbf8ea2954087e6a43
20180318 20:55:41< gfgtdf> vultraz: you need to install INSTALL.md then
20180318 20:56:00< vultraz> I need to know what the new minimum is
20180318 20:56:07< celticminstrel> TadCarlucci: Is it easy to use with VSCode?
20180318 20:56:36< TadCarlucci> Very. And there's a WML highliter available.
20180318 20:56:38< celticminstrel> Like, setting it up or whatever.
20180318 20:56:45< gfgtdf> vultraz: according to this page en.cppreference.com/w/cpp/compiler_support gcc5/clang3.4 is enough for c++14
20180318 20:56:52< celticminstrel> Yeah, I have the WML highligher. I've been using VSCode for Lua/WML for a few weeks now.
20180318 20:57:03< vultraz> I'd rather bump it to 6 if possible
20180318 20:57:32< vultraz> I'd still like to be able to use c++17 stuff if possiblle
20180318 20:57:35< celticminstrel> I'd rather not bump it if it's not strictly necessary.
20180318 20:58:11< vultraz> bumping to 17 would cause issues with server-side builds
20180318 20:58:17< TadCarlucci> To compile I just click use menu Tools|Run Build Tool and wait. Basically using the same set-up as AppVeyor 2017 using the 2015 (was 2013) project file and overriding the toolset to use vs 2017 compiler
20180318 20:58:41< gfgtdf> as listed in the same page, not all c++17 features are supported in all compilres even in the latest version.
20180318 20:58:55< TadCarlucci> Debugger works, too. But I try real hard not to have to debug Windows version.
20180318 20:59:24< gfgtdf> if you have a specific feature that you want to use, we can maybe buming requirement for that.
20180318 20:59:26< vultraz> I have no idea what 19.10 is for msvc
20180318 21:00:17< irker713> Failed to fast-forward branch 1.14
20180318 21:00:22< vultraz> what
20180318 21:00:25< gfgtdf> some specific update of vs2017 
20180318 21:00:40< vultraz> gfgtdf: well it would be nice if we could use std::string_view and std::filesystem
20180318 21:01:03< gfgtdf> vultraz: std::string_view needs gcc 7 for example
20180318 21:01:24< gfgtdf> and filesystem is not event implemented in latest msvc (accoring to that page)
20180318 21:02:51< celticminstrel> It can't find msbuild when I do that.
20180318 21:03:13< celticminstrel> Doesn't it need to execute the vcvars batch-file first?
20180318 21:03:38< celticminstrel> Apparently it's defined in tasks.json. I dunno how to let it know where msbuild is.
20180318 21:04:13< celticminstrel> Wait, what the heck does this mean?
20180318 21:04:14< celticminstrel> [Mar 18@5:00:17pm] irker713: Failed to fast-forward branch 1.14
20180318 21:04:27< vultraz> dunno
20180318 21:05:53< vultraz> anywway, for now we can start with c++14 as minimum
20180318 21:06:00< vultraz> then see how stuff progresses as 1.15 goes along
20180318 21:06:06< vultraz> it's 2018 now
20180318 21:06:10< vultraz> 1.12 came out in 2014
20180318 21:06:47 * Soliton is looking into the irker complaint.
20180318 21:08:21-!- travis-ci [~travis-ci@ec2-54-196-127-238.compute-1.amazonaws.com] has joined #wesnoth-dev
20180318 21:08:22< travis-ci> wesnoth/wesnoth#17029 (master - 9830457 : pentarctagon): The build failed.
20180318 21:08:22< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/355101131
20180318 21:08:22-!- travis-ci [~travis-ci@ec2-54-196-127-238.compute-1.amazonaws.com] has left #wesnoth-dev []
20180318 21:08:24< gfgtdf> note that vs15 does not suport all c++14 features (Extended constexpr N3652)
20180318 21:08:29< gfgtdf> vultraz: ^
20180318 21:08:31< vultraz> yeah
20180318 21:08:40< vultraz> that's part of why i kind want to require 2017..
20180318 21:08:46< vultraz> but there was some opposition to the idea
20180318 21:09:41< gfgtdf> i actualyl think anyone that uses vs15 can easiylupdate vs17, afaik vs17 work also on older windows systems (7)
20180318 21:10:03< vultraz> yes
20180318 21:10:05< vultraz> that is true
20180318 21:10:10< celticminstrel> I can't seem to find where MSBuild is. It should have been installed with Visual Studio, right?
20180318 21:10:18< vultraz> jyrki raised the main opposition
20180318 21:10:24< vultraz> but i still don't understand his reasoning
20180318 21:11:05< Soliton> irker should not complain again next hour.
20180318 21:11:34< Soliton> (the 1.14 checkout was messed up somehow.)
20180318 21:16:05< TadCarlucci> celticminstrel, MS Build Tools is a separate download, too. If you have VS 2017 you have both '15 and '17 versions of build tools.
20180318 21:17:05< TadCarlucci> https://www.visualstudio.com/downloads/#build-tools-for-visual-studio-2017 near the bottom: "Build Tools for Visual Studio 2017"
20180318 21:17:31< celticminstrel> I couldn't find it because I was looking under the Visual Studio program folders, but it was in a separate MSBuild program folder.
20180318 21:17:58< celticminstrel> I do have VS2015 and VS2017 both installed (and both expired, I might as well uninstall them I suppose, as long as that can be done while leaving the command-line tools).
20180318 21:18:34< gfgtdf> vultraz: well thne we shodul wait for jykive to repeat his explaining.
20180318 21:19:21< celticminstrel> I think I might have it working now in VSCode.
20180318 21:19:31< celticminstrel> Not sure though because it seems to have frozen.
20180318 21:27:11< TadCarlucci> One of these days I should write a HOWTO for setting up VS Code with Wesnoth and the external packages. You can do everything except update the project files for added/removed source files. (It's possible to hand-edit, but easier to hassle someone with VS 2015 to do it in the UI.)
20180318 21:27:39-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20180318 21:28:04< celticminstrel> I've hand-edited it before, it's not that hard.
20180318 21:28:55-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20180318 21:30:41< celticminstrel> Random WML API request: [move_unit]to_location=special_location_id
20180318 21:30:57< celticminstrel> Is it possible to get that in for 1.14, I wonder?
20180318 21:32:30< gfgtdf> i'd says with rc1 anounced we should really take the freature freeze seriously
20180318 21:37:07< shadowm> Nah, you don't say that. That's the *entire point* of RC 1.
20180318 21:37:23< shadowm> If people break the feature freeze now they'd better have a goddamn good reason or get booted off the project.
20180318 21:37:35< celticminstrel> I guess not even 1.14.1 then?
20180318 21:37:46< gfgtdf> obviosuly not 1.14.1
20180318 21:37:49< celticminstrel> Oh well, I can just override the tags in my addon to add that support anyway.
20180318 21:37:58< shadowm> The Lua and WML API should remain completely unchanged throughout the stable cycle.
20180318 21:38:12< shadowm> Unless you want people encountering weird errors in replays and MP.
20180318 21:40:01< gfgtdf> celticminstrel: note that overwriting code tags fails if another addon you have installed also overrrides core that tag. so it'd probaly saver to make you own custom tag (like [celmin_move_unit]) and use that
20180318 21:40:16< celticminstrel> It'll be fine, because this is a campaign.
20180318 21:45:47< celticminstrel> So anyway, my VSCode build works up to the link stage. It can't find the libs to link with though. At least, it can't find Boost.
20180318 21:46:40-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20180318 21:58:22-!- travis-ci [~travis-ci@ec2-54-91-126-162.compute-1.amazonaws.com] has joined #wesnoth-dev
20180318 21:58:22< travis-ci> wesnoth/wesnoth#17032 (master - 9902a2d : Celtic Minstrel): The build has errored.
20180318 21:58:23< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/355117696
20180318 21:58:23-!- travis-ci [~travis-ci@ec2-54-91-126-162.compute-1.amazonaws.com] has left #wesnoth-dev []
20180318 22:04:15< irker713> wesnoth/wesnoth:1.14 Jyrki Vesterinen 0ab238ab76 Fix heading in players_changelog.md AppVeyor: All builds passed
20180318 22:06:23< irker713> wesnoth: Gregory A Lundberg wesnoth:master 22f0a89a647a / src/hash.hpp: Fix Coverity 1386194 Initialize class member https://github.com/wesnoth/wesnoth/commit/22f0a89a647a017cbe0d94ac316c6928f0bd9a79
20180318 22:07:24-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Quit: Leaving.]
20180318 22:07:36-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20180318 22:20:48-!- Oebele [~quassel@143.177.58.202] has quit [Remote host closed the connection]
20180318 22:21:28-!- octalot [~steve@91.141.2.105.wireless.dyn.drei.com] has quit []
20180318 22:32:05< TadCarlucci> celticminstrel, I added the external dll to my default PATH. The external stuff for compileing and linking is assumed to be ~wesnoth/../external/...
20180318 22:34:06< celticminstrel> I think I just discovered something in 1.13.12 that could be considered a (minor) regression.
20180318 22:34:24< celticminstrel> I can no longer hold down Ctrl+R to recruit a full keep of one type of unit.
20180318 22:34:30< celticminstrel> Ctrl+Alt+R, sorry.
20180318 22:35:11< celticminstrel> Tad, the external dir certainly exists and is set up properly, since I've been using it for Visual Studio.
20180318 22:36:20< irker713> wesnoth/wesnoth:master Gregory A Lundberg 5b371161a7 Add missing override specifier. AppVeyor: 2/4 builds failed
20180318 22:36:21< irker713> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-2008
20180318 22:36:22< irker713> Details vs2017/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-master-1712
20180318 22:42:31-!- commavir [vir@2604:180::502b:135a] has quit [Remote host closed the connection]
20180318 22:42:49< TadCarlucci> Well, I give up for the day. At present, getting Wesnoth to build on Windows is beyond me today. Maybe tomorrow. At least I can get it to build on Linux. *sigh*
20180318 22:43:07-!- commavir [vir@2604:180::502b:135a] has joined #wesnoth-dev
20180318 22:55:47< vultraz> celticminstrel: i don't think that was an intentional feature
20180318 22:56:01< celticminstrel> Whether intentional not, it was a convenient one.
20180318 22:56:16< vultraz> celticminstrel: it was likely fixed with the "holding down menu item hotkey causes repeated execution"
20180318 22:56:19< vultraz> HOWEVER
20180318 22:56:28< vultraz> jyrki added an optional switch for that
20180318 22:56:33< vultraz> repeating_hotkey=yes
20180318 22:56:42< vultraz> how that could be applied to default ones, I don't know..
20180318 22:56:59< celticminstrel> Hmm, okay. We could find/create a way to apply it to some default hotkeys, then.
20180318 22:57:00< vultraz> oh wait, we have data/core/hotkeys
20180318 22:57:13< celticminstrel> We do indeed. :P
20180318 22:57:22< celticminstrel> I dunno if that contains that info.
20180318 22:57:30< vultraz> yes, it contains hotkey definitions
20180318 22:57:39< celticminstrel> We also have the source file hotkey_info.cpp or something, I forget exactly.
20180318 22:57:42< vultraz> but i don't get how that should work?
20180318 22:57:50< vultraz> recruiting is supposed to bring up the dialog
20180318 22:57:57< celticminstrel> Ctrl+Alt+R
20180318 22:58:01< celticminstrel> "Recruit last unit:
20180318 22:58:02< celticminstrel> ^"
20180318 22:58:09< vultraz> ohh
20180318 22:58:17< celticminstrel> So bring it up once, choose the unit, then hold Ctrl+Alt+R to get a keep full.
20180318 22:58:20< vultraz> repeatrecruit
20180318 22:58:24< celticminstrel> Yeah, that one.
20180318 22:59:04< celticminstrel> BTW I added [move_unit]to_location in my addon, it works well. I'll probably push it to 1.15 at some point.
20180318 22:59:10< vultraz> that is a very akward hotkey
20180318 22:59:12< vultraz> awkward
20180318 22:59:16< vultraz> requires two hands..
20180318 22:59:25< celticminstrel> You mean the binding Ctrl+Alt+R?
20180318 22:59:33< vultraz> yes
20180318 22:59:33< celticminstrel> How does it require two hands?
20180318 22:59:40< Ravana_> it doesn't need two hands
20180318 22:59:56< vultraz> well, i can do it with one, but it's a stretch 
20180318 23:00:03< celticminstrel> How is it a stretch?
20180318 23:00:11< AI0867> shadowm: should be the same. I'll see if I can write some unit tests for the hash subsystem
20180318 23:00:38< vultraz> i need to kinda contort my hand
20180318 23:00:41< celticminstrel> Oh, I guess Ctrl and Alt aren't actually adjacent on most keyboards (they are on mine).
20180318 23:00:45< celticminstrel> Still...
20180318 23:01:14< celticminstrel> Even Ctrl+Cmd+R wouldn't be too awkward.
20180318 23:01:14< vultraz> for me, ctl and alt are separated by fn and windows
20180318 23:01:27< celticminstrel> Oh, you have a Fn key in there too. I guess that could make it harder.
20180318 23:01:33< celticminstrel> My Fn key replaces Insert.
20180318 23:02:05< celticminstrel> Which is kinda nice because it means I don't have to worry about accidentally hitting Insert all the time.
20180318 23:02:23< gfgtdf> then where do you have insert ?
20180318 23:02:27< celticminstrel> I don't.
20180318 23:02:29< Ravana_> ctrl alt y is stretch for me (same 2 buttons between as vultraz)
20180318 23:02:47-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20180318 23:02:49< vultraz> that's even worse D:
20180318 23:02:52< vultraz> hm
20180318 23:02:57< vultraz> i can't get this to repeat with repeat_on_hold...
20180318 23:03:00< vultraz> (that's the key)
20180318 23:03:05-!- hrubymar10 [~textual@ip-86-49-9-122.net.upcbroadband.cz] has quit [Quit: hrubymar10]
20180318 23:03:11< celticminstrel> Hm?
20180318 23:03:22< vultraz> repeat_on_hold is supposed to make it repeat on hold
20180318 23:03:27< vultraz> perhaps it's a local issue
20180318 23:03:36< vultraz> lot of stuff has changed with event handling
20180318 23:03:38< celticminstrel> It wasn't repeating_hotkey=yes?
20180318 23:03:46< vultraz> no, i was mistaken
20180318 23:03:52< celticminstrel> Ah, okay.
20180318 23:04:03< vultraz> looks like repeat_on_hold is only valid for menu items...
20180318 23:04:12< celticminstrel> I see.
20180318 23:04:21< vultraz> we can ask jyrki to expand it
20180318 23:04:27< vultraz> just need to move it to global hotkey handling
20180318 23:04:31< celticminstrel> Yeah.
20180318 23:04:41< celticminstrel> I guess it's not high priority.
20180318 23:04:49< vultraz> heh, on current master you can open UNLIMITED CONTEXT MENUS
20180318 23:05:00< celticminstrel> Like, when you open one the previous one doesn't close?
20180318 23:05:04< vultraz> yes
20180318 23:05:22< vultraz> but they do dismiss in opposite order of opening!
20180318 23:05:23< vultraz> :P
20180318 23:05:54< vultraz> basically, gui2 dialogs no longer stop stuff from drawing
20180318 23:06:03< celticminstrel> Hmm, unresolved external symbol crypt64::encode.
20180318 23:06:07< vultraz> but it also means there's context bleedthrough
20180318 23:06:12< celticminstrel> Did someone forget to update the VS projects?
20180318 23:06:18< vultraz> perhaps?
20180318 23:06:23< vultraz> i could have sworn i did though
20180318 23:07:25< celticminstrel> No, base64.cpp is there.
20180318 23:08:05< vultraz> many many conflicts trying to merge gui2_help
20180318 23:08:09< vultraz> wonder if i should have cherry picked...
20180318 23:08:16< celticminstrel> :(
20180318 23:08:21< celticminstrel> What kinds of conflicts?
20180318 23:08:35< vultraz> hm.
20180318 23:08:44< celticminstrel> Cherry-pick doesn't avoid conflicts.
20180318 23:08:45< vultraz> actually, most are minor
20180318 23:08:49< celticminstrel> That's nice!
20180318 23:08:54< vultraz> yeah, i know
20180318 23:09:02< vultraz> still, perhaps merging a very old branch is bad
20180318 23:10:37< celticminstrel> Uhh. So I built a release build and clicked "Start Without Debugging" and... the WML tests ran. :S
20180318 23:10:53< celticminstrel> Instead of Wesnoth. Even though it wesnoth is the startup project.
20180318 23:10:55< celticminstrel> WTH?
20180318 23:11:02< celticminstrel> (They also all failed.)
20180318 23:14:57-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 240 seconds]
20180318 23:20:13-!- travis-ci [~travis-ci@ec2-54-196-127-238.compute-1.amazonaws.com] has joined #wesnoth-dev
20180318 23:20:14< travis-ci> wesnoth/wesnoth#17035 (master - 22f0a89 : Gregory A Lundberg): The build has errored.
20180318 23:20:14< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/355137979
20180318 23:20:14-!- travis-ci [~travis-ci@ec2-54-196-127-238.compute-1.amazonaws.com] has left #wesnoth-dev []
20180318 23:22:39-!- indy116 [~knfotzw@182.253.202.162] has joined #wesnoth-dev
20180318 23:22:40-!- indy116 [~knfotzw@182.253.202.162] has quit [Client Quit]
20180318 23:23:18< irker713> wesnoth/wesnoth:master Gregory A Lundberg f97a617a26 Fix doccomments. AppVeyor: 1/2 builds failed
20180318 23:23:19< irker713> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-2009
20180318 23:30:33-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180318 23:30:39-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20180318 23:53:07-!- Bonobo [~Bonobo@203.63.93.247] has joined #wesnoth-dev
20180318 23:54:05< celticminstrel> So, I give up. I'll just wait for loonycyborg's build before doing more addon work.
20180318 23:54:23< vultraz> build?
20180318 23:54:28< loonycyborg> hmm which build?
20180318 23:54:32< loonycyborg> on jenkins?
20180318 23:55:43< celticminstrel> I mean 1.13.12. I was trying to create my own release build to work on my campaign because I hoped it would lag less than the debug build.
20180318 23:56:10< vultraz> he already uploaded it?
20180318 23:56:36< celticminstrel> Oh? I just assumed it wouldn't be available before the actual announcement... >_>
20180318 23:57:00< celticminstrel> ...speaking of which, I don't even see a draft of the announcement.
20180318 23:57:27< vultraz> there is not yet
20180318 23:58:00< celticminstrel> ...
20180318 23:58:11 * celticminstrel noticed one of the spam threads in the moderator forum. >_>
20180318 23:59:32< irker713> wesnoth: Celtic Minstrel wesnoth:master fbd42a737857 / / (4 files in 2 dirs): Help Browser: Actually show the correct topics with the correct icons https://github.com/wesnoth/wesnoth/commit/fbd42a737857f25e08e5147fb394eb7c72cf2853
20180318 23:59:34< irker713> wesnoth: Celtic Minstrel wesnoth:master 178dba82849f / src/ (4 files in 2 dirs): Help Viewer: Show topics with generated text https://github.com/wesnoth/wesnoth/commit/178dba82849f755a047b1d242c99503e29e0b185
20180318 23:59:36< irker713> wesnoth: Celtic Minstrel wesnoth:master d61af99a9b25 / src/help/ (help_impl.cpp help_impl.hpp): Help: That parameter isn't really needed https://github.com/wesnoth/wesnoth/commit/d61af99a9b256e382b942e4a8baaade28399e542
20180318 23:59:38< irker713> wesnoth: Charles Dang wesnoth:master 19eee7e80636 / data/gui/window/help_browser.cfg: Help Browser: improved layout stability and added next/back buttons (non-functio https://github.com/wesnoth/wesnoth/commit/19eee7e8063614cfdb6fe2096f22f10822b0f699
20180318 23:59:41< irker713> wesnoth: Celtic Minstrel wesnoth:master 11dbcb1464f9 / src/ (5 files in 2 dirs): Help Viewer: Parse help markup to Pango markup... mostly. https://github.com/wesnoth/wesnoth/commit/11dbcb1464f9b30796ff3faadb60dd85fd154ba8
20180318 23:59:43< irker713> wesnoth: Charles Dang wesnoth:master 231a8ccbf237 / / (3 files in 2 dirs): Help Browser: implemented viewing of sub-sections/topics https://github.com/wesnoth/wesnoth/commit/231a8ccbf2376b56c9bc02c4cf93c1a9079fc4f2
20180318 23:59:43< celticminstrel> Oh hey, GUI2 help merge.
20180318 23:59:46< irker713> wesnoth: Charles Dang wesnoth:master c514c95a1f18 / src/ (gui/dialogs/title_screen.cpp help/help.cpp): Moved new help entry point to a common location https://github.com/wesnoth/wesnoth/commit/c514c95a1f182bc44a6c2d13ae590238227f1a4e
20180318 23:59:49< irker713> wesnoth: Celtic Minstrel wesnoth:master cdea534ee0f2 / src/gui/dialogs/ (help_browser.cpp help_browser.hpp): Help Browser: Implement history https://github.com/wesnoth/wesnoth/commit/cdea534ee0f2ef04191bf4ad6b15a06b73504985
20180318 23:59:51< irker713> wesnoth: Celtic Minstrel wesnoth:master a96c270b321b / src/help/help_text_area.cpp: Fix GUI1 help topics not showing https://github.com/wesnoth/wesnoth/commit/a96c270b321b2ac69b9e15f56a76617c42b08d66
20180318 23:59:53< irker713> wesnoth: Charles Dang wesnoth:master 71a89de7b2ff / / (3 files in 3 dirs): Help Browser: properly implement toggling by clicking the book icons https://github.com/wesnoth/wesnoth/commit/71a89de7b2ffa204de0142a045880021b603db3f
20180318 23:59:56< irker713> wesnoth: Celtic Minstrel wesnoth:master f2434d657203 / src/gui/dialogs/help_browser.cpp: Help Browser: Fix back button being visible when dialog opens https://github.com/wesnoth/wesnoth/commit/f2434d65720363ab572cd81166beac535e2ca9d9
20180318 23:59:58< irker713> wesnoth: Celtic Minstrel wesnoth:master 854ade5d5c99 / data/gui/window/help_browser.cfg src/gui/dialogs/help_browser.cpp: Help Browser: Show topic title https://github.com/wesnoth/wesnoth/commit/854ade5d5c99f00eb792443858cb2ef77019d8a1
--- Log closed Mon Mar 19 00:00:00 2018