--- Log opened Thu Mar 22 00:00:10 2018 20180322 00:24:43< wedge009> That may be generally true, but it does make it harder for native English-speakers to learn European languages (and presumably hard for translators from English, which I'm guessing what the conversation is about). 20180322 00:26:08<+discordbot2> certainly something one needs to get used to, yes 20180322 00:57:24< wedge009> Oh, what happened to discordbot1? Is this an upgrade? 20180322 00:58:36<+discordbot2> hm? 20180322 00:58:39<+discordbot2> what about it 20180322 01:05:01-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20180322 01:06:25-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180322 01:10:36-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20180322 01:11:57-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180322 01:21:48<+discordbot2> No, it's the same bot as always. 20180322 01:24:52<+discordbot2> I've ended up making significant edits to the proposed Dunefolk description. 20180322 01:25:08<+discordbot2> 'bout halfway done.. 20180322 01:33:43< irker760> wesnoth/wesnoth:master Charles Dang 75954109c5 Fake Display: cleanup AppVeyor: 2/4 builds failed 20180322 01:33:44< irker760> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-2081 20180322 01:33:45< irker760> Details vs2017/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-master-1785 20180322 01:35:33-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!] 20180322 01:36:20-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180322 01:37:57-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20180322 01:52:37-!- gfgtdf [~chatzilla@x4e368626.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.93 [Firefox 52.7.2/20180315163333]] 20180322 02:04:23<+discordbot2> well that took way too long 20180322 02:20:03<+discordbot2> @Vultraz while your edits are good, that description could still use some work IMO 20180322 02:20:22<+discordbot2> there are a couple issues in some places 20180322 02:20:22<+discordbot2> How so? 20180322 02:20:38<+discordbot2> one I can point out is this 20180322 02:20:40<+discordbot2> "But do not mistake this for disunity." 20180322 02:20:50<+discordbot2> to me, it reads awkwardly to have a command in a description 20180322 02:22:00<+discordbot2> there's also some wording that sounds like fluff 20180322 02:22:08<+discordbot2> e.g. "designated to protect the superior interest of the nation" 20180322 02:22:23<+discordbot2> -> designated to protect their nation's interests 20180322 02:25:27<+discordbot2> That bit was from the previous draft 20180322 02:25:44<+discordbot2> And I kinda like the use of the imperative there 20180322 02:26:31<+discordbot2> it's up to you 20180322 02:26:40<+discordbot2> the use of the command is really jarring to me though 20180322 02:28:30<+discordbot2> I guess I could say”this should not be mistaken” 20180322 02:28:39<+discordbot2> meh 20180322 02:28:46<+discordbot2> maybe instead of me suggesting all these things 20180322 02:28:57<+discordbot2> I can just edit your description a bit and put my own version there 20180322 02:30:37<+discordbot2> You could 20180322 02:42:54-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev 20180322 02:53:03< irker760> wesnoth/wesnoth:1.14 Iris Morelle ef8fc9df93 Check the Travis status for 1.14 in the AppVeyor: 2/4 builds failed 20180322 02:53:04< irker760> Details vs2017/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-1.14-1787 20180322 02:53:05< irker760> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-1.14-2082 20180322 02:59:59<+discordbot2> From the 1.13.11 announcement thread: "1.13.12 will need Stretch to compile on debian, due to boost libs 1.56. i was meaning to upgrade OS anyway" 20180322 03:00:04<+discordbot2> When was this decided? 20180322 03:01:09< celticminstrel> Probably when someone realized it doesn't work on pre-Stretch. 20180322 03:01:19< celticminstrel> Whoa I have a lot of forum notificaitons today. 20180322 03:01:35<+discordbot2> Rebuilding the 1.14 campaignd. 20180322 03:01:55<+discordbot2> If this affects campaignd and wesnothd I'm not going to be happy. 20180322 03:02:04<+discordbot2> .... 20180322 03:02:37<+discordbot2> Checking for Boost random library version >= 1.56.0... no 20180322 03:02:41<+discordbot2> Are you kidding me? 20180322 03:03:00<+discordbot2> Why didn't anyone even bother asking me or the other website admins before doing this? 20180322 03:03:22<+discordbot2> I'm afraid I don't have too much time to spend on it, so my edits are not extremely thorough 20180322 03:03:34<+discordbot2> however, I've cleaned up a couple things @Vultraz 20180322 03:03:35<+discordbot2> https://pastebin.com/ikzvQitf 20180322 03:03:49< shadowm> celticminstrel: Commit c82c1ff9059aa19adda6a527f41595a18b8c0a1f . It is your change. 20180322 03:04:13< shadowm> You do realize that this means that I have to update 2 VMs out of schedule now if I want to deploy any bug fixes for any reason? 20180322 03:04:35< celticminstrel> "out of schedule"? 20180322 03:04:50< shadowm> They were not slated for upgrade any time soon. 20180322 03:05:01< shadowm> They are both running Debian jessie right now. 20180322 03:05:12< celticminstrel> Oh the stretch thing. 20180322 03:05:47< celticminstrel> It might be possible to reduce the requirement for the servers only? 20180322 03:06:03< celticminstrel> I think the reason for increasing it (boost::optional::emplace) doesn't actually affect them. 20180322 03:06:10< shadowm> https://packages.debian.org/jessie/libboost-all-dev 20180322 03:06:16< celticminstrel> The Boost version at least, no idea on the stretch thing. 20180322 03:06:20< shadowm> Version 1.55.0 is what ships with jessie. 20180322 03:06:53< shadowm> tr0ll says 1.13.12 needs stretch because only stretch ships with a Boost version that meets the requirement you introduced. 20180322 03:07:23< shadowm> You know, this kind of thing is precisely why back in the day we required *ALL* version requirement changes to go through the mailing list first. 20180322 03:07:35< shadowm> Not discussed on a volatile chat platform. 20180322 03:07:41<+discordbot2> @Yumi these are quite good edits 20180322 03:08:01<+discordbot2> they smooth out a few rough edges i couldn't think of better text for 20180322 03:08:12< celticminstrel> @Vultraz So what was changed? 20180322 03:08:14< shadowm> We have a situation at wesnoth.org and I don't know if it's safe to upgrade anything at the moment, so I hope no-one needs a newer wesnothd or campaignd any time soon. 20180322 03:08:22<+discordbot2> celmin what? 20180322 03:08:47< celticminstrel> Maybe I should've pinged @Yumi for that actually. 20180322 03:08:48< shadowm> Meanwhile hopefully someone will realize that changing version requirements without an extremely good reason this late in the cycle is a bad thing? 20180322 03:09:12<+discordbot2> it was a dunefolk description 20180322 03:09:25<+discordbot2> I think someone put one on the forum, Vultraz edited it, and I did a second edit 20180322 03:09:32< shadowm> We made an exception for a 1.12 RC (RC3 I believe) because we needed to solve a major long-standing bug. I'd like to hear what bug the Boost version requirement actually solves. 20180322 03:09:36< celticminstrel> What about the version in the pull request? 20180322 03:09:50<+discordbot2> @Yumi please post it 20180322 03:10:35<+discordbot2> oh, I thought you might like to edit your post to avoid confusion 20180322 03:10:42<+discordbot2> but I suppose I can 20180322 03:10:45< celticminstrel> shadowm: It was related to https://github.com/wesnoth/wesnoth/issues/2247 20180322 03:11:01< celticminstrel> I think that's the only place I used boost::optional::emplace. 20180322 03:11:03<+discordbot2> @Yumi would you prefer i edit ine? 20180322 03:11:04<+discordbot2> mine 20180322 03:11:22<+discordbot2> doesn't matter to me, I was just thinking that having a billion descriptions floating around gets confusing 20180322 03:11:33<+discordbot2> for everyone reading the thread 20180322 03:11:38<+discordbot2> alright ill edit 20180322 03:11:42< shadowm> celticminstrel: It seems like you could've used an alternative that didn't require changing our version requirements then? 20180322 03:11:45<+discordbot2> mkay 20180322 03:12:29< shadowm> It doesn't sound like it's code that absolutely needs the negligible performance gain from using emplace (assuming Boost.optional's emplace is like STL emplace). 20180322 03:13:31< shadowm> Also hilariously enough this version requirement change is not mentioned in the release announcement draft. 20180322 03:14:22< celticminstrel> shadowm: Possibly, I could probably make it use unique_ptr instead. 20180322 03:14:25< shadowm> Or in the email that loonycyborg sent out to packagers, which claims "Nothing has changed for packagers in terms of dependencies or install locations in this release." 20180322 03:14:46< celticminstrel> I used emplace because the type is not assignable IIRC. 20180322 03:14:48<+discordbot2> celmin: isn't there an insert equivalent? 20180322 03:14:51< shadowm> Meaning this piece of information in the email is a flat-out lie. 20180322 03:15:09< celticminstrel> @Vultraz even if there were it'd probably have the same problem I got with simple assignment. 20180322 03:15:18<+discordbot2> hm 20180322 03:15:31< celticminstrel> That said, simple assignment probably is the insert equivalent. 20180322 03:16:01<+discordbot2> did you delete the copy assignment op? 20180322 03:16:41< celticminstrel> I think it's implicitly deleted. 20180322 03:16:55< celticminstrel> Which generally means it can't be sensibly defined, because some member data is const. 20180322 03:17:00<+discordbot2> right 20180322 03:17:07< celticminstrel> Thogh that could still be solved by making it non-const. 20180322 03:17:13<+discordbot2> but can't you define a move assignment op? 20180322 03:17:18< celticminstrel> Note that references count as const (whether they're const or not) for this purpose. 20180322 03:17:45<+discordbot2> aren't move assignment is used for rvalues if the copy ctor is deleted? 20180322 03:17:50<+discordbot2> copy assignment op* 20180322 03:17:50< celticminstrel> If you can't assign a copy assignment operator due to const data, you can't define a move assignment operator either. 20180322 03:18:11< celticminstrel> The point is it's const so you can't overwrite it with the thing you're assigning. 20180322 03:18:19<+discordbot2> ah 20180322 03:18:49< celticminstrel> BTW if someone does decide to revert the version-bump commit, you should be aware that one of the Boost requirements in CMake was previously incorrect, so a manual revert is probably better. 20180322 03:20:00<+discordbot2> This is partly on me. 20180322 03:20:12<+discordbot2> I said it was fine to bump the version. 20180322 03:20:50< celticminstrel> It should be possible to rewrite that bit of code to not require boost::optional::emplace, if we need to do it. 20180322 03:21:44<+discordbot2> where are you even using those variables? 20180322 03:22:13< celticminstrel> Hmm? 20180322 03:22:35< celticminstrel> I can't even see the difference between @Yumi's version and skeptical_troll's. I guess the difference can't be that big then. 20180322 03:22:46<+discordbot2> in both cases you create opp_ctx and then do nothing with it 20180322 03:23:00<+discordbot2> celmin there are some rather significant differences 20180322 03:23:08<+discordbot2> i know because yumi edited my edit 20180322 03:23:09< celticminstrel> It's a RAII class. 20180322 03:23:24< celticminstrel> Creating it sets something up, which is then torn down by its destructor. 20180322 03:23:35<+discordbot2> ok 20180322 03:23:40<+discordbot2> wasn't clear it was RAII 20180322 03:24:23<+discordbot2> normally i add a comment denoting it so 20180322 03:24:54< celticminstrel> IMO the word "context" in the type name is a strong clue. 20180322 03:28:56-!- vn971 [~vasya@94.158.103.15] has quit [Ping timeout: 245 seconds] 20180322 03:44:54-!- Bonobo [~Bonobo@203.63.93.247] has joined #wesnoth-dev 20180322 03:47:01< irker760> wesnoth: Charles Dang wesnoth:master 4ea25d5df52d / src/ (controller_base.cpp display.cpp display.hpp playsingle_controller.cpp): Display: removed more theme handling stuff https://github.com/wesnoth/wesnoth/commit/4ea25d5df52d8b5185465c239c88a5508dc8704f 20180322 04:05:03-!- Bonobo [~Bonobo@203.63.93.247] has quit [Quit: Leaving] 20180322 04:05:32-!- Bonobo [~Bonobo@203.63.93.247] has joined #wesnoth-dev 20180322 04:07:11-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The computer falls into a deep sleep, to awake again some other day!] 20180322 04:18:23-!- travis-ci [~travis-ci@ec2-54-224-223-228.compute-1.amazonaws.com] has joined #wesnoth-dev 20180322 04:18:24< travis-ci> wesnoth/wesnoth#17089 (master - 4ea25d5 : Charles Dang): The build is still failing. 20180322 04:18:25< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/356701389 20180322 04:18:25-!- travis-ci [~travis-ci@ec2-54-224-223-228.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180322 04:25:41< irker760> wesnoth/wesnoth:master Charles Dang 4ea25d5df5 Display: removed more theme handling stu AppVeyor: vs2015/Release Failed 20180322 04:25:42< irker760> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-2083 20180322 04:40:49<+discordbot2> Somehow the typesetting in the victory popup doesn't seem all that balanced to me. 20180322 04:40:50<+discordbot2> https://cdn.discordapp.com/attachments/259976436490829825/426238802458312705/unknown.png 20180322 04:43:22<+discordbot2> i did that 20180322 04:44:41<+discordbot2> It seems like the Recall dialog pops up again after recalling a unit under conditions I've not yet determined. 20180322 04:46:59<+discordbot2> @Vultraz So your forum post is the most up to date version, not what Yumi linked to early here? 20180322 04:48:20<+discordbot2> @Pentarctagon i replaced my version with yumi's edit of my version 20180322 04:48:25<+discordbot2> ok 20180322 04:50:53<+discordbot2> his edit was not of whatshisname's version 20180322 04:52:18<+discordbot2> skeptical_troll? 20180322 04:54:02<+discordbot2> yes 20180322 04:54:14<+discordbot2> skeptical_troll -> me -> yumi 20180322 04:54:47<+discordbot2> what do you think of the latest version? 20180322 04:55:57<+discordbot2> Two Brothers scenario 4 has this: [endlevel] result=victory carryover_report=no [/endlevel] 20180322 04:56:06<+discordbot2> So other than the linger screen overlay I'm not told I won? 20180322 04:56:35<+discordbot2> Also of course the music for the next scenario doesn't trigger at the start of the story screen... 20180322 04:56:43<+discordbot2> {SCENARIO_MUSIC traveling_minstrels.ogg} # Talk-only scenario 20180322 04:56:56<+discordbot2> I'm still hearing Aleksi's battle theme from the previous scenario's playlist. 20180322 04:59:11<+discordbot2> i have a fix locally 20180322 05:00:05<+discordbot2> I'd make a couple minor changes: "the Dunefolk call home the river valleys and oases of the Sandy Wastes" -> "the Dunefolk call the river valleys and oases of the Sandy Wastes home" "the more centralized nations of the north" -> "the more centralized nations to the north" Also not sure I like this: "At the same time, this analytical mindset has distanced them from magical arts; to the rational mind, magic is uncontrollable, 20180322 05:00:05<+discordbot2> unpredictable, and hence unreliable. For this reason, the Dunefolk loathe all forms of necromancy and the dark arts, even moreso than other races." - it doesn't seem to follow that would seem to indicate that this would lead them to dislike only necromancy et al. Also: "When facing the Dunefolk in battle, however, the most fearsome sight is certainly their deployment of ferocious and bizarre beasts. From the majestic Roc to the imposing 20180322 05:00:06<+discordbot2> Wyvern, their synergy with these creatures allows for great versatility in combat." - it's weird to mention this when right now the faction can only recruit weak falcons. 20180322 05:01:39<+discordbot2> Any noobs reasonably skilled people want to play a 1v1 against me on the trunk MP server right now? 20180322 05:01:40<+discordbot2> I kinda like "call home the" 20180322 05:02:06<+discordbot2> to the north, that's fine 20180322 05:02:31<+discordbot2> (Using 1.13.12+dev.) 20180322 05:02:36<+discordbot2> I don't have too many complaints but one glaring issue to my eye is "Each of these cities also enjoys a degree of independence almost unheard of in the more centralized nations of the north, many even maintaining their own standing armies." 20180322 05:02:36<+discordbot2> we could say "especially loathe" 20180322 05:02:55<+discordbot2> This ignores Elensefar and Dwarven Doors 20180322 05:03:18<+discordbot2> but i guess the "call [] home" edit would be fine. 20180322 05:04:32<+discordbot2> what about: "For this reason, the Dunefolk loathe all forms of necromancy and the dark arts" -> "For this reason, the Dunefolk especially loathe the perversions of necromancy and the dark arts"? 20180322 05:04:34<+discordbot2> @pydsigner "Each of these cities also enjoys a degree of independence skin to the free-minded nation-states to the north, many even maintaining their own standing armies." 20180322 05:05:33<+discordbot2> @Pentarctagon sounds alright 20180322 05:06:24<+discordbot2> Eh. Just swap "almost unheard of" for "less common" 20180322 05:06:28<+discordbot2> ok 20180322 05:07:35<+discordbot2> I would prefer "lay claim to []" to "call [] home" because of the noun-phrase length 20180322 05:08:12<+discordbot2> @Pentarctagon ok, so: add your "to the north" edit, your necromancy edit (don't forget to keep the "moreso [...]" but, and do as suggested and replace "almost unhead of" with "less common" 20180322 05:08:27<+discordbot2> @pydsigner you dont think we should keep it as-is for stylstic reasons? 20180322 05:08:29<+discordbot2> sylistic 20180322 05:08:31<+discordbot2> stylistic 20180322 05:10:50<+discordbot2> First try ;) 20180322 05:11:38<+discordbot2> I think my tweak is sufficiently fluid or I'd have suggested something else but IDK, I'm just one non-writing-major 20180322 05:12:26<+discordbot2> https://forums.wesnoth.org/viewtopic.php?f=32&t=47721&p=624996#p624996 20180322 05:14:47<+discordbot2> @Pentarctagon why not, let's use pyd's "lay claim to" 20180322 05:15:37<+discordbot2> sure 20180322 05:37:16<+discordbot2> Maybe we could give them an animal recruit 20180322 05:42:46<+discordbot2> They have one 20180322 05:43:03<+discordbot2> A better one 20180322 05:43:31<+discordbot2> Ftr I think it would be nice to establish the name of this ruling body 20180322 05:43:47<+discordbot2> BTW is this text addition for 1.14 or 1.15 20180322 05:45:35<+discordbot2> 15 20180322 05:54:45<+discordbot2> This name should be in native tongue ugh 20180322 05:55:58<+discordbot2> Do we want to establish the Dunefolk as having a language similar to the original pseudoArabic or come up with something entirely off the wall? 20180322 05:57:03<+discordbot2> Interesting question 20180322 06:00:48<+discordbot2> Is it necessary to name the ruling body in the description? 20180322 06:01:12-!- vn971 [~vasya@94.158.103.15] has joined #wesnoth-dev 20180322 06:02:21<+discordbot2> It feels a bit like a cop out not to 20180322 06:06:45<+discordbot2> And the text is a bit awkward 20180322 06:06:51<+discordbot2> But we could leave it out I suppose 20180322 06:08:01<+discordbot2> Adding in the Roc and Wyvern wouldn't be a huge thing though, I don't think. Adding the Roc as the third advancement of the Falcon probably wouldn't impact much, and the wyvern would just be a non-recruitable unit available. IIRC there are already sprites available for them somewhere too. 20180322 06:08:30<+discordbot2> Could even write some nice flavor description of how that transformation happens at some point. 20180322 06:08:50<+discordbot2> elder falcon -> roc, I mean 20180322 06:16:23-!- discordbot3 [~discordbo@baldras.wesnoth.org] has joined #wesnoth-dev 20180322 06:16:26-!- mode/#wesnoth-dev [+v discordbot3] by ChanServ 20180322 06:17:07-!- discordbot2 [~discordbo@baldras.wesnoth.org] has quit [Write error: Broken pipe] 20180322 06:18:09<+discordbot3> anyway, @Vultraz, it sounds like it's just waiting on maybe naming the ruling body, and whether or not to use "world" or "Irdya". 20180322 06:18:31<+discordbot3> I say stick with irdya 20180322 06:19:04-!- discordbot4 [~discordbo@baldras.wesnoth.org] has joined #wesnoth-dev 20180322 06:19:07-!- mode/#wesnoth-dev [+v discordbot4] by ChanServ 20180322 06:19:08-!- discordbot3 [~discordbo@baldras.wesnoth.org] has quit [Read error: Connection reset by peer] 20180322 06:20:04<+discordbot4> wouldn't it be ironic to have the ruling body called the "khalifate" 20180322 06:20:15<+discordbot4> 😖 20180322 06:21:22<+discordbot4> But I guess we can leave the council thing for later 20180322 06:25:22<+discordbot4> alright. I'll update the PR, then maybe leave it for a day so celticminstrel can take a look at least. 20180322 07:07:02< irker760> wesnoth/wesnoth:master pentarctagon c8b8eaaa44 Add the updated Dunefolk race descriptio AppVeyor: vs2017/Release Failed 20180322 07:07:03< irker760> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-master-1789 20180322 07:20:40<+discordbot4> @Vultraz ^ 20180322 07:26:05-!- Netsplit *.net <-> *.split quits: midzer 20180322 07:26:20-!- midzer_ [~quassel@p5B312805.dip0.t-ipconnect.de] has joined #wesnoth-dev 20180322 07:33:31<+discordbot4> Hm, I'm looking at a bit of #2709. I literally can't see how the $login’s game string isn't being localized. 20180322 07:33:48<+discordbot4> cpp utils::string_map i18n_symbols; i18n_symbols["login"] = preferences::login(); return vgettext("$login|’s game", i18n_symbols); 20180322 07:34:40<+discordbot4> The implementation of vgettext() looks just fine to me. 20180322 07:44:29-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20180322 07:51:40< irker760> wesnoth: Lari Nieminen wesnoth:master 4d86af796ca4 / data/campaigns/Eastern_Invasion/lua/bandits.lua: EI: Fix Lua syntax error from 3783693cbe95 https://github.com/wesnoth/wesnoth/commit/4d86af796ca46f204f958b712465a05bdfa0de75 20180322 07:52:09< irker760> wesnoth: Lari Nieminen wesnoth:1.14 48514bf318fb / data/campaigns/Eastern_Invasion/lua/bandits.lua: EI: Fix Lua syntax error from 3783693cbe95 https://github.com/wesnoth/wesnoth/commit/48514bf318fb0aad1e227060b027fd5c74bff9c4 20180322 08:04:41<+discordbot4> @loonycyborg Forgot to mention that I confirmed earlier that the fixes on 1.12 let me build with SCons again, thanks. 20180322 08:04:58<+discordbot4> cool 20180322 08:05:51<+discordbot4> Ugh. std::cerr << vgettext("$login|’s game", i18n_symbols) << '\n'; 20180322 08:06:15<+discordbot4> Literally writes shadowm’s game to the console even though the locale is Spanish and I can clearly see that the string is in the catalogue, not fuzzy. 20180322 08:08:32<+discordbot4> So somehow translation::dsgettext("wesnoth", "$login|’s game") is not retrieving the string. 20180322 08:11:34<+discordbot4> Hang on a moment, if I actually call that it does retrieve the translation. 20180322 08:13:24<+discordbot4> GETTEXT_DOMAIN is correctly set to "wesnoth" for that file. What on earth... 20180322 08:13:51<+discordbot4> OH. 20180322 08:20:04-!- vn971 [~vasya@94.158.103.15] has quit [Ping timeout: 260 seconds] 20180322 08:20:59<+discordbot4> @loonycyborg Can you remind me how you perform a pot-update these days? 20180322 08:21:20< loonycyborg> scons pot-update 20180322 08:21:39< loonycyborg> don't do that on 1.12 yet though 20180322 08:21:51<+discordbot4> I only want it for 1.14. 20180322 08:22:31-!- vn971 [~vasya@94.158.103.15] has joined #wesnoth-dev 20180322 08:23:48<+discordbot4> Oh dear oh dear there are a lot of naked vgettext() calls everywhere. 20180322 08:24:19<+discordbot4> src/actions/move.cpp: message = vgettext("Units sighted! ($friendphrase, $enemyphrase)", symbols); 20180322 08:24:28<+discordbot4> I'm pretty sure I saw this come up in English as well during gameplay. 20180322 08:33:17<+discordbot4> I'm sorting them all out at once in a big POR. 20180322 08:38:58< irker760> wesnoth/wesnoth:master Lari Nieminen 4d86af796c EI: Fix Lua syntax error from 3783693cbe AppVeyor: vs2017/Release Failed 20180322 08:38:59< irker760> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-master-1790 20180322 08:49:25<+discordbot4> Huh. 20180322 08:50:10<+discordbot4> @Vultraz Commit a43623ff2d2b341dd3290039d38a3bb9c1dff151 breaks the string freeze. 20180322 08:50:36<+discordbot4> Your homework is to figure out why (the answer is trivial). 20180322 09:03:16<+discordbot4> 05:51:43 shadowm@hanacore ~/src/wesnoth-1.14 git:bugfix/1.4-naked-vgettext % git commit src/ [bugfix/1.4-naked-vgettext b8bce09265] Replace all instances of naked vgettext() calls with VGETTEXT() 39 files changed, 106 insertions(+), 107 deletions(-) 20180322 09:06:10< irker760> wesnoth: loonycyborg wesnoth:1.12 19259b0dbff0 / po/SConscript: Fix incorrect port of os.path.walk to os.walk https://github.com/wesnoth/wesnoth/commit/19259b0dbff0bd5ec7ff6ebd4eef28ce6dc8c436 20180322 09:25:43< irker760> wesnoth/wesnoth:master Charles Dang 4ea25d5df5 Display: removed more theme handling stu AppVeyor: 2/4 builds failed 20180322 09:25:44< irker760> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-2083 20180322 09:25:45< irker760> Details vs2017/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-master-1788 20180322 09:36:36<+discordbot4> how about dropping the last three languages listed at gettext.wesnoth.org 20180322 09:37:38<+discordbot4> They are languages spoken in rather regions than countries, and have 1-3 translated words each 20180322 09:38:28<+discordbot4> I think that's unnecessary now that languages below a certain completeness threshold can be removed form view. 20180322 09:38:39<+discordbot4> Plus removing languages is not exactly a thing we do. 20180322 09:39:27<+discordbot4> (This reminds me I've been waiting over a week for @hrubymar10 to confirm I fixed the issues with the language team stat view.) 20180322 09:41:45<+discordbot4> Sorry about that 😄 Yes, it is fixed now. Thank you 20180322 09:53:59< irker760> wesnoth/wesnoth:1.14 Lari Nieminen 48514bf318 EI: Fix Lua syntax error from 3783693cbe AppVeyor: vs2015/Release Failed 20180322 09:54:00< irker760> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-1.14-2086 20180322 10:21:55-!- travis-ci [~travis-ci@ec2-54-224-223-228.compute-1.amazonaws.com] has joined #wesnoth-dev 20180322 10:21:57< travis-ci> shikadiqueen/wesnoth#34 (bugfix/1.14-naked-vgettext - b8bce09 : Iris Morelle): The build passed. 20180322 10:21:57< travis-ci> Build details : https://travis-ci.org/shikadiqueen/wesnoth/builds/356773028 20180322 10:21:57-!- travis-ci [~travis-ci@ec2-54-224-223-228.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180322 10:51:15-!- octalot [~steve@178.115.131.231.wireless.dyn.drei.com] has quit [Ping timeout: 256 seconds] 20180322 10:58:51-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180322 10:59:14< irker760> wesnoth/wesnoth:1.14 Iris Morelle 365fb8bdfe Update the changelog AppVeyor: vs2015/Release Failed 20180322 10:59:15< irker760> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-1.14-2088 20180322 10:59:45-!- Bonobo [~Bonobo@203.63.93.247] has quit [Ping timeout: 248 seconds] 20180322 11:01:04-!- Bonobo [~Bonobo@203.220.138.198] has joined #wesnoth-dev 20180322 11:09:06< irker760> wesnoth: Charles Dang wesnoth:master 8d1ec6216bb3 / data/gui/macros/ (custom_options_tree.cfg player_list_panel.cfg): Added two missing textdomain headers https://github.com/wesnoth/wesnoth/commit/8d1ec6216bb336f29f5e213df5b1418703cdc0a0 20180322 12:03:52< irker760> wesnoth: Charles Dang wesnoth:master 6721c84f7e49 / src/display.cpp: Display: minor code cleanup https://github.com/wesnoth/wesnoth/commit/6721c84f7e49d87ac2f9ea61e1134e850c2ebbaa 20180322 12:03:55< irker760> wesnoth: Charles Dang wesnoth:master c195ff25d98a / src/display.cpp: Display: formatting cleanup https://github.com/wesnoth/wesnoth/commit/c195ff25d98adb62e562cc1307f1fb961a1f09dc 20180322 12:03:58< irker760> wesnoth: Charles Dang wesnoth:master 4abbb7b9f936 / src/display.cpp: Display: more code cleanup, mostly of stuff I noticed while formatting https://github.com/wesnoth/wesnoth/commit/4abbb7b9f936edaa266e8606f72f41b1504a32c8 20180322 12:05:45<+discordbot4> All hail the great utils::clamp 20180322 12:07:02< irker760> wesnoth/wesnoth:master pentarctagon c8b8eaaa44 Add the updated Dunefolk race descriptio AppVeyor: 2/4 builds failed 20180322 12:07:03< irker760> Details vs2017/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-master-1789 20180322 12:07:04< irker760> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-2084 20180322 12:07:21-!- midzer_ is now known as midzer 20180322 12:25:19-!- travis-ci [~travis-ci@ec2-54-166-12-172.compute-1.amazonaws.com] has joined #wesnoth-dev 20180322 12:25:20< travis-ci> wesnoth/wesnoth#17092 (master - 4abbb7b : Charles Dang): The build is still failing. 20180322 12:25:20< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/356839475 20180322 12:25:20-!- travis-ci [~travis-ci@ec2-54-166-12-172.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180322 12:33:42< irker760> wesnoth: Charles Dang wesnoth:master 410398a70b37 / src/ (9 files in 7 dirs): Used stdlib math functions instead of global C versions https://github.com/wesnoth/wesnoth/commit/410398a70b37d6cf4a75ff1e3abd43225413c9d2 20180322 12:42:05-!- atarocch [~atarocch@93.56.164.28] has quit [Ping timeout: 240 seconds] 20180322 12:51:44-!- travis-ci [~travis-ci@ec2-54-166-120-113.compute-1.amazonaws.com] has joined #wesnoth-dev 20180322 12:51:45< travis-ci> wesnoth/wesnoth#17093 (master - 410398a : Charles Dang): The build is still failing. 20180322 12:51:45< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/356851810 20180322 12:51:45-!- travis-ci [~travis-ci@ec2-54-166-120-113.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180322 13:19:31-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer] 20180322 13:23:08< irker760> wesnoth/wesnoth:master Charles Dang 410398a70b Used stdlib math functions instead of gl AppVeyor: vs2017/Release Failed 20180322 13:23:09< irker760> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-master-1797 20180322 13:38:58< irker760> wesnoth/wesnoth:master Lari Nieminen 4d86af796c EI: Fix Lua syntax error from 3783693cbe AppVeyor: 2/4 builds failed 20180322 13:38:59< irker760> Details vs2017/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-master-1790 20180322 13:39:00< irker760> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-2085 20180322 13:51:35-!- Bonobo [~Bonobo@203.220.138.198] has quit [Ping timeout: 276 seconds] 20180322 14:08:39-!- atarocch [~atarocch@93-36-163-158.ip61.fastwebnet.it] has joined #wesnoth-dev 20180322 14:13:09-!- molgrum [~molgrum@databur.st] has joined #wesnoth-dev 20180322 14:13:09-!- molgrum [~molgrum@databur.st] has quit [Changing host] 20180322 14:13:09-!- molgrum [~molgrum@unaffiliated/molgrum] has joined #wesnoth-dev 20180322 14:47:44-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180322 14:47:50-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180322 14:53:59< irker760> wesnoth/wesnoth:1.14 Lari Nieminen 48514bf318 EI: Fix Lua syntax error from 3783693cbe AppVeyor: 2/4 builds failed 20180322 14:54:00< irker760> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-1.14-2086 20180322 14:54:01< irker760> Details vs2017/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-1.14-1791 20180322 15:14:48< irker760> wesnoth: Gregory A Lundberg wesnoth:master 812de972ac4a / src/playsingle_controller.cpp: Fix unused parameter https://github.com/wesnoth/wesnoth/commit/812de972ac4a91b58b5a88c4e65d39ad9da28d52 20180322 15:53:23< irker760> wesnoth: Alexander van Gessel wesnoth:master 8179c7226b2f / src/minimap.cpp: Invert a conditional https://github.com/wesnoth/wesnoth/commit/8179c7226b2f9dbf714ccc48303c1b5177b7635e 20180322 15:53:55-!- travis-ci [~travis-ci@ec2-54-166-120-113.compute-1.amazonaws.com] has joined #wesnoth-dev 20180322 15:53:56< travis-ci> wesnoth/wesnoth#17094 (master - 812de97 : Gregory A Lundberg): The build is still failing. 20180322 15:53:56< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/356927853 20180322 15:53:56-!- travis-ci [~travis-ci@ec2-54-166-120-113.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180322 15:59:14< irker760> wesnoth/wesnoth:1.14 Iris Morelle 365fb8bdfe Update the changelog AppVeyor: 2/4 builds failed 20180322 15:59:15< irker760> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-1.14-2088 20180322 15:59:16< irker760> Details vs2017/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-1.14-1794 20180322 16:01:33-!- atarocch [~atarocch@93-36-163-158.ip61.fastwebnet.it] has quit [Ping timeout: 264 seconds] 20180322 16:22:20<+discordbot4> Hello. I'm having trouble building wesnoth, but I think I might have found a solution for https://github.com/wesnoth/wesnoth/issues/2225 . If I paste the modified file here would someone else be willing to verify that it compiles/works? 20180322 16:28:50<+discordbot4> @MiddleTwin Please use a GitHub Pull Request. Small code snippets are OK here but the full file would probabyl be ignored by most and upset a few. 20180322 16:29:00<+discordbot4> What is the issue you are having compiling? 20180322 16:30:51-!- travis-ci [~travis-ci@ec2-54-161-182-138.compute-1.amazonaws.com] has joined #wesnoth-dev 20180322 16:30:52< travis-ci> wesnoth/wesnoth#17095 (master - 8179c72 : Alexander van Gessel): The build is still failing. 20180322 16:30:52< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/356948133 20180322 16:30:52-!- travis-ci [~travis-ci@ec2-54-161-182-138.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180322 16:38:39< irker760> wesnoth/wesnoth:master Alexander van Gessel 8179c7226b Invert a conditional AppVeyor: vs2017/Release Failed 20180322 16:38:40< irker760> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-master-1799 20180322 16:39:47<+discordbot4> Alright. I wasn't sure if a PR was appropriate when the change was completely untested. Compilation issues are probably on my end; I'm trying to use mingw but I'm not very good with it. 20180322 16:41:57<+discordbot4> PRs are easier to test 20180322 16:42:19<+discordbot4> Just mention that it hasn't been in the description 20180322 16:43:16<+discordbot4> And some here use MinGW so ask if you need help. If its a Unix-y question many of us can help. 20180322 16:45:02<+discordbot4> If the CI were working, basic "at least it doesn't crash" testing would be done for you. 20180322 16:55:34< Ravana_> update all addons button caused https://i.imgur.com/lmbUame.jpg https://github.com/wesnoth/wesnoth/issues/2712 20180322 16:55:59< Ravana_> btw, seems that C:\Users\USER\Documents\My Games\Wesnoth1.13 change was not applies to other logging 20180322 17:20:44-!- atarocch [~atarocch@93.56.164.28] has joined #wesnoth-dev 20180322 17:29:58< Soliton> any clue why access was denied? 20180322 17:30:17< Soliton> perhaps installed the addon as admin or so? 20180322 17:38:51<+discordbot4> Your branch is behind 'upstream/master' by 227 commits, and can be fast-forwarded. o.O 20180322 17:40:37< Ravana_> first thought was race condition between deleting old version and adding new version 20180322 17:41:05< Ravana_> addon installed without admin context 20180322 17:41:50<+discordbot4> Whee. Mine was behind be about that and conflicting on about 60 files .. so, instead I watched it circle the drain and will re-do it once master stops changing so rapidly 20180322 17:42:20< Ravana_> I have its _info.cfg open in notepad++ but that keep in memory copy instead of locking file 20180322 17:43:29<+discordbot4> You sure? Most editors hold a write lock on the file. 20180322 17:43:45<+discordbot4> Or at least on the filename. 20180322 17:44:15< Ravana_> yes, that file is still open, it survived both deleting addon, and installing new version 20180322 17:44:37< Soliton> sounds like a likely candidate for that error. 20180322 17:45:13< Ravana_> going to verify that then 20180322 17:45:16-!- Oebele [~quassel@143.177.58.202] has joined #wesnoth-dev 20180322 17:46:20< Ravana_> not from that 20180322 17:46:42< Ravana_> opened wesnoth, opened info, updated addons, worked 20180322 17:46:59< Soliton> so you closed the file and wesnoth, reopened wesnoth and tried to install the add-on again and it still errors? 20180322 17:47:16< Soliton> oh, so the issue is gone now? 20180322 17:47:45< Ravana_> closed file, closed wesnoth, deleted cache/*, reopened wesnoth, reopened info, updated addons again, and no error this time 20180322 17:52:10< Soliton> weird stuff, not sure if that issue is of much use if you cannot reproduce it though. 20180322 17:53:15<+discordbot4> Windows or Linux? 20180322 17:54:41<+discordbot4> If it's Windows, try opening the File Explorer and browsing into your addon directory, then upgrading. Especially problematic if yoiu have a file which shows a thumbnail in the sidebar, like an image. 20180322 18:03:14< irker760> wesnoth/wesnoth:master Joseph Gelfand 3fb5f245e5 Removed overly-aggressive blitting error AppVeyor: vs2015/Release Failed 20180322 18:03:15< irker760> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-2094 20180322 18:03:40< Ravana_> windows, and file explorer was open in that addon folder for both times; file explorer has no sidebar 20180322 18:05:11< Ravana_> note that it was creating directory that failed, not deleting 20180322 18:06:41<+discordbot4> 9 times out of 10 when I have an unexplained permission denial on Windows, File Explorer has been in the scene. That, or a runaway task with no window. If Task manger can't kill them I reboot and chalk it up to windows being windows. 20180322 18:08:30< Soliton> i could imagine wesnoth deleted the dir and was not allowed to create it again because it was kept alive in some way because of some other process. 20180322 18:23:08< irker760> wesnoth/wesnoth:master Charles Dang 410398a70b Used stdlib math functions instead of gl AppVeyor: 2/4 builds failed 20180322 18:23:09< irker760> Details vs2017/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-master-1797 20180322 18:23:10< irker760> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-2091 20180322 19:15:14< irker760> wesnoth/wesnoth:master Joseph Gelfand 7e8e7833e5 Changed comment to more appropriate styl AppVeyor: vs2017/Release Failed 20180322 19:15:15< irker760> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-master-1801 20180322 19:56:11-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180322 19:59:01<+discordbot4> @Pentarctagon ^^ 20180322 20:19:32-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20180322 20:27:31-!- Bonobo [~Bonobo@203.220.138.198] has joined #wesnoth-dev 20180322 20:51:37< irker760> wesnoth/wesnoth:master Sofartin c2dccf742d Preparation for #2670 fix AppVeyor: vs2017/Release Failed 20180322 20:51:38< irker760> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-master-1802 20180322 21:19:44-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180322 21:38:39< irker760> wesnoth/wesnoth:master Alexander van Gessel 8179c7226b Invert a conditional AppVeyor: 2/4 builds failed 20180322 21:38:40< irker760> Details vs2017/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-master-1799 20180322 21:38:41< irker760> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-2093 20180322 21:45:09< galegosimpatico> <3 20180322 22:02:19-!- octalot [~steve@77.119.131.210.wireless.dyn.drei.com] has joined #wesnoth-dev 20180322 22:10:59-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180322 22:14:30-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 246 seconds] 20180322 22:15:58-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20180322 22:17:02-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180322 22:18:37-!- Oebele [~quassel@143.177.58.202] has quit [Remote host closed the connection] 20180322 22:28:11<+discordbot4> @Vultraz I'll look over the you-know-what story images during the weekend, please don't blindly throw them in yet. 20180322 22:41:42< octalot> There haven't been many fixes after 1.13.12, but would it be worth creating a 1.13.13 instead of announcing 1.13.12? 20180322 22:43:03< octalot> (The string change, fixing a bug that made EI impossible, and fixing the minimap buttons all seem like reasons for that) 20180322 22:56:22-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 268 seconds] 20180322 23:00:02< Ravana_> RC are supposed to happen often, I don't see reason to not announce 1.13.12, even if week later is next one 20180322 23:03:14< irker760> wesnoth/wesnoth:master Joseph Gelfand 3fb5f245e5 Removed overly-aggressive blitting error AppVeyor: 1/2 builds failed 20180322 23:03:15< irker760> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-2094 20180322 23:09:07<+discordbot4> @zookeeper what? 20180322 23:09:38<+discordbot4> @zookeeper oh 20180322 23:10:30<+discordbot4> Not sure what you need to look over them for 20180322 23:10:31<+discordbot4> but alright 20180322 23:34:41<+discordbot4> hey celticminstrel you around 20180322 23:44:50<+discordbot4> Oh hey Vultraz since you're here do you want to discuss https://github.com/wesnoth/wesnoth/pull/2713? I'd be interested in hearing your concerns. 20180322 23:48:48-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev 20180322 23:50:19<+discordbot4> well, first off, blit_surface is something we're trying to get rid of. 20180322 23:50:57<+discordbot4> And we're planning on doing a lot of refactoring of rendering on master so I think this only makes sense in the context of 1.14 20180322 23:50:58<+discordbot4> that said 20180322 23:51:28<+discordbot4> I'm not entirely sure whether removing the strict canvas size requirements for ~BLIT is a good thing 20180322 23:51:35<+discordbot4> certainly, they've been annoying in the past 20180322 23:51:35<+discordbot4> but 20180322 23:51:47<+discordbot4> idk 20180322 23:51:49<+discordbot4> I'm just not sure 20180322 23:58:57<+discordbot4> ah- i didn't realize you were trying to do away with blit_surface lol --- Log closed Fri Mar 23 00:00:11 2018