--- Log opened Fri Mar 23 00:00:11 2018 20180323 00:01:49< celticminstrel> Well we're not doing away with the functionality, right? 20180323 00:01:57< celticminstrel> Just implementing it in GPU instead, right? 20180323 00:02:42<+discordbot4> doing away with blit_surface the function 20180323 00:03:06< celticminstrel> IMO removing the strict canvas requirements on blit is nice, though I suppose you could offer it as an option instead of automatic (but there's really no reason you'd want an error instead of it actually working, surely?) 20180323 00:03:21<+discordbot4> that's a good point 20180323 00:03:34<+discordbot4> honestly, i dunno 20180323 00:03:52<+discordbot4> I need to finish this damn release draft today 20180323 00:03:53<+discordbot4> blah 20180323 00:04:26< celticminstrel> IMO the PR is acceptable, but the IPFs are basically getting a total rewrite anyway, so I dunno if the PR is worth it. 20180323 00:05:23<+discordbot4> Regarding the whole error instead of it working thing: I actually opened this PR because I had a blit fail and i felt like having to do a ton of cropping to make it work was kinda ridiculous 20180323 00:06:16<+discordbot4> If IPFs are getting reworked it still seems worth if 1.14 lasts nearly as long as 1.12 20180323 00:07:54< celticminstrel> I can see a point there, yeah. 20180323 00:08:05< celticminstrel> I dunno when it will get to the point that the IPFs can be reworked. 20180323 00:08:24< celticminstrel> Technically I already started on it, but it can't be merged in at this point in time. 20180323 00:08:58< celticminstrel> https://github.com/CelticMinstrel/wesnoth-ipf 20180323 00:15:14< irker760> wesnoth/wesnoth:master Joseph Gelfand 7e8e7833e5 Changed comment to more appropriate styl AppVeyor: 2/4 builds failed 20180323 00:15:15< irker760> Details vs2017/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-master-1801 20180323 00:15:16< irker760> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-2095 20180323 00:58:05-!- molgrum [~molgrum@unaffiliated/molgrum] has quit [Ping timeout: 240 seconds] 20180323 01:15:14<+discordbot4> i was gonna ask celmin something but now i forgot what it was 20180323 01:27:49< shadowm> celticminstrel: So what have you decided about the Boost requirement bump? 20180323 01:31:40< shadowm> I really want to know if we'll pass it off as an accident and revert it for RC 2/gold, or we're going to mention it in the RC 1 announcement that's currently long overdue and doesn't mention anything about the change at the moment (and neither does the changelog). 20180323 01:33:28<+discordbot4> I've been procrastinating writing about the DUnefolk changes 20180323 01:33:50<+discordbot4> You should ask your Community Manager to write your release announcements. 🤔 20180323 01:37:57<+discordbot4> I'll add the version req change after I hear back from celmin, and also the graphics stuff that's pretty important and user-visible, and then scour the changelog for whatever else might be of interest. Within the next 2 hours. 20180323 01:38:10<+discordbot4> I hope the release announcement will be out after I'm done messing with it. 20180323 01:38:57<+discordbot4> I remembered something the other day that we changed/fixed that didn't get a changelog entry 20180323 01:39:02<+discordbot4> and now I can't remember what it was 20180323 01:39:15<+discordbot4> maybe it was the image base64 stuff that was mentioned 20180323 01:40:52< celticminstrel> @Vultraz What about the Dunefolk changes? 20180323 01:41:41< celticminstrel> @shadowm I'm fine with reverting the Boost requirement bump but would prefer if someone else does the work. >_> Though I could probably do it on the weekend if no-one else wants to. 20180323 01:42:29< celticminstrel> Also I think I already looked through the changelog, but you might have a different idea of what's interesting. (Assuming we're talking about 1.13.12 announcement.) 20180323 01:42:49< celticminstrel> @Vultraz FTR I already edited mention of the Dunefolk balance tweaks into your post. 20180323 01:43:48< celticminstrel> And the Data URI thing is there too, though it seems you're correct about it missing from the changelog? 20180323 01:43:58< shadowm> celticminstrel: I literally cannot do it because I lack the required knowledge of the code and the framework it uses. 20180323 01:44:13< shadowm> We can pass it off as an accident then? 20180323 01:44:19< celticminstrel> Sure. 20180323 01:44:47< shadowm> Okay. I'll add an entry about it after I finish my dinner. 20180323 01:44:53< celticminstrel> AFAIK reverting it would basically require one of: 1) using std::unique_ptr instead of boost::optional or 2) using assignment instead of emplace and making the type in question assignable. 20180323 01:44:56< celticminstrel> The second is preferred. 20180323 01:45:33< celticminstrel> (Technically the bump was indeed an accident and then we - me, vult, jyrki - decided to make it official, not realizing that would cause problems. >_> ) 20180323 01:49:16 * celticminstrel kinda wishes someone would look at wesnoth-ipf and comment on it... though I guess there's no hurry... 20180323 01:49:57<+discordbot4> I don't understand it 20180323 01:51:37< irker760> wesnoth/wesnoth:master Sofartin c2dccf742d Preparation for #2670 fix AppVeyor: 2/4 builds failed 20180323 01:51:38< irker760> Details vs2017/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-master-1802 20180323 01:51:39< irker760> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-2096 20180323 02:00:08<+discordbot4> I also didn't really understand most of it, but I have some questions, i guess? It looks like you make a separate class that extends image_mod for every modifier and then give them all a generate_code function that's responsible for the compilation into the shader language? 20180323 02:06:32<+discordbot4> but your generate_code functions do a lot of replace_alls instead of actually writing code and im not sure why 20180323 02:22:08-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180323 02:22:10-!- molgrum [~molgrum@databur.st] has joined #wesnoth-dev 20180323 02:22:10-!- molgrum [~molgrum@databur.st] has quit [Changing host] 20180323 02:22:10-!- molgrum [~molgrum@unaffiliated/molgrum] has joined #wesnoth-dev 20180323 02:22:13-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180323 02:38:09-!- octalot [~steve@77.119.131.210.wireless.dyn.drei.com] has quit [Ping timeout: 264 seconds] 20180323 02:53:24< celticminstrel> @MiddleTwin I'm using a Wesnoth-style string formatting system there - the first argument to each replace_all is a code string, and the second is a dictionary of parameters which are substituted in. 20180323 02:57:01< celticminstrel> So for example the code for ~FL() is "$TEX_COORDS *= flip($ARG|.x, $ARG|.y);" 20180323 03:02:50<+discordbot4> oooh that makes sense 20180323 03:04:12-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Quit: wedge009] 20180323 03:23:41< celticminstrel> ...ugh, I just noticed that [random_placement]num_items uses a Lua expression. :/ 20180323 03:23:58< celticminstrel> But I guess it's too late to change it now? 20180323 03:24:20< celticminstrel> Would much prefer it uses the standard WFL interpolation (as seen extensively in GUI2). 20180323 03:24:38< celticminstrel> (That is, if enclosed in parentheses, it's a formula; otherwise it's a number.) 20180323 03:25:12< celticminstrel> I understand why it's like this (WFL evaluation from Lua wasn't possible back when it was made), but it's still annoying that no-one remembered it all this time. 20180323 03:33:51-!- Bonobo [~Bonobo@203.220.138.198] has quit [Ping timeout: 240 seconds] 20180323 03:37:42-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20180323 03:47:15< celticminstrel> So no-one thought to make [village] accept location_id? :| 20180323 03:47:25< celticminstrel> Or did they allow it and just didn't document it? 20180323 03:49:27< celticminstrel> Yup no-one bothered. :| 20180323 03:53:25-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev 20180323 04:05:09-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180323 04:05:15-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180323 04:13:04-!- Bonobo [~Bonobo@129.127.113.241] has joined #wesnoth-dev 20180323 04:16:39-!- higgins [~higgins@68.ip-149-56-14.net] has quit [Quit: Leaving] 20180323 04:20:01-!- higgins [~higgins@68.ip-149-56-14.net] has joined #wesnoth-dev 20180323 04:30:03<+discordbot4> https://cdn.discordapp.com/attachments/259976436490829825/426598476827066370/unknown.png 20180323 04:31:36<+discordbot4> https://github.com/wesnoth/wesnoth/pull/2711 has issues with both Codacy and Appveyor behaving unexpectedly (the latter seems to have link-time issues involving OpenSSL). 20180323 04:32:01<+discordbot4> @Vultraz The main thing I needed you to review is the fact that the PR breaks the string freeze. 20180323 04:32:26<+discordbot4> You or I might need to email the i18n ML if you decide it's worth it. 20180323 04:32:33<+discordbot4> Codact I can fix. AppVeyor probably needs the OpenSSL refreshed 20180323 04:32:34<+discordbot4> Alternatively, I can back out that particular change. 20180323 04:33:20<+discordbot4> @Pentarctagon will need to update the 'external' kit in the packages 20180323 04:33:23<+discordbot4> hmmmmmmmmmm 20180323 04:33:45<+discordbot4> You can re-read my explanation of the string freeze break to see why it might be worth it. 20180323 04:34:07<+discordbot4> I rather already committed a minor infraction of the string freeze by changing PNG to JPG. 20180323 04:34:11<+discordbot4> in version info. 20180323 04:34:16<+discordbot4> Wait. 20180323 04:34:18<+discordbot4> WHat. 20180323 04:34:26<+discordbot4> Codacy should be analysing 1.14 now 20180323 04:34:34<+discordbot4> Thanks 20180323 04:35:11<+discordbot4> Well. 20180323 04:35:12<+discordbot4> I just hit the libeay vs libcrypto issue myself. Just needs a refresh. 20180323 04:35:25<+discordbot4> I guess the string freeze under vultraz's administration is as soft as talcum powder. 20180323 04:35:30<+discordbot4> I should have added that to pofix, actually. 20180323 04:35:39<+discordbot4> Just saw that the aforementioned change took place at 386 commits past 1.13.11. 20180323 04:36:25<+discordbot4> I guess now I'm even more disappointed it says JPG instead of JPEG. :p 20180323 04:36:53<+discordbot4> That can be pofixed, for sure. PNG vs. JPEG? Not entirely certain. 20180323 04:37:28<+discordbot4> For all I know there might be some weird language out there where a different inflection is needed depending on whether the format is PNG or JPEG. 20180323 04:38:26<+discordbot4> To recap, this is the affected string in #2711: https://github.com/wesnoth/wesnoth/pull/2711/files#diff-8dd74f653e8c20d19565e37121f74e9fR1790 20180323 04:38:53<+discordbot4> Um. 20180323 04:39:13<+discordbot4> The anchor is all wrong. Look at line 1790 of src/units/unit.cpp is what I'm trying to say. 20180323 04:39:48<+discordbot4> I guess technically it's not a particularly visible string. 20180323 04:40:19<+discordbot4> I reckon these are composed into a tooltip that only appears when hovering on parts of the unit preview on the sidebar? 20180323 04:54:02-!- irker760 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout] 20180323 04:54:04< celticminstrel> IMO a change from PNG -> JPG shouldn't really be pofixed. 20180323 04:54:56< celticminstrel> And yeah this goes in the sidebar when hovering over a trait. 20180323 04:56:33< celticminstrel> But I should be asleep by now. 20180323 04:56:37-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The computer falls into a deep sleep, to awake again some other day!] 20180323 04:57:41-!- irker073 [~irker@uruz.ai0867.net] has joined #wesnoth-dev 20180323 04:57:42< irker073> wesnoth: Charles Dang wesnoth:master b6c4f0f6aefc / src/ (display.cpp display.hpp editor/controller/editor_controller.cpp): Display: removed redraw observer interface https://github.com/wesnoth/wesnoth/commit/b6c4f0f6aefcf2d4f16ee91400039b4de5e8d137 20180323 04:57:42< irker073> wesnoth: Charles Dang wesnoth:master 7a9ed8d3631c / src/ (6 files in 6 dirs): Used UNUSED macro instead of (void) where applicable https://github.com/wesnoth/wesnoth/commit/7a9ed8d3631cecc7053ed91b2501d6d145d7a4cd 20180323 05:14:45-!- Bonobo [~Bonobo@129.127.113.241] has quit [Ping timeout: 263 seconds] 20180323 05:16:03<+discordbot4> @Vultraz Kind of need to know your opinion before merging. 20180323 05:16:37<+discordbot4> It's minor, and you said I already broke the freeze in the screenshot dialog, and when you also consider PNG -> JPG, why not, just merge 20180323 05:17:36<+discordbot4> @jyrkive I added a section to the RC 1 announcement draft explaining the totally-inconspicuous change to file/dir access semantics in WML/Lua. You might want to eye it over to make sure I understood correctly what it is. 20180323 05:18:20<+discordbot4> @Tad Carlucci I need to update the what? 20180323 05:18:22<+discordbot4> @Vultraz I added a section mentioning the Boost 1.56 mess-up and a section on UI, graphics, and sound improvements, and a section on JPEG screenshots support, and expanded the multiplayer section just a tiny bit. 20180323 05:18:36<+discordbot4> mein gott 20180323 05:18:39<+discordbot4> thanks! 20180323 05:19:52<+discordbot4> @Pentarctagon nevermind. I just realized it's Windows not Linux 20180323 05:20:01<+discordbot4> Don't expect much in the MP section, I just added a single item as filler so it doesn't seem like it's all Dunefolk. 20180323 05:20:57<+discordbot4> I just added a couple lines about the Dunefolk renaming 20180323 05:23:53<+discordbot4> @shadowm Where was that AppVeyor failure for your PR on 1.14? Did it send a message to IRC so I can take a look at the logs? 20180323 05:24:31<+discordbot4> https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-1.14-1794 20180323 05:24:43<+discordbot4> I got this link from the PR page on GitHub at least. 20180323 05:25:37<+discordbot4> The IRC notifications has these two links: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-1.14-2088 https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-1.14-1794 20180323 05:25:59<+discordbot4> Good enough the name of the library was libeay .. from OpenSSL 0.98 or some such. The new name is libcrypto. 20180323 05:26:19<+discordbot4> So the 1.14 project file needs updating. 20180323 05:26:24<+discordbot4> @shadowm I rewrote the description of the security fix. 20180323 05:26:35<+discordbot4> Yeah, that library name made me raise an eyebrow. 20180323 05:26:56<+discordbot4> It ignores _server.ign files, and blocks access to the files even if the developers attempts to include them as images or whatever. 20180323 05:27:19<+discordbot4> Ahhh, okay. 20180323 05:28:02<+discordbot4> if you're editing the post right now, "Heavy Infrantryment" 20180323 05:28:31<+discordbot4> I'm editing it right now. 20180323 05:28:44<+discordbot4> Need to do a small grammar fix to the rewritten description of the security fix. 20180323 05:29:32<+discordbot4> @jyrkive Can you git @shadowm a PR to merge to her PR 2711 updating the VS project file for libcrypto? 20180323 05:29:45<+discordbot4> @Vultraz Done both. 20180323 05:30:17<+discordbot4> @Tad Carlucci I can do that in the evening (about 12 hours from now). I'm too tired to do it now. 20180323 05:30:33<+discordbot4> np for me. 20180323 05:30:59<+discordbot4> (A PR to merge to my PR?) 20180323 05:31:13<+discordbot4> I mean, we can just ignore that issue and merge. 20180323 05:31:43<+discordbot4> I'll need @loonycyborg to run a pot-update before I announce the break in the i18n ML though. 20180323 05:31:45<+discordbot4> That works too 20180323 05:32:10<+discordbot4> He told me it's just scons pot-update but I just want to make sure that's the full story. 20180323 05:32:46<+discordbot4> I assumed your complaint was that AppVeypor failed. But you told Travis to skip the run so it was noise because you don't care about CI. 20180323 05:32:59<+discordbot4> @shadowm Khalifate were renamed to Dunefolk last release 20180323 05:33:06<+discordbot4> I only had [ci skip] on the second commit since it's a changelog commit. 20180323 05:33:24<+discordbot4> @jyrkive OK. So she doesn't need it and is goina to merge without a CI run. Thanks anyway. 20180323 05:33:49<+discordbot4> @Vultraz I know. Why are you telling me this? 😛 20180323 05:33:59<+discordbot4> I didn't add that line, it was already there. 20180323 05:34:00<+discordbot4> because someone put it in the post 20180323 05:34:05<+discordbot4> That was me 20180323 05:34:14<+discordbot4> Because it wasn't in the last release notes 20180323 05:34:16<+discordbot4> Yeah, he mentioned something about telling people what you didn't tell them last time. 20180323 05:34:25<+discordbot4> oh 20180323 05:34:27<+discordbot4> k 20180323 05:36:34<+discordbot4> Still want to check Travis, hang on. 20180323 05:36:50<+discordbot4> Oh yeah, Travis passed on my PR, good. 20180323 05:37:37< irker073> wesnoth/wesnoth:master Charles Dang 7a9ed8d363 Used UNUSED macro instead of (void) wher AppVeyor: vs2017/Release Failed 20180323 05:37:38< irker073> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-master-1803 20180323 05:37:44<+discordbot4> @shadowm In that case, if the error is just linking to libeay instead of the new libcrypto Windows should be fine. 20180323 05:37:53< irker073> wesnoth: Iris Morelle wesnoth:1.14 69c28e5088b6 / src/ (39 files in 15 dirs): Replace all instances of naked vgettext() calls with VGETTEXT() https://github.com/wesnoth/wesnoth/commit/69c28e5088b6a9624e08c72be510e0a670d030f0 20180323 05:37:56< irker073> wesnoth: Iris Morelle wesnoth:1.14 96032f978c43 / changelog.md: Update the changelog https://github.com/wesnoth/wesnoth/commit/96032f978c431525267c75d0e6781e97608145a1 20180323 05:40:16-!- travis-ci [~travis-ci@ec2-54-163-180-75.compute-1.amazonaws.com] has joined #wesnoth-dev 20180323 05:40:17< travis-ci> wesnoth/wesnoth#17099 (master - 7a9ed8d : Charles Dang): The build is still failing. 20180323 05:40:17< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/357235578 20180323 05:40:17-!- travis-ci [~travis-ci@ec2-54-163-180-75.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180323 05:53:11<+discordbot4> 20180323 02:53:02 error general: Error while reading the WML: Mandatory WML child missing yet untested for. Please report. 20180323 05:53:22<+discordbot4> The tutorial campaign seems to be doing great on master. 20180323 05:54:27<+discordbot4> https://cdn.discordapp.com/attachments/259976436490829825/426619716430331904/unknown.png 20180323 05:55:05<+discordbot4> Ignoring for a moment the fact that I can relive the glory days of non-composited Windows on my Wesnoth build for Linux, 20180323 05:55:16<+discordbot4> @Vultraz Are you aware of the front issue? 20180323 05:55:39<+discordbot4> on master? 20180323 05:55:47<+discordbot4> Yes, this is master. 20180323 05:55:59<+discordbot4> No, this is Patrick. 20180323 05:56:12<+discordbot4> (yes) 20180323 05:56:13<+discordbot4> The popup menus have a font rendering issue that isn't present on 1.14, I assume it's related to the a_r changes. 20180323 05:56:28<+discordbot4> all text does 20180323 05:56:28<+discordbot4> Ah okay, just wanted to make sure it wasn't one of those platform-specific things you'll inevitably miss. 20180323 05:56:39<+discordbot4> Nah, the menu buttons look fine. 20180323 05:56:52<+discordbot4> Well, actually, yes, button text looks fine 20180323 05:56:54<+discordbot4> it's all other text 20180323 06:02:07<+discordbot4> has taken a detour and almost successfully refactored out the use of boost::mpl from GUI2's dispatcher 20180323 06:02:47-!- travis-ci [~travis-ci@ec2-54-166-12-172.compute-1.amazonaws.com] has joined #wesnoth-dev 20180323 06:02:48< travis-ci> Pentarctagon/wesnoth#342 (xcode-travis-remove-g - e16b541 : pentarctagon): The build was canceled. 20180323 06:02:48< travis-ci> Build details : https://travis-ci.org/Pentarctagon/wesnoth/builds/357241410 20180323 06:02:49-!- travis-ci [~travis-ci@ec2-54-166-12-172.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180323 06:03:33<+discordbot4> All hail the great constexpr 20180323 06:05:35<+discordbot4> I swear mordante must have been a robot to code some of this, though. 20180323 06:08:41<+discordbot4> 20180323 03:08:22 warning deprecation: helper.set_wml_tag_metatable has been deprecated and may be removed at any time. (Nota: Sería mejor que usara wml.tag en el nuevo código) 20180323 06:08:55<+discordbot4> Somehow I'm still getting an untranslated string here... 20180323 06:09:20-!- travis-ci [~travis-ci@ec2-54-166-12-172.compute-1.amazonaws.com] has joined #wesnoth-dev 20180323 06:09:21< travis-ci> wesnoth/wesnoth#17100 (1.14 - 69c28e5 : Iris Morelle): The build passed. 20180323 06:09:21< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/357243519 20180323 06:09:21-!- travis-ci [~travis-ci@ec2-54-166-12-172.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180323 06:09:25<+discordbot4> D'oh. 20180323 06:09:38<+discordbot4> My 1.14 branch is behind my PR merge. 20180323 06:11:13<+discordbot4> What. 20180323 06:11:23<+discordbot4> I'm still getting that first line untranslated. 20180323 06:11:46<+discordbot4> ...did you build? 20180323 06:11:51<+discordbot4> Yes. 20180323 06:11:58<+discordbot4> The MP match name is correctly translated now. 20180323 06:12:26-!- travis-ci [~travis-ci@ec2-54-163-180-75.compute-1.amazonaws.com] has joined #wesnoth-dev 20180323 06:12:27< travis-ci> Pentarctagon/wesnoth#343 (xcode-travis-remove-g - 6ae1e81 : pentarctagon): The build was canceled. 20180323 06:12:28< travis-ci> Build details : https://travis-ci.org/Pentarctagon/wesnoth/builds/357248925 20180323 06:12:28-!- travis-ci [~travis-ci@ec2-54-163-180-75.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180323 06:13:37<+discordbot4> #: src/deprecation.cpp:47 msgid "$elem has been deprecated and may be removed in version $version." msgstr "$elem ha sido excluido y podría ser eliminado en la versión $version." 20180323 06:13:44<+discordbot4> It's definitely there and not fuzzy. 20180323 06:13:50<+discordbot4> looks like I can't use static_assert in a constexpr function that's also invoked at runtime 20180323 06:13:51<+discordbot4> 🤔 20180323 06:15:04<+discordbot4> well, that does make sense 20180323 06:15:42<+discordbot4> huh. commenting that out didn't work, actually. 20180323 06:17:17<+discordbot4> wth 20180323 06:18:07<+discordbot4> Oh for the love of 20180323 06:18:20<+discordbot4> hmm? 20180323 06:18:26<+discordbot4> VGETTEXT() calls the version with a forced textdomain is GETTEXT_DOMAIN hasn't been defined. 20180323 06:18:42<+discordbot4> This is controlled by an #ifdef. 20180323 06:19:10<+discordbot4> src/deprecation.cpp includes fornula/string_utils.hpp before gettext.hpp so GETTEXT_DOMAIN is not defined at that point. 20180323 06:19:25<+discordbot4> Therefore we get the neutered version of VGETTEXT() that forces the wesnoth-lib textdomain. 20180323 06:20:11<+discordbot4> Would it kill people if I just made sure formula/string_utils.hpp includes gettext.hpp to get the GETTEXT_DOMAIN defaults sorted out? 20180323 06:20:32<+discordbot4> no 20180323 06:20:32-!- travis-ci [~travis-ci@ec2-54-166-12-172.compute-1.amazonaws.com] has joined #wesnoth-dev 20180323 06:20:33< travis-ci> Pentarctagon/wesnoth#343 (xcode-travis-remove-g - 6ae1e81 : pentarctagon): The build was canceled. 20180323 06:20:33< travis-ci> Build details : https://travis-ci.org/Pentarctagon/wesnoth/builds/357248925 20180323 06:20:34-!- travis-ci [~travis-ci@ec2-54-166-12-172.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180323 06:20:48<+discordbot4> Or to put it another way, is there anywhere that file is used where we might not want gettext.hpp pulled in for some reason? 20180323 06:21:10<+discordbot4> not that I know of 20180323 06:22:04<+discordbot4> There's another angle for this issue. 20180323 06:22:21<+discordbot4> One could say that it just doesn't make sense that formula/string_utils.cpp wants the wesnoth-lib textdomain for itself. 20180323 06:22:36<+discordbot4> Ugh. 20180323 06:22:43<+discordbot4> Okay, it does make use of translatable strings itself. 20180323 06:22:58<+discordbot4> the format_conjunct_list()/format_disjunct_list() functions in particular. 20180323 06:23:21<+discordbot4> is reminded once again of her old proposal to merge wesnoth and wesnoth-lib 20180323 06:24:12<+discordbot4> Primarily (but not solely) thanks to the integration of the map editor into the main game, and then the advent of GUI2, the textdomain segregation just doesn't make sense. 20180323 06:24:38<+discordbot4> Nobody even knows why something should belong in either textdomain since that has never been documented. 20180323 06:25:22<+discordbot4> That is true 20180323 06:25:25<+discordbot4> I certainly don't 20180323 06:26:07<+discordbot4> Firstly, both WML and C++ default to wesnoth. This has always been the case. Thanks to wmllint, a multitude of WML files also explicitly request wesnoth. 20180323 06:26:35<+discordbot4> So it's never been about i18n in C++ vs. WML. 20180323 06:27:26<+discordbot4> I do remember that wesnoth-lib used to be preferred (or required?) for stuff that was actually part of the Wesnoth library that was statically linked against both the game and the editor, back when the editor was a separate executable target entirely. 20180323 06:28:38<+discordbot4> 1.5.x dropped the game/editor divide when Editor2 was finished, and also introduced GUI2, which exclusively added strings to wesnoth-lib. 20180323 06:29:10<+discordbot4> Even though one of the first GUI2 dialogs was not part of the editor, it was part of the game -- the WML [message] dialog. 20180323 06:30:51<+discordbot4> Although I do know that it used to be possible to build either the game, the editor, the MP server, or the add-ons server independently and without enabling the others (yes, you could enable only the editor and leave everything else out), I somehow don't think the build toolchain was smart enough to avoid compiling the wesnoth textdomain catalogues if the game was disabled. 20180323 06:31:47<+discordbot4> The bottomline is wesnoth vs. wesnoth-lib feels like a relic of the past that's causing more trouble for everyone (including translators) than it's worth, and it only serves as an arbitrary categorization. 20180323 06:32:12<+discordbot4> (There are strings that appear in both textdomains, I'm pretty sure.) 20180323 06:32:55-!- travis-ci [~travis-ci@ec2-54-163-180-75.compute-1.amazonaws.com] has joined #wesnoth-dev 20180323 06:32:56< travis-ci> Pentarctagon/wesnoth#344 (xcode-travis-remove-g - a544b85 : pentarctagon): The build was canceled. 20180323 06:32:56< travis-ci> Build details : https://travis-ci.org/Pentarctagon/wesnoth/builds/357253177 20180323 06:32:56-!- travis-ci [~travis-ci@ec2-54-163-180-75.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180323 06:35:22<+discordbot4> But yeah, forcinggettext.hpp to be included first to get GETTEXT_DOMAIN defined solves that punctual issue. 20180323 06:35:52<+discordbot4> Now to make sure there aren't any files defining a custom GETTEXT_DOMAIN after including formula/string_utils.hpp and before including gettext.hpp for some stupid reason... 20180323 06:41:09<+discordbot4> Apparently not. 20180323 06:42:44<+discordbot4> At least based on a search using this: perl #!/usr/bin/env perl use strict; use warnings; my $have_string_utils = 0; while(<>) { exit $have_string_utils if /#\s*define\s+GETTEXT_DOMAIN/; /formula\/string_utils\.hpp/ and $have_string_utils = 1; } 0; 20180323 06:43:42<+discordbot4> It's been literally 5 years since I last used Perl, I don't know why I'm using it again as of late. 20180323 06:45:32< irker073> wesnoth/wesnoth:1.14 Iris Morelle 96032f978c Update the changelog AppVeyor: vs2015/Release Failed 20180323 06:45:33< irker073> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-1.14-2098 20180323 06:52:48<+discordbot4> @jyrkive do you know why a static_assert will always be evaluated if using a plain if() block inside a constexpr function, but not if using if constexpr()? 20180323 06:53:04<+discordbot4> Inside that same constexpr function, I mean 20180323 06:53:47< irker073> wesnoth: Iris Morelle wesnoth:1.14 dbac6e4e08f3 / src/formula/string_utils.hpp: i18n: Forcefully pull gettext.hpp into formula/string_utils.hpp https://github.com/wesnoth/wesnoth/commit/dbac6e4e08f304f113538cd637868fb4544df71a 20180323 06:53:50< irker073> wesnoth: Iris Morelle wesnoth:1.14 26b327485d3a / src/formula/string_utils.hpp: i18n: Make VGETTEXT()/VNGETTEXT() always require a GETTEXT_DOMAIN to be defined https://github.com/wesnoth/wesnoth/commit/26b327485d3a79b9ace043b6fd4c575527dc321d 20180323 06:54:32<+discordbot4> Finally I can work on porting this set to master. 20180323 06:55:18<+discordbot4> I may be wrong, but my testing seemed to indicate that: constexpr bool foo(const bool bar) { if(bar) { static_assert(false, ""); } } Will always fail. Whereas: constexpr bool foo(const bool bar) { if constexpr(bar) { static_assert(false, ""); } } Will fail only if bar is indeed false. 20180323 06:56:01<+discordbot4> @jyrkive is that correct, or am I mistaken? and if so, how come? 20180323 06:57:23<+discordbot4> gettext.hpp has this: cpp #if defined(__GNUCC__) || defined(__clang__) || defined(__MINGW32__) #define UNUSEDNOWARN __attribute__((unused)) #else #define UNUSEDNOWARN #endif 20180323 06:57:35<+discordbot4> This really feels like it belongs in a global header elsewhere. 20180323 06:57:55<+discordbot4> (I'm getting a feeling of déjà vu from pointing this out.) 20180323 06:58:46<+discordbot4> Uhhh we have UNUSED 20180323 06:58:58<+discordbot4> that just aliases to (void) 20180323 06:59:01<+discordbot4> Why is that there? 20180323 06:59:28<+discordbot4> ¯_(ツ)_/¯ 20180323 07:00:22<+discordbot4> O 20180323 07:00:49<+discordbot4> People are using translation::compare() and translation::icompare() in threaded code? 20180323 07:01:11<+discordbot4> I see both randomly gained a mutex acquire at some point. 20180323 07:01:16<+discordbot4> Presumably that’s why gfgtdf added the locks 20180323 07:01:49<+discordbot4> He did say perhaps we should only lock it if we actually have more than one thread 20180323 07:03:03<+discordbot4> Yeah, I see basically all translation namespace functions make a provision for concurrent calls for some reason. 20180323 07:03:19<+discordbot4> He randomly added it to possibly fix some crash 20180323 07:03:24<+discordbot4> Not sure which one it was now 20180323 07:03:37<+discordbot4> Some very hard t reproduced bug 20180323 07:03:42<+discordbot4> Some of them do it after a call to the logging facilities though. 20180323 07:03:45<+discordbot4> (???) 20180323 07:03:46<+discordbot4> He said this would likely fix it 20180323 07:03:59<+discordbot4> Oh great, voodoo fixes. 20180323 07:04:37<+discordbot4> Why is translation::init() a thing? It's literally a no-op function. 20180323 07:05:25<+discordbot4> Oh, let me guess. It wasn't in the libintl-based implementation that no longer exists. 20180323 07:05:46<+discordbot4> It probably did something magical and amazing and convoluted then. 20180323 07:06:06<+discordbot4> Probably 20180323 07:06:43<+discordbot4> Actually, that's not it. 20180323 07:07:02<+discordbot4> I mean, yes, that's it. 20180323 07:07:27<+discordbot4> But it was just a call to std::set_locale(LC_MESSAGES, "") when running on POSIX. 20180323 07:19:18<+discordbot4> I'll just dispense with the static assert for now 20180323 07:19:23<+discordbot4> can't get it working.. 20180323 07:27:23< irker073> wesnoth: Iris Morelle wesnoth:master c5b3947e4a83 / src/ (39 files in 15 dirs): Replace all instances of naked vgettext() calls with VGETTEXT() https://github.com/wesnoth/wesnoth/commit/c5b3947e4a837dc98868e3b2c3fa55668fec27a4 20180323 07:27:26< irker073> wesnoth: Iris Morelle wesnoth:master 5c28dcaab66e / src/formula/string_utils.hpp: i18n: Forcefully pull gettext.hpp into formula/string_utils.hpp https://github.com/wesnoth/wesnoth/commit/5c28dcaab66e34af718c7ceff6ccc9e33b58b039 20180323 07:27:29< irker073> wesnoth: Iris Morelle wesnoth:master a60239116863 / src/formula/string_utils.hpp: i18n: Make VGETTEXT()/VNGETTEXT() always require a GETTEXT_DOMAIN to be defined https://github.com/wesnoth/wesnoth/commit/a60239116863ea7592d27f2819017b57a34e0ce5 20180323 07:27:32< irker073> wesnoth: Iris Morelle wesnoth:master 94c5f64cc624 / src/ (gettext.hpp gettext_boost.cpp tests/utils/game_config_manager.cpp wesnoth.cpp): i18n: Remove no-op translation::init() function https://github.com/wesnoth/wesnoth/commit/94c5f64cc62452f420a9886eefc75d5e4af121fc 20180323 07:28:06<+discordbot4> did that have any effect on the mysteriously not-translated "random faction matchups" string? 20180323 07:28:16<+discordbot4> No. 20180323 07:28:46<+discordbot4> I spotted the string in the code wrapped in a no-op N_(), so that might have something to do with it though. 20180323 07:29:07<+discordbot4> Haven't looked into it to see if the N_() is justified and if so where the gettext call should be. 20180323 07:29:58<+discordbot4> @Vultraz See https://stackoverflow.com/questions/26582875/constexpr-function-parameters-as-template-arguments 20180323 07:30:10<+discordbot4> I can tell you that this might've fixed many more cases of untranslated interpolated strings than I thought at first, but I'm too lazy to do a script to check exactly how many those would be. 20180323 07:30:38<+discordbot4> This highlights another problem we have right now though. 20180323 07:30:45<+discordbot4> The compiler can't know that the parameters are always constant expressions, and therefore has to fail the build if you use static_assert(false) inside the function. 20180323 07:31:11<+discordbot4> Translators clearly do not have time to test their translations, otherwise posts like this wouldn't happen so late in the cycle: https://forums.wesnoth.org/viewtopic.php?f=7&p=624993#p624993 20180323 07:31:15<+discordbot4> As a workaround, you can use template parameters instead (since they can't be determined at runtime). 20180323 07:31:49<+discordbot4> We have several active translation teams and none of them reported the bugs in #2709. 20180323 07:32:12<+discordbot4> Or the bugs that #2711 fixes. 20180323 07:32:25<+discordbot4> (At least I couldn't find any bugs with the Translation tag that were obviously related.) 20180323 07:32:59<+discordbot4> @jyrkive so you mean instead of: 20180323 07:33:19<+discordbot4> So basically I wouldn't have found any of this if I didn't have a slight distrust of the Spanish translation team's work and decided to test with the Spanish translation selected. 20180323 07:33:20< irker073> wesnoth/wesnoth:1.14 Iris Morelle 26b327485d i18n: Make VGETTEXT()/VNGETTEXT() always AppVeyor: vs2015/Release Failed 20180323 07:33:21< irker073> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-1.14-2099 20180323 07:33:28<+discordbot4> constexpr bool is_general_event(const ui_event event) I use template constexpr bool is_general_event() 20180323 07:33:29<+discordbot4> ? 20180323 07:33:40<+discordbot4> Yes. 20180323 07:33:45<+discordbot4> Hm. 20180323 07:33:48<+discordbot4> (You'll note I posted a couple dozen of corrections to that thread too.) 20180323 07:34:00<+discordbot4> But then I won't be able to use these functions for the runtime test too. 20180323 07:34:27<+discordbot4> If you need the assertion to fire at runtime, you can't use static_assert. 20180323 07:34:37<+discordbot4> Use a plain assert instead. 20180323 07:35:17<+discordbot4> heh. Actually, the runtime usecase is an assert 😛 20180323 07:35:37< irker073> wesnoth: Iris Morelle wesnoth:master 9d76278e7137 / changelog.md: Update the changelog https://github.com/wesnoth/wesnoth/commit/9d76278e71375257d528df91e82a6156b61f5a45 20180323 07:39:15<+discordbot4> src/mp_game_settings.hpp:68: (NO_ALLY_MIRROR, N_("No Ally Mirror")) 20180323 07:39:27<+discordbot4> The no-op call I was talking about. 20180323 07:39:34<+discordbot4> that's not the header 20180323 07:39:37<+discordbot4> er 20180323 07:39:39<+discordbot4> I mean 20180323 07:39:41<+discordbot4> That's the header Vultraz. 20180323 07:39:44<+discordbot4> I mean 20180323 07:39:45<+discordbot4> I MEAN 20180323 07:39:59<+discordbot4> that's not where the string from above the menu box is 20180323 07:40:01<+discordbot4> That's part of a MAKE_ENUM, but that's not the point. 20180323 07:40:11<+discordbot4> Yes, that's the only place whence it can come in mainline. 20180323 07:40:12<+discordbot4> that's its contents 20180323 07:40:19<+discordbot4> 04:38:58 shadowm@hanacore ~/src/wesnoth-1.14 git:1.14 % fgrep -nRI 'No Ally Mirror' src src/mp_game_settings.hpp:68: (NO_ALLY_MIRROR, N_("No Ally Mirror")) src/gui/dialogs/multiplayer/mp_create_game.cpp:278: rfm_options[2]["tooltip"] = _("No Ally Mirror: No two allied players will get the same faction"); 20180323 07:40:33<+discordbot4> The second place has a longer string that just happens to contain the other as a substring. 20180323 07:40:36<+discordbot4> you told me that the label about that widget was untranslated 20180323 07:40:45<+discordbot4> above* 20180323 07:40:50<+discordbot4> I said the contents were untranslated. 20180323 07:41:06<+discordbot4> https://github.com/wesnoth/wesnoth/issues/2709 20180323 07:41:22<+discordbot4> "Textdomain wesnoth-lib Random Faction Matchups:" 20180323 07:41:25<+discordbot4> Oh hey, "Random Faction Matchups:" was magically fixed. 20180323 07:41:41<+discordbot4> hell, now that I look again, that's even translated in your screenshot 20180323 07:41:43<+discordbot4> what gives 20180323 07:41:49<+discordbot4> ("Eras:" isn't, though) 20180323 07:41:59<+discordbot4> Wut. 20180323 07:42:07<+discordbot4> I misread my own screenshot. 20180323 07:42:16<+discordbot4> I'll remove it from the OP. 20180323 07:42:51<+discordbot4> Also, Eras is translated. 20180323 07:42:59<+discordbot4> It's just that "Eras" translates to "Eras". 20180323 07:43:03<+discordbot4> oh 20180323 07:43:29<+discordbot4> Anyway, my point is that clearly the members of that MAKE_ENUM need to be manually gettext'd somewhere and they are not. 20180323 07:43:52<+discordbot4> Added a strikethrough for the game name entry 20180323 07:44:14<+discordbot4> I suspect you can figure out where that would be needed faster than me since you were involved in the MP UI rewrite. Extensively. 20180323 07:44:22<+discordbot4> I know where 20180323 07:44:27<+discordbot4> "involved" 20180323 07:44:29<+discordbot4> it was all me 😐 20180323 07:44:40<+discordbot4> well, actually no, gfgtdf did a few things 20180323 07:44:45<+discordbot4> but it was 95% me 20180323 07:45:15<+discordbot4> here 20180323 07:45:18<+discordbot4> rfm_options.emplace_back(config {"label", mp_game_settings::RANDOM_FACTION_MODE::enum_to_string(type)}); 20180323 07:45:23<+discordbot4> what function do I need? 20180323 07:45:24<+discordbot4> Hence extensively. 20180323 07:46:10<+discordbot4> translation::sgettext() I believe. 20180323 07:47:11<+discordbot4> The difference with translation::gettext() is that the latter does not handle disambiguation prefixes specially. 20180323 07:47:48<+discordbot4> (That's what I can see from a cursory glance at the code, at least. Don't quote me on it.) 20180323 07:48:05<+discordbot4> honestly, MP Create Game is probably the dialog I'm most proud of 20180323 07:48:09<+discordbot4> (Figures that the most crucial functions in the whole codebase are undocumented.) 20180323 07:48:24<+discordbot4> you have no idea how long it took to get just right 20180323 07:48:46<+discordbot4> but it just looks so fucking good 20180323 07:49:28<+discordbot4> 04:49:13 shadowm@hanacore ~/src/wesnoth-1.14 git:1.14 % fgrep -nRI '"Search"' src data/gui src/menu_events.cpp:997: msg << _("Search"); 20180323 07:49:30<+discordbot4> Mhm. 20180323 07:49:50<+discordbot4> not that one 20180323 07:49:57<+discordbot4> it's in data/gui/widget/text_box 20180323 07:50:00<+discordbot4> Well, it's the only i 20180323 07:50:03<+discordbot4> What? 20180323 07:50:13<+discordbot4> But... I did look in data/gui. 20180323 07:50:43<+discordbot4> Oh my god, I see why. 20180323 07:50:46<+discordbot4> It's part of a formula. 20180323 07:50:47<+discordbot4> text = "(if(text = '', 'Search', ''))" 20180323 07:51:08<+discordbot4> This is kind of an issue. 20180323 07:51:22<+discordbot4> Can you propagate a formula variable to that with the translated string from the C++? 20180323 07:51:27<+discordbot4> tbh not exactly sure why this works without the else clause being text 20180323 07:52:03<+discordbot4> i could, probably, yes 20180323 07:52:31<+discordbot4> You could either piggy-back on the "Search" string in src/menu_events.cpp (textdomain wesnoth) or... break the string freeze again for a duplicate string. 20180323 07:52:59<+discordbot4> There isn't any way to define variables for the canvas formulas in WML alone, is there? 20180323 07:53:01<+discordbot4> why is my computer so laggy today 20180323 07:53:19<+discordbot4> usually i can do stuff while i build 20180323 07:53:46<+discordbot4> Also, as long as translators do not insert characters that would break the formula, the fix is as easy as this: text = "(if(text = '', '"+_"Search"+"', ''))" 20180323 07:54:02<+discordbot4> With a preceding #textdomain wesnoth hack maybe. 20180323 07:54:34<+discordbot4> This is obviously hacky and if a translator needs to insert an ASCII apostrophe there the whole thing will go boom though. 20180323 07:54:49< irker073> wesnoth: Charles Dang wesnoth:master 57700090d898 / src/gui/core/event/ (dispatcher.cpp dispatcher.hpp): GUI2: reimplemented [dis]connect_signal SFINAE using constexpr functions https://github.com/wesnoth/wesnoth/commit/57700090d898d90766c7b0849020f9af696c55ed 20180323 07:56:21<+discordbot4> Also, I was on mobile so I couldn't take a closer look, and now I can't because I'm about to fall asleep, but 20180323 07:56:39<+discordbot4> https://github.com/wesnoth/wesnoth/issues/2709#issuecomment-375266869 I'm curious exactly how that change is supposed to fix things. 20180323 07:57:04<+discordbot4> wouldn't it? 20180323 07:57:15<+discordbot4> Is this another case of a no-op gettext string being thrown around and eventually ending up gettexted from the wrong textdomain? 20180323 07:58:03<+discordbot4> no, just that there were translatable strings in those files and no textdomain declaration 20180323 07:58:25<+discordbot4> That means they were in the wesnoth textdomain by default. 20180323 07:58:37<+discordbot4> They should still work unless the engine is doing something weird to them. 20180323 07:59:06<+discordbot4> (Also, the WML fix doesn't make a difference but that might be because there's not been a pot-update in master and the Spanish catalogues still have those strings in the wesnoth textdomain, not wesnoth-lib.) 20180323 07:59:54<+discordbot4> starting to like your idea of merging wesnoth and wesnoth-lib 20180323 08:00:51<+discordbot4> ... Actually... 20180323 08:01:36<+discordbot4> Hold the phone. 20180323 08:01:44<+discordbot4> What is the default textdomain for a WML file? 20180323 08:02:06<+discordbot4> diff diff --git a/data/gui/macros/custom_options_tree.cfg b/data/gui/macros/custom_options_tree.cfg index 15b8ea7c5e..247af76120 100644 --- a/data/gui/macros/custom_options_tree.cfg +++ b/data/gui/macros/custom_options_tree.cfg @@ -2,6 +2,8 @@ # Not a dialog, but a common portion of dialog layout used in at least two dialogs # +#textdomain wesnoth + #define _GUI_CUSTOM_OPTIONS_TREE_LINKED_GROUPS [linked_group] 20180323 08:02:06<+discordbot4> id = "custom_options_labels" 20180323 08:02:35<+discordbot4> This fixes the problem with the There are no custom options available for the selected era, game, or modification. label on 1.14 without breaking the string freeze. 20180323 08:02:57<+discordbot4> But then that means that the textdomain at the start of that context is not wesnoth? 20180323 08:03:06<+discordbot4> (And wmlxgettext assumes it is.) 20180323 08:03:35<+discordbot4> well likely the last one it came across wuld have been wesnoth-lib 20180323 08:03:50<+discordbot4> I thought the preprocessor would reset the textdomain at the start of every file context. 20180323 08:04:18-!- Bonobo [~Bonobo@203.220.138.198] has joined #wesnoth-dev 20180323 08:04:23<+discordbot4> Well, so basically the fix for 1.14 is to do what you did in master, just with a different textdomain that matches wmlxgettext's assumption. 😐 20180323 08:05:04<+discordbot4> I'll commit it. 20180323 08:06:03<+discordbot4> I may want to have a look at the preprocessor's code again. This seems really fishy and unlike what I remember reading before. 20180323 08:06:17<+discordbot4> maybe i fucked it up 20180323 08:06:29<+discordbot4> i did refactor some proprocessor stuff after all 20180323 08:06:34<+discordbot4> And believe it or not, sometimes people break the preprocessor in subtle way. I had to track down a really tricky bug in 1.11.x at one point. 20180323 08:07:24<+discordbot4> and i had to track down a 7 years ( at least) old bug in the parser recently 20180323 08:07:45<+discordbot4> That is something I don't really remember for certain right now. 20180323 08:08:05<+discordbot4> Who's the one with the conductor's baton when it comes to textdomain directives, the preprocessor or the parser? 20180323 08:08:24<+discordbot4> former iirc 20180323 08:08:29<+discordbot4> As far as I remember the parser has its own \xFEtextdomain and \xFEline directives. 20180323 08:09:09<+discordbot4> But it's the preprocessor that emits them as a way to communicate special information about the WML tree to the parser. 20180323 08:10:30< irker073> wesnoth: pentarctagon wesnoth:master b801140344c7 / utils/travis/steps/script.sh: Remove debugging symbols from Travis xcode build. https://github.com/wesnoth/wesnoth/commit/b801140344c7cbf86980ff54ef963f9ec2122897 20180323 08:14:05< irker073> wesnoth: Iris Morelle wesnoth:1.14 15db5181cfe9 / data/gui/macros/ (custom_options_tree.cfg player_list_panel.cfg): gui/mp: Fix two strings not being translated in the UI https://github.com/wesnoth/wesnoth/commit/15db5181cfe9a0f6fa7dd2c24bc74bded77099d8 20180323 08:14:52<+discordbot4> I'll let you figure out what to do about "Search" in text boxes. 20180323 08:15:06<+discordbot4> And about the RFM MAKE_ENUM entries. 20180323 08:15:46<+discordbot4> As for the last two in #2709: 20180323 08:16:04<+discordbot4> src/gui/dialogs/multiplayer/lobby.cpp:806: chatbox_->room_window_open("lobby", true, false); src/gui/dialogs/multiplayer/mp_join_game.cpp: chat.room_window_open("this game", true, false); // TODO: better title? src/gui/dialogs/multiplayer/mp_staging.cpp: chat.room_window_open("this game", true, false); // TODO: better title? 20180323 08:16:39<+discordbot4> These might require a more creative solution. 20180323 08:16:46<+discordbot4> Those are the ids 20180323 08:16:51<+discordbot4> Which ar ethen used as the titles 20180323 08:17:08<+discordbot4> And I presume there's no way to give them localized titles yet. 20180323 08:18:39<+discordbot4> I could add it 20180323 08:20:28<+discordbot4> As a random bit of useless trivia, back in 1.3.x/1.5.x, at least a lot of my code contributions consisted of i18n fixes. 20180323 08:21:45<+discordbot4> So these i18n debugging sessions make me feel like it's 2007 again, when I could barely do C++ and couldn't even protect myself from null pointers to save my life. 20180323 08:23:19<+discordbot4> Most likely the main reason why I'm not making localization fixes is that we Finns are used to play games in English. 20180323 08:23:43<+discordbot4> I guess shadowm is currently the most active developer from a country that's used to localized games. 20180323 08:24:09<+discordbot4> I've not played with the Spanish translation in 9 years. 20180323 08:25:01<+discordbot4> Last time I used it it was specifically because I took over as the team maintainer, and before that, it was because I still selected Spanish when installing Linux despite not needing it anymore. 20180323 08:26:39<+discordbot4> When I switched to Debian in late 2008 I went with en_US as my default locale and stopped seeing Spanish unless I went out of my way to switch to it to test translations for the team I took over. 20180323 08:27:33<+discordbot4> I think it was late 2009 when I took over and had to translate an enormous amount of strings (including one whole new campaign) without any help until a second translator came along. 20180323 08:27:53<+discordbot4> Not to mention taking care of all the fuzzies. 20180323 08:29:18<+discordbot4> After that whole experience I decided I'd never translate for Wesnoth again because the pressure to reach 100% before the first stable release did a number on me. Kept me from working on my campaigns, on bug fixes for mainline, and from sleeping. 20180323 08:30:05<+discordbot4> Sounds like a good decision. We're all volunteers in the end. Your own well-being definitely comes first. 20180323 08:30:16<+discordbot4> And the only reason I took over in the first place was because I knew a new stable series was approaching and the Spanish team was completely dead. 20180323 08:31:01<+discordbot4> For the past few years there's been like one guy in charge of the translation again, with occasional help from another translator. I believe. Don't quote me on that. 20180323 08:31:33<+discordbot4> I occasionally weigh in because it's obvious that they don't always look at the strings in context. 20180323 08:33:07<+discordbot4> Hm. Okay, seems like they're back in shape with 3 translators plus the maintainer. 20180323 08:37:33-!- travis-ci [~travis-ci@ec2-54-166-12-172.compute-1.amazonaws.com] has joined #wesnoth-dev 20180323 08:37:34< travis-ci> wesnoth/wesnoth#17103 (master - 94c5f64 : Iris Morelle): The build is still failing. 20180323 08:37:34< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/357267623 20180323 08:37:35-!- travis-ci [~travis-ci@ec2-54-166-12-172.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180323 08:40:11<+discordbot4> Oh right, there is a bigger reason why I wanted to test translations before 1.14. 20180323 08:40:18<+discordbot4> Steam. 20180323 08:41:44-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20180323 08:42:09<+discordbot4> It's always a big plus when a game is translated to a big market segment 's nate language, and especially important that the translation works correctly. 20180323 08:42:40<+discordbot4> It just so happens that there's a huge number of countries that speak Spanish. 20180323 08:43:26<+discordbot4> (Thanks phone for the autocorrect mistakes.) 20180323 08:46:07<+discordbot4> Ultimately it benefits everyone when people speaking XYZ language promote the game via word of mouth or even specialized review sites. 20180323 08:46:53<+discordbot4> Or even become interested in contributing themselves. 20180323 08:48:03< irker073> wesnoth/wesnoth:master pentarctagon b801140344 Remove debugging symbols from Travis xco AppVeyor: vs2015/Release Failed 20180323 08:48:04< irker073> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-2106 20180323 09:08:32-!- travis-ci [~travis-ci@ec2-54-163-180-75.compute-1.amazonaws.com] has joined #wesnoth-dev 20180323 09:08:33< travis-ci> wesnoth/wesnoth#17104 (master - 5770009 : Charles Dang): The build is still failing. 20180323 09:08:33< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/357274465 20180323 09:08:34-!- travis-ci [~travis-ci@ec2-54-163-180-75.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180323 09:45:24<+discordbot4> I need help with fontconfig building... Anyone? 20180323 09:46:59<+discordbot4> https://pastebin.com/zaRV9xAd 20180323 09:54:39<+discordbot4> Judging from your log, you did build it successfully. 20180323 09:55:39<+discordbot4> but didn't got any .dylib or .a 20180323 09:57:02<+discordbot4> Is there any in src/.libs? 20180323 09:59:19< irker073> wesnoth/wesnoth:1.14 Iris Morelle 15db5181cf gui/mp: Fix two strings not being transl AppVeyor: vs2015/Release Failed 20180323 09:59:20< irker073> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-1.14-2107 20180323 10:00:55-!- octalot [~steve@77.119.131.210.wireless.dyn.drei.com] has joined #wesnoth-dev 20180323 10:15:49<+discordbot4> yes... 20180323 10:15:55<+discordbot4> I am stupid 20180323 10:15:57<+discordbot4> 😄 20180323 10:16:08<+discordbot4> Thank you @jyrkive 20180323 10:16:32-!- octalot [~steve@77.119.131.210.wireless.dyn.drei.com] has quit [] 20180323 10:16:48-!- octalot [~steve@77.119.131.210.wireless.dyn.drei.com] has joined #wesnoth-dev 20180323 10:37:38< irker073> wesnoth/wesnoth:master Charles Dang 7a9ed8d363 Used UNUSED macro instead of (void) wher AppVeyor: 2/4 builds failed 20180323 10:37:39< irker073> Details vs2017/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-master-1803 20180323 10:37:40< irker073> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-2097 20180323 11:16:21-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180323 11:45:34< irker073> wesnoth/wesnoth:1.14 Iris Morelle 96032f978c Update the changelog AppVeyor: 1/2 builds failed 20180323 11:45:35< irker073> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-1.14-2098 20180323 12:19:21-!- Bonobo [~Bonobo@203.220.138.198] has quit [Ping timeout: 240 seconds] 20180323 12:20:03-!- Bonobo [~Bonobo@203.220.138.198] has joined #wesnoth-dev 20180323 12:33:20< irker073> wesnoth/wesnoth:1.14 Iris Morelle 26b327485d i18n: Make VGETTEXT()/VNGETTEXT() always AppVeyor: 2/4 builds failed 20180323 12:33:21< irker073> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-1.14-2099 20180323 12:33:22< irker073> Details vs2017/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-1.14-1805 20180323 12:33:42-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20180323 13:30:20-!- octalot [~steve@77.119.131.210.wireless.dyn.drei.com] has quit [] 20180323 13:46:57<+discordbot4> @loonycyborg any chance you could build the steam builds with newer libs? 20180323 13:47:14<+discordbot4> At least in the case of SDL_Image, using 2.0.1 means no jpg screenshots 20180323 13:47:50<+discordbot4> I can update my buildfiles 20180323 13:48:03< irker073> wesnoth/wesnoth:master pentarctagon b801140344 Remove debugging symbols from Travis xco AppVeyor: 2/4 builds failed 20180323 13:48:04< irker073> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-2106 20180323 13:48:05< irker073> Details vs2017/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-master-1812 20180323 13:48:28<+discordbot4> just tell me which updates are needed to enable particular features 20180323 13:48:36<+discordbot4> is there anything beside sdl-image? 20180323 13:49:09<+discordbot4> shadowm was surprised lua console completion wasn't enabled 20180323 13:49:15<+discordbot4> can't remember what that needs.. 20180323 13:49:23<+discordbot4> libhistory? 20180323 13:49:32<+discordbot4> I was planning to add that too 20180323 13:49:39<+discordbot4> it just requires extra effort 20180323 13:49:42<+discordbot4> (FTR, she was able to successfully download, install, and run the Linux package off Steam) 20180323 13:49:46<+discordbot4> readline not in steam runtime 20180323 13:50:27<+discordbot4> I posted about missing deps on dev usergroup too 20180323 13:50:33<+discordbot4> as they recommended in linux faq 20180323 13:51:08<+discordbot4> Would static linking be possible? 20180323 13:51:39<+discordbot4> I will just provide that lib in separate dir 20180323 13:51:47<+discordbot4> and add it via LD_LIBRARY_PATH 20180323 13:51:59<+discordbot4> all linux games do so for steam releases I think 20180323 13:52:34<+discordbot4> though if we didn't have any .so files not in steam runtime that would eliminate the need to provide start.sh script 20180323 13:52:45<+discordbot4> 🤦 What even is the point of dynamic linking in that case? 20180323 13:53:08<+discordbot4> static linking is more problematic 20180323 13:53:26<+discordbot4> it can't use dynamic linker to handle indirect dependencies 20180323 13:53:51<+discordbot4> Honestly, if it's too much trouble, just leave it out 20180323 13:54:16<+discordbot4> dw I already was planning to do it 20180323 14:02:10< irker073> wesnoth: Charles Dang wesnoth:master 2e502334f234 / src/gui/dialogs/multiplayer/mp_create_game.cpp: MP Create Game: attempt to fix RFM type labels being untranslated (#2709) https://github.com/wesnoth/wesnoth/commit/2e502334f23447609e2553cbbbae8b251f9796bc 20180323 14:02:13< irker073> wesnoth: Charles Dang wesnoth:master c2fd4f48f912 / src/ (15 files in 9 dirs): Cleaned up unnecessary instances of emplace_back(config {}) https://github.com/wesnoth/wesnoth/commit/c2fd4f48f912c48e71382c61e4012ec7fae2f930 20180323 14:09:04-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180323 14:17:43<+discordbot4> Is there any reason to keep utils/travis/check_utf8.sh and utils/travis/utf8_bom_dog.sh around anymore? The first checks for invalid uft8 files, and the second checks for BOMs, but both are only used in the travis script for the osx+scons job, and their return codes are not checked to see if they actually found anything. 20180323 14:18:51<+discordbot4> you're the one who can make that kind of call 20180323 14:19:18<+discordbot4> I don't know what the reasoning behind putting them there in the first place was though 20180323 14:21:32<+discordbot4> I imagine it was intended to detect cases like this: https://github.com/wesnoth/wesnoth/commit/05da076e9229051c64f487a8307ba6fa2febbdbe 20180323 14:22:41<+discordbot4> A separate script for that is no longer necessary, though, because Clang can detect it as well: https://clang.llvm.org/docs/DiagnosticsReference.html#winvalid-source-encoding 20180323 14:23:40< Soliton> clang is probably not going to check po/ and data/ though? 20180323 14:24:18<+discordbot4> Ah, right. 20180323 14:25:56< irker073> wesnoth/wesnoth:master newfrenchy83 7128f16a38 Update reports.cpp AppVeyor: vs2017/Release Failed 20180323 14:25:57< irker073> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-master-1814 20180323 14:27:08<+discordbot4> unless someone actually goes and checks the logs for the osx+scons job though, anything found by those will never get noticed. So right now, they seem not very useful. So, are they something to get rid of, or to check the return code of and fail if anything is found? 20180323 14:27:26< Soliton> the scripts could be improved to work on non-GNU platforms but they seem useful either way. not particularly specific to travis though. 20180323 14:27:34<+discordbot4> It would be better to check the return code. 20180323 14:28:04< Soliton> yeah, the build should fail if they find something. 20180323 14:28:04<+discordbot4> ok 20180323 14:31:20-!- DeFender1031 [~DeFender1@dsl217-132-38-129.bb.netvision.net.il] has quit [Quit: I'm not back now.] 20180323 14:32:43-!- travis-ci [~travis-ci@ec2-54-145-185-49.compute-1.amazonaws.com] has joined #wesnoth-dev 20180323 14:32:44< travis-ci> wesnoth/wesnoth#17108 (master - c2fd4f4 : Charles Dang): The build is still failing. 20180323 14:32:45< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/357405061 20180323 14:32:45-!- travis-ci [~travis-ci@ec2-54-145-185-49.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180323 14:55:25-!- travis-ci [~travis-ci@ec2-54-163-180-75.compute-1.amazonaws.com] has joined #wesnoth-dev 20180323 14:55:26< travis-ci> Pentarctagon/wesnoth#345 (master - b801140 : pentarctagon): The build failed. 20180323 14:55:26< travis-ci> Build details : https://travis-ci.org/Pentarctagon/wesnoth/builds/357395078 20180323 14:55:26-!- travis-ci [~travis-ci@ec2-54-163-180-75.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180323 14:59:19< irker073> wesnoth/wesnoth:1.14 Iris Morelle 15db5181cf gui/mp: Fix two strings not being transl AppVeyor: 2/4 builds failed 20180323 14:59:20< irker073> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-1.14-2107 20180323 14:59:21< irker073> Details vs2017/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-1.14-1813 20180323 15:31:38-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20180323 15:31:52<+discordbot4> agh. I need to remember to stop force pushing changes while a travis build is going... 20180323 15:34:36<+discordbot4> @Pentarctagon I would recommend simply eliminating the UTF-8 scripts. Mainly because clang checks for invalid encodings. I always assumed they're not checked because they're ancient hold-overs. The checks were originally added by Chris Beck on June 30, 2014 for 1.13.0. At the time, the results actually were used. Any decent compiler will flag invalid encodings. And a BOM should be ignored even though, strictly speaking, 20180323 15:34:37<+discordbot4> it's not part of UTF-8. The reason we have BOM in UTF-8 is in case something did a lazy conversion from UTF-16 or UTF-32 and failed to strip the BOM. 20180323 15:35:19<+discordbot4> As Soliton mentioned above though, the scripts check more than just files that are compiled. 20180323 15:36:24<+discordbot4> they both check po/ src/ data/, actually 20180323 15:36:27<+discordbot4> /data /po and /src and I'm guessing (since the commit messages are silent on it) that it was because pre-1.13.0 someone committed a file with a BOM. Most likely a Windows user. 20180323 15:37:36<+discordbot4> I suppose we can still check for it but the check was originally in after_failure. So I guess it was causing a failure somewhere which was hard to find due to the lack of a meaningful diagnostic 20180323 15:38:13< Soliton> so it's a good idea to fail the build if someone does it again since i don't thing our parser/preprocessor or the gettext tools handle BOMs gracefully. 20180323 15:38:51< Soliton> and they shouldn't handle invalid utf-8 gracefully. 20180323 15:39:14<+discordbot4> I didn't look to see if/when it was moved from after_failure but, yes, if we're going to check proper encoding (which include NO byte order mark at all), it should be before we begin the build. 20180323 15:40:04< Soliton> sure, before building makes sense. 20180323 15:40:22< Soliton> and it should be enough if one configuration does it. 20180323 15:41:15<+discordbot4> I'd move it to the PO step since it's most likely in /po we'd actually need to check. I suppose checking /data makes a lot of sense, too. 20180323 15:42:05-!- Bonobo [~Bonobo@203.220.138.198] has quit [Ping timeout: 240 seconds] 20180323 15:48:02<+discordbot4> When did the scripts' results stop being considered then? 20180323 15:50:52<+discordbot4> error in wesnothd 20180323 15:51:54<+discordbot4> macOS package Wesnoth 1.13.12 First Wesnoth can't find wesnothd automatically (where is expected location?) and when you manually select it: 20180323 16:45:53 error filesystem: Trying to open file with empty name. sh: ./wesnothd: No such file or directory 20180323 16:46:33 warning general: Failed to run server start script Started wesnothd as a daemon with process id 43154 20180323 16:47:01 warning general: Failed to run 20180323 15:51:55<+discordbot4> server start script 20180323 16:47:01 info server: Server configuration from file: '/Users/user/Library/Application Support/Wesnoth_1.13/lan_server.cfg' read. 20180323 16:47:01 error server: could not make fifo at '/var/run/wesnothd/socket' (No such file or directory) libc++abi.dylib: terminating with uncaught exception of type boost::exception_detail::clone_impl >: 20180323 15:51:55<+discordbot4> bind: Address already in use 20180323 15:52:21<+discordbot4> Also, the in-game parser does handle BOMs, it just outputs a warning to stderr eevery time it reads a file with one. 20180323 15:52:29< Soliton> terminate the already running wesnothd. 20180323 15:52:39< Soliton> or whatever might be on port 15000. 20180323 15:52:45<+discordbot4> there weren't any wesnothd running before 20180323 15:53:03<+discordbot4> look: 20180323 16:47:01 error server: could not make fifo at '/var/run/wesnothd/socket' (No such file or directory) 20180323 15:53:13< Soliton> that is not so important. 20180323 15:53:28< Soliton> "bind: Address already in use" this suggest that the port is no available. 20180323 15:53:34<+discordbot4> welp, I'll try reproduce it on another machine 20180323 15:54:09< Soliton> check if there is anything running on port 15000. with netstat -plant or so. 20180323 15:55:03<+discordbot4> TCP? 20180323 15:55:09< Soliton> yes. 20180323 15:55:28< Soliton> (-t for netstat means tcp) 20180323 15:56:00<+discordbot4> Welp, on another machine (not tested wesnothd yet): MacBook-Pro:~ user$ nmap localhost -p 15000 Starting Nmap 7.60 ( https://nmap.org ) at 2018-03-23 16:55 CET Nmap scan report for localhost (127.0.0.1) Host is up (0.00023s latency). Other addresses for localhost (not scanned): ::1 PORT STATE SERVICE 15000/tcp closed hydap Nmap done: 1 IP address (1 host up) scanned in 0.05 seconds 20180323 15:57:01< Soliton> perhaps there is some permission/policy whatever that prevents binding to that port then? sounds odd though. 20180323 15:58:36<+discordbot4> For the named socket, you need to change the directory ownership so the user running wesnothd has permission to create the fifo. 20180323 15:58:59<+discordbot4> I can reproduce it on another mac 20180323 15:59:29<+discordbot4> For the listening socket, 15000, if campaignd is not already running, look for another process using 15000 20180323 16:00:12<+discordbot4> sorry wesnothd 20180323 16:00:18<+discordbot4> /Users/martinhruby/Do_not_backup/wesnoth_1.13.12/Wesnoth.app/Contents/MacOS/Wesnoth ; exit; objc[62122]: Class SDLApplication is implemented in both /Users/martinhruby/Do_not_backup/wesnoth_1.13.12/Wesnoth.app/Contents/Frameworks/SDL2.framework/Versions/A/SDL2 (0x10488a280) and /Users/martinhruby/Do_not_backup/wesnoth_1.13.12/Wesnoth.app/Contents/MacOS/Wesnoth (0x103ad6b78). One of the two will be used. Which one is undefined. 20180323 16:00:19<+discordbot4> Battle for Wesnoth v1.13.12 Started on Fri Mar 23 16:58:13 2018 Automatically found a possible data directory at /Users/USER/Do_not_backup/wesnoth_1.13.12/Wesnoth.app/Contents/Resources Fontconfig warning: line 146: blank doesn't take any effect anymore. please remove it from your fonts.conf Data directory: /Users/USER/Do_not_backup/wesnoth_1.13.12/Wesnoth.app/Contents/Resources User configuration directory: 20180323 16:00:19<+discordbot4> /Users/USER/Library/Application Support/Wesnoth_1.13 User data directory: /Users/USER/Library/Application Support/Wesnoth_1.13 Cache directory: /Users/USER/Library/Application Support/Wesnoth_1.13/cache Setting mode to 1440x878 Checking lua scripts... ok 20180323 16:58:18 error filesystem: Trying to open file with empty name. Started wesnothd as a daemon with process id 62131 20180323 16:58:27 warning general: Failed 20180323 16:00:20<+discordbot4> to run server start script 20180323 16:58:27 info server: Server configuration from file: 20180323 16:00:24<+discordbot4> '/Users/martinhruby/Library/Application Support/Wesnoth_1.13/lan_server.cfg' read. 20180323 16:58:27 error server: could not make fifo at '/var/run/wesnothd/socket' (No such file or directory) Started wesnothd as a daemon with process id 62142 20180323 16:58:39 warning general: Failed to run server start script 20180323 16:58:39 info server: Server configuration from file: '/Users/martinhruby/Library/Application 20180323 16:00:24<+discordbot4> Support/Wesnoth_1.13/lan_server.cfg' read. 20180323 16:58:39 error server: could not make fifo at '/var/run/wesnothd/socket' (No such file or directory) libc++abi.dylib: terminating with uncaught exception of type boost::exception_detail::clone_impl >: bind: Address already in use 20180323 16:01:20<+discordbot4> welp, after trying wesnoth 15000 is opened 20180323 16:01:30<+discordbot4> Last login: Fri Mar 23 16:58:13 on ttys003 Martin-Hrubys-MacBook-Pro:~ martinhruby$ nmap localhost -p 15000 Starting Nmap 7.60 ( https://nmap.org ) at 2018-03-23 17:01 CET Nmap scan report for localhost (127.0.0.1) Host is up (0.00021s latency). Other addresses for localhost (not scanned): ::1 PORT STATE SERVICE 15000/tcp open hydap Nmap done: 1 IP address (1 host up) scanned in 0.05 seconds 20180323 16:01:40<+discordbot4> chown /var/run/wesnothd to your account. 20180323 16:01:51<+discordbot4> and is still opened after closing wesnoth 20180323 16:02:14< Soliton> that's expected it closes after a time of inactivity. 20180323 16:02:17<+discordbot4> /var/run/wesnothd doesn't exist 20180323 16:02:41< Soliton> the fifo is non-essential, really. 20180323 16:02:46<+discordbot4> there you go. Create it using sudo then check it's owned by you 20180323 16:03:02<+discordbot4> https://cdn.discordapp.com/attachments/259976436490829825/426772874016063499/unknown.png 20180323 16:03:46<+discordbot4> >there you go. Create it using sudo then check it's owned by you This is workaround... Not good for production release 20180323 16:04:03<+discordbot4> The fifo is how the IRC channel can control the MP server. Like me, he's just trying to snub errors, not actually use it 20180323 16:04:20< Soliton> is the currently running wesnothd PID 62142? 20180323 16:04:46<+discordbot4> nope, wesnothd runs under 62131 20180323 16:04:58<+discordbot4> I sent screenshot on discord 20180323 16:04:58< Soliton> so maybe it started it twice for some reason. 20180323 16:05:24< Soliton> i couldn't guess what the numbers mean, my apologies. 20180323 16:05:46<+discordbot4> Like "Local Game" option. 20180323 16:06:07<+discordbot4> you want steps to reproduce? 20180323 16:06:33<+discordbot4> I sometimes forget I have a wesnothd up and running and get the error when I try to start another as a local game instead of a non-standard networked game. 20180323 16:06:49< Soliton> sounds like you should make an issue on github. 20180323 16:07:08<+discordbot4> there is also other problem 20180323 16:07:08< Soliton> yeah, it'd be nice if wesnoth would not freak out if there is already a wesnothd running on port 15000. i think before we did not check that wesnothd succeeded (which is not ideal as well of course) and thus connected to the already running server. 20180323 16:08:07< Soliton> of course it's probably difficult to tell if the thing already running on port 15000 is really wesnothd.. 20180323 16:08:46<+discordbot4> And we probably should have an issue about not complaining if it can't create the FIFO. But, then, the official server would silently faile. So it needs more than just not complaining. Perhaps a command-line option to complain if it can't create the FIFO (default, don't) 20180323 16:08:50<+discordbot4> I clicked 'Host local game' while wesnothd was already running from previous session it wanted me to select wesnothd binary but I also got crashlog and backtrace from newly spawn wesnothd 20180323 16:09:30< irker073> wesnoth/wesnoth:master Charles Dang c2fd4f48f9 Cleaned up unnecessary instances of empl AppVeyor: vs2017/Release Failed 20180323 16:09:31< irker073> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-master-1815 20180323 16:10:00<+discordbot4> it looks that wesnoth actually can find wesnothd binary in macos bundle, starts it but then wanted you to select it manually 20180323 16:10:16< Soliton> so feature request for just trying to connect to port 15000 if something's already running there and bug report for whatever is happening on macos there. 20180323 16:10:55<+discordbot4> I'll go create issue 20180323 16:11:14< Soliton> right, perhaps also feature request for not constantly asking for the binary if running wesnothd failed. 20180323 16:11:43< Soliton> we could run it once with --version or so to verify it's the wesnothd we're expecting and then not ask for the path again. 20180323 16:12:59-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180323 16:25:42<+discordbot4> Issue: https://github.com/wesnoth/wesnoth/issues/2720 20180323 16:25:47< Soliton> so it successfully spawns wesnothd and THEN asks you for the path? 20180323 16:26:18<+discordbot4> yes, it looks like that 20180323 16:26:31<+discordbot4> Is there more verbose setting for it? 20180323 16:26:33< Soliton> well, then there is the double execution. 20180323 16:26:45< Soliton> the question is then why does it ask. 20180323 16:27:08<+discordbot4> Do you want dir structure of macOS package? 20180323 16:27:25< Soliton> though from the log output it seems to have not been able to start wesnothd the first time. 20180323 16:27:33< Soliton> sh: ./wesnothd: No such file or directory 20180323 16:27:44<+discordbot4> when it asks you, it expect wesnothd in Resources 20180323 16:28:14<+discordbot4> but every time before it was in MacOS (next to Wesnoth executable) 20180323 16:29:22< Soliton> it'd be good if wesnothd would be in the expected location to begin with, yeah. 20180323 16:29:32< Soliton> or that it'd expect the right location. 20180323 16:30:09<+discordbot4> welp, I'll kill existing wesnothd process and copy (<--- copy not move) wesnothd also to Resources 20180323 16:30:12< Soliton> not sure off hand how that is determined though. 20180323 16:30:42<+discordbot4> It should be in MacOS but maybe there was source changes which breaked this logic 20180323 16:30:57< Soliton> well, it's probably just the current dir. is wesnoth started with Resources as the current dir? 20180323 16:32:07<+discordbot4> idk tbh but regarding to manual select path it is same as Data directory path if you get me 20180323 16:32:10-!- travis-ci [~travis-ci@ec2-54-145-185-49.compute-1.amazonaws.com] has joined #wesnoth-dev 20180323 16:32:11< travis-ci> Pentarctagon/wesnoth#358 (travis-script-cleanup - 5a8d12c : pentarctagon): The build was canceled. 20180323 16:32:11< travis-ci> Build details : https://travis-ci.org/Pentarctagon/wesnoth/builds/357472366 20180323 16:32:11-!- travis-ci [~travis-ci@ec2-54-145-185-49.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180323 16:32:15<+discordbot4> so Resources 20180323 16:34:49<+discordbot4> welp... I copied wesnothd to Resources and it spawned wesnothd process from MacOS and asked me if the Resources path is right: https://pasteboard.co/HdfLNZA.png 20180323 16:35:33<+discordbot4> screenshot shows 2 wesnoth processes (main and wesnothd) before i selected path manually 20180323 16:48:25-!- travis-ci [~travis-ci@ec2-54-145-185-49.compute-1.amazonaws.com] has joined #wesnoth-dev 20180323 16:48:26< travis-ci> Pentarctagon/wesnoth#360 (travis-script-cleanup - 89421b9 : pentarctagon): The build was canceled. 20180323 16:48:26< travis-ci> Build details : https://travis-ci.org/Pentarctagon/wesnoth/builds/357480730 20180323 16:48:26-!- travis-ci [~travis-ci@ec2-54-145-185-49.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180323 17:03:17< Soliton> that is good info. 20180323 17:03:43< Soliton> so it somehow does spawn wesnothd but thinks it didn't. 20180323 17:08:22<+discordbot4> yes 20180323 17:09:08<+discordbot4> I don't have required time to DEBUG it now TBH 😦 but if you tell me what should I add to src or uncomment, I can let it compile and test 20180323 17:11:56-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20180323 17:13:15-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180323 17:13:18<+discordbot4> So anyone wants to place bets on exactly when the 1.14 RC 1 announcement will be posted? :> 20180323 17:13:49-!- midzer [~quassel@p5B312805.dip0.t-ipconnect.de] has quit [Remote host closed the connection] 20180323 17:24:23<+discordbot4> I'll take May 15th for 10, Alex 20180323 17:25:49< Soliton> pff, 1.14 is dead. long live master! 20180323 17:28:43<+discordbot4> 😄 20180323 17:31:14<+discordbot4> Does anyone know what happened to using utils/travis/test_wrapper.sh? It seems to have been removed from docker_run.sh between LTO being enabled and then being disabled again. When it was there, test_wrapper.sh was run for the boost unit tests, and test_executor.sh was run if there were errors. After it was removed, test_executor.sh is run for the boost unit tests instead. 20180323 17:31:47<+discordbot4> git seems to have lost the history of docker_run after it was moved though 20180323 17:32:23< Soliton> you have to ask git for the history at the old path. 20180323 17:33:46<+discordbot4> I'm sure master can use the extra love right now. 20180323 17:33:59<+discordbot4> It seemed a bit blue last night when I had a look at it. 20180323 17:34:34<+discordbot4> And also reeked of alcohol. 20180323 17:34:36<+discordbot4> For me, this morning was the first time since 1.14 tagged I've not had to hold it's hand and help master compile cleanly. 20180323 17:35:12< Soliton> @Pentarctagon: btw, these if [ $? ... ] tests are not the way to go. when cleaning up those should rather be removed. f.e. you can just write: my_command || exit if you want to exit if my_command failed. 20180323 17:44:15<+discordbot4> alright 20180323 17:57:38-!- midzer [~quassel@p5B312805.dip0.t-ipconnect.de] has joined #wesnoth-dev 20180323 17:59:10-!- midzer [~quassel@p5B312805.dip0.t-ipconnect.de] has quit [Remote host closed the connection] 20180323 18:06:06-!- midzer [~quassel@p5B312805.dip0.t-ipconnect.de] has joined #wesnoth-dev 20180323 18:08:38-!- midzer [~quassel@p5B312805.dip0.t-ipconnect.de] has quit [Remote host closed the connection] 20180323 18:14:43-!- travis-ci [~travis-ci@ec2-54-145-185-49.compute-1.amazonaws.com] has joined #wesnoth-dev 20180323 18:14:44< travis-ci> Pentarctagon/wesnoth#361 (travis-script-cleanup - 88c53ea : pentarctagon): The build failed. 20180323 18:14:44< travis-ci> Build details : https://travis-ci.org/Pentarctagon/wesnoth/builds/357512168 20180323 18:14:44-!- travis-ci [~travis-ci@ec2-54-145-185-49.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180323 18:26:55-!- midzer [~quassel@p5B312805.dip0.t-ipconnect.de] has joined #wesnoth-dev 20180323 18:32:15-!- gfgtdf [~chatzilla@x4e3637f0.dyn.telefonica.de] has joined #wesnoth-dev 20180323 18:32:51< gfgtdf> shadowm: the loadingscreen uses gettext function to display the status strings, so i had to add mutexes there, 20180323 18:33:28<+discordbot4> We still don't know for sure if the mutexes fix the crash. 20180323 18:35:27< irker073> wesnoth/wesnoth:master pentarctagon ca3967cffa Make UTF8 checks fail the build if they AppVeyor: vs2017/Release Failed 20180323 18:35:29< irker073> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-master-1818 20180323 18:39:35<+discordbot4> I submitted a pull request to aquileia/external: https://github.com/aquileia/external/pull/26 20180323 18:39:56<+discordbot4> It will be necessary to build the 1.14 branch with Visual Studio 2013 after my next commit. 20180323 18:41:53< gfgtdf> jyrkive: im am sure that they fix a crash, what was unsure about is whether all 3 of those bugreports are really dublicates of each other. 20180323 18:47:13-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180323 18:47:19-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180323 18:48:38-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20180323 18:49:56-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180323 18:56:53-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180323 18:56:59-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180323 19:11:21<+discordbot4> *sigh* This is why one shouldn't rush in last-minute changes right before a release... 20180323 19:13:13< irker073> wesnoth: Jyrki Vesterinen wesnoth:1.14 a48f26340503 / projectfiles/VC12/ (campaignd.vcxproj wesnoth.vcxproj wesnothd.vcxproj): Update Visual Studio project files for OpenSSL 1.1.0 https://github.com/wesnoth/wesnoth/commit/a48f26340503f495afa633998f4ad0ca18ff0017 20180323 19:13:20< gfgtdf> we needed it, in fact i made it knowing that it might not work with zoom and even if 0, is the only 'supported' value it's still an imporvemnt 20180323 19:15:29< Soliton> gfgtdf: you can see github notifications in #wesnoth-commits, btw. 20180323 19:16:00< gfgtdf> Soliton: ok thx 20180323 19:23:15-!- TadCarlucci [~lundberg@74.193.219.119] has quit [Remote host closed the connection] 20180323 19:23:28-!- TadCarlucci [~lundberg@74.193.219.119] has joined #wesnoth-dev 20180323 19:25:02< Soliton> loonycyborg: btw, do we have backup downloads for the current binaries on wesnoth.org? 20180323 19:25:21< Soliton> in case sf has issue again or so... 20180323 19:25:29< loonycyborg> of 1.13.12? nope 20180323 19:25:38< loonycyborg> I still didn't make it part of my procedure 20180323 19:25:51< irker073> wesnoth/wesnoth:master newfrenchy83 979622204a Update abilities.cfg AppVeyor: vs2017/Release Failed 20180323 19:25:52< irker073> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-master-1819 20180323 19:25:57< irker073> wesnoth/wesnoth:master newfrenchy83 7128f16a38 Update reports.cpp AppVeyor: 2/4 builds failed 20180323 19:25:58< irker073> Details vs2017/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-master-1814 20180323 19:25:59< irker073> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-2108 20180323 19:25:59< Soliton> i think it'd be nice just in case. 20180323 19:26:24< Soliton> doesn't have to be accessible all the time if we're worried about bandwidth. 20180323 19:27:10< Soliton> i think that risk is fairly low though. 20180323 19:36:01< irker073> wesnoth: gfgtdf wesnoth:gfgtdf-fix_2683 69fb7e22fc66 / src/synced_commands.cpp: fix #2683 step1 https://github.com/wesnoth/wesnoth/commit/69fb7e22fc66a1db054fdb6f210326d2cc3b91f8 20180323 19:48:19-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180323 19:48:26-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180323 19:57:57<+discordbot4> @shadowm is there a dedicated 1.14 wesnothd instance yet? 20180323 19:58:30< Soliton> no. 20180323 19:58:50<+discordbot4> Ok. I'll keep the text mentioning the 1.13 server 20180323 20:00:38<+discordbot4> Just going to announce now 20180323 20:06:47< irker073> wesnoth: Charles Dang wesmere:master 8272b087aba4 / static/docroot/index.php: Updated frontpage links for 1.13.12 https://github.com/wesnoth/wesmere/commit/8272b087aba43df55a017bc0d79efb61c9c0a11f 20180323 20:06:56< irker073> wesnoth/wesnoth:master newfrenchy83 98cf521346 Update wesnoth.cbp AppVeyor: vs2015/Release Failed 20180323 20:06:57< irker073> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-2113 20180323 20:10:05< irker073> wesnoth: gfgtdf wesnoth:gfgtdf-fix_2683 12e284aa43c1 / src/play_controller.hpp: f https://github.com/wesnoth/wesnoth/commit/12e284aa43c1ec5901ed28df16a803f4c37071e1 20180323 20:16:36< Soliton> ok, announced on the mp server as well. (not that anyone was listening) 20180323 20:26:07<+discordbot4> @loonycyborg oh, BTW, you did get that issue with the corrupted worktree messing up Windows packages sorted before 1.13.12, right? 20180323 20:26:30<+discordbot4> yes, I remake that clone 20180323 20:26:34<+discordbot4> and ran git fsck too 20180323 20:26:51<+discordbot4> just to be sure 😛 20180323 20:26:58<+discordbot4> 👍 20180323 20:44:23-!- octalot [~steve@178.165.129.225.wireless.dyn.drei.com] has joined #wesnoth-dev 20180323 20:50:12< irker073> wesnoth: gfgtdf wesnoth:gfgtdf-fix_2683 be628d53e40b / src/savegame.hpp: Update savegame.hpp https://github.com/wesnoth/wesnoth/commit/be628d53e40bf92361a48050c55b64973c62d03f 20180323 20:53:10< irker073> wesnoth: gfgtdf wesnoth:gfgtdf-fix_2683 8f00db684acd / src/savegame.hpp: revert 'Update savegame.hpp' https://github.com/wesnoth/wesnoth/commit/8f00db684acdc1835c73e11f598d0f6b9bb4c2d1 20180323 20:59:43< irker073> wesnoth: gfgtdf wesnoth:gfgtdf-fix_2683 ef9580fb83b8 / src/synced_commands.cpp: fix #2683 step2 https://github.com/wesnoth/wesnoth/commit/ef9580fb83b80c2e324d40df1bb1b65591e51391 20180323 21:04:31-!- travis-ci [~travis-ci@ec2-54-205-56-74.compute-1.amazonaws.com] has joined #wesnoth-dev 20180323 21:04:32< travis-ci> wesnoth/wesnoth#17118 (gfgtdf-fix_2683 - 12e284a : gfgtdf): The build failed. 20180323 21:04:32< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/357568559 20180323 21:04:32-!- travis-ci [~travis-ci@ec2-54-205-56-74.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180323 21:09:30< irker073> wesnoth/wesnoth:master Charles Dang c2fd4f48f9 Cleaned up unnecessary instances of empl AppVeyor: 2/4 builds failed 20180323 21:09:31< irker073> Details vs2017/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-master-1815 20180323 21:09:32< irker073> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-2109 20180323 21:17:31-!- travis-ci [~travis-ci@ec2-54-224-141-220.compute-1.amazonaws.com] has joined #wesnoth-dev 20180323 21:17:32< travis-ci> wesnoth/wesnoth#17121 (gfgtdf-fix_2683 - ef9580f : gfgtdf): The build is still failing. 20180323 21:17:32< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/357589119 20180323 21:17:32-!- travis-ci [~travis-ci@ec2-54-224-141-220.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180323 21:18:23< irker073> wesnoth: gfgtdf wesnoth:gfgtdf-fix_2683 b62422b2e11d / src/synced_commands.cpp: f https://github.com/wesnoth/wesnoth/commit/b62422b2e11d75893ff2768091e0649c3a5615a6 20180323 21:27:19-!- grzywacz [~karol@89-70-226-147.dynamic.chello.pl] has joined #wesnoth-dev 20180323 21:27:37< grzywacz> Still up? 20180323 21:28:35< gfgtdf> ? 20180323 21:28:39-!- iceiceice [~chris@unaffiliated/iceiceice] has joined #wesnoth-dev 20180323 21:29:06< Soliton> see status.wesnoth.org 20180323 21:29:57< grzywacz> Soliton: :D :) 20180323 21:30:15< grzywacz> I'm more curious about the project itself. 20180323 21:30:26< Soliton> 1.14 is imminent. 20180323 21:30:54< grzywacz> What brought me here was the latest off-master dev version not connecting to the dev MP server, but maybe that's ok, or maybe I have to make clean it for some reason. 20180323 21:30:57< Soliton> you need to test mp though because barely anyone else does. 20180323 21:31:05< grzywacz> "you" :-))) 20180323 21:31:14< Soliton> see. 20180323 21:31:38< grzywacz> status.wesnoth.org is better than what many serious companies have, congrats. 20180323 21:32:15-!- grzywacz [~karol@89-70-226-147.dynamic.chello.pl] has quit [Changing host] 20180323 21:32:15-!- grzywacz [~karol@wesnoth/developer/grzywacz] has joined #wesnoth-dev 20180323 21:32:41< Soliton> you should be allowed in now. 20180323 21:33:12< grzywacz> It works. 20180323 21:33:49< irker073> wesnoth: Nils Kneuper wesnoth:1.14 3f4d003f13b2 / / (13 files in 12 dirs): updated Spanish translation https://github.com/wesnoth/wesnoth/commit/3f4d003f13b2d72e8b669a01e5a1d5de7e0c3217 20180323 21:33:52< irker073> wesnoth: Nils Kneuper wesnoth:master 0bab3fb4d385 / / (13 files in 12 dirs): updated Spanish translation https://github.com/wesnoth/wesnoth/commit/0bab3fb4d385a326c79bc1f0a27afe399a481d37 20180323 21:33:59-!- travis-ci [~travis-ci@ec2-54-145-185-49.compute-1.amazonaws.com] has joined #wesnoth-dev 20180323 21:34:00< travis-ci> wesnoth/wesnoth#17122 (gfgtdf-fix_2683 - b62422b : gfgtdf): The build is still failing. 20180323 21:34:00< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/357595784 20180323 21:34:01-!- travis-ci [~travis-ci@ec2-54-145-185-49.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180323 21:41:55< irker073> wesnoth/wesnoth:master pentarctagon 81c87624c4 Make UTF8 checks fail the build if they AppVeyor: vs2015/Release Failed 20180323 21:41:56< irker073> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-2114 20180323 21:43:55< grzywacz> Soliton: well, but can't start a game :D 20180323 21:44:10< Soliton> can't have everything. 20180323 21:44:32< Soliton> master is fairly broken afaik. 20180323 21:44:37< Soliton> better try 1.14. 20180323 21:45:15< Soliton> (the branch is already there.) 20180323 21:54:53<+discordbot4> yeah, master hasn't had a successful travis build in 5 days 20180323 21:56:24< grzywacz> How does that even happen... 20180323 21:56:51<+discordbot4> Dont get us started. 20180323 21:57:37< grzywacz> discordbot... I feel old. :P 20180323 21:58:16<+discordbot4> I think I heard that it's likely master will continue to fail tests for another week or so. But I've been checking every morning to make sure it, at least, compiles even if I can't get the test passng. 20180323 21:59:58<+discordbot4> I was going to try to stick to master, but the [for] loop bug is kind of a deal breaker 20180323 22:06:12< Soliton> grzywacz: thanks for the reports but i think it's not that useful to report every issue for master currently. :-) 20180323 22:06:17-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev 20180323 22:07:13< grzywacz> Soliton: I beg to differ, but feel free to close them all! :) 20180323 22:09:29< Soliton> well, much more important IMO is to polish 1.14 currently. 20180323 22:10:13< Soliton> if i log on to 1.12 mp with the dev version i can only imagin what will happen if more people start playing 1.13/1.14... 20180323 22:12:33< irker073> wesnoth: gfgtdf wesnoth:gfgtdf-fix_2683 705ca1a3a8f8 / src/play_controller.hpp: f1 https://github.com/wesnoth/wesnoth/commit/705ca1a3a8f8941dff78f60a08799bd0360cc856 20180323 22:12:38-!- travis-ci [~travis-ci@ec2-54-145-185-49.compute-1.amazonaws.com] has joined #wesnoth-dev 20180323 22:12:39< travis-ci> wesnoth/wesnoth#17124 (master - 0bab3fb : Nils Kneuper): The build is still failing. 20180323 22:12:39< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/357600980 20180323 22:12:39-!- travis-ci [~travis-ci@ec2-54-145-185-49.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180323 22:13:18<+discordbot4> If you want to file tickets on wesnoth/master it would be a lot less work to open just one, name it "Master does not work" and we can close it as "Duplicate" 😛 20180323 22:13:37< irker073> wesnoth: gfgtdf wesnoth:gfgtdf-fix_2683 30f3a3ec2d50 / src/synced_commands.cpp: f2 https://github.com/wesnoth/wesnoth/commit/30f3a3ec2d502d2176c8e6c2f07b3540a37d90a7 20180323 22:15:15-!- octalot [~steve@178.165.129.225.wireless.dyn.drei.com] has quit [] 20180323 22:15:23< grzywacz> Soliton: noted 20180323 22:22:26< irker073> wesnoth/wesnoth:master Joseph Gelfand e1dae2424f Changed comment to more appropriate styl AppVeyor: vs2015/Release Failed 20180323 22:22:27< irker073> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-2115 20180323 22:25:20<+discordbot4> https://github.com/wesnoth/wesnoth/commit/2e502334f23447609e2553cbbbae8b251f9796bc "manually un-not-translate" Talk about awkward wording @Vultraz. 20180323 22:25:47<+discordbot4> "manually translate" is easier and more accurate. 20180323 22:26:27-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 240 seconds] 20180323 22:36:56< gfgtdf> Soliton: ^ made a pr for the network debug thing, will probably merge it soon. We will probalby change the exact wording later. 20180323 22:37:28< Soliton> thanks i'll take look later. 20180323 22:37:52< gfgtdf> it basicially uses the oos savegame dialog. 20180323 22:38:01< gfgtdf> with different text 20180323 22:38:08< Soliton> that sounds good. 20180323 22:50:55-!- travis-ci [~travis-ci@ec2-54-205-56-74.compute-1.amazonaws.com] has joined #wesnoth-dev 20180323 22:50:56< travis-ci> wesnoth/wesnoth#17125 (gfgtdf-fix_2683 - 30f3a3e : gfgtdf): The build was fixed. 20180323 22:50:56< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/357613700 20180323 22:50:56-!- travis-ci [~travis-ci@ec2-54-205-56-74.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180323 22:57:08-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180323 22:57:14-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180323 23:13:47<+discordbot4> @shadowm it was meant as tongue-in-cheek 20180323 23:14:38< Soliton> loonycyborg: what can i modify to revert the boost 1.56 requirement? preferably without editing the checkout. 20180323 23:15:02< Soliton> loonycyborg: i just want to build wesnothd. 20180323 23:15:21< loonycyborg> well you can reduce version strings in sconstruct 20180323 23:15:27< loonycyborg> but chances are it won't build 20180323 23:16:07< Soliton> was the boost optional stuff in server relevant code? 20180323 23:16:20< gfgtdf> i don't think so. 20180323 23:16:25<+discordbot4> no. it's it unit code. 20180323 23:16:50< Soliton> thought so. then i'll take my chances. 20180323 23:22:29< loonycyborg> we had previously lower boost version requirements for server 20180323 23:22:41< loonycyborg> not sure why all of them got bumped now 20180323 23:22:51< loonycyborg> I assumed it was used in shared code 20180323 23:22:55< loonycyborg> like wesnoth_core 20180323 23:32:41-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev 20180323 23:35:27< irker073> wesnoth/wesnoth:master pentarctagon ca3967cffa Make UTF8 checks fail the build if they AppVeyor: 1/2 builds failed 20180323 23:35:28< irker073> Details vs2017/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-master-1818 20180323 23:40:37<+discordbot4> @Vultraz Any objection to me merging the dunefolk race description PR as-is? 20180323 23:41:05<+discordbot4> do you have all the latest edits? 20180323 23:41:42<+discordbot4> looks like it 20180323 23:41:43<+discordbot4> yep 20180323 23:41:47<+discordbot4> yeah, just merge it 20180323 23:41:50<+discordbot4> we can always tweak later 20180323 23:41:58<+discordbot4> we're not chiseling this in rock 20180323 23:42:15< irker073> wesnoth: pentarctagon wesnoth:master 994e6efa7966 / data/core/ (macros/deprecated-utils.cfg units.cfg units/dunefolk/deprecated.cfg): Remove deprecated Khalifate references. https://github.com/wesnoth/wesnoth/commit/994e6efa796681e0952d4aeb623adcf3cf75d1ef 20180323 23:42:17< irker073> wesnoth: pentarctagon wesnoth:master 3b5cbc3e3c5e / data/core/units.cfg: Add the updated Dunefolk race description. https://github.com/wesnoth/wesnoth/commit/3b5cbc3e3c5e7529412ba38e64145b9303474da3 20180323 23:45:59<+discordbot4> is 2721 good to fo in/ 20180323 23:46:00<+discordbot4> ? 20180323 23:46:17<+discordbot4> yep, was about to do that too 20180323 23:46:33< Soliton> please don't. 20180323 23:46:38<+discordbot4> or not 20180323 23:46:51<+discordbot4> raises eyebrow 20180323 23:47:23< Soliton> i gave a hint earlier but i'm currently writing a comment in the PR. 20180323 23:48:00<+discordbot4> I'm going guess that it's about check_utf8? 20180323 23:48:08< Soliton> yes. 20180323 23:48:19< Soliton> comment added. 20180323 23:49:42<+discordbot4> so: find src/ -type f -print0 | xargs -0 isutf8 -- || exit_code=1? 20180323 23:49:48<+discordbot4> and same for the rest 20180323 23:49:56< Soliton> yes. 20180323 23:50:19< Soliton> even better would be to change the find | xargs to find -exec ... 20180323 23:50:37<+discordbot4> alright. I've never done it that way, so that's not the first thing to come to mind. 20180323 23:51:20< Soliton> it's a common idiom. 20180323 23:51:35< Soliton> checking $? explicitely is rarely needed. 20180323 23:51:51< Soliton> only if you need to check for more than success or failure. 20180323 23:53:49-!- iceiceice [~chris@unaffiliated/iceiceice] has quit [Quit: Leaving] 20180323 23:54:06-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection] 20180323 23:57:46<+discordbot4> alright, now it should be good to go 20180323 23:59:03< Soliton> yes, looks good. thanks. 20180323 23:59:31< irker073> wesnoth: pentarctagon wesnoth:master 344b5c56b90c / utils/travis/ (exit_wrapper.sh install_deps.sh steps/install.sh test_wrapper.sh): Removes a couple scripts that are not used. https://github.com/wesnoth/wesnoth/commit/344b5c56b90cffcbc9638bcb7535bb3e0f073da7 20180323 23:59:33< irker073> wesnoth: pentarctagon wesnoth:master c456d4b288ca / utils/travis/ (check_utf8.sh docker_run.sh steps/script.sh utf8_bom_dog.sh): Make UTF8 checks fail the build if they find anything. https://github.com/wesnoth/wesnoth/commit/c456d4b288ca6df59cca3663c10131f2c75e8574 --- Log closed Sat Mar 24 00:00:13 2018