--- Log opened Sat Mar 24 00:00:13 2018 20180324 00:00:39< irker073> wesnoth: Charles Dang wesnoth:master 3be39a98fe75 / src/ (display.cpp generators/cave_map_generator.hpp): 0 -> nullptr in 2 places https://github.com/wesnoth/wesnoth/commit/3be39a98fe753123ae4685d124876e7a7eb93160 20180324 00:00:42< irker073> wesnoth: Charles Dang wesnoth:master c7367344b1f2 / src/ (sdl/surface.cpp sdl/surface.hpp widgets/widget.cpp widgets/widget.hpp): Removed surface_restorer class https://github.com/wesnoth/wesnoth/commit/c7367344b1f259e2807c757919d48f5ecf4a668f 20180324 00:00:45< irker073> wesnoth: Charles Dang wesnoth:master 85dcef7fa09f / src/ (display.cpp font/marked-up_text.cpp video.cpp video.hpp widgets/widget.cpp): Removed remaining references to window framebuffer surface https://github.com/wesnoth/wesnoth/commit/85dcef7fa09f8a2e760e997363b8df1539534588 20180324 00:00:48< irker073> wesnoth: Charles Dang wesnoth:master c76bef8bb834 / / (24 files in 17 dirs): Merge branch 'master' of github.com:wesnoth/wesnoth https://github.com/wesnoth/wesnoth/commit/c76bef8bb8344e744ff44bc26a7df7ea90a737b6 20180324 00:02:39-!- travis-ci [~travis-ci@ec2-54-224-141-220.compute-1.amazonaws.com] has joined #wesnoth-dev 20180324 00:02:40< travis-ci> wesnoth/wesnoth#17127 (master - 994e6ef : pentarctagon): The build is still failing. 20180324 00:02:40< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/357638487 20180324 00:02:40-!- travis-ci [~travis-ci@ec2-54-224-141-220.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180324 00:04:07< celticminstrel> Ugh, the merges. 20180324 00:09:59-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20180324 00:12:12<+discordbot4> im sorry 20180324 00:12:18<+discordbot4> didn't want to rebase and rebuildall over again 20180324 00:13:05-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180324 00:17:43<+discordbot4> Welllllll I just dipped my toes into that "Preferred Fate of the Dunefolk faction" and it seems just glorious! >_> 20180324 00:18:04<+discordbot4> lol 20180324 00:18:07<+discordbot4> welcome 20180324 00:18:08<+discordbot4> 😄 20180324 00:21:30< celticminstrel> Huh? 20180324 00:21:36< celticminstrel> What are you talking about? 20180324 00:22:08<+discordbot4> which thing? 20180324 00:25:51< irker073> wesnoth/wesnoth:master newfrenchy83 979622204a Update abilities.cfg AppVeyor: 1/2 builds failed 20180324 00:25:52< irker073> Details vs2017/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-master-1819 20180324 00:26:40< celticminstrel> Something about fate of dunefolk. 20180324 00:26:50<+discordbot4> this 20180324 00:26:51<+discordbot4> https://forums.wesnoth.org/viewtopic.php?f=15&t=47895 20180324 00:26:54<+discordbot4> glorious thread 20180324 00:28:05-!- gfgtdf [~chatzilla@x4e3637f0.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.93 [Firefox 52.7.2/20180315163333]] 20180324 00:28:47-!- grzywacz [~karol@wesnoth/developer/grzywacz] has quit [Ping timeout: 268 seconds] 20180324 00:29:33<+discordbot4> It's definitely not how I would've brought it up. 20180324 00:32:09<+discordbot4> Also Krogen has a way too outsized opinion of the ladder's influence 20180324 00:32:16<+discordbot4> I don't think the premise was that stupid a question. What I find ridiculous is how it seems to have dissolved into Ladder elitism. 20180324 00:32:26<+discordbot4> yeah 20180324 00:32:34<+discordbot4> The Ladder barely exists anymore. 20180324 00:32:53< Soliton> how do you know? 20180324 00:32:58<+discordbot4> but as long as there can agreement on what to do, I don't need to argue every point with him. 20180324 00:33:03<+discordbot4> I spoke to the guy who manages it a few months ago. 20180324 00:33:21< Soliton> how does it relate to wesnoth mp in general? 20180324 00:33:36<+discordbot4> What do you mean? 20180324 00:34:07< Soliton> have ladder games decreased as much as mp games in general or more or what? 20180324 00:36:10< Soliton> not that i've caught up on that thread yet but ladder players are certainly a good bet if we want to get the dunefolk better balanced. 20180324 00:36:50<+discordbot4> According to Cackfiend at the end of January, there are 39 active ladder accounts. 20180324 00:37:27<+discordbot4> So. 20180324 00:37:59< celticminstrel> That seems like a fair few to me. 20180324 00:38:07< celticminstrel> I mean, it's a significant number. 20180324 00:38:32<+discordbot4> It's a number. 20180324 00:38:37<+discordbot4> -_- 20180324 00:38:47<+discordbot4> Not significant enough to dictate our entire MP policy. 20180324 00:39:02< celticminstrel> I'm fine with swapping the names so that Default becomes Classic and Default+Khalifate becomes Default. 20180324 00:39:09<+discordbot4> So who should dictate our MP policy according to you? 20180324 00:39:21< celticminstrel> Well, that depends, Vultraz. 20180324 00:39:38< celticminstrel> If there are 39 ladder players and 42 non-ladder MP regulars, then yes it's significant enough. 20180324 00:39:49<+discordbot4> @Vultraz https://forums.wesnoth.org/viewtopic.php?f=15&p=625094#p625094 20180324 00:39:51< Soliton> you can only do that if you fix the description to not claim balance like it does now. 20180324 00:41:06< Soliton> even then it's questionable IMO. 20180324 00:51:45-!- travis-ci [~travis-ci@ec2-54-224-141-220.compute-1.amazonaws.com] has joined #wesnoth-dev 20180324 00:51:46< travis-ci> wesnoth/wesnoth#17130 (master - c76bef8 : Charles Dang): The build is still failing. 20180324 00:51:46< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/357642913 20180324 00:51:46-!- travis-ci [~travis-ci@ec2-54-224-141-220.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180324 00:52:01< Soliton> well, seems like mostly reasonable discussion to me. 20180324 00:53:41< Soliton> there is the assumption that it may not be possible to balance dunefolk reasonably in the context of default. still people are open to the idea. 20180324 00:54:23<+discordbot4> mostly it's just a couple people being a bit overly dramatic 20180324 00:54:30 * Soliton nods. 20180324 01:00:49<+discordbot4> anyway, if you have specific concerns about the thread or anyone who's posting, a non-public channel would be better to discuss. 20180324 01:06:57< irker073> wesnoth/wesnoth:master newfrenchy83 98cf521346 Update wesnoth.cbp AppVeyor: 2/4 builds failed 20180324 01:06:58< irker073> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-2113 20180324 01:06:59< irker073> Details vs2017/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-master-1820 20180324 01:42:41< celticminstrel> Hmm. Looking at 2718... 20180324 01:42:48< celticminstrel> First of all, is that actually not already possible? 20180324 01:43:07< celticminstrel> I guess leadership is an ability, not a weapon special, so it wouldn't have any way to match based on weapons... 20180324 01:43:38< celticminstrel> Oh BTW @Vultraz, did someone remove the commented-out implementation of [defense] (the ability) or do I just fail at searching? 20180324 01:44:11< celticminstrel> Oh, hmm... 20180324 01:44:16<+discordbot4> what? 20180324 01:44:21<+discordbot4> I know not of what you speak 20180324 01:44:59< celticminstrel> You know how there's abilities that modify resistance and damage, but not defense? Someone coded it, decided it was too inefficient, and left it in commented-out. 20180324 01:45:32<+discordbot4> That seems vaguely familiar somehow but I know nothing of i 20180324 01:45:32<+discordbot4> t 20180324 01:45:42< celticminstrel> Just searched again and found it this time. 20180324 01:45:53< celticminstrel> It's in unit.cpp around line 1550. 20180324 01:48:26< celticminstrel> ANYWAY back to 2718. 20180324 01:48:51< celticminstrel> Have you looked at it, Vultraz? 20180324 01:49:48<+discordbot4> I don't really understand what it does 20180324 01:50:09< Soliton> having leadership affect only specific weapons sounds weird. 20180324 01:50:22< celticminstrel> I think it makes sense in context. 20180324 01:51:22< celticminstrel> The example of a mage helping an apprentice with their magic actually seems like a pretty good one. 20180324 01:51:57< celticminstrel> (Oh yeah, BTW someone should check if that commented-out [defense] code actually compiles still and fix it up if not. >_> ) 20180324 01:52:48< celticminstrel> @Vultraz As far as I can tell, what it does is add a [filter_weapon] tag to [leadership] which causes the ability to only take effect when the unit under leadership is using a matching weapon. 20180324 01:53:22<+discordbot4> hmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmm 20180324 01:53:58<+discordbot4> to be clear, can you filter out what units to whom leadership is applied right now? 20180324 01:54:25< celticminstrel> You can filter out units, yes. You could only allow it to apply to units that possess a particular sort of weapon in current Wesnoth. 20180324 01:54:40< Soliton> if it adds new generic possibilities i suppose it's fine. people will find uses for it. 20180324 01:54:42< celticminstrel> However, I'm not sure if you can only apply it to units that are using a particular sort of weapon. 20180324 01:55:31< Soliton> so far his PRs sounded quite specific to some quite specific use cases though. 20180324 01:55:36<+discordbot4> it seems a reasonable idea 20180324 01:57:13< celticminstrel> Yeah, I don't think the PR is that good, but I think the idea may be good. 20180324 01:57:52< celticminstrel> IMO a good implementation of the idea would add: 20180324 01:57:53< celticminstrel> * Ability to match the opponent's weapon 20180324 01:57:53< celticminstrel> * Same abilities in [resistance] 20180324 01:57:55<+discordbot4> His PRs are always all messed up, indent-wise... 20180324 01:58:15< celticminstrel> Disregarding indent, does anyone see issues with the actual code? 20180324 01:58:25<+discordbot4> the code's your area 20180324 01:58:49< celticminstrel> I'm kinda wondering why there's a whole new unit::get_abilities() function. 20180324 01:58:55< celticminstrel> I guess because of the new argument, but... 20180324 01:59:16< celticminstrel> BTW, can weapon specials filter on the opponent's weapon? 20180324 02:00:00< celticminstrel> I think they can, right? 20180324 02:00:45< celticminstrel> So I think what he did was copy the existing unit::get_abilities and add the new argument and logic. 20180324 02:14:09<+discordbot4> do you think I should create the minimap_interactive widget to handle the in-game minimap? 20180324 02:14:13< celticminstrel> FTR, I've basically given up on him regarding code formatting. If he makes the requested changes it can be merged manually. 20180324 02:14:19< celticminstrel> I dunno. 20180324 02:14:50< celticminstrel> The minimap logically fits into the MVC framework, sharing the M but having a different V and maybe a different C. 20180324 02:15:52<+discordbot4> whyy do you keep bringing up MVC 20180324 02:16:16-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20180324 02:18:20< celticminstrel> Because it fits very well in this situation and is IMO not overengineering the situation. 20180324 02:18:50<+discordbot4> I do not understand MVC 20180324 02:19:31< celticminstrel> Then, you should learn. 20180324 02:19:33<+discordbot4> At all. And the only instances I've seen of it in wesnoth have made me hate it. So if you want me to use it, could you please just do more than say "use MVC!" 😦 20180324 02:19:40< celticminstrel> TBF I don't fully understand it either. 20180324 02:20:10<+discordbot4> There's ridiculous stuff like it being used for the Mp Change COntrol dialog (formally) and the chat log 20180324 02:20:29< celticminstrel> Does the player controller etc count as one of the uses you've seen in Wesnoth or are you only talking about the GUI2 dialogs that needlessly used it? 20180324 02:20:38< celticminstrel> Like the Lua console for example. 20180324 02:20:45<+discordbot4> GUI2 dialogs that needlessly use it. 20180324 02:20:55< celticminstrel> The gamestate inspector, too. Does that one still use it actually? 20180324 02:21:10<+discordbot4> I think so? 20180324 02:23:10< irker073> wesnoth: Charles Dang wesnoth:master 5ece7ac5b710 / / (6 files in 4 dirs): Split the rect_of_hexes struct into its own file https://github.com/wesnoth/wesnoth/commit/5ece7ac5b71032ec2c6f9bccb57be9a0a863c5ba 20180324 02:30:58<+discordbot4> i swear, the number of times I end up modifying display.hpp... 20180324 02:31:04-!- Bonobo [~Bonobo@203.220.138.198] has joined #wesnoth-dev 20180324 02:41:55< irker073> wesnoth/wesnoth:master pentarctagon 81c87624c4 Make UTF8 checks fail the build if they AppVeyor: 1/2 builds failed 20180324 02:41:56< irker073> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-2114 20180324 03:01:35<+discordbot4> I mean, you're working on the rendering engine. It comes with the territory. 20180324 03:02:00<+discordbot4> (Also before you ask, yes, I'm building master to check your change for #2709.) 20180324 03:03:09<+discordbot4> Also, I have a complaint from the Spanish translation maintainer for you. 20180324 03:03:47<+discordbot4> hm? 20180324 03:03:50<+discordbot4> @Vultraz https://forums.wesnoth.org/viewtopic.php?f=7&p=625044#p625044 -- What he's saying is that the label on the right of the player count slider ends up being too long for display. 20180324 03:03:58<+discordbot4> See the screenshot in the post immediately above. 20180324 03:04:24<+discordbot4> That "Cualq" is actually "Cualquiera", cut off because of the engine running out of room for it. 20180324 03:04:39<+discordbot4> That long for "Any"? 20180324 03:04:44<+discordbot4> Yes. 20180324 03:04:49<+discordbot4> 🤔 20180324 03:05:09<+discordbot4> His proposal is to use "Varios" (lit. "many", "various" or "miscellaneous"). 20180324 03:05:16<+discordbot4> Except he claims that the 's' is still cut off. 20180324 03:05:25<+discordbot4> He suggests using a smaller font size. 20180324 03:05:50<+discordbot4> I'll have to look into this 20180324 03:06:20<+discordbot4> src/widgets/widget.cpp: In member function ‘void gui::widget::bg_restore(const SDL_Rect&) const’: src/widgets/widget.cpp:248:41: error: unused parameter ‘rect’ [-Werror=unused-parameter] void widget::bg_restore(const SDL_Rect& rect) const ^~~~ cc1plus: all warnings being treated as errors scons: *** [build/release/widgets/widget.o] Error 1 20180324 03:06:52<+discordbot4> javla helvete... 20180324 03:07:16<+discordbot4> I started singing "can't build master, can't build" to the tune of the Indiana Jones theme track. 20180324 03:07:39<+discordbot4> That was completely random but it accurately describes how much of an adventure building master is these days. 20180324 03:07:42<+discordbot4> can you just comment that out 20180324 03:07:45<+discordbot4> the parameter 20180324 03:07:46<+discordbot4> Illustrates rather. 20180324 03:07:47<+discordbot4> Speaking of a lot of modifications to display.hpp for various reasons. https://sourcemaking.com/refactoring/smells/divergent-change 20180324 03:08:00<+discordbot4> Yeah vultraz I can, why can't the person who made that change happen do it though? 20180324 03:08:12<+discordbot4> because I don't have that warning 😦 20180324 03:08:29<+discordbot4> HOW 20180324 03:08:35<+discordbot4> The method is empty. 20180324 03:08:50<+discordbot4> sometimes i forget while emptying things out 20180324 03:08:53<+discordbot4> There's absolutely no way any compiler will fail to detect the parameter as unused. 20180324 03:08:59< celticminstrel> Even if you don't have the warning it's easy to figure out how to fix it. 20180324 03:09:08< celticminstrel> Just delete the paramter name. 20180324 03:09:18<+discordbot4> Yeah, I know how to fix it. 20180324 03:09:28<+discordbot4> i mean i don't get warned about unused parameters 20180324 03:09:35<+discordbot4> How come? 20180324 03:09:40<+discordbot4> I don't know 20180324 03:09:46<+discordbot4> Can anyone who groks Visual C++ tell Vultraz how to do it? :p 20180324 03:10:39<+discordbot4> Because it's such a basic warning, I dread to think of how many other essential warnings you might be missing with your current set-up. 20180324 03:11:11<+discordbot4> Hm, your RFM commit doesn't fix things. 20180324 03:11:16<+discordbot4> ;_: 20180324 03:11:22<+discordbot4> Are you using the right textdomain? 20180324 03:11:48<+discordbot4> Let me get there and try it out myself. 20180324 03:11:53<+discordbot4> Meh. 20180324 03:12:20<+discordbot4> what even is the textdomain for a N_ string in a header 20180324 03:12:31<+discordbot4> The default textdomain for xgettext. 20180324 03:12:36<+discordbot4> Which is wesnoth. 20180324 03:12:56<+discordbot4> Unless the header defines GETTEXT_DOMAIN to something else (but headers MUST NOT define that). 20180324 03:13:21< celticminstrel> Though it might be alright if they also undeffed it (not that I'm recommending this). 20180324 03:13:31<+discordbot4> NO GETTEXT_DOMAIN IN HEADERS. 20180324 03:13:35<+discordbot4> End of story. 20180324 03:13:51<+discordbot4> Really, a better question here is why these strings need to be in a header at all. 20180324 03:14:05< celticminstrel> Are templates involved? 20180324 03:14:08<+discordbot4> MAKE_ENUM 20180324 03:14:17< celticminstrel> ISTR some strings were in headers because they were in template functions. 20180324 03:14:24< celticminstrel> But I have no idea if that's these strings. 20180324 03:14:53<+discordbot4> MAkE_ENUM is on my list of lame things to get rid of, some day. 20180324 03:15:04<+discordbot4> iceiceice rolls in his grave. 20180324 03:15:16<+discordbot4> (He's Chris Beck, btw. You mentioned his name earlier I believe.) 20180324 03:15:42< celticminstrel> I like the intent of MAKE_ENUM though I'm not sure what I think about the particular implementation. 20180324 03:15:51<+discordbot4> in cases like the loading screen, i dont' use MAKE_ENUM, but a plain enum and an enum-string map 20180324 03:19:44<+discordbot4> Yup, I have the complete fix now. 20180324 03:20:17<+discordbot4> these strings also also usedin the lobby i just remembered 20180324 03:20:28<+discordbot4> Where exactly? 20180324 03:20:32<+discordbot4> top right 20180324 03:20:40<+discordbot4> My commit is a bit bigger than you might expect because of future-proofing. 20180324 03:20:43<+discordbot4> Yes. Where in the code? 20180324 03:21:00<+discordbot4> probably the lobby's file 20180324 03:21:04<+discordbot4> gui/dialogs/multiplayer/lobby 20180324 03:21:35<+discordbot4> I bet you'll find more untranslated strings there.. 20180324 03:22:26< irker073> wesnoth/wesnoth:master Joseph Gelfand e1dae2424f Changed comment to more appropriate styl AppVeyor: 2/4 builds failed 20180324 03:22:27< irker073> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-2115 20180324 03:22:28< irker073> Details vs2017/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-master-1821 20180324 03:22:28<+discordbot4> Um, excuse me, address already in use? 20180324 03:22:36<+discordbot4> There's no way I have a wesnothd already running in here. 20180324 03:23:38<+discordbot4> gdi vultraz. 20180324 03:24:00<+discordbot4> I can't test creating games on the MP server in master because of the "Mandatory WML child missing yet untested for. Please report." error when launching them. 20180324 03:24:14<+discordbot4> huh. 20180324 03:24:17<+discordbot4> i wonder why 20180324 03:24:18<+discordbot4> I'll port the commits over to a temporary branch for 1.14 to test. 20180324 03:26:55<+discordbot4> Whargable 20180324 03:31:23<+discordbot4> Um. 20180324 03:31:44<+discordbot4> Okay, I got the inactive account prompt when trying to join the MP server, and now the game is stuck in the loading screen forever. 20180324 03:32:26<+discordbot4> This appears to happen consistently if you try to join using the name of an account that's been marked inactive. 20180324 03:33:02<+discordbot4> I'll file a bug report, that's a blocker. 20180324 03:33:17<+discordbot4> fuck 20180324 03:33:25<+discordbot4> ing hell 20180324 03:33:32< celticminstrel> ...hmm, wonder if I can make the AI never attack a specific unit if it could be killed in retaliation... 20180324 03:33:40<+discordbot4> @Vultraz Where in the lobby can I see the RFM choice? 20180324 03:33:51<+discordbot4> .... oh wait 20180324 03:33:54<+discordbot4> .... nevermind 20180324 03:33:57<+discordbot4> I think I misremembered 20180324 03:34:01<+discordbot4> yeah, nevermind 20180324 03:34:04<+discordbot4> shakes her first 20180324 03:34:14<+discordbot4> At least that led me to find a new bug huh. 20180324 03:34:15<+discordbot4> that's an Enter Blindfolded options 20180324 03:34:41<+discordbot4> https://cdn.discordapp.com/attachments/259976436490829825/426946932296908809/unknown.png 20180324 03:35:24<+discordbot4> https://cdn.discordapp.com/attachments/259976436490829825/426947112673214481/unknown.png 20180324 03:35:54<+discordbot4> "Modificaciones: Ningún" is grammatically incorrect. 20180324 03:36:17<+discordbot4> "Modificación" is a female noun, "ningún" is a male adjective. 20180324 03:36:30<+discordbot4> Hey, I ain't the Spanish translator 20180324 03:36:44<+discordbot4> I want to know if the English original has a disambiguation prefix. 20180324 03:37:04<+discordbot4> We can't just go and use "Ninguna" in all places where "None" can be used. 20180324 03:37:11< irker073> wesnoth: Charles Dang wesnoth:master 49d36e6eb443 / src/ (display.cpp display.hpp editor/editor_display.cpp editor/editor_display.hpp): Display: always draw the map in the full window https://github.com/wesnoth/wesnoth/commit/49d36e6eb44306fff8d1709c34843932adb76eaf 20180324 03:37:29<+discordbot4> look in lobby.cpp 20180324 03:37:30<+discordbot4> it's there 20180324 03:37:34<+discordbot4> i mean 20180324 03:37:37< irker073> wesnoth: Iris Morelle wesnoth:master 9852064ba937 / src/widgets/widget.cpp: Fix warning about an unused method parameter https://github.com/wesnoth/wesnoth/commit/9852064ba937555fae54462465b159d3332fa1c4 20180324 03:37:39<+discordbot4> that's where the text is 20180324 03:37:40< irker073> wesnoth: Iris Morelle wesnoth:master 5c59fade0f96 / src/ (gui/dialogs/multiplayer/mp_create_game.cpp mp_game_settings.hpp): Use the correct textdomain for the random faction mirror options https://github.com/wesnoth/wesnoth/commit/5c59fade0f96d75e306d48cf3a2448602ae29c7c 20180324 03:37:48<+discordbot4> I don't think I added a prefix 20180324 03:37:51<+discordbot4> Yep. 20180324 03:37:59< celticminstrel> Guessing no-one even thought of this possibility. 20180324 03:38:05<+discordbot4> So we're stuck with the grammatically-incorrect form. 20180324 03:38:06< celticminstrel> Even I didn't think of that one. >_> 20180324 03:38:21<+discordbot4> The perils of composing strings at runtime. 20180324 03:39:04<+discordbot4> This is a tricky one because "None" probably isn't the only string that can cause this kind of problem for translators. 20180324 03:39:06<+discordbot4> btw, I dunno if I ever got your thoughts on the final lobby design 20180324 03:39:15<+discordbot4> I don't play MP. 20180324 03:39:44<+discordbot4> The people you need to poll are the Crazy MP People. 20180324 03:40:32<+discordbot4> the crazy MP people lined up in the peanut gallery and drowned me in requests the last time I did that 20180324 03:40:55<+discordbot4> I still haven't implemented any of them! 😛 20180324 03:40:56<+discordbot4> They are the ones who are going to promote your game bt. 20180324 03:41:02<+discordbot4> Not me. 20180324 03:41:05<+discordbot4> And not the dev team. 20180324 03:41:06<+discordbot4> (to be clear, it was feedback regarding the game display) 20180324 03:41:33<+discordbot4> As ridiculous and toxic as the MP community as a whole is, you're making this stuff for them, not anyone else. 20180324 03:41:51<+discordbot4> (I hope you're not one of those UI designers who design UIs for themselves, at least.) 20180324 03:42:07<+discordbot4> but it was honestly just fucking disheartening, and I haven't done much work on the lobby's UI since then. 20180324 03:42:47< irker073> wesnoth: Charles Dang wesnoth:1.14 0333ddda6cba / src/gui/dialogs/multiplayer/mp_create_game.cpp: MP Create Game: attempt to fix RFM type labels being untranslated (#2709) https://github.com/wesnoth/wesnoth/commit/0333ddda6cbaebdf3191fb4fd63f9ef98cef1e78 20180324 03:42:50< irker073> wesnoth: Iris Morelle wesnoth:1.14 3f63eed68162 / src/ (gui/dialogs/multiplayer/mp_create_game.cpp mp_game_settings.hpp): Use the correct textdomain for the random faction mirror options https://github.com/wesnoth/wesnoth/commit/3f63eed6816258fc888fb0ced3180ffa4dec4a8a 20180324 03:45:00<+discordbot4> by the way, has there been any progress on a 1.14 trailer? 20180324 03:45:13<+discordbot4> It shouldn't get to me, but just the absolute negative reaction to my last refactor of the game display was just...ugh 20180324 03:45:17<+discordbot4> @Pentarctagon no 20180324 03:46:07< celticminstrel> You should at least publicize any requests they made so that someone else could implement them. 20180324 03:46:33<+discordbot4> doofus01's avatar probably isn't helping matters, honestly 20180324 03:46:49<+discordbot4> meh 20180324 03:47:09<+discordbot4> celmin: there's a whole damn forum thread 20180324 03:47:40< celticminstrel> Ah, okay. 20180324 03:47:50< celticminstrel> Still, better to gather them into an easier-to-find place if possible. 20180324 03:48:08<+discordbot4> I haven't decided which ones to do and which ones to ignore 20180324 03:48:49< celticminstrel> Uhuh. 20180324 03:49:37<+discordbot4> @Vultraz The people giving the worst feedback are actually the best part of the audience. They give us the feedback how to make the product better! If we handle their request right (which doesn't mean to fulfill it - sometimes it's enough to hear them out and be professional), they can turn into the most loyal opinion leaders promoting our product. That's because they have strong emotions about it. Much worse is when people just 20180324 03:49:38<+discordbot4> shrug and uninstall the product forever. 20180324 03:50:00<+discordbot4> fair point 20180324 03:51:31<+discordbot4> @Pentarctagon Well, he seems to have replaced his avatar. 20180324 03:51:31<+discordbot4> random: wesnoth actually looks really good with absolutely no in-game UI at all. huh. 20180324 03:51:51<+discordbot4> is happy 20180324 03:51:53<+discordbot4> Yes vultraz. Everything looks good whe it's completely non-functional. 20180324 03:51:59<+discordbot4> 😛 20180324 03:52:39<+discordbot4> The thing is, @Vultraz did not make any effort to publicize the trailers request thread anywhere else. 20180324 03:52:45<+discordbot4> I'm just pondering if someone of my ideas, like a floating minimap, might be viable. 20180324 03:52:55<+discordbot4> ... 20180324 03:52:57<+discordbot4> some of 20180324 03:52:59<+discordbot4> I'd be surprised if it reached the target audience as it is. 20180324 03:55:19<+discordbot4> I think we need to write a more honest statement with regards to what we need from people for 1.14.0 in general, now. 20180324 03:55:29<+discordbot4> Not just the trailer, everything. 20180324 03:55:47<+discordbot4> Testing, bug reporting, translations, porting content, spreading the word. 20180324 03:56:26<+discordbot4> Back in the day a certain someone would've wanted to write a post like that for me. 20180324 03:56:36<+discordbot4> Like that call for help we did. 20180324 03:57:03<+discordbot4> We especially need the MP people to understand why it's important that they test 1.14.0 now. 20180324 03:57:14<+discordbot4> That they test the 1.14 release candidates now. 20180324 03:57:18<+discordbot4> Not 1.14.0, the RCs. 20180324 03:57:34<+discordbot4> When I thought it would be easy, I envisioned a mobile UI like in Majesty: small HUD buttons that expand into bigger items including minimap (which has 3 sizes: collapsed, small, big): https://www.nineoverten.com/wp-content/uploads/2013/01/majesty2.jpg http://www.prostomac.com/wp-content/uploads/2011/10/majesty3.jpg https://arcadelife.files.wordpress.com/2012/12/img_5068.jpg 20180324 03:58:05<+discordbot4> those are all rather messy 20180324 03:58:29<+discordbot4> but I definitely think a better mobile UI will be easier in 1.15 20180324 03:58:31<+discordbot4> Right now I'm on the dev server, and what do I see? 20180324 03:58:34<+discordbot4> Emptiness. 20180324 03:59:25<+discordbot4> maybe I'll speak to LB, though 20180324 03:59:35<+discordbot4> brainstorm some designs 20180324 04:04:27< celticminstrel> Shadowm does have a point. 20180324 04:04:50< celticminstrel> Now's the time to focus on getting 1.14 out and spreading the word. 20180324 04:04:59< celticminstrel> I don't think I'll be of much help for that though. 20180324 04:05:08< celticminstrel> I mean maybe I can help a little. 20180324 04:05:35< celticminstrel> Do the MP people know there's a release candidate? 20180324 04:05:56< celticminstrel> Perhaps that info could be added to the 1.12 server's MOTD? Not sure how much that would help, but it might help a bit? 20180324 04:07:21-!- travis-ci [~travis-ci@ec2-54-224-141-220.compute-1.amazonaws.com] has joined #wesnoth-dev 20180324 04:07:22< travis-ci> wesnoth/wesnoth#17134 (master - 5c59fad : Iris Morelle): The build is still failing. 20180324 04:07:22< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/357679982 20180324 04:07:22-!- travis-ci [~travis-ci@ec2-54-224-141-220.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180324 04:07:37<+discordbot4> might also help if www.wesnoth.org said 1.13.12 now instead of 1.13.11 20180324 04:07:57< celticminstrel> Hmm, it seems that [fire_event] cannot pass a location without a unit... 20180324 04:08:06< celticminstrel> At least according to the wiki... 20180324 04:08:11<+discordbot4> @Vultraz Can you do the website update commit or do you need me to do it myself? 20180324 04:08:21<+discordbot4> I already did it 20180324 04:08:24<+discordbot4> 🤔 20180324 04:08:28<+discordbot4> And I wasn't told? 20180324 04:08:50<+discordbot4> sorry 20180324 04:09:28<+discordbot4> Okay, deployed. 20180324 04:09:47<+discordbot4> I guess I'll add a script to do this half-hourly. 20180324 04:10:19< celticminstrel> Looking at the Lua implementation, it seems as though it'll take x and y from the filter if it matches nothing. Should probably document that. 20180324 04:10:22<+discordbot4> For RC 2 I'd like to switch to the dev branch as the default on the front page. 20180324 04:10:35<+discordbot4> I believe I made provisions in the code to enable that possibility. 20180324 04:16:04<+discordbot4> just realized in 1.16 it will actually be incredibly simple to implement an action to totally hide the in-game UI 20180324 04:16:10<+discordbot4> if we want that 20180324 04:19:13<+discordbot4> I think it was mentioned before about possibly having a tournament of sorts to try to encourage people to try it out. 20180324 04:20:25<+discordbot4> maybe even work in using the +Dunefolk era, now that that's a topic 20180324 04:21:02<+discordbot4> dunno if I'd have the time to organize something like that though, and I've never done anything like it before either 20180324 04:24:21< celticminstrel> If it's simple, let's do it. :P 20180324 04:26:00<+discordbot4> I suggested a tournament for 1.11.x as well, nobody really adopted the idea. 20180324 04:26:51<+discordbot4> celticminstrel: If I thought it was simple, I'd just say I'd do it 😛 20180324 04:27:13< celticminstrel> Sorry, that was at @Vultraz. 20180324 04:27:17< celticminstrel> I guess that wasn't clear. 20180324 04:27:34<+discordbot4> yeah 20180324 04:27:35<+discordbot4> later 20180324 04:27:46< celticminstrel> Of course. 20180324 04:33:31<+discordbot4> celticminstrel: now, you said i need to re-enable that checkbox in the comand console? 20180324 04:33:33<+discordbot4> commmmmmmmand 20180324 04:34:35< celticminstrel> If by command console you mean "the place where you type : commands" then no. If by command console you mean "the general bottom-of-window text entry area that's used for multiple things", then yes. 20180324 04:34:45< celticminstrel> You only need the checkbox for chat. 20180324 04:34:53< celticminstrel> It should not be shown for commands or search. 20180324 04:35:03< celticminstrel> (Were there other uses for that area? I can't remember any others.) 20180324 04:35:20<+discordbot4> I created a game on the 1.14 server and tere's a vacant slot but people don't get the Join option? 20180324 04:35:47< celticminstrel> IMO it's not high priority since it's more of a convenience than a necessity (you can always do team chat with alt+C IIRC), but if you want to do it now, go ahead I guess. 20180324 04:36:15<+discordbot4> Same issue again. 20180324 04:36:52<+discordbot4> wth 20180324 04:36:58-!- celticminstrel is now known as celmin|sleep 20180324 04:37:06<+discordbot4> @Vultraz How do I open up a game for people to join as players instead of observers? 20180324 04:37:16<+discordbot4> what?? 20180324 04:37:21<+discordbot4> O_O 20180324 04:37:28<+discordbot4> Join the 1.13 server. 20180324 04:37:32<+discordbot4> server.wesnoth.org:14997 20180324 04:37:40<+discordbot4> The Join option is grayed out. 20180324 04:38:40<+discordbot4> what do you see for mine? 20180324 04:38:48<+discordbot4> Grayed out too. 20180324 04:38:52<+discordbot4> I can only observe. 20180324 04:38:54<+discordbot4> what in goddamn hell 20180324 04:39:12<+discordbot4> THIS WASN'T THE CASE LAST TIMEI TOUCHED THIS CODE 20180324 04:39:22<+discordbot4> could it possibly be a version issue 20180324 04:39:25<+discordbot4> like does this happen with 1.13.11 20180324 04:39:46<+discordbot4> I think he just confirmed it's a regression. 20180324 04:40:25<+discordbot4> never mind you can't even connect with 1.13.11 anymore 20180324 04:41:13<+discordbot4> @shadowm I can't repro theproblem on a local wesnothd instance 20180324 04:41:17<+discordbot4> what the hell 20180324 04:41:33<+discordbot4> Was there a wesnothd fix you didn't inform me about? 20180324 04:41:41<+discordbot4> Of course currently I can't even build a newer wesnothd. 20180324 04:41:50<+discordbot4> I don't think so... 20180324 04:42:37<+discordbot4> I assume the server was rebuilt after the crypto changes 20180324 04:42:41< celmin|sleep> I imagine you could hack the scons script to not require Boost 1.56 and then build a newer wesnothd. Pretty sure the new Boost features were only used in the game, not the server. 20180324 04:42:56< celmin|sleep> Might be worth a try in any case. 20180324 04:42:58<+discordbot4> Give me a patch. 20180324 04:43:05< irker073> wesnoth/wesnoth:1.14 gfgtdf d763799221 f2 AppVeyor: vs2015/Debug Failed 20180324 04:43:06< irker073> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-1.14-2127 20180324 04:43:15<+discordbot4> Except I cannot really use the patch without breaking the hourly git pull. 20180324 04:43:26< celmin|sleep> @shadowm Easiest way I guess would be to git revert the version bump commit? 20180324 04:43:27<+discordbot4> Oh fuck this. 20180324 04:43:39<+discordbot4> That's exactly what I decided to do when I said "fuck this". 20180324 04:43:50< celmin|sleep> :) 20180324 04:44:14< irker073> wesnoth: Iris Morelle wesnoth:1.14 6265181b5792 / CMakeLists.txt INSTALL.md SConstruct: Revert "Bump min Boost version to 1.56.0" https://github.com/wesnoth/wesnoth/commit/6265181b579230b5764b8d29afe099b1185d5617 20180324 04:47:09< irker073> wesnoth: Iris Morelle wesnoth:master cdf9b465c668 / CMakeLists.txt INSTALL.md SConstruct: Revert "Bump min Boost version to 1.56.0" https://github.com/wesnoth/wesnoth/commit/cdf9b465c668648721c4638ce117da130ad36284 20180324 04:47:30<+discordbot4> Need to update update_server to use the 1.14 branch for 1.13. 20180324 04:47:33<+discordbot4> why on master? 20180324 04:47:40<+discordbot4> See above. 20180324 04:48:56<+discordbot4> Oh hell no. 20180324 04:49:00<+discordbot4> master is unbuildable anyway. 20180324 04:49:16<+discordbot4> I'm seeing pages and pages of errors. 20180324 04:50:40<+discordbot4> Hopefully 1.14 doesn't have the same issue, otherwise I'm going to want my squeaky mallet back. 20180324 04:51:03<+discordbot4> And now I have a migraine. 20180324 04:51:07<+discordbot4> *squeak 20180324 04:52:19<+discordbot4> I suppose it would be pointless to ask people to try playing on the 1.14 server right now, then 20180324 04:52:30<+discordbot4> Let me see if rebuilding the server fixes it first. 20180324 04:54:06< irker073> wesnoth: Iris Morelle wesnoth:master f6a128579ad6 / CMakeLists.txt INSTALL.md SConstruct: Revert "Revert "Bump min Boost version to 1.56.0"" https://github.com/wesnoth/wesnoth/commit/f6a128579ad6d94cc7c8a57bebd1fc2bb0f735a0 20180324 04:55:25<+discordbot4> CRISIS AVERTED. 20180324 04:55:30<+discordbot4> Rebuilding the server fixed the issue. 20180324 04:56:25<+discordbot4> @Yumi 20180324 04:58:31<+discordbot4> hey 20180324 04:58:31<+discordbot4> it works 20180324 04:58:33<+discordbot4> 😄 20180324 04:59:32<+discordbot4> @Vultraz Not sure how I feel about the fact that the map name is more prominent than the match name now. 20180324 04:59:38<+discordbot4> How do other people feel? 20180324 05:03:44<+discordbot4> Badly 20180324 05:03:56<+discordbot4> That was a consistent complaint 20180324 05:04:53<+discordbot4> It makes it really hard to find matches you know you're looking for. 20180324 05:05:26<+discordbot4> Without typing into the filter box, at least. But you yourself can attest to the fact that most people would rather use the mouse first. 20180324 05:21:22-!- travis-ci [~travis-ci@ec2-54-205-56-74.compute-1.amazonaws.com] has joined #wesnoth-dev 20180324 05:21:23< travis-ci> wesnoth/wesnoth#17138 (master - f6a1285 : Iris Morelle): The build is still failing. 20180324 05:21:23< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/357689730 20180324 05:21:23-!- travis-ci [~travis-ci@ec2-54-205-56-74.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180324 05:23:15< irker073> wesnoth/wesnoth:1.14 Nils Kneuper 3f4d003f13 updated Spanish translation AppVeyor: All builds passed 20180324 05:59:05<+discordbot4> hm. 20180324 05:59:10<+discordbot4> I just realized something... 20180324 05:59:35<+discordbot4> I might be looking at this event problem with modal dialogs from the wrong angle.. 20180324 06:00:19<+discordbot4> https://cdn.discordapp.com/attachments/259976436490829825/426983580602728449/unknown.png 20180324 06:00:25<+discordbot4> Somehow Mint is still in a game except the game already ended. 20180324 06:00:31<+discordbot4> I think...I might have inadvertently broken the distinction between modal and modeless dialogs? 20180324 06:00:58<+discordbot4> @shadowm server-side issue, i think 20180324 06:02:08<+discordbot4> damn, your text rendering is so much better than mine. 20180324 06:02:54<+discordbot4> also reminds me i was going to make server messages a different color 20180324 06:17:00<+discordbot4> ok, let me think 20180324 06:17:18-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev 20180324 06:17:31<+discordbot4> a modal dialog is supposed to mean you need to deal with that dialog 20180324 06:17:40<+discordbot4> and a modeless dialog means you can do other stuff 20180324 06:18:47<+discordbot4> so it seems reasonable that creating a modal at least would be its own event context 20180324 06:18:51<+discordbot4> let me see how that works out.. 20180324 06:20:59<+discordbot4> "Can anyone who groks Visual C++ tell Vultraz how to do it? :p" @shadowm The warning in question is C4100 (https://msdn.microsoft.com/en-us/library/26kb9fy0.aspx), enabled by default at /W4. 20180324 06:21:34<+discordbot4> Turns out that while our Visual Studio project makes debug builds with /W4, it only uses /W3 for release builds. 20180324 06:21:46<+discordbot4> Of course, Vultraz uses release builds for everything. 20180324 06:22:11<+discordbot4> I'll increase the warning level to /W4 for release builds as well, and specifically make C4100 an error. 20180324 06:29:52< irker073> wesnoth/wesnoth:master doofus-01 bb9122f301 defense animations for sun-singer and su AppVeyor: vs2017/Release Failed 20180324 06:29:53< irker073> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-master-1839 20180324 06:33:38<+discordbot4> Building master at /W4 and C4100-as-error gives me 5 errors and 55 warnings. Let's see how many I can fix... 20180324 06:33:54<+discordbot4> p_p 20180324 06:35:15<+discordbot4> Hm, we have C4100 within Boost. That means I can't make it an error. 😦 20180324 06:35:39<+discordbot4> honestly, doesn't need to be an error 20180324 06:35:44<+discordbot4> a warning is fine 20180324 06:50:11<+discordbot4> Hm, this is quite nice. try{ std::vector::iterator it = std::find(observers_.begin(), observers_.end(), obs); if (it == observers_.end()){ handler_detached = false; } else{ observers_.erase(it); handler_detached = true; } } catch (...){ change_handler_ = false; throw; 20180324 06:50:12<+discordbot4> } Visual C++ was able to prove that the code in the try block never throws exceptions, and thus the catch block is unreachable code. 20180324 06:50:16<+discordbot4> Removing. 20180324 06:57:03<+discordbot4> cpp #include int main(int, char**) { std::cerr << "Hello world!\n"; return 0; } 20180324 06:57:38<+discordbot4> why is that suddenly colored o_O 20180324 06:57:49<+discordbot4> Just as a reminder, you can set the language on the same line as the opening graves to choose a syntax highlighter. 20180324 06:57:57<+discordbot4> C++'s is cpp. 20180324 06:58:12<+discordbot4> mein gott 20180324 06:58:36<+discordbot4> prior or after? 20180324 06:59:18<+discordbot4> I recall trying it before, but it only ended up showing the language name in the first line. 20180324 06:59:27<+discordbot4> (Or maybe it was in Slack.) 20180324 06:59:39<+discordbot4> cpp if(event_context_ && is_modal_window(disp)) { itor = std::find_if(dispatchers_.rbegin() + 1, dispatchers_.rend(), is_modal_window); if(itor == dispatchers_.end()) { leave(); event_context_.reset(nullptr); } } 20180324 06:59:42<+discordbot4> 😮 20180324 06:59:52<+discordbot4> how did I not know you could do this 20180324 07:00:15<+discordbot4> "but vultraz you love discord so much and you don't even know how to use it" 20180324 07:00:32<+discordbot4> Oh dear, you're turning into Gambit. 20180324 07:00:42<+discordbot4> even worse! 20180324 07:00:55<+discordbot4> He used to hear my voice as his conscience. 20180324 07:01:34<+discordbot4> GitHub has better syntax highlighting than Discord, BTW. Discord only seems to highlight keywords and types. 20180324 07:01:59<+discordbot4> Yeah, that comes with the territory of GitHub being a platform for coders and Discord... not being one. 20180324 07:02:40<+discordbot4> GitHub's Markdown is also much richer. 20180324 07:02:54<+discordbot4> I find it admirable that even as a platform dedicated for gamers they've worked on some features to allow direct integration with places like GH. 20180324 07:03:06<+discordbot4> (Which is a pity when it's time to write a rules post on a Discord.) 20180324 07:03:21<+discordbot4> you can use markdown here? O_O 20180324 07:03:29<+discordbot4> Admirable? It's just convenience. 20180324 07:03:37<+discordbot4> Yes, vultraz. Those formatting things are Markdown. 20180324 07:03:54<+discordbot4> Blah blah blah the blah blah 20180324 07:04:19<+discordbot4> https://support.discordapp.com/hc/en-us/articles/210298617-Markdown-Text-101-Chat-Formatting-Bold-Italic-Underline- 20180324 07:04:59< vn971> The IRC bridge won't handle some of the formatting though, I think. 20180324 07:05:23< vn971> Or better to say, most of it. Anything non-unicode. 20180324 07:05:27<+discordbot4> Naturally, it can't handle most of it. 20180324 07:05:55<+discordbot4> Multi-line code blocks in particular do not work because in IRC newlines (specifically CR LF) are line terminators. 20180324 07:06:01<+discordbot4> And each line is a command. 20180324 07:06:54< vn971> Nice to see "call for testing" on the current stable multiplayer server! I think it's just the right action, hopefully it'll bring in more testers, and more bug reports. 20180324 07:07:00<+discordbot4> e.g. :shadowm!~iris@wesnoth/developer/shadowm PRIVMSG #wesnoth-dev :This is actually a public message to the channel #wesnoth-dev 20180324 07:07:31<+discordbot4> So the very concept of "multiline messages" is incompatible with IRC. 20180324 07:07:36<+discordbot4> Modulo client-specific extensions. 20180324 07:08:09<+discordbot4> And also individual lines have a character limit of 512 including the CR-LF sequence and the sender prefix. 20180324 07:08:15<+discordbot4> And the command bits. 20180324 07:09:21<+discordbot4> The few bits of formatting you see on IRC like bold, underline, italics, colour codes, are actually not part of the protocol, client-specific extensions (mainly from mIRC) that clients eventually adopted as a de facto thing. 20180324 07:09:29< vn971> yeah that too. IRC only works for simple not-very-long messages really. No real "mentions", no real "reply to this specific message", no multi-lines, no colors etc. 20180324 07:10:39< vn971> still lightweight and nice if you avoid non-free software.:P :) 20180324 07:11:03<+discordbot4> Unfortunately IRC is so fragmented as a platform and there are so many IRC networks all running their own ircds, that it's pretty much impossible for there to be a central authority filing out additions to the original RFCs, unlike e.g. freedesktop.org. 20180324 07:11:30<+discordbot4> Developing an IRC client is harder than it sounds because of that platform fragmentation. 20180324 07:12:22<+discordbot4> Things as ubiquitous as the WHOIS and MODE commands tend to have server-specific extensions and semantics. 20180324 07:12:53<+discordbot4> Even PRIVMSG often has server-specific extensions that clients don't always know how to use or handle gracefully. 20180324 07:13:37<+discordbot4> And don't even get me started on IRC user management services. 20180324 07:14:39<+discordbot4> Those are decidedly not part of the protocol and there are way too many implementations of the same concept. 20180324 07:14:55<+discordbot4> All incompatible with each other. 20180324 07:15:44<+discordbot4> I think I need to disable C4127. https://msdn.microsoft.com/en-us/library/6t66728h.aspx It fires even if the constant being checked is a template parameter. Fixing it "properly" would require converting easy-to-understand if statements into hard-to-read template code. 20180324 07:17:54-!- octalot [~steve@178.165.129.225.wireless.dyn.drei.com] has joined #wesnoth-dev 20180324 07:41:56< irker073> wesnoth/wesnoth:gfgtdf-fix_2683 gfgtdf 30f3a3ec2d f2 AppVeyor: All builds passed 20180324 07:42:48< irker073> wesnoth: Jyrki Vesterinen wesnoth:master d4c9db9e3529 / / (10 files in 6 dirs): Visual Studio: increased warning level to /W4 even for release builds https://github.com/wesnoth/wesnoth/commit/d4c9db9e3529434bf29a4ed237bc64e67f868f45 20180324 08:08:59-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection] 20180324 08:15:51-!- zookeeper_ [~lmsnie@95.175.104.119] has joined #wesnoth-dev 20180324 08:17:02-!- zookeeper_ is now known as zookeeper 20180324 08:17:04-!- zookeeper [~lmsnie@95.175.104.119] has quit [Changing host] 20180324 08:17:04-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20180324 09:01:32<+discordbot4> /Users/user/xcode/wesnoth/src/map/hex_rect.hpp:39:9: Suggest braces around initialization of subobject /Users/user/xcode/wesnoth/src/arrow.cpp:20:10: In file included from /Users/user/xcode/wesnoth/src/arrow.cpp:20: /Users/user/xcode/wesnoth/src/arrow.hpp:22:10: In file included from /Users/user/xcode/wesnoth/projectfiles/Xcode/../../src/arrow.hpp:22: /Users/user/xcode/wesnoth/src/display.hpp:60:10: In file included from 20180324 09:01:32<+discordbot4> /Users/user/xcode/wesnoth/projectfiles/Xcode/../../src/display.hpp:60: /Users/user/xcode/wesnoth/src/map/hex_rect.hpp:40:12: Suggest braces around initialization of subobject /Users/user/xcode/wesnoth/src/arrow.cpp:20:10: In file included from /Users/user/xcode/wesnoth/src/arrow.cpp:20: /Users/user/xcode/wesnoth/src/arrow.hpp:22:10: In file included from /Users/user/xcode/wesnoth/projectfiles/Xcode/../../src/arrow.hpp:22: 20180324 09:01:33<+discordbot4> /Users/user/xcode/wesnoth/src/display.hpp:60:10: In file included from /Users/user/xcode/wesnoth/projectfiles/Xcode/../../src/display.hpp:60: 20180324 09:03:08<+discordbot4> Already planning to fix it. (I first want to reproduce it locally, to make sure that my fix really fixes it.) 20180324 09:03:46<+discordbot4> you can send me fix here and I'll try it for you. I have it precompiled already 20180324 09:04:00<+discordbot4> No need. It should be trivial. 20180324 09:04:54<+discordbot4> This PR is related to it 20180324 09:12:19< irker073> wesnoth: Jyrki Vesterinen wesnoth:master 2257c0377159 / src/ (map/hex_rect.hpp scripting/lua_common.cpp): Fix build with GCC and Clang https://github.com/wesnoth/wesnoth/commit/2257c03771596060c0523a4e597431caeff3d8a0 20180324 09:12:56< irker073> wesnoth: Sofartin wesnoth:master 29b12782a82b / projectfiles/Xcode/Wesnoth.xcodeproj/project.pbxproj: Fixed Xcode Project after 5ece7ac5b71032ec2c6f9bccb57be9a0a863c5ba https://github.com/wesnoth/wesnoth/commit/29b12782a82be70965faf38bfffa2aeacc1ac0ac 20180324 09:13:20-!- travis-ci [~travis-ci@ec2-50-17-85-166.compute-1.amazonaws.com] has joined #wesnoth-dev 20180324 09:13:21< travis-ci> wesnoth/wesnoth#17141 (master - 2257c03 : Jyrki Vesterinen): The build was canceled. 20180324 09:13:21< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/357724283 20180324 09:13:21-!- travis-ci [~travis-ci@ec2-50-17-85-166.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180324 09:37:34-!- grzywacz [~karol@89-70-226-147.dynamic.chello.pl] has joined #wesnoth-dev 20180324 09:39:11< irker073> wesnoth: Jyrki Vesterinen wesnoth:master fbfa82c6b10b / src/floating_label.cpp: Remove error message if creating texture for floating label fails https://github.com/wesnoth/wesnoth/commit/fbfa82c6b10bffdd920638e5abc6373767f673b3 20180324 09:43:07< irker073> wesnoth/wesnoth:1.14 gfgtdf d763799221 f2 AppVeyor: 1/4 builds failed 20180324 09:43:08< irker073> Details vs2015/Debug: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-1.14-2127 20180324 09:53:00-!- travis-ci [~travis-ci@ec2-54-145-185-49.compute-1.amazonaws.com] has joined #wesnoth-dev 20180324 09:53:01< travis-ci> wesnoth/wesnoth#17142 (master - 29b1278 : Sofartin): The build is still failing. 20180324 09:53:01< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/357724345 20180324 09:53:01-!- travis-ci [~travis-ci@ec2-54-145-185-49.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180324 09:58:36-!- vn971 [~vasya@94.158.103.15] has quit [Remote host closed the connection] 20180324 10:04:02-!- travis-ci [~travis-ci@ec2-54-145-185-49.compute-1.amazonaws.com] has joined #wesnoth-dev 20180324 10:04:03< travis-ci> wesnoth/wesnoth#17143 (master - fbfa82c : Jyrki Vesterinen): The build failed. 20180324 10:04:03< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/357728337 20180324 10:04:03-!- travis-ci [~travis-ci@ec2-54-145-185-49.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180324 10:21:42<+discordbot4> @jyrkive the last issues about event contexts are rather odd. It means the fake_display's event context hasn't been initialized before it attempts to initialize a gui2 dialog for testing. 20180324 10:22:06<+discordbot4> or... 20180324 10:22:25<+discordbot4> actually, I suppose it could also mean that that's the only event context 🤔 20180324 10:22:49<+discordbot4> I guess nothing in wesnoth.cpp runs with the tests? 20180324 10:23:09<+discordbot4> if so then yes, it is the only context 20180324 10:23:21<+discordbot4> in which case we should just disable that assertion when running the tests 20180324 10:23:40<+discordbot4> Shouldn't the global event context be created implicitly? 20180324 10:23:56<+discordbot4> If object X creates its own event context, it shouldn't be the global context. 20180324 10:24:05<+discordbot4> (The first event context is always the global one.) 20180324 10:24:27<+discordbot4> right now the global context is initialized at wesnoth.cpp:1116 20180324 10:24:43<+discordbot4> That's a wrong place. 20180324 10:24:48<+discordbot4> but you're right, actually, it would probably be better to auto-initialize at least 1 context 20180324 10:24:57<+discordbot4> wesnoth.cpp isn't even linked in to the unit test executable. 20180324 10:25:40<+discordbot4> ok 20180324 10:25:42<+discordbot4> I'll fix it 20180324 10:37:45< irker073> wesnoth: gfgtdf wesnoth:gfgtdf-fix_2683 48a810b380a8 / src/synced_commands.cpp: add a vgettext https://github.com/wesnoth/wesnoth/commit/48a810b380a87fc2e657bafb615dac3b2221986f 20180324 10:44:41-!- midzer_ [~quassel@p5B312805.dip0.t-ipconnect.de] has joined #wesnoth-dev 20180324 10:49:06-!- gfgtdf [~chatzilla@x4e3680f2.dyn.telefonica.de] has joined #wesnoth-dev 20180324 10:49:13< gfgtdf> zookeeper: did you saw this: https://forums.wesnoth.org/viewtopic.php?f=38&t=828&start=540#p625082 20180324 10:52:11-!- Bhoren [~Bhoren_wh@2a01:e0a:c:2150:211e:96:9e16:a70c] has joined #wesnoth-dev 20180324 10:52:25-!- midzer_ [~quassel@p5B312805.dip0.t-ipconnect.de] has quit [Remote host closed the connection] 20180324 11:02:32< irker073> wesnoth: gfgtdf wesnoth:1.14 74ca37f97bba / src/game_initialization/create_engine.cpp: fix initial selection of mods in sp https://github.com/wesnoth/wesnoth/commit/74ca37f97bba4d2dc1cf0ec2c2b146bd00102451 20180324 11:05:54< irker073> wesnoth: gfgtdf wesnoth:1.14 e379fdb30447 / src/ (play_controller.hpp synced_commands.cpp): show the oos savegame dialog when receiving a debug command in mp https://github.com/wesnoth/wesnoth/commit/e379fdb30447262c21cde7e6b8d8f7ed2b5c24e5 20180324 11:29:53< irker073> wesnoth/wesnoth:master doofus-01 bb9122f301 defense animations for sun-singer and su AppVeyor: 2/4 builds failed 20180324 11:29:54< irker073> Details vs2017/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-master-1839 20180324 11:29:55< irker073> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-2133 20180324 11:43:27< zookeeper> @Vultraz i'm going to assume this is probably your fault too: https://forums.wesnoth.org/viewtopic.php?p=625082#p625082 20180324 11:45:57< gfgtdf> zookeeper: it clearly is, but i think it's exactly the same line you 'fixed' 20180324 11:46:13< zookeeper> oh right, so there's a semantic problem too 20180324 12:14:37-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180324 12:56:37<+discordbot4> @hrubymar10 Why is it necessary to add libboost_chrono and libboost_timer to the XCode project explicitly? Isn't the linker smart enough to automatically pull in recursive dependencies? 20180324 13:10:59< irker073> wesnoth: newfrenchy83 wesnoth:master 67f2ba9767e6 / projectfiles/CodeBlocks/wesnothd.cbp: Update wesnothd.cbp https://github.com/wesnoth/wesnoth/commit/67f2ba9767e659d9e6589b1279d8eb5e6c5fd2af 20180324 13:17:37< irker073> wesnoth/wesnoth:1.14 Iris Morelle 6265181b57 Revert "Bump min Boost version to 1.56.0 AppVeyor: All builds passed 20180324 13:27:16<+discordbot4> @jyrkive it don't have to be in project, but it is good IMO. there are already other deps Xcode in project which aren't required straight but are dependences of dependencies 20180324 13:27:36<+discordbot4> Okay. 20180324 13:27:43< irker073> wesnoth: Sofartin wesnoth:master 00e9f4482fee / projectfiles/Xcode/ (Fix_Xcode_Dependencies Wesnoth.xcodeproj/project.pbxproj): Add new unit_tests dependencies https://github.com/wesnoth/wesnoth/commit/00e9f4482feecc21ffa88f1a0f8e24f6160f007c 20180324 13:28:31<+discordbot4> can you also merge it to 1.14? 20180324 13:28:41<+discordbot4> Yes. I'm on it. 20180324 13:28:50<+discordbot4> ty 20180324 13:29:57< irker073> wesnoth: Sofartin wesnoth:1.14 cffdf8a597ce / projectfiles/Xcode/ (Fix_Xcode_Dependencies Wesnoth.xcodeproj/project.pbxproj): Add new unit_tests dependencies https://github.com/wesnoth/wesnoth/commit/cffdf8a597cec4aa37060dc0ece52a6d66b76129 20180324 13:32:43-!- travis-ci [~travis-ci@ec2-54-224-141-220.compute-1.amazonaws.com] has joined #wesnoth-dev 20180324 13:32:44< travis-ci> wesnoth/wesnoth#17150 (master - 67f2ba9 : newfrenchy83): The build is still failing. 20180324 13:32:44< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/357771675 20180324 13:32:44-!- travis-ci [~travis-ci@ec2-54-224-141-220.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180324 14:28:35< gfgtdf> Soliton: do 1.13+dev and 1.15+dev have diffrent mp servers ? 20180324 14:28:53< Soliton> yes. 20180324 14:29:28< gfgtdf> ok thx 20180324 14:29:40-!- travis-ci [~travis-ci@ec2-54-224-141-220.compute-1.amazonaws.com] has joined #wesnoth-dev 20180324 14:29:41< travis-ci> wesnoth/wesnoth#17152 (master - 00e9f44 : Sofartin): The build is still failing. 20180324 14:29:41< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/357775240 20180324 14:29:41-!- travis-ci [~travis-ci@ec2-54-224-141-220.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180324 14:31:35< Soliton> [debug_create_unit] is one of the synced debug commands, yes? 20180324 14:33:33< gfgtdf> yes, basicially all commands whose names with debug' 20180324 14:34:22< Soliton> ok, so it looks like they're illegal commands for now anyway. 20180324 14:34:35< gfgtdf> huh ? 20180324 14:34:51< gfgtdf> debug_create_unit shouldn'T be illegal 20180324 14:35:14< gfgtdf> maybe you tried to invoke them suring an opponents turn ? 20180324 14:35:22< Soliton> 20180324 14:25:05 info server: ILLEGAL COMMAND in game: 36 ((( 20180324 14:35:22< Soliton> from_side=1 20180324 14:35:22< Soliton> [debug_create_unit] 20180324 14:35:27< gfgtdf> synced commands cannot be invoked during anoppenents turn. 20180324 14:35:34< Soliton> just saw that in the server log. 20180324 14:35:40< gfgtdf> that was probably the test game i did right now 20180324 14:35:48< Soliton> ah, i see. 20180324 14:35:53< gfgtdf> whewre i also tested usign thme during an opponenets turn 20180324 14:36:06< gfgtdf> synced commands cannot be used during an opponents turn. 20180324 14:36:41< gfgtdf> (normal or debug commands doesnt matter) 20180324 14:38:00< Soliton> oh, so i was wrong about the versions earlier. 1.13+dev and 1.15+dev both go to the trunk server. 1.13.12 would go to the 1.13/1.14 server though. 20180324 14:39:37< gfgtdf> hmm, iirc 1.15 has no changes related to mp yet so no problem for now, but if that happens it shodul be changed 20180324 14:40:54-!- atarocch [~atarocch@93.56.164.28] has quit [Remote host closed the connection] 20180324 14:42:05-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Quit: wedge009] 20180324 14:42:10< Soliton> it'll change automatically when the version is 1.14+dev. 20180324 14:42:48-!- celmin|sleep is now known as celticminstrel 20180324 14:48:50-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev 20180324 14:57:45< octalot> where would 1.13.12+dev go (as in, can we test bugfixes on the mp server with the 1.13.12 players)? 20180324 14:58:29< Soliton> yes, but you need to explicitely join port 14997. 20180324 14:58:57< octalot> ah, thanks 20180324 14:59:19< Soliton> with +dev you can even join 1.12 and probably have a good chance to find more issues. 20180324 14:59:35< Soliton> 1.12 is port 14998. 20180324 15:00:19< Soliton> naturally some of those issue might be because of version differences but the lobby stuff is mostly the same. 20180324 15:30:51-!- Bonobo [~Bonobo@203.220.138.198] has quit [Ping timeout: 240 seconds] 20180324 15:44:28< irker073> wesnoth: Celtic Minstrel wesnoth:1.14 667b2b7bd342 / src/ (actions/attack.cpp units/abilities.cpp): Revert use of boost::optional::emplace for attack specials contexts https://github.com/wesnoth/wesnoth/commit/667b2b7bd3425516bd084eb9bc036dafd3ecf584 20180324 15:45:03-!- Oebele [~quassel@92-110-163-84.cable.dynamic.v4.ziggo.nl] has joined #wesnoth-dev 20180324 15:45:36< celticminstrel> Is it my imagination or is F5 much faster in 1.13.12 than in 1.12? 20180324 15:45:59< celticminstrel> Or maybe it's just a function of the different computer (I was using 1.12 on my Mac but am using 1.13.12 on my Windows). 20180324 15:46:05< Soliton> same amount of addons? 20180324 15:46:09< celticminstrel> I think so? 20180324 15:46:26< celticminstrel> Maybe not precisely the same, but close at least; I basically copied the addons over. 20180324 15:46:39< celticminstrel> BTW, that commit should probably be tested with Boost 1.50. 20180324 15:46:49< celticminstrel> I think it should work but I might've missed a case or two. 20180324 15:47:27< celticminstrel> Oh yay "Invalid WML found - [event] is missing a name key" 20180324 15:47:47< celticminstrel> But the wiki says it's supposed to be optional now (you need at least one of name or id, but not both). 20180324 15:47:54< celticminstrel> What should we do? Update wiki, or update code? 20180324 15:49:28-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer] 20180324 15:49:33-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180324 15:50:35< celticminstrel> Looks like it means the event is not registered, because it didn't fire when I tried to. 20180324 15:53:45< celticminstrel> Firing an event by ID does work as long as it also has a name. 20180324 15:53:51 * celticminstrel pokes @Vultraz 20180324 15:54:27 * celticminstrel also pokes @shadowm for opinion on whether to update wiki or code. 20180324 15:59:38< celticminstrel> Unfortunately what I said last night about passing a location to a fired event does not seem to work. :| 20180324 15:59:57< celticminstrel> The Lua code implied that it would take the x,y from the filter if the filter didn't match anything... 20180324 16:00:22< celticminstrel> Still, that wasn't documented behaviour, so I guess I'll have to find a different way to pass the info. :/ 20180324 16:00:30-!- travis-ci [~travis-ci@ec2-54-204-75-6.compute-1.amazonaws.com] has joined #wesnoth-dev 20180324 16:00:31< travis-ci> wesnoth/wesnoth#17155 (1.14 - 667b2b7 : Celtic Minstrel): The build was broken. 20180324 16:00:31< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/357809020 20180324 16:00:31-!- travis-ci [~travis-ci@ec2-54-204-75-6.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180324 16:00:42< celticminstrel> \o/ (not really) 20180324 16:01:57< celticminstrel> So basically what it's saying is that if I explicitly declare a move constructor I also need to explicitly declared a move assignment operator. Alright then. 20180324 16:03:30-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20180324 16:04:10<+discordbot4> Can you check history to see what the actual intention for fire_event at the time was? 20180324 16:04:21-!- octalot [~steve@178.165.129.225.wireless.dyn.drei.com] has quit [Ping timeout: 240 seconds] 20180324 16:04:45-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180324 16:05:23<+discordbot4> It'd also help if you could confirm it's a regression of some sort (perhaps resulting from someone messing around with the implementation of events recently). 20180324 16:06:00< celticminstrel> I'll try. I think it's fairly likely since Vultraz was messing around with events at some point. 20180324 16:07:37<+discordbot4> Oh I misread. You said [event] not [fire_event]. Even more reason to suspect the wiki might have been right at some point. 20180324 16:08:48< irker073> wesnoth: Celtic Minstrel wesnoth:1.14 c0c5fc9d7375 / src/units/ (abilities.cpp attack_type.hpp): Fix build by explicitly defining a move assignment operator https://github.com/wesnoth/wesnoth/commit/c0c5fc9d73753807aca756f45859780c1a7e8f75 20180324 16:08:57<+discordbot4> Somehow the subject does sound vaguely familiar but I don't know if it was just a discussion or an actual change since I've not done any add on development on 1.13.x yet. 20180324 16:15:39< gfgtdf> i dont see how events without a name would ever make sense. and the 'now' in celmins post makes it likeely that event never supported events with no name 20180324 16:17:48< celticminstrel> Allow firing events by ID: July 23, 2016. https://github.com/wesnoth/wesnoth/commit/5588642 20180324 16:18:06< celticminstrel> Raise warning if name is missing: Feb 1, 2018. https://github.com/wesnoth/wesnoth/commit/c916a85 20180324 16:18:20< celticminstrel> Does that count as a regression then? 20180324 16:18:48< celticminstrel> I can fix it easily for 1.14, if we want that. 20180324 16:19:22< celticminstrel> Though it's easy to work around by just adding a dummy name. 20180324 16:21:08-!- atarocch [~atarocch@93.56.164.28] has joined #wesnoth-dev 20180324 16:22:12<+discordbot4> celticminstel 20180324 16:22:17<+discordbot4> celticminstrel 20180324 16:22:22<+discordbot4> it's not a regression, per-se... 20180324 16:22:34<+discordbot4> I just forgot you added your fire-by-id thing 20180324 16:22:47< celticminstrel> I wasn't the one who added that, did you even click the first link. 20180324 16:23:22<+discordbot4> oh, ok. 20180324 16:23:31< celticminstrel> The wiki currently states name is optional, too. Wonder when that changed. Obviously later than Feb 1. 20180324 16:23:38<+discordbot4> What? 20180324 16:23:43<+discordbot4> I thought i update the wiki 20180324 16:23:53<+discordbot4> Maybe I just forgot 20180324 16:24:01< celticminstrel> Wait no, I think I was looking at [fire_event] there, not [event]. 20180324 16:24:09< celticminstrel> It's listed as optional in [fire_event]. 20180324 16:24:16< celticminstrel> I didn't actually look at [event]. 20180324 16:24:20<+discordbot4> heh 20180324 16:24:27< celticminstrel> It's not a big issue, so maybe it's best left for 1.15. 20180324 16:24:32< celticminstrel> I just added name=nothing and it worked. 20180324 16:24:52< celticminstrel> What do you thing shadowm? 20180324 16:24:55< celticminstrel> ^think 20180324 16:25:56<+discordbot4> I think validating the presence of the name key is good 20180324 16:26:07<+discordbot4> Because it's needed in 99% of cases. 20180324 16:26:17< celticminstrel> Yes, but ideally it would accept cases where there's an ID but no name, too. 20180324 16:26:33< celticminstrel> Anyway, how can I convert a location_id to coordinates in WML... gfgtdf? 20180324 16:27:00<+discordbot4> If I understand correctly you were looking at fire_event and the wiki does not claim the event name is optional for an [event]? 20180324 16:28:27<+discordbot4> Because in that case this is definitely not the right time to change any WML or Lua API semantics unless it's needed to fix a regression. We're in the RC phase. 20180324 16:31:47< irker073> wesnoth: Celtic Minstrel wesnoth:master e317f346e8d9 / src/game_events/manager_impl.cpp: Don't show a message for missing name in [event] if it has an id https://github.com/wesnoth/wesnoth/commit/e317f346e8d9c4363075532efb762cc42646d42f 20180324 16:32:21<+discordbot4> ehhhhh... 20180324 16:32:39<+discordbot4> ehhhhhhhhhhh....... 20180324 16:32:43<+discordbot4> I guess.. that works 20180324 16:32:44< celticminstrel> Because if you're using [fire_event] by ID, there's no need for a name at all. 20180324 16:33:10<+discordbot4> The change is just that trivial? 20180324 16:33:18< irker073> wesnoth/wesnoth:master Jyrki Vesterinen fbfa82c6b1 Remove error message if creating texture AppVeyor: All builds passed 20180324 16:33:21<+discordbot4> Yes. 20180324 16:33:36< celticminstrel> Right, but note that if the message is shown, the event is not added. 20180324 16:33:50< celticminstrel> So technically it does slightly change WML API? 20180324 16:33:59<+discordbot4> That basically just means the engine already supported that scenario, it just arbitrarily forbade it. 20180324 16:34:50<+discordbot4> I don't know then, it seems really tempting to backlog. 20180324 16:35:29<+discordbot4> Backport. Stupid phone. 20180324 16:35:58<+discordbot4> Keep it mind it's only been forbidden since Feb 2nd 20180324 16:36:20<+discordbot4> So it is a regression then? 20180324 16:36:22< celticminstrel> When was 1.13.11 released? 20180324 16:36:46< celticminstrel> If that was before February it's probably reasonable to count as a regression. 20180324 16:37:10<+discordbot4> FTR, did you test that the code won't assert now 20180324 16:37:30<+discordbot4> i just checked, and it's very likely it will assert. 20180324 16:37:47< celticminstrel> How would it assert? 20180324 16:37:59<+discordbot4> assert(!standardized_names.empty()); 20180324 16:38:17< irker073> wesnoth: Charles Dang wesnoth:master 89e0d7e2aede / src/ (events.cpp wesnoth.cpp): Events: ensure the global event context is always available https://github.com/wesnoth/wesnoth/commit/89e0d7e2aede862298389b53f7248c0f46ce1704 20180324 16:38:35< celticminstrel> Oh I see it now. 20180324 16:39:25<+discordbot4> though honestly, I don't even use the by-name or has-variables filings anymore 20180324 16:39:30<+discordbot4> maybe I should just remove them 20180324 16:40:31-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev 20180324 16:40:31<+discordbot4> or remove the assert 20180324 16:40:43< irker073> wesnoth: Celtic Minstrel wesnoth:master f7cc1842bb63 / src/game_events/manager_impl.cpp: Don't bother trying to standardize event name if there isn't one https://github.com/wesnoth/wesnoth/commit/f7cc1842bb630bd8c642ea025124ddbfa1c57433 20180324 16:40:59< celticminstrel> ARGH 20180324 16:41:02< celticminstrel> I missed another detail. 20180324 16:41:35<+discordbot4> now you sound like me 😛 20180324 16:41:57< irker073> wesnoth: Celtic Minstrel wesnoth:master cf385537c234 / src/game_events/manager_impl.cpp: Fixup last commit https://github.com/wesnoth/wesnoth/commit/cf385537c234f00e34dc9892b0acd6ecf302aea5 20180324 16:44:06<+discordbot4> a better assertion would be old size = new size, come to think of it 20180324 16:45:08< gfgtdf> celticminstrel : store_locations i'd say 20180324 16:45:31<+discordbot4> honnestly, the fact that we can now fire events by name and id is a bit weird 20180324 16:46:10< celticminstrel> Firing by ID technically makes more sense when you're using events like functions. 20180324 16:46:20< celticminstrel> Because ID is unique; name isn't. 20180324 16:46:48<+discordbot4> I think someone people rely on that behavior in places 20180324 16:46:51<+discordbot4> shadowm even maybe 20180324 16:46:54<+discordbot4> .... 20180324 16:46:56<+discordbot4> SOME* people 20180324 16:47:01<+discordbot4> why do I keep typing someone people 20180324 16:47:14<+discordbot4> agh. 20180324 16:47:15< gfgtdf> which behviour ? 20180324 16:47:25< celticminstrel> Uh-oh. 20180324 16:47:29< celticminstrel> Assertion in 1.13.12. 20180324 16:47:35<+discordbot4> The ability to fire events by id wasn't in 1.12 so I couldn't possibly rely on it. 20180324 16:47:38<+discordbot4> what have you done 20180324 16:47:52< celticminstrel> game_events/manager.cpp, line 139, !eh->disabled() 20180324 16:48:01< celticminstrel> This is the stock 1.13.12 version, from the installer. 20180324 16:48:05<+discordbot4> @shadowm no, I mean possibly firing multiple custom events with the same name but each having different IDs that can be removed at different times 20180324 16:48:06< gfgtdf> how does 1.12 bahve if one adds an event with no name ? 20180324 16:48:18<+discordbot4> i don 20180324 16:48:20<+discordbot4> t remember 20180324 16:48:34< gfgtdf> Vultraz: that behviour shodul not have changed ? 20180324 16:48:37<+discordbot4> @Vultraz Oh, yes, that I certainly must've used somewhere. 20180324 16:48:55< celticminstrel> Well, you can still rely on it. 20180324 16:49:01<+discordbot4> gfgtdf: it was a deliberate change to make the wiki 20180324 16:49:09< celticminstrel> The ability to fire by ID doesn't change that. 20180324 16:49:20<+discordbot4> 's assertion that name= is mandatory actually be enforceable 20180324 16:49:38<+discordbot4> or do you mean the other ting 20180324 16:49:39<+discordbot4> thing 20180324 16:50:05< celticminstrel> So can anyone tell me what cause the assertion and how I can work around it. 20180324 16:50:11<+discordbot4> celticminstrel: tha's bad 20180324 16:50:14<+discordbot4> that's 20180324 16:50:14< celticminstrel> I know. 20180324 16:50:34<+discordbot4> it means you have a CORRUPTED GAMESTATE. 20180324 16:50:37< gfgtdf> celticminstrel: did you use the gamestate insepctor ? 20180324 16:50:52< celticminstrel> Wait, can using the gamestate inspector cause this? o.O 20180324 16:50:59< celticminstrel> I did add an inspect tag somewhere. 20180324 16:50:59< gfgtdf> celticminstrel: some time ago someone reported the same thing sying it woudlbe related to th gamestate insepctor 20180324 16:51:05<+discordbot4> wat 20180324 16:51:16<+discordbot4> ....seriously, what 20180324 16:51:20< celticminstrel> So if that's the only problem, then I guess it's not too bad, though it should still be fixed. 20180324 16:51:20< gfgtdf> celticminstrel: it was here on irc if i rmember correctly. 20180324 16:51:46<+discordbot4> ...looks like the gamestate inspector does use that write_events function 20180324 16:52:27<+discordbot4> celmin: did you invoke it mid-event? 20180324 16:52:32< celticminstrel> Yes. 20180324 16:52:38< celticminstrel> With the [inspect] tag. 20180324 16:52:48<+discordbot4> Agh 20180324 16:53:24< celticminstrel> If the idea of that was to not write the events to save files, it's probably fine to just skip over disabled events? 20180324 16:53:39< celticminstrel> You shouldn't be asserting while saving anyway. 20180324 16:53:42<+discordbot4> @jyrkive changed it to an assert 20180324 16:53:54<+discordbot4> because there SHOULD NEVER BE disabled events when saving 20180324 16:54:02<+discordbot4> but now it turns out you can invokve this function mid-event 20180324 16:54:07< celticminstrel> Ah. 20180324 16:54:30-!- travis-ci [~travis-ci@ec2-54-204-75-6.compute-1.amazonaws.com] has joined #wesnoth-dev 20180324 16:54:30< travis-ci> wesnoth/wesnoth#17156 (1.14 - c0c5fc9 : Celtic Minstrel): The build was fixed. 20180324 16:54:30< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/357814861 20180324 16:54:31-!- travis-ci [~travis-ci@ec2-54-204-75-6.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180324 16:54:40<+discordbot4> events are marked disabled before they're executed, ftr 20180324 16:55:03< celticminstrel> FTR it's important to be able to invoke the inspector mid-event. 20180324 16:55:15< celticminstrel> So this does need to be fixed in some way. 20180324 16:55:49<+discordbot4> @jyrkive perhaps we add a strict argument to that function that can be false when invoking from the gsi? 20180324 16:56:05<+discordbot4> Sounds reasonable to me. 20180324 16:56:21<+discordbot4> on it. 20180324 16:59:00< celticminstrel> At first I thought gsi was a misspelling of gui. Then I realised what it really meant. >_> 20180324 17:00:46-!- DeFender1031 [~DeFender1@89-138-91-7.bb.netvision.net.il] has joined #wesnoth-dev 20180324 17:06:24<+discordbot4> 😛 20180324 17:06:57<+discordbot4> ok, both these things need to go into 1.14.. 20180324 17:07:01<+discordbot4> and have changelog entries.. 20180324 17:07:08<+discordbot4> along with gfgtdf's fix 20180324 17:07:11<+discordbot4> for sp modcheck 20180324 17:10:27< irker073> wesnoth: Charles Dang wesnoth:master ef172d47fa41 / src/tests/gui/test_gui2.cpp: Exclude command console and game ui dialogs from tests https://github.com/wesnoth/wesnoth/commit/ef172d47fa412c256928a9099012ec9c0acc26f1 20180324 17:10:30< irker073> wesnoth: Charles Dang wesnoth:master afaa75842c89 / src/ (3 files in 2 dirs): Add ability to bypass strict no-disabled-events assertion when writing events https://github.com/wesnoth/wesnoth/commit/afaa75842c8914406bed75d3557ec241b0de9b6a 20180324 17:13:29<+discordbot4> wait, is gfgtdf's commmit on 1.14 only? 20180324 17:14:25<+discordbot4> Oh yeah, please do keep an eye on people pushing commits to one branch and not the other one. 20180324 17:14:29<+discordbot4> BOTH of his commits are on 1.14 only.. 20180324 17:14:32<+discordbot4> That caused a lot of issues last time. 20180324 17:15:00<+discordbot4> I should've been more stern about that kind of thing tbh. 20180324 17:15:30<+discordbot4> They tend to use the excuse of "i'll do it laaater mum" and then "later" never comes. 20180324 17:15:41< celticminstrel> I forget, was there a replacement for helper.rand? 20180324 17:15:48< celticminstrel> Or do we just continue to use it for the time being? 20180324 17:15:53<+discordbot4> (Especially when one of them decides to disappear entirely.) 20180324 17:17:32< irker073> wesnoth: gfgtdf wesnoth:master da2081de7713 / src/game_initialization/create_engine.cpp: fix initial selection of mods in sp https://github.com/wesnoth/wesnoth/commit/da2081de7713b1c19b2be268e8dd0a48e898bf1c 20180324 17:17:34< irker073> wesnoth: gfgtdf wesnoth:master 7621af926b1b / src/ (play_controller.hpp synced_commands.cpp): show the oos savegame dialog when receiving a debug command in mp https://github.com/wesnoth/wesnoth/commit/7621af926b1bd1343c48be8c6dd821b3f1778c26 20180324 17:19:00< gfgtdf> oh thx 20180324 17:19:13< gfgtdf> coudl you please do the same for df058356df8a6db8092fa30d73cacdda45637377 ? 20180324 17:21:29< irker073> wesnoth: gfgtdf wesnoth:master 83007d4825c0 / data/campaigns/Under_the_Burning_Suns/utils/abilities.cfg: remove a [on_redo] https://github.com/wesnoth/wesnoth/commit/83007d4825c0a9daca158ec821da34c8968b7536 20180324 17:21:51<+discordbot4> next time please remember to backport yourself 20180324 17:22:06<+discordbot4> (heh) 20180324 17:22:12<+discordbot4> More like forward-port in this case. 😉 20180324 17:22:20<+discordbot4> indeed 20180324 17:22:57< gfgtdf> thx again. 20180324 17:23:06-!- Bhoren [~Bhoren_wh@2a01:e0a:c:2150:211e:96:9e16:a70c] has quit [Quit: Leaving] 20180324 17:23:34<+discordbot4> celticminstrel: if you're done fiddling with the event behavior and consider it finished do backport it 20180324 17:23:46<+discordbot4> and can someone update he changelog on 1.14 20180324 17:24:07<+discordbot4> needs the sp mod fix, the even assertion fix, the event name= key warning change 20180324 17:24:39<+discordbot4> was there something else...? 20180324 17:24:55<+discordbot4> oh yeah the thing about the thing 20180324 17:24:56<+discordbot4> debug thing 20180324 17:27:01<+discordbot4> Basically my point is, if people can write C++, they can port their patches themselves without needing a reminder 100 days later. 20180324 17:27:13<+discordbot4> It's not rocket science and they're all supposed to be programmers. 20180324 17:28:15<+discordbot4> If it's a situation where they intentionally want something to be in master for a while before it's backported, though, they'd better file a bug and mark it as Blocker that serves as a reminder for the release team that there are patches pending backport. 20180324 17:28:41<+discordbot4> Or create a pull request. 20180324 17:28:56<+discordbot4> It's supposed to be a safeguard against hit-by-a-bus situations. https://en.wikipedia.org/wiki/Bus_factor 20180324 17:29:16<+discordbot4> A lot of issues in the past could've been avoided if people were more conscious about that principle. 20180324 17:29:59<+discordbot4> FUCKING HELL GIANT SPIDER 20180324 17:30:04< irker073> wesnoth: Celtic Minstrel wesnoth:lua_reorg 0049f12b4d9d / data/lua/helper.lua: Rewrite helper.move_unit_fake to not use a WML variable https://github.com/wesnoth/wesnoth/commit/0049f12b4d9d7175363f2de51b0427fdebac0a2b 20180324 17:30:05< celticminstrel> Rebased lua_reorg. 20180324 17:30:06< irker073> wesnoth: Celtic Minstrel wesnoth:lua_reorg 79ffbd58287e / data/lua/ (core.lua helper.lua wml/items.lua): Lua API reorganization: interface module https://github.com/wesnoth/wesnoth/commit/79ffbd58287e533460360f5b2aeea129ea90bf9c 20180324 17:30:08< irker073> wesnoth: Celtic Minstrel wesnoth:lua_reorg ed81085e6698 / data/lua/ (core.lua helper.lua wml/items.lua): Lua API reorganization: interface module deprecations https://github.com/wesnoth/wesnoth/commit/ed81085e6698b5fc70d38a32e2efd63044665fb1 20180324 17:30:10< irker073> wesnoth: Celtic Minstrel wesnoth:lua_reorg 843b86cdd56a / data/lua/helper.lua: Use wml.tag in helper.get_user_choice https://github.com/wesnoth/wesnoth/commit/843b86cdd56ae88c020c96fb8cf59a10f67ecc39 20180324 17:30:12< irker073> wesnoth: Celtic Minstrel wesnoth:lua_reorg 77692c5aa26a / data/lua/ (core.lua helper.lua): Lua API reorganization: GUI module https://github.com/wesnoth/wesnoth/commit/77692c5aa26aad235dc168c1b27a53e01dad98ad 20180324 17:30:14< irker073> wesnoth: Celtic Minstrel wesnoth:lua_reorg 3991e2d23f1e / data/lua/ (core.lua helper.lua): Lua API reorganization: GUI module deprecations https://github.com/wesnoth/wesnoth/commit/3991e2d23f1e0861140a1e7b97523601b74450b7 20180324 17:30:16< irker073> wesnoth: Celtic Minstrel wesnoth:lua_reorg 59b25b5e8bf0 / data/lua/helper.lua: Rewrite helper.modify_unit to not use a WML variable https://github.com/wesnoth/wesnoth/commit/59b25b5e8bf008c6f2690ba975ac4ffd3c011f45 20180324 17:30:18< irker073> wesnoth: Celtic Minstrel wesnoth:lua_reorg 4ea95c492dd1 / data/lua/ (core.lua helper.lua): Lua API reorganization: units module https://github.com/wesnoth/wesnoth/commit/4ea95c492dd16edadc6a15b92c68a769642c01d9 20180324 17:30:20< irker073> wesnoth: Celtic Minstrel wesnoth:lua_reorg b80391004e26 / data/lua/ (core.lua helper.lua): Lua API reorganization: units module deprecations https://github.com/wesnoth/wesnoth/commit/b80391004e26dbdabd7c8bb801ff51f625ef8741 20180324 17:30:21-!- Oebele [~quassel@92-110-163-84.cable.dynamic.v4.ziggo.nl] has quit [Ping timeout: 265 seconds] 20180324 17:30:22< irker073> wesnoth: Celtic Minstrel wesnoth:lua_reorg f646955f6004 / data/lua/core.lua: Lua GUI module: minor fix, plus name changes from discussions https://github.com/wesnoth/wesnoth/commit/f646955f60045144f4666f8289c10b44e5cfd5dc 20180324 17:30:24< irker073> wesnoth: Celtic Minstrel wesnoth:lua_reorg e177021e44d2 / data/lua/ (core.lua helper.lua): Deprecate helper.wml_error and move it to wml.error https://github.com/wesnoth/wesnoth/commit/e177021e44d27f91ed3ed7c08b68d5aa6a504de6 20180324 17:30:41<+discordbot4> go to fill my dogs' water bowl a this giant-ass spider is sitting on it 20180324 17:31:05<+discordbot4> See? Bus factor. 20180324 17:31:20<+discordbot4> Vultraz could've just died of poisoning and what would we do? 20180324 17:31:37<+discordbot4> Flail our arms and run around like headless chickens. 20180324 17:32:37-!- octalot [~steve@77.119.128.62.wireless.dyn.drei.com] has joined #wesnoth-dev 20180324 17:32:44<+discordbot4> thankfully we don't have poisonous spiders here 20180324 17:33:04<+discordbot4> You could be allergic to its venom and have no idea until you find yourself in your deathbed. 20180324 17:33:11<+discordbot4> Australia, OTHO... 20180324 17:33:37<+discordbot4> The wildlife in Australia seems perfectly engineered to murder you to death 20180324 17:33:50<+discordbot4> Point is, it's not escaped my attention that certain people have a habit of staying silent and not acknowledging anything said when it seems even slightly like criticism directed towards them. 20180324 17:34:03<+discordbot4> Two years later the same people keep doing the same stuff. 20180324 17:35:15<+discordbot4> Ultimately this is not any single dev's solo project and if we can't all be on the same page then we're going to have trouble. And that trouble usually takes the shape of technical debt. 20180324 17:35:18< celticminstrel> @Vultraz, gfgtdf: Please explain "the thing about the thing" and "the sp mod fix" so I can add them to the changelog. 20180324 17:35:48<+discordbot4> "Fixed being unable to deselect modifications in Singleplayer" 20180324 17:36:15<+discordbot4> gfgtdf: did you disable those debug dialogs for sp? 20180324 17:36:21<+discordbot4> or i mean, for the person who used the command? 20180324 17:36:33<+discordbot4> if now it spawns a dialog in sp every time you use a command it's unusable 20180324 17:36:51< celticminstrel> Yeah, it is indeed. 20180324 17:37:06< celticminstrel> It should only spawn a dialog if someone else used it. 20180324 17:37:20< celticminstrel> FTR, in 1.13.12 there are no dialogs when using debug commands in a campaign, at least. 20180324 17:37:44<+discordbot4> what aboutt messagagagegsgsgsg 20180324 17:38:00-!- travis-ci [~travis-ci@ec2-54-224-141-220.compute-1.amazonaws.com] has joined #wesnoth-dev 20180324 17:38:01< travis-ci> wesnoth/wesnoth#17161 (master - afaa758 : Charles Dang): The build passed. 20180324 17:38:01< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/357832075 20180324 17:38:01-!- travis-ci [~travis-ci@ec2-54-224-141-220.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180324 17:38:11< celticminstrel> I do get the message, which is annoying. 20180324 17:39:35<+discordbot4> @jyrkive ermeghard 😮 ^^^^ 20180324 17:39:45<+discordbot4> MASTER IS PASSING THE TESTS AGAIN 20180324 17:39:48<+discordbot4> \o/ 20180324 17:40:50<+discordbot4> @Tad Carlucci shall be pleased 20180324 17:41:43<+discordbot4> Well, a lot of people. But .. does it actually run or are we just passing the tests and not testing the failures? 20180324 17:42:03<+discordbot4> it passes. 20180324 17:42:20< celticminstrel> Does this mean all the WML tests pass then? 20180324 17:42:26<+discordbot4> I think his question was about if the game is in a playable state. 20180324 17:42:36<+discordbot4> all WML tests pass 20180324 17:43:03<+discordbot4> Only the parts which have automated tests are working correctly. For example, the UI is still unusable. 20180324 17:43:42<+discordbot4> That's enough for me to work, but still blocks some developers. 20180324 17:44:32<+discordbot4> Anyone wanting to play with the Map Editor (as of a few hours ago, at least) will be disappoined because it seffaults. 20180324 17:44:57<+discordbot4> ok, seriously, can't you be happy about something 😐 20180324 17:45:44<+discordbot4> @shadowm is no password prompt the correct behavior when using an inactive nick? 20180324 17:45:51<+discordbot4> Yes. 20180324 17:46:25< irker073> wesnoth: Charles Dang wesnoth:master e4b7820ab094 / src/game_initialization/multiplayer.cpp: Fixed infinite loading screen when logging in with an invalid nickname https://github.com/wesnoth/wesnoth/commit/e4b7820ab094fa3847bd8b47fdaca376b4c5ad2b 20180324 17:46:32<+discordbot4> Otherwise people were registering accounts that'd never be activated, just to steal alts from other people who didn't take the care of registering them, or to perform font-based troll attacks. 20180324 17:46:49<+discordbot4> (e.g. shadowm vs. shadowrn. And yes, someone actually did that to me.) 20180324 17:46:57< irker073> wesnoth: Charles Dang wesnoth:1.14 7c6d2d2eeb67 / src/game_initialization/multiplayer.cpp: Fixed infinite loading screen when logging in with an invalid nickname https://github.com/wesnoth/wesnoth/commit/7c6d2d2eeb677252536549debaebc4a5ee695dc9 20180324 17:47:03<+discordbot4> celticminstrel: can you also add that to your changelog update 20180324 17:47:26<+discordbot4> fix t'was surprisingly simple 20180324 17:47:27< celticminstrel> Is anyone going to tell me what the other thing is that I need to add? 20180324 17:47:32< celticminstrel> Something about debug something? 20180324 17:48:34<+discordbot4> "Made it easier to know if another player uses debug commands in a multiplayer game." 20180324 17:48:35<+discordbot4> or something 20180324 17:51:05<+discordbot4> @shadowm oh, hell. https://github.com/wesnoth/wesnoth/issues/2732 Might you be able to help with this? Dunno if they have spanish translatins 20180324 17:52:30<+discordbot4> Yeah, I can at least confirm #2732 still happens. 20180324 17:53:00<+discordbot4> https://cdn.discordapp.com/attachments/259976436490829825/427162932577828864/unknown.png 20180324 17:53:03< irker073> wesnoth: Celtic Minstrel wesnoth:1.14 6c2a78c35a1d / src/game_events/manager_impl.cpp: Don't bother trying to standardize event name if there isn't one https://github.com/wesnoth/wesnoth/commit/6c2a78c35a1db2bd9b66cf2cd609dbaf439644a8 20180324 17:53:05< irker073> wesnoth: Celtic Minstrel wesnoth:1.14 61f7c25a1cd5 / src/game_initialization/multiplayer.cpp: Merge branch '1.14' of github.com:wesnoth/wesnoth into 1.14 https://github.com/wesnoth/wesnoth/commit/61f7c25a1cd5b2ee9dcecde48dc4f90f842b052f 20180324 17:53:07< irker073> wesnoth: Celtic Minstrel wesnoth:1.14 6b7ff398dd7a / changelog.md: Update changelog https://github.com/wesnoth/wesnoth/commit/6b7ff398dd7a52ec189b5f08029599ecf7a70ca3 20180324 17:53:07<+discordbot4> (Compare the spearman's stats on the Recruit dialog to the sidebar.) 20180324 17:53:09< irker073> wesnoth: Celtic Minstrel wesnoth:1.14 ea739324dfa2 / data/ (4 files in 4 dirs): Remove some uses of set_wml_tag_metatable https://github.com/wesnoth/wesnoth/commit/ea739324dfa278aa3006605b53dbe5978122484b 20180324 17:53:14<+discordbot4> I'll take a look later. 20180324 17:53:28< celticminstrel> ...how did that merge commit get in there? o.O 20180324 17:53:35< celticminstrel> Well, too late to change it now. Oh well. 20180324 17:53:43<+discordbot4> you forgot the commit for the inspector! 20180324 17:53:44<+discordbot4> D: 20180324 17:54:09< celticminstrel> Hmm? 20180324 17:54:27< celticminstrel> Was I supposed to cherry-pick it? I thought you already did that and I just needed to add it to the changelog? 20180324 17:54:29<+discordbot4> wait a sec 20180324 17:54:53<+discordbot4> yeha, I didn't... 20180324 17:54:58<+discordbot4> what the hell, vult. 20180324 17:55:06<+discordbot4> ill do it 20180324 17:55:45< irker073> wesnoth: Charles Dang wesnoth:1.14 60aee8face25 / src/ (3 files in 2 dirs): Add ability to bypass strict no-disabled-events assertion when writing events https://github.com/wesnoth/wesnoth/commit/60aee8face2567d160d67d575a84f7aaa34dba9d 20180324 17:56:22<+discordbot4> what was i thinking 20180324 17:57:04< celticminstrel> I wonder if the invulnerable status lasts between scenarios. >_> 20180324 17:57:40<+discordbot4> There's an invulnerable status now? 20180324 17:57:59< celticminstrel> Yeah. The intent is for debugging IIRC. It means attacks never hit you. 20180324 17:58:15< celticminstrel> Jyrki implemented it. 20180324 17:58:38<+discordbot4> I mean, I use {CHANCE_TO_HIT id=Foo 100 ()} or so a lot for non-debugging purposes. 20180324 17:58:50<+discordbot4> And 0 instead of 100. 20180324 17:59:16<+discordbot4> And people give me flak for it because god forbid story may trump gameplay for a single scene. 20180324 17:59:52<+discordbot4> As celmin said, invulnerability is primarily for testing. 20180324 17:59:59<+discordbot4> But primarily my issue with that approach is that the CTH macro is extremely convoluted and at least two add-ons out there deliberately tamper with its effects. 20180324 18:00:07<+discordbot4> Meaning I've had to blacklist them during load instead. 20180324 18:00:32<+discordbot4> It's too common for developers to instead increase the unit's HP to ridiculous levels, with the side effect of slowing down damage prediction and increasing its memory usage. 20180324 18:00:47<+discordbot4> @shadowm beginning to think we should never use N() localized strings in headers ever >> 20180324 18:01:08<+discordbot4> You mean any single macro or function that results in string extraction. 20180324 18:01:09<+discordbot4> @jyrkive you implemented monte carlo to deal with that, didn't you? 20180324 18:01:12<+discordbot4> (Multiplying unit's HP by 10 also multiplies memory usage of attack prediction by 10. Doing it for both units multiplies memory usage by 100.) 20180324 18:01:45<+discordbot4> Yeah, LotI uses big HP values for legitimate gameplay and that's always been a frequent cause of complaints from both its players and the author. 20180324 18:01:45< celticminstrel> @Vultraz, yes, you should never put localized strings in headers unless you absolutely have to. 20180324 18:01:47<+discordbot4> Monte carlo damage prediction may increase performance, but it does nothing to memory usage. 20180324 18:01:53<+discordbot4> (is that option on by default, btw?) 20180324 18:02:00<+discordbot4> They expect Wesnoth to be designed around handling big numbers. 20180324 18:02:23<+discordbot4> celticminstrel: they're causing problems by being used in MAKE_ENUM 20180324 18:02:34< Ravana_> isn't it good enough to use only first x significant numbers in predictions 20180324 18:02:57< celticminstrel> ...why on earth would MAKE_ENUM need localized strings? 20180324 18:03:01<+discordbot4> @jyrkive well, if we have a new invulnerable status it should be documented. 20180324 18:03:16<+discordbot4> celmin: MAKE_ENUM (ALIGNMENT, (LAWFUL, N_("lawful")) etc 20180324 18:03:22<+discordbot4> @Vultraz The engine calculates a complexity score for each battle, and uses Monte carlo simulation if a certain threshold is exceeded. 20180324 18:03:30< celticminstrel> Oh, that's not a problem then. 20180324 18:03:37<+discordbot4> Yes, it is documented in the wiki. 20180324 18:03:42<+discordbot4> it is aproblem because you need to use sgettext 20180324 18:03:49<+discordbot4> we had to do it once 20180324 18:03:49<+discordbot4> The MAKE_ENUM issue can be solved with some effort without resorting to hacks. 20180324 18:03:52<+discordbot4> now we have to do it again 20180324 18:03:58< celticminstrel> Well, there's not really a way around it for the enums? 20180324 18:03:59-!- travis-ci [~travis-ci@ec2-50-17-85-166.compute-1.amazonaws.com] has joined #wesnoth-dev 20180324 18:04:00< travis-ci> wesnoth/wesnoth#17163 (master - 83007d4 : gfgtdf): The build passed. 20180324 18:04:00< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/357835215 20180324 18:04:00-!- travis-ci [~travis-ci@ec2-50-17-85-166.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180324 18:04:07<+discordbot4> don't use the damn enums 20180324 18:04:28< celticminstrel> You could probably add a function to the enum that attempts to get a localized enum name, though. 20180324 18:04:29<+discordbot4> Exactly. 20180324 18:04:36<+discordbot4> And that. 20180324 18:04:44<+discordbot4> do what I did for the loading screen and use a plain enum and an enum/string map 20180324 18:05:07<+discordbot4> we have std::map::at now, we don't really need string_to_enum. 20180324 18:05:20<+discordbot4> I never used MAKE_ENUM myself because it felt like overengineering to solve a coding style issue. 20180324 18:05:38<+discordbot4> I'd never have considered using it with translatable strings either. 20180324 18:05:44<+discordbot4> almost nothing checks the exceptions those various functions throw anyway 20180324 18:07:51<+discordbot4> C++ enums could be better.In C#, for example, enumerated types can have extension methods, arbitrary metadata accessible via reflection, and other goodies. 20180324 18:08:26<+discordbot4> gets excited that master started passing WML tests again recompiles starts Aethermaw error general: Error while reading the WML: Mandatory WML child missing yet untested for. Please report. 20180324 18:08:49<+discordbot4> Yup https://github.com/wesnoth/wesnoth/issues/2724 20180324 18:09:53<+discordbot4> I have NFI what that's on about 20180324 18:10:07<+discordbot4> would be nice if it said what child it was 20180324 18:11:36<+discordbot4> If/when someone finds out, it'd be good if there was a test for it 😛 20180324 18:11:56<+discordbot4> Like I said before, that's our equivalent of Microsoft's Windows Setup "Something happened" error. 20180324 18:12:04<+discordbot4> it's kinda weird that all tests pass, but I can't even start a scenario 20180324 18:12:14<+discordbot4> Well, there is an automatic MP test. 20180324 18:12:49< irker073> wesnoth: Charles Dang wesnoth:master 8d3dcb109b43 / src/gui/widgets/window.cpp: GUI2/Window: reverted some unintentional semantic changes from 88e5c49f5d3d300ea https://github.com/wesnoth/wesnoth/commit/8d3dcb109b438efd926e97a7daa93c190109ebf1 20180324 18:13:29<+discordbot4> It is a very generic error that just happens when a config object is requested with a const method, it can't be found, so a special magic config with no attributes or children is retrieved instead to honour the method's contract. 20180324 18:14:04<+discordbot4> Then something fails to check that the retrieved config isn't invalid (i.e. isn't the magic fallback config), attempts to read from it, and... "Something happened". 20180324 18:15:36<+discordbot4> It all boils down to config::operator[]() and others having two guarantees: that they always, without fail, return a reference and not a copy or pointer (that may be null); and that their non-const versions can silently create children or attributes as needed. 20180324 18:16:01<+discordbot4> That pattern has permeated the codebase since before version 1.0 so it's not trivial to do away with it. 20180324 18:16:29<+discordbot4> Is it also about the guarantee that they don't throw exceptions? 20180324 18:16:32< celticminstrel> @jyrkive An idiom I like is to overload operator* for enum types and return a struct of auxiliary information. 20180324 18:16:43< celticminstrel> (I'd prefer to overload operator-> but that's not allowed.) 20180324 18:17:21<+discordbot4> (A more concrete example:) cpp config cfg; cfg["foo"] = "bar"; /* ... */ config const& cfg2 = cfg; std::string baz = cfg2["bar"]; 20180324 18:17:49<+discordbot4> They do throw exceptions, that's the only way that dialog ever comes up I believe. 20180324 18:18:24<+discordbot4> And causes an subsequent quit to whatever the next handler in the stack is, be it the main screen or the final frontier at main(). 20180324 18:18:48<+discordbot4> My point was that the exception occurs when trying to use the invalid config object, instead of when the code attempts to retrieve the nonexistent WML child. 20180324 18:19:03<+discordbot4> Oh yeah, that. 20180324 18:19:35<+discordbot4> There is code that does retrieve the invalid config and actually does its homework and checks whether it's valid or not later on, though. 20180324 18:20:22<+discordbot4> I think parts of the add-ons client code use that pattern for example. 20180324 18:21:23< gfgtdf> most of the code that uses .child checks the result. 20180324 18:21:40<+discordbot4> But it's too easy to forget to do that. 20180324 18:21:52< gfgtdf> in particualr if(const config& child = cfg.child("tag")) {} is a ver ycommon idiom 20180324 18:21:53<+discordbot4> well the exception is thrown somewhere in campaign_controller::play_game() 20180324 18:21:54< gfgtdf> yes 20180324 18:22:28<+discordbot4> And then you get the infamous "Mandatory WML child missing yet untested for" error and it's a royal pain in the bottom for everyone involved to track down where it came from in the first place. 20180324 18:22:57< gfgtdf> the alterntive that does not have thisb behviour is not so easy so sue sicne it requires you to pass the tagname of the parent 20180324 18:23:31< gfgtdf> we coudl make child() just throw an exception and adda new function child_or_invalid() with the bahviour of the current child() 20180324 18:24:01< gfgtdf> but its quite some work 20180324 18:24:25< gfgtdf> also it will problem casue merging conflics when porting stuff master<->1.14 20180324 18:24:54<+discordbot4> Those merge conflicts are inevitable and that's why eventually people start procrastinating on pushing bug fixes to stable. 20180324 18:25:23<+discordbot4> And then they stop trying. And then people get stuck with certain bugs in stable for years and years because development cycles are 2-3 years long now. 20180324 18:25:42< celticminstrel> I think making the child getters throw exceptions is best, but I guess now is not the time. 20180324 18:25:45< gfgtdf> well yes of aoucr this willhappen evntually 20180324 18:26:03< gfgtdf> but currently we do not even have 1.14 released 20180324 18:27:33< Ravana_> what is the suggested way to hide development-specific stuff for 1.13.12? before I have been using https://github.com/ProditorMagnus/OrociaRandomMod/blob/master/scenarios/OrociaRandomMod.cfg#L121 20180324 18:27:40<+discordbot4> @shadowm My viewpoint isn't that negative. We're all perfectly aware that development cycles are long, and thus bugfix releases are the only way to get bug fixes to players' hands quickly. That's motivation enough to push bug fixes to stable. 20180324 18:28:17<+discordbot4> (We have been having the reverse problem of developers trying to push changes other than bug fixes in a very late stage, instead...) 20180324 18:28:28< gfgtdf> Ravana_: wait i have been using the same thing, are you saying it does nto work anymore ? 20180324 18:28:44< Ravana_> UMC is no longer allowed to access files or directories which aren't uploaded to the add-on server by default 20180324 18:29:12< celticminstrel> Try #ifnhave ~add-ons/OrociaRandomMod/info.cfg 20180324 18:29:25< celticminstrel> Not sure if it'll work though. 20180324 18:29:35< celticminstrel> But IIRC all downloaded addons have an info.cfg but uploaded ones don't. 20180324 18:30:20<+discordbot4> _info.cfg is also in the blacklist. 20180324 18:30:36< Ravana_> I guess I check against public files of private addon then 20180324 18:30:38< celticminstrel> Ah. Hmm. 20180324 18:30:52<+discordbot4> #ifhave isn't supposed to reveal its existence, either. If it does, it's a bug. (But we might leave it unfixed for now.) 20180324 18:30:55< celticminstrel> So I guess _server.pbl is similarly not an option. 20180324 18:31:08<+discordbot4> you can just create a maintenance_mode.cfg file or something locally 20180324 18:31:21< celticminstrel> No, that won't work. 20180324 18:31:27< celticminstrel> I think. 20180324 18:31:30<+discordbot4> that defines a macro 20180324 18:31:31<+discordbot4> celticminstrel , do you know who is responsible for MacCompileStuff? Except ancestral, I already know about him 20180324 18:31:31<+discordbot4> it's what I do 20180324 18:31:42< celticminstrel> @jyrkive does it actually check your server.ign for the blacklist? 20180324 18:31:51<+discordbot4> (i got th emethod for from shadomw) 20180324 18:31:54<+discordbot4> No, it doesn't. 20180324 18:32:01< gfgtdf> maybe you can just move out of /addons ? liek ~haveOrociaRandomModlocally where you just put a file "haveOrociaRandomModlocally " at "/data" ? 20180324 18:32:06< gfgtdf> like* 20180324 18:32:06< celticminstrel> @hrubymar10 AFAIK only mattsc and possibly ancestral have the ability to update it. 20180324 18:32:09<+discordbot4> just check for the file's existence with #ifhave, then include it if you have it 20180324 18:32:23<+discordbot4> it should define a macro you can then used to define stuff 20180324 18:32:31<+discordbot4> cordon off stuff* 20180324 18:32:36<+discordbot4> How can one contact mattsc ? 20180324 18:32:43 * celticminstrel waiting on Jyrki's response. 20180324 18:32:52<+discordbot4> Is he here on discord or irc? 20180324 18:32:57< celticminstrel> @hrubymar10 Probably just wait until he notices he was pinged on here. 20180324 18:33:12< celticminstrel> He pops into IRC every so often, and he reads logs too so he'll probably notice we were talking about him. 20180324 18:33:13<+discordbot4> @hrubymar10 ping @csttam 20180324 18:33:14<+discordbot4> celticminstrel: I already answered. The blacklist ignores server.ign. 20180324 18:33:27< celticminstrel> (I mean he reads logs when he's not around.) 20180324 18:33:32< celticminstrel> ... 20180324 18:33:34<+discordbot4> celmin: even better. we can ping him directly here 😛 20180324 18:33:37< celticminstrel> XD His name is backwards on Discord? 20180324 18:33:42<+discordbot4> yes 20180324 18:33:56<+discordbot4> wow 😄 20180324 18:34:09< Ravana_> switching to #ifhave ~add-ons/DBG_Modification/_main.cfg, normal cfg that still never gets uploaded 20180324 18:34:20< celticminstrel> Oh I missed that, sorry Jyrki. So then @Vultraz's idea mixed with Ravana's would work (add any file you want, add it to server.ign as well, and check for its presence). 20180324 18:34:47< gfgtdf> unless someone else has an addon named "DBG_Modification" 20180324 18:35:17<+discordbot4> seriously, just check for the existence of a file in your addon's folder 😐 20180324 18:37:24< Ravana_> not reliable, I would need to manually create that file every time 20180324 18:37:39< Ravana_> better use file that is always there 20180324 18:47:14< irker073> wesnoth/wesnoth:master Celtic Minstrel 18876f54fe Deprecate helper.wml_error and move it t AppVeyor: vs2015/Release Failed 20180324 18:47:15< irker073> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-2164 20180324 18:47:48< Ravana_> seems that 1.13 does not allow extending helper.set_wml_var_metatable {} 20180324 18:48:08< celticminstrel> gfgtdf: When applying a terrain mask, are special locations from the mask merged into the main map? 20180324 18:49:45-!- travis-ci [~travis-ci@ec2-50-17-85-166.compute-1.amazonaws.com] has joined #wesnoth-dev 20180324 18:49:46< travis-ci> wesnoth/wesnoth#17164 (lua_reorg - e177021 : Celtic Minstrel): The build has errored. 20180324 18:49:46< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/357837235 20180324 18:49:46-!- travis-ci [~travis-ci@ec2-50-17-85-166.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180324 18:53:39< gfgtdf> celticminstrel: hmm not sure. 20180324 18:54:05< gfgtdf> Ravana_: not sure what you mean 20180324 18:54:22< gfgtdf> celticminstrel: i vagueley rmember working on soemthing related 20180324 18:54:29< Ravana_> meant https://github.com/ProditorMagnus/OrociaRandomMod/blob/master/lua/_init.lua#L24-L33 20180324 18:56:05< gfgtdf> celticminstrel: seems so: https://github.com/wesnoth/wesnoth/blob/1.14/src/map/map.cpp#L292 20180324 18:56:47< gfgtdf> Ravana_: hmm ok 20180324 18:56:48< celticminstrel> So ignore_special_locations=yes disables the behaviour, but it's on by default. Alright. 20180324 18:57:22<+discordbot4> @Ravana well, it's deprecated 20180324 18:57:23<+discordbot4> so 20180324 18:57:24< gfgtdf> Ravana_: but you coudl probably easily impleemtn your own helper.set_wml_var_metatable 20180324 18:57:27< Ravana_> for workaround I just had to copy parts of proxy_var_mt instead of using helper 20180324 18:57:33<+discordbot4> as is set_wml_tag_metatable 20180324 18:58:37< celticminstrel> Hmm. 20180324 18:58:40<+discordbot4> wml.variables is the new metatable 20180324 18:58:51< celticminstrel> Yeah, copying is the only way to go ATM. 20180324 18:59:25< celticminstrel> That feature could probably be merged into the built-in proxy at some point, if desired. 20180324 19:01:10< zookeeper> @Vultraz, so i take it that you'll fix the remaining bandits.lua issues? 20180324 19:01:23<+discordbot4> what remaining issue 20180324 19:01:25<+discordbot4> you fixed the issue 20180324 19:01:30< zookeeper> the ones i pinged you about today. 20180324 19:01:34< celticminstrel> Is ^Ecf impassable? 20180324 19:01:37<+discordbot4> I saw no such thing 20180324 19:01:40< zookeeper> @Vultraz i'm going to assume this is probably your fault too: https://forums.wesnoth.org/viewtopic.php?p=625082#p625082 20180324 19:02:36< zookeeper> or check if it's legit at all, etc. 20180324 19:03:09<+discordbot4> hm 20180324 19:03:11<+discordbot4> the old code was.. 20180324 19:03:13<+discordbot4> wesnoth.set_variable(string.format("bandit_villages[%d]", i - 1)) 20180324 19:03:19<+discordbot4> I guess I misread it 20180324 19:03:25<+discordbot4> celmin: would this just clear the variable? 20180324 19:03:42< gfgtdf> yes 20180324 19:03:43< celticminstrel> gfgtdf: Are special location IDs unique or can I have duplicates? 20180324 19:03:56< celticminstrel> @Vultraz Yes, setting it to nil clears it. 20180324 19:04:03< gfgtdf> celticminstrel: they are unique iirc, 20180324 19:04:06<+discordbot4> soI can do vars[string.format("bandit_villages[%d]", i - 1)] = nil? 20180324 19:04:26< celticminstrel> Could be useful to allow non-unique ones, but not really a problem, I can just have several instead. 20180324 19:04:41< Ravana_> new way is not documented enough to be useful yet 20180324 19:05:14< zookeeper> sound like you might want to re-check your other changes in those commits, too. 20180324 19:05:53<+discordbot4> meh 20180324 19:07:10< gfgtdf> celticminstrel: are you trying to use it in your addon ? 20180324 19:07:21< celticminstrel> ??? 20180324 19:07:27< gfgtdf> specil_locations i mean 20180324 19:07:31< celticminstrel> I discovered another bug in the locations palette BTW. 20180324 19:07:42< celticminstrel> If you have multiple maps open it shows locations from all the maps. 20180324 19:07:49< celticminstrel> And yeah I'm trying to use special locations in my addon. 20180324 19:07:54<+discordbot4> >_> 20180324 19:07:56<+discordbot4> y u do dis 20180324 19:08:22< celticminstrel> Because it can enable the WML to be more independent from the map, requiring less work if the map needs to be changed later. 20180324 19:08:38< gfgtdf> celticminstrel: iirc fabis plan was to make the [area]s more genreal purpose, (what currently is used for tod area) 20180324 19:09:05< gfgtdf> celticminstrel: and then the scenario editors 'area' feature coudl also be used 20180324 19:09:15<+discordbot4> yeah, wel, he's long gone 20180324 19:09:45< celticminstrel> Could we at least fix the map editor location palette though? 20180324 19:10:05<+discordbot4> no 20180324 19:10:05< celticminstrel> Basically it should only list locations that currently exist in the currently-active map. 20180324 19:10:14< celticminstrel> Why would you say that. 20180324 19:10:23< gfgtdf> celticminstrel: you mean the oldest isue in your tracker ? 20180324 19:10:26<+discordbot4> gui1. don't want to go near it with a 10 foot pole. 20180324 19:10:36< celticminstrel> Well, I wasn't asking you specifically to fix it. 20180324 19:10:40<+discordbot4> 100 foot pole, actually 20180324 19:10:41< celticminstrel> gfgtdf: I dunno, which issue is that? 20180324 19:10:42< gfgtdf> celticminstrel: it'd be nice if it codul be fixed. 20180324 19:10:49< gfgtdf> celticminstrel: https://github.com/wesnoth/wesnoth/issues/1023 20180324 19:10:54< gfgtdf> celticminstrel: well the secodn odlest issue 20180324 19:11:00< celticminstrel> Yeah, that one. 20180324 19:18:02<+discordbot4> well this exception is absolutely useless 20180324 19:18:24<+discordbot4> i can't even get a backtrase 20180324 19:18:26< gfgtdf> which one ? 20180324 19:18:39<+discordbot4> the mandatory wml child missing one 20180324 19:19:17<+discordbot4> The best way to go about it is to have your debugger break as soon as the exception is thrown. 20180324 19:19:20< gfgtdf> you can set a breakpoiunt in config::check_valid inside the if 20180324 19:19:24<+discordbot4> Can't you add a breakpoint to https://github.com/wesnoth/wesnoth/blob/master/src/config.cpp#L120 ? 20180324 19:19:41<+discordbot4> oh, I was adding the breakpoint where it was caught... 20180324 19:19:44<+discordbot4> -_- 20180324 19:20:19<+discordbot4> pats Vultraz's head 20180324 19:21:52< celticminstrel> Okay, ^Ecf is not impassable. :( 20180324 19:22:43< celticminstrel> Hmm. 20180324 19:22:51< celticminstrel> What's the best way to make it impassable. 20180324 19:23:22< celticminstrel> Best I can think of is making an impassable variant of cave terrain and placing it there. 20180324 19:23:34< celticminstrel> Or maybe it was dirt, one of them. 20180324 19:24:04<+discordbot4> well this is odd 20180324 19:25:20<+discordbot4> ah, I see the problem 20180324 19:28:32< irker073> wesnoth: Charles Dang wesnoth:master 915dfaa399e1 / src/gui/dialogs/ingame_ui_base.cpp: Quick fix for "Mandatory WML child missing" error when starting MP https://github.com/wesnoth/wesnoth/commit/915dfaa399e146a328e0ee32d43311660cae7fcf 20180324 19:28:35< irker073> wesnoth: Charles Dang wesnoth:master bad574f7c8f6 / data/campaigns/Eastern_Invasion/lua/bandits.lua: EI: fixed another Lua syntax error from 3783693cbe95 https://github.com/wesnoth/wesnoth/commit/bad574f7c8f6106e6879c14318f3fcf0ec4cc2bf 20180324 19:31:00< gfgtdf> why woudl that need to use the currently scenario cofnig in the first place? 20180324 19:31:19< irker073> wesnoth: Charles Dang wesnoth:1.14 dfee9d0bc5f4 / data/campaigns/Eastern_Invasion/lua/bandits.lua: EI: fixed another Lua syntax error from 3783693cbe95 https://github.com/wesnoth/wesnoth/commit/dfee9d0bc5f4395e84d205c08770e2817acffaec 20180324 19:31:22< irker073> wesnoth: Charles Dang wesnoth:1.14 58ef84216fb4 / changelog.md: Mentioned EI fixes in changelog https://github.com/wesnoth/wesnoth/commit/58ef84216fb4a011b4d71273ab2d428d6dbfa55f 20180324 19:31:59<+discordbot4> gfgtdf: needed for the minimap widget 20180324 19:32:39<+discordbot4> needed to create a terrain_type_data ptr for the gamemap object is owns 20180324 19:32:40<+discordbot4> it 20180324 19:33:03< gfgtdf> now the widgets own the gamemap object ? 20180324 19:33:21<+discordbot4> no the minimap has always owned its own gamemap object 20180324 19:33:30<+discordbot4> but i might make a new minimap widget 20180324 19:33:35<+discordbot4> that takes a display_context 20180324 19:33:49< gfgtdf> yes better so do. 20180324 19:33:51<+discordbot4> really all of this is in flux 20180324 19:34:00< gfgtdf> ok 20180324 19:34:11<+discordbot4> that's why i didn'tbother with a proper fix 20180324 19:34:12< gfgtdf> does it already use opengl ? 20180324 19:34:15<+discordbot4> no 20180324 19:34:42< gfgtdf> good becasue my pc likeley cannot handle opengl :( (have to buy a new one anywqays but it'll take some time) 20180324 19:35:01< gfgtdf> no need to stop becasue of that though. 20180324 19:35:33<+discordbot4> It probably can, just with very low frame rates and a lot of heat emission. 20180324 19:36:48<+discordbot4> gfgtdf: i've already converted GUI2 to run entirely on accelerated rendering tho 20180324 19:36:56<+discordbot4> im using SDL's API right now 20180324 19:37:04< gfgtdf> shadowm: most thignk that use opengl just refuse to start here (didn't test that many) 20180324 19:37:08<+discordbot4> but yeah, the UI is converted 20180324 19:38:14<+discordbot4> not the in-game ui 20180324 19:38:16<+discordbot4> yet 20180324 19:38:19<+discordbot4> tho 20180324 19:38:25<+discordbot4> well it technically is but non-functional 20180324 19:38:42< irker073> wesnoth/wesnoth:master newfrenchy83 d60f7d8555 Update abilities.cfg AppVeyor: All builds passed 20180324 19:46:13< zookeeper> ^ it would be handy if those messages would mention/link the associated PR. 20180324 19:46:31<+discordbot4> what messages? 20180324 19:46:58< zookeeper> oh right, irker doesn't show up in discord? 20180324 19:46:59< gfgtdf> irker073 messages 20180324 19:47:23<+discordbot4> indeed, they do not 20180324 19:52:32<+discordbot4> 1.13.13 scheduled for next week 20180324 19:53:15< celticminstrel> I might've found a bug with [terrain_mask]. 20180324 19:53:22<+discordbot4> fun! 20180324 19:53:24< celticminstrel> I need a few minutes to confirm though. 20180324 19:53:43< celticminstrel> Because I also used it wrong so it could be an artifact of that. 20180324 19:53:44<+discordbot4> speak unto us what be within this conundrum? 20180324 19:54:08-!- gfgtdf [~chatzilla@x4e3680f2.dyn.telefonica.de] has quit [Read error: Connection reset by peer] 20180324 19:57:13< Ravana_> Vultraz: is it intentional that mp lobby search does not update immediately after changing its text value? 20180324 19:57:44<+discordbot4> yes 20180324 19:58:39< celticminstrel> Okay, changing border=no to border=yes fixed it, so I guess it's not a bug, just an incompatibility. 20180324 19:58:54< celticminstrel> Should be mentioned in the incompatibility list though, maybe? 20180324 19:59:10<+discordbot4> terrain_mask is weird 20180324 19:59:32<+discordbot4> I think I found i needed border= just to get it to apply correctly at all? 20180324 19:59:39<+discordbot4> not sure 20180324 19:59:53<+discordbot4> all that border stuff was from back i 1.13.2 20180324 20:00:00<+discordbot4> can't remember what was up with it 20180324 20:03:13<+discordbot4> @zookeeper did you take a look at LB's images? 20180324 20:03:21< zookeeper> not yet 20180324 20:03:23< celticminstrel> Preferences bug. 20180324 20:03:34< celticminstrel> Speed setting is not saved if accelerated speed is unchecked. 20180324 20:03:47< celticminstrel> Also, the slider shouldn't be disabled when accelerated speed is unchecked. 20180324 20:04:00<+discordbot4> that was old behavior 20180324 20:04:24< Ravana_> for some reason even 1.13.12 does not remember my password properly, still need to delete last prefilled symbol to log in 20180324 20:04:26< celticminstrel> Maybe, but it's wrong either way. The two settings are not dependent on each other. 20180324 20:04:59<+discordbot4> @Ravana perhaps you should try totally deleting your credentials file 20180324 20:06:06< Ravana_> didn't help 20180324 20:06:15< Ravana_> still last symbol is problem 20180324 20:06:21<+discordbot4> no idea then 20180324 20:06:28<+discordbot4> you must have a weird character in your password 20180324 20:06:56< Ravana_> [A-Za-z0-9]+ type of password 20180324 20:07:21<+discordbot4> so you deleted your credentials file 20180324 20:07:24<+discordbot4> restarted wesnoth 20180324 20:07:30<+discordbot4> renetered your password 20180324 20:07:33<+discordbot4> tried to log in again? 20180324 20:08:07< Ravana_> 1) deleted your credentials file; 2) restarted wesnoth; 3) renetered your password; 4) restarted wesnoth; 5) tried to log in again 20180324 20:08:43< Ravana_> for one session it seems to keep it in memory properly 20180324 20:08:51<+discordbot4> speak to @Tad Carlucci 20180324 20:09:10<+discordbot4> I think I observed the issue once buuuuut 20180324 20:09:11<+discordbot4> never again 20180324 20:09:30< Ravana_> 1.13 uses hardcoded userdata paths so not possible to test against clean install either 20180324 20:09:49<+discordbot4> uh 20180324 20:09:52<+discordbot4> what?? 20180324 20:10:00-!- travis-ci [~travis-ci@ec2-54-242-4-177.compute-1.amazonaws.com] has joined #wesnoth-dev 20180324 20:10:01< travis-ci> wesnoth/wesnoth#17169 (1.14 - 60aee8f : Charles Dang): The build passed. 20180324 20:10:01< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/357844396 20180324 20:10:01-!- travis-ci [~travis-ci@ec2-54-242-4-177.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180324 20:10:06<+discordbot4> no it doesn't? 20180324 20:10:17<+discordbot4> I didn't change the saved p;assword junk. I wanted to but felt the pushback was too much so backed away from it. 20180324 20:10:29<+discordbot4> I have been able to change the userdata path with --userdata-dir, no problem. 20180324 20:10:33<+discordbot4> ^ 20180324 20:10:46<+discordbot4> So Celtic Minstel would be the one to talk to, IIRC he wrote it. 20180324 20:10:47<+discordbot4> perhaps you're referring to the removal of the option to keep userdata in the install location 20180324 20:10:56<+discordbot4> @Tad Carlucci still think you should have changed it 20180324 20:11:17<+discordbot4> And I still think it was better to keep this way. 20180324 20:11:18< Ravana_> yes, I keep wesnoths in sensible location where virtualstore doesn't happen 20180324 20:11:36<+discordbot4> @Ravana what? 20180324 20:11:40<+discordbot4> @jyrkive why? 20180324 20:12:00<+discordbot4> @Ravana what even is "virtual store" 20180324 20:12:13<+discordbot4> @Vultraz His idea was to store the password hash in the preferences, right? 20180324 20:12:27<+discordbot4> @jyrkive well, that's not what I asked him to do... 20180324 20:12:45<+discordbot4> That would have meant that the game sends the hash to the server, and the server checks if it matches. 20180324 20:13:25< Ravana_> 1.13.2 userdata location change was made because of virtualstore 20180324 20:13:26<+discordbot4> It was too late in the development cycle. Cleaning it up to secure the local password better sould have needed a UI redesign. For some reason, it is felt important that the stored password be pre-entered into the Password field. So the near-plain-text password (in RC4 format) is what we're using. 20180324 20:13:31<+discordbot4> @jyrkive I asked him to save a login token of some sort from the server instead of saving the encrypted password. Now, if that means saving the hash, then I'm mistaken. 20180324 20:13:41< Ravana_> C:\Users\\AppData\Local\VirtualStore\Program Files (x86)\Battle for Wesnoth 1.12 20180324 20:13:50-!- gfgtdf [~chatzilla@x4e3680f2.dyn.telefonica.de] has joined #wesnoth-dev 20180324 20:13:53< gfgtdf> celticminstrel: yes please add the [terrain_mask] change to the list of changes 20180324 20:14:14< Ravana_> but no matter, no point complaining about that 20180324 20:14:18<+discordbot4> This sounds like something that was brought up earlier? https://forums.wesnoth.org/viewtopic.php?f=21&t=44570&p=625154#p625154 20180324 20:14:20< gfgtdf> celticminstrel: what border=no basicially does is adding a vorder of foig tiles around the data. 20180324 20:14:34<+discordbot4> @Pentarctagon just fixed earlier 20180324 20:14:49< gfgtdf> border* 20180324 20:14:55<+discordbot4> @Ravana and what was the problem with this virtualstore? 20180324 20:15:33<+discordbot4> all I remember was we removed the option to keep userdata in the install dir, which is usually C:/Program Files 20180324 20:15:43< Ravana_> https://forums.wesnoth.org/viewtopic.php?f=5&t=43342 20180324 20:15:53<+discordbot4> @Vultraz "token" means anything. The token we have in hand is the bcrypt hashed password. IT works as well as any other token. The problem is, whatever the token used, the UI needed to change 20180324 20:16:07< Ravana_> shadowm explained it under Long “you want to read this with a cup of tea” version: 20180324 20:16:15<+discordbot4> reads 20180324 20:17:16< gfgtdf> celticminstrel: i think the change is bsicially that border= now defaults to yes instead of no 20180324 20:17:32<+discordbot4> And that meant no password in the Password field, In fact, no login dialog at all in most cases once you store the password-token and username in the credentials file. Too much of a change, nobody wanted to make it impossible to retrieve your password. 20180324 20:17:53< gfgtdf> celticminstrel: maybe we coudl make wmlint warn if a [terrain_mask] with no border=key is used ? 20180324 20:18:06<+discordbot4> Not only that, but such a change would also be worse for security. 20180324 20:18:22< celticminstrel> gfgtdf: Uhh, it was removing the border key that fixed it for me. 20180324 20:18:26< celticminstrel> I had border=no. 20180324 20:18:29<+discordbot4> @Ravana ok, so I'm not sure what that has to do with you and not testing with a clean userdata dir 20180324 20:18:32<+discordbot4> After that, obtaining the hash alone would allow an attacker to upload add-ons. 20180324 20:18:39< celticminstrel> I assume it worked at some point. 20180324 20:18:50< gfgtdf> celticminstrel: that's suprising 20180324 20:18:53< Ravana_> It means I can't run 1.13.12 installer again to get clean version 20180324 20:19:04<+discordbot4> @Ravana I've always stored userdata in Documents/My Games (the default). What's wrong with just using --userdata-dir to poit to a new folder somewhere? 20180324 20:19:17<+discordbot4> you don't need to reinstall the game to get a clean userdata dir... 20180324 20:19:18<+discordbot4> O_O 20180324 20:19:43<+discordbot4> @jyrkive addon passwords have nothing to do with mp passwords 20180324 20:19:45<+discordbot4> The most important attack login databases try to defend against is "someone managed to dump the whole DB". If you store hashes in the DB but login happens with actual password, you're still safe because hashes can't be traced back to the actual passwords. 20180324 20:20:18<+discordbot4> If the hash is used for authentication, that defense falls down. 20180324 20:22:45<+discordbot4> I defer to your superior knowledge on the subject. 20180324 20:23:10<+discordbot4> I don't actually know what I'm talking about here 20180324 20:23:19<+discordbot4> same thing happens to me as @Ravana 20180324 20:23:39<+discordbot4> @Pentarctagon passwords have an extra character? 20180324 20:23:43<+discordbot4> yes 20180324 20:23:59<+discordbot4> the hell 20180324 20:24:16<+discordbot4> first time works,. close > join the server > password doesn't work until I remove the last character 20180324 20:24:32<+discordbot4> @Ravana That same post explains exactly how to get Wesnoth to use a different (optionally clean) userdata+config dir. 20180324 20:25:27<+discordbot4> what goes in the config dir again? 20180324 20:25:36<+discordbot4> because for me it and userdata are the same 20180324 20:25:55< Ravana_> config-dir says it is deprecated 20180324 20:26:00<+discordbot4> Use it anyway. 20180324 20:26:10<+discordbot4> We'll figure out what to do with it in 1.15.x. 20180324 20:26:46<+discordbot4> also, what's the purpose of the hover over the username? It looks like it has a link to the forums, but only part of it is underlined and I can't click it anyway because the hover disappears when I move my cursor off 20180324 20:26:48<+discordbot4> --config-dir Foo is essentially --userconfig-dir Foo --userdata-dir Foo for compatibility purposes since we used to have unified user config+data on all platforms. 20180324 20:27:03<+discordbot4> https://cdn.discordapp.com/attachments/259976436490829825/427201702396035072/Screenshot_from_2018-03-24_15-24-57.png 20180324 20:27:08<+discordbot4> Then that stopped being the case when on X11 we switched to using the Freedesktop.org model. 20180324 20:27:28<+discordbot4> yeah, i didn't really think that through 20180324 20:27:49<+discordbot4> 😬 20180324 20:27:54<+discordbot4> One idea I had was renaming --config-dir to --profile-dir or so but I was forced to take an extended break first. 20180324 20:28:29<+discordbot4> The only reason it's deprecated is because it is too close to --userconfig-dir in name, not because it is not useful. 20180324 20:29:17< Ravana_> ok, password problem remains even when running as C:\Users\Ravana\Desktop\general\wesnoth-related\dev1.13.12>wesnoth_1_13_12.exe - -config-dir ./userdata 20180324 20:29:47<+discordbot4> @Ravana might as well open a bug at this point 20180324 20:29:51<+discordbot4> since pent can repro 20180324 20:30:03<+discordbot4> src/filesystem_common.cpp:49: return get_user_config_dir() + "/credentials"; 20180324 20:30:35<+discordbot4> It will be read from the user config dir along with preferences. 20180324 20:31:22<+discordbot4> celticminstrel: might want to file an issue about the prefs thing 20180324 20:36:24<+discordbot4> @shadowm some of these translation issues are because I never marked them as translatable at all 😦 20180324 20:36:25<+discordbot4> what do? 20180324 20:37:10<+discordbot4> ie, ss << "Level " << type_.level(); 20180324 20:37:19<+discordbot4> how do I know if we have a textdomain with "level" 20180324 20:38:03<+discordbot4> By grepping the catalogue templates (pot files). 20180324 20:38:08< irker073> wesnoth: pentarctagon wesnoth:master 376f2e9dbe56 / .travis.yml: Explicitly set osx_image for osx+scons job. https://github.com/wesnoth/wesnoth/commit/376f2e9dbe562c21671f88e8f3ef932b003a7fb5 20180324 20:39:00< celticminstrel> Bug filed. 20180324 20:39:33<+discordbot4> About speed preferences? 20180324 20:39:50<+discordbot4> Here in Discord side we get automatic notifications about new bug reports. 20180324 20:40:06<+discordbot4> indeed we do :3 20180324 20:43:55-!- travis-ci [~travis-ci@ec2-54-198-138-121.compute-1.amazonaws.com] has joined #wesnoth-dev 20180324 20:43:56< travis-ci> wesnoth/wesnoth#17172 (master - 915dfaa : Charles Dang): The build passed. 20180324 20:43:56< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/357869046 20180324 20:43:57-!- travis-ci [~travis-ci@ec2-54-198-138-121.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180324 20:51:58< celticminstrel> There's issue notifications on the IRC side too if you join #wesnoth-commits 20180324 20:52:30<+discordbot4> Meh 20180324 20:52:56< irker073> wesnoth/wesnoth:master newfrenchy83 50c85512dc Update abilities.cfg AppVeyor: All builds passed 20180324 21:02:27< celticminstrel> Might have another bug. :| 20180324 21:02:33< celticminstrel> [avoid] doesn't seem to be working... 20180324 21:03:41< celticminstrel> Hmm, now that I'm looking at the correct side, the AI facet is added with the correct value... 20180324 21:04:45< celticminstrel> I've still had two units clearly ignore it though... 20180324 21:05:14< celticminstrel> Unless dirt doesn't match R* 20180324 21:09:57-!- grzywacz [~karol@89-70-226-147.dynamic.chello.pl] has quit [Ping timeout: 240 seconds] 20180324 21:10:29-!- mattsc [~mattsc@167.98.9.52] has joined #wesnoth-dev 20180324 21:11:38-!- mattsc [~mattsc@167.98.9.52] has quit [Changing host] 20180324 21:11:38-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev 20180324 21:13:20< mattsc> So the irc and discord dev channels are linked now? 20180324 21:13:28<+discordbot4> Looks like it ... 20180324 21:13:32<+discordbot4> Yes 20180324 21:13:39<+discordbot4> It has been proving useful 20180324 21:13:43<+discordbot4> I bet 20180324 21:14:19<+discordbot4> @hrubymar10 , celmin : I don't think I have any special permissions to the MacCompileStuff folder on SF 20180324 21:14:38<+discordbot4> That reminds me 20180324 21:14:50< mattsc> Anybody with a SF account should be able to upload there 20180324 21:15:04< mattsc> Well, SF dev account, or whatever it is called 20180324 21:15:13<+discordbot4> Planning to create two repos, one each for windows and MacOs dependencies onGH 20180324 21:15:20<+discordbot4> Unless celmin has a better idea 20180324 21:15:31-!- travis-ci [~travis-ci@ec2-54-198-138-121.compute-1.amazonaws.com] has joined #wesnoth-dev 20180324 21:15:32< travis-ci> wesnoth/wesnoth#17173 (master - 376f2e9 : pentarctagon): The build passed. 20180324 21:15:32< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/357887001 20180324 21:15:32-!- travis-ci [~travis-ci@ec2-54-198-138-121.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180324 21:15:56< mattsc> Also, I am traveling overseas at the moment, until Wed, so I have very limited ability to take care of anything. 20180324 21:15:56<+discordbot4> Sure, but I had different question, I'll contact you via DM on Discord @csttam mattsc 20180324 21:16:05< mattsc> ok 20180324 21:16:35<+discordbot4> @Vultraz I am working on repo for macOS https://github.com/hrubymar10/MacCompileStuff 20180324 21:17:04<+discordbot4> Indeed, something like that but under the wesnoth org 20180324 21:18:18< celticminstrel> @Vultraz I don't like that idea at all. I'd much prefer if we don't need any "compile-stuff". HOWEVER, if you want to do it, then fine. 20180324 21:18:18<+discordbot4> mine repo is not done yet, but after it will be, you can transfer it under wesnoth.org 20180324 21:18:38< celticminstrel> I can at least see that it makes sense to have that level of control over the libs used for releases. 20180324 21:18:40< mattsc> Btw, I don’t think I can easily change my nick on Discord … (or maybe I haven’t tried, I’ve forgotten) 20180324 21:18:41<+discordbot4> celmin 20180324 21:18:43<+discordbot4> i kidan agree with you 20180324 21:19:06<+discordbot4> @csttam you can very easily change your displayed nick on discord 20180324 21:19:20<+discordbot4> @csttam right click your name -> change nickname 20180324 21:20:18-!- hrubymar10 [~textual@ip-86-49-9-122.net.upcbroadband.cz] has joined #wesnoth-dev 20180324 21:21:04<+discordbot4> @Vultraz nope 20180324 21:21:18<+discordbot4> Isn't that restricted to certain roles? 20180324 21:22:57-!- hrubymar10 [~textual@ip-86-49-9-122.net.upcbroadband.cz] has quit [Client Quit] 20180324 21:22:59< celticminstrel> Aww, I can't play rumble-short.ogg at reduced volume. Oh well? 20180324 21:23:21< celticminstrel> Although... if [sound_source] works through impassable terrain... 20180324 21:23:43< celticminstrel> ...nah. 20180324 21:24:14< celticminstrel> (Looks like it does though.) 20180324 21:24:49<+discordbot4> @csttam odd 20180324 21:25:23<+discordbot4> @csttam User Settings perhaps? 20180324 21:30:58-!- hrubymar10 [~textual@ip-86-49-9-122.net.upcbroadband.cz] has joined #wesnoth-dev 20180324 21:33:17<+discordbot4> @Vultraz Hmm, I thought I had tried that previously and it had not worked. 20180324 21:33:36< mattsc> yeah, see, still showing up as csttam there ^ 20180324 21:34:01<+discordbot4> Only in the side bar is it different (for me) now 20180324 21:34:28<+discordbot4> yeah i still see csttam 20180324 21:34:48<+discordbot4> but your name has changed to @csttam 20180324 21:35:19<+discordbot4> I guess that's the underlying user id 20180324 21:35:23<+discordbot4> but not your display name 20180324 21:36:04< mattsc> something like that 20180324 21:36:54<+discordbot4> because I now definitely @ you differently 20180324 21:37:11<+discordbot4> no idea why you're not seeing Change Nickname 20180324 21:40:15<+discordbot4> I've given @hrubymar10 the Packagers role and removed @ancestral from the same 20180324 21:40:26< mattsc> Me neither. Either way, I need to be off again. I’ll be checking the logs on and off, but I’m on the road, so it might be a bit until I can reply if needed. Forntuanetly, it’s not needed much these days. 20180324 21:40:35< mattsc> Sounds good to me. 20180324 21:40:40< mattsc> Bye for now. 20180324 21:40:59<+discordbot4> Bye mattsc 20180324 21:41:08-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: So long and thanks for all the fish.] 20180324 21:43:43<+discordbot4> project members are not allowed to change nicknames 20180324 21:44:07< Ravana_> forgot that I should send messages only from irc 20180324 21:44:15<+discordbot4> @Vultraz The OldaniaADFStd-Regular.otf font file in the repo has another md5sum than the one availaible here, which I think is the upstream source http://arkandis.tuxfamily.org/adffonts.html 20180324 21:44:18<+discordbot4> nein 😛 20180324 21:44:34<+discordbot4> @sevu hm? 20180324 21:44:53<+discordbot4> I dunno, maybe you added an older version of the font file? 20180324 21:45:32<+discordbot4> The one I pulled was from https://github.com/wesnoth/resources/tree/master/images/logoscript 20180324 21:45:51<+discordbot4> which I added because Sgt Groovy (the new logo's author) included it when he sent that resource pack 20180324 21:45:57<+discordbot4> so that's entirely possile 20180324 21:47:11<+discordbot4> oh my, there are style variants here o_o 20180324 21:48:26<+discordbot4> @sevu you're right. We have version 1.006;FFEdit, whereas that download is of 1.007;FFEdit 20180324 21:49:02<+discordbot4> How did you find out the version? I was looking for that 20180324 21:49:20<+discordbot4> Preview 20180324 21:49:27<+discordbot4> it's a context menu option for font files on Windows 20180324 21:50:11<+discordbot4> I could get a new software for displaying font files ... 20180324 21:50:41<+discordbot4> what? 20180324 21:51:03<+discordbot4> I have some KDE software which doesn't display it 20180324 21:51:31<+discordbot4> https://cdn.discordapp.com/attachments/259976436490829825/427222961359945728/unknown.png 20180324 21:52:47<+discordbot4> I'll commit the new version and the variants 20180324 21:53:37<+discordbot4> @sevu thanks for finding this 😃 20180324 21:54:48<+discordbot4> just coincidence. if they are commited, that means umc authors can specify somewhere in wml what font to use? 20180324 21:55:35<+discordbot4> it might be possible with the current API, yes 20180324 21:55:48< celticminstrel> Hmm. Has anyone actually thought to try custom conditionals in events? 20180324 21:56:03< celticminstrel> eg [filter_condition][used_item] 20180324 21:56:08<+discordbot4> yes 20180324 21:56:13< celticminstrel> So do they work? 20180324 21:56:17<+discordbot4> I did that two years ago. 20180324 21:56:31< celticminstrel> ...when were custom conditionals added, again? 20180324 21:56:40< celticminstrel> So anyway, they do work, then? 20180324 21:57:03<+discordbot4> last i checked 20180324 21:57:06<+discordbot4> why wouldn't they? 20180324 21:57:06< celticminstrel> Hmm. 20180324 21:57:13<+discordbot4> did you break them? 20180324 21:57:17< celticminstrel> Just trying to do something, it's not working. 20180324 21:57:21< celticminstrel> I doubt I broke them. 20180324 21:57:32< celticminstrel> There are multiple reasons why it could be not working though. 20180324 21:58:00< celticminstrel> I can see that the conditional is being called at least once, so it might not be a question of whether or not it's called... 20180324 21:58:32-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20180324 22:00:59-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180324 22:01:21< irker073> wesnoth: Charles Dang wesnoth:master cef0edb4ac02 / fonts/ (4 files): Updated Oldania font files to version 1.007 (FFEdit) https://github.com/wesnoth/wesnoth/commit/cef0edb4ac02e9cbb3c7044466f9655a1e66278f 20180324 22:03:03< celticminstrel> Looks like the problem was in my code after all. 20180324 22:03:45< irker073> wesnoth: Charles Dang wesnoth:1.14 d73302240b63 / / (5 files in 2 dirs): Updated Oldania font files to version 1.007 (FFEdit) https://github.com/wesnoth/wesnoth/commit/d73302240b63ee8c61c1a2afe04eb2e77b4481b9 20180324 22:04:16<+discordbot4> many fonts, ship now we do 20180324 22:05:03< celticminstrel> I've added formula= to [variable], is that wanted in master? 20180324 22:05:30< celticminstrel> So basically you can do eg [variable] name=thing formula="value > 12 and value < 72" 20180324 22:05:31<+discordbot4> wasn't that added months ago? 20180324 22:05:34< celticminstrel> No. 20180324 22:05:40< celticminstrel> As far as I know. 20180324 22:05:48<+discordbot4> I swear it was.. 20180324 22:05:48< celticminstrel> I know of no extensions ever made to [variable] 20180324 22:06:00<+discordbot4> oh 20180324 22:06:01< celticminstrel> You might be thinking of [set_variable]? I might've added it there somewhat recently. 20180324 22:06:05<+discordbot4> maybe it was [set_variab;[e 20180324 22:06:30<+discordbot4> well, to answer your questions, ALL such features are wanted in master 20180324 22:06:35< celticminstrel> Alright. 20180324 22:08:04< Ravana_> if formula is added then lua_function should be as well 20180324 22:08:16< Ravana_> that also currently needs going though standard unit filter 20180324 22:08:21< irker073> wesnoth: Celtic Minstrel wesnoth:lua_reorg f61589569750 / data/lua/wml-conditionals.lua: Support formula= in [variable] ConditionalWML https://github.com/wesnoth/wesnoth/commit/f61589569750133c636c117218b749446c5ebc0c 20180324 22:08:51< irker073> wesnoth: Celtic Minstrel wesnoth:master 4e52d62963b1 / data/lua/wml-conditionals.lua: Support formula= in [variable] ConditionalWML https://github.com/wesnoth/wesnoth/commit/4e52d62963b10c26f33bccfcbad758c0072da393 20180324 22:09:16<+discordbot4> if that's not being packborted add a changelog entry to master 20180324 22:09:22< celticminstrel> Ravana_: IMO lua_function support there is pointless. 20180324 22:09:36< celticminstrel> If you're using Lua you might as well just define a custom tag instead. 20180324 22:09:47-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection] 20180324 22:10:09< celticminstrel> @Vultraz It's not being backported. 20180324 22:10:19<+discordbot4> then please add a changelog to master 20180324 22:10:34<+discordbot4> it seems we're adding entries to the 1.13.12 log for stuff that's in both branches 20180324 22:10:39<+discordbot4> but if it's not it needs to go in master 20180324 22:11:37< irker073> wesnoth: Celtic Minstrel wesnoth:master 7a1ea36d3943 / changelog.md: Update changelog https://github.com/wesnoth/wesnoth/commit/7a1ea36d3943050bd26072ed8d1cabb7aca2f6eb 20180324 22:12:31-!- travis-ci [~travis-ci@ec2-54-204-75-6.compute-1.amazonaws.com] has joined #wesnoth-dev 20180324 22:12:32< travis-ci> wesnoth/wesnoth#17174 (lua_reorg - f615895 : Celtic Minstrel): The build has errored. 20180324 22:12:32< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/357906202 20180324 22:12:32-!- travis-ci [~travis-ci@ec2-54-204-75-6.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180324 22:15:50< irker073> wesnoth: Charles Dang wesnoth:master 11e88dd1caf2 / fonts/ (5 files): Updated DejaVu Sans font files to version 2.37 (from 2.35) https://github.com/wesnoth/wesnoth/commit/11e88dd1caf22af0d65a1785ff8e972f6a99270d 20180324 22:17:46< celticminstrel> gfgtdf: Does wesnoth.special_locations["invalid_loc"] return nil? 20180324 22:18:18< gfgtdf> i'd think so but you coudl also just test it 20180324 22:18:25< irker073> wesnoth: Charles Dang wesnoth:1.14 44d95543618e / / (6 files in 2 dirs): Updated DejaVu Sans font files to version 2.37 (from 2.35) https://github.com/wesnoth/wesnoth/commit/44d95543618e2c28cfa05ee163ddc3c3d741aec1 20180324 22:18:50<+discordbot4> Didn't update the codepoints list, though. 20180324 22:20:02<+discordbot4> the fact that that thing exists is absurd >_> 20180324 22:21:05< celticminstrel> Probably a necessary evil. 20180324 22:21:18< celticminstrel> UE uses codepoint lists too FTR. 20180324 22:21:21<+discordbot4> who know 20180324 22:21:28<+discordbot4> wat 20180324 22:22:45<+discordbot4> im curious how long it takes to parse those lists 20180324 22:22:53<+discordbot4> they're thousands of entries long 20180324 22:23:13< celticminstrel> Probably not that long. 20180324 22:23:25<+discordbot4> adds logging 20180324 22:23:29< celticminstrel> Doesn't it use range operators or something? 20180324 22:23:41< celticminstrel> Like 32-126 20180324 22:23:50< celticminstrel> (Or 20-FE if it's in hex.) 20180324 22:24:09<+discordbot4> sometimes 20180324 22:25:04<+discordbot4> celmin 20180324 22:25:11<+discordbot4> did you ever take a look at the lp8 lua pack? 20180324 22:26:20< celticminstrel> Keep in mind that without these codepoint lists you'll have to either 1. build up the font texture atlas on-demand as text is rendered or 2. run a lengthy loop over every possible character to see if the font has it (or 3. ask the font for a lit of all the characters it has, but not sure if that's possible). 20180324 22:26:22< celticminstrel> The what pack now? 20180324 22:26:47<+discordbot4> celticminstrel: 8680 was basically wrote this helper lib of a lot of stuff to help me with Lua stuff in 1.12. Has very useful stuff. Like it had a [remove_object] impl. 20180324 22:26:54<+discordbot4> figured it might be useful to look at for reference 20180324 22:26:55<+discordbot4> https://github.com/8573/wesnoth-lp8 20180324 22:27:23< celticminstrel> Oh, I think I remember looking at that [remove_object] implementation awhile ago. 20180324 22:27:49<+discordbot4> but it has a ton of other stuff! 20180324 22:31:58< irker073> wesnoth: Celtic Minstrel wesnoth:master 1dd411a84eb6 / changelog.md data/lua/wml/move_unit.lua: Support to_location in [move_unit] https://github.com/wesnoth/wesnoth/commit/1dd411a84eb6a45c81d14359aaaec7af34351a39 20180324 22:33:26<+discordbot4> ftr pango knows how many unknown glyphs there are 20180324 22:33:27<+discordbot4> pango_layout_get_unknown_glyphs_count 20180324 22:35:08<+discordbot4> celmin: anyway can we do stuff like this in 1.14? https://github.com/8573/wesnoth-lp8/blob/master/8680s_Lua_Pack/modify_unit_attacks.lua 20180324 22:35:16<+discordbot4> i dunno if you added attack access. 20180324 22:35:45< celticminstrel> You can do it in an addon in 1.14, sure. 20180324 22:35:58< celticminstrel> You can access attacks without going through __cfg, yes. 20180324 22:36:43-!- hrubymar10 [~textual@ip-86-49-9-122.net.upcbroadband.cz] has quit [Quit: hrubymar10] 20180324 22:37:32<+discordbot4> perhaps his addon is obsolete 😦 20180324 22:37:43< celticminstrel> I dunno. 20180324 22:37:53< celticminstrel> Might not be. 20180324 22:38:25-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 248 seconds] 20180324 22:43:04< celticminstrel> Hmm, I guess [unit] doesn't accept a filter for the unit's location... :/ 20180324 22:45:49-!- hrubymar10 [~textual@ip-86-49-9-122.net.upcbroadband.cz] has joined #wesnoth-dev 20180324 22:52:33< Ravana_> that red [S] needs tooltip https://i.imgur.com/kbjqW5Q.png 20180324 22:54:08< Ravana_> 1.13 doesn't say https://i.imgur.com/eOE2J6G.png , but I guess it is not really needed either 20180324 22:57:57<+discordbot4> You don’t need to use imgur, you can just paste directly in Discord 20180324 22:58:29< Ravana_> that requires sending messages from dc interface 20180324 22:58:34<+discordbot4> Yes 20180324 22:58:59< Ravana_> honestly uploading it somewhere is more work than just taking screenshot and pasting link 20180324 22:59:29< Ravana_> https://i.imgur.com/4WjEQPc.png 20180324 23:06:48-!- hrubymar10 [~textual@ip-86-49-9-122.net.upcbroadband.cz] has quit [Quit: hrubymar10] 20180324 23:07:24-!- hrubymar10 [~textual@ip-86-49-9-122.net.upcbroadband.cz] has joined #wesnoth-dev 20180324 23:09:02-!- travis-ci [~travis-ci@ec2-54-204-75-6.compute-1.amazonaws.com] has joined #wesnoth-dev 20180324 23:09:03< travis-ci> gfgtdf/wesnoth#1045 (fix_1856 - 360d22c : gfgtdf): The build failed. 20180324 23:09:03< travis-ci> Build details : https://travis-ci.org/gfgtdf/wesnoth/builds/357908723 20180324 23:09:03-!- travis-ci [~travis-ci@ec2-54-204-75-6.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180324 23:10:54-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Quit: Caught sigterm, terminating...] 20180324 23:11:16-!- Ivanovic [~ivanovic@p4FC53D61.dip0.t-ipconnect.de] has joined #wesnoth-dev 20180324 23:11:35-!- Ivanovic [~ivanovic@p4FC53D61.dip0.t-ipconnect.de] has quit [Changing host] 20180324 23:11:36-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev 20180324 23:11:50< celticminstrel> Possible bug (gfgtdf?): location_id=1 does not work. 20180324 23:12:00< celticminstrel> This is in a filter FTR. 20180324 23:13:25< celticminstrel> ...hold that thought, let me check again. 20180324 23:14:07<+discordbot4> @Ravana honestly, some of the stuff is going to have changed. We can't expect everything to work exactly the same :/ 20180324 23:15:29< Ravana_> better for me would be to not care about missing units and just let me observe 20180324 23:15:56< Ravana_> but current message itself says to report, so something needs to be changed 20180324 23:16:04<+discordbot4> yes, THAT bit is a problem 20180324 23:16:33<+discordbot4> what era was this game? 20180324 23:16:45< Ravana_> SXC default low level 20180324 23:17:10<+discordbot4> hmm 20180324 23:17:11<+discordbot4> well 20180324 23:17:18<+discordbot4> that message means no required addons were found 20180324 23:17:25<+discordbot4> yet it says addons are needed 20180324 23:17:34<+discordbot4> Not sure how to deal with this.. 20180324 23:18:20< Ravana_> 1.12 would grey it out for nonmods and allow attempting observing for mods 20180324 23:18:42< irker073> wesnoth/wesnoth:master Celtic Minstrel bbbbd6d90a Deprecate helper.wml_error and move it t AppVeyor: vs2017/Release Failed 20180324 23:18:43< irker073> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-master-1884 20180324 23:18:55< Ravana_> but addon server checking might happen at different time so might not be useful 20180324 23:18:57<+discordbot4> yes well now we allow downloading addons 20180324 23:20:19< Ravana_> I guess I should eventually verify that downloading addons works with addon updates 20180324 23:20:25<+discordbot4> @Ravana also, please, PLEASE don't tell me the era just appears only as "(missing)"... 20180324 23:20:40< Ravana_> appears as https://i.imgur.com/OkDIpC2.png 20180324 23:20:58<+discordbot4> ok 20180324 23:20:59<+discordbot4> WHEW 20180324 23:21:00<+discordbot4> ok 20180324 23:21:01<+discordbot4> ok ok ok 20180324 23:21:07<+discordbot4> that's fine 20180324 23:21:28<+discordbot4> is SX on the server? 20180324 23:22:17< celticminstrel> gfgtdf: False alarm, it does work. 20180324 23:22:34-!- hrubymar10 [~textual@ip-86-49-9-122.net.upcbroadband.cz] has quit [Quit: hrubymar10] 20180324 23:23:12< celticminstrel> Hmm. Is there a way to construct a location filter that takes the intersection of three circles/ 20180324 23:23:14< Ravana_> deleted that image as it contained my IP 20180324 23:23:15< celticminstrel> ^? 20180324 23:23:30-!- hrubymar10 [~textual@ip-86-49-9-122.net.upcbroadband.cz] has joined #wesnoth-dev 20180324 23:23:32<+discordbot4> from imgur? 20180324 23:23:52< Ravana_> yes 20180324 23:25:52< Ravana_> fortunate that sharex saves delete link too 20180324 23:26:29<+discordbot4> no idea how important keeping an IP safe is 20180324 23:27:03< Ravana_> at least something, otherwise there wouldn't be said "Note that IP addresses of users are not available to non-administrators, and should be treated as confidential." 20180324 23:30:16<+discordbot4> Next release on 1. April? Bad date, nobody will take it serious 20180324 23:30:24<+discordbot4> xD 20180324 23:32:26< hrubymar10> Does anyone has contact to crimson_penguin? He is online since 15 March but is inactive 20180324 23:32:48<+discordbot4> yes 20180324 23:32:55<+discordbot4> what's the problem? 20180324 23:33:14<+discordbot4> with crimson_penguin? 20180324 23:33:29<+discordbot4> no why do you need to talk to him 20180324 23:34:05<+discordbot4> I have questions about MacCompileStuff 20180324 23:34:14<+discordbot4> He created some releases 20180324 23:34:28<+discordbot4> That was a long time ago 20180324 23:34:57<+discordbot4> ikr, but this is question about thing which is still same 😄 20180324 23:35:12<+discordbot4> How can one build fontconfig without UUID dependence 20180324 23:35:26<+discordbot4> UUID? 20180324 23:36:03<+discordbot4> ... checking for struct dirent.d_type... yes checking The type of len parameter of gperf hash/lookup function... unsigned int checking for FREETYPE... yes checking for FT_Get_BDF_Property... yes checking for FT_Get_PS_Font_Info... yes checking for FT_Has_PS_Glyph_Names... yes checking for FT_Get_X11_Font_Format... yes checking for FT_Done_MM_Var... yes checking for UUID... no configure: error: Package requirements (uuid) were 20180324 23:36:04<+discordbot4> not met: No package 'uuid' found Consider adjusting the PKG_CONFIG_PATH environment variable if you installed software in a non-standard prefix. Alternatively, you may set the environment variables UUID_CFLAGS and UUID_LIBS to avoid the need to call pkg-config. See the pkg-config man page for more details. 20180324 23:37:05<+discordbot4> I can instal UUID package but then output .dylib library of fontconfig also require UUID and we aren't packaging UUID inside wesnoth 20180324 23:37:48<+discordbot4> wasn't homebrew supposed to be a package manager solution to build deps for mac? 20180324 23:38:04<+discordbot4> i'm wondering if it'd not be better to abandon maccompilestuff like celmin suggested 20180324 23:38:07<+discordbot4> only for local builds 20180324 23:39:11<+discordbot4> @sinda 's quote "homebrew is designed to get/build the latest version for YOUR hardware and OS" 20180324 23:39:16<+discordbot4> ah 20180324 23:39:59<+discordbot4> well penguin's over on the frogatto server: https://discord.gg/n7a4S3 20180324 23:40:12<+discordbot4> you could pop in and ask him (probably in a DM) 20180324 23:40:21<+discordbot4> As result packages built using homebrew worked only in macOS 10.10 and newer. But Wesnoth theoretically supports 10.7 and practically 10.8 now 20180324 23:40:46<+discordbot4> eh, we're saying 10.8 up just for convenience 20180324 23:41:02<+discordbot4> ignore 10.7 20180324 23:41:55<+discordbot4> Thank you for contact @Vultraz 20180324 23:42:50<+discordbot4> Well, IMO 10.7 is so outdated that we should fully abandon it (sorry CelticMinstrel but you are only person who still uses it) 20180324 23:43:11< celticminstrel> Even the sole 10.7 user agrees it's impractical to continue supporting it. 20180324 23:43:14<+discordbot4> Also Wesnoth is 64-bit only now on macOS and 10.7 have big problems with it 20180324 23:43:33< loonycyborg> btw will frogatto be released on steam too? 20180324 23:43:56< celticminstrel> It could be practical to support it for building, but Vultraz insists on using the latest and greatest of C++, so... 20180324 23:44:21<+discordbot4> So, can we officially cut support for 10.7 before 1.14.0 release? 20180324 23:44:48<+discordbot4> I am still do tests on 10.7 but long story short, it doesn't work now 20180324 23:45:22-!- hrubymar10 [~textual@ip-86-49-9-122.net.upcbroadband.cz] has quit [Quit: hrubymar10] 20180324 23:45:33<+discordbot4> Yes 20180324 23:47:15< irker073> wesnoth/wesnoth:master Celtic Minstrel 18876f54fe Deprecate helper.wml_error and move it t AppVeyor: 2/4 builds failed 20180324 23:47:16< irker073> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-2164 20180324 23:47:17< irker073> Details vs2017/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-master-1870 20180324 23:47:45<+discordbot4> Ok, tomorrow I'll update Xcode projects 20180324 23:52:26-!- travis-ci [~travis-ci@ec2-54-198-138-121.compute-1.amazonaws.com] has joined #wesnoth-dev 20180324 23:52:27< travis-ci> wesnoth/wesnoth#17177 (lua_reorg - e177021 : Celtic Minstrel): The build has errored. 20180324 23:52:27< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/357906401 20180324 23:52:27-!- travis-ci [~travis-ci@ec2-54-198-138-121.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180324 23:53:08< celticminstrel> I'm okay with it. I'm doing my campaign work on Windows now in any case. --- Log closed Sun Mar 25 00:00:14 2018