--- Log opened Sun Mar 25 00:00:14 2018 20180325 00:22:07<+discordbot4> hmm apparently not endless, it ended by the time I submitted the issue 20180325 00:23:36<+discordbot4> or maybe not 20180325 00:25:20-!- travis-ci [~travis-ci@ec2-54-204-75-6.compute-1.amazonaws.com] has joined #wesnoth-dev 20180325 00:25:21< travis-ci> gfgtdf/wesnoth#1046 (fix_1856 - 6eacabe : gfgtdf): The build is still failing. 20180325 00:25:21< travis-ci> Build details : https://travis-ci.org/gfgtdf/wesnoth/builds/357931530 20180325 00:25:21-!- travis-ci [~travis-ci@ec2-54-204-75-6.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180325 00:26:11-!- Bonobo [~Bonobo@203.220.138.198] has joined #wesnoth-dev 20180325 00:38:02-!- travis-ci [~travis-ci@ec2-54-242-4-177.compute-1.amazonaws.com] has joined #wesnoth-dev 20180325 00:38:03< travis-ci> gfgtdf/wesnoth#1047 (fix_1856 - 2809df8 : gfgtdf): The build is still failing. 20180325 00:38:03< travis-ci> Build details : https://travis-ci.org/gfgtdf/wesnoth/builds/357932705 20180325 00:38:03-!- travis-ci [~travis-ci@ec2-54-242-4-177.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180325 00:53:00-!- travis-ci [~travis-ci@ec2-54-198-138-121.compute-1.amazonaws.com] has joined #wesnoth-dev 20180325 00:53:01< travis-ci> gfgtdf/wesnoth#1049 (fix_1856 - c055465 : gfgtdf): The build is still failing. 20180325 00:53:01< travis-ci> Build details : https://travis-ci.org/gfgtdf/wesnoth/builds/357935804 20180325 00:53:01-!- travis-ci [~travis-ci@ec2-54-198-138-121.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180325 01:00:08-!- travis-ci [~travis-ci@ec2-54-242-4-177.compute-1.amazonaws.com] has joined #wesnoth-dev 20180325 01:00:09< travis-ci> wesnoth/wesnoth#17180 (master - 1dd411a : Celtic Minstrel): The build has errored. 20180325 01:00:09< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/357911595 20180325 01:00:09-!- travis-ci [~travis-ci@ec2-54-242-4-177.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180325 01:07:51-!- Bonobo [~Bonobo@203.220.138.198] has quit [Ping timeout: 240 seconds] 20180325 01:08:13-!- travis-ci [~travis-ci@ec2-54-204-75-6.compute-1.amazonaws.com] has joined #wesnoth-dev 20180325 01:08:14< travis-ci> gfgtdf/wesnoth#1050 (fix_1856 - 5b50bfe : gfgtdf): The build is still failing. 20180325 01:08:14< travis-ci> Build details : https://travis-ci.org/gfgtdf/wesnoth/builds/357938143 20180325 01:08:14-!- travis-ci [~travis-ci@ec2-54-204-75-6.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180325 01:08:18-!- Bonobo [~Bonobo@203.220.138.198] has joined #wesnoth-dev 20180325 01:12:16<+discordbot4> @shadowm related to #2748: When I try to use the Password Reminder function at all, it tells me to use the password recovery option on the forums. Should we perhaps get rid of the PAssword Reminder button, then? 20180325 01:16:58-!- gfgtdf_ [~chatzilla@x4e363818.dyn.telefonica.de] has joined #wesnoth-dev 20180325 01:18:51-!- gfgtdf [~chatzilla@x4e3680f2.dyn.telefonica.de] has quit [Ping timeout: 240 seconds] 20180325 01:18:53-!- gfgtdf_ is now known as gfgtdf 20180325 01:22:53-!- travis-ci [~travis-ci@ec2-54-204-75-6.compute-1.amazonaws.com] has joined #wesnoth-dev 20180325 01:22:54< travis-ci> gfgtdf/wesnoth#1051 (fix_1856 - 128bf77 : gfgtdf): The build is still failing. 20180325 01:22:54< travis-ci> Build details : https://travis-ci.org/gfgtdf/wesnoth/builds/357939230 20180325 01:22:54-!- travis-ci [~travis-ci@ec2-54-204-75-6.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180325 01:28:44<+discordbot4> @csttam You can change your username on Discord under User Settings → My Account → Edit. It applies to all servers where you don't have a nickname, and DMs. 20180325 01:30:36<+discordbot4> @loonycyborg The next major version of Frogatto will be released on Steam but it's taken them like 4 years and it doesn't look like they're close to a release yet. 20180325 01:31:06<+discordbot4> (Something I was telling Vultraz the other day when he insisted on trying to emulate Frogatto's obviously highly successful development model /s) 20180325 01:31:07<+discordbot4> They are 20180325 01:31:41<+discordbot4> Well, if they are I guess I'm going to have to file a PR for them soon. 20180325 01:31:51<+discordbot4> in fact, they're aiming for a showcase at Pax West to promote it. 20180325 01:31:56<+discordbot4> Also, we do not allow nicknames on this server. 20180325 01:32:06<+discordbot4> (the game, not the release on steam itself) 20180325 01:32:07<+discordbot4> Only mods can set nicknames and that's only for special cases. 20180325 02:01:11<+discordbot4> I'm not asking about big effort, but does this stack remind of anything to anybody? https://gist.github.com/singalen/f8be614501cdb4dbde6e535021a8e22b (stack memory usage after return) game_controller::load_game_cfg(bool) -> game_config::config_cache::load_configs() -> ... -> game_config::config_cache::write_file() -> ... -> write_key_val_visitor::operator() Looks like a reference to a local variable slipped into some object 20180325 02:01:11<+discordbot4> like config, but my debugging is very limited, as it only appears on -O3. 20180325 02:04:40<+discordbot4> It's been too long since 1.10 for anyone to be familiar with the codebase 20180325 02:07:16< gfgtdf> why are you dealing with 1.10 in the first place ? 20180325 02:13:13<+discordbot4> he's trying to rebuild the 1.10 port for the iPhone for iOS 100 20180325 02:13:16<+discordbot4> er 20180325 02:13:16<+discordbot4> 11 20180325 02:13:17<+discordbot4> xD 20180325 02:13:27<+discordbot4> 😂 20180325 02:21:16-!- travis-ci [~travis-ci@ec2-54-204-75-6.compute-1.amazonaws.com] has joined #wesnoth-dev 20180325 02:21:17< travis-ci> gfgtdf/wesnoth#1052 (fix_1856 - ba9d07d : gfgtdf): The build has errored. 20180325 02:21:17< travis-ci> Build details : https://travis-ci.org/gfgtdf/wesnoth/builds/357944169 20180325 02:21:17-!- travis-ci [~travis-ci@ec2-54-204-75-6.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180325 02:37:58-!- gfgtdf [~chatzilla@x4e363818.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.93 [Firefox 52.7.2/20180315163333]] 20180325 02:44:49< irker073> wesnoth/wesnoth:1.14 Charles Dang 58ef84216f Mentioned EI fixes in changelog AppVeyor: All builds passed 20180325 02:56:34-!- travis-ci [~travis-ci@ec2-54-242-4-177.compute-1.amazonaws.com] has joined #wesnoth-dev 20180325 02:56:35< travis-ci> gfgtdf/wesnoth#1053 (fix_1856 - c38f05c : gfgtdf): The build has errored. 20180325 02:56:35< travis-ci> Build details : https://travis-ci.org/gfgtdf/wesnoth/builds/357951157 20180325 02:56:35-!- travis-ci [~travis-ci@ec2-54-242-4-177.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180325 03:00:24-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20180325 03:12:16<+discordbot4> doesn't look like frogatto's doing so well towards making their pax milestone. 27/29 issues are open, some of which date back to 2015. 20180325 03:14:56<+discordbot4> https://github.com/frogatto/frogatto/milestone/5 20180325 03:20:44<+discordbot4> @shadowm How is the "WML Tags" sidebar populated on the wiki? Is it manual, or is it done automatically somehow? 20180325 03:20:53<+discordbot4> Manual. 20180325 03:21:12<+discordbot4> There's an Edit link on it that leads you to the Edit mode link for its template. 20180325 03:21:40<+discordbot4> okay, thanks 20180325 03:21:48<+discordbot4> someone added a link to something that's not a tag 20180325 03:22:59<+discordbot4> Really? 20180325 03:23:26<+discordbot4> yeah 20180325 03:23:27<+discordbot4> array 20180325 03:23:38<+discordbot4> links to https://wiki.wesnoth.org/SyntaxWML#Array 20180325 03:26:38<+discordbot4> Yeah, just remove it. 20180325 03:30:19<+discordbot4> yep, that's what I did. 20180325 03:38:42< irker073> wesnoth/wesnoth:master Celtic Minstrel 1dd411a84e Support to_location in [move_unit] AppVeyor: vs2017/Release Failed 20180325 03:38:43< irker073> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-master-1889 20180325 03:53:47-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180325 03:53:57-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180325 04:02:01-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180325 04:02:07-!- janebot_ [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180325 04:02:07-!- janebot_ is now known as janebot 20180325 04:13:09-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180325 04:13:15-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180325 04:18:43< irker073> wesnoth/wesnoth:master Celtic Minstrel bbbbd6d90a Deprecate helper.wml_error and move it t AppVeyor: 2/4 builds failed 20180325 04:18:44< irker073> Details vs2017/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-master-1884 20180325 04:18:45< irker073> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-2178 20180325 04:45:18< celticminstrel> I was going to add something to some tag IIRC, but I forget what it was... 20180325 04:45:24< celticminstrel> Oh well. I'm sure I'll remember later. 20180325 04:48:51-!- Bonobo [~Bonobo@203.220.138.198] has quit [Ping timeout: 256 seconds] 20180325 04:49:24-!- Bonobo [~Bonobo@203.220.138.198] has joined #wesnoth-dev 20180325 04:59:56< celticminstrel> BTW, which version of OSX introduced built-in system notifications? 20180325 05:00:26< celticminstrel> If they were introduced in 10.8 @hrubymar10 then you can drop Growl from the OSX dependencies. 20180325 05:08:33<+discordbot4> 10.8 AFAIK 20180325 05:09:26< celticminstrel> IMO the only reason to support Growl is because of 10.7. If we're dropping 10.7 it makes sense to also drop Growl. 20180325 05:09:49<+discordbot4> sure 20180325 05:10:00< celticminstrel> Mind you, it's possible that Growl still works in 10.8 alongside Cocoa notifications, and there's a slight chance someone would still be using it, but... 20180325 05:10:15<+discordbot4> meh 20180325 05:13:46< celticminstrel> BTW, do you need to do something special to support switching difficulties mid-scenario? I tried it once today in my campaign and it didn't seem to work. 20180325 05:14:15< celticminstrel> (I switched from medium to easy IIRC, so there should've been only three bats, but there were still five.) 20180325 05:14:30<+discordbot4> since when was that a thing? 20180325 05:14:35< celticminstrel> Huh? 20180325 05:14:48< celticminstrel> Mid-campaign, sorry. Not mid-scenario.. 20180325 05:14:52<+discordbot4> oh 20180325 05:14:56< celticminstrel> I was loading a start-of-scenario save. 20180325 05:15:17<+discordbot4> i dunno, has anyone tested that in the past few years? 20180325 05:15:38< celticminstrel> I would assume so? 20180325 05:16:40< celticminstrel> ...I did add changelogs for my new WML features today, right? 20180325 05:17:05<+discordbot4> IIRC? 20180325 05:17:23< celticminstrel> I don't suppose you have any idea what the other one was that I wanted to add. 20180325 05:17:28< celticminstrel> (I doubt it but it can't hurt to ask.) 20180325 05:17:51<+discordbot4> i dunno, you were talking about formula= 20180325 05:18:02< celticminstrel> I did that one IIRC 20180325 05:18:10< celticminstrel> And [move_unit]to_location 20180325 05:18:46<+discordbot4> that one doesn't ave ena entru 20180325 05:19:23< celticminstrel> Did I push it? 20180325 05:21:09<+discordbot4> I don't think you even pushed the other ting 20180325 05:21:14<+discordbot4> I don't see it 20180325 05:22:05<+discordbot4> I guess I found my UB. Looks exactly like this with t_string conversion to string. https://stackoverflow.com/questions/48749296/stdbind-and-stack-use-after-scope/48763980#48763980 20180325 05:22:14< celticminstrel> Uhh, to_location is the latest commit. 20180325 05:22:27< celticminstrel> And it has a changelog entry, good. 20180325 05:23:53<+discordbot4> I hope Rust takes over some day :trollface: 20180325 05:26:06< celticminstrel> ...okay, so do I go to bed, or do I do more Wesnoth stuff... decisions... >_> 20180325 05:28:44<+discordbot4> You seize the means of production. 20180325 05:39:02< irker073> wesnoth/wesnoth:master doofus-01 5803f0e1a9 champion defense animation AppVeyor: vs2015/Release Failed 20180325 05:39:04< irker073> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-2184 20180325 06:02:38< irker073> wesnoth: Charles Dang wesnoth:master 0e9eac9ad800 / src/ (mouse_events.cpp mouse_events.hpp): Mouse Events: removed an override that only called the base method https://github.com/wesnoth/wesnoth/commit/0e9eac9ad800f95a55a676d4e91e503120ff49c7 20180325 06:02:41< irker073> wesnoth: Charles Dang wesnoth:master 5ddc1d9a2e7c / changelog.md data/lua/wml/move_unit.lua: Merge branch 'master' of github.com:wesnoth/wesnoth https://github.com/wesnoth/wesnoth/commit/5ddc1d9a2e7ccd7d7846970554e2499ed410b103 20180325 06:24:57< irker073> wesnoth/wesnoth:1.14 Charles Dang 44d9554361 Updated DejaVu Sans font files to versio AppVeyor: All builds passed 20180325 06:27:48-!- vn971 [~vasya@94.158.103.15] has joined #wesnoth-dev 20180325 06:47:43< irker073> wesnoth: Jyrki Vesterinen wesnoth:1.14 c76967f443f7 / src/units/abilities.cpp: Simplify move assignment operator of attack_type::specials_context_t https://github.com/wesnoth/wesnoth/commit/c76967f443f75155749c939444aff3e5ab7f1f53 20180325 06:52:57-!- travis-ci [~travis-ci@ec2-50-17-73-160.compute-1.amazonaws.com] has joined #wesnoth-dev 20180325 06:52:58< travis-ci> wesnoth/wesnoth#17190 (master - 5ddc1d9 : Charles Dang): The build has errored. 20180325 06:52:58< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/357977600 20180325 06:52:58-!- travis-ci [~travis-ci@ec2-50-17-73-160.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180325 07:13:00< celticminstrel> Hmm, I suppose you could say this was my first actual contribution... >_> https://github.com/wesnoth/wesnoth/commit/281fc2a33151e6f4c08188d35f1ca75f41d6f394 20180325 07:21:22<+discordbot4> But that’s e_h 20180325 07:22:28< celticminstrel> https://forums.wesnoth.org/viewtopic.php?p=535219#p535219 20180325 07:22:43< celticminstrel> Not sure if he took my version or redid it, though. 20180325 07:25:23< irker073> wesnoth: Iris Morelle wesnoth:1.14 7bcf8e71a702 / src/gui/widgets/unit_preview_pane.cpp: gui2/unit_attack: Fix alignments being displayed in English https://github.com/wesnoth/wesnoth/commit/7bcf8e71a7024f557d19c170e4e956668d94ad47 20180325 07:25:26< irker073> wesnoth: Iris Morelle wesnoth:master 7056ae014ced / src/gui/widgets/unit_preview_pane.cpp: gui2/unit_attack: Fix alignments being displayed in English https://github.com/wesnoth/wesnoth/commit/7056ae014ced381cec3e1fdd86a268749bb83562 20180325 07:41:34< irker073> wesnoth: Iris Morelle wesnoth:1.14 950222f0d949 / src/gui/widgets/unit_preview_pane.cpp: gui2/unit_attack: Fix damage types and ranges being displayed in English https://github.com/wesnoth/wesnoth/commit/950222f0d9490ed9bed2314fdebbc9ebce5aa72e 20180325 07:41:37< irker073> wesnoth: Iris Morelle wesnoth:master 84ce75af1915 / src/gui/widgets/unit_preview_pane.cpp: gui2/unit_attack: Fix damage types and ranges being displayed in English https://github.com/wesnoth/wesnoth/commit/84ce75af191590823033f3186213f1b39375934c 20180325 07:43:53< celticminstrel> ... 20180325 07:43:55< celticminstrel> So uh. 20180325 07:44:05< celticminstrel> Apparently location_id does not work in [unit_overlay]? 20180325 07:44:49< celticminstrel> Unless I made a typo, let me check that. 20180325 07:44:57< celticminstrel> Because according to the Lua it should work fine. 20180325 07:45:29< celticminstrel> ...oh. It's that other thing biting me yet again. 20180325 07:45:37< celticminstrel> location_id works only in SLF, not in SUF. 20180325 07:47:42<+discordbot4> @Vultraz Re #2732, the translatable string "Level: " exists. 20180325 07:48:37<+discordbot4> One way we could go about this is to recycle that string by displaying "Level: #" below the unit sprites instead of "Level #" above. 20180325 07:49:12<+discordbot4> Alternatively, since we already broke the string freeze for i18n bugs, just go and make "Level " translatable. 20180325 07:49:48<+discordbot4> src/reports.cpp:235: tooltip << _("Level: ") << "" << u->level() << "\n"; 20180325 07:50:21<+discordbot4> (The textdomain in wesnoth, same as src/help/help_topic_generators.cpp.) 20180325 07:53:04<+discordbot4> Other than that I've only got the very last item (the trait tooltips) to deal with. 20180325 07:53:33<+discordbot4> Oh, and Search, which is also part of #2709. 20180325 07:53:53< celticminstrel> I'm confused, why am I testing for *^Vct when a) it doesn't exist on the map and b) this code clearly relates to windmills which are ^Vcm? :| 20180325 07:54:04< celticminstrel> ^Vwm I mean 20180325 07:54:30< celticminstrel> Did the code for windmill villages change at some point? Did I just mistype it and never test and notice it never worked? What's up with this? :S 20180325 08:07:14-!- grzywacz [~karol@89-70-226-147.dynamic.chello.pl] has joined #wesnoth-dev 20180325 08:13:12<+discordbot4> OK, I'll drop Growl: https://developer.apple.com/documentation/foundation/nsusernotification 20180325 08:16:27<+discordbot4> I think I found an UB. This commit shouldn't have been reverted: https://github.com/wesnoth/wesnoth/commit/3d225ca46a7a2884b39af0fc079ba0de7e1e4d90#diff-03bbf51cecdeb21bfc6baf13bceeef09 I think, the +#ifdef _MSC_VER behavior - namely, constructing t_string from string.get() should be used everywhere. Otherwise, there's a chance we'll store a reference to a temporary. I just fixed a crash related to this on clang/iOS in 1.10 branch 20180325 08:16:28<+discordbot4> (don't ask why I'm doing this). My fix is similar: https://gist.github.com/singalen/f8be614501cdb4dbde6e535021a8e22b What do you think? 20180325 08:28:06<+discordbot4> @Vultraz Just drop the Password Reminder function, really. 20180325 08:29:06<+discordbot4> It makes sense for the generic user handler (which isn't even used in production anywhere to my knowledge), but for the forum user handler it's just too much effort. 20180325 08:35:29-!- travis-ci [~travis-ci@ec2-50-17-73-160.compute-1.amazonaws.com] has joined #wesnoth-dev 20180325 08:35:30< travis-ci> wesnoth/wesnoth#17193 (master - 7056ae0 : Iris Morelle): The build has errored. 20180325 08:35:30< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/357987484 20180325 08:35:30-!- travis-ci [~travis-ci@ec2-50-17-73-160.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180325 08:35:42-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20180325 08:36:05< irker073> wesnoth: Iris Morelle wesnoth:master 3c6bb665c6bd / data/core/about_i18n.cfg: Update credits https://github.com/wesnoth/wesnoth/commit/3c6bb665c6bd6686eeee2711534ee52fcd65ce5a 20180325 08:36:09< irker073> wesnoth: Iris Morelle wesnoth:1.14 125c33039a1c / data/core/about_i18n.cfg: Update credits https://github.com/wesnoth/wesnoth/commit/125c33039a1c79063a572e7edd91cb0e33a3a8d4 20180325 08:38:44< irker073> wesnoth/wesnoth:master Celtic Minstrel 1dd411a84e Support to_location in [move_unit] AppVeyor: 2/4 builds failed 20180325 08:38:45< irker073> Details vs2017/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-master-1889 20180325 08:38:46< irker073> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-2183 20180325 08:44:05<+discordbot4> @Vultraz Opinions on what I should do with https://wiki.wesnoth.org/index.php?title=DevelopmentRoadmap&redirect=no ? 20180325 08:44:49<+discordbot4> It's currently a double redirect because I renamed my wiki user the other day, but the thing is nothing links to it in the first place. 20180325 08:45:11<+discordbot4> Also you'd need something completely new for 1.16 anyway. 20180325 08:51:00-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev 20180325 09:14:20-!- celticminstrel is now known as celmin|sleep 20180325 09:32:39-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180325 09:32:45-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180325 09:42:04-!- travis-ci [~travis-ci@ec2-50-17-73-160.compute-1.amazonaws.com] has joined #wesnoth-dev 20180325 09:42:05< travis-ci> wesnoth/wesnoth#17195 (master - 84ce75a : Iris Morelle): The build has errored. 20180325 09:42:05< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/357989639 20180325 09:42:05-!- travis-ci [~travis-ci@ec2-50-17-73-160.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180325 09:53:04< irker073> wesnoth/wesnoth:master Iris Morelle 3c6bb665c6 Update credits AppVeyor: vs2017/Release Failed 20180325 09:53:05< irker073> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-master-1905 20180325 10:17:57-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180325 10:18:03-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180325 10:39:04< irker073> wesnoth/wesnoth:master doofus-01 5803f0e1a9 champion defense animation AppVeyor: 2/4 builds failed 20180325 10:39:05< irker073> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-2184 20180325 10:39:06< irker073> Details vs2017/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-master-1890 20180325 10:42:55< vn971> The new Time-Of-Day icons look really nice! Though it's still much preferable to have Northern/Southern pole separation. 20180325 10:46:38<+discordbot4> rolls eyes 20180325 10:55:24< zookeeper> i still don't get how people even notice that. it's never caught my eye that the sun goes the "wrong way" for me in the ToD images, except when i've actually specifically checked it after hearing others talk about it. 20180325 11:04:38< vn971> that may depend on where you live. If you live on Southern part of the world, naturally you can't notice that at all. If you live near equator, then you still barely see it because the sun is generally "low" at first, then it is "high", then it is "low" again. But if you are somewhat away from equator, the sun starts to go "left-to-right" instead of "up and down". On the pole specifically, sun is never higher than about 20 degrees, 20180325 11:04:39< vn971> almost ONLY moving horizontally. 20180325 11:04:41< vn971> zookeeper: ^ 20180325 11:07:24< zookeeper> of course. and my mental image of how the sun moves is pretty much "horizontal, left to right". 20180325 11:11:57< DeFender1031> zookeeper, you in the southern hemisphere? 20180325 11:12:09< zookeeper> northern 20180325 11:12:35< DeFender1031> wait, I read what you said backward. 20180325 11:13:07< DeFender1031> But anyway, even if it DOES go the wrong way, who says wesnoth is in the nothern hemisphere? 20180325 11:13:22< zookeeper> indeed 20180325 11:14:03< DeFender1031> I mean, there's a desert to the south and cooler mountains to the north, but there's also (IIRC) more desert to the north in some of the extended maps. 20180325 11:14:45< DeFender1031> And global climates are weird and not always a one-to-one of "anything farther from the equator than anything else is cooler" 20180325 11:15:20-!- travis-ci [~travis-ci@ec2-54-198-138-121.compute-1.amazonaws.com] has joined #wesnoth-dev 20180325 11:15:21< travis-ci> wesnoth/wesnoth#17195 (master - 84ce75a : Iris Morelle): The build has errored. 20180325 11:15:21< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/357989639 20180325 11:15:21-!- travis-ci [~travis-ci@ec2-54-198-138-121.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180325 11:15:37< DeFender1031> Heck, it'd be kinda cool to have wesnoth canonically in the southern hemisphere. Too many things are nothern-hemisphere-centric. 20180325 11:16:10< DeFender1031> Just because OUR planet happens to have most of its inhabited landmass in the north. 20180325 11:17:19< vn971> DeFender1031: nobody says wesnoth units are on northern hemisphere, BUT it'd be cool for pictures to match your mental model, I think. 20180325 11:18:09< DeFender1031> vn971, didn't say anyone did. 20180325 11:18:23< vn971> DeFender1031: it's also possible to draw a sun and say "night", draw a moon and say "day", because on another language "day" and "night" might be mixed. But, it won't match user-s expectations, and wouldn't do any good. 20180325 11:19:01< DeFender1031> vn971, not sure what that has to do with anything. Another language could call day "monkeys" and night "apothecary". 20180325 11:19:04< vn971> DeFender1031: I was replying to this: > who says wesnoth is in the nothern hemisphere? 20180325 11:19:30< DeFender1031> yeah, that was my point. There's no reason for wesnoth to have to be in the north. 20180325 11:20:44< vn971> DeFender1031: ok, maybe some creatures don't like sun (for example because of it being too UV-intensive), but have other sources of power usable when sun is out. Then the main/normal time of day to do things would be when sun is out. 20180325 11:20:59< DeFender1031> I mean, the idea of wesnoth being in the southern hemisphere won't sit too well with flat-Irdyaers, but whatever. 20180325 11:21:13< vn971> DeFender1031: you don't have to place wesnoth anywhere at all. My point is that you should match user expectations, not break them needlessly. 20180325 11:21:38< DeFender1031> vn971, what's any of that got to do with this? 20180325 11:22:07< vn971> DeFender1031: can't parse the question. 20180325 11:22:24< vn971> my point is to support "inverting" pictures, that's all. 20180325 11:22:30< DeFender1031> "User expectations" for the sun to go a specific way are only true for northern-hemisphere users. As the canonical images stand, it's just an indication that wesnoth is in the southern hemisphere. 20180325 11:22:43< vn971> Same as old wesnoth did, under "advanced" options sector. 20180325 11:22:49< DeFender1031> That's what I'M saying. What are YOU saying? 20180325 11:23:16< DeFender1031> Huh? What's the same as old wesnoth and under advanced options? 20180325 11:23:27< vn971> DeFender1031: please be aware of the full story behind then. Specifically read my message at xx:21:13 please. 20180325 11:25:04< vn971> DeFender1031: if you're interested, check out wesnoth-1.12 > Preferences > Advanced > 6-th entry from bottom "Reverse time graphics". Then you'll understand what the proposal is, exactly. 20180325 11:25:08< DeFender1031> My timestamps won't be entirely in sync with yours. What message are you rferring to? 20180325 11:25:52< DeFender1031> hmm 20180325 11:26:00< vn971> DeFender1031: > you don't have to place wesnoth anywhere at all. My point is that you should match user expectations, not break them needlessly. 20180325 11:26:33< vn971> so the proposal was never to place wesnoth on Northern hemisphere, but to allow the user inverting this, if (s)he really wants to. 20180325 11:26:52< DeFender1031> Meh. I doubt it's really a big deal. 20180325 11:27:11< DeFender1031> And if wesnoth IS placed somewhere, then it'd figure in. 20180325 11:27:27< DeFender1031> But it's not like a UI expectation is being violated. 20180325 11:28:16-!- octalot [~steve@77.119.128.62.wireless.dyn.drei.com] has quit [] 20180325 11:29:19-!- travis-ci [~travis-ci@ec2-54-198-138-121.compute-1.amazonaws.com] has joined #wesnoth-dev 20180325 11:29:20< travis-ci> gfgtdf/wesnoth#1054 (fix_1856 - aed2505 : gfgtdf): The build passed. 20180325 11:29:20< travis-ci> Build details : https://travis-ci.org/gfgtdf/wesnoth/builds/358020306 20180325 11:29:20-!- travis-ci [~travis-ci@ec2-54-198-138-121.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180325 11:31:13< zookeeper> as i said, my personal befuddlement is mainly about how people regularly notice and find that worth requesting in the first place, as if it somehow messes with their mental model of where the sun/moon is during certain times of day. 20180325 11:33:42< zookeeper> ...because there's no way i can casually be checking what ToD it is, see schedule-dawn.png, and have the fact that the sun is on the right side of the image result in any kind of discord in my mind 20180325 11:57:18-!- Gambit [~derek@wesnoth/developer/grickit] has quit [Quit: No Ping reply in 180 seconds.] 20180325 11:58:54-!- Grickit [~derek@grickit.us] has joined #wesnoth-dev 20180325 11:58:54-!- Grickit [~derek@grickit.us] has quit [Changing host] 20180325 11:58:54-!- Grickit [~derek@wesnoth/developer/grickit] has joined #wesnoth-dev 20180325 12:24:26< wedge009> What brought this up again? I thought vultraz already shut it down as 'too many options'. Personally I didn't think it's a problem to have the option and I have no connection between Wesnoth's celestial object movement direction and my conception of the movement of the sun in real life (I'm in southern hemisphere). 20180325 12:25:09< wedge009> But the decision was made I'm okay with that too. 20180325 12:25:15< wedge009> It's a very minor thing. 20180325 12:29:23-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180325 12:31:51< irker073> wesnoth: newfrenchy83 wesnoth:master f8abea0de496 / projectfiles/CodeBlocks/wesnoth.cbp: Update wesnoth.cbp https://github.com/wesnoth/wesnoth/commit/f8abea0de496cdde1da854151a26b570fea06144 20180325 12:47:11< irker073> wesnoth: gfgtdf wesnoth:1.14 219f977b2736 / src/ (7 files): fix chat during [delay] and animations https://github.com/wesnoth/wesnoth/commit/219f977b2736c35683f98fba2c80b2cc31d16aa5 20180325 12:47:13< irker073> wesnoth: gfgtdf wesnoth:1.14 1e1a6fbe488a / src/playmp_controller.cpp: fix moves sometimes not undone when control is changed. https://github.com/wesnoth/wesnoth/commit/1e1a6fbe488a2000f2399faa4c1383f434351563 20180325 12:47:15< irker073> wesnoth: gfgtdf wesnoth:1.14 5361b7d715cd / src/playmp_controller.cpp: fix playmp_controller reading later network packages https://github.com/wesnoth/wesnoth/commit/5361b7d715cd7d4adbcbcdbabc5a7fc3e9f10056 20180325 12:48:03< irker073> wesnoth/wesnoth:1.14 gfgtdf c1296e89d3 fix playmp_controller reading later netw AppVeyor: All builds passed 20180325 12:48:25< irker073> wesnoth: Martin Hrubý wesnoth:master 39d1476ade2a / / (4 files in 4 dirs): Drop OS X 10.7 and Growl support (#2749) https://github.com/wesnoth/wesnoth/commit/39d1476ade2a438c783ee0570a51db12da30b33e 20180325 12:57:11< irker073> wesnoth: Martin Hrubý wesnoth:1.14 f6c795ffc07b / / (4 files in 4 dirs): Drop OS X 10.7 and Growl support (#2749) https://github.com/wesnoth/wesnoth/commit/f6c795ffc07ba788504524aad684efd68b7b0a46 20180325 13:00:27-!- Bonobo [~Bonobo@203.220.138.198] has quit [Ping timeout: 240 seconds] 20180325 13:01:43-!- Bonobo [~Bonobo@203.220.138.198] has joined #wesnoth-dev 20180325 13:06:06-!- travis-ci [~travis-ci@ec2-50-17-73-160.compute-1.amazonaws.com] has joined #wesnoth-dev 20180325 13:06:07< travis-ci> gfgtdf/wesnoth#1056 (fix_1856 - 3e634fd : gfgtdf): The build has errored. 20180325 13:06:07< travis-ci> Build details : https://travis-ci.org/gfgtdf/wesnoth/builds/358042330 20180325 13:06:07-!- travis-ci [~travis-ci@ec2-50-17-73-160.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180325 13:24:41-!- octalot [~steve@77.119.128.62.wireless.dyn.drei.com] has joined #wesnoth-dev 20180325 13:41:59< irker073> wesnoth: Hironori Fujimoto wesnoth:1.14 7ac369714251 / src/gui/widgets/text_box_base.cpp: Turn ime_in_progress_ off when composition text is nothing https://github.com/wesnoth/wesnoth/commit/7ac3697142512e1654ab2428ca18a835ec288e62 20180325 13:42:01< irker073> wesnoth: Hironori Fujimoto wesnoth:1.14 264fe1d4d388 / src/gui/widgets/ (text_box_base.cpp text_box_base.hpp): Remove private member 'ime_length_' https://github.com/wesnoth/wesnoth/commit/264fe1d4d3880f9f518553005066653971acd863 20180325 13:42:03< irker073> wesnoth: Hironori Fujimoto wesnoth:1.14 8522e25ffb58 / src/gui/widgets/text_box_base.cpp: Use is_composing() instead of raw ime_in_progress_ https://github.com/wesnoth/wesnoth/commit/8522e25ffb581155e79a1cb273187bcce9e3931b 20180325 13:42:05< irker073> wesnoth: Hironori Fujimoto wesnoth:1.14 8cd0585ba50c / src/gui/widgets/ (text_box_base.cpp text_box_base.hpp): Rename variable so that it's role becomes clearly https://github.com/wesnoth/wesnoth/commit/8cd0585ba50cc6406aaf4d8b94f082188dc191e5 20180325 13:42:07< irker073> wesnoth: Jyrki Vesterinen wesnoth:1.14 e6b411d21a60 / src/gui/widgets/ (text_box_base.cpp text_box_base.hpp): Merge branch 'fix_2694' into 1.14 https://github.com/wesnoth/wesnoth/commit/e6b411d21a60af300931736bf16221a30da9066b 20180325 13:47:33< irker073> wesnoth/wesnoth:master newfrenchy83 fc8dd3518f Update attack_predictions.cpp AppVeyor: vs2017/Release Failed 20180325 13:47:34< irker073> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-master-1912 20180325 13:49:44< irker073> wesnoth: Hironori Fujimoto wesnoth:master 16a8ac7e4956 / src/gui/widgets/text_box_base.cpp: Turn ime_in_progress_ off when composition text is nothing https://github.com/wesnoth/wesnoth/commit/16a8ac7e4956bdf236b518e42913af1ae7360cbf 20180325 13:49:46< irker073> wesnoth: Hironori Fujimoto wesnoth:master 5e22b2b714d5 / src/gui/widgets/ (text_box_base.cpp text_box_base.hpp): Remove private member 'ime_length_' https://github.com/wesnoth/wesnoth/commit/5e22b2b714d58b7f6041c323b0e4c9c7e02bc0b1 20180325 13:49:48< irker073> wesnoth: Hironori Fujimoto wesnoth:master 6212a62a985b / src/gui/widgets/text_box_base.cpp: Use is_composing() instead of raw ime_in_progress_ https://github.com/wesnoth/wesnoth/commit/6212a62a985b60110a7350ed28bfb0601cc1d0b8 20180325 13:49:50< irker073> wesnoth: Hironori Fujimoto wesnoth:master 6b98bbdca125 / src/gui/widgets/ (text_box_base.cpp text_box_base.hpp): Rename variable so that it's role becomes clearly https://github.com/wesnoth/wesnoth/commit/6b98bbdca125a748bc4eafb5f54394d0f14a7177 20180325 14:04:44-!- travis-ci [~travis-ci@ec2-50-17-73-160.compute-1.amazonaws.com] has joined #wesnoth-dev 20180325 14:04:45< travis-ci> wesnoth/wesnoth#17211 (master - 39d1476 : Martin Hrubý): The build has errored. 20180325 14:04:45< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/358043304 20180325 14:04:45-!- travis-ci [~travis-ci@ec2-50-17-73-160.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180325 14:46:25< celmin|sleep> [Mar 25@07:19:30am] DeFender1031: yeah, that was my point. There's no reason for wesnoth to have to be in the north. 20180325 14:46:26< celmin|sleep> Well, the name "Wesnoth" does imply it though. 20180325 14:46:57< DeFender1031> No it doesn't... People came from the west and the north and created it. 20180325 14:47:39-!- celmin|sleep is now known as celticminstrel 20180325 14:48:11< DeFender1031> Pretty sure that's said so canonicly. 20180325 14:49:34<+discordbot4> Please someone forward-port gfgtf’s last commit set to master 20180325 14:51:54<+discordbot4> @shadowm the roadmap might be useful reference. Can it stay out for the moment? 20180325 14:53:04< irker073> wesnoth/wesnoth:master Iris Morelle 3c6bb665c6 Update credits AppVeyor: 2/4 builds failed 20180325 14:53:05< irker073> Details vs2017/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-master-1905 20180325 14:53:06< irker073> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-2199 20180325 14:56:13-!- travis-ci [~travis-ci@ec2-50-17-73-160.compute-1.amazonaws.com] has joined #wesnoth-dev 20180325 14:56:14< travis-ci> wesnoth/wesnoth#17213 (1.14 - e6b411d : Jyrki Vesterinen): The build passed. 20180325 14:56:14< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/358054456 20180325 14:56:14-!- travis-ci [~travis-ci@ec2-50-17-73-160.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180325 14:56:18-!- Bhoren [~Bhoren_wh@2a01:e0a:c:2150:8400:e233:8281:c025] has joined #wesnoth-dev 20180325 14:56:31<+discordbot4> ah, nevermind, I'll do the forward-port 20180325 15:02:14<+discordbot4> @Vultraz Ar you getting warnings on VS 2017 toolset compiling for Release? 20180325 15:02:37<+discordbot4> been getting warnings since jyrki's changes. but they're in boost. 20180325 15:03:40<+discordbot4> So we need to suppress some warnings in the project file. If nobody does it by the time my systems calm down I'll take a loot at them. 20180325 15:04:41<+discordbot4> i think it's only 2 20180325 15:04:46<+discordbot4> The best way would be to suppress warnings for extrenal headers after upgrading to VS2017. 20180325 15:04:47<+discordbot4> https://blogs.msdn.microsoft.com/vcblog/2017/12/13/broken-warnings-theory/ 20180325 15:05:03<+discordbot4> C4706 20180325 15:05:23<+discordbot4> Warning C4706 assignment within conditional expression wesnoth c:\users\\documents\external\include\boost\iostreams\filter\bzip2.hpp 319 Warning C4706 assignment within conditional expression wesnoth c:\users\\documents\external\include\boost\iostreams\filter\zlib.hpp 384 20180325 15:07:29<+discordbot4> Yes but that just goes to an action item: audit error/warning suppression on all targets. Windows 10 / Visual Studio is probably the worst for that but it looks like macOS wants some love, too. And I know Linux does. 20180325 15:07:39-!- Bonobo [~Bonobo@203.220.138.198] has quit [Ping timeout: 256 seconds] 20180325 15:07:57< irker073> wesnoth: gfgtdf wesnoth:master 274da80788b3 / src/ (7 files): fix chat during [delay] and animations https://github.com/wesnoth/wesnoth/commit/274da80788b3ec1c2517a9ed305d796d688382d3 20180325 15:07:59< irker073> wesnoth: gfgtdf wesnoth:master 94aa24c5a800 / src/playmp_controller.cpp: fix moves sometimes not undone when control is changed. https://github.com/wesnoth/wesnoth/commit/94aa24c5a80076feb16018e1e7939622934a3a29 20180325 15:08:01< irker073> wesnoth: gfgtdf wesnoth:master f219b527e4b5 / src/playmp_controller.cpp: fix playmp_controller reading later network packages https://github.com/wesnoth/wesnoth/commit/f219b527e4b5b83dade346a2091e45380c0961ef 20180325 15:16:31< irker073> wesnoth: Charles Dang wesnoth:master ebec4d6ce8fd / / (3 files in 3 dirs): MP Login: removed Password Reminder functionality https://github.com/wesnoth/wesnoth/commit/ebec4d6ce8fd8e46ce1d8a4bb4f5d04fddd87c72 20180325 15:17:03< irker073> wesnoth: Charles Dang wesnoth:1.14 81cca86f9085 / / (3 files in 3 dirs): MP Login: removed Password Reminder functionality https://github.com/wesnoth/wesnoth/commit/81cca86f90850b78abaf088b4f294d5c4ef8344f 20180325 15:39:58< celticminstrel> I am merging 2718. 20180325 15:40:09< celticminstrel> It will take some time since I want to test it first. 20180325 15:40:17< celticminstrel> I've already fixed the whitespace issues. 20180325 15:40:50< celticminstrel> I'm testing it on 1.14 though. 20180325 15:40:57< celticminstrel> But I'll push it to master. 20180325 15:48:17-!- octalot [~steve@77.119.128.62.wireless.dyn.drei.com] has quit [Ping timeout: 248 seconds] 20180325 16:09:35-!- travis-ci [~travis-ci@ec2-54-211-39-126.compute-1.amazonaws.com] has joined #wesnoth-dev 20180325 16:09:36< travis-ci> wesnoth/wesnoth#17215 (master - f219b52 : gfgtdf): The build has errored. 20180325 16:09:36< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/358074323 20180325 16:09:36-!- travis-ci [~travis-ci@ec2-54-211-39-126.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180325 16:17:35< irker073> wesnoth/wesnoth:master Charles Dang ebec4d6ce8 MP Login: removed Password Reminder func AppVeyor: vs2017/Release Failed 20180325 16:17:36< irker073> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-master-1927 20180325 16:21:33-!- octalot [~steve@77.119.128.187.wireless.dyn.drei.com] has joined #wesnoth-dev 20180325 16:39:13<+discordbot4> @Vultraz Again, why isn't gfgtdf forward-porting his own commits? 20180325 16:39:32<+discordbot4> And also, the wiki thing is not the only thing I tagged you for. 20180325 16:39:40<+discordbot4> Shouldn't you ask gfgtdf directly and not Vultraz? 20180325 16:41:51<+discordbot4> I'm asking him since by asking others to forward port the commits he's essentially asking others to do gfgtdf's work, and I'm assuming there has to be a good reason for that. 20180325 16:42:12<+discordbot4> @shadowm I'm thinking about the Help string issue. I'm not sure what you mean by "under the image" vs "over the image". Do you mean sidebar vs help page? 20180325 16:42:13-!- TadCarlucci [~lundberg@74.193.219.119] has quit [Read error: Connection reset by peer] 20180325 16:42:38<+discordbot4> It's the help browser, there's no sidebar. 20180325 16:42:52<+discordbot4> @shadowm I asked someone else to do it since I was on my tablet. But then I got back to my laptop and did it myself instead of waiting for someone else. 20180325 16:42:55<+discordbot4> I need you to go look at the screen shot in the bug report. 20180325 16:43:17<+discordbot4> Either way he should be doing it himself unless he got hit by a bus. 20180325 16:44:06<+discordbot4> Ok, I'm looking at the screenshot. 20180325 16:46:58<+discordbot4> "Level" currently goes above the sprites and right below the unit name. 20180325 16:47:22<+discordbot4> yes. I believe that was a deliberate choice on my part 20180325 16:47:27<+discordbot4> My point is the only way to not introduce a new string is to recycle the version with the colon from the sidebar. 20180325 16:47:35<+discordbot4> Using it at the top might look weird. 20180325 16:48:00<+discordbot4> ahhhhhhhhhhhhhh 20180325 16:48:01<+discordbot4> And also I'm not even sure why it's currently there from a design perspective. 20180325 16:48:02<+discordbot4> I see what you mean 20180325 16:48:23<+discordbot4> IIRC I put it there so it would be immediately obvious 20180325 16:49:21< irker073> wesnoth: Charles Dang wesnoth:1.14 b81c53cde80c / changelog.md: Updated changelog https://github.com/wesnoth/wesnoth/commit/b81c53cde80c497785f02051d86b9a78bd534988 20180325 16:49:56<+discordbot4> yeah, I guess it could go underneath and use the : 20180325 16:50:32<+discordbot4> The alternative is to just make the current string translatable. 20180325 16:50:59<+discordbot4> It's not the first string break for this release anyway. Which brings me to the next point. 20180325 16:51:34<+discordbot4> We need to stop breaking the string freeze at some point so people have a reasonable amount of time to translate the few new strings for RC 2. 20180325 16:51:55<+discordbot4> (And run the pot update afterwards.) 20180325 16:53:12<+discordbot4> I'm trying to get this bug out of the way before Monday 23:00 UTC. It'd be great if you could do the same with the Search box part of mine (also mentioned in this bug). 20180325 16:53:48<+discordbot4> You grok GUI2 better than me right now so you can decide best how to inject the required string into the canvas code. 20180325 16:54:23<+discordbot4> Might be worth just using your hack for now 20180325 16:54:40<+discordbot4> I'm not a fan of my suggestion to use the WML string concatenation approach because it will break the widget horribly if a translator needs to insert an apostrophe in it. 20180325 16:54:51<+discordbot4> hmmmmmmmmmmmmmmmmmmmmm 20180325 16:54:57<+discordbot4> ponder ponder 20180325 16:55:04<+discordbot4> It'll probably cause a formula parser error at runtime. 20180325 16:55:19<+discordbot4> And CTD. 20180325 16:55:28<+discordbot4> well, I could ask celmin to add a WFL function to handle translatable strings 20180325 16:56:27< celticminstrel> I'm confused, what are we talking about exactly? 20180325 16:56:48< celticminstrel> Adding a WFL function is not an option in 1.14, just FTR. 20180325 16:57:22<+discordbot4> That'll not do much good by itself without either hacking the string somewhere in WML that won't be validated, in a no-op gettext macro in C++, or teaching wmlxgettext new tricks. 20180325 16:57:43< celticminstrel> You need to concatenate two strings or something? 20180325 16:57:57<+discordbot4> no 20180325 16:58:02<+discordbot4> I need to translate "Search" in this 20180325 16:58:04<+discordbot4> text = "(if(text = '', 'Search', ''))" 20180325 16:58:20<+discordbot4> We need a translatable string in the canvas formula that defines the text for the search box widget. 20180325 16:58:32< celticminstrel> Oh. 20180325 16:58:41< irker073> wesnoth/wesnoth:1.14 Iris Morelle 125c33039a Update credits AppVeyor: All builds passed 20180325 16:59:02<+discordbot4> I suggested making the widget's C++ inject a formula variable too. 20180325 16:59:22-!- travis-ci [~travis-ci@ec2-54-198-138-121.compute-1.amazonaws.com] has joined #wesnoth-dev 20180325 16:59:23< travis-ci> wesnoth/wesnoth#17216 (master - ebec4d6 : Charles Dang): The build has errored. 20180325 16:59:23< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/358076918 20180325 16:59:23-!- travis-ci [~travis-ci@ec2-54-198-138-121.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180325 16:59:57<+discordbot4> Not sure if that'll cause the widget definition to get stuck with the localization that was used when Wesnoth was launched and not change when switching languages, though. 20180325 17:00:09< celticminstrel> Why not just add a new key to [text_box]? 20180325 17:00:12< celticminstrel> eg, hint= 20180325 17:00:27< celticminstrel> It could then be used for other things besides just a search box. 20180325 17:00:42< celticminstrel> The widget can inject it as a formula variable. 20180325 17:00:43<+discordbot4> I suppose that could work... 20180325 17:00:59< celticminstrel> I suppose that's technically an API change, so you could hardcode it as "Search" in 1.14 and add the new key only in master. 20180325 17:01:24<+discordbot4> It's part of an obscure API though. 20180325 17:01:28<+discordbot4> backend changes don't matter 20180325 17:01:46< celticminstrel> I dunno if API changes in GUI2 are important though. 20180325 17:02:05<+discordbot4> though you forget the search box also includes an image 20180325 17:02:05-!- APic [apic@apic.name] has quit [Ping timeout: 240 seconds] 20180325 17:02:29< celticminstrel> Yes it's user-visible, but I think it's "known" to be immature and subject to change? Plus I don't think it would cause OOS in any case? 20180325 17:02:42< celticminstrel> I have no idea what the image has to do with this. 20180325 17:02:58<+discordbot4> You can mention it in the changelog in case someone who really wants to take advantage of it can use the Lua wesnoth version check function for compatibility with RC 1. 20180325 17:03:09<+discordbot4> what are you talking about oos... 20180325 17:03:27<+discordbot4> It wouldn't cause OOS no. 20180325 17:03:34< celticminstrel> OOS is the main reason not to add things in the stable branch, right? 20180325 17:03:51<+discordbot4> In fact it'd just be ignored by RC 1. 20180325 17:03:53< celticminstrel> Or certainly a major reason. 20180325 17:03:55<+discordbot4> Also yes. 20180325 17:04:07<+discordbot4> we're not talking about the [message] textbox, celmin... 20180325 17:04:25< celticminstrel> I'm not sure why you'd think I thought we were. 20180325 17:04:46<+discordbot4> because how can a GUI2 dialog's key possibly cause OOS 20180325 17:05:33< celticminstrel> That's what I was saying. It shouldn't. 20180325 17:07:19<+discordbot4> ah 20180325 17:07:20<+discordbot4> ok 20180325 17:07:29<+discordbot4> I thought you were saying they would 20180325 17:07:35<+discordbot4> sorry 20180325 17:07:50< celticminstrel> I was saying I don't think it would because that's an important consideration when deciding whether to add it even in 1.14. 20180325 17:16:47-!- APic [apic@apic.name] has joined #wesnoth-dev 20180325 17:22:14-!- gfgtdf [~chatzilla@x4e363818.dyn.telefonica.de] has joined #wesnoth-dev 20180325 17:24:13<+discordbot4> Commit ebec4d6ce8fd8e46ce1d8a4bb4f5d04fddd87c72 is full of whitespace noise huh. 20180325 17:24:23<+discordbot4> You could even call it... 20180325 17:24:29<+discordbot4> white noise 20180325 17:25:11<+discordbot4> (Tip: git show --ignore-space-change -p ebec4d6ce8fd8e46ce1d8a4bb4f5d04fddd87c72 ignores said noise.) 20180325 17:25:49<+discordbot4> @Vultraz It'd be nice in the future if you could have your editor not do that when you're clearly not reindenting code. 20180325 17:26:25<+discordbot4> The GitHub web page UI you love so much doesn't have an equivalent for the --ignore-space-change option. 20180325 17:26:44<+discordbot4> So I just panicked when I saw the huge blotches of red and green around the auth code. 20180325 17:27:20<+discordbot4> The person who coded this must've expected phpBB to have such a thing as a password reminder option, btw. 20180325 17:27:22<+discordbot4> I deliberately reindented it 20180325 17:27:34<+discordbot4> Since I removed an enclosing block 20180325 17:27:47<+discordbot4> Since the condition would always be true 20180325 17:28:00<+discordbot4> Ohhhh okay, I didn't see the if(is_pw_request) { line, my bad. 20180325 17:28:19<+discordbot4> In reality, it doesn't have the functionality he wanted (because phpBB 3.0.x and later do not know passwords, only hashes). 20180325 17:28:31<+discordbot4> The closest thing is the password reset function. 20180325 17:29:00<+discordbot4> Either way you're forced to use the forums to set a new password. 20180325 17:29:24<+discordbot4> You get a one-time key via email to enable you to set a new password and that's it. 20180325 17:29:41<+discordbot4> By the way, GitHub does have a way to ignore whiespace changes. Add ?w=1 to the URL. 20180325 17:29:47<+discordbot4> And you need to know both your username and email address to be able to use that functionality. 20180325 17:29:51<+discordbot4> https://github.com/wesnoth/wesnoth/commit/ebec4d6ce8fd8e46ce1d8a4bb4f5d04fddd87c72?w=1 20180325 17:30:03<+discordbot4> From the server code it looks like our own server is supposed to send the email ? 20180325 17:30:22<+discordbot4> That would be a physical impossibility right now. 20180325 17:30:56<+discordbot4> The only link between the wesnothd and web VMs is two shared mounts, and the fact that both are whitelisted to access the database server. 20180325 17:31:46<+discordbot4> wesnothd wouldn't be able to run phpBB without them sharing the same VM or implementing a backdoor to the web VM. 20180325 17:32:08<+discordbot4> Nobody has time for that. 20180325 17:43:06-!- Bhoren [~Bhoren_wh@2a01:e0a:c:2150:8400:e233:8281:c025] has quit [Quit: Leaving] 20180325 17:45:00< gfgtdf> any objection to disabling the wml test in the msvcd projectfile in master? (to get an appveyor build) 20180325 17:45:26<+discordbot4> I object. Unit tests shouldn't be disabled. 20180325 17:46:00< gfgtdf> but they fail and the travis ci does already the same tests 20180325 17:46:06<+discordbot4> Why are they failing? 20180325 17:46:21<+discordbot4> Also, since you're there now gfgtdf, why is it you're requiring others' help with forward-porting patches? 20180325 17:46:45<+discordbot4> @shadowm Judging from Travis CI logs, they most likely broke in https://github.com/wesnoth/wesnoth/commit/1dd411a84eb6a45c81d14359aaaec7af34351a39 20180325 17:47:03< gfgtdf> i am not requiring. I don't know why they fail. 20180325 17:47:21<+discordbot4> Vultraz was asking around for people to do it for you. 20180325 17:47:44<+discordbot4> So assumedly you have a problem with getting them delivered in time. 20180325 17:50:11<+discordbot4> And by ¨in time", I mean either immediately, or after testing. 20180325 17:50:34<+discordbot4> I explained yesterday that there's a bus factor issue when people wait for testing before backporting/forward porting patches. 20180325 17:51:02<+discordbot4> And that ideally people should use PRs or issues to make sure patches aren't forgotten like they kept being last time with 1.12 vs. master. 20180325 17:54:05< shadowm> gfgtdf: Can I have your confirmation that you read this? 20180325 17:54:29< gfgtdf> well sure. 20180325 17:54:57< gfgtdf> but i'd still rather risk the bus factor then doing it asap. 20180325 17:55:26< shadowm> And I just explained that that is a perfectly valid approach IF you make sure nobody can possibly forget to port the patches if you instantly get hit by a bus after pushing. 20180325 17:55:56< shadowm> We haven't had people get literally hit by a bus before but they have done similar stuff before. 20180325 17:56:06< shadowm> I'm not just speaking in terms of hypotheticals here. 20180325 17:56:26<+discordbot4> What do you even gain by waiting? At best,cherry-picking a commit to master requires only few Git commands. 20180325 17:57:10< shadowm> Also, incidentally, if a commit goes to 1.14 first then it is most certainly in shape for an immediate push to master. 20180325 17:57:20< shadowm> Unless you lost track of what 1.14 is supposed to be. 20180325 18:47:34< irker073> wesnoth/wesnoth:master newfrenchy83 fc8dd3518f Update attack_predictions.cpp AppVeyor: 2/4 builds failed 20180325 18:47:35< irker073> Details vs2017/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-master-1912 20180325 18:47:36< irker073> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-2206 20180325 18:49:33-!- Nobun [~user@51.179.98.217] has joined #wesnoth-dev 20180325 18:49:50< Nobun> a brief question about SConstruct used on wesnoth development 20180325 18:51:10< Nobun> AddOption and GetOption are something related to python or to scons? Becouse in python3 I would use argparse to parse command line... 20180325 18:51:40<+discordbot4> They are SCons functions. 20180325 18:51:55< Nobun> thank for reply 20180325 18:57:43-!- Nobun [~user@51.179.98.217] has quit [Ping timeout: 256 seconds] 20180325 18:59:24-!- Nobun [~user@51.179.98.217] has joined #wesnoth-dev 20180325 19:11:53< Nobun> another question: why you use AddOption('--option-cache' AND opts.AddVariables( for actual custom parameters? 20180325 19:12:10< Nobun> I mean, reading scons documentation I could expect to use only AddOption 20180325 19:13:45<+discordbot4> Most likely in order to add dozens of variables in one go (that AddOption() can't do AFAIK). 20180325 19:15:12< Nobun> ok cool. Thank for hint. Probably I could use this tecnique also in my SConstruct I will develop. This is a brilliant idea :) 20180325 19:15:27< Nobun> so you can also add variables on the fly in a more organized way :P 20180325 19:57:41-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180325 19:57:47-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180325 19:59:41< celticminstrel> Getting a crash on 1.14 branch... 20180325 20:00:13< celticminstrel> Full rebuild didn't solve it. Is aquileia/external still appropriate for the stable branch? 20180325 20:00:22< celticminstrel> If so I could try redownloading that. 20180325 20:00:26< gfgtdf> when exactly do you get a crash ? 20180325 20:00:38< celticminstrel> It's in lexical_cast within the animations parser. 20180325 20:00:44<+discordbot4> Yes, aquileia/external still works with the 1.14 branch. 20180325 20:00:46< celticminstrel> Before the window even appears, I think. 20180325 20:02:37<+discordbot4> I can say that I wasn't getting a startup crash at commit https://github.com/wesnoth/wesnoth/commit/e6b411d21a60af300931736bf16221a30da9066b at least. 20180325 20:02:56<+discordbot4> There have only been two commits since them, one being a changelog update. 20180325 20:03:08<+discordbot4> I think the issue is your build, not Wesnoth itself. 20180325 20:03:23< celticminstrel> I was at the same commit, apparently. 20180325 20:03:25< celticminstrel> So yeah. 20180325 20:04:05< Nobun> I could try to build it in my system if you want to have a third comparison 20180325 20:04:15< celticminstrel> Either it's my build or something somehow introduced by PR2718. 20180325 20:04:21< Nobun> after git fetch what tag should I build exacly? 20180325 20:04:45<+discordbot4> Nobun: the branch 1.14 (not a tag). 20180325 20:04:51< gfgtdf> didnt you say you are testing 1.14 ? 20180325 20:05:19< celticminstrel> Yeah, I'm merging it to 1.14, testing it quickly, then cherry-picking to master and pushing that, and reverting it on 1.14. 20180325 20:05:26< celticminstrel> Because my VSCode build doesn't work yet. 20180325 20:05:31< gfgtdf> i don't think #2718 is good for 1.14 (feature freeze) 20180325 20:05:39< celticminstrel> (And even if it did I'm not sure if I'd even be able to test it there.) 20180325 20:06:07< gfgtdf> ah ok idnt read the last part 20180325 20:06:12< gfgtdf> didn't* 20180325 20:06:17< gfgtdf> sry 20180325 20:07:08< gfgtdf> celticminstrel: does it also happen if you disable your addons ? 20180325 20:07:53< celticminstrel> My addons are now in Wesnoth1.14, so the Wesnoth1.13 addons folder is empty. 20180325 20:08:22< celticminstrel> (I manually edited the shortcut from the 1.13.12 installer to point to Wesnoth1.14 as the userdata directory.) 20180325 20:08:31< celticminstrel> ^shortcuts 20180325 20:09:14< celticminstrel> Okay, full rebuild with up-to-date external initiated... *crosses fingers* 20180325 20:09:57< celticminstrel> Full rebuild takes awhile. :/ 20180325 20:12:29< Nobun> ok I am copying file from git branch 1.14. Tomorrow I will build it and will let you know if it will be a successful or failing build 20180325 20:14:07< celticminstrel> ...that's... quite a long time from now. It's very likely I'll have the issue resolved by then. 20180325 20:17:47< Nobun> celticminstrel: well. I don't have time to build wesnoth now. I will re-join tomorrow and let me know if you can need another build for another person. If it can be helpful, I will do it. 20180325 20:20:43< Nobun> now I have to go. Good night all. 20180325 20:21:35-!- gfgtdf [~chatzilla@x4e363818.dyn.telefonica.de] has quit [Write error: Connection reset by peer] 20180325 20:22:39-!- Nobun [~user@51.179.98.217] has quit [Quit: good night all] 20180325 20:33:53< irker073> wesnoth/wesnoth:master newfrenchy83 1c68da5fc1 Update abilities.cpp AppVeyor: vs2017/Release Failed 20180325 20:33:54< irker073> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-master-1931 20180325 20:48:14<+discordbot4> Wow, apparently this is what the server used to do for non-forum passwords... 20180325 20:48:17<+discordbot4> void suh::password_reminder(const std::string& name) { std::stringstream msg; msg << "Hello " << name << ",\nyour password is '" << get_password(name) << "'.\n\nHave fun playing Wesnoth :)"; send_mail(name, "Wesnoth Password Reminder", msg.str()); } 20180325 20:48:25<+discordbot4> just.... 20180325 20:48:28<+discordbot4> blinks 20180325 20:49:14<+discordbot4> In fairness, the guy who wrote this (Baufo I believe) had forum_user_handler as his absolute priority. 20180325 20:49:27<+discordbot4> fair enough 20180325 20:49:37<+discordbot4> The rest was just the result of the kind of prototyping you tend to do when doing OOP as far as I recall. 20180325 20:50:55< irker073> wesnoth: Charles Dang wesnoth:master e52682e07b74 / src/server/ (6 files): wesnothd: removed password reminder backend (closes #2753) https://github.com/wesnoth/wesnoth/commit/e52682e07b74e63cdcc670a9b6113f6c8934e86b 20180325 20:54:38<+discordbot4> Looks like they even left a note saying not to use the sample_user_handler in actual deployment ever. 20180325 20:54:51<+discordbot4> so that's a 👍 20180325 20:58:52<+discordbot4> @jyrkive RE https://github.com/wesnoth/wesnoth/issues/2750 looks like we just have to remove that assertion entirely and restore it as part of the if block. Thoughts? 20180325 20:59:43<+discordbot4> I think it would be best to ignore disabled events when saving, but only when saving from within the OOS dialog. 20180325 20:59:58<+discordbot4> Otherwise it would still be best to keep the assert enabled IMO. 20180325 21:00:16< grzywacz> What's the reasoning for having rooms in MP lobby? 20180325 21:00:46<+discordbot4> Organizing games between more than two people without having to use an external platform. 20180325 21:00:49<+discordbot4> the assertion is also disabled when accessing the gamestate inspector 20180325 21:01:33< grzywacz> Why is one public lobby not good enough for that? I've never seen any excessive chatter on the stable MP server. 20180325 21:01:50< grzywacz> Privacy? 20180325 21:01:56<+discordbot4> thing is, from a cursory glance at the code, it looks like the OOS dialog invokes the normal save path 20180325 21:02:29<+discordbot4> It could pass down a flag, or even use a public static variable. 20180325 21:02:39<+discordbot4> since there's no explicit call to write_events like with the inspector, not sure what to do without adding yet more arguments 20180325 21:02:40<+discordbot4> hmmm 20180325 21:03:32<+discordbot4> grzywacz: Excessive chatter is discouraged by the CoC. 20180325 21:04:10< octalot> having a room for "looking for co-op campaign" might be nice 20180325 21:04:33<+discordbot4> I'm going to clarify, the rooms feature has been in place since version 1.8.0, it's just that it was limited to the GUI2 lobby, which was seriously crippled until Vultraz finished it up and made it the only option in 1.13.x. 20180325 21:04:53< octalot> ty 20180325 21:05:01<+discordbot4> It's not received much testing for that reason, and as you know, people are allergic to development releases so it's still not hugely tested. 20180325 21:05:15<+discordbot4> Whether we'll keep or remove the feature obviously comes down to user feedback. 20180325 21:05:19<+discordbot4> wait a minute 20180325 21:05:26<+discordbot4> We need to get that feedback first. 20180325 21:05:30<+discordbot4> ...aren't rooms totally broken? 20180325 21:06:10< octalot> who can create rooms? (I just tried to see if they get auto-created by /join like IRC, and it didn't) 20180325 21:06:14<+discordbot4> I had loonycyborg fix them shortly after the Asio merge I'm pretty sure. 20180325 21:06:38<+discordbot4> I thought they were something lost in the ASIO port that I only retained a facsimile of via a tabbed chat UI but that didn't actually give users the ability to create their own rooms, and where I cannot even have the lobby and game rooms open at once because of the way the server works? 20180325 21:08:05<+discordbot4> @loonycyborg is it not so? 20180325 21:08:16< Ravana_> 1.13 doesn't have rooms 20180325 21:08:30<+discordbot4> [frustrated noises] 20180325 21:09:12< Ravana_> I investigated that for https://github.com/wesnoth/wesnoth/issues/2500 20180325 21:09:58<+discordbot4> slightly related: will probably add another room here on discord for matchmaking/game coordination 20180325 21:10:11<+discordbot4> We don't need that. 20180325 21:10:22<+discordbot4> I didn't implement rooms yet 20180325 21:10:26<+discordbot4> Unless #general's activity grows to the point that it can justify that decision. 20180325 21:10:30<+discordbot4> I'm still not sure we really need it 20180325 21:10:37<+discordbot4> For the love of 20180325 21:10:41<+discordbot4> and I can only focus on packaging now 20180325 21:11:01<+discordbot4> @Vultraz I'm guessing you can just hide or remove the tab bar then. 20180325 21:11:17<+discordbot4> no, because PMs open in new tabs 20180325 21:11:20<+discordbot4> Isn't it also used for private chats? 20180325 21:11:23<+discordbot4> asdf. 20180325 21:11:49<+discordbot4> Okay, then you still get to fix the last two items of #2709. 20180325 21:11:58<+discordbot4> We can postpone them until after gold if necessary. 20180325 21:13:20<+discordbot4> To reiterate what I said earlier, I'd like to have a hard string freeze again tomorrow at 23:00 UTC so I can run a pot-update and tell translators we broke the string freeze and why. 20180325 21:13:59<+discordbot4> So ideally #2709 and #2732 (which I'm still taking care of) will be sorted out by then modulo bigger engineering issues like the room names. 20180325 21:14:03-!- deekay [~deekayish@77-254-147-144.adsl.inetia.pl] has joined #wesnoth-dev 20180325 21:14:39<+discordbot4> Failing that I'd prefer if the pot-update wasn't any later than Tuesday 23:00 UTC. 20180325 21:15:14< grzywacz> deekay: hi? ;) 20180325 21:15:52< deekay> Oh hi 20180325 21:15:56< deekay> Long time no see 20180325 21:16:21< irker073> wesnoth: newfrenchy83 wesnoth:master 76c2cbac46a6 / / (8 files in 5 dirs): Implement [filter_weapon] in leadership and resistance abilities https://github.com/wesnoth/wesnoth/commit/76c2cbac46a6417bf15a52ce3c6589c0c3954c74 20180325 21:17:36< irker073> wesnoth/wesnoth:master Charles Dang ebec4d6ce8 MP Login: removed Password Reminder func AppVeyor: 2/4 builds failed 20180325 21:17:37< irker073> Details vs2017/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-master-1927 20180325 21:17:38< irker073> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-2221 20180325 21:17:51<+discordbot4> @Vultraz And that means I still need you to figure out the Search box i18n issue and also what to do with the Level label in unit descriptions in Help. 20180325 21:18:25<+discordbot4> If you're really attached to the current layout I can just mark "Level " as translatable. 20180325 21:19:43<+discordbot4> (Also, to clarify for anyone who might be suspecting that this might be the start of a slippery slope of string thawings throughout the RC phase: this is specifically to solve glaring internationalization bugs. If it were anything else I'd not be as supportive of adding or altering strings.) 20180325 21:21:49-!- DeFender1031 [~DeFender1@89-138-91-7.bb.netvision.net.il] has quit [Quit: I'm not back now.] 20180325 21:24:41< vn971> Question about Lua API. If I have side1 and side2, can I assign the current controller of side1 to also control side2, from Lua? 20180325 21:36:10-!- gfgtdf [~chatzilla@x4e363818.dyn.telefonica.de] has joined #wesnoth-dev 20180325 21:36:34< gfgtdf> vn971: changign which player controls a side ? 20180325 21:36:45< gfgtdf> vn971: that is not really posible 20180325 21:37:23< gfgtdf> vn971: with one exception: you change a sides controller to null and then to human it will then be controlled by the players that also conntrls the current side 20180325 21:37:49< irker073> wesnoth/wesnoth:master newfrenchy83 76c2cbac46 Implement [filter_weapon] in leadership AppVeyor: vs2017/Release Failed 20180325 21:37:50< irker073> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-master-1933 20180325 21:40:16<+discordbot4> btw libhistory support should be enabled in steam linux now 20180325 21:40:35<+discordbot4> though steamrt has too old version of sdl-image 20180325 21:40:56<+discordbot4> to support that jpeg feature 20180325 21:41:12<+discordbot4> it works on windows release though 20180325 21:41:20<+discordbot4> because II've built my own sdl 20180325 21:41:20-!- travis-ci [~travis-ci@ec2-54-211-39-126.compute-1.amazonaws.com] has joined #wesnoth-dev 20180325 21:41:21< travis-ci> wesnoth/wesnoth#17220 (master - e52682e : Charles Dang): The build has errored. 20180325 21:41:21< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/358160854 20180325 21:41:21-!- travis-ci [~travis-ci@ec2-54-211-39-126.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180325 21:42:48<+discordbot4> @loonycyborg why would you build SDL o_o you can download MinGW devlibs right here: https://www.libsdl.org/download-2.0.php 20180325 21:43:59<+discordbot4> well it's easy enough to build 20180325 21:44:10<+discordbot4> even with cross-compiler 20180325 21:44:27<+discordbot4> last time I checked it had only msvc sdk 20180325 21:44:54<+discordbot4> It has SDL2-devel-2.0.8-mingw.tar.gz now it seems 20180325 21:45:05<+discordbot4> Must've been a long time ago. I remember there being an MGW build there for years 20180325 21:45:11< gfgtdf> why woudl they be differnt? its a c library. 20180325 21:45:38<+discordbot4> pkg-config 20180325 21:45:47<+discordbot4> and different naming convention for libs 20180325 21:46:03<+discordbot4> IIRC the MSVC one are .lib and the MinGW ones are .a 20180325 21:46:05<+discordbot4> Also, handling of linking up to DLLs is different. 20180325 21:47:53< vn971> gfgtdf: thanks a lot! So if I want controller of side1 to also control side2, it would be possible by waiting till it's side2-s turn and using the schema you told about. I was wondering if a similar thing could work, yes. Thanks again! 20180325 21:49:13< gfgtdf> no you have to wait unitls side1's turn. and tne use the shema, 20180325 21:49:46< gfgtdf> in fact the negine won't even allow you to change the controller of side2 to null during the turn of side2 20180325 21:52:00<+discordbot4> @Vultraz, everyone else: https://wiki.wesnoth.org/User:Shadowm/Stable_1.14_Announcement_Outline 20180325 21:52:30<+discordbot4> Start adding stuff there that you worked on during 1.13.x that you want Vultraz and others to include in the 1.14 release announcement. 20180325 21:52:42< gfgtdf> did i understood correctly that we are not in a stringfreeeze currently ?` 20180325 21:53:08<+discordbot4> We are in a string freeze unless you have a good excuse that has to go through either me or vultraz first. 20180325 21:53:26<+discordbot4> The excuse had better be that it solves an i18n bug. 20180325 21:53:52-!- travis-ci [~travis-ci@ec2-54-211-39-126.compute-1.amazonaws.com] has joined #wesnoth-dev 20180325 21:53:53< travis-ci> wesnoth/wesnoth#17221 (master - 76c2cba : newfrenchy83): The build failed. 20180325 21:53:53< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/358167878 20180325 21:53:53-!- travis-ci [~travis-ci@ec2-54-211-39-126.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180325 21:54:59<+discordbot4> Also, that page is an outline. We don't want prose, we just want to enumerate items we'll talk about in the real release announcement. 20180325 21:55:54<+discordbot4> The whole point of having an outline is so that people who're not great at speaking English in a marketing speech fashion don't need to worry about doing that because someone else will do it for them. 20180325 21:56:27<+discordbot4> Tag platform-specific features like I already did with the Windows crap. 20180325 21:56:36< celticminstrel> Should we be enumerating all of the new Lua and WML API features? 20180325 21:56:56<+discordbot4> Use this as reference: https://www.wesnoth.org/start/1.12/#creators 20180325 21:57:20<+discordbot4> You do not need to enumerate all of them, only the really big stuff that is oh my god so important that everyone absolutely needs to know about it. 20180325 21:57:28< vn971> gfgtdf: ah right. OK, got it! 20180325 21:57:39< gfgtdf> well i'll leave it to to decide then: you can mark https://github.com/wesnoth/wesnoth/blob/1.14/src/synced_commands.cpp#L402 as transltable if you want. 20180325 21:59:19< gfgtdf> i'd ned the spmp patch in 1.13. in partiuclar mods for sp. 20180325 22:00:49<+discordbot4> gfgtdf: Have you and Soliton come to a consensus with regards to how that should be displayed then? 20180325 22:01:12<+discordbot4> Also didn't understand that last sentence. 20180325 22:04:27< celticminstrel> XD Looks like the new wml module was mentioned in three different changelogs. 20180325 22:04:50< celticminstrel> I mean, the changelog for three different versions mentioned it as something new. Only in the latest was it mentioned in the release notes though. 20180325 22:05:15<+discordbot4> gfgtdf: I need to know the answer to that question before I let a string into the pot-update, btw. This stuff is going to be permanent until 1.14.1. 20180325 22:05:36<+discordbot4> That's a pretty long time in case it isn't obvious. 20180325 22:05:54<+discordbot4> Plus translators' time doesn't exactly come for free. 20180325 22:06:09< Soliton> shadowm: haven't tested the dialog yet but that it's based on the oos dialog is how i imagined it. 20180325 22:06:50< celticminstrel> Currently scanning the changelog, but off the top of my head, the two things most worth mentioning are probably "further hooks", meaning wesnoth.wml_conditionals, wesnoth.effects, wesnoth.persistent_tags; and "expanded use of WFL both in filters and in unit abilities / weapon specials". 20180325 22:06:50< Soliton> the text is ok as well afaiac. 20180325 22:07:09-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection] 20180325 22:07:51<+discordbot4> celticminstrel: Yeah, that sounds good to me, in particular the conditionals stuff which is the only one I had the chance to see and understand before taking that extended break. You can add it to the outline. 😃 20180325 22:08:15< celticminstrel> I'll do that once I've finished looking through the changelogs. 20180325 22:08:52< celticminstrel> wesnoth.music_list might be worth it but not sure... 20180325 22:09:37< celticminstrel> Do you think the wesnoth.require upgrades are worth a mention? Basically you can omit the extension (wesnoth.require "helper") and you can require a whole directory. 20180325 22:10:09< celticminstrel> ...which IIUC would also check for _main.lua, _initial.lua, _final.lua in the same vein as the preprocessor... 20180325 22:10:26< celticminstrel> That... might be a little problematic actually. 20180325 22:10:32< celticminstrel> If it does, I mean. 20180325 22:10:34<+discordbot4> I mean, remember that we're not going to go into details about any changes or list all of them. There are wiki pages or forum pages for that purpose. 20180325 22:10:40< celticminstrel> Yeah, okay. 20180325 22:10:58< celticminstrel> I guess it's also not something that would affect many people, so maybe not worth a mention. 20180325 22:11:07<+discordbot4> It's just to entice people migrating from 1.12 to come up with new ideas w.r.t. how to use Wesnoth's engine changes and additions to enhance their add-ons. 20180325 22:11:27< Soliton> add-on licensing changes should be mentioned. 20180325 22:11:33< celticminstrel> I guess "expansion of Lua GUI2 API" is probably worth a mention, because there are quite a few things that fit that. 20180325 22:12:28<+discordbot4> Is the Lua GUI2 API considered a stable API now? Because up until 1.12.0 it wasn't and we treated it more like some kind of badly emaciated child we kept in the attic away from the world and fed twice a day. 20180325 22:12:49< celticminstrel> Personally I still think it should be scrapped. 20180325 22:12:54< celticminstrel> And replaced with something different. 20180325 22:13:07< celticminstrel> I don't know if it can be considered stable. 20180325 22:13:15< celticminstrel> I do know it has been greatly expanded. 20180325 22:14:12<+discordbot4> Added an item for the licensing changes at the very end of the outline. 20180325 22:15:04<+discordbot4> (I'd like to think the items in the outline will come out the other end in the same order, meaning that every section has items listed in descending order of importance, but that's really up to Vultraz or whoever ends up being in the team writing the announcement.) 20180325 22:15:16< celticminstrel> Oh hmm, maybe something about IPFs... 20180325 22:16:02< celticminstrel> Or maybe that could just fall in as part of the WFL mention, since that's probably the most significant new IPF. 20180325 22:16:32< celticminstrel> FTR, it looks like the most recent Lua engine upgrade was to 5.3.3+patches 20180325 22:17:28< Ravana_> under content creators or multiplayer would go downloading addons from lobby 20180325 22:17:40< celticminstrel> I think even if the core of the GUI2 stuff isn't worth a mention that it might be worth mentioning that there's a pack of predefined dialogs now accessible from Lua... 20180325 22:18:13< celticminstrel> Oh! Should we mention the gamestate inspector redesign? 20180325 22:18:32< celticminstrel> And speaking of that, the Lua console is actually new in 1.13.x too, right? 20180325 22:18:49< Ravana_> lua console is included there 20180325 22:19:05< celticminstrel> Ah, okay. Haven't actually looked at the outline closely yet. >_> 20180325 22:19:14-!- deekay [~deekayish@77-254-147-144.adsl.inetia.pl] has quit [Quit: Leaving] 20180325 22:19:20<+discordbot4> Ravana_: Downloading add-ons from the lobby is strictly a player (multiplayer) feature. 20180325 22:19:37<+discordbot4> As in content creators do not need to do anything about it or even know it exists. 20180325 22:19:45< celticminstrel> Maybe the new looping tags are worth a mention? 20180325 22:21:03< celticminstrel> "Support [effect]times=" Uh, isn't there something missing there? IIRC that should be the support for using an integer to apply an effect repeatedly. 20180325 22:23:11< celticminstrel> On the one hand we could mention the unification of AI aspect syntax, but on the other hand I'm not sure how much that'll actually affect content creators... though I guess some of their aspects could now be written in a more abbreviated fashion... 20180325 22:24:54< celticminstrel> And the new abilitiy to nest facets in facets probably has few uses... 20180325 22:24:57< gfgtdf> are we supposed to tell you or just add it ourselves to that page ? 20180325 22:25:26< celticminstrel> You're supposed to add it. I'm just giving a running commentary as I go through the changelog in case someone has comments. 20180325 22:26:29< celticminstrel> I think it's probably worth having a sentence that mentions the AI in some way... 20180325 22:27:57< celticminstrel> Especially since apparently there are some compatibility-breaking changes? 20180325 22:28:05< celticminstrel> I vaguely remember these. 20180325 22:28:30< celticminstrel> The 1.13.5 release announcement goes into some detail on them. 20180325 22:28:42<+discordbot4> I think the AI stuff simply has less users because it is less known and the aspects aren't needed that much (Or maybe one doesn't get the idea where to use them unil one has experience with it) 20180325 22:29:37< gfgtdf> should i add [on_undo] ? It's a rather simple feature but it was requested multiple times. 20180325 22:29:48< celticminstrel> I thought that was removed. 20180325 22:29:55< gfgtdf> [on_redo] was removed 20180325 22:30:04< celticminstrel> Ah, okay. 20180325 22:31:25< celticminstrel> I think I spotted a Markdown formatting error in the changelog. 20180325 22:31:47< gfgtdf> i think gui2 expansion is really nice, but i think there are only very few people that actualyl use it, and those that do porbaly already know it 20180325 22:32:07< gfgtdf> not sure though 20180325 22:32:32< gfgtdf> "WFL in unit abilities / weapon specials" is really nice and should be mentioned. 20180325 22:32:52< celticminstrel> I plan to. 20180325 22:33:09< celticminstrel> I wonder if I should have just one bullet point for WFL or a few bullet points... 20180325 22:33:43< gfgtdf> added soem things that you didn't mention yet. 20180325 22:33:44<+discordbot4> That's the thing. The Lua GUI2 API was the freak child for so long it's a bit difficult to talk about it, especially when it has such obvious deficiencies that celticminstrel of all people would like to replace it. 20180325 22:34:15<+discordbot4> Are you talking about the changelog or the release announcement? 20180325 22:34:17< celticminstrel> Me "of all people", huh. 20180325 22:34:29<+discordbot4> Yeah. 20180325 22:34:56<+discordbot4> @Tad Carlucci https://wiki.wesnoth.org/User:Shadowm/Stable_1.14_Announcement_Outline 20180325 22:36:10<+discordbot4> gfgtdf: For the record, I had "Ability to use mod add-ons in single-player campaigns" in the For Players/Campaigns section, but I guess it doesn't hurt to go into just a little bit more detail as to what that entails for add-on creators. 20180325 22:36:39< celticminstrel> Found another formatting error in the changelog. I think we should probably go over it in some detail for more such errors. 20180325 22:36:46< gfgtdf> oh roight didn'T see it sry 20180325 22:36:49< gfgtdf> didn't 20180325 22:37:18< gfgtdf> (' needs shift here that's why i'm often writing the letter after the ' in caps) 20180325 22:37:30<+discordbot4> celticminstrel: I think vultraz would welcome any fixes to the changelog's Markdown, since it was done rather haphazardly on purpose. 20180325 22:38:30<+discordbot4> Not that I consider it to be the best use of anyone's time, mind you (that's the reason I didn't bother with it beyond the automated conversions that were requested from me). 20180325 22:38:59< celticminstrel> If I use VSCode for it, I imagine it shouldn't be too hard... assuming the size of the file doesn't freeze VSCode every time I change something. 20180325 22:43:06< celticminstrel> Okay, I reached 1.11.11 in the changelog. 20180325 22:43:14< celticminstrel> I'll add some things to the outline now. 20180325 22:45:03<+discordbot4> Okay okay hold the phone. 20180325 22:45:36<+discordbot4> unit::describe_builtin_effect() is using VGETTEXT() already. 20180325 22:45:42<+discordbot4> celmin: micro ais were 1.13 ? 20180325 22:45:49<+discordbot4> were new in* 20180325 22:46:19<+discordbot4> I think so, and if so that's something else to add 20180325 22:46:21<+discordbot4> Ohhhhh. 20180325 22:46:33<+discordbot4> I think I fixed the tooltips part of #2732 already. 20180325 22:46:54<+discordbot4> Yep, I did. 20180325 22:46:55<+discordbot4> good, good 20180325 22:47:23<+discordbot4> In fact the string the translator uses for the example is precisely the one I warned you about because it required a string thaw. 20180325 22:47:48<+discordbot4> (i.e. the one that was read as "wesnoth" by xgtettext.) 20180325 22:48:05<+discordbot4> So it's down to the help page for that bug. 20180325 22:48:15< celticminstrel> @Vultraz They're in 1.12. I used them in my campaign. 20180325 22:48:19<+discordbot4> ah 20180325 22:48:20<+discordbot4> ok 20180325 22:48:23<+discordbot4> I couldnt remember 20180325 22:48:44<+discordbot4> and yes, I agree with you we need a new user-facing GUI2 API 20180325 22:49:41<+discordbot4> and yes, VSCode can handle previewing the changelog 20180325 22:49:57< celticminstrel> I know, I already did it with my addon's changelog when I added one recently. 20180325 22:50:00<+discordbot4> celmin: and no, the most recent Lua upgrade is to 5.3.4 + patches 20180325 22:50:12< celticminstrel> What's the version in 1.12? 20180325 22:50:19<+discordbot4> celmin: I mean the game's changelog. You said it might cause VSC to freeze 20180325 22:50:27<+discordbot4> No idea. 20180325 22:50:28< celticminstrel> Oh, right. 20180325 22:50:33<+discordbot4> VS Code also has a linter addon for markdown 20180325 22:50:36< celticminstrel> Well someone else can add the old version then. 20180325 22:50:56<+discordbot4> @shadowm Since you said you wanted to start a new string freeze tomorrow, I want to remind that https://github.com/wesnoth/wesnoth/issues/1709 is still a think on linux (not on windows). 20180325 22:51:16<+discordbot4> oh god dammit that fucking bug ... 20180325 22:51:16< celticminstrel> BTW, I was assuming having the preview and the raw markdown visible at the same time. 20180325 22:51:29<+discordbot4> that is possible 20180325 22:52:02<+discordbot4> @sevu Would you have any idea of where I need to start looking at for that one? 20180325 22:52:09< celticminstrel> Added a bunch of things, any comments? https://wiki.wesnoth.org/User:Shadowm/Stable_1.14_Announcement_Outline#For_Content_Creators 20180325 22:52:24<+discordbot4> @shadowm the problem apparently appeared after I deployed std::put_time 20180325 22:52:57< celticminstrel> Not sure whether I'll actually go over the changelog though... 20180325 22:52:59<+discordbot4> @shadowm the game still uses the boost::locale codepath for the time formatting on GCC < 5.1 IIRC, but no one actually builds with that, 20180325 22:53:05< celticminstrel> I'll consider it. 20180325 22:53:28<+discordbot4> @Vultraz It sounds like you got the fix figured out already? 😛 20180325 22:53:30< celticminstrel> (I mean for formatting errors.) 20180325 22:53:31<+discordbot4> I have this issue with modern GCC 20180325 22:53:36<+discordbot4> yes 20180325 22:53:48<+discordbot4> which leads me to believe someone fucked up the std::put_time implementation on Linux. 20180325 22:54:30<+discordbot4> I mean 20180325 22:54:32<+discordbot4> the relevant function is translations::strftime 20180325 22:55:07<+discordbot4> https://cdn.discordapp.com/attachments/259976436490829825/427601354673094656/unknown.png 20180325 22:55:12<+discordbot4> The issue is only with days of the week? 20180325 22:55:49< celticminstrel> I think std::put_time is kinda weird TBH. 20180325 22:55:51<+discordbot4> wedge says it's with months 20180325 22:56:01<+discordbot4> @shadowm you run linux on that image? 20180325 22:56:08<+discordbot4> Debian buster/sid. 20180325 22:56:32<+discordbot4> for me it displays the left column localized, but the right one in english locale 20180325 22:56:43<+discordbot4> The left column is file names. 20180325 22:56:46<+discordbot4> e.g. "24. Mar" 20180325 22:56:53<+discordbot4> i.e. it's never localized. 20180325 22:57:05-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Ping timeout: 248 seconds] 20180325 22:57:10<+discordbot4> It's the names that may or may not have been composed from localized strings. 20180325 22:57:15<+discordbot4> true 20180325 22:58:00<+discordbot4> Well, here we have it: 20180325 22:58:03<+discordbot4> https://cdn.discordapp.com/attachments/259976436490829825/427602090697818112/unknown.png 20180325 22:58:32<+discordbot4> On the description, it should be saying "Lunes Enero 01 00:00 2018" (possibly abbreviated) and on the list it should say "01 de Ene". 20180325 22:59:14<+discordbot4> IIRC the description uses a different codepath? 20180325 22:59:43<+discordbot4> You think it might use the system locale/LC_TIME for the description? 20180325 23:00:01<+discordbot4> hm... 20180325 23:00:03<+discordbot4> checks to see if she left es_CL.UTF-8 enabled 20180325 23:00:21<+discordbot4> Doesn't seem to work. 20180325 23:00:41<+discordbot4> So, currently it's a mix of localized and english one? the " de " from l18n, and "Jan" from Egnlish? 20180325 23:00:56<+discordbot4> Yes. 20180325 23:01:12<+discordbot4> I do have the locale enabled but LC_TIME=es_CL.UTF-8 doesn't seem to do anything for Wesnoth. Then again, isn't there an open report about Wesnoth ignoring the locale env vars? 20180325 23:01:36<+discordbot4> (Proof it's correctly configured.) 20:01:16 shadowm@hanacore ~ % LC_TIME=es_CL.UTF-8 date dom mar 25 20:01:21 -03 2018 20180325 23:01:53<+discordbot4> looks like both codepaths eventually end up at translation::strftime 20180325 23:02:05<+discordbot4> https://github.com/wesnoth/wesnoth/issues/2558 20180325 23:02:28<+discordbot4> This seems to be specific to LANGUAGE though. 20180325 23:02:50<+discordbot4> the description codepath is simply 20180325 23:02:52<+discordbot4> std::string save_info::format_time_local() const { if(tm* tm_l = localtime(&modified())) { const std::string format = preferences::use_twelve_hour_clock_format() ? _("%a %b %d %I:%M %p %Y") : _("%a %b %d %H:%M %Y"); return translation::strftime(format, tm_l); } LOG_SAVE << "localtime() returned null for time " << this->modified() << ", save " << name(); return ""; } 20180325 23:03:15<+discordbot4> and then strftime... cpp std::string strftime(const std::string& format, const std::tm* time) { std::basic_ostringstream dummy; std::lock_guard lock(get_mutex()); dummy.imbue(get_manager().get_locale()); dummy << std::put_time(time, format.c_str()); return dummy.str(); } 20180325 23:03:25<+discordbot4> (that's on master, without the fallback to boost) 20180325 23:03:49<+discordbot4> cpp std::basic_ostringstream dummy; std::lock_guard lock(get_mutex()); 20180325 23:03:59-!- Ivanovic [~ivanovic@p4FC53D61.dip0.t-ipconnect.de] has joined #wesnoth-dev 20180325 23:04:07<+discordbot4> the issue occurred before the mutex was added ftr 20180325 23:04:14<+discordbot4> Is it safe to conjure up a basic_ostringstream before locking? 20180325 23:04:24<+discordbot4> I don't know. Ask gfgtdf 20180325 23:04:25<+discordbot4> Just out of curiosity, it's unrelated to the issue at hand. 20180325 23:04:25<+discordbot4> he added them 20180325 23:05:24<+discordbot4> std::put_time uses the current locale, doesn't it? 20180325 23:05:44<+discordbot4> Meaning the application has to set the locale correctly first. 20180325 23:06:03<+discordbot4> it uses whatever you imbue the stream with 20180325 23:06:09<+discordbot4> Oh, okay. 20180325 23:06:32<+discordbot4> When used in an expression out << put_time(tmb, fmt), converts the date and time information from a given calendar time tmb to a character string according to format string fmt, as if by calling std::strftime, std::wcsftime, or analog (depending on CharT), according to the std::time_put facet of the locale currently imbued in the output stream out. 20180325 23:06:42< celticminstrel> So was the stream not imbued on one code path? 20180325 23:06:48<+discordbot4> "dummy" is a rather odd choice of words when the usage here is pretty much on par with the stringstream used by formatter. 20180325 23:06:56<+discordbot4> Name. Odd choice of name. 20180325 23:07:07<+discordbot4> It's imbued in both paths. 20180325 23:07:47<+discordbot4> I suppose one should check get_manager().get_locale() to see it's always giving the right result 20180325 23:07:53< gfgtdf> shadowm: what need nned to be inside the mutext is mainly the get_mamanger().get_locale() which might call update_locale_internal() 20180325 23:08:01<+discordbot4> My knowledge of i18n stuff is a bit hazy at this point, but could the problem be that I do not have the exact locale Wesnoth wants? 20180325 23:08:15< gfgtdf> at least that was what teh bugreport was about, i did not explicitly check how save out logging functions were 20180325 23:08:24<+discordbot4> How do I get to see the exact locale in question btw? 20180325 23:08:54<+discordbot4> OK never mind. 20180325 20:08:42 info general: updated locale to 'es_ES.UTF-8' locale is now '*' ( name='es_ES.UTF-8' country='ES' language='es' encoding='utf-8' variant='') 20180325 23:09:07<+discordbot4> Let me see what happens if I enable es_ES.UTF-8... 20180325 23:09:57<+discordbot4> No difference. 20180325 23:10:00<+discordbot4> (ot for a sec: for the Search thing i think ll take celmins suggestion) 20180325 23:10:54<+discordbot4> I wouldn't rule out a bug in libstdc++ but it'd be odd since it's been so many years. 20180325 23:11:22<+discordbot4> I mean, the boost path definitely works, as sevu said. 20180325 23:11:24<+discordbot4> "Setting it to 0 works" 20180325 23:11:30<+discordbot4> (0 meaning disabling the put_time path) 20180325 23:12:04<+discordbot4> so the fact that it's only a issue on linux... odd 20180325 23:13:15<+discordbot4> Any concrete downsides to using the Boost.Locale path for the time being? 20180325 23:13:48<+discordbot4> Not particularly. But we'd still have to deal with it on master. And this is only one place where put_time is used. 20180325 23:18:21<+discordbot4> Found a few open bugs upstream related to std::get_time and std::put_time but nothing that sounds like this. 20180325 23:25:07<+discordbot4> 168 test, 165 of them failed .. makes me wonder what's wrong with those three 20180325 23:25:25<+discordbot4> eh? 20180325 23:25:31<+discordbot4> maybe they were expected to fail? 20180325 23:25:44<+discordbot4> what the hell could have been in celmin's commit that broke them so spectacularly.. 20180325 23:25:51<+discordbot4> Oh, that might do it 20180325 23:26:24<+discordbot4> i mean, it seems to be celmin's commi about map location something oranoher that broke them 20180325 23:27:00< irker073> wesnoth/wesnoth:1.14 Charles Dang b81c53cde8 Updated changelog AppVeyor: All builds passed 20180325 23:29:21<+discordbot4> it's not even that they just fail, they almost fail via all time out until the entire travis job reaches its time limit 20180325 23:30:05-!- Gambit [~derek@wesnoth/developer/grickit] has joined #wesnoth-dev 20180325 23:30:48< celticminstrel> Hm? 20180325 23:30:54< celticminstrel> Which commit?. 20180325 23:30:56<+discordbot4> tell me about it. almost an hour in WML tests locally. Doing a Batch Build after a Batch Clear, Release and Debug 20180325 23:31:04<+discordbot4> "Support to_location in [move_unit]" 20180325 23:31:09< celticminstrel> Oh. 20180325 23:31:17< celticminstrel> What're the tests? 20180325 23:31:40-!- Grickit [~derek@wesnoth/developer/grickit] has quit [Quit: No Ping reply in 180 seconds.] 20180325 23:32:16<+discordbot4> Soliton: This is the debug command report dialog, btw (excuse the fact that it's full of Spanish, its caption is "Save Game", it offers the options to Ignore all future reports or quit the game, and Yes/No at the bottom). 20180325 23:32:17<+discordbot4> https://cdn.discordapp.com/attachments/259976436490829825/427610700689440799/unknown.png 20180325 23:32:28<+discordbot4> well you broke the build 20180325 23:32:31<+discordbot4> as well 20180325 23:32:32<+discordbot4> last commit 20180325 23:32:51<+discordbot4> and as for the tests 20180325 23:33:02<+discordbot4> Starting with "Support formula= in [variable] ConditionalWML" as well possibly, since that build was canceled 20180325 23:33:09<+discordbot4> (The punctuation is really off so I'm going ot have to go over those strings before marking them as translatable.) 20180325 23:33:10<+discordbot4> you broke almost all of them 20180325 23:33:37<+discordbot4> agh 20180325 23:33:39<+discordbot4> that text... 20180325 23:33:52<+discordbot4> (Or Vultraz might want to do it for me.) 20180325 23:34:54<+discordbot4> "The use of a debug command was detected. Another player might be cheating. \n\n Details: \n A unit was created with a debug command during $user's turn" 20180325 23:34:58< Soliton> shadowm: yeah, punctuation should be fixed. perhaps some formatting tweaks, looks good to me otherwise. 20180325 23:35:36<+discordbot4> gfgtdf: These debug_notification() strings aren't instantly translatable, btw, no matter how hard you try feeding them into VGETTEXT(). I'll use N_() on them to make them so. 20180325 23:36:05<+discordbot4> xgettext is not going to add them to the catalogue otherwise and translators will never be able to translate them. 20180325 23:39:26<+discordbot4> cpp debug_notification(N_(":next_level debug command was used during $player’s turn")); 20180325 23:39:46<+discordbot4> I'm curious exactly what are the consequences of this particular command in MP. 20180325 23:40:14<+discordbot4> Oh, I get the dialog and the save/replay save prompts then return to lobby. 20180325 23:40:32< celticminstrel> If you're in an MP campaign though you'd advance to the next scenario. 20180325 23:40:50<+discordbot4> celticminstrel: do you have any idea in hell what this PR is on about? That codepath doesn't even exist in master https://github.com/wesnoth/wesnoth/pull/2754 20180325 23:41:16<+discordbot4> Yeah, I was mostly curious if the game would know what to do for something that isn't a campaign but I guess it's kind of a stupid thing to worry about after the "SP/MP unification" thingamabob. 20180325 23:41:34<+discordbot4> Seriously, the code never existed in master, yet GH says no conflicts...? What the hell 20180325 23:42:04< celticminstrel> Uh, I added that code in the last commit. We can't remove it. Maybe there's a missing include for optional? 20180325 23:42:13< Ravana_> last I looked (1.13.12) lua console lua does not cause notice 20180325 23:42:20<+discordbot4> what? 20180325 23:42:27<+discordbot4> do I not have latest master? 20180325 23:42:34< celticminstrel> I guess not? 20180325 23:42:34<+discordbot4> OH 20180325 23:42:34<+discordbot4> yes 20180325 23:42:39<+discordbot4> I do not 20180325 23:42:50<+discordbot4> why are you using equals here 20180325 23:42:55< celticminstrel> Huh? 20180325 23:43:01<+discordbot4> you should be using emplace 20180325 23:43:05<+discordbot4> this is in master 20180325 23:43:17< celticminstrel> Oh, you're right. I forgot. 20180325 23:43:22-!- grzywacz [~karol@89-70-226-147.dynamic.chello.pl] has quit [Remote host closed the connection] 20180325 23:43:46< irker073> wesnoth/wesnoth:master newfrenchy83 9afe9a9849 Update attack_predictions.cpp AppVeyor: vs2017/Release Failed 20180325 23:43:47< irker073> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-master-1934 20180325 23:44:05< celticminstrel> I guess that's one of the downsides of working on 1.14 and then cherry-picking to master. 20180325 23:44:13<+discordbot4> yes 20180325 23:44:17<+discordbot4> sbuilder << _("The game detected the use of a debug command, potentially due to another player cheating."); 20180325 23:44:20<+discordbot4> How does this sound? 20180325 23:44:27< celticminstrel> Sounds good to me. 20180325 23:44:30<+discordbot4> sounds fine 20180325 23:44:49<+discordbot4> (The original was fine but "maybe" sounds a bit too informal for my taste.) 20180325 23:45:03< celticminstrel> Okay the WML test failures are actually timing out... 20180325 23:45:19< celticminstrel> And it appears to be all of them. 20180325 23:45:19<+discordbot4> yes 20180325 23:45:38< celticminstrel> Off the top of my head, the most likely cause for that would be a Lua error in core.lua or some other core Lua file. 20180325 23:46:25< celticminstrel> IOW, just try starting a scenario and the error will likely be instantly clear. Unless it's related to the [variable] commit, then it would take a little more than that. 20180325 23:46:42< celticminstrel> The [variable] commit is code that I tested on 1.13.12 FTR. 20180325 23:46:50< celticminstrel> Though possibly tweaked a little. 20180325 23:46:55< irker073> wesnoth: Charles Dang wesnoth:master 46598681b61d / src/gui/dialogs/attack_predictions.cpp: Fixup 76c2cbac46a6417 https://github.com/wesnoth/wesnoth/commit/46598681b61d1c85b665ca902648b9d587903894 20180325 23:47:09< celticminstrel> The [move_unit] commit on the other hand is a different implementation than I used in 1.13.12. 20180325 23:47:26< celticminstrel> (Since in 1.13.12 it had to be a wrapper of the built-in tag.) 20180325 23:47:44<+discordbot4> seriously. Get VS 2017. 20180325 23:47:49<+discordbot4> This is ridiculous. 20180325 23:48:05< celticminstrel> No. 20180325 23:48:06< gfgtdf> 20180325 23:39:46<+discordbot4> I'm curious exactly what are the consequences of this particular command in MP. 20180325 23:48:17< gfgtdf> shadowm: mp also has campaigns, 20180325 23:48:44<+discordbot4> Then get your damn build with VSCode working. 20180325 23:49:05< celticminstrel> I will, but probably not before next weekend. 20180325 23:49:11< celticminstrel> Not gonna work on it today, at least. 20180325 23:49:37< celticminstrel> So @Vultraz, can you start a scenario without Lua errors? 20180325 23:49:56< celticminstrel> eg, just hit the Tutorial button (it's the easiest way to get into a scenario) 20180325 23:50:19<+discordbot4> i cannot 20180325 23:50:20 * celticminstrel will look over the code for obvious problems... 20180325 23:50:31<+discordbot4> When executing, Lua runtime error: lua/wml/move_unit.lua:20: unexpected symbol near '=' 20180325 23:50:40< celticminstrel> Okay so it's move_unit. 20180325 23:51:23<+discordbot4> yes. 20180325 23:51:31< celticminstrel> Ahah, I see it. It was a typo. 20180325 23:51:48-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 260 seconds] 20180325 23:52:24< irker073> wesnoth: Celtic Minstrel wesnoth:master 4427ee19362b / data/lua/wml/move_unit.lua: Fix typo in 1dd411a84eb6a45c81d14359aaaec7af34351a39 https://github.com/wesnoth/wesnoth/commit/4427ee19362bc739a51945b9f2b2eec59de7010c 20180325 23:54:19< celticminstrel> It's a bit of a pain that an error in any core Lua file causes all the WML tests to time out. It'd be nice if there were a way to detect that and fail early... 20180325 23:55:34< celticminstrel> Like if an empty scenario containing nothing but a start event with an end level tag times out, then it could assume all the tests will similarly time out and consider the entire batch failed. 20180325 23:55:57< celticminstrel> Alternatively, it could do something like give up after n consecutive test timeouts. 20180325 23:56:56< celticminstrel> (I think the former would pretty much always work; generally speaking an error in core Lua means none of the WML tag definitions get added.) 20180325 23:57:14< celticminstrel> (Actually, does that also apply to non-core Lua? I hope not. >_> ) 20180325 23:57:40< celticminstrel> Pretty sure it doesn't though. 20180325 23:59:57<+discordbot4> it's acceptable to use macros in quoted strings right --- Log closed Mon Mar 26 00:00:07 2018