--- Log opened Mon Mar 26 00:00:07 2018 --- Day changed Mon Mar 26 2018 20180326 00:00:07< celticminstrel> As long as they're not translatable. 20180326 00:00:37<+discordbot4> so something like font_size = "(if(hint_text != '', {GUI_FONT_SIZE_SMALL}, {SIZE}))" is fine? 20180326 00:00:59< celticminstrel> Totally. 20180326 00:01:07<+discordbot4> "Several built-in predefined dialogs are now exposed to Lua, including the storyscreen" oooo 20180326 00:01:09< celticminstrel> Aren't there tons of GUI2 formulas that already do that sort of thing? 20180326 00:01:13<+discordbot4> That sounds interesting. 20180326 00:01:28<+discordbot4> I told you about being able to invoke the storyscreen mid-scenario before 😐 20180326 00:01:34< celticminstrel> That said, personally I'd prefer the form where macro substitutions only occur in a where clause. 20180326 00:01:49<+discordbot4> Yes Vultraz, but the entry he added says "several", not just the story screen. 20180326 00:02:03<+discordbot4> I don't know of any others 20180326 00:02:14< celticminstrel> "(if(hint_text != '', small_sz, big_sz) where small_sz = {...}, big_sz = {...})" 20180326 00:02:33< celticminstrel> @shadowm Do you want a list? 20180326 00:03:49< celticminstrel> There's a total of five, though one of those isn't new. 20180326 00:04:17<+discordbot4> Nah I'll look it up later when I actually start working on porting my add-ons 20180326 00:04:31-!- Bonobo [~Bonobo@203.220.138.198] has joined #wesnoth-dev 20180326 00:04:32< celticminstrel> Okay. 20180326 00:04:44<+discordbot4> I know I specifically requested the story screen part because I want to mess with the player. 20180326 00:04:45< celticminstrel> I was contemplating adding a sixth but never got around to it. 20180326 00:04:48<+discordbot4> working on the text box thing as we speak 20180326 00:05:17<+discordbot4> Is the outro screen amongst those by any chance? 20180326 00:05:27<+discordbot4> (The "The End" screen.) 20180326 00:05:29< celticminstrel> No, it's not. I never even thought of it. 20180326 00:06:02<+discordbot4> god dammit, the magnet in my iPad's bezel keeps pulling my pen off the table 20180326 00:06:48< celticminstrel> I did think of supporting the list selector (for example when you use the :choose_level command) and something like JS prompt() 20180326 00:07:30< celticminstrel> I'm not sure if the latter exists as a generic thing in the game though. 20180326 00:07:39< celticminstrel> (There's definitely some dialogs that resemble it.) 20180326 00:07:53< celticminstrel> (For example when adding a new named location in the map editor.) 20180326 00:08:13< celticminstrel> (But I don't know if that's a generic "get some text from the player" dialog or if each use-case uses a separate dialog definition.) 20180326 00:09:08<+discordbot4> i wonder the scope of functions = 20180326 00:09:15< celticminstrel> ? 20180326 00:09:29<+discordbot4> [resolution] functions= 20180326 00:10:17<+discordbot4> our WFL support is so damn primitive >_> 20180326 00:11:24< celticminstrel> I think the scope is the current tag, not including subtags. 20180326 00:11:34< celticminstrel> But, not sure. 20180326 00:11:55<+discordbot4> we need to make WFL strictly-typed 20180326 00:12:09< celticminstrel> Too much effort. 20180326 00:12:14<+discordbot4> why? 20180326 00:12:37< celticminstrel> I also don't think it's really needed. 20180326 00:19:29< celticminstrel> Is there any difference at all between [heals] and [regenerates}? 20180326 00:19:55<+discordbot4> i assume one is for others and one is for yourself 20180326 00:20:34< celticminstrel> The wiki strongly implies they are identical. 20180326 00:20:48< celticminstrel> It doesn't explicitly say so though. 20180326 00:21:19< celticminstrel> Off the top of my head, one thing that would differ is in filters... 20180326 00:21:34< celticminstrel> ie, a troll won't be matched in [heal_unit] as a possible healer unit. 20180326 00:22:26<+discordbot4> celmin: did you add a changelog entry for your last change 20180326 00:22:31-!- travis-ci [~travis-ci@ec2-54-211-39-126.compute-1.amazonaws.com] has joined #wesnoth-dev 20180326 00:22:33< travis-ci> wesnoth/wesnoth#17224 (master - 4427ee1 : Celtic Minstrel): The build passed. 20180326 00:22:33< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/358199302 20180326 00:22:33-!- travis-ci [~travis-ci@ec2-54-211-39-126.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180326 00:23:16<+discordbot4> [heals] is heals+4. It has affect_self=no and affect_adjacent, [regenerates] has affect_self=yes and heal 8 20180326 00:23:31< celticminstrel> If you mean the PR I merged, yes I did. 20180326 00:23:44< celticminstrel> I didn't use his changelog message; I wrote my own. 20180326 00:24:05< celticminstrel> @MiddleTwin - heals+8 is also [heals] 20180326 00:24:40<+discordbot4> oooh i see what you're saying now 20180326 00:25:23< celticminstrel> BTW I made a mistake, it's [regenerate] not [regenerates]. 20180326 00:27:38< celticminstrel> Looks like [regenerate] isn't even checked for units of different sides, so you can't have a [regenerate] ability that affects allies or enemies. 20180326 00:29:13< celticminstrel> ...oh wait, can you use gives_healing to make a terrain that automatically damages people? 20180326 00:29:26< celticminstrel> Or is that a boolean key... 20180326 00:36:06<+discordbot4> I swear, it feels like gettext_boost.cpp takes as long to compile on VS 2017 as the entire remainder of wesnothlib and either campaignd or wesnothd. 20180326 00:38:43<+discordbot4> BLAH 20180326 00:38:49<+discordbot4> use of GUI__FONT_COLOR_DISABLED__DEFAULT is breaking my formula string 20180326 00:38:52<+discordbot4> god damn preprocessor 20180326 00:39:13<+discordbot4> @hrubymar10 will growl notifications be dropped for 1.14 too or only master? 20180326 00:39:39<+discordbot4> 1.14 20180326 00:40:21< celticminstrel> Would be kinda nice if [unit] supported full SLF for specifying location. >_> 20180326 00:40:48< celticminstrel> Oh, I suddenly remembered the WML thing I wanted to do on master. 20180326 00:42:33<+discordbot4> gooddddammmitttt 20180326 00:42:50<+discordbot4> ONE MILLION CURSES UPON THE PREPROCESSOR 20180326 00:43:37<+discordbot4> ONE MILLION YEARS DUNGEON. 20180326 00:44:20<+discordbot4> What 20180326 00:44:39<+discordbot4> What did the preprocessor ever do to you? 20180326 00:44:48< irker073> wesnoth: Severin Glöckner wesnoth:1.14 3e53f63b520d / INSTALL.md: remove outdated information from install.md https://github.com/wesnoth/wesnoth/commit/3e53f63b520d6e34eb29893d12ef6919a5c87ad1 20180326 00:46:37<+discordbot4> the preprocessor cannot handle concatenation of this string for som ereason 20180326 00:47:11< irker073> wesnoth: Severin Glöckner wesnoth:master 409c596fa134 / INSTALL.md: remove outdated information from install.md https://github.com/wesnoth/wesnoth/commit/409c596fa134decdccc9d703468e2ce8d8b81c1e 20180326 00:50:59<+discordbot4> celticminstrel 20180326 00:51:03<+discordbot4> bit misleading, this 20180326 00:51:09<+discordbot4> https://cdn.discordapp.com/attachments/259976436490829825/427630555572731907/unknown.png 20180326 00:51:11<+discordbot4> how should we reword it? 20180326 00:51:18<+discordbot4> specifically, the part about loading a file 20180326 00:51:42<+discordbot4> What is the code you're trying to use that doesn't work as expected? 20180326 00:51:58<+discordbot4> color = "( if(text = '' and hint_text != '', hint_color, reg_color) where hint_color = {__BULLSHIT_PREPROCESSOR_WORKAROUND}, reg_color = {COLOR} ))" 20180326 00:52:24<+discordbot4> I hope you're going to rename that before committing. 20180326 00:52:38<+discordbot4> That's not the full story anyway. What does that macro contain? 20180326 00:52:44< celticminstrel> "Missing value in where expression variable assignment"? 20180326 00:52:56<+discordbot4> what? 20180326 00:52:59<+discordbot4> I posted an image 20180326 00:53:05<+discordbot4> And what is the version that didn't work and led you to come up with the work around? 20180326 00:53:30<+discordbot4> oh wait, I think I know how to fix this... 20180326 00:53:30 * celticminstrel points Vultraz at my response. 20180326 00:53:36<+discordbot4> it's the commas... 20180326 00:53:56< celticminstrel> Maybe if you showed the code that doesn't work? 20180326 00:53:56<+discordbot4> celmin: no, I meant, we should remove the "File you have tried to load is corrupt" bit 20180326 00:54:04< celticminstrel> Uh, sure. 20180326 00:54:25< celticminstrel> That doesn't make any sense. I've never even seen it before? 20180326 00:55:26<+discordbot4> I think the problem has to do with the color values having commas 20180326 00:55:37<+discordbot4> so it thinks each is a where alias 20180326 00:55:44<+discordbot4> just need to wrap them in [] 20180326 00:56:44< celticminstrel> Yeah, uh, commas are never allowed in WFL except: 20180326 00:56:51< celticminstrel> - In lists, ie [] 20180326 00:57:04< celticminstrel> - In functions, ie f() - both definitions and calls 20180326 00:57:08< celticminstrel> - In where clauses 20180326 00:57:11< celticminstrel> (I think that's it) 20180326 00:57:25<+discordbot4> anywya, I still can't use GUI__FONT_COLOR_DISABLED__DEFAULT 20180326 00:57:32< irker073> wesnoth: Celtic Minstrel wesnoth:master e4a2c1417761 / changelog.md data/lua/wml/random_placement.lua: Allow WFL for [random_placement]num_items= https://github.com/wesnoth/wesnoth/commit/e4a2c141776124c4e0b16677265c4623a4a02aad 20180326 00:57:34< celticminstrel> Why not? 20180326 00:57:34< irker073> wesnoth: Celtic Minstrel wesnoth:master 229d2f04831f / changelog.md data/lua/wml/random_placement.lua: Allow percentages in [random_placement]num_items= https://github.com/wesnoth/wesnoth/commit/229d2f04831fc75a154b5b718c7d308fb3d81217 20180326 00:57:35<+discordbot4> even in this context 20180326 00:57:37<+discordbot4> color = "( if(text = '' and hint_text != '', hint_color, reg_color) where hint_color = [" + {GUI__FONT_COLOR_DISABLED__DEFAULT} + "], reg_color = [{COLOR}] )" 20180326 00:57:44<+discordbot4> "Unexpected characters at line start" 20180326 00:57:59<+discordbot4> probably has to do with #arg 20180326 00:58:02<+discordbot4> #define GUI__FONT_COLOR_DISABLED__DEFAULT #arg ALPHA 255#endarg "128, 128, 128, {ALPHA}" #enddef 20180326 00:58:06<+discordbot4> oh wait 20180326 00:58:12<+discordbot4> YOU CAN'T SEE THE CODE SNIPPETS 20180326 00:58:12<+discordbot4> 😐 20180326 00:58:18< celticminstrel> I can see them. 20180326 00:58:23< celticminstrel> But they all run into one line. 20180326 00:59:04< celticminstrel> The definition of the macro should have line breaks before #arg, after #endarg, and after #enddef - no others. 20180326 00:59:24< celticminstrel> In particular, no blank line can be added between #endarg and the string. 20180326 01:00:16<+discordbot4> uh what? 20180326 01:00:21< celticminstrel> IIRC "unexpected characters at line start" means the WML parser was expecting a tag or attribute but found something else. 20180326 01:00:25< celticminstrel> What do you mean what? 20180326 01:00:41< celticminstrel> I can't see where the line breaks are in your snippet so I'm just spelling out where they should be in case it's wrong. 20180326 01:00:41<+discordbot4> oh, you said breaks 20180326 01:00:46<+discordbot4> i thought you meant empty lines 20180326 01:00:55< celticminstrel> Yeah, no empty lines allowed. 20180326 01:03:22< celticminstrel> ...hmm. 20180326 01:03:44< irker073> wesnoth: Severin Glöckner wesnoth:1.14 ae2b875cd40a / INSTALL.md: install.md: cmake version requirement had changed https://github.com/wesnoth/wesnoth/commit/ae2b875cd40aa456be7e854725d0457f21bbc9e9 20180326 01:03:55< celticminstrel> That code I added to random_placement could be moved to wml-utils since it'd be generally useful... though it would need some variation first... 20180326 01:04:11<+discordbot4> please don't commit anything for a few mins 20180326 01:04:14<+discordbot4> do not want t need to rebase 20180326 01:04:50< celticminstrel> @sevu 20180326 01:04:53< celticminstrel> ^ 20180326 01:04:56<+discordbot4> okay 20180326 01:05:18< celticminstrel> Unless it's too late because I committed something? 20180326 01:05:23< celticminstrel> Or did you already deal with that? 20180326 01:05:26<+discordbot4> no it's fine 20180326 01:06:03<+discordbot4> just need to write a long commit message here 20180326 01:06:24< celticminstrel> Ah. 20180326 01:13:08< irker073> wesnoth: Charles Dang wesnoth:master 2b9c7b1abd7f / data/gui/schema.cfg src/gui/core/canvas.cpp src/gui/core/canvas_private.hpp: GUI2/Canvas: allow formula values for [text] font_size= https://github.com/wesnoth/wesnoth/commit/2b9c7b1abd7f881953552dac49d68f2aa5cf2525 20180326 01:13:11< irker073> wesnoth: Charles Dang wesnoth:master db5abb7e637f / / (12 files in 5 dirs): GUI2/Text Box: refactored hint text interface https://github.com/wesnoth/wesnoth/commit/db5abb7e637fd87699fce49a9543faafc3f58068 20180326 01:13:17< irker073> wesnoth: Charles Dang wesnoth:1.14 71d62630877a / data/gui/schema.cfg src/gui/core/canvas.cpp src/gui/core/canvas_private.hpp: GUI2/Canvas: allow formula values for [text] font_size= https://github.com/wesnoth/wesnoth/commit/71d62630877afecc7cfbe431451db96f285c0221 20180326 01:13:20< irker073> wesnoth: Charles Dang wesnoth:1.14 90ea8dcf0d03 / / (12 files in 5 dirs): GUI2/Text Box: refactored hint text interface https://github.com/wesnoth/wesnoth/commit/90ea8dcf0d034850c41735e8279a650ad5745007 20180326 01:13:25<+discordbot4> ok, you guys can commit again 20180326 01:13:27<+discordbot4> thanks for waiting 20180326 01:13:29< celticminstrel> ...formulas weren't allowed before? Huh. 20180326 01:13:30<+discordbot4> @shadowm it is fixed 20180326 01:13:51< celticminstrel> BTW it'd be nice if you'd actually change the schema to f_t_string or whatever as well. 20180326 01:13:57<+discordbot4> OK I'll check it when I'm back at my computer. 20180326 01:14:08< celticminstrel> Technically not necessary, as there's no actually way to distinguish between a general string and a formula string, but... 20180326 01:14:39< celticminstrel> Oh, wait, I misread, ignore that. XD 20180326 01:15:13< irker073> wesnoth: lundberg wesnoth:master a8539cfca0cf / projectfiles/VC14/ (campaignd.vcxproj wesnoth.vcxproj wesnothd.vcxproj wesnothlib.vcxproj): Fix VC warnings about upstream issues https://github.com/wesnoth/wesnoth/commit/a8539cfca0cfd5c79430f430b6f6256987e37c28 20180326 01:15:15-!- gfgtdf_ [~chatzilla@x4e363945.dyn.telefonica.de] has joined #wesnoth-dev 20180326 01:16:00< celticminstrel> FTR, the comment suggests a bug in the #arg implementation. 20180326 01:16:24< celticminstrel> So we should probably look into that as well. 20180326 01:17:33-!- gfgtdf [~chatzilla@x4e363818.dyn.telefonica.de] has quit [Ping timeout: 260 seconds] 20180326 01:17:40-!- gfgtdf_ is now known as gfgtdf 20180326 01:17:47< celticminstrel> We should probably allow functions= in a widget definition, I guess. 20180326 01:17:55<+discordbot4> yes 20180326 01:17:57< celticminstrel> Or in a canvas item definition, even. 20180326 01:18:01<+discordbot4> it doesn't work, so it's commented out 20180326 01:18:50< irker073> wesnoth: Charles Dang wesnoth:1.14 10ae1ec8bbca / src/help/help_topic_generators.cpp: Help: marked "Level" string in unit topic description translatable https://github.com/wesnoth/wesnoth/commit/10ae1ec8bbca78eaba18962caeb6082e0ef64b16 20180326 01:19:54<+discordbot4> My commit 18539cf (above) was to master. If it needs porting to 1.14 let me know. 20180326 01:20:06<+discordbot4> probably 20180326 01:20:20< celticminstrel> No idea. 20180326 01:21:37<+discordbot4> I can't see AppVeyor output for 1.14. If it's getting a bunch of warnings in gettext_boost or simple_wml (or a couple others I don't remember) then I need to port a8539cf 20180326 01:21:44< irker073> wesnoth: Charles Dang wesnoth:master 0a67e9725c02 / src/help/help_topic_generators.cpp: Help: marked "Level" string in unit topic description translatable https://github.com/wesnoth/wesnoth/commit/0a67e9725c02989ed625d527725a5accec4dbdce 20180326 01:21:47< irker073> wesnoth: Charles Dang wesnoth:master b32ccb05dd85 / data/gui/window/help_browser.cfg: Help Browser: increased window height https://github.com/wesnoth/wesnoth/commit/b32ccb05dd858fc904b10b481dae71879ca88e7d 20180326 01:21:58<+discordbot4> we really should go through and clear out all cases where translatable strings have punctuation like : or empty trailing spaces 20180326 01:22:03<+discordbot4> clean up, rather 20180326 01:22:11<+discordbot4> @shadowm and now the help thing is fixed too 20180326 01:23:19<+discordbot4> it's ridiculous that "Level" and "Level: " are cataloged as different strings 20180326 01:23:38< celticminstrel> Tad, I do recall 1.14 getting a bunch of Boost warnings, but I don't recall specifically what they were. 20180326 01:23:45< celticminstrel> @Vultraz I agree. 20180326 01:25:27< irker073> wesnoth: Severin Glöckner wesnoth:master e0c9d7b9f647 / INSTALL.md: install.md: cmake version requirement had changed https://github.com/wesnoth/wesnoth/commit/e0c9d7b9f6479fe028a7613b5f5148ab3b3d4bf6 20180326 01:25:34<+discordbot4> yes 20180326 01:27:22<+discordbot4> celmin: not sure a good way to find them, though 20180326 01:27:54< celticminstrel> ? 20180326 01:27:56<+discordbot4> we'd need a regex 20180326 01:28:07< celticminstrel> Oh, you mean you want to find uses of each one. 20180326 01:28:48< celticminstrel> git grep -E "\"Level(: )?\"" data src 20180326 01:29:09<+discordbot4> to search any string within _() where there are number of empty spaces before the closing quite or a given set of punctuation like : 20180326 01:29:24<+discordbot4> not JUST "level: " 😛 20180326 01:29:39< celticminstrel> Oh, you want any string that ends in an optional colon plus one or more spaces. 20180326 01:29:53<+discordbot4> or begins with spaces too 20180326 01:29:56< celticminstrel> Then "\".*?:? +\"" 20180326 01:30:07<+discordbot4> and not just colons 20180326 01:30:39< celticminstrel> Oh, then "\"*.*?[:!]? +\"" if you want exclamation marks too. 20180326 01:30:49<+discordbot4> hm. maybe... 20180326 01:30:52< celticminstrel> I think you'd need to search separately for trailing and leading space. 20180326 01:31:00<+discordbot4> i dunno. 20180326 01:31:05< celticminstrel> "\" +.*\"" for leading space 20180326 01:31:05<+discordbot4> maybe you could come up with a regex 20180326 01:31:22< celticminstrel> I mean, you can take those to regexes and combine them with | obviously. 20180326 01:31:27< celticminstrel> ^those two 20180326 01:32:04<+discordbot4> but it needs to be between _(" and ") 20180326 01:32:08< celticminstrel> And maybe you want tabs too. 20180326 01:32:20< celticminstrel> So let's see... 20180326 01:32:32<+discordbot4> seriously, you know I cannot do regex 20180326 01:32:44<+discordbot4> I can do * and that's it 😛 20180326 01:33:04< celticminstrel> Leading space in C++: \" +.*?\" 20180326 01:33:07<+discordbot4> inb4 someone "vultraz! how can you bee a successful programmer and not know regex!" 20180326 01:33:18< celticminstrel> Ah wait I forgot the... 20180326 01:33:53< irker073> wesnoth/wesnoth:master newfrenchy83 1c68da5fc1 Update abilities.cpp AppVeyor: 1/2 builds failed 20180326 01:33:54< irker073> Details vs2017/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-master-1931 20180326 01:34:01<+discordbot4> @Tad Carlucci now Warning C4244 '=': conversion from 'std::streamsize' to '::size_t', possible loss of data campaignd c:\users\exodi\documents\wesnoth\src\server\simple_wml.cpp 64 has appeared 20180326 01:34:07< celticminstrel> Leading space in C++ _n?\s*\(\s*\" +.*?\" 20180326 01:34:22< celticminstrel> Wait no. 20180326 01:34:27< celticminstrel> Leading space in C++ _n?\(\s*\" +.*?\" 20180326 01:34:41<+discordbot4> you NEED to use backticks 20180326 01:34:47<+discordbot4> you're writing italic text here 20180326 01:34:51< celticminstrel> Trailing space/punctuation in C++ _n?\(\s*\".*?[:!?]? +\" 20180326 01:34:58< celticminstrel> Then look in the IRC logs. 20180326 01:35:22< celticminstrel> It's not my fault that Discord chose a ridiculous method of representing formatting in a chat program. 20180326 01:35:40<+discordbot4> the code formatting is the same as markdown... 20180326 01:35:47< celticminstrel> That's exactly the problem. 20180326 01:36:00< celticminstrel> Markdown in a chat program is ridiculous IMO. 20180326 01:36:00<+discordbot4> We're not doing the chat platform argument again. 20180326 01:36:10< celticminstrel> Skype's method is much better IMO. 20180326 01:36:23<+discordbot4> @Vultraz Just once? And just in simple_wml? XCode says we have 1.5 Bazzion of that message if you accidentially enable the message. 20180326 01:36:25< celticminstrel> Anyway, that aside... 20180326 01:36:36< celticminstrel> If you combine the last two patterns with | it should work. 20180326 01:36:39<+discordbot4> no, we are not having this argument. I promised I wouldn't go there. But if you insist on arguing about it.. 20180326 01:36:53< celticminstrel> I can also write patterns for cases in WML if you want. 20180326 01:36:59<+discordbot4> all I'm asking is you accommodate us by using backticks. 20180326 01:37:06<+discordbot4> no need to be an ass about it 20180326 01:37:23< celticminstrel> IOW you want to potentially confuse IRC users just so that you can see what I'm writing. 20180326 01:37:41<+discordbot4> oh ffs... 20180326 01:37:46<+discordbot4> @Tad Carlucci 1 20180326 01:37:57<+discordbot4> @Tad Carlucci didn't do a full rebuild though 20180326 01:38:28< celticminstrel> Also, whose brilliant idea was it to have @ pings but also allow spaces in usernames... 20180326 01:38:39<+discordbot4> That thing I just said was directed at the both of you. This is absolutely childish. 20180326 01:39:57<+discordbot4> I didn't see it when building master a while ago. Is it possible there was a commit recently which tickled that warning? IMHO it's better to fix it by using the correct integer type than to cast or suppress, if it's just once. 20180326 01:41:27<+discordbot4> _([^)]*[:!]|? +) might work if you still need a regex 20180326 01:41:58<+discordbot4> oops left a | in there 20180326 01:42:06< celticminstrel> That's more or less what I posted too IIRC, though I used non-greedy dot instead of a character class. 20180326 01:42:12<+discordbot4> doesn't match anything 20180326 01:42:13<+discordbot4> 😦 20180326 01:42:21< celticminstrel> Because of the | 20180326 01:42:38< celticminstrel> Which actually makes the entire expression invalid, come to think of it. 20180326 01:42:42<+discordbot4> yeah 20180326 01:42:42<+discordbot4> it was marked invalid with the | 20180326 01:42:48<+discordbot4> it doesn't match anything without it 20180326 01:43:03<+discordbot4> the | was dumb lol i don't know how it snuck in 20180326 01:43:21< celticminstrel> Oh yeah, you're not explicitly including the \" like I did... 20180326 01:43:38<+discordbot4> oh yeah 20180326 01:43:51< celticminstrel> (BTW, random aside, did you guys know you can escape special characters in markdown, eg, \`like this\`?) 20180326 01:44:09< celticminstrel> (Also heh, the `? tried to turn into ʔ) 20180326 01:44:18<+discordbot4> not even seeing that as formatting here 20180326 01:44:26<+discordbot4> i just posted it unformatted to discord, then edited the message into discord-friendly format XD 20180326 01:44:41<+discordbot4> IIRC you can escape with \ 20180326 01:44:47< celticminstrel> Yes, that was my point. 20180326 01:53:30<+discordbot4> https://cdn.discordapp.com/attachments/259976436490829825/427646242680733696/unknown.png 20180326 01:53:37<+discordbot4> Think the spacing looks better now? 20180326 01:53:56< celticminstrel> Looks good to me. 20180326 01:54:08<+discordbot4> got results with grep -R -P --include=".cpp" --include=".hpp" '_("[^)]*[:!]")' 20180326 01:54:20<+discordbot4> Not sure we need to say "The game" 20180326 01:54:47<+discordbot4> looks good 20180326 01:54:55<+discordbot4> "The use [...] was detected" also seems acceptable 20180326 01:56:22<+discordbot4> How do I trigger intentional OOS now :/ 20180326 01:56:26<+discordbot4> xD 20180326 01:56:38< celticminstrel> Isn't there a debug command for that or something 20180326 01:56:43<+discordbot4> I wanted to compare with the OOS dialog but if all debug commands are synced then how am I supposed to do it? 20180326 01:56:46<+discordbot4> What is a bit unclear to me - why save the game in this case? 20180326 01:57:05<+discordbot4> Because it's the OOS dialog, which offers the option to do that. 20180326 01:57:07< celticminstrel> I mean, I thought there was a debug command specifically for triggering an OOS error. 20180326 01:57:27<+discordbot4> It's just passed a different text for this particular usage. 20180326 01:58:14<+discordbot4> What would the command be celticminstrel? 20180326 01:58:32< celticminstrel> I'm curious, does the saved game from that dialog include the outcome of the debug command? 20180326 01:58:37< gfgtdf> the lua console can still do unsynced things so you can use that to create an oos. 20180326 01:58:57<+discordbot4> Need a quick example because I'm lazy. 20180326 01:59:04<+discordbot4> or use an add-on with an [advancefrom] on one client 20180326 01:59:15<+discordbot4> and eventually as debug command the one to advance 20180326 01:59:30< gfgtdf> wesnoth.put_unit(4,5,{side=1, type="Knight"}) should work, not tested. 20180326 01:59:44<+discordbot4> So you get both, OOS and debug message 20180326 01:59:45< gfgtdf> and thne move to that hex with another client 20180326 02:00:11<+discordbot4> https://cdn.discordapp.com/attachments/259976436490829825/427647925825437708/unknown.png 20180326 02:00:13< celticminstrel> Hmm, I'm not seeing it in menu_events.cpp... 20180326 02:00:21<+discordbot4> (You'll note I'm so lazy I chose the worst map for a test.) 20180326 02:00:34<+discordbot4> agh 20180326 02:00:39<+discordbot4> so much excess space! 20180326 02:01:01<+discordbot4> unnecessary comma in the first sentence 20180326 02:01:08<+discordbot4> Probably because the dialog is passed a string with a trailing newline that follows a concatenation of a string (probably intended for the console log) that already has a trailing newline. 20180326 02:01:14< celticminstrel> Oh, why are the buff and unbuff commands commented out? :O 20180326 02:01:14<+discordbot4> I know it's not part of the dialog itself, at least 20180326 02:01:27<+discordbot4> the text isn't logical... 20180326 02:01:38< celticminstrel> Oh, so I can view terrain codes in-game? 20180326 02:01:45<+discordbot4> it says there are a number of reason and then lists only one... 20180326 02:01:53<+discordbot4> @Vultraz Too late. File a bug for 1.14.1. 20180326 02:01:58< gfgtdf> i think i used the singeplayer version of the oos dialog (used in replays) as a template when doing the debug notification dialog 20180326 02:02:19< gfgtdf> which looks a bit differnt 20180326 02:02:32<+discordbot4> I'll fix the text in master and open a backport reminder 20180326 02:02:51<+discordbot4> https://cdn.discordapp.com/attachments/259976436490829825/427648599610884106/unknown.png 20180326 02:02:53< celticminstrel> BTW, do we have a way to register new console commands from Lua? 20180326 02:03:11<+discordbot4> no.. 20180326 02:03:21<+discordbot4> Beware that IIRC there are two or three possible ways to get the OOS dialog besides the new addition of the debug command warning. 20180326 02:03:21<+discordbot4> why the hell do you want to customize ALL THE THINGS 20180326 02:03:22< gfgtdf> no, but i think we haeva feature request for that. 20180326 02:03:31< celticminstrel> Do we? Alright, I won't open one then. 20180326 02:03:41<+discordbot4> It is possible to make aliases without Lua. 20180326 02:03:51< celticminstrel> Yeah, I saw there was an alias command built-in. 20180326 02:03:59<+discordbot4> agh, my neck hurts 20180326 02:04:02< celticminstrel> Are all those commands actually documented... 20180326 02:04:02<+discordbot4> so much hunching over laptop 20180326 02:04:03<+discordbot4> summon="lua wesnoth.wml_actions.animate_unit({ { 'filter', { type='Demon Hellbent Tide' } }, with_bars = false, flag='e3s5_cutscene' }) wesnoth.delay(10)" 20180326 02:04:20< gfgtdf> celticminstrel: https://github.com/wesnoth/wesnoth/issues/1408 20180326 02:04:23<+discordbot4> I think I needed that to test the animation in question over and over to get the timings right. 20180326 02:04:35<+discordbot4> Also superhp="unit hitpoints=1000" 20180326 02:04:42< celticminstrel> I'm no t wuite sure but I suspect some aren't. 20180326 02:05:21<+discordbot4> ow ow ow 20180326 02:05:30<+discordbot4> The OOS message has a few issues now that I read it in detail, yeah. 20180326 02:05:39<+discordbot4> "Game settings" should be "game files" instead. 20180326 02:06:51<+discordbot4> And actually the most likely reason is that the players have conflicting add-ons 20180326 02:06:53<+discordbot4> I think I'll add a trailing newline to the debug command warning to separate the details area from the buttons below. 20180326 02:07:02<+discordbot4> Or different versions of the add-ons. 20180326 02:10:08<+discordbot4> Hmmmm. 20180326 02:10:14<+discordbot4> Was the Clearing Gushes map in 1.12? 20180326 02:10:24<+discordbot4> no 20180326 02:10:36<+discordbot4> More stuff for the announcement outline then :p 20180326 02:10:42<+discordbot4> something ot mention in the announcement 20180326 02:10:43<+discordbot4> new mp maps 20180326 02:10:51<+discordbot4> there are several 20180326 02:11:02<+discordbot4> ~10 20180326 02:12:50<+discordbot4> Also, I believe (gfgtdf may be able to confirm) from looking at the code, that the saved game produced at this point is before the synced debug command is actually executed on your side. 20180326 02:12:58-!- Bonobo [~Bonobo@203.220.138.198] has quit [Ping timeout: 260 seconds] 20180326 02:13:11<+discordbot4> If this is correct, I wonder if that might be worth mentioning in the text? 20180326 02:13:43-!- Bonobo [~Bonobo@203.220.138.198] has joined #wesnoth-dev 20180326 02:13:43< irker073> wesnoth: Charles Dang wesnoth:master 34797ed1a26d / / (19 files in 6 dirs): Removed or commented out (for reference) all uses of the GUI1 button widget https://github.com/wesnoth/wesnoth/commit/34797ed1a26d23b40e3c43a9a6609a61d9389b29 20180326 02:13:46<+discordbot4> @hrubymar10 could you update the xcode file 20180326 02:14:05< gfgtdf> yes the save is from before the debug command is executed. 20180326 02:14:52<+discordbot4> There are a few things which I do not like about the OOS dialogue. 20180326 02:15:33<+discordbot4> First of all, the text seems to target to detect cheaters, but that's 99% of the time wrong 20180326 02:16:43< gfgtdf> although the replay entry for that debug_command will probably be in that savefile. so if you continue playing from that savefile, the replay of that game might be broken. 20180326 02:17:19<+discordbot4> And It's not clear what the purpose is to save the game. Most players have autosaves turned on (and the ones who don't probably don't see an OOS the first tinme). 20180326 02:18:30<+discordbot4> I believe the intention is for players to post the save when reporting bugs. 20180326 02:19:20<+discordbot4> Also, as you said, most players have autosaves turned on. Not all of them — a few turn them off or cap them down deliberately to resist the temptation to reload. 20180326 02:19:48< celticminstrel> Is there any GUI1 left now? 20180326 02:20:00< celticminstrel> Oh, I can see widget.hpp is still there... 20180326 02:20:01<+discordbot4> The Help browser? 20180326 02:20:07< celticminstrel> I mean in master. 20180326 02:20:15<+discordbot4> Is it converted in master already? 20180326 02:20:18< celticminstrel> Yup. 20180326 02:20:20<+discordbot4> partly 20180326 02:20:25<+discordbot4> it like 20180326 02:20:29<+discordbot4> 40% works 20180326 02:20:31< celticminstrel> Though missing one or two features IIRC. 20180326 02:20:37<+discordbot4> many features 😛 20180326 02:20:44< celticminstrel> And possibly a little broken by accelerated_rendering. 20180326 02:20:55<+discordbot4> dunno why topics aren't expanding right now, though 20180326 02:21:01< celticminstrel> @Vultraz, the original PR only missed a few features, so um. 20180326 02:21:01<+discordbot4> anyway, yes, there is some GUI1 20180326 02:21:05<+discordbot4> related to the editor 20180326 02:21:08< celticminstrel> If it's missing many features now, then... 20180326 02:21:19< celticminstrel> It's some problem since master diverged. 20180326 02:21:26< celticminstrel> Or I guess I should say since 1.14 diverged. 20180326 02:21:51< celticminstrel> So yeah, the help browser in master is GUI2 but it has not quite reached feature-parity with the GUI1 browser. 20180326 02:22:04<+discordbot4> Colour me unsurprised. 20180326 02:22:18<+discordbot4> it's low priority 20180326 02:22:20< celticminstrel> I'll probably work on some things there at some point. 20180326 02:22:23<+discordbot4> we have all of 1.16 to fix it 20180326 02:22:38<+discordbot4> Then Vultraz got hit by a bus. 20180326 02:22:45< celticminstrel> It's not really a priority until whenever you want to release 1.15.0 at the earliest. 20180326 02:22:59<+discordbot4> A bunch of developers who had little to no idea what his plan was were left to pick the pieces up and try to make sense of them. 20180326 02:23:06<+discordbot4> The pieces of his code, not the pieces of his body. 20180326 02:23:10< celticminstrel> More my plan than his though. 20180326 02:23:10<+discordbot4> P_P 20180326 02:23:45< celticminstrel> That said, I'm not looking forward to working with Pango, so that's why there's an issue open about this. 20180326 02:23:52<+discordbot4> hmm, if you keep the "save game" headline in the debug OOS, maybe it should be mentioned in the text like in the other OOS dialoge. Though, I prefer your new text way more - it's just the heading line isn't explained 20180326 02:23:58< celticminstrel> I did get started on it awhile back, though I never got that far. 20180326 02:24:06<+discordbot4> Do you plan to use Pango's API for manually parsing the entire markup? 20180326 02:24:28< celticminstrel> Probably something like that? 20180326 02:24:37< celticminstrel> Basically we need to extend the markup to add more features. 20180326 02:24:42<+discordbot4> the neat thing about your debug OOS is that it doesn't give a wall of text with not fitting info 20180326 02:24:46<+discordbot4> i mean, stuff like can be converted to 20180326 02:24:59< celticminstrel> So if that means we need to reimplement the built-in Pango stuff, then it's unfortunate, but that's what we'll have to do. 20180326 02:25:05<+discordbot4> Because it does have that, but last time I checked (id est, several years ago) 1) it wasn't documented; 2) the devs admitted it was incredibly difficult to use. 20180326 02:25:27< celticminstrel> The issue in question: https://github.com/wesnoth/wesnoth/issues/2687 20180326 02:25:29<+discordbot4> It's mostly the links and embedded images that you need to be concerned about. 20180326 02:25:45<+discordbot4> links we can do 20180326 02:25:47< celticminstrel> If we can use the built-in Pango markup parsing and add additional features on top of that, that would be preferred. 20180326 02:25:51<+discordbot4> embedded images.. 20180326 02:25:52<+discordbot4> harder 20180326 02:25:55<+discordbot4> @sevu There's no API to set the dialog's caption right now I don't think. 20180326 02:25:55< celticminstrel> We already do links, so that just needs to be generalized. 20180326 02:26:00< celticminstrel> I assume. 20180326 02:26:01<+discordbot4> yes 20180326 02:26:04< celticminstrel> I haven't looked closely at it. 20180326 02:26:27<+discordbot4> bool savegame::save_game_interactive(const std::string& message, DIALOG_TYPE dialog_type) 20180326 02:26:33< celticminstrel> There is an API in Pango IIRC to set a text wrapping shape, so that's probably what'll need to be done for images. 20180326 02:26:37<+discordbot4> It's not exactly the greatest signature to work with 20180326 02:27:06<+discordbot4> now sush, I'm getting rid of the SDL_TTF/GUI1 rendering API 20180326 02:27:17< gfgtdf> the dialog type prameter is ignored for oos savegames iirc. 20180326 02:27:21<+discordbot4> class game_save_message : public modal_dialog { public: game_save_message(std::string& filename, const std::string& title, const std::string& message); 20180326 02:27:57<+discordbot4> Hang on 20180326 02:28:03<+discordbot4> I lost track of where the title comes from. 20180326 02:28:31<+discordbot4> @shadowm just a note that if you happen to end up with a single display or execute function with no overloads that just forwards argument to the ctor, please use DEFINE_SIMPLE_DISPLAY_WRAPPER(class name) or DEFINE_SIMPLE_EXECUTE_WRAPPER(class name) 20180326 02:28:37<+discordbot4> Uggggggggghhhhhh inheritance. 20180326 02:28:43<+discordbot4> Object-oriented programming. YAY 20180326 02:28:44<+discordbot4> They're variaidic template macros 20180326 02:29:14<+discordbot4> @Vultraz You'll need to tell me that at some later point if I end up writing a GUI2 dialog in the future again. 20180326 02:30:27<+discordbot4> Wh 20180326 02:31:51<+discordbot4> I really can't keep track of where the title comes from or where it is even used. 20180326 02:32:13< gfgtdf> https://github.com/wesnoth/wesnoth/blob/master/src/savegame.cpp#L624 20180326 02:32:24< gfgtdf> https://github.com/wesnoth/wesnoth/blob/master/src/savegame.cpp#L611 20180326 02:32:44<+discordbot4> Okay, so there isn't a method to override it after construction yet? 20180326 02:32:59< gfgtdf> not that i know of 20180326 02:33:19<+discordbot4> What would an appropriate caption for this prompt be anyway? 20180326 02:33:22< gfgtdf> but i didn't wrote that code so 20180326 02:33:40<+discordbot4> "Debug Command Detected"? 20180326 02:33:47<+discordbot4> "Cheat Warning!" 20180326 02:33:57<+discordbot4> former 20180326 02:34:01<+discordbot4> "You Have A Hacker In Your Game!" 20180326 02:34:12<+discordbot4> "The Russians are hacking your game" 20180326 02:34:20<+discordbot4> Debug Command Detected is quite a mouthful, though. 20180326 02:34:28<+discordbot4> "Comando de depuración detectado" 20180326 02:37:50< irker073> wesnoth/wesnoth:master newfrenchy83 76c2cbac46 Implement [filter_weapon] in leadership AppVeyor: 2/4 builds failed 20180326 02:37:51< irker073> Details vs2017/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-master-1933 20180326 02:37:52< irker073> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-2227 20180326 02:38:43<+discordbot4> Okay, let's backtrack a bit. 20180326 02:38:57<+discordbot4> I had this, but Vultraz says "the game" is redundant: _("The game detected the use of a debug command, potentially due to another player cheating.") 20180326 02:39:39<+discordbot4> How about: _("A debug command was used in the game. If this is not expected, it means the player in question is cheating.") 20180326 02:40:21<+discordbot4> Change "is cheating" to "may be cheating" and it's better 20180326 02:40:36<+discordbot4> There is literally no other way you'll see this happen otherwise. 20180326 02:40:54<+discordbot4> People don't just "accidentally" turn debug mode on, since they have to do so in the command line. 20180326 02:41:21<+discordbot4> Windows and macOS users in particular won't ever do that unintentionally. 20180326 02:42:06<+discordbot4> But one might do it out of curiosity and no ill intent 20180326 02:42:29<+discordbot4> In a multiplayer game? 20180326 02:42:32<+discordbot4> No. 20180326 02:43:15<+discordbot4> One does not see a command to create a unit and use it without being fully aware of the fact that it alters the state of the game in a way that is not legit. 20180326 02:43:37<+discordbot4> At least not anyone who should be allowed to operate a computer with access to the Internet. 20180326 02:43:50<+discordbot4> whatever. it 20180326 02:44:48<+discordbot4> I'll commit the rest of the changes while we continue deliberating the description text and the need to add an API to set the caption. 20180326 02:45:11-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20180326 02:45:11<+discordbot4> I keep causing my entire desktop to freeze when I ctrl+c Wesnoth, huh. 20180326 02:46:00<+discordbot4> Previously debug was causing OOS, and now it works but gives the warning? This might be sth for Coop games.... The AI crushes us - let's cheat some units 20180326 02:47:53<+discordbot4> That's more or less why I proposed the "expected" wording. 20180326 02:48:07<+discordbot4> Although what I had in mind was more like collaborative testing/development of maps. 20180326 02:48:51<+discordbot4> Like, "hi would you like to help me test this map? beware i might need to use debug mode a few times because of some bugs in it". 20180326 02:49:15<+discordbot4> Or "oops an event didn't fire, i'll have to do it by hand". 20180326 02:51:49<+discordbot4> src/editor/palette/location_palette.cpp: In member function ‘virtual void editor::location_palette::adjust_size(const SDL_Rect&)’: src/editor/palette/location_palette.cpp:225:12: error: unused variable ‘button_height’ [-Werror=unused-variable] const int button_height = 22; ^~~~~~~~~~~~~ src/editor/palette/location_palette.cpp:226:12: error: unused variable ‘button_y’ [-Werror=unused-variable] const int 20180326 02:51:49<+discordbot4> button_y = 30; ^~~~~~~~ cc1plus: all warnings being treated as errors scons: *** [build/release/editor/palette/location_palette.o] Error 1 20180326 02:52:10<+discordbot4> 23:50:55 shadowm@hanacore ~/src/wesnoth git:master % scons -j16 strict=no 2 :( 20180326 02:52:41<+discordbot4> 16 cores? o.O 20180326 02:52:50<+discordbot4> No, 4 cores, 8 threads. 20180326 02:53:17<+discordbot4> I just fully trust my platform's scheduler to deal with it, plus I have too much RAM. 20180326 02:53:47<+discordbot4> Not all C++ files are born equal after all, a few take considerably less time to compile. 20180326 02:54:11<+discordbot4> @Vultraz So I take it you haven't got your warnings sorted out yet? 20180326 02:54:15-!- gfgtdf [~chatzilla@x4e363945.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.93 [Firefox 52.7.2/20180315163333]] 20180326 02:54:25<+discordbot4> guess not 20180326 02:55:41<+discordbot4> would you mind holding off on committing to master for a few mins 20180326 02:55:55<+discordbot4> have a huge-ass commit removing the SDL_TTF stuff coming 20180326 02:55:58<+discordbot4> Yes, I would mind. 20180326 02:56:03<+discordbot4> I have a commit pending. 20180326 02:56:25<+discordbot4> does it touch Many Things? 20180326 02:56:34<+discordbot4> Literally only one file and nothing to do with SDL_ttf. 20180326 02:56:43<+discordbot4> ok 20180326 02:56:52<+discordbot4> then please commitit 20180326 02:57:16<+discordbot4> I'm waiting to make sure the build passes since I ported it from 1.14. 20180326 02:57:41<+discordbot4> I swear, it's like master is twice as large as 1.14. 20180326 02:57:53<+discordbot4> Has anyone build Release for Visual Studio on 1.14 recently? 20180326 02:57:56<+discordbot4> And 1.14 twice as large as 1.12. And 1.12 twice as large as 1.10. And 20180326 02:58:04<+discordbot4> which doesn't make sense since I'm ripped thousands of lines of code out 20180326 02:58:13<+discordbot4> There 20180326 02:58:14< irker073> wesnoth: Iris Morelle wesnoth:master ab67b402d144 / src/synced_commands.cpp: Let synced debug command notifications be localized, fix them up a bit https://github.com/wesnoth/wesnoth/commit/ab67b402d1449384c12564e6a6a1d79a4bfb7e14 20180326 02:58:19< irker073> wesnoth: Iris Morelle wesnoth:1.14 5cdd9e4b822d / src/synced_commands.cpp: Let synced debug command notifications be localized, fix them up a bit https://github.com/wesnoth/wesnoth/commit/5cdd9e4b822db73e82d4432432eda1a6c33b2127 20180326 03:01:54<+discordbot4> I'm doing a test-build Release and Debug for my last commit to see if it clears all the remaining warnings from 1.14 as well. Looks good but still running. But when Release ran WML tests I got 137 failures out of 168 tests. 20180326 03:02:53<+discordbot4> Not timeouts like I saw on master, all "returned 1, expected 0" 20180326 03:03:54<+discordbot4> have :choose_level and :inspect been forgotten for this dialogue? 20180326 03:04:30<+discordbot4> Vultraz. 20180326 03:04:46<+discordbot4> si? 20180326 03:05:00<+discordbot4> Wait, never mind, I have an outdated 1.14 build. 20180326 03:05:29<+discordbot4> The Search box thing means that the game will CTD when firing up a dialog with a text box unless the engine is at that commit or later. 20180326 03:06:05<+discordbot4> Worth noting for anyone who might not expect that to happen. 20180326 03:06:51<+discordbot4> Wait what was I testing 20180326 03:07:22<+discordbot4> Yeah, :inspect doesn't generate any warnings gfgtdf. 20180326 03:07:53<+discordbot4> :choose_level generates the same warning as :n though. 20180326 03:08:51<+discordbot4> "24 files changed, 241 insertions(+), 1878 deletions(-)" 20180326 03:08:52<+discordbot4> 👌 20180326 03:09:14< celticminstrel> Don't look smug just because you're deleting stuff. >_> 20180326 03:09:27< celticminstrel> Tad, which tests are failing? 20180326 03:09:45<+discordbot4> 137 of 168 WML tests 20180326 03:09:59< celticminstrel> I mean like the names of one or two failing tests. 20180326 03:10:16< celticminstrel> Ideally we'd see the log output too... 20180326 03:10:32<+discordbot4> . WML_tests.cmd : error WML1: Test 'test_basic_composite_aspect' returned 1, expected 0 . WML_tests.cmd : error WML1: Test 'test_basic_lua_aspect' returned 1, expected 0 . WML_tests.cmd : error WML1: Test 'test_basic_composite_facet' returned 1, expected 0 . WML_tests.cmd : error WML1: Test 'test_basic_lua_facet' returned 1, expected 0 . WML_tests.cmd : error WML1: Test 'test_basic_composite_default_facet' returned 1, 20180326 03:10:33<+discordbot4> expected 0 . WML_tests.cmd : error WML1: Test 'test_basic_lua_default_facet' returned 1, expected 0 . WML_tests.cmd : error WML1: Test 'test_modify_ai_delete_facet' returned 1, expected 0 20180326 03:10:54<+discordbot4> But at this failure rate, pick one, chances are it failed. 20180326 03:10:56< celticminstrel> Hmm, a bunch of AI tests, huh... 20180326 03:11:03<+discordbot4> Nah 20180326 03:11:10<+discordbot4> Just a random scroll back 20180326 03:11:14<+discordbot4> return faules 20180326 03:11:18<+discordbot4> assert failes 20180326 03:11:18< celticminstrel> But I don't think there's 137 AI tests, so it's probably not something in the AI tests specifically. 20180326 03:11:25<+discordbot4> sounds like all of them failed, some of them just expect failure 20180326 03:11:34< celticminstrel> Hmm. 20180326 03:11:41< celticminstrel> An interesting thought. 20180326 03:11:43-!- travis-ci [~travis-ci@ec2-54-211-39-126.compute-1.amazonaws.com] has joined #wesnoth-dev 20180326 03:11:44< travis-ci> wesnoth/wesnoth#17232 (master - ab67b40 : Iris Morelle): The build is still failing. 20180326 03:11:44< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/358229647 20180326 03:11:44-!- travis-ci [~travis-ci@ec2-54-211-39-126.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180326 03:11:44<+discordbot4> well you said the same thing about master 165 of 168 failing 20180326 03:11:57< celticminstrel> Well, master was an error in core Lua. 20180326 03:12:08< celticminstrel> Is it possible that's the issue here too? 20180326 03:12:08<+discordbot4> timeout failure is different from regular failure 20180326 03:12:10<+discordbot4> And master is all timeout failures 20180326 03:12:14< celticminstrel> Ah, right, true. 20180326 03:12:22< celticminstrel> I don't think that could be a Lua problem then. 20180326 03:12:39<+discordbot4> Dunno . All I care about is that I get no errors and no warnings and I'm pushing up the commit 20180326 03:12:56< celticminstrel> Tad, I fixed the timeout failures on master though. 20180326 03:13:24<+discordbot4> Not been looking since I'm checking the conflict resolution for my commit is good. 20180326 03:18:00<+discordbot4> @sevu To be fair, :inspect doesn't offer anything to players that loading a save on another session doesn't. 20180326 03:18:19<+discordbot4> I'm going to check now but I suspect the Lua console is covered by :lua. 20180326 03:19:31<+discordbot4> Hmm. 20180326 03:19:42<+discordbot4> Okay, nope, the Lua console is not checked. 20180326 03:19:43<+discordbot4> celticminstrel: it's cathartic, really, to clear out all this mess 20180326 03:21:33<+discordbot4> On the other hand, I don't seem to be able to actually wesnoth.put_unit with it? I don't see the unit I'm purportedly creating. 20180326 03:21:57<+discordbot4> are you using unit, x, y 20180326 03:22:05<+discordbot4> the parameters switched in 1.13 20180326 03:22:31<+discordbot4> I was using this: wesnoth.put_unit(4,5,{side=1, type="Knight"}) should work, not tested. 20180326 03:22:49< celticminstrel> BTW, does anyone think attribute amendment would be a good feature in WML 20180326 03:22:54< celticminstrel> my_key=thing 20180326 03:22:58< celticminstrel> my_key+=stuff 20180326 03:23:07< celticminstrel> config["my_key"] then returns "thingstuff: 20180326 03:24:16<+discordbot4> if my_key is a message and we're building up bit by bit, maybe 20180326 03:24:48<+discordbot4> You'll have to convince me with more elaborate use cases. 20180326 03:25:02<+discordbot4> Not that you need to convince me, mind you. 20180326 03:25:56<+discordbot4> I used wesnoth.sides[1].fog = false and wesnoth.redraw({ side = 1 }) and only the latter seemed to have any effect at all. 20180326 03:26:39<+discordbot4> Oh wait, fog is not a field for those. 20180326 03:26:50<+discordbot4> Wait, it is, I'm reading the wiki wrong. 20180326 03:27:07<+discordbot4> That should disable fog for side 1 but it's not doing anything at all? 20180326 03:27:17<+discordbot4> celmin ^ 20180326 03:27:46<+discordbot4> (I'm trying to see what happens when using the Lua Console to do things in MP.) 20180326 03:27:54< irker073> wesnoth: lundberg wesnoth:1.14 6a91de417a93 / projectfiles/VC12/ (campaignd.vcxproj wesnoth.vcxproj wesnothd.vcxproj wesnothlib.vcxproj): Fix VC warnings about upstream issues https://github.com/wesnoth/wesnoth/commit/6a91de417a93ad83e79b1eae47182b06b7951c16 20180326 03:29:58<+discordbot4> I now get both master and 1.14, using VS 2017, no error no warning release or debug as of recent commits today. 20180326 03:30:31<+discordbot4> Switching to Linux to check WML tests for 1.14 there 20180326 03:36:54<+discordbot4> I am needs more ram 20180326 03:37:25< irker073> wesnoth: Charles Dang wesnoth:master c198be1fa8c6 / / (25 files in 8 dirs): Removed the SDL_TTF and GUI1 font rendering API and associated functions https://github.com/wesnoth/wesnoth/commit/c198be1fa8c62265e496c135c6ee324404e8dcd9 20180326 03:37:28< irker073> wesnoth: Charles Dang wesnoth:master c453a97dacce / src/sdl/ (utils.cpp utils.hpp): Removed custom blit_surface function https://github.com/wesnoth/wesnoth/commit/c453a97dacce917b957fe10133a6aea1e6cec34a 20180326 03:37:31< irker073> wesnoth: Charles Dang wesnoth:master b08fa982600c / src/ (editor/palette/tristate_button.cpp video.cpp video.hpp): Removed CVideo::blit_surface https://github.com/wesnoth/wesnoth/commit/b08fa982600c82e258dfd555c2cf170e0a623539 20180326 03:37:33<+discordbot4> I have 4 x 4 GB DDR3 sticks that are currently sitting in a corner gathering dust. 20180326 03:37:34< irker073> wesnoth: Charles Dang wesnoth:master 8b6270f92f17 / src/ (editor/palette/location_palette.cpp help/help_impl.cpp): Fix some unused parameter warnings caused by recent commits https://github.com/wesnoth/wesnoth/commit/8b6270f92f178ad10189a278ab19b8405dfa1eea 20180326 03:37:45<+discordbot4> can someone update CMake and Scons to remove SDL_TTF as a dependency? 20180326 03:37:46<+discordbot4> They're regular DIMM though, not SODIMM. 20180326 03:38:07<+discordbot4> At least last time I checked you were still using a laptop. 20180326 03:38:12<+discordbot4> Yes. 20180326 03:38:36<+discordbot4> 16 GB of RAM 20180326 03:39:07<+discordbot4> That's enough for this. 20180326 03:39:18<+discordbot4> and an i7 7500U @ 2.7 GhZ 20180326 03:39:26<+discordbot4> Unless you have more than 4 cores/8 threads. 20180326 03:39:39<+discordbot4> It's only 2/4 20180326 03:39:48<+discordbot4> Then you shouldn't have any trouble. 20180326 03:40:01<+discordbot4> I never ran out of RAM building Wesnoth on my previous desktop, even while running Windows VMs. 20180326 03:40:05<+discordbot4> Compile times seem longer than when I first bought this a year ago 20180326 03:40:35<+discordbot4> https://cdn.discordapp.com/attachments/259976436490829825/427673195890343956/unknown.png 20180326 03:41:11<+discordbot4> What do Yes and No mean? 20180326 03:41:34<+discordbot4> That made more sense with the Save Game caption... 20180326 03:41:37<+discordbot4> I can see Quit Game and Continue Game 20180326 03:41:49<+discordbot4> you can drop "that" and what about saying "during" instead of "in" 20180326 03:42:02<+discordbot4> Yes is really Save and No is really Cancel. But the code isn't designed for that right now. 20180326 03:42:40<+discordbot4> In order to add that I would have to dig really deep into the code across several classes. 20180326 03:42:59<+discordbot4> I think "during" is better. 20180326 03:43:00<+discordbot4> last thing we want 20180326 03:43:36<+discordbot4> Mostly because for some reason, savegame has a DIALOG_TYPE enum and that's an option in some paths. 20180326 03:43:38<+discordbot4> agree drop "than" from "that the playher" 20180326 03:43:41<+discordbot4> It's either YES_NO or OK_CANCEL. 20180326 03:44:40<+discordbot4> There are at least 3 users of OK_CANCEL. 20180326 03:44:50< celticminstrel> The DIALOG_TYPE enum is meant for the generic message box, I think (gui2::show_transient_message). 20180326 03:44:55<+discordbot4> And another 3 of YES_NO. 20180326 03:45:15<+discordbot4> When is that ever used by savegame and its subclasses though? 20180326 03:45:38< celticminstrel> No idea? I assume it's just being reused by another dialog. 20180326 03:45:56<+discordbot4> There's a dedicated dialog for the savegame family. 20180326 03:46:10<+discordbot4> Well, three of them to be precise. game_save, game_save_message, and game_save_oos. 20180326 03:46:59<+discordbot4> _("A player used a debug command during the game. If this is unexpected, it is possible the player in question is cheating.") 20180326 03:47:09<+discordbot4> 👍 20180326 03:47:16<+discordbot4> @Vultraz While I was compiling 1.14 on VS 2017 a bit ago I had system monitor up. With 4 threads the highest I saw memory go was about 4G of the 8G I gave the VM. 20180326 03:50:24<+discordbot4> Actually, the Yes/No labels are defined by WML. 20180326 03:50:50<+discordbot4> There's nothing in the dialog's implementation replacing them. 20180326 03:52:00<+discordbot4> This goes for all three dialogs. So I could potentially replace that with Save/Cancel depending on whether I can trace down all their users and ensure the button labels will be coherent with all the potential messages. 20180326 03:53:08<+discordbot4> Hmm. Whatever is causing the WML test failures, it's local to Windows. I'm getting no failures at all for 1.14 on Linux 20180326 03:53:17<+discordbot4> I think regardless of what the next question is whether to explain why the option to save is being offered or just leave it alone. 20180326 03:53:22<+discordbot4> *that 20180326 04:00:40< irker073> wesnoth: Charles Dang wesnoth:master ecab22e6aaf2 / data/core/ (editor/help.cfg help.cfg): Help: replaced custom and formatting tags with Pango equivalents https://github.com/wesnoth/wesnoth/commit/ecab22e6aaf295437da7993622ce74488d467530 20180326 04:01:11< celticminstrel> I consider that entirely pointless at this stage, but whatever. 20180326 04:01:25<+discordbot4> What do you consider pointless? 20180326 04:01:31< celticminstrel> They're already translated into Pango markup anyway, and it's not like you can just skip the translation stage. 20180326 04:01:38< celticminstrel> Vultraz's commit. 20180326 04:02:51< celticminstrel> In other news, the definition of the [aspect] tag is in fact recursive... I'm having trouble representing it in the schema... 20180326 04:06:27< irker073> wesnoth: Charles Dang wesnoth:master 73d0bf10c313 / data/core/ (editor/help.cfg help.cfg): Help: replaced custom
formatting tag with https://github.com/wesnoth/wesnoth/commit/73d0bf10c313f763ae80d794830f821efaae63d7 20180326 04:06:30< irker073> wesnoth: Charles Dang wesnoth:master b4adec6ef59e / src/gui/dialogs/help_browser.cpp: Help Browser: removed custom formatting conversion for , , and wesnoth: Iris Morelle wesnoth:1.14 c3a6300bce93 / src/ (savegame.cpp savegame.hpp synced_commands.cpp): Set a custom dialog caption for the synced debug command prompt https://github.com/wesnoth/wesnoth/commit/c3a6300bce93c4a146e71865e0663df4a1e0b886 20180326 04:06:40<+discordbot4> Crp. 20180326 04:06:45<+discordbot4> I forgot to make it translatable. 20180326 04:06:57<+discordbot4> Ohhhh the irony. 20180326 04:07:11<+discordbot4> 🤷 20180326 04:07:35<+discordbot4> @Vultraz I assume @hrubymar10 should also remove sdl2_ttf from xcode? 20180326 04:07:40<+discordbot4> yes 20180326 04:07:48<+discordbot4> could you remove it from cmake and scons 20180326 04:07:52<+discordbot4> (and INSTALL) 20180326 04:08:21< irker073> wesnoth: Iris Morelle wesnoth:1.14 03924c673c77 / src/synced_commands.cpp: Make the synced debug command prompt caption translatable https://github.com/wesnoth/wesnoth/commit/03924c673c774519d84804966c2b99f18a4f2e92 20180326 04:08:34< irker073> wesnoth: Iris Morelle wesnoth:master b7e08977edd7 / src/ (savegame.cpp savegame.hpp synced_commands.cpp): Set a custom dialog caption for the synced debug command prompt https://github.com/wesnoth/wesnoth/commit/b7e08977edd703ad9f146fd81768b2f09c39facd 20180326 04:09:01<+discordbot4> (The commit in master uses a translatable string.) 20180326 04:09:48<+discordbot4> grep also finds some remaining places that should probably be cleaned up: src/help/help_topic_generators.cpp:797: //row.emplace_back(bold(name), font::line_width(name, normal_font_size, TTF_STYLE_BOLD)); src/build_info.hpp:35: LIB_SDL_TTF, src/font/text.hpp:34: * Note: This is the cairo-pango code path, not the SDL_TTF code path. src/font/text.cpp:71: // With 72 dpi the sizes are the same as with SDL_TTF so 20180326 04:09:48<+discordbot4> hardcoded. src/font/font_config.hpp:19: * what local fonts to use. It also asks SDL_TTF to initialize itself, via the src/font/font_config.hpp:20: * sdl_ttf raii object. src/gui/widgets/text_box.cpp:280: // of a certain font via SDL_TTF. data/hardwired/fonts.cfg:14: # like the SDL_TTF code does. However, there's a weird bug in Pango itself 20180326 04:10:27<+discordbot4> stuff in help is all commented out (giant #if 0) 20180326 04:16:01<+discordbot4> https://cdn.discordapp.com/attachments/259976436490829825/427682110275584013/unknown.png 20180326 04:16:36<+discordbot4> 👍 20180326 04:18:35<+discordbot4> Decided against changing the buttons because the Yes/No wording is actually relied upon by the OOS dialog calls. 20180326 04:19:26<+discordbot4> Looks good. 20180326 04:22:52-!- travis-ci [~travis-ci@ec2-54-211-39-126.compute-1.amazonaws.com] has joined #wesnoth-dev 20180326 04:22:53< travis-ci> wesnoth/wesnoth#17235 (master - 8b6270f : Charles Dang): The build is still failing. 20180326 04:22:53< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/358236077 20180326 04:22:53-!- travis-ci [~travis-ci@ec2-54-211-39-126.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180326 04:26:31< irker073> wesnoth: Iris Morelle wesnoth:master cbec739e238a / src/synced_commands.cpp: New translatable version of the synced debug command prompt text https://github.com/wesnoth/wesnoth/commit/cbec739e238a603e579131016fc0d7c918ba1095 20180326 04:26:37< irker073> wesnoth: Iris Morelle wesnoth:1.14 948839692cfd / src/synced_commands.cpp: New translatable version of the synced debug command prompt text https://github.com/wesnoth/wesnoth/commit/948839692cfd6bebd5826d10a73ce39b191c400b 20180326 04:33:23<+discordbot4> @Vultraz ^ 20180326 04:33:47<+discordbot4> thanks 20180326 04:41:14<+discordbot4> SDL or SDL2? 20180326 04:42:01<+discordbot4> ? 20180326 04:43:16<+discordbot4> Just checking. He asled for SDL_TTF to be removed. You're removing SDL2_TTF. 20180326 04:43:46< irker073> wesnoth/wesnoth:master newfrenchy83 9afe9a9849 Update attack_predictions.cpp AppVeyor: 1/2 builds failed 20180326 04:43:47<+discordbot4> er... wesnoth hasn't used SDL1 anything for a while, right? 20180326 04:43:47< irker073> Details vs2017/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-master-1934 20180326 04:44:03<+discordbot4> SDL 1.2 was dropped with version 1.13.3 I'm sure? 20180326 04:44:06<+discordbot4> Or 1.13.5. 20180326 04:44:14<+discordbot4> So I thought, too. 20180326 04:44:37<+discordbot4> Then he means SDL2_ttf. 20180326 04:45:11<+discordbot4> ^ 20180326 04:45:18<+discordbot4> If SDL2_TTF is being dropped, we need a PR on external to remove it, VC project and XCode changes, too. 20180326 04:45:30<+discordbot4> already updated VS 20180326 04:45:41<+discordbot4> @hrubymar10 can handle the XCode changes 20180326 04:45:43<+discordbot4> Need to think about external pack 20180326 04:45:49<+discordbot4> eh, just leave it for now 20180326 04:46:01<+discordbot4> Maybe not .. probably breaks 1.14 20180326 04:47:44<+discordbot4> that too 20180326 05:14:11-!- travis-ci [~travis-ci@ec2-50-16-14-231.compute-1.amazonaws.com] has joined #wesnoth-dev 20180326 05:14:12< travis-ci> wesnoth/wesnoth#17242 (master - cbec739 : Iris Morelle): The build failed. 20180326 05:14:12< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/358243473 20180326 05:14:12-!- travis-ci [~travis-ci@ec2-50-16-14-231.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180326 05:21:16<+discordbot4> I'm refactoring the debug_notification() code to bring down the new string count. 20180326 05:21:44<+discordbot4> After trying to translate the new strings to Spanish on my own I realized they're just too many and repetitive and that's really unfair on our translators. 20180326 05:34:21< irker073> wesnoth: lundberg wesnoth:1.14 95332aee0920 / projectfiles/VC12/campaignd.vcxproj: Fix missing VC project options https://github.com/wesnoth/wesnoth/commit/95332aee0920517a06ada34e9b6aa1cd5c9f5e02 20180326 05:34:35<+discordbot4> @Vultraz Which is more correct? :$command debug command was used during $player’s turn or The :$command debug command was used during $player’s turn 20180326 05:34:57<+discordbot4> Latter, I think 20180326 05:35:18<+discordbot4> That's my feeling as well. 20180326 05:37:56< irker073> wesnoth: lundberg wesnoth:master 8b7eb536ebb3 / projectfiles/VC14/campaignd.vcxproj: Fix missing VC project options https://github.com/wesnoth/wesnoth/commit/8b7eb536ebb34eb8915cd409d8917e1a2398f3f4 20180326 05:38:53-!- travis-ci [~travis-ci@ec2-54-211-39-126.compute-1.amazonaws.com] has joined #wesnoth-dev 20180326 05:38:54< travis-ci> wesnoth/wesnoth#17243 (1.14 - 9488396 : Iris Morelle): The build passed. 20180326 05:38:54< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/358243481 20180326 05:38:54-!- travis-ci [~travis-ci@ec2-54-211-39-126.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180326 05:39:44<+discordbot4> @Vultraz I think that gets all the warnings from master and 1.14 for Visual Studio. I'm still getting WML test failures on Windows 10 but cannot reproduce them on Linux. 20180326 05:39:56<+discordbot4> :/ 20180326 05:44:03<+discordbot4> Does anyone know what ~/wesnoth/fonts/.uuid is? I'm getting an untracked file with that name. Have not tracked down where it comes from but if I delete it, it reappers. Should it go into .gitignore? 20180326 05:44:39<+discordbot4> wasn't @hrubymar10 mentioning UUID in conjunction with FontConfig? 20180326 05:46:26<+discordbot4> I don't see it in my 1.14 workdir. 20180326 05:46:55<+discordbot4> Dunno. What I notices was XCode flagged a warning about / no longer being needed and should be removed. 20180326 05:47:51<+discordbot4> Hmm. 20180326 05:48:04<+discordbot4> The Search box placeholder isn't being translated. 20180326 05:48:14<+discordbot4> 😐 20180326 05:48:38<+discordbot4> +#: data/gui/macros/_initial.cfg:348 +msgid "Search" +msgstr "Buscar" 20180326 05:48:44<+discordbot4> I don't see it. 20180326 05:49:16<+discordbot4> perhaps the class member should have been a t_string 20180326 05:49:19<+discordbot4> @Tad Carlucci UUID dependence seems to be new Fontconfig's dependence 20180326 05:49:26<+discordbot4> Ohhhhh. 20180326 05:49:29<+discordbot4> Let me check something quickly. 20180326 05:49:50<+discordbot4> @Vultraz Yeah, it is translated, but only exactly once. 20180326 05:50:17<+discordbot4> I am trying to workaround it but it looks, like I can't the newest fontconfig because of that 20180326 05:50:26<+discordbot4> Meaning it's stuck with the translation for the locale that was set during GUI2 initialization, and changing locales later during the program's execution doesn't have an effect because the string is stored that way forever. 20180326 05:50:45<+discordbot4> t_string needed, then? 20180326 05:50:53<+discordbot4> That's the main symptom of not using a t_string to store a persistent translatable string, yes. 20180326 05:51:04<+discordbot4> could you change it? 20180326 05:51:09<+discordbot4> SDL2_ttf could be removed only from master, right? 20180326 05:51:09<+discordbot4> gui/widgets/text_box.hpp 20180326 05:51:13<+discordbot4> @hrubymar10 yes 20180326 05:52:01<+discordbot4> @hrubymar10 I'm seeing it on Linux. I saw it before, deleted it, and it's back. So I'm repeating the steps. Delete, cmake ., make clean, make, run_wml_tests to see which step brings it out. Probably just needs to be added to .gitignore, but I'd feel better knowing where it comes from before I .gitignore it. 20180326 05:52:23<+discordbot4> strace? 20180326 05:52:56<+discordbot4> Although that really won't tell you anything other than the fact that it's being created. 20180326 05:53:03<+discordbot4> @Tad Carlucci it's new way of fontconfig's cache AFAIK 20180326 05:53:35<+discordbot4> where / what is fontconfig? build or run time? 20180326 05:53:48<+discordbot4> That seems a bit odd because normally fonts are read from mode 0755 paths. 20180326 05:53:55<+discordbot4> As non-root. 20180326 05:54:28<+discordbot4> And with fontconfig being a freedesktop project and freedesktop having a well-defined path for cache files... 20180326 05:55:47<+discordbot4> runtime, fontconfig is wesnoth's dependence and it basically scans all fonts available on your machine and can use them for wesnoth instead of default wesnoth's fonts 20180326 05:56:52<+discordbot4> if you remove its cache files, it will regenerate them again during wesnoth start. And wesnoth should start much longer in this case 20180326 05:58:57<+discordbot4> Hmm. OK pacman says I upgraded from 2.12.6 to 2.13.0 on March 17, 2018. Must be what changed. 20180326 05:59:57<+discordbot4> indeed, I have UUID problem with 2.13.0 ........ 20180326 06:00:22<+discordbot4> Interesting is, that Homebrew (macOS' package manager) can build it without UUID.... 20180326 06:00:27<+discordbot4> Ah yes, still 2.12.6 here. 20180326 06:00:36<+discordbot4> OK. Need to be added to .gitignore. Ran wesnoth and it appears. 20180326 06:00:51<+discordbot4> I feel like it's really rude of fontconfig to do that though. 20180326 06:01:33<+discordbot4> is pissed at himself right now so is currently refactoring the help code to let off steam 20180326 06:01:48<+discordbot4> https://github.com/behdad/fontconfig/commit/af687139f2866a736f294c7c54f9ea57219a079b 20180326 06:02:00<+discordbot4> @Vultraz t_string fix confirmed, will commit soon. 20180326 06:02:25<+discordbot4> Akira TAGOH (13): cleanup files Update .uuid only when -r is given but not -f. Returns false if key is already available in the table Add missing doc of FcDirCacheCreateUUID Replace uuid in the table properly when -r Add a test case for uuid creation Do not update mtime with creating .uuid Disable uuid related code on Win32 Try to get current instance of FcConfig as far as 20180326 06:02:25<+discordbot4> possible do not check the existence of itstool on win32 Fix the mis-ordering of ruleset evaluation in a file with include element Fix compiler warnings Add FcReadLink to wrap up readlink impl. 20180326 06:03:57<+discordbot4> I'm not sure if it makes sense for the player using the debug command to get the debug prompt themselves... 20180326 06:04:19<+discordbot4> Eh. 20180326 06:04:20<+discordbot4> no, because then no one would ever use debug commands in SP ever again 20180326 06:04:25<+discordbot4> I got OOS at the other end first. 20180326 06:04:42<+discordbot4> I didn't get the debug prompt in fact, just the OOS prompt. 20180326 06:04:58<+discordbot4> https://cdn.discordapp.com/attachments/259976436490829825/427709527001923585/unknown.png 20180326 06:05:09<+discordbot4> That must be why. gfgtdf ideas? 20180326 06:05:43<+discordbot4> https://cdn.discordapp.com/attachments/259976436490829825/427709719193452564/unknown.png 20180326 06:05:46<+discordbot4> Uhhhhhh okay??? 20180326 06:05:53<+discordbot4> This was working earlier so what gives? 20180326 06:06:09<+discordbot4> Oh, is it because I'm doing it out of turn... 20180326 06:06:40<+discordbot4> The Spanish translation for the OOS prompt is really emphatic: 20180326 06:06:41<+discordbot4> https://cdn.discordapp.com/attachments/259976436490829825/427709956825808898/unknown.png 20180326 06:07:32<+discordbot4> Okay, so things work as intended when using debug commands during your own turn, but if you do it out of turn the other players just get OOS. 20180326 06:07:46<+discordbot4> (And you get a prompt for your own action thrown at you.) 20180326 06:08:19<+discordbot4> well that's odd... 20180326 06:08:53-!- Ivanovic [~ivanovic@p4FC53D61.dip0.t-ipconnect.de] has quit [Changing host] 20180326 06:08:53-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev 20180326 06:09:10<+discordbot4> I mean, I'm not entirely surprised since you are sending commands out of turn. 20180326 06:09:29<+discordbot4> It's just a major oversight. 20180326 06:10:07<+discordbot4> I'm not even sure if the server supports players doing that in the first place. 20180326 06:10:58-!- travis-ci [~travis-ci@ec2-50-16-14-231.compute-1.amazonaws.com] has joined #wesnoth-dev 20180326 06:10:59< travis-ci> wesnoth/wesnoth#17245 (1.14 - 95332ae : lundberg): The build passed. 20180326 06:10:59< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/358252411 20180326 06:11:00-!- travis-ci [~travis-ci@ec2-50-16-14-231.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180326 06:13:51< irker073> wesnoth: Gregory A Lundberg wesnoth:1.14 6b14662d6455 / .gitignore: Add fonts.uuid to .gitignore for fontconfig 2.13.0 https://github.com/wesnoth/wesnoth/commit/6b14662d6455c59447bee3e7edeb88050650f686 20180326 06:15:49< irker073> wesnoth: Gregory A Lundberg wesnoth:master 49ecb08338be / .gitignore: Add fonts.uuid to .gitignore for fontconfig 2.13.0 https://github.com/wesnoth/wesnoth/commit/49ecb08338be1987250a2f6c6ca2b3f5fd13b9a1 20180326 06:16:47< irker073> wesnoth: Iris Morelle wesnoth:1.14 673c4dc04486 / src/gui/widgets/ (text_box.cpp text_box.hpp): gui2/text_box: Store hint text as a t_string https://github.com/wesnoth/wesnoth/commit/673c4dc044869f8e084acbd4652f022018d5d0f9 20180326 06:16:50< irker073> wesnoth: Iris Morelle wesnoth:1.14 9ea0b80a048c / src/synced_commands.cpp: Refactor synced debug commands prompt to bring the string count down to 2 https://github.com/wesnoth/wesnoth/commit/9ea0b80a048c7939d660645a69853172ded312ed 20180326 06:16:53< irker073> wesnoth: Iris Morelle wesnoth:master eacbc5f6959f / src/gui/widgets/ (text_box.cpp text_box.hpp): gui2/text_box: Store hint text as a t_string https://github.com/wesnoth/wesnoth/commit/eacbc5f6959f57ff05451a2874a8e494ac3cb8db 20180326 06:16:56< irker073> wesnoth: Iris Morelle wesnoth:master 56e7b01ac4cd / src/synced_commands.cpp: Refactor synced debug commands prompt to bring the string count down to 2 https://github.com/wesnoth/wesnoth/commit/56e7b01ac4cdfd6cf51c36cc7bf1cac33391cc58 20180326 06:21:48<+discordbot4> @hrubymar10 Instead of closing the PR you could commit a fixup to revert, git rebase --interactive to merge it to fix the original commit, then force-pushed your branch to upate the PR. 20180326 06:25:35-!- travis-ci [~travis-ci@ec2-54-211-39-126.compute-1.amazonaws.com] has joined #wesnoth-dev 20180326 06:25:36< travis-ci> wesnoth/wesnoth#17246 (master - 8b7eb53 : lundberg): The build is still failing. 20180326 06:25:36< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/358253254 20180326 06:25:36-!- travis-ci [~travis-ci@ec2-54-211-39-126.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180326 06:27:20< irker073> wesnoth: Hironori Fujimoto wesnoth:1.14 478bc206c4c7 / data/campaigns/Under_the_Burning_Suns/units/quenoth/Youth.cfg: UtBS: Fix Nym's hit sound to be female https://github.com/wesnoth/wesnoth/commit/478bc206c4c7539fcab417efc775564ecd3c4670 20180326 06:27:58<+discordbot4> forward-port 20180326 06:28:11< irker073> wesnoth: Iris Morelle wesnoth:1.14 b3b0f6ee6afe / changelog.md: Update changelog for issue #2732 and issue #2709 https://github.com/wesnoth/wesnoth/commit/b3b0f6ee6afe2dea55c0048540e5042fc9caa44e 20180326 06:28:14< irker073> wesnoth: Iris Morelle wesnoth:master 6f17695d7cde / changelog.md: Update changelog for issue #2732 and issue #2709 https://github.com/wesnoth/wesnoth/commit/6f17695d7cde2af39db6d8ee85314cdfe64cbc87 20180326 06:28:31< celticminstrel> Oh yeah, can someone also check if Nym's die_sound is correct. 20180326 06:29:41-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The computer falls into a deep sleep, to awake again some other day!] 20180326 06:30:43-!- JyrkiVesterinen [~JyrkiVest@195-192-251-124.s1networks.fi] has joined #wesnoth-dev 20180326 06:33:56< irker073> wesnoth: Sofartin wesnoth:master bc027b4fba27 / projectfiles/Xcode/ (Fix_Xcode_Dependencies Wesnoth.xcodeproj/project.pbxproj): Fixed Xcode project and removed SDL2_ttf https://github.com/wesnoth/wesnoth/commit/bc027b4fba2787461fbf5e68a5b4eadd79068eb3 20180326 06:37:19<+discordbot4> /Users/user/xcode/wesnoth/src/editor/palette/empty_palette.hpp:81:11: Private field 'gui_' is not used /Users/user/xcode/wesnoth/src/editor/map/context_manager.cpp:30:10: In file included from /Users/user/xcode/wesnoth/src/editor/map/context_manager.cpp:30: /Users/user/xcode/wesnoth/src/editor/controller/editor_controller.hpp:22:10: In file included from 20180326 06:37:19<+discordbot4> /Users/user/xcode/wesnoth/projectfiles/Xcode/../../src/editor/controller/editor_controller.hpp:22: /Users/user/xcode/wesnoth/src/editor/toolkit/editor_toolkit.hpp:18:10: In file included from /Users/user/xcode/wesnoth/projectfiles/Xcode/../../src/editor/toolkit/editor_toolkit.hpp:18: /Users/user/xcode/wesnoth/src/editor/palette/palette_manager.hpp:23:10: In file included from 20180326 06:37:20<+discordbot4> /Users/user/xcode/wesnoth/projectfiles/Xcode/../../src/editor/palette/palette_manager.hpp:23: /Users/user/xcode/wesnoth/src/help/help_topic_generators.hpp:42:19: Private field 'type_' is not used /Users/user/xcode/wesnoth/src/help/help_topic_generators.cpp:15:10: In file included from /Users/user/xcode/wesnoth/src/help/help_topic_generators.cpp:15: /Users/user/xcode/wesnoth/src/font/marked-up_text.cpp:155:13: Unused function 20180326 06:37:20<+discordbot4> 'break_before' /Users/user/xcode/wesnoth/src/font/marked-up_text.cpp:163:13: Unused function 'break_after' 20180326 06:38:17<+discordbot4> blah 20180326 06:38:24<+discordbot4> guess I need to fix all that 20180326 06:39:24<+discordbot4> Oh my god serve me stir-fried with soy sauce. 20180326 06:39:39<+discordbot4> Oh wait, nvm. 20180326 06:39:44<+discordbot4> This isn't just my mistake. 20180326 06:39:48<+discordbot4> why do you want stir fry 20180326 06:41:18< irker073> wesnoth: Iris Morelle wesnoth:master 28c35e71fa49 / changelog.md: Alphabetical order, alphabetical order, alphabetical order... https://github.com/wesnoth/wesnoth/commit/28c35e71fa49f76dc14b9f34d1c26cf9e0874328 20180326 06:55:39< irker073> wesnoth: Charles Dang wesnoth:master 8fc49bdce1cc / src/ (3 files in 3 dirs): Fixed some stuff causing compiler errors https://github.com/wesnoth/wesnoth/commit/8fc49bdce1cc17e937c670f1671290bb1273302f 20180326 06:56:38< irker073> wesnoth: pentarctagon wesnoth:master 3343a9451a26 / / (7 files in 5 dirs): Remove SDL2_TTF https://github.com/wesnoth/wesnoth/commit/3343a9451a266916930716bb2e0392861a532c2a 20180326 07:04:37<+discordbot4> Because stir-fried food is delicious. 20180326 07:05:40<+discordbot4> Try fried tempura sushi rolls dipped in soy sauce + lemon juice if you ever get the chance. 20180326 07:05:41<+discordbot4> 👌 20180326 07:23:58<+discordbot4> I have reservations about consuming fish raw or half-cooked. 20180326 07:37:42-!- grzywacz [~karol@89-70-226-147.dynamic.chello.pl] has joined #wesnoth-dev 20180326 07:37:55-!- grzywacz [~karol@89-70-226-147.dynamic.chello.pl] has quit [Changing host] 20180326 07:37:55-!- grzywacz [~karol@wesnoth/developer/grzywacz] has joined #wesnoth-dev 20180326 07:40:24-!- travis-ci [~travis-ci@ec2-50-16-14-231.compute-1.amazonaws.com] has joined #wesnoth-dev 20180326 07:40:25< travis-ci> wesnoth/wesnoth#17256 (master - 3343a94 : pentarctagon): The build passed. 20180326 07:40:25< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/358268363 20180326 07:40:25-!- travis-ci [~travis-ci@ec2-50-16-14-231.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180326 07:40:44<+discordbot4> \o/ 20180326 07:41:08<+discordbot4> Now if only AppVeyor builds were passing as well... 20180326 07:41:09-!- deekay [~deekayish@77-254-147-144.adsl.inetia.pl] has joined #wesnoth-dev 20180326 08:09:48-!- grzywacz [~karol@wesnoth/developer/grzywacz] has quit [Ping timeout: 256 seconds] 20180326 08:18:27< irker073> wesnoth: Charles Dang wesnoth:1.14 d80fde1632f0 / src/server/ (6 files): wesnothd: removed password reminder backend (closes #2753) https://github.com/wesnoth/wesnoth/commit/d80fde1632f08ad90210eeba905c7f419fe61a77 20180326 08:22:13-!- timotei_ [~timotei@wesnoth/developer/timotei] has quit [Ping timeout: 268 seconds] 20180326 08:23:41<+discordbot4> noted 20180326 08:24:16<+discordbot4> Her death sounds will be male, judging by the code. 20180326 08:44:44-!- travis-ci [~travis-ci@ec2-54-211-39-126.compute-1.amazonaws.com] has joined #wesnoth-dev 20180326 08:44:45< travis-ci> wesnoth/wesnoth#17257 (1.14 - d80fde1 : Charles Dang): The build passed. 20180326 08:44:45< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/358290382 20180326 08:44:45-!- travis-ci [~travis-ci@ec2-54-211-39-126.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180326 08:47:49-!- travis-ci [~travis-ci@ec2-50-16-14-231.compute-1.amazonaws.com] has joined #wesnoth-dev 20180326 08:47:50< travis-ci> shikadiqueen/wesnoth#35 (master - bc027b4 : Sofartin): The build is still failing. 20180326 08:47:50< travis-ci> Build details : https://travis-ci.org/shikadiqueen/wesnoth/builds/358286350 20180326 08:47:50-!- travis-ci [~travis-ci@ec2-50-16-14-231.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180326 09:30:15-!- JyrkiVesterinen [~JyrkiVest@195-192-251-124.s1networks.fi] has quit [Quit: .] 20180326 10:06:22-!- vn971 [~vasya@94.158.103.15] has quit [Ping timeout: 264 seconds] 20180326 10:30:17-!- Bonobo [~Bonobo@203.220.138.198] has quit [Ping timeout: 276 seconds] 20180326 10:30:54-!- Bonobo [~Bonobo@203.220.138.198] has joined #wesnoth-dev 20180326 10:36:07-!- JyrkiVesterinen [~JyrkiVest@195-192-251-124.s1networks.fi] has joined #wesnoth-dev 20180326 10:36:27< irker073> wesnoth/wesnoth:master Iris Morelle cbec739e23 New translatable version of the synced d AppVeyor: All builds passed 20180326 10:37:12<+discordbot4> Okay, so AppVeyor builds are passing in master, including the WML tests. 20180326 10:37:25<+discordbot4> (Irker's message was filtered out in the Discord side.) 20180326 10:37:59<+discordbot4> That conflicts with @Tad Carlucci 's claim that WML tests don't pass on Windows. 20180326 10:38:15-!- JyrkiVesterinen [~JyrkiVest@195-192-251-124.s1networks.fi] has left #wesnoth-dev [] 20180326 10:49:43-!- JyrkiVesterinen [~JyrkiVest@195-192-251-124.s1networks.fi] has joined #wesnoth-dev 20180326 10:50:06-!- gfgtdf [~chatzilla@x4e363945.dyn.telefonica.de] has joined #wesnoth-dev 20180326 10:53:57< gfgtdf> yes the server rejects out-of-turn commands, one of the main reason is that tey are just very likeley to casue OOS, if for exmaple the current player already invoked a move and another players would invoke another command (a debug command) at the same time, the clients would execute them in different order. 20180326 10:54:18< gfgtdf> do you think accepting debug command out-of-turn is an important thing to support ? 20180326 10:55:08< gfgtdf> note that this does not apply to sp, where it is 'always your turn' from th mp perspoective (ai sides are conrolled by a local ai) 20180326 11:02:42<+discordbot4> @jyrkive Yes, I noted that I get 100% passing of WML tests on Linux. So I need to figure out why I get nearly 100% failure on Windows. It would help if there were more information than just pass or fail. And, iirc, at the time celmin found a bug causing a lot of failures. 20180326 11:03:33<+discordbot4> But its good to know AppVeyor is passing again. 20180326 11:17:48-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180326 11:17:54-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180326 11:19:13-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180326 11:26:33-!- octalot [~steve@77.119.128.187.wireless.dyn.drei.com] has quit [] 20180326 11:46:21< irker073> wesnoth/wesnoth:master pentarctagon 1023688c90 Remove SDL2_TTF AppVeyor: All builds passed 20180326 11:52:07-!- deekay [~deekayish@77-254-147-144.adsl.inetia.pl] has quit [Quit: Leaving] 20180326 11:53:59<+discordbot4> Another passed AppVeyor build. 20180326 11:54:01<+discordbot4> https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-master-1976/job/ihm3gcuwq832gisq#L1462 20180326 11:54:40<+discordbot4> All WML tests passed, but one timed out (a timeout doesn't fail the build). Likely just a random timeout. 20180326 11:54:50-!- JyrkiVesterinen [~JyrkiVest@195-192-251-124.s1networks.fi] has left #wesnoth-dev ["Closing Window"] 20180326 11:55:22<+discordbot4> I get that, too. Usually on the 'return' test. 20180326 11:55:42<+discordbot4> It's the first test, right? 20180326 11:55:46<+discordbot4> yes 20180326 11:55:55< gfgtdf> it gives some warning C4706 though. 20180326 11:56:10<+discordbot4> It may just be that it times out because the filesystem cache is cold or WML cache is empty. 20180326 11:56:31<+discordbot4> I thought I got all those 4706 4458 and 4459 messages. sigh 20180326 11:57:04< gfgtdf> i wonder whtwhe we an restore the vs2013 build on the 1.14 branch only ? 20180326 11:57:32<+discordbot4> I think there isn't much point. 20180326 11:57:47<+discordbot4> There aren't supposed to be large changes in the 1.14 branch any more. 20180326 11:58:07<+discordbot4> Meaning a low risk of developers accidentally pushing code that coesn't compile with VS2013. 20180326 11:59:20< gfgtdf> hm ok 20180326 11:59:36<+discordbot4> I was digging in my archives and came across my old 8.1 / VS 2013 VM if we need it 20180326 11:59:56<+discordbot4> I'm still using VS2013 when I need to build the 1.14 branch. 20180326 12:00:06<+discordbot4> ok good 20180326 12:07:21-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20180326 12:13:30-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20180326 12:13:39-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180326 12:35:37-!- grzywacz [~karol@89-70-226-147.dynamic.chello.pl] has joined #wesnoth-dev 20180326 12:42:15-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20180326 13:14:11-!- grzywacz [~karol@89-70-226-147.dynamic.chello.pl] has quit [Ping timeout: 276 seconds] 20180326 13:20:29-!- grzywacz [~karol@89-70-226-147.dynamic.chello.pl] has joined #wesnoth-dev 20180326 13:33:45-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180326 13:35:19-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20180326 13:37:03-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180326 13:42:05-!- Nobun [~user@51.179.98.217] has joined #wesnoth-dev 20180326 13:44:01-!- Bonobo [~Bonobo@203.220.138.198] has quit [Ping timeout: 248 seconds] 20180326 14:00:19-!- vn971 [~vasya@94.158.103.15] has joined #wesnoth-dev 20180326 14:05:21-!- molgrum [~molgrum@unaffiliated/molgrum] has quit [Ping timeout: 240 seconds] 20180326 14:25:33< irker073> wesnoth/wesnoth:master pentarctagon 3343a9451a Remove SDL2_TTF AppVeyor: All builds passed 20180326 14:29:30-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!] 20180326 14:49:33< irker073> wesnoth: newfrenchy83 wesnoth:master cf70a6bb54fa / projectfiles/CodeBlocks/wesnoth.cbp: Update wesnoth.cbp https://github.com/wesnoth/wesnoth/commit/cf70a6bb54fa6e6e1332ed5aa1abe1dc93de28a6 20180326 14:57:21-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180326 14:57:27-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180326 15:08:05< irker073> wesnoth: lundberg wesnoth:master d322e1fb973e / projectfiles/VC14/campaignd.vcxproj: Suppress VC warning 4706 for campaignd https://github.com/wesnoth/wesnoth/commit/d322e1fb973e89354b6d851a902c048702df94ba 20180326 15:09:52< irker073> wesnoth: lundberg wesnoth:1.14 ecde4da6b9d3 / projectfiles/VC12/campaignd.vcxproj: Suppress VC warning 4706 for campaignd https://github.com/wesnoth/wesnoth/commit/ecde4da6b9d35994a757bbeaf423f13fcb15e189 20180326 15:33:49-!- Oebele [~quassel@143.177.58.202] has joined #wesnoth-dev 20180326 16:07:02-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180326 16:10:09-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20180326 16:16:29<+discordbot4> gfgtdf: Letting people use these commands out of turn does cause OOS, and the sender is the one that sees the debug prompt. 20180326 16:18:15<+discordbot4> I think it'd be preferable if they weren't allowed to use any of them out of turn rather than make things worse by allowing them. The thing is in single player it can be legitimately useful to issue certain debug mode commands when it's not your turn. 20180326 16:18:37<+discordbot4> Also, I need you to explain where the Lua Console fits in all of this. 20180326 16:18:59< gfgtdf> shadowm: the lua console is completley unsynced. 20180326 16:19:52<+discordbot4> Welp okay. Although I couldn't get it to actually do anything like I expected. 20180326 16:20:04< gfgtdf> why that? 20180326 16:21:27<+discordbot4> wesnoth.sides[1].fog = false and a subsequent redraw is supposed to disable and lift fog for side 1, isn't it? 20180326 16:22:28< gfgtdf> i'd guess so. 20180326 16:23:43<+discordbot4> Maybe I did the redraw wrong. It's been ages since I did any WML or Lua. 20180326 16:24:00< gfgtdf> "wesnoth.sides[1].fog = true; wesnoth.wml_actions.redraw{};" worked withotu problems. 20180326 16:25:10< gfgtdf> false i meant 20180326 16:35:41< gfgtdf> it woudl porobbly be rather simple to disable all debug command offturn in networked mp. but that'd then also apply to :inspect and other unsyced debug commands 20180326 16:39:29< gfgtdf> oh wait, we alreaday have a tag for synced debug commands. 20180326 16:43:36-!- sevu [~Shiki@p5485560E.dip0.t-ipconnect.de] has joined #wesnoth-dev 20180326 16:48:37< irker073> wesnoth/wesnoth:1.14 Charles Dang d80fde1632 wesnothd: removed password reminder back AppVeyor: All builds passed 20180326 16:49:47< irker073> wesnoth: gfgtdf wesnoth:master a1c06fbc65c3 / src/ (hotkey/hotkey_handler_sp.cpp menu_events.cpp): disable debug command off-turn in mp https://github.com/wesnoth/wesnoth/commit/a1c06fbc65c380574f5449e5ea067d414544c155 20180326 17:00:52-!- Nobun [~user@51.179.98.217] has quit [Quit: WeeChat 2.1-dev] 20180326 17:13:49< gfgtdf> ok now m git cleints gets stuck when i try to checkout 1.14 20180326 17:16:45< gfgtdf> works now 20180326 17:18:22< irker073> wesnoth: gfgtdf wesnoth:1.14 81cfb11af0e4 / src/ (hotkey/hotkey_handler_sp.cpp menu_events.cpp): disable debug command off-turn in mp https://github.com/wesnoth/wesnoth/commit/81cfb11af0e4b6a53b941618fb4cb175f1b480c7 20180326 17:59:08<+discordbot4> Ther was this discussion about the "prefered fate of the dunefolk/khalifate" in the forums, and it has been decided to keep two eras, with and without them. There has as well been brought up to rename the eras, e.g. to promote the name of the era with the dunefolk to "default", and to rename the current default era to "classic". What about that? 20180326 18:04:49<+discordbot4> shelved for now. 20180326 18:05:47-!- sevu [~Shiki@p5485560E.dip0.t-ipconnect.de] has quit [Remote host closed the connection] 20180326 18:14:44-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180326 18:38:36-!- heirecka [~heirecka@exherbo/developer/heirecka] has quit [Quit: Bye] 20180326 18:42:22-!- heirecka [~heirecka@exherbo/developer/heirecka] has joined #wesnoth-dev 20180326 18:43:31-!- Bhoren [~Bhoren_wh@2a01:e0a:c:2150:dcf4:e04c:eb34:bb69] has joined #wesnoth-dev 20180326 19:22:41< irker073> wesnoth/wesnoth:master newfrenchy83 6e3d438489 Update attack_predictions.cpp AppVeyor: All builds passed 20180326 19:30:08-!- octalot [~steve@77.119.129.208.wireless.dyn.drei.com] has joined #wesnoth-dev 20180326 20:02:12-!- janebot_ [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180326 20:02:18-!- janebot_ is now known as janebot__ 20180326 20:02:19-!- janebot__ is now known as janebot_ 20180326 20:02:30-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180326 20:03:54-!- janebot_ is now known as janebot 20180326 20:04:15-!- deekay [~deekayish@public-gprs376051.centertel.pl] has joined #wesnoth-dev 20180326 20:11:36-!- oldlaptop_ [~quassel@45.63.78.126] has joined #wesnoth-dev 20180326 20:13:33-!- oldlaptop [~quassel@45.63.78.126] has quit [Ping timeout: 256 seconds] 20180326 20:17:21-!- oldlaptop_ is now known as oldlaptop 20180326 20:34:05-!- Oebele [~quassel@143.177.58.202] has quit [Remote host closed the connection] 20180326 20:36:40-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev 20180326 21:07:51-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 240 seconds] 20180326 21:08:18<+discordbot4> @loonycyborg So for the pot updates you just run scons pot-update, right? 20180326 21:08:42<+discordbot4> basically yes 20180326 21:08:48<+discordbot4> there are other targets for manual 20180326 21:08:52<+discordbot4> and man pages 20180326 21:09:09<+discordbot4> Oh, never mind, the wiki says scons pot-update update-po4a manual. 20180326 21:09:27<+discordbot4> update-po4a takes care of the manpages I presume. 20180326 21:09:40<+discordbot4> yes, and of inner parts of manual 20180326 21:09:50<+discordbot4> generation of xml from pot 20180326 21:17:32<+discordbot4> @shadowm I'm leaving the room name issue until 1.14.1. The fix is not inherently difficult, but I'm not really feeling up to dealing with it right now 20180326 21:17:53<+discordbot4> Okay, I'll change the milestone then. 20180326 21:22:12<+discordbot4> Basically, I'm finding myself up against design barriers in everything I've been trying to do recently (with minor exceptions). There's really been no functional progress with a_r besides ripping all the old code out. I've been stuck the last 12 hours on a simple design issue in my Help refactor wherein I cannot decide on a simple damn solution, I can't figure out how to finish that removal of boost::mpl from GUI2, I can't figure 20180326 21:22:13<+discordbot4> out how to implement my/tad's idea for a new main register event callback system.... 20180326 21:22:51<+discordbot4> And while I successfully implemented that text box change yesterday, I just don't really want to try something else and fail at that too 😐 20180326 21:23:59<+discordbot4> Rather starting to question my abilities when it comes to coming up with new designs, instead of simply porting stuff from api A to api B 20180326 21:24:12<+discordbot4> yaknowwhaimsaying 20180326 21:32:13-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180326 21:32:19-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180326 21:32:29<+discordbot4> Also, in the future, it'd be great if some heads up was given before a poll like adding the Dunefolk to Default/removing them from mainline altogether is created. 20180326 21:32:48< gfgtdf> why woud you want to remove mpl form gui2 in the first place? 20180326 21:40:33<+discordbot4> because MPL is pre-c++11 metaprogramming and the way it's used is confusing as hell and probably slow as molasses to compilec 20180326 21:46:12-!- atarocch [~atarocch@93.56.164.28] has quit [Remote host closed the connection] 20180326 21:46:40-!- Bhoren [~Bhoren_wh@2a01:e0a:c:2150:dcf4:e04c:eb34:bb69] has quit [Quit: Leaving] 20180326 21:46:42<+discordbot4> you're replacing it with stuff like lambdas and variadic templates? 20180326 21:47:31<+discordbot4> that stuff is leagues better than what was there before, but still can be hard to replace boost metaprogramming with it 20180326 21:48:22<+discordbot4> I already replaced a whole bit with variadic templates a year ago 20180326 21:48:55<+discordbot4> and I replaced part of the compile-time event set checks with constexpr functions 20180326 21:50:13<+discordbot4> but there's one last bit that uses MPL that I cannot touch 20180326 21:50:15<+discordbot4> it's impossible 20180326 21:50:36<+discordbot4> (for me) 20180326 21:50:49<+discordbot4> I know what it does, and how it works, but I don't know how to replace it 20180326 21:53:53<+discordbot4> I explained the thing to @Tad Carlucci the other day 20180326 22:00:57-!- grzywacz [~karol@89-70-226-147.dynamic.chello.pl] has quit [Ping timeout: 240 seconds] 20180326 22:07:23-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection] 20180326 22:22:34-!- deekay [~deekayish@public-gprs376051.centertel.pl] has quit [Quit: Leaving] 20180326 22:23:09-!- irker073 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout] 20180326 22:41:02< shadowm> gfgtdf: Hm, it seems in single-player $player can be empty for the debug command notifications. 20180326 22:41:45< shadowm> Also, it seems it's not possible to use debug commands out of turn in single-player anymore. I guess it doesn't really matter that much. 20180326 22:42:52< gfgtdf> shadowm: was it possibel before my last change? note that even before my last cahnge it was not possibel to use them while another action is executing (which is usually the case during an ais turns since the ai doesnt take long tiome thinking) 20180326 22:43:02< shadowm> Weird, I can't reproduce the situation where $player is empty. 20180326 22:43:06< gfgtdf> $player uses the muliplayer name 20180326 22:43:18< gfgtdf> (current_player()) 20180326 22:43:31< gfgtdf> it defaults to your systrem username iirc. 20180326 22:43:43<+discordbot4> Yeah, or "Player" as a fallback. 20180326 22:44:42<+discordbot4> Okay... 20180326 22:45:34<+discordbot4> It becomes empty when you do the following: 1) load a replay in single-player mode (any replay); 2) load a game save in single-palyer mode; 3) use :lua to reproduce. 20180326 22:47:00<+discordbot4> Also, I know using some debug commands out of turn in SP was possible in 1.12, whilst others were ignored. 20180326 22:47:24<+discordbot4> :unit in particular worked, but only sometimes and during very brief intervals. 20180326 22:47:38<+discordbot4> So it doesn't really matter tbh. 20180326 22:47:55<+discordbot4> I'm more curious why loading a replay appears to blank out the player's name forever. 20180326 22:48:54< Ravana_> using offturn debug commands to change units in 1.12 is likely to make wesnoth crash 20180326 22:48:59<+discordbot4> An d now I can't reproduce it. 20180326 22:49:08<+discordbot4> What on earth... 20180326 22:50:25<+discordbot4> Well, I'm going to do the pot-update. 20180326 22:52:28<+discordbot4> I just started the game, loaded a SP campaign SOS save and used :lua and $player is empty. 20180326 22:54:08<+discordbot4> It seems this particular case is 100% reliable for reproducing. 20180326 22:55:49<+discordbot4> @loonycyborg How do I build with UBSan using SCons? 20180326 22:56:23<+discordbot4> sanitize=undefined 20180326 22:56:39<+discordbot4> Oh, it's sanitize. 20180326 22:56:59<+discordbot4> I kept writing "sanitizer" instead. 20180326 22:58:04< gfgtdf> shadowm: hmm it seems leik "current_player" is only set in the mp connect_engine code and that is is not run, when loading in sp game (but it is executed betwwen two scenarios of a sp game) 20180326 22:58:09< gfgtdf> like* 20180326 22:59:02<+discordbot4> Can that be fixed or should I make debug_notification() come up with a fallback for when current_team.current_player() returns an empty string? 20180326 22:59:41<+discordbot4> (I guess I don't need the -O0 UBSan build I'm making anymore but I'mma keep going anyway.) 20180326 23:01:10< gfgtdf> running mp_copnnect_engine when we are loading an sp save seems rather risky for littel gain to me. 20180326 23:03:10<+discordbot4> Eh, I guess it can be "". 20180326 23:03:42< gfgtdf> we coudl porobably just set it to perfernces::login at the start of 'campaign_controller::playsingle_scenario' if it is unset at that point, not sure. 20180326 23:03:57<+discordbot4> Even if that'll display weird in some languages including English ("The :$command debug command was used during 's turn"), I think it's preferable to the alternative, and it is supposed to be a debug message anyway. 20180326 23:04:37< gfgtdf> ye to question is probably more whether 'current_player' is also used in other more important dialogs in sp . 20180326 23:04:43< gfgtdf> as a fallback usually. 20180326 23:04:50<+discordbot4> Probably. 20180326 23:05:05<+discordbot4> Also, I'm getting feedback from UBSan on the way to the main screen... 20180326 23:05:24<+discordbot4> https://pastebin.com/7aeXfKKk 20180326 23:05:42<+discordbot4> It's known 20180326 23:05:53<+discordbot4> But nothing we can do about it now 20180326 23:06:07<+discordbot4> It's UB, but it works right now 20180326 23:06:08<+discordbot4> so 20180326 23:07:01< gfgtdf> 'current_player' is used as a fallback of various dialogs in case that the name of that side is not set hmm. 20180326 23:07:44<+discordbot4> The main screen UBSan warnings were reported on github as well. 20180326 23:07:50<+discordbot4> https://github.com/wesnoth/wesnoth/issues/2400 20180326 23:07:54<+discordbot4> I hope Vultraz has a better excuse than what he just said xD 20180326 23:08:20<+discordbot4> what do you want me to do about it 20180326 23:08:46< gfgtdf> (which is rareley the case in practioce since usually umc authors do not want that name to pop up there) so it's probalby nto that bad (taking about current_player, not ubsan) 20180326 23:09:07<+discordbot4> @Vultraz Do what Pentarctagon just did and point me to something that doesn't sound like you're treating Wesnoth like a black box again. 20180326 23:09:35<+discordbot4> I'm reading celticminstrel's comment there, it's more enlightening and reasonable than what you said. 20180326 23:09:55<+discordbot4> https://github.com/wesnoth/wesnoth/issues/2400#issuecomment-360998790 20180326 23:09:58<+discordbot4> This comment in particular. 20180326 23:10:46<+discordbot4> Interestingly enough, the issue is specifically that the virtual member is called in the initializer list. If it were in the ctor body it would be fine. 20180326 23:10:49<+discordbot4> Which is an odd design thing 20180326 23:11:13<+discordbot4> IIUC it's specifically because it's called when initializing the parent class. 20180326 23:11:52<+discordbot4> So it's a chicken-and-egg issue where you're calling a virtual member when your own identity isn't fully defined yet (that's supposed to be part of the process of constructing the parent class). 20180326 23:12:42<+discordbot4> It's actually a miracle that doesn't blow up in your face somehow. 20180326 23:13:26<+discordbot4> I'm guessing it just coincidentally happens that all the compiler we use go out of their way to make sure that there's an incomplete vtable set up at that point? 20180326 23:16:05< gfgtdf> well it's ub, behving like vultraz expected is not forbitten. i tihnk they just inline that function directly or at least resovle that adress at compiletime. 20180326 23:18:03<+discordbot4> It sounds to me like more like something mordante expected. 20180326 23:18:09<+discordbot4> *more like 20180326 23:18:56<+discordbot4> Except the design pattern is my doing 20180326 23:19:06<+discordbot4> Oh, never mind then. 20180326 23:19:06<+discordbot4> The problem with this kind of thing is that sooner or later you'll come across a compiler that breaks your expectations and things will go south pretty quickly. 20180326 23:19:28<+discordbot4> I refactored the initialization process not too long ago based on some code comments mordante had left 20180326 23:20:02<+discordbot4> But the detail about using the virtual function in the initializer list was, IIRC, something I came up with 20180326 23:20:45<+discordbot4> before, the initialization was done in multiple steps, so there was a period before the canvas and definition data were valid 20180326 23:20:54<+discordbot4> specifically, before init_control was called 20180326 23:21:18<+discordbot4> I did away with all that and instead had the constructors do all the initializing by passing the builder objects directly to the widget ctors 20180326 23:21:44<+discordbot4> which then works downwards and ensures that a widget is ready to use as soon as you create it 20180326 23:21:56<+discordbot4> including allowing stuff like access to the canvas in the ctor 20180326 23:23:09< octalot> C++ spec: during construction, virtual function calls ignore subclasses. http://en.cppreference.com/w/cpp/language/virtual#During_construction_and_destruction 20180326 23:23:37<+discordbot4> yes, i know you can't call a virtual function from a base class to get a derived member 20180326 23:23:53<+discordbot4> but I thought (as jyrki too) that calling the virtual override from the derived class's ctor was valid 20180326 23:23:59<+discordbot4> apparently, it's only valid in the ctor body 20180326 23:24:03<+discordbot4> but the initializer list 20180326 23:24:29-!- Bhoren [~Bhoren_wh@2a01:e0a:c:2150:dcf4:e04c:eb34:bb69] has joined #wesnoth-dev 20180326 23:30:29<+discordbot4> All right, string freeze time again. 20180326 23:30:29-!- irker785 [~irker@uruz.ai0867.net] has joined #wesnoth-dev 20180326 23:30:29< irker785> wesnoth: Iris Morelle wesnoth:1.14 8b41d4d8fc44 / src/synced_commands.cpp: Use a fallback for when the player name is not known in debug notifications https://github.com/wesnoth/wesnoth/commit/8b41d4d8fc4408084abff62a4e7d63eeb1c10bd1 20180326 23:31:32<+discordbot4> src/editor/map/map_context.cpp:156: warning: unterminated string literal 20180326 23:31:39<+discordbot4> Apparently GNU gettext's xgettext doesn't know C++11. 20180326 23:33:25-!- Bhoren [~Bhoren_wh@2a01:e0a:c:2150:dcf4:e04c:eb34:bb69] has quit [Quit: Leaving] 20180326 23:35:21<+discordbot4> @loonycyborg I need you to do the pot-update, the toolchain for the manuals and other stuff is making assumptions that do not hold true on Debian. 20180326 23:35:25<+discordbot4> xsltproc --nonet --stringparam callout.graphics 0 --stringparam navig.graphics 0 --stringparam admon.textlabel 1 --stringparam admon.graphics 0 --stringparam html.stylesheet ./styles/manual.css /usr/share/asciidoc/docbook-xsl/xhtml.xsl doc/manual/manual.cs.xml > doc/manual/manual.cs.html warning: failed to load external entity "/usr/share/asciidoc/docbook-xsl/xhtml.xsl" cannot parse /usr/share/asciidoc/docbook-xsl/xhtml.xsl 20180326 23:36:07<+discordbot4> is it at same path as for @jyrkive ? 20180326 23:36:19<+discordbot4> How am I supposed to know? 20180326 23:37:01<+discordbot4> it didn't work for him, he had it at different path on a distro based on Sid 20180326 23:37:21<+discordbot4> Odds are pretty good it's the same then. 20180326 23:37:27<+discordbot4> I forgot exact path though 20180326 23:39:48<+discordbot4> It's also possible I've removed a required package since then but I wouldn't know what it was. 20180326 23:40:07<+discordbot4> asciidoc I guess 20180326 23:40:12<+discordbot4> No, that's installed. 20180326 23:40:44<+discordbot4> 20:39:09 shadowm@hanacore ~/src/wesnoth-1.14 git:1.14 % dpkg --get-selections | egrep '^(asciidoc|docbook)' asciidoc install asciidoc-base install asciidoc-common install asciidoc-dblatex install docbook install docbook-dsssl 20180326 23:40:44<+discordbot4> install docbook-utils install docbook-website install docbook-xml install docbook-xsl install docbook-xsl-ns install docbook2x install docbook5-xml install 20180326 23:41:47< octalot> with the constructors, I don't see what get_control_type() adds, why not just put the string literal where the call to get_control_type() is? 20180326 23:43:01< Ravana_> I wonder if translations should change : to their local default command hotkey 20180326 23:43:54<+discordbot4> /usr/share/xml/docbook/stylesheet/docbook-xsl/xhtml/docbook.xsl 20180326 23:43:59<+discordbot4> you got it there? 20180326 23:44:05<+discordbot4> @Ravana Is there such a thing? 20180326 23:44:27<+discordbot4> They can do it if they want anyway. The whole format string is translatable. 20180326 23:44:54<+discordbot4> @loonycyborg Yes. -rw-r--r-- 1 root root 20297 Sep 16 2015 /usr/share/xml/docbook/stylesheet/docbook-xsl/xhtml/docbook.xsl 20180326 23:45:16<+discordbot4> It's from the docbook-xsl package. 20180326 23:45:27< Ravana_> new hotkey system means that instead of using character value ( : ), its position is used, which means different character on different layout 20180326 23:45:30<+discordbot4> Not even asciidoc. 20180326 23:46:07<+discordbot4> I don't have it at that path on gentoo 20180326 23:46:08<+discordbot4> I don't know anything about that so you might want to weigh in when I post the i18n ML announcement. 20180326 23:46:19<+discordbot4> Ravana_: ^ 20180326 23:46:28<+discordbot4> Yes loonycyborg I assumed so. :p 20180326 23:46:29-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer] 20180326 23:46:52<+discordbot4> In fact I distinctly recall having a similar conversation with Ivanovic back in the day. 20180326 23:47:22<+discordbot4> yes me too 20180326 23:47:23-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180326 23:47:27<+discordbot4> those path sure do change 20180326 23:47:30<+discordbot4> Commit b270658f50d1f8971d9a9f8d35a1ca9a536513ef. 20180326 23:47:39<+discordbot4> https://github.com/wesnoth/wesnoth/commit/b270658f50d1f8971d9a9f8d35a1ca9a536513ef 20180326 23:48:22<+discordbot4> Both he and I used CMake, not SCons. 20180326 23:51:14<+discordbot4> Anyway I'll draft my post while you do that. 20180326 23:51:18-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev 20180326 23:53:26<+discordbot4> I hope it will reach the people it needs to reach. 20180326 23:54:17< Ravana_> I tested that again, seems that it was changed back sometime in the middle of 1.13, so no matter 20180326 23:55:22<+discordbot4> hmm I can do the same in scons 20180326 23:55:23<+discordbot4> sec --- Log closed Tue Mar 27 00:00:17 2018