--- Log opened Wed Mar 28 00:00:18 2018 20180328 00:13:01< irker906> wesnoth/wesnoth:master Joseph Gelfand 0171a61f97 Made blitting error handling less aggres AppVeyor: All builds passed 20180328 00:21:18< irker906> wesnoth: pentarctagon wesnoth:master 0bbc78945ee9 / src/CMakeLists.txt: Remove tools-external-libs. https://github.com/wesnoth/wesnoth/commit/0bbc78945ee9945be708396f71d80d3869a31951 20180328 01:00:25<+discordbot> is celticminstrel around 20180328 01:00:30< celticminstrel> Never! 20180328 01:00:33< celticminstrel> Hi. 20180328 01:00:37< celticminstrel> What's up? 20180328 01:01:00<+discordbot> can you use std::make_move_iterator in conjunction with std::merge? 20180328 01:01:01< celticminstrel> (I guess you don't see joins through the bridge, eh?) 20180328 01:01:10< celticminstrel> Uhh. 20180328 01:01:24<+discordbot> (no I don't) 20180328 01:02:17< celticminstrel> So you want to know if the first/last iterators can be move iterators? 20180328 01:02:53 * celticminstrel suppose std::merge would be appropriate to use for a merge sort... 20180328 01:02:56< celticminstrel> ^supposes 20180328 01:03:53<+discordbot> basically, in the help code there's this bit: cpp std::sort(topics.begin(),topics.end(), title_less()); std::sort(generated_topics.begin(), generated_topics.end(), title_less()); std::merge(generated_topics.begin(), generated_topics.end(), topics.begin(), topics.end(), std::back_inserter(sec.topics), title_less()); 20180328 01:04:07<+discordbot> wondering if the topic objects can be moved instead of copied 20180328 01:04:25<+discordbot> though I guess it doesn't matter, since topic is light 20180328 01:04:32< celticminstrel> As far as I can tell from cppreference.com, std::merge shouldn't care whether the first and last range ranges are move iterators. 20180328 01:04:40< celticminstrel> What exactly was in topic again? 20180328 01:04:55< celticminstrel> You say it's light but surely it has the actual topic text? 20180328 01:05:21<+discordbot> std::string id; std::string title; mutable topic_text text; 20180328 01:05:28< celticminstrel> Strings are not light unless you know they're going to be short. 20180328 01:05:35<+discordbot> topic_text has a config.. 20180328 01:05:42<+discordbot> so... actually, yeah, it might be a bit expensive 20180328 01:05:43< celticminstrel> Configs are definitely not light. 20180328 01:05:50<+discordbot> so, ok, yeah, need to move these 20180328 01:06:02<+discordbot> no idea why there are even two vectors here.. 20180328 01:06:05< celticminstrel> I still don't think it matters that much, but... 20180328 01:06:16<+discordbot> basically it's copying from two vectors into a list in a sorted manner 20180328 01:06:39< celticminstrel> I wonder whether it's more efficient to add the topics and then sort or to add the topics while keeping it sorted... 20180328 01:06:45< celticminstrel> Probably the former actually. 20180328 01:06:50<+discordbot> you can't sort an std::list 20180328 01:06:55<+discordbot> though why it's a list I don't kjow 20180328 01:07:04< celticminstrel> Uhh, sure you can? 20180328 01:07:23<+discordbot> say what? I was told std::sort doesn't work on `std::list 20180328 01:07:24<+discordbot> ` 20180328 01:07:25< celticminstrel> You can even sort an std::forward_list if you really want to, though it might be a bit tricy. 20180328 01:07:47< celticminstrel> "std::sort doesn't work on std::list" is not the same thing as "you can't sort an std::list". 20180328 01:07:57<+discordbot> oh 20180328 01:07:59<+discordbot> std::list::sort 20180328 01:07:59<+discordbot> 😐 20180328 01:08:03< celticminstrel> XD 20180328 01:08:12<+discordbot> 🤦 20180328 01:08:19< celticminstrel> Yeah, you're right; std::sort does not work for std::list. 20180328 01:08:35< celticminstrel> Nor does std::stable_sort. 20180328 01:08:48< celticminstrel> Wonder if there's an std::list::stable_sort. 20180328 01:08:50<+discordbot> JE SUIS STUPID 20180328 01:09:11< celticminstrel> Doesn't look like there is. 20180328 01:09:25< celticminstrel> Oh, but std::list::sort is already stable. 20180328 01:10:05<+discordbot> I have no idea why the old code implements operator< for sections and topics in terms of ID 20180328 01:10:49< celticminstrel> Someone probably just wasn't thinking? 20180328 01:11:46<+discordbot> dunno, might be something to do with there being an unsorted state... 20180328 01:12:49<+discordbot> random thought: why were pre-C++11 comparison functions implemented in terms of a class/struct with an operator() instead of just a function that took the same arguments? 20180328 01:13:51<+discordbot> oh, right, the latter would only with with runtime sort 20180328 01:13:56< celticminstrel> I'm thinking it's probably so that the comparator can be passed as a template type parameter. 20180328 01:14:00<+discordbot> not for template sorters like std::set 20180328 01:14:27< celticminstrel> For example in std::map. 20180328 01:14:54< celticminstrel> If you're only calling std::sort, you can just use a function, sure. 20180328 01:15:05< celticminstrel> But if you want a map sorted by unusual criteria, then you need a functor. 20180328 01:15:35< celticminstrel> Pretty sure that was the case in C++03. Probably was the case even in C++98. 20180328 01:15:48<+discordbot> ponders if we should add a general-purpose sort helper struct for compare and icompare since we use those in so many places. 20180328 01:15:56 * celticminstrel wonders what comes before C++98. 20180328 01:16:24< celticminstrel> I guess somewhere in there is a version of C++ that didn't have exceptions. 20180328 01:17:30< celticminstrel> Wow, there are a lot of things that are taken for granted now that the original C++ didn't ahve. 20180328 01:19:10< celticminstrel> Multiple inheritance, abstract classes, static and const member functions, protected access, templates, namespaces, bool... 20180328 01:19:23< celticminstrel> And the C++ style casts... 20180328 01:19:34<+discordbot> something like.. cpp template struct translated_sort { bool operator()(const T& lhs, const T& rhs) { return translation::compare(value_getter_(lhs), value_getter_(rhs)) < 0; } std::function value_getter_; }; 20180328 01:19:37< celticminstrel> ^have 20180328 01:20:00< celticminstrel> @Vultraz As a rule of thumb, unless it's impossible, always make your operator() functions const. 20180328 01:20:13<+discordbot> though I guess with a function it couldn't work as a template argument... 20180328 01:20:22< celticminstrel> Yes, exactly. 20180328 01:20:32<+discordbot> ah, but.. 20180328 01:20:41< celticminstrel> (Technically you can pass functions as template arguments though, but I'm not sure if there are problems with that approach.) 20180328 01:21:14< celticminstrel> (At the very least it would be less flexible, preventing a whole category of comparators from being used at all.) 20180328 01:21:19<+discordbot> what about cpp template struct translated_sort { bool operator()(const T& lhs, const T& rhs) const { return translation::compare((*fptr)(lhs), (*fptr)(rhs)) < 0; } }; 20180328 01:21:31<+discordbot> or 20180328 01:21:32<+discordbot> wait, no 20180328 01:21:34<+discordbot> that's wrong 20180328 01:22:33<+discordbot> hmmmmmmmm 20180328 01:22:40<+discordbot> actually, not sure the right syntax for this 20180328 01:23:25 * celticminstrel wonders if the original SotA translators are also listed in the main translation credits. 20180328 01:23:47<+discordbot> Imean, this would work, I think 20180328 01:23:57<+discordbot> but you'd need to define the getter function 20180328 01:24:13-!- nurupo [~nurupo.ga@unaffiliated/nurupo] has quit [Ping timeout: 252 seconds] 20180328 01:24:14<+discordbot> for type T 20180328 01:24:54<+discordbot> or 20180328 01:25:10<+discordbot> wait, wasn't there a thing you said once about how T::member could then be called on this? 20180328 01:26:06<+discordbot> eh, nevermind, t'is too complcated 20180328 01:26:17< celticminstrel> I'm not even sure what you're getting at. 20180328 01:26:25-!- nurupo [~nurupo.ga@unaffiliated/nurupo] has joined #wesnoth-dev 20180328 01:27:39<+discordbot> idle musings 20180328 01:29:02<+discordbot> btw, how goes the schema? 20180328 01:29:10<+discordbot> have you had a chance to try it with std::regex? 20180328 01:29:21< celticminstrel> Still struggling with the AI stuff. 20180328 01:29:28< celticminstrel> I haven't had a change to try std::regex. 20180328 01:35:57< celticminstrel> ^chance 20180328 01:36:55<+discordbot> I can definitely use std::make_move_iterator for std::list::insert, though? 20180328 01:38:32<+discordbot> or wait, I don't need the temporary vector 20180328 01:39:16< celticminstrel> I'll note that std::list::insert is AFAIK constant time. 20180328 01:39:44< celticminstrel> Also, if you want the equivalent of move, you may wish to consider splice. 20180328 01:39:46<+discordbot> ? 20180328 01:40:02<+discordbot> huh 20180328 01:40:06<+discordbot> very interesting 20180328 01:40:21<+discordbot> yeah, I might just use that, assuming I don't use a temp 20180328 01:40:21< celticminstrel> Inserting an element at an arbitrary location in a linked list is at worst linear time (finding the element); it's constant time if you already know where to insert it. 20180328 01:40:26<+discordbot> er 20180328 01:40:28<+discordbot> i DO Use a temp 20180328 01:40:32< celticminstrel> It's literally just updating two pointers. 20180328 01:40:39< celticminstrel> Well okay. Four pointers. 20180328 01:40:45< celticminstrel> Since this is a doubly-linked list. 20180328 01:41:27<+discordbot> I may not even use a temporary 20180328 01:57:01< irker906> wesnoth/wesnoth:opengl Jyrki Vesterinen 5f6dda55db Integrate GLEW to the Visual Studio proj AppVeyor: 2/4 builds failed 20180328 01:57:02< irker906> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-opengl-2310 20180328 01:57:03< irker906> Details vs2017/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-opengl-2017 20180328 02:01:06-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20180328 02:01:32< celticminstrel> FTR I'm not going to be doing anything with std::regex in schema until well after it's finished. 20180328 02:01:59< celticminstrel> (Where "finished" excludes HelpWML and ThemeWML since they are a) not very user-visible and b) scheduled for major overhaul.) 20180328 02:02:24< celticminstrel> I'm intentionally working on 1.14 branch since that's where any potential errors I uncover would need to be fixed. 20180328 02:02:44< celticminstrel> So I won't be rebasing it onto master until after it's basically done. 20180328 02:12:42-!- Bonobo [~Bonobo@203.220.138.198] has joined #wesnoth-dev 20180328 02:39:41<+discordbot> makes sense 20180328 02:39:52<+discordbot> I only bring it up since you might need to change the syntax to work with std::regex 20180328 02:40:05< celticminstrel> Shouldn't need to. 20180328 02:40:15< celticminstrel> None of the regexes are particularly complicated AFAIK. 20180328 02:40:37< celticminstrel> As long as I make sure it uses JS-style there should be no issues... and IIRC that was the default? 20180328 02:40:54<+discordbot> EMScript is supposedly the default 20180328 02:41:02< celticminstrel> Exactly. 20180328 02:41:45< celticminstrel> ECMAScript is the "formal" name for JavaScript. 20180328 02:43:29<+discordbot> well, the problem was somewhere in the use of formula values 20180328 02:44:13<+discordbot> all the schema failures were formula values 20180328 02:50:54< celticminstrel> BTW have you added anything to the GUI2 schema recently? 20180328 02:51:18< celticminstrel> At some point I want to condense it down using the new schema features (and macros), but maybe that should wait until after merging. 20180328 02:59:14<+discordbot> yes 20180328 02:59:21<+discordbot> Just the other day 20180328 02:59:43<+discordbot> [text] font_size= from unsigned to f_unsigned. 20180328 03:00:03<+discordbot> added [text_box] hint_text (type t_string) and hint_image (type string) 20180328 03:03:00< celticminstrel> Guess it's best to hold off until merging after all, then. 20180328 03:03:21<+discordbot> why? 20180328 03:03:38< celticminstrel> Well, in case you need to add more stuff to the GUI2 schema. 20180328 03:03:53< celticminstrel> The thing being held off is working on the GUI2 schema. 20180328 03:03:54<+discordbot> I see 20180328 03:03:59< celticminstrel> Not working on the schema in general. 20180328 03:04:33<+discordbot> ponders making the topic struct templated 20180328 03:05:29<+discordbot> I suppose it's not necessary... could just have a template set_generator function 20180328 03:07:17<+discordbot> though this would probably be more convenient 20180328 03:09:59<+discordbot> ah, actually, can't do that 20180328 03:33:17< celticminstrel> ...is there any way in [filter_wml] to match the absence of a key? 20180328 03:34:19 * celticminstrel also wishes you could pattern match on the values of the keys, but I'm not sure how that could be done without hurting the ability to match some reasonable values. 20180328 03:34:39< celticminstrel> Pattern matching on the values is actually what's needed for [modify_ai] though... 20180328 03:35:49< celticminstrel> @jyrkive, you worked on the glob function recently, do you know if there's a way to escape the metacharacters? 20180328 03:37:11< celticminstrel> Oh wait, I should probably try passing "don't remove empty" to split() to see if perhaps key= actually does match the absence of the key (though I suspect it won't). 20180328 03:39:45<+discordbot> celticminstrel: No, our glob syntax doesn't have a way to escape metacharacters. 20180328 03:43:46< celticminstrel> Which means allowing it in [filter_wml] could potentially be worse than just a compatibility-breaking change. 20180328 03:44:28 * celticminstrel should add quotes around "just" 20180328 03:53:39< celticminstrel> I suppose what I could do is add support for something like missing_*=yes and match_*=pattern. 20180328 03:54:04< celticminstrel> Perhaps a bit different, we do want to try and avoid potential conflicts with real attribute names. 20180328 03:54:14< celticminstrel> This sort of thing is precedented in the merge syntax though. 20180328 03:54:24< celticminstrel> add_to_* and concat_to_* IIRC. 20180328 03:54:32< celticminstrel> And __delete=yes for tags. 20180328 03:55:06< celticminstrel> Maybe we should make a rule that these sorts of keys always begin with a double underscore? (And add the double underscore in the case of __add_to_* and __concat_to_*) 20180328 03:55:41< celticminstrel> I mean, if we wanted we could even embrace the new ability to have $ in keys and use it for this. :P (Not sure I'd recommend that though.) 20180328 03:58:50< celticminstrel> BTW, doesn't SDL provide some OpenGL extension management? Do we actually need GLEW? (Not that I mind having it, just wondering.) 20180328 03:59:14<+discordbot> I'm not aware of such a feature. 20180328 03:59:47< celticminstrel> I could be imagining it. (Or just unclear on what OpenGL extension management actually entails.) 20180328 04:00:07<+discordbot> well there is https://wiki.libsdl.org/SDL_GL_LoadLibrary 20180328 04:00:48<+discordbot> Most notably, OpenGL extension management requires exporting every function ever added to OpenGL after version 1.4. 20180328 04:01:01<+discordbot> AFAIK, SDL definitely doesn't do that. 20180328 04:01:16< celticminstrel> So, is not sufficient? 20180328 04:01:22< celticminstrel> Or was it GL.h? 20180328 04:01:25< celticminstrel> I forget. 20180328 04:01:30<+discordbot> and https://wiki.libsdl.org/SDL_GL_GetProcAddress 20180328 04:01:38<+discordbot> but 20180328 04:01:39<+discordbot> IIRC, it's SDL_opengl.h. 20180328 04:01:39<+discordbot> "If the GL library is loaded at runtime with SDL_GL_LoadLibrary(), then all GL functions must be retrieved this way. Usually this is used to retrieve function pointers to OpenGL extensions." 20180328 04:01:43< celticminstrel> Right, that one. 20180328 04:01:52<+discordbot> isn't that version og OGL ancient 20180328 04:02:08<+discordbot> It #includes the system's , which is only OpenGL 1.4 on Windows. 20180328 04:02:10< celticminstrel> I think my computer runs 1.2. :P 20180328 04:02:37< celticminstrel> Huh? I thought SDL_opengl.h also defined a whole slew of additional contants and possibly some functions. 20180328 04:02:54< celticminstrel> Uhh. Declared. Not defined. 20180328 04:03:27<+discordbot> I think it indeed declares some other stuff in addition to just #including gl.h. 20180328 04:03:30<+discordbot> the only SDL GL helpers are these 20180328 04:03:33<+discordbot> SDL_GL_CreateContext SDL_GL_DeleteContext SDL_GL_ExtensionSupported SDL_GL_GetAttribute SDL_GL_GetCurrentContext SDL_GL_GetCurrentWindow SDL_GL_GetDrawableSize SDL_GL_GetProcAddress SDL_GL_GetSwapInterval SDL_GL_LoadLibrary SDL_GL_MakeCurrent SDL_GL_ResetAttributes SDL_GL_SetAttribute SDL_GL_SetSwapInterval SDL_GL_SwapWindow SDL_GL_UnloadLibrary 20180328 04:03:48<+discordbot> Anyway, my point was that it does not export any functions added to OpenGL after version 1.4. 20180328 04:04:17<+discordbot> Even glTexSubImage isn't available that way IIRC. 20180328 04:04:52<+discordbot> "Windows users new to OpenGL should note that, for historical reasons, GL functions added after OpenGL version 1.1 are not available by default. Those functions must be loaded at run-time, either with an OpenGL extension-handling library or with SDL_GL_GetProcAddress() and its related functions." 20180328 04:07:37< celticminstrel> Force-pushing schema. I guess it might also duplicate a few 1.14 commits or something... 20180328 04:08:03< irker906> wesnoth: Celtic Minstrel wesnoth:schema b5757f83042d / / (44 files in 10 dirs): Implement validation of the core game config WML https://github.com/wesnoth/wesnoth/commit/b5757f83042d99ee650b15579a63cdc629e0d2e6 20180328 04:08:05< irker906> wesnoth: Celtic Minstrel wesnoth:schema 59c4ff38e077 / data/schema/core/addons.cfg: Address some feedback https://github.com/wesnoth/wesnoth/commit/59c4ff38e077aeddf46276590ab2018462ad30f9 20180328 04:08:07< irker906> wesnoth: Celtic Minstrel wesnoth:schema 9447cc93b038 / data/schema/ (core/config.cfg game_config.cfg terrain/graphics.cfg): Address a few TODO notes https://github.com/wesnoth/wesnoth/commit/9447cc93b038b2e0023e74d560b10cabc9d7c93f 20180328 04:08:09< irker906> wesnoth: Celtic Minstrel wesnoth:schema ca2b2b175360 / data/gui/schema.cfg data/schema/gui.cfg src/gui/gui.cpp: Move GUI2 schema into the schema directory https://github.com/wesnoth/wesnoth/commit/ca2b2b1753609cf84db5d9e1d5877a38c0033e51 20180328 04:08:11< irker906> wesnoth: Celtic Minstrel wesnoth:schema 69d1c6168740 / / (5 files in 3 dirs): Get game config and schema to use some common types https://github.com/wesnoth/wesnoth/commit/69d1c61687407e7c9daf483c77722b2ad5d5e41f 20180328 04:08:11< celticminstrel> Guess not, good to know. 20180328 04:08:13< irker906> wesnoth: Celtic Minstrel wesnoth:schema 9201904e8344 / / (5 files in 2 dirs): Enable nesting of [type] tags https://github.com/wesnoth/wesnoth/commit/9201904e83442ae2267c690f8d97d9f800734ceb 20180328 04:08:15< irker906> wesnoth: Celtic Minstrel wesnoth:schema 8f8f00fa472e / src/serialization/tag.hpp: Super-rudimentary documentation... https://github.com/wesnoth/wesnoth/commit/8f8f00fa472e0bfe734ce3451d853a6e95b86922 20180328 04:08:17< irker906> wesnoth: Celtic Minstrel wesnoth:schema 1e88ebd663b6 / / (9 files in 3 dirs): Support [switch] and [if] in [tag] https://github.com/wesnoth/wesnoth/commit/1e88ebd663b6614be1284ee7b0014c1b4216ced3 20180328 04:08:19< irker906> wesnoth: Celtic Minstrel wesnoth:schema 649c1a57ea93 / src/serialization/ (tag.cpp tag.hpp): Fix crash if a tag has conditions but no subtags https://github.com/wesnoth/wesnoth/commit/649c1a57ea939d7b9201e1f36c3bbb42795252c0 20180328 04:08:21< irker906> wesnoth: Celtic Minstrel wesnoth:schema 37e766fa9dbe / data/schema/units/modifications.cfg: fixup! Support [switch] and [if] in [tag] https://github.com/wesnoth/wesnoth/commit/37e766fa9dbe054124dadcd3d898136e32b60e5a 20180328 04:08:23< irker906> wesnoth: Celtic Minstrel wesnoth:schema 51902b66fc54 / / (4 files in 3 dirs): Support multiple super tags and even conditional super tags https://github.com/wesnoth/wesnoth/commit/51902b66fc54ee506f39016bfdad1a5e198efb17 20180328 04:08:25< irker906> wesnoth: Celtic Minstrel wesnoth:schema 2a0018209b97 / data/schema/units/specials.cfg: Missed a couple weapon special definitions https://github.com/wesnoth/wesnoth/commit/2a0018209b97cfa9b40ac51f68cd2fd2f1805d52 20180328 04:08:27< irker906> wesnoth: Celtic Minstrel wesnoth:schema f5937a83c55b / data/schema/core/addons.cfg: Use a few more conditional tag elements https://github.com/wesnoth/wesnoth/commit/f5937a83c55beeca46e35e530ac005cb2314e250 20180328 04:08:29< irker906> wesnoth: Celtic Minstrel wesnoth:schema 955a4b85ab83 / data/schema/game_config.cfg src/serialization/tag.cpp: Fix matching of list types with limits https://github.com/wesnoth/wesnoth/commit/955a4b85ab8335f344b9416538f4ad5f82f824fb 20180328 04:08:31< irker906> wesnoth: Celtic Minstrel wesnoth:schema 7e6705fa295f / data/schema/units/modifications.cfg src/serialization/tag.cpp: Schema: Accept [elseif] in [if] and change [switch][default] to [else] https://github.com/wesnoth/wesnoth/commit/7e6705fa295fb268bc066a37f88cc60f1cca3930 20180328 04:08:33< irker906> wesnoth: Celtic Minstrel wesnoth:schema c4308420b1a5 / data/schema/ (10 files in 3 dirs): WIP Schema for the AI WML https://github.com/wesnoth/wesnoth/commit/c4308420b1a51177906c24bc472a870caebaeab1 20180328 04:08:44< celticminstrel> The last two are the new commits FTR. 20180328 04:08:50<+discordbot> "files changed: 1,310" 20180328 04:09:13<+discordbot> guess COmpare CHanges not what I want 20180328 04:09:26< celticminstrel> Probably because the branch is open against master but applied against 1.14. 20180328 04:09:45< celticminstrel> So it looks like it's undoing all of accelerated_rendering and gui2_help and a whole slew of other stuff that's new in master. 20180328 04:09:54<+discordbot> y u do dis 20180328 04:09:58< celticminstrel> Obviously it won't be merged until it's rebased against master. 20180328 04:10:09< celticminstrel> But ATM I'm working on it on 1.14 for the reasons I mentioned earlier. 20180328 04:10:40< celticminstrel> For now if you want to look I'd suggest just viewing the diffs of the individual commits. 20180328 04:10:42<+discordbot> there are some spurious commits listed in the PR 20180328 04:14:13< celticminstrel> Not surprised. 20180328 04:14:32< celticminstrel> It was rebased against something at some point but it's very much not against latest master. 20180328 04:15:27< celticminstrel> Okay yeah, as I expected, those are commits from the 1.14 branch after it diverged. 20180328 04:15:47< celticminstrel> Oh, argh, I forgot to satisfy codacy again. Let me just do that quickly... 20180328 04:17:18< irker906> wesnoth: Celtic Minstrel wesnoth:schema 97ffb40c0d46 / src/serialization/tag.hpp: Add explicit qualifiers to satisfy codacy https://github.com/wesnoth/wesnoth/commit/97ffb40c0d46367cd6cfd6fdbd58a45bee2fe6c7 20180328 04:18:25< celticminstrel> Wonder why Appveyor couldn't build it. 20180328 04:18:40< celticminstrel> Doesn't really matter, it doesn't need to pass right now, but kinda odd. 20180328 04:19:16< celticminstrel> So anyway. 20180328 04:19:41< celticminstrel> Can anyone see anything I might be doing wrong in https://github.com/wesnoth/wesnoth/blob/c4308420b1a51177906c24bc472a870caebaeab1/data/schema/ai/_main.cfg ? 20180328 04:20:01< celticminstrel> It keeps complaining that [facet] or [value] isn't allowed and that bool values aren't allowed in boolean aspects. 20180328 04:20:15< celticminstrel> Oh, that's the wrong file. 20180328 04:20:28< celticminstrel> https://github.com/wesnoth/wesnoth/blob/c4308420b1a51177906c24bc472a870caebaeab1/data/schema/ai/aspect_complex.cfg 20180328 04:21:04< celticminstrel> (It is pretty convoluted, I'll admit... which is probably a large part of why I'm having difficulty tracking down the error. >_> ) 20180328 04:26:23< celticminstrel> I guess I'll ask again tomorrow. I'll probably put the aspects on hold for a bit though while I do [modify_ai]. 20180328 04:26:35-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The computer falls into a deep sleep, to awake again some other day!] 20180328 04:34:41-!- grzywacz [~karol@89-70-226-147.dynamic.chello.pl] has joined #wesnoth-dev 20180328 04:37:51< irker906> wesnoth/wesnoth:1.14 Iris Morelle be21b30232 SotA: Drop UMC translations section from AppVeyor: All builds passed 20180328 05:10:21-!- grzywacz [~karol@89-70-226-147.dynamic.chello.pl] has quit [Ping timeout: 240 seconds] 20180328 06:00:27-!- Oebele [~quassel@143.177.58.202] has joined #wesnoth-dev 20180328 06:28:16-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20180328 06:29:15-!- commavir [vir@2604:180::502b:135a] has quit [Ping timeout: 246 seconds] 20180328 06:31:21-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev 20180328 06:31:27-!- Bonobo [~Bonobo@203.220.138.198] has quit [Ping timeout: 240 seconds] 20180328 06:31:58-!- Bonobo [~Bonobo@203.220.138.198] has joined #wesnoth-dev 20180328 06:33:28-!- travis-ci [~travis-ci@ec2-54-157-236-220.compute-1.amazonaws.com] has joined #wesnoth-dev 20180328 06:33:29< travis-ci> Pentarctagon/wesnoth#368 (cmake-remove-tools-var - 06fcd3b : pentarctagon): The build failed. 20180328 06:33:29< travis-ci> Build details : https://travis-ci.org/Pentarctagon/wesnoth/builds/359147451 20180328 06:33:29-!- travis-ci [~travis-ci@ec2-54-157-236-220.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180328 06:40:04-!- commavir [vir@2604:180::502b:135a] has joined #wesnoth-dev 20180328 06:40:47-!- grzywacz [~karol@89.70.226.147] has joined #wesnoth-dev 20180328 06:45:12-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [] 20180328 07:14:45-!- grzywacz [~karol@89.70.226.147] has quit [Ping timeout: 256 seconds] 20180328 07:36:25< irker906> wesnoth/wesnoth:master pentarctagon 0bbc78945e Remove tools-external-libs. AppVeyor: All builds passed 20180328 07:58:01-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20180328 08:03:58<+discordbot> If you have a ctor that takes a unique_ptr argument, does it have to be an rvalue reference? 20180328 08:04:34<+discordbot> You can receive it either by value or by reference. 20180328 08:05:09<+discordbot> If you receive it by value, the caller has to call it with a rvalue reference so that it can be moved to the callee. 20180328 08:09:53<+discordbot> does make_unique in the context of an emplace call count as rvalue reference? ie, cpp topics.emplace_back(id, title, std::make_unique(std::forward(generator_args)...)); 20180328 08:10:10<+discordbot> Losing track due to the multiple levels of forwarding here.. 20180328 08:10:34<+discordbot> Yes. Because you haven't bound the return value to a variable, it's an rvalue reference. 20180328 08:12:28<+discordbot> ok, thanks 20180328 08:45:54-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity] 20180328 09:06:41<+discordbot> @jyrkive opengl branch crashes without backtrace on start 20180328 09:06:51<+discordbot> no message about inicialization 20180328 09:08:41<+discordbot> On macOS? 20180328 09:09:42<+discordbot> yes 20180328 09:09:49<+discordbot> Preparing PR with fixed project 20180328 09:10:17<+discordbot> Okay, so that's how you got it to compile. 😅 Also, thanks. 20180328 09:10:30<+discordbot> Does it log anything on startup? 20180328 09:10:52<+discordbot> yes 20180328 09:10:58<+discordbot> sec 20180328 09:11:29<+discordbot> also window pop up but stay black and after ~2sec exita 20180328 09:19:36< irker906> wesnoth: Sofartin wesnoth:opengl 453b1eda3ce7 / projectfiles/Xcode/ (Fix_Xcode_Dependencies Wesnoth.xcodeproj/project.pbxproj): Fixed Xcode Project for OpenGL https://github.com/wesnoth/wesnoth/commit/453b1eda3ce74243cc5ef30f4e1775ca9b14451a 20180328 09:34:54<+discordbot> Sorry @jyrkive , I runned out of battery, but messages were same as for normal wesnoth until “setting screen res 1440x800”. It printed this message, showed blank window (possibly before this message) and then exited. I must research around it more 20180328 09:35:12-!- Nobun [~user@51.179.98.217] has joined #wesnoth-dev 20180328 09:35:36<+discordbot> Hm. Sounds like it doesn't even try to initialize OpenGL. 20180328 09:35:37<+discordbot> Behaviour was same as iOS fullscreen bug @sinda 20180328 09:35:47<+discordbot> It may be connected 20180328 09:35:48<+discordbot> You could try --log-info opengl. 20180328 09:36:14<+discordbot> Sure. I’ll try once I’ll get near to charger 20180328 09:36:17<+discordbot> 😃 20180328 09:36:17< Nobun> sorry for boring you again. I'm stuck on understanding: conf = env.Configure(**configure_args) 20180328 09:36:55< Nobun> in the (almost silent) documentation of env.Configure() I should expect to see 'env' as parameter 20180328 09:37:29<+discordbot> I think it's some kind of Python syntax trick. 20180328 09:37:35< Nobun> but this case you should see things like "CheckSDL", execute CheckSDL 20180328 09:37:45<+discordbot> I don't know enough Python to determine what exactly it does. 20180328 09:38:01< Nobun> jyrkive. Thank for trying 20180328 09:38:27< Nobun> http://scons.org/doc/1.1.0/HTML/scons-user/x4023.html 20180328 09:38:38< Nobun> this scons page show a very different sybtax for Configure 20180328 09:39:14< Nobun> this why I am not understanding. The trouble is to try to understand what env.Configure should be exactly 20180328 09:39:21<+discordbot> SCons manual can show that there are two allowed ways to call Configure(). 20180328 09:39:27<+discordbot> "Configure(env, [custom_tests, conf_dir, log_file, config_h]) , env.Configure([custom_tests, conf_dir, log_file, config_h])" 20180328 09:39:34<+discordbot> http://scons.org/doc/production/HTML/scons-man.html 20180328 09:41:42< Nobun> thank again. Now it seems a bit clearer 20180328 09:42:27< Nobun> and now I perhaps get why configure_args = dict( 20180328 09:42:29< Nobun> custom_tests = init_metasconf(env, ["ieee_754", "cplusplus", "python_devel", "sdl", "boost", "cairo", "pango", "pkgconfig", "gettext_tool", "lua"]), 20180328 09:43:14< Nobun> until now I didn't understand why dict contained "custom_tests" 20180328 09:44:14< Nobun> but I figure that it should be somehow related to Configure(env, [-> custom_tests <- ... 20180328 09:49:27< irker906> wesnoth/wesnoth:opengl Sofartin 453b1eda3c Fixed Xcode Project for OpenGL AppVeyor: vs2017/Release Failed 20180328 09:49:28< irker906> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-opengl-2031 20180328 09:50:16< Nobun> yeah now I got it 20180328 09:50:51< Nobun> it was a little hard to understand, but I undertand also that line. Thank again for help, jyrkive 20180328 10:28:21-!- Appleman1234 [~quassel@124x38x163x22.ap124.ftth.ucom.ne.jp] has quit [Quit: http://quassel-irc.org - Chat comfortably. Anywhere.] 20180328 10:35:47< Nobun> reading deeper the scons source a thing that I though it was clear, I discovered it is not. 20180328 10:36:03< Nobun> configure_args = dict( 20180328 10:36:05< Nobun> custom_tests = init_metasconf 20180328 10:36:46< Nobun> the unclear part is custom_tests when it will be used by env.Configure 20180328 10:36:53< Nobun> I mean 20180328 10:37:38< Nobun> after running init_metasconf, it will be return a dictionary of all the pairs of "function names" and "functions", and any function will have their own parameters 20180328 10:37:52-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180328 10:38:57< Nobun> I can't understand how env.Configure can actually use, for example, CheckSDL, without any of the defined arguments in the function 20180328 10:39:18<+discordbot> See https://github.com/wesnoth/wesnoth/tree/master/scons 20180328 10:39:35<+discordbot> Each string in that list is a name of a script in that folder. 20180328 10:40:10<+discordbot> The test from each script is then injected to the environment. 20180328 10:40:34<+discordbot> For example CheckSDL is defined here: https://github.com/wesnoth/wesnoth/blob/master/scons/sdl.py#L8 20180328 10:43:10< Nobun> oh well. I didn't think about file name, actually. My failure. However it is not clear to me how Configure will use CheckSDL, since CheckSDL requires four parameters, and the first one does not have a default value 20180328 10:44:00< Nobun> (the first should be, I think, the enviornment itself or something similar) 20180328 10:45:09<+discordbot> The first parameter is a SCons CheckContext. 20180328 10:45:27<+discordbot> Search "CheckContext" in SCons manual for information. 20180328 10:46:07< Nobun> yeah I'm reading. 20180328 10:46:08<+discordbot> The manual also has a short example about using custom tests. 20180328 10:48:52< Nobun> so, if I understood well 20180328 10:50:49< Nobun> ah no. THere is something I can't understand. I will think it a bit and then I will ask. 20180328 10:53:53< Nobun> ok. So configure actually don't directly "use" the function, but inject the function that will be actually used during the configure step, when calling conf.something 20180328 10:53:59< Nobun> right? 20180328 10:55:02<+discordbot> Correct. SCons generates the function conf.CheckSDL(), which calls CheckSDL() we have defined in sdl.py. 20180328 10:57:10< Nobun> only a curiosity: you "override" custom path to "scons". But if I will use the same method I must put my "imports" in site_scons/site_tools right? 20180328 10:57:40< Nobun> I mean without overriding custom path for tools 20180328 10:58:17<+discordbot> I think so. 20180328 10:59:53< Nobun> again thank. For the moment my questions stops there (I will continue analyzing wesnoth scons and learning scons another day) 20180328 11:06:09-!- Nobun [~user@51.179.98.217] has quit [Quit: WeeChat 2.1-dev] 20180328 11:23:39-!- Appleman1234 [~quassel@124x38x163x22.ap124.ftth.ucom.ne.jp] has joined #wesnoth-dev 20180328 11:26:59<+discordbot> @jyrkive MacBook-Pro:MacOS user$ ./Wesnoth --log-info opengl objc[6674]: Class SDLApplication is implemented in both /Users/user/xcode/wesnoth_opengl/projectfiles/Xcode/Build/Products/Debug/Wesnoth.app/Contents/Frameworks/SDL2.framework/Versions/A/SDL2 (0x10e50a680) and /Users/user/xcode/wesnoth_opengl/projectfiles/Xcode/Build/Products/Debug/Wesnoth.app/Contents/MacOS/./Wesnoth (0x10b0257b8). One of the two will be used. Which 20180328 11:26:59<+discordbot> one is undefined. Battle for Wesnoth v1.15.0-dev (f563436dc6-Modified) Started on Wed Mar 28 13:26:16 2018 Automatically found a possible data directory at /Users/USER/xcode/wesnoth_opengl/projectfiles/Xcode/Build/Products/Debug/Wesnoth.app/Contents/Resources Fontconfig warning: "./fonts.conf", line 146: blank doesn't take any effect anymore. please remove it from your fonts.conf Data directory: 20180328 11:27:00<+discordbot> /Users/USER/xcode/wesnoth_opengl/projectfiles/Xcode/Build/Products/Debug/Wesnoth.app/Contents/Resources User configuration directory: /Users/USER/Library/Application Support/Wesnoth_1.13 User data directory: /Users/USER/Library/Application Support/Wesnoth_1.13 Cache directory: /Users/USER/Library/Application Support/Wesnoth_1.13/cache Setting mode to 1440x878 20180328 13:26:17 info opengl: Using OpenGL core profile 20180328 11:27:00<+discordbot> version 4.1 INTEL-10.32.48 20180328 13:26:17 info opengl: GPU: Intel Inc. Intel(R) Iris(TM) Graphics 650 20180328 11:27:50<+discordbot> So, OpenGL initialization succeeds. 20180328 11:28:18<+discordbot> yes 20180328 11:28:38<+discordbot> When I was testing it, the game crashed in the first time (apparently it thought that window size is 0x0). I failed to reproduce the crash later on, though. 20180328 11:29:38<+discordbot> I believe the crash will go away once I get window size calculation to work. (That will take a long time, I'll initially focus on writing low-level classes.) 20180328 12:26:36-!- travis-ci [~travis-ci@ec2-54-157-236-220.compute-1.amazonaws.com] has joined #wesnoth-dev 20180328 12:26:37< travis-ci> wesnoth/wesnoth#17292 (master - 4799ca0 : Iris Morelle): The build was canceled. 20180328 12:26:37< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/359113164 20180328 12:26:37-!- travis-ci [~travis-ci@ec2-54-157-236-220.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180328 12:49:40-!- irker906 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout] 20180328 13:17:42-!- matthiaskrgr [matthiaskr@gateway/shell/panicbnc/x-htzrtgjsghetfiug] has quit [Ping timeout: 246 seconds] 20180328 13:33:07-!- matthiaskrgr [matthiaskr@gateway/shell/panicbnc/x-nzfmrfnrlplkxirw] has joined #wesnoth-dev 20180328 13:33:30-!- matthiaskrgr is now known as Guest33597 20180328 13:35:06-!- Guest33597 [matthiaskr@gateway/shell/panicbnc/x-nzfmrfnrlplkxirw] has quit [Changing host] 20180328 13:35:06-!- Guest33597 [matthiaskr@unaffiliated/matthiaskrgr] has joined #wesnoth-dev 20180328 13:35:06-!- Guest33597 [matthiaskr@unaffiliated/matthiaskrgr] has quit [Changing host] 20180328 13:35:06-!- Guest33597 [matthiaskr@gateway/shell/panicbnc/x-nzfmrfnrlplkxirw] has joined #wesnoth-dev 20180328 13:35:21-!- Guest33597 is now known as matthiaskrgr_ 20180328 13:44:35-!- travis-ci [~travis-ci@ec2-54-197-142-109.compute-1.amazonaws.com] has joined #wesnoth-dev 20180328 13:44:36< travis-ci> wesnoth/wesnoth#17295 (master - 0bbc789 : pentarctagon): The build passed. 20180328 13:44:36< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/359155881 20180328 13:44:36-!- travis-ci [~travis-ci@ec2-54-197-142-109.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180328 14:21:00-!- grzywacz [~karol@89-70-226-147.dynamic.chello.pl] has joined #wesnoth-dev 20180328 14:41:21-!- grzywacz [~karol@89-70-226-147.dynamic.chello.pl] has quit [Ping timeout: 246 seconds] 20180328 14:49:33-!- irker344 [~irker@uruz.ai0867.net] has joined #wesnoth-dev 20180328 14:49:33< irker344> wesnoth/wesnoth:opengl Sofartin 453b1eda3c Fixed Xcode Project for OpenGL AppVeyor: 2/4 builds failed 20180328 14:49:34< irker344> Details vs2017/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-opengl-2031 20180328 14:49:34< irker344> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-opengl-2324 20180328 14:51:57-!- vn971 [~vasya@94.158.103.15] has quit [Quit: Leaving.] 20180328 14:55:31-!- travis-ci [~travis-ci@ec2-54-157-236-220.compute-1.amazonaws.com] has joined #wesnoth-dev 20180328 14:55:33< travis-ci> wesnoth/wesnoth#17296 (schema - c430842 : Celtic Minstrel): The build is still failing. 20180328 14:55:33< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/359200769 20180328 14:55:33-!- travis-ci [~travis-ci@ec2-54-157-236-220.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180328 15:09:56-!- commavir [vir@2604:180::502b:135a] has quit [Ping timeout: 276 seconds] 20180328 15:11:10-!- commavir [vir@2604:180::502b:135a] has joined #wesnoth-dev 20180328 15:22:42-!- vn971 [~vasya@94.158.103.15] has joined #wesnoth-dev 20180328 15:33:31-!- matthiaskrgr_ [matthiaskr@gateway/shell/panicbnc/x-nzfmrfnrlplkxirw] has quit [Ping timeout: 245 seconds] 20180328 15:38:59-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180328 15:39:05-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180328 15:55:00< irker344> wesnoth: Jyrki Vesterinen wesnoth:opengl c4a4ffe3e833 / src/ogl/context.cpp: Stop logging GL_VENDOR https://github.com/wesnoth/wesnoth/commit/c4a4ffe3e8330032659693d3f981cf10849d0bf2 20180328 15:56:03-!- travis-ci [~travis-ci@ec2-54-197-142-109.compute-1.amazonaws.com] has joined #wesnoth-dev 20180328 15:56:04< travis-ci> wesnoth/wesnoth#17297 (schema - 97ffb40 : Celtic Minstrel): The build is still failing. 20180328 15:56:04< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/359202358 20180328 15:56:04-!- travis-ci [~travis-ci@ec2-54-197-142-109.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180328 16:08:03-!- gfgtdf [~chatzilla@x4e36815a.dyn.telefonica.de] has joined #wesnoth-dev 20180328 16:22:01-!- matthiaskrgr [matthiaskr@gateway/shell/panicbnc/x-umtglvwjcutuehdl] has joined #wesnoth-dev 20180328 16:22:25-!- matthiaskrgr is now known as Guest28297 20180328 16:46:25-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180328 16:46:31-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180328 16:50:49-!- Oebele [~quassel@143.177.58.202] has quit [Remote host closed the connection] 20180328 17:05:01< zookeeper> gfgtdf, so the thing i don't know is what has changed in the API since we last discussed how that stuff should work and i added force_lock_settings=yes to that scenario. because that didn't completely break things then. 20180328 17:08:57< gfgtdf> zookeeper: i think it's probably this one: https://github.com/wesnoth/wesnoth/commit/c64c6f513aeb2037669ec35987f74edf5c9c7247 20180328 17:10:46-!- Bonobo [~Bonobo@203.220.138.198] has quit [Ping timeout: 256 seconds] 20180328 17:21:51-!- Guest28297 [matthiaskr@gateway/shell/panicbnc/x-umtglvwjcutuehdl] has quit [Changing host] 20180328 17:21:51-!- Guest28297 [matthiaskr@unaffiliated/matthiaskrgr] has joined #wesnoth-dev 20180328 17:21:51-!- Guest28297 [matthiaskr@unaffiliated/matthiaskrgr] has quit [Changing host] 20180328 17:21:51-!- Guest28297 [matthiaskr@gateway/shell/panicbnc/x-umtglvwjcutuehdl] has joined #wesnoth-dev 20180328 17:22:05-!- Guest28297 is now known as matthiaskrgr 20180328 18:02:50-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev 20180328 18:10:37-!- new_one [~new_one@2604:a880:1:20::22e:d001] has quit [Quit: WeeChat 1.1.1] 20180328 18:12:50<+discordbot> window size calculations? 20180328 18:13:10<+discordbot> I didn't look closer. 20180328 18:13:28<+discordbot> The game crashed because it thought that window size was 0x0. That's all I know. 20180328 18:18:08<+discordbot> unrelated, but this looks like something @hrubymar10 should set if not already: On Apple's OS X you must set the NSHighResolutionCapable Info.plist property to YES, otherwise you will not receive a High DPI OpenGL canvas. 20180328 18:18:51<+discordbot> Receiving a high-DPI canvas may be worse if we don't have native DPI scaling support... 20180328 18:19:11<+discordbot> This didn't work before, I can try it again now with A-R 20180328 18:19:25<+discordbot> so, on master. 20180328 18:19:51<+discordbot> I'm not working on a_r anymore since it's been merged, just to be clear. 20180328 18:22:17<+discordbot> ofc, I get it and I'll do that 20180328 18:22:59<+discordbot> though also note I doubt it would do anything on master unless SDL chose ogl as its rendering backend.. 20180328 18:25:05<+discordbot> though since you don't have DX, it's very likely, I guess? 20180328 18:25:47<+discordbot> DX stands for DirectX? 20180328 18:25:55<+discordbot> yes 20180328 18:26:14<+discordbot> DirectX is only for Windows AFAIK 20180328 18:26:37<+discordbot> in new OpenGL branch there is version with uses GLEW 20180328 18:26:53<+discordbot> yes 20180328 18:28:07<+discordbot> @jyrkive btw, there's an old branch from 2010 that has some unfinished OGL stuff. Dunno if any of it is at all useful at this point, but it might be worth looking at: https://github.com/wesnoth/wesnoth/commits/ogl 20180328 18:37:04-!- travis-ci [~travis-ci@ec2-54-221-15-98.compute-1.amazonaws.com] has joined #wesnoth-dev 20180328 18:37:05< travis-ci> wesnoth/wesnoth#17300 (opengl - c4a4ffe : Jyrki Vesterinen): The build is still failing. 20180328 18:37:05< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/359433793 20180328 18:37:05-!- travis-ci [~travis-ci@ec2-54-221-15-98.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180328 18:38:36<+discordbot> Quick look shows that the code in the ogl branch uses obsolete functions and is badly optimized. 20180328 18:38:41<+discordbot> Example: https://github.com/wesnoth/wesnoth/commit/f699119aa2c722c9726a476010bc238ef0cf9f06 20180328 18:39:49<+discordbot> The glBegin()/glEnd()/glVertex2i() stuff is the old fixed-function pipeline that isn't even available in core profile. 20180328 18:41:25<+discordbot> And that code is merely a reimplementation of sdl_blit() using OpenGL instead of SDL. It's technically using the OpenGL API, but continuing to use one texture per sprite is very inefficient and likely loses to 1.13 in performance. 20180328 18:55:11-!- irker344 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout] 20180328 19:36:36-!- irker752 [~irker@uruz.ai0867.net] has joined #wesnoth-dev 20180328 19:36:36< irker752> wesnoth: Martin Hrubý wesnoth:1.14 dc174fb10a0c / projectfiles/Xcode/README.md: Updated Xcode's README.md https://github.com/wesnoth/wesnoth/commit/dc174fb10a0c8bc12caf7504cfc6afd3ccee5797 20180328 19:38:21< irker752> wesnoth: Martin Hrubý wesnoth:master 212cb9be186c / projectfiles/Xcode/README.md: Updated Xcode's README.md https://github.com/wesnoth/wesnoth/commit/212cb9be186c1e95d5a22c4c7696508da1a122d9 20180328 19:39:47< vn971> During whole time I waited for people on 1.14 server, none showed up... 20180328 19:40:23< vn971> or better to say, there was 1 person named "mobile" who played with himself. An old-timer I think, was occasionally visible on 1.13 server as well. 20180328 19:41:25< gfgtdf> vn971: do you want to test someting in parituclar or wer you wauting for a game ? 20180328 19:42:59< vn971> gfgtdf: wanted to test it overall, hoping to find bugs before major release. 20180328 19:43:13< gfgtdf> ok 20180328 19:55:27-!- gfgtdf [~chatzilla@x4e36815a.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.93 [Firefox 52.7.3/20180322140748]] 20180328 19:57:21< Soliton> mobile is the default nick for the ios version at least. 20180328 19:58:28<+discordbot> sinda is now working on 'new' version of wesnoth for iPhone. He is using Wesnoth 1.10.x for it 20180328 19:58:52<+discordbot> and yes, iOS by default uses nick mobile 20180328 19:58:59< Soliton> server replays do not work at all in 1.14 it seems. :-( 20180328 20:07:52<+discordbot> @Vultraz , it is already here: https://github.com/wesnoth/wesnoth/blob/master/projectfiles/Xcode/Info.plist#L29-L30 20180328 20:24:27-!- deekay [~deekayish@public-gprs378280.centertel.pl] has joined #wesnoth-dev 20180328 20:38:20-!- Bhoren [~Bhoren_wh@2a01:e0a:c:2150:b966:525d:fc1f:49e5] has joined #wesnoth-dev 20180328 20:40:25-!- Bonobo [~Bonobo@203.220.138.198] has joined #wesnoth-dev 20180328 20:46:39-!- gfgtdf [~chatzilla@x4e36815a.dyn.telefonica.de] has joined #wesnoth-dev 20180328 20:46:41< gfgtdf> 20180328 19:58:59< Soliton> server replays do not work at all in 1.14 it seems. :-( 20180328 20:46:53< gfgtdf> Soliton: i just tested and didn't have any problems 20180328 20:47:05-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20180328 20:47:08< gfgtdf> (first entry from https://replays.wesnoth.org/1.13/20180328/) 20180328 20:48:29< vn971> so the nick "mobile" is unregistered? Didn't expect that, ok. 20180328 20:48:39< Soliton> i tried https://replays.wesnoth.org/1.13/20180328/2p__Caves_of_the_Basilisk_Turn_19_(108).bz2 for example. 20180328 20:50:17-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180328 20:50:47< Soliton> that clash game does seem to work indeed. 20180328 20:51:38< gfgtdf> well that one gives me OOS immidieteley but i aslo don't have that era installed i tihnk 20180328 20:51:57< Soliton> yeah, i guess missing era issues then. 20180328 20:54:17< Soliton> would be nice to get some hint when trying to load such a game. 20180328 20:55:21< gfgtdf> ye 20180328 20:55:41< gfgtdf> ideally we woudl give an option to download it automaticially jsut liek we do when joingin an mp game 20180328 20:59:11< Soliton> how do mods work in that regard? i guess you need the mod as well and make sure it's active somehow? 20180328 21:02:55< gfgtdf> Soliton: just like eras, some mods require download and some do not. 20180328 21:22:08-!- deekay [~deekayish@public-gprs378280.centertel.pl] has quit [Quit: Leaving] 20180328 21:43:41-!- Bhoren [~Bhoren_wh@2a01:e0a:c:2150:b966:525d:fc1f:49e5] has quit [Quit: Leaving] 20180328 21:43:52< irker752> wesnoth: Victor Sergienko wesnoth:master 004d7b541b19 / data/core/about_i18n.cfg: Credits for Chinese translation of iOS announcements https://github.com/wesnoth/wesnoth/commit/004d7b541b19cdb29c9be3b8dae80c65be7f4d48 20180328 21:44:41< irker752> wesnoth: Victor Sergienko wesnoth:1.14 6da3387969f0 / data/core/about_i18n.cfg: Credits for Chinese translation of iOS announcements https://github.com/wesnoth/wesnoth/commit/6da3387969f01c787aad1548b52e4d5973bbb0cb 20180328 22:04:42< gfgtdf> is there a way to delected form umc whether i am in a network game ? 20180328 22:04:57-!- grzywacz [~karol@89-70-226-147.dynamic.chello.pl] has joined #wesnoth-dev 20180328 22:05:20< Soliton> shouldn't you know that? :-P 20180328 22:08:14< gfgtdf> ye, but i don't know of any. I hoped that maybe there was some umc author who already solved that problem 20180328 22:09:17< gfgtdf> the reson is that in my pickyourrecruits addon to add a 'chat' button that pauses the dialog to give the users the option to chat, but that'D make littel sense in sp 20180328 22:09:21-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection] 20180328 22:10:17< gfgtdf> i mean i coudl of course check 'whether there is a nonlocal side', but 'networked singeplayer gamews with oversers' are also thing. 20180328 22:16:15< gfgtdf> wait the durion in [print] is still measured in 'frames'? i thought we fixed that 20180328 22:16:52<+discordbot> current_player in [side] uses in MP the server login name ... the docs are not clear what it does in SP, but probably sth different, maybe it doesn'T exist there. 20180328 22:16:55< irker752> wesnoth/wesnoth:opengl Jyrki Vesterinen c4a4ffe3e8 Stop logging GL_VENDOR AppVeyor: All builds passed 20180328 22:18:11< gfgtdf> iirc it still the players mp name in sp 20180328 22:21:16<+discordbot> Just read it again, if I understand correctly it uses in SP the leader's name., and in MP, the leader uses the MP login name. ... so it's in both cases the same. 20180328 22:23:49< gfgtdf> sevu: seems like outdated inftomation to me, where did you read it ? 20180328 22:26:08< gfgtdf> actuaqll i just came to te conslusion that that chat button might be useful in sp aswell. 20180328 22:26:51<+discordbot> https://wiki.wesnoth.org/SideWML -> current_player thought I may have misunderstand it 20180328 22:29:27<+discordbot> hmm, reading the next entry below it, side_name, it sounds like the check wether it's MP or not is wether it's using a [scenario] or [multiplayer] tag 20180328 22:29:28< gfgtdf> sevu: ye the "Version 1.13.0 and later only" part is the important one here (since i write my addon for 1.14) 20180328 22:32:21<+discordbot> What about side_name: (Version 1.13.5 and later only) The name of the side, used for example in the new turn dialog, defaults to name if the side was inside a [scenario] and to the player's name if the side was inside a [multiplayer]. 20180328 22:32:53<+discordbot> I don't know what name is meant with "defaults to name" 20180328 22:33:37<+discordbot> ahh, the name from the unit_type for the leader 20180328 22:36:41< gfgtdf> hmm actuall i wrote that code and i dont remeber making it use the players name in mp. (and even if, i don't see how having a filed that is the players name or not can help me to tecet whether it is a netowrked multiplayer game or not) 20180328 22:40:11< gfgtdf> oh but the getter returns current_player if it empty (even if the internal c++ reppresentation is still empty) 20180328 22:40:19< gfgtdf> so i guess that text on the wiki makes sense 20180328 22:41:51<+discordbot> My Idea would have been to check wether current_player (or side_player) is different from the name of the leader, but it's in both cases the same. 20180328 22:51:32<+discordbot> I guess only way to know for sure is when theme_items says there are observers 20180328 22:57:49< gfgtdf> hmm, also another good idea, but i already came to the conslusion that i do not really need this information anyways. 20180328 23:38:38<+discordbot> ok, wow, I just realized there's yet another GL branch in the repo, this time from 2007 20180328 23:39:18<+discordbot> (dave's) 20180328 23:39:35<+discordbot> let's hope third time's a charm! 😛 20180328 23:54:08-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev 20180328 23:55:14< celticminstrel> So, can anyone see anything I might've done wrong here for the [aspect] tag? 20180328 23:55:18< celticminstrel> https://github.com/wesnoth/wesnoth/blob/c4308420b1a51177906c24bc472a870caebaeab1/data/schema/ai/aspect_complex.cfg 20180328 23:56:18< celticminstrel> General idea is that the tag's contents depends primarily upon the id key and secondarily upon the engine+name combo, while the [facet] tag's contents are basically the same except depending on the id of the enclosing [aspect] rather than their own id. --- Log closed Thu Mar 29 00:00:20 2018