--- Log opened Fri Mar 30 00:00:21 2018 20180330 00:10:53-!- DDR_ [~david@ec2.happyspork.com] has joined #wesnoth-dev 20180330 00:12:15-!- Netsplit *.net <-> *.split quits: Bonobo, Gambit, +discordbot, celticminstrel, Kawa[m], shadowm, Ravana_, DDR, timotei__, wedge009, (+3 more, use /NETSPLIT to show all of them) 20180330 00:12:15-!- crimson_pingvin [~crimson_p@ec2.happyspork.com] has joined #wesnoth-dev 20180330 00:12:27-!- crimson_pingvin is now known as crimson_penguin 20180330 00:13:50-!- Netsplit over, joins: celticminstrel, Bonobo, Gambit, shadowm, vn971, wedge009 20180330 00:14:23-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Ping timeout: 252 seconds] 20180330 00:16:19-!- crimson_penguin [~crimson_p@ec2.happyspork.com] has quit [Changing host] 20180330 00:16:19-!- crimson_penguin [~crimson_p@wesnoth/developer/crimsonpenguin] has joined #wesnoth-dev 20180330 00:16:48-!- DDR_ is now known as DDR 20180330 00:17:03-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180330 00:23:30-!- madmax28 [madmax28ma@gateway/shell/matrix.org/x-eaavaakvrxvoeklo] has quit [Ping timeout: 256 seconds] 20180330 00:23:38-!- syrma[m] [syrmamatri@gateway/shell/matrix.org/x-fihzqgbvteiqtbvu] has quit [Ping timeout: 260 seconds] 20180330 00:23:55-!- ChipmunkV[m] [chipmunkvm@gateway/shell/matrix.org/x-ekbnbighylehtnhb] has quit [Ping timeout: 256 seconds] 20180330 00:34:56-!- syrma[m] [syrmamatri@gateway/shell/matrix.org/x-ueeehhmrssffhqfh] has joined #wesnoth-dev 20180330 00:35:25-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev 20180330 00:49:59-!- allefant [~allefant@allegro/developer/allefant] has joined #wesnoth-dev 20180330 00:51:07-!- allefant [~allefant@allegro/developer/allefant] has quit [Client Quit] 20180330 00:51:39-!- allefant [~allefant@allegro/developer/allefant] has joined #wesnoth-dev 20180330 00:53:14-!- allefant is now known as elias 20180330 00:56:40-!- travis-ci [~travis-ci@ec2-184-73-71-71.compute-1.amazonaws.com] has joined #wesnoth-dev 20180330 00:56:41< travis-ci> wesnoth/wesnoth#17317 (1.14 - 8f37d41 : Nils Kneuper): The build has errored. 20180330 00:56:41< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/360033861 20180330 00:56:41-!- travis-ci [~travis-ci@ec2-184-73-71-71.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180330 00:57:31-!- ChipmunkV[m] [chipmunkvm@gateway/shell/matrix.org/x-kjtltbmavlyqyhif] has joined #wesnoth-dev 20180330 00:57:31-!- Kawa[m] [kawamatrix@gateway/shell/matrix.org/x-fkcsrodvanejlncq] has joined #wesnoth-dev 20180330 00:57:31-!- madmax28 [madmax28ma@gateway/shell/matrix.org/x-nufqszyzbeccffrc] has joined #wesnoth-dev 20180330 00:57:35< shadowm> /names 20180330 00:57:59< shadowm> loonycyborg: The discord bridge got stuck at the wrong end of a netsplit it seems, or it disconnected 20180330 01:28:04-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20180330 01:28:34-!- timotei__ [~timotei@wesnoth/developer/timotei] has joined #wesnoth-dev 20180330 01:28:34-!- discordbot [~discordbo@baldras.wesnoth.org] has joined #wesnoth-dev 20180330 01:28:34-!- Ravana_ [~Ravana@unaffiliated/ravana/x-2327071] has joined #wesnoth-dev 20180330 01:28:34-!- ServerMode/#wesnoth-dev [+v discordbot] by hobana.freenode.net 20180330 01:29:21-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180330 01:31:52-!- Kawa[m] [kawamatrix@gateway/shell/matrix.org/x-fkcsrodvanejlncq] has quit [Ping timeout: 245 seconds] 20180330 01:32:30-!- syrma[m] [syrmamatri@gateway/shell/matrix.org/x-ueeehhmrssffhqfh] has quit [Ping timeout: 252 seconds] 20180330 01:32:32-!- ChipmunkV[m] [chipmunkvm@gateway/shell/matrix.org/x-kjtltbmavlyqyhif] has quit [Ping timeout: 256 seconds] 20180330 01:32:34-!- madmax28 [madmax28ma@gateway/shell/matrix.org/x-nufqszyzbeccffrc] has quit [Ping timeout: 248 seconds] 20180330 01:40:29<+discordbot> @shadowm is that what the MP screen is supposed to look like? 20180330 01:40:39<+discordbot> As far as layout? 20180330 01:41:14<+discordbot> I get 20180330 01:41:14<+discordbot> https://cdn.discordapp.com/attachments/259976436490829825/429092708175577088/unknown.png 20180330 01:41:39<+discordbot> oh, so you have the opposite problem 20180330 01:41:57< celticminstrel> That looks right to me? Apart from maybe the proportions of the three columns. 20180330 01:42:17<+discordbot> Ive tried to make them proportional 20180330 01:45:07<+discordbot> celticminstrel: that's exactly my concern 20180330 01:45:15<+discordbot> This is on a 1920x1200 screen 20180330 01:45:16< celticminstrel> Error at src/editor/map/map_context.cpp:480! 20180330 01:45:32<+discordbot> Which is the width that probably most players on Steam will use 20180330 01:45:38<+discordbot> celmin what 20180330 01:45:43< celticminstrel> I guess it's simple enough that I can fix it on github. 20180330 01:45:58< celticminstrel> @Vultraz It sets an attribute that the game never reads. 20180330 01:46:07<+discordbot> oh? 20180330 01:46:11<+discordbot> schema> 20180330 01:46:12<+discordbot> ? 20180330 01:46:43< celticminstrel> Well, sorta. I noticed because this wrong attribute is being used in some of the test scenarios, so I grepped to see if maybe it was the wiki that was wrong. 20180330 01:47:45< celticminstrel> The editor even reads the correct attribute, which basically means if you load a scenario that set that attribute, it'll be lost. 20180330 01:48:09< irker752> wesnoth: Celtic Minstrel wesnoth:master dd4f80fdd1fb / src/editor/map/map_context.cpp: Fix scenario editor writing to wrong key https://github.com/wesnoth/wesnoth/commit/dd4f80fdd1fb22ebee4c6ec1bf883611e0e823d2 20180330 01:48:37< irker752> wesnoth: Celtic Minstrel wesnoth:1.14 0bbdd1d79cd1 / src/editor/map/map_context.cpp: Fix scenario editor writing to wrong key https://github.com/wesnoth/wesnoth/commit/0bbdd1d79cd17696515d77c3142b40f7a31eea75 20180330 01:49:19<+discordbot> 👍 20180330 01:50:00<+discordbot> checks Steam Survey 20180330 01:50:38<+discordbot> Yep, about 80% of Steam users have a 1920px wide screen 20180330 01:51:12<+discordbot> oh boy 20180330 01:52:14<+discordbot> What did you expect the most common res to be? 20180330 01:54:22<+discordbot> I didn't give it much thought 20180330 01:54:51<+discordbot> nor am I in a good position to fix the core issue here 20180330 01:54:54<+discordbot> Well I'm glad I waited until 1.13.12 to mention this 20180330 01:55:11<+discordbot> I incorrectly assumed this would be something devs were aware of 20180330 01:55:24<+discordbot> well, I kinda was. 20180330 01:55:27<+discordbot> This is my webdev background showing through 20180330 01:55:30<+discordbot> I've seen what it looks like in 4K 20180330 01:55:44<+discordbot> what's your screen DPI? 20180330 01:55:46<+discordbot> Guess how many people have 4K screens? 20180330 01:56:15<+discordbot> 0.49% 20180330 01:56:23<+discordbot> what? 20180330 01:56:37<+discordbot> ....what? 20180330 01:56:38-!- syrma[m] [syrmamatri@gateway/shell/matrix.org/x-jugjfzoqjtdjltin] has joined #wesnoth-dev 20180330 01:56:58<+discordbot> that would mean you have 47 DPI 20180330 01:57:02<+discordbot> standard is 96 20180330 01:57:08<+discordbot> I was answering my question 20180330 01:57:14<+discordbot> oh 20180330 01:57:17<+discordbot> I'm using 100% scaling 20180330 01:57:37<+discordbot> ok, so you have standard 96 DPI 20180330 01:57:52<+discordbot> Yes. 20180330 01:58:34<+discordbot> here's the thing. Wesnoth looks worse and worse the higher resolution you go because it uses pixel size calculations instead of screen coordinate calculations. 20180330 01:58:59<+discordbot> I would bet that 99+% of desktop users have standard 96DPI 20180330 01:59:29<+discordbot> So wesnoth running at native 4k without Window's automatic DPI virtualization looks like holy crap wow. 20180330 02:00:16<+discordbot> Now, I still don't really know enough about DPI to fully know if the look its meant to emulate is indeed what things owuld appear like at 96 DPI, just a lot damn crisper 20180330 02:01:20<+discordbot> regardless, even if it were, the issues you're seeing at 96 DPI 1080 are again symptomatic of the same problem 20180330 02:01:30<+discordbot> which is, again, pixel measurements 20180330 02:01:37<+discordbot> god damn pixel measurements 20180330 02:02:19<+discordbot> What do you mean by pixel size calcs 20180330 02:03:08<+discordbot> I mean if you said you want a size 5 border around an element, it's a 5 pixel border. 20180330 02:03:33<+discordbot> If you want an element with width 100, it's a 100 pixel width element 20180330 02:05:10<+discordbot> So what you're saying is that the game options pane is the fixed width part 20180330 02:05:12<+discordbot> that's where all the empty space comes from. the layout engine already found enough pixels for the stuff it has on the right, and because of the way I positioned the game list, it leavs a giant void 20180330 02:09:52<+discordbot> I would love it if I could just tell the columns to try to div available space between them as evenly as possibly, but.... 20180330 02:20:38-!- Kawa[m] [kawamatrix@gateway/shell/matrix.org/x-nzhtbvejhfefnhfa] has joined #wesnoth-dev 20180330 02:20:38-!- ChipmunkV[m] [chipmunkvm@gateway/shell/matrix.org/x-njbmwiliymgrqobz] has joined #wesnoth-dev 20180330 02:20:38-!- madmax28 [madmax28ma@gateway/shell/matrix.org/x-fgmcydmmialwdadx] has joined #wesnoth-dev 20180330 02:24:49-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20180330 02:35:48< celticminstrel> @Vultraz Uh, isn't that what that one key is for. 20180330 02:35:55< celticminstrel> The one you insist on setting always to 1 or 0. 20180330 02:36:00< celticminstrel> What was it again... 20180330 02:36:23<+discordbot> Grow factor 20180330 02:36:29< celticminstrel> Yeah that sounds about right. 20180330 02:36:46<+discordbot> Doesn’t really seem to work here for some reason 20180330 02:37:06< celticminstrel> Well, I think certain widgets also don't play nice with the layout engine... 20180330 02:37:10< celticminstrel> Like sliders and listboxes. 20180330 02:37:21< celticminstrel> And you have both in there. 20180330 02:44:31-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity] 20180330 02:47:20-!- travis-ci [~travis-ci@ec2-184-73-71-71.compute-1.amazonaws.com] has joined #wesnoth-dev 20180330 02:47:21< travis-ci> wesnoth/wesnoth#17321 (1.14 - 0bbdd1d : Celtic Minstrel): The build passed. 20180330 02:47:21< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/360115388 20180330 02:47:21-!- travis-ci [~travis-ci@ec2-184-73-71-71.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180330 03:06:12< irker752> wesnoth/wesnoth:1.14 Nils Kneuper 8f37d4114e updated British English translation AppVeyor: All builds passed 20180330 03:10:26<+discordbot> celmin: do you remember why you added this to the help browser 20180330 03:10:30<+discordbot> cpp if(initial_topic_.compare(0, 2, "..") == 0) { initial_topic_.replace(0, 2, "+"); } else { initial_topic_.insert(0, "-"); } 20180330 03:11:37< celticminstrel> I think it's something to do with generated magic topic IDs, possibly for hidden topics or something? I don't quite remember. 20180330 03:12:05< celticminstrel> It could be something else though. 20180330 03:12:43<+discordbot> alright 20180330 03:12:58<+discordbot> currently pondering when exactly the help stuff needs to be regenerated... 20180330 03:13:38<+discordbot> seems it's actually regenerated when you actually launch the browser 20180330 03:13:50<+discordbot> the old manager class simply set the game config pointer 20180330 03:13:58<+discordbot> and reset the stuff when it was destroyed... 20180330 04:43:36-!- hrubymar10 [~textual@ip-86-49-9-122.net.upcbroadband.cz] has quit [Quit: hrubymar10] 20180330 04:53:56< irker752> wesnoth/wesnoth:master Nils Kneuper 57c1a67134 updated British English translation AppVeyor: 1/4 builds failed 20180330 04:53:57< irker752> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-2345 20180330 04:58:57-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180330 04:59:02-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180330 05:26:40< celticminstrel> Alright, DirectActionsWML and ConditionalActionsWML is now fully documented in the schema! \o/ 20180330 05:26:51< celticminstrel> Based on wiki, later I'll look over the code for discrepancies. 20180330 05:27:02<+discordbot> \o/ 20180330 05:27:36< celticminstrel> That's probably like, one-half of all ActionWML? Not quite sure, but there are two other wiki pages listing ActionWML tags in any case. And this also means all the core ConditionalWML is included too. 20180330 05:28:14< celticminstrel> I also haven't actually tried this schema yet, there are probably little errors here and there. 20180330 05:28:56< celticminstrel> IIRC ActionWML was the one big thing still missing from the schema, so once this is done, the schema can be considered basically complete. 20180330 05:29:07< celticminstrel> Though there are still a ton of TODO notes I want to address. 20180330 05:29:30< celticminstrel> (As mentioned earlier, I'm skipping ThemeWML because it's being replaced, and also HelpWML since it may also be replaced.) 20180330 05:30:01< celticminstrel> (Themes and help are included in the schema, but as "anything-goes" tags.) 20180330 05:30:38<+discordbot> meanwhile I've spent way too much time pondering the API for the help entry points... 20180330 05:31:28<+discordbot> seems the game config object exists for the lifetime of the session, so it should be ok to just keep a reference to it in the help manager 20180330 05:34:34< celticminstrel> By "the game config object" do you mean "contents of data/_main.cfg"? 20180330 05:35:15< celticminstrel> I don't know if the object itself is persistent, but its contents sure isn't; in other words, it might be safe to store a reference to the root but it definitely wouldn't be safe to store a reference to any subtags. 20180330 05:35:15<+discordbot> yes. 20180330 05:35:50<+discordbot> the only reason I need a reference to root is that two places need access to the [era] range... 20180330 05:35:52<+discordbot> which... 20180330 05:36:13<+discordbot> come to think of it, might be best to just handle with game_config_manager::get()->game_config() where needed 20180330 05:36:37<+discordbot> then just keep a reference to the [help] 20180330 05:36:38<+discordbot> subtag 20180330 05:36:41<+discordbot> i think that'd be safe? 20180330 05:37:02< celticminstrel> Sorry, what? 20180330 05:37:28< celticminstrel> Didn't I just say that keeping references to subtags wouldn't be safe? It'd go stale as soon as the game config is reloaded (which happens rather often). 20180330 05:38:27<+discordbot> but it's the same config object 20180330 05:38:33<+discordbot> oh 20180330 05:38:38<+discordbot> i see what you mean 20180330 05:38:41< celticminstrel> Not once it's reloaded it's not. 20180330 05:38:42<+discordbot> BLAH 20180330 05:38:44<+discordbot> yes 20180330 05:38:47<+discordbot> I see what you mean 20180330 05:38:56< celticminstrel> Like, the root config might be the same object in the same memory location. 20180330 05:39:03< celticminstrel> But any subtags will have been reallocated, essentially. 20180330 05:39:14<+discordbot> yes,I see 20180330 05:39:19<+discordbot> god dammit 20180330 05:52:48<+discordbot> ok I know what to do 20180330 06:04:21-!- celticminstrel is now known as celmin|sleep 20180330 06:08:21-!- atarocch [~atarocch@93.56.164.28] has quit [Ping timeout: 240 seconds] 20180330 06:20:04<+discordbot> out of curiosity, what do you plan to do with the WML schema once you complete it, celticminstrel? 20180330 06:27:38<+discordbot> I guess you are planning to write some external validation tools? or would it be integrated with wesnoth / campaign server ? 20180330 07:05:33< irker752> wesnoth/wesnoth:master catagent101 b1f162daf4 Remove slows notes for Quenoth Scout AppVeyor: All builds passed 20180330 08:14:01-!- vn971 [~vasya@94.158.103.15] has quit [Read error: Connection reset by peer] 20180330 08:14:09-!- vn971 [~vasya@94.158.103.15] has joined #wesnoth-dev 20180330 09:09:00< irker752> wesnoth: pentarctagon wesnoth:master 1bb5fdf28305 / / (7 files in 3 dirs): Add using dockerfiles based on the LTS and BRANCH env vars https://github.com/wesnoth/wesnoth/commit/1bb5fdf2830515d33793c52f298d305bd12b5a60 20180330 09:19:11< irker752> wesnoth: pentarctagon wesnoth:1.14 5a7f651ec90d / / (7 files in 3 dirs): Add using dockerfiles based on the LTS and BRANCH env vars https://github.com/wesnoth/wesnoth/commit/5a7f651ec90d4fef31173857fd2dbb8cfd14adc3 20180330 09:26:52< irker752> wesnoth/wesnoth:master Celtic Minstrel dd4f80fdd1 Fix scenario editor writing to wrong key AppVeyor: All builds passed 20180330 09:31:42-!- louis94 [~~louis94@149.36-245-81.adsl-dyn.isp.belgacom.be] has joined #wesnoth-dev 20180330 09:47:05-!- louis94 [~~louis94@149.36-245-81.adsl-dyn.isp.belgacom.be] has quit [Ping timeout: 240 seconds] 20180330 10:14:15<+discordbot> I have interesting bug in 1.13.12 on mac 20180330 10:14:24<+discordbot> I can reproduce it every time 20180330 10:15:34<+discordbot> in lobby, when you press shift + ˇ (on czech layout; ˇ is next to backspace) you got this crash: 20180330 10:15:54<+discordbot> Exception Type: EXC_CRASH (SIGABRT) Exception Codes: 0x0000000000000000, 0x0000000000000000 Exception Note: EXC_CORPSE_NOTIFY Application Specific Information: Assertion failed: (offset <= length_), function insert_text, file /Users/martinhruby/xcode/wesnoth_prepare_for_release/src/font/text.cpp, line 129. 20180330 10:17:10<+discordbot> it is reproducible with official package version. I don't know why release version knows original path of text.cpp 20180330 11:05:18-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20180330 11:35:28< irker752> wesnoth: doofus-01 wesnoth:master 816dd075dcf3 / data/campaigns/Under_the_Burning_Suns/ (25 files in 5 dirs): [UtBS] Quenoth elf animations (#2679) https://github.com/wesnoth/wesnoth/commit/816dd075dcf36e154475fdd84043680d49ad58c1 20180330 11:37:17-!- atarocch [~atarocch@37.176.34.14] has joined #wesnoth-dev 20180330 11:38:29< irker752> wesnoth: doofus-01 wesnoth:1.14 caf2dbe202e2 / data/campaigns/Under_the_Burning_Suns/ (25 files in 5 dirs): [UtBS] Quenoth elf animations (#2679) https://github.com/wesnoth/wesnoth/commit/caf2dbe202e2690fdf40c54e5d0f7bd77fa8c429 20180330 11:41:22< zookeeper> oh, duh, should have waited/asked for someone to wmlindent those first before porting. 20180330 11:41:43< zookeeper> i wish there was some way to get doofus to do whitespace right. 20180330 11:47:42< irker752> wesnoth/wesnoth:1.14 Celtic Minstrel 0bbdd1d79c Fix scenario editor writing to wrong key AppVeyor: All builds passed 20180330 11:49:35<+discordbot> @jyrkive and @Pentarctagon ^^ 20180330 12:10:07-!- travis-ci [~travis-ci@ec2-54-204-251-136.compute-1.amazonaws.com] has joined #wesnoth-dev 20180330 12:10:08< travis-ci> wesnoth/wesnoth#17326 (1.14 - caf2dbe : doofus-01): The build is still failing. 20180330 12:10:08< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/360236953 20180330 12:10:08-!- travis-ci [~travis-ci@ec2-54-204-251-136.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180330 12:22:31< zookeeper> @Vultraz, so how would you suggest i workaround the "text has a font size of 0" errors that i get when trying to run 1.14 data with the 1.13.12 binary? 20180330 12:23:04< irker752> wesnoth: Sofartin wesnoth:opengl 2d7b0a182b80 / projectfiles/Xcode/Wesnoth.xcodeproj/project.pbxproj: Fixed Xcode Project for OpenGL https://github.com/wesnoth/wesnoth/commit/2d7b0a182b80f5cdb6c418b74245c85367c892a5 20180330 12:23:59< zookeeper> or perhaps more importantly, i guess you don't think RC's should be forward-compatible when possible? 20180330 12:24:31< zookeeper> currently i can't test master nor 1.14 because i can't build nor use existing builds. 20180330 12:32:49-!- Gfg [50bb657b@gateway/web/freenode/ip.80.187.101.123] has joined #wesnoth-dev 20180330 12:33:55< Gfg> zookeeper: if you are using Windows you can download a build from appveyoyr it jenkins 20180330 12:38:36< Gfg> or* 20180330 12:39:33< zookeeper> oh yeah, only took me literally 5 minutes to find an actual download link. as always. 20180330 12:44:17-!- travis-ci [~travis-ci@ec2-54-204-251-136.compute-1.amazonaws.com] has joined #wesnoth-dev 20180330 12:44:18< travis-ci> wesnoth/wesnoth#17328 (opengl - 2d7b0a1 : Sofartin): The build was fixed. 20180330 12:44:18< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/360250009 20180330 12:44:18-!- travis-ci [~travis-ci@ec2-54-204-251-136.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180330 12:46:52-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180330 12:50:17<+discordbot> The build was fixed ^^ 😄 I like this message 😄 20180330 12:53:47< zookeeper> so who's changed the semantics of [modify_side] income= since 1.12? 20180330 12:54:56< Gfg> well iirc someone ported it to Lua? 20180330 12:55:18< Gfg> what exactly has changed? 20180330 12:57:19< zookeeper> in 1.12 income=-2 gives you 0 income because of the standard +2, now you actually end up at -2. 20180330 12:57:48<+discordbot> ouch 20180330 12:59:28< zookeeper> i care less about the change itself, as the old behavior is pretty sketchy anyway, and more about that change apparently being completely undocumented. 20180330 13:00:09-!- Gfg [50bb657b@gateway/web/freenode/ip.80.187.101.123] has quit [Ping timeout: 260 seconds] 20180330 13:05:56< zookeeper> i hope it's just an unintentional bug, and not someone deciding it makes more sense this way but then not changing current usages accordingly. 20180330 13:29:13-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180330 13:29:19-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180330 13:31:44< vn971> zookeeper: can't really change current usages accordingly by the way, because you don't control all the add-ons (and never will). 20180330 13:32:13< zookeeper> obviously i didn't mean you magically change all add-on code too. 20180330 13:33:01< vn971> zookeeper: so I'm against all changes altogether. If anything should happen, then deprecation of the old field and introduction of a new one. 20180330 13:33:50< vn971> IDK why I'm saying this though as this particular issue seems to be a pure mistake with everyone understanding what to do (reverting the meaning of income to the old one). 20180330 13:41:35<+discordbot> The base_income is a separate thing from income. So the word "income" is a bit misleading, since it is something added to base_income. So I was in the habit of writing income as "+2" instead of 2 to make it clear that it was being added to something. Although it would be read as a plain int. 20180330 13:44:11<+discordbot> I say "was" because I vaguely recall that being broken or changed at some point 20180330 14:03:21< irker752> wesnoth/wesnoth:master pentarctagon 69e972b7b9 Add using dockerfiles based on the LTS a AppVeyor: All builds passed 20180330 14:08:06<+discordbot> The commit comment was "properly convert ..." and it improperly converted. Change was dated August 4, 2016. 20180330 14:09:43<+discordbot> So do you want the behavior reverted to adding to game's base_income or leave it as-os. 20180330 14:11:21<+discordbot> @zookeeper ^ 20180330 14:18:12-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer] 20180330 14:25:22<+discordbot> I think you have to revert that 20180330 14:26:17<+discordbot> Especially considering the difference between income and base income 20180330 14:27:09<+discordbot> The original was in C++ and added base_income to the incoming field named 'income' but which is th base_income_modifier. 20180330 14:27:47< zookeeper> well maybe you could link to the commit(s) if you have them handy? 20180330 14:28:01<+discordbot> So what happens in 1.13 if you change base income? 20180330 14:29:04<+discordbot> Dunno. We're talking about [modify_side] income = which used to be base_income += and is now base_income = 20180330 14:30:37<+discordbot> Diggin out the commit now. It's large. Eliminates the C++ and adds the Lua. 20180330 14:32:27<+discordbot> https://github.com/wesnoth/wesnoth/commit/e0d07e854ecd4a731aebcf72c7af2fe5f5f48034 20180330 14:35:15< zookeeper> well, i'm sure celmin|sleep will fix it 20180330 14:37:00<+discordbot> As I read it, the old code set the side base_income to game base_income + while the new code simply sets the side base_income to . Frankly, it makes more sense as-is, but it's a breaking change, even if it's been there since 1.13.7. So either it needs a changelog entry or code correction. 20180330 14:38:06< celmin|sleep> @sapient_n3t I'll probably somehow tweak the --validate command-line option to allow passing a config file as a parameter. 20180330 14:38:07< celmin|sleep> @zookeeper The income change is probably fixable by adding "+ wesnoth.game_config.income" to the [modify_side] code, I'd guess? 20180330 14:38:29-!- gfgtdf [~chatzilla@x4e363a2d.dyn.telefonica.de] has joined #wesnoth-dev 20180330 14:38:46< gfgtdf> zookeeper: are you now using the jenkins or te appveyor build ? 20180330 14:38:56< zookeeper> jenkins 20180330 14:39:40< celmin|sleep> @sapient_n3t And a separate schema file actually, so it would be an option taking two parameters I guess, 20180330 14:39:58< celmin|sleep> Or maybe I'd need a separate --schema parameter... 20180330 14:40:23< zookeeper> gfgtdf, i don't even know where i'd start looking for information on where the appveyor builds actually are 20180330 14:40:32< zookeeper> well, besides asking here of course. 20180330 14:41:33< gfgtdf> zookeeper: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/history and thne under 'artifacts' of the leatest succeeding build. 20180330 14:41:46< gfgtdf> (for the branch that you want of course) 20180330 14:44:29< zookeeper> what 'artifacts'? there's nothing like that anywhere 20180330 14:45:12< zookeeper> ohhh, found it. 20180330 14:51:16-!- Oebele [~quassel@143.177.58.202] has joined #wesnoth-dev 20180330 14:59:32-!- celmin|sleep is now known as celticminstrel 20180330 15:05:33< irker752> wesnoth: Celtic Minstrel wesnoth:master 79bc18fe9522 / data/lua/wml/modify_side.lua: Fix unintended change to the semantics of [modify_side]income= https://github.com/wesnoth/wesnoth/commit/79bc18fe9522049d1844a99e37d58eab43898941 20180330 15:06:00< irker752> wesnoth: Celtic Minstrel wesnoth:1.14 cfceec1d58f7 / data/lua/wml/modify_side.lua: Fix unintended change to the semantics of [modify_side]income= https://github.com/wesnoth/wesnoth/commit/cfceec1d58f758f628f0b0eb92fbfebff7fc7550 20180330 15:07:53-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180330 15:10:50< zookeeper> oh, cool. 20180330 15:14:31< celticminstrel> [message]duration is dumb (at least based on wiki). Who thought it was a good idea to specify the value in frames? 20180330 15:14:44< celticminstrel> It should be in either seconds or milliseconds. 20180330 15:14:57< celticminstrel> Seconds is probably easier to understand, but milliseconds allows it to be an int. 20180330 15:26:53< vn971> celticminstrel: good question IMO. I never understood the "frames" approach either. 20180330 15:27:22< vn971> especially for [print] 20180330 15:28:00< vn971> either a 16x player won't see anything, or the 1x will get bored by the label, or even find it disturbing. 20180330 15:28:26< vn971> never gone as close as raising an issue for that, but I'd support a change totally. 20180330 15:32:10<+discordbot> Agree. Seconds makes more sense. Maybe seconds with one decimal allowed. Milliseconds are too small for mere mortals. 20180330 15:33:25< celticminstrel> Right, if it's seconds it needs to be take as a real number, not an int. 20180330 15:33:42< celticminstrel> But I guess it's too late to change this for 1.14, huh? 20180330 15:33:53< celticminstrel> I can change it on 1.15 I suppose. 20180330 15:36:28<+discordbot> Is it a new feature or a reversion from an old one? IF so, it should go into 1.14.0 .. otherwise, if it's a minor change to avoid user error, I'd suggest 1.14.1. 1.15 should be for more major stuff. 20180330 15:37:02< celticminstrel> I don't actually know if it works in 1.12, but I'd suspect so? 20180330 15:37:32< celticminstrel> I guess I can actually test that myself because I have 1.12.5 right here. 20180330 15:37:59< celticminstrel> The titlescreen buttons seem to be taller in 1.13... 20180330 15:38:15< celticminstrel> Oh hey the tutorial character selection in 1.12 doesn't use the custom dialog. 20180330 15:40:27< zookeeper> uh. milliseconds is definitely the correct choice for specifying durations like that. 20180330 15:41:16< celticminstrel> I think seconds is fine too as long as it's a real number and not an integer. 20180330 15:41:29< celticminstrel> So you can say duration=0.5 for half a second. 20180330 15:42:09-!- travis-ci [~travis-ci@ec2-54-204-251-136.compute-1.amazonaws.com] has joined #wesnoth-dev 20180330 15:42:10< travis-ci> wesnoth/wesnoth#17330 (1.14 - cfceec1 : Celtic Minstrel): The build is still failing. 20180330 15:42:10< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/360306871 20180330 15:42:10-!- travis-ci [~travis-ci@ec2-54-204-251-136.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180330 15:43:05< celticminstrel> [print]duration=50 seems to be approximately one second. 20180330 15:43:25< zookeeper> in my experience, milliseconds are an extremely common way to specify durations, not to mention _wesnoth_ uses milliseconds everywhere else too. 20180330 15:43:45< vn971> the more important question might be this: are we changing "duration" field meaning, or we are introducing a new field? 20180330 15:43:49< celticminstrel> They are indeed a common way to specify durations. 20180330 15:43:57< zookeeper> a new one, of course 20180330 15:43:57< vn971> because one changes already-existing add-on, the other does not. 20180330 15:44:00< celticminstrel> It doesn't seem like [message]duration works in 1.12. 20180330 15:44:15< celticminstrel> [print]duration does, though. 20180330 15:44:22< vn971> celticminstrel: wait, for [print] the duration does work for sure 20180330 15:44:23< vn971> ah 20180330 15:44:25< celticminstrel> Does [message]duration even work in 1.13? 20180330 15:44:49< celticminstrel> I'll test that soon if no-one else does, I guess. 20180330 15:45:34< vn971> celticminstrel: I never even barely understood why this field exist at all, never used it, so don't know. 20180330 15:45:50< zookeeper> [message]duration= is a dubious feature anyway if you ask me. it was originally implemented for a silly reason, and i don't really see what usecases there are supposed to be for it. 20180330 15:46:12< vn971> zookeeper: +1 20180330 15:46:25< celticminstrel> What would you propose as a new field in [print] then? 20180330 15:46:35< zookeeper> time= ? 20180330 15:46:36< vn971> seconds :-) 20180330 15:48:39< celticminstrel> At least wesnoth.delay is already in milliseconds. 20180330 15:57:32< irker752> wesnoth/wesnoth:master pentarctagon 1bb5fdf283 Add using dockerfiles based on the LTS a AppVeyor: All builds passed 20180330 16:01:13< celticminstrel> Another possibility is allowing explicit specification of the unit. 20180330 16:01:35< celticminstrel> So duration=50 has the same effect as it always did, but you can also do duration=5s or duration=100ms. 20180330 16:07:51-!- Oebele [~quassel@143.177.58.202] has quit [Remote host closed the connection] 20180330 16:08:02< zookeeper> just... no 20180330 16:08:37< vn971> celticminstrel: I thought about duration=100s too, but that smells a bit like introducing a new data type -- time. Since this is a big undertaking, I think it makes sense to avoid unless we have strong need for that. 20180330 16:09:10< vn971> we could add unit=(frames|seconds) though 20180330 16:09:30< vn971> or time_unit=(frame|seconds) 20180330 16:10:59<+discordbot> what was the problem with only using milliseconds? 20180330 16:11:28< celticminstrel> No problem, just considering the possibilities. 20180330 16:12:40<+discordbot> alright. having both seconds and milliseconds seems rather redundant to me, in that case. 20180330 16:14:56< zookeeper> academic overengineering hypotheticals are great, but you might want to make it clear that's what you're doing. 20180330 16:18:40< irker752> wesnoth: pentarctagon wesnoth:1.14 ae332bf8b1a8 / / (5 files in 2 dirs): Give 1.14 its own docker image. https://github.com/wesnoth/wesnoth/commit/ae332bf8b1a810ce255ee5207008f564371254ed 20180330 16:24:19-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20180330 16:25:47-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180330 16:30:47-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180330 16:30:53-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180330 16:33:59< celticminstrel> I really don't think [random_placement] makes sense in internal actions.... 20180330 16:34:07<+discordbot> @hrubymar10 Commits like that should not be explicitly merged to the opengl branch. 20180330 16:34:19<+discordbot> I'll rebase that branch on master once in a while. 20180330 16:34:38<+discordbot> It will be easier to do if random commits aren't duplicated in both branches. 20180330 16:35:15<+discordbot> kk 20180330 16:35:25<+discordbot> So only 1.14 and master 20180330 16:35:26<+discordbot> 😄 20180330 16:39:31< vn971> celticminstrel: zookeeper: do we have a proper issue raised for [print].duration? I'd subscribe. 20180330 16:39:54< celticminstrel> So did anyone decide whether my fix for [filter_wml][or] should be put on the 1.14 branch? Or whether we should revert the broken support for it on the 1.14 branch? 20180330 16:41:28< celticminstrel> vn971: Now we do! 20180330 16:47:00< celticminstrel> Huh, Lua doesn't seem to have a truncate function. 20180330 16:47:23< celticminstrel> I guess modf is close though. 20180330 16:47:36<+discordbot> Lua's standard library is very small. You're expected to write almost everything yourself. 20180330 16:48:14< vn971> celticminstrel: what is "truncate"? String truncation? 20180330 16:48:34< vn971> = removing whitespace at end and start of the string? 20180330 16:48:45< celticminstrel> math.trunc(5.5) --> 5; math.trunc(-5.5) --> -5 20180330 16:49:02< celticminstrel> Basically, "round towards zero". 20180330 16:49:53< vn971> ah. Probably no such function indeed. No `round` either. 20180330 16:50:17< celticminstrel> There's ceil and floor, but yeah, no round or trunc. 20180330 16:50:47< vn971> Also no array.map, array.flatMap, array.exists, set.intersect etc etc etc. But *sigh* I'm not on Scala or Haskell, y. 20180330 16:51:05-!- mkdroid [~null@unaffiliated/matthiaskrgr] has joined #wesnoth-dev 20180330 16:51:20< celticminstrel> vn971: You should try wesnoth.require "functional" 20180330 16:51:22< celticminstrel> >_> 20180330 16:51:28< celticminstrel> data/lua/functional.lua 20180330 16:51:50< celticminstrel> Mind you, still no intersect there, but IIRC there's a map. 20180330 16:52:03<+discordbot> I recall we had a file called utils.lua in the Angry Birds Stella codebase, providing low-level utility functions like that. 20180330 16:52:28< vn971> celticminstrel: I think I saw it once but didn't estimate as "hot enough", to be honest. Not sure. 20180330 16:53:08< vn971> I define functions like that in my local utils.lua whenever I need them. 20180330 16:54:05< vn971> I actually thought about joking that my addons already have packaging step, building step, testing step etc, but still no dependency management. 20180330 16:54:34< vn971> room for improvement he-he. 20180330 17:00:53< vn971> celticminstrel: for example, functional.reduce has a bad implementation. It does not uniformly handle absense of `identity`: one time we write `or 0`, the other time we don't. It has unneeded special handling of #input == 1 case. And if you think about it, it has unneeded special handling of case #input == 0. 20180330 17:01:17< celticminstrel> Well, feel free to submit improvements? 20180330 17:01:33< celticminstrel> I can't remember if I was the one who wrote those or if they were moved from ai_helper. 20180330 17:01:34< vn971> nah better whine and write my own things in add-on :D 20180330 17:01:49< celticminstrel> Better for you, worse for everyone else. 20180330 17:02:38< vn971> Well I mean, I don't know any good solution except dependency management, if we're talking seriously. 20180330 17:03:00< celticminstrel> Looks like only filter and choose were not written by me. 20180330 17:03:05< celticminstrel> What are you talking about? 20180330 17:03:12< vn971> writing or copy-pasting big blocks of code might not be "scalable" enough if it's not code copied from e.g. public Lua projects. 20180330 17:03:49< vn971> if we write many things manually, there'll still be mistakes and we still won't cover all popular usages. 20180330 17:04:35< vn971> instead, should not re-invent the wheel but use some kind of real dependency management (never gonna happen) or at least copy snapshots of popular public libraries. 20180330 17:05:36<+discordbot> I think I was the one who coded message duration back in September 2006, to fulfill a request by esr. Not sure if frames duration was his idea or mine... maybe just laziness on my part. Basically, the problem was that several people complained about missing messages that popped up when they moved to a village, because they were busy moving all their units and were already clicking on the next unit to move when it would 20180330 17:05:37<+discordbot> accidentally dismiss the message. 20180330 17:07:13<+discordbot> The main purpose of the feature was to add a default duration that would prevent that from happening. The configurable duration was just an afterthought. With the idea being that authors would rarely customize such a thing. 20180330 17:08:57-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev 20180330 17:09:07<+discordbot> I still think a default duration is a good idea for the same reason it was originally proposed. Although I wouldn't be surprised if it got dropped somewhere with all the GUI changes since then. To really solve the problem though, you need to have some kind of a message history log. 20180330 17:09:35< vn971> sapient_n3t, oh, actually this usage is quite valid, thanks for telling! 20180330 17:11:09< zookeeper> (yes, that's the silly reason i referred to, because that doesn't fix the genuine UI problem, it just allows content authors to so awkwardly workaround it that i don't recall ever seeing anyone consistently do it) 20180330 17:12:53<+discordbot> Not allowing dialogue to be skipped immediately is common even in commercial games. 20180330 17:13:06-!- mkdroid [~null@unaffiliated/matthiaskrgr] has quit [Read error: Connection reset by peer] 20180330 17:13:09<+discordbot> to be clear, even if we had a perfect message history log, I'd still want a tiny prevent message dismissal duration 20180330 17:13:29-!- mkdroid [~null@unaffiliated/matthiaskrgr] has joined #wesnoth-dev 20180330 17:13:47< zookeeper> @jyrkive, not to mention not allowing dialogue to be skipped _at all_ ;] 20180330 17:13:50<+discordbot> common annoyance, yes. 20180330 17:16:20< vn971> zookeeper: regarding "consistently doing it" -- sapient_n3t said that it was intended to be a default field, with some default non-zero value. Content creators would then change the value only if needed (not change at all by default). 20180330 17:17:05< zookeeper> yeah but if it ever actually was a default, then obviously it was removed as soon as someone actually tried it. 20180330 17:18:44-!- travis-ci [~travis-ci@ec2-54-204-251-136.compute-1.amazonaws.com] has joined #wesnoth-dev 20180330 17:18:45< travis-ci> wesnoth/wesnoth#17332 (1.14 - ae332bf : pentarctagon): The build was fixed. 20180330 17:18:45< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/360335001 20180330 17:18:45-!- travis-ci [~travis-ci@ec2-54-204-251-136.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180330 17:18:58-!- Bonobo [~Bonobo@203.220.138.198] has quit [Ping timeout: 264 seconds] 20180330 17:19:48< zookeeper> for all intents and purposes the only possible use was to have content authors give a positive duration for literally all the first messages of any event that might be prone to a misclick, that is pretty much all. 20180330 17:20:05< vn971> celticminstrel: since you asked: (functional.lua) https://github.com/wesnoth/wesnoth/pull/2788/files 20180330 17:20:56< celticminstrel> Looks good. 20180330 17:21:20<+discordbot> @sapient_n3t I remember the [message] click delay. I don't remember it being configurable (but there was a bogus addition to the wiki that claimed it was a thing), but it'd certainly be nice. As to when the delay was removed, I can say with absolute certainty that it happened during 1.5.x when mordante replaced the previous UI with thew new GUI2-based dialogs for the new portraits. 20180330 17:21:49<+discordbot> It was pretty inconspicuous in the code so odds are it was entirely accidental. 20180330 17:21:56< celticminstrel> So it's not actually a thing that works? I kinda thought it wasn't. 20180330 17:22:25< celticminstrel> By which I mean the duration= key in [message] 20180330 17:22:42< celticminstrel> Mind you, I first came to Wesnoth at 1.10 which I guess is after it was broken. 20180330 17:22:44<+discordbot> That kind of thing should be called min_duration or so anyway. 20180330 17:22:48< celticminstrel> Yeah. 20180330 17:23:00<+discordbot> duration brings to mind something like "show this message for x amount of time then automatically dismiss it". 20180330 17:23:06< celticminstrel> Exactly. 20180330 17:23:11< vn971> good point about it being called "min_duration" ! 20180330 17:23:41< irker752> wesnoth: Vasya wesnoth:master 2b8782923a75 / data/lua/functional.lua: Lua API: simplify functional.reduce (#2788) https://github.com/wesnoth/wesnoth/commit/2b8782923a758eee2e167e5c4097f2803e6e2be6 20180330 17:25:18<+discordbot> Wow, a fun tool: displays compiler's assembly output online. This one comparison is curious in particular: https://t.co/HYMGJwgaUH 20180330 17:25:56-!- mkdr0id [~null@unaffiliated/matthiaskrgr] has joined #wesnoth-dev 20180330 17:26:48<+discordbot> Interesting, but only really useful for micro-optimizing. 20180330 17:29:50-!- mkdroid [~null@unaffiliated/matthiaskrgr] has quit [Ping timeout: 276 seconds] 20180330 17:30:38< zookeeper> @shadowm, do you remember how long that delay was? i mean, i don't think i've ever objected to a very small default/global delay, but one that would prevent misclicks would surely have had to be much longer. 20180330 17:32:55<+discordbot> Just as an example, the way the game I started playing today handles it (I'm playing with an Xbox 360 controller): dialogue appears one character at a time and I can skip by pressing A after it has fully displayed. If I want to skip faster, I only need to press A twice: first press to show the whole line immediately, second press to skip it. 20180330 17:33:05<+discordbot> I remember I used to get so upset in Dungeon Siege when I’d miss the characters’ dialog. That was my favorite part, but it had a bad habit of getting dismissed halfway through 20180330 17:37:42<+discordbot> If you put the min duration back in you just need to be careful that it doesn’t propagate to other GUI elements where it’s unwanted 20180330 17:44:26-!- atarocch [~atarocch@37.176.34.14] has quit [Remote host closed the connection] 20180330 17:45:38-!- mkdr0id [~null@unaffiliated/matthiaskrgr] has quit [Quit: I'll be back!] 20180330 17:45:57-!- mkdroid [~null@unaffiliated/matthiaskrgr] has joined #wesnoth-dev 20180330 18:01:35<+discordbot> zookeeper you may be right that the duration of 10 frames (~300ms) was too short. it was just an arbitrary number... there was no research behind it. 20180330 18:10:53-!- louis94 [~~louis94@149.36-245-81.adsl-dyn.isp.belgacom.be] has joined #wesnoth-dev 20180330 18:18:57-!- louis94 [~~louis94@149.36-245-81.adsl-dyn.isp.belgacom.be] has quit [Ping timeout: 264 seconds] 20180330 18:22:06-!- mkdr0id [~null@unaffiliated/matthiaskrgr] has joined #wesnoth-dev 20180330 18:26:14-!- mkdroid [~null@unaffiliated/matthiaskrgr] has quit [Ping timeout: 255 seconds] 20180330 18:26:20<+discordbot> @Vultraz Did you implement a check that prevented uploading add-ons with a non-mainline image as the icon? 20180330 18:27:37< gfgtdf> i thinki saw an addon with nonworking image on te adon server very recently 20180330 18:27:49<+discordbot> yeah, water era 20180330 18:28:09<+discordbot> so I was kinda surprised that was still possible 20180330 18:28:56< gfgtdf> just tested that the same addon also had a nonworking image in the 1.12 server 20180330 18:29:37< irker752> wesnoth/wesnoth:master doofus-01 816dd075dc [UtBS] Quenoth elf animations (#2679) AppVeyor: All builds passed 20180330 18:31:03<+discordbot> @shadowm btw did you look into adding login via steam support to forums? 20180330 18:31:13<+discordbot> iirc there were some plugins for that 20180330 18:31:22<+discordbot> I will not. 20180330 18:32:56<+discordbot> Actually wait there's an extension I came across that supports that. 20180330 18:34:50<+discordbot> This is something I need to discuss privately with the forum admin and Vultraz anyway. 20180330 18:35:50<+discordbot> anyway my thinking is this: if we want to let people login to mp server with steam 20180330 18:36:02<+discordbot> we'd have to keep permanent memory of mappings 20180330 18:36:08<+discordbot> between names and steamids 20180330 18:36:43<+discordbot> and if we do it via forum we can reuse any facilities for user management it has 20180330 18:37:07<+discordbot> If we do it via this extension I believe you won't need to do anything at all on the wesnothd side. 20180330 18:37:29<+discordbot> Don't quote me on that though. The primary issue I see reading the documentation is that I'll need an API key from Valve to use it. 20180330 18:37:58<+discordbot> But again that's not something I wan to talk about right now and I need to discuss it with Pent and Vultraz in particular. 20180330 18:38:36<+discordbot> ok 20180330 18:39:35-!- mkdr0id [~null@unaffiliated/matthiaskrgr] has quit [Ping timeout: 240 seconds] 20180330 18:55:44< vn971> hmm, I came to a realisation that I don't understand one simple fact. Why don't we duplicate messages sent in game to a public chat, or, on wesnoth-1.13+, any other chat? 20180330 18:56:05< vn971> sorry, I mean for a user, not globally. 20180330 18:56:45< vn971> so that, after you quit a game, you'd still have some chat left to check. There are tons of cases where you exit from a game chat and lose messages sent to you _permanently_. 20180330 18:57:44< vn971> example use case on 1.12. You observe a game. You become AFK. Then another player sends you a PM, **and it is displayed in game chat**. Then you return to game to see there has been a DC. 20180330 18:58:36< vn971> what happens in this example use case? You're right, you lost your PM permanently. To make things worse, it may already be hidden by newer chat messages, so just not pressing the DC pop-up and reading won't help. 20180330 19:06:35-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180330 19:06:41-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180330 19:17:25< celticminstrel> @Pentarctagon - Have you actually used font_size in [message], or seen anyone use it? 20180330 19:18:26< celticminstrel> I see it has been documented. 20180330 19:18:57< celticminstrel> I'm thinking it might've been better to not expose it directly but instead multiply it by 1024 so it can be specified in points. 20180330 19:19:51<+discordbot> I added it as an option that can be set in my music player add-on when I was bored one day. 20180330 19:20:17<+discordbot> I actually did the multiple by 1024 automatically there, in fact 20180330 19:20:41<+discordbot> entering 35000 or whatever was kind of silly 20180330 19:20:47< celticminstrel> I guess the same argument could also apply to letter_spacing. 20180330 19:20:50< celticminstrel> Yeah. 20180330 19:21:01< celticminstrel> And rise is also in really weird units. 20180330 19:22:11< celticminstrel> Hmm, what would be a typical rise value for superscript...? 20180330 19:22:27< celticminstrel> Probably something like 0.5em, right? 20180330 19:23:07< celticminstrel> So it'd make more sense to just specify the rise in ems. 20180330 19:23:57<+discordbot> IIRC there's at least of couple attributes documented on the wiki that don't actually work in [message]s 20180330 19:24:10< celticminstrel> Like duration, right? 20180330 19:25:09<+discordbot> I was thinking more for the formatting, but yeah, probably that too. 20180330 19:25:51<+discordbot> when I checked a year or so ago, for example, background/bgcolor did nothing. 20180330 19:26:27< celticminstrel> I guess it's too late to actually change these things on 1.14. :/ 20180330 19:27:11-!- JikanA2TXHP [~lqmirhpy@2001:19f0:5c01:143:5400:1ff:fe6f:3f52] has joined #wesnoth-dev 20180330 19:27:12< JikanA2TXHP> .-. .-. 20180330 19:27:12< JikanA2TXHP> .-. .-. 20180330 19:27:16< JikanA2TXHP> / \ / \ 20180330 19:27:16< JikanA2TXHP> / \ / \ 20180330 19:27:20< JikanA2TXHP> | _ \ / _ | 20180330 19:27:20< JikanA2TXHP> | _ \ / _ | 20180330 19:27:24< JikanA2TXHP> ; | \ \ / / | ; 20180330 19:27:24< JikanA2TXHP> ; | \ \ / / | ; 20180330 19:27:28< JikanA2TXHP> \ \ \ \_.._/ / / / 20180330 19:27:28< JikanA2TXHP> \ \ \ \_.._/ / / / 20180330 19:27:32< JikanA2TXHP> '. '.;' ';,' .' 20180330 19:27:32< JikanA2TXHP> '. '.;' ';,' .' 20180330 19:27:36< JikanA2TXHP> './ _ _ \.' 20180330 19:27:36< JikanA2TXHP> './ _ _ \.' 20180330 19:27:40< JikanA2TXHP> .' a __ a '. 20180330 19:27:40< JikanA2TXHP> .' a __ a '. 20180330 19:27:44< JikanA2TXHP> '--./ _, \/ ,_ \.--' 20180330 19:27:44< JikanA2TXHP> '--./ _, \/ ,_ \.--' 20180330 19:27:48< JikanA2TXHP> ----| \ /\ / |---- 20180330 19:27:48< JikanA2TXHP> ----| \ /\ / |---- 20180330 19:27:52< JikanA2TXHP> .--'\ '-' '-' /'--. 20180330 19:27:52< JikanA2TXHP> .--'\ '-' '-' /'--. 20180330 19:27:56< JikanA2TXHP> _>.__ -- _.- `; 20180330 19:27:56< JikanA2TXHP> _>.__ -- _.- `; 20180330 19:28:00< JikanA2TXHP> .' _ __/ _/ 20180330 19:28:00< JikanA2TXHP> .' _ __/ _/ 20180330 19:28:04< JikanA2TXHP> / '.,:".-\ /:, 20180330 19:28:04< JikanA2TXHP> / '.,:".-\ /:, 20180330 19:28:08< JikanA2TXHP> | \.' `""`'.\\ 20180330 19:28:08< JikanA2TXHP> | \.' `""`'.\\ 20180330 19:28:12< JikanA2TXHP> '-,.__/ _ .-. ;|_ 20180330 19:28:12< JikanA2TXHP> '-,.__/ _ .-. ;|_ 20180330 19:28:16< JikanA2TXHP> /` `|| _/ `\/_ \_|| `\ 20180330 19:28:16< JikanA2TXHP> /` `|| _/ `\/_ \_|| `\ 20180330 19:28:20< JikanA2TXHP> | ||/ \-./` \ / || | 20180330 19:28:20< JikanA2TXHP> | ||/ \-./` \ / || | 20180330 19:28:24< JikanA2TXHP> \ ||__/__|___|__|| / 20180330 19:28:24< JikanA2TXHP> \ ||__/__|___|__|| / 20180330 19:28:28< JikanA2TXHP> \_ |_Happy Easter_| / 20180330 19:28:28< JikanA2TXHP> \_ |_Happy Easter_| / 20180330 19:28:32< JikanA2TXHP> jgs .' \ = _= _ = _= /`\ 20180330 19:28:32< JikanA2TXHP> jgs .' \ = _= _ = _= /`\ 20180330 19:28:36< JikanA2TXHP> / `-;----=--;--' \ 20180330 19:28:36< JikanA2TXHP> / `-;----=--;--' \ 20180330 19:28:40< JikanA2TXHP> \ _.-' '. / 20180330 19:28:40< JikanA2TXHP> \ _.-' '. / 20180330 19:28:44< JikanA2TXHP> `""` `""` 20180330 19:28:44< JikanA2TXHP> `""` `""` 20180330 19:28:48< JikanA2TXHP> L0DE AND CHRON FROM #LRH & L0DE RADIO HOUR (IRC.EFNET.ORG) WANTED TO SAY HAPPY EASTER!! 20180330 19:28:48< JikanA2TXHP> L0DE AND CHRON FROM #LRH & L0DE RADIO HOUR (IRC.EFNET.ORG) WANTED TO SAY HAPPY EASTER!! 20180330 19:28:52< JikanA2TXHP> janebot boucman stikonas gfgtdf zookeeper vn971 madmax28 ChipmunkV[m] Kawa[m] syrma[m] Ravana_ discordbot timotei__ elias shadowm Gambit wedge009 celticminstrel crimson_penguin DDR molgrum esr irker752 matthiaskrgr commavir Appleman1234 nurupo Ivanovic iwaim oldlaptop heirecka APic midzer higgins Polsaker loonycyborg Soliton lobby aeth TC01 nore pydsigner aidanhs minzbonbon EliDupree vincent_c vihta galegosimpatico Rhonda A 20180330 19:28:52-!- JikanA2TXHP [~lqmirhpy@2001:19f0:5c01:143:5400:1ff:fe6f:3f52] has quit [Client Quit] 20180330 19:29:12< loonycyborg> nasty annoying bunnybot 20180330 19:29:27< celticminstrel> Well, that's one of the more benign spams I've seen... 20180330 19:30:39< celticminstrel> Does anyone who uses VSCode know if there's a way to get the behaviour that when you press enter, all whitespace to the right of the cursor up to the first non-whitespace character is deleted? 20180330 20:01:07< celticminstrel> Does the limit key in SUF still work? IIRC gfgtdf added it for cases when you know you don't want all possible matches, but I think it was before he reorganized the filter implementation to optimize it. 20180330 20:01:17< celticminstrel> Someone should test it. 20180330 20:01:17-!- mkdr0id [~null@unaffiliated/matthiaskrgr] has joined #wesnoth-dev 20180330 20:01:17-!- mkdr0id [~null@unaffiliated/matthiaskrgr] has quit [Client Quit] 20180330 20:01:29< celticminstrel> It might be in SLF too? Not sure. 20180330 20:01:57< gfgtdf> i actualyl don't think it'll work, i somehow remember havign a discussion anout it recentl 20180330 20:04:18< celticminstrel> When was the 1.14 release slated for, again? I see one place that says April 22 but I also saw someplace saying May 1. 20180330 20:05:03<+discordbot> Says May 1st up on the header thing over here. 20180330 20:05:30< celticminstrel> Not in the IRC topic. 20180330 20:05:50< celticminstrel> The IRC topic also says "announcing soon" of 1.13.12 though, so clearly it hasn't been updated recently. 20180330 20:06:20<+discordbot> The gold build needs to be tagged something like a week before May 1, to leave time for packaging, preparing the Steam page, etc. 20180330 20:14:35-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180330 20:14:41-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180330 20:17:24<+discordbot> May 1st is the announcement date 20180330 20:44:17<+discordbot> The 1.14.0 milestone on GitHub was the tagging date btw. 20180330 20:44:22<+discordbot> *has 20180330 20:45:36-!- commavir [vir@2604:180::502b:135a] has quit [Ping timeout: 245 seconds] 20180330 21:09:45-!- commavir [vir@2604:180::502b:135a] has joined #wesnoth-dev 20180330 21:10:55-!- gfgtdf [~chatzilla@x4e363a2d.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.93 [Firefox 52.7.3/20180322140748]] 20180330 21:18:45< irker752> wesnoth/wesnoth:opengl Sofartin 2d7b0a182b Fixed Xcode Project for OpenGL AppVeyor: All builds passed 20180330 21:28:33-!- louis94 [~~louis94@149.36-245-81.adsl-dyn.isp.belgacom.be] has joined #wesnoth-dev 20180330 21:55:02-!- atarocch [~atarocch@93.56.164.28] has joined #wesnoth-dev 20180330 21:58:26< celticminstrel> ... 20180330 21:59:14< celticminstrel> ...oh right, I implemented it in C++. 20180330 21:59:20 * celticminstrel was trying to find invoke_synced_command. 20180330 22:00:11-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection] 20180330 22:01:37-!- louis94 [~~louis94@149.36-245-81.adsl-dyn.isp.belgacom.be] has quit [Quit: Konversation terminated!] 20180330 22:02:35-!- louis94 [~~louis94@149.36-245-81.adsl-dyn.isp.belgacom.be] has joined #wesnoth-dev 20180330 22:08:24-!- gfgtdf [~chatzilla@x4e363a2d.dyn.telefonica.de] has joined #wesnoth-dev 20180330 22:09:09< wedge009> ...that was supposed to be a bunny? >.< 20180330 22:09:31< gfgtdf> looks like that 20180330 22:09:31< celticminstrel> It wasn't a great one in my non-fixed-width font, for sure. 20180330 22:09:40< celticminstrel> Does vaguely resemble one though. 20180330 22:09:56< wedge009> Yeah, mine is non-fixed-width too. 20180330 22:09:56< gfgtdf> with a bit of imagination you can see it better at https://www.wesnoth.org/irclogs/2018/03/%23wesnoth-dev.2018-03-30.log 20180330 22:10:18< gfgtdf> also it wrote each line twice for some reason .. 20180330 22:10:19< wedge009> Ah, no left spacing killed it. 20180330 22:11:17< celticminstrel> That was the bots fault though, I think. 20180330 22:11:26< celticminstrel> Pretty sure IRC doesn't care about left spacing. 20180330 22:12:05< gfgtdf> test 20180330 22:16:08-!- louis94 [~~louis94@149.36-245-81.adsl-dyn.isp.belgacom.be] has quit [Remote host closed the connection] 20180330 22:16:22-!- atarocch [~atarocch@93.56.164.28] has quit [Remote host closed the connection] 20180330 22:17:02-!- louis94 [~~louis94@149.36-245-81.adsl-dyn.isp.belgacom.be] has joined #wesnoth-dev 20180330 22:27:02< gfgtdf> do we have a date for 1.13.13 ? 20180330 22:28:11<+discordbot> Says April 1st over here. So... maybe? 20180330 22:28:31< gfgtdf> ok 20180330 22:30:50< gfgtdf> zookeeper: an opinion on https://github.com/wesnoth/wesnoth/issues/2785 ? 20180330 22:34:35< zookeeper> gfgtdf, well clearly we can't just change the behavior again now, so it's a moot point. 20180330 22:35:58< irker752> wesnoth: Celtic Minstrel wesnoth:schema a2e5e28b5a51 / src/serialization/tag.cpp: Schema: Extra sanity check for [elseif] tags https://github.com/wesnoth/wesnoth/commit/a2e5e28b5a517b158095b6b3ec918b1b761b3bd1 20180330 22:35:59< irker752> wesnoth: Celtic Minstrel wesnoth:schema 8a11d6c74e0c / src/serialization/tag.cpp: Schema: Fix [elseif] requiring an [then] tag https://github.com/wesnoth/wesnoth/commit/8a11d6c74e0c2993b2b85b93c4ac6197ab9fa491 20180330 22:36:02< irker752> wesnoth: Celtic Minstrel wesnoth:schema 291e5aca71ef / data/schema/ (ai/_main.cfg ai/aspect_complex.cfg ai/modify.cfg game_config.cfg): Schema: Definition of [modify_ai] tag https://github.com/wesnoth/wesnoth/commit/291e5aca71ef4cca0e6fd4be92b7ed3a77ff0ce7 20180330 22:36:04< irker752> wesnoth: Celtic Minstrel wesnoth:schema 4bb45b8a9077 / data/lua/wml/set_variable.lua: Support [set_variable]round=trunc https://github.com/wesnoth/wesnoth/commit/4bb45b8a90776808265f47967f501680be3dd83f 20180330 22:36:05< irker752> wesnoth: Celtic Minstrel wesnoth:schema c609395ab55f / data/lua/functional.lua: Lua API: Small fixup to functional.reduce https://github.com/wesnoth/wesnoth/commit/c609395ab55fa54646579b471983058c5f4d2b7f 20180330 22:36:08< irker752> wesnoth: Celtic Minstrel wesnoth:schema 64d3e92a6e1e / data/schema/units/modifications.cfg: Fix [effect][set_specials] not correctly allowing special ability tags https://github.com/wesnoth/wesnoth/commit/64d3e92a6e1e07001cbb2f7ce43773c41262fbae 20180330 22:36:09< irker752> wesnoth: Celtic Minstrel wesnoth:schema 40f949b9a580 / data/schema/ (6 files in 4 dirs): Schema: Add all known ActionWML and ConditionalWML tags (based on wiki) https://github.com/wesnoth/wesnoth/commit/40f949b9a58058faf3bd97c8874abfae854449d3 20180330 22:36:12< irker752> wesnoth: Celtic Minstrel wesnoth:schema da15897994a9 / data/lua/wml/message.lua: Handle speaker=id directly in [message] instead of relying on SUF https://github.com/wesnoth/wesnoth/commit/da15897994a9b47ae1b43d9d3382a4c90279dd52 20180330 22:36:14< irker752> wesnoth: Celtic Minstrel wesnoth:schema cca6a1b7aa1f / src/units/filter.cpp: Remove speaker=id support from SUF https://github.com/wesnoth/wesnoth/commit/cca6a1b7aa1f7fcb69c403298bf014f255e0e054 20180330 22:36:16< irker752> wesnoth: Celtic Minstrel wesnoth:schema a9066d506f22 / data/lua/wml/message.lua: Nicer handling of some Pango formatting attributes in [message] https://github.com/wesnoth/wesnoth/commit/a9066d506f225287fbf8a49ffca83a822698f0d2 20180330 22:36:18< irker752> wesnoth: Celtic Minstrel wesnoth:schema 1fc7346aec71 / data/schema/ (core/actionwml.cfg game_config.cfg): Schema: Definition of [micro_ai] tag, including all known MicroAIs https://github.com/wesnoth/wesnoth/commit/1fc7346aec7112c423b9e65faa19c79a67edeb82 20180330 22:36:20< irker752> wesnoth: Celtic Minstrel wesnoth:schema e4f057f380dd / data/schema/ (core/actionwml.cfg game_config.cfg types/pango.cfg): Schema: Pango formatting keys for [message] https://github.com/wesnoth/wesnoth/commit/e4f057f380ddad2481a529fea4149094d6d39775 20180330 22:36:22< irker752> wesnoth: Celtic Minstrel wesnoth:schema 4fdf94df3dd0 / data/lua/wml/objectives.lua: Use wesnoth.format instead of string.format for translateable strings in [object https://github.com/wesnoth/wesnoth/commit/4fdf94df3dd05e3438ef6b58127a2b7d0fd20d0d 20180330 22:36:24< irker752> wesnoth: Celtic Minstrel wesnoth:schema 7fca563aef0b / data/lua/wml/set_variable.lua: Support root=cube and root=int in [set_variable] https://github.com/wesnoth/wesnoth/commit/7fca563aef0b783f8e185855e184204203c9532d 20180330 22:36:26< irker752> wesnoth: Celtic Minstrel wesnoth:schema a0ec7162f2d3 / src/game_events/action_wml.cpp: Support force_scroll in [move_units_fake] (same as in [move_unit_fake]) https://github.com/wesnoth/wesnoth/commit/a0ec7162f2d31a61b13e22042da1ee0635fc52c5 20180330 22:36:28< irker752> wesnoth: Celtic Minstrel wesnoth:schema 41bc71a9eb35 / data/lua/wml/role.lua: Support facing in [role][auto_recall] https://github.com/wesnoth/wesnoth/commit/41bc71a9eb35b98bb7b8859fd1f03c731bae0fed 20180330 22:36:30< irker752> wesnoth: Celtic Minstrel wesnoth:schema 419439873929 / src/persist_var.cpp: Fix an incorrect error message in [clear_global_variable] https://github.com/wesnoth/wesnoth/commit/419439873929421cc6c1c1a40790968ce4adef6b 20180330 22:36:32< irker752> wesnoth: Celtic Minstrel wesnoth:schema 2fe239e2236a / data/schema/ (7 files in 4 dirs): Schema ActionWML: Small bugfixes and add undocumented stuff from perusing source https://github.com/wesnoth/wesnoth/commit/2fe239e2236a70a7cedfbe9594b31c9964638608 20180330 22:38:54< zookeeper> gfgtdf, what was left unclear to me was whether https://github.com/wesnoth/wesnoth/commit/c64c6f513aeb2037669ec35987f74edf5c9c7247 introduced some kind of bug(s) or not. 20180330 22:42:41< gfgtdf> well it does what the message says it does, previosuly sides with "type=\n no_leader=yes" or type=\n leader_lock=yes" had a random leader generated for them, now they don't 20180330 22:43:28< irker752> wesnoth: Celtic Minstrel wesnoth:master b483d96f5008 / src/config.cpp: Fix [filter_wml] implementation so that [or] tags actually work https://github.com/wesnoth/wesnoth/commit/b483d96f500827ccacc78f3c2e89fc6690a3d2df 20180330 22:43:30< irker752> wesnoth: Celtic Minstrel wesnoth:master 5ee9b094708e / src/config.cpp: Add a way in [filter_wml] to match key values against a glob https://github.com/wesnoth/wesnoth/commit/5ee9b094708e456e94e1b6ac2309bccac3d03a9d 20180330 22:43:32< irker752> wesnoth: Celtic Minstrel wesnoth:master beb5dc75aaa6 / data/lua/wml/set_variable.lua: Support [set_variable]round=trunc https://github.com/wesnoth/wesnoth/commit/beb5dc75aaa60af30dcfe58074771080b5da3aeb 20180330 22:43:34< irker752> wesnoth: Celtic Minstrel wesnoth:master 2bd2a8b1b6d7 / data/lua/wml/message.lua: Handle speaker=id directly in [message] instead of relying on SUF https://github.com/wesnoth/wesnoth/commit/2bd2a8b1b6d7bba67b6d1b4eb0e03dca56f5a54a 20180330 22:43:36< irker752> wesnoth: Celtic Minstrel wesnoth:master d48206bdbe73 / src/units/filter.cpp: Remove speaker=id support from SUF https://github.com/wesnoth/wesnoth/commit/d48206bdbe73c1060f1705ca07d3ee02641f85c1 20180330 22:43:38< irker752> wesnoth: Celtic Minstrel wesnoth:master c835e5b7e660 / data/lua/wml/message.lua: Nicer handling of some Pango formatting attributes in [message] https://github.com/wesnoth/wesnoth/commit/c835e5b7e660e0842ab765d6cab7615a8790af2b 20180330 22:43:40< irker752> wesnoth: Celtic Minstrel wesnoth:master 15ae9fcb0cc9 / data/lua/wml/objectives.lua: Use wesnoth.format instead of string.format for translateable strings in [object https://github.com/wesnoth/wesnoth/commit/15ae9fcb0cc93da52c4ee1100c4422d815b8b28d 20180330 22:43:42< irker752> wesnoth: Celtic Minstrel wesnoth:master 7a3d6f958a2f / data/lua/wml/set_variable.lua: Support root=cube and root=int in [set_variable] https://github.com/wesnoth/wesnoth/commit/7a3d6f958a2f8c89488a7a3d2439c37ae50032c8 20180330 22:43:44< irker752> wesnoth: Celtic Minstrel wesnoth:master 325f4c40705b / src/game_events/action_wml.cpp: Support force_scroll in [move_units_fake] (same as in [move_unit_fake]) https://github.com/wesnoth/wesnoth/commit/325f4c40705b96ed4f5a009bfb76e0d30297743c 20180330 22:43:46< irker752> wesnoth: Celtic Minstrel wesnoth:master ea0bcec92f02 / data/lua/wml/role.lua: Support facing in [role][auto_recall] https://github.com/wesnoth/wesnoth/commit/ea0bcec92f021c9e2c1efc838508d5d662803771 20180330 22:43:48< irker752> wesnoth: Celtic Minstrel wesnoth:master 6184489a6523 / src/persist_var.cpp: Fix an incorrect error message in [clear_global_variable] https://github.com/wesnoth/wesnoth/commit/6184489a6523ef91433cf894825184e9011177c2 20180330 22:43:50< irker752> wesnoth: Celtic Minstrel wesnoth:master 8becc799c1b5 / changelog.md: Update changelog https://github.com/wesnoth/wesnoth/commit/8becc799c1b5cce8f08d756dfb41628cb5c3be68 20180330 22:48:35< celticminstrel> Forgot to check the last schema commit has no syntax errors. Whoops! 20180330 22:48:41< celticminstrel> Good thing it's not on master. 20180330 23:08:43-!- travis-ci [~travis-ci@ec2-23-20-176-38.compute-1.amazonaws.com] has joined #wesnoth-dev 20180330 23:08:44< travis-ci> gfgtdf/wesnoth#1058 (ingamechat2 - 1d0705e : gfgtdf): The build passed. 20180330 23:08:44< travis-ci> Build details : https://travis-ci.org/gfgtdf/wesnoth/builds/360450163 20180330 23:08:44-!- travis-ci [~travis-ci@ec2-23-20-176-38.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180330 23:19:45<+discordbot> Release in 25 hours. 20180330 23:20:00<+discordbot> @zookeeper did you look at the story art you promised to look at last weekend? 20180330 23:20:19-!- travis-ci [~travis-ci@ec2-54-221-128-240.compute-1.amazonaws.com] has joined #wesnoth-dev 20180330 23:20:20< travis-ci> wesnoth/wesnoth#17337 (schema - 2fe239e : Celtic Minstrel): The build is still failing. 20180330 23:20:20< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/360465223 20180330 23:20:20-!- travis-ci [~travis-ci@ec2-54-221-128-240.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180330 23:21:48-!- travis-ci [~travis-ci@ec2-54-221-128-240.compute-1.amazonaws.com] has joined #wesnoth-dev 20180330 23:21:49< travis-ci> gfgtdf/wesnoth#1059 (ingamechat2 - d40496e : gfgtdf): The build passed. 20180330 23:21:49< travis-ci> Build details : https://travis-ci.org/gfgtdf/wesnoth/builds/360469396 20180330 23:21:49-!- travis-ci [~travis-ci@ec2-54-221-128-240.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180330 23:23:23< zookeeper> @Vultraz, i was too sick for that until about yesterday, so no. what's one week of delay, eh? :p 20180330 23:24:56<+discordbot> oh, geez 😦 20180330 23:25:02<+discordbot> hope you're better 20180330 23:25:03< zookeeper> i wonder, what might have caused this change? https://forums.wesnoth.org/viewtopic.php?p=625354#p625354 20180330 23:25:45<+discordbot> ask celmin 20180330 23:26:52< celticminstrel> I can't think of anything recently touched that would affect that... 20180330 23:27:41< celticminstrel> But I guess grepping the source for "\"disable\"" should help find the cause probably? 20180330 23:28:11< celticminstrel> Oh, I guess it might be related to all the specials context stuff. 20180330 23:28:22< celticminstrel> Maybe we should have the specials context struct store the previous context or something. 20180330 23:30:52< gfgtdf> ye probably the context is reset before "disable" is checked 20180330 23:34:27-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 240 seconds] 20180330 23:35:45-!- louis94 [~~louis94@149.36-245-81.adsl-dyn.isp.belgacom.be] has quit [Ping timeout: 264 seconds] 20180330 23:42:10< irker752> wesnoth: Sofartin wesnoth:master 917401acaa1d / projectfiles/Xcode/ (2 files in 2 dirs): Remove rest of Growl things and CodeSign everything after copy https://github.com/wesnoth/wesnoth/commit/917401acaa1d0e98b0946c36fd2ab857c3476cc0 20180330 23:52:46< irker752> wesnoth/wesnoth:1.14 Celtic Minstrel cfceec1d58 Fix unintended change to the semantics o AppVeyor: All builds passed 20180330 23:59:02<+discordbot> @hrubymar10 PR 2786 not merged to 1.14 Merge conflict removing SDL_ttf disapproved. Please verify Growl shouldbe removed for 1.14 and code signing changes needed there. I consider OpenGL to be @jyrkive 's branch: he can cherry-pick if he feels your commit is required prioer to merging to master. --- Log closed Sat Mar 31 00:00:22 2018