--- Log opened Sat Mar 31 00:00:22 2018 20180331 00:02:40<+discordbot> It should be removed from 1.14. 20180331 00:03:22< celticminstrel> IMO the primary reason for Growl support is for 10.7 and earlier users. 20180331 00:03:36<+discordbot> ^ 20180331 00:03:40<+discordbot> and we're dropping 10.7 20180331 00:03:43<+discordbot> support 20180331 00:05:34-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180331 00:06:49<+discordbot> "And we dropped 10.7 support for 1.13.x and 1.14.x" 20180331 00:06:52<+discordbot> ??? 20180331 00:07:40< celticminstrel> Mainly because it appers to be impossible AFAICT to produce binaries that work on both 10.7 and 10.12 or whatever the latest is. 20180331 00:09:05-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 256 seconds] 20180331 00:09:17<+discordbot> Not impossible by far, just doesn't fit the current approach to take binary libraries from Homebrew. 20180331 00:09:32<+discordbot> I can hand-edit to remove the drop of SDL_ttf when picking the commit over to 1.14 but I thought we were bumping the min past macOS 10.7 after 1.14 .. that is, master-only. 20180331 00:10:59<+discordbot> I don't agree, I believe we could still use old binary libraries just fine, but the people who do actual work should have some freedom in their decisions. 20180331 00:11:22< celticminstrel> The drop of SDL_TTF does not apply to 1.14. 20180331 00:11:35< celticminstrel> Oh, right, that's what you were saying though. 20180331 00:12:24<+discordbot> Which was a full-stop for me. I was about to commit a hand-merge of the commit when I realized that I was not sure when we dropped Growl .. 1.13->1.14 or 1.14->1.15. 20180331 00:13:07< celticminstrel> We could keep Growl for 1.14 (I think it does run on post-10.7 systems), but there's little point IMO. 20180331 00:15:23<+discordbot> I dont use macOS .. so won't make the call. I can do the work and test on macOS 1.13.3 but that's just a pass/fail check .. don't know what changes when and platform-specific needs. 20180331 00:21:11< gfgtdf> how do i change a side that i made 'idle' ? i tried "control " to get contorl over it but that didn't work 20180331 00:22:09< gfgtdf> ok found it, i needed 'idle' command 20180331 00:25:46< irker752> wesnoth: gfgtdf wesnoth:1.14 ef2db5650cf0 / src/synced_user_choice.cpp: pull remote user input even if we are doing a local choice. https://github.com/wesnoth/wesnoth/commit/ef2db5650cf03ef1e0e3f697018c69fa01347dd0 20180331 00:25:48< irker752> wesnoth: gfgtdf wesnoth:1.14 4cd98821a936 / src/replay.cpp: treat local choices as like sycned contexts in replay.cpp https://github.com/wesnoth/wesnoth/commit/4cd98821a936aa526f633b9927c61e50ae08a25a 20180331 00:28:22-!- stikonas_ is now known as stikonas 20180331 00:36:23<+discordbot> gfgtdf also to master? 20180331 00:36:36< gfgtdf> ye will do 20180331 01:01:33-!- Bonobo [~Bonobo@203.220.138.198] has joined #wesnoth-dev 20180331 01:09:40-!- gfgtdf_ [~chatzilla@x4e32b735.dyn.telefonica.de] has joined #wesnoth-dev 20180331 01:11:26< irker752> wesnoth/wesnoth:1.14 pentarctagon ae332bf8b1 Give 1.14 its own docker image. AppVeyor: All builds passed 20180331 01:12:40-!- gfgtdf [~chatzilla@x4e363a2d.dyn.telefonica.de] has quit [Ping timeout: 256 seconds] 20180331 01:12:50-!- gfgtdf_ is now known as gfgtdf 20180331 01:18:58< celticminstrel> gfgtdf: Still working on it? 20180331 01:19:11< gfgtdf> on what? 20180331 01:19:21< celticminstrel> Cherry-picking those commits to master. 20180331 01:19:54< gfgtdf> no, will to that later, next time i checkout master. 20180331 01:19:57< celticminstrel> ... 20180331 01:20:15< celticminstrel> BTW, can you think of a list of places to look for undocumented WML features? 20180331 01:20:46< celticminstrel> I already covered wml-tags.lua and wml_actions.cpp and was going to look in units/filter.cpp, side_filter.cpp, etc. 20180331 01:21:04< celticminstrel> (Basically the four filters.) 20180331 01:21:11< celticminstrel> I guess maybe also units/abilities.cpp? 20180331 01:22:34< gfgtdf> hmm so basicially everythign that takes cfg parameters? 20180331 01:22:45< celticminstrel> I dunno, maybe? 20180331 01:22:54< celticminstrel> Everything that influences the WML API. 20180331 01:23:19< celticminstrel> But things like savegame and network protocol don't count. 20180331 01:24:30< gfgtdf> i mean we some a lot stuff uni unit.cpp (the effects, the units ctor), in unit types you can look for undocuemnted keys on [unit_type], and of cours the whole lua api (scripting/) 20180331 01:25:06< celticminstrel> I don't think scripting/ influences the WML API at all, does it? 20180331 01:25:19< gfgtdf> and ofcourse a lot of functiosn just forward their config objects to other functions, like gamemap::overlay 20180331 01:26:10< gfgtdf> well some wml actions in wml-tag.lua are siply defined as 'function wesnoth.wml_actions.name(cfg) wesnoth.name(cfg) end' iirc 20180331 01:26:40< celticminstrel> Ah, true, there are still a few of those. I tried to cut down on them, but didn't get them all. 20180331 01:28:31< celticminstrel> O_O 20180331 01:28:38< celticminstrel> I started A New Land and was instantly defeated. 20180331 01:28:41< gfgtdf> just search for checkconfig i'd say, intf_set_music, intf_add_tile_overlay are some of the first thing of those. 20180331 01:28:51< gfgtdf> celticminstrel: soudns like a known bug 20180331 01:29:00< gfgtdf> i tohught zookeeper fixed it ? 20180331 01:29:38< gfgtdf> zookeeper: ^ 20180331 01:29:59< gfgtdf> celticminstrel: basically you have to add lick_faction=no etc to all sides 20180331 01:30:08< gfgtdf> lock_faction=no* 20180331 01:30:23< gfgtdf> iirc 20180331 01:30:26< celticminstrel> My branch is based off b81c53c. 20180331 01:31:01< celticminstrel> I don't see a fix later than that (or indeed any commits from zookeeper). 20180331 01:34:46-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20180331 01:40:54< gfgtdf> hmm ye then he probbly didn't commit(push it. 20180331 01:42:12-!- gfgtdf [~chatzilla@x4e32b735.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.93 [Firefox 52.7.3/20180322140748]] 20180331 01:48:06< celticminstrel> FTR, changing faction_lock to no does not fix it. 20180331 02:09:44< celticminstrel> https://github.com/wesnoth/wesnoth/issues/2779 20180331 02:09:48< celticminstrel> Requesting comments. 20180331 02:10:06< celticminstrel> Particularly if mattsc is around (do I ping @mattsc or @csttam ?) 20180331 02:21:33<+discordbot> cstam on discord 20180331 02:23:01< irker752> wesnoth/wesnoth:master Sofartin 28299dd597 Remove rest of Growl things and CodeSign AppVeyor: All builds passed 20180331 02:23:25< celticminstrel> Only one t? @cstam ? 20180331 02:24:06<+discordbot> No. two. And you pinged him in "Particularly if ..." above 20180331 02:24:20< celticminstrel> Yeah okay, that's what I thought. 20180331 02:30:53< celticminstrel> Okay, next question. Can anyone tell what this does? https://github.com/wesnoth/wesnoth/blob/master/data/campaigns/Legend_of_Wesmere/lua/wml_tags.lua#L32 20180331 02:31:19< celticminstrel> Is it trying to take a subset of a map, perchance? I'm not quite sure. 20180331 02:32:33< celticminstrel> More to the point, does it seem worth importing the feature into core? 20180331 02:34:14< celticminstrel> Also, does [shift_labels] (a bit higher up in that file) seem worth importing into core? 20180331 02:40:53<+discordbot> Looks like it's using something like { x=3-5 y=2-4 } to replace (3,2) through (5,4) of the map with a new map. I question the math without more looking but it appears to do the job. 20180331 02:41:29< celticminstrel> So wait... 20180331 02:42:01< celticminstrel> Is it taking the new map and dropping it on top of the old map somewhere in the middle, with the edges unchanged; or is it taking the new map, trimming the edges, and replacing the old map with that? 20180331 02:44:54<+discordbot> Not sure. I think that's the '+ 2` bit, trying to stay off the edges. Looks like it should work but probably needs some testing and experimenting if you're looking to document it. 20180331 02:46:02<+discordbot> The shift labels bit .. first loop removes the existing label, second puts it back at the offset location. Not sure why you'd want to do that unless you're doing marching ants. 20180331 02:46:18< celticminstrel> FTR, if it's the former case it should be changed to [terrain_mask]. If it's the latter, obviously it shouldn't be. 20180331 02:46:43< celticminstrel> I think LoW actually needs shift_labels because of the [replace_map] extension. 20180331 02:47:04<+discordbot> shrugs Looks like it works but don't ask me why it's needed or why it does a +2 20180331 02:47:22< celticminstrel> ...yeah the +2 is a bit weird indeed. 20180331 02:47:40<+discordbot> So shift labels is needed to fix and off-by-one bug? Rather than fix the bug? sheesh 20180331 02:48:43< celticminstrel> Well, after [replace_map]x,y=9-53,9-53 it then calls [shift_labels]x,y=-8,-9, so it does seem like they're related. 20180331 02:49:25<+discordbot> Ah. OK. Makes sense. 20180331 02:49:46< celticminstrel> Though why it shifts x by -8 instead of -9, I'm not sure. 20180331 02:50:26<+discordbot> Lots of stuff about maps makes not sense, mainly due to the strange coordinante system. 20180331 02:50:38< celticminstrel> I guess it could be something about that, yeah. 20180331 02:51:25<+discordbot> the fact if needed to do both makes you wonder if it's waving a huge read "BUG HERE!" flag 20180331 02:51:34<+discordbot> Huge. Red. 20180331 02:51:43< celticminstrel> Heh. 20180331 02:52:05< celticminstrel> It does seem like what it really wants is [crop_map]. 20180331 02:52:25< celticminstrel> Which, done properly, would move the labels and everything for you (it would probably need to be implemented in C++ ATM). 20180331 02:52:34< celticminstrel> That's if I'm reading it correctly. 20180331 02:52:52<+discordbot> Or that there's a parameter missing. "Relative" or "Absolute" or something like that, for lables and named locations 20180331 02:53:17< celticminstrel> ...wait. Wait. What the heck? *gape* 20180331 02:53:35< celticminstrel> https://github.com/wesnoth/wesnoth/blob/master/data/campaigns/Legend_of_Wesmere/scenarios/chapter2/07_Elves_Last_Stand.cfg#L244 20180331 02:53:46< celticminstrel> What is it doing here!? That has never worked, has it? 20180331 02:54:08< celticminstrel> [ai] in [unit] is only useful if you're using the unit_formulas (FormulaAI) stage. 20180331 02:54:18< celticminstrel> It doesn't accept aspects or anything like that. 20180331 02:54:21< celticminstrel> :| 20180331 02:54:45< celticminstrel> Is... is all that supposed to be up one level, in the [side]? 20180331 02:55:00< celticminstrel> But it's duplicated twice in different units. Did someone just Not Understand? 20180331 02:55:42<+discordbot> Or copy and paste an entire block not knowing what was important and what was not, depending upon stuff being ignored if not needed? 20180331 02:55:47< celticminstrel> WHAT 20180331 02:55:52< celticminstrel> The two blocks are DIFFERENT 20180331 02:56:01< celticminstrel> And there's a ... 20180331 02:56:16< celticminstrel> OH, extra_recruit is used, so the presence of different recruitment_patterns does actually make sense... 20180331 02:56:43< celticminstrel> The aggressions are the same, at least... caution and attack_depth are the same.. grouping is different and recruitment patterns are different. 20180331 02:57:26< celticminstrel> Okay, I guess LoW7 is the next thing I work on. >_> 20180331 02:58:22< celticminstrel> I think setting the leader_aggression aspect globally on the side would have the same effect that they seem to have intended. The only thing I don't think I can do is making the grouping aspect depend on the leader. 20180331 02:58:49<+discordbot> I always hate that scene. Mainly because it caused me to panic when I first played it and was swamped with enemies. Took me a while to realize it's not overpower, I was under-speeded. 20180331 02:59:47< celticminstrel> Does side 7 have multiple keeps? 20180331 03:00:48<+discordbot> Dunno. There's a bunch of 'em on the map/. 20180331 03:45:25<+discordbot> maybe you should skip LoW šŸ˜› 20180331 03:46:03<+discordbot> and do it last 20180331 03:53:34<+discordbot> // ...then recursively check this section's sub-section's sub-sections. 20180331 03:53:35<+discordbot> heeheehee 20180331 03:53:42<+discordbot> SUBSECTIONCEPTION 20180331 03:56:36< celticminstrel> I don't think it makes any difference what order I do things in. 20180331 03:56:59< celticminstrel> That said, I need to wait on mattsc before I can finish the LoW7 thing, so I may move on soon and come back to it again later. 20180331 03:57:02<+discordbot> well it means you can focus more on easier-to-fix stuff elsewhere 20180331 03:57:30< celticminstrel> LoW has in fact helped me track down numerous errors in the schema definition, so it's not like I'm making no progress here. 20180331 03:57:40< celticminstrel> BTW, does anyone know what the proper format for [endlevel]bonus is? 20180331 03:57:41<+discordbot> ah 20180331 03:57:47< celticminstrel> The wiki is a little unclear. 20180331 03:57:56<+discordbot> not off the top of my head 20180331 04:09:27< celticminstrel> ...what would [unit]color= be? 20180331 04:09:38< celticminstrel> Or [unit]flag= ? 20180331 04:09:53< celticminstrel> Just misplaced keys, maybe? 20180331 04:10:02<+discordbot> maybe? 20180331 04:10:07<+discordbot> you'd have to check if they work 20180331 04:10:38< celticminstrel> LoW does use a lot of macros so I wouldn't be surprised if some of them usually go straight in [side] but occasionally end up instead in [unit]. 20180331 04:11:01<+discordbot> LoW is kinda a mess 20180331 04:11:07<+discordbot> scratch that - definitely a mess 20180331 04:11:18< celticminstrel> You can say that again XD 20180331 04:13:20<+discordbot> The problem is it wants to be both SP and MP. And it's inconsistent in MP. 20180331 04:28:11< irker752> wesnoth: Celtic Minstrel wesnoth:schema_fixes 3c3a45a7ccae / data/core/ (editor/_main.cfg macros/sound-utils.cfg): Fix useless [event] in [titlescreen_music] https://github.com/wesnoth/wesnoth/commit/3c3a45a7ccae52da9090e39696cc5da1d479413c 20180331 04:28:13< irker752> wesnoth: Celtic Minstrel wesnoth:schema_fixes d7f96496702e / data/ (64 files in 18 dirs): Embrace turns=unlimited as a way of specifying unlimited turns https://github.com/wesnoth/wesnoth/commit/d7f96496702e363a4a75fd74c9070415aaaa5736 20180331 04:28:15< irker752> wesnoth: Celtic Minstrel wesnoth:schema_fixes bccc4f090084 / data/multiplayer/_main.cfg: Fix erroneous [event] in [lobby_music] https://github.com/wesnoth/wesnoth/commit/bccc4f0900847f12516acf8d51f1fe059df3b14f 20180331 04:28:17< irker752> wesnoth: Celtic Minstrel wesnoth:schema_fixes 70525be2c101 / data/multiplayer/scenarios/ANL_utils/ (ANL_general_macros.cfg ANL_special_macros.cfg): ANL: Remove needless silent= key from [object]s https://github.com/wesnoth/wesnoth/commit/70525be2c1016564b5aec41e45c4a20dbac3b277 20180331 04:28:19< irker752> wesnoth: Celtic Minstrel wesnoth:schema_fixes 731c798d0fc1 / data/campaigns/Legend_of_Wesmere/scenarios/ (8 files in 3 dirs): LoW: Remove redundant AI definitions https://github.com/wesnoth/wesnoth/commit/731c798d0fc12fda4ce9c14f8610692aaccaf930 20180331 04:28:21< irker752> wesnoth: Celtic Minstrel wesnoth:schema_fixes 512c24feba12 / data/campaigns/Legend_of_Wesmere/scenarios/chapter2/07_Elves_Last_Stand.cfg: LoW7: Fix invalid use of aspects in [unit][ai] https://github.com/wesnoth/wesnoth/commit/512c24feba1283976653d26660f3bf2adf49827d 20180331 04:28:23< irker752> wesnoth: Celtic Minstrel wesnoth:schema_fixes e19aa7fe7f48 / data/campaigns/Legend_of_Wesmere/utils/characters.cfg: LoW: Fix erroneous used of unrenamable and canrecruit keys in [side] when there https://github.com/wesnoth/wesnoth/commit/e19aa7fe7f484d4d86eff628576ff28a8f655f89 20180331 04:28:25< irker752> wesnoth: Celtic Minstrel wesnoth:schema_fixes c70fd9ebd247 / data/core/macros/ai_controller.cfg: Fix error in AI control core macros https://github.com/wesnoth/wesnoth/commit/c70fd9ebd247b3b9e7ffbf75f22993510eabf7da 20180331 04:28:27< irker752> wesnoth: Celtic Minstrel wesnoth:schema_fixes d15da0d5a49e / data/campaigns/Legend_of_Wesmere/ (7 files in 5 dirs): LoW: Several small fixes (misplaced keys mostly) https://github.com/wesnoth/wesnoth/commit/d15da0d5a49ea76edc552a47ceaddce828852f5f 20180331 04:29:41<+discordbot> damn 20180331 04:29:45<+discordbot> šŸ‘Œ 20180331 04:29:45<+discordbot> good work 20180331 04:30:19< celticminstrel> Opened PR for initial review: https://github.com/wesnoth/wesnoth/pull/2793 20180331 04:30:32<+discordbot> We get a notification here 20180331 04:30:37< celticminstrel> Don't merge it yet. 20180331 04:30:56< celticminstrel> Yeah, you may get a notification, but there may be people in IRC who don't. 20180331 04:31:01<+discordbot> true 20180331 04:31:44< celticminstrel> I'll probably merge the first and third commits later, once I add another commit relating to the same thing (in [editor_music]). 20180331 04:32:21< celticminstrel> FTR, turns=unlimited works because any value that's not a number is read as -1, which is unlimited turns. 20180331 04:32:28<+discordbot> should we remove those ai alias files? 20180331 04:32:30< celticminstrel> So turns=kumquat would do the exact same thing. 20180331 04:32:48< celticminstrel> Regarding the alias files, I'd ask mattsc. 20180331 04:32:57< celticminstrel> But definitely don't remove them for 1.14. 20180331 04:33:51< celticminstrel> I'm probably going to take a break from this for at least a few days so that I can get some work done on my campaign. 20180331 04:34:39 * celticminstrel pokes at a Soliton for bot muting so that I can force-push my schema branch without spamming everyone. 20180331 04:34:57< celticminstrel> (Unless it spams you on Discord?) 20180331 04:35:05<+discordbot> It does not 20180331 04:35:14 * celticminstrel also notes that I don't see mute messages, so you'll need to tell me it's muted after you do it. 20180331 04:35:17<+discordbot> It just says a nice "branch x was forced pushed in commit" 20180331 04:35:47<+discordbot> Our webhook is very considerate šŸ˜› 20180331 04:35:57<+discordbot> It also doesn't display a list of more than 5 or 6 commits at a time 20180331 04:36:17< celticminstrel> ...oh yeah, I was going to look at 2761 this weekend... 20180331 04:36:34< celticminstrel> Maaaaybe on Sunday? I don't feel like it right now. >_> 20180331 04:36:57< celticminstrel> And anyway there's no urgency since it's for master, not 1.14. 20180331 04:39:27< celticminstrel> Considering implementing [crop_map] for LoW, as well. 20180331 04:40:13< celticminstrel> Ideally it would automatically shift any units, overlays (ie items), labels, and other locaiton-based stuff so that they remain on the same apparent hex. 20180331 04:40:20< celticminstrel> ^location 20180331 04:40:29< celticminstrel> (Did I miss anything in that list?) 20180331 04:41:36<+discordbot> don't think so 20180331 04:42:32< celticminstrel> [expand_map] on the other hand sounds like it would be rather useless (how do you decide what the terrain in the expanded portion is?). 20180331 04:43:16<+discordbot> yeah 20180331 04:43:38< celticminstrel> That said, I won't be implementing [crop_map] right away (unless it's as a drop-in replacement for LoW's alternate [replace_map]; that I might do to reduce the schema errors). 20180331 04:44:28< celticminstrel> Mind you I've yet to verify that [crop_map] actually is what it's doing. >_> 20180331 04:45:11<+discordbot> I don't remember 20180331 05:11:16-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180331 05:11:22-!- janebot_ [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180331 05:11:22-!- janebot_ is now known as janebot 20180331 05:18:34<+discordbot> blah. this help stuff is so TEDIOUS. 20180331 05:25:51<+discordbot> looks like weapon specials have that same problem abilities had 20180331 05:25:56<+discordbot> with the name thingy whatsit 20180331 05:35:21-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180331 05:35:27-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180331 05:47:02<+discordbot> @shadowm could you check if the "Time of Day Schedule" text is translated when you view the ToD schedule from help within a game? 20180331 05:47:22<+discordbot> looking at the code here, it seems it would not be 20180331 05:48:37-!- celticminstrel is now known as celmin|sleep 20180331 05:48:52-!- travis-ci [~travis-ci@ec2-54-91-20-190.compute-1.amazonaws.com] has joined #wesnoth-dev 20180331 05:48:53< travis-ci> wesnoth/wesnoth#17343 (schema_fixes - d15da0d : Celtic Minstrel): The build has errored. 20180331 05:48:53< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/360526443 20180331 05:48:53-!- travis-ci [~travis-ci@ec2-54-91-20-190.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180331 06:18:42<+discordbot> is it valid to have a function take an argument of type decltype(T::foo())? 20180331 06:19:33<+discordbot> ie, if I want to say, "this function takes an argument of the whatever type the function T::foo() returns? 20180331 06:23:36<+discordbot> seems it might... but with T::foo 20180331 06:23:40<+discordbot> if I'm reading this right 20180331 06:23:44<+discordbot> 2) If the argument is an unparenthesized id-expression or an unparenthesized class member access expression, then decltype yields the type of the entity named by this expression. If there is no such entity, or if the argument names a set of overloaded functions, the program is ill-formed. 20180331 06:26:52-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev 20180331 06:37:12< irker752> wesnoth/wesnoth:master Sofartin 917401acaa Remove rest of Growl things and CodeSign AppVeyor: All builds passed 20180331 07:48:00-!- Nobun [~user@host91-49-dynamic.52-79-r.retail.telecomitalia.it] has joined #wesnoth-dev 20180331 07:48:17< Nobun> sorry again.... continuing with questions about scons-wesnoth 20180331 07:50:32< Nobun> at: https://github.com/wesnoth/wesnoth/blob/master/scons/sdl.py --> from line 58 to 154 20180331 07:51:58< Nobun> why do you never use CheckLib(sdl) before TryLink? and why, on windows, did you use "env.AppendUnique(LIBS = Split("mingw32 %s %s" % (sdlmain_name, sdl_lib_name)))" 20180331 07:53:06< Nobun> I mean.... it could work with mingw32 (even if I don't understand why you must run Split on mingw, SDL_main and sdl 20180331 07:53:30< Nobun> but it seems to me that could have problems with Visual Studio... 20180331 07:54:02<+discordbot> My understanding is that VS has its own setup. 20180331 07:54:26< Nobun> so for VisualStudio you don't use scons but cmake? 20180331 07:54:46<+discordbot> No, we don't use either. 20180331 07:55:07< Nobun> ah ok. So the build supports only for mingw... make sense. 20180331 07:55:09<+discordbot> There's a VS projectfile in projectfiles/VCXX 20180331 07:55:24<+discordbot> There used to be some VS support in cmake, but it was completely unused, so I removed it. 20180331 07:55:44<+discordbot> VS and Xcode project files are handled on their own. 20180331 07:56:18< Nobun> It seems to me a clever solution. I could use the same method, even if I will never provide a Visual Studio project (and so, asking using mingw to compile the program I am writing) 20180331 07:56:56<+discordbot> technically, the codeblocks projectfile (which is sparsely maintained) is a way to build with MinGW 20180331 07:57:15< Nobun> another question. Why context.Result("yes") and context.Result("no") ? 20180331 07:57:50< Nobun> Vultraz: thank for clarification. 20180331 07:58:40< Nobun> I mean. return True and return False will be used by SConstruct to understand if the configure worked or failed. But what it is the purpose of those lines? 20180331 08:00:46-!- Oebele [~quassel@143.177.58.202] has joined #wesnoth-dev 20180331 08:00:49<+discordbot> Well, WML and lua already mixes and matches them, so why not scons? (joking, of course) 20180331 08:01:31<+discordbot> šŸ˜› 20180331 08:01:44<+discordbot> scons at least they 20180331 08:01:51<+discordbot> 'll equal the same 20180331 08:02:08<+discordbot> totally isn't annoyed about this 20180331 08:02:29<+discordbot> anyway, back on topic, I don't really know 20180331 08:02:30<+discordbot> sorry 20180331 08:02:54< Nobun> @Pentarctagon: well thank anyway :) 20180331 08:04:00< Nobun> hmm don't worry the answer was easier than I though 20180331 08:05:35< Nobun> it is simply needed by scons to know if test was successful ('yes') or not ('no'). I don't understand how scons internally use this information, but I will probably see it with experimentations 20180331 08:07:15-!- atarocch [~atarocch@2.43.53.115] has joined #wesnoth-dev 20180331 08:07:17< Nobun> ah. Ok. simply looking at source, a reply comed: It's purpose is simply to inform user on text information 20180331 08:07:39< Nobun> well, again... thank for help :) 20180331 08:09:44< loonycyborg> Nobun: as that arg to context.Result is passed the string it will print to stdout 20180331 08:09:50< loonycyborg> to show result of check 20180331 08:12:38< loonycyborg> for example I made it print the list of boost.locale backends supported in icu check instead of "yes" or "no" 20180331 08:13:00< Nobun> Ohh... nice :) 20180331 08:13:37< loonycyborg> https://github.com/wesnoth/wesnoth/blob/master/scons/boost.py#L216 20180331 08:13:40<+discordbot> For the record, context.Result(True) prints "yes". There isn't any point in passing the string "yes" explicitly. 20180331 08:13:49<+discordbot> (Same for false and "no".) 20180331 08:14:08< loonycyborg> could even use :) and :( instead 20180331 08:14:34< Nobun> interesting :) 20180331 08:15:27< Nobun> loonycyborg: from line 73 to 78. I understand you verify the SDL version by C preprocessor 20180331 08:15:39< Nobun> but can you explain exactly what the python code does? 20180331 08:15:58< Nobun> I mean: sdl_lib.upper() what do? 20180331 08:16:49< Nobun> and where do you find things like SDL_VERSIONNUM(_MAJOR_VERSION, ...) 20180331 08:20:35<+discordbot> That code generates a short C++ program. #if SDL_VERSIONNUM(SDL_MAJOR_VERSION, SDL_MINOR_VERSION, SDL_PATCHLEVEL) < SDL_VERSIONNUM(2, 0, 4) 20180331 08:20:40<+discordbot> That's C++ code. 20180331 08:21:13<+discordbot> sdl_lib.upper() simply changes the string sdl_lib to all uppercase. 20180331 08:23:13<+discordbot> The actual programs run can be found in build/sconf_temp/ after running scons. 20180331 08:38:31-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20180331 08:54:20< irker752> wesnoth/wesnoth:1.14 gfgtdf 4cd98821a9 treat local choices as like sycned conte AppVeyor: All builds passed 20180331 09:21:26<+discordbot> @Vultraz The instructions to reproduce the bug you suspect with the help text (on 1.14 or master?) are unclear. 20180331 09:22:12<+discordbot> I found it anyway. 20180331 09:22:46<+discordbot> Is it translated? 20180331 09:22:56<+discordbot> And 1.14 20180331 09:23:02<+discordbot> You canā€™t access help on master right now 20180331 09:23:19<+discordbot> It is not, obviously. 20180331 09:23:31<+discordbot> topics.emplace_back("Time of Day Schedule", "..schedule", toplevel.str()); 20180331 09:24:16<+discordbot> The good news is that the string exists in wesnoth-help. 20180331 09:24:26<+discordbot> (From data/core/help.cfg:10.) 20180331 09:24:48<+discordbot> You could file a bug and in the meantime use a direct dsgettext() call to get it from that domain. 20180331 09:25:07<+discordbot> Then replace it with the xgettext marker wrapper after 1.14.0. 20180331 09:25:49<+discordbot> The call ought to be something like translation:dsgettext("wesnoth-help, "Time of Day Schedule"). 20180331 09:26:06<+discordbot> (Missed a quote for the first parameter, IRC people. Already fixed it.) 20180331 09:27:14<+discordbot> master fix will be part of my refactors 20180331 09:27:26<+discordbot> will commit the 1.14 one later 20180331 09:27:38<+discordbot> The even better news is that the string in wesnoth-help is exactly what the C++ engine is supposed to use. 20180331 09:27:54<+discordbot> [section] id=schedule title= _ "Time of Day Schedule" generator=time_of_days sort_topics=generated [/section] 20180331 09:28:22<+discordbot> Kind of makes me feel like all of src/help/ should use wesnoth-help instead of any other textdomain. 20180331 09:28:30<+discordbot> yes, it should 20180331 09:28:35<+discordbot> right now it doesn't... 20180331 09:28:42<+discordbot> Except for strings that are more context-free, like error messages and such. 20180331 09:29:03<+discordbot> I'll add the appropriate GETTEXT_DOMAIN definition in my new files 20180331 09:30:26<+discordbot> actually, perhaps you could commit the fix on 1.14? 20180331 09:34:43<+discordbot> Okay 20180331 09:48:38< irker752> wesnoth: Iris Morelle wesnoth:1.14 e9105ab8a708 / changelog.md src/help/help_impl.cpp: help: Fix ToD Schedule topic index heading not being translatable https://github.com/wesnoth/wesnoth/commit/e9105ab8a708b729d10057ba3a9acaacc53e1d64 20180331 09:48:41< irker752> wesnoth: Iris Morelle wesnoth:1.14 161d17bdb245 / changelog.md src/help/help_impl.cpp: help: Borrow "Lawful Bonus" translation from wesnoth-lib https://github.com/wesnoth/wesnoth/commit/161d17bdb2453c5e4b2eea2ee5fc5c996706008f 20180331 09:48:44< irker752> wesnoth: Iris Morelle wesnoth:1.14 82af89f950fc / changelog.md src/help/help_impl.cpp: help: Call gettext on ToD topic strings that are already marked translatable https://github.com/wesnoth/wesnoth/commit/82af89f950fc90c3326a85cad6f5485a85d5d8b2 20180331 09:48:48<+discordbot> @Vultraz There's a bit more for you to forward-port into your work above, namely. 20180331 09:49:24<+discordbot> noted 20180331 09:49:25<+discordbot> I'm guessing it's either impossible or pointless for me to attempt a trivial forward-port right now, and I'm going to bed anyway. 20180331 09:49:41<+discordbot> yeah, I have everything moved around locally 20180331 09:49:46<+discordbot> I'll apply the changes 20180331 09:49:50<+discordbot> thanks for the commits 20180331 09:51:46<+discordbot> *namely commits #2 and #3 20180331 09:52:00<+discordbot> @Tad Carlucci , @Vultraz , @sinda and CelticMinstrel : Dropping for 10.7 was not because of Homebrew local builds. Homebrew can do work also on OS X older then 10.10. Anyway package builds are produced with bundled MacCompileStuff libraries. These libraries theoretically can support 10.7-10.13 systems so there is also no problem. Problem is that Wesnoth on mac is since 1.13.0 (I guess) 64-bit app only. OS X 10.7 is primary 20180331 09:52:00<+discordbot> 32-bit os with very small support for 64-bit. This caused many problems but worst was, that every package build (I tested primary 1.13.11 and latest 1.13.12) doesn't work on 10.7 as expected. It started but when you click on smt it crashed without useful backtrace. Debugging 64-bit on 10.7 is nearly impossible with Xcode and LLVM also didn't help much. So after that we decided to drop 10.7 . And about Growl. Only OS X 10.7 were able (weren't 20180331 09:52:01<+discordbot> in true, because project file weren't usable with 10.7's Xcode) to build Wesnoth with Growl support. Well, if other users did some project 'hacks' they was able to build it on others systems too but IMO these users aren't priority while NSUserNotification is much better (again IMO) and Growl is officially deprecated. EOF šŸ˜„ 20180331 09:52:01<+discordbot> See I'm falling asleep so hard right now I can't even complete a sentence. 20180331 09:53:50<+discordbot> changes incorporated 20180331 10:21:33< Nobun> sorry for late reply (I had to be afk) 20180331 10:22:23< Nobun> I know that test_program is a c code (shouldn't be C instead of C++ since TryLink is pointed to .c ?) 20180331 10:22:46< Nobun> my question was a bit unclear and I try to explain it better 20180331 10:25:41< Nobun> I mean. How do you find SDL_VERSIONNUM and SDL_MAJOR_VERSION in sdl api? I mean. If I had to search similar macros inside a library API how can I search and find them? 20180331 10:39:26-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180331 10:49:34< loonycyborg> either in doc or just by looking at headers 20180331 10:49:50< loonycyborg> generally they have something_version.h file 20180331 10:50:09-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20180331 10:51:01<+discordbot> for SDL it's SDL_version.h 20180331 10:51:46-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180331 10:53:21-!- louis94 [~~louis94@149.36-245-81.adsl-dyn.isp.belgacom.be] has joined #wesnoth-dev 20180331 10:56:23-!- gfgtdf [~chatzilla@x4e32b735.dyn.telefonica.de] has joined #wesnoth-dev 20180331 11:00:58<+discordbot> k 20180331 11:05:02< gfgtdf> zookeeper: are you going to commit the anl changes? 20180331 11:05:11< zookeeper> yes 20180331 11:07:32< irker752> wesnoth/wesnoth:schema_fixes Celtic Minstrel d15da0d5a4 LoW: Several small fixes (misplaced keys AppVeyor: All builds passed 20180331 11:10:32< irker752> wesnoth: ln-zookeeper wesnoth:master d0a2fde239d8 / data/multiplayer/scenarios/4p_A_New_Land.cfg: ANL: Fixed scenario brokenness stemming from force_lock_settings=yes https://github.com/wesnoth/wesnoth/commit/d0a2fde239d86d9d539846e001f96f342383ad0d 20180331 11:12:38< irker752> wesnoth: ln-zookeeper wesnoth:1.14 1ab34fde2185 / data/multiplayer/scenarios/4p_A_New_Land.cfg: ANL: Fixed scenario brokenness stemming from force_lock_settings=yes https://github.com/wesnoth/wesnoth/commit/1ab34fde218557a5fee7ea9015a1f789f42f522e 20180331 11:13:25< zookeeper> wouldn't hurt to try and spot more potential problems there, although i didn't see any. 20180331 11:15:44< zookeeper> and DF too. 20180331 11:27:50< irker752> wesnoth: Sofartin wesnoth:1.14 64240b9fbff7 / projectfiles/Xcode/ (2 files in 2 dirs): Remove rest of Growl things and CodeSign everything after copy https://github.com/wesnoth/wesnoth/commit/64240b9fbff7fca121629506877d7e91a2f1a85e 20180331 11:29:45< Nobun> thank, loonycyborg and Vultraz :)+ 20180331 11:42:22-!- louis94 [~~louis94@149.36-245-81.adsl-dyn.isp.belgacom.be] has quit [Ping timeout: 264 seconds] 20180331 11:51:58-!- lipkab [~lipk@host-91-147-210-58.biatv.hu] has joined #wesnoth-dev 20180331 11:53:24< gfgtdf> vultraz: in 1.14 when i call display::get_singleton()->redraw_everything() during a gui2 dialog the gui2 dialog disappears, do you know a good fix for that ? 20180331 11:54:39< gfgtdf> vultraz: i thought of something like "if (is_gui2dialog_open) {gui2dialog::redraw(); }" at the end of display::redraw_everything 20180331 11:54:56< gfgtdf> vultraz: do you know whetehr that's possile ? 20180331 11:56:54<+discordbot> uhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhh 20180331 11:56:59<+discordbot> hang on 20180331 11:58:04<+discordbot> i mean, there's no dialog redraw function... 20180331 11:58:18<+discordbot> probably what you want to do is um 20180331 11:58:31<+discordbot> go to gui/core/event/handler.cpp and 20180331 11:58:52<+discordbot> wait, no 20180331 11:59:05<+discordbot> redraw_everything is different from the damn event system... 20180331 11:59:39<+discordbot> yeah I really don't know 20180331 12:00:56< gfgtdf> i think there is an event that redraws the whole gui2 ? i coudl do hackish things and fire a resize event probably. 20180331 12:01:33< gfgtdf> if it doesnt happen immidialteely that's also acceptable, i really just want to fix #2794 20180331 12:02:20<+discordbot> you can dispatch a DRAW_ALL_EVENT through the main event pipeline 20180331 12:04:41< gfgtdf> ok will try that thx 20180331 12:09:41< gfgtdf> vultraz: so this is my current attempt: https://github.com/gfgtdf/wesnoth/commit/cd8bea52d34efb69d29c47be798f99e1f5214806 i assume that there is no point in putting it to master aswel ? 20180331 12:11:13<+discordbot> Does't trigger_full_redraw() make redraw_everything() redundant? 20180331 12:11:32<+discordbot> definitely 100% not needed in master 20180331 12:11:58< gfgtdf> jyrkive: i don't know actually. 20180331 12:14:46< gfgtdf> maybe te beteer fix is actually just to remove that redraw_everything 20180331 12:15:04< gfgtdf> i don't see why i shoudl be needed actually. 20180331 12:16:09<+discordbot> does it work if you do so? 20180331 12:16:31< gfgtdf> vultraz: didn' 20180331 12:16:35< gfgtdf> t test yet 20180331 12:16:38-!- octalot [~steve@178.165.128.114.wireless.dyn.drei.com] has joined #wesnoth-dev 20180331 12:17:06< gfgtdf> by current workflow is still downloading builds from appveyor which take 30 mins + 10 mins wmltests ... 20180331 12:20:48<+discordbot> šŸ˜¦ 20180331 12:20:51<+discordbot> no loal build? 20180331 12:24:40< gfgtdf> no although i shoudl probably make it work now... i always think like 'i want to get new pc anyways why bother settings up a environment' but i'm in that site for quite some time now. 20180331 12:24:46< irker752> wesnoth: Nils Kneuper wesnoth:1.14 b8300d8e20c6 / / (5 files in 4 dirs): updated French translation https://github.com/wesnoth/wesnoth/commit/b8300d8e20c6087e0819553e8a48cce240fd9843 20180331 12:24:50< irker752> wesnoth: Nils Kneuper wesnoth:master a32d689c46a2 / / (5 files in 4 dirs): updated French translation https://github.com/wesnoth/wesnoth/commit/a32d689c46a2a71c958007695eab953637ecb9f9 20180331 12:26:51-!- lipkab [~lipk@host-91-147-210-58.biatv.hu] has quit [Remote host closed the connection] 20180331 12:29:38-!- atarocch [~atarocch@2.43.53.115] has quit [Ping timeout: 260 seconds] 20180331 12:32:18-!- Oebele [~quassel@143.177.58.202] has quit [Remote host closed the connection] 20180331 12:34:21-!- Nobun [~user@host91-49-dynamic.52-79-r.retail.telecomitalia.it] has quit [Quit: WeeChat 2.1-dev] 20180331 12:42:03-!- atarocch [~atarocch@93.56.164.28] has joined #wesnoth-dev 20180331 12:51:54-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev 20180331 13:05:22< gfgtdf> ok that commit (calling video2::trigger_full_redraw()) seems to fix it, i'm not sure whetehr it's woth investigating/optimising it more if its unneeded in master anyways. 20180331 13:12:50< gfgtdf> does oemone know ehere to find the odl tracker on a webarhcieve? 20180331 13:12:53< gfgtdf> someone* 20180331 13:17:02< gfgtdf> ok found it 20180331 13:21:38-!- louis94 [~~louis94@149.36-245-81.adsl-dyn.isp.belgacom.be] has joined #wesnoth-dev 20180331 13:21:45< gfgtdf> jyrkive: it seems like DRAW_ALL_EVENT onyl calls a simple draw() on the display.cpp https://github.com/wesnoth/wesnoth/blob/1.14/src/display.cpp#L3261 so it loosk like that trigger_full_redraw() will not replace redraw_everything() 20180331 13:39:03-!- travis-ci [~travis-ci@ec2-54-221-128-240.compute-1.amazonaws.com] has joined #wesnoth-dev 20180331 13:39:04< travis-ci> gfgtdf/wesnoth#1062 (ingamechat2 - b82b5f7 : gfgtdf): The build has errored. 20180331 13:39:04< travis-ci> Build details : https://travis-ci.org/gfgtdf/wesnoth/builds/360614464 20180331 13:39:04-!- travis-ci [~travis-ci@ec2-54-221-128-240.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180331 13:56:22-!- travis-ci [~travis-ci@ec2-54-91-20-190.compute-1.amazonaws.com] has joined #wesnoth-dev 20180331 13:56:23< travis-ci> gfgtdf/wesnoth#1063 (ingamechat2 - 3264467 : gfgtdf): The build was broken. 20180331 13:56:23< travis-ci> Build details : https://travis-ci.org/gfgtdf/wesnoth/builds/360615353 20180331 13:56:23-!- travis-ci [~travis-ci@ec2-54-91-20-190.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180331 13:58:25-!- lipkab [~lipk@host-91-147-210-58.biatv.hu] has joined #wesnoth-dev 20180331 14:07:46-!- travis-ci [~travis-ci@ec2-23-20-176-38.compute-1.amazonaws.com] has joined #wesnoth-dev 20180331 14:07:47< travis-ci> gfgtdf/wesnoth#1064 (ingamechat2 - 5b5e6c2 : gfgtdf): The build failed. 20180331 14:07:47< travis-ci> Build details : https://travis-ci.org/gfgtdf/wesnoth/builds/360619532 20180331 14:07:47-!- travis-ci [~travis-ci@ec2-23-20-176-38.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180331 14:08:51< irker752> wesnoth/wesnoth:1.14 Celtic Minstrel 938515a741 LoW: Several small fixes (misplaced keys AppVeyor: All builds passed 20180331 14:11:20-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev 20180331 14:11:24< celmin|sleep> So I've been thinking about liminal. 20180331 14:11:51< mattsc> celmin|sleep: ping me as mattsc 20180331 14:12:31< mattsc> I only see discord notification if I log in, which I donā€™t do very often, but I have a script that greps for certain keywords in the irc logs that I run at least once a day. 20180331 14:12:56< celmin|sleep> Ah, okay, 20180331 14:12:58< mattsc> Iā€™m also going to see if I can change my discord nick sometime 20180331 14:14:02< celmin|sleep> Anyway, I went through the default schedules and mapped out roughly what I would expect of a liminal alignment, and I think the PR is at least on the right track. 20180331 14:15:17< mattsc> celmin|sleep: do I understand it right that you are asking whether leaving out the [] at the end of those lines should be valid syntax? 20180331 14:15:32-!- celmin|sleep is now known as celticminstrel 20180331 14:15:44< celticminstrel> That's the first thing, yeah. 20180331 14:15:51< celticminstrel> The other thing is https://github.com/wesnoth/wesnoth/pull/2793 20180331 14:16:42< celticminstrel> Particularly the LoW7 commit. 20180331 14:16:44< mattsc> Havenā€™t gotten there yet ā€¦ Whatā€™s the specific question? 20180331 14:17:39< celticminstrel> Basically it seems from the original (non-working) code as though the scenario designer wanted different aspect values to be applied for different races on a single side. 20180331 14:18:00< celticminstrel> They included AI aspect definitions in [unit][ai], which AFAIK does not work. 20180331 14:18:55< celticminstrel> And I wondered if there were a way to actually get that effect. 20180331 14:19:22< mattsc> I see. I donā€™t think thatā€™s possible, but let me refresh my memory. 20180331 14:23:40< celticminstrel> So what's the answer regarding leaving out the []? 20180331 14:27:21< mattsc> I donā€™t really have an optnion. Iā€™d say if the wiki says that thatā€™s valid syntax, we should leave it that way. But I donā€™t remember if it does (and I havenā€™t looked yet). 20180331 14:27:43< celticminstrel> The wiki was a bit vague IIRC (I did look recently). 20180331 14:27:58< mattsc> You remember which page that is on? 20180331 14:28:10< celticminstrel> I think it should be "Modifying AI Components"? 20180331 14:28:19< mattsc> okay, let me have a look 20180331 14:28:57< celticminstrel> Possibly also of note is that the core AI modification macros omit it; but of course, changing the macros is also an option. 20180331 14:29:25< celticminstrel> (At least, the add component macros omit it.) 20180331 14:30:21< mattsc> The potential problem with that then is that there are probably people who have copied those macros for their own purposes. I do that at least. 20180331 14:30:34< mattsc> So I guess Iā€™d vote for allowing that as valid syntax. 20180331 14:30:57< celticminstrel> But it certainly makes no sense to omit it for change or delete, right? 20180331 14:31:07< celticminstrel> I guess my schema actually would accept it for delete though. 20180331 14:31:32< celticminstrel> But I can change that by adding glob_on_path=*[*] 20180331 14:34:31-!- travis-ci [~travis-ci@ec2-23-20-176-38.compute-1.amazonaws.com] has joined #wesnoth-dev 20180331 14:34:32< travis-ci> gfgtdf/wesnoth#1065 (ingamechat2 - fe3641f : gfgtdf): The build was fixed. 20180331 14:34:32< travis-ci> Build details : https://travis-ci.org/gfgtdf/wesnoth/builds/360623363 20180331 14:34:32-!- travis-ci [~travis-ci@ec2-23-20-176-38.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180331 14:34:57-!- atarocch [~atarocch@93.56.164.28] has quit [Ping timeout: 240 seconds] 20180331 14:36:11< mattsc> celticminstrel: Yeah, the wiki page does not specifically say it one way or the other, but all the examples use the []. 20180331 14:37:04< mattsc> Is the schema validator supposed to be used on mainline only, or for UMC as well? 20180331 14:38:16< celticminstrel> I intend it to be applicable to both, but it'll be opt-in, like wmllint. 20180331 14:39:17< mattsc> Okay. I guess thereā€™s no harm in requiring the [] to be there then, as long as the error message is clear enough. 20180331 14:39:47< celticminstrel> The error message would be "invalid value in path" and then show the invalid value... I'm not sure if that's clear enough though. 20180331 14:40:35< celticminstrel> I was also getting "invalid tag" as a result, but I can easily make it complain about the path value but still manage to figure out whether you should have a [candidate_action] or [facet] tag. 20180331 14:41:01< celticminstrel> Since the matching to determine what kind of tag is needed is separate from the matching to determine whether the path is valid. 20180331 14:41:55< mattsc> How about ā€œinvalid or missing value in pathā€ ? 20180331 14:42:13< mattsc> And we should add a note on the wiki saying that this is required. 20180331 14:42:23< mattsc> Which nobody will ever see since the page is pretty massive. :P 20180331 14:43:03< celticminstrel> It's basically a generic message about an invalid value for a key, so I can't easily customize the message just for [modify_ai]. That's not to say it's impossible to customize it, it would just require changes to the actual schema validator code. 20180331 14:43:21< celticminstrel> It has a different message if the path key is missing altogether. 20180331 14:43:36< mattsc> Okay, thatā€™s fine. 20180331 14:44:22< celticminstrel> Okay, so I'll make the [] required but have the schema still consider it allowable when determining what sort of tag you need? 20180331 14:44:34< celticminstrel> (Consider omitting it allowable, I mean.) 20180331 14:44:51< celticminstrel> So that way if you omit it you'll get the invalid key error, but not wrong tag error. 20180331 14:45:16< mattsc> Sure. Sounds good AFAICT. 20180331 14:45:35< celticminstrel> And then I'll change the core macros to include it. 20180331 14:46:04< mattsc> Right. 20180331 14:50:50< mattsc> celticminstrel: As for your other question, I am pretty sure that aspects inside [unit][ai] have no meaning. The only thing that can go in there is unit formula AI code. 20180331 14:50:59< celticminstrel> Exactly. 20180331 14:51:17< celticminstrel> So do you think there's a way to get what the author presumably intended by adding them there? 20180331 14:51:31< mattsc> No, thatā€™s not possible. 20180331 14:51:43< mattsc> Well, not with the default AI. 20180331 14:51:50< celticminstrel> I did the recruitment_pattern part, at least. 20180331 14:52:02< celticminstrel> Using a recruitment_instructions node that has [recruit] tags with leader_id. 20180331 14:52:17< celticminstrel> Sorry, [pattern] tags; but they're basically the same thing in any case. 20180331 14:52:37< celticminstrel> Did you look at the scenario in question BTW? 20180331 14:53:34< mattsc> No, not yet. 20180331 14:53:54< mattsc> I just saw though that thatā€™s for the side leader(s)? 20180331 14:54:10< celticminstrel> Yeah, it's the leaders. 20180331 14:54:29< mattsc> Thereā€™s a possibility that [ai] tags inside the leaderā€™s [unit] tag get copied into [side][ai], I donā€™t remember. 20180331 14:54:42< mattsc> But even if that works, I am sure that that wonā€™t work for multiple leaders. 20180331 14:55:35< celticminstrel> I forget, are nagas chaotic too? 20180331 14:55:44< mattsc> yes 20180331 14:56:04< celticminstrel> So they at least wouldn't be hurt by the increased aggression / decreased caution during the night. 20180331 14:56:08< celticminstrel> Probably. 20180331 14:56:25<+discordbot> which Nagas? 20180331 14:56:32< celticminstrel> LoW 20180331 14:56:39< celticminstrel> Scenario 7 20180331 14:56:40<+discordbot> ah, ok 20180331 14:56:40< mattsc> Oh, no wait, they are neutral ... 20180331 14:56:50< celticminstrel> Oh. 20180331 14:56:57<+discordbot> was going to say the ingame help sayd they are neutral 20180331 14:57:03<+discordbot> *says 20180331 14:57:09< mattsc> the default ones, at least 20180331 14:57:22< mattsc> Right, sorry. 20180331 14:57:35< celticminstrel> Hmm. 20180331 14:58:11< celticminstrel> Basically what seems to be wanted is "the trolls and orcs become more aggressive and less cautious during the night". 20180331 14:59:16< mattsc> You canā€™t really do that and not have it apply to the rest of the units. 20180331 14:59:30< celticminstrel> Attack depth doesn't actually do anything anyway, so I guess that one could be removed? 20180331 14:59:39< mattsc> Yes. 20180331 15:00:46< celticminstrel> They also seemed to want to have only the nagas recruit scouts (the orcs and trolls had {AI_NO_SCOUTS} in their [ai] tag, which IIUC sets something like villages_per_scout, though I haven't actually looked). 20180331 15:01:05-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity] 20180331 15:01:28< celticminstrel> Wouldn't the trolls and orcs seem more aggressive at night simply because the AI knows they perform better? 20180331 15:01:36< celticminstrel> Even without aspect modifications, I mean. 20180331 15:01:54< celticminstrel> It also had grouping=no for the orcs but grouping=offensive for the trolls. 20180331 15:02:13< celticminstrel> I don't think that can be done, either. (What was the default, again...) 20180331 15:03:00< celticminstrel> But in any case... if there's a way to get a similar effect to what was probably intended, whether it's an aspect or a MicroAI or whatever, that would be good. 20180331 15:03:14< celticminstrel> https://github.com/wesnoth/wesnoth/pull/2793/commits/512c24feba1283976653d26660f3bf2adf49827d 20180331 15:03:27< celticminstrel> The specific commit where I attempted to fix it ^ 20180331 15:03:48< celticminstrel> (I think my initial guess that aggression was intended to mean the aggression of that specific unit is probably wrong.) 20180331 15:04:56< mattsc> Yeah, Iā€™d looked at that commit already. 20180331 15:05:19< celticminstrel> Ah. 20180331 15:05:19< mattsc> I donā€™t think this is possible without a major effort, which is probably not worth it. 20180331 15:05:37< celticminstrel> I see, so what would you recommend? Drop everything except the recruitment_instructions? 20180331 15:05:42< celticminstrel> Or keep some of them, or...? 20180331 15:05:45< gfgtdf> we could also just plit it into multiple sides? iirc the main reason why they were merge anyways was that wesnoth 1.12 did only support up 9 sides in mp 20180331 15:06:01< celticminstrel> Yeah, I did think of that... 20180331 15:06:03< mattsc> Even if you could set the aspects separately, it wouldnā€™t make that much of a difference. 20180331 15:06:23< mattsc> Thatā€™s an option, of course. But again, Iā€™m not sure if it is worth it. 20180331 15:06:38< mattsc> And AIs on different sides often get into each otherā€™s way. 20180331 15:06:50< mattsc> That depends on the scenario though, and I donā€™t remember how this is set up. 20180331 15:07:04< mattsc> So I would just find some reasonable value overall and leave it at that. 20180331 15:07:25< mattsc> Which is how itā€™s been so far anyway, since the desired effect was not working. 20180331 15:07:45< celticminstrel> True, true. 20180331 15:09:26-!- gfgtdf [~chatzilla@x4e32b735.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.93 [Firefox 52.7.3/20180322140748]] 20180331 15:09:39< mattsc> So yes, saparating the recruitment instructions is good (and actually possible), but besides that Iā€™d just go with the higher aggression for all units. 20180331 15:10:10< celticminstrel> So aggresion 0.75 for everyone IOW? 20180331 15:10:15< celticminstrel> At night only. 20180331 15:10:21< mattsc> Right. 20180331 15:10:36< mattsc> And just leave grouping and attack_depth at their default. 20180331 15:10:48< celticminstrel> Okay. 20180331 15:11:18< celticminstrel> And keep the caution for everyone too, and drop AI_NO_SCOUTS? 20180331 15:12:16< mattsc> Right on the caution. 20180331 15:12:33< mattsc> As for no scouts, let me check something 20180331 15:16:07< mattsc> Those two lines (AI_NO_SCOUTS and recruitment_pattern) in the original AI are contradictory anyway. 20180331 15:16:30< mattsc> The first means donā€™t recruit scouts, the second specifically says a scout should be recruited first. 20180331 15:16:37< celticminstrel> Oh, heh. XD 20180331 15:16:50< mattsc> So letā€™s drop the former. 20180331 15:24:10< irker752> wesnoth: Celtic Minstrel wesnoth:schema_fixes 097622c13da0 / data/campaigns/Legend_of_Wesmere/scenarios/chapter2/07_Elves_Last_Stand.cfg: squash! LoW7: Fix invalid use of aspects in [unit][ai] https://github.com/wesnoth/wesnoth/commit/097622c13da0fea504a3be36c9f1b96a99fcf290 20180331 15:58:10< irker752> wesnoth/wesnoth:1.14 Iris Morelle 82af89f950 help: Call gettext on ToD topic strings AppVeyor: All builds passed 20180331 16:08:42-!- gfgtdf [~chatzilla@x4e32b735.dyn.telefonica.de] has joined #wesnoth-dev 20180331 16:10:09-!- travis-ci [~travis-ci@ec2-54-221-128-240.compute-1.amazonaws.com] has joined #wesnoth-dev 20180331 16:10:11< travis-ci> wesnoth/wesnoth#17354 (schema_fixes - 097622c : Celtic Minstrel): The build passed. 20180331 16:10:11< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/360638702 20180331 16:10:11-!- travis-ci [~travis-ci@ec2-54-221-128-240.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180331 16:20:54< gfgtdf> loonycyborg: coudl you please fix https://github.com/wesnoth/wesnoth/issues/2357 ? 20180331 16:22:28< gfgtdf> hmm wait, maybe there are multiple bugs involved 20180331 16:23:07< gfgtdf> well what i am interested in is was probably borken by https://github.com/wesnoth/wesnoth/commit/36e92900c374b801df133b7221a04014b3b20b84 20180331 16:23:15< gfgtdf> broken* 20180331 16:25:29< gfgtdf> tad, please fix that, and make sure that that commit didn't intrpoduce other similar issues. 20180331 16:29:02-!- gfgtdf [~chatzilla@x4e32b735.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.93 [Firefox 52.7.3/20180322140748]] 20180331 16:29:14<+discordbot> @Vultraz I got that crash again in the OpenGL branch. 20180331 16:29:19<+discordbot> https://cdn.discordapp.com/attachments/259976436490829825/429678591123652618/unknown.png 20180331 16:30:34<+discordbot> Not going to investigate it right now. It's rare in my experience, and stuff is easier to test when render-GUI-with-hacks is up. 20180331 16:32:23< irker752> wesnoth: Jyrki Vesterinen wesnoth:opengl 5c0e86d3f54d / / (6 files in 3 dirs): Add a texture class https://github.com/wesnoth/wesnoth/commit/5c0e86d3f54d306e72ba3fb06d2cf9c54007f2bc 20180331 16:51:35< celticminstrel> ...hmm. Can I use [set_variable] on some_container.length to remove the last few entries? 20180331 16:59:14-!- atarocch [~atarocch@109.112.94.208] has joined #wesnoth-dev 20180331 16:59:19< celticminstrel> Aww, looks like I can't. :( 20180331 16:59:24< celticminstrel> We should add that though! 20180331 16:59:52< celticminstrel> Is there any other easy way to clear, say, the last three entries? 20180331 17:00:39< celticminstrel> I'm not sure if it's safe to do {CLEAR_VARIABLE container[$($container.length - 3)],container[$($container.length - 2)],container[$($container.length - 1)]} 20180331 17:01:23< celticminstrel> ...I suppose the fact that $ is evaluated from right-to-left would mean that it is safe... 20180331 17:02:12< celticminstrel> ie, if there's 12 items, the clear_variable Lua function sees container[9],container[10],container[11] 20180331 17:02:29-!- gfgtdf [~chatzilla@x4e32b735.dyn.telefonica.de] has joined #wesnoth-dev 20180331 17:03:20-!- gfgtdf [~chatzilla@x4e32b735.dyn.telefonica.de] has quit [Client Quit] 20180331 17:04:12-!- lipkab [~lipk@host-91-147-210-58.biatv.hu] has quit [Remote host closed the connection] 20180331 17:04:31-!- lipkab [~lipk@host-91-147-210-58.biatv.hu] has joined #wesnoth-dev 20180331 17:05:05< mattsc> I usually run a loop with stpe -1 when I do things like that. I donā€™t know if that qualifies as an easy way for you. 20180331 17:07:58-!- lipkab [~lipk@host-91-147-210-58.biatv.hu] has quit [Client Quit] 20180331 17:09:12< mattsc> Inverse loop? Descending loop? However you say that ā€¦ 20180331 17:10:54<+discordbot> @hrubymar10 Sorry. I had a memory lapse. 20180331 17:13:25-!- Bonobo [~Bonobo@203.220.138.198] has quit [Ping timeout: 256 seconds] 20180331 17:14:04-!- Bonobo [~Bonobo@203.220.138.198] has joined #wesnoth-dev 20180331 17:17:03< celticminstrel> ...if I use [for] for that, it won't work because end is re-evaluated for each loop... 20180331 17:17:10< celticminstrel> Which should also be documented I guess. 20180331 17:17:44< celticminstrel> I'm pretty sure there was a good reason for that but I don't remember anymore. 20180331 17:17:57< celticminstrel> Maybe so that the loop would work if you added items while iterating? 20180331 17:18:05< celticminstrel> For a forward loop that is. 20180331 17:18:52< celticminstrel> Oh wait, in this specific case it'll work because I'm using path.hexes instead of path.step.length. 20180331 17:21:38< mattsc> @hrubymar10: I compiled 1.15-dev using Xcode and that worked without a hitch. However, the user_dir is still ~Library/Application\ Support/Wesnoth_1.13/ 20180331 17:21:58< mattsc> Shouldnā€™t that be changed to 1.15? IIRC thatā€™s a setting in the Xcode project somewhere. 20180331 17:22:56<+discordbot> Yes, you are right 20180331 17:27:27-!- Bonobo [~Bonobo@203.220.138.198] has quit [Ping timeout: 240 seconds] 20180331 17:27:56< mattsc> @hrubymar10: okay, thanks 20180331 17:28:57< celticminstrel> Oddly, the for-loop is not working. The final step in the path is still there. 20180331 17:29:10<+discordbot> mattsc: I fixed it localy. I'll test it first and PR then 20180331 17:29:25<+discordbot> Should I also change path in 1.14 branch? 20180331 17:29:32< mattsc> @hrubymar10: no rush, I just thought I mention it while I am thinking about it 20180331 17:29:48< celticminstrel> For 1.14 I imagine we want to change the path only once the version is actually 1.14.0? 20180331 17:29:50< mattsc> @hrubymar10: yes, I believe so, but I donā€™t know when that should happen 20180331 17:29:51< celticminstrel> Not sure though. 20180331 17:29:59< mattsc> Yeah, same here. 20180331 17:30:46<+discordbot> It is called 1.14 and it will be 1.14 soon (well not that soon) but we can change it IMO @jyrkive ? 20180331 17:31:03< celticminstrel> Oh duh I did {CLEAR_VARIABLE $var[$i]} 20180331 17:32:41<+discordbot> @hrubymar10 The decision about the data directory on macOS belongs to developers higher up in the hierarchy, especially @Vultraz . 20180331 17:33:12<+discordbot> kk 20180331 17:35:30<+discordbot> celticminstrel: is this on 1.14 or master? since at least last I checked there was still this issue with for loops: https://github.com/wesnoth/wesnoth/issues/2699 20180331 17:35:43< celticminstrel> 1.14 20180331 17:37:01< celticminstrel> That issue doesn't even make sense... 20180331 17:37:18< celticminstrel> $counter is populated based on $i 20180331 17:37:49<+discordbot> yup 20180331 17:39:53< irker752> wesnoth: gfgtdf wesnoth:1.14 0d2870394f2b / src/playturn.cpp: fix gui2 dialog disappearing after [change_controller] https://github.com/wesnoth/wesnoth/commit/0d2870394f2b11917e9f116653ff3130dc8e296e 20180331 17:39:55< irker752> wesnoth: gfgtdf wesnoth:1.14 247e08e1d521 / src/playturn.cpp: less redraw_everything calls when receiving [change_controller] https://github.com/wesnoth/wesnoth/commit/247e08e1d521cfca3279c679f93dd0248ef23832 20180331 17:39:57< irker752> wesnoth: gfgtdf wesnoth:1.14 7fca064c6e4a / src/synced_user_choice.cpp: guard against calling user_choice_manager::pull() recursively https://github.com/wesnoth/wesnoth/commit/7fca064c6e4a4fb65ffdef90f19d49934d3ffa01 20180331 17:40:25< celticminstrel> Oh! 20180331 17:40:48-!- travis-ci [~travis-ci@ec2-54-221-128-240.compute-1.amazonaws.com] has joined #wesnoth-dev 20180331 17:40:49< travis-ci> gfgtdf/wesnoth#1066 (fwesnothd - cc03b98 : gfgtdf): The build failed. 20180331 17:40:49< travis-ci> Build details : https://travis-ci.org/gfgtdf/wesnoth/builds/360658445 20180331 17:40:49-!- travis-ci [~travis-ci@ec2-54-221-128-240.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180331 17:41:00< celticminstrel> It is working. 20180331 17:41:35< celticminstrel> I just didn't account for the fact that path.step.length is one more than path.hexes, so the first element I need to delete is path.step[$path.hexes]. 20180331 17:44:40< irker752> wesnoth: gfgtdf wesnoth:master edd7a82255e6 / src/synced_user_choice.cpp: pull remote user input even if we are doing a local choice. https://github.com/wesnoth/wesnoth/commit/edd7a82255e6ec7d8882900e0df56fb3af853436 20180331 17:44:42< irker752> wesnoth: gfgtdf wesnoth:master bce8c29568a0 / src/replay.cpp: treat local choices as like sycned contexts in replay.cpp https://github.com/wesnoth/wesnoth/commit/bce8c29568a0ba28455579e0057180f00bdd9190 20180331 17:44:44< irker752> wesnoth: gfgtdf wesnoth:master 9593062fc65e / src/synced_user_choice.cpp: guard against calling user_choice_manager::pull() recursively https://github.com/wesnoth/wesnoth/commit/9593062fc65eb1769ebdab16ed4b1d380e6aaa69 20180331 17:46:39<+discordbot> mattsec: https://github.com/wesnoth/wesnoth/pull/2798 20180331 17:46:58<+discordbot> mattsc: https://github.com/wesnoth/wesnoth/pull/2798 20180331 17:51:59-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180331 17:52:05-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180331 17:52:08< celticminstrel> IMO we really desperately need that map diff tool. 20180331 17:52:15< celticminstrel> Can someone please make it soon. 20180331 17:52:52< irker752> wesnoth: Sofartin wesnoth:master 0a9b10cfa886 / projectfiles/Xcode/Wesnoth.xcodeproj/project.pbxproj: Fix Wesnoth's Application Support dir name https://github.com/wesnoth/wesnoth/commit/0a9b10cfa8863b56fc8f309fb49e2fdbbd516c53 20180331 17:53:10< celticminstrel> I mean, maaaybe I could manage it but... 20180331 17:54:39< celticminstrel> ...actually, a good first start would be a gamemap::diff() function returning a config of ActionWML which would transform the one map into the other... 20180331 17:55:06< celticminstrel> (Though some operations it would need don't actually exist in ActionWML right now, like changing the map size.) 20180331 17:55:17< celticminstrel> Ideally a minimal config, 20180331 17:55:37< celticminstrel> Oh right, you can't set special locations at runtime either, right gfgtdf? 20180331 17:55:50< celticminstrel> Unless wesnoth.special_locations.blah = 4,5 works. 20180331 17:56:11< celticminstrel> I guess you'd need braces, wesnoth.special_locations.blah = {4,5} 20180331 17:59:46< irker752> wesnoth: Sofartin wesnoth:master 2e2015b6da71 / projectfiles/Xcode/Wesnoth.xcodeproj/project.pbxproj: Enable Testability for macOS DEBUG builds https://github.com/wesnoth/wesnoth/commit/2e2015b6da71a918db32e216a1bd30be51980830 20180331 18:01:27< irker752> wesnoth: Sofartin wesnoth:1.14 8b33f2bf9193 / projectfiles/Xcode/Wesnoth.xcodeproj/project.pbxproj: Enable Testability for macOS DEBUG builds https://github.com/wesnoth/wesnoth/commit/8b33f2bf919359ec44f21384a8d3cb0f1c1ba588 20180331 18:02:18< celticminstrel> Would be nice if the orb didn't turn orange when a unit's moves is above the maximum... 20180331 18:03:31< irker752> wesnoth: Sofartin wesnoth:master 62febff94ea4 / projectfiles/Xcode/Fix_Xcode_Dependencies: Remove redundand cp https://github.com/wesnoth/wesnoth/commit/62febff94ea444e3b09ce599f2fa497bf639bde8 20180331 18:04:28<+discordbot> I'll stop with PR spam now, I promise šŸ˜„ 20180331 18:04:59< irker752> wesnoth: Sofartin wesnoth:1.14 82e9b80452a2 / projectfiles/Xcode/Fix_Xcode_Dependencies: Remove redundand cp https://github.com/wesnoth/wesnoth/commit/82e9b80452a25423c2723f748413dba4d61adb2d 20180331 18:07:00-!- louis94 [~~louis94@149.36-245-81.adsl-dyn.isp.belgacom.be] has quit [Ping timeout: 256 seconds] 20180331 18:11:45< irker752> wesnoth: gfgtdf wesnoth:1.14 c61873da76e3 / data/multiplayer/scenarios/2p_Dark_Forecast.lua: fix lua error in 2p_Dark_Forecast https://github.com/wesnoth/wesnoth/commit/c61873da76e30222c7dcb6faf91349143c8fa912 20180331 18:12:31-!- gfgtdf [~chatzilla@x4e32b735.dyn.telefonica.de] has joined #wesnoth-dev 20180331 18:13:10< gfgtdf> well you can probably set a starting locations with [terrain_mask] or [replace_map], but i don't rmember implementing it in wesnoth.special_locations.bahl = {} 20180331 18:14:51< gfgtdf> and replace_map can also change the map size. 20180331 18:16:03< celticminstrel> mattsc: What would be your recommended method of ensuring certain units make it their goal to kill a certain other unit? 20180331 18:16:25< celticminstrel> I think I set an attacks aspect for it at one point, but IIUC that also means the AI won't make any other attacks, either. 20180331 18:19:32< vn971> I'm quite tempted to write one just for fun. Like "VasyaNeverLoses", which would alter CTK if player has a hard-coded name. 20180331 18:19:44< celticminstrel> ??? 20180331 18:19:57< celticminstrel> ...why does my log say "failed to auto-store $second_unit at 3,25"? 20180331 18:19:58< vn971> hm, wrong order 20180331 18:20:10< celticminstrel> This is seemingly in a capture event which shouldn't even have a $second_unit. 20180331 18:20:14< celticminstrel> Also it's on 1.14 FTR. 20180331 18:20:27< vn971> this was meant to be sent first: > I wonder, has anyone created deliberately and explicitly cheating add-ons for fun? 20180331 18:20:37< Ravana_> I have 20180331 18:20:46< Ravana_> you are not allowed to upload them though 20180331 18:20:50< vn971> Ravana_: what's the name?) 20180331 18:20:52< vn971> oh:( 20180331 18:21:12< vn971> well I still can if I find a replay with it, but OK) 20180331 18:21:20< Ravana_> for example I made one that spawns units if my nick is in observers list 20180331 18:21:29< vn971> lol 20180331 18:21:32< Ravana_> you know enough Lua to do that all alone just as well 20180331 18:21:40< vn971> yes true. 20180331 18:22:05< vn971> I was worried to attract real cheaters a bit though.) 20180331 18:22:47< vn971> checking observers is a bit OOS by the way. Hm, and I didn't know I can check if somebody is observing.. Not that easy. 20180331 18:22:59< Ravana_> theme_items has that 20180331 18:23:46< vn971> heh, indeed. 20180331 18:23:59< celticminstrel> <3 dominates special 20180331 18:24:12< celticminstrel> Sorry, it's an ability not a special. Duh. 20180331 18:24:44< celticminstrel> ...on a random note I wonder if anyone took my campaign's special elf units and put them in their addon... >_> 20180331 18:26:36-!- Oebele [~quassel@143.177.58.202] has joined #wesnoth-dev 20180331 18:35:39< celticminstrel> It's weird, sometimes when I return to the titlescreen (or press F5 while already there), the music goes back to main title music, but sometimes it doesn't. 20180331 18:39:45-!- travis-ci [~travis-ci@ec2-54-91-20-190.compute-1.amazonaws.com] has joined #wesnoth-dev 20180331 18:39:46< travis-ci> gfgtdf/wesnoth#1068 (fwesnothd - 8b13de4 : gfgtdf): The build passed. 20180331 18:39:46< travis-ci> Build details : https://travis-ci.org/gfgtdf/wesnoth/builds/360669134 20180331 18:39:46-!- travis-ci [~travis-ci@ec2-54-91-20-190.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180331 18:40:20-!- travis-ci [~travis-ci@ec2-23-20-176-38.compute-1.amazonaws.com] has joined #wesnoth-dev 20180331 18:40:21< travis-ci> wesnoth/wesnoth#17366 (master - 62febff : Sofartin): The build passed. 20180331 18:40:21< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/360675608 20180331 18:40:21-!- travis-ci [~travis-ci@ec2-23-20-176-38.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180331 18:41:57< mattsc> celticminstrel: You want a subset of the AI units to target one specific enemy unit? 20180331 18:42:10< celticminstrel> Correct. 20180331 18:42:32< mattsc> And does that mean only the attacks, or moving toward that unit while itā€™s out of range also? 20180331 18:42:41< celticminstrel> Both in the second case. 20180331 18:42:53< celticminstrel> The first case might be easier if it's only the attacks. 20180331 18:43:05< celticminstrel> Though I can just tighten the filter instead. 20180331 18:43:43< mattsc> Thereā€™s no good way of doing this with the Default AI. 20180331 18:43:56< mattsc> As you say the attacks aspect excludes all other attacks, 20180331 18:44:11< celticminstrel> Yeah, thought so; what I did before is just make it apply for one or two turns. 20180331 18:44:13< mattsc> You could use goto_x/y to force them to move to a sepcific location 20180331 18:44:20< celticminstrel> So it basically worked. 20180331 18:44:30< mattsc> There are several Micro AIs that might get close 20180331 18:44:36< celticminstrel> The problem with goto_x|y is that I don't think it'll update once the target unit moves? 20180331 18:44:50< celticminstrel> I guess I could update it every side turn or something. 20180331 18:45:01< mattsc> Thatā€™s correct. 20180331 18:45:07< mattsc> Right, thatā€™s what youā€™d have to do,. 20180331 18:45:24< mattsc> The Goto MAI will do this for you though, thatā€™s much more versatile. 20180331 18:45:38< mattsc> The Assassin Squad MAI might or might not do what you want, depends on the setup. 20180331 18:46:11< celticminstrel> Okay, so what about the case where the attackers are already in place and I just want them to focus on killing the unit? Would Goto/Asassin MAI make sense even there? 20180331 18:46:35< mattsc> A combination of Goto and Simple Attack might do it. 20180331 18:46:59< mattsc> In that case, goto will not do it, Assassin will. 20180331 18:47:08< celticminstrel> Hm? 20180331 18:47:09< mattsc> And as I said, Simple Attack should be usable for that. 20180331 18:47:24< celticminstrel> Are you suggesting Goto+Simple for the case where the units are already in place, or... 20180331 18:47:36< mattsc> ā€œin that caseā€ is referring to the last question you asked before that. 20180331 18:47:57< celticminstrel> So that's for the case where the units are not yet in place, while Assassin is suggested for the case where they are already in place. 20180331 18:48:04< mattsc> No, the Goto + Simple comment was written before I saw that question 20180331 18:48:06< celticminstrel> Okay, I'll look at the MicroAIs in question. 20180331 18:48:21< mattsc> Okay, let me take a step back ... 20180331 18:48:29< mattsc> We had two questions in parallel here 20180331 18:48:55< mattsc> Goto will get the units to where you want them to be (and update automatically even if the target moves), but will not take care of attacks 20180331 18:49:39< mattsc> Simple Attack can be used to force attacks by certain units against certain enemies, but will not move the units there when they are out of range. 20180331 18:49:51< mattsc> Assassin Squad does both, but maybe not in the way you want it. 20180331 18:51:43< mattsc> I also wrote a ā€œpriority targetā€ engine that still exists (and is used in the protect unit test scenario) that does the targeted attacks part in a more hacky way, by dynamically updating the attacks aspect. 20180331 18:52:25< mattsc> I hope that was cleaerer? 20180331 18:52:35< celticminstrel> Yeah, thanks. 20180331 18:52:56< celticminstrel> So SimpleAttack in both cases, Goto in the one case. 20180331 18:53:41< mattsc> PRobably yes. 20180331 18:58:25<+discordbot> How can I force wesnoth to run under certain resolution programatically? 20180331 18:58:34-!- gfgtdf [~chatzilla@x4e32b735.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.93 [Firefox 52.7.3/20180322140748]] 20180331 18:58:58< celticminstrel> ...wait, what happens if the Goto MAI's filter_location matches no units? 20180331 18:59:04< celticminstrel> I mean no locations, duh. 20180331 18:59:25<+discordbot> Testing wesnoth on iPhone. my iPhone is 1136x640 but wesnoth starts with 1280x800 20180331 18:59:57< celticminstrel> Specifically if it used to match locations but then it no longer does. 20180331 19:00:09< celticminstrel> Like, the filter is [filter[id= but that unit was killed. 20180331 19:02:31-!- travis-ci [~travis-ci@ec2-54-221-128-240.compute-1.amazonaws.com] has joined #wesnoth-dev 20180331 19:02:32< travis-ci> wesnoth/wesnoth#17368 (1.14 - c61873d : gfgtdf): The build passed. 20180331 19:02:32< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/360677954 20180331 19:02:32-!- travis-ci [~travis-ci@ec2-54-221-128-240.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180331 19:12:11< celticminstrel> Heh. I was wondering why the MicroAI wasn't working? I forgot side=2. >_> 20180331 19:16:03< irker752> wesnoth/wesnoth:1.14 Nils Kneuper b8300d8e20 updated French translation AppVeyor: All builds passed 20180331 19:20:48< celticminstrel> mattsc: ca_id is accepted by all the MicroAIs, right? 20180331 19:20:53< mattsc> celticminstrel: I forgot what happens in that case. I think it does not take effect. 20180331 19:21:00< mattsc> Yes, it is. 20180331 19:23:11< mattsc> celticminstrel: https://github.com/wesnoth/wesnoth/blob/master/data/ai/micro_ais/cas/ca_goto.lua#L61 20180331 19:23:31< mattsc> So yes, if no locations match, then the CA score is 0, and others CAs take over. 20180331 19:24:04-!- commavir [vir@2604:180::502b:135a] has quit [Ping timeout: 256 seconds] 20180331 19:24:16< celticminstrel> So the release at goal or whatever wasn't actually necessary, then. 20180331 19:24:18< celticminstrel> Ah well. 20180331 19:26:55< mattsc> Btw, I would probably set the simple attack MAI score to higher than the goto MAI score, rather than using the defaults (which is the opposite). 20180331 19:27:09< mattsc> But again, it depends on exactly what you want. 20180331 19:28:03< celticminstrel> It seems to work with the defaults, but... 20180331 19:28:43< celticminstrel> The only possible complaint is that they didn't seem to make any attempt to surround the target unit. 20180331 19:28:56< mattsc> Well, yes, it does, but I think the behavior would likely be better the other way around. But again, depends on the exact situation, which I donā€™t know. 20180331 19:29:09< mattsc> Well, the simple attack MAI does not do that either. 20180331 19:29:17< mattsc> Thatā€™s in part why it is called simple. 20180331 19:29:36< mattsc> But neither does the default AI combat CA. 20180331 19:29:39< celticminstrel> One also attacked from the water. :P 20180331 19:29:47< celticminstrel> Instead of forest where I presume it had more defense. 20180331 19:31:00< mattsc> This is with the Goto MAI having the higher score? 20180331 19:31:02-!- commavir [vir@2604:180::502b:135a] has joined #wesnoth-dev 20180331 19:31:09< celticminstrel> Yeah, with the defaults. 20180331 19:31:17< mattsc> And I presume youā€™re having hexes adjacent to the enemy set us goto goals? 20180331 19:31:30< celticminstrel> I set the enemy's hex as the goto goal. 20180331 19:31:44< celticminstrel> And used ignore_enemy_at_goal=yes or something. 20180331 19:31:59< mattsc> okay 20180331 19:32:26< mattsc> so that means that the goto AI moves as close to the enemy as it can, and then the attack CA has to attack from that hex 20180331 19:32:56< mattsc> If you change the order of the scores, then the attack CA will choose where to attack from, which includes a score for good terrain 20180331 19:33:34< celticminstrel> So the attack CA does include moving to the target if they are within range? 20180331 19:33:37-!- atarocch [~atarocch@109.112.94.208] has quit [Ping timeout: 260 seconds] 20180331 19:33:43< mattsc> yes 20180331 19:33:52< mattsc> as does the default combat CA 20180331 19:36:05< mattsc> All attack CAs that I am aware of do this, so that movement CAs do not need to do attack evaluations. 20180331 19:36:20-!- commavir [vir@2604:180::502b:135a] has quit [Ping timeout: 276 seconds] 20180331 19:37:10-!- commavir [vir@2604:180::502b:135a] has joined #wesnoth-dev 20180331 19:41:52< mattsc> @hrubymar10 Sorry, missed your pointer to the directory change PR earlier. Thanks! 20180331 19:42:11-!- commavir [vir@2604:180::502b:135a] has quit [Ping timeout: 276 seconds] 20180331 19:43:15<+discordbot> np šŸ˜ƒ 20180331 19:59:01-!- commavir [vir@2604:180::502b:135a] has joined #wesnoth-dev 20180331 20:07:28-!- louis94 [~~louis94@149.36-245-81.adsl-dyn.isp.belgacom.be] has joined #wesnoth-dev 20180331 20:11:03< irker752> wesnoth: Nils Kneuper wesnoth:master 742c378361f4 / / (31 files in 30 dirs): updated Czech translation https://github.com/wesnoth/wesnoth/commit/742c378361f43a49f20b3d7f11061da6ea575166 20180331 20:11:10< irker752> wesnoth: Nils Kneuper wesnoth:1.14 3a6c300b352e / / (31 files in 30 dirs): updated Czech translation https://github.com/wesnoth/wesnoth/commit/3a6c300b352e66fd2f5a33040444423bae36cb2e 20180331 20:13:38<+discordbot> Marked #2782 as blocker. 20180331 20:14:26< celticminstrel> Still need opinions on 2791 BTW 20180331 20:17:51< celticminstrel> I just discovered something interesting. Apparently __metatable is also used instead of the string "userdata" when printing the object. 20180331 20:18:23< celticminstrel> Only for userdata though, not for tables. 20180331 20:19:34< celticminstrel> Using an invalid terrain string in the Lua console boots you to the titlescreen. o.O 20180331 20:26:23-!- louis94 [~~louis94@149.36-245-81.adsl-dyn.isp.belgacom.be] has quit [Ping timeout: 268 seconds] 20180331 20:47:27< celticminstrel> gfgtdf: IMO wesnoth.package does not belong on the "do not use" list. It's almost certainly not ever going to be removed, and while it's not intended for user access, it doesn't really hurt for users to access it (though the only use I can imagine for that is to check if a package is loaded before loading it). 20180331 21:04:18-!- atarocch [~atarocch@93.56.164.28] has joined #wesnoth-dev 20180331 21:09:33-!- gfgtdf [~chatzilla@x4e32b735.dyn.telefonica.de] has joined #wesnoth-dev 20180331 21:09:39< gfgtdf> are we going to tag 1.13.13 in an hour ? 20180331 21:10:01< celticminstrel> ...wait seriously? 20180331 21:11:52< gfgtdf> yesterday soemoen said tha was the plan 20180331 21:12:17< gfgtdf> or do you want to merge your pr first ? 20180331 21:12:35< celticminstrel> The schema fixes one? It's not really ready IMO. 20180331 21:12:57< celticminstrel> It just covers MP stuff and most of one campaign. Need to cover all campaigns. 20180331 21:13:12< celticminstrel> Oh, it does cover tutorial too, technically, but there were no actual problems there. 20180331 21:13:29< gfgtdf> does it contain 'real fixes' or just removeal of nonworking/nothgindoing code? 20180331 21:13:53< celticminstrel> Probably a mixture? Which is also why it needs review. 20180331 21:16:15< gfgtdf> what is the differnt between "dialogs/attack_predictions.cpp" and "dialogs/unit_attack.cpp" ? 20180331 21:16:48< celticminstrel> The latter is where you choose your attack, the former gives you the graph and breakdown. 20180331 21:17:22< gfgtdf> ok 20180331 21:18:08< mattsc> @hrubymar10 Another question ā€¦ 20180331 21:18:39< mattsc> My self-compiled 1.13.12+dev has the thin and almost invisible font problem, while the 1.13.12 package does not. 20180331 21:19:03< mattsc> Do you know what I need to change so that my own builds become usable again? 20180331 21:19:26< gfgtdf> celticminstrel: maybe you could do #2801 ? 20180331 21:19:50< celticminstrel> Maybe? I dunno. 20180331 21:19:55< celticminstrel> I think I do have an idea, at least. 20180331 21:21:39<+discordbot> mattsc : It is problem with newest pango-cairo. I haven't have time to DEBUG it more šŸ˜¦ 1.13.12 is package version and using MacCompileStuff packages, which are outdated 20180331 21:21:54< gfgtdf> replacing it with "attacker.disable" _coudl_ but that makes me wonder why it didn't dothat in the first place so maybe there is a reason why it didn't do that before? 20180331 21:22:48< mattsc> @hrubymar10 Oh, right (I think you had said that before, but Iā€™d forgotten). So in principle downgrading pango-cairo should work. Not sure if I want to do that, but itā€™s good to know. 20180331 21:23:32<+discordbot> You can download latest MacCompileStuff, apply it and then replace it with my new MacCompileStuff on which I am working now. It is not done yet, but it is enought when you combine it with old one 20180331 21:23:37< gfgtdf> hmm attacks seem to have max/min _range fields, didn't know that 20180331 21:23:58<+discordbot> Yes, downgrading pango-cairo will help. 20180331 21:24:06< celticminstrel> Pretty sure that does absolutely nothing and was removed at some point. 20180331 21:24:40< gfgtdf> celticminstrel: well it's used to when calculating battle_context_unit_stats::disable 20180331 21:24:48< mattsc> Right. Thanks. 20180331 21:25:19< zookeeper> gfgtdf, i presume by "release" he meant the announcement. 20180331 21:25:38< gfgtdf> zookeeper: ? 20180331 21:26:02< zookeeper> oh wait nevermind. 20180331 21:26:08<+discordbot> mattsc : if you want to try it, here is link to my new MacCompileStuff https://github.com/hrubymar10/MacCompileStuff 20180331 21:26:44< zookeeper> i looked at the news forum yesterday and didn't see the 1.13.12 thread so i figured it just still hadn't been announced for some reason. 20180331 21:26:52< gfgtdf> 20180331 20:19:34< celticminstrel> Using an invalid terrain string in the Lua console boots you to the titlescreen. o.O 20180331 21:27:03< gfgtdf> celticminstrel: you like for exampel in wesnoth.set_terrain() ? 20180331 21:27:31< mattsc> hrubymar10: Thanks. I bookmarked it and might have a look at it later. For now I am good (and out of time right this moment). 20180331 21:27:44< irker752> wesnoth/wesnoth:master Nils Kneuper a32d689c46 updated French translation AppVeyor: All builds passed 20180331 21:27:52< celticminstrel> gfgtdf: I got it with wesnoth.unit_defense. 20180331 21:27:58< celticminstrel> But maybe also set_terrain, I dunno. 20180331 21:29:20< zookeeper> @Vultraz, so what was that "Release in 25 hours" stuff about? that was the first i recall hearing about the next release, not to mention the topic etc etc. 20180331 21:29:41<+discordbot> "1.13.13 (1.14 RC2) scheduled for Sunday, April 1st 00:01 UTC" 20180331 21:30:26<+discordbot> Looks like somebody forgot to update the IRC topic. 20180331 21:30:27< zookeeper> uh, what? "1.13.12 (1.14 RC1) tagged, announcing soon" 20180331 21:30:53-!- shadowm changed the topic of #wesnoth-dev to: 1.13.13 (1.14 RC 2) scheduled for April 1st 00:01 UTC | Wesnoth Developers Channel | >>> Want to help? Go here: https://r.wesnoth.org/t42911 (and thanks!) <<< | Discord Server: https://discord.gg/battleforwesnoth | Logs: http://irclogs.wesnoth.org | Bug tracker: https://bugs.wesnoth.org 20180331 21:31:11< zookeeper> ohhh, right, discord has topics too. i hadn't even noticed. 20180331 21:31:14< shadowm> It's not like any of you need to be concerned about the exact timing at this stage unless you're doing something wrong. 20180331 21:31:24< shadowm> Right? 20180331 21:31:53< celticminstrel> BTW, could someone mute irker for a minute? I want to force-push my schema branch without spamming everyone. 20180331 21:31:59-!- mode/#wesnoth-dev [+q *!*@uruz.ai0867.net] by ChanServ 20180331 21:31:59< shadowm> DOne 20180331 21:32:10< shadowm> To clarify, if the 1.14 branch is not in releasable shape 24/7 at this point, there's something seriously wrong with the project. 20180331 21:32:13< zookeeper> that was fast 20180331 21:32:30< zookeeper> it's sad that saying that no longer elicits the classic response. 20180331 21:32:43< shadowm> (Excluding the pot-update step from that for obvious reasons.) 20180331 21:32:51-!- mode/#wesnoth-dev [+o shadowm] by ChanServ 20180331 21:32:52-!- mode/#wesnoth-dev [+mz] by shadowm 20180331 21:32:56-!- mode/#wesnoth-dev [-m] by shadowm 20180331 21:33:21< gfgtdf> celticminstrel: cannot preorudce that crash, tried 'wesnoth.get_unit(32,20):defense("asdf")' 20180331 21:34:08<@shadowm> How many commits is this? 20180331 21:34:22< celticminstrel> 60+ 20180331 21:34:29<@shadowm> Oh dear. 20180331 21:34:30< celticminstrel> I think it's probably done now? 20180331 21:34:34< celticminstrel> Not quite sure though. 20180331 21:34:35<@shadowm> No it isn't. 20180331 21:34:38<@shadowm> I'm watching it. 20180331 21:34:41< celticminstrel> Ah, okay. 20180331 21:34:59< celticminstrel> gfgtdf: I wouldn't call "boot to titlescreen" a crash, but I guess you mean you don't even get booted. 20180331 21:35:03<@shadowm> Finally done. 20180331 21:35:05< celticminstrel> It's on 1.13.12 if that's relevant. 20180331 21:35:16-!- mode/#wesnoth-dev [-qzo *!*@uruz.ai0867.net shadowm] by shadowm 20180331 21:36:01< gfgtdf> i get just the default resistence of 100 returned, tried on 1.14 latest (well on my branch tha fixed the chat during delay) 20180331 21:36:45< gfgtdf> but yes we did fixes to that, since 1.13.12 (that randomly annoying cannot enter some terrains bug) 20180331 21:37:16< celticminstrel> gfgtdf: Oh right, try a longer string. The error message was about the length. 20180331 21:37:47< gfgtdf> oh right 20180331 21:37:50< gfgtdf> now i get it aswell. 20180331 21:39:46<+discordbot> Someone remind me to merge a Spanish translation update for Ivanovic if he hasn't done so by the time the pot-update for 1.13.13 is pushed. 20180331 21:41:41<+discordbot> Or rather, right before said pot-update. 20180331 21:41:44<+discordbot> @Vultraz 20180331 21:46:41< Ivanovic> shadowm: I got no further updates waiting in my inbox 20180331 21:46:42< Ivanovic> should be all online 20180331 21:47:30<+discordbot> Your inbox is wrong. 20180331 21:47:33< vn971> A couple of questions on 1.14 chat. First, where did the timestamps go? They're absolutely necessary! 20180331 21:47:46<+discordbot> About 9 minutes ago I got an email from the maintainer with a new batch of updates. 20180331 21:48:09< zookeeper> vn971, ...1.14 lobby chat doesn't have timestamps? 20180331 21:48:31< vn971> zookeeper: that's right! As far as my client is concerned anyway 20180331 21:48:43< Ivanovic> shadowm: that is I just received it a minute ago... 20180331 21:49:02< zookeeper> vn971, oh dear. surely there must be an option for it then? 20180331 21:49:06<+discordbot> https://cdn.discordapp.com/attachments/259976436490829825/429759065393201162/unknown.png 20180331 21:49:13<+discordbot> Preferences ā†’ Multiplayer ā†’ Timestamps 20180331 21:49:14< vn971> Secondly, it seems rather disappointing that private chat tabs are lost when you enter a game or leave it. What makes it especially important is that their contents get lost, too. You permanently erase your history if you join a game or leave it. 20180331 21:49:53< vn971> shadowm: indeed, thanks. Is it disabled by default?.. Why? 20180331 21:51:02< celticminstrel> Hmm. What's the best way to do something to units created by plague? 20180331 21:51:36< vn971> shadowm, by the way, do you get "mention" notification if I type your (or any Discord) name without the "@" sign? 20180331 21:51:38< celticminstrel> I know there's a unit create event now, but is it possible to distinguish recruited WCs from plague-created WCs there? 20180331 21:52:48< zookeeper> from there only? probably not. 20180331 21:52:58< gfgtdf> celticminstrel: you probably can use a (pre) recruit event? not sure? 20180331 21:53:30< gfgtdf> ut i assume even that fires before the placed event? you probably have to use attack events 20180331 21:53:51< celticminstrel> Oh well, I hoped there might be a nicer way now. 20180331 21:53:59< gfgtdf> and then use a "if is_in_attack then ... else ..." check in your unit placed event. 20180331 21:54:11< celticminstrel> Hmmmmm... 20180331 21:54:25< celticminstrel> So you mean set a variable in attack begin, clear it in attack end, and check it in unit placed? 20180331 21:54:37< celticminstrel> That... might actually work really well? 20180331 21:57:16< vn971> the second issue of private chat erasure: https://github.com/wesnoth/wesnoth/issues/2802 20180331 21:59:56< celticminstrel> Does [set_variable]to_variable work if it's a container variable? 20180331 22:01:13< irker752> wesnoth: Nils Kneuper wesnoth:master 7f35558799f5 / po/ (12 files in 12 dirs): updated Spanish translation https://github.com/wesnoth/wesnoth/commit/7f35558799f55cd36bc738ceb8ce34a9e1ba143c 20180331 22:01:18< irker752> wesnoth: Nils Kneuper wesnoth:1.14 10bab07ada9b / po/ (12 files in 12 dirs): updated Spanish translation https://github.com/wesnoth/wesnoth/commit/10bab07ada9b2870c9048577e6f979b057523dfa 20180331 22:01:29-!- travis-ci [~travis-ci@ec2-54-167-51-167.compute-1.amazonaws.com] has joined #wesnoth-dev 20180331 22:01:30< travis-ci> wesnoth/wesnoth#17371 (schema - 34b3780 : Celtic Minstrel): The build is still failing. 20180331 22:01:30< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/360721894 20180331 22:01:30-!- travis-ci [~travis-ci@ec2-54-167-51-167.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180331 22:06:30< Ivanovic> shadowm: now my inbox appears to really be empty... 20180331 22:06:32< Ivanovic> ;) 20180331 22:09:12-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection] 20180331 22:09:36<+discordbot> So 1.13.13 release today? no april fool? šŸ˜„ @shadowm ? 20180331 22:14:33<+discordbot> In all seriousness? No, we don't joke around with things like that, so it is going to be after midnight UTC assuming Vultraz doesn't get hit by a bus before then. 20180331 22:17:21< zookeeper> remind me: if you rename a (binary) file in git, is it really just a rename or is it equivalent to deleting and re-adding the file (so, double the filesize in history, etc)? 20180331 22:17:37< celticminstrel> The latter. 20180331 22:17:48< celticminstrel> For some bizarre reason git doesn't see the worth in tracking renames. 20180331 22:18:05<+discordbot> šŸ˜ƒ ok then. I am +3:00 so we already had midnight. Iā€™ll create macOS package ASAP, but I am on vacation now, so I expect it around 19:00 UTC 20180331 22:18:39<+discordbot> (Today ofc and only if 1.13.13 will be tagged) 20180331 22:19:21-!- Oebele [~quassel@143.177.58.202] has quit [Remote host closed the connection] 20180331 22:19:30< zookeeper> celticminstrel, urgh, okay. i guess i won't just dump these TRoW story images in with my meager half an hour of sorting them out... next release, then. 20180331 22:23:16<+discordbot> vn971: No, you need to use the @ sign to tag me on Discord and I look at IRC very infrequently these days. 20180331 22:24:18< vn971> zookeeper: celticminstrel: no, the file doesn't take double size IIRC, because SHA is taken from it. 20180331 22:24:29-!- grzywacz [~karol@89-70-226-147.dynamic.chello.pl] has joined #wesnoth-dev 20180331 22:24:54< vn971> but from the view of git history, this is file deletion and file addition. It is understood to be a renaming only by clients that analyse the diff. 20180331 22:24:55< celticminstrel> vn971: Maybe if it's a straight rename, but I find those tend to be rare unless you go out of your way to do so. 20180331 22:25:12< celticminstrel> Typically you rename the file and also make a few changes at the same time. 20180331 22:25:53< vn971> celticminstrel: if you change at least one bit then it's addition and deletion, agree. 20180331 22:26:13< gfgtdf> does wesnoth skip addons director y that begin with dot? in particular: can i disable addons by prefixing their directory them with a dot ? 20180331 22:26:59< vn971> celticminstrel: actually, git is pretty smart about renames. You can set various "similarity index" levels by your git client and see what's considered a rename on a particular similarity level. 20180331 22:27:17< celticminstrel> That's not smart IMO. 20180331 22:27:30< vn971> gfgtdf: just try out and see?.. 20180331 22:27:46< celticminstrel> Smart is tracking renames as a different type of change. 20180331 22:28:10< celticminstrel> So the fact that it's a rename is actually recorded in the history, rather than inferred from the diff. 20180331 22:28:11< gfgtdf> hmm i porbably, will. 20180331 22:28:13< vn971> well OK, "smart" is subjective, so let's leave it as is. 20180331 22:29:48< celticminstrel> (Another good thing would be the ability to track copies / forks as a different type of change.) 20180331 22:30:16< celticminstrel> (By "fork" I mean for example when you decide to split a file in two, you might copy it and remove different parts from each version.) 20180331 22:38:17< celticminstrel> I figured out my problem. Apparently a unit placed event for a plague unit is fired after the attack end event. 20180331 22:38:30< celticminstrel> So I guess what I can do is just clear the variable in unit placed instead of in attack end. 20180331 22:39:33< celticminstrel> This looks a lot more concise now. \o/ 20180331 22:39:54 * celticminstrel simplified the dominates definition by writing a WML tag pair that does most of the grunt work. 20180331 22:40:44< gfgtdf> hmm sounds unexpewcted to me, i think the attack_end even shodul always fire last 20180331 22:40:46< gfgtdf> zookeeper: ^ 20180331 22:41:06< celticminstrel> Yeah, it was indeed unexpected, but not difficult to work around at least. 20180331 22:42:00< zookeeper> doesn't sound expected nor unexpected to me in case of plague. 20180331 22:42:22< celticminstrel> ...true, I could see an argument either way. 20180331 22:47:49< celticminstrel> You know what would be cool? Having several emotion-variants of all of the standard unit portraits. 20180331 22:48:06< grzywacz> ... 20180331 22:48:14< celticminstrel> I doubt it'll ever happen. 20180331 22:48:28< grzywacz> Morhped automatically with deep style transfer. 20180331 22:48:40< celticminstrel> That's a lot of work, plus some of the original artists aren't really around anymore. 20180331 22:49:02< grzywacz> If you can make Mona Lisa smile.. 20180331 22:50:25< gfgtdf> hmm it seems liek it has been liek since quite some time (attack_end event beeing fired before last_breath) 20180331 22:59:57-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180331 23:00:04-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180331 23:00:06< zookeeper> ... 20180331 23:00:57< zookeeper> you know what would also be cool? _animated_ portraits 20180331 23:01:08< celticminstrel> ...indeed! 20180331 23:03:57< zookeeper> also you might want to understate your doubts a bit less 20180331 23:08:51< loonycyborg> how will they be animated? palette rotation? :P 20180331 23:09:30< zookeeper> a few hundred hand-drawn frames each, naturally 20180331 23:10:16< loonycyborg> sounds like lot of work 20180331 23:10:31< zookeeper> not at all 20180331 23:22:16<+discordbot> šŸ˜› 20180331 23:23:07<+discordbot> Does anyone have anything else to add before release? 20180331 23:23:51< zookeeper> i'm doing changelogging right now 20180331 23:25:32<+discordbot> @loonycyborg pot update need do we 1.14 for? 20180331 23:26:45<+discordbot> @shadowm told me to make one recently 20180331 23:26:57<+discordbot> I'm not sure if there were any string changes since then 20180331 23:27:59<+discordbot> Two strings were marked translatable, but they had translated strings in other domains, and two were changed from N_() to _() 20180331 23:28:05<+discordbot> I'm not sure if that counts? 20180331 23:28:13< celticminstrel> The latter doesn't count, the former does. 20180331 23:28:16< celticminstrel> I think. 20180331 23:29:33<+discordbot> even when using dsgettext? 20180331 23:30:01<+discordbot> Oh my god. 20180331 23:30:08<+discordbot> How many times do I have to repeat myself AND the wiki page? 20180331 23:30:12<+discordbot> @zookeeper can you mention gfgtdf's fix for GUI2 dialogs disappearing and the lua error in dark forecast 20180331 23:30:33<+discordbot> @Vultraz @loonycyborg https://wiki.wesnoth.org/ReleasingWesnoth#General_maintenance 20180331 23:30:37< zookeeper> if you tell me exactly what to write, sure 20180331 23:30:39<+discordbot> Read what it says about pot-updates. 20180331 23:30:49<+discordbot> We had a "new" string freeze this Monday. 20180331 23:31:00<+discordbot> The next pot-update is supposed to take place right before the release. 20180331 23:31:01<+discordbot> Come on. 20180331 23:31:22<+discordbot> I'm busy right now so hopefully I don't need to spell it out again. 20180331 23:31:59<+discordbot> when is the release exactly? 20180331 23:32:14<+discordbot> in 30 minutes 20180331 23:33:28-!- grzywacz [~karol@89-70-226-147.dynamic.chello.pl] has quit [Ping timeout: 260 seconds] 20180331 23:33:56<+discordbot> @zookeeper hmmm... 20180331 23:35:38< zookeeper> i presume you must be aware of what the HI anim looks like in N/S dir, right..? 20180331 23:35:52<+discordbot> nothing one can do 20180331 23:36:19<+discordbot> unless you know of something one can do 20180331 23:36:40< zookeeper> i dunno, mostly the idea of having it look less dumb sprang to mind 20180331 23:37:33-!- octalot [~steve@178.165.128.114.wireless.dyn.drei.com] has quit [Ping timeout: 268 seconds] 20180331 23:37:55<+discordbot> raises eyebrow 20180331 23:41:10< irker752> wesnoth: ln-zookeeper wesnoth:1.14 1179593a4f5e / changelog.md: Updated changelog https://github.com/wesnoth/wesnoth/commit/1179593a4f5ea1d6a8d5c5d95cf69b0bd34e5cb2 20180331 23:41:54<+discordbot> should forward port that too 20180331 23:41:59< irker752> wesnoth: loonycyborg wesnoth:1.14 409f1a163b54 / / (309 files in 9 dirs): pot-update and regenerate doc files https://github.com/wesnoth/wesnoth/commit/409f1a163b541ca81ed625803b69184d1b2d4206 20180331 23:42:07< zookeeper> yes 20180331 23:44:26< mattsc> zookeeper: if you swing the maze all across your body in the front and half way around you in the back, you can develop more momentum for th hit! 20180331 23:45:11< mattsc> *mace 20180331 23:46:01 * zookeeper tries to figure out the joke, fails 20180331 23:46:15< irker752> wesnoth: Charles Dang wesnoth:1.14 7e279748ccd0 / changelog.md: Mentioned Dark Forecast fix https://github.com/wesnoth/wesnoth/commit/7e279748ccd0c896f4e3c6b9c97d6f896b2a87d7 20180331 23:46:22< mattsc> Talking about the HI attack animation. 20180331 23:46:34< zookeeper> well obviously 20180331 23:47:21< mattsc> With a ā€œlittle bit of imaginationā€ you can think of the one in the south hitting the one in the north behind the back. 20180331 23:48:04< zookeeper> uh, okay, if you say so :P 20180331 23:48:12< mattsc> I do :P 20180331 23:48:16<+discordbot> 360 noscope 20180331 23:48:32-!- octalot [~steve@178.165.128.114.wireless.dyn.drei.com] has joined #wesnoth-dev 20180331 23:55:32< celticminstrel> Soooo, $other_unit from Lua seems to not be working in 1.13.12, unless I'm doing something wrong... 20180331 23:56:37< celticminstrel> But other in formula= does seem to work, so I might well be doing something wrong... 20180331 23:57:30< gfgtdf> vultraz: the gui2 dialogs disappearing fix is mainly mainly fixes an issue intruduces by another commit of me that was made after 1.13.12 that's why i ddn't put it into the changelog 20180331 23:58:53< celticminstrel> Passing the filter through wml.tovconfig should be the correct move, right? (When testing with a literal filter at least, when it's handled in a WML tag it should already be a vconfig.) --- Log closed Sun Apr 01 00:00:24 2018