--- Log opened Sun Apr 01 00:00:24 2018 20180401 00:00:41< gfgtdf> celticminstrel: iirc te filter c++ function takes a vconfig prameter, menaing it shodul matter whetehr you pass it to tovconfig or not, c++ woudl do that anyways. 20180401 00:00:59< celticminstrel> Ah. 20180401 00:01:15< gfgtdf> s/shodul/shouldn't 20180401 00:02:17<+discordbot> ok 20180401 00:04:54< celticminstrel> wesnoth.get_units{wml.tag.filter_adjacent{id=dominator.id}} works 20180401 00:05:18< celticminstrel> wesnoth.get_units({wml.tag.filter_adjacent{id="$other_unit.id"}}, dominator) does not work 20180401 00:05:40-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [] 20180401 00:05:45< celticminstrel> I'm not doing something wrong, am I? 20180401 00:06:40< gfgtdf> maybe that that $other_unit in a filter_adjacent is actuall the original unit? (that that adjacent unit is adjacent to) 20180401 00:06:57< gfgtdf> iirc you implemented this so you shodul know better. 20180401 00:07:03< gfgtdf> than me 20180401 00:07:06< celticminstrel> In this case $other_unit should be the unit you pass to get_units. 20180401 00:07:28< celticminstrel> ... 20180401 00:07:31< celticminstrel> Oh wait, 20180401 00:07:40< celticminstrel> No, I think you're actually right? 20180401 00:07:58< celticminstrel> What I just said is true of $other_unit in the parent filter, but not in [filter_adjacent], 20180401 00:08:09< celticminstrel> In [filter_adjacent], the parent filter's unit is now $other_unit. 20180401 00:08:49< celticminstrel> So the $other_unit that was passed in... is basically not accessible from [filter_adjacent]... 20180401 00:09:07< celticminstrel> So basically what I'd need to do is use formula to detect the adjacency, I guess? 20180401 00:10:41<+discordbot> eh, ya know what? 20180401 00:10:45<+discordbot> I'll do the tagging in a few hours 20180401 00:10:49<+discordbot> so time right now 20180401 00:11:18< gfgtdf> is anyone here planing to fix things in th next few hours ? 20180401 00:12:27< celticminstrel> ...where on the wiki are the formula gamestate functions documented... o.o 20180401 00:12:35< celticminstrel> I thought it was FormulaAI, but they're not there? 20180401 00:12:50< celticminstrel> Wesnoth Formula Language only has the core functions ATM. 20180401 00:13:06< celticminstrel> (Though IMO gamestate functions that are not AI-specific should be moved there too, under section 7.) 20180401 00:13:27< gfgtdf> i don't know, i always looksed up the formula functions up directly in the c++ source when i neeeded them. 20180401 00:13:45< celticminstrel> Oh, it's "FormulaAI Functions". Of course. >_> 20180401 00:25:28< celticminstrel> Yay, works now. 20180401 00:32:47< irker752> wesnoth/wesnoth:1.14 Celtic Minstrel b889cd4875 squash! LoW7: Fix invalid use of aspects AppVeyor: All builds passed 20180401 00:33:09< celticminstrel> !!! 20180401 00:33:32< celticminstrel> Why does that say 1.14 and not schema_fixes? 20180401 00:41:03< celticminstrel> :( 20180401 00:41:18< celticminstrel> ...wait, I did reload the config didn't I... 20180401 00:41:53< celticminstrel> (Changing a unit's side in pre advance apparently doesn't block the advancement choice dialog?) 20180401 00:42:30< celticminstrel> Yeah, I reloaded. 20180401 00:42:57< celticminstrel> If your own unit levels up, but a pre_advance event changes the side, you still get to choose the advancement option even though it's no longer your unit. 20180401 00:43:09< celticminstrel> I assume [cancel_action] will not do what I want here? 20180401 00:43:30< gfgtdf> i don't rmember implementing [cancel_action] in advancement related events 20180401 00:43:33< gfgtdf> maybe we should 20180401 00:43:57< celticminstrel> Well, IMO it should also check if it's still on your side after the pre_advance event. 20180401 00:44:33< gfgtdf> well it shoudl still advance, just not show the advancement dialog to you 20180401 00:44:38< celticminstrel> Right. 20180401 00:44:42< gfgtdf> seemslik quite a rare case 20180401 00:44:50< celticminstrel> I dunno. 20180401 00:45:01< celticminstrel> It's quite relevant to my dominates ability though. 20180401 00:45:12< celticminstrel> Because when the unit levels up, it is freed back to its original side. 20180401 00:45:26< gfgtdf> hmm 20180401 00:45:33< celticminstrel> Is there any way to prevent an advancement dialog? 20180401 00:45:55< celticminstrel> I guess maybe choosing it manually in pre_advance and setting advances_to to just that single option? 20180401 00:45:59< gfgtdf> maybe you can fire the advancemnt manually (wesnoth.advance_unit) during that preadvance event, after you changed the side 20180401 00:46:09< celticminstrel> Hmm. That sounds... dangerous. >_> 20180401 00:46:18< celticminstrel> BUT I WILL TRY IT 20180401 00:46:37< celticminstrel> That's [transform_unit] in WML, right? 20180401 00:46:46< octalot> the Pick Your Advancements mode prevents the advancement dialog 20180401 00:48:36< celticminstrel> [transform_unit] works, thanks! 20180401 00:49:41< gfgtdf> [transform_unit] might have no option to advance with advance animation though (unliek wesnoth.advance_unit) 20180401 00:55:08< celticminstrel> Turns out my test was wrong. :/ 20180401 00:55:15< celticminstrel> I used the debug advancement command. 20180401 00:55:31< celticminstrel> But apparently that always gives an advancement dialog even it it's not a unit on the current side. 20180401 00:55:49< celticminstrel> When I set the experience to 1 under the max and had it attack an L1 unit, it worked correctly with pre advance. 20180401 00:55:59< celticminstrel> So IOW I can just use pre_advance without any hack. 20180401 01:05:17 * octalot stares at https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=483893 The bug report is correct, the door should be on 55,33; but the fix put it on 53,33; and it's stayed wrong for 10 years since 1.4. 20180401 01:06:10< octalot> or maybe 55,34, but definitely not 53,33 20180401 01:08:49-!- gfgtdf_ [~chatzilla@x4e363bcb.dyn.telefonica.de] has joined #wesnoth-dev 20180401 01:11:05-!- gfgtdf [~chatzilla@x4e32b735.dyn.telefonica.de] has quit [Ping timeout: 276 seconds] 20180401 01:11:14-!- gfgtdf_ is now known as gfgtdf 20180401 01:24:43< octalot> should a bugfix for 1.14 be opened as a PR to 1.14, or a PR to master for later cherry-picking? 20180401 01:25:22< celticminstrel> IMO it's slightly better to open the PR on 1.14 and then cherry-pick to master, but either works. 20180401 01:31:13-!- Bonobo [~Bonobo@203.220.138.198] has joined #wesnoth-dev 20180401 01:34:53-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: So long and thanks for all the fish.] 20180401 01:43:03-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20180401 01:51:00-!- octalot [~steve@178.165.128.114.wireless.dyn.drei.com] has quit [] 20180401 02:07:07< irker752> wesnoth/wesnoth:opengl Jyrki Vesterinen 5c0e86d3f5 Add a texture class AppVeyor: All builds passed 20180401 02:36:19-!- gfgtdf [~chatzilla@x4e363bcb.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.93 [Firefox 52.7.3/20180322140748]] 20180401 02:52:02< irker752> wesnoth: Steve Cotton wesnoth:1.14 bcaac1efefe0 / data/campaigns/The_Hammer_of_Thursagan/scenarios/12_The_Underlevels.cfg: THoT S12 Put the sneak-passageway's door on the right hex https://github.com/wesnoth/wesnoth/commit/bcaac1efefe0f4cd9222e7811178cf458185d71f 20180401 03:25:03< celticminstrel> Don't forget to cherry-pick that to master, @Vultraz 20180401 03:25:24<+discordbot> Indeed 20180401 03:25:32<+discordbot> Already opened an issue reminder 20180401 03:36:20< celticminstrel> Gah, mouse, why do you keep double-clicking when I'm just holding the mouse button!? 20180401 04:23:33<+discordbot> the hell this.. 20180401 04:23:37<+discordbot> cpp // a #rrggbb color in pango format. if (*cmp_str.c_str() == '#' && cmp_str.size() == 7) { return color_t::from_argb_bytes(strtoul(cmp_str.c_str() + 1, nullptr, 16)); } 20180401 04:23:58<+discordbot> should be using from_hex_string.... 20180401 04:25:07< celticminstrel> Heh 20180401 04:27:12<+discordbot> blah! 20180401 04:27:15<+discordbot> having trouble with this... 20180401 04:27:23<+discordbot> I got rid of the topic_text class 20180401 04:27:32<+discordbot> merged it into topic... 20180401 04:27:40< celticminstrel> Okay? 20180401 04:27:44<+discordbot> but now I need a non-const ptr in order to call parsed_text... 20180401 04:27:56<+discordbot> guess I need to modify find_topic... 20180401 04:28:10< celticminstrel> parsed_text seems like something that could modify a mutable member variable. 20180401 04:29:02<+discordbot> oh yeah, it IS mutable... 20180401 04:29:05<+discordbot> so why is this a problem... 20180401 04:29:20< celticminstrel> Maybe parsed_text is not const? 20180401 04:29:31<+discordbot> that's it 20180401 04:30:17<+discordbot> ty 20180401 04:30:40< celticminstrel> :) 20180401 04:31:00 * celticminstrel wonders if Discord converts text emoticons like that to emoji. 20180401 04:31:54<+discordbot> nope 20180401 04:33:09<+discordbot> looks like I might get my first working build with my new help framework.. 20180401 04:35:46<+discordbot> but then there's still a lot of cleanup and polish 20180401 04:37:56<+discordbot> ah, nice. can't even open the browser 20180401 04:39:51<+discordbot> oh, I see 20180401 04:40:06<+discordbot> I let the exception propagate out to the manager,meaning the toplevel is nulllllllllllllllllllllll 20180401 04:40:17<+discordbot> I need to catch the exception beforehand 20180401 04:42:06<+discordbot> well now it just crashes earlier 20180401 04:43:38<+discordbot> oh well, time to debug 20180401 05:08:16< irker752> wesnoth/wesnoth:master Nils Kneuper 7f35558799 updated Spanish translation AppVeyor: All builds passed 20180401 05:17:57-!- atarocch [~atarocch@93.56.164.28] has quit [Ping timeout: 240 seconds] 20180401 05:28:51<+discordbot> ๐Ÿค” 20180401 05:29:10<+discordbot> odd 20180401 05:29:24<+discordbot> read access violation 20180401 05:31:10<+discordbot> oh 20180401 05:31:25<+discordbot> yeah, I'm not using a map here ๐Ÿ˜ 20180401 05:31:53<+discordbot> I keep forgetting vector::emplace_back does NOT have map's "return the existing element" functionality... 20180401 05:32:16< celticminstrel> I can't believe there's no way to shuffle a variable. >_> 20180401 05:32:24<+discordbot> er waitno 20180401 05:32:28<+discordbot> this is a vector. 20180401 05:32:31<+discordbot> why is it doing this. 20180401 05:32:38<+discordbot> it should ALWAYS insert... 20180401 05:33:26<+discordbot> this should not assert... 20180401 05:33:31<+discordbot> OH 20180401 05:33:34<+discordbot> yes 20180401 05:33:36<+discordbot> right 20180401 05:33:47< celticminstrel> What's the problem? 20180401 05:33:48<+discordbot> it returns null if there was a parsing errororororororor 20180401 05:33:54< celticminstrel> ??? 20180401 05:34:30<+discordbot> I forgot a function could return nullptr 20180401 05:34:50<+discordbot> if a exception was thrown during object construction 20180401 05:34:54< celticminstrel> ...? 20180401 05:36:24<+discordbot> what? 20180401 05:36:39< celticminstrel> But yeah, we need a way to shuffle an array variable. :( 20180401 05:37:17<+discordbot> we don't have such a thing? 20180401 05:37:37< celticminstrel> I know, hard to believe, right? 20180401 05:38:09< celticminstrel> Obviously it can be done in Lua, but you probably need to code the shuffle algorithm manually. 20180401 05:38:23<+discordbot> YAY help opens! 20180401 05:38:32< celticminstrel> \o/ 20180401 05:39:18<+discordbot> where t'f my text tho 20180401 05:39:29<+discordbot> literally no text 20180401 05:39:42<+discordbot> oh wait 20180401 05:40:15<+discordbot> wait, this should work? 20180401 05:40:34<+discordbot> blah 20180401 05:40:41<+discordbot> also, why can I still not expand tree nodes 20180401 05:40:52<+discordbot> did I break that at some point 20180401 05:41:20<+discordbot> no? 20180401 05:41:25<+discordbot> tree expansion is still there 20180401 05:41:31< celticminstrel> Does it affect other tree nodes or just help tree nodes 20180401 05:41:37<+discordbot> help tree nodes 20180401 05:43:12<+discordbot> ....huh 20180401 05:43:14<+discordbot> hang on.. 20180401 05:46:29<+discordbot> oh, nevermind 20180401 05:47:59< celticminstrel> ...isn't mode=merge supposed to, you know, merge the configs? 20180401 05:48:21< celticminstrel> Does it only merge subtags, and overwrite attributes? That doesn't make any sense. 20180401 05:48:33<+discordbot> who knows! 20180401 05:49:21< celticminstrel> A liberal reading of the documentation might support the view that the old attributes are altogether dropped, but a sane reading wouldnot. 20180401 05:50:03<+discordbot> ah, I see why no text 20180401 05:50:09<+discordbot> i was writing to the text= key 20180401 05:50:36<+discordbot> but the formatting thing you added uses all_children_range 20180401 05:52:03< celticminstrel> Formatting thing? 20180401 05:52:12<+discordbot> formatting parser 20180401 05:52:23<+discordbot> ok, what the HELL is dumping all the text to console! 20180401 05:52:25< celticminstrel> The variable array access is super-arcane and I have no idea how to interpret what it's doing, particularly at 2am. 20180401 05:52:55<+discordbot> oh, it's the formatting engine 20180401 05:53:09<+discordbot> celmin: don't, it will make your head hurt 20180401 05:53:20< celticminstrel> Especially at 2am. 20180401 05:53:49< celticminstrel> Okay, I give up. I'm gonna write a tag or something. 20180401 05:53:55<+discordbot> ok, looks like your pango thingy is verynecessary 20180401 05:54:09< celticminstrel> [scatter_units] is oh so close to what I need and yet not quite there. 20180401 05:54:35< celticminstrel> (Mind you I should go through eventually and replace the [scatter_units] with [random_placement] though.) 20180401 05:55:09<+discordbot> ahhh 20180401 05:55:13<+discordbot> i need the parse_text thing too... 20180401 05:55:24<+discordbot> damn that thing 20180401 05:56:50<+discordbot> as for the tree thing 20180401 05:57:01<+discordbot> it looks like somewhere along the way the code to adtully add the nodes was removed? 20180401 05:57:08<+discordbot> i wonder if the gui2_help branch is still around... 20180401 05:57:24< celticminstrel> It's still around on my computer if nothing else. 20180401 05:57:25<+discordbot> it is 20180401 05:59:04<+discordbot> hmmm 20180401 05:59:12<+discordbot> actually, the code's still here, but... 20180401 06:14:35<+discordbot> OH 20180401 06:14:48<+discordbot> aaaahhhgotitgotit 20180401 06:14:53<+discordbot> I changed the toggle id at some point 20180401 06:55:34-!- celticminstrel is now known as celmin|sleep 20180401 07:30:57-!- aeth [~Michael@wesnoth/umc-dev/developer/aethaeryn] has quit [Ping timeout: 240 seconds] 20180401 07:31:52<+discordbot> Is 1.13.13 tagged already? 20180401 07:33:00<+discordbot> No, it's not. 20180401 07:33:03-!- aeth [~Michael@wesnoth/umc-dev/developer/aethaeryn] has joined #wesnoth-dev 20180401 07:33:41<+discordbot> (Geez, Vultraz. Could you refrain from announcing stable release dates as definite in Twitter when you can't keep RC tagging schedules?) 20180401 07:35:59< irker752> wesnoth/wesnoth:1.14 Charles Dang 7e279748cc Mentioned Dark Forecast fix AppVeyor: All builds passed 20180401 07:37:22<+discordbot> It's Easter Sunday here ๐Ÿ˜ 20180401 07:37:30<+discordbot> I was kinda busy this afternoon. 20180401 07:37:42<+discordbot> I have a few things I need to do, figured I'd tag this evening 20180401 07:37:50<+discordbot> geez 20180401 07:38:03<+discordbot> In that case I guess today was a bad choice for the tagging day. 20180401 07:38:15<+discordbot> I was planning on tagging this morning, but i was late for church. 20180401 07:39:53<+discordbot> Also, the problem isn't the schedule slip. It's perfectly normal that things go behind schedule. 20180401 07:41:03<+discordbot> And that's the exact reason why you shouldn't announce as release date as "this is the final date, it won't change no matter what". Maybe you can do that when you already have the gold build, but not really earlier than that. 20180401 07:41:37<+discordbot> That's why that's supposed to be the announcement date, not the tagging date. 20180401 07:45:10<+discordbot> I'll tag right now. 20180401 07:49:31< irker752> wesnoth: Charles Dang wesnoth:1.14 5b7aca975611 / changelog.md: Mentioned THoT change in changelog https://github.com/wesnoth/wesnoth/commit/5b7aca97561142501eb54c4a156a740b87178a23 20180401 07:49:34< irker752> wesnoth: Charles Dang wesnoth:1.14 642768e48e3e / / (5 files in 3 dirs): Pre-release version bump https://github.com/wesnoth/wesnoth/commit/642768e48e3ed6a40e08ee405acdd0cd0fe551a6 20180401 07:49:37< irker752> wesnoth: Charles Dang wesnoth:1.14 cef598699019 / Doxyfile changelog.md players_changelog.md src/wesconfig.h: Post-release version bump https://github.com/wesnoth/wesnoth/commit/cef598699019de1d72f775e3b7f7f6956da0281e 20180401 07:49:38<+discordbot> @hrubymar10 now it is 20180401 07:51:19<+discordbot> @loonycyborg tag is tagged 20180401 08:02:18-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev 20180401 08:14:24< irker752> wesnoth: Charles Dang wesnoth:1.14 6b20ccdb6282 / data/core/help.cfg: Help: removed sort_sections key with invalid value https://github.com/wesnoth/wesnoth/commit/6b20ccdb6282084b1fdb446d8a93d621204e8408 20180401 08:17:12<+discordbot> @Vultraz it is? I don't see that tag 20180401 08:17:26<+discordbot> even after git fetch 20180401 08:17:30<+discordbot> oh dear 20180401 08:17:33<+discordbot> did I forget to push tags 20180401 08:17:48<+discordbot> derp 20180401 08:18:01<+discordbot> I forgot to use the push dialog and click Include Tags 20180401 08:18:03<+discordbot> derp derp derp 20180401 08:18:19< irker752> wesnoth: Vultraz wesnoth: 642768e48e3e tagged as 1.13.13 20180401 08:18:30<+discordbot> @loonycyborg @hrubymar10 ok, the tag is actually pushed now 20180401 08:20:11<+discordbot> and this is why I prefer cli workflows now 20180401 08:21:34<+discordbot> Ok, I am on way home now. macOS release will be done in 10hours at max. Today I donโ€™t expect any codesigning related problems as before. 20180401 08:22:25<+discordbot> I am forgetting a lot today....just went out without my keys 20180401 08:22:33<+discordbot> ๐Ÿ˜‘ 20180401 08:33:56-!- Oebele [~quassel@143.177.58.202] has joined #wesnoth-dev 20180401 08:42:14<+discordbot> ๐Ÿ˜ƒ๐ŸŽ‰ 20180401 08:49:19-!- grzywacz [~karol@89-70-226-147.dynamic.chello.pl] has joined #wesnoth-dev 20180401 09:01:25< irker752> wesnoth/wesnoth:1.14 Steve Cotton bcaac1efef THoT S12 Put the sneak-passageway's door AppVeyor: All builds passed 20180401 09:07:45-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180401 09:07:51-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180401 09:08:18-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20180401 09:15:44<+discordbot> oh wow it's 1st april 20180401 09:15:59<+discordbot> can we be sure that this release isn't a joke? ๐Ÿ˜› 20180401 09:19:09<+discordbot> It is not. 20180401 09:19:58<+discordbot> Unless events somehow conspire to make it so (i.e. a major blocker made it into the release and it requires an immediate RC 3 to replace it). 20180401 09:20:13<+discordbot> *e.g. 20180401 09:20:41<+discordbot> I'm speaking hypotheticals here, just to clarify. I'd hope that isn't the case since, like I said, the branch is supposed to be releasable 24/7 modulo pot-updates. 20180401 09:20:55-!- grzywacz [~karol@89-70-226-147.dynamic.chello.pl] has quit [Ping timeout: 256 seconds] 20180401 09:22:22< vn971> I personally think this is a blocker: https://github.com/wesnoth/wesnoth/issues/2802 Though I will step aside if core maintainers think it shouldn't be a blocker. 20180401 09:24:07< zookeeper> yes, that's pretty horrible 20180401 09:36:14<+discordbot> I'll work on that 20180401 09:38:06-!- travis-ci [~travis-ci@ec2-54-226-45-119.compute-1.amazonaws.com] has joined #wesnoth-dev 20180401 09:38:07< travis-ci> wesnoth/wesnoth#17379 (1.13.13 - 642768e : Charles Dang): The build passed. 20180401 09:38:07< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/360819267 20180401 09:38:07-!- travis-ci [~travis-ci@ec2-54-226-45-119.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180401 09:43:19< vn971> This will be official 1.14 release, right? Not e.g. 1.14-RC2 ? 20180401 09:44:10<+discordbot> No, there will be more RCs. To leave more time for translation updates, if nothing else. 20180401 09:44:40-!- Nobun [~user@host91-49-dynamic.52-79-r.retail.telecomitalia.it] has joined #wesnoth-dev 20180401 09:45:35<+discordbot> Probably no more than 1 more 20180401 09:46:09< vn971> jyrkive: that's a relief. People played too few games on the new server yet, things _will_ come up. 20180401 09:51:09-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180401 09:51:15-!- janebot_ [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180401 09:51:17-!- janebot_ is now known as janebot 20180401 09:56:17-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180401 09:56:24-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180401 09:58:17-!- Nobun [~user@host91-49-dynamic.52-79-r.retail.telecomitalia.it] has quit [Quit: WeeChat 2.1-dev] 20180401 10:20:57-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180401 10:21:03-!- janebot_ [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180401 10:21:05-!- janebot_ is now known as janebot 20180401 10:38:17-!- Oebele [~quassel@143.177.58.202] has quit [Remote host closed the connection] 20180401 10:51:51<+discordbot> wish there were any documentation what exactly .. means in the context of help... 20180401 11:00:52-!- Oebele [~quassel@143.177.58.202] has joined #wesnoth-dev 20180401 11:13:19< vn971> By the way, would anyone have any use of the following map functions?: 1. wesnoth_x, wesnoth_y => real_x, real_y 2. real_x, real_y => wesnoth_x, wesnoth_y 3. rotate(x,y, degree) => x,y 20180401 11:13:48<+discordbot> I think we have those? 20180401 11:14:16< vn971> Decided to write one for Choicerer's map randomizer, to remember complex numbers (math) and all that stuff a little. 20180401 11:14:29< vn971> @vultraz: where? I don't see it.. 20180401 11:14:51<+discordbot> ah, wait, no, I'm thinking on the c++ side 20180401 11:16:00< vn971> this may be. I remember there was some talk about doing 30deg rotations etc effeciently. Wonder if that's being solved or if it needs any help. 20180401 11:16:22< vn971> I do know math, complex numbers and programming so I could help. (If needed.) 20180401 11:17:06<+discordbot> IIRC, the first two are just a matter of 1-indexing vs 0-indexing... 20180401 11:17:19<+discordbot> (ie, the difference is just 1) 20180401 11:18:46<+discordbot> as for the rotation thing....not sure how one would do it off the top of my head 20180401 11:19:14<+discordbot> you can't do a simple trig calculation since you're not working with a grid, but rather staggered hexes. 20180401 11:19:21< vn971> @Vultraz well not exactly. Wesnoth coordinates jump up-down comparing to real coordinates. Also one "x" step is a bit shorter than one "y" step. 20180401 11:20:02< vn971> or better to say, two "x" steps are shorter that two "y". The "y" equals to 2 in real coordinates, whereas the "x" equals to sqrt(3). 20180401 11:21:23< vn971> @Vultraz rotation can be done by first transforming to real x,y, then doing a rotation by means of complex number multiplication, then transforming back to wesnoth coords. 20180401 11:22:04< vn971> complex number multiplication is even faster than sin-cos, it's 4 multiplications and 2 additions only. 20180401 11:22:07<+discordbot> ๐Ÿค” 20180401 11:22:57<+discordbot> well, if you code such functions (in Lua, I presume?) we'd very likely add them. 20180401 11:24:35< vn971> I haven't thought about that, but that may be nice indeed. Chances are it could be used by some of the add-on developers. Like random terrain generation that is symmetrical regarding 30/60deg rotation, etc. 20180401 11:26:14< vn971> I'll look into it, thx for noticing. 20180401 11:36:29< vn971> hm, by the way, I looked into the CPP implementation of "distance_between" to see if it's correct, and I believe it's not. A test to prove that would be drawing a large circle and see it's not symmetrical regarding hexes. I think it would be flattened. 20180401 11:36:54< vn971> Wonder if anybody cares and if I should do all that.. 20180401 11:47:01< vn971> UPD: I'm wrong: it measures hexes number instead of "isometric" distance sqrt(x^2 + y^2). By that definition, it's correct. My apologies. 20180401 12:02:55-!- octalot [~steve@178.165.128.114.wireless.dyn.drei.com] has joined #wesnoth-dev 20180401 12:03:09-!- irker752 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout] 20180401 12:07:35-!- octalot [~steve@178.165.128.114.wireless.dyn.drei.com] has quit [Ping timeout: 240 seconds] 20180401 12:08:05-!- octalot [~steve@178.115.130.95.wireless.dyn.drei.com] has joined #wesnoth-dev 20180401 12:24:14< Ravana_> seems that addon check is not smart enough to check version from pbl https://i.imgur.com/h6OJ34K.png 20180401 12:30:49<+discordbot> I created macOS package for 1.13.13 . I tested that it works under 10.13 and 10.8 . Package is signed. 20180401 12:31:22<+discordbot> I canโ€™t upload it directly to SF, as I donโ€™t have privilages for it. 20180401 12:32:34<+discordbot> Also I would like if atl one of mentioned try it first. @ancestral , @sinda , @galegosimpatico and mattsc 20180401 12:40:16<+discordbot> ah, crap 20180401 12:40:20<+discordbot> i forgot I was supposed to add you 20180401 12:45:29<+discordbot> @hrubymar10 you hould be able to updload to SF 20180401 12:45:31<+discordbot> should* 20180401 12:45:32<+discordbot> nw 20180401 12:45:34<+discordbot> now 20180401 12:46:11-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180401 13:04:24-!- irker767 [~irker@uruz.ai0867.net] has joined #wesnoth-dev 20180401 13:04:24< irker767> wesnoth: Steve Cotton wesnoth:master d6661fdb802a / / (2 files in 2 dirs): THoT S12 Put the sneak-passageway's door on the right hex (fixes #2804) https://github.com/wesnoth/wesnoth/commit/d6661fdb802a06050a9a76693c40566e9ecbdc10 20180401 13:35:14<+discordbot> Iโ€™ll upload it in 1 hour 20180401 13:38:41<+discordbot> ok, no hurry 20180401 13:41:54< vn971> Damn. I was writing an algo to check if map is symmetrical (for Choicerer). And I wrote it. And it gives correct results. Results being that a big fraction of maps that are supposed to be symmetrical do actually have bugs (usually away from center). 20180401 13:42:42< vn971> When a programmer hits real life of map creators... 20180401 13:49:08<+discordbot> heh 20180401 13:57:10<+discordbot> Uploading 20180401 13:58:26< celmin|sleep> vn971: You should look at wesnoth.map, there's a rotation function there. 20180401 13:58:50< celmin|sleep> I think wesnoth.map isn't yet documented either; it should be. 20180401 14:00:42< celmin|sleep> Ah, wait, maybe I did actually document it...? 20180401 14:01:12< celmin|sleep> Yeah, I did. 20180401 14:02:02< celmin|sleep> wesnoth.map.rotate_right_around_center which is admittedly quite an unwieldy name; and the "angle" IIRC is just an index... 20180401 14:02:53-!- celmin|sleep is now known as celticminstrel 20180401 14:06:16< celticminstrel> There are a lot of issues, the undocumented API has been pushed to page 3... o.> 20180401 14:06:20< celticminstrel> o.O 20180401 14:19:18-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180401 14:19:24-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180401 14:21:40<+discordbot> Sounds like maybe he has a better Impl? 20180401 14:24:16<+discordbot> All up now: https://sourceforge.net/projects/wesnoth/files/wesnoth/wesnoth-1.13.13/ 20180401 14:26:56<+discordbot> Ty 20180401 14:27:02<+discordbot> Will announce tomorrow 20180401 14:27:18-!- vn971 [~vasya@94.158.103.15] has quit [Read error: Connection reset by peer] 20180401 14:27:39-!- vn9711 [~vasya@94.158.103.15] has joined #wesnoth-dev 20180401 14:28:08<+discordbot> @hrubymar10 The package works for me on macOS Sierra 10.12.6 20180401 14:28:47<+discordbot> Obviously I have not done much testing yet, but I checked the sha, that it opens and I can move and attack in a scenario, and that I can change the language. 20180401 14:28:59<+discordbot> Just the basic tests ... 20180401 14:31:49<+discordbot> Yes, that's good. @Tad Carlucci also do some tests, including Gatekeeper one so I don't expect any problems with this package. 20180401 14:32:41<+discordbot> Checkpointing macOS. Hang on. 20180401 14:34:29<+discordbot> Out of curiosity, under which name do I show up for you here? 20180401 14:34:55<+discordbot> Because I still see myself as csttam, even though I changed my name in the profile 20180401 14:34:59<+discordbot> On Discord: csttam 20180401 14:35:24<+discordbot> okay - so not sure what the name change does then 20180401 14:36:08<+discordbot> Actually, in the private conversations it shows the other name. Weird. 20180401 14:38:51<+discordbot> You can have different name for DM and groups 20180401 14:39:06<+discordbot> also you can have different name in each group 20180401 14:39:45<+discordbot> And, apparently, each instance of Discord. 20180401 14:40:34<+discordbot> Hmm, yeah. Apparently this modern technology is too complicated for me. ๐Ÿ˜‰ 20180401 14:40:54<+discordbot> I am admin of other discord group and when I right-click on any name in the right sidebar I see this: 20180401 14:40:54<+discordbot> https://cdn.discordapp.com/attachments/259976436490829825/430013693841899520/unknown.png 20180401 14:41:21<+discordbot> But here I see only this for my name: 20180401 14:41:22<+discordbot> https://cdn.discordapp.com/attachments/259976436490829825/430013810447876115/unknown.png 20180401 14:41:39<+discordbot> I believe, that only admin can change nickname 20180401 14:42:47<+discordbot> I've been lost ever since I had to swap my cell phone and pager for a feature phone. Don't grok all the junk on my iPhone 4+, so I use it as a feature phone .. voice/text and don't ask for more. 20180401 14:43:33<+discordbot> Nope, it must be enabled by admin: 20180401 14:43:33<+discordbot> https://cdn.discordapp.com/attachments/259976436490829825/430014359687790594/unknown.png 20180401 14:43:52< zookeeper> vn9711, how do you know which maps are supposed to be symmetrical? 20180401 14:43:54<+discordbot> everyone can change his nickname if admin enale this feature 20180401 14:44:31< vn9711> zookeeper: that's exactly what I was trying to do: find out if the map is already symmetrical, from Lua. 20180401 14:44:37<+discordbot> I see. Thanks. It's not that important anyway, was just wondering, because @Vultraz seems to have seen me by the changed name the other day. 20180401 14:46:13< zookeeper> vn9711, my point was that the only reason to assume a map is meant to be strictly symmetrical is if the author tells you so. which might be the case in your case, i guess. 20180401 14:46:15<+discordbot> And @Tad Carlucci : I still have a cell phone that's just a phone. Because that's all I needed (and I have my laptop with me pretty much at all times anyway). But traveling is becoming more convenient these days with one of them fancy thingies, so I might switch soon. 20180401 14:49:39<+discordbot> For the record, I'm not opposed to the the latest gadgets, I just go for the minimal approach for myself. If something's sufficient for my purpose and not too inconvenient, that's good enough for me. 20180401 14:51:06<+discordbot> I have an iPhone for two reasons: martial harmony ("But you need Facebook!" even though I don't and won't use it.) and it was a cast-off from the wife because she wanted an SE. 20180401 14:51:26< zookeeper> martial, huh... 20180401 14:51:39<+discordbot> martial marital .. same thing 20180401 14:51:48<+discordbot> I was just going to say that ^ 20180401 14:51:50< zookeeper> so i've heard 20180401 14:52:23<+discordbot> I had no cell phone at all for almost a year a few years back until I was told that I need to have one. 20180401 14:53:27<+discordbot> Anyways, I'll stop spamming this channel with this now. Family duties ... 20180401 14:53:41<+discordbot> same here 20180401 15:00:43<+discordbot> Anyone? https://github.com/wesnoth/wesnoth/pull/2680 I can't create package without this PR. 20180401 15:07:41-!- grzywacz [~karol@89-70-226-147.dynamic.chello.pl] has joined #wesnoth-dev 20180401 15:07:52-!- grzywacz [~karol@89-70-226-147.dynamic.chello.pl] has quit [Changing host] 20180401 15:07:52-!- grzywacz [~karol@wesnoth/developer/grzywacz] has joined #wesnoth-dev 20180401 15:13:40< irker767> wesnoth/wesnoth:1.14 Charles Dang 6b20ccdb62 Help: removed sort_sections key with inv AppVeyor: All builds passed 20180401 15:25:15< celticminstrel> I have no ability to check that PR. The SDLMain.nib file isn't editable with any tools I have on my computer. 20180401 15:26:11< celticminstrel> Could you maybe post a screenshot or something @hrubymar10? 20180401 15:27:57<+discordbot> Only change is that I can't include full text anymore, so I have to include only changes for 1.13 . I'll post 2 screenshots into PR 20180401 15:28:10< celticminstrel> Oh. 20180401 15:28:32< celticminstrel> Well, I guess the really old changelogs aren't that important, and they can be found on the website if anyone's super interested. 20180401 15:31:24<+discordbot> celticmintrel : https://github.com/wesnoth/wesnoth/pull/2680#issuecomment-377794567 20180401 15:31:43<+discordbot> celticminstrel : https://github.com/wesnoth/wesnoth/pull/2680#issuecomment-377794567 20180401 15:33:58<+discordbot> Why do we have enabled spellchecker here? ๐Ÿ˜„ 20180401 15:35:00<+discordbot> Maybe I should disable spellchecking first? 20180401 15:35:19-!- lipkab [~lipk@host-91-147-210-58.biatv.hu] has joined #wesnoth-dev 20180401 15:37:02< celticminstrel> loonycyborg: How much work would it be to make the installer detect and offer to remove previous versions in the same development series? 20180401 15:39:12< celticminstrel> I directed the installer to install to the same location as 1.13.12, but it gives me no indication that it knows it's overwriting a previous install. 20180401 15:39:40< celticminstrel> (Which in theory could also mean it doesn't delete files that were removed, though that shouldn't be an issue in a stable release.) 20180401 15:42:42< celticminstrel> (On an unrelated note, why is cwesnoth.cmd needed? It'd be better if we could do away with it IMO.) 20180401 15:44:46< loonycyborg> celticminstrel: I guess it can be done but I don't like working with NSI 20180401 15:44:58< loonycyborg> I'm planning to change installer generator 20180401 15:45:08< celticminstrel> Oh? To what? 20180401 15:45:34< celticminstrel> When I looked into it, NSI seemed to be the best I could find; Microsoft's alternative is bad. 20180401 15:45:43< loonycyborg> to this https://wiki.gnome.org/msitools 20180401 15:45:59<+discordbot> Not even Microsoft uses their package. 20180401 15:46:07< celticminstrel> XD 20180401 15:46:10< celticminstrel> Really? 20180401 15:46:15< loonycyborg> or maybe WiX in wine 20180401 15:46:24< loonycyborg> Microsoft use WiX :P 20180401 15:46:36< celticminstrel> WiX is the one that I thought was bad. 20180401 15:46:52<+discordbot> And WiX is what I strongly recommend 20180401 15:47:06< loonycyborg> I don't like two things about NSI: its language and that it requires me to do too many things manually 20180401 15:47:21< celticminstrel> I can't remember why I thought it was bad, but I think it was something along the lines of being difficult to work with or perhaps just poorly documented. 20180401 15:47:28< loonycyborg> at least unsafely manually 20180401 15:47:50< celticminstrel> Suffice to say that I spent a long time failing to get it to work, but when I tried NSI instead, it went more smoothly. 20180401 15:47:50< loonycyborg> case you want is exactly what I would be loath to implement in NSI 20180401 15:48:11< celticminstrel> Yeah, IIRC WiX has a mechanism for that built-in or something? 20180401 15:48:37< loonycyborg> at least it automatically can ensure that everything that was added will be removed 20180401 15:48:38<+discordbot> Also VS natively supports WiX projects 20180401 15:48:48< loonycyborg> while with nsi I'd need to do it manually 20180401 15:48:51< celticminstrel> I know, but that didn't really help me. 20180401 15:48:56< loonycyborg> and likely fuckup in some corner cases 20180401 15:49:23< loonycyborg> but if you want to add changes to nsi script feel free to 20180401 15:49:28< loonycyborg> it's in git 20180401 15:49:51< loonycyborg> https://github.com/wesnoth/wesnoth/blob/master/packaging/windows/Wesnoth.nsi.in 20180401 16:01:12-!- lipkab [~lipk@host-91-147-210-58.biatv.hu] has quit [Remote host closed the connection] 20180401 16:01:35-!- lipkab [~lipk@host-91-147-210-58.biatv.hu] has joined #wesnoth-dev 20180401 16:12:24< grzywacz> Ivanovic: are you still handling translation updates? :) 20180401 16:14:11-!- gfgtdf [~chatzilla@x4e363bcb.dyn.telefonica.de] has joined #wesnoth-dev 20180401 16:14:29<+discordbot> judging by recent commits yes 20180401 16:19:04-!- louis94 [~~louis94@149.36-245-81.adsl-dyn.isp.belgacom.be] has joined #wesnoth-dev 20180401 16:23:09< vn9711> celticminstrel: the rotation you wrote about (wesnoth.map.rotate_right_around_center) is nice, but some maps should be rotated around vertex, not center. 20180401 16:23:40< celticminstrel> Isn't that still possible to do with rotate_right_around_center? 20180401 16:23:55< celticminstrel> Harder though, I guess. Need to calculate the centre from the vertex or something. 20180401 16:24:19< celticminstrel> (This isn't about rotating maps, it's about rotating map locations.) 20180401 16:24:22< grzywacz> translate, rotate, translate back? 20180401 16:24:33< celticminstrel> Something like that. 20180401 16:25:10< vn9711> grzywacz: basically yes. You have to understand how to do translation though (it's non-linear, requires rounding at certain steps), and you have to understand how to do rotation (basically complex numbers). 20180401 16:25:27-!- Bonobo [~Bonobo@203.220.138.198] has quit [Ping timeout: 240 seconds] 20180401 16:25:36< grzywacz> Yeah, I can only imagine the corner cases. :) 20180401 16:26:16< celticminstrel> Adding a translation function might be an idea then? 20180401 16:26:18< celticminstrel> I dunno. 20180401 16:27:21< vn9711> though to be honest, for "integer" coordinates and center of hex (or vertex), maybe there's a smartass formula not requiring complex numbers. Actually if you take complex numbers and simplify the resulting formula all the way through, you'll get something that doesn't look like complex numbers. 20180401 16:29:05< gfgtdf> we cealrly cannot do that right now, but i wonder whether it'd be better to have invariant coordinates, where the cooridnates with even x cooridnates can only have even y coordinates and the coordinates with uneven x coordinate have only uneven y coorinates. meaning that '+(1,1)' would _always_ specify the cooridnate on the southeast of a hey indpendent on which hex the origin is. 20180401 16:29:24< vn9711> hm, also there can be 180deg rotation around middle of an edge. So to mimic the existing approach, we must create a total of 3 funcitons. One that rotates around center of hex, one that rotates around vertex, and one that rotates around middle of an edge. 20180401 16:29:57< celticminstrel> "This map is already open" 20180401 16:30:09< celticminstrel> Yeah uh, maybe you could just, y'know, reload it from disk for me? 20180401 16:30:32< celticminstrel> Do I really have to close my map and reopen it to revert all changes? 20180401 16:30:56< vn9711> celticminstrel: sounds like a feature request.. 20180401 16:30:59< zookeeper> there's a revert option 20180401 16:31:25< zookeeper> just make a change and take it from the main menu 20180401 16:31:31< vn9711> celticminstrel: I came accross that too. But since I'm spamming with much more feature requests than I implement already, I just clicked "close".. 20180401 16:31:33< gfgtdf> celticminstrel: sounds liek the expected behviour actually, no (text) editor your reload the file form disk in that case if it is already open 20180401 16:31:38< celticminstrel> ...oh it's hidden if there's no changes? 20180401 16:31:48< gfgtdf> "no (text) editor i know"* 20180401 16:33:13< celticminstrel> Well, at the very least the "this map is already open" popup should point at the revert option IMO. 20180401 16:35:24< zookeeper> why/how? 20180401 16:36:03< celticminstrel> Just add "If you want to reload it from disk, select 'Revert All Changes' from the file menu" or something like that. 20180401 16:36:24< celticminstrel> Alternatively, replace it with a yes/no dialog which lets you revert or not, I suppose, but that's not really necessary. 20180401 16:37:03< zookeeper> yeah, i guess a mention like that might be useful 20180401 16:37:43< vn9711> celticminstrel: alternatively, just have to click "close" and open again... 20180401 16:38:07< vn9711> not too hard anyway considering there are very few map developers (I think). 20180401 16:38:12< celticminstrel> Which is a pain because the file dialog doesn't remember your directory. 20180401 16:38:28< celticminstrel> Or to be more precise, the directory it uses is that of the currently active map, I suspect. 20180401 16:38:37< celticminstrel> Rather than the last used directory as one would expect. 20180401 16:39:07< vn9711> celticminstrel: yes, I know your pain, I've stumbled accross that myself.. Had to open a file nearby first, then switch to old back, then close, then click "open" and get the dir back. 20180401 16:39:27< vn9711> celticminstrel: maybe you can transform your feature request to "remember last opened directory". 20180401 16:41:28-!- TC01 [~quassel@venus.arosser.com] has quit [Remote host closed the connection] 20180401 16:46:28-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180401 16:46:34-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180401 16:52:51< irker767> wesnoth/wesnoth:1.13.13 Charles Dang 642768e48e Pre-release version bump AppVeyor: All builds passed 20180401 16:56:11-!- louis94 [~~louis94@149.36-245-81.adsl-dyn.isp.belgacom.be] has quit [Ping timeout: 276 seconds] 20180401 16:58:48-!- lipkab [~lipk@host-91-147-210-58.biatv.hu] has quit [Ping timeout: 260 seconds] 20180401 17:01:39< grzywacz> You know what would be cool? Personal pronoun/gender setting in preferences, so it would be possible to translate "you" without being awkwards in languages where it matters. :S 20180401 17:01:48< grzywacz> *awkward 20180401 17:02:17<+discordbot> If it was just a preference, almost everyone would just leave it at default. 20180401 17:02:23< celticminstrel> How many places actually use "you" to refer to the player? 20180401 17:02:36< grzywacz> Lots, in help / tooltips. 20180401 17:02:45< celticminstrel> Hmm. 20180401 17:02:50< celticminstrel> Can I have a tooltip example? 20180401 17:03:17< grzywacz> Rough estimate: 20180401 17:03:18< grzywacz> karol@omoikane wesnoth% pwd 20180401 17:03:18< grzywacz> /home/karol/git/wesnoth/po/wesnoth 20180401 17:03:18< grzywacz> karol@omoikane wesnoth% git grep 'you' pl.po | wc -l 20180401 17:03:22< grzywacz> 235 20180401 17:03:42< celticminstrel> I would imagine most of those are one unit speaking to another though? 20180401 17:03:45< grzywacz> "the amount of gold that would be deducted if you lost all villages." 20180401 17:04:13< grzywacz> One unit speaking to the other is determined by unit gender, which is usually specified in the campaign. 20180401 17:04:31< grzywacz> And they rarely speak otherwise? 20180401 17:04:37< celticminstrel> Well, that specific example could be rephrased as passive... though I dunno if that'll work in Polish. 20180401 17:04:50< grzywacz> I rephrased it in passive. 20180401 17:04:54< celticminstrel> Ah. 20180401 17:04:57< celticminstrel> Nice. 20180401 17:05:03< grzywacz> But it feels less personal than in the original. ;) 20180401 17:05:15< celticminstrel> So it's solvable without awkwardness, at least. 20180401 17:05:36< grzywacz> Yeah, well... As I said, would be cool, not really a must have feature. :p 20180401 17:06:32< grzywacz> That estimate above ^ is grossly overinflated, ignore. :) 20180401 17:08:14-!- lipkab [~lipk@host-91-147-210-58.biatv.hu] has joined #wesnoth-dev 20180401 17:18:11< celticminstrel> ...hold on a sec, why am I still getting the wml_tag_metatable errors on 1.13.13? 20180401 17:18:18< celticminstrel> Deprecation messages I mean. 20180401 17:18:26< celticminstrel> I thought I fixed that on the 1.14 branch? 20180401 17:20:24< celticminstrel> There are no instances of it on 1.14 and no instances of it in my addon and I still get it... oh wait, could it be that some other addon is using it? 20180401 17:20:39< celticminstrel> I do have a couple of others that I migrated from 1.13. 20180401 17:31:27-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180401 17:31:33-!- janebot_ [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180401 17:31:38-!- janebot_ is now known as janebot 20180401 17:45:12< grzywacz> ata% git grep -i 'rusty.*gate' | grep -i open | uniq 20180401 17:45:12< grzywacz> core/terrain.cfg: editor_name= _ "Open Rusty Gate" 20180401 17:45:14< grzywacz> core/terrain.cfg: editor_name= _ "Rusty Open Gate" 20180401 17:45:15< grzywacz> hah 20180401 17:45:40< grzywacz> And I thought I've had that string translated. :D 20180401 17:45:44< celticminstrel> ? 20180401 17:46:23< grzywacz> I was like, "I've just translated something about open rusty gates". But there are actually two different strings there. ;) 20180401 17:46:37< celticminstrel> Oh. 20180401 17:46:39< celticminstrel> ... 20180401 17:46:45< celticminstrel> Why are there two strings there. :| 20180401 18:01:52< irker767> wesnoth: Celtic Minstrel wesnoth:1.14 2492585ee225 / data/lua/core.lua: Fix incorrect error message when encountering an unknown persistent tag https://github.com/wesnoth/wesnoth/commit/2492585ee2251d8c97a937143932959807d87010 20180401 18:03:19<+discordbot> @hrubymar10 Again, nicknames are disabled on purpose. 20180401 18:03:43< grzywacz> Currently in 1.14 MP lobby, I'm getting warnings in the console: "20180401 20:02:44 warning engine: User Diabl0tin has unknown game_id: 112" 20180401 18:03:52< grzywacz> 20180401 20:03:32 warning unit: Unknown attribute 'player' discarded. 20180401 18:05:05< irker767> wesnoth: Celtic Minstrel wesnoth:master d2a8c5bb3200 / data/lua/core.lua: Fix incorrect error message when encountering an unknown persistent tag https://github.com/wesnoth/wesnoth/commit/d2a8c5bb3200898a068aa24b7b968e444c7dc851 20180401 18:05:11<+discordbot> Someone gave @csttam a nickname without asking first so that's why his username change doesn't do anything. 20180401 18:05:35< irker767> wesnoth: Celtic Minstrel wesnoth:master fed46ec45f37 / changelog.md data/lua/wml-tags.lua: Support location_id in [teleport] https://github.com/wesnoth/wesnoth/commit/fed46ec45f37baab8bd4491f4b67492256e42132 20180401 18:06:51<+discordbot> Group admin should e ale to change his nickname. I don't care about nickname tbh. I just told him, why it didn't work. @shadowm 20180401 18:07:17< grzywacz> And finally on OOS: https://gist.github.com/knowak/c97a3484d0dda5fe6261a3ab6aebd57a 20180401 18:07:22< grzywacz> (game crashed) 20180401 18:07:29<+discordbot> Did you mentioned that my B key is broken? ๐Ÿ˜ฆ 20180401 18:07:40<+discordbot> I will remove his nickname if nobody beats me to it. It's just ridiculously hard on mobile. 20180401 18:08:02<+discordbot> Or assign him a nickname that people can actually recognise really. 20180401 18:09:25<+discordbot> There. 20180401 18:10:45< gfgtdf> grzywacz: so whatdid you do to get that OOS ? 20180401 18:11:11< celticminstrel> I wonder, does define= work in [scenario] or just [multiplayer]? 20180401 18:11:19-!- lipkab [~lipk@host-91-147-210-58.biatv.hu] has quit [Remote host closed the connection] 20180401 18:11:32<+discordbot> @hrubymar10 Also, did @loonycyborg add you to the packagers mail list? 20180401 18:11:34< grzywacz> gfgtdf: joined someone's game :D 20180401 18:11:36< celticminstrel> If it works in scenario= I can use it to enable an extra advancement after a particular scenario. 20180401 18:11:44< grzywacz> Someone was testing a survival. 20180401 18:11:49<+discordbot> sohuld I? 20180401 18:11:52<+discordbot> I added me myself 20180401 18:11:56<+discordbot> Yes. 20180401 18:11:56<+discordbot> already 20180401 18:11:57<+discordbot> we notify him via discord anyway 20180401 18:12:11<+discordbot> Am I on that ml? 20180401 18:12:17<+discordbot> And what happens in the event that Discord is down? 20180401 18:12:29< gfgtdf> i doubt it works in [scenario], do you ahve a usecase for that ? 20180401 18:12:32<+discordbot> The list you use for sending out that email loonycyborg. 20180401 18:12:33<+discordbot> Email is like double tap ๐Ÿ˜„ 20180401 18:12:34<+discordbot> Ugh. 20180401 18:12:49< celticminstrel> gfgtdf: I just posted it - varying unit advancement lines as the campaign progresses. 20180401 18:12:52<+discordbot> Not the actual ML that I don't think anyone uses yet. 20180401 18:12:54<+discordbot> oh 20180401 18:13:05<+discordbot> Unless someone else subscribed me to it. 20180401 18:13:08<+discordbot> btw 20180401 18:13:17<+discordbot> Your email is incorrect for the second time in a row. 20180401 18:13:17< celticminstrel> Actually, UtBS's increasing unit cost could also be a good use-case. 20180401 18:13:23<+discordbot> maybe we just add those guys to that mlk? 20180401 18:13:39<+discordbot> The dependencies did change twice, one for RC 1 and again for RC 2. 20180401 18:13:39<+discordbot> what was incorrect? 20180401 18:13:42< gfgtdf> celticminstrel: ew i always hated the 'change unit advancements via deifnes' mechanic. 20180401 18:13:49<+discordbot> boost version? 20180401 18:13:59<+discordbot> RC 1 bumped Boost and RC 2 undid that change. 20180401 18:14:14< celticminstrel> gfgtdf: Well what about the second use-case then. 20180401 18:14:33<+discordbot> macOS package now uses Boost 1.66 btw 20180401 18:14:39<+discordbot> hmm I'm not sure that should be in mail even 20180401 18:14:45<+discordbot> I thought you were aware of this since I tagged you in the middle of that debate. 20180401 18:14:46<+discordbot> I though it's only for new libs 20180401 18:14:54< gfgtdf> ? 20180401 18:14:54<+discordbot> Oh my god. 20180401 18:15:22<+discordbot> Loonycyborg how is that even a point of contention for you? 20180401 18:15:28< celticminstrel> gfgtdf: 20180401 18:15:29< celticminstrel> [Apr 01@2:13:17pm] celticminstrel: Actually, UtBS's increasing unit cost could also be a good use-case. 20180401 18:16:43<+discordbot> I really can't tell if you genuinely don't realise that dependency changes include changes to the required versions, or you're just doing this to make me type more words on my phone. 20180401 18:16:57<+discordbot> A dependency change is a dependency change. 20180401 18:17:07<+discordbot> It doesn't get simpler than that. 20180401 18:17:56< gfgtdf> celticminstrel: hmm i realyl diliek the idea of reloading the whole gmae config just to change one single variable somehere. Also even if you did it via defined it'd be rather unflexible, for exmapel you still couldn't change these states via the scenaio. 20180401 18:18:17<+discordbot> Could you for once try to think about it from the perspective of the people you're addressing (i.e. the packagers)? 20180401 18:18:34<+discordbot> @shadowm is that enough? I did subscribe these ~month ago 20180401 18:18:35<+discordbot> https://cdn.discordapp.com/attachments/259976436490829825/430068473855606785/unknown.png 20180401 18:18:44< gfgtdf> celticminstrel: if we want soemthing that changes suhc unit tyypes states i'd rather have soemtihng that changes it with actionwml/lua 20180401 18:18:49<+discordbot> The fact that half of them are inactive does not excuse being dense about the matter. 20180401 18:18:54<+discordbot> actually that was exactly what I was thinking 20180401 18:19:05< gfgtdf> grzywacz: on the current 1.14 server ? 20180401 18:19:11<+discordbot> like most of them will wait for stable version anyway 20180401 18:19:25<+discordbot> @hrubymar10 I already explained it doesn't. 20180401 18:19:25<+discordbot> and those that don't probably work on a bleeding edge distro anyway 20180401 18:19:43< celticminstrel> gfgtdf: Well, I can do what I want with the new unit placed event in any case. 20180401 18:19:47<+discordbot> Could you for once stop making assumptions to justify your own laziness? 20180401 18:20:00< celticminstrel> That wouldn't work for UtBS obviously. 20180401 18:20:09<+discordbot> Only under effects of a lobotomy 20180401 18:20:18<+discordbot> That's not funny or endearing or anything, especially given who you work with. 20180401 18:20:31< grzywacz> gfgtdf: yes 20180401 18:20:44< gfgtdf> grzywacz: i see one game on the current trunk server 20180401 18:20:56< gfgtdf> grzywacz:; it says 'era default+kalifate (missing)' ? 20180401 18:20:58< celticminstrel> I just realized, maybe schema_fixes can't go in 1.14 after all? 20180401 18:21:10< gfgtdf> why that ? 20180401 18:21:21<+discordbot> If this is how you're going to go about things then I don't know why you even help vultraz with the release stuff @loonycyborg 20180401 18:21:33< celticminstrel> Because of OOS? Would it not cause OOS if people had two different versions of the scenario WML? 20180401 18:21:35<+discordbot> okok I'll mention it next time 20180401 18:21:42<+discordbot> just to make you type on the phone less 20180401 18:21:46< gfgtdf> no scenariowmlis sesnded to other players form the host 20180401 18:21:46< grzywacz> gfgtdf: yeah, same user/game that I crashed on. 20180401 18:21:55< celticminstrel> Even if it's a core scenario? 20180401 18:21:59< grzywacz> gfgtdf: I can't observe it either. Says to report a bug. ;) 20180401 18:22:02<+discordbot> There's no next time since nobody's changing anything for RC 3. 20180401 18:22:04< gfgtdf> celticminstrel: yes 20180401 18:22:10< celticminstrel> Okay. 20180401 18:22:16<+discordbot> Hopefully. 20180401 18:22:24< celticminstrel> What about changes to unit WML for example? 20180401 18:22:34< celticminstrel> That would cause OOS right? 20180401 18:22:41<+discordbot> I hope so too 20180401 18:22:42< gfgtdf> yes it would 20180401 18:22:45< celticminstrel> So IOW I may need to hold back some of the schema fixes. 20180401 18:22:50< gfgtdf> grzywacz: so when did you get OOS in it when you couldn't join it ? 20180401 18:22:56< celticminstrel> Though I think I probably don't need any changes to unit WML, but we'll see. 20180401 18:23:09< gfgtdf> celticminstrel: well which exactly? removing a nonfuintinal key probably won't casue OOS, 20180401 18:23:18< grzywacz> gfgtdf: no, I joined it, game started, I got OOS and crashed after the OOS dialog 20180401 18:23:28< grzywacz> Apparently the game is still there, and now it's impossible to observe it? 20180401 18:23:35< gfgtdf> hmm 20180401 18:23:39< celticminstrel> Oh, wait, changing campaign unit WML (other than LoW) also wouldn't cause OOS, right? Since people can't play those in MP anyway unless they run with --debug. 20180401 18:24:09< gfgtdf> celticminstrel: i think vultraz made that campaign avialable in mp too 20180401 18:24:15< gfgtdf> celticminstrel: but they are complateley untested 20180401 18:24:27< celticminstrel> Yeah, they're available, but IIRC only with --debug? I could be mistaken. 20180401 18:24:41< gfgtdf> celticminstrel: iirc vultraz moved it out of debug 20180401 18:24:51< celticminstrel> I think I actually already made all the core unit WML changes that would be needed. 20180401 18:24:57< gfgtdf> celticminstrel: which doesnt guernettee that they actualyl work if you start them from there 20180401 18:25:18< celticminstrel> Still, once I'm finished the schema fixes we need to go over them and make sure it's all fine for 1.14, in case I need to pull a commit here or there. 20180401 18:25:20< gfgtdf> celticminstrel: i woudn't worry there, if you can fix an important bug by changing unit stats in a campaign do it. 20180401 18:26:27< gfgtdf> a stat of a campaign specific unit*, worring about mp compability* 20180401 18:28:32< gfgtdf> shadowm: does te 1.14 server reject older 1.13 versions (like 1.13.12 after 13.13.13 comes out ?) 20180401 18:29:16< gfgtdf> grzywacz: i think that player is probalby just using an outdated client. 20180401 18:30:04< gfgtdf> grzywacz: which _could_ also explaing those OOS you got. 20180401 18:30:09< grzywacz> that would a server config thing then... otoh crashing a game because of OOS is ugly either way :) 20180401 18:30:34<+discordbot> gfgtdf it accepts all 1.14.x versions and the RCs. 20180401 18:31:08<+discordbot> Still need to sort out a few things and the backend but you can work under that assumption. 20180401 18:31:40< gfgtdf> grzywacz: if you coudl somehow get s stacktrace we coudl fix that assertion error, but now wehave basicially no idea how that happend 20180401 18:32:12<+discordbot> If you break the MP protocol or change the synced attributes of ANY core units (hopefully with an EXTREMELY GOOD excuse) you must inform us and mention it in R_N. 20180401 18:32:58<+discordbot> And changelogs, but I don't need to point those out at this point I think. 20180401 18:33:23< grzywacz> gfgtdf: ok, I'll setup myself for this next time 20180401 18:33:24< grzywacz> afk for now 20180401 18:34:07<+discordbot> Also you should @ me because I don't read IRC unless I really have to. 20180401 18:34:33< celticminstrel> BTW @shadowm, would you sat it's acceptable or not to add deprecation messages to the 1.14 branch before release? 20180401 18:34:52< celticminstrel> I don't think they'd cause OOS, and they shouldn't even make any difference at all to people not using debug mode. 20180401 18:35:16< celticminstrel> ^say 20180401 18:35:28<+discordbot> They aren't translatable right? 20180401 18:35:47<+discordbot> Why weren't they added before RC 1? 20180401 18:35:55< celticminstrel> Only the core "This is deprecated" message is translatable, the details for individual messages are not. 20180401 18:36:10< celticminstrel> I don't know, someone forgot I guess? 20180401 18:36:22< celticminstrel> I'm fine with leaving them until 1.15 though. 20180401 18:36:34< celticminstrel> But I'd still prefer if they could go in 1.14. 20180401 18:37:35<+discordbot> I'd defer to zookeeper's opinion on this one 20180401 18:38:32< celticminstrel> The "This save is from a different version" popup is bugging me kinda, is it supposed to show when only the bugfix revision is different? 20180401 18:38:45< gfgtdf> what do you want to deprecate ? 20180401 18:39:09< celticminstrel> ATM, {REPEAT} is the one that comes to mind. 20180401 18:39:13<+discordbot> you were talking about that /scratch/packagers on server? 20180401 18:39:19< celticminstrel> Possibly one or two Lua functions. 20180401 18:39:20<+discordbot> It will stop showing once the major version is an even number. 20180401 18:39:29< celticminstrel> I see. 20180401 18:39:34<+discordbot> I don't see hruby there 20180401 18:39:36< celticminstrel> Okay then. 20180401 18:40:06<+discordbot> That file is a backup of your own list in case you get hit by a bus @loonycyborg 20180401 18:40:43<+discordbot> You probably manage it in some other way with your mail client. 20180401 18:41:04<+discordbot> yes I send it with claw mails 20180401 18:41:10<+discordbot> I just open sent mail 20180401 18:41:13<+discordbot> then edit it 20180401 18:41:15<+discordbot> then send 20180401 18:41:22<+discordbot> Wasn't the intent to switch to using the ML though? 20180401 18:41:47<+discordbot> would be cool 20180401 18:42:12<+discordbot> we have mls now but I don't know how to set them up properly 20180401 18:42:31<+discordbot> It's not rocket science really. 20180401 18:42:57<+discordbot> The list already exists I believe, but I don't know if the subs list makes sense yet. 20180401 18:43:12<+discordbot> is it possible to just manually add addresses there? 20180401 18:43:25< gfgtdf> grzywacz: hmm actuall i think it's porbably rather easy to trigger that assertion failure: just do a scenario with no sides and use soem actionswml tag that refers to the current side. 20180401 18:43:39<+discordbot> Then people (like @hrubymar10 did) just add themselves as needed. 20180401 18:43:49< gfgtdf> grzywacz: but your scenario had at least one side i think (it was a 2player mp game) 20180401 18:43:57<+discordbot> You have to be a list admin to do that. 20180401 18:44:15<+discordbot> To mass-add people, I mean. 20180401 18:44:23<+discordbot> also 20180401 18:44:39<+discordbot> I think it has passwords to let people change their settings 20180401 18:44:45<+discordbot> if I add them manually 20180401 18:44:50<+discordbot> what passwords will they have? 20180401 18:45:13<+discordbot> That's something I've been meaning to ask AI about 20180401 18:45:29<+discordbot> Because it does NOT ask me for a password. 20180401 18:45:47<+discordbot> At least not for i18n. 20180401 18:46:11<+discordbot> Meaning anyone who knows my address (which is to say everyone) can change my settings. 20180401 18:49:47<+discordbot> maybe older version didn't have passwords and it require password in latest version 20180401 19:02:40<+discordbot> anyway I'll read up on gnu mailman 20180401 19:02:59<+discordbot> and no access control can stop me from doing stuff since I can pct enter that ct anyway 20180401 19:06:26< vn9711> hmm. If a bat jumped happily on impassable terrain -- is that a bug? 20180401 19:07:35< vn9711> I guess it is right? It has terrain defense of 0% now (as expected). 20180401 19:12:57< zookeeper> bats don't jump. 20180401 19:14:27< zookeeper> anyway, you might want to explain what you mean exactly. 20180401 19:20:54<+discordbot> @loonycyborg Correction: It does require a password, it's just that it remembers my session. 20180401 19:21:04<+discordbot> yeah 20180401 19:21:05<+discordbot> Now I need a new password. 20180401 19:21:07<+discordbot> it was a cookie 20180401 19:26:36-!- Bonobo [~Bonobo@203.220.138.198] has joined #wesnoth-dev 20180401 19:30:10< vn9711> zookeeper: ok. I played Dark Forecast. I stayed in castle and waited for AI to attack. One of the AI units -- a bat -- flew on impassable terrain to attack one of my units. 20180401 19:30:36< gfgtdf> vn9711: that's explciitly done yb dark_forecasts scripting iirc 20180401 19:30:40< gfgtdf> by* 20180401 19:30:42< zookeeper> yep 20180401 19:31:20< vn9711> so maybe it indeed jumped instead of flying normally?:D Anyway, thanks, clear. 20180401 19:36:53-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20180401 19:36:59< gfgtdf> loonycyborg: how long does it usually take fo the 1.14 wesnothd to notice tha a player/connection is 'dead'? I somehow got dc from another client about 10 minues ago and now i still thee that user in the mp server when i login with another nick. 20180401 19:37:40< loonycyborg> well iterval was quite high 20180401 19:37:49< loonycyborg> it relies on tcp keepalive 20180401 19:38:07-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180401 19:39:28< loonycyborg> did you change ip? 20180401 19:40:09< gfgtdf> no i logged on with a different nick from the same ip. 20180401 19:41:59<+discordbot> gfgtdf Normal, default TCP socket takes about 30 minutes to notice the remote has stopped talking using defaults everywhere. 20180401 19:42:34< gfgtdf> Tad: ok thx 20180401 19:43:45<+discordbot> You could set it up to take about a week, but that would only be needed if you didn't want to lose your connection to Mars. 20180401 19:44:47< gfgtdf> ye let's not do that until there are actualyl people on mars. 20180401 19:45:24<+discordbot> Might as well do PBEM in that case ๐Ÿ˜› 20180401 19:45:40<+discordbot> Even then, I imagine using the Internet with ping of a couple of minutes would be a painful experience. ๐Ÿ˜‰ 20180401 19:46:25<+discordbot> @jyrkive Yes, but a turn-based game like WEsnoth would work. Though Play-by-email would fo better I guess. 20180401 19:47:43<+discordbot> .oO ( Note to self: draft proposal for Elon Musk. ) 20180401 19:48:30<+discordbot> We should have that in marketing. "Are you living in Mars and tired of being utterly crushed every time you try to play Overwatch? Play Wesnoth instead! We have taken your needs into account." ๐Ÿ˜› 20180401 19:49:28< gfgtdf> tad: did you see my comment yesterday? about 36e92900c374b801df133b7221a04014b3b20b84 breaking chatline colors when a player assigns his last side to another players? (#2357) 20180401 19:49:47<+discordbot> Nope. Looking now. 20180401 19:50:52<+discordbot> Ooo, my nickname magically inverted. ๐Ÿ˜‰ 20180401 19:51:18<+discordbot> Still not sure what my username is (in comparison to the nick) and why it shows up in some places but not in others. 20180401 19:51:32<+discordbot> But I don't care all that much either. 20180401 19:52:04<+discordbot> On discord: mattsc 20180401 19:53:03<+discordbot> @mattsc : @shadowm saw our discussion and changed your nickname here on discord ๐Ÿ˜„ 20180401 19:53:29<+discordbot> Your username is Fred, mattsc. 20180401 19:53:30<+discordbot> I know. That's why I put the ๐Ÿ˜‰ behind it. Thanks @shadowm 20180401 19:53:40<+discordbot> https://cdn.discordapp.com/attachments/259976436490829825/430092403056181248/unknown.png 20180401 19:53:43<+discordbot> You made it so for whatever reason. 20180401 19:53:49<+discordbot> But we don't know you as Fred, soooo. 20180401 19:53:55<+discordbot> I can see that, but where does it show up. For example: 20180401 19:54:00<+discordbot> https://cdn.discordapp.com/attachments/259976436490829825/430092487894237185/Screen_Shot_2018-04-01_at_12.52.41.png 20180401 19:54:14<+discordbot> Top right its mattsc, bottom left it's Fred. 20180401 19:54:19<+discordbot> 1) When completing tags; 2) when clicking on your profile. 20180401 19:54:31<+discordbot> For example if you click on mine you'll see shadowm isn't my username. 20180401 19:54:44<+discordbot> @Fred#2694 20180401 19:54:53<+discordbot> I just changed it to Fred to see what would happen. And then it didn't show up anywhere (that I looked, at least), so I forgot to change it back. 20180401 19:55:08<+discordbot> I think someone had already nicknamed you. 20180401 19:56:35<+discordbot> What gets me is on Linux it says I'm Playing Hookey but on Windows and macOS it doesn't say anything. So I wonder if I need to make them all agree so you can't tell when I'm host hopping. 20180401 19:57:09<+discordbot> to me it doesn't say you're plaing hooky 20180401 19:57:10<+discordbot> I see "playing Hooky" for you. I'm on Windows. 20180401 19:57:17<+discordbot> it says ะธะณั€ะฐะตั‚ ะฒ hooky 20180401 19:57:32<+discordbot> And for me, "Pelaa: Hooky" 20180401 19:57:40<+discordbot> mac OS 20180401 19:57:40<+discordbot> https://cdn.discordapp.com/attachments/259976436490829825/430093411945807888/unknown.png 20180401 19:57:41<+discordbot> I see you playing Hookey (on a Mac) 20180401 19:57:55<+discordbot> okay, maybe Hooky 20180401 19:58:16<+discordbot> So it must be my local machines which don't respect what the Linux login says. And yes Hooky is right. 20180401 19:58:28<+discordbot> Anyways, I think I am back to mattsc everywhere now. Thanks all for trying to explain things to me. ๐Ÿ˜› 20180401 19:59:07<+discordbot> Rephrasing things: thanks for explaining things to me and trying to make me understand. 20180401 19:59:37-!- lipkab [~lipk@host-91-147-210-58.biatv.hu] has joined #wesnoth-dev 20180401 19:59:47<+discordbot> I'm going to try to figure out now what the AI does not want to recall units. 20180401 20:00:02<+discordbot> Keep it up and I'll send a requst to the HGU Editors to upgrade you to "Somewhat Harmless" 20180401 20:00:17<+discordbot> Heh! 20180401 20:01:08<+discordbot> The game list is specific to each Discord install. 20180401 20:01:14<+discordbot> It's not synced across devices or platforms. 20180401 20:01:48<+discordbot> I suppose the reason I see it different is I'm on the same login on all platforms. 20180401 20:02:08<+discordbot> /And of course it auto-detects most games without assisnatce of the custom game list.) 20180401 20:02:21< irker767> wesnoth/wesnoth:master Steve Cotton d6661fdb80 THoT S12 Put the sneak-passageway's door AppVeyor: All builds passed 20180401 20:03:09<+discordbot> does it support wesnoth already? 20180401 20:03:14<+discordbot> Never detects any of mine. So I told it /bin/bash was "Hooky" or whatever suits me when I decide to change. 20180401 20:03:30<+discordbot> @loonycyborg Yep, and even detects local builds. 20180401 20:03:46<+discordbot> It detect wesnoth for me 20180401 20:04:12<+discordbot> On Linux game detection works, per se. 20180401 20:04:56<+discordbot> But it doesn't guess the name of the game correctly unless you've got Steam connected to your account and running on the same machine, and then it gets confused the second time you launch the game and falls back to the user-set game list. 20180401 20:04:57<+discordbot> it doesn't detect for me 20180401 20:05:22<+discordbot> if I just run master build 20180401 20:05:23< irker767> wesnoth: pentarctagon wesnoth:master 3f67c2fbf051 / docker/Dockerfile-travis-1604-master utils/travis/steps/install.sh: Create travis dockerfile in the travis script step. https://github.com/wesnoth/wesnoth/commit/3f67c2fbf051aa9e322defb66c782477cd53b8bd 20180401 20:05:26<+discordbot> with steam or anything 20180401 20:05:43<+discordbot> It won't work with the Steam version of Wesnoth. 20180401 20:06:26<+discordbot> OK On Windows it shows my (to myself) playing BfW. Linux stillsays Hooky to me 20180401 20:06:38<+discordbot> Also Wesnoth isn't autodetected, and the entries don't stick around, possibly because it's looking at the window title in addition to the binary path. 20180401 20:07:02<+discordbot> hmm I think they accept user submissions of games to their db 20180401 20:10:15<+discordbot> Doesn't that require having Discord API integration in your app? 20180401 20:10:59<+discordbot> I think they accept manual submissions too 20180401 20:11:07<+discordbot> If you have a link... 20180401 20:11:21<+discordbot> Vultraz has a branch where he was working on that and we told him keep it on hold until 1.14 was branched away. 20180401 20:12:05<+discordbot> If it's helpful in some way related to that and it's not too intrusive it can be merged for 1.14.1 when the noise from the 1.14.0 preparations has subsided. 20180401 20:12:37<+discordbot> And I'm not sure we want to mainline support for one 3rd party app. 20180401 20:13:05<+discordbot> That's part of the "intrusive" aspect of the matter. 20180401 20:13:23<+discordbot> If it just involves detecting a DLL and calling LoadLibrary() or something that's not terribly bad. 20180401 20:13:28<+discordbot> Discord Rich Presence support is a good idea IMO. Just not in such a late stage of 1.14.0 development. 20180401 20:13:30<+discordbot> I'd feel different if it were an addon but we don't support those 20180401 20:13:33<+discordbot> If it involves compile-time linking then MEH. 20180401 20:14:02<+discordbot> https://support.discordapp.com/hc/en-us/articles/217960107-Games-Detection-101 20180401 20:14:15<+discordbot> they recommend sending suggestions to their mail 20180401 20:14:43<+discordbot> via a carrier pigeon though 20180401 20:14:52<+discordbot> That's... not ideal. 20180401 20:15:06<+discordbot> Not because of the joke, but because of the paths point. 20180401 20:15:07<+discordbot> yes, I don't have tame pigeons ๐Ÿ˜ฆ 20180401 20:15:39<+discordbot> My Wesnoth is either in /home/shadowm/bin/wesnoth-1.14 or /home/shadowm/src/wesnoth-1.14/wesnoth or /home/shadowm/src/wesnoth-1.14/wesnoth-debug. 20180401 20:16:02<+discordbot> only chance if it supports regex 20180401 20:16:03<+discordbot> It works fine for nearly all games I play, and I have them in a separate drive (outside of Steam's default path). 20180401 20:16:10<+discordbot> Or /home/shadowm/src/wesnoth-1.14///wesnoth if I use CMake. 20180401 20:17:34<+discordbot> Discord on macOSdoes not detect WEsnoth .. 1.13.13 officual installed in /Applications 20180401 20:17:36< celticminstrel> Wait! According to the wiki, enter hex events are somehow broken!? O.O 20180401 20:17:43 * celticminstrel pokes gfgtdf 20180401 20:17:50< gfgtdf> uh what ? 20180401 20:19:04< gfgtdf> any particular question ? 20180401 20:19:55< celticminstrel> "At the time of writing, if the hex is occupied then $unit contains the occupying unit, not the moving unit" 20180401 20:20:21< celticminstrel> Which also contradicts the preceding note that you can detect an occupied hex by comparing $x1,$y2 to $unit.x,$unit.y. 20180401 20:20:28< gfgtdf> hmm ye that soudns lieka bug, did you test that the bheviour in 1.13.13 is the same? 20180401 20:20:36< celticminstrel> I didn't test, no. 20180401 20:20:57< gfgtdf> ye actualyl i probably wrote that preceeding comment becsaue i do exactly that in my addon (not sure though) 20180401 20:20:57< celticminstrel> It says that was the case for 1.13.11. 20180401 20:21:47< celticminstrel> I call this broken because the content of $unit shouldn't be dependent on conditions like that. 20180401 20:22:10< gfgtdf> ye sounds leik a a bug 20180401 20:22:29< celticminstrel> Will enter hex be triggered by unit creation? 20180401 20:23:47< celticminstrel> ...actually, I think what I originally wanted to do here was a sighted event triggered by an ambush ability, but that was apparently not possible in 1.12. 20180401 20:24:12< gfgtdf> no enter hex is onyl during movement 20180401 20:24:26< celticminstrel> Well, I'll test to see if the wiki is right. 20180401 20:28:10< celticminstrel> Good news: The wiki is wrong. 20180401 20:28:22< celticminstrel> Will edit. 20180401 20:29:09< gfgtdf> well the wiki might still be right since it only claims behviour for wesnoth 1.13.11 20180401 20:29:19< celticminstrel> Ah true. 20180401 20:29:50<+discordbot> Interesting. There's a logic error in AI recruiting/recalling ... 20180401 20:29:53< celticminstrel> Anyway, I had an enter_hex for a specific location which says "$unit.id at $unit.x,$unit.y entered hex $x1,$y1", placed a unit there with create, and moved a unit through the hex. 20180401 20:29:58< celticminstrel> @Mattsc Uh-oh... 20180401 20:30:28< celticminstrel> The message said the id of the moving unit, not the placed unit. 20180401 20:30:29< gfgtdf> ye the lua intercae in that case (wesnoth.current.event_context) also behves as expected just tested 20180401 20:30:36<+discordbot> It can happen that the AI considers a recall to be the best "recruit", but after that it checks whether the recall is worth it. And if that is not the case, the recruiting CA gets blacklisted. 20180401 20:30:44<+discordbot> Which means no recruiting happens either. 20180401 20:31:14<+discordbot> I'll have to think about how to deal with this. 20180401 20:35:59<+discordbot> @loonycyborg Did you upload RC 2 to Steam? 20180401 20:36:08<+discordbot> yup 20180401 20:36:18<+discordbot> Ahh, okay, I was wondering if the 34.3 MB update I'm downloading right now was that. 20180401 20:36:30<+discordbot> It's definitely far more convenient than downloading 400 MB every time. 20180401 20:36:58< celticminstrel> There was a separate 1.13.12 -> 1.13.13 update package? 20180401 20:37:06< celticminstrel> Pretty sure I just downloaded the full thing... 20180401 20:37:12<+discordbot> Vultraz hasn't started working on the RC 2 announcement yet huh. 20180401 20:37:15< celticminstrel> Oh wait, Steam? 20180401 20:37:22<+discordbot> Yes, Steam. 20180401 20:37:23< celticminstrel> RC2 is already on Steam somehow? 20180401 20:37:28<+discordbot> Yes, it is. 20180401 20:37:35<+discordbot> I'm part of a select few with access to it. 20180401 20:37:44< celticminstrel> Ah, okay, only for a few people. 20180401 20:37:55< celticminstrel> I'll stick with the installer for now, then. 20180401 20:38:59< gfgtdf> loonycyborg: i still see my 'dead' nick on the mpserver 20180401 20:38:59<+discordbot> I don't know if there are macOS builds for it yet incidentally. 20180401 20:39:50<+discordbot> btw 20180401 20:40:15<+discordbot> 1.14 server might not have keepalive enabled if it's recently started 20180401 20:40:21< celticminstrel> Even if there were, I won't be playing Wesnoth ever again on this computer. 20180401 20:40:35< gfgtdf> i actuall meant the trunk server sry. 20180401 20:43:22<+discordbot> how will we make mac builds for steam btw? 20180401 20:43:31<+discordbot> give steam access to mac packager too? 20180401 20:43:50<+discordbot> @loonycyborg You'll have to explain to me in the admin IRC channel what that means. I plan to start a 1.14 instance soon. 20180401 20:43:57<+discordbot> We're currently piggybacking on the 1.13 instance. 20180401 21:05:30-!- TC01 [~quassel@venus.arosser.com] has joined #wesnoth-dev 20180401 21:19:42-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 256 seconds] 20180401 21:24:45<+discordbot> @loonycyborg good question... 20180401 21:25:13<+discordbot> @hrubymar10 could you also handle publishing the Steam package? 20180401 21:25:14<+discordbot> I guess I could just rip out binary from mac package 20180401 21:25:21<+discordbot> but not sure if it'll work 20180401 21:25:26<+discordbot> (hypothetically) 20180401 21:26:11<+discordbot> I can if somebody tell me first how to do that 20180401 21:26:35<+discordbot> well I can but I might not know about mac specifics 20180401 21:26:35<+discordbot> and let me try it first. Don't wait until 1.14 release please ๐Ÿ˜„ 20180401 21:26:53<+discordbot> @shadowm my branch had to do with Discord Rich Presence, which basically allows for more info to be displayed on your profile (including Join/Observe buttons to do those things directly from Discord. I didn't touch anything regarding app detection. 20180401 21:27:09<+discordbot> Yes, that's why I want try it before May RELEASE 20180401 21:27:21<+discordbot> @shadowm on a different note, thank you for confirming the updates via steam work ๐Ÿ‘ 20180401 21:28:05<+discordbot> @hrubymar10 do you have a Steam account? 20180401 21:28:08<+discordbot> yes 20180401 21:28:43<+discordbot> ok, I can add you as an account with permissions to upload stuff. 20180401 21:28:55<+discordbot> then loonycyborg can help you with the process 20180401 21:29:18<+discordbot> kk 20180401 21:34:57< celticminstrel> I just noticed Lua's next() function appears to cover the array elements before the non-array elements, is that guaranteed? 20180401 21:35:38<+discordbot> No, it's not. 20180401 21:35:49< celticminstrel> So it was just a fluke> 20180401 21:35:51< celticminstrel> ? 20180401 21:36:07<+discordbot> Even the order in which array elements are enumerated isn't specified. 20180401 21:36:16< celticminstrel> It was quite a simple test table, {1,2,3,[0]=7} 20180401 21:36:35<+discordbot> Most likely an implementation detail of the reference Lua implementation. 20180401 21:36:39< celticminstrel> But iterating over it with next() returned them in the presented order. 20180401 21:37:04<+discordbot> It may even depend on how the table is constructed (e.g. if it has ever been sparse). 20180401 21:37:32< celticminstrel> Okay, so what's the easiest way to make an iterator that's equivalent to ipairs() but returns only the value, not the index? 20180401 21:37:37<+discordbot> Quoting Lua's reference manual: "The order in which the indices are enumerated is not specified, even for numeric indices. (To traverse a table in numerical order, use a numerical for.)" 20180401 21:37:59< celticminstrel> I suppose I could use the coroutine library. 20180401 21:40:07<+discordbot> You could reimplement what ipairs() does internally. Increment the index in every step and test if such a value exists. 20180401 21:40:19< celticminstrel> I'd rather not go that low-level... 20180401 21:40:35<+discordbot> inb4 celmin writes assembly 20180401 21:40:47< celticminstrel> I have written assembly. 20180401 21:41:08< celticminstrel> Though that was for school and didn't really have much practical application (given that it's for a chip that's not used so much anymore). 20180401 21:41:10<+discordbot> ๐Ÿ˜ฎ 20180401 21:41:27< celticminstrel> It was a required course for the CS degree. 20180401 21:49:01< celticminstrel> Come to think of it, there's actually no reason why the split iterators need to be recreated on each loop... so instead of the "yield values" iterator I could instead create a "yield relative locations" iterator... 20180401 21:52:31<+discordbot> looks like I'm going to need to come up with a new parser for help ๐Ÿค” 20180401 21:53:07< celticminstrel> Why? 20180401 21:54:15<+discordbot> it currently chokes on the fact that there's pango markup text and custom markup text='foo' dst='bar' 20180401 21:54:44<+discordbot> Render it verbatim, the formater is parsed and the latter gets rejected. 20180401 21:54:44< celticminstrel> Uh. So what happened to the parser that I wrote which stripped those out? 20180401 21:55:03<+discordbot> Parse it with the latter, and it fails on the former (I think) 20180401 21:55:03< celticminstrel> Did you remove it prematurely? 20180401 21:55:15<+discordbot> Your parser is late-stage parsing 20180401 21:55:25< celticminstrel> What do you mean. 20180401 21:55:30<+discordbot> I'm referring to the parser that parses the output of the topic text generators 20180401 21:55:41<+discordbot> those output an std::string. 20180401 21:55:45< celticminstrel> Just use my parser? 20180401 21:55:50<+discordbot> the first parser parses it to a config 20180401 21:56:06<+discordbot> your parser parses the config and does more parsin 20180401 21:56:08<+discordbot> g 20180401 21:56:11< celticminstrel> I don't see why you have a problem here. I had a parser, it worked, what have you done. 20180401 21:56:18<+discordbot> there are two parsers 20180401 21:56:23<+discordbot> there have always been two 20180401 21:57:32<+discordbot> the first is this thing 20180401 21:57:32<+discordbot> https://pastebin.com/R54a85VG 20180401 21:58:06< celticminstrel> Sure, but why does it not work now when it worked before. 20180401 21:58:29<+discordbot> Error when parsing help markup as WML: Unexpected characters after variable name (expected , or =) at :2 20180401 21:58:50<+discordbot> I think that means it finds no value for the pango markup 20180401 21:58:51< celticminstrel> Oh, wait, it's because you needlessly replaced the old markup with Pango markup. 20180401 21:58:57< celticminstrel> My suggestion: revert that for the time being. 20180401 21:59:02<+discordbot> nein! 20180401 21:59:08< celticminstrel> Just temporarily. 20180401 21:59:25<+discordbot> I've already converted several cases of it on the c++ side too 20180401 21:59:29< celticminstrel> What you've discovered is basically that we can't mix the old and new markup. So don't mix them, just use the old. 20180401 22:00:01< celticminstrel> It was an ill-advised move in the first place TBH. If you just revert it for the time being I expect you'll save yourself a lot of headaches. 20180401 22:00:06<+discordbot> I want to get RID of the help markup.... 20180401 22:00:10< celticminstrel> Yeah, I know. 20180401 22:00:13<+discordbot> Not commit to its use ๐Ÿ˜ 20180401 22:00:20< celticminstrel> That doesn't mean you have to get rid of it now. 20180401 22:00:27< celticminstrel> Leaving it in for the time being is not a commitment to keeping it. 20180401 22:00:48< celticminstrel> That said, if you want to define the new markup, let's discuss it. 20180401 22:01:05< celticminstrel> Then you can remove both parsers probably. 20180401 22:01:09<+discordbot> Right now I need to run get breakfast 20180401 22:01:25< celticminstrel> Or maybe just have the first one replaced with something that converts the new markup into actual Pango markup (for now). 20180401 22:01:47< celticminstrel> It would be really handy if Pango offers some way of "registering" a formatting tag. (I doubt it does though.) 20180401 22:02:07<+discordbot> stevecotton being very helpful 20180401 22:02:14<+discordbot> oh wait, you don't see PR notifs like I do 20180401 22:02:40<+discordbot> celmin: I can't tell, because their documentation is confusing and technical 20180401 22:20:40-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection] 20180401 22:23:33< irker767> wesnoth: Celtic Minstrel wesnoth:move_unit_relative 69807e6af71e / data/lua/wml/move_unit.lua: Allow [move_unit]to_location to take a list of waypoints https://github.com/wesnoth/wesnoth/commit/69807e6af71e55ffe0d333310d2fd2ab1848bd8c 20180401 22:23:43-!- grzywacz [~karol@wesnoth/developer/grzywacz] has quit [Ping timeout: 260 seconds] 20180401 22:25:45-!- lipkab [~lipk@host-91-147-210-58.biatv.hu] has quit [Ping timeout: 256 seconds] 20180401 22:29:55-!- octalot [~steve@178.115.130.95.wireless.dyn.drei.com] has quit [] 20180401 22:32:34< irker767> wesnoth/wesnoth:master Sofartin 35e4a73451 Disaled Spell Checking and bumped to 1.1 AppVeyor: All builds passed 20180401 22:37:13<+discordbot> I've been thinking about this AI recall issue. It's not only a question of how to fix it, but also of what the behavior should be. Let's assume I have an AI side that has no recruit list, but a recall list full of peasants. Recall cost is set to 20. What should the AI be doing? Recall peasants at 20 gold a piece or sit and wait? 20180401 22:37:29<+discordbot> And of course, the answer is: it depends. But what should the default behavior be? 20180401 22:37:37<+discordbot> At the moment it just sits and does nothing. 20180401 22:38:17<+discordbot> And a related question is whether this counts as a feature or a bug. As in, does the 1.14 feature freeze apply to this if we decided it's not the desired behavior? 20180401 22:40:36<+discordbot> Then there is the other issue that an AI side with both recalls and a recruit list sometimes does not even recruit after it finds recalls not to be worth it. 20180401 22:40:47<+discordbot> That's definitely a bug that needs to be fixed. 20180401 22:45:42< gfgtdf> mattsc: changing ai behviour can break umc scenarios and thus it's celarly part of the 'feature freeze' 1.14 20180401 22:47:25< Ravana_> by default AI can expect that recall and recruit list is static, nothing new will become available. And by default having units is better than not having units, especially when they have no upkeep like Peasant. So for default it would make sense to recall them 20180401 22:49:01< celticminstrel> I think that makes sense, yeah. The AI can't predict that its recruits or recalls might change, so IMO it makes more sense for it to assume that the current ones are all it has. 20180401 22:52:18<+discordbot> Right. I'd say the same. But that's not what it currently does. 20180401 22:52:44<+discordbot> And as gfgtdf says, changing that would mean breaking the feature freeze. 20180401 22:53:06<+discordbot> Btw, Peasants was just an example. I actually found the problem in a test with Spearmen. 20180401 22:53:49-!- travis-ci [~travis-ci@ec2-54-81-77-161.compute-1.amazonaws.com] has joined #wesnoth-dev 20180401 22:53:50< travis-ci> wesnoth/wesnoth#17387 (move_unit_relative - 69807e6 : Celtic Minstrel): The build passed. 20180401 22:53:50< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/360994181 20180401 22:53:50-!- travis-ci [~travis-ci@ec2-54-81-77-161.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180401 22:54:11< irker767> wesnoth: Celtic Minstrel wesnoth:move_unit_relative 4930e817784c / changelog.md data/lua/wml/move_unit.lua: Allow [move_unit]dir= to perform relative movements https://github.com/wesnoth/wesnoth/commit/4930e817784c112edb7b743190d9f9adc4c970fb 20180401 22:54:27<+discordbot> But I'd still claim that the fact that the AI does not even recruit in that case, and that this only happens sometimes, and at times randomly, that's a bug that needs to be fixed. 20180401 22:54:50<+discordbot> in that case = if it does not consider recalls worth it, but when there is a recruit list 20180401 22:56:48<+discordbot> So I guess the actions to take are: fix that latter bug in 1.13 and master; and change the default recall behavior in master. 20180401 22:56:52<+discordbot> Any objections? 20180401 22:57:35<+discordbot> (then I have to figure out how to code that, of course ...) 20180401 23:05:39-!- Oebele [~quassel@143.177.58.202] has quit [Remote host closed the connection] 20180401 23:11:03< celticminstrel> I don't have any particular objections, but I'm not sure if even that fix is permitted in feature freeze... 20180401 23:12:07-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180401 23:12:15-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer] 20180401 23:14:19< gfgtdf> it'd be nice if the ai more configurable (or completeley in lua ) so that such things could be fixed by umc addons if needed. 20180401 23:14:46< celticminstrel> Well uh. Technically this almost certainly can be fixed in Lua. 20180401 23:15:33< celticminstrel> Though if it's a bug in the recruitment engine I imagine we want to fix it in C++. 20180401 23:17:31<+discordbot> I thought bug fixes are allowed during a feature freeze? 20180401 23:17:48<+discordbot> Isn't that what we are currently doing? 20180401 23:18:06<+discordbot> Depends on the kind of fix. 20180401 23:18:24<+discordbot> Does it break synchronization? Does it require API changes? 20180401 23:18:35<+discordbot> Does it require moving massive amounts of code around? 20180401 23:18:57<+discordbot> No. On all of that. 20180401 23:19:11<+discordbot> Then it shouldn't be a problem. 20180401 23:19:11<+discordbot> Here's what's happening: 20180401 23:19:33<+discordbot> (I'm kind of busy so I might not read all of the details, sorry.) 20180401 23:19:38-!- stikonas_ is now known as stikonas 20180401 23:19:52<+discordbot> That's why I am summarizing ... 20180401 23:19:58<+discordbot> Assume I have an AI side that has spearmen on the recall list and bowmen on the recruit list. 20180401 23:20:17<+discordbot> Sometime this AI may recruit the bowmen. 20180401 23:20:40<+discordbot> Sometime it will (internally) consider spearmen not worth recalling, and then not recruit bowmen either. 20180401 23:21:09<+discordbot> As in, you can take the same save and run it once and it will do one, and then re-load and do it again and do the other. 20180401 23:21:18<+discordbot> How is that not a bug that should be fixed? 20180401 23:24:49< celticminstrel> It should be fixed. I just don't know for certain if it's freeze-safe. 20180401 23:27:25<+discordbot> For all I know about this, it is. But if anybody knows better, please correct me. 20180401 23:27:45<+discordbot> BTW, the reason why we have not found this before is because it only happens in certain situations. 20180401 23:28:05<+discordbot> For example, if there are also spearmen on the recruit list, this won't happen. 20180401 23:28:29<+discordbot> Or, if it's swordsmen on the recall list, it will also not happen. 20180401 23:28:30<+discordbot> Etc. 20180401 23:40:08< celticminstrel> 1.14 bug: Right-clicking while the context menu is open does absolutely nothing. 20180401 23:41:00< Ravana_> maybe questionable design, but I don't think bug 20180401 23:45:20< loonycyborg> gfgtdf: so on which server was that dead connection again? 20180401 23:45:40< gfgtdf> loonycyborg: it was trunk, let me check whetehr it's still there 20180401 23:46:00< loonycyborg> trunk is the one master branch connects to? 20180401 23:46:19< gfgtdf> the one that 1.13.12+dev connect to (shoudl be the same) 20180401 23:47:01< gfgtdf> loonycyborg: hmm no it's gone now 20180401 23:47:46< gfgtdf> mattsc: it should be fixed, before 1.14 i'd say 20180401 23:48:05< gfgtdf> mattsc: the problem occurs when some old 'relies' on the old behviour 20180401 23:48:45< gfgtdf> s/some old/someone 20180401 23:59:23<+discordbot> Can somebody finally make statement if we are 'Battle for Wesnoth' or 'The Battle of Wesnoth' ? --- Log closed Mon Apr 02 00:00:25 2018