--- Log opened Wed Apr 11 00:00:39 2018 20180411 00:20:04-!- Sirp_ [d040cb0b@gateway/web/freenode/ip.208.64.203.11] has quit [Quit: Page closed] 20180411 00:35:57-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180411 00:36:03-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180411 00:43:36<+discordbot> That's not going to fix the bug, in case you were wondering that. 20180411 00:43:54<+discordbot> 😐 20180411 00:43:57<+discordbot> why not 20180411 00:44:03<+discordbot> I think it's pretty obvious? 20180411 00:44:09<+discordbot> You're assigning a std::string. 20180411 00:44:40<+discordbot> There's no magic there to make it a dynamic translatable string, you're just assigning the result of the translation to it. 20180411 00:45:00< celticminstrel> ??? 20180411 00:45:01<+discordbot> VGETTEXT is assigned to an std::string in many places... 20180411 00:45:27< celticminstrel> What are we talking about? 20180411 00:45:42<+discordbot> Okay, never mind, I thought you were expecting it to magically become a translatable string across the network. 20180411 00:45:55<+discordbot> it's handled on the other end 20180411 00:46:14< celticminstrel> ??? 20180411 00:46:17<+discordbot> Anyway it's not going to magically fix the bug. 20180411 00:46:24<+discordbot> item["label"] = (formatter() << _("Team:") << " " << t_string::from_serialized(side["user_team_name"])).str(); 20180411 00:46:28<+discordbot> The string was already localised prior to assignment. 20180411 00:46:43<+discordbot> I just brought up that the composition is bad for translations. 20180411 00:47:12<+discordbot> Anything that goes _("foo") + bar is bad. 20180411 00:48:01<+discordbot> (I'd expect you to understand the code you're writing prior to committing a patch that claims to attempt to fix the bug, though.) 20180411 00:49:03<+discordbot> Also, an important point here is that to test the patch (which like I said doesn't fix the bug, it's a lateral move) people will need to run a pot-update, then update the translation of that string. 20180411 00:49:29<+discordbot> god dammit 20180411 00:50:31<+discordbot> then I have NFI 20180411 00:50:42<+discordbot> I will have to remain unfixed 20180411 00:50:47< celticminstrel> ... 20180411 00:51:15< celticminstrel> What's the line of code you posted? 20180411 00:51:38<+discordbot> has to do with sending the translated user team name over the network 20180411 00:51:58< celticminstrel> You can't send translated anything over the network. 20180411 00:52:05<+discordbot> yes 20180411 00:52:09<+discordbot> that's why I don't 20180411 00:52:19<+discordbot> Is the value constructed here sent in the first place? 20180411 00:52:22< celticminstrel> And the line you posted is clearly wrong anyway. 20180411 00:52:27<+discordbot> And used? 20180411 00:52:35< irker643> wesnoth: Charles Dang wesnoth:master b0f767bdb505 / changelog.md: Changelog entry for 79072b7c3d7ab662f1ca7bb27aa257bf9fd1a9fe https://github.com/wesnoth/wesnoth/commit/b0f767bdb5056ed2f12c26b5c52157abcf6908b4 20180411 00:52:41<+discordbot> Because if the answer to both of those questions is true, then everyone should see the translated version for the host's language. 20180411 00:53:00<+discordbot> That's marginally better than only ever being able to see the English versions I guess. 20180411 00:53:02<+discordbot> oh, god dammit 20180411 00:53:08<+discordbot> 😐 20180411 00:53:11<+discordbot> sigh 20180411 00:53:19<+discordbot> You aren't being very articulate tonight. 20180411 00:53:39< celticminstrel> If this needs to be sent across the network, you need to send just the number and build the translated string locally with VGETTEXT. 20180411 00:54:29<+discordbot> no, no, no 20180411 00:54:32< irker643> wesnoth: Charles Dang wesnoth:1.14 b0da923cffad / changelog.md: Changelog entry for fa8e301c93df0f576d8f71c3fa0831afe5dbe23b https://github.com/wesnoth/wesnoth/commit/b0da923cffadd3fbf1e199af84662b7ba407c3cd 20180411 00:54:49< celticminstrel> Instead of saying "no, no, no" you could try actually explaining yourself. 20180411 00:55:37<+discordbot> Ok, look at this issue: https://github.com/wesnoth/wesnoth/issues/2040 20180411 00:55:43<+discordbot> specifically, the second point 20180411 00:55:45<+discordbot> Teamname for your former team becomes untranslated and is displayed as "teamname^South" 20180411 00:55:53<+discordbot> this happened after leaving and rejoining a game 20180411 00:55:55<+discordbot> I don't know why! 20180411 00:56:23<+discordbot> my fix was this: 20180411 00:56:24<+discordbot> https://github.com/wesnoth/wesnoth/commit/c795b316c737a404f8bfc445f5674fbee4a39e24 20180411 00:56:34<+discordbot> it seemed to be reasonable 20180411 00:57:09<+discordbot> since connect_engine::user_team_name uses from_serialized. 20180411 00:57:52<+discordbot> the user team here may not necessarily be "Team 1", "Team 2", etc 20180411 00:57:59<+discordbot> that's the fallback in case UMS is off 20180411 00:58:07< celticminstrel> UMS? 20180411 00:58:11<+discordbot> use map settings 20180411 00:58:33<+discordbot> now, that commit above changed the format for the utn string in the connect_engine... 20180411 00:58:38<+discordbot> which was used by mp_staging.. 20180411 00:58:51<+discordbot> wherein this new non-translatable bug is... 20180411 00:58:57<+discordbot> but it also touched mp_join_game... 20180411 00:59:05<+discordbot> but I don't know if it appears there.. 20180411 00:59:13<+discordbot> AND I'm told it's only random maps that are affected 20180411 00:59:46< celticminstrel> Yeah okay, I have no idea... but if it's not fixed the issue should be reopened or something. 20180411 00:59:49<+discordbot> So I have no idea where to look, what could possibly be wrong, and given how confusing this all is I don't really want to go looking 20180411 00:59:54<+discordbot> no, the issue is fixed 20180411 00:59:57<+discordbot> this is a different issue 20180411 01:00:04< celticminstrel> Okay? 20180411 01:00:19< celticminstrel> Well, "or something" still applies. 20180411 01:00:25<+discordbot> I guess I honestly have no idea what the foo^ prefixes to some strings do 20180411 01:00:35<+discordbot> Really? 20180411 01:00:35< celticminstrel> They're just a marker. 20180411 01:00:42<+discordbot> I call it a disambiguation prefix. 20180411 01:00:48<+discordbot> all I know is it went away when using from_serialized 20180411 01:00:52< celticminstrel> A way to distinguish strings that would otherwise be identical, so that they can have different translations. 20180411 01:01:00<+discordbot> yeah, I figured something like that 20180411 01:01:08<+discordbot> You call a DA a "Dark Adept" or a "female^Dark Adept" depending on the unit's gender. 20180411 01:01:29<+discordbot> In Spanish, a vast majority of nouns, adjectives, and articles are gendered. 20180411 01:02:08<+discordbot> So if you used "Dark Adept" for both in the source version, it'd be impossible to translate it differently depending on gender. 20180411 01:02:28<+discordbot> That's just one convenient examples. There are more contrived cases around. 20180411 01:03:07<+discordbot> When you call dsgettext() (however you do it, including through VGETTEXT()), you're asking the game to strip the prefix if there's no translation or the current locale is en_US. 20180411 01:04:15<+discordbot> oh, dsgettext handles that... 20180411 01:04:54<+discordbot> The prefix is also sometimes used as a quick aid for translators. 20180411 01:05:19<+discordbot> For example: src/gui/dialogs/addon/manager.cpp:266: : _("addon_state^Published"); 20180411 01:05:37<+discordbot> It's easier to use this than to include a comment explaining "hey, this refers to one of several possible states for an add-on in the Add-ons Manager". 20180411 01:05:43<+discordbot> honestly, I have no idea why user_team_name handling uses from/to_serialized 20180411 01:05:46<+discordbot> (That'd be done with a // TRANSLATORS: comment) 20180411 01:05:58<+discordbot> all it seems to do is append some marker for the current textdomain 20180411 01:06:26<+discordbot> Here's a more practical example: 20180411 01:06:29<+discordbot> 22:05:09 shadowm@hanacore ~/src/wesnoth git:master % egrep -nRI '"[^\^]+\^Unknown' src src/gui/dialogs/game_cache_options.cpp:137: size_label_->set_label(_("dir_size^Unknown")); src/gui/dialogs/addon/manager.cpp:209: {ADDON_UNKNOWN, N_("addons_of_type^Unknown")}, src/gui/dialogs/addon/manager.cpp:300: s = _("addon_state^Unknown"); src/gui/widgets/addon_list.cpp:130: tx = 20180411 01:06:29<+discordbot> _("addon_state^Unknown"); 20180411 01:06:46<+discordbot> in the entire codebase, the only think that makes use of to/from_serialized is the user_team_name handling 20180411 01:06:48<+discordbot> Can you link me to the code in question? 20180411 01:07:07<+discordbot> it's in multiple places 20180411 01:07:36<+discordbot> I see it. 20180411 01:07:48<+discordbot> game_initialization/connect_engine.cpp:162 is where to_serialized is called... 20180411 01:08:23<+discordbot> and as for from_serialized, well, just grep for it 20180411 01:08:53<+discordbot> the only bit with any clue why it might be needed is in team.cpp 20180411 01:08:55<+discordbot> cpp if(!user_team_name.translatable()) user_team_name = t_string::from_serialized(user_team_name); 20180411 01:08:56<+discordbot> I grepped for both. 20180411 01:09:01<+discordbot> 22:07:21 shadowm@hanacore ~/src/wesnoth git:master % egrep -nRI '(to|from)_serialized' src 20180411 01:10:14<+discordbot> Uhhhh 20180411 01:11:07<+discordbot> What is the bug you're trying to fix now again? 20180411 01:11:07<+discordbot> I seem to recall if it isn't used the disambiguation prefix shows up 20180411 01:11:27<+discordbot> the one where "Team 1" is not translated 20180411 01:11:43<+discordbot> https://github.com/wesnoth/wesnoth/issues/2863 20180411 01:16:49<+discordbot> I'm looking at the most bizarre thing ever. 20180411 01:17:03<+discordbot> If I type "shadowm0" in the MP login dialog, I see "shadowm1". 20180411 01:17:12<+discordbot> If I type "1" at the end, it becomes "shadowm01". 20180411 01:17:42<+discordbot> And by MP login dialog I mean the one you get when your username has a password the game doesn't know yet. 20180411 01:18:01<+discordbot> ..........what the hell 20180411 01:18:12<+discordbot> could this have something to do with the password problem? 20180411 01:18:30<+discordbot> I don't know what password problem you're talking about. 20180411 01:18:41<+discordbot> Enlighten me. 20180411 01:19:27<+discordbot> I wish Gallaecio had left instructions to reproduce #2863. 20180411 01:19:32<+discordbot> https://github.com/wesnoth/wesnoth/issues/2745 20180411 01:20:07<+discordbot> No, because what I'm seeing only happens on master. 20180411 01:20:18<+discordbot> GLORIOUS 20180411 01:20:21<+discordbot> "shadowm0" displays as "shadowm0" on 1.14. 20180411 01:20:46<+discordbot> Do you know how to reproduce #2863? 20180411 01:21:20<+discordbot> i assume just start a game with a random map. though it should happen with any map when UMS off 20180411 01:21:51<+discordbot> I reverted your patch and on the host's (Spanish) side I'm getting the Spanish team names in 2v2 games, and on the second player's (English) side I'm getting the English names. 20180411 01:22:16<+discordbot> now leave the game 20180411 01:22:17<+discordbot> and rejoin it 20180411 01:22:19<+discordbot> And the Spanish name if I switch the joining client to Spanish. 20180411 01:22:24<+discordbot> Who needs to leave and rejoin? 20180411 01:22:25<+discordbot> you'll see the issue the patch was supposed to fix 20180411 01:22:33<+discordbot> the player 20180411 01:22:42<+discordbot> obviously, you dnt have to actually start the game 20180411 01:22:46<+discordbot> Nop,e I don't see the issue. 20180411 01:23:00<+discordbot> But it must be because it's using the scenario's team names. 20180411 01:23:17<+discordbot> the issue happened with scenario team names... 20180411 01:23:39<+discordbot> Not for me, I get the translations for "North Team" and "South Team" or whatever. 20180411 01:23:42<+discordbot> OH 20180411 01:23:42<+discordbot> wait 20180411 01:23:43<+discordbot> >_> 20180411 01:23:47<+discordbot> But I do see the issue with a random map. 20180411 01:23:50<+discordbot> by my path you meant by cmmit earlier 20180411 01:23:52<+discordbot> commit* 20180411 01:23:58<+discordbot> Obviously. 20180411 01:24:00<+discordbot> nevermind. 20180411 01:24:10<+discordbot> https://cdn.discordapp.com/attachments/259976436490829825/433437069990428673/unknown.png 20180411 01:24:16<+discordbot> ok, now what do you see when starting a regular scenario like den of onis with UMS off 20180411 01:24:55<+discordbot> Okay, now "shadowm0" displays just fine. 20180411 01:25:09<+discordbot> What's UMS? 20180411 01:25:15<+discordbot> use map settings 20180411 01:25:41<+discordbot> I'll check later. 20180411 01:26:41<+discordbot> https://cdn.discordapp.com/attachments/259976436490829825/433437703275806730/unknown.png 20180411 01:26:44<+discordbot> This is what I wanted to check. 20180411 01:27:24<+discordbot> I don't know if it's actually transferred that way across the network, but whoever is writing into the network log domain at debug level doesn't appear to be getting the "serialized t_string" value you want to get across. 20180411 01:28:01<+discordbot> I'd be happy to not use the serialization stuff if I knew why it was used in the first place 20180411 01:28:48<+discordbot> I seem to remember we've had weird issues with the utn's translatability in the past... 20180411 01:29:04<+discordbot> I was going to ask a question but I think I'm going to find out the answer myself instead. 20180411 01:29:41<+discordbot> I suppose I should have tested with translations at the time... 20180411 01:29:59<+discordbot> I dunno if I realized I just needed to rename po/ to translations/ to get it to work 20180411 01:30:05<+discordbot> Okay, so I had Map Settings on. 20180411 01:30:19< celticminstrel> That does work, yes, but loading all those po-files is significantly slower. 20180411 01:30:27< celticminstrel> Compared to loading the compiled mo-files. 20180411 01:30:34<+discordbot> (which reminds me, I don't think anyone ever decided anything about by idea of having the game check po/ for translations after translations/) 20180411 01:30:35<+discordbot> 20180410 22:30:20 debug network: Received [1] 31926 segmentation fault wesnoth --log-debug=network 2>&1 | 20180411 01:30:49<+discordbot> This is great. 20180411 01:30:51< celticminstrel> Well, it'd be basically trivial to do, Vultraz. 20180411 01:30:58<+discordbot> celmin: i don't HAVE the mo files 20180411 01:30:58< celticminstrel> In fact you could probably do it without any code changes? 20180411 01:31:10< celticminstrel> By adding a [textdomain] tag in data/_main.cfg 20180411 01:31:26<+discordbot> I saw the translated team names for a split second when not using Use Map Settings with the random map, then the host crashed. 20180411 01:31:31<+discordbot> 😐 20180411 01:31:34< celticminstrel> Though, not sure if it can handle having multiple declarations of the same textdomain... 20180411 01:31:34<+discordbot> what in hell 20180411 01:31:35<+discordbot> Then the joining client got sent EOF byt he server. 20180411 01:31:51<+discordbot> Actually, the host client didn't crash, it also got sent EOF. 20180411 01:32:07<+discordbot> The server just randomly decided to kick us both out. 20180411 01:32:31<+discordbot> @Vultraz So the Use Map Settings path is the one with problems. 20180411 01:32:41<+discordbot> But only when the map is a random map. Do you know what this means? 20180411 01:32:48<+discordbot> I do not know what this means... 20180411 01:32:49<+discordbot> or 20180411 01:32:51<+discordbot> wait 20180411 01:32:51<+discordbot> wait 20180411 01:32:56<+discordbot> The scenario code is broken. 20180411 01:32:59<+discordbot> you said UMS was on AND you had a random map? 20180411 01:33:03<+discordbot> The scenario emitted by the random map generator. 20180411 01:33:16-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20180411 01:33:55<+discordbot> of course.. 20180411 01:33:58<+discordbot> It's either not defining user_team_name and something else is falling back to using team_name for that before sending the WML over the network, or the user_team_name it defines is not translatable. 20180411 01:34:02<+discordbot> cpp if(params_.use_map_settings && user_team_name.empty()) { user_team_name = team_name; } 20180411 01:34:26<+discordbot> this is the fallback to team_name. but team_name is not translated. 20180411 01:34:29<+discordbot> The bug only happens when Use Map Settings is off. 20180411 01:34:37<+discordbot> Ugh. 20180411 01:34:38<+discordbot> when ums is OFF??? 20180411 01:34:43<+discordbot> On I mean. 20180411 01:34:46< celticminstrel> So wait, have we concluded that there's a bug in the default scenario generator? 20180411 01:34:54<+discordbot> ON 20180411 01:34:55<+discordbot> ok 20180411 01:34:59<+discordbot> Yes, on. 20180411 01:35:15<+discordbot> If it's off the host's translated version of the fallback is used for all. 20180411 01:35:37<+discordbot> ok, connect_engine.cpp:117 20180411 01:35:46<+discordbot> can you run that string through dsgettext 20180411 01:35:53<+discordbot> and why does this file not set a GETTEXT_DOMAIN... 20180411 01:36:14< celticminstrel> Probably because it's in the "wesnoth" domain which is the default. 20180411 01:36:17<+discordbot> Focus vultraz. 20180411 01:36:25<+discordbot> What celmin said. 20180411 01:36:54<+discordbot> Oh no. This is bad. 20180411 01:36:56< celticminstrel> Speaking of domains, is there any strong reason not to merge wesnoth and wesnoth-lib on master? The divide seems to be largely arbitrary. 20180411 01:37:07<+discordbot> we can do it 20180411 01:37:13<+discordbot> shadowm has proposed it 20180411 01:37:18<+discordbot> no has done it ye 20180411 01:37:18<+discordbot> Found something else entirely in the process of diagnosing this. 20180411 01:37:28< celticminstrel> I know it has been proposed, I'm wondering if there's arguments against it. 20180411 01:37:42<+discordbot> not of which I know 20180411 01:37:46< celticminstrel> Do I want to know what shadowm has found. 20180411 01:38:06< celticminstrel> Is there an easy way to check if wesnoth and wesnoth-lib contain duplicate strings? 20180411 01:39:58<+discordbot> No idea 20180411 01:44:58-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180411 01:45:04-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180411 01:48:28< celticminstrel> You know, that fishing dialogue for one kid in SotA10 could've been written without duplicating all the kids' messages, because they're exactly the same. All you'd have to do is write id=Carcyn,Shynal rather than using speaker. 20180411 01:48:44< celticminstrel> (Unless of course there's gender problems with those strings.) 20180411 01:51:07<+discordbot> The strings are identical. 20180411 01:51:57< celticminstrel> Yes, they're identical, I just don't know whether it's okay for them to be identical because I have no idea whether these people are both boys or both girls or one of each, plus I'm not sure if the specific content of the strings is reliably gender-neutral in all languages. 20180411 01:52:01<+discordbot> They'll be translated the same no matter what the unit's gender is if you don't actually alter them to be different (e.g. add a female^ prefix like I was explaining earlier. I'm not familiarised with SotA so I have no idea if this is an issue to begin with 20180411 01:52:33<+discordbot> Always assume that prose isn't gender-neutral. 20180411 01:52:58< celticminstrel> IIRC @Vultraz wanted me to cherry-pick the fix for [filter_wml][or] to 1.14, is that okay with you too shadowm? 20180411 01:53:06<+discordbot> (Even if 99% of the time you people assume otherwise and then we have to come up with contrived work-around measures.) 20180411 01:53:23<+discordbot> I don't know what that fix is about and I suspect I don't want to either. 20180411 01:53:27< irker643> wesnoth/wesnoth:1.14 Jyrki Vesterinen cd4bb21c81 Changelog entry for commit f80bc4262194c AppVeyor: All builds passed 20180411 01:54:04<+discordbot> Or whether it's worth, you know, altering the WML API after release candidate #1 to fix it. 20180411 01:54:33< celticminstrel> The alternative IMO is reverting the addition of [filter_wml][or]. 20180411 01:54:58<+discordbot> I haven't even used 1.13.x's WML yet so that's up to the rest of you. 20180411 01:55:25< celticminstrel> Anyway, back to SotA, I can make those strings gender-dependent if you want, assuming the kids are in fact not of the same gender. 20180411 01:55:46< irker643> wesnoth: Celtic Minstrel wesnoth:intl_fixes a9a6804712fe / data/campaigns/Under_the_Burning_Suns/utils/abilities.cfg: Fix #2857 https://github.com/wesnoth/wesnoth/commit/a9a6804712feb7923806784ebb8d751dbd944f3a 20180411 01:55:48< irker643> wesnoth: Celtic Minstrel wesnoth:intl_fixes 1a5ee4dadc22 / data/campaigns/Secrets_of_the_Ancients/scenarios/ (09_Training_Session.cfg 10_Merfolk_Revenge.cfg): Fix 2848 https://github.com/wesnoth/wesnoth/commit/1a5ee4dadc22d4df81d49c96ac90916dd20a6078 20180411 01:56:56<+discordbot> See the thing is that for Spanish line 562 vs. 566 it's not an issue, but it's a coincidence. 20180411 01:57:10<+discordbot> (Assuming they are in fact of different genders.) 20180411 01:57:47<+discordbot> If instead of "I don’t fancy wading in the water to fight these things." it said "I don’t fancy wading in the water to fight these things, I'll get all wet.", then, yes, two different translations would be needed in Spanish to accomodate both genders. 20180411 01:58:16<+discordbot> On the other hand, in Japanese, the "I don’t fancy wading in the water to fight these things." line could be translated differently depending on the gender OR the speaker. 20180411 01:58:38< celticminstrel> Currently trying to determine whether they are of different gender, and noticed a lot of po-comments that don't seem to have been picked up by wmlxgettext. 20180411 01:58:45<+discordbot> Because Japanese has different first person pronouns for different situations, personal preference, AND gender. 20180411 01:59:37<+discordbot> I've been told before that our Japanese translators tend to opt for more neutral (but somewhat stilted-sounding) language in these cases. 20180411 01:59:40< celticminstrel> I assume gender=male is default, in which case they are indeed of different genders. 20180411 02:01:10<+discordbot> random_gender=no and gender=male are the defaults, yes. 20180411 02:02:13<+discordbot> Or rather, the first defined gender variation's gender value is the default. 20180411 02:02:42< celticminstrel> type=Ruffian SotA 20180411 02:04:58< celticminstrel> I feel like the "right away sir are you feeling well" could be left gender-neutral, but I guess it can't hurt to add a female variant there anyway? 20180411 02:05:38<+discordbot> It probably can be left as it is until someone requests otherwise. 20180411 02:06:00< celticminstrel> Alright, I'll stick to the ones that contain personal pronouns then. 20180411 02:06:43<+discordbot> It can't hurt to add a variation for that line, but some translators might assume the differently-gendered entity isn't the first person. 20180411 02:07:14<+discordbot> (Maybe using self_female^ instead of just female^ might be clearer, not sure.) 20180411 02:07:48< celticminstrel> IIRC I used just female^ in the tutorial though. 20180411 02:07:58< celticminstrel> But I guess it can never hurt to be a little more explicit. 20180411 02:09:15< irker643> wesnoth: Charles Dang wesnoth:master a1810bde32a9 / / (4 files in 3 dirs): Game Events/Manager: skip disabled assertion if write_events is called mid-event https://github.com/wesnoth/wesnoth/commit/a1810bde32a95ae00827b5db5ac08f63d9907acb 20180411 02:10:04< irker643> wesnoth: Celtic Minstrel wesnoth:intl_fixes 994a074233fc / data/campaigns/Secrets_of_the_Ancients/scenarios/ (09_Training_Session.cfg 10_Merfolk_Revenge.cfg): Fix gender-dependent strings in SotA involving the kids https://github.com/wesnoth/wesnoth/commit/994a074233fc638a66d100ec5e43c3a1876d084f 20180411 02:10:41< irker643> wesnoth: Charles Dang wesnoth:1.14 1fe396309e10 / / (4 files in 3 dirs): Game Events/Manager: skip disabled assertion if write_events is called mid-event https://github.com/wesnoth/wesnoth/commit/1fe396309e10df46fa7a1524c1473397796b60a9 20180411 02:11:02<+discordbot> hopefully that catches all cases 20180411 02:11:56<+discordbot> (it should fix the OOS one at least) 20180411 02:14:20< irker643> wesnoth: Celtic Minstrel wesnoth:1.14 ebde628e05a3 / changelog.md src/config.cpp: Revert "Accept [and] and [or] in [filter_wml]" https://github.com/wesnoth/wesnoth/commit/ebde628e05a3548fb9bd894e19546d32890f6b1e 20180411 02:21:02< irker643> wesnoth: Celtic Minstrel wesnoth:intl_fixes 0bbf21ec8781 / data/campaigns/Secrets_of_the_Ancients/scenarios/ (09_Training_Session.cfg 10_Merfolk_Revenge.cfg): Fix #2848 https://github.com/wesnoth/wesnoth/commit/0bbf21ec8781714ceb5e57b5d0f09763b507bc57 20180411 02:21:04< irker643> wesnoth: Celtic Minstrel wesnoth:intl_fixes 5876f9bae43a / data/campaigns/Secrets_of_the_Ancients/scenarios/ (09_Training_Session.cfg 10_Merfolk_Revenge.cfg): Fix gender-dependent strings in SotA involving the kids https://github.com/wesnoth/wesnoth/commit/5876f9bae43aad865d0ec35155c4789e389e6ad8 20180411 02:23:08< irker643> wesnoth: Celtic Minstrel wesnoth:master b46381c83a29 / data/campaigns/Under_the_Burning_Suns/utils/abilities.cfg: Fix #2857 https://github.com/wesnoth/wesnoth/commit/b46381c83a290b081cc700c13fc182c88301bebd 20180411 02:23:10< irker643> wesnoth: Celtic Minstrel wesnoth:master 04d51a4b17b9 / data/campaigns/Secrets_of_the_Ancients/scenarios/ (09_Training_Session.cfg 10_Merfolk_Revenge.cfg): Fix #2848 https://github.com/wesnoth/wesnoth/commit/04d51a4b17b9eabb59c077b235e9c952b8890540 20180411 02:23:12< irker643> wesnoth: Celtic Minstrel wesnoth:master 7661c655b07f / data/campaigns/Secrets_of_the_Ancients/scenarios/ (09_Training_Session.cfg 10_Merfolk_Revenge.cfg): Fix gender-dependent strings in SotA involving the kids https://github.com/wesnoth/wesnoth/commit/7661c655b07f739738ef791719b80b8af1c69880 20180411 02:25:28<+discordbot> And master crashes when launching a campaign. 20180411 02:25:41<+discordbot> Apparently there's not enough room in the game window for the story screen UI. 20180411 02:26:09<+discordbot> oh hell 20180411 02:26:39<+discordbot> src/gui/widgets/window.cpp:762 in function 'layout' found the following problem: Failed to size window; wanted size 1255,700 available size 1280,671 screen size 1280,671. 20180411 02:27:21<+discordbot> inb4 "this fixes blah blah by setting the minimum window size to 1280x720" commit pushed to master. 20180411 02:35:41< irker643> wesnoth: Celtic Minstrel wesnoth:fix_2745 983a1c8d92fc / src/preferences/credentials.cpp: Fix #2745 https://github.com/wesnoth/wesnoth/commit/983a1c8d92fcc68a52562230d75ab0173f796981 20180411 02:36:18<+discordbot> wha?? 20180411 02:37:39< celticminstrel> ??? 20180411 02:40:34<+discordbot> Wut. 20180411 02:42:22<+discordbot> how is it that simple 20180411 02:42:39< celticminstrel> Why are you so surprised. 20180411 02:42:54< celticminstrel> Were you thinking "oh it's crypto the solution has to be fiendishly complicated"? 20180411 02:45:54<+discordbot> yes 20180411 02:48:14-!- travis-ci [~travis-ci@ec2-54-156-152-24.compute-1.amazonaws.com] has joined #wesnoth-dev 20180411 02:48:15< travis-ci> wesnoth/wesnoth#17526 (intl_fixes - 1a5ee4d : Celtic Minstrel): The build has errored. 20180411 02:48:15< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/364906679 20180411 02:48:15-!- travis-ci [~travis-ci@ec2-54-156-152-24.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180411 03:02:05< celticminstrel> Hm, for the music bug I'm not sure whether I should be changing playsingle_controller::play_scenario or sound::commit_music_changes or something else... 20180411 03:04:00<+discordbot> latter 20180411 03:04:09<+discordbot> i think 20180411 03:04:47< celticminstrel> ...wait, could this possibly be a WML problem... 20180411 03:04:58<+discordbot> it isn't 20180411 03:05:02< celticminstrel> The reason it doesn't change to a new track is because the current track is play_once. 20180411 03:06:08<+discordbot> we want to override that behavior when entering scenario 20180411 03:06:34< celticminstrel> But why is the current track play_once in the first place? 20180411 03:06:49< celticminstrel> Also, it doesn't really make sense to interrupt the music when you use Back To Turn. 20180411 03:07:50<+discordbot> no idea 20180411 03:07:52<+discordbot> just roll with it 20180411 03:09:02< celticminstrel> The new titlescreen music isn't main_menu.ogg is it? 20180411 03:09:22<+discordbot> return_to_wesnoth.ogg 20180411 03:09:34-!- vn971 [~vasya@94.158.103.15] has quit [Read error: Connection reset by peer] 20180411 03:09:40< celticminstrel> It's not even in the playlist... 20180411 03:09:41-!- vn971 [~vasya@94.158.103.15] has joined #wesnoth-dev 20180411 03:10:05< celticminstrel> By which I mean the playlist defined in [titlescreen_music]. 20180411 03:11:01<+discordbot> what's [titlescreen_msuic]? 20180411 03:11:16< celticminstrel> It defines the tracks that are allowed to play at the titlescreen, I think. 20180411 03:11:25< celticminstrel> I guess the main title theme is handled separately. 20180411 03:11:32< celticminstrel> I can see it's defined in [game_config]. 20180411 03:11:37<+discordbot> yes 20180411 03:14:13-!- vn971 [~vasya@94.158.103.15] has quit [Ping timeout: 256 seconds] 20180411 03:20:04< celticminstrel> Well, I've figured out why the main title theme gets set to play_once, at least - it's because {DEFAULT_PLAYLIST}'s first entry does not have append=yes. 20180411 03:20:22< celticminstrel> (Which makes sense, because you generally don't want to append to a pre-existing playlist.) 20180411 03:20:57<+discordbot> So it is a WML problem then? 20180411 03:21:04< celticminstrel> I wonder if the issue depends on the main title theme currently playing though... 20180411 03:21:18< celticminstrel> Well, it could in theory be fixed in WML, yes. 20180411 03:21:39< celticminstrel> Assuming it does depend on the main title theme currently playing. 20180411 03:22:20< celticminstrel> I'd need a scenario that doesn't use {DEFAULT_PLAYLIST} to test that, I think. 20180411 03:24:09< celticminstrel> Ah, wait. 20180411 03:24:45< celticminstrel> It's play_music_config() that sets play_once on the current track, duh. 20180411 03:25:48< celticminstrel> So basically, when starting or loading a scenario, would we prefer the track is changed immediately? (But if that's what we want on start, we can use immediate=yes.) Or is the issue only with loading? 20180411 03:27:14< celticminstrel> Ah, wait, immediate=yes only works if you want to start with a specific track... 20180411 03:27:42< celticminstrel> Well, I guess I'll look at it more tomorrow... 20180411 03:31:11<+discordbot> For the record, in case this comes up as a subject of discussion later, there is literally no point in allowing backwards compatibility for UtBS with 1.12 saves on 1.14 given the extent of the faction redesign and the implications this has for the campaign's gameplay and story (or so goes the theory for the latter -- see #2854 for a textbook example of how not to do a faction redesign in a consistent fashion). There are times 20180411 03:31:11<+discordbot> when you just have to let go of the past if you don't want to make everything a maintenance nightmare for yourself and whoever comes to replace you if you get hit by a bus. And in this particular case, a campaign is not an API and there are no strong compatibility guarantees between different stable series w.r.t. saves in the first place. 20180411 03:32:57< celticminstrel> Oh, that one, yeah. 20180411 03:33:13< celticminstrel> So are you saying we should remove the old scenarios in 1.14.0? Or in 1.14.1? 20180411 03:33:33<+discordbot> now 20180411 03:33:35<+discordbot> Vultraz knows what I'm saying. 20180411 03:33:57< celticminstrel> I'm just going to assume that means in 1.14.0? 20180411 03:34:10<+discordbot> Also, I just checked that after letting the game advance to a scenario's playlist... loading a different save doesn't change the music to that save's playlist even if there's no overlap between both. 20180411 03:34:13< celticminstrel> That said, if you're doing it, it might be best to merge schema_fixes first in case of conflicts. >_> 20180411 03:35:01<+discordbot> no need, unless you touched the old files 20180411 03:35:08<+discordbot> in which case just discard those changes 20180411 03:35:12< celticminstrel> _main.cfg 20180411 03:35:22< celticminstrel> If I touched _main.cfg there could be conflicts there. 20180411 03:37:16<+discordbot> To elaborate, I loaded AtS E1S1 (knolls.ogg, loyalists.ogg), let the game advance from return_to_wesnoth.ogg into knolls.ogg, then loaded UtBS scenario 1 (elf-land.ogg, revelation.ogg, nunc_dimittis.ogg, elvish-theme.ogg). knolls.ogg kept playing until it finally finished and then the game selected nunc_dimittis.ogg. 20180411 03:37:52<+discordbot> (Loaded both via turn saves.) 20180411 03:38:40< irker643> wesnoth: Charles Dang wesnoth:master 1068ca128c0e / data/campaigns/Under_the_Burning_Suns/ (378 files in 5 dirs): UtBS: removed old Desert Elves and accompanying scenarios and loading code https://github.com/wesnoth/wesnoth/commit/1068ca128c0e50f09cfc77effafde98aa678b251 20180411 03:40:31<+discordbot> schema_fixes does not touch _main.cfg 20180411 03:40:31< irker643> wesnoth: Charles Dang wesnoth:1.14 cbedd09ec2bd / data/campaigns/Under_the_Burning_Suns/ (378 files in 5 dirs): UtBS: removed old Desert Elves and accompanying scenarios and loading code https://github.com/wesnoth/wesnoth/commit/cbedd09ec2bd0d121e1deb38e3600f1e042032b7 20180411 03:40:37<+discordbot> (I checked) 20180411 03:54:52-!- travis-ci [~travis-ci@ec2-54-198-123-118.compute-1.amazonaws.com] has joined #wesnoth-dev 20180411 03:54:53< travis-ci> wesnoth/wesnoth#17532 (intl_fixes - 5876f9b : Celtic Minstrel): The build passed. 20180411 03:54:53< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/364912536 20180411 03:54:53-!- travis-ci [~travis-ci@ec2-54-198-123-118.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180411 03:57:29< celticminstrel> @Vultraz I think you forgot to remove a comment about how loading saves should still work? 20180411 03:57:46<+discordbot> Heh 20180411 03:57:52<+discordbot> I’ll double check 20180411 03:58:29< celticminstrel> Hmm, maybe I should adopt the UTBS_INCLUDE approach for BCoA... 20180411 03:58:48< celticminstrel> I guess the idea is to make it minimally dependent on the name of the containing folder. 20180411 04:03:01<+discordbot> That was the point 20180411 04:03:17< celticminstrel> Kinda wanted to check in again with gfgtdf before merging 2793, but I think if he doesn't show up tomorrow I may merge it anyway. 20180411 04:04:00< celticminstrel> FTR I've decided to put the schema branch on hold until May. 20180411 04:04:30< celticminstrel> Since the chief goal of getting it done before 1.14.0 has been accomplished. 20180411 04:04:51< celticminstrel> And there's still a number of things to do on the branch. 20180411 04:05:38< celticminstrel> ...@Vultraz... why is #994 still open...? 20180411 04:05:42<+discordbot> But you will merge fixes yes? 20180411 04:06:21< celticminstrel> I'll merge the schema_fixes branch to 1.14 if that's what you mean... or are you asking me to also merge its equivalent to master? 20180411 04:06:37<+discordbot> Now it’s not 20180411 04:06:54<+discordbot> No I’m asking you to merge it for 1.14 20180411 04:07:13< celticminstrel> Yeah, I just said a minute ago that I'll likely do it tomorrow. 20180411 04:07:23< celticminstrel> I guess maybe you didn't make the connection that 2793 = schema_fixes. 20180411 04:08:19< celticminstrel> Regarding 2854... do the Quenoth not have any blonde hair anymore? 20180411 04:09:56<+discordbot> Nym does for some bizarre reason. 20180411 04:10:49<+discordbot> I guess it's not any weirder than Kaleh having the wrong skin and hair colours on his portrait compared to his sprite. 20180411 04:12:06<+discordbot> I wonder if perhaps we should repurpose jetrel's sprite for the fighter for kaleh 🤔 (he'd need to be given his sword, of course) 20180411 04:12:18< celticminstrel> No idea! 20180411 04:12:35< celticminstrel> It's the sprite that's old, not the portrait? 20180411 04:13:02<+discordbot> the sprite is "new" 20180411 04:13:05<+discordbot> it's by kwandulin 20180411 04:13:21<+discordbot> (kaleh's) 20180411 04:15:11<+discordbot> https://github.com/wesnoth/wesnoth/commit/ce363f491d8c5f47476d91aa709c2dc56ea97c0b?short_path=f553dd6#diff-f553dd6f642853064c45d638bcb2af84 20180411 04:15:31<+discordbot> see the fighter sprite 20180411 04:15:38< celticminstrel> And the portrait is the original terrible one? 20180411 04:15:49<+discordbot> what????? 20180411 04:15:56<+discordbot> we're talking about sprites 20180411 04:15:59< celticminstrel> For Kaleh. 20180411 04:16:09< celticminstrel> Shadowm was talking about the sprite and portrait not matching. 20180411 04:16:17<+discordbot> the portrait is the original 20180411 04:16:31<+discordbot> which, incidentally, remained the campaign icon until my above commit 😐 20180411 04:16:57< celticminstrel> I don't think that's the portrait? 20180411 04:17:04< celticminstrel> Well, if the sprite matches the rest of the sprites, I don't really see a reason to change it now. 20180411 04:17:18< celticminstrel> That is, I don't see a reason to change it at this time. 20180411 04:17:18<+discordbot> what??? 20180411 04:17:23< celticminstrel> ... 20180411 04:17:47<+discordbot> I want to change it because it's never good to let art by jetrel go to waste and honestly kwandulin's sprites aren't the highest quality. 20180411 04:17:51<+discordbot> they're somewhat frankens 20180411 04:17:58< celticminstrel> Uh. 20180411 04:18:22< celticminstrel> But isn't your substitute proposal also a franken? You said you'd take the fighter sprite and splice in the sword. 20180411 04:18:37<+discordbot> he'd need to have a sword properly drawn in 20180411 04:18:52< celticminstrel> But even so, it's still the same sprite as the fighter? 20180411 04:19:01<+discordbot> no! 20180411 04:19:25< celticminstrel> That's so helpful. 20180411 04:19:27<+discordbot> jetrel's fighter was replaced by a new fighter by doofus since jet never completed the whole line and doofus was doing so 20180411 04:19:35< celticminstrel> Ah, I see. 20180411 04:19:42<+discordbot> I'm proposing using jetrel's fighter for kaleh so it doesn't go to waste 20180411 04:20:04<+discordbot> except enswordened 20180411 04:20:20< celticminstrel> So this one? https://raw.githubusercontent.com/wesnoth/wesnoth/0100e3a9f7a95872cd7f9a1f44e4c9c14a6a0c0f/data/campaigns/Under_the_Burning_Suns/images/units/quenoth/fighter.png 20180411 04:21:18<+discordbot> oui 20180411 04:22:01< celticminstrel> Gives off more of a Nym than Kaleh feel to me, but I suppose you could even use it for both of them (maybe recolour Nym's hair red or blond). 20180411 04:22:15<+discordbot> nym, eh? 20180411 04:22:52< celticminstrel> The clothes also don't seem to match well with others, but... this is the leader, so maybe that's even a good thing? I dunno. 20180411 04:23:27<+discordbot> doofus did not go with jetrel's design 20180411 04:23:35<+discordbot> that's why the beast rider guy looks so different 20180411 04:23:41<+discordbot> jetrel did that one 20180411 04:23:57< celticminstrel> Which beast rider? There are two. 20180411 04:24:03<+discordbot> dunno 20180411 04:24:08<+discordbot> one of them is the original 20180411 04:24:11< celticminstrel> Though only one is in the commit you linked. 20180411 04:24:12< celticminstrel> ... 20180411 04:24:15<+discordbot> though, jet migh have dne the further edits 20180411 04:24:22< celticminstrel> No, I mean, which beast. 20180411 04:24:24<+discordbot> oh, no 20180411 04:24:25<+discordbot> not those 20180411 04:24:34<+discordbot> jet did do edits to those mounts 20180411 04:24:46< celticminstrel> So you're talking about the bovine beast? 20180411 04:24:47<+discordbot> I meant the rider 20180411 04:24:53<+discordbot> yes 20180411 04:25:07< celticminstrel> What's the word for deerline... cervine or something... 20180411 04:25:11< celticminstrel> ^deerlike 20180411 04:25:20<+discordbot> not the deer ones 20180411 04:25:27<+discordbot> seriously, go look in the image folder 20180411 04:25:31< celticminstrel> To me they look like gazelles. 20180411 04:25:42< celticminstrel> Yeah I can't be bothered looking in the folder right now. 20180411 04:25:56< celticminstrel> It's really bedtime anyway. 20180411 04:26:04<+discordbot> https://cdn.discordapp.com/attachments/259976436490829825/433482845638623232/kaleh.png 20180411 04:26:09<+discordbot> this is current kaleh 20180411 04:26:20<+discordbot> i mean, it's not bad 20180411 04:26:24< celticminstrel> Seems pretty decent. 20180411 04:26:28<+discordbot> indeed 20180411 04:26:34< celticminstrel> Though I have to wonder why the hair is purple. 20180411 04:26:37< celticminstrel> :P 20180411 04:26:39<+discordbot> likewise 20180411 04:26:59<+discordbot> apparently kaleh and nym suffer from anime protagonist syndrome 20180411 04:27:12< celticminstrel> But then, use of purple doesn't mean it's literally purple, so whatever (purple can be used as a highlight for black after all). 20180411 04:27:20< celticminstrel> Haha 20180411 04:27:38<+discordbot> "ELOH! OMAE MOU WA SHINDERU!" 20180411 04:27:48<+discordbot> "NANI!" 20180411 04:27:57< celticminstrel> I think I even kinda understand that. >_> 20180411 04:28:19<+discordbot> "SHINDEKUDASAIIIIII!!!" 20180411 04:28:32<+discordbot> (you should understand it, it's a meme 😛 ) 20180411 04:28:45< celticminstrel> Never expect me to get memes. Never. 20180411 04:28:52< celticminstrel> If I get them, just consider it a nice bonus. 20180411 04:29:17<+discordbot> heh 20180411 04:30:47<+discordbot> so would you rather we stick with kaleh 20180411 04:31:22< celticminstrel> I don't really have any strong preference, but if the sprites we have are good, I don't think we really need to change them at this time. 20180411 04:31:28< celticminstrel> Focus on more important things, basically. 20180411 04:32:00<+discordbot> Do I need to look at the backlog for the conversation I missed or is "Vultraz discusses memes in the dev channel again" an accurate summary of what just took place? 20180411 04:32:23< celticminstrel> Well, there was that, and also proposals for changing Kaleh's sprite. 20180411 04:41:41-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The computer falls into a deep sleep, to awake again some other day!] 20180411 04:59:13-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev 20180411 04:59:26-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Client Quit] 20180411 05:09:54-!- boucman [~rosen@221.86.207.77.rev.sfr.net] has joined #wesnoth-dev 20180411 05:09:56-!- boucman [~rosen@221.86.207.77.rev.sfr.net] has quit [Changing host] 20180411 05:09:56-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev 20180411 05:28:52<+discordbot> I'm trying out Visual Studio Code... there's no insert/overwrite toggle behaviour when pressing Insert on my keyboard? 20180411 05:33:15-!- vn971 [~vasya@94.158.103.15] has joined #wesnoth-dev 20180411 05:39:16< vn971> Interesting. I had internet connection DC and wesnoth-1.14 left running in background, logged into MP lobby. Now when I got back to the wesnoth client, it showed as I was still in the lobby, even though 2 hours passed without connection. When I pressed Preferences button from lobby screen, the client exited immediately. There was also this in the log, which I don't know how to interpret at all: https://gist.github.com/vgaming/0b347c 20180411 05:39:17< vn971> 2c88af86a8cd5ac84f7a2ec74d 20180411 05:39:52<+discordbot> Well, that's literally a link and a half. 20180411 05:40:11< vn971> The log in the middle says something about... X communication error? o_O 20180411 05:40:26<+discordbot> (Meaning that IRC's line length caused your client to send it in two halves.) 20180411 05:40:27< vn971> shadowm: must be IRC message length thing. https://gist.github.com/vgaming/0b347c2c88af86a8cd5ac84f7a2ec74d 20180411 05:41:00<+discordbot> The X11 error is unrelated. 20180411 05:41:45<+discordbot> And also it indicates that something had a problem with something about your monitor set-up changing in the meantime (did you plug or unplug a monitor?). 20180411 05:41:58-!- travis-ci [~travis-ci@ec2-54-226-151-214.compute-1.amazonaws.com] has joined #wesnoth-dev 20180411 05:41:59< travis-ci> wesnoth/wesnoth#17535 (fix_2745 - 983a1c8 : Celtic Minstrel): The build passed. 20180411 05:41:59< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/364915633 20180411 05:41:59-!- travis-ci [~travis-ci@ec2-54-226-151-214.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180411 05:42:13< vn971> Should I make it an issue in the bug tracker? IDK what I'd write really, not clear what to reproduce exactly and what do I want specifically. 20180411 05:43:00< vn971> shadowm: I don't think I've unplugged. It was an external monitor. The monitor may have put itself to sleep, this I'm not sure about. 20180411 05:43:15-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection] 20180411 05:43:21<+discordbot> Then your driver might not be handling that event properly. 20180411 05:43:47< vn971> shadowm: I mean, I didn't plug a monitor, unplug it or change monitor settings whatsoever, except the possibility of the monitor going to sleep. 20180411 05:43:58< vn971> shadowm: could be, to be honest. 20180411 05:45:38<+discordbot> Anyway, the error doesn't come from Wesnoth, I can say that much. Wesnoth doesn't talk to X11 directly right now, and the only things it asks from SDL after initialization that could be relevant here is your display configuration -- that last part could trip a bug in SDL or your display driver since Preferences needs to enumerate all possible resolutions. 20180411 05:45:40< vn971> I'd leave the Xorg error as is, but IDK what to do with wesnoth client thinking it's still online after 2 hours. By default I think I won't raise issue too because I can't formulate what exactly I'd expect instead. 20180411 05:46:15<+discordbot> I have observed the issue with Wesnoth not realising it's disconnected from the server but I do not know if it's a known bug or if it's even fixable. 20180411 05:46:28< vn971> shadowm: ah, interesting. Maybe it's indeed something about Preferences specifically that triggered some underlying bug. 20180411 05:46:31<+discordbot> (I mean, fixable without redoing the network protocol.) 20180411 05:55:05<+discordbot> gfgtdf: You forgot to document bar_offset_x/y on the wiki it seems. 20180411 06:15:26-!- gallaecio [~quassel@38.red-83-46-126.dynamicip.rima-tde.net] has joined #wesnoth-dev 20180411 06:28:05<+discordbot> @jyrkive was my workaround for the assertion in write_events triggering at inappropriate times acceptable? 20180411 06:29:24<+discordbot> Yes, I think so. We haven't had any reports about the assertion firing in any other way, so I think we have found all the ways it can occur. 20180411 06:29:51<+discordbot> annnd I just noticed I messed up the comment >_> 20180411 06:41:32-!- irker643 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout] 20180411 06:41:38-!- irker509 [~irker@uruz.ai0867.net] has joined #wesnoth-dev 20180411 06:41:38< irker509> wesnoth: Charles Dang wesnoth:master 4b6e5478be32 / src/game_events/manager.cpp: Fixup a1810bde32a95 (better comment) https://github.com/wesnoth/wesnoth/commit/4b6e5478be3293794e030d7f63071a13fecbb0b1 20180411 06:42:17<+discordbot> something when wrong -> something went wrong 20180411 06:42:30<+discordbot> (╯°□°）╯︵ ┻━┻ 20180411 06:44:09< irker509> wesnoth: Charles Dang wesnoth:master 607bc4c935be / src/game_events/manager.cpp: Fixup 4b6e547 because apparently I cannot write https://github.com/wesnoth/wesnoth/commit/607bc4c935beaa698d5985eafc5074fbe41bbf37 20180411 06:44:21<+discordbot> ┬─┬ ノ( ゜-゜ノ) 20180411 06:56:41< irker509> wesnoth/wesnoth:master Charles Dang b0f767bdb5 Changelog entry for 79072b7c3d7ab662f1ca AppVeyor: All builds passed 20180411 07:37:07-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180411 07:42:09-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20180411 07:42:50-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180411 07:51:06<+discordbot> I don't understand issue #2865. 20180411 07:51:28<+discordbot> I only see and interact with the Difficulty selection dialog once. 20180411 07:51:34-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20180411 07:51:46<+discordbot> Ohhh. 20180411 07:52:09-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180411 07:59:11-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20180411 07:59:48-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180411 08:00:06-!- octalot [~steve@213-225-13-31.nat.highway.a1.net] has joined #wesnoth-dev 20180411 08:01:23-!- octalot [~steve@213-225-13-31.nat.highway.a1.net] has quit [Client Quit] 20180411 08:02:55< irker509> wesnoth: Iris Morelle wesmere:develop 2b60c18709c2 / static/bits/downloads.js: home: Account for there being 0 or 1 release branches https://github.com/wesnoth/wesmere/commit/2b60c18709c2fbaf4c2705311e69f63d86f6dd51 20180411 08:05:37< irker509> wesnoth: Martin Hrubý (hrubymar10) wesnoth:opengl f4e0934ac5b9 / projectfiles/Xcode/Wesnoth.xcodeproj/project.pbxproj: Fix Xcode project after 3e96a3aa2c357c539c255dbe8b431f6857f8170a https://github.com/wesnoth/wesnoth/commit/f4e0934ac5b9cb51c6ea75bd2529f8edec8eef4a 20180411 08:32:14< irker509> wesnoth/wesnoth:intl_fixes Celtic Minstrel 994a074233 Fix gender-dependent strings in SotA inv AppVeyor: All builds passed 20180411 08:41:47-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180411 08:42:15-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 246 seconds] 20180411 08:56:55-!- grzywacz [~karol@89-70-226-147.dynamic.chello.pl] has joined #wesnoth-dev 20180411 09:40:41-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180411 09:40:48-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180411 09:45:29-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180411 09:45:59-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 268 seconds] 20180411 10:45:08< irker509> wesnoth/wesnoth:1.14 Celtic Minstrel 0eeedc8cdd Fix gender-dependent strings in SotA inv AppVeyor: All builds passed 20180411 11:08:44-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180411 11:08:51-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180411 12:02:13<+discordbot> @Ravana can you see if https://github.com/wesnoth/wesnoth/pull/2870 fixes the password issue 20180411 12:03:43<+discordbot> @Pentarctagon If you can build the PR above and test it, it would be appreciated. 20180411 12:18:52< Ravana_> not really, can't compile on windows 20180411 12:20:12<+discordbot> AFAIK, the bug isn't Windows-specific. 20180411 12:31:41<+discordbot> I tried, but couldn't connect to the MP server at the time 20180411 12:33:10<+discordbot> seems to work now though 20180411 12:33:34<+discordbot> so, the bug is fixed? 20180411 12:34:29<+discordbot> looks like it 20180411 12:38:43< irker509> wesnoth/wesnoth:1.14 Charles Dang cbedd09ec2 UtBS: removed old Desert Elves and accom AppVeyor: vs2015/Release Failed 20180411 12:38:44< irker509> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-1.14-2578 20180411 13:33:59-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20180411 13:55:41< irker509> wesnoth/wesnoth:fix_2745 Celtic Minstrel 983a1c8d92 Fix #2745 AppVeyor: All builds passed 20180411 13:56:21-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20180411 14:01:27< irker509> wesnoth/wesnoth:master Charles Dang 607bc4c935 Fixup 4b6e547 because apparently I canno AppVeyor: vs2015/Release Failed 20180411 14:01:28< irker509> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-2580 20180411 14:11:57-!- vn971 [~vasya@94.158.103.15] has quit [Read error: Connection reset by peer] 20180411 14:28:35-!- vn971 [~vasya@94.158.103.15] has joined #wesnoth-dev 20180411 14:40:36-!- Oebele [~quassel@143.177.58.202] has joined #wesnoth-dev 20180411 15:32:06-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180411 15:37:06-!- atarocch [~atarocch@109.112.10.51] has joined #wesnoth-dev 20180411 15:39:16-!- atarocch [~atarocch@109.112.10.51] has quit [Client Quit] 20180411 15:39:34-!- atarocch [~atarocch@109.112.10.51] has joined #wesnoth-dev 20180411 15:45:44-!- gallaecio [~quassel@38.red-83-46-126.dynamicip.rima-tde.net] has quit [Remote host closed the connection] 20180411 15:45:54-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180411 15:47:16-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 245 seconds] 20180411 15:49:54-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20180411 15:50:29-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180411 15:56:48< irker509> wesnoth: Jyrki Vesterinen wesnoth:1.14 b72d6ae37da3 / changelog.md players_changelog.md: Revert "Changelog entry for commit f80bc4262194c161c95aa1ffb83ee7f73df4f73d" https://github.com/wesnoth/wesnoth/commit/b72d6ae37da37a706eb0470ed01a43e6dfa2a8db 20180411 15:56:50< irker509> wesnoth: Jyrki Vesterinen wesnoth:1.14 0fdb4614e0f6 / src/events.cpp: Revert "Fix #1736: on GNU/Linux, a hotkey can trigger multiple commands" https://github.com/wesnoth/wesnoth/commit/0fdb4614e0f60a673277afea28459cbb7a3febc8 20180411 15:59:19< irker509> wesnoth: Jyrki Vesterinen wesnoth:master 2562a7e3b008 / changelog.md players_changelog.md: Revert "Changelog entry for commit c42401a8deb92acc16039fbeed0acf16287e286c" https://github.com/wesnoth/wesnoth/commit/2562a7e3b008a9e349a2f5ce3f215dae62bf9958 20180411 15:59:21< irker509> wesnoth: Jyrki Vesterinen wesnoth:master 934f0326d85c / src/events.cpp: Revert "Fix #1736: on GNU/Linux, a hotkey can trigger multiple commands" https://github.com/wesnoth/wesnoth/commit/934f0326d85c90b7b0250f38365f56073540e357 20180411 16:01:05<+discordbot> You found it broke certain keys? 20180411 16:01:42<+discordbot> Celticminstrel spotted the problem: https://github.com/wesnoth/wesnoth/commit/c42401a8deb92acc16039fbeed0acf16287e286c#commitcomment-28511454 20180411 16:01:44-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20180411 16:02:54<+discordbot> Yeah, that... 20180411 16:03:33<+discordbot> I really wish I understood why all this hockey business is so shaky >_< it shouldn’t be this complicated... 20180411 16:04:11<+discordbot> Wesnoth is probably the only piece of software in the world that attempts to use text input events for hotkeys. 20180411 16:05:15<+discordbot> I still don’t understand why, despite it having been explained several times and my own efforts to understand it. 20180411 16:05:37<+discordbot> We did fine in 1.12 without text input 20180411 16:05:48<+discordbot> And if other apps also work without it, why need we 20180411 16:06:55<+discordbot> IIRC, the problem was that Wesnoth displayed some hotkeys incorrectly and refused to bind some keys as hotkeys. 20180411 16:07:03<+discordbot> (What even is text input for anyway) 20180411 16:07:12<+discordbot> (Onscreen keyboards?) 20180411 16:07:13<+discordbot> Still, using text input for hotkeys is definitely a wrong fix IMHO. 20180411 16:08:09<+discordbot> The primary purpose for text input events is, obviously, text input. Text boxes and the like. 20180411 16:08:37<+discordbot> They work much more reliably when the game doesn't attempt to map key events to text on its own. 20180411 16:08:56<+discordbot> Then perhaps we need rethink our approach 20180411 16:09:09<+discordbot> If we had manpower to deal with it... 20180411 16:09:14<+discordbot> It feels like we’re building on a foundation of sand here. 20180411 16:09:24<+discordbot> There have been how many hotkey bugs? 20180411 16:12:07<+discordbot> If not using text input means certain keys can be hotkeys, I don’t see that as a huge deal. 20180411 16:14:59-!- gallaecio [~quassel@57.99.79.188.dynamic.jazztel.es] has joined #wesnoth-dev 20180411 16:16:26<+discordbot> BUT 20180411 16:17:17<+discordbot> Regardless, it’s too late to toss text input for 1.14, so we do need to find a workaround ... 20180411 16:17:56<+discordbot> As I said in the comment below, my plan is to have a queue of events in the hotkey manager itself, and drop duplicate events there. 20180411 16:18:21<+discordbot> (This is when I tend to refactor: when I have no other choice.) 20180411 16:18:52<+discordbot> 👍 20180411 16:19:35-!- iwaim [~iwaim@rasteenie.alib.jp] has quit [Ping timeout: 240 seconds] 20180411 16:21:09-!- travis-ci [~travis-ci@ec2-54-166-6-76.compute-1.amazonaws.com] has joined #wesnoth-dev 20180411 16:21:10< travis-ci> wesnoth/wesnoth#17538 (1.14 - 0fdb461 : Jyrki Vesterinen): The build was broken. 20180411 16:21:10< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/365192062 20180411 16:21:10-!- travis-ci [~travis-ci@ec2-54-166-6-76.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180411 16:23:01<+discordbot> Unlikely that my revert would have broken the tests. 20180411 16:23:07<+discordbot> It's much more likely https://github.com/wesnoth/wesnoth/commit/cbedd09ec2bd0d121e1deb38e3600f1e042032b7 20180411 16:23:52<+discordbot> Why? 20180411 16:23:56<+discordbot> That’s wml 20180411 16:24:32<+discordbot> You can break the game with WML changes, too. 20180411 16:24:52<+discordbot> error preprocessor: Macro/file 'campaigns/Under_the_Burning_Suns/units/elves/Kaleh.cfg' is missing 20180411 16:24:54<+discordbot> And we know that the build preceding that commit passed. 20180411 16:25:20<+discordbot> Is that the error you're discussing? I've been seeing it for a couple/three hours. 20180411 16:25:39<+discordbot> Maybe. I didn't look closer at the log. 20180411 16:25:45<+discordbot> From whence? 20180411 16:26:26<+discordbot> That message? From Travis' most recent failure. I've been play-testing and the tutorial went fine. But my local wml tests agree on the failure 20180411 16:26:41< irker509> wesnoth/wesnoth:1.14 Celtic Minstrel 2a842b67bb Fix #2745 AppVeyor: All builds passed 20180411 16:27:15<+discordbot> No, what’s including it 20180411 16:27:40<+discordbot> at scenario-test.cfg:12 included from _main.cfg:56 20180411 16:28:28<+discordbot> Oh, I see 20180411 16:28:46<+discordbot> Ok, Tje tests need to be updated 20180411 16:29:04<+discordbot> I guess I’ll do it tomorrow 20180411 16:29:24<+discordbot> What needs changing? 20180411 16:29:48-!- travis-ci [~travis-ci@ec2-54-226-151-214.compute-1.amazonaws.com] has joined #wesnoth-dev 20180411 16:29:49< travis-ci> wesnoth/wesnoth#17539 (master - 934f032 : Jyrki Vesterinen): The build was broken. 20180411 16:29:49< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/365193232 20180411 16:29:49-!- travis-ci [~travis-ci@ec2-54-226-151-214.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180411 16:33:06<+discordbot> References to the old units need to be changed 20180411 16:33:25<+discordbot> Ie, the new file is Quenoth/youth.cfg 20180411 16:33:43<+discordbot> And his unit type is Quenoth Youth 20180411 16:34:29<+discordbot> OK. Well since I don't know what changed I guess it's best to leave it until you arise and get to it. 20180411 16:44:28-!- atarocch [~atarocch@109.112.10.51] has quit [Ping timeout: 265 seconds] 20180411 16:46:26<+discordbot> @zookeeper you must do something about the horse references 20180411 16:50:49-!- Oebele [~quassel@143.177.58.202] has quit [Remote host closed the connection] 20180411 16:58:20-!- iwaim [~iwaim@2001:2c0:40e:2002:0:4:14:80] has joined #wesnoth-dev 20180411 17:09:24< zookeeper> @Vultraz, the only thing that can be done is removing all strings referencing horses, naturally. not so good. 20180411 17:14:17< zookeeper> anyway, since you might ask about the story images next; yes, i was planning on getting them in tonight. 20180411 17:14:31< zookeeper> well, s/was/am even. 20180411 17:38:43< irker509> wesnoth/wesnoth:1.14 Charles Dang cbedd09ec2 UtBS: removed old Desert Elves and accom AppVeyor: 2/4 builds failed 20180411 17:38:44< irker509> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-1.14-2578 20180411 17:38:45< irker509> Details vs2017/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-1.14-2287 20180411 17:58:13-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev 20180411 18:12:53< irker509> wesnoth/wesnoth:1.14 Jyrki Vesterinen 0fdb4614e0 Revert "Fix #1736: on GNU/Linux, a hotke AppVeyor: vs2015/Release Failed 20180411 18:12:54< irker509> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-1.14-2582 20180411 18:26:22< zookeeper> humm. i don't recall messages with a shroud/fog/etc-hidden speaker scrolling to that speaker before. 20180411 18:29:42<+discordbot> don't recall that, either, and think it definitely should not scroll at all else it gives away where to look 20180411 18:29:56<+discordbot> They definitely did not. 20180411 18:33:21< irker509> wesnoth: Nils Kneuper wesnoth:master 5f201e17f009 / po/wesnoth/zh_CN.po: updated Chinese (Simplified) translation https://github.com/wesnoth/wesnoth/commit/5f201e17f0095e111c9b0f7174f1b6d0be20c3b6 20180411 18:33:23< irker509> wesnoth: Nils Kneuper wesnoth:master 7ab1da24a52d / / (40 files in 28 dirs): updated Galician translation https://github.com/wesnoth/wesnoth/commit/7ab1da24a52d5842c0c3aaf18220f692ce000295 20180411 18:33:25< irker509> wesnoth: Nils Kneuper wesnoth:1.14 6f5851b49d82 / po/wesnoth/zh_CN.po: updated Chinese (Simplified) translation https://github.com/wesnoth/wesnoth/commit/6f5851b49d82a92e77082685071d94ec7ede144d 20180411 18:33:27< irker509> wesnoth: Nils Kneuper wesnoth:1.14 349775c05fcd / / (40 files in 28 dirs): updated Galician translation https://github.com/wesnoth/wesnoth/commit/349775c05fcddcb329c9d02b3a247f990d863428 20180411 18:34:03 * zookeeper wants a good app for finding the ideal jpeg compression level 20180411 18:40:46-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180411 18:50:40<+discordbot> That's hard since you're trading lossiness for size. "Ideal" lossiness will mean different things to different peopel. 20180411 18:51:24<+discordbot> It depends on the image too. 20180411 18:51:25< matthiaskrgr> zookeeper: like jpegoptim? 20180411 18:52:03< zookeeper> matthiaskrgr, that looks like it's just an optimizer. 20180411 18:52:04-!- travis-ci [~travis-ci@ec2-54-198-10-138.compute-1.amazonaws.com] has joined #wesnoth-dev 20180411 18:52:05< travis-ci> wesnoth/wesnoth#17540 (master - 7ab1da2 : Nils Kneuper): The build is still failing. 20180411 18:52:05< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/365258376 20180411 18:52:05-!- travis-ci [~travis-ci@ec2-54-198-10-138.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180411 18:52:17<+discordbot> If it was possible to automatically determine optimal compression level, image compression would be a solved problem. 20180411 18:52:23< irker509> wesnoth: ln-zookeeper wesnoth:1.14 0854bf8fe3c5 / / (30 files in 4 dirs): TRoW: New set of story art by LordBob https://github.com/wesnoth/wesnoth/commit/0854bf8fe3c594ce4fc0e670574e80090a1865e6 20180411 18:52:34<+discordbot> Pixel-art heavy screenshots would have a higher minimum decent quality than live pictures. 20180411 18:52:38< matthiaskrgr> well you will always trade performance for compresison 20180411 18:52:53< matthiaskrgr> but flif is also a thing https://flif.info/ 20180411 18:53:30<+discordbot> For lossy compression, there is BPG: https://bellard.org/bpg/ 20180411 18:53:31< zookeeper> @jyrkive, of course. which is why "a good app for finding the ideal jpeg compression level" naturally means an app that will make it easier for _me_ to determine it. 20180411 18:54:20< matthiaskrgr> hmm 20180411 18:54:28< matthiaskrgr> what is the meaning of "ideal compression level" ? 20180411 18:54:53-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20180411 18:55:29<+discordbot> I just enable live previews on the GIMP's JPEG export dialog and toss the slider around at 100%-250% zoom levels and try to choose a level where the artifacts are not too noticeable. 20180411 18:55:40< matthiaskrgr> uh :( 20180411 18:55:50-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180411 18:56:26<+discordbot> (250% to account for artificial upscaling, high DPI devices, and people zooming into the target application.) 20180411 18:57:04< zookeeper> matthiaskrgr, one that gives me the smallest filesize without clearly-human-perceptible loss in quality, pretty much. 20180411 18:57:26< irker509> wesnoth: Jyrki Vesterinen wesnoth:hotkey-event-buffer 6a4783841e59 / / (6 files in 3 dirs): Hotkey manager: drop duplicate commands https://github.com/wesnoth/wesnoth/commit/6a4783841e59f924e5f69096b73fb1a002839d9f 20180411 19:01:27< irker509> wesnoth/wesnoth:master Charles Dang 607bc4c935 Fixup 4b6e547 because apparently I canno AppVeyor: 2/4 builds failed 20180411 19:01:28< irker509> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-2580 20180411 19:01:29< irker509> Details vs2017/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-master-2289 20180411 19:02:56< zookeeper> "Auto packing the repository in background for optimum performance." yet does it modally anyway. oh well, no big deal. 20180411 19:05:10< irker509> wesnoth: Jyrki Vesterinen wesnoth:hotkey-event-buffer 64ef0eb1e683 / / (6 files in 3 dirs): Hotkey manager: drop duplicate commands https://github.com/wesnoth/wesnoth/commit/64ef0eb1e6830fc61a617a094b6f0cbb6cf97dfc 20180411 19:05:36<+discordbot> (rebase to allow automatic merging) 20180411 19:06:51-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20180411 19:07:25-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180411 19:14:34-!- travis-ci [~travis-ci@ec2-54-198-10-138.compute-1.amazonaws.com] has joined #wesnoth-dev 20180411 19:14:35< travis-ci> wesnoth/wesnoth#17541 (1.14 - 349775c : Nils Kneuper): The build is still failing. 20180411 19:14:35< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/365258392 20180411 19:14:35-!- travis-ci [~travis-ci@ec2-54-198-10-138.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180411 19:16:49< irker509> wesnoth/wesnoth:master Nils Kneuper 7ab1da24a5 updated Galician translation AppVeyor: vs2017/Release Failed 20180411 19:16:50< irker509> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-master-2293 20180411 19:28:11-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180411 19:28:18-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180411 19:29:34-!- travis-ci [~travis-ci@ec2-54-166-6-76.compute-1.amazonaws.com] has joined #wesnoth-dev 20180411 19:29:35< travis-ci> wesnoth/wesnoth#17542 (1.14 - 0854bf8 : ln-zookeeper): The build is still failing. 20180411 19:29:35< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/365266459 20180411 19:29:35-!- travis-ci [~travis-ci@ec2-54-166-6-76.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180411 19:34:36-!- atarocch [~atarocch@37.159.24.75] has joined #wesnoth-dev 20180411 19:39:53< irker509> wesnoth: Nils Kneuper wesnoth:master 90dba93784d5 / po/ (24 files in 24 dirs): updated Czech translation https://github.com/wesnoth/wesnoth/commit/90dba93784d525be7007edffc6e3cbb66422157f 20180411 19:39:58< irker509> wesnoth: Nils Kneuper wesnoth:1.14 719ee4f5cdc6 / / (26 files in 25 dirs): updated Czech translation https://github.com/wesnoth/wesnoth/commit/719ee4f5cdc61bba7d200a2d9f46abe80c0cc5dc 20180411 20:08:33-!- atarocch [~atarocch@37.159.24.75] has quit [Ping timeout: 260 seconds] 20180411 20:24:02-!- Porusaka [g7Ji5CDiIw@donger/wielder/Polsaker] has joined #wesnoth-dev 20180411 20:28:44-!- Netsplit *.net <-> *.split quits: Polsaker 20180411 20:33:31< irker509> wesnoth/wesnoth:hotkey-event-buffer Jyrki Vesterinen 6a4783841e Hotkey manager: drop duplicate commands AppVeyor: vs2015/Release Failed 20180411 20:33:33< irker509> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-hotkey-event-buffer-2587 20180411 20:35:31-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20180411 20:36:10-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180411 20:40:11-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20180411 20:40:50-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180411 20:43:46-!- travis-ci [~travis-ci@ec2-54-198-10-138.compute-1.amazonaws.com] has joined #wesnoth-dev 20180411 20:43:47< travis-ci> wesnoth/wesnoth#17544 (hotkey-event-buffer - 64ef0eb : Jyrki Vesterinen): The build failed. 20180411 20:43:47< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/365271852 20180411 20:43:47-!- travis-ci [~travis-ci@ec2-54-198-10-138.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180411 21:10:39< zookeeper> technically the master changelog should of course list changes since the point at which 1.14 was branched off, but at the time of 1.15.0's release it'll be weird to see for example fixes that were already in 1.14.0. not a big deal, just random musings. 20180411 21:11:01-!- Porusaka is now known as Polsaker 20180411 21:13:32-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20180411 21:14:04-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180411 21:20:24-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180411 21:20:31-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180411 21:36:06-!- travis-ci [~travis-ci@ec2-54-198-10-138.compute-1.amazonaws.com] has joined #wesnoth-dev 20180411 21:36:07< travis-ci> wesnoth/wesnoth#17547 (1.14 - 719ee4f : Nils Kneuper): The build is still failing. 20180411 21:36:07< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/365286943 20180411 21:36:07-!- travis-ci [~travis-ci@ec2-54-198-10-138.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180411 21:38:50-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20180411 21:39:05-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180411 21:45:24-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20180411 21:45:42-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180411 21:47:57-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20180411 21:48:18-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180411 21:50:39-!- gallaecio [~quassel@57.99.79.188.dynamic.jazztel.es] has quit [Remote host closed the connection] 20180411 21:51:33-!- atarocch [~atarocch@93.56.164.28] has joined #wesnoth-dev 20180411 21:52:37-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20180411 21:52:53-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180411 21:53:26-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20180411 21:54:59< irker509> wesnoth/wesnoth:1.14 Jyrki Vesterinen 2b3d8bc985 Hotkey manager: drop duplicate commands AppVeyor: vs2015/Release Failed 20180411 21:55:00< irker509> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-1.14-2588 20180411 22:01:34-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180411 22:01:40-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180411 22:02:28< irker509> wesnoth/wesnoth:opengl Martin Hrubý (hrubymar10) f4e0934ac5 Fix Xcode project after 3e96a3aa2c357c53 AppVeyor: All builds passed 20180411 22:09:26-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180411 22:09:32-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180411 22:09:33-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection] 20180411 22:11:46-!- grzywacz [~karol@89-70-226-147.dynamic.chello.pl] has quit [Ping timeout: 264 seconds] 20180411 22:20:52-!- atarocch [~atarocch@93.56.164.28] has quit [Ping timeout: 265 seconds] 20180411 22:27:29-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180411 22:27:33-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180411 22:39:10-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 256 seconds] 20180411 22:44:57-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180411 22:45:03-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180411 23:12:53< irker509> wesnoth/wesnoth:1.14 Jyrki Vesterinen 0fdb4614e0 Revert "Fix #1736: on GNU/Linux, a hotke AppVeyor: 1/2 builds failed 20180411 23:12:54< irker509> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-1.14-2582 20180411 23:14:59< irker509> wesnoth/wesnoth:master Nils Kneuper 90dba93784 updated Czech translation AppVeyor: vs2017/Release Failed 20180411 23:15:00< irker509> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-master-2298 20180411 23:36:57-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180411 23:37:03-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180411 23:37:17<+discordbot> Are regular users able to set tags for their own issues on GH? 20180411 23:37:58< Ravana_> no 20180411 23:38:14-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev 20180411 23:39:06<+discordbot> Also it'd be nice if Gallaecio could mention the affected versions even if we can safely assume 1.14 is involved somehow while master is unplayable... 20180411 23:42:57<+discordbot> Ah, he did for one of the three issues. 20180411 23:51:33-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev --- Log closed Thu Apr 12 00:00:41 2018