--- Log opened Thu Apr 12 00:00:41 2018 20180412 00:05:30< mattsc> celticminstrel: I just created a pull request for the recall/recruit bug. I used the solution we talked about that does a little bit of double evaluation. 20180412 00:05:53< mattsc> I looked into a solution that does not do that, but it’s much more complex and there’s no way I get that figured out before 1.13.14. 20180412 00:07:02< mattsc> This really is just a tiny bit of double eval, so I think this is acceptable. 20180412 00:12:27< celticminstrel> Ah, nice. I did eventually see your PM with a paste but I didn't get around to doing anything with it. 20180412 00:13:40< mattsc> No worries. I worked on it some more and figured out most of the coding problems with the help of the Internet, but abandonded that solution because it is too complicated in my opinion given how the CA is currently organized. 20180412 00:14:31< celticminstrel> So will this be cherry-picked to 1.14 too, or does 1.14 get its own unique solution? 20180412 00:14:56< mattsc> This is a PR vs. 1.14. It should then get cherry-picked to master. 20180412 00:14:58< celticminstrel> s/1.14/master/ 20180412 00:15:07< mattsc> In that case: yes 20180412 00:15:08< celticminstrel> Mind you, those aren't technically mutually exclusive if you want to build the master version on top of this fix. 20180412 00:15:23< celticminstrel> I guess that's what you mean by yes. 20180412 00:15:36< mattsc> Right, that’s what I mean. 20180412 00:15:55< mattsc> It’s pretty easy to build the other part of it that should go into master on top of this. 20180412 00:16:15< mattsc> I think ... 20180412 00:16:28< celticminstrel> You said something about a new aspect as well, right? 20180412 00:16:49< irker509> wesnoth/wesnoth:master Nils Kneuper 7ab1da24a5 updated Galician translation AppVeyor: 1/2 builds failed 20180412 00:16:50< irker509> Details vs2017/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-master-2293 20180412 00:16:58< mattsc> I did. But thinking about it afterward, it might make more sense to put it into the recruitment_instructions aspect. 20180412 00:17:07< celticminstrel> I thought about that too. 20180412 00:17:26< celticminstrel> IMO it depends on whether you think people might want to customize it on a per-job basis. 20180412 00:17:57< mattsc> There is probably somebody out there who will come up with that idea. 20180412 00:18:14< celticminstrel> What exactly would it be? 20180412 00:18:43< celticminstrel> A flag to determine whether to consider recalls at all? Or a flag to determine whether to recruit unworthy recalls as a last resort? 20180412 00:19:10< mattsc> The latter is what I was thinking about so far. 20180412 00:19:49< mattsc> The former might be an interesting addition, although there are already all kinds of ways of disabling that. 20180412 00:20:18< celticminstrel> I guess [filter_recall][not][/not][/filter_recall] would do it... 20180412 00:21:17< mattsc> Right! I hadn’t even thought of that. 20180412 00:22:08< mattsc> So, yeah, the former is probably not necessary, while the latter is really only doable in a rather hacky way. 20180412 00:22:46< mattsc> You need to reduce the recall cost, but then, if you want it to be the standard 20 gold, you need to subtract that manually. Which requires first checking whether there’s 20 gold left. Etc. 20180412 00:27:38< irker509> wesnoth: Iris Morelle wesnoth:1.14 b2297bb4ed50 / changelog.md src/help/help_topic_generators.cpp: help: Use new attack stats separator in unit descriptions https://github.com/wesnoth/wesnoth/commit/b2297bb4ed5020894001dbc605ccfda0ed93005a 20180412 00:28:43<+discordbot> @Vultraz I tried forward porting the above but the code in question in master appears to be part of a big #if 0 block. Am I wrong? Is there any point in forward porting the patch anyway? 20180412 00:35:55-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180412 00:36:01-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180412 00:48:07< celticminstrel> @shadowm, @Vultraz - I imagine that #if 0 block is probably temporary? 20180412 00:48:21< celticminstrel> Certainly the code is still needed in some form... 20180412 00:48:48<+discordbot> Either that or he has a huge a completely rewritten version stashed somewhere in his own copy. 20180412 00:48:54<+discordbot> *huge and 20180412 00:48:58< celticminstrel> I guess that's a possibility. 20180412 00:56:07-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: So long and thanks for all the fish.] 20180412 00:58:11< celticminstrel> Okay, so 2875... 20180412 00:58:16<+discordbot> I do not have a rewritten version locally. It’s commented out on master since it makes use of some stuff from the old font rendering system and I have yet to convert it. 20180412 00:59:02<+discordbot> And please, someone forward port zookeeper’s commit... 20180412 00:59:18<+discordbot> Can I forward-port my patch into the commented-out block then? 20180412 00:59:59<+discordbot> Yes 20180412 01:01:22-!- travis-ci [~travis-ci@ec2-54-166-6-76.compute-1.amazonaws.com] has joined #wesnoth-dev 20180412 01:01:23< travis-ci> wesnoth/wesnoth#17549 (1.14 - b2297bb : Iris Morelle): The build is still failing. 20180412 01:01:23< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/365388090 20180412 01:01:23-!- travis-ci [~travis-ci@ec2-54-166-6-76.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180412 01:01:42< irker509> wesnoth: Celtic Minstrel wesnoth:intl_fixes fb67e73e2954 / data/campaigns/tutorial/scenarios/02_Tutorial_part_2.cfg: Fix #2875 https://github.com/wesnoth/wesnoth/commit/fb67e73e2954cff65f6334cf35bb8228e97133b5 20180412 01:02:39< irker509> wesnoth: Iris Morelle wesnoth:master 7f8cb13bd309 / changelog.md src/help/topic_text_generators.cpp: help: Use new attack stats separator in unit descriptions https://github.com/wesnoth/wesnoth/commit/7f8cb13bd309eabe960a975a0ec0b5cbdd7f0719 20180412 01:03:18< irker509> wesnoth: Celtic Minstrel wesnoth:master bf70d50b8085 / data/campaigns/tutorial/scenarios/02_Tutorial_part_2.cfg: Fix #2875 https://github.com/wesnoth/wesnoth/commit/bf70d50b80857b01b70357bf8e6d62b55c34b6ec 20180412 01:04:01<+discordbot> celmin did you merge the password fix? 20180412 01:04:15< celticminstrel> Oh yeah, thanks for reminding me. 20180412 01:04:59< irker509> wesnoth: Celtic Minstrel wesnoth:1.14 02ab29d2f198 / src/preferences/credentials.cpp: Fix #2745 https://github.com/wesnoth/wesnoth/commit/02ab29d2f19800d28fa10476c48261be1083ad2c 20180412 01:05:24< irker509> wesnoth: Celtic Minstrel wesnoth:master 8f6613ea09ba / src/preferences/credentials.cpp: Fix #2745 https://github.com/wesnoth/wesnoth/commit/8f6613ea09ba5740c9b9d4d50d4ebb1215605f82 20180412 01:05:50<+discordbot> changelog? 20180412 01:07:05< irker509> wesnoth: Iris Morelle wesnoth:1.14 28db261ebd72 / data/scenario-test.cfg: Fix test scenario references to Kaleh's WML https://github.com/wesnoth/wesnoth/commit/28db261ebd725aed968738de7846e972348dbdc7 20180412 01:07:11< irker509> wesnoth: Iris Morelle wesnoth:master 0610b48d7e15 / data/scenario-test.cfg: Fix test scenario references to Kaleh's WML https://github.com/wesnoth/wesnoth/commit/0610b48d7e150a319ac55bb348d44d569712cc0d 20180412 01:07:40< irker509> wesnoth/wesnoth:1.14 mattsc 1814ccf862 AI recruitment: fix units on recall list AppVeyor: vs2017/Release Failed 20180412 01:07:41< irker509> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-1.14-2300 20180412 01:12:24< irker509> wesnoth: Celtic Minstrel wesnoth:schema_fixes d0e41518b166 / data/ (4 files in 3 dirs): Fix erroneous/useless [event] in [titlescreen_music], [lobby_music], [editor_mus https://github.com/wesnoth/wesnoth/commit/d0e41518b1669cf7e6e596de281b3f41e9e0eb9d 20180412 01:12:26< irker509> wesnoth: Celtic Minstrel wesnoth:schema_fixes afddd612fc54 / data/ (61 files in 17 dirs): Embrace turns=unlimited as a way of specifying unlimited turns https://github.com/wesnoth/wesnoth/commit/afddd612fc54d6941f800d5130151e52fd670783 20180412 01:12:28< irker509> wesnoth: Celtic Minstrel wesnoth:schema_fixes 649e927ebf69 / data/multiplayer/scenarios/ANL_utils/ (ANL_general_macros.cfg ANL_special_macros.cfg): ANL: Remove needless silent= key from [object]s https://github.com/wesnoth/wesnoth/commit/649e927ebf695c105e0843b808b32b7aefa24468 20180412 01:12:30< irker509> wesnoth: Celtic Minstrel wesnoth:schema_fixes d988d966bd64 / data/campaigns/Legend_of_Wesmere/scenarios/ (8 files in 3 dirs): LoW: Remove redundant AI definitions https://github.com/wesnoth/wesnoth/commit/d988d966bd64c5d7efdc161ccee24de1b42dabf0 20180412 01:12:32< irker509> wesnoth: Celtic Minstrel wesnoth:schema_fixes 395ac5cd1362 / data/campaigns/Legend_of_Wesmere/scenarios/chapter2/07_Elves_Last_Stand.cfg: LoW7: Fix invalid use of aspects in [unit][ai] https://github.com/wesnoth/wesnoth/commit/395ac5cd13622da07e007579091e8d0f74ff4fc1 20180412 01:12:34< irker509> wesnoth: Celtic Minstrel wesnoth:schema_fixes c506788894b6 / data/campaigns/Legend_of_Wesmere/utils/characters.cfg: LoW: Fix erroneous used of unrenamable and canrecruit keys in [side] when there https://github.com/wesnoth/wesnoth/commit/c506788894b6ee1f7163c8ccbb9421c00bab079a 20180412 01:12:36< irker509> wesnoth: Celtic Minstrel wesnoth:schema_fixes e6f88c8f93a8 / data/core/macros/ai_controller.cfg: Fix error in AI control core macros https://github.com/wesnoth/wesnoth/commit/e6f88c8f93a81e66de88011aec9899b66c078966 20180412 01:12:38< irker509> wesnoth: Celtic Minstrel wesnoth:schema_fixes 5e6b4c41506b / data/campaigns/Legend_of_Wesmere/ (7 files in 5 dirs): LoW: Several small fixes (misplaced keys mostly) https://github.com/wesnoth/wesnoth/commit/5e6b4c41506bfe54b10e2a703e62b06d85ef0db4 20180412 01:12:40< irker509> wesnoth: Celtic Minstrel wesnoth:schema_fixes e248a5da9c91 / data/campaigns/Two_Brothers/scenarios/ (01_Rooting_Out_a_Mage.cfg 02_The_Chase.cfg): TB: Fix errors found by schema validator https://github.com/wesnoth/wesnoth/commit/e248a5da9c91975d815d95d6e6dcc9e1484e4da2 20180412 01:12:42< irker509> wesnoth: Celtic Minstrel wesnoth:schema_fixes 0891b102c9f3 / data/campaigns/An_Orcish_Incursion/scenarios/ (02_Assassins.cfg 04_Valley_of_Trolls.cfg): AOI: Fix errors found by schema validator https://github.com/wesnoth/wesnoth/commit/0891b102c9f3c6743bfb12d19a9fdfbb414b05fb 20180412 01:12:44< irker509> wesnoth: Celtic Minstrel wesnoth:schema_fixes 3fd4f96624ad / data/core/macros/unit-utils.cfg: Remove animate=no from {GUARDIAN} https://github.com/wesnoth/wesnoth/commit/3fd4f96624adc17c48564828cf58ba3f04e9b2eb 20180412 01:12:46< irker509> wesnoth: Celtic Minstrel wesnoth:schema_fixes 236fd6f5c487 / data/campaigns/The_South_Guard/scenarios/ (05_Choice_In_The_Fog.cfg 06a_Tidings_Good_and_Ill.cfg 06b_The_Long_March.cfg): TSG: Fix errors found by schema validator https://github.com/wesnoth/wesnoth/commit/236fd6f5c4878f8a4af005c276a7bed615b1bead 20180412 01:12:47<+discordbot> celmin: add changelog entries please... 20180412 01:12:48< irker509> wesnoth: Celtic Minstrel wesnoth:schema_fixes 2001424cada2 / data/campaigns/Heir_To_The_Throne/units/ (Battle_Princess.cfg Commander.cfg Fighter.cfg Lord.cfg Princess.cfg): HTTT: Unit variations don't need an ID https://github.com/wesnoth/wesnoth/commit/2001424cada260bf6a22cad5d81a173007861ddb 20180412 01:12:50< irker509> wesnoth: Celtic Minstrel wesnoth:schema_fixes 50df7717e552 / data/core/macros/items.cfg: [effect]apply_to=new_animation does not support name https://github.com/wesnoth/wesnoth/commit/50df7717e5520c7f09049db7584d88f91439d12c 20180412 01:12:52< irker509> wesnoth: Celtic Minstrel wesnoth:schema_fixes 3df296e0991e / data/campaigns/Heir_To_The_Throne/scenarios/ (4 files): HTTT: Fix errors found by schema validator https://github.com/wesnoth/wesnoth/commit/3df296e0991e58ae530fdd757d03353be1ee3a3e 20180412 01:12:54< irker509> wesnoth: Celtic Minstrel wesnoth:schema_fixes f77a84939229 / data/campaigns/Eastern_Invasion/scenarios/ (5 files): EI: Fix issues found by the schema validator https://github.com/wesnoth/wesnoth/commit/f77a849392297f90e1a51f7868b5d9ba98f94c35 20180412 01:12:56< irker509> wesnoth: Celtic Minstrel wesnoth:schema_fixes b4f839a721b8 / data/campaigns/The_Hammer_of_Thursagan/scenarios/12_The_Underlevels.cfg: HoT: Fix issues found by the schema validator https://github.com/wesnoth/wesnoth/commit/b4f839a721b844d3875139db8c81695b29e879eb 20180412 01:12:58< irker509> wesnoth: Celtic Minstrel wesnoth:schema_fixes df462e54c6ad / data/campaigns/Descent_Into_Darkness/scenarios/ (7 files): DiD: Fix issues found by the schema validator https://github.com/wesnoth/wesnoth/commit/df462e54c6ad988a6204c14ff1881da285087901 20180412 01:13:00< irker509> wesnoth: Celtic Minstrel wesnoth:schema_fixes 975529936240 / data/campaigns/Delfadors_Memoirs/scenarios/ (3 files): DM: Fix issues found by the schema validator https://github.com/wesnoth/wesnoth/commit/97552993624010dc735767a3e9379deb940d3e80 20180412 01:13:02< irker509> wesnoth: Celtic Minstrel wesnoth:schema_fixes b8f96d0352ab / data/campaigns/Dead_Water/scenarios/ (01_Invasion.cfg 04_Slavers.cfg): DW: Remove [message]duration key since it does absolutely nothing https://github.com/wesnoth/wesnoth/commit/b8f96d0352abfde0fb1007bbc8e4e0a460938e15 20180412 01:13:04< irker509> wesnoth: Celtic Minstrel wesnoth:schema_fixes 6912e1255032 / data/campaigns/Dead_Water/scenarios/10_The_Flaming_Sword.cfg: DW: Fix a couple more issues found by the schema validator https://github.com/wesnoth/wesnoth/commit/6912e1255032a8512a3b53173e15fe6b00b730a2 20180412 01:13:06< irker509> wesnoth: Celtic Minstrel wesnoth:schema_fixes 667ae9ec1fc1 / data/campaigns/Secrets_of_the_Ancients/maps/ (16 files): SotA: Remove obsolete map headers https://github.com/wesnoth/wesnoth/commit/667ae9ec1fc11e72401d466835c73aff5806ae45 20180412 01:13:08< irker509> wesnoth: Celtic Minstrel wesnoth:schema_fixes 6217cde5aada / data/campaigns/Secrets_of_the_Ancients/ (5 files in 2 dirs): SotA: Remove weird terrain='' convention https://github.com/wesnoth/wesnoth/commit/6217cde5aada11f798e0f8cdbef75da01e697622 20180412 01:13:10< irker509> wesnoth: Celtic Minstrel wesnoth:schema_fixes fcd3d8fb72f6 / data/campaigns/Secrets_of_the_Ancients/scenarios/ (5 files): SotA: Fix a few more issues found by the schema validator https://github.com/wesnoth/wesnoth/commit/fcd3d8fb72f65306d4c6fb7d7ad785bcc0c9a82b 20180412 01:13:13< irker509> wesnoth: Celtic Minstrel wesnoth:schema_fixes c62e717d0e5c / data/campaigns/Sceptre_of_Fire/scenarios/ (1_A_Bargain_is_Struck.cfg 8_The_Dragon.cfg 9_Caverns_of_Flame.cfg): SoF: Fix issues found by the schema validator https://github.com/wesnoth/wesnoth/commit/c62e717d0e5c4ab8b42c20ad20db52d4970ea2f5 20180412 01:13:14< irker509> wesnoth: Celtic Minstrel wesnoth:schema_fixes 39ac4217b367 / data/campaigns/Northern_Rebirth/utils/herodeaths.cfg: NR: usage= and alignment= not supported in SUF https://github.com/wesnoth/wesnoth/commit/39ac4217b3670a34a8674cc276ae65de6eb4c638 20180412 01:13:17< irker509> wesnoth: Celtic Minstrel wesnoth:schema_fixes acf5a20b5bd4 / data/campaigns/Northern_Rebirth/scenarios/ (9 files): NR: Explicitly specify redundant side parameter in unit macros https://github.com/wesnoth/wesnoth/commit/acf5a20b5bd4cb211a5fbc82ec613ea9cd4f4ce7 20180412 01:13:18< irker509> wesnoth: Celtic Minstrel wesnoth:schema_fixes 95c736a55dd1 / data/campaigns/Northern_Rebirth/scenarios/ (08b_Ray_of_Hope.cfg 10a_Stolen_Gold.cfg 13a_Showdown.cfg): NR: [ai]villages_per_scout= is an integer https://github.com/wesnoth/wesnoth/commit/95c736a55dd19a06940a9668516251f739a9e5f5 20180412 01:13:20< irker509> wesnoth: Celtic Minstrel wesnoth:schema_fixes 98552d8cf17e / data/campaigns/Northern_Rebirth/scenarios/ (10a_Stolen_Gold.cfg 12a_Get_the_Gold.cfg 13a_Showdown.cfg): NR: [store_unit] does not support fire_event https://github.com/wesnoth/wesnoth/commit/98552d8cf17e300d42d8cff22189506c09fbdef6 20180412 01:13:23< irker509> wesnoth: Celtic Minstrel wesnoth:schema_fixes 1d0a2fd1cebc / data/campaigns/Northern_Rebirth/scenarios/ (4 files): NR: Fix a few more issues found by the schema validator https://github.com/wesnoth/wesnoth/commit/1d0a2fd1cebcd4f61e65140b4124417bcc12e4bd 20180412 01:13:25< irker509> wesnoth: Celtic Minstrel wesnoth:schema_fixes cecec264ce25 / data/campaigns/Under_the_Burning_Suns/scenarios/ (5 files): UtBS: [objectives] does not support show= https://github.com/wesnoth/wesnoth/commit/cecec264ce25b78c99d990d59825dd4471785197 20180412 01:13:26< irker509> wesnoth: Celtic Minstrel wesnoth:schema_fixes 1e879c3dc950 / data/campaigns/Under_the_Burning_Suns/scenarios/ (10 files): UtBS: [scenario]snapshot= doesn't seem like it would have any useful effect https://github.com/wesnoth/wesnoth/commit/1e879c3dc950b060c250448296ccd15e7bbde419 20180412 01:13:29< irker509> wesnoth: Celtic Minstrel wesnoth:schema_fixes b9ac4a12cadb / data/campaigns/Under_the_Burning_Suns/scenarios/ (06a_In_the_Tunnels_of_Trolls.cfg 06b_In_the_Domain_of_Dwarves.cfg): UtBS: silent= is meaningless in [object][modifications] https://github.com/wesnoth/wesnoth/commit/b9ac4a12cadbbbb86906ea1c575e088deac2d233 20180412 01:13:31< irker509> wesnoth: Celtic Minstrel wesnoth:schema_fixes 0d6efe61557f / data/campaigns/Under_the_Burning_Suns/scenarios/ (6 files): UtBS: Fix a few more issues found by the schema validator https://github.com/wesnoth/wesnoth/commit/0d6efe61557faa464acc1f0cb18306f2e9dab296 20180412 01:13:32< irker509> wesnoth: Celtic Minstrel wesnoth:schema_fixes d3106398c15b / data/campaigns/The_Rise_Of_Wesnoth/scenarios/ (21_The_Plan.cfg 23_Epilogue.cfg): TRoW: Fix a couple of issues found by the schema validator https://github.com/wesnoth/wesnoth/commit/d3106398c15bef75c592d99abc794b30acdf20b0 20180412 01:13:35< irker509> wesnoth: Celtic Minstrel wesnoth:schema_fixes d7185f76914c / data/campaigns/Heir_To_The_Throne/ (scenarios/01_The_Elves_Besieged.cfg utils/intro.cfg): HTTT: Fix toplevel [story] https://github.com/wesnoth/wesnoth/commit/d7185f76914c84793715452a15305bb65c2e5f2a 20180412 01:13:37< irker509> wesnoth: Celtic Minstrel wesnoth:schema_fixes 0c48c66ba5fd / data/campaigns/The_Rise_Of_Wesnoth/scenarios/ (15 files): TRoW: [scenario] does not support bonus=yes https://github.com/wesnoth/wesnoth/commit/0c48c66ba5fdf8db553184e28fafcd88ad40de9a 20180412 01:13:39< irker509> wesnoth: Celtic Minstrel wesnoth:schema_fixes 752e016cc7d5 / data/campaigns/The_Rise_Of_Wesnoth/ (scenarios/16_The_Kalian.cfg units/Kalian.cfg): TRoW: [unit]image= is not supported https://github.com/wesnoth/wesnoth/commit/752e016cc7d5622b36d80ae663441371c95bdd8a 20180412 01:13:41< irker509> wesnoth: Celtic Minstrel wesnoth:schema_fixes 9e88bee292e0 / data/campaigns/The_Rise_Of_Wesnoth/ (scenarios/16_The_Kalian.cfg units/Kalian.cfg): TRoW: [unit]image= is not supported https://github.com/wesnoth/wesnoth/commit/9e88bee292e027cf0d453dd6fefd39356b42afda 20180412 01:13:43< irker509> wesnoth: Celtic Minstrel wesnoth:schema_fixes dd12cbcf52c6 / data/campaigns/ (2 files in 2 dirs): HTTT, SoF: Fix a couple more issues found by the schema validator https://github.com/wesnoth/wesnoth/commit/dd12cbcf52c6cdc7f64bf72ff5c4afb06cd99e1a 20180412 01:13:45< irker509> wesnoth: Celtic Minstrel wesnoth:schema_fixes 1a0cebf9ecb0 / data/scenario-test.cfg: Test scenario: remove useless [object]silent=yes https://github.com/wesnoth/wesnoth/commit/1a0cebf9ecb0597b5578de76b834685498a9728e 20180412 01:13:47< irker509> wesnoth: Celtic Minstrel wesnoth:schema_fixes f8f4dedc4b38 / data/scenario-test.cfg: Test scenario: Fix invalid [message] key https://github.com/wesnoth/wesnoth/commit/f8f4dedc4b38a51052d4fbcdd26006d96975a87b 20180412 01:13:49< irker509> wesnoth: Celtic Minstrel wesnoth:schema_fixes a5347639287d / data/scenario-story.cfg: Story test scenario: Fix misplaced duplicate map data https://github.com/wesnoth/wesnoth/commit/a5347639287d2eadbca365d59a8e7ccb2cbe4459 20180412 01:13:51< irker509> wesnoth: Celtic Minstrel wesnoth:schema_fixes fa591e04ea61 / data/campaigns/Legend_of_Wesmere/scenarios/chapter4/13_News_from_the_Front.cfg: LoW: [scenario]snapshot= is not supported https://github.com/wesnoth/wesnoth/commit/fa591e04ea61066ef20f8980a7234baa08528e7f 20180412 01:13:53< irker509> wesnoth: Celtic Minstrel wesnoth:schema_fixes 282178e42ef5 / data/campaigns/Legend_of_Wesmere/scenarios/chapter3/12_Revelations.cfg: LoW MP: Fix a few more issues found by the schema validator https://github.com/wesnoth/wesnoth/commit/282178e42ef590d8e6c698faa6b93d9ffed4ec67 20180412 01:13:55< irker509> wesnoth: Celtic Minstrel wesnoth:schema_fixes fc5e3c59cca3 / data/ (3 files in 3 dirs): Fix a few schema issues in some of the interactive test scenarios https://github.com/wesnoth/wesnoth/commit/fc5e3c59cca39f77d3d68581a587c3eb2551e328 20180412 01:13:57< irker509> wesnoth: Celtic Minstrel wesnoth:schema_fixes d16813a33e68 / data/ai/micro_ais/scenarios/ (7 files): MicroAI Tests: Fix issues found by the schema validator https://github.com/wesnoth/wesnoth/commit/d16813a33e688a6a88be0e9a9b4b5a344ee8f5cf 20180412 01:13:59< irker509> wesnoth: Celtic Minstrel wesnoth:schema_fixes ff627782fce2 / data/test/ (maps/pathfind_1.cfg scenarios/test_menu_items.cfg): WML Unit Tests: Fix issues found by the schema validator https://github.com/wesnoth/wesnoth/commit/ff627782fce2b820cc4fbd9a6377b2eb0317a8b2 20180412 01:16:28< irker509> wesnoth: Charles Dang wesnoth:1.14 f7ab008c593a / src/help/help.cpp: Help: disabled parsing error popup https://github.com/wesnoth/wesnoth/commit/f7ab008c593aa00029147bd86556dcebdc28a719 20180412 01:17:16 * celticminstrel git rebase HEAD@{1} 20180412 01:17:17< celticminstrel> <_< 20180412 01:17:41< celticminstrel> Check out a specific commit, revert the unwanted commit, checkout schema, then ^ 20180412 01:17:52< irker509> wesnoth: Charles Dang wesnoth:1.14 2aff2cd36f86 / src/help/help.cpp: Fixup f7ab008 before GCC complains about an unused parameter >_< https://github.com/wesnoth/wesnoth/commit/2aff2cd36f86113afa383ff45c7005cdbc7b1022 20180412 01:18:10<+discordbot> also I don't think you ever added changelog entries for the last think I asked you to add changelog entries for 20180412 01:22:24< celticminstrel> Hmm, should I force-push schema... 20180412 01:23:46< irker509> wesnoth: ln-zookeeper wesnoth:master eaf186e021d8 / / (30 files in 4 dirs): TRoW: New set of story art by LordBob https://github.com/wesnoth/wesnoth/commit/eaf186e021d885d5fb39c0ff5c89413d769f0fdd 20180412 01:24:21< celticminstrel> It's over 100 commits. 20180412 01:30:14<+discordbot> AR was over 100 commits and I routinely forced-pushed it 20180412 01:30:57< celticminstrel> I probably won't force-push again between now and rebasing it to master, since it'll be a pain. 20180412 01:33:31< irker509> wesnoth/wesnoth:hotkey-event-buffer Jyrki Vesterinen 6a4783841e Hotkey manager: drop duplicate commands AppVeyor: 2/4 builds failed 20180412 01:33:32< irker509> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-hotkey-event-buffer-2587 20180412 01:33:33< irker509> Details vs2017/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-hotkey-event-buffer-2296 20180412 01:36:18<+discordbot> What is schema_fixes about, out of curiosity? 20180412 01:36:18< celticminstrel> mattsc: I looked into the "pathfinding with custom cost function ignores teleports" and it seems to me that changing it would need an API change? 20180412 01:36:41< celticminstrel> @shadowm: Fixing hard-to-find errors that were found using the schema validator. 20180412 01:37:08<+discordbot> Are there are lot of those? 20180412 01:37:18< celticminstrel> Mind you, while some of the commits fix clear errors, others are merely removing bits of WML that wouldn't've done anything after all. 20180412 01:37:28< celticminstrel> There are a surprisingly large number of errors, yeah. 20180412 01:38:57< celticminstrel> I could remove the ones that don't actually fix problems, I guess. 20180412 01:39:03< celticminstrel> I mean, ones that just remove useless WML. 20180412 01:39:20<+discordbot> There's nothing wrong with removing useless WML unless the fact that it's useless in the first place is a bug. 20180412 01:39:36<+discordbot> (e.g. someone typing random_trails=yes instead of random_traits=yes.) 20180412 01:39:54< celticminstrel> There were several of those actually (not that specific example, but similar). 20180412 01:40:16< celticminstrel> There was an instance of [if]side={CONTROLLER_SIDE} 20180412 01:40:28< celticminstrel> Oh sorry, [show_if]. Still. 20180412 01:40:40<+discordbot> It might be preferrable to get those into 1.14 in two different batches (one for actual bugs, the other for cleanups) for two different versions, though, or even skip the cleanup batch entirely. 20180412 01:40:50<+discordbot> If the intention is to ever get the changes into 1.14, anyway. 20180412 01:41:05< celticminstrel> Sure, I can split it. 20180412 01:43:22<+discordbot> just get it in today 20180412 02:02:07< celticminstrel> I'll push the actual fixes to 1.14 today and the rest to schema_fixes for possible merging later. --- Log opened Thu Apr 12 02:38:35 2018 20180412 02:38:49-!- lobby [~wesnoth@wesnoth/bot/lobby] has joined #wesnoth-dev 20180412 02:38:49-!- Topic for #wesnoth-dev: 1.13.14 (1.14 RC 3) scheduled for April 15th 00:01 UTC | String and feature freeze on 1.14 branch | Wesnoth Developers Channel | >>> Want to help? Go here: https://r.wesnoth.org/t42911 (and thanks!) <<< | Discord Server: https://discord.gg/battleforwesnoth | Logs: http://irclogs.wesnoth.org | Bug tracker: https://bugs.wesnoth.org 20180412 02:38:49-!- Topic set by shadowm [~iris@wesnoth/developer/shadowm] [Mon Apr 2 07:06:30 2018] 20180412 02:38:49[Users #wesnoth-dev] 20180412 02:38:49[+discordbot ] [ EliDupree ] [ Kawa[m] ] [ Rhonda ] 20180412 02:38:49[ aeth ] [ esr ] [ lobby ] [ shadowm ] 20180412 02:38:49[ AI0867 ] [ galegosimpatico] [ loonycyborg ] [ Soliton ] 20180412 02:38:49[ aidanhs ] [ Gambit ] [ madmax28 ] [ syrma[m] ] 20180412 02:38:49[ APic ] [ heirecka ] [ matthiaskrgr] [ TC01 ] 20180412 02:38:49[ Appleman1234 ] [ higgins ] [ minzbonbon ] [ TheJJ ] 20180412 02:38:49[ celticminstrel ] [ iceiceice ] [ nore ] [ timotei_ ] 20180412 02:38:49[ ChipmunkV[m] ] [ irker509 ] [ nurupo ] [ vihta ] 20180412 02:38:49[ commavir ] [ Ivanovic ] [ oldlaptop ] [ vincent_c] 20180412 02:38:49[ crimson_penguin] [ iwaim ] [ Polsaker ] [ vn971 ] 20180412 02:38:49[ DDR ] [ janebot ] [ pydsigner ] 20180412 02:38:49[ elias ] [ Jetrel_bot ] [ Ravana_ ] 20180412 02:38:49-!- Irssi: #wesnoth-dev: Total of 46 nicks [0 ops, 0 halfops, 1 voices, 45 normal] 20180412 02:38:49-!- Home page for #wesnoth-dev: https://www.wesnoth.org 20180412 02:38:50< celticminstrel> And now it's done. Didn't mean to push that last commit though, but whatever. 20180412 02:38:52-!- Channel #wesnoth-dev created Tue Jan 27 05:28:41 2009 20180412 02:39:30< celticminstrel> Oh hey the last commit also includes the 1.14 version of the TRoW fix. Well, it'll be rebased away as soon as I get back to the branch, so whatever. 20180412 02:39:42-!- Irssi: Join to #wesnoth-dev was synced in 61 secs 20180412 02:40:04<+discordbot> C H A N G E L O G 20180412 02:40:05< celticminstrel> If you want to see me using the schema format to define itself though, feel free to! 20180412 02:40:10<+discordbot> why do you refuse to add changelog entries 20180412 02:40:17< celticminstrel> That's ironic coming from you. 20180412 02:40:51< celticminstrel> I didn't add changelog entries while working on a branch because they would always conflict, and in the unlikely event that they didn't technically conflict, they'd risk being added to the wrong version. 20180412 02:41:06<+discordbot> Not when I keep asking you to please add changelogs entries for the mp fix 20180412 02:41:15< celticminstrel> For what now? 20180412 02:41:25<+discordbot> THE MP PASSWORD FIX 20180412 02:41:29< celticminstrel> Oh, that. 20180412 02:41:43<+discordbot> You can express yourself without caps. 20180412 02:42:25<+discordbot> and there was another thing you added to master awhile back and i don't know if you ever noted it 20180412 02:42:27< celticminstrel> Anything else I need to changelog besides that? 20180412 02:42:35< celticminstrel> For 1.14 first. 20180412 02:42:43<+discordbot> i don't think so 20180412 02:43:47< irker509> wesnoth: Celtic Minstrel wesnoth:1.14 25b30608f904 / changelog.md: Update changelog.md https://github.com/wesnoth/wesnoth/commit/25b30608f90482ee2785a59928b65e2a580ac6eb 20180412 02:44:04< celticminstrel> Can I merge 2812? 20180412 02:44:28<+discordbot> if it's ready 20180412 02:44:47< celticminstrel> It's as ready as it can possibly be on a broken master, I think? 20180412 02:45:16<+discordbot> then megre it 20180412 02:45:39< celticminstrel> Is this the one you're thinking of? https://github.com/wesnoth/wesnoth/commit/7f60fb0fbc3b8245562503376905a16ab51a8d13 20180412 02:46:03<+discordbot> probably 20180412 02:46:53< irker509> wesnoth: Celtic Minstrel wesnoth:master 622db9d08b1e / data/lua/wml/move_unit.lua: Allow [move_unit]to_location to take a list of waypoints https://github.com/wesnoth/wesnoth/commit/622db9d08b1e15ba99ccb797b4785ac9df4f49fe 20180412 02:46:55< irker509> wesnoth: Celtic Minstrel wesnoth:master 68b33cf6bd8a / changelog.md data/lua/wml/move_unit.lua: Allow [move_unit]dir= to perform relative movements https://github.com/wesnoth/wesnoth/commit/68b33cf6bd8a44470c7ba8069b6b3502e117b5bd 20180412 02:46:57< irker509> wesnoth: Celtic Minstrel wesnoth:master b062b19e10c8 / data/lua/wml/move_unit.lua: Add [move_unit]clear_shroud= as an attempt to clear shroud as the unit moves (un https://github.com/wesnoth/wesnoth/commit/b062b19e10c85faecf65246e94ec8dbbad0ad4ed 20180412 02:47:22< celticminstrel> BTW, why is it 1.15.0-dev instead of 1.15.0+dev? 20180412 02:47:37<+discordbot> because 1.15.0 isn't out yet 20180412 02:47:42<+discordbot> What Vultraz said. 20180412 02:48:13<+discordbot> (This is a thing since 1.5.0-dev, incidentally. Best not to question it and carry on.) 20180412 02:51:36< irker509> wesnoth: Celtic Minstrel wesnoth:master 191c23c194be / changelog.md: Update changelog.md https://github.com/wesnoth/wesnoth/commit/191c23c194bedf13e1eb6e27eb469d43da965af5 20180412 02:52:32<+discordbot> celmin: do you happen to remember what the bug again was that prompted us to use TEXT_INPUT events 20180412 02:52:47< celticminstrel> No. 20180412 02:53:06<+discordbot> damn 20180412 02:53:24<+discordbot> guess we'll need to find it if we want to remove TEXT_INPUT 20180412 02:53:26< celticminstrel> I think it was probably something related to how hotkeys are shown though, not anything to do with hotkey behaviour. 20180412 02:53:58<+discordbot> IIRC it was something about finnish keyboards? 20180412 02:54:31< celticminstrel> I doubt it was specifically about Finnish keyboards. 20180412 02:54:35<+discordbot> yeah 20180412 02:54:39< irker509> wesnoth: Iris Morelle valen:master de25c9e5b267 / bin/valen.pl: valen: Drop check for 1.13.x campaignd https://github.com/wesnoth/valen/commit/de25c9e5b2672a545d92ad7f00a89c6418ee5190 20180412 02:54:41<+discordbot> but we should not be using T_I 20180412 02:55:00< irker509> wesnoth/wesnoth:1.14 Jyrki Vesterinen 2b3d8bc985 Hotkey manager: drop duplicate commands AppVeyor: 2/4 builds failed 20180412 02:55:01< irker509> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-1.14-2588 20180412 02:55:02< irker509> Details vs2017/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-1.14-2297 20180412 02:57:10<+discordbot> we can remove it for 1.15 and find a better solution 20180412 02:57:23<+discordbot> 1.16* 20180412 03:15:04< celticminstrel> I don't think that's a good idea? 20180412 03:15:18< celticminstrel> It doesn't strike me as the sort of thing that you can just "remove" and "find a better solution". 20180412 03:15:27< celticminstrel> It's rather a complicated situation TBH. 20180412 03:46:51< celticminstrel> BTW @Vultraz, you said you have a fix for the music issue? 20180412 03:49:02<+discordbot> If other apps can do it, no reason we cannot 20180412 03:49:16< celticminstrel> But are those other apps using SDL? 20180412 03:49:22<+discordbot> And if it means some keys can’t be hotkeys, no matter. 20180412 03:49:27< celticminstrel> It can definitely be done at the OS API level. 20180412 03:49:38< celticminstrel> But I don't know if it can be done with SDL. 20180412 03:49:57<+discordbot> Then we ignore keys that don’t work. 20180412 03:50:07< celticminstrel> And if it means some keys can't be hotkeys, that's not good. 20180412 03:50:28< celticminstrel> It's not "no matter", it's a problem if you can't assign certain keys. 20180412 03:50:31<+discordbot> It’s acceptable 20180412 03:50:52< celticminstrel> It's not acceptable in the slightest (unless they're rare edge-case keys like fn which you don't expect to work anyway). 20180412 03:51:05<+discordbot> Why is it not acceptable 20180412 03:51:21< celticminstrel> What keys do you think might become unassignable anyway? 20180412 03:52:25<+discordbot> I don’t know. Because I don’t remember what the original but was. 20180412 03:52:32<+discordbot> But you said the hotkeys worked fine 20180412 03:52:38< celticminstrel> Huh? 20180412 03:52:38<+discordbot> It was just their display 20180412 03:52:47< celticminstrel> Oh, yeah, I think that's what it was. 20180412 03:53:18< celticminstrel> What's really needed is a way to query the keyboard's physical layout. 20180412 03:53:44< celticminstrel> So even if you've set your keyboard layout to French, if you're using a UK keyboard, it'll return map scancodes to UK key names. 20180412 03:54:07< celticminstrel> That kind of method would lead towards showing eg shift+a instead of A, but that's acceptable. 20180412 03:55:00<+discordbot> Does any other app do that? 20180412 03:55:45< celticminstrel> No idea? 20180412 03:56:10< celticminstrel> I'd be surprised if none do. 20180412 03:56:30< celticminstrel> At least in terms of the display detail, not so sure about the scancode thing. 20180412 03:57:52<+discordbot> If you’ve set your keyboard layout to French I have no idea why you would want UK key names, whatever that means 20180412 03:58:34< celticminstrel> Because this isn't text, it's hotkeys; so it should use the actual physical key labels. 20180412 03:59:00< celticminstrel> But I think it may be literally impossible to query the physical keyboard layout. 20180412 03:59:34<+discordbot> I mean, if I’m using the French language pack so I can type French accents and stuff (no idea if there are physical keyboard where you can do that) I’d expect whatever accented character to be the hotkey, however one types it 20180412 04:00:14< celticminstrel> Well, then you need to use TEXT_INPUT. 20180412 04:00:33<+discordbot> Not the physical keys 20180412 04:00:38< celticminstrel> If you want the displayed hotkey to be what would result from pressing a key combination in a text field, there isn't really another option. 20180412 04:01:06<+discordbot> Or perhaps we just don’t allow combination characters 20180412 04:01:17< celticminstrel> What do you mean by combination characters? 20180412 04:01:36<+discordbot> Ie, why would you want a kotkey be to be à 20180412 04:01:42<+discordbot> Or î 20180412 04:02:04< celticminstrel> Well, those wouldn't be allowed anyway, because there's no single keystroke for them (as far as I know). 20180412 04:02:14< celticminstrel> I think there's a single keystroke for é on some layouts though. 20180412 04:02:25< celticminstrel> And if you're using such a layout, that key should be bindable. 20180412 04:05:26< celticminstrel> The "correct" way is probably to handle scancodes instead of virtual keycodes or TEXT_INPUT. Unfortunately, that doesn't give the correct results for non-English layouts IIRC. 20180412 04:05:56< celticminstrel> For example, if you type Z on an AZERTY layout, it'll be reported as W IIRC because that's the key that would be at that location on a QWERTY keyboard. 20180412 04:07:26<+discordbot> Why can’t everyone just use QWERTY... 😑 20180412 04:07:33< celticminstrel> I could be mistaken though, and I can't test since I don't have an AZERTY keyboard. 20180412 04:07:58< celticminstrel> I assume other languages rearranged the keyboard to be more convenient (or less convenient) for typing in that language. 20180412 04:08:13< celticminstrel> Different languages use the letters in different frequencies. 20180412 04:09:37< celticminstrel> Hmm, this sounds like a useful answer, actually. https://gamedev.stackexchange.com/a/69276 20180412 04:10:13< celticminstrel> Basically, use scancodes internally but map them to keycodes for display. 20180412 04:10:53< celticminstrel> Maybe map them to keycodes for persistence too (in preferences), so people don't get confused if they decide to edit the preferences. 20180412 04:11:10< celticminstrel> I'm not sure if that works for the case of W vs Z on an AZERTY keyboard. 20180412 04:12:23< celticminstrel> ..."which is outside the purview of a game engine" <-- strongly disagree 20180412 04:14:59< irker509> wesnoth/wesnoth:master Nils Kneuper 90dba93784 updated Czech translation AppVeyor: 2/4 builds failed 20180412 04:15:00< irker509> Details vs2017/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-master-2298 20180412 04:15:01< irker509> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-2589 20180412 04:19:39< celticminstrel> ...beetlenaut's fix for the [object]id= description is wrong. :( 20180412 04:19:59< celticminstrel> Or wait, maybe it's not? 20180412 04:20:15< celticminstrel> Hmm. 20180412 04:21:02< celticminstrel> I guess it's not wrong but I can't decide whether it's truly an improvement on the previous version. 20180412 04:22:02< celticminstrel> I wonder if we have the DevFeature1.15 template yet. 20180412 04:22:40< celticminstrel> Nope. I'll create it, then. 20180412 04:23:15< celticminstrel> But don't use it before May, please. 20180412 04:23:39< celticminstrel> Well, I suppose it doesn't matter that much. 20180412 04:24:10< celticminstrel> It's only the template documentation that's inaccurate prior to May. 20180412 04:26:44-!- travis-ci [~travis-ci@ec2-54-166-6-76.compute-1.amazonaws.com] has joined #wesnoth-dev 20180412 04:26:45< travis-ci> wesnoth/wesnoth#17566 (schema - 6562f11 : Celtic Minstrel): The build is still failing. 20180412 04:26:45< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/365412346 20180412 04:26:45-!- travis-ci [~travis-ci@ec2-54-166-6-76.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180412 04:26:53< celticminstrel> Meh! 20180412 04:27:40< celticminstrel> Oh, I wonder if we should also mention the rebranding of FormulaAI (the language) to WFL on https://wiki.wesnoth.org/User:Shadowm/Stable_1.14_Announcement_Outline 20180412 04:27:52< celticminstrel> Thus leaving FormulaAI to refer only to the AI usage of the language. 20180412 04:28:08< celticminstrel> Maybe it's not important? I dunno. 20180412 04:28:48<+discordbot> @Vultraz Removing code and then saying "we'll figure out how to reimplement the functionality later" is definitely a wrong way to refactor anything. 20180412 04:28:54< celticminstrel> ^ 20180412 04:29:35<+discordbot> That way you end up in a situation where the development version has regressions spanning back even a couple of years, in a state where releasing is impossible. 20180412 04:30:38< celticminstrel> I keep going to edit a page and noticing the code isn't syntax-hilited. :( 20180412 04:31:32<+discordbot> What fix to object id=? 20180412 04:31:46< celticminstrel> @Vultraz - Talking about the wiki. 20180412 04:31:55<+discordbot> Oh 20180412 04:32:00<+discordbot> Nevermind 20180412 04:43:33-!- travis-ci [~travis-ci@ec2-54-226-151-214.compute-1.amazonaws.com] has joined #wesnoth-dev 20180412 04:43:34< travis-ci> wesnoth/wesnoth#17567 (1.14 - 25b3060 : Celtic Minstrel): The build passed. 20180412 04:43:34< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/365414069 20180412 04:43:34-!- travis-ci [~travis-ci@ec2-54-226-151-214.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180412 04:43:46< celticminstrel> No-one ever updated this! Shame! https://wiki.wesnoth.org/TerrainCodesWML#Terrain_codes_in_map_data 20180412 04:46:06< celticminstrel> Okay so I'm pretty sure wesnoth.{get,match}_locations has a new argument to document... 20180412 04:50:19-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev 20180412 04:51:31<+discordbot> yoooowww. god damn splitting headache for the last hour. 20180412 04:51:38<+discordbot> probably because i didn't have coffee this morning >_> 20180412 04:51:57< celticminstrel> Oh hi mattsc, nice timing. 20180412 04:52:12< mattsc> Hey. 20180412 04:52:13< celticminstrel> I was totally planning to go to bed in like, ten minutes-ish. 20180412 04:52:14<+discordbot> I'm not mattsc 😐 20180412 04:52:22< celticminstrel> I know you're not @Vultraz 20180412 04:52:25< mattsc> But I am ;) 20180412 04:52:37< celticminstrel> I was responding to mattsc's join which you can't see since you've deserted IRC. 20180412 04:52:52< mattsc> heh 20180412 04:52:59< mattsc> (I figured) 20180412 04:53:47<+discordbot> indeed, I have deserted IRC. 20180412 04:53:59< celticminstrel> So did you see what I said earlier? 20180412 04:54:04< celticminstrel> @Vultraz Your loss! 20180412 04:54:05<+discordbot> I maintained an IRC presence to talk to celmin 20180412 04:54:07< mattsc> If somebody could tell me why gcc is complaining while clang is happy, that would be much apppreciated 20180412 04:54:10<+discordbot> but now I can talk to celmin here 20180412 04:54:32< celticminstrel> Maybe I can look at your PR it a couple of minutes. I want to document these things first. 20180412 04:54:43<+discordbot> someone fixed the tests earlier.. 20180412 04:54:48<+discordbot> n both branches? 20180412 04:55:10<+discordbot> ... 20180412 04:55:29< mattsc> celticminstrel: ok 20180412 04:55:30<+discordbot> mattsc: What excatly is GCC's complaint? 20180412 04:55:30<+discordbot> yes, she did 20180412 04:55:48< celticminstrel> mattsc: Did you see what I said to you earlier? 20180412 04:55:54< mattsc> Something about it not liking ‘const’. I really don’t know C++ very well, so .... 20180412 04:56:17-!- travis-ci [~travis-ci@ec2-54-166-6-76.compute-1.amazonaws.com] has joined #wesnoth-dev 20180412 04:56:18< travis-ci> wesnoth/wesnoth#17569 (master - 191c23c : Celtic Minstrel): The build passed. 20180412 04:56:18< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/365415477 20180412 04:56:18-!- travis-ci [~travis-ci@ec2-54-166-6-76.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180412 04:56:27< mattsc> celticminstrel: hold on, just got back literally a couple minutes ago. 20180412 04:56:29-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev 20180412 04:57:10<+discordbot> Please post the whole error message (pastebin it if it's too long). 20180412 04:57:16<+discordbot> And the affected code, too. 20180412 04:59:20< mattsc> @jyrkive this is directed at me? 20180412 04:59:29<+discordbot> Yes. 20180412 05:00:08< mattsc> @jyrikve: BTW, how are you still awake?? 20180412 05:00:30<+discordbot> probably since it's 8 am for him 20180412 05:00:30<+discordbot> I'm not "still" awake. I woke up about an hour ago. 20180412 05:00:50< mattsc> Ah ... 20180412 05:01:00< mattsc> @jyrkive: https://travis-ci.org/wesnoth/wesnoth/jobs/365381409 20180412 05:01:15< mattsc> Something about it not liking ‘const’ before and after 20180412 05:01:37< mattsc> @jyrkive: have I ever mentioned that I do not know C++ at all? 20180412 05:02:05< mattsc> I know how to solve problems. 20180412 05:02:09< mattsc> I do not know how to code. 20180412 05:02:31<+discordbot> As far as I can see, there aren't any GCC error messages in the log you linked. 20180412 05:02:42<+discordbot> scroll up 20180412 05:02:51< celticminstrel> I don't see any either? 20180412 05:02:53<+discordbot> src/ai/default/recruitment.hpp:177:69: warning: type qualifiers ignored on function return type [-Wignored-qualifiers] const double recall_unit_value(const unit_const_ptr & recall_unit) const; 20180412 05:03:04< celticminstrel> Oh. 20180412 05:03:06<+discordbot> Ah, right. They're warnings, not errors. 20180412 05:03:33< celticminstrel> mattsc: Using const for a return type that's not a reference or pointer is worthless since it's effectively const anyway 20180412 05:03:39< mattsc> src/ai/default/recruitment.hpp:177:69: warning: type qualifiers ignored on function return type [-Wignored-qualifiers] 20180412 05:03:40< mattsc> const double recall_unit_value(const unit_const_ptr & recall_unit) const; 20180412 05:03:46< celticminstrel> Just remove the leading const. 20180412 05:03:47<+discordbot> GCC is highlighting a wrong const. 20180412 05:03:50<+discordbot> I found it rather disconcerting to see you all treating the tests situation like it was a huge chore. 20180412 05:03:56<+discordbot> It's complaining about the one at the beginning of the line. 20180412 05:04:01< celticminstrel> ^ 20180412 05:04:07<+discordbot> https://github.com/wesnoth/wesnoth/commit/28db261ebd725aed968738de7846e972348dbdc7 20180412 05:04:10<+discordbot> Just remove the const at the beginning. 20180412 05:04:35< mattsc> celticminstrel, @jyrkive, @vultraz: you do know that I don’t know C++, right? ;) 20180412 05:04:58<+discordbot> Sure. And there's no harm in asking simple questions like this. 😃 20180412 05:05:11< celticminstrel> Well, the build didn't fail because of those consts, it failed because of other issues unrelated to your work. 20180412 05:05:36< mattsc> FYI, I had 2 beers and 4 scotches tonight, so logical thinking is kind of … slowed down right this moment. 20180412 05:05:41<+discordbot> @shadowm only because i was asleep when I was made away of the fact 20180412 05:05:50<+discordbot> it was 3 am 20180412 05:05:54< celticminstrel> So mattsc, did you see what I said to you earlier yet? 20180412 05:06:00< celticminstrel> Should I repost it? 20180412 05:06:08< mattsc> celticminstrel: yes, but I need to re-read it. 20180412 05:06:16< celticminstrel> About the pathfinding. 20180412 05:06:25< mattsc> yes. 20180412 05:06:34< mattsc> Give me a second (or seceral) 20180412 05:08:59< mattsc> celticminstrel: in which way wouold it need an API change? 20180412 05:08:59<+discordbot> @shadowm I didn't know whether fixing the test situation would be a "huge chore" or not. I was waiting for Vultraz to fix it like he had said yesterday, and had my focus on the GNU/Linux hotkey issue instead. 20180412 05:09:17< celticminstrel> To specify whether or not to ignore teleports when using a custom cost function? 20180412 05:09:29< mattsc> Hmm ... 20180412 05:09:37< mattsc> Agreed. 20180412 05:10:01< celticminstrel> If you just want me to change it to never ignore them with a custom cost function, that I can do (looks like it's really easy). 20180412 05:10:06< mattsc> But what do you think the default behavior'w that the “uninitiated” user would epect. 20180412 05:10:16< mattsc> s/‘w/‘s 20180412 05:11:20< celticminstrel> I guess ignoring teleports would be a bit surprising? 20180412 05:11:28< mattsc> Right. 20180412 05:11:49< mattsc> So that’s the problem we have been encountering with a couple of these things. 20180412 05:12:06< celticminstrel> So should I make it never ignore teleports for a custom cost function in 1.14? 20180412 05:12:10< mattsc> The default behavior is not what I (personally speaking) is what I would expect intuitievely. 20180412 05:12:28< mattsc> But I think it’s too late for 1.14. 20180412 05:12:38< mattsc> We should keep the default behavior as it is. 20180412 05:13:13< mattsc> I _really_ *really* hte it when I implemented a work-around in my campaigns and suddnely the project decides to change the default. 20180412 05:13:59< mattsc> So … here’s what I think: 20180412 05:14:11< mattsc> We need to keep the default behavior what it is for 1.14. 20180412 05:14:31< mattsc> We need to document on the wiki what that default behavior is. 20180412 05:15:15< mattsc> We need to change the behavior for 1.15 to whatever is what the uninitiated “user” expects, while retaining an option to keep the old defaut behaivior. 20180412 05:16:00< mattsc> celticminstrel: does that make sense? 20180412 05:16:28< celticminstrel> Think so. I'll push a commit to a branch soon for review, then go to sleep. 20180412 05:16:49< mattsc> It’s late where you are ... 20180412 05:18:26< mattsc> As for me, I’ll try to fix that ‘const’ thing to make gcc happy. 20180412 05:18:40< mattsc> And add the thing that gfgtdf pointed out. 20180412 05:18:59< mattsc> and figure out how to squash commits somehow without spamming the channel. 20180412 05:19:52< mattsc> Anythng else? 20180412 05:20:27< mattsc> celticminstrel: for the things I am ware of, I will update the wiki. 20180412 05:23:47< irker509> wesnoth: Celtic Minstrel wesnoth:pf_custom_cost 11b1a5cba419 / src/scripting/game_lua_kernel.cpp: wesnoth.find_path: Allow specifying custom flags (in particular teleport) when u https://github.com/wesnoth/wesnoth/commit/11b1a5cba4194ee42cf84c850c4f089326458431 20180412 05:24:04< celticminstrel> mattsc: ^ 20180412 05:24:15< celticminstrel> What this means for users of the function: 20180412 05:24:43< celticminstrel> 1. If you pass a custom cost function instead of the options table, the function will also accept an additional argument after that for whether to ignore teleport. 20180412 05:25:07< celticminstrel> 2. Alternatively, you can pass the custom cost function in the options table, which allows you to set things such as viewing_side as well for custom cost functions. 20180412 05:25:28<+discordbot> could we just always consider teleport 20180412 05:25:35< celticminstrel> 3. The extra optional parameter with a custom cost function not in the options table defaults to false. 20180412 05:25:44< celticminstrel> @Vultraz No, there are legitimate reasons to ignore it. 20180412 05:25:50<+discordbot> k 20180412 05:26:35< celticminstrel> 4. With the extra parameter method, the viewing side will be the unit's side. 20180412 05:27:51< celticminstrel> Note that this is untested though. It's built on the 1.14 branch ATM, so you could merge it locally and test if you want; I intend to cherry-pick it to master and then just delete the branch. 20180412 05:28:09< celticminstrel> And I can't really stay up any longer, so... good night. 20180412 05:28:17< mattsc> celticminstrel: good night 20180412 05:28:32< mattsc> All that sounds good to me as far as I can tell at this time, 20180412 05:28:58-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The computer falls into a deep sleep, to awake again some other day!] 20180412 05:38:28<+discordbot> Ok, just a reminder: We REALLY Need someone to take at least 5 good, varied screenshots within the next week or so 20180412 05:40:53<+discordbot> like. REALLY REALLY need. 20180412 05:43:50<+discordbot> As in, just a regular screenshot of 5 different places/scenarios ingame? Or is there more to it than that? 20180412 05:44:12-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection] 20180412 05:49:16<+discordbot> yes 20180412 05:56:08<+discordbot> but they need to be widescreen format 20180412 05:56:14<+discordbot> 1080, perhaps. 20180412 05:56:23<+discordbot> or what was the other one 20180412 05:57:53< vn971> 1920x1080 ? 20180412 05:59:56<+discordbot> For best results, please provide screenshots in high-res, widescreen format (ideally 1280 x 720 or 1920 x 1080). We ask that any images you upload to the ‘screenshot’ section of your store page should be screenshots that show your game. This means avoiding using concept art, pre-rendered cinematic stills, or images that contain awards, marketing copy, or written product descriptions. Please show customers what your game is 20180412 05:59:56<+discordbot> actually like to play. 20180412 06:04:25-!- travis-ci [~travis-ci@ec2-54-198-10-138.compute-1.amazonaws.com] has joined #wesnoth-dev 20180412 06:04:26< travis-ci> wesnoth/wesnoth#17570 (pf_custom_cost - 11b1a5c : Celtic Minstrel): The build failed. 20180412 06:04:26< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/365447116 20180412 06:04:26-!- travis-ci [~travis-ci@ec2-54-198-10-138.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180412 06:07:42< irker509> wesnoth/wesnoth:1.14 mattsc 1814ccf862 AI recruitment: fix units on recall list AppVeyor: 2/4 builds failed 20180412 06:07:43< irker509> Details vs2017/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-1.14-2300 20180412 06:07:44< irker509> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-1.14-2591 20180412 06:11:24-!- gallaecio [~quassel@119.red-83-34-169.dynamicip.rima-tde.net] has joined #wesnoth-dev 20180412 06:31:26<+discordbot> Almost three quarters of Steam users have 1080p displays, so 1920x1080 is definitely the best size for screenshots. 20180412 06:31:27<+discordbot> http://store.steampowered.com/hwsurvey 20180412 06:39:53<+discordbot> ok, let's go with that 20180412 06:44:35-!- gallaecio [~quassel@119.red-83-34-169.dynamicip.rima-tde.net] has quit [Ping timeout: 240 seconds] 20180412 06:46:55-!- gallaecio [~quassel@119.red-83-34-169.dynamicip.rima-tde.net] has joined #wesnoth-dev 20180412 06:52:40<+discordbot> @hrubymar10 yeah, I don't think they'll care 20180412 06:53:26<+discordbot> Who when why 20180412 06:53:30<+discordbot> they've had a windows bug sitting in their tracker for 11 years and haven't fixed it 20180412 06:53:34<+discordbot> https://github.com/wesnoth/wesnoth/issues/2859#issuecomment-380697582 20180412 06:53:42<+discordbot> Oh, those people. 20180412 06:54:33<+discordbot> @hrubymar10 If you can bisect the issue, it would be of huge help to Pango developers. 20180412 06:54:55<+discordbot> https://stackoverflow.com/a/4714297 20180412 06:55:32<+discordbot> sure, that's my motivation. Sadly I haven't have enough time these days 😦 . So hopefully later. 20180412 06:59:25<+discordbot> http://ftp.gnome.org/pub/GNOME/sources/pango/1.40/pango-1.40.2.changes 20180412 06:59:42<+discordbot> they actually keep a list of commits between versions 20180412 06:59:56<+discordbot> We do as well. :p 20180412 07:00:20<+discordbot> Everyone using Git does, they just don't necessarily know it yet. 20180412 07:00:30<+discordbot> Only about 20 commits. Bisecting shouldn't take that long, then. 20180412 07:01:06<+discordbot> commit 783544ddfc23225f894a26eb31fcc4bc3990ce22 Author: Kristian Rietveld Date: Sat Sep 5 22:52:48 2015 +0200 coretext: properly handle UTF32 characters in CFStrings pango/pangocoretext-shape.c | 72 +++++++++++++++++++++++++++++++++++++++------ 1 file changed, 63 insertions(+), 9 deletions(-) 20180412 07:01:16<+discordbot> This could possibly be problem 20180412 07:01:32<+discordbot> There seem to be a few coretext commits. 20180412 07:01:46<+discordbot> I would think the problem would have to do with how font weights are picked 20180412 07:01:56<+discordbot> if the problem only cropped up after i added the font variant 20180412 07:02:01<+discordbot> s 20180412 07:02:17<+discordbot> maybe the bug is in fontconfig... 20180412 07:02:20<+discordbot> Given that the bug is macOS-specific, it may have something to do with the coretext backend in particular. 20180412 07:03:39-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180412 07:03:56<+discordbot> Hey... wait a second. 20180412 07:04:01<+discordbot> commit fcec6f721d5254b9010814023f98f541ca798b02 Author: Behdad Esfahbod Date: Thu May 19 11:12:02 2016 -0700 Bug 766148 - CT font weights do not map correctly to PangoWeight 20180412 07:04:10<+discordbot> I bet CT stands for coretext. 20180412 07:04:52<+discordbot> I tested that If I keep newest libs for pango (libpango-1.0.0.dylib and libpango-1.0.0.dylib) and for cairo (libcairo.2.dylib) and replace only pango's libpangocairo-1.0.0.dylib then it works 20180412 07:05:13<+discordbot> Problematic part of pango should be pangocairo 20180412 07:05:24<+discordbot> fontconfig seems to not cause issues 20180412 07:05:52<+discordbot> fontconfig could potentially be used to force a workaround. 20180412 07:08:12<+discordbot> I don't remember exactly how much power Wesnoth takes from fontconfig for selecting fonts on non-Windows platforms, but it may be possible to use fontconfig to force it to select the Regular variant of the font in question instead of trying to go for Light where it shouldn't. 20180412 07:09:05<+discordbot> We already ship with a local fonts.conf to enforce certain rendering parameters across all platforms. https://www.freedesktop.org/software/fontconfig/fontconfig-user.html 20180412 07:09:26<+discordbot> I'll try build 1.40.1 with this patch applied https://github.com/GNOME/pango/commit/fcec6f721d5254b9010814023f98f541ca798b02 20180412 07:10:22<+discordbot> and if it's broken we knw it's the problem? 20180412 07:11:19<+discordbot> yes and then we will open issue at pango's tracker and as they won't have to debug it from scratch then they will be able to fix it soon 20180412 07:11:36<+discordbot> These lines look interesting, in particular: c if (value < ct_weight_min || value > ct_weight_max) { /* This is really an error */ weight = PANGO_WEIGHT_NORMAL; } 20180412 07:12:06<+discordbot> If font weight is below the minimum, normalize it to the default weight. What could possibly go wrong? 😛 --- Log opened Thu Apr 12 07:19:39 2018 20180412 07:19:53-!- lobby [~wesnoth@wesnoth/bot/lobby] has joined #wesnoth-dev 20180412 07:19:53-!- Topic for #wesnoth-dev: 1.13.14 (1.14 RC 3) scheduled for April 15th 00:01 UTC | String and feature freeze on 1.14 branch | Wesnoth Developers Channel | >>> Want to help? Go here: https://r.wesnoth.org/t42911 (and thanks!) <<< | Discord Server: https://discord.gg/battleforwesnoth | Logs: http://irclogs.wesnoth.org | Bug tracker: https://bugs.wesnoth.org 20180412 07:19:53-!- Topic set by shadowm [~iris@wesnoth/developer/shadowm] [Mon Apr 2 07:06:30 2018] 20180412 07:19:53[Users #wesnoth-dev] 20180412 07:19:53[+discordbot ] [ esr ] [ Jetrel_bot ] [ pydsigner] 20180412 07:19:53[ aeth ] [ galegosimpatico] [ Kawa[m] ] [ Ravana_ ] 20180412 07:19:53[ AI0867 ] [ gallaecio ] [ lobby ] [ Rhonda ] 20180412 07:19:53[ aidanhs ] [ Gambit ] [ loonycyborg ] [ shadowm ] 20180412 07:19:53[ APic ] [ grzywacz ] [ madmax28 ] [ Soliton ] 20180412 07:19:53[ Appleman1234 ] [ heirecka ] [ matthiaskrgr] [ syrma[m] ] 20180412 07:19:53[ ChipmunkV[m] ] [ higgins ] [ mattsc ] [ TC01 ] 20180412 07:19:53[ commavir ] [ iceiceice ] [ minzbonbon ] [ TheJJ ] 20180412 07:19:53[ crimson_penguin] [ irker509 ] [ nore ] [ timotei_ ] 20180412 07:19:53[ DDR ] [ Ivanovic ] [ nurupo ] [ vihta ] 20180412 07:19:53[ elias ] [ iwaim ] [ oldlaptop ] [ vincent_c] 20180412 07:19:53[ EliDupree ] [ janebot ] [ Polsaker ] [ vn971 ] 20180412 07:19:53-!- Irssi: #wesnoth-dev: Total of 48 nicks [0 ops, 0 halfops, 1 voices, 47 normal] 20180412 07:19:53-!- Home page for #wesnoth-dev: https://www.wesnoth.org 20180412 07:19:54<+discordbot> Could you file a bug report to Pango? 20180412 07:20:01-!- Channel #wesnoth-dev created Tue Jan 27 05:28:41 2009 20180412 07:20:06<+discordbot> .... wait a minute, what am I saying, they ARE on GitHub https://github.com/GNOME/pango 20180412 07:20:09<+discordbot> 🤦 20180412 07:20:51-!- Irssi: Join to #wesnoth-dev was synced in 66 secs 20180412 07:21:03<+discordbot> I think what's happening is that the font's weight is below the new minimum height (-0.7). Make sure that you provide a link to the font in the bug report. 20180412 07:21:32<+discordbot> Three clicks and https://wiki.gnome.org/Sysadmin/GitHub 20180412 07:21:35<+discordbot> https://github.com/wesnoth/wesnoth/blob/master/fonts/Lato-Hairline.ttf 20180412 07:21:43<+discordbot> "The GNOME Infrastructure is currently managing a mirror of git.gnome.org on GitHub." 20180412 07:22:52<+discordbot> @jyrkive according to http://www.latofonts.com/lato-free-fonts/, Hairline should be weight 100 20180412 07:22:57<+discordbot> 🤔 20180412 07:23:15<+discordbot> Yes, but CoreText has its own font weights. 20180412 07:23:35<+discordbot> That's why Pango has conversion from CT weights to Pango weights in the first place. 20180412 07:23:53<+discordbot> One more test and then yeah, I'll create an issue 20180412 07:25:37<+discordbot> surprisingly simple debug session 😛 20180412 07:26:08<+discordbot> It's not debugging if you won't use a debugger. 20180412 07:26:14<+discordbot> *don't 20180412 07:26:28<+discordbot> fair enough 20180412 07:27:28<+discordbot> BTW, something I've been wondering... IIRC, we don't build the windows pango lib with fontconfig, right? Would it make any difference on rendering? 20180412 07:27:32<+discordbot> if we did* 20180412 07:28:35<+discordbot> We do build it with fontconfig. There is fontconfig.dll in external\dll. 20180412 07:28:40<+discordbot> I see 20180412 07:28:42<+discordbot> 🤔 20180412 07:28:47<+discordbot> nevermind 20180412 07:29:08<+discordbot> oh, but wait, we don't have the fontconfig lib 20180412 07:29:19<+discordbot> We don't need it. 20180412 07:29:36<+discordbot> We'd need it if we linked directly to fontconfig and called its functions. 20180412 07:29:42<+discordbot> I see 20180412 07:29:51-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180412 07:29:54<+discordbot> But because it's only used by the rest of the GTK+ stack, the DLL is enough. 20180412 07:30:06<+discordbot> ah 20180412 07:30:07<+discordbot> makes sense 20180412 07:35:22<+discordbot> Ok, confirmed. I did some other test and I can now confirm, that this commit causes issue 20180412 07:36:39-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20180412 07:46:28<+discordbot> https://bugzilla.gnome.org/show_bug.cgi?id=795188 20180412 07:50:25< zookeeper> @Vultraz, i didn't test, but it looks like you made existing UtBS saves with the new units unloadable. 20180412 07:50:42<+discordbot> How so? 20180412 07:51:28<+discordbot> Difficulty defines? 20180412 07:51:30< zookeeper> because of a difficulty symbol mismatch 20180412 07:51:32< zookeeper> yeah 20180412 07:51:50< zookeeper> i'm not sure why i don't have any saves to test with, because i should have lots of them 20180412 07:52:13<+discordbot> Ah 20180412 07:52:23<+discordbot> Well it had to be done 20180412 07:52:37< zookeeper> no it didn't 20180412 07:53:20<+discordbot> The only option would be to maintain the new difficulty defines as aliases for the standard ones forever 20180412 07:54:09< zookeeper> is that a gut feeling or did you actually think about whether it's true? 20180412 07:54:28<+discordbot> Aliases aren't a burden to maintain. It's not a problem as far as I can see. 20180412 07:54:49<+discordbot> Invalidating existing saves is, on the other hand. 20180412 07:55:43<+discordbot> @zookeeper I thought about it 20180412 08:00:14<+discordbot> (Well, just now as you mentioned it) 20180412 08:00:21<+discordbot> If there’s another way, what is it? 20180412 08:02:09<+discordbot> And is it worth it 20180412 08:02:15<+discordbot> Ie, how many saves would be affected? 20180412 08:02:28<+discordbot> Especially since most people will start new games anyway 20180412 08:02:32<+discordbot> Saves don’t carry over 20180412 08:03:12< zookeeper> everyone who's started the campaign on 1.13.13 (or earlier)..? 20180412 08:04:45< zookeeper> anyway, sure the aliases would need to be maintained, but you can still change the difficulty symbols. i don't foresee any problem with that. 20180412 08:07:30< zookeeper> and that "is it worth it?" question doesn't even make any sense again. 20180412 08:15:40<+discordbot> Are you thinking something like ifdef easy define easy new? 20180412 08:16:02<+discordbot> If so that’s certainly simpler than what I was imagining 20180412 08:18:04< zookeeper> just a minute, testing it now... 20180412 08:19:13< zookeeper> yep, looks like the existing aliasing code is like magic, it works both ways as-is. 20180412 08:20:13<+discordbot> Existing? 20180412 08:21:06< zookeeper> well, the one that was part of what you removed. 20180412 08:21:43<+discordbot> can you restore it without UTBSNEW? 20180412 08:22:41< zookeeper> no, but that doesn't mean what you probably think it does 20180412 08:23:05<+discordbot> Probably 20180412 08:23:19<+discordbot> If you do restore it, please add a comment explaining why its there. 20180412 08:23:29< zookeeper> of course 20180412 08:23:46<+discordbot> and if possible, keep the difficulty defines standard 20180412 08:23:56<+discordbot> and avoid reparsing 20180412 08:24:00< zookeeper> of course 20180412 08:24:31< zookeeper> what do you mean, avoid reparsing? 20180412 08:24:44<+discordbot> you included utils twice 20180412 08:24:58<+discordbot> very likely what resulted in those redefinition warnings. 20180412 08:25:45< zookeeper> oh? i'm not sure if i can avoid it, checking... 20180412 08:26:32<+discordbot> well, that's not good 20180412 08:28:12< zookeeper> well, i can add in a local undef/redef of just that one macro that's needed. 20180412 08:28:13<+discordbot> In the long run, it would be nice to have some kind of require system, where attempting to load the same script a second time would just be ignored. 20180412 08:28:40<+discordbot> reparsing the entire file redefines every single macro 20180412 08:33:39<+discordbot> (I assume this change would only be for 1.14) 20180412 08:34:23< zookeeper> yes 20180412 08:46:29< zookeeper> well, this seems to work in all cases... 20180412 08:53:26-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180412 08:53:33-!- janebot_ [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180412 08:53:33-!- janebot_ is now known as janebot 20180412 08:54:41< zookeeper> although the code is certainly less icky if i just keep the re-parsing of utils.cfg, so considering how the redef warnings would _only_ pop up when loading an older save, that seems okay. 20180412 09:05:05< irker509> wesnoth: Iris Morelle wesnoth:1.14 d4c0783914eb / data/multiplayer/scenarios/2p_Aethermaw.cfg: Add team colouring to some Aethermaw props missing it https://github.com/wesnoth/wesnoth/commit/d4c0783914eb9385e7c59dd8542a73d79df12768 20180412 09:05:12< irker509> wesnoth: Iris Morelle wesnoth:master 8c97458a76b1 / data/multiplayer/scenarios/2p_Aethermaw.cfg: Add team colouring to some Aethermaw props missing it https://github.com/wesnoth/wesnoth/commit/8c97458a76b1a7303e23c2008cb069b0ffdd6724 20180412 09:09:14<+discordbot> How come you need to reparse it again? 20180412 09:09:59<+discordbot> @zookeeper does it use difficulty macros? 20180412 09:10:10< zookeeper> as said, to avoid having to duplicate the actual macro definition, because that's ickier. 20180412 09:12:00<+discordbot> @zookeeper no, but IIRC there was one macro that checked UTBSNEW 20180412 09:12:00-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20180412 09:12:07<+discordbot> right? 20180412 09:12:16<+discordbot> nothing about difficulty macrsos 20180412 09:12:18<+discordbot> macros 20180412 09:12:35< zookeeper> wrong, there's no macros checking for UTBSNEW 20180412 09:12:36-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180412 09:13:24<+discordbot> there was conditional code inside INCREASE_RECRUIT_COSTS 20180412 09:14:45< zookeeper> oh, that. yeah it's of no concern. 20180412 09:14:49<+discordbot> you haven't explained what macro is the problem 20180412 09:15:08< zookeeper> ON_DIFFICULTY 20180412 09:15:32< irker509> wesnoth: Iris Morelle wesnoth:master cfd5d5289d94 / changelog.md: Update changelog https://github.com/wesnoth/wesnoth/commit/cfd5d5289d94aad69b5ef6ed3433e001ef224b49 20180412 09:15:37< irker509> wesnoth: Iris Morelle wesnoth:1.14 05b464aadfe1 / changelog.md: Update changelog https://github.com/wesnoth/wesnoth/commit/05b464aadfe1c531578e54331ff8a53b371f48c6 20180412 09:15:56<+discordbot> Argh. 20180412 09:16:16<+discordbot> Of course I spot the grammar mistake after pushing. 20180412 09:16:42<+discordbot> but ON_D checks the default difficulty macros 20180412 09:16:55<+discordbot> which were defined if you used the custom ones 20180412 09:17:02<+discordbot> and now we use the default ones 20180412 09:17:12<+discordbot> so what's the problem 20180412 09:18:17< zookeeper> no! ON_D is _only defined_ if one of the default difficulty symbols is used. hence, when you load a save that has EASY_NEW, ON_D does not get defined. which is why i re-parse core utils.cfg (or add a redef of ON_D, whichever) _after_ the compatibility code does that #ifdef EASY_NEW #define EASY aliasing. 20180412 09:19:15< zookeeper> make sense? 20180412 09:20:11<+discordbot> gah 20180412 09:20:14<+discordbot> I guess 20180412 09:28:53<+discordbot> @Vultraz A problem with your "fix" for #2874 is that now the game just closes the help window when encountering invalid markup. 20180412 09:29:23<+discordbot> I think he knows about that already. 20180412 09:29:31<+discordbot> It'd be preferrable to emit an error message into the help topic itself (as well as stderr -- currently there's no indication that anything happened at all). 20180412 09:30:57<+discordbot> I don't know if he knows but it's worth reminding him anyway, especially since this can legitimately crop up either due to defective translations (as with #2874 proper) or mistakes in the descriptions of custom abilities, etc. 20180412 09:31:16<+discordbot> (Assuming the latter aren't escaped in 1.13.x.) 20180412 09:33:02<+discordbot> Ugh. 20180412 09:33:24<+discordbot> Just line in 1.12.x, the Editor help entries are 40-60% "TODO" placeholders. 20180412 09:34:02<+discordbot> And this: 20180412 09:34:02<+discordbot> https://cdn.discordapp.com/attachments/259976436490829825/433922734280671243/unknown.png 20180412 09:34:13<+discordbot> I guess no one is really willing to work on Editor help. 20180412 09:34:23<+discordbot> I wonder if we should just remove the placeholders. 20180412 09:34:39<+discordbot> The section can be commented out using #ifdef 0 or so. 20180412 09:35:14<+discordbot> I don't know if that's what Vultraz wants, since evidently there must be a reason why the scenario editor functionality is still around. 20180412 09:36:47<+discordbot> What on earth... Two of the Deep Water terrain help entries have the black background outside the hex area, one of them doesn't. 20180412 09:38:14<+discordbot> The two entries that have the black background are referencing indexed PNGs. 20180412 09:39:01<+discordbot> data/core/images/terrain/water/ocean-{tropical,grey}-tile.png, to be specific (as per the respective [terrain] symbol_image attributes. 20180412 09:39:25< irker509> wesnoth/wesnoth:pf_custom_cost Celtic Minstrel 11b1a5cba4 wesnoth.find_path: Allow specifying cust AppVeyor: vs2017/Release Failed 20180412 09:39:26< irker509> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-pf_custom_cost-2320 20180412 09:41:03<+discordbot> Lava has the same problem, probably others as well. 20180412 09:50:28< irker509> wesnoth/wesnoth:1.14 Celtic Minstrel 7fe49c134c MicroAI Tests: Fix issues found by the s AppVeyor: All builds passed 20180412 09:51:47-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20180412 09:52:23-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180412 10:03:25< zookeeper> for what it's worth, i don't see that on 1.13.13. 20180412 10:12:19< zookeeper> and for pre-emptive clarity, there's nothing wrong with indexed/paletted png's and you can have transparency in a paletted image (such as in unwalkable/lava-tile.png). 20180412 10:13:56< zookeeper> (so the fix should not be "make sure we use 32-bit everywhere") 20180412 10:30:25<+discordbot> Vultraz has already implemented converting indexed images to RGBA at load time. 20180412 10:30:39<+discordbot> So you can store them as indexed on disk, no problem. 20180412 10:31:10<+discordbot> Then what's special about the help topics? 20180412 10:32:32<+discordbot> Figuring that out would require debugging. 20180412 10:32:43<+discordbot> Maybe help bypasses the image cache manager? 20180412 10:34:36<+discordbot> I'd be concerned if that were the case. 20180412 10:35:07<+discordbot> Does that change apply to all images, or only images of a certain kind? IIRC there are four kinds of images that can be loaded through the cache manager. 20180412 10:35:24<+discordbot> Something, something, scaled to hex, scaled to zoom, or so. 20180412 10:35:58<+discordbot> I think one of the somethings has ToD tint applied to it. 20180412 10:36:00<+discordbot> It's in load_image_file(): https://github.com/wesnoth/wesnoth/blob/f78e32c7f88b631f577e88315634ada43098885e/src/image.cpp#L590 20180412 10:36:20<+discordbot> I think load_image_file() is used for all image kinds. 20180412 10:43:05<+discordbot> very odd... 20180412 10:43:25<+discordbot> @shadowm the help entries can be commented out 20180412 10:43:51<+discordbot> @shadowm I also don't know if it's possible to display one topic in a error state 20180412 10:44:03<+discordbot> as far as I could tell during refactoring, a single error brings the entire system down 20180412 10:44:17<+discordbot> because the parse_error exception is caught at toplevel 20180412 10:44:20<+discordbot> The error doesn't come from the topic gen? 20180412 10:44:34<+discordbot> it propagates to toplevel 20180412 10:44:36<+discordbot> Does something block you from catching it lower down, then? 20180412 10:44:42<+discordbot> ^ 20180412 10:45:11<+discordbot> I already do so in master, ftr. 20180412 10:45:35<+discordbot> as for 1.14... 20180412 10:45:46<+discordbot> it could be done, I think, but I don't know if it would break things... 20180412 10:46:58<+discordbot> the code is beyond messy, and I had a hard enough time picking through the rubble when I refactored it. I don't want to somehow break the system so close to release. 20180412 10:47:45<+discordbot> the issue with the popup not appearing is unfixable on 1.14, I think, so the best best is probably a cerr message 20180412 10:49:15-!- vladimirslavik [vslavik@nat/redhat/x-qnvcfbflgdscvpce] has joined #wesnoth-dev 20180412 10:49:25<+discordbot> though 20180412 10:49:47<+discordbot> come to think of it, I didn't reintegrate the popups on master either 😬 20180412 10:49:51<+discordbot> I just made them log messages 20180412 10:53:06<+discordbot> (and yes, I am aware I sound like a bit of a hypocrite now advocating caution and careful consideration when it comes to changes in master 😬 ) 20180412 10:53:29<+discordbot> Took you long enough. 20180412 10:53:37<+discordbot> I'm glad to see you're avoiding risky changes. 😃 20180412 11:35:08-!- vladimirslavik [vslavik@nat/redhat/x-qnvcfbflgdscvpce] has quit [Remote host closed the connection] 20180412 11:36:11-!- vladimirslavik [vslavik@nat/redhat/x-fntyginixootslbr] has joined #wesnoth-dev 20180412 11:46:13< irker509> wesnoth: loonycyborg wesnoth:master 19d9e150e15e / src/server/server.cpp: Fix issue #1757: prevent abnormal termination if failed to bind address https://github.com/wesnoth/wesnoth/commit/19d9e150e15ef811a2a395dbce874086c5efe216 20180412 11:47:53< irker509> wesnoth: loonycyborg wesnoth:1.14 bb14c3bc217f / src/server/server.cpp: Fix issue #1757: prevent abnormal termination if failed to bind address https://github.com/wesnoth/wesnoth/commit/bb14c3bc217fd70c3dc3e3ea0c9eb777c95d7979 20180412 11:49:39<+discordbot> that's very weird 20180412 11:49:54<+discordbot> "host networked game" option doesn't work for me 20180412 11:50:05<+discordbot> because std::system always returns -1 20180412 11:50:37<+discordbot> even when server is started successfully 20180412 11:51:13<+discordbot> if I just make it proceed with that return value anyway it works fine 20180412 11:51:21<+discordbot> http://en.cppreference.com/w/cpp/utility/program/system says that the return value of system() is implementation-defined. 20180412 11:51:51<+discordbot> yeah 20180412 11:52:01-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20180412 11:52:10<+discordbot> but it's supposed to match program's return code on posix systems at least 20180412 11:52:19-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180412 11:52:22<+discordbot> should I remove return value check then? 20180412 11:53:41-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20180412 11:53:57-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180412 11:56:51-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20180412 11:57:08-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180412 11:58:30<+discordbot> Does it even return to begin with? As a server program, wesnothd is supposed to stay running. 20180412 11:58:55<+discordbot> client runs it with -d option 20180412 11:59:11<+discordbot> -d option makes wesnothd fork itself and return 0 immediately 20180412 11:59:33<+discordbot> but even in this case std::system returns -1 anyway 20180412 11:59:42<+discordbot> Hmm. I wonder if it's working correctly (if the return code really is 0). 20180412 12:00:20<+discordbot> std::system always returns -1 20180412 12:00:28<+discordbot> wesnothd never uses -1 as return code 20180412 12:00:40-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20180412 12:00:49<+discordbot> if I neuter return value everything works just fine 20180412 12:00:57<+discordbot> Okay. In that case I think it would be best to disable the return code check on GNU/Linux. 20180412 12:00:58<+discordbot> it starts local server and connects to it 20180412 12:01:20<+discordbot> You could also complain to GNU about the useless return value. 20180412 12:01:42<+discordbot> maybe it's something about my distro 20180412 12:01:46<+discordbot> or gcc version 20180412 12:02:03<+discordbot> Yes, it may well be distro-specific. 20180412 12:02:05-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180412 12:02:06<+discordbot> maybe you could test it yourself too 20180412 12:02:26<+discordbot> Wouldn't take long to test. I can try it in the evening. 20180412 12:02:31<+discordbot> cool 20180412 12:03:07<+discordbot> also try the case when you try to run "host local server" when one already runs 20180412 12:03:58-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20180412 12:04:16-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180412 12:07:37-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20180412 12:07:56-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180412 12:08:56< irker509> wesnoth/wesnoth:1.14 Celtic Minstrel 25b30608f9 Update changelog.md AppVeyor: All builds passed 20180412 12:11:46-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20180412 12:12:05-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180412 12:12:48<+discordbot> just to let you guys know, the mobile version says “unit sighted, press t to continue” 20180412 12:13:08<+discordbot> @sinda See above. 20180412 12:13:18<+discordbot> (Sinda is the maintainer of the iOS port.) 20180412 12:13:38-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20180412 12:13:56-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180412 12:21:57<+discordbot> finally caved in and bought it for long shifts lol 20180412 12:25:50<+discordbot> @jyrkive was just trying to convert uses of boost::thread to std::thread, and I came across a use of boost::thread::timed_join Boost says it's deprecated, and there seems to be no std equivalent. However... I'm confused as to why it's being called with a time value of 0. Ie: cpp timed_join(boost::posix_time::milliseconds(0)) Boost's docs say:If *this refers to a thread of execution, waits for that thread of execution to complete, 20180412 12:25:51<+discordbot> the specified duration rel_time has elapsed. " So if given a time of 0, doesn't that mean that it simply returns immediately if the thread 20180412 12:25:55<+discordbot> is active? 20180412 12:26:08<+discordbot> "true if *this refers to a thread of execution on entry, and that thread of execution has completed before the call times out, false otherwise." 20180412 12:26:11<+discordbot> but time is 0 20180412 12:26:21<+discordbot> so it seems if the thread is active, it should always return false 20180412 12:26:34<+discordbot> in which case the function would be std::thread::joinable 20180412 12:27:37<+discordbot> With std::thread::joinable() there would be a slight race condition: it's possible that the thread finishes right after querying it. 20180412 12:27:51<+discordbot> IDK if it would be a problem in practice. 20180412 12:29:21<+discordbot> but wouldn't there be the same issue with timed_join? 20180412 12:29:46<+discordbot> it doesn't delay at all 20180412 12:30:56<+discordbot> timed_join() can, in theory, be atomic so that the thread cannot finish between querying if it's joinable and attempting to join it. 20180412 12:42:03-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180412 12:42:09-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180412 12:57:04-!- vladimirslavik [vslavik@nat/redhat/x-fntyginixootslbr] has quit [Ping timeout: 268 seconds] 20180412 13:17:33-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20180412 13:17:51-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180412 13:21:53-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20180412 13:22:28-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180412 13:26:29-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20180412 13:27:08-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180412 13:32:09-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20180412 13:32:48-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180412 13:39:35-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: So long and thanks for all the fish.] 20180412 13:49:48-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20180412 13:50:24-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180412 13:58:20< irker509> wesnoth/wesnoth:master Celtic Minstrel 191c23c194 Update changelog.md AppVeyor: All builds passed 20180412 13:59:49-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20180412 14:00:27-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180412 14:03:46<+discordbot> Difference between boost and std:: thread: the latter calls std::terminate if it's destroyed while joinable. 20180412 14:04:00<+discordbot> took me an hour of reading to figure out the solution is to call thread::detach 20180412 14:06:16<+discordbot> And as for the timed_join issue, I changed it to just use the is_worker_running_ variable 😛 20180412 14:09:14< irker509> wesnoth: Charles Dang wesnoth:master 2edcbdced860 / src/ (5 files in 2 dirs): Convert uses of boost::thread to std::thread https://github.com/wesnoth/wesnoth/commit/2edcbdced8608936c50a9ec1e54ca07644d713d7 20180412 14:37:28-!- travis-ci [~travis-ci@ec2-54-162-215-241.compute-1.amazonaws.com] has joined #wesnoth-dev 20180412 14:37:29< travis-ci> wesnoth/wesnoth#17573 (master - 2edcbdc : Charles Dang): The build was broken. 20180412 14:37:29< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/365630593 20180412 14:37:29-!- travis-ci [~travis-ci@ec2-54-162-215-241.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180412 14:39:25< irker509> wesnoth/wesnoth:pf_custom_cost Celtic Minstrel 11b1a5cba4 wesnoth.find_path: Allow specifying cust AppVeyor: 2/4 builds failed 20180412 14:39:26< irker509> Details vs2017/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-pf_custom_cost-2320 20180412 14:39:27< irker509> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-pf_custom_cost-2611 20180412 14:53:47<+discordbot> ☹️ 20180412 15:13:18-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev 20180412 15:17:09<+discordbot> @jyrkive Coming back to my C++ question, so I remove the 'const' at the beginning of the function definition (in both .hpp and .cpp, I assume). Do I also remove it for the variable when I call the function here: 20180412 15:17:11<+discordbot> https://github.com/wesnoth/wesnoth/pull/2876/commits/11e91e04fea30165d93c0f2ceab64b39f9af83d0#diff-3fb455a3a4de1643cd04e57473b1b564R265 20180412 15:17:59<+discordbot> My Xcode build does not complain about it when I leave it in, but clang didn't mind how it was before either. 20180412 15:26:36-!- atarocch [~atarocch@93.56.164.28] has joined #wesnoth-dev 20180412 15:28:29<+discordbot> no 20180412 15:33:17<+discordbot> @jyrkive if I join instead of detach in the wesnothd_connection dtor, the game just hangs :/ 20180412 15:33:56<+discordbot> @jyrkive also, I'm not sure joining the thread in the timer callback makes sense? Wouldn't it mean the callback never completes? 20180412 15:39:42<+discordbot> @Vultraz Was that a reply to my question? 20180412 15:41:27<+discordbot> The no, yes 20180412 15:41:54<+discordbot> Okay. Thanks. 20180412 15:46:47-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev 20180412 15:47:19-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Excess Flood] 20180412 15:48:04-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev 20180412 15:52:55<+discordbot> Alright, so I think I figured out how to fix that, squash the commits, and update the PR without screwing things up for other people. 😛 20180412 15:53:15<+discordbot> So now I guess I wait for travis to do its thing again? Even though it will fail with other problems? 20180412 15:54:16<+discordbot> Actually, I might as well add the other fix (recall cost by unit) that gfgtdf mentioned to this PR. 20180412 16:00:11<+discordbot> It will fail since I just happened to break master again xD 20180412 16:01:11<+discordbot> @mattsc Doesn't matter. You can leave it in. 20180412 16:06:00<+discordbot> @Vultraz Try calling io_service_.stop() before joining the thread. 20180412 16:06:01<+discordbot> https://www.boost.org/doc/libs/1_57_0/doc/html/boost_asio/reference/io_service/stop.html 20180412 16:06:05<+discordbot> @jyrkive Thanks 20180412 16:06:17<+discordbot> I tried that. No luck. 20180412 16:08:05<+discordbot> Hmm, that's strange... 20180412 16:08:33<+discordbot> Another thing is that the worker thread keeps around a reference to the wesnothd_connection object. 20180412 16:08:34<+discordbot> https://github.com/wesnoth/wesnoth/blob/2edcbdced8608936c50a9ec1e54ca07644d713d7/src/wesnothd_connection.cpp#L154 20180412 16:08:51<+discordbot> It shouldn't even be possible to call the destructor as long as the thread is running. 20180412 16:09:07<+discordbot> (And when it's finished, joining the thread should succeed immediately.) 20180412 16:10:14<+discordbot> That’s a good point... 20180412 16:15:41<+discordbot> I guess that for now we can just leave the detach() there to match boost::thread semantics. 20180412 16:16:02<+discordbot> It's still highly suspicious and dangerous-looking code, though. 20180412 16:17:39<+discordbot> And you're right regarding the timer callback. However, AFAIK it's common practice to detach a thread immediately after creating it, instead of right before losing the reference to it. 20180412 16:20:28<+discordbot> @loonycyborg I can reproduce your problem. system() returns a nonzero value even though the server starts successfully. 20180412 16:23:49<+discordbot> And I can also confirm that the process exit code is zero: sh jyrki@siductionbox:~/wesnoth$ ./wesnothd -c /home/jyrki/.config/wesnoth/lan_server.cfg -d -t 2 -T 5 Started wesnothd as a daemon with process id 25171 20180412 19:22:44 info server: Server configuration from file: '/home/jyrki/.config/wesnoth/lan_server.cfg' read. jyrki@siductionbox:~/wesnoth$ 20180412 19:22:44 error server: could not make fifo at 20180412 16:23:49<+discordbot> '/var/run/wesnothd/socket' (No such file or directory) jyrki@siductionbox:~/wesnoth$ echo $? 0 20180412 16:25:43<+discordbot> I’ll have to look at it more tomorrow.. the boost unit tests are failing. Something with that detach call. 20180412 16:30:29< irker509> wesnoth: Jyrki Vesterinen wesnoth:1.14 64ef0eb1e683 / / (6 files in 3 dirs): Hotkey manager: drop duplicate commands https://github.com/wesnoth/wesnoth/commit/64ef0eb1e6830fc61a617a094b6f0cbb6cf97dfc 20180412 16:30:31< irker509> wesnoth: Jyrki Vesterinen wesnoth:1.14 47d83b44b2b1 / / (6 files in 3 dirs): Merge branch 'hotkey-event-buffer' into 1.14 https://github.com/wesnoth/wesnoth/commit/47d83b44b2b17461d96d5550b259bfa6e9958431 20180412 16:47:53< irker509> wesnoth: Jyrki Vesterinen wesnoth:master 8667e5bbdd3d / / (6 files in 3 dirs): Hotkey manager: drop duplicate commands https://github.com/wesnoth/wesnoth/commit/8667e5bbdd3d2a92e966a15f12a3753b9e3c283f 20180412 17:15:56-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: So long and thanks for all the fish.] 20180412 17:27:28-!- travis-ci [~travis-ci@ec2-54-91-135-84.compute-1.amazonaws.com] has joined #wesnoth-dev 20180412 17:27:29< travis-ci> wesnoth/wesnoth#17576 (master - 8667e5b : Jyrki Vesterinen): The build is still failing. 20180412 17:27:29< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/365706534 20180412 17:27:29-!- travis-ci [~travis-ci@ec2-54-91-135-84.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180412 17:49:52<+discordbot> @jyrkive I think it used to work for me before 20180412 17:50:27<+discordbot> I'm not sure we can ignore return value 20180412 17:50:43<+discordbot> maybe we'll have to call C variant of that function instead 20180412 17:56:25-!- gallaecio [~quassel@119.red-83-34-169.dynamicip.rima-tde.net] has quit [Remote host closed the connection] 20180412 17:58:08< irker509> wesnoth/wesnoth:master loonycyborg 19d9e150e1 Fix issue #1757: prevent abnormal termin AppVeyor: All builds passed 20180412 18:01:23<+discordbot> If the C++ variant returns a wrong value, I doubt that the C variant would work any better. 20180412 18:01:46<+discordbot> They should be just different aliases of the same function. 20180412 18:14:57-!- gallaecio [~quassel@188.79.96.255] has joined #wesnoth-dev 20180412 18:25:46-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity] 20180412 18:31:46-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180412 18:31:53-!- janebot_ [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180412 18:31:53-!- janebot_ is now known as janebot 20180412 18:32:40-!- vladimirslavik [vslavik@nat/redhat/x-coitxeixeigedizu] has joined #wesnoth-dev 20180412 18:34:39<+discordbot> C function is required to return real status by std 20180412 18:34:52<+discordbot> I think there might be bug in C++ wrapper 20180412 18:37:26< Soliton> seems very unlikely but probably easy enough to test. 20180412 18:37:33<+discordbot> And in general, the C++ specification simply states that the C standard library is included (by referencing the C specification) and adds that the C++ wrapper headers simply put the C standard library functions to the std namespace. 20180412 18:38:28<+discordbot> system is a bit more complex I think 20180412 18:38:46-!- vladimirslavik [vslavik@nat/redhat/x-coitxeixeigedizu] has quit [Ping timeout: 264 seconds] 20180412 18:44:46< Soliton> it'd be better to not use system anyway though since we don't just issue a fixed command. 20180412 18:45:45< Soliton> so currently it's shell injection which will fail depending on the path wesnothd or the config is in. 20180412 18:48:50<+discordbot> well at least std::system is cross-platform 20180412 18:48:57<+discordbot> what else we can use? 20180412 18:49:20<+discordbot> conditional compilation that does fork/exec or uses winapi? 20180412 18:49:23<+discordbot> At this rate we need platform-specific code anyway (at least ignoring the return value on GNU/Linux). 20180412 18:50:12<+discordbot> or boost.process maybe 😛 20180412 18:50:40< Soliton> we should use some exec function that we can hand the arguments in a list instead of building a shell command. 20180412 18:51:16< Soliton> the shell command is already platform specific. 20180412 18:51:48<+discordbot> yeah, I can figure out this part 20180412 18:52:07<+discordbot> the question is does fork and winapi cover all systems we support? 20180412 18:52:18<+discordbot> I guess fork/exec will work on mac at least 20180412 18:52:39< Soliton> that'd still be posix+windows, right? 20180412 18:52:48< Soliton> so same as now i'd imagine. 20180412 18:53:59<+discordbot> hmm yes 20180412 18:54:08<+discordbot> we used to support more exotic stuff like beos 20180412 18:54:15<+discordbot> but I think its support is removed already 20180412 18:54:35<+discordbot> I suggest posix_spawn(), it's easier to use than fork/exec: https://linux.die.net/man/3/posix_spawn 20180412 18:56:12< Soliton> anything that takes a list of arguments is better than what we have now. 20180412 18:56:26< Soliton> need something for windows as well though. 20180412 18:56:42<+discordbot> On Windows there is CreateProcess(). 20180412 18:57:01<+discordbot> We could also continue to use system(), it seems to work fine on Windows. 20180412 18:57:50<+discordbot> iirc CreateProcess() takes single string and not a list 20180412 18:58:04<+discordbot> but I guess there's nothing better on winapi 20180412 18:58:31< Soliton> if a path with double quotes is allowed on windows it does not work fine there either. 20180412 18:58:39<+discordbot> Indeed, it receives parameters as a string. 20180412 18:58:51<+discordbot> See https://github.com/wesnoth/wesnoth/blob/master/src/wesnoth.cpp#L966 for an example. 20180412 18:59:11<+discordbot> (I wrote it, so if you have any questions about it, you can ask me.) 20180412 19:00:44< Soliton> that re-uses the existing (known good) commandline though afaict. 20180412 19:00:56<+discordbot> Indeed. 20180412 19:04:09< Soliton> i mean it's very unlikely people will install into a path with double quotes (which is why that code survived for so long) but that will definitely break start_wesnothd(). 20180412 19:06:55<+discordbot> https://github.com/loonycyborg/scons-plusplus/blob/master/src/util.cpp#L142 20180412 19:07:06<+discordbot> maybe I should reuse this func I made 20180412 19:09:39<+discordbot> I don't think double quotes are allowed in filesystem object names on Windows. 20180412 19:10:54<+discordbot> They are used to ensure that paths with spaces are parsed correctly, though, e.g. "C:\Program Files\foo\bar.exe" /parameter1 /parameter2 -- otherwise that would be interpreted as C:\Program Files\foo\bar.exe /parameter1 /parameter2 (the first argument is "Files\foo\bar.exe"). 20180412 19:12:35<+discordbot> Wesnoth itself suffered from that problem, which is why I ended up writing restart_process() in the first place: https://github.com/wesnoth/wesnoth/pull/571 20180412 19:13:00< Soliton> if quotes are not allowed then we just need to check what else is interpreted in double quotes on windows. 20180412 19:14:30< Soliton> like for posix sh you'd have variable expansion and backslash escapes. i have not much clue about windows though. 20180412 19:18:02<+discordbot> Is this a right place to ask UMC dev questions? Or it's only for core game dev? 20180412 19:18:34<+discordbot> You can ask UMC development questions here. 20180412 19:22:51<+discordbot> Nice 😃 Is there any way to modify healing value of a village? Currently i'm replacing all existing map tiles (only village overlay) with my newly defined terrain_type. It works, but it effects the visual side (all original villages will change their appearance). 20180412 19:24:00< Ravana_> you can modify healing value of all villages, but not specific village 20180412 19:25:37<+discordbot> Should work for me. Is there a constant that overrides all village specific healing value? 20180412 19:28:47< Ravana_> see wesnoth.game_config documentation 20180412 19:29:41< Ravana_> https://wiki.wesnoth.org/LuaWML/Misc#wesnoth.game_config 20180412 19:32:05<+discordbot> There is no such thing in [game_config] The healing amount comes from [terrain_type]->heals attribute. 20180412 19:41:57< irker509> wesnoth: Severin Glöckner wesnoth:1.14 c9c676b761eb / README.md: INSTALL had been renamed to INSTALL.md https://github.com/wesnoth/wesnoth/commit/c9c676b761eb8d2efed681c72bcce66f87647b5f 20180412 19:43:12< irker509> wesnoth: Severin Glöckner wesnoth:master 7d427aedee8f / README.md: INSTALL had been renamed to INSTALL.md https://github.com/wesnoth/wesnoth/commit/7d427aedee8ff5e8cec2866e3aee2d041ecc1a50 20180412 19:54:22-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180412 19:54:28-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180412 19:58:46< Ravana_> it is good that [game_config] is only usable for cores in that case 20180412 20:08:44< irker509> wesnoth: Severin Glöckner wesnoth:1.14 6a085e490f17 / data/multiplayer/scenarios/ (2p_Dark_Forecast.cfg 4p_A_New_Land.cfg): remove unneded keys https://github.com/wesnoth/wesnoth/commit/6a085e490f1798ec931b5c4a13266b6663c38869 20180412 20:09:39< irker509> wesnoth: Severin Glöckner wesnoth:master 533c7e9822b0 / data/multiplayer/scenarios/ (2p_Dark_Forecast.cfg 4p_A_New_Land.cfg): remove unneded keys https://github.com/wesnoth/wesnoth/commit/533c7e9822b097fd8cc7502d8362d0345b29d022 20180412 20:22:47< irker509> wesnoth/wesnoth:1.14 loonycyborg bb14c3bc21 Fix issue #1757: prevent abnormal termin AppVeyor: All builds passed 20180412 20:27:55-!- sevu [~Shiki@p5485585D.dip0.t-ipconnect.de] has joined #wesnoth-dev 20180412 20:28:17-!- sevu [~Shiki@p5485585D.dip0.t-ipconnect.de] has quit [Client Quit] 20180412 20:30:04-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20180412 20:32:22-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180412 20:35:41-!- DeFender1 [~danf@2601:155:4301:341d:a155:533f:1841:7072] has joined #wesnoth-dev 20180412 20:50:12<+discordbot> @jyrkive @blarghy-y4 Thanks, that's a known problem (or' rather, piece of work): https://github.com/singalen/wesnoth/issues/21 20180412 20:50:31<+discordbot> ah cheers 20180412 20:51:00<+discordbot> another minor thing - when i open it, the title screen is one way up, but then the main menu and game are the other way up 20180412 20:53:00<+discordbot> PMed. Thanks! 20180412 21:03:33-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180412 21:03:39-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180412 21:06:21-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 264 seconds] 20180412 21:06:36-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev 20180412 21:17:51-!- matthiaskrgr [matthiaskr@gateway/shell/panicbnc/x-umtglvwjcutuehdl] has quit [Ping timeout: 240 seconds] 20180412 21:22:59<+discordbot> I have a question to how dehydration is working: 20180412 21:23:33<+discordbot> One loses 4 HP per turn and has -1 damage when being in the desert on day 20180412 21:23:53<+discordbot> When being in the keep instead, one doesn't lose HP 20180412 21:24:08<+discordbot> but why does the dehydrated status and icon still remain? 20180412 21:33:11<+discordbot> afaik, castles and grass (and healers) stop dehydration getting worse - i.e. no damage 20180412 21:33:34<+discordbot> but only standing in water can make it better - i.e. remove the damage modifier 20180412 21:38:01<+discordbot> What campaign is this? 20180412 21:38:33-!- gallaecio [~quassel@188.79.96.255] has quit [Remote host closed the connection] 20180412 21:38:39-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20180412 21:43:40<+discordbot> UtBS 20180412 22:03:45-!- DeFender1 [~danf@2601:155:4301:341d:a155:533f:1841:7072] has quit [Read error: Connection reset by peer] 20180412 22:04:10-!- DeFender1 [~danf@2601:155:4301:341d:a155:533f:1841:7072] has joined #wesnoth-dev 20180412 22:13:41-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev 20180412 22:20:09-!- matthiaskrgr [matthiaskr@gateway/shell/panicbnc/x-ihchowyaftepsbvb] has joined #wesnoth-dev 20180412 22:20:32-!- matthiaskrgr is now known as Guest2936 20180412 22:30:07-!- heirecka [~heirecka@exherbo/developer/heirecka] has quit [Ping timeout: 256 seconds] 20180412 22:37:20-!- DeFender1 [~danf@2601:155:4301:341d:a155:533f:1841:7072] has quit [Ping timeout: 255 seconds] 20180412 22:39:52-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection] 20180412 23:00:47-!- grzywacz [~karol@89-70-226-147.dynamic.chello.pl] has quit [Ping timeout: 268 seconds] 20180412 23:12:37-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20180412 23:23:15-!- irker509 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout] 20180412 23:25:04-!- irker683 [~irker@uruz.ai0867.net] has joined #wesnoth-dev 20180412 23:25:04< irker683> wesnoth: Charles Dang wesnoth:master acc3fe890611 / src/ (3 files in 2 dirs): Refactor out custom wesnothd_connection_ptr class again https://github.com/wesnoth/wesnoth/commit/acc3fe890611b54c8493acafc33f1e78832b65dc 20180412 23:25:10<+discordbot> second time's a charm 20180412 23:32:44< irker683> wesnoth/wesnoth:1.14 Jyrki Vesterinen 47d83b44b2 Merge branch 'hotkey-event-buffer' into AppVeyor: All builds passed 20180412 23:39:52-!- travis-ci [~travis-ci@ec2-54-162-215-241.compute-1.amazonaws.com] has joined #wesnoth-dev 20180412 23:39:53< travis-ci> wesnoth/wesnoth#17578 (master - acc3fe8 : Charles Dang): The build is still failing. 20180412 23:39:53< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/365869147 20180412 23:39:53-!- travis-ci [~travis-ci@ec2-54-162-215-241.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180412 23:40:11<+discordbot> oops, I think I forgot to update the tests 20180412 23:42:21-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20180412 23:42:57-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180412 23:43:02< irker683> wesnoth: Charles Dang wesnoth:master 7767902261e6 / src/tests/gui/test_gui2.cpp: Update tests for acc3fe8 https://github.com/wesnoth/wesnoth/commit/7767902261e60f64a541cac11d647b0075ea1049 20180412 23:46:26-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20180412 23:49:54< irker683> wesnoth: Charles Dang wesnoth:master fee641516b3f / src/tests/gui/test_gui2.cpp: Fixup 7767902 https://github.com/wesnoth/wesnoth/commit/fee641516b3f3ac954aa787d3625e254d652a86c 20180412 23:58:06-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev 20180412 23:59:14< celticminstrel> gfgtdf can you please document add_widget_definition... --- Log closed Fri Apr 13 00:00:40 2018