--- Log opened Fri Apr 13 00:00:40 2018 20180413 00:03:15< irker683> wesnoth: Severin Glöckner wesnoth:1.14 bdf9523b65be / data/campaigns/Dead_Water/units/Brawler.cfg: update 2nd stunned event as well with additions from 1.13.2 https://github.com/wesnoth/wesnoth/commit/bdf9523b65be1f3a90a585cc4cc41f87aa3d72e0 20180413 00:04:05<+discordbot> please forward-port 20180413 00:04:21< celticminstrel> I'll cherry-pick it as soon as I get on Windows. 20180413 00:04:27< celticminstrel> But that might not be for an hour or so. 20180413 00:04:38<+discordbot> alright 20180413 00:05:09<+discordbot> damn, some tests still failing 20180413 00:07:19-!- travis-ci [~travis-ci@ec2-54-162-215-241.compute-1.amazonaws.com] has joined #wesnoth-dev 20180413 00:07:20< travis-ci> wesnoth/wesnoth#17580 (master - fee6415 : Charles Dang): The build failed. 20180413 00:07:20< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/365876655 20180413 00:07:20-!- travis-ci [~travis-ci@ec2-54-162-215-241.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180413 00:07:37<+discordbot> no idea why it segfaults 20180413 00:08:26<+discordbot> Thread 1 "boost_unit_test" received signal SIGSEGV, Segmentation fault. 0x00007ffff476db74 in std::thread::join() () from /usr/lib/x86_64-linux-gnu/libstdc++.so.6 20180413 00:08:53-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: mattsc] 20180413 00:10:17<+discordbot> interesting 20180413 00:10:19<+discordbot> "warning network: poll Rethrowing: asio.netdb:1" 20180413 00:11:45<+discordbot> oh, I think I see the problem? 20180413 00:12:05<+discordbot> the wesnothd_connection_init class in the tests is supposed to catch any exception... 20180413 00:12:13<+discordbot> so, I guess it does, but.. 20180413 00:12:27<+discordbot> actually, I guess that's unrelated 20180413 00:15:49<+discordbot> I wonder if workerthread is null there.. 20180413 00:16:35<+discordbot> would be a bit easier if I actually built the tests..... 20180413 00:17:38-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev 20180413 00:18:37< celticminstrel> Then build them? 20180413 00:18:52< celticminstrel> There is a target in MSVC for them.3 20180413 00:20:08<+discordbot> thee is? 20180413 00:20:33< celticminstrel> Yes, it's in the config dropdown alongside Debug and Release. 20180413 00:20:43< celticminstrel> Or wait, is that the WML tests? 20180413 00:21:05< celticminstrel> Pretty sure both the WML and Boost tests are accessible somehow in MSVC, though. 20180413 00:22:11< celticminstrel> I think the Boost unit tests configuration might only be defined in the wesnoth project and thus isn't accessible in the solution's dropdown menu, but there should be some way to get at it still... 20180413 00:28:27-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180413 00:28:33-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180413 00:28:35<+discordbot> I gotta say, all this threading stuff is rather complicated. 20180413 00:29:02<+discordbot> std::future and std::promise especially. 20180413 00:35:44-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: mattsc] 20180413 00:45:45<+discordbot> celmin: any updates on the schemmmmmmmmmmmma fixes? 20180413 00:45:52< celticminstrel> Hm? 20180413 00:46:09<+discordbot> will you merge them today? 20180413 00:46:27<+discordbot> (tbh I'm a little worried they might break something but since they're bug fixes I guess it's alright) 20180413 00:46:28< celticminstrel> I guess you weren't paying attention yesterday.. 20180413 00:46:40<+discordbot> you said you'd split the branch? 20180413 00:46:46< celticminstrel> I pushed all the bug fixes to 1.14 and left the PR with just cleanups. 20180413 00:46:51<+discordbot> oh 20180413 00:46:53<+discordbot> ok, good, good 20180413 00:46:56<+discordbot> good, good, good 20180413 00:47:00< celticminstrel> I didn't just say I'd do it, I did it. :P 20180413 00:47:03<+discordbot> I missed that 20180413 00:47:06<+discordbot> xD 20180413 00:47:37<+discordbot> but master doesn't have them yet, right? 20180413 00:47:48< celticminstrel> Master will get them whenever the schema branch is merged. 20180413 00:47:55< celticminstrel> That likely won't be for at least another month though. 20180413 00:47:57<+discordbot> mk 20180413 00:48:02<+discordbot> got it 20180413 00:48:06<+discordbot> so that's done 20180413 00:50:25< irker683> wesnoth: Charles Dang wesnoth:master 90d45dcf074a / data/multiplayer/scenarios/ANL_utils/ANL_general_macros.cfg: ANL: removed unused macro (closes #2878) https://github.com/wesnoth/wesnoth/commit/90d45dcf074aaf6e2f118abba81103999a17521a 20180413 00:51:19< irker683> wesnoth: Charles Dang wesnoth:1.14 06af9401eec7 / data/multiplayer/scenarios/ANL_utils/ANL_general_macros.cfg: ANL: removed unused macro (closes #2878) https://github.com/wesnoth/wesnoth/commit/06af9401eec7153277d564f071a85618062fea46 20180413 00:51:24<+discordbot> (figured I'd just remove the macro myself instead of making sevu update the PR) 20180413 00:58:07< celticminstrel> Speaking of schema though, I do need to look through its commits for undocumented things that need to be documented... 20180413 00:58:37<+discordbot> and document the schema schema 20180413 00:58:46< celticminstrel> Huh? 20180413 00:59:03<+discordbot> AFAIK the schema schema was never documented 20180413 00:59:33< celticminstrel> I assume what you're trying to say is that you want a wiki page documenting SchemaWML? 20180413 01:00:05<+discordbot> yes 20180413 01:00:14<+discordbot> especially the new schema 20180413 01:04:35<+discordbot> how in hell is Ageless almost 80 MB 20180413 01:04:37<+discordbot> O_O 20180413 01:04:53<+discordbot> what the hell did they stick in there 20180413 01:05:47< celticminstrel> Images. Tons and tons of images. 20180413 01:06:06< celticminstrel> I really wish Ageless Era did not exist, but I guess there's not much I can do about it. 20180413 01:06:42<+discordbot> Correction: there's not much we can do about it if we don't want to piss off 80% of the MP people 😛 20180413 01:07:35<+discordbot> There's nothing (technically) stopping us from taking Ageless down. But we shouldn't do that. 20180413 01:08:09<+discordbot> I'll admit, I'm rather miffed that SXCollection has it as a dependency... 20180413 01:08:23< celticminstrel> Ageless is a bloated monstrosity. 20180413 01:08:40<+discordbot> oh, indeed 20180413 01:08:46< celticminstrel> And the exact opposite of how things should be done. 20180413 01:08:51<+discordbot> Indeed. 20180413 01:08:55<+discordbot> But what can we do 20180413 01:08:59< celticminstrel> I wonder if the eras it has absorbed still exist independently. 20180413 01:09:04<+discordbot> Who knows? 20180413 01:09:18< celticminstrel> Ugh. 20180413 01:09:24<+discordbot> I used to think it was awesome 20180413 01:09:29<+discordbot> because of the chaos faction 20180413 01:09:35<+discordbot> but now I realize it's horrible. 20180413 01:09:40< celticminstrel> It has everything, and that's the problem. 20180413 01:09:49<+discordbot> You can't keep the art updated 20180413 01:09:55< celticminstrel> "What's wrong with having everything?" you ask? 20180413 01:09:55<+discordbot> You can't balance anything 20180413 01:09:59<+discordbot> It takes years to load 20180413 01:10:16< celticminstrel> BECAUSE I DON'T WANT EVERYTHING, I JUST WANT THIS THING AND THAT THING, SO WHY SHOULD I HAVE TO DOWNLOAD EVERYTHING!? 20180413 01:10:17<+discordbot> So much so that ravana provids pre-preprocessed wml 20180413 01:10:51<+discordbot> which is even worse, since that probably bloats the size further 20180413 01:10:59< celticminstrel> Oh, I just thought of something we can do to destroy Ageless. 20180413 01:11:04<+discordbot> oh? 20180413 01:11:17< celticminstrel> Allow choosing multiple eras instead of just one. 20180413 01:11:22< celticminstrel> When starting a game. 20180413 01:11:42< celticminstrel> That would pretty much destroy the entire point of Ageless, wouldn't it? 20180413 01:11:53< celticminstrel> The point being that you can mix and match factions from different eras. 20180413 01:12:04<+discordbot> you'd still have people bitch that they'd need to track down an addon with their favorite faction 20180413 01:12:15<+discordbot> boo hoo. 20180413 01:12:46< celticminstrel> Well, you could still put up Ageless as a metapackage that defines all the addons as dependencies but doesn't actually include anything itself. 20180413 01:13:10< celticminstrel> So people who really want everything can download everything in one click, and people who don't want everything can just download what they want instead. 20180413 01:13:12<+discordbot> Useless if we don't implement shadowm's optional dependency system 20180413 01:13:28< celticminstrel> Eh? Why would it be optional dependencies? 20180413 01:13:41<+discordbot> fair point, I suppose 20180413 01:14:02<+discordbot> jesus christ 20180413 01:14:08<+discordbot> TLU resources part 1 is almost 100 MB 20180413 01:14:18<+discordbot> that's on top of 31 MB for part 2 20180413 01:14:21<+discordbot> and 10 mb for the base 20180413 01:15:32<+discordbot> but yeah, ageless is horrible 20180413 01:16:13<+discordbot> If we allow selecting multiple eras we can probably ask ravana to not upload it to 1.15/1.16 20180413 01:16:42< celticminstrel> Or to upload it only as a metapackage. 20180413 01:16:49<+discordbot> yes 20180413 01:17:24<+discordbot> I'm downloading it out of curiosity to see how much stuff is in there... 20180413 01:17:38<+discordbot> it must be more than last I played with it in 1.8/1.10 20180413 01:18:50-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev 20180413 01:33:07-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20180413 01:40:51<+discordbot> celmin: 15 eras including default 20180413 01:40:52<+discordbot> 😐 20180413 01:41:06< celticminstrel> https://wiki.wesnoth.org/SchemaWML 20180413 01:41:27<+discordbot> and god, this art.. 20180413 01:41:43<+discordbot> oh, how nice, Era of Chaos got roped in! 20180413 01:41:46<+discordbot> jesus christ. 20180413 01:42:09< celticminstrel> Not gonna look at the link?3 20180413 01:43:08< celticminstrel> It's orphaned, so maybe we could link to it from somewhere. 20180413 01:43:13<+discordbot> ageless begone! uninstalls 20180413 01:43:37<+discordbot> celmin: looks good 20180413 01:44:55< celticminstrel> It's actually not a particularly complicated format, is it? 20180413 01:45:16< celticminstrel> The most complicated thing about it is probably that tags can be nested infinitely. 20180413 01:45:33< celticminstrel> And types too, on the schema branch. 20180413 01:46:28< celticminstrel> There aren't a lot of tags that can be nested infinitely. AI [facet] tags are one, and I guess [command], [event], and similar. 20180413 01:46:57<+discordbot> I wonder if we could use the schema files for experimenting with JSON formats... 20180413 01:47:10< celticminstrel> Uh. 20180413 01:47:23< celticminstrel> I'm just wondering how you think there's any connection whatsoever there. 20180413 01:47:53<+discordbot> just that they're wholly backend files. 20180413 01:47:56<+discordbot> and large 20180413 01:50:27<+discordbot> and have varied types of keys/tags 20180413 01:50:40< celticminstrel> I have no idea what you're even talking about? 20180413 01:53:00<+discordbot> what? 20180413 01:53:29< celticminstrel> First of all, what does "they" actually refer to in your sentence. 20180413 01:54:21<+discordbot> the schema config files 20180413 01:55:46<+discordbot> they're contained, don't have external dependencies, and are large 20180413 01:56:21< Ravana_> half of ageless size is from EoMa 20180413 01:56:56< Ravana_> preprocessed version is with 1.14 only required for wmlunits, some time ago its limit was lowered from 60s to 20s 20180413 01:57:06< Ravana_> with 1.12 it is needed for cache issues too 20180413 01:57:25< Ravana_> I will use EoMa resources as dependency on 1.14 20180413 01:57:49< Ravana_> preprocessed version is uncompressed around 15mb, compressed 10x less 20180413 02:04:12< irker683> wesnoth/wesnoth:1.14 mattsc 6924910b5a AI recruitment: use unit-specific recall AppVeyor: All builds passed 20180413 02:09:33< celticminstrel> And what how does JSON come into all of this? 20180413 02:27:24< irker683> wesnoth: Severin Glöckner wesnoth:master 469488d9815a / data/campaigns/Dead_Water/units/Brawler.cfg: update 2nd stunned event as well with additions from 1.13.2 https://github.com/wesnoth/wesnoth/commit/469488d9815a1dc243512396b5c644918dc77d60 20180413 02:34:28<+discordbot> nevermind 20180413 02:42:37<+discordbot> celmin: could you test out gfgtdf's suggestion for fixing this? https://github.com/wesnoth/wesnoth/issues/2850 20180413 02:44:58-!- heirecka [~heirecka@exherbo/developer/heirecka] has joined #wesnoth-dev 20180413 03:13:30< celticminstrel> Probably tomorrow. 20180413 03:38:53< celticminstrel> @Vultraz, thoughts? https://wiki.wesnoth.org/FilterWML#Filtering_on_WML_data 20180413 03:44:31-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180413 03:44:37-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180413 03:46:30< celticminstrel> Also https://wiki.wesnoth.org/index.php?title=StandardUnitFilter&type=revision&diff=59402&oldid=59198 20180413 03:46:42< celticminstrel> Ah, I'll fix the typo though. Whoops. 20180413 04:09:46< celticminstrel> [modify_unit]mode needs documenting. 20180413 04:24:17< celticminstrel> Not sure whether [item] name= write_name= need documenting or if they're more like internal implementation detail. 20180413 04:24:19< celticminstrel> ^+s 20180413 04:26:00-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: So long and thanks for all the fish.] 20180413 04:42:35<+discordbot> Looks good to me 20180413 04:47:37< irker683> wesnoth/wesnoth:1.14 Severin Glöckner 659add575d Adjust the weapon names of the heroes to AppVeyor: All builds passed 20180413 04:48:18<+discordbot> @jyrkive I removed the wesnothd_connection_ptr class and implemented your suggestion of joining the thread in the dtor. Much cleaner. 20180413 04:48:34<+discordbot> Looks good. 👍 20180413 04:49:44<+discordbot> just need to clean up the loading screen now 20180413 04:50:28<+discordbot> it occurred to me (based on what celmin said) there's a very low possibility of the whole think exiting early, if the worker thread takes > 100 ms to begin execution. 20180413 04:53:06<+discordbot> One idea I had was to replace the is_worker_thread_running flag with a mutex, lock it in the thread, and use mutex::try_lock in the flag's place.... though I suppose that would suffer the same problem 🤔 20180413 04:53:42< celticminstrel> Hmm, that might work...? 20180413 04:54:29< celticminstrel> But there's still the risk that the thread doesn't get a chance to lock it before you first try to lock it on the main thread... 20180413 04:54:39< celticminstrel> Maybe that could be solved by waiting until it's locked? 20180413 04:55:12< celticminstrel> Like, have a loop where you try_lock, and if successful, release and sleep for one second, and if not successful, exit the loop. 20180413 04:55:38< celticminstrel> I dunno if that could affect performance or anything though. 20180413 04:56:27<+discordbot> How about making is_worker_thread_running an atomic flag and setting it in the main thread? 20180413 04:56:43<+discordbot> Or we could use an std::promise for the worker's return value like you suggested 20180413 04:56:44<+discordbot> http://en.cppreference.com/w/cpp/atomic/atomic_flag 20180413 04:57:51<+discordbot> What are the benefits? 20180413 04:59:04<+discordbot> It would be a simple implementation, that's all. 20180413 05:04:35-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The computer falls into a deep sleep, to awake again some other day!] 20180413 05:45:21-!- timotei_ [~timotei@wesnoth/developer/timotei] has quit [Ping timeout: 264 seconds] 20180413 05:45:54-!- timotei_ [~timotei@wesnoth/developer/timotei] has joined #wesnoth-dev 20180413 06:05:49<+discordbot> ....oh no. 20180413 06:06:06<+discordbot> ? 20180413 06:07:04<+discordbot> oh, whew, not in 1.14 20180413 06:07:19<+discordbot> had just noticed duplicate side number labels in MP Staging 20180413 06:07:26<+discordbot> in master 20180413 06:09:14-!- gallaecio [~quassel@38.red-83-46-126.dynamicip.rima-tde.net] has joined #wesnoth-dev 20180413 06:13:08-!- atarocch [~atarocch@93.56.164.28] has quit [Ping timeout: 260 seconds] 20180413 06:14:53-!- Guest2936 [matthiaskr@gateway/shell/panicbnc/x-ihchowyaftepsbvb] has quit [Changing host] 20180413 06:14:53-!- Guest2936 [matthiaskr@unaffiliated/matthiaskrgr] has joined #wesnoth-dev 20180413 06:14:53-!- Guest2936 [matthiaskr@unaffiliated/matthiaskrgr] has quit [Changing host] 20180413 06:14:53-!- Guest2936 [matthiaskr@gateway/shell/panicbnc/x-ihchowyaftepsbvb] has joined #wesnoth-dev 20180413 06:15:02-!- Guest2936 is now known as matthiaskrgr 20180413 06:50:23-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20180413 06:55:24-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20180413 06:55:47-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20180413 07:00:07-!- noy [~Noy@wesnoth/developer/noy] has quit [Ping timeout: 256 seconds] 20180413 07:06:09< irker683> wesnoth/wesnoth:master Charles Dang 90d45dcf07 ANL: removed unused macro (closes #2878) AppVeyor: All builds passed 20180413 07:22:04< irker683> wesnoth: Charles Dang wesnoth:master 802bbe8cdcca / changelog.md data/gui/window/game_load.cfg src/gui/dialogs/game_load.cpp: Game Load: added a convenient button in Load Game to open your saves folder https://github.com/wesnoth/wesnoth/commit/802bbe8cdccacb225ea02a8f8b4240b7172549ed 20180413 07:24:18< irker683> wesnoth: Charles Dang wesnoth:1.14 0c745f0fc5a2 / changelog.md data/gui/window/game_load.cfg src/gui/dialogs/game_load.cpp: Game Load: added a convenient button in Load Game to open your saves folder https://github.com/wesnoth/wesnoth/commit/0c745f0fc5a2b5066431979dd503f2ad5eabc1b2 20180413 07:41:52-!- travis-ci [~travis-ci@ec2-54-234-20-18.compute-1.amazonaws.com] has joined #wesnoth-dev 20180413 07:41:53< travis-ci> wesnoth/wesnoth#17581 (master - 802bbe8 : Charles Dang): The build is still failing. 20180413 07:41:53< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/365978804 20180413 07:41:53-!- travis-ci [~travis-ci@ec2-54-234-20-18.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180413 07:46:12<+discordbot> someone who builds the tests is going to have to take a look at the failure, I think 😦 20180413 07:46:26<+discordbot> I have no idea what could be wrong on a log readover 20180413 07:46:56<+discordbot> I'll be too busy investigating https://github.com/wesnoth/wesnoth/issues/2880 and the blockers. 😦 20180413 07:47:35<+discordbot> ah, well, it's not on 1.14 at least. 20180413 07:48:56<+discordbot> though that does remind me i should get on that chat bug 20180413 07:49:01<+discordbot> it will require refactoring 20180413 07:49:24<+discordbot> Yeah, I had been thinking about unassigning it from you because of lack of progress. 20180413 07:50:02<+discordbot> It's not a good situation when the assignee of a blocker is just sitting on it. 20180413 07:51:03<+discordbot> Basically, the state of the chatbox needs be held by something other than the chatbox widget itself 20180413 07:51:22<+discordbot> Static variables in the MP lobby class? 20180413 07:51:37-!- grzywacz [~karol@89-70-226-147.dynamic.chello.pl] has joined #wesnoth-dev 20180413 07:51:45<+discordbot> no 20180413 07:51:50<+discordbot> remember, staging needs them too 20180413 07:52:12<+discordbot> the GUI1 mp workflow had this... I guess I didn't realize it was necessary 😬 20180413 07:52:23<+discordbot> and I chucked it 20180413 07:53:06<+discordbot> I'll do some poking around.. 20180413 07:53:18<+discordbot> I think there's some stuff in lobby info I can probably repurpose? 20180413 07:56:28<+discordbot> I assume you're not working on the text crash since you can't repro that? 20180413 07:56:43<+discordbot> Indeed. I'm completely unable to debug it. 20180413 07:58:49<+discordbot> @sinda I guess you weren't able to glean anything else from debugging? 20180413 07:59:00-!- grzywacz [~karol@89-70-226-147.dynamic.chello.pl] has quit [Ping timeout: 246 seconds] 20180413 07:59:49<+discordbot> You mean IME input that crashes the lobby? 20180413 08:00:12<+discordbot> Not much. 20180413 08:00:33<+discordbot> In fact, I'm just back from vacation and debugging it right now. 20180413 08:01:36<+discordbot> The way we respond to IME events is quite different from what I see in https://wiki.libsdl.org/Tutorials/TextInput. Dunno if the tutorial handles IME; it should, but who knows. 20180413 08:02:54<+discordbot> I built and stepped into SDL2 source. The way it generates the input event in question, looks like it's not related to our selection at all. Which matches the mentioned tutorial on SDL wiki. 20180413 08:05:49<+discordbot> I can add my workaround, which might produce correct results only by coincidence. Or I can propose to redo the IME events handling (move logic from text_box_base::handle_editing to a new SDL_TEXTINPUT handler, like the tutorial does), and see how it goes. 20180413 08:06:37<+discordbot> Using the workaround sounds like a better option. Attempting to rewrite IME event handling has too high risk of breaking IME input. 20180413 08:06:38<+discordbot> I feel that it may take me several more days at least, as I'm not familiar with languages that require a true text composition. 20180413 08:07:24<+discordbot> but if the refactor is worth it, you can do it for master 20180413 08:07:30<+discordbot> The workaround is a completely blind shot. I have no evidence that it is anywhere near being correct. 20180413 08:07:58<+discordbot> It prevents a crash, but might result in a garbled utf-8 characters. 20180413 08:08:18<+discordbot> The only advantage of it is It doesn't make it worse. 20180413 08:08:47<+discordbot> It would be an improvement, and I don't see how it could cause any regressions, either. 20180413 08:09:06<+discordbot> OK. I can make a PR against 1.14 right now. 20180413 08:25:02< irker683> wesnoth: Iris Morelle website:master a7bf668c3d22 / start/1.14/ (34 files in 8 dirs): New style for the 1.14 press-release announcement, codename Lintanir https://github.com/wesnoth/website/commit/a7bf668c3d2267d9bc3a9ce518ef7bccd6c55814 20180413 08:25:49<+discordbot> @sinda text_box_base::handle_editing is whats called when a SDL_TEXTEDITING event happens 20180413 08:25:58<+discordbot> (if you follow the event chain) 20180413 08:27:26<+discordbot> Yeah, but, AFAIU the tutorial, a text should be changed by SDL_TEXTINPUT, and SDL_TEXTEDITING is only for displaying the composition selection/cursor. 20180413 08:27:31<+discordbot> https://wiki.libsdl.org/Tutorials/TextInput 20180413 08:30:45<+discordbot> SDL_TEXTINPUT is mapped to key down events in GUI2 20180413 08:30:49<+discordbot> Okay, I got it. So the fix in https://github.com/wesnoth/wesnoth/pull/2666/commits/562d9233c09400d1792bed0d80ee5af14c762998 is incorrect. 20180413 08:30:52<+discordbot> sameas SDL_KEYDOWN 20180413 08:31:17<+discordbot> text_box_base::handle_editing() shouldn't mess with text_. 20180413 08:33:31<+discordbot> #2666 was a follow-up to #2644, which was a fix for #2619. 20180413 08:34:24<+discordbot> Namely a crash if the player used an IME to exceed the maximum length of the textbox (the normal check doesn't help in that case because an IME can send multiple characters at once). 20180413 08:42:56<+discordbot> Yup, that. Tested my workaround for the last time, the results look very wrong even in Latin composition. Not sure it's much better than a crash. Should probably be rewritten, starting with the mentioned fixes. 20180413 08:44:20<+discordbot> Here is what I tried for a workaround, but I'm personally against merging it: https://github.com/singalen/wesnoth/commit/6cab3bfe598879363acb0cd877aac44f2da4900c 20180413 08:44:32<+discordbot> Now, have a good night 😃 20180413 08:45:01<+discordbot> It's 11:44AM here. Not planning to go to bed just yet. 😉 20180413 08:45:11<+discordbot> 7:45 PM here 20180413 08:46:03<+discordbot> You should try, you might like it. 20180413 08:46:15<+discordbot> 😂 20180413 08:46:51<+discordbot> Maybe I would like it, but I don't know about my coworkers... 😛 20180413 08:48:06-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180413 09:15:17< irker683> wesnoth/wesnoth:1.14 Charles Dang 06af9401ee ANL: removed unused macro (closes #2878) AppVeyor: All builds passed 20180413 09:16:13-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!] 20180413 09:16:29-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180413 09:24:27-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180413 09:24:32-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180413 09:29:15-!- atarocch [~atarocch@93.68.189.211] has joined #wesnoth-dev 20180413 09:44:13-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20180413 09:44:51-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180413 10:53:10< irker683> wesnoth/wesnoth:master Severin Glöckner 469488d981 update 2nd stunned event as well with ad AppVeyor: All builds passed 20180413 11:12:21-!- atarocch [~atarocch@93.68.189.211] has quit [Ping timeout: 264 seconds] 20180413 11:22:01<+discordbot> @jyrkive I nailed the culprit! https://github.com/wesnoth/wesnoth/blob/master/src/wesnoth.cpp#L1104 20180413 11:22:23<+discordbot> ignoring SIGCHLD makes system always return -1 20180413 11:22:33<+discordbot> Oh, right. And I'm the one who did it. 🤦 20180413 11:22:35<+discordbot> because apparently it depends on waitpid 20180413 11:24:12<+discordbot> https://github.com/wesnoth/wesnoth/commit/b95c9996bf435daa4d7e64fd1ef41425ac182b95 20180413 11:24:50<+discordbot> yeah but if it reaps zombies we can't read status from them anymore 20180413 11:25:09<+discordbot> seems it breaks waitpid even if it's called when child process still exists 20180413 11:25:25<+discordbot> IMO, it would be best to just remove the return value check. Ensuring that the game doesn't freeze when launching the web browser is more important that being able to handle wesnothd failing to start somehow. 20180413 11:26:04<+discordbot> maybe there's another solution for web browser launching? 20180413 11:26:10<+discordbot> like waiting for it in a thread 20180413 11:26:28<+discordbot> Yes, I think that would also work. 20180413 11:27:27<+discordbot> like could you point me to all instances of code that will be affected by stopping ignoring SIGCHLD? 20180413 11:28:59< Soliton> we could also just ignore CHLD when launching the browser and not when launching wesnothd? 20180413 11:29:27<+discordbot> @loonycyborg I'm not aware of any other instances. 20180413 11:29:48<+discordbot> Soliton: you mean changing the SIGCHLD handler temporarily? 20180413 11:29:57< Soliton> yep. 20180413 11:30:45< Soliton> the description in that commit sounded to me like that is enough anyway. 20180413 11:31:15<+discordbot> Yes, I think it's indeed enough. 20180413 11:31:34<+discordbot> (Although maybe it should be the other way: ignore always except when using system()." 20180413 11:31:38<+discordbot> Going to a meeting now. 20180413 11:31:52< Soliton> sure, that'd work as well. 20180413 11:37:25<+discordbot> I think ignoring only for browser would be better 20180413 11:37:54<+discordbot> since everything that depends on waiting for children not working might be counter intuitive 20180413 11:49:45<+discordbot> @jyrkive what if we do instead something like std::thread t{ { waitpid(...); }}; t.detach()? 20180413 11:50:03-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20180413 11:50:08<+discordbot> As I said, I think it would also work. 20180413 11:50:42-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180413 11:52:09<+discordbot> We could also use this: std::async(std::launch::async, { waitpid(...); }); 20180413 11:54:47<+discordbot> we already require high enough std version for this? 20180413 11:54:56<+discordbot> It's C++11. 20180413 11:55:08<+discordbot> cool 20180413 11:58:55<+discordbot> the problem is that future returned by async will block in destructor 20180413 11:59:23<+discordbot> Ah, okay. In that case it's indeed best to just create and detach a thread explicitly. 20180413 12:07:25-!- vladimirslavik [~vslavik@95.82.135.136] has joined #wesnoth-dev 20180413 12:08:39-!- vladimirslavik [~vslavik@95.82.135.136] has quit [Client Quit] 20180413 12:16:26<+discordbot> We can probably remove boost::thread from the required boost libs list. 20180413 12:16:44<+discordbot> We should first get unit tests to pass. 20180413 12:16:52<+discordbot> True 20180413 12:17:03<+discordbot> For now, the easiest way to get them to pass would be just reverting to Boost.Thread. 20180413 12:17:10<+discordbot> There's also one include in gettext_boost.cpp that says thus: cpp // including boost/thread fixes linking of boost locale for msvc on boost 1.60 #include 20180413 12:17:21<+discordbot> which seems...odd. 20180413 12:18:57-!- grzywacz [~karol@wesnoth/developer/grzywacz] has joined #wesnoth-dev 20180413 12:20:13<+discordbot> I wonder where @Tad Carlucci has been. He usually looks at this stuff (the test failures) 20180413 12:21:08<+discordbot> According to https://web.archive.org/web/20161118203359/http://www.pdimov.com/tmp/report-develop-c3bb6eb/module-levels.html Boost.Locale doesn't depend on Boost.Thread (Locale is at level 7, Thread at level 12). 20180413 12:22:08-!- gallaecio [~quassel@38.red-83-46-126.dynamicip.rima-tde.net] has quit [Remote host closed the connection] 20180413 12:29:06< irker683> wesnoth: Charles Dang wesnoth:master 593e6737348a / src/wesnothd_connection.cpp: Shot-in-the-dark attempt to fix the tests https://github.com/wesnoth/wesnoth/commit/593e6737348aaf3b576ff71c8f4d401fc732e10a 20180413 12:46:02<+discordbot> That actually appears to have worked so far o_O 20180413 12:46:06< irker683> wesnoth: loonycyborg wesnoth:master 846bf8f208ae / src/ (desktop/open.cpp wesnoth.cpp): Fix "host networked game" option https://github.com/wesnoth/wesnoth/commit/846bf8f208ae41381e133e96b24e6b9876ea2a01 20180413 12:48:06<+discordbot> Yup, the tests are back to working order \o/ 20180413 12:48:40<+discordbot> (I'm guessing the io service only runs if the worker thread is created, so that's why I left the stop() call in the condition) 20180413 12:48:43<+discordbot> @loonycyborg is that so? 20180413 12:50:00<+discordbot> I'm not sure, worker thread is whatever thread you run io_service.run() 20180413 12:52:19-!- gallaecio [~quassel@188.79.96.255] has joined #wesnoth-dev 20180413 12:52:21<+discordbot> you could as well use main thread as worker thread 20180413 12:52:46<+discordbot> but then only asio's handlers would ever execute 20180413 12:52:53<+discordbot> and this is exactly how wesnothd works 20180413 12:53:06<+discordbot> how it is used in client and tests I'm not sure 20180413 12:54:30< irker683> wesnoth: loonycyborg wesnoth:1.14 0c3f6da83072 / src/ (desktop/open.cpp wesnoth.cpp): Fix "host networked game" option https://github.com/wesnoth/wesnoth/commit/0c3f6da8307283045094e23b439b13abd7f912e5 20180413 12:56:15< irker683> wesnoth: Charles Dang wesnoth:master 7cf93413797c / src/gettext_boost.cpp: Removed last boost/thread.hpp include https://github.com/wesnoth/wesnoth/commit/7cf93413797c73e6ca33e22a615897ffbec42cdb 20180413 12:56:18< irker683> wesnoth: Charles Dang wesnoth:master 9de7aff9044b / CMakeLists.txt INSTALL.md SConstruct changelog.md: Removed Boost Thread as a built-time dependency https://github.com/wesnoth/wesnoth/commit/9de7aff9044b1aae7fc56c4b78a400d93c0f6750 20180413 13:04:48-!- travis-ci [~travis-ci@ec2-54-91-135-84.compute-1.amazonaws.com] has joined #wesnoth-dev 20180413 13:04:49< travis-ci> wesnoth/wesnoth#17584 (master - 846bf8f : loonycyborg): The build was fixed. 20180413 13:04:49< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/366092446 20180413 13:04:49-!- travis-ci [~travis-ci@ec2-54-91-135-84.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180413 13:10:33-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180413 13:10:39-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180413 13:14:48<+discordbot> "The same syntax as [filter_wml] is supported." hmm, that's not really something to be glad about 20180413 13:16:10<+discordbot> although it was done long ago, adding [not] to filter_wml was an egregious design error. 20180413 13:17:50<+discordbot> one could have simply written not... but now the schema is ambiguous if you want to actually match a [not] 20180413 13:18:32<+discordbot> Thats a good point 🤔 20180413 13:18:35<+discordbot> it could be removed 20180413 13:20:11<+discordbot> I support that removal 20180413 13:27:58<+discordbot> normally I would be against something that breaks backwards compatibility, but you can't break what's already broken. purging that abomination would be worth it. 20180413 13:28:04< irker683> wesnoth/wesnoth:master Charles Dang 802bbe8cdc Game Load: added a convenient button in AppVeyor: All builds passed 20180413 13:29:10<+discordbot> pings @zookeeper 20180413 13:30:03< zookeeper> eh? 20180413 13:30:22< zookeeper> oh, that. 20180413 13:31:25< zookeeper> or, actually, you might want to be more specific. didn't someone even add [and]/[or] support there in _addition_ to [not], or how was it? 20180413 13:33:33<+discordbot> the and/or proposal was shot down by me ages ago and I griped about [not] at that time. recently it appears and/or went in briefly, but was then quickly removed. 20180413 13:34:20<+discordbot> @zookeeper : https://github.com/wesnoth/wesnoth/commit/82fd82d53403b8173d234b8a3abef6a1e3ef39c9 20180413 13:34:59<+discordbot> then https://github.com/wesnoth/wesnoth/commit/b483d96f500827ccacc78f3c2e89fc6690a3d2df 20180413 13:35:10< zookeeper> oh. right. yeah, of course support for any of those tags (or any other) _inside_ [filter_wml] doesn't really make sense. or at least it'll inevitably cause some things to be unfilterable. 20180413 13:35:11<+discordbot> so as far as I can tell, it's still there 20180413 13:36:37< Soliton> i think it was only reverted for 1.14. 20180413 13:38:38<+discordbot> https://github.com/wesnoth/wesnoth/commit/ebde628e05a3548fb9bd894e19546d32890f6b1e#diff-42ba1d994f4fa8c6ad17a7efae7936cc 20180413 13:40:58<+discordbot> maybe and/or/not makes sense at the SchemaWML level, but I don't feel it should be added to filter_wml 20180413 13:50:09<+discordbot> they're still in master 20180413 13:50:14<+discordbot> reverted in 1.14 20180413 13:59:15-!- Oebele [~quassel@143.177.58.202] has joined #wesnoth-dev 20180413 14:18:41-!- atarocch [~atarocch@31.159.128.64] has joined #wesnoth-dev 20180413 14:38:47-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!] 20180413 14:39:08-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180413 14:40:17-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20180413 14:42:18-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180413 14:52:17-!- atarocch [~atarocch@31.159.128.64] has quit [Ping timeout: 276 seconds] 20180413 14:53:22< irker683> wesnoth/wesnoth:1.14 Charles Dang 0c745f0fc5 Game Load: added a convenient button in AppVeyor: All builds passed 20180413 15:01:47<+discordbot> I'm playing UtBs with the new unit line for the first time after putting it off for an eternity. The new units are fantastic and all but i have one question. The lv 1 quenoth mystic advances to lv 2 shaman and lv 2 sun singer but not to the lv 2 moon singer. So will i get moon singers in the campaign ? ( without using mods or messing with the code ) I'm currently starting the 3 rd scenario where the two undead leaders fight. If 20180413 15:01:47<+discordbot> not, then can someone tell me why moon singers are out of the main evolution tree ? they seem like a cool unit line 20180413 15:01:50<+discordbot> 🤔 20180413 15:01:59<+discordbot> @zookeeper you can get moon singers, right? 20180413 15:04:56< Soliton> nope. 20180413 15:06:10<+discordbot> wait what 20180413 15:08:49<+discordbot> then when do you get moon singers 20180413 15:19:29-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180413 15:19:35-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180413 15:48:24-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20180413 16:18:06-!- Oebele [~quassel@143.177.58.202] has quit [Remote host closed the connection] 20180413 16:22:01-!- gfg [~androirc@tmo-103-106.customers.d1-online.com] has joined #wesnoth-dev 20180413 16:39:30-!- DeFender1 [~danf@pool-98-114-181-118.phlapa.fios.verizon.net] has joined #wesnoth-dev 20180413 16:42:49<+discordbot> Problem with new Cairo... 20180413 16:43:00<+discordbot> https://cdn.discordapp.com/attachments/259976436490829825/434393078271442944/unknown.png 20180413 16:44:03<+discordbot> Right is new one 20180413 16:44:04<+discordbot> https://cdn.discordapp.com/attachments/259976436490829825/434393342382702592/unknown.png 20180413 16:45:35<+discordbot> ok... nvmw 😄 20180413 16:45:47-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20180413 16:45:57<+discordbot> I just used bad one 20180413 16:50:40<+discordbot> Could you clarify what you mean by "bad one"? 20180413 17:13:34-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180413 17:25:57-!- gfg [~androirc@tmo-103-106.customers.d1-online.com] has quit [Ping timeout: 240 seconds] 20180413 17:55:38-!- irker683 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout] 20180413 18:10:56<+discordbot> @shadowm I already resolved this 'issue'. I just copied bad version.h (it is described in screen) 20180413 18:11:45-!- Bhoren [~Bhoren_wh@2a01:e0a:c:2150:2154:5bd6:fe03:950a] has joined #wesnoth-dev 20180413 18:18:56< zookeeper> @Vultraz, no, they're removed. my bad for still having the strings for the unit type names in, though. 20180413 18:43:29-!- gallaecio [~quassel@188.79.96.255] has quit [Remote host closed the connection] 20180413 18:45:57-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20180413 18:47:23-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20180413 18:50:46-!- gfg [~androirc@x4e363824.dyn.telefonica.de] has joined #wesnoth-dev 20180413 18:58:38-!- gfg [~androirc@x4e363824.dyn.telefonica.de] has quit [Ping timeout: 276 seconds] 20180413 19:06:45-!- gfg [~androirc@x4e363824.dyn.telefonica.de] has joined #wesnoth-dev 20180413 19:18:09-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20180413 19:21:18-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20180413 19:21:22-!- irker911 [~irker@uruz.ai0867.net] has joined #wesnoth-dev 20180413 19:21:22< irker911> wesnoth/wesnoth:1.14 loonycyborg 0c3f6da830 Fix "host networked game" option AppVeyor: All builds passed 20180413 19:27:23-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20180413 19:33:12-!- Bhoren [~Bhoren_wh@2a01:e0a:c:2150:2154:5bd6:fe03:950a] has quit [Quit: Leaving] 20180413 19:36:59-!- gallaecio [~quassel@188.79.96.255] has joined #wesnoth-dev 20180413 19:48:45< irker911> wesnoth: Jyrki Vesterinen wesnoth:1.14 61e15c42e229 / src/gui/dialogs/game_load.cpp: Fix build with Visual Studio 2013 https://github.com/wesnoth/wesnoth/commit/61e15c42e2298e050c2af880833d68a5922bf267 20180413 19:48:47< irker911> wesnoth: Jyrki Vesterinen wesnoth:1.14 4916e1c0b9ff / src/team.hpp: Fix #2850: [modify_side] share_vision=yes doesn't do anything https://github.com/wesnoth/wesnoth/commit/4916e1c0b9ff1dfe2547d65e01fa711ff01a7dff 20180413 19:48:49< irker911> wesnoth: Jyrki Vesterinen wesnoth:1.14 f4ee47c6ea40 / changelog.md: Changelog entry for commit 4916e1c0b9ff1dfe2547d65e01fa711ff01a7dff https://github.com/wesnoth/wesnoth/commit/f4ee47c6ea4026b37a913d67e0cda9b7ad976a5a 20180413 19:52:00< irker911> wesnoth: Jyrki Vesterinen wesnoth:master 82e04ab7611b / src/team.hpp: Fix #2850: [modify_side] share_vision=yes doesn't do anything https://github.com/wesnoth/wesnoth/commit/82e04ab7611b8c8458e70f66c49a8032e1c8469c 20180413 19:52:02< irker911> wesnoth: Jyrki Vesterinen wesnoth:master c5802cdcda42 / changelog.md: Changelog entry for commit 82e04ab7611b8c8458e70f66c49a8032e1c8469c https://github.com/wesnoth/wesnoth/commit/c5802cdcda42f068aa2a7372f864cc8f1522568a 20180413 20:02:18-!- gfg [~androirc@x4e363824.dyn.telefonica.de] has quit [Remote host closed the connection] 20180413 20:02:29-!- gfg [~androirc@x4e363824.dyn.telefonica.de] has joined #wesnoth-dev 20180413 20:13:58-!- gfg [~androirc@x4e363824.dyn.telefonica.de] has quit [Remote host closed the connection] 20180413 20:14:24-!- gfg [~androirc@x4e363824.dyn.telefonica.de] has joined #wesnoth-dev 20180413 20:19:06-!- gfg [~androirc@x4e363824.dyn.telefonica.de] has quit [Remote host closed the connection] 20180413 20:19:29-!- gfg [~androirc@x4e363824.dyn.telefonica.de] has joined #wesnoth-dev 20180413 20:26:27-!- gfg [~androirc@x4e363824.dyn.telefonica.de] has quit [Ping timeout: 240 seconds] 20180413 20:33:08-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20180413 20:33:25-!- gfg [~androirc@x4e363824.dyn.telefonica.de] has joined #wesnoth-dev 20180413 20:33:27-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180413 20:38:28-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20180413 20:39:03-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180413 20:50:21< irker911> wesnoth: Nils Kneuper wesnoth:master 6034cc50d155 / / (14 files in 13 dirs): updated Italian translation https://github.com/wesnoth/wesnoth/commit/6034cc50d1559a9776be9e4b4882c449b7c64afe 20180413 20:50:23< irker911> wesnoth: Nils Kneuper wesnoth:master cff478f9d386 / po/ (wesnoth-lib/pl.po wesnoth-units/pl.po wesnoth/pl.po): updated Polish translation https://github.com/wesnoth/wesnoth/commit/cff478f9d386afcb18e3bd5ed06149c29c4b356e 20180413 20:50:27< irker911> wesnoth: Nils Kneuper wesnoth:1.14 be36c9e5561e / / (14 files in 13 dirs): updated Italian translation https://github.com/wesnoth/wesnoth/commit/be36c9e5561ea95e509ad8593885bae7cb54a29a 20180413 20:50:29< irker911> wesnoth: Nils Kneuper wesnoth:1.14 cf92afd1355e / po/ (wesnoth-lib/pl.po wesnoth-units/pl.po wesnoth/pl.po): updated Polish translation https://github.com/wesnoth/wesnoth/commit/cf92afd1355e14ea35d61b50e4b7ffbeefce9fc2 20180413 20:51:39< irker911> wesnoth: Martin Hrubý (hrubymar10) wesnoth:master 68c1dbeab245 / projectfiles/Xcode/README.md: Update link to new MacCompileStuff repo https://github.com/wesnoth/wesnoth/commit/68c1dbeab2453f41cfc06742becf149a2487694b 20180413 20:53:40< irker911> wesnoth: Martin Hrubý (hrubymar10) wesnoth:1.14 e09afcffb5ad / projectfiles/Xcode/README.md: Update link to new MacCompileStuff repo https://github.com/wesnoth/wesnoth/commit/e09afcffb5adfe5d51e36d4d92daf553821b1ef0 20180413 20:54:29<+discordbot> @loonycyborg I saw that boost thread requirement was removed in master, was it also removed in 1.14 ? 20180413 20:56:07<+discordbot> doesn't seem so 20180413 20:56:52<+discordbot> Yes, I thought it 20180413 21:03:13<+discordbot> I assume it can be removed from master's docker image as well? 20180413 21:06:05-!- DeFender1 [~danf@pool-98-114-181-118.phlapa.fios.verizon.net] has quit [Ping timeout: 240 seconds] 20180413 21:09:46<+discordbot> also somewhat interestingly, it looks like the UB in #2400 is what causes the boost unit tests to fail when using LTO. Most of the same warnings get printed there as when the boost unit tests run, and the boost tests also fail even with -flto -O0. 20180413 21:32:42-!- DeFender1 [~danf@pool-98-114-181-118.phlapa.fios.verizon.net] has joined #wesnoth-dev 20180413 21:36:35-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 265 seconds] 20180413 21:40:22-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev 20180413 21:51:44-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20180413 21:52:20-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180413 21:53:35-!- DeFender1 [~danf@pool-98-114-181-118.phlapa.fios.verizon.net] has quit [Ping timeout: 240 seconds] 20180413 22:03:39-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20180413 22:04:15-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180413 22:05:05< irker911> wesnoth/wesnoth:master Charles Dang 9de7aff904 Removed Boost Thread as a built-time dep AppVeyor: All builds passed 20180413 22:08:13-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20180413 22:09:30< irker911> wesnoth: Martin Hrubý (hrubymar10) wesnoth:master 6314c6ab05a2 / projectfiles/Xcode/ (Fix_Xcode_Dependencies Wesnoth.xcodeproj/project.pbxproj): Remove Boost thread from Xcode project https://github.com/wesnoth/wesnoth/commit/6314c6ab05a2ac89efac2313c285c7aa5c4b2b29 20180413 22:16:55< irker911> wesnoth: pentarctagon wesnoth:master 52f8e8233c99 / docker/Dockerfile-base-1604-master: Remove boost-thread from dockerfile. https://github.com/wesnoth/wesnoth/commit/52f8e8233c99c214d7409fd9f0b2cd4056590255 20180413 22:18:46<+discordbot> and now back to thinking about the 18.04 docker image. If only the updated image that got uploaded of it had a working apt command... 20180413 22:25:05< irker911> wesnoth: mattsc wesnoth:1.14 1597a2ce273e / src/ai/default/ (recruitment.cpp recruitment.hpp): AI recruitment: fix units on recall list interfering with recruiting https://github.com/wesnoth/wesnoth/commit/1597a2ce273e2f6f89221fc9fa10590892f43043 20180413 22:25:07< irker911> wesnoth: mattsc wesnoth:1.14 011941391059 / src/ai/default/recruitment.cpp: AI recruitment: use unit-specific recall cost https://github.com/wesnoth/wesnoth/commit/0119413910591aa9e8ced71c9702271df51b67c4 20180413 22:25:09< irker911> wesnoth: mattsc wesnoth:1.14 84c39de58d0e / src/ai/default/ (recruitment.cpp recruitment.hpp): Merge pull request #2876 from mattsc/recall_recruit_bug https://github.com/wesnoth/wesnoth/commit/84c39de58d0e4cad7e0f474dca833ef60e8c3f65 20180413 22:27:23-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20180413 22:34:58-!- DeFender1 [~danf@pool-98-114-181-118.phlapa.fios.verizon.net] has joined #wesnoth-dev 20180413 22:39:28-!- DeFender1 [~danf@pool-98-114-181-118.phlapa.fios.verizon.net] has quit [Client Quit] 20180413 22:54:24-!- gfg [~androirc@x4e363824.dyn.telefonica.de] has quit [Ping timeout: 265 seconds] 20180413 22:57:40-!- grzywacz [~karol@wesnoth/developer/grzywacz] has quit [Ping timeout: 256 seconds] 20180413 23:05:14-!- atarocch [~atarocch@93.56.164.28] has joined #wesnoth-dev 20180413 23:38:34-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20180413 23:44:38-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180413 23:44:49-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180413 23:50:25-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev 20180413 23:55:38-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: KABOOM! It seems that I have exploded. Please wait while I reinstall the universe.] 20180413 23:58:56-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev --- Log closed Sat Apr 14 00:00:42 2018