--- Log opened Sat Apr 14 00:00:42 2018 20180414 00:48:32-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180414 00:48:39-!- janebot_ [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180414 00:48:39-!- janebot_ is now known as janebot 20180414 01:02:46-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20180414 01:24:10<+discordbot> @mattsc please cherry-pick your commits to master unless you intend a different fix on master in which case open an issue reminder of the fact 20180414 01:29:03-!- irker911 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout] 20180414 01:32:59-!- gallaecio [~quassel@188.79.96.255] has quit [Remote host closed the connection] 20180414 01:38:23-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180414 01:38:30-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180414 01:43:35<+discordbot> is celmin around? 20180414 01:43:54< celticminstrel> If you were on IRC you'd know the answer. 20180414 01:44:39<+discordbot> Vultraz, can you actually be on IRC? 20180414 01:44:49<+discordbot> Because there's one channel where your presence is required. 20180414 01:45:01<+discordbot> Now I understand why you weren't reacting to my remarks a couple of nights ago. 20180414 01:46:16<+discordbot> I've kinda been avoiding it since the bot causes my notifications to go crazy... 20180414 01:46:33<+discordbot> Then be in that single one channel at least. 20180414 01:55:56-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180414 01:56:03-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180414 02:14:21< celticminstrel> ...I think @Vultraz forgot what he actually wanted me for. 20180414 02:14:48<+discordbot> I had an idea but then I realized the idea was bad 20180414 02:15:39< celticminstrel> Now I'm curious. >_> 20180414 02:19:46<+discordbot> I was wondering if we should switch to a functional-based drawing API in lua that could replace the GUI2 canvas paradigm and allow for more flexible control of element size, position, etc. I had also been thinking such a thing would improve Lua UI API like you’ve been proposing, but then I realize it doesn’t actually do that since it only touches drawing and not layout. 20180414 02:20:55< celticminstrel> I don't think I'd mind having a tag in [canvas] that could take a formula specifying what to draw in some way, but I wouldn't rate it a priority. 20180414 02:21:24<+discordbot> Not a formula. 20180414 02:23:35<+discordbot> I’m just trying to figure out how best to be able to move elements 20180414 02:25:09<+discordbot> Including whole windows 20180414 02:26:03<+discordbot> What is it you wanted to do with the lua UI api? 20180414 02:27:56< celticminstrel> Haven't fully decided yet. 20180414 02:28:42< celticminstrel> One thing I don't like is how all the dialog functions act on the "current dialog", which only exists while wesnoth.show_dialog is running. 20180414 02:28:54< celticminstrel> I'd rather them be member functions of a dialog "class". 20180414 02:29:18<+discordbot> perfectly reasonable 20180414 02:31:20<+discordbot> I wonder if we should unify the core UI API and UMC-side APU more 20180414 02:31:31<+discordbot> That's why I was thinking a unified Lua-based drawing API 20180414 02:31:46< celticminstrel> I dunno if unifying them is quite the best option, but.... 20180414 02:31:52< celticminstrel> It's one possibility. 20180414 02:32:14<+discordbot> I mean, right now we have the problem of maintaining two versions of the same API 20180414 02:32:19<+discordbot> one vastly inferior 20180414 02:33:42<+discordbot> If we unified some parts of them any feature we add would immediately be available to both 20180414 02:34:05<+discordbot> core and umc 20180414 02:34:23< celticminstrel> I think that's not realistically possible. 20180414 02:34:34< celticminstrel> Certainly not with a vast amount of metaprogramming. 20180414 02:34:48<+discordbot> you mean without? 20180414 02:34:56< celticminstrel> Right. 20180414 02:35:17< celticminstrel> But even with a vast amount of metaprogramming I don't think you could avoid having to manually enable each new C++-side feature for Lua. 20180414 02:37:22<+discordbot> well, whatever we do, GUI2 really needs a better drawing API 20180414 02:37:47< celticminstrel> I don't see what's wrong with the existing one? It's similar to SVG, which isn't all that bad. 20180414 02:37:49<+discordbot> It occurred to me recently how hard it would be to have a proper animated element of any kind in a window 20180414 02:38:04<+discordbot> say we want to add a better animation to the loading screen 20180414 02:38:08< celticminstrel> Well, it's not like we need animated elements, but I don't think it would be as hard as you think. 20180414 02:38:25<+discordbot> Basically our UI is very static 20180414 02:38:28<+discordbot> I don't like that 20180414 02:38:41< celticminstrel> One minor improvement for animations might be adding a "time" variable to the canvas formulas. 20180414 02:39:29< celticminstrel> Though you'd have to define what that even means, is it just seconds since the canvas was first displayed? Probably you'd need to modulus it to get anything useful out of it. 20180414 02:39:38<+discordbot> if I want to have a window slide off to the side, I can't do that. If I want a window to fade out, I can't do that. 20180414 02:39:49<+discordbot> if I want to shift elements in a window, I can't do that 20180414 02:39:51< celticminstrel> But even now, dialogs that want animations can manually add the time variable. 20180414 02:40:09< celticminstrel> Oh, well now you're talking about dynamic layout, which is kinda a different beast. 20180414 02:40:55<+discordbot> say I wanted to do something like have the loading screen fade into the titlescreen, but the logo to move to the top of the screen and the text fade in. 20180414 02:41:00<+discordbot> That'd be really cool 20180414 02:41:07< celticminstrel> That said, I don't think there's any reason why you can't change aspects of the layout at runtime, beyond "mordante didn't bother to make sure it was supported and added checks to prevent it so that people don't get confused if it only half works". 20180414 02:41:08<+discordbot> But how could it be done! 20180414 02:42:34<+discordbot> a_r means we can actually technically do something like the above, but the UI API has no way to handle it 20180414 02:43:25< celticminstrel> I think the UI is not as inflexible as you believe, at least in theory (may require some patching of holes). 20180414 02:43:30<+discordbot> It's stuff like that that I'd really like to do, and I'd like it if we could design an improvement to the drawing API to facilitate it 20180414 02:43:34<+discordbot> without hax. 20180414 02:43:42<+discordbot> and that allows UMC authors similar control 20180414 02:43:45< celticminstrel> Like, I don't understand why you can't just build a grid on the fly. 20180414 02:44:14< celticminstrel> Is there any reason why it wouldn't Just Work if you removed the checks explicitly put there to prevent it? 20180414 02:44:17<+discordbot> Mordant designed for a static layout 20180414 02:44:51< celticminstrel> In any case, it's far too early to be thinking about this kind of thing. 20180414 02:45:04<+discordbot> Yeah 20180414 02:45:12<+discordbot> Not right now, but I want to get to it eventually. 20180414 02:45:26<+discordbot> Our UI is too damn static 20180414 02:45:38< celticminstrel> I really don't think that's a bad thing though. 20180414 02:45:49< celticminstrel> There's nothing wrong with a static but perfectly functional UI. 20180414 02:46:07<+discordbot> nothing flows, moves, fades, shifts, or is animated in any way 20180414 02:46:23< celticminstrel> Oftentimes animations of the sort you've been describing don't really add to the experience; in fact, they can detract from it, making the UI feel slower and less responsive (regardless of whether it actually is). 20180414 02:46:37< celticminstrel> We don't need animations. We need something that works, which we have. 20180414 02:46:47<+discordbot> I'm of course thinking of Dota 2 20180414 02:46:55< celticminstrel> We don't need to modernize the game. People will play it even without fancy UI animations. 20180414 02:47:00< celticminstrel> I'm not saying we shouldn't, but. 20180414 02:47:05<+discordbot> it has a lot of fluid UI transitions that make it feel really polished 20180414 02:47:12<+discordbot> We don't need to, but we should 20180414 02:47:20< celticminstrel> That's debatable. 20180414 02:47:21<+discordbot> Just like we don't need map particle effects 20180414 02:47:25<+discordbot> but we should 100% add them 20180414 02:47:52< celticminstrel> If I had to choose between fluid UI animations/transitions and map particle effects, I'd take the latter. 20180414 02:47:54<+discordbot> imagine actually being able to have blowing sand in utbs 20180414 02:48:19<+discordbot> or actual god-damn weather effects in dark forecast 20180414 02:48:31<+discordbot> or transitional ToD lighting 20180414 02:48:39<+discordbot> animated lightbeams 20180414 02:48:42< celticminstrel> I mean, technically all this is probably possible in the current system, but. 20180414 02:49:06<+discordbot> ANIMATED FOG 20180414 02:49:14<+discordbot> we must have animated fog for 1.16 20180414 02:49:18< celticminstrel> Like, the terrain graphics system is basically flexible enough to do everything you're describing here, if I'm not mistaken. 20180414 02:49:21<+discordbot> it is a requirement 20180414 02:49:44<+discordbot> probably, but until now it would have been unbelievably bad for performance 20180414 02:49:51<+discordbot> you can't have fancy graphical effects with software rendering 20180414 02:50:07< celticminstrel> Okay, so uh... we were supposed to have a release tomorrow, right? I think maybe that's not possible. 20180414 02:50:12< celticminstrel> The editor is utterly broken. 20180414 02:50:17<+discordbot> what?? 20180414 02:50:32< celticminstrel> I mean unless there's something weird with my build, but... 20180414 02:50:39< celticminstrel> I can't click any of the palette buttons. 20180414 02:50:59<+discordbot> you mean the toolkit buttons? 20180414 02:51:09< celticminstrel> Yeah those. Palette actually does work. 20180414 02:51:17<+discordbot> jyrki's hotkey commit 20180414 02:51:21< celticminstrel> As do the buttons along the top (or at least the time one). 20180414 02:51:22< celticminstrel> Hmm. 20180414 02:51:30<+discordbot> I swear to god.... 20180414 02:51:42< celticminstrel> Squash one bug, another pops up? 20180414 02:51:45<+discordbot> (it's not his fault, it's our system >_> ) 20180414 02:51:46< celticminstrel> Which commit was this one again? 20180414 02:52:24< celticminstrel> Oh, was it the event queueing thingy? 20180414 02:52:28<+discordbot> https://github.com/wesnoth/wesnoth/commit/64ef0eb1e6830fc61a617a094b6f0cbb6cf97dfc 20180414 02:52:53<+discordbot> frustration with our hotkey system increases 20180414 02:53:41<+discordbot> just........ 20180414 02:53:42<+discordbot> GAAH 20180414 02:53:46<+discordbot> why can't this shit be SIMPLE 20180414 02:53:50<+discordbot> IT SHOULD BE SIMPLE 20180414 02:54:10<+discordbot> and now we have a release blocker introduced in an attempt to fix another blocker 20180414 02:57:42<+discordbot> I'm moving the 1.14.0 tagging from the 22nd to the 25th 20180414 02:58:09<+discordbot> I was considering it anyway since Lb needed more time, but now unless jyrki can fix this today RC 3 will be delayed, s we need those extra 3 days 20180414 02:58:10< celticminstrel> Well, don't be too hasty, if we can fix this by tomorrow there might still be a chance... 20180414 02:58:38< celticminstrel> I'm looking at it because it's blocking what I wanted to do, but I dunno if I'll be able to get anywhere. 20180414 02:59:12<+discordbot> like I said 20180414 02:59:14<+discordbot> LB needed more time 20180414 03:05:18< celticminstrel> If Jyrki shows up, I'm guessing this was introduced somehow due to editor_controller inheriting from command_executor and controller_base, but I'm not sure exactly how that could happen at this point. 20180414 03:05:50<+discordbot> because the entire controller interface is a mess 20180414 03:07:04-!- irker891 [~irker@uruz.ai0867.net] has joined #wesnoth-dev 20180414 03:07:04< irker891> wesnoth/wesnoth:master Martin Hrubý (hrubymar10) 68c1dbeab2 Update link to new MacCompileStuff repo AppVeyor: All builds passed 20180414 03:07:17<+discordbot> Which is the problem I'm having on master 20180414 03:07:44< celticminstrel> I think this bug is the same as 2884. 20180414 03:07:56< celticminstrel> I guess you agree. 20180414 03:08:35< celticminstrel> Well, I guess I'll give up for now and work on my campaign for a bit. 20180414 03:16:49< irker891> wesnoth: Charles Dang wesnoth:master d384b96d97ac / / (7 files in 4 dirs): Removed joystick code https://github.com/wesnoth/wesnoth/commit/d384b96d97acf62cf148a1a6f24e7f59e38f60d1 20180414 03:17:07< celticminstrel> I wish the game would ask to overwrite start-of-scenario saves, just like it asks for replays. >< 20180414 03:17:19< celticminstrel> I just accidentally clobbered the save I was using for testing my campaign. 20180414 03:17:46< celticminstrel> I wonder if I can convert the turn 1 back to a start-of-scenario save... 20180414 03:20:05<+discordbot> blah, missed a bunch of joystick-related code 20180414 03:22:42< celticminstrel> Oh right, maybe I can regenerated it by loading the previous scenario's replay? 20180414 03:25:47< irker891> wesnoth/wesnoth:master Charles Dang d384b96d97 Removed joystick code AppVeyor: vs2015/Release Failed 20180414 03:25:48< irker891> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-2652 20180414 03:28:33< celticminstrel> Ugh, seriously? I get the debug command notification dialog box during a replay? >< 20180414 03:28:51< celticminstrel> And a local campaign replay at that. 20180414 03:34:21< irker891> wesnoth: Charles Dang wesnoth:master 50407c1e8e35 / src/ (5 files in 2 dirs): Cleaned up some joystick-related code I missed (fixup d384b96) https://github.com/wesnoth/wesnoth/commit/50407c1e8e350b2668637e036128b5f66a6b26db 20180414 03:38:24< celticminstrel> Anyway, watching the replay worked for getting my save back, so yay. 20180414 03:43:02< irker891> wesnoth/wesnoth:master Charles Dang 50407c1e8e Cleaned up some joystick-related code I AppVeyor: vs2015/Release Failed 20180414 03:43:03< irker891> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-2653 20180414 03:47:24-!- travis-ci [~travis-ci@ec2-54-204-108-8.compute-1.amazonaws.com] has joined #wesnoth-dev 20180414 03:47:25< travis-ci> wesnoth/wesnoth#17596 (master - d384b96 : Charles Dang): The build was broken. 20180414 03:47:25< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/366387505 20180414 03:47:25-!- travis-ci [~travis-ci@ec2-54-204-108-8.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180414 03:49:01< celticminstrel> Unexpectedly found a nice portrait in Fate of a Princess. 20180414 03:50:31< celticminstrel> Not sure who made it. The credits don't say. 20180414 03:51:03< celticminstrel> This was on the 1.10 addon server? I could've sworn I got it from 1.8? Oh well. 20180414 03:54:50< celticminstrel> Ooh, it has a hydra too. 20180414 03:55:04< celticminstrel> Heh, riderless horse. 20180414 03:56:03<+discordbot> Horseless rider is better 20180414 03:56:15< celticminstrel> Uh. Okay? 20180414 03:56:21<+discordbot> :3 20180414 03:56:54< irker891> wesnoth: Charles Dang wesnoth:master 164b6af76688 / src/hotkey/ (hotkey_item.cpp hotkey_item.hpp): Cleaned up even more joystick-related code... https://github.com/wesnoth/wesnoth/commit/164b6af766888135aad1048470c7fa5cea0dd224 20180414 03:56:55<+discordbot> @hrubymar10 can you update the xcode project? 20180414 03:57:08<+discordbot> need to remove joystick.*pp 20180414 04:06:33< irker891> wesnoth/wesnoth:master Charles Dang 164b6af766 Cleaned up even more joystick-related co AppVeyor: vs2015/Release Failed 20180414 04:06:34< irker891> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-2654 20180414 04:06:43-!- travis-ci [~travis-ci@ec2-54-234-20-18.compute-1.amazonaws.com] has joined #wesnoth-dev 20180414 04:06:44< travis-ci> wesnoth/wesnoth#17597 (master - 50407c1 : Charles Dang): The build was broken. 20180414 04:06:44< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/366389872 20180414 04:06:44-!- travis-ci [~travis-ci@ec2-54-234-20-18.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180414 04:10:51<+discordbot> yes, yes, yes, travis 20180414 04:22:04-!- travis-ci [~travis-ci@ec2-54-234-20-18.compute-1.amazonaws.com] has joined #wesnoth-dev 20180414 04:22:05< travis-ci> wesnoth/wesnoth#17598 (master - 164b6af : Charles Dang): The build is still failing. 20180414 04:22:05< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/366392500 20180414 04:22:05-!- travis-ci [~travis-ci@ec2-54-234-20-18.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180414 04:36:13< irker891> wesnoth/wesnoth:master pentarctagon 52f8e8233c Remove boost-thread from dockerfile. AppVeyor: All builds passed 20180414 05:10:56<+discordbot> @Vultraz only in master? 20180414 05:11:27<+discordbot> @hrubymar10 yes but you could wait a few mins before committing, I have some commits here that cause full rebuilds and I don't want to rebase 😬 20180414 05:11:37<+discordbot> just waiting for my build to finish 20180414 05:11:52<+discordbot> kk 20180414 05:12:35-!- celticminstrel is now known as celmin|sleep 20180414 05:18:17< irker891> wesnoth: Charles Dang wesnoth:master 07b69bdd32e0 / projectfiles/VC14/ (wesnoth.vcxproj wesnoth.vcxproj.filters): Updated VS projectfile https://github.com/wesnoth/wesnoth/commit/07b69bdd32e02743de365ccbec6f731329cab600 20180414 05:18:18<+discordbot> @hrubymar10 ok, done 20180414 05:18:20< irker891> wesnoth: Charles Dang wesnoth:master 17fc9d71dbd9 / src/ (6 files in 3 dirs): Removed bind_void https://github.com/wesnoth/wesnoth/commit/17fc9d71dbd933fa2e37c8fd9aed52a4e2fb5735 20180414 05:18:23< irker891> wesnoth: Charles Dang wesnoth:master 00d87f8fe407 / src/serialization/string_view.hpp: String View: use std::string_view on C++17 (untested) https://github.com/wesnoth/wesnoth/commit/00d87f8fe4078ffd84fcdc0d73fcc2104efef1e7 20180414 05:18:26< irker891> wesnoth: Charles Dang wesnoth:master 96681151f083 / src/ (gettext_boost.cpp global.hpp wml_exception.hpp): Expand NORETURN, enable C99 unconditionally on MSVC https://github.com/wesnoth/wesnoth/commit/96681151f083bb25a3ddb3301083241e36fd6789 20180414 05:19:42< irker891> wesnoth: Martin Hrubý (hrubymar10) wesnoth:master 9329daf0da0e / projectfiles/Xcode/Wesnoth.xcodeproj/project.pbxproj: Fix Xcode project after d384b96d97acf62cf148a1a6f24e7f59e38f60d1 https://github.com/wesnoth/wesnoth/commit/9329daf0da0e0fd7014cb2212859043c1cff1809 20180414 05:20:26<+discordbot> ty 20180414 05:20:46<+discordbot> np 20180414 05:20:56<+discordbot> You are using C++17 in VS? 20180414 05:20:59<+discordbot> No. 20180414 05:21:06<+discordbot> Still 14 20180414 05:21:18<+discordbot> String View: use std::string_view on C++17 20180414 05:21:31<+discordbot> It's conditional 20180414 05:22:01<+discordbot> it's also untested 😛 20180414 05:22:23<+discordbot> I just tested that wesnoth can't be builded with C++17 at all 😄 20180414 05:22:33<+discordbot> very likely 😛 20180414 05:22:35<+discordbot> no one has done it 20180414 05:22:39<+discordbot> what's the problem? 20180414 05:23:40<+discordbot> I'll send you full error list, but on 150 from 506 I have 82 compile errors 😄 20180414 05:24:20<+discordbot> oh, there are also errors from boost 😄 20180414 05:24:29<+discordbot> not only wesnoth itself 20180414 05:24:35<+discordbot> of course, of course 20180414 05:24:39<+discordbot> I had a working c++17 travis build on ubuntu 18.04 just earlier today. 20180414 05:24:44<+discordbot> oh? 20180414 05:24:49<+discordbot> perhaps my commit just broke it.. 20180414 05:26:13<+discordbot> https://travis-ci.org/Pentarctagon/wesnoth/jobs/366154493 20180414 05:28:09<+discordbot> based on master from a week ago, admittedly 20180414 05:28:58<+discordbot> but should be relevant, unless there's been other untested c++17 code added as well 20180414 05:33:39<+discordbot> @jyrkive urgent blocker: https://github.com/wesnoth/wesnoth/issues/2884 20180414 05:34:22<+discordbot> editor is essentially completely because of it 20180414 05:34:54<+discordbot> C++17 errors in Xcode: http://ix.io/17J6 20180414 05:35:56<+discordbot> oh 20180414 05:35:57<+discordbot> dir 20180414 05:35:58<+discordbot> dur* 20180414 05:36:17<+discordbot> of course 20180414 05:38:42<+discordbot> @hrubymar10 hang on 20180414 06:13:36-!- travis-ci [~travis-ci@ec2-54-204-108-8.compute-1.amazonaws.com] has joined #wesnoth-dev 20180414 06:13:37< travis-ci> wesnoth/wesnoth#17600 (master - 9329daf : Martin Hrubý (hrubymar10)): The build was fixed. 20180414 06:13:37< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/366403519 20180414 06:13:37-!- travis-ci [~travis-ci@ec2-54-204-108-8.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180414 06:25:42<+discordbot> @hrubymar10 can you try now? 20180414 06:25:50< irker891> wesnoth: Charles Dang wesnoth:master 9977addd6450 / src/config_attribute_value.hpp: Removed duplicate config_key_type alias https://github.com/wesnoth/wesnoth/commit/9977addd64505b3042cd2a2a9e26f2a7a84acd5c 20180414 06:25:53< irker891> wesnoth: Charles Dang wesnoth:master 52a516cfb77b / src/ (config.hpp serialization/string_view.hpp): Expand and fixup 00d87f8 https://github.com/wesnoth/wesnoth/commit/52a516cfb77bf16e4f953d46e5292bce8d60d04b 20180414 06:27:25<+discordbot> compiling 20180414 06:48:25-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180414 06:50:42-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20180414 06:50:48<+discordbot> well less errors but still can't pass compilation 20180414 06:51:10<+discordbot> 110 errors before -> 97 errors now 😄 20180414 06:51:17<+discordbot> 😦 20180414 06:51:29<+discordbot> You want err log? 20180414 06:53:06<+discordbot> I can take a look 20180414 06:53:30<+discordbot> and do you want full build log or only errors? 20180414 06:53:36<+discordbot> errors 20180414 06:57:22-!- atarocch [~atarocch@93.56.164.28] has quit [Ping timeout: 264 seconds] 20180414 06:57:29<+discordbot> http://ix.io/17Jh 20180414 06:59:04<+discordbot> hm. 20180414 06:59:23<+discordbot> yeah, I really dunno what's going on with these boost errors 20180414 07:00:55<+discordbot> probably has to do with the c++ version with which boost is built 20180414 07:01:03<+discordbot> std::auto_ptr was removed in c++17 20180414 07:01:18<+discordbot> as for the gettext stuff.. 20180414 07:01:25<+discordbot> I guess the attribute needs to be after staic? 20180414 07:01:26<+discordbot> MacBook-Pro:~ user$ brew info boost boost: stable 1.66.0 (bottled), HEAD Collection of portable C++ source libraries https://www.boost.org/ /usr/local/Cellar/boost/1.66.0 (13,101 files, 435.2MB) * Poured from bottle on 2018-02-09 at 20:24:59 From: https://github.com/Homebrew/homebrew-core/blob/master/Formula/boost.rb ==> Dependencies Optional: icu4c ✔ ==> Options --with-icu4c Build regexp engine with icu support 20180414 07:01:26<+discordbot> --without-single Disable building single-threading variant --without-static Disable building static library variant --HEAD Install HEAD version 20180414 07:01:46<+discordbot> This build used this boost 20180414 07:02:32<+discordbot> I can use one from MCS but the version of boost in MCS is now newest so I don't think that it will make any difference 20180414 07:02:39<+discordbot> the alternative is that boost doesn't build with c++17 20180414 07:03:06<+discordbot> Maybe Boost itself was built without C++17 support? 20180414 07:03:14<+discordbot> that's what I'm saying 20180414 07:03:32<+discordbot> But it has problem with headers, doesn't it? 20180414 07:03:52<+discordbot> it can't use auto_ptr with c++17 20180414 07:03:54<+discordbot> Boost headers have #ifdefs all over the place. 20180414 07:03:55<+discordbot> it doesnt exist 20180414 07:04:28<+discordbot> It's very likely that the auto_ptr codepath isn't compiled in when the right compiling options are used. 20180414 07:04:43<+discordbot> boost headers are generated by b2 script probably. I can't remember now 20180414 07:05:12<+discordbot> So yes, I probably can try rebuild MCS boost using C++17 20180414 07:05:25<+discordbot> Here's our documentation about how to build Boost for Visual Studio: https://github.com/aquileia/external 20180414 07:06:38<+discordbot> This is build script for MCS https://github.com/hrubymar10/MacCompileStuff/blob/master/SourcesAndScripts/Scripts/boost_build 20180414 07:07:43<+discordbot> BTW new MacCompileStuff is completed now and tested on oldest supported os (OS X 10.8) and newest (macOS 10.13) 20180414 07:08:10<+discordbot> All is prepared for upcoming 1.13.14 😄 20180414 07:09:09<+discordbot> We cannot release 1.13.14 tomorrow unless jyrki fixes the hotkey bug 😦 20180414 07:10:27<+discordbot> After debugging the current 1.14, I don't understand how the sidebar buttons have even worked before. 20180414 07:10:27<+discordbot> Why is every version released at 0:01 UTC? 20180414 07:10:45<+discordbot> I checked out the last working revision. Building it now so that I can debug how it worked. 20180414 07:11:30<+discordbot> We have CEST now, so +2:00. That means that I should create package at 2:01AM 😦 20180414 07:11:34<+discordbot> 😄 20180414 07:13:07<+discordbot> You can create it later. 20180414 07:13:09<+discordbot> I use 1 minute after midnight in order to make it clear what day I mean 20180414 07:13:10-!- gallaecio [~quassel@188.79.96.255] has joined #wesnoth-dev 20180414 07:15:03<+discordbot> Someone said using 00:00 was unclear 20180414 07:15:13<+discordbot> Well this release is ok, but the stable release 1.14.0 will be problem, because it means 2:01 at Wednesday 20180414 07:15:46<+discordbot> 1.14.0 is supposed to be tagged on April 25, but only announced in May 1. 20180414 07:15:59<+discordbot> There's easily enough time to make the build. 20180414 07:16:12<+discordbot> oh, ok then 😄 20180414 07:16:50<+discordbot> I see you read the backlog 👍 20180414 07:17:22<+discordbot> (Jyrki) 20180414 07:17:45<+discordbot> I find reading the backlog is a responsibility of every project member. 20180414 07:18:16<+discordbot> and btw, what about wesnoth dir? In which release will be renamed to Wesnoth_1.14? 20180414 07:18:26-!- travis-ci [~travis-ci@ec2-54-224-78-189.compute-1.amazonaws.com] has joined #wesnoth-dev 20180414 07:18:27< travis-ci> Pentarctagon/wesnoth#424 (master - 9329daf : Martin Hrubý (hrubymar10)): The build passed. 20180414 07:18:27< travis-ci> Build details : https://travis-ci.org/Pentarctagon/wesnoth/builds/366411601 20180414 07:18:27-!- travis-ci [~travis-ci@ec2-54-224-78-189.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180414 07:18:37<+discordbot> 1.14 20180414 07:18:45<+discordbot> It happens automatically 20180414 07:19:00<+discordbot> not in macOS package 😄 20180414 07:19:38<+discordbot> I’m referring to the user data folder 20180414 07:19:47<+discordbot> yes 20180414 07:21:08<+discordbot> https://github.com/wesnoth/wesnoth/commit/0a9b10cfa8863b56fc8f309fb49e2fdbbd516c53#diff-6ad4699f8d404be493a9e9396834814d 20180414 07:24:27-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20180414 07:28:09-!- Oebele [~quassel@143.177.58.202] has joined #wesnoth-dev 20180414 07:28:55-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20180414 07:30:19<+discordbot> Is that the only thing that controls the name? 20180414 07:30:27<+discordbot> If so it should be changed before 1.14 proper 20180414 07:32:11<+discordbot> Yes, it is 20180414 07:32:25<+discordbot> I would change it after 1.13.14 tag 20180414 07:33:04<+discordbot> Ok 20180414 07:36:26< irker891> wesnoth/wesnoth:1.14 mattsc 84c39de58d Merge pull request #2876 from mattsc/rec AppVeyor: All builds passed 20180414 07:40:54<+discordbot> Or will be better to create PR with blocker status so you will have to merge it before 1.14 tag? 20180414 07:41:14<+discordbot> Creating a PR would be a good idea. 20180414 07:43:56-!- grzywacz [~karol@89-70-226-147.dynamic.chello.pl] has joined #wesnoth-dev 20180414 07:49:19-!- grzywacz [~karol@89-70-226-147.dynamic.chello.pl] has quit [Ping timeout: 256 seconds] 20180414 07:55:21< irker891> wesnoth: Jyrki Vesterinen wesnoth:1.14 a0b54b1513e8 / src/hotkey/ (command_executor.cpp command_executor.hpp): Fix #2884: minimap buttons don't do anything https://github.com/wesnoth/wesnoth/commit/a0b54b1513e840498e90572e0e4b9687df36a9cd 20180414 08:01:14<+discordbot> also a little interesting, clang 7 has a sanitizer that actually requries LTO: https://clang.llvm.org/docs/ControlFlowIntegrity.html 20180414 08:25:49< irker891> wesnoth/wesnoth:master Charles Dang d384b96d97 Removed joystick code AppVeyor: 1/2 builds failed 20180414 08:25:50< irker891> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-2652 20180414 08:26:56<+discordbot> I have calendar event that 23th April I'll create PR with userdir version bump on macOS 20180414 08:31:43-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20180414 08:39:24< irker891> wesnoth: pentarctagon wesnoth:master 66caa190f6dc / utils/travis/steps/install.sh: Make LTO controllable via travis env variable. https://github.com/wesnoth/wesnoth/commit/66caa190f6dcde039cc5cb73e4f43a061aef43b8 20180414 08:39:26< irker891> wesnoth: pentarctagon wesnoth:master 2ed9d2c0c4d1 / utils/travis/steps/install.sh: Allow setting EXTRA_FLAGS_RELEASE to something other than -O0. https://github.com/wesnoth/wesnoth/commit/2ed9d2c0c4d1d079190ff5bd2a8a287f9076d198 20180414 08:39:28< irker891> wesnoth: pentarctagon wesnoth:master 92f74c39f6ae / utils/travis/ (docker_run.sh steps/script.sh): Allow setting a sanitizer to use. https://github.com/wesnoth/wesnoth/commit/92f74c39f6aedc10bd04f1cf6dc9144fb35e3a19 20180414 08:39:30< irker891> wesnoth: pentarctagon wesnoth:master 5d970e40cd43 / utils/travis/docker_run.sh: Add a check to fail the job if compiling takes too long. https://github.com/wesnoth/wesnoth/commit/5d970e40cd43a23a8d1b8198e962f198fc9282b0 20180414 08:39:32< irker891> wesnoth: pentarctagon wesnoth:master 7aeca70cb04f / SConstruct: Allow setting c++17 in scons. https://github.com/wesnoth/wesnoth/commit/7aeca70cb04f1990aeef0213b88ec80b0f4d24f8 20180414 08:43:04< irker891> wesnoth/wesnoth:master Charles Dang 50407c1e8e Cleaned up some joystick-related code I AppVeyor: 1/2 builds failed 20180414 08:43:05< irker891> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-2653 20180414 08:51:58-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20180414 09:01:26<+discordbot> Does the commit need be in master too? 20180414 09:05:26<+discordbot> No, the ThemeWML sidebar doesn't exist in master. 20180414 09:06:35< irker891> wesnoth/wesnoth:master Charles Dang 164b6af766 Cleaned up even more joystick-related co AppVeyor: 2/4 builds failed 20180414 09:06:36< irker891> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-2654 20180414 09:06:37< irker891> Details vs2017/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-master-2362 20180414 09:11:25<+discordbot> @sevu units.wesnoth.org isn't updating 1.12 because of filesystem corruption issues, for the record. 20180414 09:12:00<+discordbot> So, no need to bother elias about it because there's nothing he can do. I need to get one of the host admins to look into it at an appropriate time. 20180414 09:22:29<+discordbot> ah, right 20180414 09:22:31<+discordbot> right 20180414 09:22:52<+discordbot> @jyrkive anyway, good work tracking that down asap 👍 20180414 09:23:58<+discordbot> I have said that I strongly prioritize regressions I have caused. 20180414 09:25:41<+discordbot> Because 1) such bugs are easiest for me to investigate, since I know how the code is supposed to work, 2) the code logic is still fresh in my mind, and 3) I really don't want to cause additional work for other developers. 20180414 09:26:01< irker891> wesnoth: Charles Dang wesnoth:master 66dc67140f93 / src/ (8 files in 4 dirs): CVideo: removed "help string" interface https://github.com/wesnoth/wesnoth/commit/66dc67140f9360d6f14154beae364c9d3a3a523e 20180414 09:26:16<+discordbot> certainly, but I was really worried it might take several days to track down the exact issue 20180414 09:26:45<+discordbot> 100% reproducible bugs are almost always easy to debug. 20180414 09:42:36<+discordbot> yeah, some changes got lost in rebase 20180414 09:46:13< irker891> wesnoth: Charles Dang wesnoth:master c43f801affd4 / src/video.cpp: Fixup 66dc671 (fixes #2887) https://github.com/wesnoth/wesnoth/commit/c43f801affd4018c93b7071d7de983082c368339 20180414 09:46:59< matthiaskrgr> :> 20180414 09:50:24-!- travis-ci [~travis-ci@ec2-54-204-108-8.compute-1.amazonaws.com] has joined #wesnoth-dev 20180414 09:50:25< travis-ci> wesnoth/wesnoth#17605 (master - 66dc671 : Charles Dang): The build was broken. 20180414 09:50:25< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/366444114 20180414 09:50:25-!- travis-ci [~travis-ci@ec2-54-204-108-8.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180414 10:11:55<+discordbot> @Vultraz can we have steam's translations managed like that? https://github.com/hrubymar10/wesnoth-steam 20180414 10:12:15<+discordbot> @shadowm is handling that 20180414 10:12:33<+discordbot> I am going to work on it over the next couple of days. 20180414 10:13:16<+discordbot> kk, you can use my base (like founded strings) 20180414 10:16:18< irker891> wesnoth: Charles Dang wesnoth:master dbb56599c591 / src/gui/ (core/canvas.cpp core/canvas.hpp widgets/styled_widget.cpp): GUI2/Canvas: consolidate set_width and set_height into a single function https://github.com/wesnoth/wesnoth/commit/dbb56599c591e988e2955ebb01f552b8b798ef75 20180414 10:35:50<+discordbot> blah 20180414 10:35:52<+discordbot> DPI is hard 20180414 10:54:48<+discordbot> I can get stuff to display at high dpi.... somewhat 20180414 10:54:55<+discordbot> but stuff like hover states are totally broken 20180414 11:13:18< irker891> wesnoth: Charles Dang wesnoth:master 7621719c9a10 / src/video.cpp: CVideo: added a macOS codepth for DIP fetch in screen_area() https://github.com/wesnoth/wesnoth/commit/7621719c9a1009bf20e9a64482682ed38109769c 20180414 11:13:54<+discordbot> (yes, I meant DIP not DPI) 20180414 11:47:51-!- gfgtdf [~chatzilla@x4e363e1a.dyn.telefonica.de] has joined #wesnoth-dev 20180414 11:58:11< irker891> wesnoth: newfrenchy83 wesnoth:master 606981bd22e8 / projectfiles/CodeBlocks/wesnoth.cbp: Update wesnoth.cbp (#2890) https://github.com/wesnoth/wesnoth/commit/606981bd22e88b0a24674ca2c3f937b73ede1eb8 20180414 12:06:29<+discordbot> hm. --wconsole still spawns a new console instance... 20180414 12:06:39<+discordbot> (if used from the cl) 20180414 13:03:07< celmin|sleep> Okay, so what I need seems to be to get a reference to the editor_toolkit from within the context_manager... 20180414 13:03:23< celmin|sleep> ...oh, forgot to change nick 20180414 13:03:26-!- celmin|sleep is now known as celticminstrel 20180414 13:15:25< irker891> wesnoth/wesnoth:master Charles Dang 52a516cfb7 Expand and fixup 00d87f8 AppVeyor: All builds passed 20180414 13:37:37-!- grzywacz [~karol@wesnoth/developer/grzywacz] has joined #wesnoth-dev 20180414 13:43:50< celticminstrel> Works! \o/ 20180414 13:44:03< celticminstrel> Can I push this to 1.14? 20180414 13:44:13< celticminstrel> I'll push it to a branch first so people can look at it, I guess. 20180414 13:49:23<+discordbot> what? 20180414 13:49:28<+discordbot> what are you doing 20180414 13:50:27< celticminstrel> https://github.com/wesnoth/wesnoth/issues/1023 20180414 13:50:38<+discordbot> I see 20180414 13:51:11< celticminstrel> Also made it keep the locations sorted. 20180414 13:51:45<+discordbot> I think it would be best to push the fix to 1.14. It's a quite severe bug. 20180414 13:54:28< celticminstrel> Not quite finished, need to make sure it also works with scenarios that have more than 9 sides. 20180414 14:01:48< mattsc> @Vultraz I’ll eventually put the AI recall bug fix into 1.15, but there are other changes needed too. I’ll probably cherry-pick and build on top of it, but not quite sure yet. 20180414 14:01:56<+discordbot> ok 20180414 14:03:20< gfgtdf> maybe make a pr first so we can takea look at it? 20180414 14:03:21< mattsc> @Vultraz Still planning to tag in 10 hours or so? I need to update the changelog. I can just commit that directly, right? Or am I going to create conflicts for somebody? 20180414 14:03:34< gfgtdf> sry wrong scrolling position 20180414 14:03:47< mattsc> @gfgtdf you mean me? Yes, of course. 20180414 14:03:50< gfgtdf> celticminstrel: are you goping to maka pr for it ? 20180414 14:04:00< celticminstrel> No don't make a PR for the changelog. 20180414 14:04:04< celticminstrel> Just commit it to 1.14. 20180414 14:04:17< mattsc> celticminstrel: Right. 20180414 14:04:29< celticminstrel> gfgtdf: I wasn't planning to make a PR, but if you want to look at it before it goes into 1.14 I can push the commit to a branch. 20180414 14:04:36< mattsc> I was talking about the additional changes needed for AI recalling for 1.15. 20180414 14:04:53< mattsc> Too many conversations in parallel... 20180414 14:08:10< celticminstrel> mattsc: While looking into the pathfinding-with-custom-cost issue I noticed that the move leader to goal phase also ignores teleport locations. 20180414 14:09:41<+discordbot> Tag in 10 hours, yes 20180414 14:10:56< mattsc> celticminstrel: I see. That’s probably undesirable (=unintuitive) as well. 20180414 14:11:28< mattsc> I guess leader goals are no used very often, so that’s probablywhy we have not noticed before. 20180414 14:16:47< mattsc> @Vultraz Are there directives whether changelog entries should be present or past tense? 20180414 14:17:01< mattsc> The bug fixes section constains many ‘fixed’s and one ‘fix’ 20180414 14:17:02<+discordbot> not really? 20180414 14:17:18<+discordbot> we usually use past, I guess 20180414 14:17:46< mattsc> I personally don’t care which one we use, but my nit-picky mind says that it should at least be consistent. :P 20180414 14:18:03< mattsc> … within the same block in the changelog 20180414 14:18:26< mattsc> I’ll change the fix->fixed while I’m at it then 20180414 14:18:56<+discordbot> sure 20180414 14:19:03< mattsc> I can also do the justification to 80 columns, if you want 20180414 14:19:04< irker891> wesnoth: Celtic Minstrel wesnoth:pf_custom_cost 37a2b54f32e1 / src/scripting/game_lua_kernel.cpp: wesnoth.find_path: Allow specifying custom flags (in particular teleport) when u https://github.com/wesnoth/wesnoth/commit/37a2b54f32e18277d54a773076a5ef9b2619abdf 20180414 14:19:06< irker891> wesnoth: Celtic Minstrel wesnoth:pf_custom_cost e4589e2cb39a / src/ai/default/ca.cpp: Fix AI ignoring teleport locations when moving leader to leader goals https://github.com/wesnoth/wesnoth/commit/e4589e2cb39af401019383e81ef077cce65e5efd 20180414 14:19:08< celticminstrel> ^ Now against master, should I open a PR? 20180414 14:19:19< celticminstrel> mattsc: Please do. 20180414 14:19:43<+discordbot> we don't need 80... 20180414 14:19:45<+discordbot> seriously 20180414 14:19:58< celticminstrel> It hurts no-one to justify it to 80 columns. 20180414 14:20:01<+discordbot> can we drop this archaic practice? 20180414 14:20:08< celticminstrel> And it takes maybe a minute or two to do it. 20180414 14:20:16< celticminstrel> And it probably helps a few people. 20180414 14:20:22< celticminstrel> So really, there's no reason not to do it. 20180414 14:20:33<+discordbot> There's no reason to do it at all 20180414 14:20:49<+discordbot> who in 2018 has a terminal window that doesn't maximize past 80 20180414 14:20:53< celticminstrel> (That estimate is pretty generous too, you could probably get it done in less than a minute with proper tools.) 20180414 14:21:06< celticminstrel> I don't know, but I'm sure they exist. 20180414 14:21:13<+discordbot> @Vultraz Someone who has multiple terminal windows in the same screen? 20180414 14:21:16< mattsc> Took me about 20 seconds ... 20180414 14:21:19< celticminstrel> ^ 20180414 14:21:33< celticminstrel> There you go, it's trivial to do and hurts no-one, so we might as well just do it. 20180414 14:21:44< mattsc> My editor is set to have light gray background past 80 chars 20180414 14:21:44< celticminstrel> FTR I prefer to see justification and new/fixed entries in separate commits, though. 20180414 14:21:54<+discordbot> whatever 20180414 14:22:16< mattsc> I personally don’t care, but I see that it is still done through 1.13.13, so I asked. :) 20180414 14:22:26< celticminstrel> I think my editor doesn't have that (though it can, I just turned it off) but it does have an auto-hard-wrap command... though unfortunately it doesn't work too well with indented lines. 20180414 14:22:27< mattsc> Don’t care one way or the other, I mean, no preference 20180414 14:22:27< Ravana_> windows terminal is limited to 80 char 20180414 14:22:51<+discordbot> no it's not 20180414 14:23:03<+discordbot> at least not with windows 10 20180414 14:23:04-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20180414 14:24:23< irker891> wesnoth: mattsc wesnoth:1.14 ab8c4c39eae8 / changelog.md: Update changelog https://github.com/wesnoth/wesnoth/commit/ab8c4c39eae83bdaff7ab1c54beafc4d79acd198 20180414 14:24:24< Ravana_> I see, it needs changing settings for that, dragging doesn't resize it 20180414 14:24:37<+discordbot> does for me 20180414 14:24:50<+discordbot> (resizes the window, that is) 20180414 14:24:56< celticminstrel> I think it's possible to change the size even in Win7 but I've never bothered. 20180414 14:25:04<+discordbot> dunno if it re-wraps the output 20180414 14:25:49< mattsc> Interesting. My github app syncs vs. ‘origin’ (my fork), and the command-line git syncs vs. ‘upstream’ (the main repo) 20180414 14:26:07< mattsc> By default, I mean. Can change that, of course. 20180414 14:27:50< mattsc> celticminstrel: Oops, missed your separate commits comment there, sorry. 20180414 14:28:12< mattsc> And I even agree with you. :P 20180414 14:28:32<+discordbot> It's not about terminal size, it's about having code able to be shared: by paper, by mail, by web, by slides. 20180414 14:29:00<+discordbot> .................what 20180414 14:29:43< mattsc> celticminstrel: Sometime in the next 48h I’ll also get on the wiki changes and reply to the person who reported the recall bug on the forums. 20180414 14:30:14< mattsc> Since those aren’t time critical though, I won’t do them right now. I just got home. And I might actually not travel for a few weeks now … 20180414 14:36:26-!- Bhoren [~Bhoren_wh@2a01:e0a:c:2150:154:8a44:fdbd:8f2] has joined #wesnoth-dev 20180414 14:36:52< mattsc> celticminstrel: I can’t help but wonder what other bugs are hidden in the AI code … 20180414 14:37:37< mattsc> Since it is non-trivial to notice when the AI does not do what it is supposed to do, some of them might go unnoticed for a long time. 20180414 14:43:59-!- Oebele [~quassel@143.177.58.202] has quit [Remote host closed the connection] 20180414 14:48:52<+discordbot> https://cdn.discordapp.com/attachments/259976436490829825/434726742993666058/lobby.png 20180414 14:50:36-!- travis-ci [~travis-ci@ec2-54-224-78-189.compute-1.amazonaws.com] has joined #wesnoth-dev 20180414 14:50:37< travis-ci> wesnoth/wesnoth#17615 (pf_custom_cost - e4589e2 : Celtic Minstrel): The build is still failing. 20180414 14:50:37< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/366502863 20180414 14:50:37-!- travis-ci [~travis-ci@ec2-54-224-78-189.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180414 14:50:38<+discordbot> Hmmm, I hosted a game with an add-on which isn't on the server yet, and which has no _info.cfg either... This message I got with another client (which has not the addon) 20180414 14:53:07< Ravana_> that message should at least say what id was expected that was not found 20180414 14:54:39<+discordbot> id of the game? It happens if I try to join the game 20180414 14:54:43<+discordbot> addon not on the server, you say? 20180414 14:54:48<+discordbot> yes 20180414 14:54:50<+discordbot> well... 20180414 14:55:00<+discordbot> I'm not sure how to handle that................... 20180414 14:55:33<+discordbot> ah, it has require_era=no, so anybody should be able to join 20180414 14:56:51<+discordbot> groans 20180414 14:56:52<+discordbot> even worse 20180414 14:57:32< irker891> wesnoth: Charles Dang wesnoth:master 29fcbd053da6 / src/ (5 files in 4 dirs): Replaced round_double and round_portable with std::round https://github.com/wesnoth/wesnoth/commit/29fcbd053da63b790eb3b4fac32e204b054929d4 20180414 14:58:01<+discordbot> though maybe it's not so bad.. 20180414 14:58:03<+discordbot> let me see here.. 20180414 14:59:12<+discordbot> @sevu do you have a working build on master? 20180414 14:59:30< Ravana_> it is open as #2747 20180414 15:00:33<+discordbot> an a few days old one 20180414 15:00:52<+discordbot> hm 20180414 15:00:58<+discordbot> I think I see the problem 20180414 15:01:46< celticminstrel> Blargh does anyone know the issue number of the pathfinding bug. 20180414 15:01:59< celticminstrel> I almost wrote pathfunding, which would be another thing entirely. 20180414 15:02:01< celticminstrel> mattsc: ^ 20180414 15:02:53< irker891> wesnoth: Charles Dang wesnoth:master ab54b62553d5 / src/game_initialization/lobby_data.cpp: Attempt to fix non-required era being flagged for download https://github.com/wesnoth/wesnoth/commit/ab54b62553d5e6b3224ecf34c0e448eb58a972e9 20180414 15:02:54<+discordbot> @Ravana @sevu can either of you test that change ^ 20180414 15:03:06<+discordbot> see if it resolves your issue 20180414 15:08:05<+discordbot> @Vultraz You might want to check the c++17 job that's been added in #2888: It's got tons of repeated warnings: https://travis-ci.org/wesnoth/wesnoth/jobs/366455302 And some other warnings/errors: https://travis-ci.org/wesnoth/wesnoth/jobs/366511005 20180414 15:18:10-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20180414 15:18:22< irker891> wesnoth: Celtic Minstrel wesnoth:fix_1023 47e423579d12 / src/editor/ (4 files in 3 dirs): Editor: Refresh named locations list when map context changes (fixes #1023) https://github.com/wesnoth/wesnoth/commit/47e423579d12ecc1a20a42017e8dd5efc8d30fae 20180414 15:18:27< celticminstrel> gfgtdf: ^ 20180414 15:19:35< celticminstrel> I'll merge in about half an hour if there's no objections. 20180414 15:20:45-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20180414 15:23:15< gfgtdf> celticminstrel: but the doesnt remove the old items yet (when switching a map) right ? 20180414 15:23:26< celticminstrel> Right. I decided that wasn't really important. 20180414 15:23:43< celticminstrel> In fact it might be useful to not remove them, if you want to use the same items on multiple maps. 20180414 15:24:16< celticminstrel> Probably wouldn't be hard to do on top of that commit though. 20180414 15:26:12< gfgtdf> ye looks good to me from what i can tell right now. 20180414 15:28:16< gfgtdf> does the texified where you enter the id support copying and pasting ? 20180414 15:28:23< mattsc> celticminstrel: pathfunding would be good too. There’s no issue report on the pathfinding bug 20180414 15:28:46< mattsc> it was reported as a MAI problem on the other irc channel, I believe. 20180414 15:29:21< celticminstrel> Oh, okay then. 20180414 15:29:32< gfgtdf> just saw this todo: https://github.com/wesnoth/wesnoth/blob/1.13.13/src/editor/palette/location_palette.cpp#L76 20180414 15:29:48< mattsc> Grr, and I always “say” Micro AI in my mind when I type MAI, this the (repeated) grammar error. 20180414 15:30:09< mattsc> s/thus/this (I’ll stop now!) 20180414 15:30:48< celticminstrel> gfgtdf: I'm not sure, but probably? It's a GUI2 dialog, I think. 20180414 15:31:17< irker891> wesnoth/wesnoth:1.14 Jyrki Vesterinen a0b54b1513 Fix #2884: minimap buttons don't do anyt AppVeyor: All builds passed 20180414 15:34:27<+discordbot> @Vultraz Can you try to join the game on the 1.15 server? 20180414 15:36:01<+discordbot> @sevu I can 20180414 15:36:18<+discordbot> great great 20180414 15:36:28<+discordbot> oos on turn 1 though 20180414 15:36:52<+discordbot> so the bug is fixed? 20180414 15:36:56<+discordbot> it is 20180414 15:37:14-!- travis-ci [~travis-ci@ec2-54-166-67-148.compute-1.amazonaws.com] has joined #wesnoth-dev 20180414 15:37:15< travis-ci> Pentarctagon/wesnoth#429 (travis-17 - 2e6deca : pentarctagon): The build failed. 20180414 15:37:15< travis-ci> Build details : https://travis-ci.org/Pentarctagon/wesnoth/builds/366510990 20180414 15:37:15-!- travis-ci [~travis-ci@ec2-54-166-67-148.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180414 15:37:38<+discordbot> The OOS could be my fault. The addon tries to load the UtBS from mainline, but I don't know if this actually is allowed 20180414 15:37:56<+discordbot> you need to update the addon 20180414 15:38:02<+discordbot> no more desert elves 20180414 15:38:06<+discordbot> they have been removed 20180414 15:38:19<+discordbot> I wrote it today for quenoth 20180414 15:38:31<+discordbot> then it must not be allowed 20180414 15:40:46< irker891> wesnoth: Charles Dang wesnoth:master 227c8ba20c24 / changelog.md: Changelog entry for ab54b62 https://github.com/wesnoth/wesnoth/commit/227c8ba20c24260a26c013d6f66f924af0c49632 20180414 15:41:59< gfgtdf> vultraz: will you backport it to 1.14 ? 20180414 15:42:21<+discordbot> of couse 20180414 15:43:56< gfgtdf> i wonder why we need that era chck in the first place? shouldn't eras be convered by the for(const config& addon : game.child_range("addon")) { loop above aswell ? 20180414 15:44:07< irker891> wesnoth: Charles Dang wesnoth:1.14 e6d4b4113a01 / src/game_initialization/lobby_data.cpp: Attempt to fix non-required era being flagged for download https://github.com/wesnoth/wesnoth/commit/e6d4b4113a011dd1ef34bc7bde75fee3892b9f82 20180414 15:44:10< irker891> wesnoth: Charles Dang wesnoth:1.14 d0d7bd1722a9 / changelog.md: Changelog entry for e6d4b4113a0 https://github.com/wesnoth/wesnoth/commit/d0d7bd1722a988d37c31ea6ef66cd712e6964b70 20180414 15:44:22<+discordbot> yes they are 20180414 15:44:31< Ravana_> when working on that code, #2851 might be suitable to handle 20180414 15:45:11< celticminstrel> @sevu It's generally not safe to assume UtBS even exists for all clients. 20180414 15:45:24<+discordbot> if it doesn't someone's fucked up 20180414 15:45:33< celticminstrel> No, it's deliberate. 20180414 15:45:36<+discordbot> gfgtdf: that loop covers addons tho, not the era specifically 20180414 15:45:47< celticminstrel> I don't understand why, but it's deliberate. 20180414 15:45:52<+discordbot> what? 20180414 15:46:15<+discordbot> gfgtdf: i think you're right about checking require_era in the other codepath too tho actually 20180414 15:46:16<+discordbot> i htink I'll do that 20180414 15:46:38<+discordbot> tho 20180414 15:46:46<+discordbot> hm 20180414 15:47:28<+discordbot> @Ravana what is a private game 20180414 15:48:34<+discordbot> celmin: how in hell could utbs not be installed 20180414 15:48:40< celticminstrel> ... 20180414 15:48:55< celticminstrel> I'm quite sure this has come up numerous times before. 20180414 15:49:00<+discordbot> some linux distros have campaigns in a separate package 20180414 15:49:02< celticminstrel> ^ 20180414 15:49:05<+discordbot> wat 20180414 15:49:13<+discordbot> why 20180414 15:49:32<+discordbot> I am literally current gaping at my screen with disbelief. 20180414 15:49:51<+discordbot> size maybe? I dunno. 20180414 15:50:01<+discordbot> I know it's not safe, but I thought it's worthy the risk 20180414 15:50:28<+discordbot> Linux is weird 20180414 15:50:41<+discordbot> All about user freedom. 😉 20180414 15:51:07<+discordbot> my opinion at least, is that even if they do that, there's no reason we have to support people deciding to split wesnoth up into multiple packages. 20180414 15:51:16<+discordbot> Agreed. 20180414 15:51:44< celticminstrel> What confuses me most is how Vultraz didn't know this already. 20180414 15:51:55< celticminstrel> Like I'm pretty sure it's been mentioned numerous times in his presence. 20180414 15:52:08<+discordbot> I probably mentally discarded it 20180414 15:52:36< celticminstrel> Not good. 20180414 15:53:20< irker891> wesnoth: Charles Dang wesnoth:master 35590fd842cc / src/game_initialization/lobby_data.cpp: Lobby Info: filter on game name first https://github.com/wesnoth/wesnoth/commit/35590fd842ccaf6ff43769c88738813e0f06c1f5 20180414 15:53:40-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20180414 15:53:43< irker891> wesnoth: Charles Dang wesnoth:1.14 b4bbb6cec775 / src/game_initialization/lobby_data.cpp: Lobby Info: filter on game name first https://github.com/wesnoth/wesnoth/commit/b4bbb6cec7753ee4c5cdf6257d58863346ec538c 20180414 15:54:41< Ravana_> private game is one that is created with observers disabled 20180414 15:54:45<+discordbot> gfgtdf: you make a good point about the addon probably already handing the era though 20180414 15:54:57<+discordbot> hmm 20180414 15:55:02<+discordbot> 🤔 20180414 15:55:54<+discordbot> @Ravana the code indicates you should be able to join 20180414 15:56:19<+discordbot> or, wait 20180414 15:56:24<+discordbot> no, I'm looking at observe 20180414 15:56:30< Ravana_> wesnoth GUI doesn't allow it at least, going to check on command line then 20180414 15:56:46<+discordbot> yeah, I got it 20180414 15:56:56<+discordbot> oh, but the bug is observe... 20180414 15:57:07<+discordbot> .... 20180414 15:57:12<+discordbot> do you want to observe or join the game 20180414 15:57:17<+discordbot> you should be able to observe it 20180414 15:57:17< Ravana_> observe 20180414 15:57:31< Ravana_> for joining it is irrelevant if game is private or not 20180414 16:00:30< irker891> wesnoth: Celtic Minstrel wesnoth:1.14 76cf5baf5dd5 / / (5 files in 4 dirs): Editor: Refresh named locations list when map context changes (fixes #1023) https://github.com/wesnoth/wesnoth/commit/76cf5baf5dd5ba9f5ffc87c22efee29e8b012710 20180414 16:01:21< Ravana_> I can join game as observer from command line 20180414 16:01:39< celticminstrel> There are conflicts for pushing that to master, should I not bother? 20180414 16:01:51<+discordbot> probably should bother 20180414 16:01:59< celticminstrel> Hm, alright. 20180414 16:02:03<+discordbot> @Ravana well, then I have no idea 20180414 16:02:27< Ravana_> It looks like GUI problem 20180414 16:02:42<+discordbot> i mean 20180414 16:02:44< Ravana_> I verified that I can observe from command line with mod account, and can't with nonmod 20180414 16:02:46<+discordbot> cpp bool game_info::can_observe() const { return observers || preferences::is_authenticated(); } 20180414 16:02:47<+discordbot> 😐 20180414 16:03:40<+discordbot> and both buttons are set active to that function's value 20180414 16:03:43<+discordbot> Then the variable has a wrng value, or something other than can_observer() is used to decide if observing is allowed. 20180414 16:03:57<+discordbot> Debugging would give the answer immediately. 20180414 16:04:33<+discordbot> I can't debug this. I'm not an MP mod. 20180414 16:05:23< Ravana_> you can use lan_server password in local wesnothd 20180414 16:05:25< irker891> wesnoth: Celtic Minstrel wesnoth:master 8e4de9db67f5 / / (5 files in 4 dirs): Editor: Refresh named locations list when map context changes (fixes #1023) https://github.com/wesnoth/wesnoth/commit/8e4de9db67f533e98cd11235567b95a03cb9889a 20180414 16:06:38<+discordbot> @Ravana when do you authenticate, btw? 20180414 16:06:41<+discordbot> is it on login? 20180414 16:06:55<+discordbot> ie, it has to do with the forum db and mp mods group? 20180414 16:06:59<+discordbot> or do you have to do something else 20180414 16:07:00< Ravana_> it happens on login based on forum name 20180414 16:07:17< Ravana_> I don't think it uses mp mods group, last I heard it was separate list 20180414 16:07:30< Ravana_> https://github.com/wesnoth/wesnoth/issues/2327#issuecomment-354045548 20180414 16:08:00<+discordbot> blah 20180414 16:11:30<+discordbot> and auth does work? 20180414 16:11:51< Ravana_> ? 20180414 16:13:39< Ravana_> funny how mods can't be kicked or banned, but can be muted https://i.imgur.com/f8oahBh.jpg 20180414 16:13:51-!- gallaecio [~quassel@188.79.96.255] has quit [Remote host closed the connection] 20180414 16:15:04-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: So long and thanks for all the fish.] 20180414 16:16:22-!- gallaecio [~quassel@188.79.96.255] has joined #wesnoth-dev 20180414 16:17:23<+discordbot> I mean you are actually authenticated and can perform admin duties, yes? 20180414 16:17:31< Ravana_> yes 20180414 16:17:35<+discordbot> Just checking it’s not a problem with that ... 20180414 16:18:47< Ravana_> shows I can use sl and can't observe https://i.imgur.com/iti5jOC.png 20180414 16:19:56< gfgtdf> is that form current 1.14 mop server ? 20180414 16:20:03< Ravana_> yes 20180414 16:20:15< gfgtdf> seems like it has 3 games whcih 0 player it it each :/ 20180414 16:20:38< gfgtdf> (0 players in selected /other game) 20180414 16:20:43< Ravana_> no, those colored names are in games 20180414 16:20:58< gfgtdf> then why do they show under "lobby" ? 20180414 16:21:19< Ravana_> it doesn't look nice yes, but it is good enough for now 20180414 16:21:44< gfgtdf> Ravana_: did you do seomthing? i was summein theis the official 1.13.13 tag 20180414 16:21:48<+discordbot> There's also a bit of a lag between a game ending and the lobby list being updated. 20180414 16:21:53< gfgtdf> assuming* 20180414 16:21:53< Ravana_> its workaround for https://github.com/wesnoth/wesnoth/issues/2538 #1199 and #1200 20180414 16:22:13<+discordbot> ie: I've ended a game, still see it in the lobby, then refresh it manually after a few seconds and it's gone. 20180414 16:22:27< Ravana_> default is to use groupings, but it is annoying to click those, so I disabled those 20180414 16:23:34< gfgtdf> in the c++ source ? 20180414 16:23:43< Ravana_> no, preferences 20180414 16:24:02< Ravana_> advanced>group players in lobby 20180414 16:24:10< gfgtdf> hmm ok 20180414 16:24:52< gfgtdf> didn't know of that option 20180414 16:28:14< irker891> wesnoth: ln-zookeeper wesnoth:master 33e924dc35fd / changelog.md: Updated changelog https://github.com/wesnoth/wesnoth/commit/33e924dc35fdbc6c32696d08d14beef9cd80893b 20180414 16:31:08-!- vultraz [uid24821@wesnoth/developer/vultraz] has joined #wesnoth-dev 20180414 16:36:05< gfgtdf> Ravana_: do you alos get OOS & freeze iof you join that one game that's currently the 1.14 server ? 20180414 16:36:58< gfgtdf> hmm ok tried it again and didn't get the freeze this tim, onyl the oos 20180414 16:37:05< Ravana_> I get OOS, but no further problems 20180414 16:37:10< gfgtdf> no idea what i did different 20180414 16:37:41< gfgtdf> hmm ok thx 20180414 16:38:10-!- vultraz [uid24821@wesnoth/developer/vultraz] has left #wesnoth-dev [] 20180414 16:58:43-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180414 17:14:32-!- travis-ci [~travis-ci@ec2-54-224-78-189.compute-1.amazonaws.com] has joined #wesnoth-dev 20180414 17:14:33< travis-ci> wesnoth/wesnoth#17620 (fix_1023 - 47e4235 : Celtic Minstrel): The build passed. 20180414 17:14:33< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/366517618 20180414 17:14:33-!- travis-ci [~travis-ci@ec2-54-224-78-189.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180414 17:25:02-!- travis-ci [~travis-ci@ec2-54-224-78-189.compute-1.amazonaws.com] has joined #wesnoth-dev 20180414 17:25:03< travis-ci> wesnoth/wesnoth#17624 (1.14 - 76cf5ba : Celtic Minstrel): The build passed. 20180414 17:25:03< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/366530816 20180414 17:25:03-!- travis-ci [~travis-ci@ec2-54-224-78-189.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180414 17:33:23< Ravana_> [unsynced] was not in tags template, added 20180414 17:37:53< gfgtdf> thx 20180414 17:41:42-!- travis-ci [~travis-ci@ec2-54-166-67-148.compute-1.amazonaws.com] has joined #wesnoth-dev 20180414 17:41:44< travis-ci> wesnoth/wesnoth#17625 (master - 8e4de9d : Celtic Minstrel): The build passed. 20180414 17:41:44< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/366532019 20180414 17:41:44-!- travis-ci [~travis-ci@ec2-54-166-67-148.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180414 17:53:16< gfgtdf> i thought we already had an issue for the loadgaem dilaog beeing slow (on windows)? I cannot find one 20180414 18:04:52< irker891> wesnoth/wesnoth:master pentarctagon f9a19707f2 Adds a c++17 build using the pre-release AppVeyor: All builds passed 20180414 18:11:24-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev 20180414 18:38:27-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20180414 19:16:04< Ravana_> has network protocol about whispers changed recently? I got https://i.imgur.com/9j7GY6m.png when testing my bot - response is in another tab called <> 20180414 19:18:12< irker891> wesnoth: Severin Glöckner wesnoth:1.14 13767fe9eecf / data/campaigns/Under_the_Burning_Suns/units/quenoth/ (9 files): utbs: change traits for higher unit types too, https://github.com/wesnoth/wesnoth/commit/13767fe9eecf63df54552f6949fe5a0132397e63 20180414 19:18:14< irker891> wesnoth: Severin Glöckner wesnoth:1.14 5c057a1e09b8 / data/campaigns/Under_the_Burning_Suns/ (units/units.cfg utils/kaleh-abilities.cfg): utbs: remove movetypes and abilities only used by old desert elves https://github.com/wesnoth/wesnoth/commit/5c057a1e09b8635daefc97de599d1e6523c2f6ab 20180414 19:18:16< irker891> wesnoth: Severin Glöckner wesnoth:1.14 10c93d24fc3b / data/campaigns/Under_the_Burning_Suns/units/ (6 files in 2 dirs): utbs: replace true by yes https://github.com/wesnoth/wesnoth/commit/10c93d24fc3b2f1cd8ab3a396f57ed033d49a1c7 20180414 19:25:03< irker891> wesnoth: Severin Glöckner wesnoth:master ea656a8cc795 / data/campaigns/Under_the_Burning_Suns/ (units/units.cfg utils/kaleh-abilities.cfg): remove movetypes and abilities only used by old desert elves https://github.com/wesnoth/wesnoth/commit/ea656a8cc795f41fcce41de2f8c5eb805d93cf4b 20180414 19:25:05< irker891> wesnoth: Severin Glöckner wesnoth:master 2e8f6c2a7993 / data/campaigns/Under_the_Burning_Suns/units/quenoth/ (9 files): utbs: change traits for higher unit types too, https://github.com/wesnoth/wesnoth/commit/2e8f6c2a799331c1a1a98a9ee478d40e51e34268 20180414 19:25:07< irker891> wesnoth: Severin Glöckner wesnoth:master 5e1f6af8dd94 / data/campaigns/Under_the_Burning_Suns/units/ (6 files in 2 dirs): utbs: replace true by yes https://github.com/wesnoth/wesnoth/commit/5e1f6af8dd940e354d19b63963c2e1b851e9ff35 20180414 19:36:32< irker891> wesnoth/wesnoth:master newfrenchy83 606981bd22 Update wesnoth.cbp (#2890) AppVeyor: All builds passed 20180414 19:45:43< Ravana_> seems only slightly 20180414 19:57:27-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180414 19:57:34-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180414 19:57:53< irker891> wesnoth/wesnoth:1.14 Severin Glöckner 10c93d24fc utbs: replace true by yes AppVeyor: vs2017/Release Failed 20180414 19:57:54< irker891> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-1.14-2392 20180414 20:09:01< zookeeper> @sevu, https://git.io/vpe0w is just a removal... 20180414 20:09:10-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20180414 20:11:55<+discordbot> should be interited from the above. Though I'm not sure if that works for unit.w.o too zookeeper 20180414 20:12:29< zookeeper> oh right, it has a base unit 20180414 20:12:49< zookeeper> i'd imagine u.w.o isn't that smart, indeed, but i'm not sure 20180414 20:13:47-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20180414 20:19:38-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20180414 20:26:40<+discordbot> I guess we won't have to possibility to try it out in the next time, will revert it 20180414 20:27:44<+discordbot> I'm not sure if I will be here at the tagging time, can the PR above be merged before, in case there are no objetions? 20180414 20:28:24<+discordbot> This kind of change needs to be in RC 3 and won't be allowed in 1.14.0 and later. 20180414 20:28:51<+discordbot> So hopefully that's all that is left. 20180414 20:44:29-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20180414 20:53:30< zookeeper> @sevu, that PR changes the image references, but doesn't rename the images? 20180414 20:54:11< zookeeper> i don't know why you removed the compatibility unit type, either 20180414 20:59:21-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20180414 20:59:45<+discordbot> the image is moved too (small entry at the top)- Moving the image breaks compatibilty already partly, so the step to removing that as well isn't far. 20180414 21:00:14<+discordbot> Actually I must just go now. 20180414 21:00:43<+discordbot> The important part in the PR is the change in scenario 9, so that new saves use the new unit id 20180414 21:10:36< celticminstrel> I wonder if there are any mainline campaigns where it could possibly make sense to include a dunefolk or two. 20180414 21:11:05< irker891> wesnoth/wesnoth:master Severin Glöckner 5e1f6af8dd utbs: replace true by yes AppVeyor: vs2017/Release Failed 20180414 21:11:06< irker891> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-master-2393 20180414 21:12:31-!- gfgtdf [~chatzilla@x4e363e1a.dyn.telefonica.de] has quit [Read error: Connection reset by peer] 20180414 21:15:20< zookeeper> oh duh, yeah, the image rename is there and i just missed it. 20180414 21:16:50< zookeeper> anyway, the file/id renamings are fine, but breaking old saves for those doesn't really make any sense. 20180414 21:17:17< celticminstrel> We can avoid breaking saves by just adding a dummy [unit_type] for it, right? 20180414 21:17:38< celticminstrel> Similiar to what was done for the Dunefolk; there's even a core macro specifically for that purpose IIRC. 20180414 21:33:19< zookeeper> i don't know why you removed the compatibility unit type, either 20180414 21:33:32< celticminstrel> What are you talking about? 20180414 21:34:31< zookeeper> the same PR as you 20180414 21:36:39< zookeeper> and no, i don't see how you could insert any dunefolk into any of the campaigns. except as a meaningless background prop, as is IIRC the case in SotA. 20180414 21:39:50< irker891> wesnoth: Celtic Minstrel wesnoth:intl_fixes ecd2aa906f89 / / (5 files in 5 dirs): Fix #2894 https://github.com/wesnoth/wesnoth/commit/ecd2aa906f89ffdb6ad1121babefa81db5440382 20180414 22:01:39<+discordbot> The big irony of assigning them the southern area is that the only major desert featured in a mainline campaign that isn't UtBS is actually in the Far North. 20180414 22:03:51-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Ping timeout: 256 seconds] 20180414 22:03:52-!- celmin [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev 20180414 22:07:10-!- Bhoren [~Bhoren_wh@2a01:e0a:c:2150:154:8a44:fdbd:8f2] has quit [Quit: Leaving] 20180414 22:08:55< zookeeper> ha, true. 20180414 22:21:01-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20180414 22:21:28 * celmin kinda wonders what they apparently missed... >_> 20180414 22:21:52-!- celmin is now known as celticminstrel 20180414 22:22:01-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180414 22:23:17-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Client Quit] 20180414 22:23:55-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180414 22:26:13< irker891> wesnoth/wesnoth:1.14 Severin Glöckner 4a837b61c4 finish renaming of the Horseman to Pathf AppVeyor: vs2015/Release Failed 20180414 22:26:14< irker891> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-1.14-2686 20180414 22:26:25-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20180414 22:27:13-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180414 22:27:16<+discordbot> is there any official map of the southern area, taking into account the dunefolk? 20180414 22:37:26-!- octalot [~steve@178.115.128.21.wireless.dyn.drei.com] has joined #wesnoth-dev 20180414 22:37:51-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20180414 22:40:06< irker891> wesnoth/wesnoth:1.14 Celtic Minstrel 76cf5baf5d Editor: Refresh named locations list whe AppVeyor: All builds passed 20180414 22:40:22-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180414 22:49:42< celticminstrel> There is the map from Kwandulin's Oath of Allegiance (linked somewhere in the dunefolk forums thread). Not sure if that'll end up being official, but it was used as a reference point for the race description, so it's likely. 20180414 22:50:09-!- octalot [~steve@178.115.128.21.wireless.dyn.drei.com] has quit [Ping timeout: 264 seconds] 20180414 22:50:28-!- octalot [~steve@91.141.2.173.wireless.dyn.drei.com] has joined #wesnoth-dev 20180414 22:52:57-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 240 seconds] 20180414 23:10:42< zookeeper> i'm inclined to call at least the geography official. 20180414 23:15:51-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20180414 23:18:09-!- gallaecio [~quassel@188.79.96.255] has quit [Remote host closed the connection] 20180414 23:23:09-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180414 23:23:15-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180414 23:28:37< celticminstrel> I just realized that [set_variable]round=trunc is technically redundant, similar to how [set_variable]to_variable= is redundant. 20180414 23:29:03< celticminstrel> [set_variable]name,to_variable=a,b is equivalent to [set_variable]name,value=a,$b 20180414 23:29:27< celticminstrel> And [set_variable]name,round=a,trunc is equivalent to [set_variable]name,ipart=a,$a 20180414 23:30:47 * celticminstrel is kinda hoping someone else steps up for issue 2653; I've already covered several of the items there, but there are so many... 20180414 23:32:37< celticminstrel> Aw, it doesn't count task items from comments into its tally of completed items... 20180414 23:43:44-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20180414 23:46:28< irker891> wesnoth/wesnoth:1.14 Celtic Minstrel 1b4dd2ebe6 Fix #2894 AppVeyor: vs2017/Release Failed 20180414 23:46:29< irker891> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-1.14-2395 20180414 23:58:42< celticminstrel> Hmm, if I add experience with [modify_unit], would it automatically advance if applicable? --- Log closed Sun Apr 15 00:00:43 2018