--- Log opened Mon Apr 16 00:00:44 2018 20180416 00:03:30-!- gfg [~androirc@tmo-106-92.customers.d1-online.com] has quit [Read error: Connection reset by peer] 20180416 00:09:03-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20180416 00:11:52-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20180416 00:27:33< mattsc> celticminstrel: What would the AI do with that information? 20180416 00:28:11< celticminstrel> Doesn't it consider unit stats when deciding what to recruit? If it knew it might get a variation, it could consider the stats of the variations as well. 20180416 00:30:18< celticminstrel> This leader sure is hard to kill. No matter what attack you use against him, he'll drain you. >_> 20180416 00:30:24< mattsc> Hmm… I forgot what exactly the default AI does (other than scouts). I don’t think that there’s too much detailed evaluation involved, so I am not sure if it would make a perceptible difference. 20180416 00:30:34< mattsc> And I really mean that I don’t know ... 20180416 00:33:00< mattsc> The recruiting algorithm in the ExpAI does a lot more of this, but even there I’m not sure how much of a difference it would make. 20180416 00:46:23-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180416 00:46:30-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180416 01:02:45< celticminstrel> Hmm... the swarm MAI is just about movement and prevents attacks AFAIK, otherwise I could use it for these mosquitos... 20180416 01:03:55< mattsc> That’s correct. But you could probably lower its ca_score. Or you could put a Simple Attack MAI on top of it. 20180416 01:07:47-!- irker523 [~irker@uruz.ai0867.net] has joined #wesnoth-dev 20180416 01:07:47< irker523> wesnoth/wesnoth:master Celtic Minstrel ceea173eb4 Remove redundant unused column in stats AppVeyor: All builds passed 20180416 01:46:43-!- ELBeavers [~beelers@208.99.109.233] has left #wesnoth-dev ["Textual IRC Client: www.textualapp.com"] 20180416 01:55:49<+discordbot> @Ravana no, no time 20180416 01:56:09< celticminstrel> Assassin MAI doesn't seem to deal well with enemies encountered along the way. It both ignores them and doesn't move to villages for healing. 20180416 01:56:28< celticminstrel> Like, if there happens to be a village along its route and it needs healing, surely it should take the chance? 20180416 01:56:52<+discordbot> celmin: I do not support disable_upload 20180416 01:56:58<+discordbot> use .ign or just be careful 20180416 01:58:28< celticminstrel> @Vultraz: That doesn't even make any sense. 20180416 01:58:44< celticminstrel> That is to say, it's 100% impossible to do it with .ign. 20180416 01:58:58< celticminstrel> So I just lost because a mosquito killed my leader. >_> 20180416 01:59:52<+discordbot> heh 20180416 02:00:16<+discordbot> then just be careful 20180416 02:05:24<+discordbot> celmin: what happened on the forums? 20180416 02:05:33< celticminstrel> ??? 20180416 02:05:37<+discordbot> in the mainline sprite thread 20180416 02:05:51<+discordbot> looks like doofus posted some utbs sprites yesterday and was told "no u"? 20180416 02:06:18< celticminstrel> I don't really know. 20180416 02:06:32<+discordbot> (actually, not "no u", that's a meme and actually not a really fitting one) 20180416 02:06:40<+discordbot> (more like he was told kwandulin's sprites were fine) 20180416 02:06:45< celticminstrel> Ask zookeeper and doofus? 20180416 02:06:56< celticminstrel> I like both sprites FTR. 20180416 02:07:19<+discordbot> I'm just curious what they looked like 20180416 02:07:29<+discordbot> he deleted the image in the face of zookeeper's criticism 20180416 02:07:39<+discordbot> (I'm assuming there must have been an image) 20180416 02:07:40< celticminstrel> ... 20180416 02:08:01< celticminstrel> There was an image on the previous page. I have no idea why the heck doofus thought it was a good idea to remove them. 20180416 02:08:17<+discordbot> Presumably because he was told not to continue 20180416 02:08:19< celticminstrel> IMO I'd ask him to put them back, just for continuity. 20180416 03:19:36-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180416 03:19:47-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180416 03:19:51-!- vn971 [~vasya@94.158.103.15] has quit [Ping timeout: 240 seconds] 20180416 03:28:50<+discordbot> announcement draft is up 20180416 03:29:45<+discordbot> forums seem quite slow right now.. 20180416 03:31:38< irker523> wesnoth/wesnoth:1.14 Celtic Minstrel 6f47abd47f Remove redundant unused column in stats AppVeyor: All builds passed 20180416 03:35:04<+discordbot> i can't get to anything by going to ttps://r.wesnoth.org/t47950 ? 20180416 03:39:14<+discordbot> Looking at players_changelog.md for 1.13.14, I think developers have a too high threshold for adding items to it. 20180416 03:39:15<+discordbot> https://github.com/wesnoth/wesnoth/blob/1.13.14/players_changelog.md 20180416 03:39:30<+discordbot> It's as if there were pretty much no interesting changes at all. 20180416 03:44:56-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180416 03:45:02-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180416 03:53:59< celticminstrel> @Safreti – Drafts are put up in the mods forum, so not everyone has access. 20180416 03:54:36<+discordbot> Topic #47950 isn't a draft, it's the RC 2 announcement. 20180416 03:54:44< celticminstrel> Oh, okay. 20180416 03:54:56<+discordbot> yeah, i copy pasted the url wrong 20180416 03:55:05<+discordbot> I dled it, but mp lobby is still dead :./ 20180416 03:57:57< celticminstrel> Which thing in resources:: was the display_context again...? 20180416 03:59:11< celticminstrel> Well, if it's not the gameboard, I guess Travis will just complain. 20180416 04:00:59< irker523> wesnoth: Celtic Minstrel wesnoth:master ecc8785edbbc / changelog.md data/lua/wml-tags.lua src/game_events/action_wml.cpp: Support location_id in [recall] and [unstore_unit] https://github.com/wesnoth/wesnoth/commit/ecc8785edbbcaa814502ccee6b2946da4242f53e 20180416 04:01:06<+discordbot> It's indeed the gameboard. 20180416 04:01:28< celticminstrel> I hope that's the right way to access the bimap, though. 20180416 04:11:19<+discordbot> @jyrkive I am seriously pondering retiring the p_c. 20180416 04:11:33< celticminstrel> I think we may need it. 20180416 04:11:57-!- atarocch [~atarocch@93.56.164.28] has quit [Ping timeout: 240 seconds] 20180416 04:12:05< celticminstrel> In theory this MVC setup allows code sharing between the editor and the game, for example. 20180416 04:12:42< celticminstrel> Like I keep saying... it's one thing to tear out MVC when it's clearly overengineering the problem, like in the lua console; it's another to tear it out when it's actually a suitable solution to the problem. 20180416 04:13:07< celticminstrel> I want to make more mega-improvements to the inspector... 20180416 04:13:35< celticminstrel> For example the ability to delve into container variables in the left panel. 20180416 04:14:03<+discordbot> MVC has its place, yes 20180416 04:14:07<+discordbot> GUI2 dialogs is not that place. 20180416 04:14:59< celticminstrel> If "retiring the player_controller" means building up a new controller to take its place, that might also be acceptable. 20180416 04:15:28<+discordbot> what are you referring to? 20180416 04:15:34< celticminstrel> ??? 20180416 04:15:38<+discordbot> ??? 20180416 04:15:41< irker523> wesnoth/wesnoth:master Celtic Minstrel ecc8785edb Support location_id in [recall] and [uns AppVeyor: vs2015/Release Failed 20180416 04:15:42< irker523> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-2720 20180416 04:15:51< celticminstrel> Did I misunderstand what you said? 20180416 04:16:03-!- travis-ci [~travis-ci@ec2-23-20-242-232.compute-1.amazonaws.com] has joined #wesnoth-dev 20180416 04:16:04< travis-ci> wesnoth/wesnoth#17655 (master - ecc8785 : Celtic Minstrel): The build was broken. 20180416 04:16:04< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/366982911 20180416 04:16:04-!- travis-ci [~travis-ci@ec2-23-20-242-232.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180416 04:16:10< celticminstrel> \o/ 20180416 04:16:19<+discordbot> D: 20180416 04:16:31< celticminstrel> Didn't p_c mean player_controller? 20180416 04:16:58<+discordbot> there is no player_controller class... 20180416 04:16:59< celticminstrel> I can't even view the build log so I have no idea how to fix that. 20180416 04:17:02<+discordbot> there is play_controller 20180416 04:17:07< celticminstrel> Close enough 20180416 04:19:00<+discordbot> He was referring to players_changelog.md. 20180416 04:19:50<+discordbot> ............... oh, geez, no wonder we were both confused 😬 20180416 04:20:30< celticminstrel> ...ah XD 20180416 04:32:06<+discordbot> And this is why forced or unnecessary abbreviations are a bad thing. 20180416 04:44:31< matthiaskrgr> k 20180416 04:45:53< celticminstrel> Blargh. Okay, I can see how to fix the build error, at least. 20180416 04:49:32< irker523> wesnoth: Celtic Minstrel wesnoth:master ea6578a87a48 / src/game_events/action_wml.cpp: fixup! Support location_id in [recall] and [unstore_unit] https://github.com/wesnoth/wesnoth/commit/ea6578a87a4806500ec482cd179c565019c548fb 20180416 04:54:43< matthiaskrgr> still failing here 20180416 04:54:55< celticminstrel> Aw... 20180416 04:55:02< matthiaskrgr> https://pastebin.com/i2MsnZJW 20180416 04:55:22< celticminstrel> Ah, need a const. 20180416 04:55:58< irker523> wesnoth: Celtic Minstrel wesnoth:master 7821f470c2c7 / src/game_events/action_wml.cpp: fixup! Support location_id in [recall] and [unstore_unit] https://github.com/wesnoth/wesnoth/commit/7821f470c2c70eb0865f27b3baece9d0ce91afbc 20180416 05:00:23< matthiaskrgr> build fixed \o/ 20180416 05:00:48< celticminstrel> \o/ 20180416 05:01:18-!- travis-ci [~travis-ci@ec2-54-221-131-22.compute-1.amazonaws.com] has joined #wesnoth-dev 20180416 05:01:19< travis-ci> wesnoth/wesnoth#17656 (master - ea6578a : Celtic Minstrel): The build is still failing. 20180416 05:01:19< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/366990511 20180416 05:01:19-!- travis-ci [~travis-ci@ec2-54-221-131-22.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180416 05:14:18<+discordbot> don't think that one's really an issue 20180416 05:16:54<+discordbot> arguably the menu scroll bar is not a bug though sm said it is, anyway imo could be better to classify the scroll bar itself as a regression 20180416 05:17:15<+discordbot> uh 20180416 05:17:16<+discordbot> what? 20180416 05:17:26<+discordbot> it's a regression to have a scrollbar in the right click menu? 20180416 05:18:11<+discordbot> well, i mean, why is it needed at all actually, wesnoth context menu is rather concise 20180416 05:18:23<+discordbot> can fit easily on the screen 20180416 05:18:43<+discordbot> Because it is not always the case. 20180416 05:18:55<+discordbot> In 1.12 there was a maximum of... 7, I think, custom WML menu items 20180416 05:18:58<+discordbot> also in lets say 80% of cases when right clicking the scroll bar will nto appear 20180416 05:19:02<+discordbot> iceiceice implemented a paging system early in 1.13 20180416 05:19:10<+discordbot> but it was later made scrollable 20180416 05:19:26<+discordbot> well, for me it always fit 20180416 05:19:32-!- travis-ci [~travis-ci@ec2-23-20-242-232.compute-1.amazonaws.com] has joined #wesnoth-dev 20180416 05:19:33< travis-ci> wesnoth/wesnoth#17657 (master - 7821f47 : Celtic Minstrel): The build was fixed. 20180416 05:19:33< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/366991554 20180416 05:19:33-!- travis-ci [~travis-ci@ec2-23-20-242-232.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180416 05:19:34<+discordbot> never seen it not fit 20180416 05:19:40<+discordbot> now, this scrollbar appearing is indeed an issue and probably stems from the issue of the window border as shadowm said 20180416 05:19:50<+discordbot> It would be better to just move the context menu up a bit at first, and only resort to the scrollbar if it still doesn't fit. 20180416 05:20:29<+discordbot> yeah, i have never seen anyone add more than... 3, maybe 4 custom context menu options? 20180416 05:20:35<+discordbot> and it still fit easily 20180416 05:20:50<+discordbot> dont even remember it being significantly longer 20180416 05:21:32<+discordbot> i can estimate 20180416 05:21:41<+discordbot> that 1 menu option is maybe 1/50th of the screen width 20180416 05:21:50<+discordbot> in 1.12 20180416 05:22:29<+discordbot> ok prob less but that is the idea 20180416 05:25:14<+discordbot> I almost forgot to report this 20180416 05:25:23<+discordbot> [heal_unit] displays the amount healed as a decimal 20180416 05:25:51<+discordbot> I believe a dev told me that it would probably be better to display it as an integer 20180416 05:26:38-!- nurupo [~nurupo.ga@unaffiliated/nurupo] has quit [Quit: nurupo] 20180416 05:27:14< irker523> wesnoth: Celtic Minstrel wesnoth:master 0294bd81b21b / data/lua/wml/heal_unit.lua: Display amount healed as an integer in [heal_unit] https://github.com/wesnoth/wesnoth/commit/0294bd81b21be27e09f10d812fafa6bae7090002 20180416 05:27:27<+discordbot> @Yumi ^ 20180416 05:27:30< celticminstrel> Someone please try that on 1.14 and make sure it works. 20180416 05:27:40< celticminstrel> And if so cherry-pick it. 20180416 05:27:57<+discordbot> celticminstrel: might make more sense to instead use math.floor() in line 35. 20180416 05:28:15<+discordbot> *34 20180416 05:28:27<+discordbot> I should be able to check when 1.13.14 comes out 20180416 05:28:34< celticminstrel> Maybe. I guess you can change it if you'd prefer that. 20180416 05:29:15<+discordbot> @Yumi The commit is only in master. It's not coming to 1.13.14 unless someone copies the commit to the 1.4 development branch. 20180416 05:29:18<+discordbot> *1.14 20180416 05:29:26<+discordbot> hrrrr 20180416 05:29:28-!- nurupo [~nurupo.ga@unaffiliated/nurupo] has joined #wesnoth-dev 20180416 05:29:54< celticminstrel> But you can test it on 1.13.14 by editing the core files with the same change, if you want. 20180416 05:30:02<+discordbot> well doesn't matter to me, I actually kind of liked the decimals :l 20180416 05:30:07<+discordbot> celcticminstrel: I'll go to work soon. I think I'll change it to math.floor() and test the fix in the evening. 20180416 05:30:19-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The computer falls into a deep sleep, to awake again some other day!] 20180416 05:55:15< irker523> wesnoth/wesnoth:1.14 Paŭlo Ebermann 20f289ccbc fix typo en german translation AppVeyor: All builds passed 20180416 06:14:34-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20180416 06:14:59-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20180416 06:15:21-!- noy [~Noy@wesnoth/developer/noy] has quit [Client Quit] 20180416 06:15:22-!- gallaecio [~quassel@38.red-83-46-126.dynamicip.rima-tde.net] has joined #wesnoth-dev 20180416 06:15:53-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20180416 06:16:00-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180416 06:16:08-!- noy [~Noy@wesnoth/developer/noy] has quit [Client Quit] 20180416 06:16:47-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20180416 06:16:55-!- noy [~Noy@wesnoth/developer/noy] has quit [Client Quit] 20180416 06:17:31-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20180416 06:17:43-!- noy [~Noy@wesnoth/developer/noy] has quit [Client Quit] 20180416 06:22:36-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20180416 06:46:17-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20180416 06:55:13-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20180416 07:44:12< irker523> wesnoth: Iris Morelle wesmere:master 123a8b5eada9 / static/docroot/addons/index.xml: static: Retire the 1.13.x add-ons server https://github.com/wesnoth/wesmere/commit/123a8b5eada925f159b615fdffa87b8b9fa5d98a 20180416 07:45:58< irker523> wesnoth: Iris Morelle wesmere:master 1d93c98dfefb / static/docroot/addons/index.xml: static: Retire the 1.13.x add-ons server https://github.com/wesnoth/wesmere/commit/1d93c98dfefbee66b872470ada4575c0a433930b 20180416 07:50:39<+discordbot> Eh, the UtBS changes didn't make it to the RC 3 changelog. 20180416 07:50:58<+discordbot> I believe there were more besides breaking backwards compatibility. 20180416 07:51:47< irker523> wesnoth: ln-zookeeper wesnoth:1.14 a565e9259faa / data/campaigns/Under_the_Burning_Suns/_main.cfg: UtBS: Re-added compatibility code to load old saves using the new elves https://github.com/wesnoth/wesnoth/commit/a565e9259faa84d8d96b5aed0ab40f299e714f7c 20180416 07:54:28<+discordbot> Okay? 20180416 07:54:41<+discordbot> What is the point of adding that after RC 3 has been tagged? 20180416 07:55:14<+discordbot> Considering that that is going to be the latest release until May 1st. 20180416 07:55:45< zookeeper> for the rare (or maybe not?) case of someone skipping 1.13.14 and loading a 1.13.13 save with 1.13.15 or whatever it's going to be called. 20180416 07:56:10<+discordbot> The next release will be 1.14.0 unless you can come up with a really good reason for a fourth RC. 20180416 07:56:42<+discordbot> Which is really another way to phrase what I just said above. 20180416 08:04:52< zookeeper> i have no idea how i forgot to push that on the night of the tagging, considering it had been discussed like a day or two earlier. 20180416 08:05:21<+discordbot> It's rather pointless now. 20180416 08:06:10<+discordbot> It doesn't hurt, but the people who are testing these releases will either have already started over by the time the next release (which is again 1.14.0 gold) comes along, or they will need to apply the patch by hand. 20180416 08:06:33< zookeeper> i wholeheartedly agree 20180416 08:08:55<+discordbot> @Vultraz Updated the draft with more stuff and linkified issue references. 20180416 08:09:11<+discordbot> zookeeper might want to check the wording I used for the UtBS changes. 20180416 08:12:14< zookeeper> looks accurate 20180416 08:15:59< zookeeper> (technically perhaps it would better fit under a "new issues" heading, but maybe it's better found under the campaigns heading) 20180416 08:16:46<+discordbot> Hm. 20180416 08:17:26< zookeeper> it's not good PR to have a "newly introduced bugs" category in RC phase, though :J 20180416 08:18:52<+discordbot> It doesn't really qualify as a proper bug. The only bug here is that it wasn't done much sooner. 20180416 08:24:43-!- grzywacz [~karol@wesnoth/developer/grzywacz] has joined #wesnoth-dev 20180416 08:26:30-!- shadowm changed the topic of #wesnoth-dev to: 1.14.0 ANNOUNCEMENT ON MAY 1ST, tag on April 25th (times TBD) | String and feature freeze on 1.14 branch | Wesnoth Developers Channel | >>> Want to help? Go here: https://r.wesnoth.org/t42911 (and thanks!) <<< | Discord Server: https://discord.gg/battleforwesnoth | Logs: http://irclogs.wesnoth.org | Bug tracker: https://bugs.wesnoth.org 20180416 08:34:28< grzywacz> Is it by design that the right-click context menu on the map cannot be closed by right-clicking again? 20180416 08:35:18<+discordbot> Right-clicking any empty hex closes it. 20180416 08:35:19< grzywacz> That's what I've always been doing, now I keep getting stuck with it open and trying to figure out my way out. :) 20180416 08:35:28< grzywacz> What's an empty hex? 20180416 08:35:43<+discordbot> Any hex without a unit. 20180416 08:35:44< grzywacz> Can't have it closed with a right click no matter where I click. 20180416 08:36:03< grzywacz> Only left-click seems to work. 20180416 08:36:17<+discordbot> Okay... That's not supposed to happen. 20180416 08:36:46< grzywacz> Linux/X11. 20180416 08:36:52<+discordbot> I wonder if it's fallout from https://github.com/wesnoth/wesnoth/pull/2872 20180416 08:37:28< grzywacz> Probably not, I noticed it earlier than 5 days ago. 20180416 08:38:21< Ravana_> it was just reported too https://github.com/wesnoth/wesnoth/issues/2905 20180416 08:38:33< grzywacz> ha, nice timing 20180416 08:38:59<+discordbot> #2905 says that right-clicking an empty hex does close the context menu. 20180416 08:40:12< Ravana_> no, "does not happen when clicking on empty hexes." 20180416 08:40:15< grzywacz> No, #2905 is about opening the menu :D 20180416 08:41:29<+discordbot> So the menu sticks around for you, instead of closing and reopening? 20180416 08:42:15< grzywacz> Correct. 20180416 08:43:49< grzywacz> Another bad behavior I notice is that there's substantial lag when I close the context menu with a left click. In the order of 0.5s . 20180416 08:44:26<+discordbot> I think closing the context menu triggers a full redraw and is slow because of that. 20180416 08:48:41-!- grzywacz [~karol@wesnoth/developer/grzywacz] has quit [Quit: Lost terminal] 20180416 08:50:18-!- grzywacz [~karol@wesnoth/developer/grzywacz] has joined #wesnoth-dev 20180416 08:52:05< grzywacz> This would have changed since 1.12, right? The old stable seems snappier. 20180416 08:53:17<+discordbot> Yes, 1.13.x replaced the old menus with GUI2. 20180416 08:53:53<+discordbot> Are you using an unoptimized build out of curiosity? 20180416 08:54:18<+discordbot> Otherwise, what are your specs? 20180416 08:57:03<+discordbot> For the record, GUI2 windows are capable of simply restoring the previous screen area when they close: https://github.com/wesnoth/wesnoth/blob/1.14/src/gui/widgets/window.cpp#L597-L601 20180416 08:57:04< grzywacz> Looks like I'm building with -O3. cmake is a little bit of a mystery to me 20180416 08:57:25< grzywacz> model name: AMD Phenom(tm) II X3 710 Processor, 3x2.6GHz 20180416 08:57:25<+discordbot> I think that capability is just not being used with context menus for some reason. 20180416 09:02:07<+discordbot> It might be worth finding out if there's a specific reason behind that. 20180416 09:02:53<+discordbot> I don't think the issue is significang enough to justify a patch before 1.14.1 though. 20180416 09:03:36<+discordbot> Then again others probably know better about the contexts where the menu code can be invoked and whether changing that could be problematic. 20180416 09:06:35< grzywacz> Certainly not a change that should be rushed. 20180416 09:07:07< grzywacz> OTOH the right-click thing is gamebreaking for me :) 20180416 09:07:34<+discordbot> Yeah, inability to close the context menu is definitely very severe. 20180416 09:08:57<+discordbot> Unfortunately, RC3 is the final RC. Any bug fixes after this point won't receive much testing before the Steam launch. If the fix causes a severe regression somewhere and we fail to notice it, it will be in the Steam version. 20180416 09:15:43< irker523> wesnoth/wesnoth:master Celtic Minstrel ecc8785edb Support location_id in [recall] and [uns AppVeyor: 2/4 builds failed 20180416 09:15:44< irker523> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-2720 20180416 09:15:45< irker523> Details vs2017/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-master-2428 20180416 09:16:43< grzywacz> jyrkive: should I open an issue about this right-click/context menu behavior? 20180416 09:17:03<+discordbot> Please do. 20180416 09:19:24< grzywacz> https://github.com/wesnoth/wesnoth/issues/2910 20180416 09:27:56<+discordbot> https://wiki.wesnoth.org/User:Shadowm/Stable_1.14_Announcement_Outline We haven't got much time left, so you'll probably only have one more day or so to add things to the outline. 20180416 09:29:02<+discordbot> After that we need to write the actual text and get it string-frozen before next Monday ( @Vultraz ) 20180416 09:32:17<+discordbot> @jyrkive not a bug 20180416 09:32:23<+discordbot> deliberate choice 20180416 09:32:28<+discordbot> (re dropdown and right click close) 20180416 09:33:23<+discordbot> After you stated that not closing the context menu on right-click is deliberate, it was changed anyway. 20180416 09:33:48<+discordbot> So, yes, if the game currently doesn't close the context menu on right-click on Linux, it is a bug. 20180416 09:34:23<+discordbot> "was changed anyway"? 20180416 09:34:26<+discordbot> when... 20180416 09:35:03<+discordbot> I need some time to dig up the commit. (Lunch time may be before I find it.) 20180416 09:35:05<+discordbot> I'm guessing this is some magic in mouse_handler_base r something 20180416 09:35:22<+discordbot> or.. 20180416 09:35:24<+discordbot> wait, no 20180416 09:35:30<+discordbot> that wouldn't work when the dialog is open 20180416 09:38:34<+discordbot> @jyrkive are you sure you aren't thinking of that bug with unit selection and the right click menu? 20180416 09:38:51<+discordbot> Found the commit. 20180416 09:38:52<+discordbot> https://github.com/wesnoth/wesnoth/commit/8e388c1b3557f436cd524fb35572e40c739043ba 20180416 09:39:22<+discordbot> Yeah, that's not the issue at hand 20180416 09:39:56<+discordbot> grzywacz says a right click doesn't close the menu. That commit means a new unit isn't selected if closing it normally with a right click 20180416 09:40:11<+discordbot> ergo, not a regression 20180416 09:40:41<+discordbot> After commit 8e388c1b, I tested the behavior. Right-clicking 1) closed the menu and 2) didn't spawn a new menu. 20180416 09:40:45<+discordbot> Ergo, a regression. 20180416 09:40:53<+discordbot> Going to a meeting now, lunch after it. 20180416 09:44:10<+discordbot> Are you sure? Because looking at the code that shouldn't happen... 20180416 10:08:03< zookeeper> i'll compile a list of notable new terrain changes/additions for the announcement... 20180416 10:10:21< irker523> wesnoth: Charles Dang wesnoth:1.14 4c9ba39a7600 / src/gui/dialogs/drop_down_menu.cpp: Drop Down Menu: allow right clicks to dismiss the window (fixes #2910) https://github.com/wesnoth/wesnoth/commit/4c9ba39a76006792c912d47169a13bc067b556ad 20180416 10:10:59< irker523> wesnoth: Charles Dang wesnoth:master 30257afd3f97 / src/gui/dialogs/drop_down_menu.cpp: Drop Down Menu: allow right clicks to dismiss the window (fixes #2910) https://github.com/wesnoth/wesnoth/commit/30257afd3f9725b1ac54610ef61d14d873057531 20180416 10:27:06< grzywacz> Works well, thanks. 20180416 10:29:46<+discordbot> @Vultraz Yes, I'm sure. Inability to close the context menu by right-clicking is so annoying that I'd remember it. 20180416 10:29:57-!- vladimirslavik [vslavik@nat/redhat/x-bwsqubheoxqzvrlv] has joined #wesnoth-dev 20180416 10:30:01<+discordbot> well, it's been fixed now 20180416 10:30:14<+discordbot> Great, thanks. 👍 20180416 11:36:42< irker523> wesnoth/wesnoth:master Celtic Minstrel 0294bd81b2 Display amount healed as an integer in [ AppVeyor: All builds passed 20180416 12:25:50-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev 20180416 12:34:16-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: So long and thanks for all the fish.] 20180416 12:49:20-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180416 12:49:26-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180416 13:24:27-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180416 13:24:33-!- janebot_ [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180416 13:24:33-!- janebot_ is now known as janebot 20180416 13:37:45< irker523> wesnoth: Severin Glöckner wesnoth:1.14 abc6b797be1f / data/campaigns/Under_the_Burning_Suns/ (5 files in 3 dirs): finish renaming of the Horseman to Pathfinder https://github.com/wesnoth/wesnoth/commit/abc6b797be1f1a34791b0a03510e5d041970318a 20180416 13:40:24< irker523> wesnoth: Severin Glöckner wesnoth:master ae0420108f97 / data/campaigns/Under_the_Burning_Suns/ (5 files in 3 dirs): finish renaming of the Horseman to Pathfinder https://github.com/wesnoth/wesnoth/commit/ae0420108f9730561e0c100f4461ff82e34395b1 20180416 13:57:32< irker523> wesnoth/wesnoth:1.14 ln-zookeeper a565e9259f UtBS: Re-added compatibility code to loa AppVeyor: All builds passed 20180416 14:35:54-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20180416 14:37:24-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180416 15:30:50-!- ustp [59b0034d@gateway/web/freenode/ip.89.176.3.77] has joined #wesnoth-dev 20180416 15:50:40-!- Oebele [~quassel@143.177.58.202] has joined #wesnoth-dev 20180416 15:59:13<+discordbot> I could have sworn you updated the VS project to use Fast LTO 20180416 15:59:15<+discordbot> 🤔 20180416 15:59:23<+discordbot> I did. 20180416 15:59:38<+discordbot> looks like it's still LTO on 1.14 20180416 15:59:51<+discordbot> Yes, 1.14 is unchanged. 20180416 16:00:12<+discordbot> It still supports VS2013, and VS2013 doesn't support incremental LTCG. 20180416 16:00:24<+discordbot> ahh 20180416 16:00:51<+discordbot> alright, at least that explains why my 1.14 builds were taking 10x longer to link 20180416 16:01:00<+discordbot> switches to FLTO locally 20180416 16:02:08-!- gallaecio [~quassel@38.red-83-46-126.dynamicip.rima-tde.net] has quit [Remote host closed the connection] 20180416 16:03:36< irker523> wesnoth: Charles Dang wesnoth:master 601c67d970c2 / changelog.md src/units/unit.cpp: Utilized 2x xBRZ scaling for portraitless units in game dialog https://github.com/wesnoth/wesnoth/commit/601c67d970c2eacd2c59b340613502de8e8861fe 20180416 16:04:54< irker523> wesnoth: Charles Dang wesnoth:1.14 2ff68304ff03 / changelog.md src/units/unit.cpp: Utilized 2x xBRZ scaling for portraitless units in game dialog https://github.com/wesnoth/wesnoth/commit/2ff68304ff035da54af74e2d22cc742ebb031c72 20180416 16:06:27< irker523> wesnoth: Charles Dang wesnoth:1.14 122621fd7bd0 / changelog.md: Changelog entry for 4c9ba39 https://github.com/wesnoth/wesnoth/commit/122621fd7bd0c2dee086d5599a965c20f46b72fe 20180416 16:07:19<+discordbot> what does the Test_Release/Test_Debug target do? 20180416 16:09:06<+discordbot> does it build the boost unit tests? 20180416 16:17:57-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Quit: Leaving.] 20180416 16:31:45-!- gallaecio [~quassel@188.79.96.255] has joined #wesnoth-dev 20180416 16:46:59-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20180416 17:03:45< irker523> wesnoth/wesnoth:1.14 Charles Dang 4c9ba39a76 Drop Down Menu: allow right clicks to di AppVeyor: All builds passed 20180416 17:43:19<+discordbot> @Yumi By the way, https://wiki.wesnoth.org/DirectActionsWML#.5Bheal_unit.5D states that the heal amount in [heal_unit] must be an integer. 20180416 17:43:34<+discordbot> Passing a decimal value is technically unsupported. 20180416 17:52:37< irker523> wesnoth: Jyrki Vesterinen wesnoth:1.14 77b9bc39695e / data/lua/wml/heal_unit.lua: [heal_unit]: ensure that heal amount is an integer https://github.com/wesnoth/wesnoth/commit/77b9bc39695eabe9202ec44e71688523974dcdc1 20180416 17:55:47< irker523> wesnoth: Jyrki Vesterinen wesnoth:master f2284e2e79db / data/lua/wml/heal_unit.lua: Revert "Display amount healed as an integer in [heal_unit]" https://github.com/wesnoth/wesnoth/commit/f2284e2e79db5432039d0ac0a364d0982c7f9f71 20180416 17:55:49< irker523> wesnoth: Jyrki Vesterinen wesnoth:master 76ed49a45f36 / data/lua/wml/heal_unit.lua: [heal_unit]: ensure that heal amount is an integer https://github.com/wesnoth/wesnoth/commit/76ed49a45f3679050cf06e2ab6aa5ec072957572 20180416 17:58:56<+discordbot> meh 20180416 17:59:15<+discordbot> then is there a WML macro for taking the floor/ceiling of a decimal value 20180416 17:59:16-!- gallaecio [~quassel@188.79.96.255] has quit [Read error: Connection reset by peer] 20180416 17:59:46<+discordbot> since my ability does some division in it and there's no way to guarantee that the division will result in an integer 20180416 18:00:06<+discordbot> Use WFL 20180416 18:00:54-!- gallaecio [~quassel@188.79.96.255] has joined #wesnoth-dev 20180416 18:00:57<+discordbot> “$(floor(Val))” afaik 20180416 18:01:08< Ravana_> set_variable supports it with extra keys 20180416 18:01:43<+discordbot> mk 20180416 18:07:32< irker523> wesnoth: Charles Dang wesnoth:master 54cacf815de0 / changelog.md: Changelog entry for 30257af https://github.com/wesnoth/wesnoth/commit/54cacf815de0923df8673ecb78a9034d09342b86 20180416 18:11:16<+discordbot> @jyrkive does you unassigning me from that bug mean you'll be working on it? 20180416 18:13:47<+discordbot> I'm planning to, yes. 20180416 18:14:18<+discordbot> (But I didn't assign it to myself. If someone else starts working on it before me, feel free.) 20180416 18:14:58<+discordbot> It's probably not that complicated... I just really haven't felt like working on it 20180416 18:15:10<+discordbot> I also expect it will require some refactoring 20180416 18:15:49<+discordbot> When you don't feel like working on an issue, you shouldn't assign it and block others from working on it. 20180416 18:17:05<+discordbot> I had initially been planning to 20180416 18:17:30<+discordbot> That's why I pretty much never assign issues. 20180416 18:18:19<+discordbot> The only time when I'd be able to assign an issue to myself is when I start working on it. And at that point, what's the point? I'll be done in few hours and it's unlikely that someone else would start working on it in the meantime. 20180416 18:20:39<+discordbot> @sinda any progress on https://github.com/wesnoth/wesnoth/issues/2782 ? I see you made a related commit to your fork 20180416 18:33:53<+discordbot> Nope, sorry. That stuff needs quite a bit of rewrite, I didn't even start it. 20180416 18:59:50-!- vladimirslavik [vslavik@nat/redhat/x-bwsqubheoxqzvrlv] has quit [Quit: Leaving] 20180416 19:16:44< zookeeper> "could not initialize fonts" what's this now? 20180416 19:18:10< zookeeper> ah well nevermind, i'll try a newer binary 20180416 19:29:52-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20180416 19:44:27-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20180416 19:52:56-!- Oebele [~quassel@143.177.58.202] has quit [Remote host closed the connection] 20180416 20:02:25< irker523> wesnoth/wesnoth:1.14 Severin Glöckner abc6b797be finish renaming of the Horseman to Pathf AppVeyor: All builds passed 20180416 20:06:01-!- octalot [~steve@178.165.130.119.wireless.dyn.drei.com] has joined #wesnoth-dev 20180416 20:11:01-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180416 20:11:07-!- janebot_ [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180416 20:11:08-!- janebot_ is now known as janebot 20180416 20:23:05-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20180416 20:27:18-!- octalot [~steve@178.165.130.119.wireless.dyn.drei.com] has quit [Ping timeout: 260 seconds] 20180416 20:27:33-!- gallaecio [~quassel@188.79.96.255] has quit [Remote host closed the connection] 20180416 20:29:05-!- octalot [~steve@178.165.130.119.wireless.dyn.drei.com] has joined #wesnoth-dev 20180416 20:33:49-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20180416 20:48:30-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Quit: Caught sigterm, terminating...] 20180416 20:48:56-!- Ivanovic [~ivanovic@p4FC53504.dip0.t-ipconnect.de] has joined #wesnoth-dev 20180416 20:48:56-!- Ivanovic [~ivanovic@p4FC53504.dip0.t-ipconnect.de] has quit [Changing host] 20180416 20:48:56-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev 20180416 21:02:41-!- octalot [~steve@178.165.130.119.wireless.dyn.drei.com] has quit [Ping timeout: 276 seconds] 20180416 21:12:08-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180416 21:12:14-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180416 21:23:51-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev 20180416 21:31:47-!- octalot [~steve@178.165.130.119.wireless.dyn.drei.com] has joined #wesnoth-dev 20180416 21:44:01-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20180416 21:44:25-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20180416 21:44:25-!- noy [~Noy@wesnoth/developer/noy] has quit [Client Quit] 20180416 21:51:26-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20180416 21:54:42-!- grzywacz [~karol@wesnoth/developer/grzywacz] has quit [Ping timeout: 260 seconds] 20180416 22:12:33< irker523> wesnoth/wesnoth:master Charles Dang 601c67d970 Utilized 2x xBRZ scaling for portraitles AppVeyor: All builds passed 20180416 22:19:51-!- timotei_ [~timotei@wesnoth/developer/timotei] has quit [Read error: Connection reset by peer] 20180416 22:19:55-!- timotei__ [~timotei@wesnoth/developer/timotei] has joined #wesnoth-dev 20180416 22:25:33-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 264 seconds] 20180416 22:40:09-!- ustp [59b0034d@gateway/web/freenode/ip.89.176.3.77] has quit [Ping timeout: 260 seconds] 20180416 22:43:42-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20180416 22:49:33-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection] 20180416 23:05:05-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180416 23:05:11-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180416 23:16:16< irker523> wesnoth: Charles Dang wesnoth:master 98ed802290fb / src/ (scripting/lua_unit.cpp units/unit.cpp): Fixup 601c67d970c2eac https://github.com/wesnoth/wesnoth/commit/98ed802290fb987fc106300a8b6414420e13ba2a 20180416 23:17:01< irker523> wesnoth: Charles Dang wesnoth:1.14 fab229b5e85e / src/ (scripting/lua_unit.cpp units/unit.cpp): Fixup 601c67d970c2eac https://github.com/wesnoth/wesnoth/commit/fab229b5e85e0b1c00d7f5223c3b2241cf6ba61c 20180416 23:20:48<+discordbot> Can you change hp_bar_scaling of a unit at runtime? I tried [modify_unit] and through lua unit proxy but it seams that attribute is not accessible nor i can find it in the inspect window 20180416 23:20:50<+discordbot> https://wiki.wesnoth.org/SingleUnitWML#Unit_Data 20180416 23:22:02<+discordbot> hm. 20180416 23:22:05<+discordbot> probably not. 20180416 23:25:21-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20180416 23:37:51<+discordbot> So its an error in the wiki? 20180416 23:38:17<+discordbot> more like it's just unmodifiable at runtime 20180416 23:38:24<+discordbot> we could rectify that, of course 20180416 23:42:46<+discordbot> [unit] action doesn't respect xp_bar_scaling either 20180416 23:43:27<+discordbot> For me it would be better if xp_bar_scaling was writable xD 20180416 23:43:41<+discordbot> xp_bar_scaling in [game_config] 20180416 23:43:55<+discordbot> hp/xp* 20180416 23:55:03-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev --- Log closed Tue Apr 17 00:00:46 2018