--- Log opened Sat Apr 21 00:00:41 2018 20180421 00:34:30<+discordbot> celticminstrel: It came up during discussions of another, related topic, but the forum thread pretty much summarizes it: https://forums.wesnoth.org/viewtopic.php?f=6&t=48014 20180421 00:35:50< celticminstrel> That's where I found out about it. 20180421 01:44:04-!- gfgtdf_ [~chatzilla@x4e32b633.dyn.telefonica.de] has joined #wesnoth-dev 20180421 01:46:14-!- gfgtdf [~chatzilla@x4e368224.dyn.telefonica.de] has quit [Ping timeout: 260 seconds] 20180421 01:46:28-!- gfgtdf_ is now known as gfgtdf 20180421 01:48:00-!- irker234 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout] 20180421 02:05:14-!- irker496 [~irker@uruz.ai0867.net] has joined #wesnoth-dev 20180421 02:05:14< irker496> wesnoth/wesnoth:master pentarctagon 23c5b85b7b Print the value of STRICT and build_time AppVeyor: All builds passed 20180421 02:30:36< irker496> wesnoth: gfgtdf wesnoth:master 3797837c746b / src/ (5 files in 3 dirs): fix handling of no_leader= (again) https://github.com/wesnoth/wesnoth/commit/3797837c746b4cd371d83f5eaed94b57f1b1cd01 20180421 02:32:32< gfgtdf> i'm still unsure about whether i should backport that ^ (would correct https://forums.wesnoth.org/viewtopic.php?f=21&t=48013) 20180421 02:34:08-!- gfgtdf [~chatzilla@x4e32b633.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.93 [Firefox 52.7.3/20180322140748]] 20180421 02:34:30<+discordbot> I don't know 20180421 03:12:55< irker496> wesnoth: Charles Dang wesnoth:master 8a00056a2279 / src/ (3 files in 2 dirs): Attempt to fix infinite loading screen if server restarts during MP login https://github.com/wesnoth/wesnoth/commit/8a00056a2279284f6834ce78d837e4728558e7d9 20180421 03:13:17<+discordbot> @shadowm could you see if that resolves 2927 ^? It's a blind attempt, but it might work. 20180421 03:43:09< irker496> wesnoth/wesnoth:1.14 Nils Kneuper b5c7696577 updated German translation AppVeyor: All builds passed 20180421 05:04:38< irker496> wesnoth: Charles Dang wesnoth:master 7241561554e9 / src/ (animated.hpp animated.tpp): Animated: simplified template stuff https://github.com/wesnoth/wesnoth/commit/7241561554e9e2d3e958a9ed9ead4c70ec27f426 20180421 05:32:25-!- celticminstrel is now known as celmin|sleep 20180421 06:00:30-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180421 06:07:09-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180421 06:07:16-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180421 06:19:52-!- grzywacz [~karol@89-70-226-147.dynamic.chello.pl] has joined #wesnoth-dev 20180421 06:32:25< irker496> wesnoth: pentarctagon wesnoth:master 63ff641662d4 / / (5 files in 3 dirs): Adds the opt/OPT option to scons/cmake. https://github.com/wesnoth/wesnoth/commit/63ff641662d4192401a49f9a002d7872000a3f02 20180421 06:32:27< irker496> wesnoth: pentarctagon wesnoth:master 96c41271d809 / SConstruct utils/travis/docker_run.sh: Print the value of STRICT and build_timeout. https://github.com/wesnoth/wesnoth/commit/96c41271d80937da778d05477b0e1caadc6def10 20180421 06:35:28< Soliton> @Vultraz: the error should just say that there was a disconnect. we don't know what happened to the server. 20180421 06:35:38-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20180421 06:35:52<+discordbot> I can tweak the error 20180421 06:35:54<+discordbot> message 20180421 06:36:00<+discordbot> but does it work 20180421 06:36:59<+discordbot> I'd suggest that wait_and_receive_data() should just throw an exception if the socket isn't open. 20180421 06:37:28<+discordbot> That way all cases of the client getting stuck would be fixed, not just this one. 20180421 06:38:08<+discordbot> good idea 20180421 06:41:21< Soliton> yeah, it's still stuck in there. 20180421 06:41:50< Soliton> you can test by using an invalid nick so you don't login immediately. 20180421 06:42:28<+discordbot> um. this issue is about the server shutting down? 20180421 06:43:23< Soliton> getting disconnected one way or another, yes. 20180421 06:43:30< irker496> wesnoth/wesnoth:master Severin Glöckner 8b492a3ab4 Tutorial: Button was renamed, update tex AppVeyor: All builds passed 20180421 06:47:59< irker496> wesnoth: Gunter Labes wesnoth:1.14 996ae23e1728 / src/server/server.cpp: Expect more data from client after sending error https://github.com/wesnoth/wesnoth/commit/996ae23e1728c91d09307767827a8b60d40c3f30 20180421 06:48:55<+discordbot> @Soliton is that live? 20180421 06:49:24< Soliton> i'm rebuilding the server now. 20180421 06:51:01<+discordbot> let me know when it's up 20180421 06:54:20<+discordbot> god dammit 20180421 06:55:19<+discordbot> Will you ever stop doing that? You are aware that these issues exist. 20180421 06:55:30<+discordbot> I thought I expanded it enough 20180421 06:55:40<+discordbot> I increased the width 20180421 06:56:01<+discordbot> It was supposed to fix that 20180421 06:56:57<+discordbot> And now it's back 20180421 06:59:07< Soliton> @Vultraz: it's up now. 20180421 06:59:45<+discordbot> doesn't work 20180421 07:01:49< Soliton> yep. :-/ 20180421 07:02:41< Soliton> would be nice to get the disconnect detection on the client going so we confirm it's a disconnect at least. 20180421 07:03:01<+discordbot> wait 20180421 07:03:06<+discordbot> what bug are we testing? 20180421 07:05:01< Soliton> i'm testing #2925. 20180421 07:05:27<+discordbot> ok, same 20180421 07:05:36<+discordbot> but that has nothing to do with disconnects 20180421 07:05:44< Soliton> if you say so. 20180421 07:16:28<+discordbot> Can I merge #2921 once is enough time to test it cross all platforms? 20180421 07:16:52< vn971> Awesome, wesnoth now preserves chats upon restarts! ♥ 20180421 07:18:08<+discordbot> https://github.com/wesnoth/wesnoth/pull/2921 20180421 07:23:28< Soliton> checking is_open() does not seem to help anything to detect a disconnect. 20180421 07:34:50-!- gallaecio [~quassel@188.79.96.255] has joined #wesnoth-dev 20180421 07:50:22-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20180421 07:53:14-!- octalot [~steve@178.115.130.196.wireless.dyn.drei.com] has joined #wesnoth-dev 20180421 07:56:45-!- grzywacz [~karol@89-70-226-147.dynamic.chello.pl] has quit [Ping timeout: 264 seconds] 20180421 08:17:22-!- grzywacz [~karol@89-70-226-147.dynamic.chello.pl] has joined #wesnoth-dev 20180421 08:38:19-!- travis-ci [~travis-ci@ec2-54-162-158-152.compute-1.amazonaws.com] has joined #wesnoth-dev 20180421 08:38:20< travis-ci> Pentarctagon/wesnoth#438 (travis-mysql - 0662667 : pentarctagon): The build passed. 20180421 08:38:20< travis-ci> Build details : https://travis-ci.org/Pentarctagon/wesnoth/builds/369436746 20180421 08:38:20-!- travis-ci [~travis-ci@ec2-54-162-158-152.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180421 08:43:51<+discordbot> @Soliton I though it could detect whether the socket had closed since shadowm said the server shutdown would forcibly close the sockets 20180421 08:51:52< irker496> wesnoth: Gunter Labes wesnoth:1.14 a58e2200ab99 / src/wesnothd_connection.cpp: Fix debug message https://github.com/wesnoth/wesnoth/commit/a58e2200ab9901751d02e8e344ce8d20d7b93969 20180421 08:52:45-!- octalot [~steve@178.115.130.196.wireless.dyn.drei.com] has quit [Ping timeout: 268 seconds] 20180421 08:53:08< Soliton> @Vultraz: yes, i get that. doesn't seem like anything sets that open status there though. 20180421 08:53:11-!- Oebele [~quassel@143.177.58.202] has joined #wesnoth-dev 20180421 08:53:48< Soliton> which perhaps is a bug. 20180421 08:56:09< Soliton> i wonder if the unregistered bug is perhaps now on the client side since i can't see what the server is missing now. 20180421 08:56:31< irker496> wesnoth/wesnoth:1.14 sigurdfdragon d297af5ef9 Help: Add wolves race description AppVeyor: All builds passed 20180421 08:56:40<+discordbot> it's not 20180421 08:56:44< Soliton> and it should be useful to fix the disconnect detection for that. 20180421 08:57:12<+discordbot> look at my paste again 20180421 08:57:19<+discordbot> the server should have sent a password request 20180421 08:57:21<+discordbot> it doesn 20180421 08:57:23<+discordbot> doesn't 20180421 08:57:26< Soliton> have you updated it? 20180421 08:57:34<+discordbot> what? 20180421 08:58:15< Soliton> did you read the word now i used above? do you understand what i mean with that? 20180421 08:58:42< Soliton> not trying to be mean but it's frustrating to communicate with you sometimes.. 20180421 08:59:03<+discordbot> updated what 20180421 09:02:28-!- octalot [~steve@178.115.130.196.wireless.dyn.drei.com] has joined #wesnoth-dev 20180421 09:16:54-!- travis-ci [~travis-ci@ec2-54-80-146-36.compute-1.amazonaws.com] has joined #wesnoth-dev 20180421 09:16:55< travis-ci> wesnoth/wesnoth#17738 (1.14 - a58e220 : Gunter Labes): The build was broken. 20180421 09:16:55< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/369442038 20180421 09:16:55-!- travis-ci [~travis-ci@ec2-54-80-146-36.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180421 09:18:43<+discordbot> Your paste to reflect the latest changes to the server codebase, surely. 20180421 09:19:01< irker496> wesnoth: Gunter Labes wesnoth:1.14 a3243bb5354e / src/wesnothd_connection.cpp: Detect disconnect when waiting on data from server https://github.com/wesnoth/wesnoth/commit/a3243bb5354e4393a7e5acf92a5ef8ae3a3ff636 20180421 09:19:14< Soliton> ok, disconnect detection works now. 20180421 09:19:44< Soliton> i'll also now noticed i introduced a warning earlier. going to fix in a moment. 20180421 09:22:35< irker496> wesnoth: Gunter Labes wesnoth:1.14 bf42e65de28d / src/wesnothd_connection.cpp: Fix compiler warning https://github.com/wesnoth/wesnoth/commit/bf42e65de28da337c02d239c2c99f6ec166a3e96 20180421 09:23:00<+discordbot> No updates to the paste were needed 20180421 09:23:59<+discordbot> How does that fix the login error exactly? 20180421 09:24:02< Soliton> well, doesn't matter now. you can see it's a disconnect. 20180421 09:24:37< Soliton> unfortunately i have no idea why. still figuring this asio stuff out. 20180421 09:24:41<+discordbot> What is a disconnect? Logging in with a different name? 20180421 09:28:52<+discordbot> I’m confused since you keep throwing around the word “disconnect” without much context 20180421 09:29:41<+discordbot> I had a possible for for 2925 20180421 09:29:44<+discordbot> You said it didn’t work 20180421 09:29:48<+discordbot> Then you commit a fix 20180421 09:29:49< Soliton> loonycyborg: why do we not have to call server::login on every return in server::handle_login? 20180421 09:29:53<+discordbot> And says it fixes 2927 20180421 09:30:21<+discordbot> And the commit message says something about 2925 that don’t make much sense 20180421 09:30:40<+discordbot> Not to mention you were working on 1.14 20180421 09:30:44<+discordbot> Which didn’t have my fix 20180421 09:30:53<+discordbot> So how could you even say it didn’t work 20180421 09:31:20<+discordbot> And you won’t explain what the hell a “disconnect” has to do with logging in with a new nickname! 20180421 09:31:29<+discordbot> And you say it’s ME who’s hard to talk to 😑 20180421 09:31:56< irker496> wesnoth: pentarctagon wesnoth:master 4157251f11a5 / / (3 files in 2 dirs): Enable building with mysql support on travis. https://github.com/wesnoth/wesnoth/commit/4157251f11a5669c64a3941462615dad0da65c96 20180421 09:32:05<+discordbot> There are better ways to phrase everything you just said. 20180421 09:33:51<+discordbot> And that's really what it all boils down to. You need to use more objective and detailed language when talking about code if you want to get anywhere. 20180421 09:33:56<+discordbot> ....ok, I think I’ve been mixing these issues up 20180421 09:34:13<+discordbot> Ok, 20180421 09:34:19<+discordbot> Let me see 20180421 09:34:28< Soliton> @Vultraz: feel free to re-test the issues on 1.14. the client will now notice when there is a disconnect. you'll notice that issue #2925 now results in a disconnect. 20180421 09:34:46<+discordbot> I thought 2927 was the issue about changing a nickname 20180421 09:35:04<+discordbot> It is not 20180421 09:35:09<+discordbot> >.>; 20180421 09:35:10<+discordbot> Does this fix the client not realising it's been disconnected we in the lobby as well? 20180421 09:35:12<+discordbot> It’s about the server disconnection 20180421 09:35:20<+discordbot> *while in the lobby 20180421 09:35:21<+discordbot> Shutting down I should say 20180421 09:35:32<+discordbot> So your fix addresses 2927 20180421 09:35:41< loonycyborg> Soliton: I don't think there's a particular reason not to 20180421 09:35:55< Soliton> it notices "simple" disconnects immediately for me. i guess the remaining issue is with the keepalive feature. 20180421 09:36:04<+discordbot> So I will revert my fix on master 20180421 09:36:06< loonycyborg> besides hysterical reasons maybe 20180421 09:36:35< loonycyborg> perhaps call to server::login could be moved to end of handler 20180421 09:36:49<+discordbot> @Soliton so you are saying when logging in with a new nickname, you end up at the titlescreen instead of an infinite loading screen now? 20180421 09:36:51< loonycyborg> but need to ensure there's no return statements in code before 20180421 09:37:04< loonycyborg> unless we want to skip that read on purpose 20180421 09:37:13-!- travis-ci [~travis-ci@ec2-54-80-146-36.compute-1.amazonaws.com] has joined #wesnoth-dev 20180421 09:37:14< travis-ci> wesnoth/wesnoth#17739 (1.14 - a3243bb : Gunter Labes): The build is still failing. 20180421 09:37:14< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/369446650 20180421 09:37:14-!- travis-ci [~travis-ci@ec2-54-80-146-36.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180421 09:37:57<+discordbot> @Vultraz It prints "End of file", then goes back to the main menu. 20180421 09:38:01< Soliton> @Vultraz: all the infinite loading screen issues should be gone now with the disconnect detection. unless there are actual cases where both client and server wait for each other. 20180421 09:38:15<+discordbot> ok 20180421 09:38:21<+discordbot> but there's still an issue 20180421 09:38:32<+discordbot> since there should be NO disconnect when logging in with a new nick 20180421 09:38:47< Soliton> yes, i'm trying to get loonycyborg to look into that. 20180421 09:38:56< Soliton> because i have no idea at this point. 20180421 09:39:50< Soliton> loonycyborg claimed earlier that we need to register an async handler all the time. yet that did not help in this case and it apparently is not needed in other cases. 20180421 09:39:55< irker496> wesnoth: Charles Dang wesnoth:master f8b936c2d517 / src/ (3 files in 2 dirs): Revert "Attempt to fix infinite loading screen if server restarts during MP logi https://github.com/wesnoth/wesnoth/commit/f8b936c2d51788ad72f21a953aab5bf532b68f8c 20180421 09:40:14<+discordbot> @Soliton please forward-port your changes 20180421 09:40:20< Soliton> (also yes i'm hopefully not forgetting to forward port stuff later.) 20180421 09:40:48< loonycyborg> how exactly do you reproduce that disconned with different nicks? 20180421 09:40:53< loonycyborg> *disconnect 20180421 09:41:06< Soliton> login with an unregistered nick then change to a registered one. 20180421 09:41:27< Soliton> (because you cannot login with an unregistered nick anymore now.) 20180421 09:41:51<+discordbot> I receive an "End of file"message 20180421 09:41:54<+discordbot> what the hell 20180421 09:42:04<+discordbot> Ah lovely. 20180421 09:42:10< Soliton> everything is a file! 20180421 09:42:35< loonycyborg> end of file signifies disconnect 20180421 09:42:41< loonycyborg> need to translate that somehow 20180421 09:42:57< loonycyborg> it's just message asio associates with that exception 20180421 09:43:01<+discordbot> That just means you got disconnected like I said before. We really need to file a bug to get that patched in 1.14.1. 20180421 09:43:07<+discordbot> clearing and waiting for data clearing and waiting for data clearing and waiting for data clearing and waiting for data trying login: vultraz2 data received from server in response to login:' [error] error_code = 105 message = The nickname 'vultraz2' is not registered. This server disallows unregistered nicknames. [/error] ' checking for error login prompt ok selected exited inner loop end of login loop, next 20180421 09:43:07<+discordbot> iteration trying login: vultraz data received from server in response to login:' ' checking for error out of login loop end master loop clearing and waiting for data 20180421 20:42:46 error network: caught network error: End of file 20180421 09:43:53<+discordbot> I'm annoyed that you don't get the real reason in the logs anymore though (connection reset by peer, etc.). 20180421 09:44:23< loonycyborg> in what logs? at least server prints exact messages 20180421 09:44:32< loonycyborg> like reset by peer 20180421 09:44:34<+discordbot> Client log obviously. 20180421 09:45:27<+discordbot> @Soliton it seems the only change here is that now an EoF is hit instead of spinning for data. There is still no response (password request) to the second login 20180421 09:45:52< Soliton> loonycyborg: https://github.com/wesnoth/wesnoth/commit/996ae23 explain to me why this does not register a receive handler for when the client sends stuff again to end up in handle_login again. 20180421 09:51:18<+discordbot> I mean, at least now it doesn't require restarting wesnoth if someone typos their username. So that's definitely an improvement at least. The error message isn't great though, and it doesn't seem like getting kicked back to the main menu even after entering a registered username is good. 20180421 09:52:11<+discordbot> Of course it’s not good 20180421 09:52:18<+discordbot> It needs to be fixed before release 20180421 09:57:00<+discordbot> It seems to me then, that there's two ways to go about it. a) Allow changing the nick and trying to log in again from the current dialog that appears when the nick isn't registered. b) Change "End of file" to the current text displayed on the dialog when the nick isn't registered, then go back to the main menu. 20180421 09:57:48<+discordbot> right now it's kind of in between those two 20180421 09:58:05< Soliton> we're going for a) since that is how it worked before. 20180421 09:58:06-!- travis-ci [~travis-ci@ec2-54-198-6-123.compute-1.amazonaws.com] has joined #wesnoth-dev 20180421 09:58:06< travis-ci> wesnoth/wesnoth#17740 (1.14 - bf42e65 : Gunter Labes): The build was fixed. 20180421 09:58:07< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/369447521 20180421 09:58:07-!- travis-ci [~travis-ci@ec2-54-198-6-123.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180421 10:11:42< loonycyborg> Soliton: I think I'll just move code that checks if login is allowed to separate function 20180421 10:12:03< loonycyborg> so it won't be needed to remember to call server::login before return 20180421 10:12:10< loonycyborg> because it's done outside of the function 20180421 10:16:18<+discordbot> Looking forward to the next rebase for my branch. 🙃 20180421 10:17:07<+discordbot> Unless I manage to get it merged before that refactoring 20180421 10:18:11-!- zookeeper_ [~lmsnie@95.175.104.29] has joined #wesnoth-dev 20180421 10:18:11-!- zookeeper_ [~lmsnie@95.175.104.29] has quit [Client Quit] 20180421 10:19:25< Soliton> loonycyborg: that sounds much better. 20180421 10:19:55-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 256 seconds] 20180421 10:29:24-!- gfgtdf [~chatzilla@x4e32b633.dyn.telefonica.de] has joined #wesnoth-dev 20180421 10:37:13-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20180421 11:05:40< irker496> wesnoth: Martin Hrubý (hrubymar10) wesnoth:1.14 335224766085 / / (4 files in 2 dirs): Remove rest of Growl things which I forgot before https://github.com/wesnoth/wesnoth/commit/3352247660857a58635669e130b2b04256c35257 20180421 11:06:30< irker496> wesnoth: Martin Hrubý (hrubymar10) wesnoth:master 783738b2f52f / / (4 files in 2 dirs): Remove rest of Growl things which I forgot before https://github.com/wesnoth/wesnoth/commit/783738b2f52f12c998a94ae9483803eeace89b38 20180421 12:21:03< irker496> wesnoth: Charles Dang wesnoth:master 2ec5c6ee5c65 / src/ (31 files in 19 dirs): Cleaned up more unnecessary includes https://github.com/wesnoth/wesnoth/commit/2ec5c6ee5c6516bb279e44492d36a47c7f26183c 20180421 12:23:46-!- octalot [~steve@178.115.130.196.wireless.dyn.drei.com] has quit [Ping timeout: 256 seconds] 20180421 12:37:56< irker496> wesnoth: Victor Sergienko wesnoth:1.14 853be75e1bc7 / src/gui/ (4 files in 2 dirs): #2782 Crash when using composing like ˇ and ' in lobby on macOS. https://github.com/wesnoth/wesnoth/commit/853be75e1bc72c8f661e92e17f27c74aa87aa791 20180421 12:37:58< irker496> wesnoth: Martin Hrubý wesnoth:1.14 7907ce9870a5 / src/gui/ (4 files in 2 dirs): Fix for #2782 https://github.com/wesnoth/wesnoth/commit/7907ce9870a58bc25814f790175cd05e73b789f8 20180421 12:38:32<+discordbot> @sinda ^^ please tell me, if I should cherry pick it to master 20180421 12:39:13-!- octalot [~steve@178.115.130.196.wireless.dyn.drei.com] has joined #wesnoth-dev 20180421 12:47:44<+discordbot> as far as I know yes 20180421 12:57:29-!- Oebele [~quassel@143.177.58.202] has quit [Remote host closed the connection] 20180421 12:57:37-!- octalot [~steve@178.115.130.196.wireless.dyn.drei.com] has quit [Ping timeout: 248 seconds] 20180421 12:59:31-!- Oebele [~quassel@143.177.58.202] has joined #wesnoth-dev 20180421 13:01:47-!- atarocch [~atarocch@93.56.164.28] has quit [Remote host closed the connection] 20180421 13:02:27< irker496> wesnoth: loonycyborg wesnoth:master 99372123da53 / src/server/ (server.cpp server.hpp): wesnothd: always wait for next login attempt after login fail https://github.com/wesnoth/wesnoth/commit/99372123da53990466b4a52bb1f206f2a1a73c75 20180421 13:03:07<+discordbot> this should fix login hang on login failure 20180421 13:12:09-!- discordbot [~discordbo@baldras.wesnoth.org] has quit [Remote host closed the connection] 20180421 13:12:23-!- discordbot [~discordbo@baldras.wesnoth.org] has joined #wesnoth-dev 20180421 13:12:26-!- mode/#wesnoth-dev [+v discordbot] by ChanServ 20180421 13:15:01< irker496> wesnoth/wesnoth:master pentarctagon 96c41271d8 Print the value of STRICT and build_time AppVeyor: All builds passed 20180421 13:17:30-!- Oebele [~quassel@143.177.58.202] has quit [Remote host closed the connection] 20180421 13:24:37<+discordbot> please backport 20180421 13:25:37<+discordbot> I will later after giving you a chance to test 20180421 13:25:45<+discordbot> I can't test unless you backport 😛 20180421 13:28:25< matthiaskrgr> hm 20180421 13:28:59< matthiaskrgr> when I try to "load" a game and hit"open saves folder" some kind of cli gui starts up?? 20180421 13:29:16< matthiaskrgr> when I close the game that cli gui totally messes up the terminal stdout 20180421 13:30:17<+discordbot> Can you take a screenshot? 20180421 13:30:38< matthiaskrgr> OH 20180421 13:31:11< matthiaskrgr> it launches 20180421 13:31:12< matthiaskrgr> /usr/bin/python -O /usr/bin/ranger /home/matthias/.local/share/wesnoth/1.15/saves 20180421 13:31:16< matthiaskrgr> in the terminal 20180421 13:31:24<+discordbot> in the TERMINAL? 20180421 13:31:27< matthiaskrgr> YES 20180421 13:31:32< matthiaskrgr> but after quitting the game these instances are still running wtf ! 20180421 13:31:36<+discordbot> it's supposed to open it in your file browser! 20180421 13:31:47< matthiaskrgr> WTF 20180421 13:31:54<+discordbot> flails 20180421 13:32:02< matthiaskrgr> I killedall ranger and it launched 10 windows now 20180421 13:32:28<+discordbot> So it's launching this? https://en.wikipedia.org/wiki/Ranger_(file_manager) 20180421 13:32:44<+discordbot> Have you set ranger as your default file manager? 20180421 13:33:06< matthiaskrgr> does it uses some env var? 20180421 13:33:30<+discordbot> Let me check. 20180421 13:34:21< matthiaskrgr> https://imgur.com/a/5o9M5QT 20180421 13:34:21<+discordbot> LOG_DU << "open_object(): on X11, will use xdg-open\n"; const char launcher[] = "xdg-open"; 20180421 13:34:34< matthiaskrgr> first image is asan output after quitting, second one is ranger 20180421 13:34:43<+discordbot> what in all hell 20180421 13:35:32<+discordbot> "xdg-open opens a file or URL in the user's preferred application. If a URL is provided the URL will be opened in the user's preferred web browser. If a file is provided the file will be opened in the preferred application for files of that type. xdg-open supports file, ftp, http and https URLs." 20180421 13:35:48-!- iceiceice [~chris@unaffiliated/iceiceice] has quit [Ping timeout: 268 seconds] 20180421 13:36:32< matthiaskrgr> well "xdg-open ." seems to use ranger here 20180421 13:36:42<+discordbot> I recall that KDE Plasma at least offers a way to set default applications (including file manager) in system settings. I don't know if it uses environment variables or something else uder the hood. 20180421 13:36:44< matthiaskrgr> must be some kind of default setting 20180421 13:48:37-!- iceiceice [~chris@209.133.79.7] has joined #wesnoth-dev 20180421 13:48:37-!- iceiceice [~chris@209.133.79.7] has quit [Changing host] 20180421 13:48:37-!- iceiceice [~chris@unaffiliated/iceiceice] has joined #wesnoth-dev 20180421 13:52:46-!- atarocch [~atarocch@93.56.164.28] has joined #wesnoth-dev 20180421 13:59:45<+discordbot> ok I can't port these damn server changes either way 20180421 13:59:46<+discordbot> what the hell 20180421 14:00:45<+discordbot> agh. it's that line solition added... 20180421 14:00:52<+discordbot> ok, I think I just use all of the incoming block 20180421 14:01:27< irker496> wesnoth: Gunter Labes wesnoth:master 6dd322324966 / src/wesnothd_connection.cpp: Fix debug message https://github.com/wesnoth/wesnoth/commit/6dd32232496678f75f582b785bcb83e8a8d36352 20180421 14:01:29< irker496> wesnoth: Gunter Labes wesnoth:master 616fdf34982b / src/wesnothd_connection.cpp: Detect disconnect when waiting on data from server https://github.com/wesnoth/wesnoth/commit/616fdf34982bd02ff53e20e66287e245269b8145 20180421 14:01:40<+discordbot> @loonycyborg actually, i can't test this at all until someone rebuilds the server on 1.14.. 20180421 14:02:12<+discordbot> hmm I guess 20180421 14:02:17<+discordbot> you could make a config file 20180421 14:02:24<+discordbot> that denies unregistered logins 20180421 14:02:29<+discordbot> in a local wesnothd 20180421 14:03:00<+discordbot> ....and I can't forward-port the keyboard changes 20180421 14:03:46<+discordbot> ah, it's just a utf8 string thing.. 20180421 14:04:25<+discordbot> ok.. 20180421 14:04:35<+discordbot> soliton forward-ported his wesnothd changes 20180421 14:04:42<+discordbot> now I'm forward-porting the keyboard fix 20180421 14:04:51<+discordbot> and then i need to BACKport the wesnothd change... 20180421 14:09:38<+discordbot> rubs eyes 20180421 14:09:58<+discordbot> ok, lemme build 1.14 and master to ensure i resolved this right 20180421 14:10:15<+discordbot> then someone need to rebuild the 1.14 server once i'm done 20180421 14:11:51<+discordbot> and then if this works i need to add changelog entries for both of these bugs 20180421 14:13:24< matthiaskrgr> whats the default timeout limit for players who lose connections to a server? 20180421 14:15:31<+discordbot> I'll backport my commit to 1.14 too, just need to cherrypick rebuild and test 20180421 14:17:36< irker496> wesnoth: loonycyborg wesnoth:1.14 0d33fcccbfd8 / src/server/ (server.cpp server.hpp): wesnothd: always wait for next login attempt after login fail https://github.com/wesnoth/wesnoth/commit/0d33fcccbfd885e6cecd8531238f3230049c2156 20180421 14:18:34<+discordbot> ok, you got to that first.. 20180421 14:18:41 * Soliton starts rebuild. 20180421 14:19:08< irker496> wesnoth: Victor Sergienko wesnoth:master 16cd19873db9 / src/gui/ (4 files in 2 dirs): #2782 Crash when using composing like ˇ and ' in lobby on macOS. https://github.com/wesnoth/wesnoth/commit/16cd19873db9686c54b1c5d3ba2d5a17d431d145 20180421 14:22:50< matthiaskrgr> 15:34 <+discordbot> LOG_DU << "open_object(): on X11, will use xdg-open\n"; const char launcher[] = "xdg-open"; 20180421 14:22:59< matthiaskrgr> why does it try to bail out to xdg-open anyway? 20180421 14:23:21<+discordbot> What else should it use? 20180421 14:23:35< matthiaskrgr> when I got Preferences -> Server Executable the things that pops up already looks like some kind of builtin file browser 20180421 14:24:17<+discordbot> Nah, it's not a full-fledged file browser. 20180421 14:24:25< matthiaskrgr> ok :( 20180421 14:26:22< matthiaskrgr> pf I can't use the builtin thing to open /dev/random... lame! :D 20180421 14:26:59<+discordbot> what would that even do... 20180421 14:27:48< matthiaskrgr> maybe something could overflow while it tries to read the file :) 20180421 14:40:52<+discordbot> I can freeze the game if I open that file in the editor 20180421 14:41:05<+discordbot> probably because it's an infinite file 20180421 14:43:26<+discordbot> The file manager like thing doesn't list (u)random in /dev, but you can open it anyway if you type it 20180421 14:46:42<+discordbot> @Soliton has the server been rebuilt? 20180421 14:51:52< Soliton> yes, also restarted. bug seems fixed now. 20180421 14:55:37<+discordbot> confirmed fix 20180421 14:55:50<+discordbot> @loonycyborg thanks for getting on this right away 👍 20180421 14:56:13<+discordbot> np 20180421 15:09:56<+discordbot> looks like we're clear for release... 20180421 15:09:59<+discordbot> we just need 20180421 15:10:01<+discordbot> SCREENSHOTS 20180421 15:11:19<+discordbot> and of course, the final UtBS portraits, which LB is studiously working on. 20180421 15:12:10<+discordbot> @jyrkive is there anything else you plan to work on between now and wednesday? 20180421 15:13:57<+discordbot> Not in the 1.14 branch. 20180421 15:14:43<+discordbot> alright. I don't think there's really anything else we need get in 20180421 15:14:48<+discordbot> (besides shadowm's PR, of course) 20180421 15:15:18<+discordbot> oh yeah, I was going to fix that tRoW error... 20180421 15:19:40<+discordbot> What were the requirements for screenshots again? 20180421 15:27:16-!- octalot [~steve@178.165.131.224.wireless.dyn.drei.com] has joined #wesnoth-dev 20180421 15:29:09<+discordbot> I believe that somebody posted here steam hardware stats and said that requirement should be Full HD 20180421 15:29:28<+discordbot> 1920x1080 20180421 15:29:44<+discordbot> But better wait for someone to confirm it 20180421 15:30:18<+discordbot> yeah, if it's just taking a few 1080p screenshots, I can get that done pretty quick 20180421 15:30:40<+discordbot> even got a 4K monitor, if anyone wants that 20180421 15:30:41<+discordbot> 😛 20180421 15:31:33<+discordbot> I have retina 2560x1800 but wesnoth runs on 1x resolution 1440x600 😃 20180421 15:42:25-!- gfgtdf [~chatzilla@x4e32b633.dyn.telefonica.de] has quit [Ping timeout: 248 seconds] 20180421 15:44:56-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: So long and thanks for all the fish.] 20180421 16:04:23<+discordbot> the option to only allow registered users in MP games is now pointless, if the server only allows registered users 20180421 16:04:33-!- celmin|sleep is now known as celticminstrel 20180421 16:16:34<+discordbot> that is a good point... 20180421 16:18:08<+discordbot> @Pentarctagon For best results, please provide screenshots in high-res, widescreen format (ideally 1280 x 720 or 1920 x 1080). We ask that any images you upload to the ‘screenshot’ section of your store page should be screenshots that show your game. This means avoiding using concept art, pre-rendered cinematic stills, or images that contain awards, marketing copy, or written product descriptions. Please show customers what 20180421 16:18:09<+discordbot> your game is actually like to play. 20180421 16:18:19<+discordbot> People can run custom servers. 20180421 16:18:55<+discordbot> yes 20180421 16:18:58<+discordbot> that is also a good poin 20180421 16:18:58<+discordbot> t 20180421 16:19:07<+discordbot> i guess it's not worth worrying about 20180421 16:20:08< celticminstrel> We should add {ILLUMINATED} and {DARKENED} macros to the schedules.cfg. 20180421 16:20:26< celticminstrel> Pass them any time schedule and they apply the illuminated effect to them. 20180421 16:20:37< celticminstrel> Might not be possible without API or WML changes though. 20180421 16:21:04< celticminstrel> I think it'd require either [time]image_mods= or key-augmentation in the WML parser. 20180421 16:35:15<+discordbot> ...why 20180421 16:35:19<+discordbot> that seems pointless 20180421 16:35:58<+discordbot> @shadowm will your PR be ready by wednesday? 20180421 16:36:18<+discordbot> Which one of all PRs? 20180421 16:36:48<+discordbot> the wesnothd bans pr 20180421 16:38:05-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev 20180421 16:38:26<+discordbot> Maybe. 20180421 16:38:56<+discordbot> It's all server-side though, except for changes that involve (but do not require) translatable strings that can't go into 1.14.0. 20180421 16:39:17<+discordbot> And which I haven't even written yet since NOBODY is helping me with the decision of how to proceed about them. 20180421 16:39:57<+discordbot> I may as well postpone dealing with that tangent until 1.14.1. 20180421 16:49:17-!- gfgtdf [~chatzilla@x4e32b633.dyn.telefonica.de] has joined #wesnoth-dev 20180421 16:49:32<+discordbot> Which decisions need to be made? 20180421 16:49:50<+discordbot> I posted in the PR earlier. 20180421 16:50:42<+discordbot> Did you commit the latest revision of the steam text, or do I need to? 20180421 16:50:58<+discordbot> the one with the short descrip change and the 60 -> 50 20180421 16:54:39<+discordbot> @Vultraz Give it to me so I can keep running the pot-update at the same time. 20180421 16:54:44<+discordbot> well I'd prefer extending wml protocol. if you add extra attributes old clients will just ignore it 20180421 16:54:54<+discordbot> (Unless you've secretly got the whole toolchain installed.) 20180421 16:55:01<+discordbot> I do not 20180421 16:55:05<+discordbot> @loonycyborg Could you post that in the PR please? 20180421 16:55:32<+discordbot> I want to keep record of all of this in a permanent place, and Discord and IRC are nos uch thing. 20180421 16:55:43<+discordbot> Here is the short description: The Battle for Wesnoth is an open source, turn-based strategy game with a high fantasy theme. Explore the four corners of Irdya in seventeen solo campaigns and dozens of multiplayer maps, taking part in countless adventures as you go. 20180421 16:55:51<+discordbot> Uh, 20180421 16:55:52<+discordbot> stop 20180421 16:55:54<+discordbot> DM me. 20180421 16:56:02<+discordbot> You'll bother people with the long text. 20180421 16:56:06< celticminstrel> Eh, we're including Irdya in the description now? 20180421 16:56:13< celticminstrel> I mean, I guess I don't mind or anything. 20180421 16:56:14<+discordbot> Yes. 20180421 16:57:01< celticminstrel> (When he posted that I kinda just assumed that one paragraph was the entire short description.) 20180421 16:57:13<+discordbot> it is 20180421 16:57:19<+discordbot> the long description is longer 20180421 16:57:34< celticminstrel> Ah, you're posting two descriptions, okay then. 20180421 16:57:56< celticminstrel> BTW, will the Steam version put data in the same place as the non-Steam version? 20180421 16:58:36<+discordbot> No. 20180421 16:58:50<+discordbot> The user profile will be in the same place but the game files will not. 20180421 16:58:59< celticminstrel> The user profile, yes. 20180421 16:59:10< gfgtdf> the the registration requirement a pernamenet thing or do you inted to change it back at some point ? 20180421 17:01:55<+discordbot> hmm... 20180421 17:02:12<+discordbot> what campaigns have good story art 20180421 17:02:18<+discordbot> TRoW 20180421 17:02:20<+discordbot> tried a few, and they don't have any 20180421 17:03:37<+discordbot> I'm not sure if we can use one of those for the steam page 20180421 17:03:41<+discordbot> but we can use it for promo 20180421 17:03:51<+discordbot> (those being a shot of the story art) 20180421 17:04:16<+discordbot> "This means avoiding using concept art, pre-rendered cinematic stills, or images that contain awards, marketing copy, or written product descriptions." 20180421 17:05:20< celticminstrel> You could probably use a shot of story art (in-game) for one of the preview stills, right? 20180421 17:05:32< celticminstrel> Wouldn't want too many of those, only one or maybe two. 20180421 17:05:38<+discordbot> Yes, as long as it's displayed exactly as it is in the game (with the UI and everything). 20180421 17:05:43< celticminstrel> Right, right. 20180421 17:05:54< celticminstrel> That's why I included the parenthetical (in-game). 20180421 17:06:04<+discordbot> gfgtdf: We're probably going to make it permanent as long as there aren't any technical reasons against doing so (no, enabling people to join with alts more easily is not a technical reason). 20180421 17:10:17< gfgtdf> hm ok 20180421 17:11:23< irker496> wesnoth/wesnoth:1.14 Martin Hrubý (hrubymar10) 3352247660 Remove rest of Growl things which I forg AppVeyor: All builds passed 20180421 17:46:00-!- mkdroid [~null@unaffiliated/matthiaskrgr] has joined #wesnoth-dev 20180421 17:49:25-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180421 17:49:42-!- mkdroid [~null@unaffiliated/matthiaskrgr] has quit [Remote host closed the connection] 20180421 17:56:17<+discordbot> How about recommending ubuntu 18.04 instead of 16.04? 20180421 18:22:01< celticminstrel> What exactly is this new "chat persistence"? 20180421 18:22:04< celticminstrel> Jyrki? 20180421 18:22:09< celticminstrel> Is it server-side or client-side? 20180421 18:22:33<+discordbot> Client-side. And chat history is kept only in memory: it's lost when restarting the game. 20180421 18:22:44<+discordbot> @sevu Could you elaborate on why you're suggesting this? 20180421 18:22:49< celticminstrel> Ah, okay. If it was saved to disk I would've suggested adding a preference to disable that. 20180421 18:22:58<+discordbot> Also, can anyone confirm that the minimum requirements for 1.14 are correct? 20180421 18:25:50<+discordbot> https://cdn.discordapp.com/attachments/259976436490829825/437318057225093121/unknown.png 20180421 18:29:11<+discordbot> We're going to recommend Ubuntu 18.04. 20180421 18:29:21<+discordbot> But I still need confirmation on the minimum requirements. 20180421 18:29:30-!- gallaecio [~quassel@188.79.96.255] has quit [Remote host closed the connection] 20180421 18:29:53<+discordbot> The minimum required version does not have to be an LTS version, it's just a reference version that fulfills all the minimum library requirements without crippling the game. 20180421 18:30:24<+discordbot> It's also a reference for deciding whether other distributions are "compatible" (in the loosest sense of the term, since we can't go and list all of them). 20180421 18:30:41<+discordbot> So just focus on confirming if the minimum version requirement for Ubuntu is correct 20180421 18:33:23<+discordbot> (You have until 1 am UTC.) 20180421 18:37:25< vn971> celticminstrel: @jyrkive: I actually thought history survives program restarts. If it doesn't, I should stop calling it "persistence" I guess. 20180421 18:37:45< vn971> EDIT: but it doesn't, so I should probably stop calling it "persistence". 20180421 18:37:53<+discordbot> I found bug in 1.14: You need to players. First player will create game which require any addon for era and start the game. Second player must NOT have this addon installed. He will try join the newly created game and dialog about missing addons appear. He will do nothing yet. First player cancel the game while second player is on missing addon dialog. Second player, after game disappear form lobby click on Cancel and game 20180421 18:37:54<+discordbot> crashes. 20180421 18:37:58<+discordbot> IIRC 14.04 doesn't meet the minimum SDL version, at least. That's why there used to be logic in scons/cmake specifically to get travis past that check. 20180421 18:38:46<+discordbot> How about 16.04 then? 20180421 18:39:11<+discordbot> Can you try reproduce this bug on other platform? 20180421 18:39:39<+discordbot> You can report it, it doesn't sound like the platform is a variable that matters for it. 20180421 18:39:40< vn971> "you"? Your platform is Apple (Mac) ? 20180421 18:40:04<+discordbot> 16.04 is used for all of 1.14's docker images, and all but 1 of master's, so it definitely does. I'm also on Mint 18, which is based on Ubuntu 16.04. 20180421 18:40:09<+discordbot> yes 20180421 18:40:20<+discordbot> vn971 : yes, I am on macOS 20180421 18:41:08<+discordbot> afaik there's also no longer any logic specific to travis to bypass any dependency version checks since I removed them. 20180421 18:41:40<+discordbot> We seriously need to sort out the communication issues regarding this for 1.16. 20180421 18:42:10<+discordbot> Either go back to using a mailing list for announcing and discussing dependency changes, or use the dev forum. 20180421 18:42:59< irker496> wesnoth: Iris Morelle wesmere:master 7fa08da9eb02 / static/docroot/index.php: home: Bump minimum Ubuntu version for 1.14 https://github.com/wesnoth/wesmere/commit/7fa08da9eb021da5395fcf7b79da0209233783f5 20180421 18:44:25< vn971> wait, 1.14 really doesn't allow any guests?! 20180421 18:44:59<+discordbot> https://r.wesnoth.org/t48014 20180421 18:45:09<+discordbot> I don't know if that's what you mean. 20180421 18:45:13< vn971> I'm trying to join with a temporary throw-away nickname and it's not working. 20180421 18:45:23<+discordbot> Yeah, you can't do that. 20180421 18:47:45< vn971> @shadowm ouch. Did this change have any underlying discussion? 20180421 18:49:01< vn971> For example, I don't really see the benefits in this, but I see considerable pain during some kinds of testing. 20180421 18:49:20<+discordbot> It's a moderation issue first and foremost. 20180421 18:49:47<+discordbot> But yes, it's been discussed. In several opportunities, I might add. 20180421 18:49:58< Soliton> you can test on server2 or 3 or your own instance. 20180421 18:49:59< vn971> Also "only registered users" checkbox in game creation dialog becomes an almost redundant option, that should probably even be removed then to avoid confusion. 20180421 18:50:32< Soliton> there's more than one server. 20180421 18:51:01< celticminstrel> Yeah, we can't really remove that, I'd say. 20180421 18:51:06< vn971> Soliton: well yes, that's true. Still sad if there were moderation issues that needed these changes. I'd read more about it. If anybody has a link nearby, please share. 20180421 18:51:18< celticminstrel> But if the server itself only allows registered users, we should have it checked and disabled. 20180421 18:51:35< vn971> celticminstrel: why not hide? 20180421 18:51:38<+discordbot> There isn't a link because it's a moderation issue and we don't discuss those in public. 20180421 18:51:39< vn971> * maybe hide? 20180421 18:51:44< celticminstrel> I suppose that could work too. 20180421 18:51:47< gfgtdf> ye hiding makes more sense to me. 20180421 18:51:55< gfgtdf> ideally we'd let the server decide whether this is supoported or not. 20180421 18:52:16< gfgtdf> that is on server join the server telly you whether such an option makes sense. 20180421 18:52:46< celticminstrel> That's a problem, yeah; unless the server already does this in some form, we can't really hide it for 1.14. 20180421 18:53:04< Soliton> it does not so far. 20180421 18:53:50< celticminstrel> Well, a quick-and-dirty workaround would be to hide it if you're connecting to the official server, or to include something in the server definitions in the WML about whether the server allows it... 20180421 18:53:52< gfgtdf> this is not the type of feature that cannot be added in 1.14.1 i'd say, as long as communication to older versiosn still works flwlessly. 20180421 18:54:49< gfgtdf> currently there are no server known where 'only registered users' makes esne afaik? Onbly one server actualol supports registed users and on that all users must be registered. 20180421 18:54:50< celticminstrel> Unless the multiplayer server definitions count as part of the API? They are part of the full game config, but I don't think they're documented. 20180421 18:54:59< gfgtdf> sense* 20180421 18:55:35< celticminstrel> FTR I'm talking about this: https://github.com/wesnoth/wesnoth/blob/master/data/game_config.cfg#L3 20180421 18:55:51< celticminstrel> You could add an allow_anon=no to the first one, for example (and have the client take that into account). 20180421 18:56:09< vn971> gfgtdf: we can probably remove the option for 1.14 though right? 20180421 18:56:11< celticminstrel> But only if that doesn't count as exposed API. 20180421 18:56:20< celticminstrel> vn971: ??? 20180421 18:56:32<+discordbot> The problem with this idea is that server.wesnoth.org:15000 redirects you to 144.76.5.6:14999. 20180421 18:56:48< vn971> celticminstrel: I don't like dead options TBH.. 20180421 18:56:50<+discordbot> It could also redirect you to 127.0.0.1:14420 or whatever else we needed. 20180421 18:56:58< celticminstrel> It's not strictly a dead option though. 20180421 18:57:09<+discordbot> (And yes, 144.76.5.6 is server.wesnoth.org but that's not something you can trivially find out.) 20180421 18:57:14< celticminstrel> It's meaningless only if the server you chose to connect to requires registration. 20180421 18:57:18< irker496> wesnoth: gfgtdf wesnoth:1.14 c510340ed22f / src/tod_manager.cpp: fix segfault on area= filter. https://github.com/wesnoth/wesnoth/commit/c510340ed22f3d4acc15d89808c0309e85e8f062 20180421 18:57:28< celticminstrel> o.o 20180421 18:57:31< vn971> celticminstrel: yes, I know that. I'd still vote for permanent hiding or removal if I'd have to choose betreen always-present and always-hidden. 20180421 18:57:57< gfgtdf> it's also meaningless if the server doesn't support registered users. 20180421 18:58:08< celticminstrel> True. 20180421 18:58:14< vn971> @shadowm getent hosts server.wesnoth.org :P 20180421 18:58:26<+discordbot> In C++. 20180421 18:58:30< celticminstrel> BTW I think there should probably be some sort of basic_user_handler which only accepts users from a whitelist. 20180421 18:58:41<+discordbot> Without introducing weird dependencies. 20180421 18:59:10<+discordbot> Patches welcome celmin. 20180421 18:59:21< celticminstrel> Yeah I was considering it. 20180421 18:59:53< gfgtdf> celticminstrel: yes that's why i suggested letting the server decide whether to show that option or not. 20180421 19:00:03<+discordbot> sample_user_handler (which got removed in master) is kind of useful as a starting point if you need one. 20180421 19:00:29< celticminstrel> 'kay 20180421 19:00:43<+discordbot> I'll also clarify that the user handler code did not change for this. 20180421 19:00:58<+discordbot> The deny_unregistered_logins option has been around for several stable series. 20180421 19:01:07< celticminstrel> And has nothing to do with the user handler, right? 20180421 19:01:23< vn971> I've raised an issue meanwhile: https://github.com/wesnoth/wesnoth/issues/2939 20180421 19:01:33<+discordbot> No, the user handler is just an information provider. 20180421 19:10:52< irker496> wesnoth/wesnoth:1.14 Martin Hrubý 7907ce9870 Fix for #2782 AppVeyor: All builds passed 20180421 19:48:10< celticminstrel> BTW gfgtdf, forward-port for c510340ed22f? 20180421 19:48:26< gfgtdf> celticminstrel: ye will do 20180421 20:09:46-!- gallaecio [~quassel@188.79.96.255] has joined #wesnoth-dev 20180421 20:24:35-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!] 20180421 20:25:03-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180421 20:34:43< grzywacz> heh, nice bug in 1.12 - the whole map gets fogged for me when it's not my turn... 20180421 20:35:22< celticminstrel> Meh! 20180421 20:35:46< grzywacz> Meh indeed. 20180421 20:35:51< grzywacz> But surprising. 20180421 20:36:14< gfgtdf> still not as good as the "an evil Kalenz appears and starts recruiting drakes" bug. 20180421 20:37:49< celticminstrel> XD 20180421 20:41:34< grzywacz> (wat) 20180421 20:45:27< octalot> grzywacz: Legend of Wesmere's multiplayer version lets you start on any of the 5 chapters, it has code to reload from a previous chapter, if you played that chapte 20180421 20:46:10< octalot> and that code has bugs. Less bugs in 1.13.13 than it did in 1.13.11 ... 20180421 20:50:20< gfgtdf> and the 'random faction' meachnics might make him recruit drakes. that bug was actually in 1.12.4 iirc. 20180421 21:00:26-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev 20180421 21:01:37<+discordbot> 20180421 23:00:44 error general: Something is wrong with the addon version check database supporting the multiplayer lobby. Please report this at http://bugs.wesnoth.org. 20180421 21:01:51<+discordbot> is this database down? 20180421 21:04:55< irker496> wesnoth/wesnoth:1.14 loonycyborg 0d33fcccbf wesnothd: always wait for next login att AppVeyor: All builds passed 20180421 21:06:12< gfgtdf> which game did you intent to join , and what era/mods did it have ? 20180421 21:08:48< gfgtdf> hrubymar10: ^ 20180421 21:09:32<+discordbot> It looks that problem was on my side, after restarting game problem dissapeared 20180421 21:10:20<+discordbot> but if you find it useful, I can answer you 20180421 21:11:51< gfgtdf> and you tried to join the same game ? 20180421 21:12:25< gfgtdf> hmm but thats less likely actually. ftr, this message probably means that that game uses an era/mod and doesnt tell to which addons iot belogs, if one for exampel would add another era directly to the main game files other people woudl probably get that error. 20180421 21:12:56<+discordbot> I tried reproduce https://github.com/wesnoth/wesnoth/issues/2938 in debugger 20180421 21:13:15<+discordbot> I created game with 'Heroes' era addon 20180421 21:13:50<+discordbot> and then I tried connect to it from second client on the same machine. 20180421 21:14:06<+discordbot> And this second client showed me the error 20180421 21:15:02< gfgtdf> hmm no idea what coudl have caused it then 20180421 21:15:37<+discordbot> btw, can you try reproduce this error on your platform? linux? 20180421 21:15:59<+discordbot> I can create game with era addon on official server for you 20180421 21:16:39< gfgtdf> i use windows. 20180421 21:16:54<+discordbot> Yes, also good. Can you try it? 20180421 21:17:17< gfgtdf> so which error? but even if ii coudl, i'm using official wondows 1.13.14 release so i dont get any useful debug information out of it 20180421 21:17:33< gfgtdf> i'm on the server my nick is '444' 20180421 21:17:40<+discordbot> I just want to know, if it crashes 20180421 21:17:48< gfgtdf> (that's easy to type) 20180421 21:18:11<+discordbot> I'll create game named test. It should show you, that some addons are missing 20180421 21:18:20< gfgtdf> ok 20180421 21:18:32<+discordbot> don't do anything and lmk here that you see that message 20180421 21:18:46<+discordbot> I'll cancel the game and then I'll tell you 20180421 21:18:58<+discordbot> and you will click on cancel button 20180421 21:18:58< gfgtdf> i dont see any open games 20180421 21:19:07<+discordbot> this should make wesnoth crash 20180421 21:19:14<+discordbot> I'll create it now 20180421 21:20:11<+discordbot> game is up 20180421 21:20:19< gfgtdf> ok im in the 'your version of heroes is outdated' dialog 20180421 21:20:33<+discordbot> ok, now I'll cancel that game 20180421 21:20:44<+discordbot> and now you click on cancel button 20180421 21:20:57< gfgtdf> ye i get a crash 20180421 21:20:59<+discordbot> does game crash? 20180421 21:21:13<+discordbot> welp, it is cross platform problem 20180421 21:21:21<+discordbot> thank you gfgtdf for help 20180421 21:21:29< gfgtdf> well ye that was rather likeley. 20180421 21:22:15<+discordbot> It should be the default assumption with code that doesn't interact directly with the platform, yeah. 20180421 21:23:03<+discordbot> problem is, that when it crash, debugger doesn't show me anything useful 😦 20180421 21:24:27<+discordbot> oh, now it does 😄 20180421 21:24:45<+discordbot> another assert error 🤔 20180421 21:24:57-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 263 seconds] 20180421 21:24:57<+discordbot> Assertion failed: (mouse_focus_), function capture_mouse, file /wesnoth_1.14/src/gui/core/event/distributor.cpp, line 153. 20180421 21:30:42< gfgtdf> i you want a fast fix your best bet is probably disabling procreccisng network data while that dependency dialog is open. 20180421 21:33:48<+discordbot> I want sleep now, but if you want do that, it would be good. Also you can repost that inside issue conversation 20180421 21:40:39-!- gallaecio [~quassel@188.79.96.255] has quit [Remote host closed the connection] 20180421 21:56:04-!- grzywacz [~karol@89-70-226-147.dynamic.chello.pl] has quit [Ping timeout: 260 seconds] 20180421 22:01:29-!- Spiffyoz [~mofikf@180.245.138.74] has joined #wesnoth-dev 20180421 22:06:57-!- aeth [~Michael@wesnoth/umc-dev/developer/aethaeryn] has quit [Ping timeout: 264 seconds] 20180421 22:08:18-!- aeth [~Michael@wesnoth/umc-dev/developer/aethaeryn] has joined #wesnoth-dev 20180421 22:08:39-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20180421 22:10:03-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180421 22:21:55-!- Spiffyoz [~mofikf@180.245.138.74] has quit [Remote host closed the connection] 20180421 22:41:30-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20180421 22:47:30-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection] 20180421 23:15:09< irker496> wesnoth/wesnoth:master Victor Sergienko 16cd19873d #2782 Crash when using composing like ˇ AppVeyor: All builds passed 20180421 23:52:32-!- octalot [~steve@178.165.131.224.wireless.dyn.drei.com] has quit [] --- Log closed Sun Apr 22 00:00:42 2018