--- Log opened Sun Apr 22 00:00:42 2018 20180422 00:51:52< irker496> wesnoth: pentarctagon wesnoth:master 5b94101975ab / CMakeLists.txt utils/travis/docker_run.sh: Allow specifying a sanitizer with cmake. https://github.com/wesnoth/wesnoth/commit/5b94101975abd1ab81cc79bc18710478129446af 20180422 00:52:10< irker496> wesnoth/wesnoth:1.14 newfrenchy83 ef897725a8 Update wesnothd.cbp AppVeyor: All builds passed 20180422 01:18:29< gfgtdf> vultraz: can't this https://github.com/wesnoth/wesnoth/blob/1.13.14/data/gui/window/game_stats.cfg#L12 be simply replaced by a vertical_alignment=top 20180422 01:19:57< gfgtdf> in the containg columns i mean 20180422 01:22:42<+discordbot> hmmmmmmmmmmm 20180422 01:22:45<+discordbot> i was thinking that 20180422 01:23:57< gfgtdf> if yes, it'd be nice to have it in 1.14 since that hack is not really translation friendly. 20180422 01:25:00< gfgtdf> hm ok i see why it's there 20180422 01:25:18<+discordbot> let me take a look 20180422 01:26:04< gfgtdf> ok seems like it doesnt work liek that sicne that newline is there to keep those two tabs in sync. 20180422 01:26:18< gfgtdf> still it'd be nice to have anothers solution. 20180422 01:27:21< gfgtdf> vultraz: maybe we coudl put an extra one-cell grid in [header] to keep thise heights in sync? 20180422 01:29:38<+discordbot> honestly, I probably cared too much about keeping them vertically synced. 20180422 01:31:04< gfgtdf> hmm putting them into a nested grid doesn't work eigher 20180422 01:31:11<+discordbot> I'll deal with it today. 20180422 01:32:05< gfgtdf> ok thx 20180422 01:42:42-!- gfgtdf_ [~chatzilla@x4e32b3d7.dyn.telefonica.de] has joined #wesnoth-dev 20180422 01:44:44-!- gfgtdf [~chatzilla@x4e32b633.dyn.telefonica.de] has quit [Ping timeout: 260 seconds] 20180422 01:44:51-!- gfgtdf_ is now known as gfgtdf 20180422 01:53:12-!- gfgtdf [~chatzilla@x4e32b3d7.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.93 [Firefox 52.7.3/20180322140748]] 20180422 02:28:32-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180422 02:28:39-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180422 02:44:34-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180422 02:44:43-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180422 03:41:21-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180422 03:41:28-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180422 03:47:57< irker496> wesnoth/wesnoth:1.14 gfgtdf c510340ed2 fix segfault on area= filter. AppVeyor: All builds passed 20180422 04:56:49-!- celticminstrel is now known as celmin|sleep 20180422 05:26:02-!- gallaecio [~quassel@188.79.96.255] has joined #wesnoth-dev 20180422 05:35:58-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev 20180422 05:48:21-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20180422 05:51:07-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection] 20180422 06:19:19< irker496> wesnoth: Iris Morelle steam-meta:master b4b700e990e9 / CONTRIBUTING.md README.md: Update or add documentation for contributors https://github.com/wesnoth/steam-meta/commit/b4b700e990e989c58e4b422f1acf146562b16e00 20180422 06:24:01-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180422 07:08:45< irker496> wesnoth/wesnoth:master pentarctagon 5b94101975 Allow specifying a sanitizer with cmake. AppVeyor: All builds passed 20180422 07:16:46-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180422 07:16:57-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180422 07:21:25< irker496> wesnoth: Nils Kneuper wesnoth:1.14 cc3fc3f97b6a / po/ (wesnoth-lib/cs.po wesnoth/cs.po): updated Czech translation https://github.com/wesnoth/wesnoth/commit/cc3fc3f97b6a398b14c05c55bf5e75186b79151d 20180422 07:21:32< irker496> wesnoth: Nils Kneuper wesnoth:master 25e3526a1f30 / po/ (wesnoth-lib/cs.po wesnoth/cs.po): updated Czech translation https://github.com/wesnoth/wesnoth/commit/25e3526a1f30cd88367359154cd5494f4ced7fa5 20180422 08:06:11-!- Oebele [~quassel@143.177.58.202] has joined #wesnoth-dev 20180422 08:21:07-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20180422 08:22:08-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180422 08:26:33-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20180422 08:29:37-!- grzywacz [~karol@89-70-226-147.dynamic.chello.pl] has joined #wesnoth-dev 20180422 08:31:57-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180422 08:34:11-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20180422 08:35:56-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180422 09:55:53<+discordbot> Uhhhh. That PR. 20180422 09:56:25<+discordbot> Could you close it? It's too late to be making changes like that to 1.14 now. 20180422 09:56:41<+discordbot> I'll leave it to someone else. Ideally someone who speaks French. 20180422 09:57:03<+discordbot> Although that's probably a pipe dream since we've not had French-speaking devs in almost 9 years. 20180422 09:58:00<+discordbot> In that case... 20180422 10:12:26<+discordbot> I think the only French speaker we have around is LordBob 🤔 20180422 10:12:51<+discordbot> I am nowhere near proficient to fluently communicate 😛 20180422 10:14:03<+discordbot> sadly, likewise with Japanese... 20180422 10:23:46-!- irker496 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout] 20180422 10:50:24<+discordbot> i'm french 👋 20180422 11:17:01< matthiaskrgr> is wesnoth c++14 ? 20180422 11:18:55< matthiaskrgr> ah yes 20180422 12:05:03-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20180422 12:06:46-!- travis-ci [~travis-ci@ec2-54-92-138-3.compute-1.amazonaws.com] has joined #wesnoth-dev 20180422 12:06:47< travis-ci> matthiaskrgr/wesnoth#12 (master - 25e3526 : Nils Kneuper): The build was fixed. 20180422 12:06:47< travis-ci> Build details : https://travis-ci.org/matthiaskrgr/wesnoth/builds/369717260 20180422 12:06:49-!- travis-ci [~travis-ci@ec2-54-92-138-3.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180422 12:13:26-!- travis-ci [~travis-ci@ec2-54-162-211-136.compute-1.amazonaws.com] has joined #wesnoth-dev 20180422 12:13:27< travis-ci> matthiaskrgr/wesnoth#13 (san_optim - 0de7b90 : Matthias Krüger): The build passed. 20180422 12:13:27< travis-ci> Build details : https://travis-ci.org/matthiaskrgr/wesnoth/builds/369718574 20180422 12:13:27-!- travis-ci [~travis-ci@ec2-54-162-211-136.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180422 12:19:49-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180422 13:05:53<+discordbot> huh. well this is something I didn't know. apparently T foo and T(foo) are identical? 20180422 13:06:03<+discordbot> That is... quite confusing 20180422 13:06:49<+discordbot> No, they're not identical. 20180422 13:07:17<+discordbot> T foo creates (or declares) a variable of type T, called foo. 20180422 13:07:53<+discordbot> T(foo) is, by default, a function declaration. A function called T that takes a parameter of type foo. 20180422 13:08:35<+discordbot> Another possible interpretation is that T(foo) is an expression which creates an object of type T and passes foo to its constructor. 20180422 13:09:06<+discordbot> Then I'm misunderstanding what they're talking about here? https://youtu.be/3MB2iiCkGxg?t=30m57s 🤔 20180422 13:13:46<+discordbot> I mean, I guess since they're talking about it in the context of a function body, it's not going to be a function declaration? 20180422 13:14:46<+discordbot> but if T(foo) is indeed valid for declaring a variable named foo of type T, how does the compiler know you don't want T(foo), the ctor call? Is that why T{foo} exists? 20180422 13:15:39<+discordbot> ...I had no idea that it's possible to create variables like that, but I can verify it. 20180422 13:15:40<+discordbot> https://godbolt.org/g/dM3LPn 20180422 13:17:45<+discordbot> Regarding the conflict between this syntax and the constructor call, I think the difference is that if you're calling the constructor of something, the content of the parenthesis must be a valid expression (such as an already existing variable). 20180422 13:18:53<+discordbot> But if that's true, then simply mistyping the variable name will create a new variable instead of causing a compiler error... 😱 20180422 13:21:31<+discordbot> Except... the bug they're discussing is a use of unique_lock(foo) wherein foo is a mutex object elsewhere, and he says that doesn't lock because it just creates a new variable that shadows the original mutex. But the unique_lock ctor DOES take a mutex argument. So it seems the compiler will default to declaration and not ctor call in this case. 20180422 13:21:48<+discordbot> Once again seeing why {} is useful here... 20180422 13:23:41<+discordbot> though... what would actually happen if you had a nameless variable like that - that is, by forcing the ctor call with unique_lock{foo}? Is that even valid? Or is it immediately destroyed 20180422 13:25:22<+discordbot> Yes, an expression that creates an unnamed variable is allowed. 20180422 13:25:37<+discordbot> Useful for things like threads or locks. 20180422 13:26:15-!- midzer_ [~quassel@p5B051DAC.dip0.t-ipconnect.de] has joined #wesnoth-dev 20180422 13:26:35-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20180422 13:27:06<+discordbot> I really have to wonder why the standard even allows T(foo) to be a declaration. 😐 It seems like can cause all kinds of confusing bugs. 20180422 13:27:08-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180422 13:28:05<+discordbot> As a function declaration the syntax makes sense (especially because it was inherited from C), but not really as a variable declaration. 20180422 13:28:29<+discordbot> Yeah, definitely not as variable declaration... 20180422 13:29:00-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20180422 13:29:10-!- midzer_ is now known as midzer 20180422 13:29:36-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180422 13:30:05-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20180422 13:30:42-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180422 13:31:11-!- irker856 [~irker@uruz.ai0867.net] has joined #wesnoth-dev 20180422 13:31:11< irker856> wesnoth: Martin Hrubý (hrubymar10) steam-meta:Czech-translation 1aa353334850 / po/cs.po: Synced with origin/master https://github.com/wesnoth/steam-meta/commit/1aa353334850bcf7139d8fccde5c8f94e60c58cd 20180422 13:31:32-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20180422 13:32:50-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180422 13:33:45< irker856> wesnoth: Iris Morelle steam-meta:Czech-translation 0e2ce0e7a791 / / (54 files in 2 dirs): Update metadata strings and Spanish translation https://github.com/wesnoth/steam-meta/commit/0e2ce0e7a791b467da30e03cc514c1aa651d8415 20180422 13:33:46< irker856> wesnoth: Iris Morelle steam-meta:Czech-translation 8476e815e107 / / (54 files in 2 dirs): Bump minimum/recommended Ubuntu version, update Spanish translation https://github.com/wesnoth/steam-meta/commit/8476e815e107ae4580eb038732f4b5e6a87df3c4 20180422 13:33:49< irker856> wesnoth: Iris Morelle steam-meta:Czech-translation b4b700e990e9 / CONTRIBUTING.md README.md: Update or add documentation for contributors https://github.com/wesnoth/steam-meta/commit/b4b700e990e989c58e4b422f1acf146562b16e00 20180422 13:33:51< irker856> wesnoth: Martin Hrubý steam-meta:Czech-translation 45b7b035569b / / (55 files in 2 dirs): Merge branch 'master' into Czech-translation https://github.com/wesnoth/steam-meta/commit/45b7b035569bb4a0f65cbb54cb9926bcb18a2c26 20180422 13:36:29< celmin|sleep> I imaging functions (and arrays and pointers) are the reason that's allowed. 20180422 13:37:08< celmin|sleep> In certain cases you need parentheses around the variable name; function pointers are the most obvious case. 20180422 13:54:29-!- celmin|sleep is now known as celticminstrel 20180422 14:02:42< celticminstrel> I think maybe we should add reduce_formula to filters as a complement to filter. 20180422 14:02:54< celticminstrel> ^as a complement to formula 20180422 14:03:10< celticminstrel> The formula= key takes the first unit for which the formula returns 1 (true). 20180422 14:03:30< celticminstrel> A reduce_formula= key would take the first unit for which the formula returns a minimal value. 20180422 14:03:44< celticminstrel> (Which means it must test all the units, so it's a little less efficient.) 20180422 14:10:20< irker856> wesnoth/wesnoth:1.14 Nils Kneuper cc3fc3f97b updated Czech translation AppVeyor: All builds passed 20180422 14:24:02<+discordbot> that isn't a very descriptive key 20180422 14:27:27< celticminstrel> How is it not very descriptive? 20180422 14:28:13< celticminstrel> It's a formula for a reduce operation on the set of units. 20180422 14:28:19< zookeeper> that functionality can't be implemented as a WFL function or something that's used _in_ formula=? 20180422 14:28:36< celticminstrel> Although maybe reduce isn't quite the best term, not sure... 20180422 14:29:38< celticminstrel> zookeeper: You can't do this in formula= because that only returns a boolean whether it matches or not; you need to be able to compare the units against each other for this kind of thing. 20180422 14:30:07< zookeeper> right, okay. 20180422 14:30:19< celticminstrel> @Vultraz - I'd be fine with renaming it though, eg minimum_formula or minimal_formula something. 20180422 14:30:23< zookeeper> so why do you think we should add a reduce_formula=? 20180422 14:30:44< celticminstrel> zookeeper: It is possible to do this in FormulaAI with the reduce() function but that's because FormulaAI exposes the whole unit list as a formula variable. 20180422 14:31:21< celticminstrel> And about why we should add it... because I think it would be useful? I could use it in my campaign to pick the unit with the best moves on cave terrain. 20180422 14:33:03< zookeeper> surely you can easily (?) do that with a lua function? 20180422 14:33:09< zookeeper> or something 20180422 14:33:22< celticminstrel> Yes. 20180422 14:33:31< celticminstrel> But IMO WFL is more convenient than a Lua function. 20180422 14:35:50< zookeeper> sure. but as always, is a rare advanced niche usecase that can already be solved without ugly hacks enough justification for adding an engine-side feature? 20180422 14:36:21< celticminstrel> I'm not sure it's really as rare or niche as you think... 20180422 14:37:10< celticminstrel> It's not possible to do this at all with a filter (the Lue function I wrote works by assigning a role to the best unit). 20180422 14:37:24< celticminstrel> It may be a little advanced, I suppose. 20180422 14:38:40< Ravana_> easy way to sort units array could be useful 20180422 14:39:06< zookeeper> well filters have lua_function=, that's what i was thinking about. have a function check whether there are units with a lower movement cost on cave than the currently considered unit? 20180422 14:39:33< celticminstrel> Doing this with lua_function would be an ugly hack, I think. 20180422 14:39:47< celticminstrel> Plus I kinda think lua_function is ugly in itself. 20180422 14:40:21< Ravana_> lua_function would have to work with anonymous function to not be ugly 20180422 14:40:31< celticminstrel> The reason you can't use formula= for this also applies to lua_function= 20180422 14:40:44< celticminstrel> And yes Ravana_. 20180422 14:41:26< celticminstrel> But gfgtdf insists that we can't do that because it would be too slow, or something? I don't recall the exact argument. 20180422 14:58:16< irker856> wesnoth: Martin Hrubý (hrubymar10) steam-meta:Czech-translation 5763beec247c / po/cs.po: Some more corrections https://github.com/wesnoth/steam-meta/commit/5763beec247cb28adece2a7cb920f62cb2547279 20180422 14:59:06-!- gfgtdf [~chatzilla@x4e32b3d7.dyn.telefonica.de] has joined #wesnoth-dev 20180422 15:00:22< gfgtdf> well yes compiling things is slower that looking it up in global namespace, but it shodul be possible to support both, if the value befing with function( compile it otherwise do a simple stirng lookup. 20180422 15:01:43< gfgtdf> begins* 20180422 15:22:49< celticminstrel> gfgtdf: While this is possible, I'm not sure I'd call it ideal? IMO it makes more sense for the contents of lua_function to be just a function body, not an expression evaluating to a function. 20180422 15:23:02< celticminstrel> Though that's not compatible with its current form... 20180422 15:51:21-!- aidanhs2 [~aidanhs@81.4.110.234] has joined #wesnoth-dev 20180422 15:59:46-!- Netsplit *.net <-> *.split quits: aidanhs1 20180422 16:24:30< irker856> wesnoth/wesnoth:master Nils Kneuper 25e3526a1f updated Czech translation AppVeyor: All builds passed 20180422 16:28:57-!- gfgtdf [~chatzilla@x4e32b3d7.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.93 [Firefox 52.7.3/20180322140748]] 20180422 16:29:15-!- syrma[m] [syrmamatri@gateway/shell/matrix.org/x-qpidorhgqfsdptck] has quit [Ping timeout: 255 seconds] 20180422 16:29:22-!- madmax28 [madmax28ma@gateway/shell/matrix.org/x-btxdgmivdhidepoe] has quit [Ping timeout: 240 seconds] 20180422 16:29:28-!- ChipmunkV[m] [chipmunkvm@gateway/shell/matrix.org/x-qazpnovytdoqjlhd] has quit [Ping timeout: 246 seconds] 20180422 16:29:37-!- Kawa[m] [kawamatrix@gateway/shell/matrix.org/x-nxgxtcdyufuqnizh] has quit [Ping timeout: 276 seconds] 20180422 16:39:10-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev 20180422 16:42:39<+discordbot> @hrubymar10 How on earth did you manage to push that branch there 20180422 16:42:59<+discordbot> Oh. I gave Write to the developers team. 20180422 16:43:16<+discordbot> To where? O.o 20180422 16:43:21<+discordbot> I was pretty sure I created a repository recently restricted to website staff. 20180422 16:43:26<+discordbot> wesnoth/steam-meta 20180422 16:43:52<+discordbot> Oh, yes, because I am part of members team in wesnoth org. 20180422 16:44:05<+discordbot> Developers team. 20180422 16:44:07<+discordbot> But I created PR as you requested 20180422 16:55:41-!- octalot [~steve@91.141.1.142.wireless.dyn.drei.com] has joined #wesnoth-dev 20180422 17:03:25< irker856> wesnoth: Martin Hrubý (hrubymar10) steam-meta:master 21225ad38d1a / po/cs.po: Added Czech translation https://github.com/wesnoth/steam-meta/commit/21225ad38d1a2186485d1f0b5d1100e7c638c451 20180422 17:06:20-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev 20180422 17:10:30<+discordbot> Thank you 20180422 17:18:08-!- gfg [~androirc@tmo-102-99.customers.d1-online.com] has joined #wesnoth-dev 20180422 17:58:08-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180422 17:58:15-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180422 18:02:36< irker856> wesnoth/wesnoth:master Matthias Krüger 7e209217c1 cmake: if sanitizers are enabled, also a AppVeyor: All builds passed 20180422 18:05:48< octalot> I'm adding translation hints on the wiki for SotA. Any objections to "[a certain book] is the book of necromancy in the Descent Into Darkness campaign, so the text should match. However SotA has far more context for the text than DiD, so it might be better to translate SotA and then copy the text to DiD."? 20180422 18:06:29< octalot> (other than the objection that it's too late for 1.14) 20180422 18:11:32<+discordbot> Adding # po: (WML) or // TRANSLATORS: (C++) hints doesn't break the string freeze. 20180422 18:11:57<+discordbot> So it's never too late for those. 20180422 18:14:20< octalot> :) 20180422 18:22:25< irker856> wesnoth: Celtic Minstrel wesnoth:1.14 8bd85636f1da / data/english.cfg: Add translation hints for the village and terrain feature name generators https://github.com/wesnoth/wesnoth/commit/8bd85636f1da050fdf637eab3018162699010555 20180422 18:23:27< irker856> wesnoth: Celtic Minstrel wesnoth:master 59e734615dab / data/english.cfg: Add translation hints for the village and terrain feature name generators https://github.com/wesnoth/wesnoth/commit/59e734615dab3920c8eb993169f0fbba697d6621 20180422 18:37:59< irker856> wesnoth: Severin Glöckner wesnoth:master 3456b0a9cb0e / data/campaigns/tutorial/scenarios/02_Tutorial_part_2.cfg: Tutorial: remove forgotten bracket and superfluous space https://github.com/wesnoth/wesnoth/commit/3456b0a9cb0ebc863b1307652ffc5ffb065ca231 20180422 18:40:16< celticminstrel> gfg: I was under the impression that you were allowed to set multiple special locations on the same space? 20180422 18:40:33< celticminstrel> It doesn't seem to be working for me (with one numeric location and one string location). 20180422 18:41:12< gfg> hmm ye i assumed that'd work 20180422 18:41:30< gfg> Does it work if you edit the map file by hand? 20180422 18:41:45< celticminstrel> That's what I'm doing (the editor seems to only allow one on a given space). 20180422 18:41:58< gfg> Meaning: is it only an Editor Problem? 20180422 18:42:07< gfg> ah ok 20180422 18:42:31< celticminstrel> Doesn't seem to work for two string locations either, so not related to it being a numeric location. 20180422 18:43:03< celticminstrel> I guess for now I should just edit the wiki to label that a 1.15 feature...? 20180422 18:43:03< gfg> then we can still fix it in 1.14.1 since the but is notpart of the wml api 20180422 18:43:27< celticminstrel> Well, I'd consider the map format to be part of the WML API... 20180422 18:43:51< gfg> yes i thought you said it work if you edit them by hand? 20180422 18:44:06< gfg> The game loading you map i meant 20180422 18:44:20< celticminstrel> No, I said I was editing by hand, because the editor apparently overwrites an existing location whenever you place one. 20180422 18:44:32< celticminstrel> So the editor won't even let you do it, so I tried editing the map by hand and it complained. 20180422 18:44:44< celticminstrel> It's parsing all but the first location as part of the terrain string. 20180422 18:45:18< celticminstrel> So I think we probably can't fix this for 1.14. It would mean people who forgot to update to the latest 1.14.x would get errors on new maps using the feature. 20180422 18:45:22< gfg> ok but if you edit by hand and load it in the game (not the editor (, does it work? 20180422 18:45:31< celticminstrel> No, it does not work. That's what I said. 20180422 18:45:43< celticminstrel> I edited the map by hand and it did not work. 20180422 18:46:51< gfg> hmm ok 20180422 18:49:52< gfg> ye looking at the code confirmed that it won't work 20180422 18:51:16< gfg> We cannot fix it for 1.14 then 20180422 18:53:39< celticminstrel> Huh, I thought there was a Great Ogre unit now in core? Was it only added to the campaign? 20180422 19:28:04-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180422 19:28:10-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180422 19:34:59-!- syrma[m] [syrmamatri@gateway/shell/matrix.org/x-llsnzghhjhegiqro] has joined #wesnoth-dev 20180422 19:50:15< celticminstrel> Is it possible to share vision with an enemy? 20180422 19:50:27< celticminstrel> gfg, do you have any idea? 20180422 19:51:47< irker856> wesnoth: Steve Cotton wesnoth:1.14 2afdcad4e50c / data/campaigns/tutorial/scenarios/01_Tutorial_part_1.cfg: Tutorial: fix the overall translation hint comment https://github.com/wesnoth/wesnoth/commit/2afdcad4e50c61017ee2c68b0fa09d226a618c51 20180422 19:52:48< irker856> wesnoth: Steve Cotton wesnoth:master eab86c30163e / data/campaigns/tutorial/scenarios/01_Tutorial_part_1.cfg: Tutorial: fix the overall translation hint comment https://github.com/wesnoth/wesnoth/commit/eab86c30163e2a2364d0abc9683cf4864fb3328b 20180422 19:52:54< gfg> It's not possible directly, you cold for example use store_locations + filter_vision + clear shroud 20180422 19:53:50< celticminstrel> When is fog recalculated for a side? If I alter the side's fog at the end of their turn, will it stay altered until the beginning of their next turn? 20180422 19:54:04< celticminstrel> (Without using multiturn fog overrides or whatever that's called.) 20180422 19:57:12< celticminstrel> According to the wiki it's calculated when the side ends their turn. 20180422 19:57:45< celticminstrel> Now I just need to know whether it's before or after the side turn end event... 20180422 20:01:21-!- ChipmunkV[m] [chipmunkvm@gateway/shell/matrix.org/x-vfpbpcukvrdueuan] has joined #wesnoth-dev 20180422 20:01:21-!- Kawa[m] [kawamatrix@gateway/shell/matrix.org/x-pgfmiuvgtqxrzjih] has joined #wesnoth-dev 20180422 20:01:21-!- madmax28 [madmax28ma@gateway/shell/matrix.org/x-esnkqapmpudwxtaq] has joined #wesnoth-dev 20180422 20:01:24< celticminstrel> Hmm, wait, this scenario actually doesn't use fog. I forgot about that. I guess I just won't worry about it then. 20180422 20:16:53< celticminstrel> I can't figure out why [animate_unit] is not working... :| 20180422 20:17:10< celticminstrel> It works if I enter the command into the command console (using the unit's ID rather than their location). 20180422 20:17:38<+discordbot> Did there used to be an End Turn option in the right-click menu ingame, or am I mis-remembering things? 20180422 20:17:58< celticminstrel> I think there was? 20180422 20:19:01< irker856> wesnoth: Iris Morelle wesnoth:master 296894c5155c / changelog.md data/core/units.cfg: Change the plural race name for merfolk to Merfolk https://github.com/wesnoth/wesnoth/commit/296894c5155ca6c2e77bfa92dee65a98e6797318 20180422 20:19:34< celticminstrel> I'm thinking one of two things is going wrong here. 20180422 20:20:11< celticminstrel> Either [animate_unit] doesn't correctly default to the primary unit for the event, or the primary unit for the event is somehow not available? 20180422 20:20:14< celticminstrel> Neither seems likely though... 20180422 20:20:24< celticminstrel> The latter seems marginally more likely... 20180422 20:20:38< celticminstrel> Also yay for merfolk change! 20180422 20:21:53< gfg> pent: it was removed 20180422 20:22:03<+discordbot> 😦 20180422 20:22:20< gfg> The right click menu was too full 20180422 20:22:44< gfg> If you really need it you can re add it locally by editing your theme wml files 20180422 20:23:06< celticminstrel> ...WTH? It doesn't even work if I hard-code a unit's ID into the WML... 20180422 20:23:33<+discordbot> easier to teach myself ctrl+space, I suppose 20180422 20:24:08< celticminstrel> That said... 20180422 20:24:33< celticminstrel> My earlier theories are probably all on the wrong track. If I add text= the text shows above the correct unit in all those cases, so it's probably somehow a problem with matching the weapon? 20180422 20:29:17< celticminstrel> Weirdly, omitting speaker or SUF from [message] makes it use your leader or something? I guess because it looks at an empty SUF and takes the first matching unit (which is the first out of all units on the map) which will pretty much always be your leader. 20180422 20:30:52< celticminstrel> So uh... adding a [message] before the animation somehow makes it work? 20180422 20:32:41< celticminstrel> No, it's not quite that simple... hmm... 20180422 20:35:29-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity] 20180422 20:41:33< celticminstrel> Seems like it works if the map is scrolled at all before the animation. Weird. 20180422 20:45:25< irker856> wesnoth: Iris Morelle wesnoth:master 14ec9954f1c3 / / (4 files in 3 dirs): Replace a few instances of "mermen" with "merfolk" in core descriptions https://github.com/wesnoth/wesnoth/commit/14ec9954f1c322d47d172e2e2572f2ece308d047 20180422 21:02:55< celticminstrel> I think I might be almost ready to put my campaign on the addons server (though I'm not sure if the 1.14 instance is up yet? If not I should wait until then). I just need to apply the stuff mattsc gave me and maybe one other thing which I imagine has been done before... 20180422 21:03:10< celticminstrel> Namely, if someone who picked up an item dies, drop it on the ground so that someone else can use it. 20180422 21:03:44< Soliton> addon server is already 1.14. 20180422 21:03:54< celticminstrel> 'kay 20180422 21:05:01< irker856> wesnoth: ln-zookeeper wesnoth:1.14 b8bf9b380634 / data/campaigns/Under_the_Burning_Suns/utils/abilities.cfg: UtBS: Removed a remaining [on_redo] https://github.com/wesnoth/wesnoth/commit/b8bf9b380634449e66a1f469b2b889d975211123 20180422 21:05:24< zookeeper> (yes, you don't need to remind to backport, i'll do them in batches later) 20180422 21:28:26<+discordbot> Ugh, as I predicted, rebasing the bans branch is no longer trivial. 20180422 21:32:09-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 264 seconds] 20180422 21:35:08-!- Oebele [~quassel@143.177.58.202] has quit [Remote host closed the connection] 20180422 22:01:31-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection] 20180422 22:20:09-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180422 22:20:19-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180422 22:41:49-!- gallaecio [~quassel@188.79.96.255] has quit [Ping timeout: 260 seconds] 20180422 22:45:21-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 264 seconds] 20180422 22:49:53-!- gfg [~androirc@tmo-102-99.customers.d1-online.com] has quit [Read error: Connection reset by peer] 20180422 22:51:12-!- octalot [~steve@91.141.1.142.wireless.dyn.drei.com] has quit [] 20180422 22:57:06-!- gfg [~androirc@134.76.63.8] has joined #wesnoth-dev 20180422 23:04:23<+discordbot> gdi zookeeper.... 20180422 23:04:35< irker856> wesnoth: ln-zookeeper wesnoth:master 221fe72dcb08 / data/campaigns/Under_the_Burning_Suns/utils/abilities.cfg: UtBS: Removed a remaining [on_redo] https://github.com/wesnoth/wesnoth/commit/221fe72dcb08929103516d98ad052654880748f3 20180422 23:04:40<+discordbot> >_> 20180422 23:06:10<+discordbot> ok, I see he mentioned backporting (really forward porting), but it is unacceptable to "do them in batches". 20180422 23:06:18<+discordbot> it is incredibly easy to forget a commit 20180422 23:06:21<+discordbot> or forget to do a port 20180422 23:06:40<+discordbot> especially when it's a minor commit 20180422 23:11:07< irker856> wesnoth: Severin Glöckner wesnoth:master b8fe22877b60 / data/campaigns/tutorial/scenarios/01_Tutorial_part_1.cfg: Tutorial: fix two strings https://github.com/wesnoth/wesnoth/commit/b8fe22877b60fa4a7638a99ce8e23f25d5bf87c1 20180422 23:17:02-!- grzywacz [~karol@89-70-226-147.dynamic.chello.pl] has quit [Remote host closed the connection] --- Log closed Mon Apr 23 00:00:44 2018