--- Log opened Mon Apr 23 00:00:44 2018 20180423 00:23:01-!- gfg [~androirc@134.76.63.8] has quit [Remote host closed the connection] 20180423 00:24:51<+discordbot> https://r.wesnoth.org/p626344 The classical pre-release crashes 20180423 00:29:00< irker856> wesnoth/wesnoth:1.14 Celtic Minstrel 8bd85636f1 Add translation hints for the village an AppVeyor: All builds passed 20180423 01:35:31< irker856> wesnoth: Charles Dang wesnoth:master 38e0b83cda3f / src/gui/dialogs/ (label_settings.cpp label_settings.hpp): Label Settings: formatting cleanup https://github.com/wesnoth/wesnoth/commit/38e0b83cda3fa406e106590a30ecd9c546139db0 20180423 01:35:34< irker856> wesnoth: Charles Dang wesnoth:master 1f319e31fed8 / src/gui/dialogs/label_settings.cpp: Label Settings: minor code cleanup https://github.com/wesnoth/wesnoth/commit/1f319e31fed8f57d5dad422517ed3d592bad898c 20180423 02:02:45< irker856> wesnoth/wesnoth:1.14 Steve Cotton 2afdcad4e5 Tutorial: fix the overall translation hi AppVeyor: All builds passed 20180423 02:52:22< irker856> wesnoth: newfrenchy83 wesnoth:1.14 12bd7c0b8cb6 / projectfiles/CodeBlocks/wesnoth.cbp: Update wesnoth.cbp https://github.com/wesnoth/wesnoth/commit/12bd7c0b8cb61421fd0c7ef14dda1a60ecbdcca8 20180423 02:52:24< irker856> wesnoth: newfrenchy83 wesnoth:1.14 66ac0bb1b23e / projectfiles/CodeBlocks/wesnothd.cbp: Update wesnothd.cbp https://github.com/wesnoth/wesnoth/commit/66ac0bb1b23e81dc52b92d52dbc4ce0aa59ab1ab 20180423 03:15:00< irker856> wesnoth/wesnoth:1.14 Iris Morelle 3a7b4bf738 Change the plural race name for merfolk AppVeyor: All builds passed 20180423 05:07:38-!- gallaecio [~quassel@188.79.96.255] has joined #wesnoth-dev 20180423 05:15:11-!- celticminstrel is now known as celmin|sleep 20180423 05:22:15< irker856> wesnoth/wesnoth:1.14 ln-zookeeper b8bf9b3806 UtBS: Removed a remaining [on_redo] AppVeyor: All builds passed 20180423 05:53:31-!- gallaecio [~quassel@188.79.96.255] has quit [Remote host closed the connection] 20180423 06:07:13< irker856> wesnoth: doofus-01 wesnoth:1.14 cd5b64122615 / data/campaigns/Under_the_Burning_Suns/ (8 files in 2 dirs): updates to Nym sprite and basic animations, and corrupt-elf sprite https://github.com/wesnoth/wesnoth/commit/cd5b64122615b2fbe0a60954bcb409075e1f21a5 20180423 06:07:15< irker856> wesnoth: doofus-01 wesnoth:1.14 1544ec9b1bf6 / data/campaigns/Under_the_Burning_Suns/images/units/quenoth/ (kaleh-defend-1.png kaleh-defend-2.png kaleh.png): Kaleh base and two defense sprites https://github.com/wesnoth/wesnoth/commit/1544ec9b1bf6987faacdac8b0cfcacc144009922 20180423 06:10:20< irker856> wesnoth: doofus-01 wesnoth:master 515af2f504d9 / data/campaigns/Under_the_Burning_Suns/ (8 files in 2 dirs): updates to Nym sprite and basic animations, and corrupt-elf sprite https://github.com/wesnoth/wesnoth/commit/515af2f504d93f077f8c048cdf52e664e584e89d 20180423 06:10:22< irker856> wesnoth: doofus-01 wesnoth:master f871040a9d55 / data/campaigns/Under_the_Burning_Suns/images/units/quenoth/ (kaleh-defend-1.png kaleh-defend-2.png kaleh.png): Kaleh base and two defense sprites https://github.com/wesnoth/wesnoth/commit/f871040a9d55c776de9227f806558245497c68bb 20180423 06:10:24< irker856> wesnoth: Charles Dang wesnoth:master cb41d21423f1 / data/campaigns/Under_the_Burning_Suns/_main.cfg: UtBS: set campaign icon TC back to red https://github.com/wesnoth/wesnoth/commit/cb41d21423f173922515e11f8433e0514007fcd5 20180423 06:11:06< irker856> wesnoth: Charles Dang wesnoth:1.14 64f944fc25b9 / data/campaigns/Under_the_Burning_Suns/_main.cfg: UtBS: set campaign icon TC back to red https://github.com/wesnoth/wesnoth/commit/64f944fc25b9836d4d831dc6b6cd2973feaab211 20180423 06:12:55-!- gallaecio [~quassel@119.red-83-34-169.dynamicip.rima-tde.net] has joined #wesnoth-dev 20180423 07:08:30-!- vn971 [~vasya@94.158.103.15] has quit [Ping timeout: 256 seconds] 20180423 07:09:47-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20180423 07:09:54-!- vn971 [~vasya@94.158.103.15] has joined #wesnoth-dev 20180423 07:20:04-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180423 08:20:37< irker856> wesnoth/wesnoth:master Charles Dang 1f319e31fe Label Settings: minor code cleanup AppVeyor: All builds passed 20180423 08:45:08-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20180423 08:47:18-!- vladimirslavik [vslavik@nat/redhat/x-fsodyzrjadvtnfir] has joined #wesnoth-dev 20180423 08:47:35-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180423 08:59:56< irker856> wesnoth: newfrenchy83 wesnoth:1.14 a24987fe63ec / projectfiles/CodeBlocks/wesnothd.cbp: Update wesnothd.cbp https://github.com/wesnoth/wesnoth/commit/a24987fe63ec0c051dbd2f854e54291be0a20eba 20180423 09:05:42< zookeeper> @Vultraz, when i update changelogs or port commits, i look at my commits in the log so i don't have to remember each one individually. 20180423 09:07:36<+discordbot> Bus factor. 20180423 09:08:20<+discordbot> We should ask Wesnoth Inc to hire people to kidnap random developers for 1 week every time and see how the rest manages to deal with that situation. 20180423 09:28:08<+discordbot> the peanut gallery is strong with the forums today 😦 20180423 09:28:23<+discordbot> (Credit to Gambit for the idea: https://twitter.com/Grickit/status/981865552850415616) 20180423 09:29:32<+discordbot> So, the random map generator (and apparently the labels API that is eventually used by the dialog from issue #2949 https://github.com/wesnoth/wesnoth/issues/2949) appears to make use of an undocumented category= attribute. 20180423 09:29:56<+discordbot> didn't celmin introduce that 20180423 09:29:59<+discordbot> Not entirely sure whether the string in question can be translatable or not. 20180423 09:30:06<+discordbot> But it could be a way to fix #2949. 20180423 09:30:34<+discordbot> Another way is to hardcode a check for "villages" in the dialog logic. 20180423 09:31:33<+discordbot> In place of the TODO comment in line 56: https://github.com/wesnoth/wesnoth/blob/a24987fe63ec0c051dbd2f854e54291be0a20eba/src/gui/dialogs/label_settings.cpp#L54 20180423 09:33:46<+discordbot> In any case I'm not too concerned about this bug since it only crops up in the random map generator output, or (theoretically) with any scenarios making use of the aforementioned undocumented attribute in [label]. 20180423 09:34:10<+discordbot> ([label] category=, forgot to include the tag name above.) 20180423 09:43:48<+discordbot> Or actually, more like this, after a quick test: https://gist.github.com/shikadiqueen/16a516b5b4d8fd5bbaefa7c22b4715ef 20180423 09:44:02<+discordbot> It's a very desperate hacky approach though. 20180423 09:45:06<+discordbot> The problem is it's not clear whether [label] category= is supposed to be an identifier used by a heretofore unmentioned API, or it can actually be a translatable string. 20180423 09:45:43<+discordbot> If it could be the latter then the fix would simply be to make it a tstring built from `N("Villages")`. 20180423 09:57:47< irker856> wesnoth/wesnoth:1.14 doofus-01 a43e64af0d updates to Nym sprite and basic animatio AppVeyor: All builds passed 20180423 10:11:55<+discordbot> (And yes I know that's a gross oversimplification and that building a proper t_string that is translatable actually necessitates calling a seldom-seen constructor.) 20180423 10:16:08<+discordbot> "If you have push access, please remember when creating issues to add the bug or enhancement label as well as at least one applicable purple label." 20180423 10:16:23<+discordbot> CONTRIBUTING.md does hint at there being a colour-key system for ticket labels. 20180423 10:17:07<+discordbot> It looks like the purple labels refer to "modules" (in the loosest sense of terms because you know how un-modular Wesnoth really is) of the game. 20180423 10:17:55<+discordbot> And the light blue labels (AppVeyor, Cmake (sic), Enhancement, Scons (sic), Travis (sic)) to stuff that has to do with the build systems... except for Enhancement. 20180423 10:19:15<+discordbot> Engine is the oddball one with a blue colour instead of purple. Blue seems to be used for ticket resolution status. 20180423 10:19:23<+discordbot> Input as well. 20180423 10:22:51<+discordbot> I was not aware of this 20180423 10:23:09<+discordbot> Really now. 20180423 10:24:03<+discordbot> I wasn't aware of the color system, either. (I created both Engine and Input tags.) 20180423 10:24:30<+discordbot> It could be a coincidence since clearly there are some inconsistencies. 20180423 10:24:50<+discordbot> I think it'd be worthwhile to settle on an actual colour-keying system though. 20180423 10:25:24<+discordbot> (And also make sure that stuff gets tagged. If only users had the ability to set tags of their own tickets as well.) 20180423 10:25:34<+discordbot> (*labels) 20180423 10:25:57-!- midzer [~quassel@p5B051DAC.dip0.t-ipconnect.de] has left #wesnoth-dev ["http://quassel-irc.org - Chat comfortably. Anywhere."] 20180423 10:28:21<+discordbot> that assertion report in the rc3 thread is troubling... 20180423 10:29:11<+discordbot> Indeed. If the game can crash when the AI is playing against itself, it's likely that it can also crash when the player is playing against the AI. 20180423 10:30:41<+discordbot> but without a save or anything to debug it looks like there's nothing we can do 20180423 10:30:42<+discordbot> 😦 20180423 10:31:39<+discordbot> I played a game consisting of me and 8 AIs to test replays.wesnoth.org the other day and didn't crash. 20180423 10:32:02<+discordbot> I deliberately rigged the numbers so I'd die very early into it. 20180423 10:32:43<+discordbot> Well, as little as knowing which assert it was is of huge help. 20180423 10:32:44<+discordbot> https://github.com/wesnoth/wesnoth/blob/1.14/src/actions/attack.cpp#L408 20180423 10:33:06<+discordbot> huh,I just observed that "unit fades to black instead of black when leveling up" thing 20180423 10:33:22<+discordbot> *instead of white 20180423 10:33:36<+discordbot> derp 20180423 10:33:49<+discordbot> I'm watching the AI play Caves of the Basilisk with OP supplies and nothing's happened thus far. 20180423 10:33:56<+discordbot> Oh, I "lost" on turn 14. 20180423 10:34:25<+discordbot> When I was making the final update of Angry Birds Stella, I was given an Excel sheet of top crashes, which only had the Lua error messages (not even call stacks). Working from there, I was able to figure out some crashes, reproduce them and fix them. 20180423 10:34:26<+discordbot> So it'd be worth knowing exactly what conditions are required to reproduce it, ergo, savegame. 20180423 10:36:22<+discordbot> I can't find what code handles that white flash... 20180423 10:38:09<+discordbot> oh, it's in actions 20180423 10:38:11<+discordbot> of course it is 20180423 10:38:15<+discordbot> OF COURSE IT IS >_> 20180423 10:39:47<+discordbot> Regarding that assertion: as an example, here we have a return statement between assigning attacker_stats_ and defender_stats_: https://github.com/wesnoth/wesnoth/blob/1.14/src/actions/attack.cpp#L562-L571 20180423 10:40:04<+discordbot> If choose_defender_weapon() doesn' 20180423 10:40:38<+discordbot> t assign defender_stats_ and that return statement is taken, it results in the corrupted state where only attacker_stats_ is assigned. 20180423 10:42:02<+discordbot> ok... sometimes it's white, sometimes it's black... 20180423 10:44:29<+discordbot> odd. and the code specifies white. 20180423 10:44:44<+discordbot> Looking at the history of actions/attack.cpp, it looks like the regressing commit is this. 20180423 10:44:45<+discordbot> https://github.com/wesnoth/wesnoth/commit/a3d5b9d603083ab0f3afcfbc9fc4c2432bb1623e#diff-54411f8c204f7ceac25ecc0882ee5623 20180423 10:45:00<+discordbot> Apparently that reset() call wasn't unnecessary. 20180423 10:45:26<+discordbot> I see 20180423 10:45:28<+discordbot> 🤔 20180423 10:46:00<+discordbot> before I deployed the unique_ptr it was... 20180423 10:46:11<+discordbot> delete attacker_stats_; attacker_stats_ = nullptr; 20180423 10:46:45<+discordbot> Yes. That, too, resulted in both attacker_stats_ and defender_stats_ being null. 20180423 10:46:50<+discordbot> indeed. 20180423 10:46:55<+discordbot> good work 👍 20180423 10:46:58<+discordbot> And then the constructor created them both. 20180423 10:47:06<+discordbot> could you commit the fix? 20180423 10:47:25<+discordbot> I can do it in the evening. 20180423 10:47:39<+discordbot> great 20180423 10:48:02<+discordbot> guess it shows even the most innocuous change can break stuff... 20180423 10:48:45<+discordbot> Never assume a line of code to be unnecessary. 20180423 11:15:03< irker856> wesnoth: loonycyborg wesnoth:master 10122057e688 / src/server/server.cpp: wesnothd: refuse to send whispers from observers to players in same game https://github.com/wesnoth/wesnoth/commit/10122057e6886b2c52066783fa9b5edc60196c09 20180423 11:25:27< irker856> wesnoth: loonycyborg wesnoth:1.14 8acbc3878ddf / src/server/server.cpp: wesnothd: refuse to send whispers from observers to players in same game https://github.com/wesnoth/wesnoth/commit/8acbc3878ddfdfb538de6ee32a5111ab900b53b7 20180423 11:51:32-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180423 11:51:39-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180423 12:15:24< irker856> wesnoth/wesnoth:master Charles Dang cb41d21423 UtBS: set campaign icon TC back to red AppVeyor: All builds passed 20180423 12:45:57-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: So long and thanks for all the fish.] 20180423 12:56:07< celmin|sleep> Yes I introduced label category. I think it should probably remain non-translatable though? It's kinda like team_name for example, a key to group labels. I'm not sure what's the best way to enable translatability of label categories, maybe also support category_name (but that's gonna result in tons of redundancy if every label in the category needs the string), or put it in [language] or something? 20180423 12:56:53< celmin|sleep> The purple labels originally corresponded to some field on GNA, I forget what it was called, but "modules" is as good a term as any. 20180423 12:57:04< celmin|sleep> Orange labels are OSes. 20180423 12:58:12< celmin|sleep> I don't think I had a strong colour-coding for issues beyond that. 20180423 12:58:34< celmin|sleep> I'd probably suggest changing the colour for AppVeyor and Cmake so that it's different from Enhancement. 20180423 12:59:54< celmin|sleep> Beyond what I mentioned, I think I mostly used a unique colour for each label (other than making "blocker" the same red as "bug"). 20180423 13:00:07< celmin|sleep> (Oh, and "Invalid" and "Duplicate" are the same grey, I think.) 20180423 13:00:53< celmin|sleep> There's also a bunch of green ones, not sure how that came about, or whether it was me or someone else. 20180423 13:15:04-!- celmin|sleep is now known as celmin|away 20180423 13:15:58< irker856> wesnoth: Severin Glöckner wesnoth:1.14 ca16166f1a38 / data/multiplayer/scenarios/2p_Dark_Forecast.cfg: Dark Forecast: fix untranslatable string by https://github.com/wesnoth/wesnoth/commit/ca16166f1a38de039b83ba5bdb338fafe539ba12 20180423 13:21:47<+discordbot> ^ I am not sure if I should regard this as a temporary workaround for the string freeze or as the prefered way to handly this. It reuses the string from a similar place, which sounds like a good idea, but only works as long as this string in gui/window/campaign_difficulty.cfg isn't going to change. 20180423 13:22:44<+discordbot> I think "Difficulty" is unlikely to change. 20180423 13:24:59< celmin|away> (Oh FTR my first statement is about in-game labels, the rest is about GitHub issue labels.) 20180423 13:30:28<+discordbot> Alright 20180423 13:30:38< irker856> wesnoth: Severin Glöckner wesnoth:master 8657fdb9a39f / data/multiplayer/scenarios/2p_Dark_Forecast.cfg: Dark Forecast: fix untranslatable string by https://github.com/wesnoth/wesnoth/commit/8657fdb9a39f6556fb236d45e451a91c547852af 20180423 13:57:14<+discordbot> I just reminded I was wrong - the gettext script is parsing all of wesnoth for each textdomain, so if one of the strings changes the other is still found and added to the .pot 20180423 14:01:05-!- Appleman1234 [~quassel@124x38x163x22.ap124.ftth.ucom.ne.jp] has quit [Ping timeout: 240 seconds] 20180423 14:43:01-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180423 14:43:06-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180423 14:55:31-!- Oebele [~quassel@143.177.58.202] has joined #wesnoth-dev 20180423 15:07:21-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20180423 15:10:12-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180423 15:12:22< irker856> wesnoth/wesnoth:1.14 Iris Morelle e00c8ecbeb wesnothd/fuh: Check IP address bans befo AppVeyor: All builds passed 20180423 15:18:17<+discordbot> working on 2953 20180423 15:55:01-!- gallaecio [~quassel@119.red-83-34-169.dynamicip.rima-tde.net] has quit [Remote host closed the connection] 20180423 16:06:35<+discordbot> Addons question: can you add more HUD to a tile/unit (e.g. display health as text on the map) via addons? 20180423 16:07:03<+discordbot> ehhhh.. somewhat 20180423 16:07:07<+discordbot> if you stick a label on the map 20180423 16:07:14<+discordbot> ([label]) 20180423 16:19:39-!- gallaecio [~quassel@188.79.96.255] has joined #wesnoth-dev 20180423 16:24:15<+discordbot> @jyrkive I think I've fixed #2953 but it involved refactoring. Would you recommend holding off a backport until 1.14.1? 20180423 16:24:37<+discordbot> Yes, please don't backport it yet. 20180423 16:29:35< irker856> wesnoth: Jyrki Vesterinen wesnoth:1.14 95953079895c / src/actions/attack.cpp: Fix rare crash in AI code https://github.com/wesnoth/wesnoth/commit/95953079895cf5c1cff89b0f7103ac850a3847db 20180423 16:32:39<+discordbot> Jyrki@DESKTOP-G4UK4BR MINGW64 /i/Battle for Wesnoth/wesnoth (master) $ git push Counting objects: 667, done. Delta compression using up to 12 threads. Compressing objects: 100% (194/194), done. error: RPC failed; curl 56 OpenSSL SSL_read: error:140943FC:SSL routines:ssl3_read_bytes:sslv3 alert bad record mac, errno 0 fatal: The remote end hung up unexpectedly Writing objects: 100% (667/667), 5.73 MiB | 518.00 KiB/s, done. Total 667 20180423 16:32:40<+discordbot> (delta 545), reused 590 (delta 473) fatal: The remote end hung up unexpectedly Everything up-to-date 20180423 16:32:55<+discordbot> I can't push to my fork's master. Wonder what's up with that... 20180423 16:33:07< irker856> wesnoth: Jyrki Vesterinen wesnoth:master 4d569815d00f / src/actions/attack.cpp: Fix rare crash in AI code https://github.com/wesnoth/wesnoth/commit/4d569815d00fc0bb7be9fcc83705ebbf9a680bd8 20180423 16:36:35< irker856> wesnoth: Charles Dang wesnoth:master 194262705229 / src/ (4 files in 2 dirs): Some refactoring of preferences-related hotkey info storage (fixes #2953) https://github.com/wesnoth/wesnoth/commit/1942627052298aca366147fbf59ee0e268810875 20180423 16:37:52<+discordbot> That's probably more than I needed to do, but I wanted to fix some messiness in the underlying code rather than just hack a fix in 20180423 16:41:27<+discordbot> ...and now push to my fork succeeded. Apparently just some kind of temporary hiccup. (It failed three times in a row before, though.) 20180423 16:43:05<+discordbot> ¯_(ツ)_/¯ 20180423 16:45:47<+discordbot> And how about displaying additional info in the "info panel" to the right? 20180423 16:46:07<+discordbot> that is possible 20180423 16:46:16<+discordbot> well 20180423 16:46:20<+discordbot> in a very limited sense 20180423 16:50:32< irker856> wesnoth: Charles Dang wesnoth:master 17da211d1f02 / src/gui/dialogs/preferences_dialog.cpp: Fixup 1942627 https://github.com/wesnoth/wesnoth/commit/17da211d1f0243297698590961c4587366e98799 20180423 16:50:45<+discordbot> Like this 20180423 16:50:46<+discordbot> https://cdn.discordapp.com/attachments/259976436490829825/438018888400371732/unknown.png 20180423 16:51:24<+discordbot> No. 20180423 16:52:07-!- Oebele [~quassel@143.177.58.202] has quit [Remote host closed the connection] 20180423 16:52:32<+discordbot> So what is possible, 20180423 16:55:38<+discordbot> In general i need to display custom unit attribute to the user 20180423 17:11:32-!- vladimirslavik [vslavik@nat/redhat/x-fsodyzrjadvtnfir] has quit [Quit: Leaving] 20180423 17:12:02<+discordbot> Some campaigns create a custom traits, but they have no numerical value. 20180423 17:18:19-!- travis-ci [~travis-ci@ec2-54-234-247-71.compute-1.amazonaws.com] has joined #wesnoth-dev 20180423 17:18:20< travis-ci> wesnoth/wesnoth#17779 (master - 1942627 : Charles Dang): The build was broken. 20180423 17:18:20< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/370185064 20180423 17:18:20-!- travis-ci [~travis-ci@ec2-54-234-247-71.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180423 17:25:19<+discordbot> Well, you can crate a trait called "Var1: 10", or rather 50 traits, and switch the traits in the situations by rebuilding the unit (since there is no other way to remove traits, and if there would be one, it would still change the order) 20180423 17:26:12<+discordbot> Ok. Thanks for the idea 20180423 17:33:28-!- gfg [~androirc@134.76.63.8] has joined #wesnoth-dev 20180423 17:34:38< gfg> wesnoth. Theme_items is a way to display vision unit attributes 20180423 17:36:38< gfg> custom traits on the other hand have the advantage of being visible the in the recall dialog aswell 20180423 17:40:06-!- travis-ci [~travis-ci@ec2-54-196-142-97.compute-1.amazonaws.com] has joined #wesnoth-dev 20180423 17:40:07< travis-ci> wesnoth/wesnoth#17780 (master - 17da211 : Charles Dang): The build passed. 20180423 17:40:07< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/370190762 20180423 17:40:07-!- travis-ci [~travis-ci@ec2-54-196-142-97.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180423 17:43:12< irker856> wesnoth/wesnoth:master loonycyborg 10122057e6 wesnothd: refuse to send whispers from o AppVeyor: All builds passed 20180423 18:13:24< irker856> wesnoth: Iris Morelle steam-meta:master 8589a0b24007 / app_metadata.zh_CN.txt po/zh_CN.po: Added Chinese translation https://github.com/wesnoth/steam-meta/commit/8589a0b24007a4cd65d2c84143fae9dfac6b5a8f 20180423 18:13:26< irker856> wesnoth: Iris Morelle steam-meta:master ca470511cedb / app_metadata.cs.txt: Add generated file from the Czech translation, oops https://github.com/wesnoth/steam-meta/commit/ca470511cedb345948ba3d552815b90cf616f78d 20180423 18:16:34<+discordbot> You guys are right, I think, about Staging... I need to rethink the leader display layout 20180423 18:17:05<+discordbot> I like sevu's idea about icon use 20180423 18:17:51-!- octalot [~steve@178.115.131.127.wireless.dyn.drei.com] has joined #wesnoth-dev 20180423 18:21:21<+discordbot> @Bitron 's idea actually 20180423 18:47:20-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180423 18:47:26-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180423 18:47:46<+discordbot> The only thing I am not sure about that is that factions aren't equal to races. Some factions happen to feature a major race, but they contain others, too. Also, with the Dunefolk, we have two factions which would share the human race icon. Except they have individual icons, I'm not aware. Another solution might be creating icons specifically for the factions. Nut that would require additional artwork. 20180423 18:55:44<+discordbot> Oh wait. I thought these are the race icons, but indeed there are actually faction icons. 20180423 19:27:05-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180423 19:27:11-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180423 19:33:53-!- gfg [~androirc@134.76.63.8] has quit [Ping timeout: 248 seconds] 20180423 19:36:38-!- octalot [~steve@178.115.131.127.wireless.dyn.drei.com] has quit [] 20180423 19:40:55< irker856> wesnoth/wesnoth:1.14 Severin Glöckner ca16166f1a Dark Forecast: fix untranslatable string AppVeyor: All builds passed 20180423 19:48:11-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180423 19:48:17-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180423 20:02:12<+discordbot> Can someone give me a hint, what was the "1.13 vs 1.12 blurry font" issue? I wonder if one of iOS feedbacks is for this upstream issue, or iOS specific. 20180423 20:02:30<+discordbot> Couldn't find it in issues searching by "font". 20180423 20:03:47< Ravana_> it is not ios specific problem 20180423 20:04:41<+discordbot> I'd like to read up its history, to see if I can help it. 20180423 20:06:16< Ravana_> it is too subjective problem for me to create issue 20180423 20:06:29< Ravana_> font scaling commit might have some info about that 20180423 20:08:21<+discordbot> You mean this? https://github.com/wesnoth/wesnoth/issues/2859 20180423 20:08:23<+discordbot> From what I remember, it doesn't look subjective to me at all. And even if it is, it's worth creating (and optionally closing) an issue, just to keep track of the discussion. Will look for the commit, thanks. 20180423 20:09:01<+discordbot> @hrubymar10 Nope, there was a discussion comparing 1.12 and 1.13 font rendering. 1.13 looked much brickier. 20180423 20:09:17<+discordbot> oh, ok 😄 20180423 20:59:47<+discordbot> @sinda sorry for asking here, but what font rendering will be used in 1.14? Cuz the one working now hurts my eyes on iPad Pro 20180423 21:08:10<+discordbot> https://imgur.com/a/i7QtY19 20180423 21:10:22<+discordbot> I tried switching font scale, didn’t help 20180423 21:10:26-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev 20180423 21:12:11<+discordbot> Yep, it needs to be addressed, at least, on iOS. I registered it in iOS tracker. 20180423 21:13:26<+discordbot> Worst case, we'll have to implement a HighDPI support for fonts. 20180423 21:13:45<+discordbot> Easiest fix would be disabling font smoothing. 20180423 21:15:29<+discordbot> Ah, so that will help? Fantastic 😄 20180423 21:16:27<+discordbot> @Rusack your screenshot is quite small and in jpg, so sadly it doesn't illustrate the point. 20180423 21:17:56<+discordbot> Assuming you're talking about the weird translucent lines which are supposed to be opaque (especially in in-game chat), yes. That translucency is the result of the font smoothing algorithm. 20180423 21:18:27<+discordbot> Hinting is supposed to ensure that lines are always visible and clear, and we should already be using it. 20180423 21:18:44<+discordbot> But if it doesn't help, fully disabling font smoothing is the brute-force solution. 20180423 21:19:52<+discordbot> (I have font smoothing disabled in Windows settings because I want highest possible contrast and clarity. I don't care about smoothness. And as a side effect, I don't experience Wesnoth's font issues at all.) 20180423 21:22:09-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 248 seconds] 20180423 21:27:55< Ravana_> for me disabling font smoothing makes ingame chat look slightly better, but everywhere else much much worse 20180423 21:28:44<+discordbot> My problem is, as we don't have a history of this specific discussion, with a screenshots, I don't know what exactly the particular problem is. 20180423 21:40:36< irker856> wesnoth: Nils Kneuper wesnoth:1.14 41c701026e4b / / (6 files in 5 dirs): updated Polish translation https://github.com/wesnoth/wesnoth/commit/41c701026e4bae6dc8376203ecd1dc561afd4268 20180423 21:40:38< irker856> wesnoth: Nils Kneuper wesnoth:1.14 37a899ee8877 / / (11 files in 10 dirs): updated Spanish translation https://github.com/wesnoth/wesnoth/commit/37a899ee88775399762febd01111ef3edd6f9b35 20180423 21:40:40< irker856> wesnoth: Nils Kneuper wesnoth:1.14 cee062c754e9 / po/ (wesnoth-help/gd.po wesnoth-tb/gd.po wesnoth/gd.po): updated Scottish Gaelic translation https://github.com/wesnoth/wesnoth/commit/cee062c754e9d3ba44f4880a41c0246797ed8fd0 20180423 21:40:42< irker856> wesnoth: Nils Kneuper wesnoth:1.14 c1f4cd52cce5 / / (32 files in 31 dirs): updated Japanese translation https://github.com/wesnoth/wesnoth/commit/c1f4cd52cce5e782eca10c74315e5c6346f179dc 20180423 21:40:45< irker856> wesnoth: Nils Kneuper wesnoth:master f3737d44ac75 / po/ (4 files in 4 dirs): updated Polish translation https://github.com/wesnoth/wesnoth/commit/f3737d44ac75350e709d84d2da0244931139f140 20180423 21:40:47< irker856> wesnoth: Nils Kneuper wesnoth:master ce4d6bfea9bb / po/ (9 files in 9 dirs): updated Spanish translation https://github.com/wesnoth/wesnoth/commit/ce4d6bfea9bbbdbf8cd1894ebe6276c8dcef25f9 20180423 21:40:49< irker856> wesnoth: Nils Kneuper wesnoth:master ff6aa075e548 / po/ (wesnoth-help/gd.po wesnoth-tb/gd.po wesnoth/gd.po): updated Scottish Gaelic translation https://github.com/wesnoth/wesnoth/commit/ff6aa075e54888e6ea7d1b081942615a027b8db6 20180423 21:40:51< irker856> wesnoth: Nils Kneuper wesnoth:master b0f76a7d4dd4 / changelog.md data/core/about_i18n.cfg players_changelog.md: updated Japanese translation https://github.com/wesnoth/wesnoth/commit/b0f76a7d4dd40f074198b6a1a9153dab5a62993c 20180423 21:40:53< irker856> wesnoth: Nils Kneuper wesnoth:master b6f412fba1b8 / po/ (29 files in 29 dirs): updated Japanese translation https://github.com/wesnoth/wesnoth/commit/b6f412fba1b85b4ae877d489906dbf67f8856b29 20180423 21:50:37-!- gallaecio [~quassel@188.79.96.255] has quit [Remote host closed the connection] 20180423 21:58:38<+discordbot> @sinda open the imgur link, full-size screenshot is there 20180423 21:59:55<+discordbot> Oh yep, it is. It's still in jpg, so all the fonts are blurry. 20180423 21:59:56<+discordbot> maybe put in an option tu turn on/off font smoothing? this shouldn't be difficult to do 20180423 22:00:24<+discordbot> how do I do screenshots on ipad in png? xD lemme try, I'll send it soon (probably) 20180423 22:00:42<+discordbot> Home-Power does pngs for me. 20180423 22:02:33<+discordbot> damn imgur converted it 20180423 22:02:40<+discordbot> It's not only smoothing, as far as I see. Hinting has changed, not sure about tracking. It still might not achieve what you want, as you might expect a true HiDPI fonts, which Wesnoth doesn't support anywhere now. 20180423 22:03:09<+discordbot> Use Dropbox/Google Drive, or just PM it to me. 20180423 22:03:12<+discordbot> https://drive.google.com/file/d/1yUODUuI27fTv_PgkXHzkwnkhj6x1LrNN/view?usp=sharing 20180423 22:03:21<+discordbot> Good, thanks! 20180423 22:03:40<+discordbot> I can make any screenshots you need, not a problem 20180423 22:04:45<+discordbot> idk, might it be that the game has set resolution ~HD and not even ~FullHD? 20180423 22:06:22<+discordbot> So far, it can not. It's scaled to iPad DPI. I'm afraid what you expect is a true HiDPI fonts, and we don't support that yet. 20180423 22:07:08<+discordbot> Is it hard to implement? (Not a coder, sorry for a dumb question) 20180423 22:11:42<+discordbot> Quite some work. Wesnoth screens' markup is currently hardwired to 96 DPI. A workaround was attempted (like, "scale controls and bitmaps to DPI, but use native fonts"), but didn't yield fruit. I believe, it can be done in about 40 working hours. I'm afraid it's going to be prioritized down. 20180423 22:12:32<+discordbot> I understand, well, that’s a pity 20180423 22:18:27<+discordbot> It makes no difference whether to double or to triple it. It's either hardwired or arbitrary. And quite some people are still on 96 DPI. 20180423 22:34:10-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20180423 22:37:19-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection] 20180423 22:43:47< irker856> wesnoth: gfgtdf wesnoth:1.14 37c913c1737a / data/multiplayer/scenarios/2p_Dark_Forecast.lua: fix lua error in 2p_Dark_Forecast 2 https://github.com/wesnoth/wesnoth/commit/37c913c1737a217f5ef2fdbd7a04a8542465a910 20180423 23:40:57< irker856> wesnoth/wesnoth:1.14 Jyrki Vesterinen 9595307989 Fix rare crash in AI code AppVeyor: All builds passed 20180423 23:51:50-!- celmin|away is now known as celticminstrel 20180423 23:54:20< celticminstrel> The_Gnat's report about attack animations sounds like a blocker. 20180423 23:54:29< celticminstrel> https://forums.wesnoth.org/viewtopic.php?p=626436#p626436 --- Log closed Tue Apr 24 00:00:45 2018