--- Log opened Tue Apr 24 00:00:45 2018 20180424 00:47:05-!- gfg [~androirc@134.76.63.8] has joined #wesnoth-dev 20180424 00:47:41< celticminstrel> gfg, can you think of any way to add an event to a unit other than store+unstore? 20180424 00:49:01< gfg> I don't know if any other way 20180424 00:49:18< gfg> Why do you want events in units? 20180424 00:50:13< gfg> I mean you can probably make it a global event 20180424 00:51:16< celticminstrel> The point of putting it in the unit is as usual - it automatically gets added when the unit is recalled or otherwise placed on the map. 20180424 00:52:57< gfg> ye but if it doesn't do any harm if the unit does not exist, you could maybe also make it a global (campaign-wide) event 20180424 00:53:42< celticminstrel> Eh. 20180424 00:54:16< celticminstrel> I wanted to use an [effect] which is why I wanted a way without store+unstore, but if there's no way, I'll probably just not use an [effect]. 20180424 00:54:45< celticminstrel> I guess since it's the dominates events they could just be global. 20180424 00:57:44< gfg> Thinking about it, i wonder why we don't use campaign-wide events more often in mainline, for example current since campaigns have {..DEATHS} in every [scenario] but they could just put it once in [campaign] 20180424 00:58:02< celticminstrel> I should think the answer to that is obvious. 20180424 00:58:11< gfg> ? 20180424 00:58:23< celticminstrel> Campaign-level events are new for 1.13, aren't they? 20180424 00:58:31< gfg> ah right 20180424 00:59:08< celticminstrel> So basically it's just that no-one bothered to change it. 20180424 00:59:10< gfg> 1.13 went way to Long, glad it's over tomorrow 20180424 00:59:22< celticminstrel> Which is perfectly fine though, there's no need to update them/ 20180424 00:59:42< celticminstrel> That said I'll probably update my own campaign anyway. 20180424 00:59:57< celticminstrel> Having a death event for a unit that doesn't exist can't hurt, right? 20180424 01:00:38< gfg> Well it could speedup well parsing time by an unnoticable amount. 20180424 01:00:45< celticminstrel> Haha. 20180424 01:01:05< gfg> No that does not hurt 20180424 01:05:10< celticminstrel> I think it might be good to support an [effect] for adding unit events, but probably low priority. 20180424 01:05:41< celticminstrel> It'd probably need to store the events in the unit and also add them to the event manager? 20180424 01:05:57< celticminstrel> Since IIRC unit events are only handled when the unit is constructed/rebuilt/something like that. 20180424 01:32:01< irker856> wesnoth/wesnoth:master Charles Dang 17da211d1f Fixup 1942627 AppVeyor: All builds passed 20180424 02:32:10<+discordbot> Though sometimes you want to have an scenario where the death events are different, or not existing anymore. E.g. one unit dies in a scenario due to storyline reasons, but you don't want her to die earlier. 20180424 02:35:21-!- gfgt [~androirc@134.76.63.8] has joined #wesnoth-dev 20180424 02:36:30-!- gfg [~androirc@134.76.63.8] has quit [Ping timeout: 255 seconds] 20180424 02:54:16< celticminstrel> True. 20180424 02:54:45< celticminstrel> I also had a case in my campaign where I wanted a different death message if the unit dies right away (like within a few turns of appearing, roughly speaking). 20180424 02:55:00< celticminstrel> So what I did was remove the normal death event by ID and add a different one. 20180424 02:55:15< celticminstrel> These events are set at scenario level ATM, though. 20180424 02:56:01 * celticminstrel also added a cool little narrative message when a hero dies. 20180424 03:32:52<+discordbot> celmin: not a blocker 20180424 03:33:04< celticminstrel> Sounds like one though. 20180424 03:33:27< celticminstrel> Then again I'm not fully clear on what exactly he's seeing, so... 20180424 03:35:52<+discordbot> he's seeing a his unit play the se attack animation to attack a unit to the north 20180424 03:37:09< celticminstrel> But the slide is implemented via "offset", which represents its position relative to the centres of the two hexes involved.. AFAIK it shouldn't be possible for it to slide in the wrong direction. 20180424 03:37:45< celticminstrel> Playing the se animation isn't the issue IIUC, it's the slide created by the "offset" key that's somehow messed up. 20180424 03:37:57< celticminstrel> Unless of course that particular unit implements the slide differently for some reason. 20180424 03:38:19<+discordbot> probably does 20180424 03:39:18< celticminstrel> Well, we should check that out then. If it implements the slide differently, then one of two things would have to be true: 20180424 03:39:29< celticminstrel> (Assuming I correctly understand the animation WML) 20180424 03:40:13< celticminstrel> 1) It's not using [attack_anim] at all. IIUC you can use [animation] to add an animation for any event without the preset defaults. 20180424 03:40:24< celticminstrel> 2) It's explicitly overriding the "offset" key. 20180424 03:40:47< celticminstrel> So IOW it should be easy to check if that unit implements the slide in a unique way. 20180424 03:41:05< celticminstrel> BTW, another thing I wasn't clear on is, was that a mainline/core unit or a custom unit? 20180424 03:41:26<+discordbot> pretty sure it's the core drake 20180424 03:41:34< celticminstrel> 'kay 20180424 03:44:01<+discordbot> oh, yeah, I was going to ask you something 20180424 03:44:17<+discordbot> why was it again you implemented the move ctor of that specials_context_t in terms of a copy ctor? 20180424 03:45:32< celticminstrel> Because I didn't want to manually copy over all the fields. 20180424 03:45:51< celticminstrel> The default copy constructor does that for you automatically, so I figured I might as well leverage that. 20180424 03:46:48<+discordbot> but why was the copy ctor not called in the first place 20180424 03:47:38<+discordbot> or more specifically, why do we want a copy not a move? 20180424 03:49:29< celticminstrel> We just need to make sure that, if moved, the destructor doesn't reset state. 20180424 03:49:55< celticminstrel> After being moved from it doesn't matter what the state of the object is anymore; it's gonna be destroyed pretty soon anyway. 20180424 03:50:11< celticminstrel> The important thing is that all the state from the old object is now in the new object. 20180424 03:50:28<+discordbot> "reset state"? 20180424 03:50:36<+discordbot> I'm confused. Which state? 20180424 03:50:40<+discordbot> the weapon's? 20180424 03:50:50< celticminstrel> The purpose of the object is to manage a "resource". 20180424 03:51:10< celticminstrel> When constructed it sets some fields in the weapon that are used by the special ability testing functions. 20180424 03:51:25< celticminstrel> On destruct it resets these fields to a neutral state. 20180424 03:51:49< celticminstrel> A copy ctor satisfies all the requirements of a move ctor, and if you're dealing with simple data (as we are here), they literally do the exact same thing. 20180424 03:52:08< celticminstrel> The copy ctor isn't called because it's private, so the caller has no access to it. 20180424 03:52:30< celticminstrel> So it's only ever called from the move ctor. 20180424 03:54:42<+discordbot> ah, I see, it doesn't actually hold any data itself 20180424 03:55:06< celticminstrel> IIRC it just holds a copy of the previous state so it can reset it? 20180424 03:55:15< celticminstrel> I can't remember if I even did that much. 20180424 03:55:21< celticminstrel> I might not have. 20180424 03:55:47<+discordbot> no 20180424 04:02:01< irker856> wesnoth: Charles Dang wesnoth:master 0cdcfac5d3cb / src/units/animation.cpp: Unit/Animation: emplace_back (mostly) ahoy https://github.com/wesnoth/wesnoth/commit/0cdcfac5d3cb348e2785e62cb2979f16b8133338 20180424 04:02:04< irker856> wesnoth: Charles Dang wesnoth:master a1c440510ccd / src/units/attack_type.cpp: Unit/Attack Type: formatting cleanup https://github.com/wesnoth/wesnoth/commit/a1c440510ccde7fe95015697c99c3bb01e01a83a 20180424 04:02:07< irker856> wesnoth: Charles Dang wesnoth:master 1749de1521b3 / src/units/ (abilities.cpp attack_type.cpp): Units/Attack Type: moved the specials_context_t ctors to the more relevant file https://github.com/wesnoth/wesnoth/commit/1749de1521b368144591d250cc935d89f76353fb 20180424 04:02:18<+discordbot> god dammit github bot. why do you always lose your icon 😦 20180424 04:05:09<+discordbot> did you see my prefs hotkey cat name refactor earlier? 20180424 04:05:17<+discordbot> i fixed the problem you had had about keeping the names in sync with the enum 20180424 04:05:37-!- gallaecio [~quassel@188.79.96.255] has joined #wesnoth-dev 20180424 04:05:39< celticminstrel> I don't even remember that problem. 20180424 04:06:33<+discordbot> the TODO you left 20180424 04:07:06< celticminstrel> Heh, I don't even remember leaving a TODO about that... >_> 20180424 04:07:26<+discordbot> ¯_(ツ)_/¯ 20180424 04:14:33<+discordbot> I still wonder what unit_ability_list::get_extremum is supposed to be short for 20180424 04:14:58< celticminstrel> "short for"? 20180424 04:15:15< celticminstrel> I mean, the name makes it quite obvious what it's intended to do. 20180424 04:15:31< celticminstrel> Though I guess one might wonder, extremum of what? 20180424 04:15:49<+discordbot> .... 20180424 04:15:53<+discordbot> derp 20180424 04:16:00<+discordbot> I've been reading it wrong all this time xD 20180424 04:16:06< celticminstrel> Oh? 20180424 04:16:43<+discordbot> yeah, I've just always assumed it was a misspelling of "extra [something]" ...didn't look closely at it... 20180424 04:17:21<+discordbot> doesn't help my spellcheck flags it... 20180424 04:17:38< celticminstrel> It's not the most common of words, I guess. 20180424 04:23:35-!- celticminstrel is now known as celmin|sleep 20180424 04:44:08-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180424 04:44:42< irker856> wesnoth: Charles Dang wesnoth:master c7b869437004 / src/units/ (abilities.cpp types.cpp unit.hpp): Unit: replace unit_ability_list::push_back with an emplace_back impl https://github.com/wesnoth/wesnoth/commit/c7b8694370046426488e475c37d77349095a7eb1 20180424 04:57:21< irker856> wesnoth/wesnoth:1.14 gfgtdf 37c913c173 fix lua error in 2p_Dark_Forecast 2 AppVeyor: All builds passed 20180424 05:14:13< irker856> wesnoth: Charles Dang wesnoth:master d2b3a25b9e41 / src/units/race.cpp: Unit/Race: formatting cleanup https://github.com/wesnoth/wesnoth/commit/d2b3a25b9e41cf47216bdda9b3c626dd51b31aa6 20180424 05:16:56-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20180424 05:34:19-!- gallaecio [~quassel@188.79.96.255] has quit [Remote host closed the connection] 20180424 05:52:07-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180424 05:52:13-!- janebot_ [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180424 05:52:13-!- janebot_ is now known as janebot 20180424 05:56:16< irker856> wesnoth: Charles Dang wesnoth:master 098bc1c0e803 / src/units/ (race.cpp race.hpp): Unit/Race: made use of std::array https://github.com/wesnoth/wesnoth/commit/098bc1c0e80363087d13e45da3874ab624f3a700 20180424 06:03:32-!- gfgt [~androirc@134.76.63.8] has quit [Remote host closed the connection] 20180424 06:11:44-!- gallaecio [~quassel@252.red-79-153-179.dynamicip.rima-tde.net] has joined #wesnoth-dev 20180424 06:27:59< irker856> wesnoth: Nils Kneuper wesnoth:1.14 d4ad5b1bcc2b / po/ (wesnoth-low/sk.po wesnoth/sk.po): updated Slovak translation https://github.com/wesnoth/wesnoth/commit/d4ad5b1bcc2bab47f5afae91628378ac64be33ef 20180424 06:28:06< irker856> wesnoth: Nils Kneuper wesnoth:master 28fc12ebd0ae / po/ (wesnoth-low/sk.po wesnoth/sk.po): updated Slovak translation https://github.com/wesnoth/wesnoth/commit/28fc12ebd0aedec53ba577aedfab19d3fcde0495 20180424 06:29:16-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev 20180424 07:03:38-!- vladimirslavik [vslavik@nat/redhat/x-jzjmpsoxbysxaqmq] has joined #wesnoth-dev 20180424 07:06:08-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20180424 07:11:04< zookeeper> time still TBD? would be nice to know, at this point. 20180424 07:13:46<+discordbot> Assume it's 00:00 UTC. 20180424 07:14:55<+discordbot> I shouldn't even have to say it, but please, if you have anything to get into 1.14.0, make sure it's in there before the end of the day. And if it's anything untested or complicated, postpone it to 1.14.1. 20180424 07:16:11<+discordbot> The 1.14 branch will be in a hard string freeze and it will only accept critical bug fixes until 1.14.0 is announced (not tagged, announced). We don't want to see any unnecessary activity going on there in case a new tag is needed for any reason. 20180424 07:16:35<+discordbot> And make sure the changelog and players_changelog are both up to date. 20180424 07:19:02< Ivanovic> shadowm: so if I receive a translation update tomorrow morning (aka "24h from now") I should wait with commiting until I see somewhere that 1.14.0 is announced? 20180424 07:19:43<+discordbot> Translation and art updates are fine since they are not code changes. 20180424 07:19:51< Ivanovic> thanks 20180424 07:19:56< Ivanovic> off to work, CU 20180424 07:20:45<+discordbot> Also, if you want to notify someone in the Discord side, prefix the username with the @ character. 20180424 07:21:25-!- shadowm changed the topic of #wesnoth-dev to: 1.14.0 tag on April 25th (00:01 UTC), DO NOT PUSH UNTESTED OR OVER-REACHING CHANGES TO 1.14, announcement on May 1st (Steam launch 6 pm PST) | String and feature freeze on 1.14 branch | Wesnoth Developers Channel | >>> Want to help? Go here: https://r.wesnoth.org/t42911 (and thanks!) <<< | Discord Server: https://discord.gg/battleforwesnoth | Logs: http://irclogs.wesnoth.org | Bug tracke 20180424 07:27:33-!- vladimirslavik [vslavik@nat/redhat/x-jzjmpsoxbysxaqmq] has quit [Ping timeout: 256 seconds] 20180424 07:29:00< irker856> wesnoth: Charles Dang wesnoth:master f17703a76fc8 / data/campaigns/Under_the_Burning_Suns/images/ (11 files in 2 dirs): UtBS: initial set of new character portraits by LordBob (more to come) https://github.com/wesnoth/wesnoth/commit/f17703a76fc8c5d74e10198551946fb578818285 20180424 07:29:55< irker856> wesnoth: Charles Dang wesnoth:1.14 1f69b3490cb5 / data/campaigns/Under_the_Burning_Suns/images/ (11 files in 2 dirs): UtBS: initial set of new character portraits by LordBob (more to come) https://github.com/wesnoth/wesnoth/commit/1f69b3490cb56ef5d620bf5c561d9e6bee98a5aa 20180424 07:30:31<+discordbot> @zookeeper ping ping ping ping ping ping 20180424 07:30:36< zookeeper> yes 20180424 07:31:30<+discordbot> I'm guessing you're going to have to choose where Nym's moody variant should be used? 20180424 07:31:36<+discordbot> yes 20180424 07:32:03<+discordbot> And I believe there were talks of using angry Eloh at the end of her dialogue with Kaleh in Out of the Frying Pan when she threatens him. 20180424 07:32:18<+discordbot> also what to do with Zhul's "Shyde" variant... which... come to think of it... 20180424 07:32:26<+discordbot> ah 20180424 07:32:26<+discordbot> I see 20180424 07:34:48<+discordbot> so, Zhul starts as a Quenoth Shaman (level 2), but her portrait is a variant of the Quenoth Druid (level 3), the advancement option of the Shaman (nothing wrong with this). And she has a Shyde variant for level 4 20180424 07:34:50< zookeeper> i'm not going to comb through literally all of nym's lines to find where the variant fits, but i'll probably wire it into at least a few places that i can easily think of 20180424 07:34:54<+discordbot> how do I wire in said variant 20180424 07:35:01< zookeeper> i can do that 20180424 07:35:17<+discordbot> @zookeeper most obvious place for moody nym is the opening of S1 20180424 07:35:29<+discordbot> it's odd seeing her grin while discussing the destruction of the village 😛 20180424 07:35:46<+discordbot> @zookeeper can you do this in the next 40 hours? 20180424 07:36:09< zookeeper> yeah, shouldn't be a problem. i'll try to do most of it right now. 20180424 07:36:33<+discordbot> egrep -nRIi 'speaker\s*=\s*"?Nym"?' data/campaigns/Under_the_Burning_Suns 20180424 07:36:54<+discordbot> They are only 176 matches and it should be fairly easy for most of them to tell the mood of the scene. 20180424 07:37:06<+discordbot> @shadowm RE changelogs, can you add entries for those two MP infinite loading screen bugs if you think that's relevant? 20180424 07:37:11<+discordbot> if not nevermind 20180424 07:37:19<+discordbot> Can someone else do it? 20180424 07:37:34<+discordbot> As far as I am concerned they are very relevant. 20180424 07:37:58<+discordbot> alright, I'll do it 20180424 07:45:06<+discordbot> I just realized the MP lobby tab in the staging screen is rather misleading. 20180424 07:45:31<+discordbot> does the registered nickname change apply to the 1.15 server? 20180424 07:45:33<+discordbot> It doesn't update even when there's activity going on in the lobby so it's only useful as a reminder of the previous chat. 20180424 07:45:39<+discordbot> There is no 1.15 server yet. 20180424 07:45:56<+discordbot> Also there are no code changes yet. 20180424 07:46:17<+discordbot> so no changelog entry? 20180424 07:46:31<+discordbot> The registered nickname requirement is a pure config change specific to the official 1.14 instance. The code for implementing it has been around for several stable series (I said this last night in #general). 20180424 07:46:33-!- vladimirslavik [vslavik@nat/redhat/x-qtcnsdvwgkygxbic] has joined #wesnoth-dev 20180424 07:46:55<+discordbot> Nope, no changelog entry since the software is the same as before. 20180424 07:47:42< irker856> wesnoth: Charles Dang wesnoth:master a85b14cfb7be / changelog.md: Various changelog updates https://github.com/wesnoth/wesnoth/commit/a85b14cfb7bea97cd785df938bdbecd602afb1dc 20180424 07:47:57<+discordbot> https://cdn.discordapp.com/attachments/259976436490829825/438244690266161154/unknown.png 20180424 07:48:08< irker856> wesnoth: Charles Dang wesnoth:1.14 3dc51ef87fc3 / changelog.md: Various changelog updates https://github.com/wesnoth/wesnoth/commit/3dc51ef87fc32699461150ed534ad14468629def 20180424 07:48:18<+discordbot> ....when did that tab appear.... 20180424 07:48:23<+discordbot> Also yes I guess the nick line in the motd is not needed. 20180424 07:48:29<+discordbot> ... @jyrkive did you add this 20180424 07:48:38<+discordbot> I added it. It's the result of keeping chat history. 20180424 07:48:43<+discordbot> groans 20180424 07:49:07<+discordbot> That's the design I wanted originally, but @loonycyborg said it wasn't possible since lobby chat isn't sent to people in-game 20180424 07:49:16<+discordbot> if we want that chat to update, @loonycyborg needs to do something 20180424 07:49:17<+discordbot> Can you somehow indicate to players that it's not being updated and that writing to it is futile, or hide it until that can be sorted out later? 20180424 07:49:25<+discordbot> I asked him about it ages ago but he never got to it 20180424 07:49:47<+discordbot> I presume the lobby code can tell that it's in the staging screen and choose to hide the lobby tab. 20180424 07:49:49<+discordbot> Indicating that it's not being futile would require some UX design. 20180424 07:50:02<+discordbot> Hiding it in the staging screen would be easy. 20180424 07:50:17<+discordbot> Please do, because as it is it'll only confuse players. 20180424 07:50:29<+discordbot> They'll try to write to it and then wonder why no-one in the lobby is reading them. 20180424 07:50:36<+discordbot> OK, will do in the evening (about nine hours from now). 20180424 07:59:10<+discordbot> This crops up every now and then in multiplayer: 20180424 04:58:48 error lobby: Error while applying the gamelist diff: 'error in diff: could not find element 'game'' Getting a new gamelist. 20180424 04:58:48 error lobby: process_gamelist_diff failed! 20180424 08:00:53<+discordbot> Also I just surrendered just as the game started (while it wasn't my turn) and this happened: 20180424 08:00:54<+discordbot> https://cdn.discordapp.com/attachments/259976436490829825/438247946450894848/unknown.png 20180424 08:01:42<+discordbot> The other client only got the ShikadiQueen has surrendered. message. I ended my turn there and I'm still able to play after surrendering. 20180424 08:02:15<+discordbot> And it keeps saying (unknown) is not in this game if I try again. 20180424 08:02:39<+discordbot> That's my host side, incidentally. 20180424 08:03:19<+discordbot> If I surrender while playing the side that isn't the host, it works and transfers control of that side to the host: 20180424 08:03:20<+discordbot> https://cdn.discordapp.com/attachments/259976436490829825/438248559737962498/unknown.png 20180424 08:05:20<+discordbot> This might be related to Shuffle Sides, since that's how I got the host side to not be the first one player in the first place. 20180424 08:05:38<+discordbot> I started a new game without Shuffle Sides enabled and surrendered immediately during my (host) turn and it worked. 20180424 08:06:48<+discordbot> that damn setting...file a bug 20180424 08:08:07<+discordbot> gfgtdf or whoever: Strictly speaking, who does surrendering actually transfer your side's control to? Is it always the host? And what happens if the surrendering side is already controlled by the host and there's more than one player in the game? I need to know this for the 1.14 announcement. 20180424 08:08:31<+discordbot> (This is also something that the game should tell you in some way. Poor UX here.) 20180424 08:13:20<+discordbot> I can't remember now the conclusion we came to RE the surrender discussion 20180424 08:38:02-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity] 20180424 09:00:32< irker856> wesnoth: ln-zookeeper wesnoth:1.14 6ca5712b7c92 / data/campaigns/Under_the_Burning_Suns/units/quenoth/ (Marksman.cfg Sun_Singer.cfg Sun_Sylph.cfg): UtBS: Fixed some missing/erroneous special notes https://github.com/wesnoth/wesnoth/commit/6ca5712b7c92e33bfa4d05e4632de77269d50738 20180424 09:16:28< irker856> wesnoth: ln-zookeeper wesnoth:1.14 f8971ed6e915 / data/campaigns/Under_the_Burning_Suns/ (scenarios/13_Epilogue.cfg utils/character-definitions.cfg): UtBS: Wire in Zhul's winged portrait variation https://github.com/wesnoth/wesnoth/commit/f8971ed6e915bbdf993cdaf93fd47791d6962b5b 20180424 09:43:56<+discordbot> @zookeeper and you're working on nym? 20180424 09:44:01< zookeeper> yes 20180424 09:44:35< zookeeper> btw, you don't need to use @, all it does is make discord highlight me as well :p 20180424 10:08:06<+discordbot> well then I make doubly sure you see 😛 20180424 10:08:17<+discordbot> (also I don't get autocomplete without it) 20180424 10:08:48< irker856> wesnoth: ln-zookeeper wesnoth:1.14 48cf35bcdfa1 / data/campaigns/Under_the_Burning_Suns/ (10 files in 2 dirs): UtBS: Wire in Nym's moody portrait variation https://github.com/wesnoth/wesnoth/commit/48cf35bcdfa1cf248a996da97972e56507f6ed8d 20180424 10:09:36< zookeeper> no one wants to pofix one small grammar typo this late, i take it? 20180424 10:10:57<+discordbot> not I 20180424 10:11:47<+discordbot> don't forget to forward-port 20180424 10:12:04< irker856> wesnoth/wesnoth:master Charles Dang 1749de1521 Units/Attack Type: moved the specials_co AppVeyor: All builds passed 20180424 10:12:31<+discordbot> zookeeper: Could you elaborate? 20180424 10:14:13<+discordbot> I really need to start writing the press release... 20180424 10:15:11<+discordbot> I'm working on it right now. 20180424 10:15:27<+discordbot> Instead of sleeping. 20180424 10:15:42<+discordbot> ❤ 20180424 10:16:21<+discordbot> I don't know how to explain the music-off-on-focus-loss feature lol. 20180424 10:17:06<+discordbot> It's the one thing in this release series that doesn't make any sense to me from a practical standpoint and just sounds like minor coding exercise. 20180424 10:17:12<+discordbot> *like a 20180424 10:17:27< zookeeper> elaborate on... uh, what? 20180424 10:17:32< zookeeper> oh right 20180424 10:17:33<+discordbot> Pofix 20180424 10:17:33<+discordbot> Well, I think most games do that 20180424 10:17:40< zookeeper> duh, i forgot already 20180424 10:17:49<+discordbot> Yes, I know they do but I don't really understand why. 20180424 10:18:14<+discordbot> it's so people can page out of the app and do other stuff while something is happening 20180424 10:18:19<+discordbot> for example 20180424 10:18:22<+discordbot> when im playing dota 20180424 10:18:25< zookeeper> UtBS S10 has "the one thing she not will be anticipating" 20180424 10:18:38<+discordbot> ill page out and do something else while I'm finding a match 20180424 10:18:41<+discordbot> Having the sounds in the background never really stopped me from switching windows before. 20180424 10:19:09<+discordbot> @zookeeper that's not pofixable, AFAIK 20180424 10:19:16<+discordbot> Anyway I'm leaving that task to you. You do have to rewrite 90% of my prose into better English after all. 20180424 10:19:38< zookeeper> ...how can something not be pofixable? 20180424 10:19:49<+discordbot> if it changes the meaning of the sentence 20180424 10:19:51<+discordbot> Also why does zookeeper's request give me déjà vu to something from that same scenario back during 1.12 beta?? 20180424 10:20:22<+discordbot> I hope it's not the same string I'm thinking of because I remember coming to the conclusion that it wasn't pofixable due to a gettext technicality. 20180424 10:21:52<+discordbot> this? https://github.com/wesnoth/wesnoth/commit/ff3f5daf6c92c1d36c1b6f943dd3e4832ace2b83 20180424 10:29:18< irker856> wesnoth: ln-zookeeper wesnoth:1.14 f108f0771c2e / data/campaigns/Under_the_Burning_Suns/scenarios/08_Out_of_the_Frying_Pan.cfg: UtBS S08: Use Eloh's raged portrait variation when she gets angry https://github.com/wesnoth/wesnoth/commit/f108f0771c2eeda9ef81ca82b880715525cae6d0 20180424 10:29:29<+discordbot> wait a minute 20180424 10:29:34<+discordbot> ,,,,,,, 20180424 10:30:03<+discordbot> it's... 10:30 AM UTC Tuesday right now. 20180424 10:30:18< zookeeper> i was just about to ask what was that about 40 hours. 20180424 10:30:20<+discordbot> Yeah and? 20180424 10:30:28<+discordbot> It's not the 25th yet. 20180424 10:30:34<+discordbot> That implies the release is in 14 hours 20180424 10:30:35<+discordbot> not 40 20180424 10:30:50<+discordbot> I added an extra day in here somewhere... 20180424 10:31:08<+discordbot> le sigh 20180424 10:31:22<+discordbot> ONE EXTRA DAY IS BEING ADDED. 20180424 10:31:41< zookeeper> really? ohh... luxurious. then i can start slacking off immediately. 20180424 10:32:31<+discordbot> No. 20180424 10:32:45<+discordbot> It's not for you. I told LB he had almost 2 days left earlier today. 20180424 10:32:47<+discordbot> You should continue operating under the assumption that it is today and ignore Vultraz's mistake. 20180424 10:33:18<+discordbot> So, since I fucked up, we'll just have to live with it 20180424 10:33:47<+discordbot> Release is now in... 37.5 hours. 20180424 10:33:55< zookeeper> the other portraits don't really matter that much, but elyssa would be most excellent to have in. 20180424 10:34:12<+discordbot> Go and update the IRC topic yourself Vultraz, I'm not in the right mindset to do maths right now. 20180424 10:34:20<+discordbot> He said he can finish one today but not two. 20180424 10:34:59<+discordbot> Why is the wiki page called ImagePathFunctionWML and not ImagePathFunctionsWML istg 20180424 10:35:05<+discordbot> no idea 20180424 10:35:46<+discordbot> celticminstrel: Explain to me what you (or someone else but it was probably you and you probably know anyway) mean in the announcement outline by "Allow use of WFL in many new places [...] even some Image path Functions". 20180424 10:35:52< zookeeper> same reason why FilterWML is not FiltersWML? 20180424 10:36:16<+discordbot> That doesn't make sense. 20180424 10:36:34<+discordbot> Actually, okay it does. 20180424 10:36:41<+discordbot> (also Jetrel still has his sprite edit incoming) 20180424 10:36:49<+discordbot> so yeah, we need this extra day 20180424 10:37:15< zookeeper> what sprite edit? 20180424 10:37:50<+discordbot> to the absolutely horrible ugly no good very bad UtBS Quenoth Shyde sprite 20180424 10:43:55< zookeeper> i guess i'll remove the naga hunter portrait too... 20180424 10:44:11<+discordbot> Yeah, please do, I forgot to mention that yesterday. 20180424 10:44:51<+discordbot> The generic naga portrait could probably be used instead if there's any chance that the Naga Hunter will speak in the campaign. 20180424 10:46:31< zookeeper> yeah. 20180424 10:48:16< irker856> wesnoth: ln-zookeeper wesnoth:1.14 800418555eb6 / data/campaigns/Under_the_Burning_Suns/ (images/portraits/naga-with-bow.png units/nagas/Naga_Hunter.cfg): UtBS: Remove old Naga Hunter portrait and use core Naga Fighter instead https://github.com/wesnoth/wesnoth/commit/800418555eb6b32110e9d45febea6515dab58bd6 20180424 10:49:38< zookeeper> i might do some other minor fiddling with something tonight, but i'll be mostly afk for at least 8 hours. 20180424 10:50:02<+discordbot> port? 20180424 10:50:05< zookeeper> unless there was something important i'm forgetting 20180424 10:50:11<+discordbot> forward-port to master? 20180424 10:50:14< zookeeper> yeah, i guess i might as well do that now rather than later... 20180424 11:00:06-!- vslavik [vslavik@nat/redhat/x-whonnzmgqmwhuqyy] has joined #wesnoth-dev 20180424 11:02:16< irker856> wesnoth: ln-zookeeper wesnoth:master ec63cff8fbdd / data/campaigns/Under_the_Burning_Suns/units/quenoth/ (Marksman.cfg Sun_Singer.cfg Sun_Sylph.cfg): UtBS: Fixed some missing/erroneous special notes https://github.com/wesnoth/wesnoth/commit/ec63cff8fbddd353bc54e6bb9fbce20d55b154ff 20180424 11:02:18< irker856> wesnoth: ln-zookeeper wesnoth:master 71178e99f83d / data/campaigns/Under_the_Burning_Suns/ (scenarios/13_Epilogue.cfg utils/character-definitions.cfg): UtBS: Wire in Zhul's winged portrait variation https://github.com/wesnoth/wesnoth/commit/71178e99f83d87361e45a2d52cff79dc57655e8e 20180424 11:02:20< irker856> wesnoth: ln-zookeeper wesnoth:master 8c2df1f18cab / data/campaigns/Under_the_Burning_Suns/ (10 files in 2 dirs): UtBS: Wire in Nym's moody portrait variation https://github.com/wesnoth/wesnoth/commit/8c2df1f18cabf943b358998e59cce6c089678b67 20180424 11:02:22< irker856> wesnoth: ln-zookeeper wesnoth:master 2bb16149af78 / data/campaigns/Under_the_Burning_Suns/scenarios/08_Out_of_the_Frying_Pan.cfg: UtBS S08: Use Eloh's raged portrait variation when she gets angry https://github.com/wesnoth/wesnoth/commit/2bb16149af7847a4f790baeb7f47d50edc3f61a6 20180424 11:02:24< irker856> wesnoth: ln-zookeeper wesnoth:master 02ef3a6a99f0 / data/campaigns/Under_the_Burning_Suns/ (images/portraits/naga-with-bow.png units/nagas/Naga_Hunter.cfg): UtBS: Remove old Naga Hunter portrait and use core Naga Fighter instead https://github.com/wesnoth/wesnoth/commit/02ef3a6a99f089acef891654d0c6877806e7ad60 20180424 11:02:25-!- vladimirslavik [vslavik@nat/redhat/x-qtcnsdvwgkygxbic] has quit [Ping timeout: 248 seconds] 20180424 11:16:24<+discordbot> lol ok https://wiki.wesnoth.org/MapGeneratorWML#The_lua_generator 20180424 11:16:30<+discordbot> "(Version 1.13.x (please read the template documentation to set the correct version number) and later only)" 20180424 11:16:57<+discordbot> Someone didn't bother to read the documentation. 20180424 11:17:06<+discordbot> (gfgtdf probably) 20180424 11:23:56-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180424 11:24:03-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180424 11:30:37< irker856> wesnoth: Iris Morelle website:master 11e6b0ccc61f / start/1.14/template.html: announcement/1.14: Very rough initial draft full of mistakes and TODOs https://github.com/wesnoth/website/commit/11e6b0ccc61fcdb05eb0171f52c4c79740e6d266 20180424 11:30:45<+discordbot> @Vultraz 20180424 11:31:16<+discordbot> Thanks! 20180424 11:31:20<+discordbot> It's a mess. 20180424 11:31:48<+discordbot> And yes I'll work on the screenshots — but only after something closer to the definitive text is there. 20180424 11:32:30<+discordbot> (Also since I know someone will ask eventually: no, the Steam link in there does not work yet, and yes, it'll take you to the store front page in the meantime.) 20180424 11:33:24<+discordbot> Also remind me, is there anything in mainline in 1.14 using CC BY-SA? If so the first paragraph in the Download section could use some tweaks. 20180424 11:34:47< irker856> wesnoth: Iris Morelle website:master 11244ef158ae / start/1.14/template.html: announcement/1.14: It's GNU GPL v2+, not GNU GPL https://github.com/wesnoth/website/commit/11244ef158aecc9980c36758ada6edabc8f0086b 20180424 11:34:48<+discordbot> "Note that while the option to use a folder in the installation path to store player files is gone, it is still possible to create a shortcut with certain command-line options to get this behavior back for those who might prefer to carry Wesnoth around on a thumb drive or the like." 20180424 11:35:06<+discordbot> Someone write me a wiki page to link there ty in advance. 20180424 11:35:24<+discordbot> Shortcuts won't work for that, they use absolute paths (including the drive letter, which changes when a removable drive is used on multiple PCs). 20180424 11:35:37<+discordbot> Yes, they do work for that. 20180424 11:36:10<+discordbot> Wait, do you need an absolute path for the executable? 20180424 11:36:23<+discordbot> If so they can write a .cmd, I don't know. WIKI PAGE PLS. 20180424 11:36:47<+discordbot> I know I specifically went through hurdles to get relative paths working at our end. 20180424 11:36:59<+discordbot> Yeah, I recommend a batch file for that. 20180424 11:37:13<+discordbot> So --config-dir .\userdata in the command-line would do exactly what you'd expect it to do. 20180424 11:37:39<+discordbot> I don't remember the specifics, but I went into great detail about it in the 1.13.2 announcement and then never got around to making a wiki page out of it. 20180424 11:38:19<+discordbot> And now before I get some sleep, pofix... 20180424 11:41:34<+discordbot> pofix: po/wesnoth-units/wesnoth-units.pot already includes the new string "the single-minded tenacity of an oak." but also the old "the singleminded tenacity of an oak." 20180424 11:41:35<+discordbot> gah 20180424 11:42:10<+discordbot> Good job THoT. 20180424 11:42:59<+discordbot> That can just be ignored, it'll be fixed in the next pot update after I push the relevant WML commit. 20180424 11:45:08-!- vslavik__ [vslavik@nat/redhat/x-rkgfvuadumcyforb] has joined #wesnoth-dev 20180424 11:47:49-!- vslavik [vslavik@nat/redhat/x-whonnzmgqmwhuqyy] has quit [Ping timeout: 260 seconds] 20180424 11:50:12<+discordbot> pofix's history diverged a lot between master and 1.14 20180424 11:50:15<+discordbot> Why. 20180424 11:51:24<+discordbot> Let me identify the diverging commits and can we please acknowledge the fact that I'm literally about to fall asleep and have to deal with a sidequest that wasn't really laid out for me ONLY because people can't port patches across branches in a consistent fashion? 20180424 11:52:09<+discordbot> oh shit. that was me 20180424 11:52:13<+discordbot> 08:52:00 shadowm@hanacore ~/src/wesnoth-1.14 git:1.14 % git log --format=oneline 1.13.12..HEAD -- utils/pofix.py | wc -l 5 08:51:45 shadowm@hanacore ~/src/wesnoth git:master % git log --format=oneline 1.13.12..HEAD -- utils/pofix.py | wc -l 1 20180424 11:52:20<+discordbot> Not just you, celticminstrel as well. 20180424 11:53:18<+discordbot> Someone explain to me why commit fb866c6d1310d8398f0f481a8ab16b1606286cdd doesn't have a counterpart in 1.14. 20180424 11:55:15<+discordbot> dunefolk description's not in 1.14 20180424 11:55:24<+discordbot> Then why does this pofix entry exist 20180424 11:55:28<+discordbot> I don't know 20180424 11:57:35<+discordbot> will the Dunefolk description become partof 1.14.1 or is it only for master? 20180424 11:57:46-!- midzer_ [~quassel@p5B0517E4.dip0.t-ipconnect.de] has joined #wesnoth-dev 20180424 11:59:55-!- midzer_ is now known as midzer 20180424 12:00:26<+discordbot> Wheeeeeeeeeeeeeee 20180424 12:00:34< irker856> wesnoth: Iris Morelle wesnoth:master f6a369a1d0bb / data/campaigns/The_Hammer_of_Thursagan/units/Dwarvish_Masked_Sentinel.cfg: THoT: Port prose punctuation fix from core https://github.com/wesnoth/wesnoth/commit/f6a369a1d0bbed9e8cdba982cc2605258f0c1380 20180424 12:00:37< irker856> wesnoth: Iris Morelle wesnoth:master 70257c9af777 / data/campaigns/Under_the_Burning_Suns/scenarios/10_Speaking_with_the_Fishes.cfg: UtBS S10: Fix typo reported by zookeeper https://github.com/wesnoth/wesnoth/commit/70257c9af777da0ae9b6df697c5fa552797c161d 20180424 12:00:40< irker856> wesnoth: Iris Morelle wesnoth:master 4d5a3de4e63e / data/core/units.cfg utils/pofix.py: Revert "'moreso' isn't a word in any dialect of English." https://github.com/wesnoth/wesnoth/commit/4d5a3de4e63ebaac4a853b0f724d1d342d451dd0 20180424 12:00:43< irker856> wesnoth: Charles Dang wesnoth:master 9531e29b5d71 / utils/pofix.py: Pofix entry for ab9f29a7a44372a3e3703fd842740a9b425b6f5f https://github.com/wesnoth/wesnoth/commit/9531e29b5d71965af8b4f7ec3991060056ca8296 20180424 12:00:46< irker856> wesnoth: Charles Dang wesnoth:master c638d71bf9f1 / utils/pofix.py: Pofix entry for b86a2968fe87a7e4112e900070446d4a83808202 https://github.com/wesnoth/wesnoth/commit/c638d71bf9f1d08fb885a3915298b7008a6b4481 20180424 12:00:49< irker856> wesnoth: Charles Dang wesnoth:master 087d9bb5afd7 / utils/pofix.py: Pofix entry for fc6c3ac04b899b4c7f629a1cd8d80101c7cbb20c https://github.com/wesnoth/wesnoth/commit/087d9bb5afd79aca926ed3f752d700a724e60a0e 20180424 12:00:50<+discordbot> zookeeper: Done. 20180424 12:00:52< irker856> wesnoth: Celtic Minstrel wesnoth:master 3768dc687d9f / utils/pofix.py: Fix pofix https://github.com/wesnoth/wesnoth/commit/3768dc687d9f8a709243912f7388f2917d20e2db 20180424 12:00:54< irker856> wesnoth: Iris Morelle wesnoth:master a2cfb3cf4c5c / po/wesnoth-sota/ (61 files): Run pofix for wesnoth-sota changes that were just fwd-ported to master https://github.com/wesnoth/wesnoth/commit/a2cfb3cf4c5ca5e94ec1ef4678d58608c7f686ed 20180424 12:00:57< irker856> wesnoth: Iris Morelle wesnoth:master f52828db88a5 / / (60 files in 2 dirs): pofix changes for UtBS S10 typo fix https://github.com/wesnoth/wesnoth/commit/f52828db88a5d1b20c4bd8225211533ac5b694df 20180424 12:01:00< irker856> wesnoth: Iris Morelle wesnoth:1.14 50949824324e / data/campaigns/The_Hammer_of_Thursagan/units/Dwarvish_Masked_Sentinel.cfg: THoT: Port prose punctuation fix from core https://github.com/wesnoth/wesnoth/commit/50949824324eebd16a1c28b66cbcddd9fd7379e1 20180424 12:01:03< irker856> wesnoth: Iris Morelle wesnoth:1.14 e03c3a09fafc / data/campaigns/Under_the_Burning_Suns/scenarios/10_Speaking_with_the_Fishes.cfg: UtBS S10: Fix typo reported by zookeeper https://github.com/wesnoth/wesnoth/commit/e03c3a09fafcf9cde08b4ab3a2f54b241ed99bfb 20180424 12:01:06< irker856> wesnoth: Iris Morelle wesnoth:1.14 6cb07f5968cd / / (60 files in 2 dirs): pofix changes for UtBS S10 typo fix https://github.com/wesnoth/wesnoth/commit/6cb07f5968cde8e1a5de2cb8930c7e6d8944c30f 20180424 12:01:13< zookeeper> yay 20180424 12:02:52<+discordbot> it can go into 1.14.1 20180424 12:04:04<+discordbot> I reckon some of the translators will want to put your head on a stake if you only give them a week for updating. 20180424 12:04:22<+discordbot> But more on that later now I need to sleep. 20180424 12:04:30<+discordbot> indeed 20180424 12:04:31<+discordbot> Indeed, 1.14.2 is a more reasonable goal. 20180424 12:04:32<+discordbot> At 9 am. 20180424 12:04:43-!- midzer [~quassel@p5B0517E4.dip0.t-ipconnect.de] has left #wesnoth-dev ["http://quassel-irc.org - Chat comfortably. Anywhere."] 20180424 12:04:52<+discordbot> I think 1.14.1 is good enough if you give them a little extra time. 20180424 12:05:26<+discordbot> Not sure if we can afford that. We may well need a bugfix release very soon after 1.14.0. 20180424 12:05:30<+discordbot> all these strings will go in immediately after 1.14 is announced and I intend to impose an immediate (or close to) string freeze again. 20180424 12:05:39<+discordbot> Buh 20180424 12:05:40<+discordbot> Easier to just delay string changes (at least the biggest ones) to 1.14.2. 20180424 12:06:09<+discordbot> I was already considering a staggered approach for the string merges the moment I was told 1.14.1 might come two weeks after 1.14.0 tbh. 20180424 12:07:15<+discordbot> Alternatively it might be possible to string-freeze 1.14.1 at the start of the first week immediately, but then you may run into situations where you need to thaw strings again. 20180424 12:08:14<+discordbot> I think we made sure to add all of the string pull requests and bugs to the 1.14.1 milestone so it shouldn't take much work to decide which ones can go in 1.14.1 and which ones can be postponed for 1.14.2 though. 20180424 12:08:27<+discordbot> (Read: if the Dunefolk description isn't a PR yet, make it so now.) 20180424 12:08:46<+discordbot> (Also, wasn't there another race description pending a merge in the forums? Woses or something?) 20180424 12:08:47<+discordbot> it's still awaiting a final tweak on master 20180424 12:08:53<+discordbot> where? 20180424 12:09:39<+discordbot> ..............oh fucking hell 20180424 12:09:41<+discordbot> that reminds me 20180424 12:09:56<+discordbot> I vaguely remembering someone complaining that a good description that was approved by devs was never added to mainline. 20180424 12:09:58<+discordbot> we never re-enabled that percentage-complete filter criteria for the language selection menu 20180424 12:09:59<+discordbot> remember 20180424 12:10:04<+discordbot> look i already forgot how to english 20180424 12:10:13<+discordbot> fuck. 20180424 12:10:15<+discordbot> ugh 20180424 12:10:22<+discordbot> ok, we can discuss that later 20180424 12:11:49<+discordbot> Oh also I forgot to mention the Spanish translation maintainer approved my translation of the Steam metadata. 20180424 12:11:52<+discordbot> So yay me. 20180424 12:12:09<+discordbot> I would be very surprised if that were not so 20180424 12:12:17<+discordbot> What's the deadline for adding them to Steam? 20180424 12:12:25<+discordbot> Since you said something about an approval process. 20180424 12:12:43<+discordbot> Also I guess that question also applies to the capsule images you wanted ugh, haven't even looked that up yet. 20180424 12:12:51<+discordbot> I'll do that 20180424 12:12:57<+discordbot> Do what? 20180424 12:13:12<+discordbot> the capsule images 20180424 12:13:23<+discordbot> Oh okay, one less thing for me to worry about. 20180424 12:14:11<+discordbot> ahhh crap. 3-5... 20180424 12:14:31<+discordbot> alright need to get pent those screenshot criteria tonight... 20180424 12:14:35<+discordbot> So until the 26th, got it. 20180424 12:14:42<+discordbot> Go tell the i18n mailing list for me. 20180424 12:14:52<+discordbot> I don't want to be the bearer of bad news like I usually am. 20180424 12:14:59<+discordbot> business days 😐 20180424 12:15:06<+discordbot> e 20180424 12:15:26<+discordbot> Are you sure Saturday 5th wouldn't be a better release date 20180424 12:15:47<+discordbot> ah wait 20180424 12:15:51<+discordbot> wait 20180424 12:15:53<+discordbot> that's just the build 20180424 12:16:03<+discordbot> or 20180424 12:16:04<+discordbot> wait 20180424 12:16:15<+discordbot> no, the store page needs to be done before they can review 20180424 12:16:26<+discordbot> but the translations are not required for release 20180424 12:16:28<+discordbot> according to Steam 20180424 12:16:33<+discordbot> ie, it doesn't block the review 20180424 12:16:43<+discordbot> Oh good then. 20180424 12:17:01<+discordbot> I'll get the ones that are already there in later today anyway. 20180424 12:18:02<+discordbot> @jyrkive can you handle uploading the trailer? You have the fastest net 20180424 12:18:18<+discordbot> Fastest upload speed. 20180424 12:18:38<+discordbot> It's 100M in/10M out. 20180424 12:18:57<+discordbot> (IRC users: I edited the word to "download") 20180424 12:19:21<+discordbot> We're using the 1.12 one ancestral made and for some damn reason Steam doesn't just accept a YT link. So someone with good net needs to download, then upload this: http://mproud.com/wesnoth/trailer.mp4 (ancestral could not do it for employer-related reasons) 20180424 12:20:25<+discordbot> Also I'm gonna need someone to go over what I wrote about SotA in the announcement predraft and make sure I'm not talking absolute nonsense that doesn't reflect the plot at all. 20180424 12:20:32<+discordbot> Zzzzzz 20180424 12:21:13<+discordbot> @Vultraz Also, how do I access the page where I can upload that trailer? (Feel free to answer in a DM.) 20180424 12:22:02<+discordbot> The only change I saw in Steam was that Wesnoth appeared in my account. That, on its own, isn't useful for editing or even viewing the store page. 20180424 12:24:35<+discordbot> We of course can't mark the Steam build as done until the 1.14 packages are added. 20180424 12:24:36<+discordbot> So... 20180424 12:24:49<+discordbot> we need to get all the remaining stuff done in the next 40 hours or so 20180424 12:25:21<+discordbot> hopefully loony and hrubmar can get the packages build quickly after tagging. 20180424 12:27:51<+discordbot> @jyrkive don't forget the "hide lobby tab in staging" fix too 20180424 12:28:14<+discordbot> Sure, I wasn't planning to forget it. 😉 20180424 12:40:39< Ravana_> I understand there is no time for it currently, but ideal solution would be working lobby tab in staging rather than hiding it 20180424 12:41:20<+discordbot> A "working lobby tab" would require server-side changes. I don't have sufficient knowledge of the server codebase. 20180424 12:41:41<+discordbot> Wasn't there a 1.14 trailer being worked on? 20180424 13:03:29-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180424 13:03:35-!- vslavik [vslavik@nat/redhat/x-dxynwkdxnomrdfyb] has joined #wesnoth-dev 20180424 13:03:35-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180424 13:06:07-!- vslavik__ [vslavik@nat/redhat/x-rkgfvuadumcyforb] has quit [Ping timeout: 256 seconds] 20180424 13:25:10-!- gfg [~androirc@tmo-102-99.customers.d1-online.com] has joined #wesnoth-dev 20180424 13:32:56< irker856> wesnoth: Severin Glöckner wesnoth:1.14 864d8677f207 / data/campaigns/Under_the_Burning_Suns/units/quenoth/Divine_Incarnation.cfg: UtBS: readd do_not_list https://github.com/wesnoth/wesnoth/commit/864d8677f207ded5f4347942e1e95afcf59bc555 20180424 13:45:56<+discordbot> I don't see anything on https://wiki.wesnoth.org/ImagePathFunctionWML about WFL support. But of course you can embed WFL with $( ) in any string 20180424 13:52:57< irker856> wesnoth/wesnoth:master Charles Dang a85b14cfb7 Various changelog updates AppVeyor: All builds passed 20180424 14:06:52-!- vihta [sid239753@gateway/web/irccloud.com/x-dukdbmfjujqremmx] has quit [] 20180424 14:07:20-!- vihta [sid239753@gateway/web/irccloud.com/x-ewfazhkreptnazzq] has joined #wesnoth-dev 20180424 14:11:12<+discordbot> that isn't precisely true. 20180424 14:11:16<+discordbot> as far as I know 20180424 14:11:39<+discordbot> @Pentarctagon plans fell through. weren't able to find someone to work on it in time 20180424 14:12:07-!- vslavik__ [vslavik@nat/redhat/x-gbaulkgmjifpozwl] has joined #wesnoth-dev 20180424 14:12:36<+discordbot> @Ravana yes, hopefully loony can make the necessary server-side changes at some point 20180424 14:14:25-!- vslavik [vslavik@nat/redhat/x-dxynwkdxnomrdfyb] has quit [Ping timeout: 248 seconds] 20180424 14:19:36<+discordbot> "that isn't precisely true." right, I mean any string where var substitution works. but it's just contextless WFL if you use $( ), there's no "me" 20180424 14:21:25<+discordbot> I think we need a WML tag that allows passing context and unescaped strings to WFL 20180424 14:21:35-!- gfgt [~androirc@ersc142.goemobile.de] has joined #wesnoth-dev 20180424 14:24:14-!- gfg [~androirc@tmo-102-99.customers.d1-online.com] has quit [Read error: Connection reset by peer] 20180424 14:25:11<+discordbot> for example, if I pass a unit as context then I can write x and y as shorthand for that unit's variables 20180424 14:27:45<+discordbot> except that's not WFL? 20180424 14:28:19<+discordbot> we are talking about Formula AI Language, right? 20180424 14:29:02<+discordbot> sadly, my proposed acronym of FAIL didn't take off 20180424 14:33:52<+discordbot> WFL is FAI, basically 20180424 14:34:00<+discordbot> except FAI has access to more stuff 20180424 14:34:31<+discordbot> we have too many damn subsystems >_> 20180424 14:34:36<+discordbot> https://wiki.wesnoth.org/SyntaxWML#Special_Attribute_Values key = "$(formula-expression)" 20180424 14:35:33<+discordbot> lol... I remember one guy in irc who wanted to rewrite wesnoth in python, back when we had python 20180424 14:35:42<+discordbot> 🤦 20180424 14:36:14<+discordbot> I wonder if we could toss FAI in favor of lua 20180424 14:37:23<+discordbot> and integrate WFL with WML key value parsing (ie, treat the whole thing as WFL) 20180424 14:37:27<+discordbot> for sure, if we had Lua first then FAI would never have been added. 20180424 14:37:58<+discordbot> that was Dragonking's experiment which I thought was insane at the time but actually became decent 20180424 14:38:13<+discordbot> I'm guessing WFL came first 20180424 14:38:15<+discordbot> then FAI on top 20180424 14:39:01<+discordbot> Frogatto took the formula language, expanded it, and then when they split off their engine it became part of Anura 20180424 14:39:19<+discordbot> yes, I am aware 20180424 14:39:32-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180424 14:39:53<+discordbot> FFL is obviously much more featured than what we have 20180424 14:39:59<+discordbot> but it's recognizably the same, still 20180424 14:40:11<+discordbot> except now it has stuff like strict typing 20180424 14:40:13<+discordbot> which is nice 20180424 14:41:31<+discordbot> the fact that Lua uses 1-based index is annoying... that's one argument against embedding it in WML attributes 20180424 14:43:13<+discordbot> just imagine you could have $wml_arr[0] and lua_arr[1] in the same $( ) 20180424 15:11:03-!- Oebele [~quassel@143.177.58.202] has joined #wesnoth-dev 20180424 15:11:16-!- vslavik__ [vslavik@nat/redhat/x-gbaulkgmjifpozwl] has quit [Quit: Leaving] 20180424 15:39:44-!- gallaecio [~quassel@252.red-79-153-179.dynamicip.rima-tde.net] has quit [Remote host closed the connection] 20180424 15:42:03-!- gfgt [~androirc@ersc142.goemobile.de] has quit [Ping timeout: 256 seconds] 20180424 15:58:04-!- gallaecio [~quassel@188.79.96.255] has joined #wesnoth-dev 20180424 16:04:27<+discordbot> @Vultraz Trailer uploaded. 20180424 16:04:41<+discordbot> thanks 👍 20180424 16:18:23< irker856> wesnoth: Jyrki Vesterinen wesnoth:1.14 1940f3d67c9d / src/gui/ (4 files in 2 dirs): Hide lobby chat log in MP staging screen https://github.com/wesnoth/wesnoth/commit/1940f3d67c9d3a2ca3ca4477099ebb06279e1d3d 20180424 16:18:27-!- gfgt [~androirc@134.76.63.8] has joined #wesnoth-dev 20180424 16:19:38< irker856> wesnoth: Jyrki Vesterinen wesnoth:master d628a73fab4a / src/gui/ (4 files in 2 dirs): Hide lobby chat log in MP staging screen https://github.com/wesnoth/wesnoth/commit/d628a73fab4a03a829c8790e2a97ea0a7d150619 20180424 16:22:58-!- gfgt [~androirc@134.76.63.8] has quit [Read error: No route to host] 20180424 16:23:07-!- gfgt [~androirc@134.76.63.8] has joined #wesnoth-dev 20180424 16:24:00<+discordbot> what about Mp Join Game? 20180424 16:25:30-!- gfgt [~androirc@134.76.63.8] has quit [Read error: No route to host] 20180424 16:25:59<+discordbot> Ah, I had missed that MP Join Game is a separate window from MP Staging. 20180424 16:26:28<+discordbot> Sure, I can show the chat logs in that window as well (and exclude the lobby chat there, too). 20180424 16:26:38<+discordbot> Indeed. I had wanted them to be one dialog when I first wrote them but it was too difficult 20180424 16:27:35<+discordbot> they handle much of the same data but from different sorces 20180424 16:28:17<+discordbot> I might be able to unify them at some point if I get the engine objects running on player machines instead of only the host's 20180424 16:28:24<+discordbot> but definitely not a priority 20180424 16:29:23< irker856> wesnoth: Jyrki Vesterinen wesnoth:1.14 898d661b03c0 / src/gui/dialogs/multiplayer/mp_join_game.cpp: Show chat logs (excluding lobby) also in MP Join Game https://github.com/wesnoth/wesnoth/commit/898d661b03c0af27e978436ab43f64c108387fc8 20180424 16:30:07-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!] 20180424 16:30:13-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180424 16:30:16< irker856> wesnoth: Jyrki Vesterinen wesnoth:master 4c258ff55071 / src/gui/dialogs/multiplayer/mp_join_game.cpp: Show chat logs (excluding lobby) also in MP Join Game https://github.com/wesnoth/wesnoth/commit/4c258ff55071df5de9adfc7bd41a50f4775f1dca 20180424 16:56:41< irker856> wesnoth/wesnoth:1.14 ln-zookeeper 800418555e UtBS: Remove old Naga Hunter portrait an AppVeyor: All builds passed 20180424 17:20:00-!- stikonas_ is now known as stikonas 20180424 17:21:54-!- gfg [~androirc@134.76.63.8] has joined #wesnoth-dev 20180424 17:23:44-!- gfg [~androirc@134.76.63.8] has quit [Remote host closed the connection] 20180424 18:04:35-!- gfg [~androirc@134.76.63.8] has joined #wesnoth-dev 20180424 18:20:39< irker856> wesnoth/wesnoth:master Iris Morelle f52828db88 pofix changes for UtBS S10 typo fix AppVeyor: All builds passed 20180424 18:40:58-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev 20180424 18:42:11-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Client Quit] 20180424 18:42:23-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev 20180424 19:59:46-!- gfg [~androirc@134.76.63.8] has quit [Remote host closed the connection] 20180424 20:05:21-!- minzbonbon [~min@meta23.net] has quit [Ping timeout: 240 seconds] 20180424 20:07:19-!- minzbonbon [~min@meta23.net] has joined #wesnoth-dev 20180424 20:27:11< Ivanovic> @shadowm did you apply the changes to the po files as well? 20180424 20:28:52< Ivanovic> anyway, off to bed, n8 20180424 20:35:29-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180424 20:35:35-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180424 20:53:09-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 255 seconds] 20180424 20:53:51-!- gfg [~androirc@134.76.63.8] has joined #wesnoth-dev 20180424 20:56:21-!- gallaecio [~quassel@188.79.96.255] has quit [Remote host closed the connection] 20180424 20:59:29<+discordbot> Ivanovic: yes, you can see that in the stat view for the commit. 20180424 21:06:40-!- Oebele [~quassel@143.177.58.202] has quit [Remote host closed the connection] 20180424 21:25:12-!- irker856 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout] 20180424 22:01:37-!- vn9711 [~vasya@94.158.103.15] has joined #wesnoth-dev 20180424 22:05:53-!- vn9711 [~vasya@94.158.103.15] has quit [Ping timeout: 248 seconds] 20180424 22:06:15-!- vn971 [~vasya@94.158.103.15] has quit [Ping timeout: 256 seconds] 20180424 22:16:43-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection] 20180424 22:27:32-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev 20180424 22:33:59-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180424 22:34:06-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180424 22:45:54-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection] 20180424 23:11:55-!- sevu [~Shiki@p5485486C.dip0.t-ipconnect.de] has joined #wesnoth-dev 20180424 23:13:17-!- sevu changed the topic of #wesnoth-dev to: 1.14.0 tag on April 26th (00:00 UTC), DO NOT PUSH UNTESTED OR OVER-REACHING CHANGES TO 1.14, announcement on May 1st (Steam launch 6 pm PST) | String and feature freeze on 1.14 branch | Wesnoth Developers Channel | >>> Want to help? Go here: https://r.wesnoth.org/t42911 (and thanks!) <<< | Discord Server: https://discord.gg/battleforwesnoth | Logs: http://irclogs.wesnoth 20180424 23:14:07< sevu> ^ updated topic with the same time for tagging as in discord (it's still one day now ) 20180424 23:15:47-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20180424 23:22:33-!- aeth [~Michael@wesnoth/umc-dev/developer/aethaeryn] has quit [Ping timeout: 264 seconds] 20180424 23:24:15-!- aeth [~Michael@wesnoth/umc-dev/developer/aethaeryn] has joined #wesnoth-dev 20180424 23:52:53-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180424 23:52:59-!- janebot_ [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180424 23:52:59-!- janebot_ is now known as janebot --- Log closed Wed Apr 25 00:00:46 2018