--- Log opened Sun May 06 00:00:05 2018 20180506 00:01:57-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: So long and thanks for all the fish.] 20180506 00:02:13<+discordbot> celticminstrel: https://github.com/wesnoth/wesnoth/issues/3033 20180506 00:02:19< celticminstrel> Okay. 20180506 00:06:45<+discordbot> @Vultraz I'll add the template edit to pofix. 20180506 00:08:35< irker825> wesnoth/wesnoth:master pentarctagon 6c5fc82b1b Add option to build wesnoth with hardeni AppVeyor: All builds passed 20180506 00:38:30-!- syrma[m] [syrmamatri@gateway/shell/matrix.org/x-amdrxwhibcayrmkt] has quit [Quit: removing from IRC because user idle on matrix for 30+ days] 20180506 00:52:45< celticminstrel> @sinda = singalen right? Shouldn't that be included in the credits? 20180506 00:53:21<+discordbot> Yes. 20180506 00:53:51<+discordbot> (To both.) 20180506 00:55:56< celticminstrel> Kasdel is listed for trailers but should also probably be in the artists section? But not sure where in the artists section, it's quite long. 20180506 00:56:25<+discordbot> I asked vultraz to give him and ancestral a separate section. 20180506 00:56:39< celticminstrel> I mean because IIRC he did some sprites too. 20180506 00:57:03<+discordbot> For mainline? I have no idea. 20180506 00:57:16< celticminstrel> Well, maybe only one sprite, but still. 20180506 00:58:45< celticminstrel> Oh yeah, the TRoW Logalmier or whatever his name is, so I guess that would suggest adding him to the TRoW art credits instead. 20180506 00:59:31< celticminstrel> Zoomo is also not credited as an artist yet. 20180506 00:59:50< celticminstrel> https://github.com/wesnoth/wesnoth/commit/31a0a19d2e70e5e850e96e5f291152e12ff8727b#diff-6b84b7876abf220d877725bc3d956cab 20180506 01:00:05<+discordbot> I'm not terribly surprised considering that sevu wasn't even added to Code Contributors or Developers on the forums until I randomly realised that. 20180506 01:00:14<+discordbot> Months after the fact. 20180506 01:00:35< celticminstrel> Should I put him in Misc or Art? 20180506 01:01:51< celticminstrel> I don't see fujimo-t anywhere but I think he might have another name that might be listed? 20180506 01:02:52< celticminstrel> Also noticed that hrubymar10 is listed both in packagers and misc, that seems kinda redundant. 20180506 01:09:21<+discordbot> It's not redundant. Only Core Contributors and Miscellaneous Contributors are mutually redundant. 20180506 01:09:34< celticminstrel> So I should leave him there? 20180506 01:09:43<+discordbot> Yes. 20180506 01:09:46< celticminstrel> It feels redundant nevertheless, but okay. 20180506 01:09:57<+discordbot> Most packagers do not contribute code. 20180506 01:10:04<+discordbot> That's why it's not redundant. 20180506 01:10:20< celticminstrel> Anyway, where should I add Zoomo? 20180506 01:10:34<+discordbot> kasdel did the trow 20180506 01:10:38<+discordbot> lord loglimir 20180506 01:10:39<+discordbot> I don't even know who that is. 20180506 01:10:44<+discordbot> Zoomo I mean. 20180506 01:10:53< celticminstrel> Someone who made a heavy infantry animation that Vultraz added. 20180506 01:11:01<+discordbot> yes 20180506 01:11:05<+discordbot> Art Contributors. 20180506 01:11:23< celticminstrel> Art Contributors doesn't look sorted, should I just add him at the bottom or something? 20180506 01:11:23<+discordbot> Note that back in the day we didn't give people the forum group membership unless it became more than a one-off contribution. 20180506 01:11:36<+discordbot> Art Contributors is sorted by loosely-defined tiers, actually. 20180506 01:12:04<+discordbot> The top tier is supposed to be "major" art developers such as Jetrel, fmunoz, kitty, LordBob. 20180506 01:12:29<+discordbot> I didn't come up with this system so I normally tossed everyone else into the bottom tier. 20180506 01:12:54< celticminstrel> Okay I'll put him at the bottom then. 20180506 01:13:33< irker825> wesnoth: Celtic Minstrel wesnoth:master ebf38661322e / data/core/about.cfg: Update credits https://github.com/wesnoth/wesnoth/commit/ebf38661322ea759acf47360b5dce006c105fa68 20180506 01:14:58< irker825> wesnoth: Celtic Minstrel wesnoth:1.14 c72932b3bada / data/core/about.cfg: Update credits https://github.com/wesnoth/wesnoth/commit/c72932b3bada90c2c92b2cb2a2b0af81533203b3 20180506 01:15:27< celticminstrel> Still need @Vultraz to handle any moving from Misc to Core though. 20180506 01:19:35<+discordbot> I gues sebu should move 20180506 01:19:48<+discordbot> actually 20180506 01:19:54<+discordbot> how do I know if i should move someone or copy someone šŸ˜ 20180506 01:20:52<+discordbot> Are they a Developer on the forums? 20180506 01:20:52< celticminstrel> I guess the answer is, if they should be in core, move them. 20180506 01:21:02< celticminstrel> Otherwise copy them. 20180506 01:21:08<+discordbot> Should they be a Developer on the forums? (i.e. have push access to the repository) 20180506 01:21:12< celticminstrel> Also what shadowm said is relevant, and whether they have commit access is relevant. 20180506 01:21:18< celticminstrel> Push access, whatever, 20180506 01:21:22<+discordbot> That's how it used to work back in my days, anyway. 20180506 01:22:39<+discordbot> for example someone named "Celtic MInstrel" is here in misc 20180506 01:22:53<+discordbot> šŸ˜› 20180506 01:22:54< celticminstrel> What a surprise. 20180506 01:23:02<+discordbot> Because you neglected to move celmin to core. 20180506 01:23:16<+discordbot> should it be "Celticminstrel" 20180506 01:23:22<+discordbot> 'Celtic Minstrel' 20180506 01:23:24< celticminstrel> No, it should be Celtic Minstrel. 20180506 01:23:26<+discordbot> "CelticMinstrel" 20180506 01:23:44< celticminstrel> It's two words, the fact that I sometimes push them together for nicknames where spaces aren't permitted is not really relevant. 20180506 01:24:12<+discordbot> and what about... Espreon. 20180506 01:24:16<+discordbot> hes not a dev anymore 20180506 01:24:18<+discordbot> but he used to be 20180506 01:24:28<+discordbot> There are a gazillion developers who are not active anymore. 20180506 01:24:35<+discordbot> Isn't he in core already though? 20180506 01:24:47<+discordbot> no 20180506 01:24:54<+discordbot> Then don't move him to core. 20180506 01:25:16<+discordbot> wedge is only in misc 20180506 01:25:25<+discordbot> he should probably be in... 20180506 01:26:11<+discordbot> @sinda do you want your real name in the credits (Currently it is just "Singalen") 20180506 01:26:46<+discordbot> a new section is needed for him 20180506 01:26:58< celticminstrel> Shouldn't he go in packagers? 20180506 01:27:03< celticminstrel> As the iOS packager basically. 20180506 01:27:15<+discordbot> but he's not just an packager 20180506 01:27:21<+discordbot> he's a developer 20180506 01:27:32<+discordbot> so maybe he should go to core... 20180506 01:27:33<+discordbot> why not 20180506 01:27:39< celticminstrel> I'm just countering your suggestion that he needs a separate section. 20180506 01:27:52< celticminstrel> Put him in packagers and perhaps core too. 20180506 01:27:59<+discordbot> both? 20180506 01:28:01< celticminstrel> That's what I'd recommend. 20180506 01:28:14< celticminstrel> Not sure about both, but it's probably not redundant and I think there's precedent? 20180506 01:28:18<+discordbot> this very specific... name = "Sergey Popov (loonycyborg)" comment = "scons" 20180506 01:28:25< celticminstrel> Heh... 20180506 01:28:58<+discordbot> vgaming is here... 20180506 01:29:01<+discordbot> misc is fine 20180506 01:29:11<+discordbot> wedge seem slike he hsould be more than misc? 20180506 01:29:25<+discordbot> Again, packagers is not redundant with any other category. 20180506 01:29:35<+discordbot> aginor is stil in misc.. 20180506 01:29:38<+discordbot> moves 20180506 01:29:42<+discordbot> Only Miscellaneous and Core are mutually redundant. 20180506 01:30:13< celticminstrel> I wouldn't call Aginor core though. 20180506 01:30:27< celticminstrel> He was core at one point but he effectively resigned. 20180506 01:30:30< celticminstrel> IMO 20180506 01:30:39<+discordbot> He's not the first core developer to leave. 20180506 01:30:42<+discordbot> šŸ¤” 20180506 01:30:55<+discordbot> His contributors are too significant to dismiss in the first place. 20180506 01:30:57< celticminstrel> Well, if the others are still listed in core, then I guess add him there. 20180506 01:30:57<+discordbot> contributions 20180506 01:31:01<+discordbot> I'm going to move tad to... 20180506 01:31:14<+discordbot> actually, ill copy tad to ... 20180506 01:31:22< celticminstrel> BTW Vultraz I do hope you pulled my changes before working on this... 20180506 01:31:34<+discordbot> oh you made changes 20180506 01:31:50< celticminstrel> https://github.com/wesnoth/wesnoth/commit/c72932b3bada90c2c92b2cb2a2b0af81533203b3 20180506 01:31:58< celticminstrel> Didn't you see the commit notification? 20180506 01:32:09<+discordbot> @Vultraz Thanks, let it be "singalen", lowercase. 20180506 01:32:12<+discordbot> i didn't scroll far upenough 20180506 01:32:21< celticminstrel> They're minor though, should be easy to resolve the conflicts, just note that both tad and singalen's entries were changed. 20180506 01:32:51<+discordbot> C O N F L I C T S 20180506 01:33:04<+discordbot> discorduser? 20180506 01:33:05<+discordbot> discorduser? 20180506 01:33:19<+discordbot> What. 20180506 01:33:55<+discordbot> that got sent twice 20180506 01:34:03<+discordbot> @Vultraz I would rather be credited for development. I believe I' in translators 20180506 01:34:16< celticminstrel> Something wrong Vultraz? 20180506 01:34:28<+discordbot> Yeah that sounded like vultraz had a moment there. 20180506 01:34:32< celticminstrel> ircuser and wikiuser are used places so I figured it also made sense to use discorduser. 20180506 01:34:48< celticminstrel> And AFAIK none of those keys are actually used for anything anyway? Unless the credits scraper script uses them? 20180506 01:34:50<+discordbot> ircuser is not a thing? 20180506 01:34:50<+discordbot> tad did a lot of code cleanup... 20180506 01:34:59<+discordbot> and build fixes 20180506 01:35:00<+discordbot> wikiuser is used by the wiki credits script, yes. 20180506 01:35:04<+discordbot> core it is 20180506 01:35:17< celticminstrel> ircuser is used in some of the entries, but I don't know if it has any effect on anything whatsoever. 20180506 01:35:25<+discordbot> But I don't think ircuser is -- normally we just list people like "Foo von Bar (foo/foov)". 20180506 01:35:46<+discordbot> Also, Discord usernames are not permanent. 20180506 01:35:52< celticminstrel> Well, I don't really have any objection to removing any use of ircuser. 20180506 01:36:09<+discordbot> so here's something I always wondered 20180506 01:36:10< celticminstrel> Nor are IRC usernames permanent. 20180506 01:36:12<+discordbot> why do the credits 20180506 01:36:21<+discordbot> (and I just saw shadowm do this the other day) 20180506 01:36:25<+discordbot> not use @ 20180506 01:36:29<+discordbot> for people's emails 20180506 01:36:39<+discordbot> and instead use _AT_ 20180506 01:36:44< celticminstrel> It's a rudimentary spam-avoidance tactic. 20180506 01:36:45<+discordbot> and _DOT_ 20180506 01:37:00<+discordbot> Protects people from the laziest bots yes. 20180506 01:37:04< celticminstrel> Not sure how well it works but... 20180506 01:37:13< celticminstrel> Does offer some measure of protection. 20180506 01:37:21<+discordbot> Emphasis on laziest. 20180506 01:37:36<+discordbot> I see 20180506 01:37:49<+discordbot> I suppose most people's emails get leaked in some fashion in general 20180506 01:37:54<+discordbot> else no one would get spam 20180506 01:38:47<+discordbot> Yes, but please just do it. 20180506 01:38:51<+discordbot> Don't question it. 20180506 01:39:04<+discordbot> I have no intention f changing it 20180506 01:40:09<+discordbot> should sigurgfdrgaon be in core 20180506 01:40:11<+discordbot> or campaign design... 20180506 01:40:16<+discordbot> he's done a LOT of campaign stuff.. 20180506 01:41:18<+discordbot> latter 20180506 01:41:23<+discordbot> ok, sevu... 20180506 01:41:52-!- dmont [636938ca@gateway/web/freenode/ip.99.105.56.202] has joined #wesnoth-dev 20180506 01:42:33< irker825> wesnoth/wesnoth:1.14 sigurdfdragon 52a559ce8e Help: Add wolves race description AppVeyor: All builds passed 20180506 01:43:26<+discordbot> sevu did mp stuff 20180506 01:43:59<+discordbot> why is matttsc in misc 20180506 01:44:10<+discordbot> but then again, he's not really core... 20180506 01:44:41< celticminstrel> He does have push access and basically is the AI person around here. 20180506 01:44:51< celticminstrel> I dunno whether that's enough to be core. 20180506 01:45:43< irker825> wesnoth: Charles Dang wesnoth:1.14 bf18a424d90e / data/core/about.cfg: Shuffled a few credits entries around https://github.com/wesnoth/wesnoth/commit/bf18a424d90e18e669d45d71280adcfa3c13cf03 20180506 01:45:50<+discordbot> anyway 20180506 01:46:04<+discordbot> I've now had sleep and feel 100x less likely to throw a book at celmin 20180506 01:46:08<+discordbot> apologies, celmin 20180506 01:46:56<+discordbot> Probably not been a good idea to address all of these bugs at the end of the day 20180506 01:49:27<+discordbot> Steam tells me we have 29,998 first-time downloads in all 20180506 01:50:10<+discordbot> 96% of 320 reviews positive 20180506 01:51:31<+discordbot> Speaking of development. I want to finally deal with this one: https://github.com/wesnoth/wesnoth/issues/2971#issuecomment-386651993 What do you think of the proposed solution? 20180506 01:51:45< celticminstrel> What happened to including "sinda" in the credits? 20180506 01:51:54< celticminstrel> Oh wait I misread, never mind. 20180506 01:52:21< celticminstrel> Thanks for doing this finally. 20180506 01:52:36<+discordbot> Hm 20180506 01:52:39<+discordbot> this is an interesting review 20180506 01:53:03<+discordbot> https://steamcommunity.com/id/trar/recommended/599390/ 20180506 01:53:12<+discordbot> Not the part about the RNG 20180506 01:53:16<+discordbot> that's standard fair 20180506 01:53:19<+discordbot> but about the writing 20180506 01:54:39<+discordbot> I think the review targets mostly the unit descriptions 20180506 01:54:47<+discordbot> Yes 20180506 01:54:48<+discordbot> doesn't sound like the person has played the campaigns 20180506 01:54:53< celticminstrel> You mean standard fare. 20180506 01:55:02<+discordbot> I actually agree with the review regarding the descriptions 20180506 01:55:12<+discordbot> they are elf-biased 20180506 01:55:22<+discordbot> but still, the Goblin Spearman description is rather uncomfortable when presented in this light 20180506 01:55:55< celticminstrel> What's this about "routinely", pretty sure that's not true. 20180506 01:56:05< celticminstrel> Well, maybe if you're being reckless though. 20180506 01:56:08<+discordbot> and, I mean, yeah, we're elf biased, but I kinda assumed that was just.... well, Tolkienian fantasy 20180506 01:56:13< celticminstrel> But then that should kinda be expected. 20180506 01:56:37<+discordbot> I wouldn't disregard the critique of the unit descriptions just because of the RNG rage 20180506 01:56:51< celticminstrel> Also, "no camping or grinding"? What? 20180506 01:57:07< celticminstrel> Isn't "camping" actually a good strategy when you're at a disadvantageous ToD? 20180506 01:57:16<+discordbot> yes, if you look at high-level replays 20180506 01:57:24<+discordbot> you'll see that a lot of time is spent just holding position 20180506 01:58:12<+discordbot> then again, wesnoth campaigns are hardly elf-biased 20180506 01:58:22<+discordbot> when taken as a whole 20180506 01:58:33<+discordbot> so it's really the unit descriptions 20180506 01:58:33<+discordbot> "Multiplayer population has not upticked like I had hoped steam integration would have brought." say what 20180506 01:58:39<+discordbot> (different review) 20180506 01:59:03<+discordbot> but yeah, to the review at hand... 20180506 01:59:07<+discordbot> well 20180506 01:59:09<+discordbot> .... 20180506 01:59:17<+discordbot> I mean 20180506 01:59:34<+discordbot> I believe the unit descriptions are outdated 20180506 01:59:34< celticminstrel> Well, we can perhaps take his criticism as a push to improve unit descriptions, though? 20180506 01:59:42<+discordbot> This is why I want to improve campaign writing, for one. 20180506 02:00:06<+discordbot> that's great, but you'll need people who are actually writers to do that 20180506 02:00:12< celticminstrel> The mention of the elvish lady is completely missing the point though. 20180506 02:00:18<+discordbot> we could throw money at you šŸ˜› 20180506 02:00:24< celticminstrel> The elvish lady isn't a real unit, she's just a cutscene sprite. 20180506 02:00:44< celticminstrel> I think it would be quite reasonable to actually give her some attacks though. 20180506 02:00:45<+discordbot> I should mention that I don't like working on stories that I dislike 20180506 02:00:55<+discordbot> cough NR cough 20180506 02:01:01<+discordbot> yeah, honestly... 20180506 02:01:05<+discordbot> so, here's the thing 20180506 02:01:12<+discordbot> a lot of of our campaigns are quite simplistic = 20180506 02:01:14<+discordbot> which is fine 20180506 02:01:24<+discordbot> I think it is quite necessary to have some simplistic campaigns 20180506 02:01:28<+discordbot> indeed 20180506 02:01:41<+discordbot> TRoW and UtBS are probably the most in-depth 20180506 02:02:10<+discordbot> ah, I also rather liked son of the black eye 20180506 02:02:25<+discordbot> it really gives a picture of orcs from the other side, whereas most campaigns have them as mostly just savages 20180506 02:02:28<+discordbot> I can't help but wonder whether this guy would appreciate something along the depths of AtS/IftU 20180506 02:02:28< celticminstrel> What the heck is this guy talking about... https://steamcommunity.com/app/599390/discussions/0/1696046342861122967/ 20180506 02:02:31< celticminstrel> (Last post) 20180506 02:02:44<+discordbot> Vultraz, I wouldn't get caught up by that review 20180506 02:02:51<+discordbot> it is quite obvious that that person didn't play the campaigns in depth 20180506 02:02:56<+discordbot> I also wonder if it's a problem we don't have something of that caliber? 20180506 02:03:10<+discordbot> it is, that's why if you have me work on UtBS 20180506 02:03:17<+discordbot> I'll try to make it close t that 20180506 02:03:36<+discordbot> nods nods 20180506 02:03:47<+discordbot> I said, give it a week or so. 20180506 02:04:00<+discordbot> It's too easy to write a review. 20180506 02:04:06<+discordbot> there are only a few negatve reviews 20180506 02:04:11<+discordbot> 96% are positive 20180506 02:04:14<+discordbot> That's also a problem. 20180506 02:04:16< celticminstrel> But there's only 320 reviews overall. 20180506 02:05:16<+discordbot> Should we attempt to revise certain unit descriptions? 20180506 02:05:48<+discordbot> it doesn't seem to be an extremely pressing issue 20180506 02:05:48< celticminstrel> I think it's worth considering a revision of some unit descriptions. I don't know which ones might need it though. 20180506 02:05:54< celticminstrel> That too. 20180506 02:06:40<+discordbot> indeed 20180506 02:06:52<+discordbot> actually, I take back what I said earlier 20180506 02:07:02<+discordbot> what would that be? 20180506 02:07:04<+discordbot> this person may have played some campaigns, and my guess is that they may have played some simpler ones 20180506 02:07:08<+discordbot> in which case the critique is spot on 20180506 02:07:21<+discordbot> I would say that the simpler campaigns are very Tolkien-esque in many ways 20180506 02:07:26<+discordbot> indeed 20180506 02:07:27<+discordbot> as one might expect 20180506 02:07:51<+discordbot> however, I don't think that's a problem 20180506 02:07:55<+discordbot> we should promote TRoW more 20180506 02:08:20<+discordbot> then I would also consider balancing easy to be a bit more newb friendly 20180506 02:08:35<+discordbot> it seems like people are saying HttT is pretty hard in one thread 20180506 02:08:47<+discordbot> We can't promote one of the hardest campaigns more, Vultraz. 20180506 02:08:56<+discordbot> Come on, I talked about this with you extensively the other day. 20180506 02:11:12<+discordbot> For the PblWML, is there a root tag I should be using? 20180506 02:11:26<+discordbot> I mean 20180506 02:11:31<+discordbot> _server.pbl 20180506 02:11:43<+discordbot> was that person upset at goblins being considered a poor mutation of orc bloodline? 20180506 02:12:03<+discordbot> yes 20180506 02:12:56< celticminstrel> What, @ancestral? 20180506 02:13:04<+discordbot> no, ancestral 20180506 02:13:05<+discordbot> i have no words for that 20180506 02:13:17< celticminstrel> For what? 20180506 02:13:38<+discordbot> _server.pbl has a bunch of keys for uploading an add-on. Is there a root-level tag? 20180506 02:13:54< celticminstrel> No? 20180506 02:13:56< dmont> In the theme system, when a rect is defined, what is the meaning of `=`? 20180506 02:14:07< celticminstrel> No WML has a root-level tag. 20180506 02:14:14<+discordbot> [?????] title="Thing" type="other" ā€¦ [/?????] 20180506 02:14:33< celticminstrel> dmont: https://wiki.wesnoth.org/ThemeWML 20180506 02:14:36<+discordbot> Well 20180506 02:14:44<+discordbot> _info.cfg kinda does 20180506 02:14:50< celticminstrel> Nope. 20180506 02:15:07<+discordbot> no, ancestral, there is no tag in server.pbl 20180506 02:15:08<+discordbot> ??? = info for _info.cfg 20180506 02:15:10<+discordbot> Okay 20180506 02:15:24< celticminstrel> @Vultraz I've definitely seen tags in _server.pbl somewhere. 20180506 02:15:31<+discordbot> [feedback] 20180506 02:15:40<+discordbot> he meant an ENCLOSING tag 20180506 02:15:40< celticminstrel> @ancestral But I wouldn't call that a root-level tag. 20180506 02:15:51< dmont> celticminstrel: thanks for the link. However, there is nothing about either + or =, although they are defined in the themes/ folder. 20180506 02:15:56<+discordbot> Okay, enclosing tag 20180506 02:16:02< celticminstrel> dmont: Uhh, it's there. 20180506 02:16:10< celticminstrel> In the first section. 20180506 02:16:11<+discordbot> @shadowm I'm not even sure what "promoting it" more would involves, but your feedback from before is still valid 20180506 02:16:15<+discordbot> so 20180506 02:16:23< celticminstrel> There's a formatting error though, I think... 20180506 02:16:44<+discordbot> dmont: I really don't recommend working with themewml... 20180506 02:17:00<+discordbot> it's not very intuitive and doesn't work well 20180506 02:17:31< celticminstrel> dmont: Look at the description of "rect". 20180506 02:17:34< dmont> Vultraz: Just tryna fix a bug... 20180506 02:17:43< dmont> yeah, got it celticminstrel , thx 20180506 02:22:42<+discordbot> Hmm 20180506 02:22:53<+discordbot> Not detecting my add-on from 1.13 20180506 02:23:26< celticminstrel> ? 20180506 02:23:44<+discordbot> Doesnā€™t show up in add-ons 20180506 02:23:47<+discordbot> in the game 20180506 02:24:22<+discordbot> What's the directory structure for the add-on? 20180506 02:25:10<+discordbot> https://cdn.discordapp.com/attachments/259976436490829825/442512114142281728/Screen_Shot_2018-05-05_at_9.24.58_PM.png 20180506 02:25:15<+discordbot> Do I need a text-domain? 20180506 02:25:24<+discordbot> for _main.cfg? 20180506 02:25:30< celticminstrel> It's not required. 20180506 02:25:51< celticminstrel> I assume all those files are in a folder with the addon's name. 20180506 02:25:57<+discordbot> Yes 20180506 02:26:13<+discordbot> FWIW I installed an add-on, so mine is next to another add-on I downloaded 20180506 02:26:38<+discordbot> https://cdn.discordapp.com/attachments/259976436490829825/442512484717297675/Screen_Shot_2018-05-05_at_9.26.25_PM.png 20180506 02:27:10<+discordbot> Is this still valid syntax? In my _main.cfg: [binary_path] path=data/add-ons/Simple_Hot_Keys [/binary_path] {~add-ons/Simple_Hot_Keys/hotkeys.cfg} 20180506 02:27:17< celticminstrel> Does it appear if you set filter for publishable addons? 20180506 02:27:21<+discordbot> No 20180506 02:27:26<+discordbot> Nothing in publishable addons 20180506 02:27:27< celticminstrel> That looks valid to me. 20180506 02:27:32< celticminstrel> ... 20180506 02:28:53<+discordbot> Could a malformed _server.pbl file cause trouble? 20180506 02:29:13< celticminstrel> Not sure. 20180506 02:29:31< celticminstrel> https://github.com/wesnoth/wesnoth/blob/master/src/addon/state.cpp 20180506 02:29:43< celticminstrel> Seems to be the relevant bit of the source code... 20180506 02:30:33<+discordbot> icon="data:image/png;base64,REDACTED" description="" tags="hotkey,keys,keyboard,controls" title="Simple Hot Keys" type="other" author="ancestral" version="1" passphrase="REDACTED" email="REDACTED" 20180506 02:31:09<+discordbot> Iā€™m sure the game doesnā€™t have my add-on installed, soā€¦ 20180506 02:31:20< celticminstrel> Hm? 20180506 02:31:27<+discordbot> (I would assume it goes hand-in-hand with publishing) 20180506 02:31:34<+discordbot> (being able to be published) 20180506 02:31:43<+discordbot> If itā€™s not installed, it canā€™t be published. 20180506 02:31:54<+discordbot> If it canā€™t be published, itā€™s probably not installed. 20180506 02:31:58< celticminstrel> But being installed just means it's in the addons folder. 20180506 02:32:05<+discordbot> Well alrgith 20180506 02:32:20<+discordbot> Then it must be installed. Soā€¦ 20180506 02:32:47<+discordbot> Could a bad _main.cfg file cause issues? 20180506 02:33:00< celticminstrel> "is installed" just checks if _main.cfg exists... 20180506 02:33:15< celticminstrel> And "can publish" is just checking if _server.pbl exists... 20180506 02:33:31< celticminstrel> Does the addon actually work for you? If it does I don't think the _main.cfg could be bad. 20180506 02:33:44<+discordbot> https://cdn.discordapp.com/attachments/358315903848415232/442514243644817419/Screen_Shot_2018-05-05_at_9.33.13_PM.png 20180506 02:33:53<+discordbot> How can I tell if itā€™s installed? 20180506 02:34:06< celticminstrel> Maybe it would show up in the Remove Addons dialog? 20180506 02:34:08<+discordbot> I can see if itā€™s active in a game 20180506 02:34:11< celticminstrel> And that. 20180506 02:34:19< celticminstrel> That's what I meant by "does it work". 20180506 02:34:21<+discordbot> Okay, it does show in Remove Addons 20180506 02:35:09<+discordbot> So then why isnā€™t this publishable? 20180506 02:35:32< celticminstrel> I have no idea. :( 20180506 02:36:42<+discordbot> @Vultraz I love the horizontal scrollbar in the addons window šŸ˜‰ 20180506 02:36:57<+discordbot> ....what 20180506 02:37:04<+discordbot> https://cdn.discordapp.com/attachments/259976436490829825/442515110917832715/Screen_Shot_2018-05-05_at_9.36.48_PM.png 20180506 02:37:19<+discordbot> ....sigh 20180506 02:37:39<+discordbot> Oh interesting 20180506 02:37:51<+discordbot> When I enter as fullscreen there is no scrollbar 20180506 02:38:01<+discordbot> Must have been when I was not fullscreen 20180506 02:38:23<+discordbot> Bizarre. Who knows. 20180506 02:39:16<+discordbot> @Vultraz Okay, found out how to reproduce it. 20180506 02:39:22<+discordbot> I can create a bug report 20180506 02:40:05< celticminstrel> I don't see anything suggesting that all addons must have an addon tag, but I suppose you could try adding a [resource] tag or something... 20180506 02:40:41<+discordbot> For Type, toggling "Unknown" on, then off, the horizontal scrollbar appears 20180506 02:40:55<+discordbot> But only for ā€œUnknownā€ AFAICT 20180506 02:44:11<+discordbot> Well, Iā€™m stuck on how to upload 20180506 02:45:14<+discordbot> there are two upload buttons 20180506 02:45:47< celticminstrel> Have you not been paying attention at all, Vultraz? 20180506 02:46:03<+discordbot> no, I was watching Honest Trailers 20180506 02:46:07<+discordbot> Where are the upload buttons? 20180506 02:46:17<+discordbot> All I see is a grayed out Update All button 20180506 02:46:19< celticminstrel> Ancestral's addon isn't even showing as publishable. 20180506 02:46:22<+discordbot> ah 20180506 02:46:26<+discordbot> then he set up his PBL wrong 20180506 02:46:34< celticminstrel> I dunno about that? 20180506 02:46:44< celticminstrel> AFAICT all that's required is that it exist. 20180506 02:46:51<+discordbot> hm 20180506 02:46:55<+discordbot> I can put this on GitHub if you like as a bug report. (Donā€™t worry, email or passphrase blanked out.) 20180506 02:46:55<+discordbot> https://cdn.discordapp.com/attachments/259976436490829825/442517586626740224/Simple_Hot_Keys.zip 20180506 02:47:15<+discordbot> Please tell me whatā€™s wrong with the pbl 20180506 02:47:54<+discordbot> I'm not sure... 20180506 02:47:58<+discordbot> try adding a desciption? 20180506 02:48:03<+discordbot> I did 20180506 02:48:06< celticminstrel> Doubt that'll help though. 20180506 02:48:08<+discordbot> Itā€™s "description" 20180506 02:48:38<+discordbot> did you refresh your cache? 20180506 02:48:40<+discordbot> F5 20180506 02:48:41<+discordbot> Has anyone here uploaded an add-on to the 1.14 server? 20180506 02:48:42<+discordbot> I did 20180506 02:48:50<+discordbot> I quit and reloaded Wesnoth several times also 20180506 02:48:58<+discordbot> My custom addon does show in Remove Addons 20180506 02:49:26<+discordbot> try changing the type around 20180506 02:49:29<+discordbot> I mean, 1.14 is new. Has anyone uploaded a new addon? 20180506 02:49:41<+discordbot> Okay, I'll try changing the type 20180506 02:49:54<+discordbot> many people have uploaded addons 20180506 02:50:54<+discordbot> New ones? 20180506 02:50:56<+discordbot> Okay 20180506 02:51:09<+discordbot> Has anyone uploaded add-ons from a Mac? 20180506 02:51:53<+discordbot> i don't know 20180506 02:51:55<+discordbot> this is weird 20180506 02:51:59<+discordbot> Also, via Steam? 20180506 02:52:08<+discordbot> Not that that should matter. 20180506 02:57:59<+discordbot> Alright, Iā€™ll try uploading this on my Windows machine 20180506 02:58:13<+discordbot> If you can then we have a serious issue šŸ˜¦ 20180506 02:59:56<+discordbot> Sounds bad either way 20180506 03:00:13<+discordbot> Unless my add-on is bad (hoping thatā€™s the case!) 20180506 03:01:11<+discordbot> @shadowm did you have a specific test case set up for th attack dialog bug? 20180506 03:01:26<+discordbot> Just spawn units. 20180506 03:01:40<+discordbot> Thieves are the most logical choice for obvious reasons. 20180506 03:06:18<+discordbot> it.... works for me? 20180506 03:06:41<+discordbot> What does? 20180506 03:07:04<+discordbot> the backstab label displays when applicable, and not otherwise 20180506 03:07:13<+discordbot> In the attack dialog? 20180506 03:07:16<+discordbot> yes 20180506 03:07:21<+discordbot> With or without the patch? 20180506 03:07:39<+discordbot> Well, can't upload it in the Windows version eitherā€¦ 20180506 03:07:50<+discordbot> I edited your code slightly. 20180506 03:08:00<+discordbot> What did you change? 20180506 03:08:07<+discordbot> cpp auto a_ctx = attacker_weapon.specials_context(attacker_itor_.get_shared_ptr(), defender_itor_.get_shared_ptr(), attacker_itor_->get_location(), defender_itor_->get_location(), true, defender.weapon); auto d_ctx = defender_weapon.specials_context(defender_itor_.get_shared_ptr(), attacker_itor_.get_shared_ptr(), defender_itor_->get_location(), attacker_itor_->get_location(), false, attacker.weapon); 20180506 03:08:08<+discordbot> std::string attw_specials = attacker_weapon.weapon_specials(true, attacker.backstab_pos); std::string defw_specials = defender_weapon.weapon_specials(true); 20180506 03:08:27<+discordbot> I moved specials_context right before calling weapon_specials 20180506 03:08:43< celticminstrel> ...huh? 20180506 03:08:49< celticminstrel> Wasn't it already in the same scope? 20180506 03:09:01<+discordbot> and i used get_shared_ptr 20180506 03:09:15<+discordbot> and used defender_weapon 20180506 03:09:19<+discordbot> for the d ctx 20180506 03:09:21< celticminstrel> Unless... something in the interim set and cleared a specials context? 20180506 03:09:44< celticminstrel> I think I was a little naĆÆve about resetting the specials context, it should probably store the previous values and restore those. 20180506 03:09:51<+discordbot> Vultraz give me your patch. 20180506 03:10:21<+discordbot> Also the patch I posted is bogus, that's only one of several attempts with contexts and that's not the latest one. 20180506 03:11:00<+discordbot> sec 20180506 03:15:01<+discordbot> One eternity later... 20180506 03:15:09<+discordbot> I'm trying to push to a fork šŸ˜ 20180506 03:15:37<+discordbot> do you mind if I just give you a pastebin 20180506 03:15:48<+discordbot> That's what I was expecting in the first place. 20180506 03:15:52<+discordbot> of the whole file 20180506 03:15:54<+discordbot> In diff form, though, not in whole-file form. 20180506 03:15:55<+discordbot> No. 20180506 03:16:00<+discordbot> I mean yes I do mind. 20180506 03:16:54<+discordbot> https://pastebin.com/VV44AaE6 20180506 03:17:12<+discordbot> @ancestral Rename _server.pbl.cfg to _server.pbl. 20180506 03:17:25<+discordbot> šŸ¤¦ 20180506 03:18:05<+discordbot> Apparently the fileā€™s extension was hidden in Finder 20180506 03:18:57<+discordbot> That worked 20180506 03:19:24< celticminstrel> Oh wow. 20180506 03:19:45< celticminstrel> Stupid Finder though... 20180506 03:20:08<+discordbot> Explorer does it too 20180506 03:20:13< celticminstrel> I always turn the extension-hiding off on both platforms. 20180506 03:20:14<+discordbot> except there's a type column 20180506 03:20:19< celticminstrel> It strikes me as really dumb. 20180506 03:20:30<+discordbot> so in this case it should have said "_server.pbl" type cfg file 20180506 03:20:33< celticminstrel> Uhh, and what if you're viewing in icon view rather than list view? 20180506 03:20:47<+discordbot> why would I view in icon view ? 20180506 03:20:53<+discordbot> that's only good for images 20180506 03:21:01< celticminstrel> Well there's one reason right there. 20180506 03:22:02< celticminstrel> I usually prefer icon view unless working with unreasonably long filenames though. 20180506 03:22:40<+discordbot> Vultraz: By the way, are you going to stop ignoring everything I've said about translations for 1.14.1? 20180506 03:23:07<+discordbot> I need to get that login change in 20180506 03:23:14<+discordbot> it's not done >_> 20180506 03:23:18<+discordbot> been focusing on the lobby 20180506 03:23:30<+discordbot> Are you going to get it in 4 hours before tagging? 20180506 03:23:35<+discordbot> tonight 20180506 03:23:37<+discordbot> So no-one has time to translate that single string? 20180506 03:23:51<+discordbot> (Or two or three.) 20180506 03:23:55< celticminstrel> Or you could postpone 1.14 another week to give translators a chance. 20180506 03:23:59<+discordbot> also, I agree with you we skip updating the completion tally 20180506 03:24:02<+discordbot> for this release 20180506 03:24:23<+discordbot> That wasn't actually something up to discussion once I decided I'd do the pot update. 20180506 03:25:36-!- celticminstrel is now known as celmin|sleep 20180506 03:26:37<+discordbot> @Vultraz Your fix works. 20180506 03:26:52<+discordbot> \o/ 20180506 03:26:54<+discordbot> I don't understand what it is you did differently. 20180506 03:27:04<+discordbot> I literally changed 3 things 20180506 03:27:09<+discordbot> 2 of which are inconsequential 20180506 03:27:13<+discordbot> diff + auto a_ctx = attacker_weapon.specials_context(attacker_itor_.get_shared_ptr(), defender_itor_.get_shared_ptr(), attacker_itor_->get_location(), defender_itor_->get_location(), true, defender.weapon); + + auto d_ctx = defender_weapon.specials_context(defender_itor_.get_shared_ptr(), attacker_itor_.get_shared_ptr(), defender_itor_->get_location(), attacker_itor_->get_location(), false, 20180506 03:27:13<+discordbot> attacker.weapon); 20180506 03:27:19<+discordbot> This was my latest version (not pushed). 20180506 03:28:00<+discordbot> weird 20180506 03:28:00<+discordbot> I did it before the attacker.disable check and that's the only difference I can see from yours. 20180506 03:28:05<+discordbot> that's exactly the same 20180506 03:28:15<+discordbot> Also, yours probably should be before the attacker.disable check too. 20180506 03:28:54<+discordbot> the specials context doesn't touch that 20180506 03:29:05<+discordbot> disable is a weapon special. 20180506 03:29:49<+discordbot> not in this context 20180506 03:30:03<+discordbot> What is special about this context? 20180506 03:30:11<+discordbot> Especially considering everything else. 20180506 03:30:12<+discordbot> I'm just checking a flag set elsewhere 20180506 03:30:24<+discordbot> it's the thing in fill_weapons_list that I think I did wrong based on gfgtdf's comment 20180506 03:30:51<+discordbot> Are you 100% positive this won't result in the dialog listing weapons that are actually disabled? 20180506 03:31:14<+discordbot> 100% 20180506 03:31:21<+discordbot> specials_context_t doesn't touch that flag 20180506 03:31:21<+discordbot> Because this is a stable branch, not development. 20180506 03:31:44<+discordbot> also, i just tested with it moved prior and it works anyway so I have no idea what went wrong on your end 20180506 03:32:19<+discordbot> Maybe I forgot to rebuild or launched the wrong build since I was falling asleep anyway. 20180506 03:32:29<+discordbot> possible 20180506 03:32:44<+discordbot> should i push my commit 20180506 03:33:01<+discordbot> I don't know, it seems like I ended up being the author of the code anyway. 20180506 03:33:15-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev 20180506 03:33:16<+discordbot> Except for the position and formatting of it. 20180506 03:33:22<+discordbot> then feel free to push it (but do keep my formatting for the calls) 20180506 03:33:28<+discordbot> and the typo fix 20180506 03:35:52<+discordbot> Incidentally, why do we prefer using foo.get_shared_ptr() instead of &*foo? 20180506 03:36:35<+discordbot> cleaner 20180506 03:36:37<+discordbot> they do the same thing 20180506 03:36:49<+discordbot> Your definition of cleaner being...? 20180506 03:36:57<+discordbot> it looks nicer 20180506 03:37:05<+discordbot> And takes up more space, got it. 20180506 03:37:13<+discordbot> and the comment indicates it's basically what it's for 20180506 03:37:33<+discordbot> Now I know who I'm never hiring to clean the house. 20180506 03:37:34<+discordbot> now, what was he forum register link again? 20180506 03:38:01<+discordbot> https://forums.wesnoth.org/ucp.php?mode=register 20180506 03:39:02<+discordbot> ya know it just occurred someone could distribute a modified binary with this link changed to point to malware 20180506 03:39:20<+discordbot> They could change a lot of other things tbh. 20180506 03:39:33<+discordbot> But I was going to suggest extending the MP protocol anyway to let this link be decided by the server. 20180506 03:39:55<+discordbot> Mostly because of the fact that it is possible to use a different forum board with wesnothd. 20180506 03:40:37< irker825> wesnoth: Iris Morelle wesnoth:1.14 da4d2b098c8f / changelog.md src/gui/dialogs/unit_attack.cpp: gui2/unit_attack: Only display active specials on the weapons list https://github.com/wesnoth/wesnoth/commit/da4d2b098c8f220eb730fbc3e1a5aef785e3737c 20180506 03:40:45< irker825> wesnoth: Iris Morelle wesnoth:master d727cf2c9986 / changelog.md src/gui/dialogs/unit_attack.cpp: gui2/unit_attack: Only display active specials on the weapons list https://github.com/wesnoth/wesnoth/commit/d727cf2c9986f7e867ca39329af84325f49ce734 20180506 03:41:33<+discordbot> except 20180506 03:41:48<+discordbot> at this point the connection to the server hasn't been opened 20180506 03:42:05<+discordbot> Poo, 20180506 03:42:29<+discordbot> :/ 20180506 03:42:31<+discordbot> Yeah, I was obviously thinking of making it part of the credentials prompt. 20180506 03:44:11<+discordbot> actually, I'll get this in now 20180506 03:44:13<+discordbot> instead of tonight 20180506 03:45:14<+discordbot> It's already tonight for me. 12:45 am. 20180506 03:48:31<+discordbot> tho lunch first 20180506 03:57:43< mattsc> Hey All: anybody here have an opinion on this? https://forums.wesnoth.org/viewtopic.php?f=38&t=6989&e=1&view=unread#p627434 20180506 03:58:15< mattsc> I mean, the part with the walkthrough is very true and needs to be changed, but on the added difficulty? 20180506 03:59:09< mattsc> I obviously think that the somewhat more sensible behavior is worth the slightly increased difficulty, but I have a hard time relating to the problems a true beginner has these days. 20180506 04:00:36< mattsc> If people think this should be reverted, thatā€™s fine by me. It was a fun little exercise and not all that much work (and I can probably use the code elsewhere). But if we do so, we should probably do that before 1.14.1 is tagged. 20180506 04:00:46< mattsc> When is 1.14.1 supposed to be tagged? 20180506 04:01:07<+discordbot> Nobody knows. 20180506 04:38:05-!- vn971 [~vasya@94.158.103.15] has quit [Ping timeout: 240 seconds] 20180506 04:40:44-!- discordbot2 [~discordbo@baldras.wesnoth.org] has joined #wesnoth-dev 20180506 04:40:47-!- mode/#wesnoth-dev [+v discordbot2] by ChanServ 20180506 04:41:10-!- discordbot [~discordbo@baldras.wesnoth.org] has quit [Remote host closed the connection] 20180506 04:42:28-!- vn971 [~vasya@94.158.103.15] has joined #wesnoth-dev 20180506 04:44:59-!- crimson_penguin [~crimson_p@wesnoth/developer/crimsonpenguin] has quit [Ping timeout: 260 seconds] 20180506 04:45:45-!- crimson_penguin [~crimson_p@ec2.happyspork.com] has joined #wesnoth-dev 20180506 04:45:45-!- crimson_penguin [~crimson_p@ec2.happyspork.com] has quit [Changing host] 20180506 04:45:45-!- crimson_penguin [~crimson_p@wesnoth/developer/crimsonpenguin] has joined #wesnoth-dev 20180506 05:01:50<+discordbot2> tomorrow 20180506 05:04:05< mattsc> okay; so do I keep the new AToTB AI or revert it before then? 20180506 05:04:06<+discordbot2> Gah. 20180506 05:04:17<+discordbot2> That's not enough time for even one translation team to get those strings done. 20180506 05:04:34<+discordbot2> You need to factor in timezones and meal times and families and jobs... 20180506 05:05:11<+discordbot2> If you aren't going to give us time for that you'll have to acquiesce to at least command the Steam packagers to update those translations out-of-band later. 20180506 05:06:07-!- gallaecio [~quassel@188.79.96.255] has joined #wesnoth-dev 20180506 05:11:00<+discordbot2> it can be tuesday 20180506 05:12:24<+discordbot2> @mattsc I don't see why we should revert AI behavior because a walkthrough said so 20180506 05:13:03<+discordbot2> a slight increase in difficulty is acceptable i think 20180506 05:13:29< mattsc> @Vultraz No, thatā€™s not it. It does make the scenario ā€¦ 20180506 05:13:34< mattsc> Right, that latter. 20180506 05:13:45< mattsc> That was my personal judgment as well. 20180506 05:15:05< mattsc> But there is a point in keeping that particular campaign pretty much as easy as possible. 20180506 05:15:11<+discordbot2> a custom AI is also more interesting 20180506 05:16:30< mattsc> Again, personally I obviously agree. 20180506 05:16:39< mattsc> I just wanted to throw it out here for comments. 20180506 05:17:52<+discordbot2> Vultraz you need to decide on a definite tagging date/time. 20180506 05:18:02<+discordbot2> Otherwise people will constantly be like "WHEN IS 1.14.1" 20180506 05:18:18<+discordbot2> It's always at 00:00 UTC. Just depends on the day. Do you want me to wait until Tuesday? 20180506 05:18:19<+discordbot2> I hate answering that question with a vague "probably xyz time". 20180506 05:18:37<+discordbot2> I'd like 48 hours minimum after the strings are in. 20180506 05:18:47<+discordbot2> OR 20180506 05:18:51<+discordbot2> You can do what I suggested. 20180506 05:18:57<+discordbot2> > If you aren't going to give us time for that you'll have to acquiesce to at least command the Steam packagers to update those translations out-of-band later. 20180506 05:19:16<+discordbot2> even if 1.14.2 is within 2 weeks? 20180506 05:19:20<+discordbot2> (That shifts the burden onto those two instead of you and me.) 20180506 05:19:36<+discordbot2> Why is 1.14.2 within two weeks?? 20180506 05:20:15<+discordbot2> The plan was to initially have a new stable patch every 2 weeks until all major issues were fixed, or when LordBob provided new art 20180506 05:20:39<+discordbot2> Okay, but you realize that translators need a 1 week-long string freeze every time? 20180506 05:20:45<+discordbot2> I remember 20180506 05:20:54<+discordbot2> Which means that devs can only get strings into the next release for one week. 20180506 05:21:29<+discordbot2> Ugh this is such a tricky situation. 20180506 05:21:37<+discordbot2> On one hand we need that patch on Steam ASAP. 20180506 05:21:48<+discordbot2> On the other hand, that patch is useless for people who have difficulty with English. 20180506 05:22:31<+discordbot2> If it's in before Monday 00:01 UTC then Wednesday 00:01 UTC would be the closest reasonable time for tagging. 20180506 05:23:02<+discordbot2> If it's in right now then Tuesday 00:01 UTC would be acceptable. 20180506 05:23:45<+discordbot2> Also, regarding the wording: if you specify that forums.wesnoth.org is only for the official MP server then we needn't worry about wording for alternate servers or we can get that in at a later time. 20180506 05:24:20<+discordbot2> (i.e. specify that it's for the official server in the MP menu, we can provide server-defined instructions for 3rd party servers in the auth prompt dialog.) 20180506 05:24:31<+discordbot2> (and that last half can be done after 1.14.1.) 20180506 05:24:34<+discordbot2> I was just going to go with what I had: 20180506 05:24:34<+discordbot2> https://cdn.discordapp.com/attachments/259976436490829825/442557261068632075/unknown.png 20180506 05:25:15<+discordbot2> May I suggest moving the button to the right of the explanatory text instead? 20180506 05:25:31<+discordbot2> And also changing it from Create Account to just Sign Up? 20180506 05:25:41<+discordbot2> Or Register? 20180506 05:26:38<+discordbot2> Alternatively... 20180506 05:26:44<+discordbot2> The whole thing could be moved to the bottom. 20180506 05:28:29<+discordbot2> it doesn't really look great 20180506 05:28:30<+discordbot2> https://cdn.discordapp.com/attachments/259976436490829825/442558249666084865/unknown.png 20180506 05:28:38<+discordbot2> My main worry is that some people might mistake the button for a Join option. 20180506 05:29:05<+discordbot2> Oh actually. 20180506 05:29:20<+discordbot2> Let it be between the Login textbox row and the menu. 20180506 05:29:39<+discordbot2> Vertically align the Register button to the center of its bounding box. 20180506 05:30:04<+discordbot2> (And to the right.) 20180506 05:31:05<+discordbot2> Also re your concern about malware, they can make that happen at soon as title screen is displayed if they want. 20180506 05:31:21<+discordbot2> They don't even need the desktop::open_object() to exist as they can write their own etc. 20180506 05:31:43<+discordbot2> https://cdn.discordapp.com/attachments/259976436490829825/442559063570644993/unknown.png 20180506 05:31:44<+discordbot2> People inject malware into closed-source apps with ease, so nothing we can do is going to stop them. 20180506 05:32:01<+discordbot2> That looks fine to me. 20180506 05:32:21<+discordbot2> agreed 20180506 05:32:43<+discordbot2> The only thing we can do is get our official packages signed. 20180506 05:33:35<+discordbot2> Both the installer and the wesnoth.exe and wesnothd.exe binaries (the macOS counterparts of all three). 20180506 05:35:17<+discordbot2> decreases max width slightly 20180506 05:35:20<+discordbot2> ok, this can go in 20180506 05:38:49< irker825> wesnoth: Iris Morelle wesnoth:master d39d1b87fdfa / utils/pofix.py: pofix: Add 1.14 announcement typo fix https://github.com/wesnoth/wesnoth/commit/d39d1b87fdfaf7cc463425cff847e28ad0d2c549 20180506 05:38:53< irker825> wesnoth: Iris Morelle website:master abb52cf6ce2a / start/1.14/ (55 files in 2 dirs): announcement/1.14: pofix pass https://github.com/wesnoth/website/commit/abb52cf6ce2a096c4c9f5d9b26a8b6a846cc7b23 20180506 05:38:56< irker825> wesnoth: Iris Morelle wesnoth:1.14 7532b25aae42 / utils/pofix.py: pofix: Add 1.14 announcement typo fix https://github.com/wesnoth/wesnoth/commit/7532b25aae427216fb2e7021a040e1a5c5d007b2 20180506 05:39:59< irker825> wesnoth: Charles Dang wesnoth:master 851b28e24bfe / / (2 files in 2 dirs): * MP Method Selection: clarified the account requirement for the official server https://github.com/wesnoth/wesnoth/commit/851b28e24bfefd068069aa9ac2eaada6593718b4 20180506 05:42:26<+discordbot2> i removed the text box tooltip 20180506 05:42:43< irker825> wesnoth: Charles Dang wesnoth:1.14 9d8d8af59643 / / (2 files in 2 dirs): MP Method Selection: clarified the account requirement for the official server https://github.com/wesnoth/wesnoth/commit/9d8d8af59643ddf09fb5909ac543c2bfa4775d28 20180506 05:43:14<+discordbot2> Not sure if I'll need to change any more strings... 20180506 05:43:42<+discordbot2> oh yeah, I was going to add an "Observable" checkbox to th elobby per enclave's suggestion 20180506 05:43:45<+discordbot2> nods nods nods 20180506 05:45:12<+discordbot2> For the record, the Sign Up button takes you to the board index if you are logged in. This is not a bug. People who aren't logged into the forums will see the start of the UCP registration sequence. 20180506 05:45:35<+discordbot2> i figured 20180506 05:45:50<+discordbot2> Make sure to copy and pastet that for the next person asking. 20180506 05:46:01<+discordbot2> Uhhh my name doesn't display in bold anymore? 20180506 05:46:18<+discordbot2> https://cdn.discordapp.com/attachments/259976436490829825/442562735348383744/unknown.png 20180506 05:46:29<+discordbot2> everyone is registered 20180506 05:46:33<+discordbot2> so I removed that 20180506 05:46:35<+discordbot2> This is not a guarantee. 20180506 05:46:41<+discordbot2> else everyone shows in bold 20180506 05:46:48<+discordbot2> We may have to disable DUL for any number of reasons. 20180506 05:46:59<+discordbot2> It doesn't even have an affect if the database is down. 20180506 05:47:54<+discordbot2> Maybe display unregistered users grayed out instead? 20180506 05:48:22<+discordbot2> Or in a darker colour in general, since the other sections have their own colours. 20180506 05:48:31<+discordbot2> hmm 20180506 05:48:33<+discordbot2> that's an idea 20180506 05:51:24< irker825> wesnoth: Charles Dang wesnoth:1.14 d84d7b0e7279 / data/gui/window/lobby_main.cfg src/gui/dialogs/multiplayer/lobby.cpp: MP Lobby: removed Refresh button https://github.com/wesnoth/wesnoth/commit/d84d7b0e7279b0766e381113f2798db980f75609 20180506 05:51:26<+discordbot2> @Ravana chat renders better now ^ 20180506 05:51:27< irker825> wesnoth: Charles Dang wesnoth:1.14 b1aa101009ae / src/display_chat_manager.cpp: Increased in-game chat size. This makes it render more smoothly https://github.com/wesnoth/wesnoth/commit/b1aa101009ae176c1dd01e819c11c20eae33289a 20180506 05:52:07<+discordbot2> Incidentally, clicking on users on the user list used to scroll to and select the game they're in. 20180506 05:53:01<+discordbot2> i know 20180506 05:53:14<+discordbot2> but it's not...really that simple to do anymore 20180506 05:53:55<+discordbot2> damn listbox 20180506 05:55:21<+discordbot2> I really fucked up the implementation of the chatbox 20180506 05:55:59<+discordbot2> it's Schrodinger's rooms 20180506 05:56:17<+discordbot2> parts of the code think we have room support, others don't... 20180506 05:56:31<+discordbot2> some parts have chat log support, but that was just implemented by another method... 20180506 06:00:02< irker825> wesnoth/wesnoth:master mattsc a82971e48d changelog entry for custom AI for AToTB AppVeyor: All builds passed 20180506 06:06:19< irker825> wesnoth: Charles Dang wesnoth:1.14 10bf2385256f / src/gui/widgets/chatbox.cpp: GUI2/Chatbox: attempt to send roomless messages to the active room first https://github.com/wesnoth/wesnoth/commit/10bf2385256f5ff910315d9a15372af8253a7343 20180506 06:21:52<+discordbot2> I think I'll removed No Ignored 20180506 06:22:00<+discordbot2> and replace it with Observable 20180506 06:22:15<+discordbot2> there's really no reason people want to see games by people they've blocked 20180506 06:25:26<+discordbot2> hm 20180506 06:25:38<+discordbot2> I think some of the scrollng issues in the lobby might be caused by the user list 20180506 06:33:02-!- celmin|sleep [~celmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The computer falls into a deep sleep, to awake again some other day!] 20180506 06:34:10< irker825> wesnoth: Charles Dang wesnoth:1.14 4fb2a52d6949 / src/gui/dialogs/multiplayer/lobby.cpp: MP Lobby: rearrange player list nodes and have Selected Game also expanded by de https://github.com/wesnoth/wesnoth/commit/4fb2a52d6949d2c4580deeb1b14501ca24001f48 20180506 06:34:12<+discordbot2> @shadowm ^^ 20180506 06:34:34-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev 20180506 06:38:37<+discordbot2> by the way, is having the games with slots available on top going to make it into 1.14.1? 20180506 06:40:12<+discordbot2> let me see.. 20180506 06:41:08-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev 20180506 06:47:29-!- travis-ci [~travis-ci@ec2-54-167-89-247.compute-1.amazonaws.com] has joined #wesnoth-dev 20180506 06:47:30< travis-ci> wesnoth/wesnoth#17992 (1.14 - 10bf238 : Charles Dang): The build passed. 20180506 06:47:30< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/375453325 20180506 06:47:32-!- travis-ci [~travis-ci@ec2-54-167-89-247.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180506 07:40:42-!- travis-ci [~travis-ci@ec2-54-205-245-66.compute-1.amazonaws.com] has joined #wesnoth-dev 20180506 07:40:43< travis-ci> wesnoth/wesnoth#17993 (1.14 - 4fb2a52 : Charles Dang): The build has errored. 20180506 07:40:43< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/375456995 20180506 07:40:43-!- travis-ci [~travis-ci@ec2-54-205-245-66.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180506 07:44:25< vn971> end game doesn't seem to be properly recognized by wesnothd: https://github.com/wesnoth/wesnoth/issues/3038 20180506 07:55:44-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Quit: Caught sigterm, terminating...] 20180506 07:56:06-!- Ivanovic [~ivanovic@p4FC53504.dip0.t-ipconnect.de] has joined #wesnoth-dev 20180506 07:56:06-!- Ivanovic [~ivanovic@p4FC53504.dip0.t-ipconnect.de] has quit [Changing host] 20180506 07:56:06-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev 20180506 07:57:19< irker825> wesnoth/wesnoth:master Celtic Minstrel ebf3866132 Update credits AppVeyor: All builds passed 20180506 08:06:41-!- lipkab [~lipk@host-91-147-210-58.biatv.hu] has joined #wesnoth-dev 20180506 08:07:18<+discordbot2> I am not adding a mod list 20180506 08:07:39<+discordbot2> I might add an indicator that mods are active, but I'm not adding a list. 20180506 08:07:59<+discordbot2> There's just no room. 20180506 08:09:15<+discordbot2> https://cdn.discordapp.com/attachments/259976436490829825/442598708580712448/unknown.png 20180506 08:09:34<+discordbot2> cpp } else if((*error)["error_code"] == MP_NAME_AUTH_BAN_USER_ERROR) { error_message = VGETTEXT("The nickname ā€˜$nickā€™ is banned on the forums board for this server.", i18n_symbols); } else if((*error)["error_code"] == MP_NAME_AUTH_BAN_IP_ERROR) { error_message = _("Your IP address is banned on the forums board for this server."); } else 20180506 08:09:34<+discordbot2> if((*error)["error_code"] == MP_NAME_AUTH_BAN_EMAIL_ERROR) { error_message = VGETTEXT("The email address for the nickname ā€˜$nickā€™ is banned on the forums board for this server.", i18n_symbols); 20180506 08:09:39<+discordbot2> @Vultraz Are these strings okay? 20180506 08:10:16<+discordbot2> They're awkward. Why are you not using possessives? 20180506 08:10:41<+discordbot2> What do you mean? 20180506 08:11:00<+discordbot2> "this server's forums" 20180506 08:12:04<+discordbot2> } else if((*error)["error_code"] == MP_NAME_AUTH_BAN_USER_ERROR) { error_message = VGETTEXT("The nickname ā€˜$nickā€™ is banned on this serverā€™s forums board.", i18n_symbols); } else if((*error)["error_code"] == MP_NAME_AUTH_BAN_IP_ERROR) { error_message = _("Your IP address is banned on this serverā€™s forums board."); } else if((*error)["error_code"] == 20180506 08:12:05<+discordbot2> MP_NAME_AUTH_BAN_EMAIL_ERROR) { error_message = VGETTEXT("The email address for the nickname ā€˜$nickā€™ is banned on this serverā€™s forums board.", i18n_symbols); 20180506 08:14:13<+discordbot2> @Vultraz Is this acceptable? 20180506 08:14:23<+discordbot2> I guess 20180506 08:14:40<+discordbot2> Okay, can we have a soft string freeze after merging this? 20180506 08:14:41<+discordbot2> I dunno why we need to mention forums at all, though 20180506 08:14:52<+discordbot2> Because they are forum bans. 20180506 08:15:43<+discordbot2> "board" is kind of unneeded. "banned on this server's forums" would work just as well. 20180506 08:15:54<+discordbot2> BLEH 20180506 08:16:55<+discordbot2> Going to convert those codes to an enum when you're done. 20180506 08:17:17<+discordbot2> Please don't. 20180506 08:17:39<+discordbot2> Leave them alone for a good while and don't make patch porting across branches harder than it needs to be. 20180506 08:18:01<+discordbot2> fine 20180506 08:18:05< vn971> @Vultraz > There's just no room. -- if you're referring to https://github.com/wesnoth/wesnoth/issues/3021 then I already wrote, scenario name is actually less important than even 20 letters of Mod list. 20180506 08:18:19<+discordbot2> oh for... 20180506 08:19:30< vn971> scenario name is most often understood by people from the image. This is why image is 4x higher than anything else and we're not objecting. If you really think there's no space, then remove the scenario name and still add Era back. Or better, both Era and Mod list.. 20180506 08:21:09< irker825> wesnoth: Iris Morelle wesnoth:1.14 bea9de088514 / src/ (8 files in 2 dirs): wesnothd: Initial support for checking forum bans during login https://github.com/wesnoth/wesnoth/commit/bea9de088514a720277b80730df0b03861bae4d7 20180506 08:21:12< irker825> wesnoth: Iris Morelle wesnoth:1.14 ec4af12994e0 / src/ (7 files in 2 dirs): wesnothd: Report different user_handler ban types https://github.com/wesnoth/wesnoth/commit/ec4af12994e03f2dfcd63ad504cb7baf3b0ffd73 20180506 08:21:15< irker825> wesnoth: Iris Morelle wesnoth:1.14 27a5eb4b8a92 / src/server/forum_user_handler.cpp: wesnothd/fuh: Check IP address bans before everything else https://github.com/wesnoth/wesnoth/commit/27a5eb4b8a92cdc625b1b6c09d7cf510e7aceb69 20180506 08:21:18< irker825> wesnoth: Iris Morelle wesnoth:1.14 869b4c29f57b / src/game_initialization/multiplayer.cpp: mp: Add client-side localization support for user_handler bans https://github.com/wesnoth/wesnoth/commit/869b4c29f57b0ef73b7719f1dcaf86d038b189f0 20180506 08:21:21< irker825> wesnoth: Iris Morelle wesnoth:1.14 f399d2854800 / src/server/forum_user_handler.cpp: fuh: Add NOTE on the status of glob bans https://github.com/wesnoth/wesnoth/commit/f399d28548002a14903cc052db3f8effe82e2935 20180506 08:21:34<+discordbot2> vn971: please. drop. it 20180506 08:21:55<+discordbot2> I added era 20180506 08:21:59<+discordbot2> but I'm not adding mods 20180506 08:22:56<+discordbot2> unless you want either horizontal scrollbars or tall-ass game list entries. 20180506 08:23:22<+discordbot2> It's not hard to mouse over an icon 20180506 08:23:35<+discordbot2> @Vultraz Can I pot-update now? 20180506 08:23:45<+discordbot2> Yes, I know UtBS' situation is still unsolved. 20180506 08:23:56<+discordbot2> zookeeper updated some stuff? 20180506 08:24:03<+discordbot2> If zookeeper or whoever still wants to merge those strings before 1.14.1 they can do that-- wait is it fixed? 20180506 08:24:29<+discordbot2> I was going to say it could be a soft string-freeze. Basically, don't touch what we actually need translators to translate ASAP -- the MP stuff. 20180506 08:24:32<+discordbot2> "tBS: Fixed some obsolete references to old elf units, weapons and hair" 20180506 08:24:43<+discordbot2> Does that fix the horses? 20180506 08:25:26<+discordbot2> no 20180506 08:25:58<+discordbot2> Soft string freeze then= 20180506 08:26:12< irker825> wesnoth: Iris Morelle wesnoth:master f2c06f0a4e0d / src/ (8 files in 2 dirs): wesnothd: Initial support for checking forum bans during login https://github.com/wesnoth/wesnoth/commit/f2c06f0a4e0d82a8e2a78d4ad25c91c09a6c2b63 20180506 08:26:15< irker825> wesnoth: Iris Morelle wesnoth:master 749e684f0398 / src/ (7 files in 2 dirs): wesnothd: Report different user_handler ban types https://github.com/wesnoth/wesnoth/commit/749e684f03982fe268ab15074f28d701d0e55f18 20180506 08:26:18< irker825> wesnoth: Iris Morelle wesnoth:master d48c84236c17 / src/server/forum_user_handler.cpp: wesnothd/fuh: Check IP address bans before everything else https://github.com/wesnoth/wesnoth/commit/d48c84236c17adca9421fe15d0d0666f1c2b96cb 20180506 08:26:20<+discordbot2> I still dunno if I'll get that extra lobby filter thing in 20180506 08:26:21< irker825> wesnoth: Iris Morelle wesnoth:master 80d6dbbaf94e / src/game_initialization/multiplayer.cpp: mp: Add client-side localization support for user_handler bans https://github.com/wesnoth/wesnoth/commit/80d6dbbaf94e17658a9bf05a28846d227e5d3259 20180506 08:26:24< irker825> wesnoth: Iris Morelle wesnoth:master c0f160b35150 / src/server/forum_user_handler.cpp: fuh: Add NOTE on the status of glob bans https://github.com/wesnoth/wesnoth/commit/c0f160b35150d1893b77da43de3279dfe54fc10c 20180506 08:26:34<+discordbot2> I just want the translators to focus on what we need for the registered users crap. 20180506 08:26:50<+discordbot2> You keep adding or changing any other strings as long as that remains intact. 20180506 08:27:04<+discordbot2> alright 20180506 08:30:03< irker825> wesnoth: Iris Morelle wesnoth:master 622b1936bc47 / changelog.md: Update changelog for MP server stuff from me and loonycyborg https://github.com/wesnoth/wesnoth/commit/622b1936bc47b92cebe5947c51b60afb890b037d 20180506 08:30:08< irker825> wesnoth: Iris Morelle wesnoth:1.14 3842d2749a18 / changelog.md: Update changelog for MP server stuff from me and loonycyborg https://github.com/wesnoth/wesnoth/commit/3842d2749a18054970d8c64143a1af554ed19c72 20180506 08:30:44<+discordbot2> @loonycyborg can you look at this https://github.com/wesnoth/wesnoth/issues/3038 20180506 08:31:39<+discordbot2> @Vultraz What will be the deadline then? 20180506 08:31:47<+discordbot2> uhhhhh 20180506 08:31:59<+discordbot2> tuesday 20180506 08:32:06<+discordbot2> 00:01 UTC? 20180506 08:32:30<+discordbot2> sure 20180506 08:32:51<+discordbot2> Okay, do I tell them Monday 23:00 UTC then or will you still wait an hour or two after that deadline? 20180506 08:33:18<+discordbot2> Although those translations will go through Ivanovic, so... 23:00 UTC might be safer. 20180506 08:33:29<+discordbot2> what? 20180506 08:33:40<+discordbot2> What is your question? 20180506 08:33:56<+discordbot2> I don't understand your question 20180506 08:34:15<+discordbot2> To avoid people submitting translations at the last minute. 20180506 08:34:26<+discordbot2> They will miss the train if Ivanovic is asleep by then. 20180506 08:34:32<+discordbot2> oh 20180506 08:34:33<+discordbot2> alright 20180506 08:34:33<+discordbot2> sure 20180506 08:34:40<+discordbot2> And I think he's in UTC+02. 20180506 08:34:43<+discordbot2> but keep in mind I'll probably be late anyway 20180506 08:34:55<+discordbot2> So 00:01 UTC Is 02:01 local time. 20180506 08:38:10< irker825> wesnoth: Iris Morelle wesnoth:1.14 fedcc6171ff6 / / (1544 files in 34 dirs): pot and documentation update without stat changes https://github.com/wesnoth/wesnoth/commit/fedcc6171ff6fc819d080d18e93dfcbd4d8692b8 20180506 08:40:09<+discordbot2> I'm seriously considering taking a long 20180506 08:40:16<+discordbot2> break from wesnoth after this 20180506 08:40:42<+discordbot2> Same. 20180506 08:41:32<+discordbot2> One is supposed to enjoy one's hobbies and instead all it's doing right now is enraging, frustrating, and stressing me out 20180506 08:42:05<+discordbot2> It all seems futile. 20180506 08:42:20<+discordbot2> Despite our best efforts we release 1.14.0 and find everything just as broken as before 20180506 08:43:55<+discordbot2> Email sent. 20180506 08:44:33-!- shadowm changed the topic of #wesnoth-dev to: 1.14.1 scheduled for Tuesday May 8th 00:01 UTC | SOFT string freeze on 1.14, any new or changed strings will NOT be translated | Wesnoth Developers Channel | >>> Want to help? Go here: https://r.wesnoth.org/t42911 (and thanks!) <<< | Discord Server: https://discord.gg/battleforwesnoth | Logs: http://irclogs.wesnoth.org 20180506 08:44:58<+discordbot2> And yes, I am aware I've been acting like the world's biggest ass all week 20180506 08:45:23<+discordbot2> I have some stuff going on (not wesnoth related) and that's also getting to me 20180506 08:46:01<+discordbot2> in fact it seems all wesnoth is doing is providing a distraction from the shit I should be doing. 20180506 08:47:39<+discordbot2> Relatable. 20180506 08:48:17<+discordbot2> Though one has to question what type of distraction it is if engaging it it makes one want to hurl their laptop at the wall half the time 20180506 08:51:17<+discordbot2> Well, I can't really speak to the other stuff you have going on, but for everything that's gone on, 1.14 doesn't seem to have gone too horribly. It's certainly a step up from 1.12. 20180506 08:54:38< vn971> what's most importantly, in my opinion, is that it's the first stable release in a couple of years. And due to the nature if it being a game -- very few people actually used beta before the release. It's hard to write correct code and maintain such a huge project without anyone testing. 20180506 08:55:09< vn971> Embracing that there will be bugs and that a couple of months will be spent just fixing them -- seems the only way out... Then again, I could be wrong. 20180506 08:55:20< vn971> * Embracing the fact that 20180506 08:55:53<+discordbot2> What's most frustrating is coming up against issues I cannot fix. 20180506 08:56:26<+discordbot2> It's very likely 1.15.0 will never release. 20180506 08:56:36<+discordbot2> at this rate, at least 20180506 09:00:13<+discordbot2> While obviously easier said than done, for things that you can't do anything about, getting frustrated about them is the worst thing you can do. Because since you can't fix them, they'll stay there and only make you more frustrated. 20180506 09:00:32<+discordbot2> fair point 20180506 09:03:07<+discordbot2> but they also seem to be the things everyone jumps on 20180506 09:03:22<+discordbot2> "scrolling issue!" " Scrolling issue" " SCROLLING ISSUE!" 20180506 09:03:27<+discordbot2> "GIFF MOD LIST" 20180506 09:03:34<+discordbot2> "master is broken" 20180506 09:03:42<+discordbot2> "when will master be fixed" 20180506 09:03:52<+discordbot2> "it's blocking all development" 20180506 09:04:21<+discordbot2> "M O D L I S T" 20180506 09:04:31<+discordbot2> "oh here's another scrollbar" 20180506 09:04:36<+discordbot2> "why does text look like shit" 20180506 09:04:39<+discordbot2> "SCROLLBAR" 20180506 09:04:57<+discordbot2> "yeah ya know you need to redesign this" 20180506 09:05:14<+discordbot2> "chat scrolls to top" 20180506 09:05:29<+discordbot2> "performance is slow" 20180506 09:07:40<+discordbot2> not to mention the endless pit of hell that is the business with the steamworks sdk 20180506 09:07:44<+discordbot2> or lack of, rather 20180506 09:08:55<+discordbot2> which, for some of those like the mod list(which I also don't really understand, given there's a hover), the answer is just "won't fix, working as intended". And for the rest, I mean, you are only one person. Even if Wesnoth was the sole thing you were doing with your life, you can't solve the world. You're going to be overwhelmed if you try. 20180506 09:09:20<+discordbot2> yeah, that's true... 20180506 09:09:39<+discordbot2> "You can't please everyone." 20180506 09:10:02<+discordbot2> UI in particular 20180506 09:10:45<+discordbot2> a lot of it too, I'd imagine, is just the amount of things that changed from 1.12. 20180506 09:10:56<+discordbot2> When it comes to objective regressions, many software projects avoid them with a policy "regressing commits are reverted". 20180506 09:11:12<+discordbot2> A commit causes a bug and the author refuses to fix it for whatever reason? Just revert it. 20180506 09:11:20<+discordbot2> most users haven't been using master constantly, and are seeing everything all at once. 20180506 09:11:52<+discordbot2> give it a month or two, and people will get used to it. 20180506 09:12:29<+discordbot2> hopefully 20180506 09:12:34<+discordbot2> thanks 20180506 09:12:58<+discordbot2> np šŸ™‚ 20180506 09:13:19-!- travis-ci [~travis-ci@ec2-54-167-89-247.compute-1.amazonaws.com] has joined #wesnoth-dev 20180506 09:13:20< travis-ci> wesnoth/wesnoth#17995 (1.14 - 869b4c2 : Iris Morelle): The build passed. 20180506 09:13:20< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/375472654 20180506 09:13:20-!- travis-ci [~travis-ci@ec2-54-167-89-247.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180506 09:20:51< lipkab> https://github.com/wesnoth/wesnoth/issues/3034 20180506 09:21:12< lipkab> I decided I'd look into this, but I can't seem to be able to reproduce. 20180506 09:21:38< lipkab> Does it happen to any of you guys? Especially Linux guys? 20180506 09:21:44<+discordbot2> Maybe it depends on hardware? 20180506 09:21:56< lipkab> Also, where is this group players option? I can't find it. 20180506 09:23:41<+discordbot2> In Advanced section 20180506 09:23:58<+discordbot2> lipkab: It's in Preferences > Advanced 20180506 09:24:24< lipkab> Well, CPU usage seems to go up a little when open that list, but it's like 1 or 2 percents. 20180506 09:24:34< lipkab> And I'm not on a supercomputer. 20180506 09:25:04< lipkab> The guy has some really ancient hardware if that's the issue. 20180506 09:25:15< lipkab> RatArmy, Pentarctagon: Thanks! 20180506 09:25:45<+discordbot2> I've got that enabled by default, and currently Wesnoth is sitting at under 1% CPU usage 20180506 09:26:38<+discordbot2> admittedly it might become noticable when there's more people online, since it can be more than double what it is now, but still 20180506 09:27:17< lipkab> Are you using Windows? 20180506 09:27:26<+discordbot2> linux, Mint 18.3 20180506 09:27:41< lipkab> Mm-hm. 20180506 09:28:35<+discordbot2> I've got a good CPU as well, so it's pretty much the opposite of testing if it happens on old hardware 20180506 09:28:55<+discordbot2> Maybe he's using a debug build? 20180506 09:29:07<+discordbot2> No, I used steam one 20180506 09:29:42< lipkab> Ah, it's you? 20180506 09:30:02<+discordbot2> Ye 20180506 09:30:05<+discordbot2> s 20180506 09:30:17<+discordbot2> what CPU do you have? 20180506 09:30:50<+discordbot2> I've also noticed slight lag when grouping is disabled 20180506 09:31:20<+discordbot2> i7-4600U 20180506 09:31:37< lipkab> Ok, that's not exactly "ancient" :D 20180506 09:31:44<+discordbot2> 2.69GHz x 4 , not so bad 20180506 09:32:02<+discordbot2> I have an i7-7500U 20180506 09:32:31< lipkab> No, not at all. I have an i5-something-U, and it's totally smooth for me. This will be something else. 20180506 09:32:44<+discordbot2> 2.70 GHz x 2 (4 virtual) 20180506 09:33:06<+discordbot2> indeed 20180506 09:34:32< lipkab> Vultraz: Do you still have your Windows machine? 20180506 09:34:50<+discordbot2> I'm now in lobby and not so heavy but, number of user was over 100 when I wrote report 20180506 09:35:12<+discordbot2> now about 60 people in lobby 20180506 09:35:44<+discordbot2> How high CPU usage do you have now (look in Task Manager)? 20180506 09:35:44<+discordbot2> yeah, 100+ seems to be when people are reporting slowness 20180506 09:36:09< lipkab> Mm-hm. 20180506 09:36:52<+discordbot2> expand: 10% no-expand: 3% 20180506 09:37:56<+discordbot2> Okay. For Wesnoth to become slow, CPU load needs to at least three times as high. 20180506 09:38:14<+discordbot2> So it sounds like CPU usage increases exponentially when there are more players. 20180506 09:39:04< lipkab> I'm betting on quadratical actually, but yeah, something like that. 20180506 09:39:52< Soliton> the more users the more changes and the more work on rebuilding the list. 20180506 09:40:25-!- travis-ci [~travis-ci@ec2-54-205-245-66.compute-1.amazonaws.com] has joined #wesnoth-dev 20180506 09:40:26< travis-ci> Pentarctagon/wesnoth#10 (scons-cmake-more-warnings - 3eeac1e : Pentarctagon): The build passed. 20180506 09:40:27< travis-ci> Build details : https://travis-ci.org/Pentarctagon/wesnoth/builds/375474406 20180506 09:40:27-!- travis-ci [~travis-ci@ec2-54-205-245-66.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180506 09:40:55<+discordbot2> maybe just rebuild the list less frequently then? It isn't something that would be changing constantly, I'd imagine, and it's not exactly the end of the world of users appear in both lists for a bit. 20180506 09:41:03< lipkab> But it's still just a list with 100 entries. This *should* be doable on an i7. 20180506 09:41:05< Soliton> wasn't there some timer that is supposed to restrict how often the list can be rebuilt? 20180506 09:41:28<+discordbot2> Indeed, I think rebuilding the player/game list only once per second or something would help. 20180506 09:41:56<+discordbot2> lipkab: Most likely the expensive part is laying out the window. 20180506 09:47:58<+discordbot2> How does the client know about changes to the list? Does the client request it, or does the server periodically send the list out? 20180506 09:48:27< Soliton> server sends changes as they happen. 20180506 09:49:26-!- travis-ci [~travis-ci@ec2-54-167-89-247.compute-1.amazonaws.com] has joined #wesnoth-dev 20180506 09:49:27< travis-ci> wesnoth/wesnoth#17997 (1.14 - fedcc61 : Iris Morelle): The build passed. 20180506 09:49:27< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/375475454 20180506 09:49:27-!- travis-ci [~travis-ci@ec2-54-167-89-247.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180506 09:49:28<+discordbot2> huh 20180506 09:49:47<+discordbot2> The client polls for changes 10 times per second. 20180506 09:50:11<+discordbot2> that seems a bit excessive 20180506 09:50:17<+discordbot2> https://github.com/wesnoth/wesnoth/blob/1.14/src/gui/dialogs/multiplayer/lobby.hpp#L211 20180506 09:50:50<+discordbot2> https://github.com/wesnoth/wesnoth/blob/1.14/src/game_config.cpp#L104 20180506 09:50:59<+discordbot2> (It's in milliseconds.) 20180506 09:52:30< Soliton> it should only rebuild the list every 4 seconds though? 20180506 09:54:20<+discordbot2> https://github.com/wesnoth/wesnoth/blob/1.14/src/gui/dialogs/multiplayer/lobby.cpp#L849 20180506 09:54:39<+discordbot2> Every four seconds is when the game list is rebuilt. 20180506 09:54:53<+discordbot2> Player list is allowed to update much faster. 20180506 09:55:28<+discordbot2> And laying out the window (as a result of a player list update) requires laying out everything, including the game list. 20180506 09:55:45< Soliton> ah, sounds like that should be changed then. 20180506 09:57:42<+discordbot2> sounds like they might as well be the same, and update everything in one go. 20180506 10:06:59< irker825> wesnoth/wesnoth:1.14 Iris Morelle da4d2b098c gui2/unit_attack: Only display active sp AppVeyor: All builds passed 20180506 10:12:29< irker825> wesnoth: Alexander van Gessel wesnoth:1.14 32a1eaee3087 / src/ (image.cpp serialization/base64.cpp): Reject bad data URIs https://github.com/wesnoth/wesnoth/commit/32a1eaee30871b71428dd71b6e44c0e7b39c36fa 20180506 10:13:50< irker825> wesnoth: Alexander van Gessel wesnoth:master 6444ebde60c5 / src/ (image.cpp serialization/base64.cpp): Reject bad data URIs https://github.com/wesnoth/wesnoth/commit/6444ebde60c5eef7923fde325b49ee1a26d1b272 20180506 10:14:56< irker825> wesnoth: Iris Morelle wesnoth:master 9850d3fa9c7f / changelog.md: Update changelog for #3019 https://github.com/wesnoth/wesnoth/commit/9850d3fa9c7f88c5433f054af9c8c6305edfe59b 20180506 10:15:12< irker825> wesnoth: Iris Morelle wesnoth:1.14 d4101b87d65a / changelog.md: Update changelog for #3019 https://github.com/wesnoth/wesnoth/commit/d4101b87d65a0fd53f199da829f641f2a67eaad6 20180506 10:21:01<+discordbot2> I ask a question in a tech support thread, nobody answers it. Okay then. 20180506 10:52:37-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180506 10:57:02< irker825> wesnoth: Lipka BoldizsĆ”r wesnoth:master 590fd3c4d5a1 / src/gui/dialogs/multiplayer/ (lobby.cpp lobby.hpp): Fix excessive mp lobby refreshing. https://github.com/wesnoth/wesnoth/commit/590fd3c4d5a19e33235bbb9c286ee3532d886944 20180506 10:57:17< lipkab> Whoops. 20180506 10:57:49< lipkab> I wanted to create a branch for this :/ 20180506 10:58:50< lipkab> ^ Could someone, who has actually touched the Wesnoth code in the past two years, please check that I didn't break something? 20180506 11:04:41< lipkab> Nevermind, I'll revert it and create a PR. 20180506 11:04:58< lipkab> I don't wanna break stuff. 20180506 11:05:22< irker825> wesnoth: Lipka BoldizsĆ”r wesnoth:master 8bd6646182ca / src/gui/dialogs/multiplayer/ (lobby.cpp lobby.hpp): Revert "Fix excessive mp lobby refreshing." https://github.com/wesnoth/wesnoth/commit/8bd6646182ca30d0fbf04688e16c44bb1f54a7b5 20180506 11:07:29< irker825> wesnoth: Lipka BoldizsĆ”r wesnoth:fix_3034 fa2aced391c6 / src/gui/dialogs/multiplayer/ (lobby.cpp lobby.hpp): Fix excessive mp lobby refreshing. https://github.com/wesnoth/wesnoth/commit/fa2aced391c647ea6c0198c629d04cdc8fbb52ac 20180506 11:08:10-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20180506 11:10:09< lipkab> Ok, here's the PR: https://github.com/wesnoth/wesnoth/pull/3041 20180506 11:32:43< irker825> wesnoth: Nils Kneuper wesnoth:1.14 247dd1c236db / / (9 files in 8 dirs): updated Czech translation https://github.com/wesnoth/wesnoth/commit/247dd1c236db339908f7a25f55f2778a87a3be67 20180506 11:32:51< irker825> wesnoth: Nils Kneuper wesnoth:master 0dda29b23886 / po/ (10 files in 10 dirs): updated Czech translation https://github.com/wesnoth/wesnoth/commit/0dda29b238864e0c9fa272fd466f5f333e5d5e27 20180506 11:41:50<+discordbot2> lipkab: that looks like a reasonable start 20180506 11:42:35< irker825> wesnoth: Lipka BoldizsĆ”r wesnoth:master 7b5cf854614e / src/gui/dialogs/multiplayer/ (lobby.cpp lobby.hpp): Fix excessive mp lobby refreshing. https://github.com/wesnoth/wesnoth/commit/7b5cf854614e775f09df5b01f24302e449cd89e9 20180506 11:43:56< irker825> wesnoth: Nils Kneuper wesnoth:1.14 706180f27c41 / / (11 files in 10 dirs): updated British English translation https://github.com/wesnoth/wesnoth/commit/706180f27c4196b4e6ccc44efce607f9635b5f97 20180506 11:44:35< irker825> wesnoth: Nils Kneuper wesnoth:master d98d711e24ef / po/ (9 files in 9 dirs): updated British English translation https://github.com/wesnoth/wesnoth/commit/d98d711e24eff8ca5b1ccac907901d432974596f 20180506 11:45:02< irker825> wesnoth: Lipka BoldizsĆ”r wesnoth:1.14 4f46f9ba50f4 / src/gui/dialogs/multiplayer/ (lobby.cpp lobby.hpp): Fix excessive mp lobby refreshing. https://github.com/wesnoth/wesnoth/commit/4f46f9ba50f435f121ca42c86923dbb11b4c4a79 20180506 11:48:53< irker825> wesnoth/wesnoth:1.14 doofus-01 aa80efde18 Kaleh bolas anim AppVeyor: All builds passed 20180506 11:50:11-!- travis-ci [~travis-ci@ec2-54-159-139-14.compute-1.amazonaws.com] has joined #wesnoth-dev 20180506 11:50:12< travis-ci> wesnoth/wesnoth#18002 (fix_3034 - fa2aced : Lipka BoldizsĆ”r): The build passed. 20180506 11:50:12< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/375504981 20180506 11:50:12-!- travis-ci [~travis-ci@ec2-54-159-139-14.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180506 11:50:42<+discordbot2> @Ravana does the ingame text look better? 20180506 11:50:53<+discordbot2> it seemed noticeably better with SIZE_15 20180506 11:52:08<+discordbot2> (which I pushed) 20180506 11:56:10< irker825> wesnoth: Charles Dang wesnoth:1.14 5fd833a91af5 / src/game_config.cpp: MP Lobby: reduced frequency of network polls (100ms -> 1000ms) https://github.com/wesnoth/wesnoth/commit/5fd833a91af57df3134e4e87a1d36b23c2811652 20180506 11:58:10<+discordbot2> oh, wait 20180506 11:58:11<+discordbot2> nevermind 20180506 11:58:17<+discordbot2> you don't have a build šŸ˜¬ 20180506 11:59:39< Ravana_> this together with lobby refresh is large enough change to try get immediately 20180506 11:59:42< irker825> wesnoth: Charles Dang wesnoth:master fe10bc031547 / data/gui/window/lobby_main.cfg src/gui/dialogs/multiplayer/lobby.cpp: MP Lobby: removed Refresh button https://github.com/wesnoth/wesnoth/commit/fe10bc0315472b49072a39cd577b9872617d81d3 20180506 11:59:45< irker825> wesnoth: Charles Dang wesnoth:master 2769345f558f / src/display_chat_manager.cpp: Increased in-game chat size. This makes it render more smoothly https://github.com/wesnoth/wesnoth/commit/2769345f558fb83b4979bb213ceaac84622ee76b 20180506 11:59:48< irker825> wesnoth: Charles Dang wesnoth:master be580a197350 / src/gui/widgets/chatbox.cpp: GUI2/Chatbox: attempt to send roomless messages to the active room first https://github.com/wesnoth/wesnoth/commit/be580a1973509f5b1ecf545f5bd17bdcd594b65c 20180506 11:59:52< irker825> wesnoth: Charles Dang wesnoth:master 6d84ee70c52c / src/gui/dialogs/multiplayer/lobby.cpp: MP Lobby: rearrange player list nodes and have Selected Game also expanded by de https://github.com/wesnoth/wesnoth/commit/6d84ee70c52c59f27997bc67d9358b96e06cb527 20180506 11:59:54< irker825> wesnoth: Charles Dang wesnoth:master 79c98621291e / src/game_config.cpp: MP Lobby: reduced frequency of network polls (100ms -> 1000ms) https://github.com/wesnoth/wesnoth/commit/79c98621291e3ee3c274738d4b1ab8a9d62444ee 20180506 12:00:21<+discordbot2> (was going to ask you confirm the PM notice thing was also fixed) 20180506 12:01:07< Ravana_> query commands also have no visible output in staging contest, but that can wait 20180506 12:01:13< Ravana_> context 20180506 12:02:43<+discordbot2> hmm 20180506 12:03:04<+discordbot2> ya know, I think I should probably redesign the data handling in the lobby... 20180506 12:04:34-!- DeFender1031 [~DeFender1@89-138-91-7.bb.netvision.net.il] has quit [Quit: I'm not back now.] 20180506 12:04:35<+discordbot2> ponders. 20180506 12:06:11<+discordbot2> right now it's polled by a timer every second, and the game and user lists updated no less than every 4 20180506 12:06:46<+discordbot2> I wonder if I should set a worker thread to just spin in place until it receives data 20180506 12:07:40<+discordbot2> we havewesnothd_connection::wait_and_receive_data 20180506 12:08:59<+discordbot2> orI could delegate all the list processing to a worker thread šŸ¤” 20180506 12:09:26<+discordbot2> I shall need to consider this 20180506 12:12:16-!- travis-ci [~travis-ci@ec2-54-167-89-247.compute-1.amazonaws.com] has joined #wesnoth-dev 20180506 12:12:17< travis-ci> wesnoth/wesnoth#18008 (master - d98d711 : Nils Kneuper): The build passed. 20180506 12:12:17< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/375512243 20180506 12:12:17-!- travis-ci [~travis-ci@ec2-54-167-89-247.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180506 12:16:34< Soliton> @Vultraz: i think you're doing an excellent job fixing the issues with 1.14. (not only you of course others as well.) no need to get discouraged if not everything is easy/feasable to fix etc. it's unfortunately natural that a lot of things crop up after a stable release. 20180506 12:16:52<+discordbot2> thanks 20180506 12:16:55<+discordbot2> I appreciate it 20180506 12:17:52< Ravana_> started compiling, should be ready in few h 20180506 12:18:26<+discordbot2> o_O 20180506 12:19:09< Soliton> @Vultraz: i would suggest taking some time to document the issues with GUI2 that look unfeasable to fix right now. you' re probably the person knowing best what those issues are. then it's easier to point to deficiencies of GUI2 when some design can't be done how you'd actually want it and then it's easier for others to help improve GUI2 where it is needed. 20180506 12:20:45< vn971> Ravana_: do you use ccache and parallel compile? I find it much more tolerable if I use `nice -n19`, ccache and high parallelism. 20180506 12:23:02< Ravana_> no idea, I just write scons 20180506 12:24:00<+discordbot2> scons jobs=$your_number_of_cores 20180506 12:24:20<+discordbot2> only this does the most of benefit if you got a multicore cpu 20180506 12:24:37<+discordbot2> ccache doesn't help with building newly modified code 20180506 12:28:05<+discordbot2> scons jobs=4 arch=native openmp=True enable_lto=True wesnoth 20180506 12:28:47<+discordbot2> arch=native and openmp=True aren't expected to give a big performance boost. 20180506 12:28:59<+discordbot2> is what I basically use. Though these options are saved in .scons-option-cache and are applied the next time when I write only scons 20180506 12:30:37-!- travis-ci [~travis-ci@ec2-54-167-89-247.compute-1.amazonaws.com] has joined #wesnoth-dev 20180506 12:30:38< travis-ci> wesnoth/wesnoth#18010 (1.14 - 5fd833a : Charles Dang): The build passed. 20180506 12:30:38< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/375514643 20180506 12:30:38-!- travis-ci [~travis-ci@ec2-54-167-89-247.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180506 12:47:50-!- travis-ci [~travis-ci@ec2-54-167-89-247.compute-1.amazonaws.com] has joined #wesnoth-dev 20180506 12:47:51< travis-ci> wesnoth/wesnoth#18011 (master - 79c9862 : Charles Dang): The build passed. 20180506 12:47:51< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/375515309 20180506 12:47:51-!- travis-ci [~travis-ci@ec2-54-167-89-247.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180506 12:48:21-!- lipkab [~lipk@host-91-147-210-58.biatv.hu] has quit [Ping timeout: 264 seconds] 20180506 12:56:23-!- Necrosporus_ [~Necrospor@unaffiliated/necrosporus] has joined #wesnoth-dev 20180506 12:56:23-!- Necrosporus [~Necrospor@unaffiliated/necrosporus] has quit [Killed (verne.freenode.net (Nickname regained by services))] 20180506 12:56:23-!- Necrosporus_ is now known as Necrosporus 20180506 12:58:16< celticminstrel> [May 06@04:07:59am] discordbot2: There's just no room. 20180506 12:58:29< celticminstrel> Oh come on, that's clearly 100% false. 20180506 12:58:46< celticminstrel> Don't make up excuses for not adding the mods list. 20180506 12:59:10< celticminstrel> I don't really mind not having the list, but the "no space" argument holds no water. 20180506 12:59:49< celticminstrel> (Also, I could've sworn I sleep-nicked last night? Did I actually forget or was there a connectivity interruption?) 20180506 13:01:49<+discordbot2> Please don't demand changes. We are all volunteers, and you can change things yourself. 20180506 13:04:21< celticminstrel> I'm not demanding changes, I'm complaining about his reasoning for not changing. 20180506 13:04:27< celticminstrel> I don't really have a problem with the decision. 20180506 13:04:57< celticminstrel> But trying to say it's due to a lack of space clearly makes no sense when the lobby has a lot of empty space for each game entry, 20180506 13:12:20< celticminstrel> @shadowm: Is there time to merge PR 3002? 20180506 13:14:52<+discordbot2> probably not, since the pot update has been done already, and translations must be ready in ~ 1 day 20180506 13:15:18< vn971> Ravana_: in addition to what jyrkive wrote, I'd suggest to use `nice`, too. So it'd be `nice -n19 scons jobs=4 ...` Helps a bit to keep other apps responsive. 20180506 13:16:06< celticminstrel> In that case, kinda disappointed that it got overlooked. 20180506 13:18:16< Ravana_> just finished compiling 20180506 13:19:52< vn971> Guys, I don't know if it's relevant at all, but a player "Yendor" explains in a game chat that he had problems after installing an add-on. There was an error, he says: 20180506 13:19:53< vn971> > Condition '!must_exist||result' failed at src/gui/auxiliary/find_widget.hpp:74 in function 'find_widget'. 20180506 13:20:26< vn971> > Mandatory widget "addons" hasn't been deefined. 20180506 13:21:05< Ravana_> Vultraz: chat looks great now 20180506 13:21:07< vn971> I have no idea if it's useful, whether he uses a manually compiled 1.14 branch or official etc. So just disregard this info if it doesn't help finding any bug. 20180506 13:23:15<+discordbot2> Trying to build Wesnoth 1.14 with VSC 17, I get an error that ....\src\spritesheet_generator.cpp is missing. 20180506 13:23:28< celticminstrel> ... 20180506 13:23:36< celticminstrel> That file only exists on master. 20180506 13:23:48< celticminstrel> So it should be safe to just delete it from the project file. 20180506 13:24:14<+discordbot2> celticminstrel, I would have merged it earlier, but I was under the impression that there would be no pot update before 1.14.1 (which would have been bad, but in that case it would be less bad with the string changes) 20180506 13:24:36<+discordbot2> vn971, coudl you eventually fill an issue, so it's not being lost 20180506 13:25:51<+discordbot2> celticminstrel, with/without/ 20180506 13:26:06< vn971> sevu: I was doubtful if this level of detail is really useful to anyone. Wouldn't want to create a "dead" issue that'll doesn't help but just fills up the list. Is this info really enough to start digging? 20180506 13:26:41<+discordbot2> Indeed, it's not enough information to figure out what's happening. 20180506 13:29:47< Ravana_> Vultraz: cpu goes over 60% (70% when scrolling gamelist) in lobby sometimes, but overall I say #3004 is fixed 20180506 13:36:21-!- Appleman1234 [~quassel@124x38x163x22.ap124.ftth.ucom.ne.jp] has quit [Ping timeout: 240 seconds] 20180506 13:43:10<+discordbot2> So it should be safe to just delete it from the project file. Same goes for ingame_ui_base.cpp and game_ui.cpp ? 20180506 13:45:16<+discordbot2> Indeed, they are also master-exclusive. 20180506 14:25:00< celticminstrel> loonycyborg: Do you think there's any merit in including a shortcut to GUI.pyw in the installer? 20180506 14:25:35< celticminstrel> Might be a little tricky, mind you; I think you'd have to detect the Python3 install location somehow. 20180506 14:26:12< loonycyborg> maybe 20180506 14:26:25< loonycyborg> is it used by a lot of people? 20180506 14:26:40< celticminstrel> Not sure. 20180506 14:26:49< celticminstrel> Probably only add-on developers, but not sure how many of them. 20180506 14:26:49< loonycyborg> is there a good place to read up on umc developer workflow and their favored tools? 20180506 14:26:57< celticminstrel> ...^-propbably 20180506 14:27:22< celticminstrel> BTW, on a related note, since GUI.pyw references wmlxgettext we should probably distribute it with the game too. 20180506 14:27:37< celticminstrel> I don't know of a good place to read up on that... 20180506 14:29:06< mattsc> loonycyborg: the ā€˜Createā€™ section on the wiki contains a page about the tools. Thatā€™s probably the closest to what you asked about. 20180506 14:31:44< mattsc> @Vultraz, zookeeper, Soliton (I think thatā€™s whoā€™s commented on the new AToTB AI), All: instead of removing the AI again, I suggest we make the two guard units slightly weaker, to counter the increased difficulty in what is really meant to be the beginnerā€™s campaign. 20180506 15:00:49-!- irker825 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout] 20180506 15:13:43-!- irker306 [~irker@uruz.ai0867.net] has joined #wesnoth-dev 20180506 15:13:43< irker306> wesnoth: Nils Kneuper wesnoth:master d0ebbbb7c3e7 / po/ (13 files in 13 dirs): updated Chinese (Simplified) translation https://github.com/wesnoth/wesnoth/commit/d0ebbbb7c3e7ddb9001c1e432a69fe93aa9a01ba 20180506 15:13:43< irker306> wesnoth: Nils Kneuper wesnoth:1.14 8c5f82e0dbca / / (15 files in 14 dirs): updated Chinese (Simplified) translation https://github.com/wesnoth/wesnoth/commit/8c5f82e0dbcaae001f3d8ba8abdbff6ceb34460b 20180506 15:13:49-!- louis94 [~~louis94@91.176.171.238] has joined #wesnoth-dev 20180506 15:15:34< Ivanovic> mattsc: the initial idea what that you could :droid on easy and the AI should be able to win in your plance in ~99% of all cases 20180506 15:15:45< Ivanovic> while it was supposed to be a real challenge on hard 20180506 15:16:22< Ivanovic> so if you change the enemy AI in that level you should test several times if you need to alter the rest of the balance as well 20180506 15:23:44<+discordbot2> another of the St8bad_cast exception: https://forums.wesnoth.org/viewtopic.php?f=4&t=48132 20180506 15:23:46< mattsc> Ivanovic: (this isnā€™t meant as a contradiction to what youā€™re saying) just FYI: this AI only controls the dark adept side leader appearing at the end, nothing else, so it only has a small (but existing) effect on the balance 20180506 15:24:32< mattsc> And itā€™s supposed to be real challenge on hard for the human player? (Iā€™m asking because, at least for a somewhat experienced player, I donā€™t think that it is.) 20180506 15:25:05< mattsc> Anyways, at this point I am tempted to revert the new AI inclusion ... 20180506 15:25:13< Ivanovic> mattsc: that what DK helped me to balance things for back in the days 20180506 15:25:27< Ivanovic> to match the "hard" difficulty level it advertises on hard 20180506 15:25:28< Ivanovic> ;) 20180506 15:29:09-!- DeFender1031 [~DeFender1@89-138-91-7.bb.netvision.net.il] has joined #wesnoth-dev 20180506 15:33:49< celticminstrel> So what's wrong with the new AI exactly? 20180506 15:34:20< mattsc> Ivanovic: Sorry, donā€™t mean to come across as arrogant or something here. :) Thatā€™s the problem with words like ā€œreal challengeā€ and ā€œhardā€. The scenario can certainly qualify as that depending on how one interprets those terms. 20180506 15:34:43< mattsc> celticminstrel: Nothingā€™s wrong with the AI, and thatā€™s the problem. It changes the balance of the scenario. 20180506 15:35:05< Ivanovic> then, at least for easy the dark adepts side needs to be scaled down a little 20180506 15:35:20< Ivanovic> no idea if that is also required for "hard" or not 20180506 15:36:13< mattsc> Ivanovic: Yes, that was my last proposal as well. But I do not have time to do several playthroughs before 1.14.1 is tagged, and if you say that the side worked as it was intended, then maybe we should go back to it. 20180506 15:36:20-!- gfgtdf [~chatzilla@x4e363492.dyn.telefonica.de] has joined #wesnoth-dev 20180506 15:36:29< celticminstrel> Does that mean reverting just on 1.14 branch? 20180506 15:36:40< Ivanovic> I have no idea if it still worked as intended in 1.14.0 20180506 15:36:56< Ivanovic> since I have not played the campaign for ages and balancing and rule changes might have altered balancing... 20180506 15:37:11< mattsc> Was the dark adept rushing out and being an easy kill intended? 20180506 15:37:29< mattsc> Because thatā€™s the part the new AI changes/ 20180506 15:37:41< Ivanovic> that is why he was only placed "rather late" so that he would at least not rush out too far... 20180506 15:39:05< mattsc> celticminstrel: itā€™s a balance change, if it is undesired (not saying that it is, but if ā€¦) it does not make sense to revert it only in 1.14. 20180506 15:39:27-!- louis94 [~~louis94@91.176.171.238] has quit [Ping timeout: 240 seconds] 20180506 15:40:14< celticminstrel> Does sound like the dark adept rushing out was not intended... 20180506 15:40:33< mattsc> Ivanovic: the way it worked before is that you could lure him out with easy bait, and then surround and kill him, mostly ignoring the skeletons/revenants. 20180506 15:40:41< celticminstrel> If the balance change is not wanted, yes, but if it's just that you don't have the time to rebalance things as needed... 20180506 15:41:04< mattsc> With the new AI, he hides behind those, so it gets easier by him not attacking, but it gets harder by you having to go through the skeletons. 20180506 15:41:28< mattsc> celticminstrel: agreed 20180506 15:43:10< mattsc> Alright, so how about this: we revert it for 1.14. Itā€™s a bit iffy to do something like this that isnā€™t really a bug in the middle of the stable series. And for 1.15 we do more careful testing and rebalance as needed. 20180506 15:43:20< mattsc> I want to do a bunch of AI work for 1.15 anyway. 20180506 15:47:35<+discordbot2> Why it so much harder to build 1.14. šŸ˜… After purging all the files which could not be found from the project, I now get a bunch of unresolved external symbol errors. 20180506 15:48:40<+discordbot2> The Visual Stido project file in the 1.14 branch isn't supposed to reference the files which don't exist there (and indeed didn't last I checked, yesterday). 20180506 15:51:16<+discordbot2> Maybe because I was building master right before switching to the 1.14 (because I forgot for the moment that master is pretty much broken) 20180506 15:51:30<+discordbot2> *1.14 branch 20180506 15:52:06< Ivanovic> mattsc: sounds like a reasonable approach 20180506 15:53:25-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180506 15:53:28< mattsc> Ivanovic: and thanks for clarifying what the intention was. Itā€™s always good to know that. 20180506 15:53:43-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20180506 16:05:19<+discordbot2> celticminstrel: Let me clarify: 1) see the channel topic; 2) yes, you can merge string changes, just remember they will not be translated. 20180506 16:05:42< celticminstrel> 'kay, I'll merge it then. 20180506 16:06:39< irker306> wesnoth: Wedge009 wesnoth:1.14 1bd7f80136cf / / (4 files in 4 dirs): Update text to match changes in dialogues (fixes #2882). https://github.com/wesnoth/wesnoth/commit/1bd7f80136cf151ab3ae5e5223f0f2d026b5a8ae 20180506 16:06:41< irker306> wesnoth: Wedge009 wesnoth:1.14 00cccd19f5ae / data/ (3 files in 2 dirs): Update text to match game-play changes (fixes #2950). https://github.com/wesnoth/wesnoth/commit/00cccd19f5aece1030494601165b5c3db877d301 20180506 16:08:23<+discordbot2> (And don't touch the strings I asked translators to translate.) 20180506 16:08:31<+discordbot2> (The ones for the MP menu.) 20180506 16:18:53-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20180506 16:19:33-!- louis94 [~~louis94@91.176.171.238] has joined #wesnoth-dev 20180506 16:23:50<+discordbot2> celticminstrel, that was not good to merge them now - all languages other than English have now strings which won't be translated fot 1.14.1 in the tutorial. I suggest to revert and include it after the tagging 20180506 16:24:28< celticminstrel> :/ 20180506 16:25:07< celticminstrel> Well, sure, I guess. 20180506 16:25:19< celticminstrel> If your complaint is specifically the tutorial, than just the one commit. 20180506 16:27:55<+discordbot2> It's affect the other one two, but I think that's something we can live with 20180506 16:28:10< celticminstrel> ... 20180506 16:28:11< celticminstrel> ^then 20180506 16:29:29-!- gfgtdf [~chatzilla@x4e363492.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.93 [Firefox 52.7.4/20180427222832]] 20180506 16:33:13 * celticminstrel tags wedge009 on this. 20180506 16:34:28<+discordbot2> https://cdn.discordapp.com/attachments/259976436490829825/442725838073495562/image.png 20180506 16:35:19<+discordbot2> @sinda See the screenshot above. 20180506 16:37:42<+discordbot2> @Rusack Try pressing F5 in the main menu, or going into Preferences ā†’ Cache ā†’ Purge 20180506 16:37:58<+discordbot2> Oh wait, don't press F5, you are on iOS I guess. 20180506 16:38:12<+discordbot2> The second option should still work. 20180506 16:38:33<+discordbot2> https://cdn.discordapp.com/attachments/259976436490829825/442726867792035850/image.jpg 20180506 16:38:40<+discordbot2> Yeah, iOS 11 20180506 16:38:55<+discordbot2> So I kinda can keep playing, see how it goes 20180506 16:39:13<+discordbot2> I guess the mod is broken or something 20180506 16:40:38< irker306> wesnoth: Wedge009 wesnoth:master f1bcdc7f1b6e / / (4 files in 4 dirs): Update text to match changes in dialogues (fixes #2882). https://github.com/wesnoth/wesnoth/commit/f1bcdc7f1b6e9c762edd075642954f4850d151f3 20180506 16:40:40< irker306> wesnoth: Wedge009 wesnoth:master d85e2a2886e1 / data/ (3 files in 2 dirs): Update text to match game-play changes (fixes #2950). https://github.com/wesnoth/wesnoth/commit/d85e2a2886e1652749376e37c94e404d4b5ace98 20180506 16:41:55<+discordbot2> A broken add-on can cause a cache issue where Wesnoth starts doing that "WESNOTH_VERSION is not defined" silliness, yes. 20180506 16:43:46<+discordbot2> Should I delete this addon? 20180506 16:43:47<+discordbot2> Yet another person hitting the 32-bit VA space limit on Windows. 20180506 16:44:17<+discordbot2> @Rusack I mean, if you can identify the add-on and it consistently happens it'd be better to report the issue to the author. 20180506 16:44:31<+discordbot2> (That screenshot doesn't show any add-ons.) 20180506 16:44:37<+discordbot2> Campaign drop mode 20180506 16:44:40<+discordbot2> No? 20180506 16:45:27<+discordbot2> Where it shows some file path, o; the 1st screenshot 20180506 16:45:53<+discordbot2> Oh right. 20180506 16:46:02<+discordbot2> There are two add-ons in that screenshot but that doesn't necessarily mean both are broken. 20180506 16:46:21<+discordbot2> Lemme check the 1st one 20180506 16:47:03<+discordbot2> Galudur is another campaign 20180506 16:47:10< irker306> wesnoth: sigurdfdragon wesnoth:master e9ab1ce8d171 / data/core/units.cfg: Help: Add falcons race description https://github.com/wesnoth/wesnoth/commit/e9ab1ce8d1718fbaf999b1a82ce09526da70bf31 20180506 16:47:12< irker306> wesnoth: sigurdfdragon wesnoth:master a67e068178c8 / data/core/units.cfg: Help: Add wolves race description https://github.com/wesnoth/wesnoth/commit/a67e068178c8acd3d3c40fd2ef5f63ed04dfb87d 20180506 16:47:20<+discordbot2> Can it cause problems when you play another campaign?? 20180506 16:47:53<+discordbot2> It doesn't even mean it's any of the two which is broken - If you want to find out which, purge the cache as shadowm explained, restart the game and look at the error message which is shown then 20180506 16:48:24< irker306> wesnoth: sigurdfdragon wesnoth:1.14 dd23d827e708 / data/core/units.cfg: Help: Add falcons race description https://github.com/wesnoth/wesnoth/commit/dd23d827e708620f7050f5810088d12b5e237a14 20180506 16:48:26< irker306> wesnoth: sigurdfdragon wesnoth:1.14 d35d2621999b / data/core/units.cfg: Help: Add wolves race description https://github.com/wesnoth/wesnoth/commit/d35d2621999be43c4aaae912e739a1f503dfffeb 20180506 16:50:16<+discordbot2> Donā€™t have this cache button 20180506 16:51:36<+discordbot2> https://i.imgur.com/UFyq3HL.jpg 20180506 16:52:27<+discordbot2> Well that's interesting @sinda 20180506 16:54:37<+discordbot2> (He's the iOS port dev so hopefully he should be able to help.) 20180506 16:55:10-!- dmont [636938ca@gateway/web/freenode/ip.99.105.56.202] has quit [Ping timeout: 260 seconds] 20180506 16:56:16<+discordbot2> Yeah, 99% this drop mode broke, cuz I managed somehow to start the next scenario and got these errors: https://i.imgur.com/u5qBSCz.jpg And no items on the map, which means that the system load needed files 20180506 17:05:35-!- Ivanovic_ [~ivanovic@p4FC53492.dip0.t-ipconnect.de] has joined #wesnoth-dev 20180506 17:08:09-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Ping timeout: 260 seconds] 20180506 17:09:18-!- Ivanovic_ [~ivanovic@p4FC53492.dip0.t-ipconnect.de] has quit [Changing host] 20180506 17:09:18-!- Ivanovic_ [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev 20180506 17:09:43-!- Ivanovic_ is now known as Ivanovic 20180506 17:19:18<+discordbot2> Okay sooo 20180506 17:20:35<+discordbot2> Looking into all these reports of bad_cast exceptions, I wonder if the issue might be in the translation::(i?)compare() functions. 20180506 17:22:33<+discordbot2> In which case the solution could be either this or a check using has_facet(): https://gist.github.com/shikadiqueen/47da1711535f6588aa74cad028dfa285 20180506 17:23:12-!- louis94 [~~louis94@91.176.171.238] has quit [Ping timeout: 260 seconds] 20180506 17:23:52<+discordbot2> Apparently the listbox widget in particular uses translation::icompare(), presumably for column sorting. 20180506 17:23:52< celticminstrel> Hmm. 20180506 17:24:19< celticminstrel> ...what's that FIXME 20180506 17:24:22<+discordbot2> And all the affected paths have a listbox in common. 20180506 17:24:33<+discordbot2> It's what it says. 20180506 17:24:56< celticminstrel> So there should be a basic case-insensitive comparator to fall back on? 20180506 17:24:59<+discordbot2> Just like the __APPLE__ version it just does a case-sensitive comparison. 20180506 17:25:18<+discordbot2> But this isn't a new issue. 20180506 17:25:26< celticminstrel> Right. 20180506 17:25:34< celticminstrel> That's why the __APPLE__ version is even there. 20180506 17:25:46<+discordbot2> Whoever added that didn't provide a case-insensitive fallback for icompare. 20180506 17:25:52< celticminstrel> Because load game was crashing right? 20180506 17:26:00<+discordbot2> No, it was the file dialog. 20180506 17:26:06< celticminstrel> Right, sorry. 20180506 17:26:23< celticminstrel> Does that actually use case-insensitive when possible? 20180506 17:26:30<+discordbot2> Yes. 20180506 17:26:47<+discordbot2> And so do other places now. 20180506 17:27:00<+discordbot2> You can grep around for ::icompare to see other cases. 20180506 17:27:07< celticminstrel> Okay, so anyway, I guess what you want is that if the Boost case-insensitive facet doesn't work, then it should fall back to an English-only case-insensitive comparator? 20180506 17:27:16<+discordbot2> And ::compare for the other potential broken path under heretofore unidentified conditions. 20180506 17:27:42<+discordbot2> Okay, maybe you are not aware but a lot of Windows users are finding that the game crashes with std::bad_cast as soon as they open Preferences or Multiplayer or others. 20180506 17:28:01< celticminstrel> I was still talking about the FIXME in particular. 20180506 17:28:13< celticminstrel> The general approach in the gist seems fine to me. 20180506 17:28:14<+discordbot2> And std::use_facet can throw std::bad_cast. 20180506 17:28:41< celticminstrel> No idea whether has_facet() would work, might be a little neater than the try-catch if it does. 20180506 17:28:43<+discordbot2> Maybe I should check with std::has_facet instead since exception overhead is a little higher on Windows than on other platforms. 20180506 17:28:58< celticminstrel> Is it? 20180506 17:29:08<+discordbot2> The big question is why this is happening (or whether it is happening in the first place, this is just a theory). 20180506 17:29:23<+discordbot2> And why it only affects some people. 20180506 17:29:27< celticminstrel> Yeah, that's a good question. 20180506 17:29:35<+discordbot2> On the other hand, it's expected to succeed, and calling potentially-throwing code that doesn't throw is faster than a branch. 20180506 17:29:43< celticminstrel> Do we know the OS versions and languages of those people? 20180506 17:29:54<+discordbot2> Not really. 20180506 17:30:26<+discordbot2> I think they are all Windows 10 at least, but they don't specify their system or game language (the latter is probabyl the default for their system). 20180506 17:30:28< celticminstrel> Like, if it only happens for English users, it seems like this theory is a likely one. 20180506 17:30:56< celticminstrel> Because IIRC they'll probably be using the default C locale? 20180506 17:31:01<+discordbot2> It never occurred to me that adding the system language to the report text would be a good idea. 20180506 17:31:02< celticminstrel> I dunno. 20180506 17:31:04<+discordbot2> No, we don't use the C locale. 20180506 17:31:09< celticminstrel> Ah okay. 20180506 17:31:16<+discordbot2> That's a can of worms for a number of reasons. 20180506 17:31:27<+discordbot2> Its encoding is not UTF-8, for starters. 20180506 17:31:30< celticminstrel> I dunno how relevant the system language is to a report TBH, unless it's a report on translations... 20180506 17:31:44< celticminstrel> But I mean, I guess it can't hurt. 20180506 17:32:24<+discordbot2> Anyway I'd like to provide a potential fix since it's pretty frustrating to answer to reports with "sorry we don't know why this is happening, we can't do anything about it". 20180506 17:32:57<+discordbot2> It'd be even better if we had a way to deliver a special build for them to tes.t.. 20180506 17:40:27-!- vn971 [~vasya@94.158.103.15] has quit [Ping timeout: 240 seconds] 20180506 17:43:41-!- vn971 [~vasya@94.158.103.15] has joined #wesnoth-dev 20180506 17:45:28<+discordbot2> All the reports I recall seeing are Windows. Mostly win10, maybe one or two on win7. 20180506 17:50:37<+discordbot2> sanitize_path is such an overly broad name for what the function actually does. 20180506 17:51:13<+discordbot2> Also FYI using %USERNAME% on Windows doesn't guarantee you'll get what you want. 20180506 17:51:21<+discordbot2> My user folder name on Windows is not the same as my username. 20180506 17:52:02<+discordbot2> AFAIK, it's not intended to give a hard guarantee that the player's user name isn't shown. 20180506 17:52:58<+discordbot2> @Rusack , thanks, it's a known problem. Can be worked around by removing and/or installing any add on, even unrelated one. The "clean cache" button was removed intentionally, I will get it back in the next version. 20180506 17:53:18<+discordbot2> What was the reason for removing it? 20180506 17:54:23-!- Ivanovic_ [~ivanovic@p579FB6AC.dip0.t-ipconnect.de] has joined #wesnoth-dev 20180506 17:54:49-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Ping timeout: 260 seconds] 20180506 17:56:16-!- Ivanovic_ [~ivanovic@p579FB6AC.dip0.t-ipconnect.de] has quit [Changing host] 20180506 17:56:16-!- Ivanovic_ [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev 20180506 17:56:29-!- Ivanovic_ is now known as Ivanovic 20180506 17:56:59<+discordbot2> @sinda#1330 just tried launch - install random addon - load the game... still crashed xD I guess Iā€™ll have to just uninstall this mod for now, looking forward to getting the new update on IOS 20180506 18:04:33-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Ping timeout: 264 seconds] 20180506 18:07:44<+discordbot2> @shadowm There are two people you could ask about their language in this thread: https://forums.wesnoth.org/viewtopic.php?f=4&t=48132 20180506 18:07:53< Ravana_> Vultraz: Seems that polling game changes less often is not enough currently, there is delay between creating game, and seeing it with updated client 20180506 18:07:56<+discordbot2> both win10 20180506 18:08:35< Ravana_> might need to get changes more often, but buffer them and display updates only every so often 20180506 18:08:38<+discordbot2> @Rusack Thanks for letting me know, will look into it. 20180506 18:11:08<+discordbot2> @Pentarctagon It's too obvious the first one is English. 20180506 18:11:39<+discordbot2> I honestly don't know for sure what to ask for since this stuff is beyond my purview both on Windows and Linux. 20180506 18:15:26< celticminstrel> What's %USERNAME% being used for? 20180506 18:15:43<+discordbot2> For the sanitize thing. 20180506 18:15:48< celticminstrel> ...why? 20180506 18:15:57<+discordbot2> You wrote it, celticminstrel. 20180506 18:16:00<+discordbot2> I was under the impression-- yeah. 20180506 18:16:02< celticminstrel> ... 20180506 18:16:08< celticminstrel> I don't remember. >_> 20180506 18:16:25<+discordbot2> https://github.com/wesnoth/wesnoth/blob/1.14/src/filesystem_boost.cpp#L1375 20180506 18:16:41< celticminstrel> Ahh, right. 20180506 18:16:42<+discordbot2> It replaces all instances of the player's user name with "USER". 20180506 18:17:09< celticminstrel> It's probably fine then? 20180506 18:17:17< celticminstrel> The goal is not including the username in reports. 20180506 18:17:31<+discordbot2> Yeah but it doesn't always work. 20180506 18:17:39< celticminstrel> Why wouldn't it work? 20180506 18:18:00<+discordbot2> Because nothing says %USERNAME% must be the user's profile folder name. 20180506 18:18:19<+discordbot2> It is possible to rename a user after the fact and Windows will not rename the profile folder since that leads to all sorts of breakage. 20180506 18:18:22< celticminstrel> So you think the profile folder name needs to be excluded? 20180506 18:18:31<+discordbot2> also https://forums.wesnoth.org/viewtopic.php?f=4&t=48127 20180506 18:18:36< celticminstrel> Yeah, I'm aware, since that actually affects me too. :/ 20180506 18:19:15< celticminstrel> Probably should do a clean install TBH before Microsoft stops offering updates... 20180506 18:19:38< irker306> wesnoth/wesnoth:fix_3034 Lipka BoldizsĆ”r fa2aced391 Fix excessive mp lobby refreshing. AppVeyor: All builds passed 20180506 18:19:51< celticminstrel> Anyway the goal is excluding the username from the report, so it does do what it intends to do. If we want to also exclude the user profile dir name, that would require some additional effort. 20180506 18:20:12< celticminstrel> I suppose it could be a good thing to add. 20180506 18:20:18<+discordbot2> "/hoUSERe/USER/.local/share/wesnoth/1.14/data/add-ons/After_the_StorUSER/_USERain.cfg" 20180506 18:20:29<+discordbot2> That'd be a sight. 20180506 18:20:31< celticminstrel> Since your user profile dir name would be a former username... 20180506 18:20:32< celticminstrel> Heh. 20180506 18:21:09< celticminstrel> Though I don't think that particular path would ever be sanitized. 20180506 18:21:23< celticminstrel> Pretty sure it's only used for the paths printed on startup or in the --report 20180506 18:21:45-!- Ivanovic [~ivanovic@p579FB6E5.dip0.t-ipconnect.de] has joined #wesnoth-dev 20180506 18:22:03< celticminstrel> If there's a way to reliably get the user profile dir name on Windows, we could bound the search term by / 20180506 18:22:25< celticminstrel> So, replace "/" + getenv("USER") + "/" with "/USER/". 20180506 18:23:01-!- Ivanovic [~ivanovic@p579FB6E5.dip0.t-ipconnect.de] has quit [Changing host] 20180506 18:23:01-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev 20180506 18:23:02<+discordbot2> %USERPROFILE% 20180506 18:23:23< loonycyborg> we need to make it obvious that the string was search&destroy'd 20180506 18:23:27<+discordbot2> Or using function thingy we already use to get the Documents path. IIRC there's a value to get the profile folder. 20180506 18:23:30< celticminstrel> I do think leaving it a little more general is better, mind you, since in theory the username could appear elsewhere in the path... but I guess that's pretty unlikely, too. 20180506 18:24:11<+discordbot2> Incidentally, the environment variables on Linux can be absent too. 20180506 18:24:17< celticminstrel> loonycyborg: I think the uppercase USER is a fairly clear hint, and it's what Apple does for its crash reports (or did, at least, I can't be sure whether they still do). 20180506 18:24:32< celticminstrel> ... 20180506 18:24:37<+discordbot2> And the home dir name needs not match the username either. 20180506 18:24:39< loonycyborg> well not clear enough for me 20180506 18:24:51< loonycyborg> it must contain characters that can't exist in paths 20180506 18:24:59<+discordbot2> Nah. 20180506 18:25:00< loonycyborg> so people would realize their error if they copy paste it 20180506 18:25:10< loonycyborg> like 20180506 18:25:11< celticminstrel> Well, I mean, there is another way to get the username using the POSIX API, so if you really want I can do that instead. 20180506 18:25:14<+discordbot2> Only / and NUL are guaranteed not to exist in directory names. 20180506 18:25:19< loonycyborg> that would make it 100% obvious 20180506 18:25:30<+discordbot2> Those two are only invalid on Windows. 20180506 18:25:37< loonycyborg> <> would be problematic in paths 20180506 18:25:41<+discordbot2> I think loonycyborg is overthinking this. 20180506 18:25:42< celticminstrel> Though I won't be able to test it; however I'd probably be copy-pasting and maybe tweaking already-tested code anyway. 20180506 18:25:44< loonycyborg> so people would see it's not real path 20180506 18:25:55< celticminstrel> (Since it's something I've actually done before.) 20180506 18:25:56<+discordbot2> (And I thought I was overthinking it.) 20180506 18:26:30< celticminstrel> loonycyborg: I really don't think it matters that it's not a real path. 20180506 18:26:55<+discordbot2> But yeah, good luck, because on Linux the only characters that aren't allowed in filenames are / and \0. 20180506 18:27:01< celticminstrel> If someone on the same system copy-pastes it into a terminal or something, without looking, I'd think they would quickly notice the error. 20180506 18:27:08<+discordbot2> (I guess jykrive meant the latter by NUL and not the Windows NUL device.) 20180506 18:27:20< loonycyborg> well it actually tripped me up 20180506 18:27:21<+discordbot2> Yes, it's what I meant. 20180506 18:27:27< loonycyborg> when I was setting up flatpak stuff 20180506 18:27:37< loonycyborg> I wasn't sure whether it's flatpak's doing 20180506 18:27:40< celticminstrel> Oh? 20180506 18:27:47< loonycyborg> it could be actually virtualize paths 20180506 18:27:50< celticminstrel> Tripped you up how? 20180506 18:27:51< loonycyborg> so I had to ask about it 20180506 18:28:30< loonycyborg> if it was I wouldn't have this opportunity to bother people with dumb questions 20180506 18:29:49< celticminstrel> Not sure why you consider them dumb questions but whatever. 20180506 18:30:29< celticminstrel> I kidna wonder whether using could actually be dangerous. 20180506 18:30:35< celticminstrel> ^kinda 20180506 18:31:40<+discordbot2> Depends on who reads the output and what it does with it. 20180506 18:31:57< celticminstrel> I mean if it's pasted unquoted into a terminal. 20180506 18:32:12< celticminstrel> Which doesn't completely answer that question, of course. 20180506 18:54:03-!- vn971 [~vasya@94.158.103.15] has quit [Quit: Leaving.] 20180506 19:01:12< Ivanovic> https://steamcommunity.com/id/jeyjeyking/recommended/599390/ 20180506 19:06:25< celticminstrel> This is known, shadowm has a possible fix but I think she can't reproduce it so it's not certain whether it works. 20180506 19:07:26-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection] 20180506 19:09:07<+discordbot2> loonycyborg: Would you be willing to make a special build of 1.14.0 with nothing other than that patch applied on top once I commit it? 20180506 19:09:25< Ivanovic> celticminstrel: i am able to see this crash on linux if boost is built without ICU support 20180506 19:09:31< loonycyborg> how do I distribute it? 20180506 19:09:41< loonycyborg> installer or steam beta channel? 20180506 19:09:57< celticminstrel> Ivanovic: From what I've heard most (all?) of the people seeing it are running Windows. 20180506 19:09:58<+discordbot2> loonycyborg: Neither, just the wesnoth.exe and we tell affected users to try it. 20180506 19:10:27< loonycyborg> I can 20180506 19:12:03-!- lipkab [~lipk@host-91-147-210-58.biatv.hu] has joined #wesnoth-dev 20180506 19:13:44< irker306> wesnoth: Iris Morelle wesnoth:1.14 18e5ea50a713 / src/gettext_boost.cpp: i18n: Blind fix attempt for std::bad_cast being thrown on Windows https://github.com/wesnoth/wesnoth/commit/18e5ea50a7136cb3686c5a7c51c111ccce73dc54 20180506 19:13:50<+discordbot2> loonycyborg: ^ This patch. Only this patch. 20180506 19:14:30<+discordbot2> Applied on top of 1.14.0. 20180506 19:14:40<+discordbot2> You can upload the wesnoth.exe to files.w.o and I'll tell people to replace their own wesnoth.exe with it. 20180506 19:19:24<+discordbot2> As for why it must be that patch only, it's because there's a recent UI change that will cause Wesnoth to crash without a matching data dir. 20180506 19:20:54< celticminstrel> ...wait what> 20180506 19:20:55< celticminstrel> ^? 20180506 19:21:08<+discordbot2> Vultraz added a button to the MP menu. 20180506 19:21:22< celticminstrel> Oh, that's what you mean. 20180506 19:21:39< celticminstrel> So basically the C++ code references a widget without checking that it exists. 20180506 19:21:39<+discordbot2> Yeah, the classic GUI2 C++/WML cohesion issue. 20180506 19:22:09< celticminstrel> GUI2 is technically built to account for missing widgets but most dialogs don't bother. 20180506 19:22:35<+discordbot2> There's usually no need to bother since people are expected to run with a data dir matching the engine version, that's why. 20180506 19:22:55< celticminstrel> Well, it's also necessary sometimes when different resolutions get their own layout. 20180506 19:23:07< celticminstrel> And technically GUI2 was built to be themable so... 20180506 19:23:37< celticminstrel> The C++ should probably try to do a little better with missing non-essential widgets. 20180506 19:23:49<+discordbot2> That's another point where reality doesn't match the design. GUI2 doesn't have a mechanism for loading different "themes" yet. 20180506 19:24:23<+discordbot2> That fell to the wayside since mordante's priority was building the whole thing for mainline first. 20180506 19:24:27< celticminstrel> Yes it does. 20180506 19:24:35< celticminstrel> Not on-the-fly mind you. 20180506 19:24:43< celticminstrel> Changing theme requires a restart. 20180506 19:25:04<+discordbot2> Where and how, without manually replacing the files/folder with the GUI WML? 20180506 19:25:13< celticminstrel> (Unless Vultraz broke it when refactoring, but...) 20180506 19:26:09< celticminstrel> Everything in the current GUI WML is contained within a [gui] tag IIRC; if you add another GUI tag that defines some of the same dialogs, and set the theme to that (there's a preference for it but it might not be exposed in the UI), it'll load the replacement theme. 20180506 19:26:22< celticminstrel> The logic for this was originally in src/gui/settings.cpp 20180506 19:26:35< celticminstrel> I think Vultraz might've moved it around, so hopefully it does still work... 20180506 19:26:39<+discordbot2> Somehow I never found this in my research, huh. 20180506 19:26:56< celticminstrel> /core/settings.cpp I think, rather 20180506 19:27:42< celticminstrel> I can't remember, it might've been not quite finished? I did change some stuff in that file related to theme loading. 20180506 19:27:53< celticminstrel> And IIRC I verified it worked with a very simple test. 20180506 19:32:21< celticminstrel> A theme doesn't need to replace every dialog/widget but unlike in the ThemeWML it can't partially remake a dialog/widget. 20180506 19:36:29<+discordbot2> Well, removing OneDrive seems to be helping people with the game paths issue... 20180506 19:44:27-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180506 19:44:34-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180506 19:45:21<+discordbot2> Celmin you finished it 20180506 19:45:33< celticminstrel> Maybe, I can't remember anymore. 20180506 20:01:56<+discordbot2> How come it canā€™t just be an update on Steam? 20180506 20:02:32<+discordbot2> I want to isolate the patch and bug. 20180506 20:02:44<+discordbot2> And 1.14.1 is coming soon anyway. 20180506 20:09:08< zookeeper> @Vultraz, @Yumi, celticminstrel, what _is_ there to revise in unit descriptions in general? the review pretty much only lambasted elf favoritism and orc prejudice. 20180506 20:09:40< celticminstrel> Well I'd have to read through every single one to answer that... 20180506 20:09:52< celticminstrel> But orc prejudice IMO is a problem, at least. 20180506 20:10:42< zookeeper> yeah, i still completely disagree with that notion :p 20180506 20:10:52<+discordbot2> what review? 20180506 20:10:55< celticminstrel> Well, that's your problem then. 20180506 20:11:07< celticminstrel> And don't :P on this. 20180506 20:11:23<+discordbot2> the elf unit descriptions are pretty outdated 20180506 20:11:49<+discordbot2> as in, they are short and don't really say much besides very very generic fantasy things 20180506 20:11:54<+discordbot2> e.g. characterization of elves and such 20180506 20:15:36< zookeeper> @Pentarctagon, this one: https://steamcommunity.com/id/trar/recommended/599390/ 20180506 20:15:52<+discordbot2> Same goes with some of the elvish portraits, when we are at it. 20180506 20:16:03<+discordbot2> Same goes with some of the elvish portraits, when we are at it. 20180506 20:16:15<+discordbot2> Same goes with some of the elvish portraits, when we are at it. 20180506 20:16:27< celticminstrel> I think you mean "while" 20180506 20:20:58<+discordbot2> I can give you a more in depth mini-essay on fantasy writing 20180506 20:20:59<+discordbot2> later 20180506 20:21:06<+discordbot2> have an event to go to soon 20180506 20:22:09<+discordbot2> the review makes a couple good points, but the level of hyperbole is off the charts. 20180506 20:22:46<+discordbot2> I agree, but the review does get at something that really could be improved 20180506 20:22:49<+discordbot2> even if for the wrong reasons 20180506 20:23:51< zookeeper> @Yumi, for what it's worth, i think most of the interesting/epic/detailed lore tidbits in unit descriptions should preferably be concentrated in higher-level units, rather than the lvl1 units. unless everyone can have a super-deep description, naturally. 20180506 20:25:01<+discordbot2> Once again, bad reviewers are our friends. It would be much worse if people just walked away, without any feedback. Once we acknowledge their unhappiness, and maybe even address valid points, they can become your most loyal followers. I'm speaking from another free app's experience. 20180506 20:25:24< celticminstrel> ^ 20180506 20:25:34<+discordbot2> I think that the review gets at a problem endemic especially to fantasy writing 20180506 20:25:42< celticminstrel> This is of course assuming they actually have a point, mind you. 20180506 20:25:50< celticminstrel> But that one did have a point IMO. 20180506 20:26:14< celticminstrel> The prejudice against orcs (and also elves) in the unit descriptions would be better eliminated IMO. 20180506 20:26:23<+discordbot2> in a nutshell, fantasy-type stuff often just ends up being a LotR clone 20180506 20:26:27< celticminstrel> (^also in favour of elves) 20180506 20:26:37<+discordbot2> ignoring why LotR worked in the first place 20180506 20:27:05< celticminstrel> Heh... 20180506 20:27:38< Ivanovic> you know, considering that the most negative points in most reviews are around the rng: I am not sure if this will ever be changed 20180506 20:27:39< Ivanovic> ;) 20180506 20:34:05< zookeeper> the thing is that elf/orc prejudice is at the core of most campaigns, it's not just a few strings that can be updated. in the majority of content, orcs _are_ irredeemable savages and elves _are_ kind of awesome and best at everything. 20180506 20:34:57< celticminstrel> zookeeper: It's acceptable in the campaigns IMO, but should be eliminated from the unit descriptions. 20180506 20:34:59< zookeeper> of course elves are _also_ jerks in a lot of content, but still. 20180506 20:35:06<+discordbot2> could probably remove the bit about the failure of the orc bloodline though 20180506 20:35:07< celticminstrel> The unit descriptions should be as neutral as possible. 20180506 20:35:40< celticminstrel> Mind you, making the orcs less "black" and more "grey" in the campaigns would still be a good idea. 20180506 20:36:01< celticminstrel> But eliminating the prejudice on the part of the player-controlled races isn't really needed. 20180506 20:36:05<+discordbot2> that's why I think SotBE is an important campaign to have 20180506 20:36:10< celticminstrel> Yeah, indeed. 20180506 20:36:54< celticminstrel> We should try to think about why the orcs decided to invade the forest (AOI) and why they decided to work with Asheviere. 20180506 20:37:11< zookeeper> as a funny detail, the orcs (or at least Kapou'e himself) in SotBE were changed to be much more savage a long time ago, because originally there was hardly nothing orcish about their demeanor :p 20180506 20:37:55<+discordbot2> anyway I'm off to my event, can talk more later 20180506 20:40:21<+discordbot2> Given a chance to respond to reviews, I would still acknowledge the user's right to have their opinion, and give them our reasons why things are not the way they like. Like, explain that RNG is a part of design, requires a different skill, and the everyone in current community has learned to play with it. That randomness is an important part of other games, like MtG or, I know, Heartstone? The fact that their opinion itself was 20180506 20:40:21<+discordbot2> taken seriously may make them reconsider or soften their opinions. 20180506 20:40:30-!- lipkab [~lipk@host-91-147-210-58.biatv.hu] has quit [Ping timeout: 256 seconds] 20180506 20:42:23< zookeeper> @Pentarctagon, why? it's heavily implied that goblins are just a normal natural result of how orcish litters function, but a speculation about it not necessarily always having been the case doesn't strike me as a bad thing. depth requires some uncertaintly and room for speculation, after all, and that one seems as good as any. 20180506 20:42:51< celticminstrel> I don't think speculation belongs in unit descriptions. 20180506 20:42:51< zookeeper> also i make a lot of typos these days, it seems. 20180506 20:43:17< celticminstrel> And that particular speculation is pretty down-putting IMO and should be removed. 20180506 20:43:43< celticminstrel> I mean if you want to put it in campaign text (if it actually fits somewhere, which I doubt), then maybe. 20180506 20:44:24<+discordbot2> What celticminstrel said, basically 20180506 20:54:12<+discordbot2> Ah RNG, the never-ending story. I think the best argument for RNG in games is to look at board games, where all the most popular games have some element of randomness. In board games, determinism is considered boring, people only want something different because they want something to blame for them being poor at the game. 20180506 20:55:57<+discordbot2> I have always thought that about the human master bowman, actually. Would be up for helping rewrite some of these. Forum thread? 20180506 20:56:46<+discordbot2> It is what the Writer's Forum is for. 20180506 20:58:54<+discordbot2> @Pentarctagon Is it possible to use scons with Microsofts compiler? 20180506 20:59:38< celticminstrel> That's actually a very good question. 20180506 21:00:13< celticminstrel> I know scons itself supports it, but if the Sconscript isn't set up for it, then it won't work (basically you need to pass different command-line arguments). 20180506 21:05:41< irker306> wesnoth: Nils Kneuper wesnoth:1.14 d4a94b62773a / po/wesnoth-lib/cs.po: updated Czech translation https://github.com/wesnoth/wesnoth/commit/d4a94b62773a63bc28fb4d2cffe1a3d9acaa74e6 20180506 21:05:43< irker306> wesnoth: Nils Kneuper wesnoth:1.14 a888d0e96a83 / po/wesnoth-lib/sk.po: updated Slovak translation https://github.com/wesnoth/wesnoth/commit/a888d0e96a831617a8d540b9e3894358c2e0a7ac 20180506 21:05:48< irker306> wesnoth: Nils Kneuper wesnoth:master 58bfca286a27 / po/wesnoth-lib/cs.po: updated Czech translation https://github.com/wesnoth/wesnoth/commit/58bfca286a270acd5ddabdfd92b01cbe14353ca8 20180506 21:05:50< irker306> wesnoth: Nils Kneuper wesnoth:master 69bc5b614f4a / po/wesnoth-lib/sk.po: updated Slovak translation https://github.com/wesnoth/wesnoth/commit/69bc5b614f4af7e71eea630651dee17023fcb482 20180506 21:08:41< irker306> wesnoth: Iris Morelle website:master 9de49a2a7164 / start/1.14/po/sk.po: announcement/1.14: Update Slovak translation https://github.com/wesnoth/website/commit/9de49a2a7164e8248cb0233d53cc1f537400f57d 20180506 21:08:44<+discordbot2> Ivanovic: ^ 20180506 21:08:51< Ivanovic> thanks 20180506 21:09:10<+discordbot2> And update your contacts. 20180506 21:09:24< Ivanovic> am I using an outdated email address? 20180506 21:09:32<+discordbot2> celmin around? 20180506 21:12:09< Ivanovic> ahhh, okay, now I see what you mean... 20180506 21:12:15< Ivanovic> fixed 20180506 21:12:56< celticminstrel> Silly Vultraz, am I ever around? ;) 20180506 21:13:40<+discordbot2> If i were to delegate the lobby data processing to a separate thread, how best would it be done? Ie, should only the network polling happen in the worker thread? Should it also handle recreating the games and user list vectors as appropriate? 20180506 21:13:56< Ivanovic> off to bed, n8 20180506 21:14:51<+discordbot2> @Vultraz The previous approach was to only do the former in a separate thread IIRC. 20180506 21:15:00<+discordbot2> Thing is, the network ops are already threaded... 20180506 21:15:10<+discordbot2> It's the polling that happens on a timer 20180506 21:15:13<+discordbot2> 3āƒ£ 20180506 21:15:16<+discordbot2> what 20180506 21:15:17<+discordbot2> Have you benchmarked this anyway? 20180506 21:15:38<+discordbot2> I suspect the bottleneck is at the UI layout code (unless you're doing something horribly wrong in the data processing...) 20180506 21:16:18<+discordbot2> that is also a possibility 20180506 21:16:41<+discordbot2> Just benchmark the thing, honestly. 20180506 21:17:00<+discordbot2> Let it sit idle at the lobby for 5 minutes and you should end up with pretty solid data. 20180506 21:17:05<+discordbot2> I'm thinking more of this bug: https://github.com/wesnoth/wesnoth/issues/3046 20180506 21:17:25<+discordbot2> I increased network polling from 100ms to 1000ms 20180506 21:17:36<+discordbot2> but how in hell does that result in a THREE MINUTE delay 20180506 21:18:01< Ravana_> until yesterday I had my bot also only poll once per second, and I saw similar falling behind 20180506 21:18:13<+discordbot2> That's not how you respond to a ticket btw. 20180506 21:18:28<+discordbot2> I mean the "THREE MINUTES???" comment. 20180506 21:18:46<+discordbot2> @Ravana oh? this is valuable data... 20180506 21:18:51<+discordbot2> šŸ¤” 20180506 21:19:17<+discordbot2> perhaps I misunderstood the loop... 20180506 21:20:51< Ravana_> with bot it is slightly different - in main loop I poll both irc and wesnoth socket for data, both with timeout of 1sec. Irc sends data quite rarely. So I made it poll wesnoth socket up to 16 times before polling irc socket(and most likely waiting there 1 s) 20180506 21:21:15<+discordbot2> I mean, I assume all the data sent by the server gets queued up until you call receive_data 20180506 21:21:27<+discordbot2> looks like it 20180506 21:44:13<+discordbot2> @sevu I have no idea. you can specify the compilers with ctool and cxxtool, but I don't know that anyone has actually tried. 20180506 21:46:59-!- loonycyborg [~loonycybo@wesnoth/developer/loonycyborg] has quit [Ping timeout: 260 seconds] 20180506 21:53:19-!- loonycyborg [~loonycybo@wesnoth/developer/loonycyborg] has joined #wesnoth-dev 20180506 21:53:25-!- Netsplit *.net <-> *.split quits: APic, janebot 20180506 21:54:08-!- Netsplit over, joins: janebot 20180506 21:58:35-!- janebot_ [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180506 22:00:29-!- APic [apic@apic.name] has joined #wesnoth-dev 20180506 22:00:55-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Ping timeout: 240 seconds] 20180506 22:01:37-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 248 seconds] 20180506 22:06:00< irker306> wesnoth/wesnoth:1.14 doofus-01 6e2501a892 quenoth flanker defense anim AppVeyor: All builds passed 20180506 22:06:49-!- janebot_ is now known as janebot 20180506 22:30:01-!- gallaecio [~quassel@188.79.96.255] has quit [Remote host closed the connection] 20180506 22:54:48-!- louis94 [~~louis94@91.176.171.238] has joined #wesnoth-dev 20180506 23:20:16<+discordbot2> bit less than 24 hours to tag 20180506 23:20:51<+discordbot2> ... No. 20180506 23:20:56<+discordbot2> It's 23:20 UTC. 20180506 23:21:23<+discordbot2> er 20180506 23:21:24<+discordbot2> ... 20180506 23:21:25<+discordbot2> more 20180506 23:21:26<+discordbot2> sorry 20180506 23:22:00<+discordbot2> also what the heck is a trampoline 20180506 23:22:01<+discordbot2> O_O 20180506 23:22:03<+discordbot2> "Warn about use of trampolines for nested functions." 20180506 23:23:35< DeFender1031> The only time I'm familiar with it being used is using SJLJ cooperative multithreading 20180506 23:24:58< DeFender1031> Being used in programming, I mean 20180506 23:25:08<+discordbot2> "A trampoline is a small piece of code that is created at run time when the address of a nested function is taken. It normally resides on the stack, in the stack frame of the containing function. These macros tell GCC how to generate code to allocate and initialize a trampoline." 20180506 23:26:30<+discordbot2> It's apparently something that GCC uses to implement nested functions, and if they're used, GCC will silently make the stack exectuable. Wesnoth doesn't currently have anything that does this, so I figured it would be good to add the warning so it doesn't get used in the future. 20180506 23:26:50<+discordbot2> is it bad if it happens? 20180506 23:28:11<+discordbot2> it's considered to be a bad thing to do, in terms of security 20180506 23:31:02<+discordbot2> ie: https://en.wikipedia.org/wiki/Executable_space_protection 20180506 23:31:36< mattsc> celticminstrel: Do you have any insight into whether it would be difficult to add a new AI aspect ([exclude_units] or something) that would exclude all units matching the filter from all default AI CAs? 20180506 23:31:40<+discordbot2> It is possible to allow programms to either execute or write data - but to restrict them from writing executable code 20180506 23:31:57< mattsc> Iā€™d imagine this should be doable relatively easily, as passive_leader=yes already does this for the side leader? 20180506 23:32:11< mattsc> This would be really useful for some custom AI implementations. 20180506 23:33:02<+discordbot2> I came across it while reading through things for #3015 20180506 23:43:40< irker306> wesnoth/wesnoth:master Pentarctagon 06ba8a8ae2 Warn about use of trampolines for nested AppVeyor: All builds passed 20180506 23:54:52-!- dmont [636938ca@gateway/web/freenode/ip.99.105.56.202] has joined #wesnoth-dev 20180506 23:58:06<+discordbot2> @shadowm u.w.o lists "Fake Shroud" in the unit details, should it? --- Log closed Mon May 07 00:00:07 2018