--- Log opened Tue May 15 00:00:21 2018 --- Day changed Tue May 15 2018 20180515 00:00:21< mattsc> @sevu was this question about NR S2? Because @Vultraz assigned that issue to me, but it sounds like a WML rather than AI issue. 20180515 00:00:53<+discordbot> I assigned it to you because I saw "micor AI" 20180515 00:00:56<+discordbot> micro 20180515 00:01:08< mattsc> As in, are your questions here and Issue #3110 about the same thing. 20180515 00:01:10< sevu> yes, it was. I will push the change later 20180515 00:01:20< mattsc> Okay, cool. 20180515 00:01:34< mattsc> @Vultraz I know and it makes sense, but turns out it’s not an AI problem. 20180515 00:01:45<+discordbot> ok 20180515 00:02:56<+discordbot> praise decltype 20180515 00:04:36<+discordbot> EliDupree: no, not until we get spritesheets 20180515 00:11:07-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Remote host closed the connection] 20180515 00:11:24-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev 20180515 00:12:15< irker002> wesnoth: mattsc wesnoth:1.14 1017a57f39ef / data/ (3 files in 3 dirs): Replace remaining uses of FOREACH macro https://github.com/wesnoth/wesnoth/commit/1017a57f39efc20d61ddc7404dcf18d682808a12 20180515 00:13:48< irker002> wesnoth: mattsc wesnoth:master 66b9e11a2d99 / data/ (3 files in 3 dirs): Replace remaining uses of FOREACH macro https://github.com/wesnoth/wesnoth/commit/66b9e11a2d99761847ab26a54fdf959e4dfbe1dc 20180515 00:13:52<+discordbot> FOREEEEACCCCCCCHHH 20180515 00:13:58< celticminstrel> Looks good. 20180515 00:14:10< celticminstrel> I don't suppose there are any uses of {REPEAT} left. 20180515 00:14:15<+discordbot> i still don't like that we use [do] 20180515 00:14:16<+discordbot> but 20180515 00:14:20<+discordbot> nothing we can [do] 20180515 00:14:36< celticminstrel> It's for consistency with [while]. 20180515 00:14:56<+discordbot> I would have preferred to change [while] 20180515 00:15:04< celticminstrel> Not possible. 20180515 00:15:11<+discordbot> or just not been consistent 20180515 00:15:13< celticminstrel> The direct contents of [while] are ConditionalWML. 20180515 00:15:16<+discordbot> since it adds another layer of indent 20180515 00:15:27< celticminstrel> You don't have to add another layer of indent. 20180515 00:15:50< mattsc> REPEAT … There are quite a few. 20180515 00:16:04< celticminstrel> Huh. 20180515 00:17:04< mattsc> Most of them in SotA 20180515 00:17:13< celticminstrel> ...heh. 20180515 00:17:27< mattsc> Is REPEAT deprectaed too? I did not produce any warnings for me. 20180515 00:17:33< celticminstrel> I think so? 20180515 00:17:38<+discordbot> i don't think so? 20180515 00:17:43< celticminstrel> I thought it was. 20180515 00:17:49 * celticminstrel checking 20180515 00:17:57<+discordbot> it's not in the deprecated file 20180515 00:18:09< mattsc> No, it’s in macros/utils.cfg 20180515 00:18:31< celticminstrel> Huh. 20180515 00:18:36<+discordbot> wait a second, why is ON_SIGHTING not deprecation level 3 20180515 00:18:41< celticminstrel> Well it'll be deprecated in 1.15 then. 20180515 00:18:47< mattsc> Alright. 20180515 00:18:55<+discordbot> ON_SIGHTING should be 3 20180515 00:19:07< celticminstrel> It's 1 because there's no reason the old method will suddenly stop working. 20180515 00:19:18< celticminstrel> I wouldn't promote it to 3, but maybe 2. 20180515 00:19:19< mattsc> Well, AFAICT, those commits are the end of the deprecated code removals then. 20180515 00:19:21<+discordbot> it's bad code and should be purged 20180515 00:19:27< celticminstrel> It's not bad code. 20180515 00:19:33<+discordbot> it's horrible code 20180515 00:19:35< mattsc> Those FOREACH commits. 20180515 00:19:52< celticminstrel> What's so horrible about it? 20180515 00:19:58<+discordbot> code bloat. 20180515 00:20:01<+discordbot> longer load times 20180515 00:20:11< celticminstrel> So yeah, not really that bad. 20180515 00:20:13<+discordbot> we already have enough problems with people not optimizing their WML 20180515 00:20:32<+discordbot> installing SXCollection already increases my WML parsing time by 10 on 1.14 20180515 00:20:53< celticminstrel> Definitely too late to promote it to 3 in 1.14 though. 20180515 00:21:00<+discordbot> not really? 20180515 00:21:14<+discordbot> no one sees deprecated messages anyway >_> 20180515 00:21:18< celticminstrel> I wouldn't promote it beyond 2 anyway. 20180515 00:21:43< celticminstrel> Probably not too late to promote it to 2 in 1.14, since 2 doesn't give any specification of when it can be removed IIRC. 20180515 00:21:53<+discordbot> I don't follow 20180515 00:21:59< celticminstrel> I'm sure plenty of people will see deprecated messages. 20180515 00:22:10<+discordbot> windows people don't use the console 20180515 00:22:48< mattsc> @Vultras just called me nobody :D 20180515 00:22:49< celticminstrel> There really is no reason to remove ON_SIGHTING though unless you can prove that literally no-one uses it anymore. 20180515 00:22:59< mattsc> @Vultraz ^ (typo) 20180515 00:23:02<+discordbot> I'm sure many people use it 20180515 00:23:02< celticminstrel> Because it'll still work. 20180515 00:23:09<+discordbot> That's the whole damn problem 20180515 00:23:13<+discordbot> We don't WANT them to use it 20180515 00:23:13< celticminstrel> And there's no reason it would ever stop working. 20180515 00:23:18<+discordbot> it bloats their addons 20180515 00:23:25< celticminstrel> I know we don't want them to, that's why it's deprecated. 20180515 00:23:28<+discordbot> imagine you have just... 10 of these 20180515 00:23:45< celticminstrel> We should be encouraging people to check their addons for deprecated code. 20180515 00:23:53<+discordbot> But we're not 20180515 00:23:59<+discordbot> because we hide the deprecation messages 20180515 00:24:10< celticminstrel> We are a little bit, by boosting the deprecation log level if debug mode is enabled. 20180515 00:24:29< celticminstrel> I would imagine most devs use debug mode, which means they'll see all the deprecation notices that aren't level 1. 20180515 00:24:32<+discordbot> but how many UMC devs use debug + console? 20180515 00:24:33< celticminstrel> IIRC 20180515 00:24:36< Ravana_> > installing SXCollection already increases my WML parsing time by 10 on 1.14 20180515 00:24:39< celticminstrel> Um. 20180515 00:24:49< Ravana_> isn't that cached so only happening rarely? 20180515 00:24:51 * mattsc did check his add-on for deprecated code. That’s how he found all those mainline uses of deprecated code. 20180515 00:24:59< celticminstrel> Pretty sure the deprecation messages are mirrored to chat too? Or was that off by default? 20180515 00:25:00<+discordbot> @Ravana seems not 20180515 00:25:27< celticminstrel> There's an option for it in prefs, if it's off by default you can feel free to make it on by default instead. 20180515 00:25:40<+discordbot> I agree that errors should be more prominent 20180515 00:25:43< celticminstrel> So you don't need to be using the console to see deprecation messages. 20180515 00:26:03<+discordbot> we need to do a similar thing for the schema 20180515 00:26:18<+discordbot> we should ad a new "quality report" to Inspect 20180515 00:26:20< celticminstrel> Anyway we should deprecate {REPEAT} on 1.15. Want to take care of that @Vultraz? 20180515 00:26:30< celticminstrel> Quality report? 20180515 00:26:32<+discordbot> yes 20180515 00:26:37< celticminstrel> What exactly would that entail? 20180515 00:26:54<+discordbot> lists all deprecation notices and schema validation errors 20180515 00:27:27< celticminstrel> Turning on schema validation by default is probably not the best idea, I imagine it likely increases load times. 20180515 00:27:40< celticminstrel> Mind you it's already done for GUI2, so maybe it's not that significant. 20180515 00:27:51< celticminstrel> On the other hand, GUI2 WML is quite a bit simpler. 20180515 00:27:52<+discordbot> devs should be hit over the head and told their code is out of date 20180515 00:28:14<+discordbot> not enough people are removing MAGENTA_IS_THE_TEAM_COLOR, for example 20180515 00:28:18< celticminstrel> Dumping deprecation messages into someplace in the inspector doesn't seem like a bad idea, though. 20180515 00:34:28<+discordbot> why is MENU_IMG_TXT not marked 3? 20180515 00:34:33< Ravana_> plan is to remove all macros that include iterating over something? 20180515 00:34:35<+discordbot> it's not marked deprecated AT ALL 20180515 00:34:59< celticminstrel> Probably an oversight if it's not marked at all. 20180515 00:35:15< celticminstrel> Feel free to deprecated it in 1.15. 20180515 00:35:33<+discordbot> uh, no, remove it 20180515 00:35:43< celticminstrel> No, you can't remove things without deprecation. 20180515 00:35:45<+discordbot> deprecation should be added to 1.14 if it was missing 20180515 00:35:49< celticminstrel> That's the whole point of having this deprecation system. 20180515 00:36:00-!- gfgt [~androirc@134.76.63.8] has quit [Ping timeout: 256 seconds] 20180515 00:36:10<+discordbot> most of these macros don't even have ... 20180515 00:36:45< celticminstrel> Don't have what? 20180515 00:36:56<+discordbot> a deprecation notice 20180515 00:37:12< celticminstrel> IMO you mostly have yourself to blame for not going over all the macros before release, so... 20180515 00:37:23<+discordbot> I trusted you! 20180515 00:37:40<+discordbot> maybe ANIMATED_CAMPFIRE and ANIMATED_BRAZIER should stay 🤔 20180515 00:37:43< celticminstrel> I think there are some in the deprecated file that don't have a notice, so those at least could be added. 20180515 00:38:18< celticminstrel> The campfire and brazier are largely superceded by the corresponding terrains, but I imagine they could still occasionally come in handy if you need to place them on a space that already has an overlay. 20180515 00:39:05<+discordbot> yes 20180515 00:39:10< irker002> wesnoth: Charles Dang wesnoth:master 3e9424fa33d4 / data/core/macros/deprecated-utils.cfg: Removed macros deprecated at level 2 and 3 https://github.com/wesnoth/wesnoth/commit/3e9424fa33d4af72efc6fc54d2198f9165600093 20180515 00:39:18< celticminstrel> Oy. 20180515 00:39:27< celticminstrel> You're only supposed to remove them if they're deprecated at level 3. 20180515 00:39:45<+discordbot> oh? 20180515 00:40:02< celticminstrel> I guess it's okay in this case, since the only L2 was leadership... 20180515 00:40:17< celticminstrel> But generally yeah, only L3 invites immediate removal. 20180515 00:40:41<+discordbot> all the other early finish text macros don't have notices 20180515 00:41:03< celticminstrel> Since they're clearly deprecated by virtue of being in that file, you can add the notices on 1.14 and remove them on 1.15. 20180515 00:41:22< celticminstrel> That is, assuming they should be L3 deprecation, if not then add the notices on 1.15 too. 20180515 00:41:51< celticminstrel> I think I didn't add the notices in some cases because I wasn't sure what the replacement was. 20180515 00:43:20<+discordbot> i forgot, why can't REPEAT be implemented with [repeat]? 20180515 00:43:31< celticminstrel> What? 20180515 00:43:42<+discordbot> the macro 20180515 00:44:09< celticminstrel> I thought it could be... but perhaps the index variable prevents it? 20180515 00:44:32< celticminstrel> If someone used the index variable, they would need to replace the macro with [for] rather than [repeat]. 20180515 00:45:11<+discordbot> blah 20180515 00:45:31< Ravana_> that is internal variable that addon should not rely on 20180515 00:46:11< celticminstrel> I can't think of any other reason, but I'd say that if we're deprecating it there's no reason to break code that previously worked. 20180515 00:46:30< celticminstrel> If we're not deprecating {REPEAT} then I suppose reimplementing it with [repeat] might be acceptable. 20180515 00:48:51< Ravana_> I suspect I will define FORI based on REPEAT if I need to modify index while in loop 20180515 00:49:12< Ravana_> main benefit of FOREACH was that index could be changed during iteration 20180515 00:49:26<+discordbot> why would you want that 20180515 00:50:33< Ravana_> for example when processing data, where after changing row I want to check it again 20180515 00:51:07< celticminstrel> Well, that's why {FOREACH} was reimplemented in terms of [for] instead of [foreach]. 20180515 00:51:28<+discordbot> you don't need to modify i to do that? 20180515 00:51:46<+discordbot> you can do... $(i - n) or something 20180515 00:52:49< celticminstrel> I don't think that would have the same effect. 20180515 00:53:03< celticminstrel> Changing the index means you actually end up processing the row a second time. 20180515 00:53:14< celticminstrel> (Or possibly even a third or fourth time.) 20180515 00:53:41< irker002> wesnoth: Charles Dang wesnoth:master 50a3960abd05 / src/ (4 files in 3 dirs): Removed a bunch of things deprecated at level 3 https://github.com/wesnoth/wesnoth/commit/50a3960abd055f9422c9c1f21af7d270dae22c96 20180515 00:53:49<+discordbot> that's really not how for-loops are supposed to work 20180515 00:54:01<+discordbot> well 20180515 00:54:13<+discordbot> not range-for 20180515 00:54:15< celticminstrel> "how for-loops are supposed to work" Uhh. 20180515 00:55:15<+discordbot> I guess you're saying FOREACH was not range-for 20180515 00:55:23<+discordbot> but index-for 20180515 00:55:46< celticminstrel> Basically. 20180515 00:55:57< celticminstrel> I mean, they don't directly compare to C/C++ for at all. 20180515 00:56:01< celticminstrel> But whatever. 20180515 00:56:45<+discordbot> index kinda does? 20180515 00:57:01< celticminstrel> Actually the other one compares better. 20180515 00:57:14< celticminstrel> C for is basically a while loop. 20180515 00:57:27<+discordbot> range-for compares to [foreach] 20180515 00:57:36< celticminstrel> Sure the common idiom is for(int i = 0; i < n; i++) 20180515 00:58:00< celticminstrel> But it's a while loop, so you can literally do anything you want. 20180515 00:58:19< celticminstrel> Any condition you want, any starting point, any increment command. 20180515 00:58:24< Ravana_> usually the for (object : array) foreach is enough (index not relevant, just current object), but I want possibility of for(i=0;i That's what [for] does, and it even has a shortcut if you're using it on an array. 20180515 00:59:03< celticminstrel> And [for] is not a C for-loop. It's that one common use of a C for-loop. 20180515 00:59:18< celticminstrel> If you need the full power of a C for-loop, that's [while]. 20180515 00:59:53< Ravana_> [for] has variable for current index, not current object 20180515 01:00:12< celticminstrel> $array[$i] gives current object. 20180515 01:00:28< Ravana_> yes, and is no better than using FOREACH like before 20180515 01:00:41< celticminstrel> Well, you can wrap it in a macro if you want. 20180515 01:00:49< celticminstrel> Or something. 20180515 01:06:11<+discordbot> if you don't want index access, use [foreach] 20180515 01:13:49< Ravana_> I will try them out when I need such functionality, currently based on documentation I do not see exactly what use cases are supported 20180515 01:14:50< irker002> wesnoth/wesnoth:1.14 mattsc 2aae4e80fa Replace remaining uses of FOREACH macro AppVeyor: All builds passed 20180515 01:43:03<+discordbot> I'm a bit curious about the specifics of [foreach] actually (and don't feel like reading the code). 20180515 01:43:47<+discordbot> Why does there have to be an index_var? 20180515 01:43:59< celticminstrel> It's not necessary. 20180515 01:44:01<+discordbot> Sure, I could leave it as the defualt of i that the wiki says will be used. 20180515 01:44:23<+discordbot> But then that means that if I happen to use [foreach] nested in a loop that is using i as the loop variable, things will break horribly. 20180515 01:44:28< celticminstrel> I don't actually remember why that was added, maybe just because some people might find it useful or something. 20180515 01:44:34< celticminstrel> No, it doesn't mean that. 20180515 01:44:56< celticminstrel> When [foreach] finishes executing it will restore the index var to whatever value it had when it started executing. 20180515 01:45:04<+discordbot> Ohhhh. 20180515 01:45:05< celticminstrel> That goes for the main var, too. 20180515 01:45:18< celticminstrel> So effectively it's scoped. 20180515 01:45:23<+discordbot> This is stuff the wiki should say. 20180515 01:45:38<+discordbot> Does this apply to [for] variable=as well? 20180515 01:45:42< celticminstrel> Yeah. 20180515 01:45:47< celticminstrel> And some other places too, I believe. 20180515 01:46:21<+discordbot> Then I don't need to explicitly define unwiedly names for loop variables in generic macros, good to know. :p 20180515 01:46:49<+discordbot> (e.g. https://github.com/project-ethea/Naia/commit/71fa4c8c3b470c2d07e4c6d602f13b1e8c364cc7) 20180515 01:46:50< celticminstrel> [modify_unit], [random_placement], [harm_unit] 20180515 01:47:00< celticminstrel> (Not sure what [harm_unit] uses a variable for.) 20180515 01:47:05< celticminstrel> Oh and [find_path]. 20180515 01:47:30< celticminstrel> And if you need to define more tags that do it, the functions start_var_scope and end_var_scope are defined in "wml-utils" 20180515 01:47:43< celticminstrel> So you can require that and use them. 20180515 01:49:54-!- gfg [~androirc@134.76.63.8] has joined #wesnoth-dev 20180515 01:51:08< EliDupree> Hmmm.... So, what's the current behavior supposed to be regarding wesnoth.set_dialog_value() triggering wesnoth.set_dialog_callback() callbacks? 20180515 01:51:25<+discordbot> what do you mean 20180515 01:52:06< gfg> Ravana: iirc one of the reasons why foreach was deprecated was that is an unquenched unbalanced macro which confused some external tools. 20180515 01:52:09< celticminstrel> Might depend on the type of widget. 20180515 01:52:16< EliDupree> Back in 1.12, it never triggered them. Sometime in 1.13, it started triggering them, causing my code to enter infinite loops, so I had to make a workaround. Now, in 1.14.1, I'm getting infinite loops again despite the workaround 20180515 01:52:40< EliDupree> I don't know for sure if it's the same issue 20180515 01:52:57<+discordbot> oh yeah 20180515 01:53:02<+discordbot> wasn't that what 20180515 01:53:07<+discordbot> {FOREACH} is certainly icky in design. 20180515 01:53:08<+discordbot> gfgtdf's fire event parameter 20180515 01:53:10< EliDupree> But I do know that my callbacks are being triggered forever, I made a debug message 20180515 01:53:13<+discordbot> in the cp 20180515 01:53:17<+discordbot> p 20180515 01:54:12<+discordbot> I kind of prefer using macro shorthands for flow control blocks but I suspect that if I redefine {FOREACH} in my own content I'm going to confuse myself and everyone else later down the line. 20180515 01:54:31<+discordbot> Considered using {FOR_EACH} instead but that's kind of ugly. 20180515 01:55:01<+discordbot> > Anyway we should deprecate {REPEAT} on 1.15. 20180515 01:55:04<+discordbot> oh no 20180515 01:55:07< EliDupree> Okay, it's not actually set_dialog_value doing it, there must be something else triggering the callbacks, but what… 20180515 01:55:22< celticminstrel> {REPEAT} is icky for a different reason. 20180515 01:55:42< celticminstrel> But IMO it shouldn't be deprecated at L1, probably only L1. 20180515 01:55:59< celticminstrel> Which is "this almost certainly won't go away, but please don't use it anyway". 20180515 01:56:06< celticminstrel> The first L1 was supposed to be L3. 20180515 01:56:35<+discordbot> I use {REPEAT} a lot. 20180515 01:56:38<+discordbot> 😦 20180515 01:56:49< celticminstrel> So you can continue using it. 20180515 01:56:55< celticminstrel> Or you can switch over to [repeat]. 20180515 01:57:26< celticminstrel> Which doesn't use a WML index variable at all. 20180515 01:57:57<+discordbot> Oh, there's a [repeat] now? Is it in 1.14? 20180515 01:58:11<+discordbot> Oh yes it is. 20180515 01:58:58<+discordbot> But again I'm like "why would i write this out when i can make a shorthand macro oh wait mainline already has a macro called REPEAT" 20180515 01:59:39<+discordbot> I should've done as I once considered and making the building blocks of my WML use lowercase macro names. 20180515 01:59:45<+discordbot> *and made 20180515 01:59:56< celticminstrel> Heh. 20180515 02:00:30< celticminstrel> I think macros can also contain weird characters, so you could probably call your flow control macros something like $REPEAT and $FOREACH or %REPEAT and %FOREACH or something. 20180515 02:01:03<+discordbot> I think I already use a macro that's just a percent sign somewhere. 20180515 02:01:32< EliDupree> Aha, found my issue! I was mistakenly adding multiple copies of the same callback, during the click that triggers the callback. Wesnoth must have changed its behavior to invoke those callbacks immediately rather than only next time. 20180515 02:01:57<+discordbot> Oh actually I don't, but I do have a {!} macro. 20180515 02:02:05< celticminstrel> What does it do? 20180515 02:02:18<+discordbot> It's just a shorthand for [inspect][/inspect]. 20180515 02:02:37<+discordbot> Not really used in production, it's just there for tricky debugging sessions. 20180515 02:03:12<+discordbot> Also emits a preprocessor warning so I don't forget to remove any instances of it before releasing. 20180515 02:03:31< gfg> What vultraz referd to is that at one point i changed a widgets callback bevor back to the 1.12 so that it no longer fired the call back when sweet via Lua (because it broke my addon) not sure whether u covered all widgets thought. 20180515 02:13:50< EliDupree> Now, onto the next issue. It seems that whenever I use set_dialog_canvas to set a widget to the SAME appearance I already set it to previously, it becomes blank instead. In fact, this applies to all previous appearances of the widget, not just the immediately previous one – could it be some buggy memoization? 20180515 02:14:49< EliDupree> Specifically, I successfully use it to set the appearance of the widgets the first time, but calling it a second time make them all blank 20180515 02:15:16< EliDupree> On the other hand, any widgets that are reset to a DIFFERENT appearance display successfully 20180515 02:20:58<+discordbot> So the scoped variable stuff also includes deleting variables that previously didn't exist? 20180515 02:21:20< celticminstrel> Pretty sure, yeah. 20180515 02:23:53<+discordbot> Oh yeah, I guess it will if setting a WML variable to nil results in it being deleted. 20180515 02:24:10-!- sevu [~Shiki@p548553E4.dip0.t-ipconnect.de] has quit [Remote host closed the connection] 20180515 02:40:28< EliDupree> Whatever's going on seems to only cause trouble for toggle buttons, hmm 20180515 03:13:08< EliDupree> This can't be right... https://github.com/wesnoth/wesnoth/blob/master/src/gui/core/canvas.cpp#L1572 20180515 03:13:54< celticminstrel> ? 20180515 03:14:19< EliDupree> Thanks to the order of operations, it looks like "force" makes the function be "don't remove anything" instead of "remove everything" 20180515 03:14:49< celticminstrel> TBH that lambda looks super-sketchy to begin with. 20180515 03:14:59< celticminstrel> Why the heck is it checking force at all? 20180515 03:15:24< EliDupree> It looks like it was INTENDED to make force mean "always remove" 20180515 03:15:34< celticminstrel> Wouldn't it make more sense to do if(force) {shapes_.clear();} else {the stuff it does there but without caring about force}? 20180515 03:16:14< EliDupree> Sure, that would also work, although it arguably has slightly more code duplication 20180515 03:17:12< EliDupree> Vultraz: Looks like you wrote that code originally? 20180515 03:17:46<+discordbot> @Vultraz isn't online on this end at the moment. 20180515 03:18:44< celticminstrel> I don't really see that as code duplication? 20180515 03:19:09< celticminstrel> clear() is a simple, fast operation; remove_if on the other hand is quite messy. 20180515 03:21:50< EliDupree> celticminstrel: It's duplicating because you have to write clear() twice as well as remove_if() twice 20180515 03:22:02< celticminstrel> Eh... I suppose... 20180515 03:22:20< EliDupree> I also see your point, I don't see either way as obviously better 20180515 03:29:17< irker002> wesnoth/wesnoth:master Charles Dang 49f7569653 Wesnothd: minor code cleanup AppVeyor: vs2015/Debug Failed 20180515 03:29:18< irker002> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-3360 20180515 03:30:15-!- matthiaskrgr [matthiaskr@gateway/shell/panicbnc/x-ihchowyaftepsbvb] has quit [Ping timeout: 276 seconds] 20180515 03:32:28-!- matthiaskrgr [matthiaskr@gateway/shell/panicbnc/x-owhgrvgjvqscyqvs] has joined #wesnoth-dev 20180515 03:32:51-!- matthiaskrgr is now known as Guest81958 20180515 03:51:43-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: KABOOM! It seems that I have exploded. Please wait while I reinstall the universe.] 20180515 03:57:44-!- commavir [vir@2604:180::502b:135a] has quit [Ping timeout: 255 seconds] 20180515 03:58:51-!- commavir [vir@2604:180::502b:135a] has joined #wesnoth-dev 20180515 04:09:33<+discordbot> jyrki wrote that 20180515 04:09:37<+discordbot> i just made it lambda-form 20180515 04:10:32<+discordbot> but yeah i see your point 20180515 04:10:34<+discordbot> what has this to do? 20180515 04:15:21-!- commavir [vir@2604:180::502b:135a] has quit [Ping timeout: 240 seconds] 20180515 04:25:28< irker002> wesnoth/wesnoth:master Charles Dang 474a7dc122 Wesnothd: minor code cleanup AppVeyor: vs2017/Debug Failed 20180515 04:25:29< irker002> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-master-3073 20180515 04:28:50-!- commavir [vir@2604:180::502b:135a] has joined #wesnoth-dev 20180515 04:34:17-!- commavir [vir@2604:180::502b:135a] has quit [Ping timeout: 260 seconds] 20180515 04:38:58< irker002> wesnoth/wesnoth:1.14 Severin Glöckner ed1ced196d NR S2: balance imporvements between AIs AppVeyor: All builds passed 20180515 04:41:01-!- commavir [vir@2604:180::502b:135a] has joined #wesnoth-dev 20180515 04:46:17-!- commavir [vir@2604:180::502b:135a] has quit [Ping timeout: 276 seconds] 20180515 04:52:47-!- commavir [vir@2604:180::502b:135a] has joined #wesnoth-dev 20180515 04:56:24<+discordbot> No, I didn't write it. I only extended it to clear drawn_shapes_ as well. 20180515 04:56:25<+discordbot> https://github.com/wesnoth/wesnoth/commit/6110fb59dbe8ffb226db720f1001aba76bdb4143 20180515 04:57:53<+discordbot> Vultraz wrote the original code: https://github.com/wesnoth/wesnoth/commit/1a231c7fdcb595e30b8d4e1b1df1a7f00bf2150b 20180515 05:02:21-!- commavir [vir@2604:180::502b:135a] has quit [Ping timeout: 240 seconds] 20180515 05:06:28<+discordbot> oh 20180515 05:06:48<+discordbot> sorry 20180515 05:10:39-!- commavir [vir@2604:180::502b:135a] has joined #wesnoth-dev 20180515 05:53:18<+discordbot> If somebody's interested: I got a crash report from iTunes in sound::decrement_chunk_usage() called from a destructor on exit(). Not a big deal, but still. 20180515 05:58:38< irker002> wesnoth/wesnoth:master Charles Dang 50a3960abd Removed a bunch of things deprecated at AppVeyor: vs2017/Debug Failed 20180515 05:58:39< irker002> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-master-3075 20180515 06:02:51-!- Appleman1234 [~quassel@124x38x163x22.ap124.ftth.ucom.ne.jp] has joined #wesnoth-dev 20180515 06:12:49-!- Appleman1234 [~quassel@124x38x163x22.ap124.ftth.ucom.ne.jp] has quit [Ping timeout: 248 seconds] 20180515 06:15:13-!- Appleman1234 [~quassel@124x38x163x22.ap124.ftth.ucom.ne.jp] has joined #wesnoth-dev 20180515 06:24:22-!- gfg [~androirc@134.76.63.8] has quit [Remote host closed the connection] 20180515 06:26:09< irker002> wesnoth/wesnoth:1.14 mattsc 1017a57f39 Replace remaining uses of FOREACH macro AppVeyor: All builds passed 20180515 06:40:39-!- Guest81958 [matthiaskr@gateway/shell/panicbnc/x-owhgrvgjvqscyqvs] has quit [Changing host] 20180515 06:40:39-!- Guest81958 [matthiaskr@unaffiliated/matthiaskrgr] has joined #wesnoth-dev 20180515 06:40:39-!- Guest81958 [matthiaskr@unaffiliated/matthiaskrgr] has quit [Changing host] 20180515 06:40:40-!- Guest81958 [matthiaskr@gateway/shell/panicbnc/x-owhgrvgjvqscyqvs] has joined #wesnoth-dev 20180515 06:41:06-!- Guest81958 is now known as matthiaskrgr 20180515 07:00:02-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20180515 07:17:04< wedge009> Vultraz: 'I decided this past weekend to direct our packagers to push any translation updates to Steam every Saturday or Sunday, so players will get those quite quickly outside the normal release schedule.' 20180515 07:17:16< wedge009> Is that why I got a small Steam update even though there wasn't a point release? 20180515 07:17:32<+discordbot> yes 20180515 07:18:25< wedge009> Cool, thanks. 20180515 07:41:51-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180515 07:41:57-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180515 08:04:25< irker002> wesnoth: Charles Dang wesnoth:master 3d73dfdb1599 / src/gui/dialogs/campaign_difficulty.cpp: Campaign Difficulty: cleaned up a few things left over from 50a3960 https://github.com/wesnoth/wesnoth/commit/3d73dfdb1599744547801ed9faf8b4bd8c30f246 20180515 08:04:28< irker002> wesnoth: Charles Dang wesnoth:master 10e43a6642df / src/gui/core/canvas.cpp: GUI2/Canvas: simplify clear_shapes logic https://github.com/wesnoth/wesnoth/commit/10e43a6642df0496beda23f891fd5cd334270921 20180515 08:08:43< irker002> wesnoth: Charles Dang wesnoth:master 946e9c31b453 / projectfiles/VC14/ (campaignd.vcxproj wesnoth.vcxproj wesnothd.vcxproj): Fixup 2a585118d8b6c (forgot to bump defines on all configurations) https://github.com/wesnoth/wesnoth/commit/946e9c31b453611271491eddf6f12437863a75b5 20180515 08:10:41<+discordbot> Any particular reason the leader's gender is preserved in a slot left vacant by a player returning to the lobby? 20180515 08:11:00<+discordbot> Not really, but is there any reason not to? 20180515 08:11:04<+discordbot> Also please add functionality for switching between chats (ctrl + tab) 20180515 08:12:02<+discordbot> @Vultraz no other information was preserved as far as I know 20180515 08:12:05<+discordbot> hm 20180515 08:12:07<+discordbot> odd 20180515 08:12:28<+discordbot> very odd 20180515 08:12:56<+discordbot> Gender was female after the player left 20180515 08:13:04<+discordbot> didn't switch back to random 20180515 08:13:27<+discordbot> I didn't notice it until now 20180515 08:13:39<+discordbot> interesting... interesting 20180515 08:15:41<+discordbot> @Vultraz actually, I would be in favor of becoming more compliant with semantic versioning 20180515 08:15:43<+discordbot> https://semver.org/ 20180515 08:16:42<+discordbot> maybe we should change our versioning scheme 20180515 08:16:53<+discordbot> so for example 1.14.x 20180515 08:17:00<+discordbot> will become 14.x.y 20180515 08:17:13<+discordbot> that'sbeen proposed for ages 20180515 08:17:13<+discordbot> that way we could better signal to umc authors 20180515 08:17:22<+discordbot> when apis change 20180515 08:17:39<+discordbot> like increment x for each new engine feature 20180515 08:17:58<+discordbot> and increment major version when we drop deprecated stuff 20180515 08:18:16<+discordbot> major versions could operate like before, with separate branches and all 20180515 08:18:20<+discordbot> I would be in support of this 20180515 08:22:33-!- atarocch [atarocch@nat/redhat/x-jxjxmupwcmlippzw] has joined #wesnoth-dev 20180515 08:29:19< irker002> wesnoth/wesnoth:master Charles Dang 49f7569653 Wesnothd: minor code cleanup AppVeyor: 1/2 builds failed 20180515 08:29:20< irker002> Details vs2015/Debug: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-3360 20180515 08:36:21-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180515 08:44:55-!- gfg [~androirc@tmo-106-17.customers.d1-online.com] has joined #wesnoth-dev 20180515 08:51:37-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20180515 09:05:08-!- gfg [~androirc@tmo-106-17.customers.d1-online.com] has quit [Remote host closed the connection] 20180515 09:06:12-!- gfg [~androirc@tmo-106-17.customers.d1-online.com] has joined #wesnoth-dev 20180515 09:08:48-!- vladimirslavik [vslavik@nat/redhat/x-cdgaypgaruvudmcl] has joined #wesnoth-dev 20180515 09:10:51-!- gfg [~androirc@tmo-106-17.customers.d1-online.com] has quit [Read error: Connection reset by peer] 20180515 09:10:52-!- gfgt [~androirc@tmo-106-17.customers.d1-online.com] has joined #wesnoth-dev 20180515 09:13:29-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180515 09:19:52-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20180515 09:21:17-!- gfgt [~androirc@tmo-106-17.customers.d1-online.com] has quit [Ping timeout: 260 seconds] 20180515 09:21:23-!- gfgt [~androirc@ersc129.goemobile.de] has joined #wesnoth-dev 20180515 09:25:30< irker002> wesnoth/wesnoth:master Charles Dang 474a7dc122 Wesnothd: minor code cleanup AppVeyor: 1/2 builds failed 20180515 09:25:30< irker002> Details vs2017/Debug: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-master-3073 20180515 09:30:41-!- gfgt [~androirc@ersc129.goemobile.de] has quit [Ping timeout: 256 seconds] 20180515 09:38:52-!- louis94 [~~louis94@91.176.171.238] has joined #wesnoth-dev 20180515 09:45:46-!- gfgt [~androirc@ersc134.goemobile.de] has joined #wesnoth-dev 20180515 09:48:49<+discordbot> @loonycyborg can i merge my wesnothd formatting pr? 20180515 09:52:33-!- gfgt [~androirc@ersc134.goemobile.de] has quit [Ping timeout: 264 seconds] 20180515 09:52:54-!- gfgt [~androirc@ersc129.goemobile.de] has joined #wesnoth-dev 20180515 09:53:01-!- louis94 [~~louis94@91.176.171.238] has quit [Ping timeout: 268 seconds] 20180515 09:58:24-!- Stragus [~alexis@modemcable198.134-161-184.mc.videotron.ca] has quit [Ping timeout: 255 seconds] 20180515 09:58:36<+discordbot> linky? 20180515 09:59:02<+discordbot> nwm found it 20180515 09:59:04<+discordbot> looking 20180515 10:02:30-!- Appleman1234 [~quassel@124x38x163x22.ap124.ftth.ucom.ne.jp] has quit [Remote host closed the connection] 20180515 10:21:10-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180515 10:24:06-!- gfgt [~androirc@ersc129.goemobile.de] has quit [Remote host closed the connection] 20180515 10:39:17-!- gfgt [~androirc@tmo-106-17.customers.d1-online.com] has joined #wesnoth-dev 20180515 10:42:18-!- commavir [vir@2604:180::502b:135a] has quit [Ping timeout: 255 seconds] 20180515 10:42:50-!- commavir [vir@2604:180::502b:135a] has joined #wesnoth-dev 20180515 10:42:53-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20180515 10:47:41-!- commavir [vir@2604:180::502b:135a] has quit [Ping timeout: 255 seconds] 20180515 10:48:55-!- commavir [vir@2604:180::502b:135a] has joined #wesnoth-dev 20180515 10:49:50< irker002> wesnoth: Charles Dang wesnoth:master b623e7a647d7 / src/server/server.cpp: Wesnothd: dropped a giant block of commented-out code https://github.com/wesnoth/wesnoth/commit/b623e7a647d7c88f4113b8bddcd6867ea7eb67e0 20180515 10:49:54< irker002> wesnoth: Charles Dang wesnoth:master 9a2d09f97ef6 / src/server/server.cpp: Wesnothd: formatting cleanup https://github.com/wesnoth/wesnoth/commit/9a2d09f97ef62dd732aecc8887b488020dce58f4 20180515 10:49:57< irker002> wesnoth: Charles Dang wesnoth:master 2d600d10dcca / src/server/server.cpp: Wesnothd: minor code cleanup https://github.com/wesnoth/wesnoth/commit/2d600d10dcca7eebe83f35623b0014d574f225b9 20180515 10:50:22<+discordbot> @Vultraz it's fine I think 20180515 10:50:52<+discordbot> can't say I appreciate extra {} but there won't be harm from them either 20180515 10:51:36<+discordbot> you use too few {} tho 20180515 10:55:21-!- commavir [vir@2604:180::502b:135a] has quit [Ping timeout: 255 seconds] 20180515 10:55:53-!- commavir [vir@2604:180::502b:135a] has joined #wesnoth-dev 20180515 10:58:02<+discordbot> hmm. I don't think it is? 20180515 10:58:40< irker002> wesnoth/wesnoth:master Charles Dang 50a3960abd Removed a bunch of things deprecated at AppVeyor: 2/4 builds failed 20180515 10:58:41< irker002> Details vs2017/Debug: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-master-3075 20180515 10:58:42< irker002> Details vs2015/Debug: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-3362 20180515 11:03:37-!- commavir [vir@2604:180::502b:135a] has quit [Ping timeout: 256 seconds] 20180515 11:04:27-!- commavir [vir@2604:180::502b:135a] has joined #wesnoth-dev 20180515 11:08:20< irker002> wesnoth: Charles Dang wesnoth:1.14 be1b1b69f194 / src/server/server.cpp: Wesnothd: dropped a giant block of commented-out code https://github.com/wesnoth/wesnoth/commit/be1b1b69f19473d27983902babddcb0a1bc3a14f 20180515 11:08:23< irker002> wesnoth: Charles Dang wesnoth:1.14 7c19789273a3 / src/server/server.cpp: Wesnothd: formatting cleanup https://github.com/wesnoth/wesnoth/commit/7c19789273a3a833b999393f0889eeb14dfeb670 20180515 11:08:27< irker002> wesnoth: Charles Dang wesnoth:1.14 2667cc21cd1e / src/server/server.cpp: Wesnothd: minor code cleanup https://github.com/wesnoth/wesnoth/commit/2667cc21cd1eacdb14ecee9fff26ae6f17862f76 20180515 11:09:47-!- commavir [vir@2604:180::502b:135a] has quit [Ping timeout: 260 seconds] 20180515 11:10:32-!- commavir [vir@2604:180::502b:135a] has joined #wesnoth-dev 20180515 11:16:01-!- commavir [vir@2604:180::502b:135a] has quit [Ping timeout: 265 seconds] 20180515 11:55:22-!- Stragus [~alexis@modemcable198.134-161-184.mc.videotron.ca] has joined #wesnoth-dev 20180515 11:55:59-!- commavir [vir@2604:180::502b:135a] has joined #wesnoth-dev 20180515 12:19:04-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180515 12:22:34-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180515 12:23:29-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 248 seconds] 20180515 12:43:19-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20180515 12:55:32-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: mattsc] 20180515 13:02:55-!- vladimirslavik [vslavik@nat/redhat/x-cdgaypgaruvudmcl] has quit [Quit: Leaving] 20180515 13:04:40-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev 20180515 13:36:46< irker002> wesnoth: Severin Glöckner wesnoth:1.14 f4f6f5bcddc8 / data/campaigns/Northern_Rebirth/scenarios/02_01_Infested_Caves.cfg: NR S2: fix filters for Micor AIs https://github.com/wesnoth/wesnoth/commit/f4f6f5bcddc83e467286de279c8d5ee8ebe3d8a3 20180515 14:00:57-!- atarocch [atarocch@nat/redhat/x-jxjxmupwcmlippzw] has quit [Ping timeout: 264 seconds] 20180515 14:07:06-!- gfgt [~androirc@tmo-106-17.customers.d1-online.com] has quit [Remote host closed the connection] 20180515 14:07:25-!- gfgt [~androirc@tmo-106-17.customers.d1-online.com] has joined #wesnoth-dev 20180515 14:15:20< EliDupree> Oh good, I recovered my wiki account. Now I can enter stuff whenever it comes to mind. Let's start with the select_unit bug 20180515 14:15:27< zookeeper> i'd suggest everyone reads their commit messages before pressing the button, as it's not nice to have typos in words likely to be used for searching the commit log later. 20180515 14:16:23< zookeeper> (for some reason it seems a lot of people make a lot of typos especially in their commit messages) 20180515 14:17:55-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev 20180515 14:26:59< irker002> wesnoth/wesnoth:master Charles Dang 946e9c31b4 Fixup 2a585118d8b6c (forgot to bump defi AppVeyor: All builds passed 20180515 14:29:52-!- gfgt [~androirc@tmo-106-17.customers.d1-online.com] has quit [Remote host closed the connection] 20180515 14:30:07< EliDupree> Ravana_: There, I wrote down the stuff I discovered about on_mouse_action https://wiki.wesnoth.org/index.php?title=LuaWML/Events&diff=prev&oldid=59634 20180515 14:31:30< EliDupree> I've probably got a lot of other accumulated knowledge I could write on the wiki, but nothing jumps to mind immediately. I'll add it as I think of it, I guess. 20180515 14:43:43< irker002> wesnoth: Severin Glöckner wesnoth:master ddaf9f5a877c / data/campaigns/Northern_Rebirth/scenarios/02_01_Infested_Caves.cfg: NR S2: fix filters for Micro AIs https://github.com/wesnoth/wesnoth/commit/ddaf9f5a877c1939ac8ec4fdb3de28d2146876e3 20180515 14:43:57<+discordbot> zookeeper, point taken 20180515 14:45:14<+discordbot> BTW, then does the string freeze for 1.14.2 start 20180515 14:45:33<+discordbot> *when 20180515 14:47:58-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: mattsc] 20180515 14:51:07<+discordbot> Hopefully today 00:01 UTC @Vultraz 20180515 14:53:18-!- atarocch [~atarocch@93.56.164.28] has joined #wesnoth-dev 20180515 15:08:14-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180515 15:08:22-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180515 15:14:17-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev 20180515 16:26:34-!- gfg [~androirc@tmo-106-17.customers.d1-online.com] has joined #wesnoth-dev 20180515 16:28:01-!- vn971 [~vasya@94.158.103.15] has joined #wesnoth-dev 20180515 16:36:51-!- Oebele [~quassel@143.177.58.202] has joined #wesnoth-dev 20180515 17:03:45-!- Bhoren [~Bhoren_wh@2a01:e0a:c:2150:296f:97c:495f:9915] has joined #wesnoth-dev 20180515 17:16:18-!- gfg [~androirc@tmo-106-17.customers.d1-online.com] has quit [Read error: Connection reset by peer] 20180515 17:16:29-!- gfg [~androirc@tmo-106-17.customers.d1-online.com] has joined #wesnoth-dev 20180515 17:20:58< irker002> wesnoth: Jyrki Vesterinen wesnoth:1.14 b8ffe007e5a4 / src/ (game_events/pump.cpp game_events/pump.hpp units/unit.cpp): Throw a Lua exception when creating a negative-HP unit in a Lua context https://github.com/wesnoth/wesnoth/commit/b8ffe007e5a4026185c488589069766f475e1013 20180515 17:23:37< irker002> wesnoth: Jyrki Vesterinen wesnoth:master 258a0e4689e9 / src/ (game_events/pump.cpp game_events/pump.hpp units/unit.cpp): Throw a Lua exception when creating a negative-HP unit in a Lua context https://github.com/wesnoth/wesnoth/commit/258a0e4689e9c000e3e0017ceed5e120156883ae 20180515 17:27:06-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity] 20180515 17:27:09-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev 20180515 17:32:09-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180515 17:32:15-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180515 17:45:24< irker002> wesnoth/wesnoth:master Charles Dang 2d600d10dc Wesnothd: minor code cleanup AppVeyor: All builds passed 20180515 17:46:01-!- gfg [~androirc@tmo-106-17.customers.d1-online.com] has quit [Remote host closed the connection] 20180515 17:55:12-!- gfg [~androirc@tmo-106-17.customers.d1-online.com] has joined #wesnoth-dev 20180515 18:02:40-!- gfg [~androirc@tmo-106-17.customers.d1-online.com] has quit [Remote host closed the connection] 20180515 18:02:52-!- gfg [~androirc@tmo-106-17.customers.d1-online.com] has joined #wesnoth-dev 20180515 18:28:19-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: So long and thanks for all the fish.] 20180515 18:42:07-!- Oebele [~quassel@143.177.58.202] has quit [Remote host closed the connection] 20180515 18:45:28-!- gfg [~androirc@tmo-106-17.customers.d1-online.com] has quit [Remote host closed the connection] 20180515 18:45:39-!- gfg [~androirc@tmo-106-17.customers.d1-online.com] has joined #wesnoth-dev 20180515 18:56:38-!- gfg [~androirc@tmo-106-17.customers.d1-online.com] has quit [Ping timeout: 265 seconds] 20180515 18:57:14-!- gfg [~androirc@134.76.63.8] has joined #wesnoth-dev 20180515 19:00:39-!- gfgt [~androirc@134.76.63.8] has joined #wesnoth-dev 20180515 19:02:57-!- gfg [~androirc@134.76.63.8] has quit [Ping timeout: 248 seconds] 20180515 19:59:16<+discordbot> ah, yes, the string freeze 🤔 20180515 19:59:22<+discordbot> do I have any other strings that need changing... 20180515 20:02:50<+discordbot> hm. That "FPS Limiter" option sounds like it could have a better name 20180515 20:09:23<+discordbot> I thought that recently too. It's vsync? 20180515 20:11:43<+discordbot> no 20180515 20:11:53-!- travis-ci [~travis-ci@ec2-54-158-40-27.compute-1.amazonaws.com] has joined #wesnoth-dev 20180515 20:11:54< travis-ci> Pentarctagon/wesnoth#37 (master - 258a0e4 : Jyrki Vesterinen): The build was broken. 20180515 20:11:54< travis-ci> Build details : https://travis-ci.org/Pentarctagon/wesnoth/builds/379367087 20180515 20:11:54-!- travis-ci [~travis-ci@ec2-54-158-40-27.compute-1.amazonaws.com] has left #wesnoth-dev [] 20180515 20:12:02<+discordbot> @shadowm I assume wesnothd and campaignd don't need SDL2? 20180515 20:12:10<+discordbot> Nope. 20180515 20:12:15<+discordbot> Ok, so no string freeze until I ask jyrki about that string 20180515 20:12:28<+discordbot> Ask him ASAP ist 20180515 20:12:32<+discordbot> *istg 20180515 20:12:34<+discordbot> he's not here 20180515 20:12:40<+discordbot> I kow. 20180515 20:12:42<+discordbot> nnnnnnnnnnn 20180515 20:12:50<+discordbot> your n is broken 20180515 20:12:53<+discordbot> I can do timezone maths in my head on the fly unlike you. 20180515 20:13:22<+discordbot> which is odd since you live in what's the equivalent of central time 20180515 20:14:00<+discordbot> Only for 4 months a year. 20180515 20:15:44<+discordbot> Also you mean Eastern Summer Time. 20180515 20:16:45<+discordbot> The point being is you're not the one with weird times 20180515 20:16:50<+discordbot> I'm GMT + 11 20180515 20:16:54<+discordbot> no DST 20180515 20:16:57<+discordbot> and a day ahead of most people 20180515 20:17:20<+discordbot> I still don't know how that's relevant. 20180515 20:17:34<+discordbot> you have easier timezone calculations 20180515 20:17:59<+discordbot> Considering that I mostly have to deal with people from Western, Eastern, and Central Europe, not really. 20180515 20:18:15<+discordbot> (And also people from the US West coast.) 20180515 20:19:54< irker002> wesnoth: Charles Dang wesnoth:1.14 cfffb9be0b09 / src/ (gui/dialogs/multiplayer/mp_options_helper.cpp saved_game.cpp): Revert "Save custom options data in a more concise way" https://github.com/wesnoth/wesnoth/commit/cfffb9be0b09c29c7c49e5f1fb92829b4a441bc1 20180515 20:20:27<+discordbot> And also you. 20180515 20:20:47< irker002> wesnoth: Nils Kneuper wesnoth:master 2d9e02cffa1a / po/ (4 files in 4 dirs): updated Spanish translation https://github.com/wesnoth/wesnoth/commit/2d9e02cffa1ae5146632c4ddbcc9e379648f6bb5 20180515 20:21:28< irker002> wesnoth: Nils Kneuper wesnoth:1.14 bccef1438727 / / (6 files in 5 dirs): updated Spanish translation https://github.com/wesnoth/wesnoth/commit/bccef143872796520ea0af11fc93e7b8e46da0dc 20180515 20:21:48< irker002> wesnoth: Charles Dang wesnoth:master 1097bad28c79 / src/ (gui/dialogs/multiplayer/mp_options_helper.cpp saved_game.cpp): Revert "Save custom options data in a more concise way" https://github.com/wesnoth/wesnoth/commit/1097bad28c79810a40a04c840a19184a68314a9b 20180515 20:22:28<+discordbot> The dunefolk description is now in 1.14 too 20180515 20:22:36<+discordbot> lot of fun for translators 😬 20180515 20:25:53<+discordbot> apparently they do need SDL2. If find_package(SDL2 2.0.4 REQUIRED) is put behind a check for the wesnoth client or boost unit tests being enabled, both wesnothd and campaignd fail with: server_base.cpp.o: undefined reference to symbol 'pthread_sigmask@@GLIBC_2.2.5' //lib/x86_64-linux-gnu/libpthread.so.0: error adding symbols: DSO missing from command line 20180515 20:28:05<+discordbot> but there's no SDL code there.. 20180515 20:28:45<+discordbot> literally all I did was change: find_package(SDL2 2.0.4 REQUIRED) to: if(ENABLE_GAME OR ENABLE_TESTS) find_package(SDL2 2.0.4 REQUIRED) endif(ENABLE_GAME OR ENABLE_TESTS) 20180515 20:28:59<+discordbot> and then try building with neither of those enabled 20180515 20:29:45<+discordbot> cmake . -DENABLE_GAME=no -DENABLE_TESTS=no -DENABLE_SERVER=yes -DENABLE_CAMPAIGN_SERVER=yes -DENABLE_NLS=no 20180515 20:30:23<+discordbot> in relation to https://github.com/wesnoth/wesnoth/issues/3115, btw 20180515 20:30:58<+discordbot> https://stackoverflow.com/questions/25617839/undefined-reference-to-symbol-pthread-key-deleteglibc-2-2-5 20180515 20:36:44<+discordbot> @Pentarctagon pthread is not SDL. 20180515 20:37:09<+discordbot> They need pthread because they use threaded functionality from Asio I think. 20180515 20:37:39<+discordbot> loonycyborg might know for certain since he did this for SCons. 20180515 20:38:27<+discordbot> that SO answer relates to cmake 20180515 20:40:02< irker002> wesnoth: Charles Dang wesnoth:master ba6fa1e46bb3 / src/server/ (send_receive_wml_helpers.ipp server_base.hpp): Convert a few remaining cases of boost::uint32_t to uint32_t https://github.com/wesnoth/wesnoth/commit/ba6fa1e46bb33b69c76d223898e4d448df74087d 20180515 20:41:14< irker002> wesnoth: Charles Dang wesnoth:1.14 5c2ab63448fb / src/server/ (send_receive_wml_helpers.ipp server_base.hpp): Convert a few remaining cases of boost::uint32_t to uint32_t https://github.com/wesnoth/wesnoth/commit/5c2ab63448fb7b1cc72d22d38619d877ac7de973 20180515 20:43:07<+discordbot> looks like just adding -lpthread to the linking fixes it. 20180515 20:45:03< irker002> wesnoth/wesnoth:1.14 Severin Glöckner f4f6f5bcdd NR S2: fix filters for Micor AIs AppVeyor: All builds passed 20180515 20:50:58< irker002> wesnoth: Pentarctagon wesnoth:1.14 9e0de75a7507 / CMakeLists.txt src/CMakeLists.txt: Don't require SDL2 for building the servers. https://github.com/wesnoth/wesnoth/commit/9e0de75a750786de40ffa6a3401e52e81ec44fc0 20180515 20:59:07-!- Bhoren [~Bhoren_wh@2a01:e0a:c:2150:296f:97c:495f:9915] has quit [Quit: Leaving] 20180515 21:39:11< irker002> wesnoth: Pentarctagon wesnoth:master fd34fe849770 / CMakeLists.txt src/CMakeLists.txt: Don't require SDL2 or OGL for building the servers. https://github.com/wesnoth/wesnoth/commit/fd34fe849770de379096ac1ffe612fb22473a846 20180515 21:45:20< zookeeper> ah, i was thinking of merging the SotBE timeline tweaking PR and porting it to 1.14 before the freeze, but guess it doesn't necessarily even need to go into 1.14... 20180515 21:46:17< zookeeper> but then again, it could, 1.14 is going to be around for a while. 20180515 22:07:34< zookeeper> does anyone consider it poor form to merge simple PR's by hand just so you can give them better commit messages (or fix indentation, or whatever)? the original author would only be mentioned in the commit message then, after all. 20180515 22:17:43<+discordbot> (I mean I'm pretty sure you're talking about me, so I'm cool with it :P ) 20180515 22:20:02<+discordbot> But if you let me know what I did wrong with commit messages so that I don't do it again that'd be cool. 20180515 22:22:15< zookeeper> nah, i was thinking of the aforementioned. 20180515 22:26:06-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection] 20180515 22:30:25< irker002> wesnoth: Aaron Winter wesnoth:master 77fd148f063c / data/campaigns/Son_Of_The_Black_Eye/scenarios/ (01_End_of_Peace.cfg 17_The_Human_Attack.cfg): SotBE: Changed a few dates to fit the tweaked timeline from the forums https://github.com/wesnoth/wesnoth/commit/77fd148f063c06866e4c7bd56451afd35bf8d448 20180515 22:32:36< irker002> wesnoth: Aaron Winter wesnoth:1.14 f31355af0db3 / data/campaigns/Son_Of_The_Black_Eye/scenarios/ (01_End_of_Peace.cfg 17_The_Human_Attack.cfg): SotBE: Changed a few dates to fit the tweaked timeline from the forums https://github.com/wesnoth/wesnoth/commit/f31355af0db37f44067aeefe9b0c7b8187725178 20180515 22:37:12-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [] 20180515 22:51:13-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180515 22:51:19-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180515 23:16:59-!- louis94 [~~louis94@91.176.171.238] has joined #wesnoth-dev 20180515 23:50:31< irker002> wesnoth/wesnoth:1.14 Jyrki Vesterinen b8ffe007e5 Throw a Lua exception when creating a ne AppVeyor: All builds passed 20180515 23:57:14-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev --- Log closed Wed May 16 00:00:48 2018