--- Log opened Fri May 18 00:00:26 2018 20180518 00:02:00< celticminstrel> https://steamcommunity.com/app/599390/discussions/0/1693795812294791548/ 20180518 00:03:26-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180518 00:17:04-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180518 00:17:57-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 240 seconds] 20180518 00:32:13-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180518 00:32:19-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180518 00:51:05-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev 20180518 00:53:57-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 256 seconds] 20180518 01:08:32< mattsc> @Bitron I tested most of the Micro AIs very recently (as in, within the last week on 1.14.1+dev) and AFAICT they all work. 20180518 01:30:02-!- irker394 [~irker@uruz.ai0867.net] has joined #wesnoth-dev 20180518 01:30:02< irker394> wesnoth/wesnoth:1.14 Nils Kneuper e19bb256bc updated Italian translation AppVeyor: All builds passed 20180518 01:42:13-!- gfgtdf [~gfgtdf@134.76.63.8] has quit [Quit: Leaving] 20180518 01:44:38< celticminstrel> BTW @Vultraz have you decided whether to merge that PR. 20180518 01:45:10< celticminstrel> Or should I close it. 20180518 01:45:28<+discordbot> BTW @Vultraz and celticminstrel how's that fix for the music issue going? 20180518 01:45:45< celticminstrel> Last I heard @Vultraz had a fix locally. No idea what came of that. 20180518 01:45:54< celticminstrel> But because of that I stopped looking into it. 20180518 01:46:05<+discordbot> He led me to believe you were supposed to review it or something. 20180518 01:46:17< celticminstrel> I'd be happy to? 20180518 01:46:22< celticminstrel> But I haven't seen the fix anywhere. 20180518 01:46:23<+discordbot> Or that you had your own fix not sure. 20180518 01:46:53<+discordbot> Anyway I'd love it if it could be sorted out before 1.14.2. :p 20180518 01:47:31< celticminstrel> Wait, come to think of it, 1.14.2 isn't until Tuesday, right? 20180518 01:47:40<+discordbot> Tuesday 00:01 UTC. 20180518 01:47:47< celticminstrel> Right, so Wednesday. 20180518 01:47:53<+discordbot> That may or may not be your Tuesday depending on your timezone. 20180518 01:47:56< celticminstrel> So I actually still have time to get that command-line argument in as long as I defer the man-page update to after the tagging. 20180518 01:47:58<+discordbot> For me it's Monday night. 20180518 01:48:08< celticminstrel> Oh, hmm. 20180518 01:48:18< celticminstrel> Yeah I guess it would be Monday? 20180518 01:48:28< celticminstrel> Since I'm UTC-5 or 4. 20180518 01:48:43<+discordbot> Yep, should be Monday night for you too then. 20180518 01:49:08<+discordbot> Or at least so it should be in theory. In practice odds are we'll find some reason to postpone it for 12 hours somehow. 20180518 01:49:14< celticminstrel> Heh. 20180518 01:53:47<+discordbot> celmin: which PR? 20180518 01:55:46<+discordbot> Gah. 20180518 01:55:52<+discordbot> GitHub was flipped side-ways. 20180518 01:57:13<+discordbot> as for the sound thing, I lost my fix, but it was simple, so I can recreate it. 20180518 01:57:33<+discordbot> I wasn't 100% satisfied with it because it didn't seem to stop music quick enough when loading 20180518 01:59:09<+discordbot> hrr 20180518 01:59:47<+discordbot> in my haste to finish cooking dinner, I forgot to update the text domain and map path for my updated THoT scenario 20180518 01:59:53-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180518 01:59:56<+discordbot> guess I'll have to add another commit to my PR 20180518 01:59:58<+discordbot> MAP PATHS 20180518 01:59:59<+discordbot> yes 20180518 02:00:04<+discordbot> =_= 20180518 02:00:14<+discordbot> sorry, you just reminded me of an Idea I had last night 20180518 02:00:37< celticminstrel> @Vultraz schema_fixes 20180518 02:02:04<+discordbot> wait a minue 20180518 02:02:11<+discordbot> is this already supported 20180518 02:02:12 * celticminstrel also wonders why you're randomly shouting about map paths. 20180518 02:02:13<+discordbot> and undocumeted? 20180518 02:02:29< celticminstrel> ? 20180518 02:02:43< celticminstrel> Map paths? 20180518 02:02:58< celticminstrel> You mean like the map_file key in [scenario] that no-one uses? (Except maybe LoW.) 20180518 02:03:26<+discordbot> celmin: I remembered that I had added map_path and mask_file path handling in [terrain_mask] and [replace_map]. It occurred to me that would be a good thing to have at toplevel since maps could be changed and mid-scenario saves could reflect that 20180518 02:03:37<+discordbot> and now I look and it seems that's already supported 20180518 02:03:38< celticminstrel> Was it map_path? I thought it was map_file. 20180518 02:04:08<+discordbot> er, yeah 20180518 02:04:11<+discordbot> but.... 20180518 02:04:12<+discordbot> hm 20180518 02:04:23<+discordbot> the only handling seems to be in expand_random_scenario 20180518 02:04:29<+discordbot> let me test 20180518 02:05:25<+discordbot> it does work 20180518 02:05:52< celticminstrel> You must've missed something? 20180518 02:06:11< celticminstrel> I definitely saw it somewhere when looking at replace_map... 20180518 02:06:19< celticminstrel> Though that might not be related. 20180518 02:06:21<+discordbot> it's handled in 3 places 20180518 02:06:36<+discordbot> anyway, looks like the full map is still written to savefiles 20180518 02:06:36< celticminstrel> Well then! 20180518 02:07:01<+discordbot> oh wait 20180518 02:07:03<+discordbot> .... 20180518 02:07:07<+discordbot> i changed the file in master 20180518 02:07:12< celticminstrel> ??? 20180518 02:07:48<+discordbot> Incidentally, I saw something earlier about removing event handlers in save files. 20180518 02:08:13< celticminstrel> ??? 20180518 02:08:58<+discordbot> (Vultraz.) You really can't do that without first coming up with a way to identify events uniquely (e.g. hashing their WML trees or something) and keep track of which ones have already fired (and have first_time_only=yes) and which ones have been removed by [remove_event]. 20180518 02:09:17<+discordbot> Aaaaand there's also the issue that not all events exist in the initial state of a scenario. 20180518 02:09:51<+discordbot> As a trivial example: [event] turn=5 [event] name=side 3 turn 5 [...] [/event] [/event] 20180518 02:10:39<+discordbot> I reckon you can just keep serializing event handlers that don't meet the criteria for reading them off the scenario config. 20180518 02:11:01<+discordbot> Although that might result in interesting issues when the scenario code changes independently of a mid-game save. 20180518 02:11:08< celticminstrel> I'm going to assume this is about removing them from the snapshot or something. 20180518 02:11:23<+discordbot> Yes. 20180518 02:11:39< celticminstrel> In which case the only ones you'd have to avoid removing are those that are dynamically constructed. 20180518 02:11:56< celticminstrel> ...which I guess might have to include nested ones though... 20180518 02:12:00<+discordbot> Yeah that's what I suggested more or less. 20180518 02:12:07< celticminstrel> Since nested ones are added from Lua. 20180518 02:12:35<+discordbot> The hash idea is incomplete btw. Two event handlers could end up having the same WML hash and still coexist. 20180518 02:12:58<+discordbot> So something more akin to UUIDs would be needed. 20180518 02:13:15< celticminstrel> You could just generate unique IDs for all the toplevel events when the scenario is loaded, I thnk. 20180518 02:13:36< celticminstrel> In theory you could probably do that for nested events too, but I'm not sure how you'd get the Lua call to take advantage of that. 20180518 02:14:50<+discordbot> looks like map_file is broken at toplevel if your map isn't in maps/ or editor/maps 20180518 02:15:00< celticminstrel> Fun! 20180518 02:15:10< celticminstrel> But does that include ~add-ons/Your_Addon/maps? 20180518 02:15:42< celticminstrel> (For example, it might be checking the binary paths, in which case that location should work.) 20180518 02:15:44<+discordbot> it should 20180518 02:15:58<+discordbot> cpp std::string map_location = get_wml_location("maps/" + name); if(!map_location.empty()) { res = read_file(map_location); } if (res.empty()) { res = read_file(get_user_data_dir() + "/editor/maps/" + name); } 20180518 02:16:06< celticminstrel> Uhh. 20180518 02:16:08< celticminstrel> What. 20180518 02:16:10<+discordbot> doesn't seem to be working though 20180518 02:16:16< celticminstrel> That's just. 20180518 02:16:18< celticminstrel> Dumb? 20180518 02:16:31< celticminstrel> Why prefix anything to the path? 20180518 02:16:34-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180518 02:16:42<+discordbot> this is filesystem::read_map 20180518 02:16:54-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 260 seconds] 20180518 02:17:21< celticminstrel> I'd say that if map_location.empty() returns true it should also try without the maps/ prefix. 20180518 02:17:42< celticminstrel> That said... it'll still work for the vast majority of people, I guess? So low priority. 20180518 02:18:16< celticminstrel> Also, it's not documented so we could probably just remove the need for a prefix altogether and break compatibility (just make sure LoW isn't using it first though). 20180518 02:18:45< celticminstrel> Actually, if you do want to maintain compatibility it's probably better to try first without the prefix and then with it. 20180518 02:21:24< celticminstrel> https://wiki.wesnoth.org/index.php?title=MapLocalization&curid=5237&diff=59643&oldid=57962 20180518 02:21:30<+discordbot> wha 20180518 02:21:33< celticminstrel> Sounds like some script might need updating? 20180518 02:21:35<+discordbot> did I not fix the textdomain change? 20180518 02:21:41< celticminstrel> Oh, you're nemaara? 20180518 02:21:44<+discordbot> err textdomain and path to the map 20180518 02:21:46<+discordbot> yah 20180518 02:21:51< celticminstrel> Huh, I had no idea. 20180518 02:22:51<+discordbot> oh you commented on the commit previous to the latest one, I think 20180518 02:23:06< celticminstrel> I only commented on the diff that GitHub showed me in the notifications... 20180518 02:23:19< celticminstrel> Did you forget to push the latest commit? 20180518 02:23:35<+discordbot> should be pushed... 20180518 02:24:05< celticminstrel> Maybe GitHub is just being weird. 20180518 02:24:13<+discordbot> idk what's wrong 20180518 02:24:25<+discordbot> it ALWAYS tries to load editor/maps 20180518 02:24:28<+discordbot> well anyway -thot is the right textdomain 20180518 02:24:32< celticminstrel> Yeah, looks like you did fix it. 20180518 02:24:39< celticminstrel> I don't know why GitHub didn't show me that. 20180518 02:24:43<+discordbot> 🤷 20180518 02:24:46<+discordbot> looks like the first part fails 20180518 02:24:49< celticminstrel> I guess it expects me to click "next' or something? I dunno. 20180518 02:24:57<+discordbot> std::string map_location = get_wml_location("maps/" + name); 20180518 02:25:22< celticminstrel> @Vultraz, I kinda have a feeling that that might require the map to be at "data/maps/the_rest_of_the_path"? 20180518 02:25:37< celticminstrel> Try putting it there as a test. 20180518 02:26:46<+discordbot> yes 20180518 02:26:53<+discordbot> wesnoth/data/maps/map.map 20180518 02:26:54<+discordbot> works 20180518 02:27:03<+discordbot> so this check is wrong 20180518 02:30:14< celticminstrel> IMO, just forget about adding a prefix and call get_wml_location on just the name alone. 20180518 02:30:48<+discordbot> I tried that 20180518 02:30:50<+discordbot> it fails 20180518 02:30:54<+discordbot> umc and core 20180518 02:30:55< celticminstrel> What's name? 20180518 02:31:10< celticminstrel> And where exactly is the map? 20180518 02:31:24<+discordbot> for core i tried map_file="01_Saving_Parthyn.map" in DiD s1 20180518 02:31:31<+discordbot> and the map is in DiD/maps 20180518 02:31:32< celticminstrel> Uhh. 20180518 02:32:00< celticminstrel> If you're calling get_wml_location then you'd need "campaigns/DiD_expanded/maps/01_Saving_Parthyn.map". 20180518 02:32:19< celticminstrel> If you want "01_Saving_Parthyn.map" to work, you need to use the binary paths API instead of get_wml_location. 20180518 02:32:52< celticminstrel> (Of course, if you use the binary paths API then all maps need to go in maps/ in the particular addon/campaign folder. 20180518 02:32:55< celticminstrel> ) 20180518 02:33:15<+discordbot> map_file="campaigns/Descent_Into_Darkness/maps/01_Saving_Parthyn.map" also fails 20180518 02:33:27< celticminstrel> Hmm. 20180518 02:33:40<+discordbot> perhaps i should try loading the path as given first? 20180518 02:33:53< celticminstrel> So if you use map_data, then that's the path that works, right? 20180518 02:34:05<+discordbot> it's preprocessed 20180518 02:34:15< celticminstrel> But it's still expressed as a path in the WML. 20180518 02:34:25< celticminstrel> And loaded by the preprocessor. 20180518 02:34:32<+discordbot> yes 20180518 02:34:36< celticminstrel> And that path works? 20180518 02:35:02<+discordbot> preprocessed, yes 20180518 02:35:15< celticminstrel> Okay so... if you use get_wml_location(name) instead of what was there before, that path doesn't work? 20180518 02:40:10<+discordbot> std::string map_location = get_wml_location(name); works 20180518 02:40:24-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20180518 02:40:35<+discordbot> with map_file="campaigns/Descent_Into_Darkness/maps/01_Saving_Parthyn.map" 20180518 02:40:41< celticminstrel> \o/ 20180518 02:41:45<+discordbot> also with map_file=~add-ons/Shadows_of_Deception/episode1/maps/00_Descry.map 20180518 02:41:48<+discordbot> for my campaig 20180518 02:41:52<+discordbot> before it did not 20180518 02:43:05<+discordbot> maybe we should just go with this? 20180518 02:43:19<+discordbot> to make transition easier if we deprecate map_data for some reason 20180518 02:43:39< celticminstrel> There's really no need to deprecate map_data. 20180518 02:43:55<+discordbot> Lua Cave Generator failed in the cave scenario of HttT. 20180518 02:44:47< celticminstrel> ...I remember mattsc looking at that, did he fix it? 20180518 02:45:01<+discordbot> yes 20180518 02:45:14< celticminstrel> Anyway, it should work if you try again once or twice. 20180518 02:45:26<+discordbot> @Lupin Yeah, it's fixed already: https://github.com/wesnoth/wesnoth/commit/09787796161 20180518 02:45:37<+discordbot> @mattsc btw, when could we remove the FAI engine? 20180518 02:46:12< celticminstrel> @Vultraz Same as when we could remove anything else - after it's been deprecated officially for at least one stable series. 20180518 02:46:26<+discordbot> how do you deprecate a whole engine 20180518 02:46:31< celticminstrel> I'm not in favour of deprecating it ATM. 20180518 02:46:33< celticminstrel> ... 20180518 02:46:44<+discordbot> I mean, practically 20180518 02:46:44< celticminstrel> What a pointless question. 20180518 02:46:48<+discordbot> where do you put th enotice 20180518 02:47:25< celticminstrel> Well, the engine basically consists of four or five AI components, so... just deprecate those individually? 20180518 02:47:42< celticminstrel> But like I said, I don't see it as being ready for deprecation. 20180518 02:47:51< celticminstrel> I want to see a few more things added to Lua first. 20180518 02:48:15<+discordbot> it's unmaintained 20180518 02:48:24<+discordbot> @Vultraz celmin is going to bring up unit formulas 😃 20180518 02:48:31< celticminstrel> "unmaintained" 20180518 02:48:35<+discordbot> the wiki says so 20180518 02:48:51<+discordbot> The wiki is wrong. 20180518 02:48:55<+discordbot> 😐 20180518 02:49:00< celticminstrel> There's no maintenance to do on it AFAIK, so... 20180518 02:49:12< celticminstrel> If there was something that needed doing I could look at it. 20180518 02:49:13<+discordbot> what is this about unit formulas 20180518 02:49:22< celticminstrel> There's no Lua equivalent. 20180518 02:49:29< celticminstrel> You can get the same effect, sure. 20180518 02:49:35<+discordbot> [unit] [ai] formula=? 20180518 02:49:40< celticminstrel> But I like the convenience of unit_formulas. 20180518 02:49:42< celticminstrel> Yes. 20180518 02:50:08<+discordbot> @Lupin As celmin said, you should just be able to make the scenario work by reloading it a couple times 20180518 02:50:10<+discordbot> shadowm uses that, but she can just use the stationed guardian micro ai. 20180518 02:50:25<+discordbot> I think? 20180518 02:50:33<+discordbot> That's what you say at least. 20180518 02:50:34< celticminstrel> Micro AIs are nice if you need to control a set of units. 20180518 02:50:46< celticminstrel> But what if you want to give specific instructions to a single unit? 20180518 02:50:54<+discordbot> I'm not going to look into this any time soon though. 20180518 02:51:18<+discordbot> I'd rather get things working for 1.14 first and then bother with rewriting stuff to be 1.16-proof. 20180518 02:51:26<+discordbot> I see 20180518 02:52:36<+discordbot> celmin: well, if it's REALLY important, it should be converted to Lua because having separate syntax for that just makes things confusing. 20180518 02:52:50< celticminstrel> ... 20180518 02:52:58<+discordbot> It's not any more confusing than using WFL in WML. 20180518 02:53:04< celticminstrel> I was envisioning something akin to [unit] [ai] code = <<>> 20180518 02:53:05<+discordbot> Which I must mention is really nice. 20180518 02:53:13< celticminstrel> Hmm? 20180518 02:53:20< celticminstrel> You mean in $(...) or somewhere else? 20180518 02:53:29<+discordbot> In $(), yes. 20180518 02:54:17<+discordbot> oh yeah 20180518 02:54:27<+discordbot> celmin: we can't use #deprecated in MENU_IMG_TXT 20180518 02:54:39<+discordbot> the preprocessor breaks 20180518 02:54:46<+discordbot> because that's used as a key value 20180518 02:54:49< celticminstrel> Isn't that a bug, then? 20180518 02:55:05< celticminstrel> IOW it should be fixed in the preprocessor. 20180518 02:55:08<+discordbot> not oneI know how to fix 20180518 02:55:08<+discordbot> No, that sounds like it's working as intended. 20180518 02:55:21< celticminstrel> Maybe I forgot to discard the newline when I implemented #deprecated 20180518 03:05:57-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180518 03:06:03-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180518 03:53:51< irker394> wesnoth/wesnoth:master Nils Kneuper 7877bc3ef4 updated Italian translation AppVeyor: All builds passed 20180518 04:01:21<+discordbot> @Vultraz I get src/server/server.cpp:1818:6: error: no previous prototype for function 'handle_send_to_player' [-Werror,-Wmissing-prototypes] void handle_send_to_player(socket_ptr socket) when trying to build with Xcode. 20180518 04:01:30<+discordbot> Very odd 20180518 04:01:41<+discordbot> Travis hasn’t complained 20180518 04:01:53<+discordbot> I know I could just diable the warning->error setting, but ... 20180518 04:02:00<+discordbot> I did move that function around in that file 20180518 04:02:19<+discordbot> That's why I am pinging you. 20180518 04:02:34<+discordbot> Try doing the same swap in the header 20180518 04:03:01<+discordbot> Uh, okay, I can try. Does that really matter? 20180518 04:03:24<+discordbot> It shouldn’t 20180518 04:03:33<+discordbot> That’s what’s weird 20180518 04:04:45< celticminstrel> Uh, that error means there's no prototype. 20180518 04:04:56< celticminstrel> Which basically means you need to declare the function separately from defining it. 20180518 04:05:01<+discordbot> Right. I don't have that function in the .hpp 20180518 04:05:05< celticminstrel> (Which is a little silly IMO if it's a local function.) 20180518 04:05:20< celticminstrel> Presumably, there's a prototype somewhere in the cpp which is no longer before the definition. 20180518 04:05:59<+discordbot> well that is just stupid... 20180518 04:06:03<+discordbot> STUPID, I say 20180518 04:06:11<+discordbot> what id you put it in an anon namespace? 20180518 04:06:35< celticminstrel> I kinda agree when it comes to static/anon-namespace functions that are local to a specific file, though I suppose having a prototypes section at the top of the file could be seen as convenient. 20180518 04:06:38<+discordbot> (I'm guessing you either have a really new or really old version of xcode) 20180518 04:06:39<+discordbot> @Vultraz I am out of my depth here. I don't know what that means. 20180518 04:06:56< celticminstrel> If you put it in an anon namespace then the prototype obviously also needs to be in an anon namespace. 20180518 04:06:56<+discordbot> I'm just reporting what Xcode tells me. 😛 20180518 04:07:17<+discordbot> celmin: I've never had to declare static/anon functions separately 20180518 04:07:20< celticminstrel> mattsc: Is there a declaration of handle_send_to_player somewhere that doesn't have a function body? 20180518 04:07:25<+discordbot> @Vultraz Nope. Pretty new, but not really new. 20180518 04:07:27<+discordbot> celmin: I removed that 20180518 04:07:40< celticminstrel> @Vultraz Obviously, because it's not required. And if you removed that, obviously that's why we're getting this error. 20180518 04:07:49<+discordbot> celmin: No, I checked for that. 20180518 04:07:55< celticminstrel> Don't go removing things without understanding the reason why they were there! 20180518 04:07:58<+discordbot> celmin: so why in hell is it required here 20180518 04:08:03< celticminstrel> It's not required. 20180518 04:08:09<+discordbot> WHAT 20180518 04:08:13<+discordbot> you just said... 20180518 04:08:17< celticminstrel> It's merely recommended, which is why this is a WARNING and not an ERROR. 20180518 04:08:33< celticminstrel> As you can tell from the -W stuff in the error message. 20180518 04:08:45< celticminstrel> (And the -Werror part means the warning has been promoted to error level._ 20180518 04:08:50< celticminstrel> ^) 20180518 04:08:51<+discordbot> are you saying it's "recommended" to declare every single damn function, static or anonymous, before implementing it?? 20180518 04:09:01< celticminstrel> Yeah. 20180518 04:09:02<+discordbot> Just that Xcode barfs at warnings (and yes, I do know how to turn that off) 20180518 04:09:05<+discordbot> WHAT 20180518 04:09:06<+discordbot> THE 20180518 04:09:07<+discordbot> FUCK 20180518 04:09:28< celticminstrel> I mean, there's sorta something to be said for having a prototype section at the top of the file (it's a bit like a ToC), but... 20180518 04:09:40<+discordbot> We've always had strict compiling (is that what it's called?) set for the Xcode project. 20180518 04:09:51<+discordbot> always = ever since I've known anything about it 20180518 04:09:54< celticminstrel> I think strict compilation might be something else? 20180518 04:09:54<+discordbot> I usually put the anon functions at the top anyway 20180518 04:10:01<+discordbot> but fully implemented right away 20180518 04:10:03< celticminstrel> Like there might actually be something like a -fstrict flag? 20180518 04:10:16< celticminstrel> Not sure though. 20180518 04:10:19<+discordbot> @mattsc remove -Wmissing-prototypes 20180518 04:10:27<+discordbot> Maybe. "treat warnings as errors" or such 20180518 04:10:35< celticminstrel> Yeah, that's -Werror. 20180518 04:10:38<+discordbot> yeah that sounds really bizarre to me. There is no reason for a declaration of a function in an unnamed namespace (unless you want to use it before its definition but this is unlikely) 20180518 04:10:43< celticminstrel> In the past, people have actually added the prototype when they found this case. 20180518 04:10:44<+discordbot> so I recommend turning that warning off. 20180518 04:10:45<+discordbot> @Vultraz: as I said, I know how to turn this off. 20180518 04:10:59<+discordbot> But then my Xcode project diverges from the Wesnoth version. 20180518 04:11:06<+discordbot> commit it 20180518 04:11:14< celticminstrel> I personally think it's better to disable it (at least for static functions), but you want to make sure it's done for all build methods. 20180518 04:11:24< celticminstrel> Which means scons and cmake as well. 20180518 04:11:37<+discordbot> there were NO problems with other build systems 20180518 04:11:41< celticminstrel> (AFAIK cl.exe doesn't have this warning? Or at least is not set up to use it in the Wesnoth project?) 20180518 04:11:41<+discordbot> including XCode on travis 20180518 04:11:44<+discordbot> when I made that change 20180518 04:11:52< celticminstrel> Pretty sure I've seen these warnings pop up on Travis before. 20180518 04:12:15< celticminstrel> Though it's possible @Pentarctagon did something about that? I dunno. 20180518 04:12:26< celticminstrel> He's been doing a lot of build script changes lately. 20180518 04:12:37<+discordbot> @hrubymar10 ^ I'll let you do this for the official version (unless there's a reason why you want me to do it) 20180518 04:13:02< celticminstrel> Don't disable "treat warnings as errors" though, just disable the one specific warning. 20180518 04:13:10<+discordbot> Yep. 20180518 04:13:37< celticminstrel> (I mean, I don't much like the "treat warnings as errors" flag either, but there's no real point in removing it when the project's already warning-free.) 20180518 04:13:41<+discordbot> as dave said, the only reason to declare an anon function before implementing it is to use it before you implement it 20180518 04:13:47<+discordbot> of which I have seen legit cases of 20180518 04:13:58<+discordbot> but this was just stupid 20180518 04:13:59< celticminstrel> (Some warnings are also things which might be better off as errors, too.) 20180518 04:14:10<+discordbot> you had a function declaration 20180518 04:14:20<+discordbot> then a like, 10-like function 20180518 04:14:23<+discordbot> and then its implementation 20180518 04:14:32<+discordbot> another 10-line* 20180518 04:14:32< celticminstrel> @Vultraz, FTR, there are probably quite a few cases in Wesnoth where you have a function declaration directly followed by the definition, just to stave off this warning. 20180518 04:14:42<+discordbot> yeah the times you do that are really rare. 20180518 04:14:48< celticminstrel> I guess it's not really very searchable though... 20180518 04:14:52<+discordbot> I agree with celticminstrel though that just remove that one specific warning 20180518 04:15:00<+discordbot> celmin: tad committed one such thing... 20180518 04:15:04<+discordbot> dunno if it was removed 20180518 04:15:25< celticminstrel> OH right, Denivarius was Dave, right? 20180518 04:15:34<+discordbot> yes, he is 20180518 04:15:42< celticminstrel> IMO it'd be better if you just called him Denivarius. 20180518 04:15:48<+discordbot> @Denivarius @Vultraz celticminstel: okay, will do (well, as I said, I'll let @hrubymar10 do it) 20180518 04:15:55<+discordbot> "Dave" is easier to type 😛 20180518 04:15:56< celticminstrel> Then the people who don't know that will also know what you're talking about. 20180518 04:16:09< celticminstrel> ...are you seriously telling me Discord doesn't have tab-completion for nicknames? o.O 20180518 04:16:17<+discordbot> it does 20180518 04:16:24< celticminstrel> You forgot the R in my name BTW mattsc. :P 20180518 04:16:34<+discordbot> but only to ping them 20180518 04:16:49< celticminstrel> ... 20180518 04:16:54< celticminstrel> That sounds... a bit useless? 20180518 04:16:58<+discordbot> no? 20180518 04:17:03< celticminstrel> I guess that's another reason not to bother with Discord. 20180518 04:17:10<+discordbot> oh,shut up 20180518 04:17:12<+discordbot> >_> 20180518 04:17:19< celticminstrel> I mean I guess you could tab-complete it, then delete the @ or something. 20180518 04:17:26< celticminstrel> But that kinda defeats the point of tab-completion. 20180518 04:17:29<+discordbot> celmin: that's because I am on the evil empire side at the moment and actually have to type it 😛 20180518 04:17:37<+discordbot> you do realize discord nicks are different from IRC nicks 20180518 04:17:37< celticminstrel> XD 20180518 04:17:44<+discordbot> they're not just text 20180518 04:17:48< celticminstrel> I don't particularly care if they're different? 20180518 04:17:53< celticminstrel> How are they not just text? 20180518 04:18:02< celticminstrel> And before you say "emoji" those are text too. 20180518 04:18:24<+discordbot> display name isn't always the nick 20180518 04:18:34< celticminstrel> I don't really see how that matters. 20180518 04:18:41<+discordbot> in cases like mine it is: Vultraz#6264 20180518 04:18:47<+discordbot> and there's that UID bit at the end 20180518 04:18:58< celticminstrel> Reminds me of battle.net. 20180518 04:19:03<+discordbot> to differentiate users with the same display name 20180518 04:19:13<+discordbot> it doesn't display outside the tab completion popup 20180518 04:19:19< celticminstrel> Allowing multiple users with the same display name is kinda dumb though. 20180518 04:19:41< celticminstrel> Even if they have avatars or something to differentiate them. 20180518 04:19:43<+discordbot> when typing a message tab completion fills out the username + UID 20180518 04:19:53<+discordbot> but its displayed as the display name 20180518 04:20:04< celticminstrel> Ick. 20180518 04:20:44<+discordbot> so, while shadowm is displayed as "shadowm" in pings and in the sidebar, when writing a message to her it's @ShikadiQueen#1903 in raw form 20180518 04:21:20< celticminstrel> Like I said, ick. 20180518 04:21:22<+discordbot> in text* 20180518 04:21:27<+discordbot> it's not ick 20180518 04:21:32< celticminstrel> Totally is. 20180518 04:21:47<+discordbot> 🙄 20180518 04:22:01< celticminstrel> You should try to remember that I can't even see half the emoji. 20180518 04:22:07< celticminstrel> (Yes that one's a box too) 20180518 04:22:20< celticminstrel> I mean if you're not actually talking to me, fine, but... 20180518 04:22:29<+discordbot> it's :rolling_eyes: 20180518 04:22:40< celticminstrel> What's wrong with 9_9 then 20180518 04:22:50<+discordbot> because that's not an emoji 20180518 04:23:05<+discordbot> that's an emote 20180518 04:23:23<+discordbot> emote/emoticon/whatever you want to call it 20180518 04:24:13<+discordbot> yeah actually the lack of non-@ tab completion in Discord is pretty annoying 20180518 04:24:19<+discordbot> I'm not sure why they don't have it. 20180518 04:24:24< celticminstrel> The difference is pretty irrelevant TBH. 20180518 04:24:41< celticminstrel> (emoticon vs emoji I mean) 20180518 04:24:54<+discordbot> it's very relevant 20180518 04:24:58<+discordbot> one is not the other 20180518 04:25:12< celticminstrel> There's no real difference except from a technical standpoint. 20180518 04:25:22< celticminstrel> They both serve the same purpose. 20180518 04:25:33<+discordbot> especially since on discord you can have image-based custom emoji 20180518 04:25:35<+discordbot> like 20180518 04:25:39<+discordbot> Discord has so many users on lots of servers that it would be pretty awkward to ban display name collisions. 20180518 04:25:43<+discordbot> :bhammer: 20180518 04:25:55< celticminstrel> Yeah on phpBB those are called emoticons. 20180518 04:25:57< celticminstrel> So uh. 20180518 04:26:06< celticminstrel> That kinda supports that they're basically the same thing. 20180518 04:26:16< celticminstrel> (At least, I'm pretty sure they are.) 20180518 04:26:24< celticminstrel> (Called that on phpBB I mean.) 20180518 04:26:28<+discordbot> emoticons are symbols made of text 20180518 04:26:36<+discordbot> emoji are special unicode charaters 20180518 04:26:47<+discordbot> I had thought that the two things were synonymous 20180518 04:26:52< celticminstrel> So what do you call your favourite shrug? 20180518 04:27:07< celticminstrel> I can't type it myself because I have no way to produce an overbar I think? 20180518 04:27:10<+discordbot> ASCII art 20180518 04:27:11< celticminstrel> Or maybe I can? 20180518 04:27:25<+discordbot> discord has a dedicated command for it 20180518 04:27:27<+discordbot> /shrug 20180518 04:27:30<+discordbot> ¯_(ツ)_/¯ 20180518 04:27:32< celticminstrel> ̄\_o_/ ̄ 20180518 04:27:35< celticminstrel> Close enough. 20180518 04:27:58< celticminstrel> Except that's the combining macron, it should be the spacer macron. Oh well. And I didn't bother with the kana because I wasn't sure which one it was. 20180518 04:28:02<+discordbot> but yeah looking it up Vultraz is correct. 20180518 04:28:33< celticminstrel> FTR I looked it up too. 20180518 04:28:44< celticminstrel> (What kana is that BTW? It's not n is it?) 20180518 04:29:18<+discordbot> I can't remember 😦 20180518 04:29:24<+discordbot> could be Shi 20180518 04:30:36<+discordbot> anyway, emotes and emoji are both ideogramic characters, but emoji are pictographic 20180518 04:30:48< celticminstrel> Ah, you're right, it's katakana shi. 20180518 04:31:03<+discordbot> hey, I was right! \o/ 20180518 04:31:50< celticminstrel> ANYWAY 20180518 04:32:06< celticminstrel> I was gonna go to bed half an hour ago before I got distracted by all this, so good night. 20180518 04:32:30<+discordbot> 💤 20180518 04:32:35< celticminstrel> ...oh right I can get the spacer macron with option+a followed by space. 20180518 04:32:41< celticminstrel> ¯\_o_/¯ 20180518 04:32:50< celticminstrel> Kana is too much work so whatever. 20180518 04:33:03< celticminstrel> (Also hey apparently I have the Zzz emoji, nice.) 20180518 04:33:12< celticminstrel> (Or should that be zzZ) 20180518 04:34:06-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has left #wesnoth-dev [] 20180518 04:38:37<+discordbot> @Vultraz BTW, I am going to make a PR out of the Experimental_AI on Dark Forecast fix. 20180518 04:38:45<+discordbot> It's a bit more complex than I anticipated. 20180518 04:39:02<+discordbot> Well, the fix itself is easy enough, but it brought to light a couple other issues. 20180518 04:39:23<+discordbot> Shouldn't be a problem to get it done before 1.14.2 though 20180518 04:40:17<+discordbot> And that's the last thing I have on my list for 1.14.2 (well, except for the changelog) 20180518 05:04:05-!- higgins [~higgins@68.ip-149-56-14.net] has quit [Quit: Leaving] 20180518 05:15:25-!- higgins [~higgins@68.ip-149-56-14.net] has joined #wesnoth-dev 20180518 05:25:44-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180518 05:26:58-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20180518 05:27:54<+discordbot> @mattsc It's not something I've done, but 1.14's and master's xcode job has -Wno-missing-prototypes 20180518 05:28:19-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180518 05:28:59-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20180518 05:30:42-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180518 05:30:56<+discordbot> it also has -Werror=format -Werror=missing-braces -Werror=return-type -Werror=missing-field-initializers -Werror=sign-compare -Werror=unused -Werror=switch rather than just -Werror like the strict-enabled travis jobs do. 20180518 05:47:49-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180518 05:47:54-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20180518 05:47:55-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180518 06:23:16<+discordbot> Yes, somebody before me (as maintainer) mutted all warnings in Xcode project 20180518 06:23:45<+discordbot> I can turn them on or turn part of them on 20180518 06:24:11<+discordbot> @Pentarctagon which one should I turn on? All of them? 20180518 06:26:00<+discordbot> It is also question for @mattsc ^^ 20180518 06:28:01<+discordbot> If -Wall is available, please use it. 20180518 06:31:32<+discordbot> It was mentioned by someone previously that planning mode shouldn’t be P, and I heartily agree. Should the hot key for planning mode be Alt + P? 20180518 06:39:45<+discordbot> Wouldn't -Wall include the warning we don't want 20180518 06:39:56<+discordbot> @ancestral sounds alright 20180518 06:42:48<+discordbot> @hrubymar10 Ultimately, what warnings are enabled shouldn't be decided by me. I'll make proposals(such as the -Wtrampolines PR), but it's really up to the people doing the programming what warnings/errors should be checked for. 20180518 06:44:05<+discordbot> -Wall doesn't enable all warnings, unlike its name suggests. 20180518 06:44:06<+discordbot> though my opinion, at least, is that it would be beneficial to enable plain -Werror on xcode as well. I don't think anyone's combing the travis logs just for warnings it reports. 20180518 06:44:13<+discordbot> Ok, I can better disable some of these: 20180518 06:44:13<+discordbot> https://cdn.discordapp.com/attachments/259976436490829825/446925959950630912/unknown.png 20180518 06:44:21<+discordbot> And we can combine it with explicitly disabling warnings we don't want. 20180518 06:44:38<+discordbot> some of those are useful 20180518 06:44:55<+discordbot> so just enabling a warning by itself isn't very useful, since chances are it won't be seen among wesnoth's hundreds of source files. 20180518 06:45:10<+discordbot> https://cdn.discordapp.com/attachments/259976436490829825/446926201261654017/unknown.png 20180518 06:45:26<+discordbot> also useful 20180518 06:45:27<+discordbot> It would be better to remove all -Werror=* switches and replace them with -Werror. 20180518 06:45:43<+discordbot> -Werror on its own turns all enabled warnings to errors. 20180518 06:47:16<+discordbot> holy crap does xcode have a lot of warnings disabled though. xD from travis: -Wno-trigraphs -fpascal-strings -Wno-missing-field-initializers -Wno-missing-prototypes -Wno-return-type -Wno-non-virtual-dtor -Wno-overloaded-virtual -Wno-exit-time-destructors -Wno-missing-braces -Wparentheses -Wswitch -Wno-unused-function -Wno-unused-label -Wno-unused-parameter -Wno-unused-variable -Wunused-value -Wno-empty-body -Wno-uninitialized 20180518 06:47:16<+discordbot> -Wno-unknown-pragmas -Wno-shadow -Wno-four-char-constants -Wno-conversion -Wno-constant-conversion -Wno-int-conversion -Wno-bool-conversion -Wno-enum-conversion -Wno-float-conversion -Wno-non-literal-null-conversion -Wno-objc-literal-conversion -Wno-shorten-64-to-32 -Wno-newline-eof -Wno-c++11-extensions 20180518 06:48:41<+discordbot> didn't one of the newer c++ standards forbid trigraphs? 20180518 06:49:07<+discordbot> Yep, they were removed in C++17. 20180518 06:50:18<+discordbot> which, we do have a c++17 job that succeeds, so -Wno-trigraphs can definitely be removed. 20180518 06:51:16<+discordbot> Is that known? /Users/user/xcode/wesnoth_1.14/src/server/server.cpp:1818:6: No previous prototype for function 'handle_send_to_player' 20180518 06:52:51<+discordbot> it has -Wno-missing-prototypes up there, so not sure why it's even showing up 20180518 06:52:54<+discordbot> yes , remove that warning 20180518 06:53:23-!- Oebele [~quassel@143.177.58.202] has joined #wesnoth-dev 20180518 06:53:52<+discordbot> I removed -Wno-missing-prototypes, that's why it is shown 20180518 06:54:09-!- irker394 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout] 20180518 06:54:17<+discordbot> oh, well we don't want it to show 20180518 06:59:22<+discordbot> the travis osx+scons job has this by comparison: -Wall -Wextra -Werror=non-virtual-dtor -Qunused-arguments -Wno-unknown-warning-option -Wmismatched-tags -Wno-conditional-uninitialized -Wno-unused-local-typedefs -Wno-maybe-uninitialized -Wtrampolines -Werror 20180518 07:00:15<+discordbot> and IIRC -Qunused-arguments is just to suppress warnings from any gcc-specific flags 20180518 07:00:40<+discordbot> That set of options looks very reasonable to me. 20180518 07:01:06<+discordbot> could probably get rid of -Werror=non-virtual-dtor as redundant. 20180518 07:01:36<+discordbot> it's specifically enabled even for non-strict builds 20180518 07:01:45<+discordbot> but strict is checked on travis anyway 20180518 07:05:33<+discordbot> missed a few more from xcode: -Wdeprecated-declarations -Winvalid-offsetof -Wno-sign-conversion -Wno-infinite-recursion -Wno-move -Wno-comma -Wno-block-capture-autoreleasing -Wno-strict-prototypes -Wno-range-loop-analysis 20180518 07:06:34<+discordbot> -Wno-unused-local-typedefs -Wno-unused-private-field 20180518 07:14:52<+discordbot> How does attack accuracy and parry work? 20180518 07:19:36-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20180518 08:10:17<+discordbot> my std::filesystem bug got marked Needs More Info... 😐 20180518 08:11:13<+discordbot> "For us to investigate this further, could you please provide us your reproduce solution or a project?" 20180518 08:11:26<+discordbot> bah! 20180518 08:11:36<+discordbot> are they asking for a testcase 20180518 08:12:35< Soliton> i would think so. 20180518 08:12:46<+discordbot> Well, we are an open source project. We have the option to simply link to the repository (although it's not good for MSVC developers). 20180518 08:12:46<+discordbot> @Vultraz the disambiguation suffix at the end of usernames is not by any means unique (you can even customize it if you've got Nitro). 20180518 08:13:01<+discordbot> @shadowm i see 20180518 08:13:18< Soliton> usually a minimal test case is preferred but just pointing at wesnoth might be enough. 20180518 08:13:18<+discordbot> The actual uid is a 64-bit integer you don't normally see. 20180518 08:13:54<+discordbot> It's quite strange to ask a test case about a "C++ standard library doesn't allow us to do X" problem... 20180518 08:14:06<+discordbot> @jyrkive exactly... 20180518 08:14:16<+discordbot> I don't see how I could have been more clear 20180518 08:14:36<+discordbot> Is there a public link to the bug in question out of curiosity? 20180518 08:14:42<+discordbot> https://developercommunity.visualstudio.com/content/problem/251213/stdfilesystemfile-time-type-does-not-allow-easy-co.html 20180518 08:14:54<+discordbot> It's a problem with the VS implementation of std::filesystem 20180518 08:15:27<+discordbot> That renders it useless for our (and probably many other people's) purposes 20180518 08:16:24<+discordbot> reads more like a form response than anything, to be honest. 20180518 08:16:41<+discordbot> indeed 20180518 08:17:17<+discordbot> a practical example is I cannot do this: cpp auto mtime = std::filesystem::last_write_time(fs::path(fname)); std::time_t = decltype(mtime)::clock::to_time_t(mtime); 20180518 08:17:35<+discordbot> Yeah. It might still be useful to write a small program showcasing the issue (even if it doesn't compile given its nature). 20180518 08:17:44<+discordbot> cppreference has this example, but notes it's predicated on clock being system_clock 20180518 08:18:47<+discordbot> Hell, they could probably just use the example program on cppreference and it wouldn't work. 20180518 08:40:48-!- irker412 [~irker@uruz.ai0867.net] has joined #wesnoth-dev 20180518 08:40:48< irker412> wesnoth/wesnoth:master nemaara 4baec42ed2 Fixed map path and textdomain AppVeyor: All builds passed 20180518 10:18:00-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180518 10:18:06-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180518 10:27:15<+discordbot> Funny. When I run Wesnoth in Steam, open the log by clicking "open log file" in the game, and then close the game, Steam things the game is still running as long as the log file is still open in text editor. 20180518 10:27:57<+discordbot> Might be that keeping the file open blocks Wesnoth from exiting. 20180518 10:28:04<+discordbot> Which operating system do you use? 20180518 10:41:14-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180518 10:41:20-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180518 10:47:14<+discordbot> Win 10 20180518 10:47:33<+discordbot> 64 Bit, if that matters 20180518 11:25:30<+discordbot> You could check in Task Manager if Wesnoth shows up in Background processes when it's in that state (closed, but Steam says that it's still running). 20180518 11:41:57-!- irker412 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout] 20180518 11:46:42<+discordbot> it seems the only process that closes when closing the editor is, well, the editor. Can't find any other process connected to that. 20180518 11:47:04<+discordbot> Though, there are quite a few, maybe I am missing it. But nothing called wesnoth or something for sure. 20180518 11:47:27<+discordbot> I see. It's probably Steam's fault, then. 20180518 11:48:21<+discordbot> If Wesnoth launches notepad.exe or whatever, Steam might think that it's part of Wesnoth. 20180518 11:48:47<+discordbot> To accommodate for games that have a main menu launcher in a separate EXE or something like that. 20180518 12:34:09-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180518 12:34:15-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180518 12:55:24-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: mattsc] 20180518 13:02:25-!- atarocch [~atarocch@93.56.164.28] has quit [Quit: Leaving] 20180518 13:02:45-!- atarocch [~atarocch@93.56.164.28] has joined #wesnoth-dev 20180518 13:06:12-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev 20180518 13:08:16<+discordbot> @hrubymar10 I'm really not the right person to decide which warnings should be active etc. I'm just reporting the error I got. So whatever the others suggest is fine by me. 20180518 14:38:06<+discordbot> Maybe I should turn off warnings for liblua in Xcode project as we can't do anything for it, can we? 20180518 14:38:46<+discordbot> yeah, we aren't editing the lua source. 20180518 14:39:15<+discordbot> unless absolutely necessary 20180518 14:40:16<+discordbot> kk 20180518 14:44:49-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: mattsc] 20180518 14:46:58<+discordbot> I decided to make RELEASE build scheme in Xcode as much as possible warning free but I'll treat all warnings in DEBUG scheme 20180518 14:47:34<+discordbot> for example there is 1 warning in RELEASE scheme for wesnothd but 265 warnings in DEBUG scheme 20180518 14:47:55<+discordbot> I can turn off some of them ofc 20180518 14:49:40-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180518 14:55:21-!- matthiaskrgr [matthiaskr@gateway/shell/panicbnc/x-owhgrvgjvqscyqvs] has quit [Ping timeout: 240 seconds] 20180518 14:56:29-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer] 20180518 14:56:38-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180518 15:06:18-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev 20180518 15:12:38-!- mkdroid [~null@unaffiliated/matthiaskrgr] has joined #wesnoth-dev 20180518 15:13:30-!- mkdroid [~null@unaffiliated/matthiaskrgr] has quit [Remote host closed the connection] 20180518 15:17:48-!- matthiaskrgr [matthiaskr@gateway/shell/panicbnc/x-wsodsbasokaywrlo] has joined #wesnoth-dev 20180518 15:18:13-!- matthiaskrgr is now known as Guest11178 20180518 15:19:06-!- Guest11178 [matthiaskr@gateway/shell/panicbnc/x-wsodsbasokaywrlo] has quit [Changing host] 20180518 15:19:06-!- Guest11178 [matthiaskr@unaffiliated/matthiaskrgr] has joined #wesnoth-dev 20180518 15:19:06-!- Guest11178 [matthiaskr@unaffiliated/matthiaskrgr] has quit [Changing host] 20180518 15:19:06-!- Guest11178 [matthiaskr@gateway/shell/panicbnc/x-wsodsbasokaywrlo] has joined #wesnoth-dev 20180518 15:19:36-!- Guest11178 is now known as matthiaskrgr_ 20180518 15:50:38-!- DeFender1031 [~DeFender1@89-138-79-9.bb.netvision.net.il] has quit [Quit: I'm not back now.] 20180518 15:57:05-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 276 seconds] 20180518 16:23:39-!- irker457 [~irker@uruz.ai0867.net] has joined #wesnoth-dev 20180518 16:23:40< irker457> wesnoth: Iris Morelle website:master 97b01bef6159 / start/1.14/ (index.en.html index.es.html index.it.html index.ja.html index.var po/es.po): announcement/1.14: Add Spanish translation https://github.com/wesnoth/website/commit/97b01bef61590720b614c8fc262893272e175ebc 20180518 16:47:57-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Quit: wedge009] 20180518 16:50:57-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev 20180518 16:52:06-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev 20180518 17:01:40<+discordbot> @Vultraz Would you be opposed to adding the "i" button to access the version dialog to the bottom left corner of Preferences? 20180518 17:44:40-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180518 17:44:46-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180518 19:05:47-!- Oebele [~quassel@143.177.58.202] has quit [Remote host closed the connection] 20180518 19:24:22-!- irker457 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout] 20180518 20:29:24-!- gfgtdf [~chatzilla@x4e363799.dyn.telefonica.de] has joined #wesnoth-dev 20180518 21:07:39-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20180518 21:07:45-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20180518 21:13:51<+discordbot> 20180518 17:13:06 error config: Unexpected characters at line start at core/macros/deprecated-utils.cfg:364 included from core/_main.cfg:18 included from _main.cfg:18 included from ~add-ons/After_the_Storm/_main.cfg:147 included from ~add-ons/After_the_Storm/episode1/menu.cfg:19 included from ~add-ons/After_the_Storm/_main.cfg:164 20180518 17:13:06 error deprecation: MENU_IMG_TXT2 has been deprecated and will be 20180518 21:13:51<+discordbot> removed in version 1.15.0. Use the new [difficulty] tag instead for campaign difficulties, or the label/description keys for message options. 20180518 17:13:06 error deprecation: MENU_IMG_TXT2 has been deprecated and will be removed in version 1.15.0. Use the new [difficulty] tag instead for campaign difficulties, or the label/description keys for message options. 20180518 17:13:06 error deprecation: MENU_IMG_TXT2 has been deprecated and 20180518 21:13:52<+discordbot> will be removed in version 1.15.0. Use the new [difficulty] tag instead for campaign difficulties, or the label/description keys for message options. 20180518 21:13:59<+discordbot> This is a bit inconvenient. 20180518 21:15:58<+discordbot> Not only is this not how deprecation works, I also don't want to stop using this macro because I can't apply formatting to the parentheses without it to achieve the grey text here: 20180518 21:15:58<+discordbot> https://cdn.discordapp.com/attachments/259976436490829825/447145344044630036/unknown.png 20180518 21:19:40< zookeeper> i noticed the Unexpected characters at line start thing like yesterday (caused by another UMC), but it only happened with a very slightly pre-1.14 build i accidentally ran. with 1.14.0 it no longer happened. _but_ for some reason i got nothing about deprecation, only the unexpected characters error, so i was very confused as to what could be going on. 20180518 21:24:47<+discordbot> This was with 1.14 tip. 20180518 21:25:17<+discordbot> No such an issue with the Steam 1.14.1 build of course since the deprecation notice hadn't been added to its accompanying data in the first place. 20180518 21:42:12-!- irker631 [~irker@uruz.ai0867.net] has joined #wesnoth-dev 20180518 21:42:12< irker631> wesnoth/wesnoth:1.14 mattsc 3354134406 Experimental AI: fix recruiting so that AppVeyor: All builds passed 20180518 21:44:05< gfgtdf> i'd think the deprecation code internally just converts to the new syntax? so everything the old syntax can should be possible with the new syntax aswell. 20180518 21:44:52<+discordbot> Not really. 20180518 21:45:11<+discordbot> The new difficulty menu code hardcodes the parentheses around the entries on the third column, so there's no way to format them. 20180518 21:45:38<+discordbot> You can still format the content inside the parentheses but it looks off if you have bright parentheses enclosing gray text. 20180518 21:46:32< gfgtdf> ok 20180518 21:46:53<+discordbot> This kind of ties in with what we were talking the other day about add-ons relying on undocumented behaviour. By all means I shouldn't have expected to be able to format the third column (both with GUI1 markup back in the day and now with Pango once it became a GUI2 dialog), but I accidentally came upon it and it's worked for years. 20180518 21:47:29<+discordbot> We could rob add-on authors of that power any time to enforce our own formatting there and escape custom markup. 20180518 21:53:40-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 268 seconds] 20180518 22:15:00<+discordbot> @shadowm I actually have been planning to automatically apply gray there 20180518 22:15:08<+discordbot> But I can’t decide what shade of gray to use 20180518 22:15:09<+discordbot> See? 20180518 22:15:16<+discordbot> What if someone wants orange instead? 20180518 22:15:23<+discordbot> Too bad 20180518 22:15:44<+discordbot> You're not going to become the next Steve Jobs by responding to philosophical questions like that with "too bad". 20180518 22:16:43<+discordbot> I deliberately hardcoded he parentheses so they wouldn’t clutter up the translatable strings 20180518 22:17:33<+discordbot> And that preprocessor message comes from the issue I mentioned yesterday 20180518 22:17:43<+discordbot> We can’t mark those macros deprecated because of a preprocessor but 20180518 22:17:48<+discordbot> Bug 20180518 22:18:11<+discordbot> That I only know about because I have AtS checkouts on 1.14 20180518 22:18:32<+discordbot> But those macros need to be deprecated 20180518 22:18:51<+discordbot> The old syntax won’t work, period, in 1.15 20180518 22:21:02<+discordbot> I feel like the focus should be on opengl and making master not be broken before talking about deprecating/removing macros. 20180518 22:21:27<+discordbot> the former is a must-fix, the latter is an annoyance. 20180518 22:22:16<+discordbot> No, open gl is not a must fix. That’s not why master is broken 20180518 22:23:16<+discordbot> Anyway, regarding custom formatting here, the gray looks fine, anything else would look gaudy so we don’t want to allow it 20180518 22:23:22-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection] 20180518 22:23:34<+discordbot> Except maybe gold. But of course, we can’t make exceptions for specific colors 20180518 22:24:31<+discordbot> I care so much about supporting 1.15 at th emoment. 20180518 22:25:42<+discordbot> Sure, you could argue "but shadowm not caring about 1.14 is how you managed to miss the steam train in the first place". 20180518 22:25:47<+discordbot> And to that I say 20180518 22:26:03<+discordbot> "yes youre right" 20180518 22:27:13<+discordbot> But in my defense there were more complicated circumstances going on keeping me from caring about 1.14 support for two years. The biggest one being IftU 2.0. 20180518 22:28:59<+discordbot> I'm willing to drop the formatting and go with plain text and the new syntax if it'll earn me a box of chocolates or some other concrete reward in return right now. 20180518 22:29:52<+discordbot> Until then, I expect that the preprocessor error will be fixed before 1.14.2 so that people who probably don't have the same reason as I do for not using the new syntax aren't forced to convert it only because of an oversight on the game devs' part. 20180518 22:35:53-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20180518 22:39:22<+discordbot> I’ll ask celmin to fix it 20180518 22:39:32<+discordbot> We can’t be unable to deprecate these types of macros 20180518 22:39:50<+discordbot> What does this mean? # Disabled for 1.9 and the whiteboard beta test #[hotkey] # command=delayshroud # key=d # shift=yes #[/hotkey] 20180518 22:40:02<+discordbot> From hotkeys.cfg 20180518 22:40:24<+discordbot> whiteboard ~== planning mode, right? 20180518 22:41:05< gfgtdf> depends how you man that, in lua '~=' means 'not equals' 20180518 22:41:26<+discordbot> I feel like the #deprecate syntax could have been done better if instead of requiring it to be in the substituted contents, it could be placed outside like so: #define FOO #enddef #deprecate FOO {FOO} # → deprecation message gets logged 20180518 22:41:40<+discordbot> That way you wouldn't have to worry about it inserting a trailing newline. 20180518 22:41:41<+discordbot> I meant “Roughly equal to” 20180518 22:41:58< gfgtdf> ye whiteboard means planning mode 20180518 22:42:02<+discordbot> (No use in crying over spilled milk, of course, but it might be worth noting for the future.) 20180518 22:44:13<+discordbot> Whiteboard is planning mode 20180518 22:47:26-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: mattsc] 20180518 22:56:17<+discordbot> just realized her example probably looks like garbage on the IRC end. 20180518 22:56:54<+discordbot> Hopefully this gets the message across better (no pun intended): https://pastebin.com/buzLEUcZ 20180518 22:57:56<+discordbot> So the delayshroud command, does that work? (What does it do?) 20180518 22:58:16<+discordbot> It’s commented out. 20180518 22:59:17< gfgtdf> it probally toggles delayed shroud updates on/off 20180518 22:59:37< gfgtdf> why are you investigating that i wonder. 20180518 23:11:37-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev 20180518 23:12:54<+discordbot> he's updating hotkeys 20180518 23:30:59< irker631> wesnoth: Nils Kneuper wesnoth:1.14 35a6df81c7c4 / / (10 files in 10 dirs): updated Italian translation https://github.com/wesnoth/wesnoth/commit/35a6df81c7c4b492caabbd7064263dbcc1174198 20180518 23:31:01< irker631> wesnoth: Nils Kneuper wesnoth:1.14 9f3248bba5bd / / (31 files in 30 dirs): updated Chinese (Simplified) translation https://github.com/wesnoth/wesnoth/commit/9f3248bba5bdb8b4053e8a070c0eda75f49f43e0 20180518 23:31:08< irker631> wesnoth: Nils Kneuper wesnoth:master 63bac52b71ed / / (10 files in 10 dirs): updated Italian translation https://github.com/wesnoth/wesnoth/commit/63bac52b71ed04ffd124a940a680e82dad261b12 20180518 23:31:10< irker631> wesnoth: Nils Kneuper wesnoth:master 1b7d8b2f604a / po/ (29 files in 29 dirs): updated Chinese (Simplified) translation https://github.com/wesnoth/wesnoth/commit/1b7d8b2f604a68df27d18d2f66255f74d4a12f02 20180518 23:53:56-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev 20180518 23:56:36-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Client Quit] 20180518 23:57:38-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev 20180518 23:58:46-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Client Quit] --- Log closed Sat May 19 00:00:16 2018