--- Log opened Sat May 19 00:00:16 2018
--- Day changed Sat May 19 2018
20180519 00:00:16-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20180519 00:25:49< gfgtdf> can i use size_lock to oynl lock te width or only to lock the height ?
20180519 00:27:19< celticminstrel> I think you can set one to 0 to only lock the other.
20180519 00:27:27< celticminstrel> (Or maybe just leave it out entirely.)
20180519 00:27:54<+discordbot> <sevu> I updated this page, especially the Suse and Fedora part (though I have none of both) https://wiki.wesnoth.org/CompilingWesnoth#Linux_Tips_to_Easily_Gather_Dependencies Is there eventually a part where the -devel package isn't needed? Bzip2 or readline eventually?
20180519 00:28:31< gfgtdf> will try
20180519 00:32:50<+discordbot> <shadowm> Funny how rewriting code to use [foreach] has allowed me to find gems like this: {VARIABLE turns_are_even "$($turns % 4)"}          {BUG_ON ({VARIABLE_NUMERICAL_NOT_EQUALS v 0}) ()}
20180519 00:33:34<+discordbot> <shadowm> (v is never assigned to so of course it always evaluates to 0.)
20180519 00:36:33< gfgtdf> hmm using size_lock fails with 'Unknown exception'....
20180519 00:38:17< gfgtdf> i bet its layout_exception_...
20180519 00:52:10<+discordbot> <shadowm> I assume [repeat] times=0 [do] [foo][/foo] [/do] [/repeat] will never execute [foo], right?
20180519 00:52:25< celticminstrel> Yeah.
20180519 00:52:39-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20180519 00:54:21-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20180519 00:54:32<+discordbot> <shadowm> Also uh @Vultraz I asked you earlier if you'd be opposed to adding the "i" button to access the version dialog to the bottom left corner of Preferences but didn't get a response.
20180519 00:56:38< gfgtdf> is there a (gui2) button definition for a big button like the "end turn" button in the standard ingame theme?
20180519 00:57:19< celticminstrel> I think there might be something like that in MP Create?
20180519 00:59:03< gfgtdf> hm ok just found a bug button deifnition it doesnt loosk like the endturn button but its ok.
20180519 01:00:36<+discordbot> <shadowm> Yeah, I don't expect you'll find one that looks exactly like the End Turn button since that's implemented in GUI1.
20180519 01:00:56< gfgtdf> s/bug/big
20180519 01:00:58<+discordbot> <shadowm> (But you could add one yourself in master if there isn't one already there.)
20180519 01:02:11< gfgtdf> shadowm: ye with 1.14 umc can add custom gui2 widget defintion, but i'd rather not make it more work.
20180519 01:03:10<+discordbot> <shadowm> Oooooo wait, you can?
20180519 01:03:24<+discordbot> <shadowm> I don't remember right now what I wanted that for a few days ago argh.
20180519 01:04:17<+discordbot> <shadowm> AH I REMEMBER NOW
20180519 01:04:39< celticminstrel> Yeah, gfgtdf added a Lua function for that.
20180519 01:05:02<+discordbot> <shadowm> What's it called?
20180519 01:05:25< celticminstrel> wesnoth.add_widget_definition IIRC
20180519 01:05:35<+discordbot> <shadowm> It's not in LuaWML.
20180519 01:05:49< celticminstrel> Is it in the appropriate subpage?
20180519 01:06:40-!- gfgtdf_ [~chatzilla@x4e36362b.dyn.telefonica.de] has joined #wesnoth-dev
20180519 01:07:22-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20180519 01:08:35-!- gfgtdf [~chatzilla@x4e363799.dyn.telefonica.de] has quit [Ping timeout: 256 seconds]
20180519 01:08:35-!- gfgtdf_ is now known as gfgtdf
20180519 01:09:28<+discordbot> <shadowm> No.
20180519 01:10:17< celticminstrel> It's probably something like add_widget_definition(definition_name, resolution_content); but ask gfgtdf because he was the one who added it.
20180519 01:10:25< celticminstrel> gfgtdf: Please document it.
20180519 01:11:46< gfgtdf> it's Arg 1: string, widget_type, Arg 3: string, definition_id, Arg 3: config, definiton_content (copied from the cpp, the second one is probalby arg2 instead of arg3)
20180519 01:12:09< celticminstrel> gfgtdf: Please document it on the wiki.
20180519 01:12:20< gfgtdf> celticminstrel: it's on the todo list https://github.com/wesnoth/wesnoth/issues/2653/ :)
20180519 01:12:23< gfgtdf> ye will do
20180519 01:12:27< celticminstrel> I know it is.
20180519 01:13:31<+discordbot> <shadowm> Does this have to be executed at a specific time to work (e.g. global [lua] instead of WML event) or it'll work any time? In either case, for how long does the definition exist?
20180519 01:14:14<+discordbot> <shadowm> (I already noticed that global [lua] is special in 1.14, whereas in 1.12 it was a glorified WML preload event.)
20180519 01:15:10< celticminstrel> I think this was discussed when he first added it, but I can't remember...
20180519 01:16:41< gfgtdf> iirc you can use it anywhere
20180519 01:16:58<+discordbot> <Pentarctagon> @sevu If you're updating build instructions for 1.14, you may as well point to the 1.14 dockerfile on github.
20180519 01:17:21< gfgtdf> added a documentation entry.
20180519 01:17:37<+discordbot> <shadowm> And for how long does the definition exist?
20180519 01:18:11< celticminstrel> Does it exist for the remainder of the session, or until the Lua kernel is destroyed, or...?
20180519 01:18:31< gfgtdf> until lk is destroeyed.
20180519 01:18:49<+discordbot> <shadowm> (what does that mean?)
20180519 01:19:13< gfgtdf> until the gmaestate is destroyed, (when you end/reload etc) the current game.
20180519 01:19:23<+discordbot> <shadowm> Oh, okay.
20180519 01:28:26<+discordbot> <ancestral> Does anybody know if delayshroud hotkey should work? Should I delete that commented command out?
20180519 01:29:22<+discordbot> <ancestral> I guess I could look through the revision history and see who put it there and ask them. (My feeling is it was probably from 10 years ago and not going to be useful.)
20180519 01:30:12<+discordbot> <ancestral> …Given the average user probably doesn’t even know what shroud is in the game, I’ll probably just ignore it.
20180519 01:31:00< celticminstrel> I've never noticed it working, but maybe I just never remembered to enable it...
20180519 01:31:05<+discordbot> <shadowm> Shroud is an option when creating games, so users really ought to know what it is.
20180519 01:31:18< celticminstrel> If the command in the menu to delay shroud works, then a hotkey for it should work too.
20180519 01:32:06< gfgtdf> i persoanlyl really dislike dsu, i think its a minefield for oos, and can also break umc scripting that relies in sightings (which i admit is something you shodul not rely on regardless)
20180519 01:32:21<+discordbot> <ancestral> (I like how the command names for planning mode are things likewbshroudtoggle)
20180519 01:32:52<+discordbot> <ancestral> Anyway, need a little more time then I’ll submit a PR
20180519 01:33:06< celticminstrel> Wouldn't the sighting events just fire when the shroud is updated though?
20180519 01:33:30< celticminstrel> Anyway the reason for delay shroud updates is so that you can undo your moves, so...
20180519 01:33:38< celticminstrel> I think it's important to have.
20180519 01:34:08<+discordbot> <ancestral> celticminstrel: So do you think it works if it gets commented in?
20180519 01:34:57< celticminstrel> I think it should be pretty easy for you to test and see if it works.
20180519 01:35:24< gfgtdf> for testing moves you can also use planning mode
20180519 01:44:41<+discordbot> <shadowm> Yeah, you mean the mode that doesn't work with one of the novice campaigns. :p
20180519 01:45:21< celticminstrel> ...wait what?
20180519 01:45:30< celticminstrel> Oh wait, the AOI problem?
20180519 01:45:38<+discordbot> <shadowm> #3100, yes.
20180519 01:45:51<+discordbot> <sevu> @Pentarctagon added it. If you would not specify the exact versions but only the packagenames it would make it easy to copy past from them.
20180519 01:46:11<+discordbot> <shadowm> Although to a casual observer it just gives off the impression that planning mode breaks the game.
20180519 01:46:50<+discordbot> <shadowm> Assuming they didn't accidentally press 'p' at some point and not realize, then they'll just assume the game is broken in general.
20180519 01:55:59< gfgtdf> still the idea behing plannign mode is simpler than dsu, and the edxtra_recruit isue will also be fixed sooner or later, in fact i don't even see why aplnning mode implement it's own recruitment check in the first place.
20180519 02:19:10<+discordbot> <shadowm> oi
20180519 02:19:22<+discordbot> <shadowm> I can't use wesnoth.set_dialog_visible on a grid widget.
20180519 02:20:33< celticminstrel> Is that possible in C++?
20180519 02:20:37<+discordbot> <Vultraz> yes
20180519 02:20:49< celticminstrel> Okay, just asking because IIRC the grid is a little weird.
20180519 02:20:53<+discordbot> <shadowm> I guess I could cheat my way out of this making it a stacked widget with a single stack.
20180519 02:21:07<+discordbot> <Vultraz> or a [panel]
20180519 02:21:26<+discordbot> <shadowm> What's a panel?
20180519 02:21:39<+discordbot> <shadowm> Or rather, in what way does it differ from a grid?
20180519 02:22:10<+discordbot> <Vultraz> it's a grid that can be styled
20180519 02:23:57<+discordbot> <shadowm> Cool, that works, ty
20180519 02:34:27<+discordbot> <Vultraz> celmin: the dofile-on-a-whole-directory thing isn;t documented
20180519 02:34:55< celticminstrel> That one might actually be documented on the WIP LuaAPI page.
20180519 02:42:43-!- gfgtdf [~chatzilla@x4e36362b.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.93 [Firefox 52.8.0/20180430140610]]
20180519 02:46:40< irker631> wesnoth: Severin Glöckner wesnoth:1.14 1caadc279306 / po/ (wesnoth-editor/de.po wesnoth-help/de.po wesnoth-lib/de.po wesnoth/de.po): updated German translation https://github.com/wesnoth/wesnoth/commit/1caadc2793067a771263b6b21f443a8528f00660
20180519 03:42:28<+discordbot> <Vultraz> huh, I'd forgotten [break], [continue], and [return] were things
20180519 04:37:23< celticminstrel> XD
20180519 04:37:36< celticminstrel> ...speaking of which, does [random_placement] support them?
20180519 04:37:55< celticminstrel> I bet it doesn't.
20180519 04:38:07 * celticminstrel checks.
20180519 04:38:12<+discordbot> <Vultraz> no idea
20180519 04:38:35< celticminstrel> It doesn't! Why am I not surprised!
20180519 04:38:37< celticminstrel> ><
20180519 04:40:30< celticminstrel> ...
20180519 04:40:48< celticminstrel> I just thought of a possible way for [for] and [foreach] to maybe leak the variable.
20180519 04:42:25< irker631> wesnoth: Celtic Minstrel wesnoth:master 4a3508f13fea / data/lua/wml/random_placement.lua: Support [break], [continue], and [return] in [random_placement] https://github.com/wesnoth/wesnoth/commit/4a3508f13fea69b5cafdfa2d46a99caec201d6e5
20180519 04:43:18< celticminstrel> Ah, looks like  I thought of it when I implemented them too. Whew.
20180519 04:43:52< celticminstrel> I used goto instead of return like random_placement does. Maybe random_placement should change to goto too, but whatever, probably doesn't matter too much.
20180519 04:51:22< celticminstrel> (I'm assuming that commit is unsafe to backport FTR, but I could be wrong.)
20180519 04:51:50<+discordbot> <Vultraz> compatibility with what
20180519 04:52:20< celticminstrel> Compatibility with 1.14?
20180519 04:52:36< celticminstrel> In 1.14 it uses [command], but IMO it's a loop so it should use [do] for consistency.
20180519 05:01:10-!- celticminstrel is now known as celmin|sleep
20180519 05:20:01-!- celmin|sleep [~celmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The computer falls into a deep sleep, to awake again some other day!]
20180519 06:01:34-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20180519 06:20:23< irker631> wesnoth/wesnoth:1.14 Nils Kneuper 9f3248bba5 updated Chinese (Simplified) translation AppVeyor: All builds passed
20180519 07:46:53< irker631> wesnoth/wesnoth:master Nils Kneuper 1b7d8b2f60 updated Chinese (Simplified) translation AppVeyor: All builds passed
20180519 08:09:00-!- matthiaskrgr_ is now known as matthiaskrgr
20180519 08:40:50< Rhonda> I fail to see the actual error here why the build fails, anyone got a clue or better look?  https://buildd.debian.org/status/package.php?p=wesnoth-1%2e14  (the snippets at the bottom, the full log can be seen when clicking on the "Build-Attemted" at the top)
20180519 08:45:45<+discordbot> <Pentarctagon> looks like:  make[3]:  [src/CMakeFiles/wesnoth-core.dir/build.make:183: src/CMakeFiles/wesnoth-core.dir/gettext_boost.cpp.o] Error 1 make[3]: Leaving directory '/<<PKGBUILDDIR>>/build' make[2]:  [CMakeFiles/Makefile2:437: src/CMakeFiles/wesnoth-core.dir/all] Error 2 make[2]: *** Waiting for unfinished jobs....
20180519 08:46:08< matthiaskrgr> E: Build killed with signal TERM after 450 minutes of inactivity   
20180519 08:46:24<+discordbot> <Pentarctagon> which doesn't seem to have any actual error, but just above there's: virtual memory exhausted: Cannot allocate memory
20180519 08:47:11<+discordbot> <Pentarctagon> for mips^
20180519 08:47:13<+discordbot> <Pentarctagon> at least
20180519 08:50:27< Rhonda> oh, hmm
20180519 09:46:56-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20180519 10:33:16< irker631> wesnoth/wesnoth:1.14 Severin Glöckner 1caadc2793 updated German translation AppVeyor: All builds passed
20180519 10:49:11-!- Oebele [~quassel@185-11-201-31.ftth.glasoperator.nl] has joined #wesnoth-dev
20180519 10:51:07-!- Oebele [~quassel@185-11-201-31.ftth.glasoperator.nl] has quit [Remote host closed the connection]
20180519 10:52:07-!- Oebele [~quassel@185-11-201-31.ftth.glasoperator.nl] has joined #wesnoth-dev
20180519 10:54:58-!- Oebele [~quassel@185-11-201-31.ftth.glasoperator.nl] has quit [Remote host closed the connection]
20180519 11:21:31-!- Oebele [~quassel@185-11-201-31.ftth.glasoperator.nl] has joined #wesnoth-dev
20180519 11:34:17-!- aeth [~Michael@wesnoth/umc-dev/developer/aethaeryn] has quit [Read error: Connection reset by peer]
20180519 11:34:38-!- aeth [~Michael@wesnoth/umc-dev/developer/aethaeryn] has joined #wesnoth-dev
20180519 11:39:42-!- Oebele [~quassel@185-11-201-31.ftth.glasoperator.nl] has quit [Remote host closed the connection]
20180519 12:10:40-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180519 12:10:50-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20180519 12:15:54-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180519 12:16:00-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20180519 12:16:04-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity]
20180519 12:27:09<+discordbot> <jyrkive> Question about #3016: https://github.com/wesnoth/wesnoth/issues/3016
20180519 12:27:31<+discordbot> <jyrkive> It is by design that GUI2 list boxes scroll to the selected element when the list changes.
20180519 12:27:49<+discordbot> <jyrkive> How exactly do you think the behavior should be changed?
20180519 12:28:18<+discordbot> <Vultraz> the fix should be in the base class, and the current position should be maintained if possible
20180519 12:28:19<+discordbot> <jyrkive> For example, should the behavior be "scroll to the selected item, but only if it was already visible"?
20180519 12:32:15< irker631> wesnoth: Jyrki Vesterinen wesnoth:1.14 c364952272cc / src/gui/widgets/listbox.cpp: Listbox: don't try to keep the selected item visible (#3016) https://github.com/wesnoth/wesnoth/commit/c364952272cc412029c324a31bdec22103da308d
20180519 12:34:21< irker631> wesnoth: Jyrki Vesterinen wesnoth:master 3deef64439e0 / src/gui/widgets/listbox.cpp: Listbox: don't try to keep the selected item visible (#3016) https://github.com/wesnoth/wesnoth/commit/3deef64439e0ae8d762fb76bafd46bb3fea0cb16
20180519 12:36:21< irker631> wesnoth/wesnoth:master Celtic Minstrel 4a3508f13f Support [break], [continue], and [return AppVeyor: All builds passed
20180519 12:38:27< irker631> wesnoth: Jyrki Vesterinen wesnoth:master c68a7ba5f614 / changelog.md players_changelog.md: Changelog entry for commit 3deef64439e0ae8d762fb76bafd46bb3fea0cb16 https://github.com/wesnoth/wesnoth/commit/c68a7ba5f61481240644ee39f0412f9ffcb354d2
20180519 12:40:51< irker631> wesnoth: Jyrki Vesterinen wesnoth:1.14 cf3ff8222bdb / changelog.md players_changelog.md: Changelog entry for commit c364952272cc412029c324a31bdec22103da308d https://github.com/wesnoth/wesnoth/commit/cf3ff8222bdbfd3ecd88436780d7397b7be281ee
20180519 12:41:07<+discordbot> <jyrkive> All right, done.
20180519 12:56:08-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180519 12:56:14-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20180519 12:59:57<+discordbot> <Vultraz> it just makes the most sense
20180519 13:00:12-!- travis-ci [~travis-ci@ec2-54-226-175-222.compute-1.amazonaws.com] has joined #wesnoth-dev
20180519 13:00:13< travis-ci> wesnoth/wesnoth#18212 (master - 3deef64 : Jyrki Vesterinen): The build was broken.
20180519 13:00:13< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/381059813
20180519 13:00:14-!- travis-ci [~travis-ci@ec2-54-226-175-222.compute-1.amazonaws.com] has left #wesnoth-dev []
20180519 13:15:20<+discordbot> <Vultraz> unusrd variables
20180519 13:40:21< irker631> wesnoth: Jyrki Vesterinen wesnoth:1.14 e02939bc2018 / src/gui/widgets/listbox.cpp: Fix build with -Werror=unused-variable https://github.com/wesnoth/wesnoth/commit/e02939bc20183fa430dab1ad5241b855da427a82
20180519 13:41:35< irker631> wesnoth: Jyrki Vesterinen wesnoth:master a388c2d891b7 / src/gui/widgets/listbox.cpp: Fix build with -Werror=unused-variable https://github.com/wesnoth/wesnoth/commit/a388c2d891b77645f62999e550740ed772f7b24b
20180519 13:54:16-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20180519 14:00:11-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20180519 14:02:07-!- travis-ci [~travis-ci@ec2-54-82-78-251.compute-1.amazonaws.com] has joined #wesnoth-dev
20180519 14:02:08< travis-ci> wesnoth/wesnoth#18213 (1.14 - e02939b : Jyrki Vesterinen): The build was fixed.
20180519 14:02:08< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/381073492
20180519 14:02:08-!- travis-ci [~travis-ci@ec2-54-82-78-251.compute-1.amazonaws.com] has left #wesnoth-dev []
20180519 14:16:21-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20180519 14:16:27-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20180519 14:18:01-!- travis-ci [~travis-ci@ec2-54-226-175-222.compute-1.amazonaws.com] has joined #wesnoth-dev
20180519 14:18:02< travis-ci> wesnoth/wesnoth#18214 (master - a388c2d : Jyrki Vesterinen): The build was fixed.
20180519 14:18:02< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/381073778
20180519 14:18:02-!- travis-ci [~travis-ci@ec2-54-226-175-222.compute-1.amazonaws.com] has left #wesnoth-dev []
20180519 14:28:01-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20180519 15:04:31< celticminstrel> I don't get it? https://github.com/wesnoth/wesnoth/issues/3023#issuecomment-390390945
20180519 15:20:31<+discordbot> <Vultraz> pretty sure that was fixed when shadowm's fix for hiding inactive specisl in the attack dialog wasmerged
20180519 15:23:27< celticminstrel> I'm referring to newfrenchy's comment.
20180519 15:51:58<+discordbot> <shadowm> Yeah, the fix for inactive specials showing up is in.
20180519 15:52:23<+discordbot> <shadowm> In 1.14.1, to be specific. I didn't realize/remember there was an open bug related to it.
20180519 15:53:47<+discordbot> <shadowm> Incidentally, it might be less confusing to give him a weapon special with a different name.
20180519 15:56:20<+discordbot> <Yumi> fervor?
20180519 15:56:25<+discordbot> <Yumi> zeal?
20180519 15:59:53<+discordbot> <shadowm> Mostly because of this: if his weapon special goes have a different, unique name, people will be forced to check its description.
20180519 16:00:43<+discordbot> <shadowm> Otherwise it'll just show up as "berserk" on the sidebar and people will assume it works the same as vanilla berserk, then be confused when it doesn't work against every unit. (Not everyone pays too much attention to the story, and if my memory serves, the way the fight goes down is incredibly confusing anyway.)
20180519 16:00:54<+discordbot> <shadowm> *does
20180519 16:42:51-!- irker631 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20180519 17:01:42< celticminstrel> Oh I just remembered there was something I'm supposed to be doing.
20180519 17:01:57< celticminstrel> Also I agree with shadowm on renaming it.
20180519 17:05:28< celticminstrel> Sooo I need to figure out where the handling for hiding incomplete translations is.
20180519 17:08:22<+discordbot> <shadowm> language.cpp or gettext*.cpp, IIRC.
20180519 17:30:02< celticminstrel> It's done!
20180519 17:30:31< celticminstrel> Though perhaps I should ask if anyone can suggest better option names.
20180519 17:31:09< celticminstrel> I added --translations-over=60 to set the completeness standard for translations, and --all-translations as a shorthand for --translations-over=0
20180519 17:47:40-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20180519 18:08:20-!- irker007 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20180519 18:08:21< irker007> wesnoth: Nils Kneuper wesnoth:1.14 66825b5b25ab / / (13 files in 13 dirs): updated Chinese (Simplified) translation https://github.com/wesnoth/wesnoth/commit/66825b5b25abebb316853b499c98597d8e35be7d
20180519 18:08:21< irker007> wesnoth: Nils Kneuper wesnoth:1.14 b8ceaf637fb1 / po/ (7 files in 7 dirs): updated Spanish translation https://github.com/wesnoth/wesnoth/commit/b8ceaf637fb13cff18795475e502f594a957fb6c
20180519 18:08:21< irker007> wesnoth: Nils Kneuper wesnoth:master 71a6488419f1 / / (13 files in 13 dirs): updated Chinese (Simplified) translation https://github.com/wesnoth/wesnoth/commit/71a6488419f1e19226f49eaa83e64f7b880157da
20180519 18:08:23< irker007> wesnoth: Nils Kneuper wesnoth:master 132f67395a62 / po/ (7 files in 7 dirs): updated Spanish translation https://github.com/wesnoth/wesnoth/commit/132f67395a62bdafe54ce28c52e4fb8a00f8d88f
20180519 18:09:03< Ivanovic> @Vultraz: you are aware that pushing translation updates to steam without pushing the changes in the src and WML files can lead to strings suddenly appearing untranslated?
20180519 18:09:26< Ivanovic> reason: if a pot-update was run on 1.14 after the last release, the translators will work against that state with changed strings
20180519 18:31:03<+discordbot> <Pentarctagon> I don't suppose anyone knows why, in github comments, I see myself labeled as a Contributor when logged out, but a Member when logged in?
20180519 18:32:05<+discordbot> <jyrkive> It's because your presence in the wesnoth organization is not public.
20180519 18:32:13<+discordbot> <jyrkive> You can change your status in https://github.com/orgs/wesnoth/people
20180519 18:33:56<+discordbot> <Pentarctagon> thanks
20180519 18:36:05-!- Bhoren [~Bhoren_wh@2a01:e0a:c:2150:29d8:1ad5:8780:274c] has joined #wesnoth-dev
20180519 19:09:45< irker007> wesnoth: gfgtdf wesnoth:1.14 0e483441d8c8 / src/ (game_initialization/create_engine.cpp saved_game.cpp saved_game.hpp): fix require_scenario=yes not working with map_generation https://github.com/wesnoth/wesnoth/commit/0e483441d8c8ef002aef9f53fa708a4899f42d2c
20180519 19:30:17< celticminstrel> gfgtdf: Shouldn't everything be carried over from the outer scenario?
20180519 19:31:34< celticminstrel> I think what I'd recommend is merging the generated config into the main scenario config.
20180519 19:31:51< celticminstrel> So in the case of duplicates, the generated config takes priority.
20180519 19:32:20< celticminstrel> I think that would be old.merge_with(new) but not quite sure, it might be the other way around.
20180519 19:32:42< celticminstrel> (Though of course you could then delete the keys and tags related to map generation.)
20180519 19:35:21< irker007> wesnoth: Martin Hrubý (hrubymar10) wesnoth:1.14 b01221e420a5 / projectfiles/Xcode/Wesnoth.xcodeproj/project.pbxproj: Xcode enable all warnings in DEBUG scheme https://github.com/wesnoth/wesnoth/commit/b01221e420a5323dbf18ad429d17566eedc63b30
20180519 19:37:10< irker007> wesnoth: Martin Hrubý (hrubymar10) wesnoth:master d19a82801faf / projectfiles/Xcode/Wesnoth.xcodeproj/project.pbxproj: Xcode enable all warnings in DEBUG scheme https://github.com/wesnoth/wesnoth/commit/d19a82801faf6d9bdc23adb167cbd13b8b468b70
20180519 19:45:45-!- gfgtdf [~chatzilla@x4e36362b.dyn.telefonica.de] has joined #wesnoth-dev
20180519 19:47:39< gfgtdf> merge also merges subtags in order right ? i think it'd bebetter if we just append subtags merging two differnt [event]s doesn't really make sense for example.
20180519 19:48:17< gfgtdf> also for some attributes like id= it might cause bugs if it suddenly changes, i think it'd be better to not allow changing it. 
20180519 19:49:05< celticminstrel> Hmm.
20180519 19:49:25< celticminstrel> You have a point.
20180519 19:49:33< celticminstrel> You could merge attributes and append children, then?
20180519 19:49:43< irker007> wesnoth/wesnoth:1.14 Jyrki Vesterinen e02939bc20 Fix build with -Werror=unused-variable AppVeyor: All builds passed
20180519 19:49:54< celticminstrel> That said...
20180519 19:50:09< celticminstrel> Merging doesn't make sense for events but it could make sense for sides...
20180519 19:50:26< celticminstrel> ...but they you'd probably want to merge based on the side number.
20180519 19:50:31< celticminstrel> ^then
20180519 19:52:18< gfgtdf> hmm ye one coudl try something like that
20180519 19:53:04< gfgtdf> but actually i think the possible advntages of allowing such a thing is quite small, so probably not worth the time.
20180519 20:07:59< irker007> wesnoth: Celtic Minstrel wesnoth:1.14 988abfaa5ce2 / src/commandline_options.cpp: Sort command-line options so the comment isn't lying https://github.com/wesnoth/wesnoth/commit/988abfaa5ce235446370855d9070f3782372b1c7
20180519 20:08:01< irker007> wesnoth: Celtic Minstrel wesnoth:1.14 dde6fb5ffff1 / / (6 files in 2 dirs): Add a command-line option to show incomplete translations in the language list https://github.com/wesnoth/wesnoth/commit/dde6fb5ffff1bb4ccf912e795df35596d45180e6
20180519 20:08:05< irker007> wesnoth: Celtic Minstrel wesnoth:master 5e28c13b8710 / src/commandline_options.cpp: Sort command-line options so the comment isn't lying https://github.com/wesnoth/wesnoth/commit/5e28c13b8710322117e53aea32888bff1d96bb4e
20180519 20:08:07< irker007> wesnoth: Celtic Minstrel wesnoth:master fc74e782b7e5 / src/ (5 files): Add a command-line option to show incomplete translations in the language list https://github.com/wesnoth/wesnoth/commit/fc74e782b7e5afc9a842f231655d48e42d63f4e6
20180519 20:08:09< irker007> wesnoth: Celtic Minstrel wesnoth:master b28c61c6dca0 / src/language.cpp: Remove now-obsolete compile flag for disabling translation completion filtering https://github.com/wesnoth/wesnoth/commit/b28c61c6dca0c4ed7b64bcfaec9896e37954169f
20180519 20:08:11< irker007> wesnoth: Celtic Minstrel wesnoth:master 51f6f5270960 / changelog.md: Update changelog https://github.com/wesnoth/wesnoth/commit/51f6f52709606082bb204915e28c3ef3b63da659
20180519 20:12:10<+discordbot> <shadowm> Ugh.
20180519 20:12:26< celticminstrel> ?
20180519 20:12:26-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 268 seconds]
20180519 20:12:35<+discordbot> <shadowm> I wish the Spanish translators were more easily reachable without using emails.
20180519 20:18:57< irker007> wesnoth: Celtic Minstrel wesnoth:master 691435ed4c5d / doc/man/wesnoth.6: Documentation for the translation completeness command-line flags https://github.com/wesnoth/wesnoth/commit/691435ed4c5d2a7cb386971288a117e1e94ac569
20180519 20:19:07< celticminstrel> ^ Needs backport after 1.14.2 is tagged.
20180519 20:19:59<+discordbot> <Pentarctagon> celticminstrel: anything else you think is needed for the dunefolk units PR, or is that good to go?
20180519 20:20:53< celticminstrel> I don't think there's anything else needed.
20180519 20:23:18< celticminstrel> Dark Forecast has no time limit, right?
20180519 20:23:30< celticminstrel> I think that's also the default if the turns key is missing...
20180519 20:24:24< irker007> wesnoth: Jyrki Vesterinen wesnoth:schema_fixes 64ef0eb1e683 / / (6 files in 3 dirs): Hotkey manager: drop duplicate commands https://github.com/wesnoth/wesnoth/commit/64ef0eb1e6830fc61a617a094b6f0cbb6cf97dfc
20180519 20:24:26< irker007> wesnoth: Celtic Minstrel wesnoth:schema_fixes 25b30608f904 / changelog.md: Update changelog.md https://github.com/wesnoth/wesnoth/commit/25b30608f90482ee2785a59928b65e2a580ac6eb
20180519 20:24:28< irker007> wesnoth: Iris Morelle wesnoth:schema_fixes d4c0783914eb / data/multiplayer/scenarios/2p_Aethermaw.cfg: Add team colouring to some Aethermaw props missing it https://github.com/wesnoth/wesnoth/commit/d4c0783914eb9385e7c59dd8542a73d79df12768
20180519 20:24:31< irker007> wesnoth: Iris Morelle wesnoth:schema_fixes 05b464aadfe1 / changelog.md: Update changelog https://github.com/wesnoth/wesnoth/commit/05b464aadfe1c531578e54331ff8a53b371f48c6
20180519 20:24:34< irker007> wesnoth: loonycyborg wesnoth:schema_fixes bb14c3bc217f / src/server/server.cpp: Fix issue #1757: prevent abnormal termination if failed to bind address https://github.com/wesnoth/wesnoth/commit/bb14c3bc217fd70c3dc3e3ea0c9eb777c95d7979
20180519 20:24:36< irker007> wesnoth: mattsc wesnoth:schema_fixes 1597a2ce273e / src/ai/default/ (recruitment.cpp recruitment.hpp): AI recruitment: fix units on recall list interfering with recruiting https://github.com/wesnoth/wesnoth/commit/1597a2ce273e2f6f89221fc9fa10590892f43043
20180519 20:24:38< irker007> wesnoth: Jyrki Vesterinen wesnoth:schema_fixes 47d83b44b2b1 / / (6 files in 3 dirs): Merge branch 'hotkey-event-buffer' into 1.14 https://github.com/wesnoth/wesnoth/commit/47d83b44b2b17461d96d5550b259bfa6e9958431
20180519 20:24:40< irker007> wesnoth: mattsc wesnoth:schema_fixes 011941391059 / src/ai/default/recruitment.cpp: AI recruitment: use unit-specific recall cost https://github.com/wesnoth/wesnoth/commit/0119413910591aa9e8ced71c9702271df51b67c4
20180519 20:24:42< irker007> wesnoth: Severin Glöckner wesnoth:schema_fixes c9c676b761eb / README.md: INSTALL had been renamed to INSTALL.md https://github.com/wesnoth/wesnoth/commit/c9c676b761eb8d2efed681c72bcce66f87647b5f
20180519 20:24:44< irker007> wesnoth: Severin Glöckner wesnoth:schema_fixes 6a085e490f17 / data/multiplayer/scenarios/ (2p_Dark_Forecast.cfg 4p_A_New_Land.cfg): remove unneded keys https://github.com/wesnoth/wesnoth/commit/6a085e490f1798ec931b5c4a13266b6663c38869
20180519 20:24:46< irker007> wesnoth: Severin Glöckner wesnoth:schema_fixes bdf9523b65be / data/campaigns/Dead_Water/units/Brawler.cfg: update 2nd stunned event as well with additions from 1.13.2 https://github.com/wesnoth/wesnoth/commit/bdf9523b65be1f3a90a585cc4cc41f87aa3d72e0
20180519 20:24:48< irker007> wesnoth: Charles Dang wesnoth:schema_fixes 06af9401eec7 / data/multiplayer/scenarios/ANL_utils/ANL_general_macros.cfg: ANL: removed unused macro (closes #2878) https://github.com/wesnoth/wesnoth/commit/06af9401eec7153277d564f071a85618062fea46
20180519 20:24:51< irker007> wesnoth: Charles Dang wesnoth:schema_fixes 0c745f0fc5a2 / changelog.md data/gui/window/game_load.cfg src/gui/dialogs/game_load.cpp: Game Load: added a convenient button in Load Game to open your saves folder https://github.com/wesnoth/wesnoth/commit/0c745f0fc5a2b5066431979dd503f2ad5eabc1b2
20180519 20:24:54< irker007> wesnoth: loonycyborg wesnoth:schema_fixes 0c3f6da83072 / src/ (desktop/open.cpp wesnoth.cpp): Fix "host networked game" option https://github.com/wesnoth/wesnoth/commit/0c3f6da8307283045094e23b439b13abd7f912e5
20180519 20:24:56< irker007> wesnoth: Jyrki Vesterinen wesnoth:schema_fixes 61e15c42e229 / src/gui/dialogs/game_load.cpp: Fix build with Visual Studio 2013 https://github.com/wesnoth/wesnoth/commit/61e15c42e2298e050c2af880833d68a5922bf267
20180519 20:24:58< irker007> wesnoth: Jyrki Vesterinen wesnoth:schema_fixes 4916e1c0b9ff / src/team.hpp: Fix #2850: [modify_side] share_vision=yes doesn't do anything https://github.com/wesnoth/wesnoth/commit/4916e1c0b9ff1dfe2547d65e01fa711ff01a7dff
20180519 20:25:00< irker007> wesnoth: Jyrki Vesterinen wesnoth:schema_fixes f4ee47c6ea40 / changelog.md: Changelog entry for commit 4916e1c0b9ff1dfe2547d65e01fa711ff01a7dff https://github.com/wesnoth/wesnoth/commit/f4ee47c6ea4026b37a913d67e0cda9b7ad976a5a
20180519 20:25:02< irker007> wesnoth: Nils Kneuper wesnoth:schema_fixes be36c9e5561e / / (14 files in 13 dirs): updated Italian translation https://github.com/wesnoth/wesnoth/commit/be36c9e5561ea95e509ad8593885bae7cb54a29a
20180519 20:25:04< irker007> wesnoth: Nils Kneuper wesnoth:schema_fixes cf92afd1355e / po/ (wesnoth-lib/pl.po wesnoth-units/pl.po wesnoth/pl.po): updated Polish translation https://github.com/wesnoth/wesnoth/commit/cf92afd1355e14ea35d61b50e4b7ffbeefce9fc2
20180519 20:25:06< irker007> wesnoth: Martin Hrubý (hrubymar10) wesnoth:schema_fixes e09afcffb5ad / projectfiles/Xcode/README.md: Update link to new MacCompileStuff repo https://github.com/wesnoth/wesnoth/commit/e09afcffb5adfe5d51e36d4d92daf553821b1ef0
20180519 20:25:08< irker007> wesnoth: mattsc wesnoth:schema_fixes 84c39de58d0e / src/ai/default/ (recruitment.cpp recruitment.hpp): Merge pull request #2876 from mattsc/recall_recruit_bug https://github.com/wesnoth/wesnoth/commit/84c39de58d0e4cad7e0f474dca833ef60e8c3f65
20180519 20:25:10< irker007> wesnoth: Jyrki Vesterinen wesnoth:schema_fixes a0b54b1513e8 / src/hotkey/ (command_executor.cpp command_executor.hpp): Fix #2884: minimap buttons don't do anything https://github.com/wesnoth/wesnoth/commit/a0b54b1513e840498e90572e0e4b9687df36a9cd
20180519 20:25:12< irker007> wesnoth: mattsc wesnoth:schema_fixes ab8c4c39eae8 / changelog.md: Update changelog https://github.com/wesnoth/wesnoth/commit/ab8c4c39eae83bdaff7ab1c54beafc4d79acd198
20180519 20:25:14< irker007> wesnoth: Charles Dang wesnoth:schema_fixes e6d4b4113a01 / src/game_initialization/lobby_data.cpp: Attempt to fix non-required era being flagged for download https://github.com/wesnoth/wesnoth/commit/e6d4b4113a011dd1ef34bc7bde75fee3892b9f82
20180519 20:25:17< irker007> wesnoth: Charles Dang wesnoth:schema_fixes d0d7bd1722a9 / changelog.md: Changelog entry for e6d4b4113a0 https://github.com/wesnoth/wesnoth/commit/d0d7bd1722a988d37c31ea6ef66cd712e6964b70
20180519 20:25:20< irker007> wesnoth: Charles Dang wesnoth:schema_fixes b4bbb6cec775 / src/game_initialization/lobby_data.cpp: Lobby Info: filter on game name first https://github.com/wesnoth/wesnoth/commit/b4bbb6cec7753ee4c5cdf6257d58863346ec538c
20180519 20:25:23< irker007> wesnoth: Celtic Minstrel wesnoth:schema_fixes 76cf5baf5dd5 / / (5 files in 4 dirs): Editor: Refresh named locations list when map context changes (fixes #1023) https://github.com/wesnoth/wesnoth/commit/76cf5baf5dd5ba9f5ffc87c22efee29e8b012710
20180519 20:25:25< irker007> wesnoth: Severin Glöckner wesnoth:schema_fixes 13767fe9eecf / data/campaigns/Under_the_Burning_Suns/units/quenoth/ (9 files): utbs: change traits for higher unit types too, https://github.com/wesnoth/wesnoth/commit/13767fe9eecf63df54552f6949fe5a0132397e63
20180519 20:25:27< irker007> wesnoth: Severin Glöckner wesnoth:schema_fixes 5c057a1e09b8 / data/campaigns/Under_the_Burning_Suns/ (units/units.cfg utils/kaleh-abilities.cfg): utbs: remove movetypes and abilities only used by old desert elves https://github.com/wesnoth/wesnoth/commit/5c057a1e09b8635daefc97de599d1e6523c2f6ab
20180519 20:25:29< irker007> wesnoth: Severin Glöckner wesnoth:schema_fixes 10c93d24fc3b / data/campaigns/Under_the_Burning_Suns/units/ (6 files in 2 dirs): utbs: replace true by yes https://github.com/wesnoth/wesnoth/commit/10c93d24fc3b2f1cd8ab3a396f57ed033d49a1c7
20180519 20:25:31< irker007> wesnoth: ln-zookeeper wesnoth:schema_fixes 0b1aaecb6ad8 / data/campaigns/Under_the_Burning_Suns/units/quenoth/Scout.cfg: UtBS: Removed obsolete slows note from Quenoth Scout https://github.com/wesnoth/wesnoth/commit/0b1aaecb6ad897e04ad2c9516a88724f9380489f
20180519 20:25:33< irker007> wesnoth: Charles Dang wesnoth:schema_fixes e863f7937cc7 / changelog.md: Better changelog entry for the MP password fix https://github.com/wesnoth/wesnoth/commit/e863f7937cc7405b3a62ef944816cfb0b8489c50
20180519 20:25:34< celticminstrel> Oh I see what's going on. Bleh.
20180519 20:25:36< irker007> wesnoth: Iris Morelle wesnoth:schema_fixes f843a0eebe56 / / (3 files in 2 dirs): Revert string changes in SotA for 1.14 RC 3 - gold https://github.com/wesnoth/wesnoth/commit/f843a0eebe56b3cd41ed76e184af9e1419525578
20180519 20:25:39< irker007> wesnoth: Iris Morelle wesnoth:schema_fixes 13e21adcfd0a / / (1539 files in 27 dirs): pot and documentation update https://github.com/wesnoth/wesnoth/commit/13e21adcfd0a47fdf0fc1c3f9576695d03d5ec34
20180519 20:25:42< irker007> wesnoth: loonycyborg wesnoth:schema_fixes 1eb762b4671d / src/server/server.cpp: wesnothd: made server fill in sender when forwarding whispers https://github.com/wesnoth/wesnoth/commit/1eb762b4671d7d4d7d551fc79ae3e8c0e7ba189b
20180519 20:25:44< irker007> wesnoth: Iris Morelle wesnoth:schema_fixes 9afd4501e704 / src/server/server.cpp: wesnothd: Use actual username when sending lobby messages too https://github.com/wesnoth/wesnoth/commit/9afd4501e7049cca649b56bae9ad3f94b2f4fce9
20180519 20:25:47< irker007> wesnoth: Iris Morelle wesnoth:schema_fixes bc195c0f1cac / changelog.md: Changelog entry for MP lobby message fixes https://github.com/wesnoth/wesnoth/commit/bc195c0f1cac307d149cbdcb01ea81265b1bfb32
20180519 20:25:50< irker007> wesnoth: Iris Morelle wesnoth:schema_fixes c6112fcfe3d4 / data/scenario-test.cfg: Remove stale include in test scenario causing errors https://github.com/wesnoth/wesnoth/commit/c6112fcfe3d4a75a50046553bfd0a3d5b62a21fb
20180519 20:25:53< irker007> wesnoth: Celtic Minstrel wesnoth:schema_fixes 100d3d4840dd / changelog.md src/scripting/lua_gui2.cpp: Fix two of the dialog functions not accepting translatable strings https://github.com/wesnoth/wesnoth/commit/100d3d4840dd23abce8d95cc14577527d1ec674e
20180519 20:25:55< irker007> wesnoth: Charles Dang wesnoth:schema_fixes 801b867afa1b / / (5 files in 3 dirs): Pre-release version bump https://github.com/wesnoth/wesnoth/commit/801b867afa1bf2cb792d5d48d159be3c586aed0f
20180519 20:25:58< irker007> wesnoth: Charles Dang wesnoth:schema_fixes a31413cc82b5 / Doxyfile changelog.md players_changelog.md src/wesconfig.h: Post-release version bump https://github.com/wesnoth/wesnoth/commit/a31413cc82b57104d2243c55bd14ab33300e6592
20180519 20:26:01< irker007> wesnoth: loonycyborg wesnoth:schema_fixes b9ee43f24fa8 / src/server/server.cpp: wesnothd: Fix UB caused by incorrect use of simple_wml::set_attr https://github.com/wesnoth/wesnoth/commit/b9ee43f24fa8d42db638372f0bc5dd0061804bb5
20180519 20:26:03< irker007> wesnoth: Nils Kneuper wesnoth:schema_fixes 26cda6bd21c4 / / (8 files in 7 dirs): updated Galician translation https://github.com/wesnoth/wesnoth/commit/26cda6bd21c40c05997b3a0cd6d95464db9b4515
20180519 20:26:05< irker007> wesnoth: Nils Kneuper wesnoth:schema_fixes f0514800d60c / / (11 files in 10 dirs): updated French translation https://github.com/wesnoth/wesnoth/commit/f0514800d60cf84e6dfdbed92fdd0c23c94fe203
20180519 20:26:07< irker007> wesnoth: Celtic Minstrel wesnoth:schema_fixes 42ee12621b95 / data/gui/window/statistics_dialog.cfg: Swap count and name columns in statistics (fixes #2893) https://github.com/wesnoth/wesnoth/commit/42ee12621b95c022b3677331abbcf6d23e54e810
20180519 20:26:09< irker007> wesnoth: Celtic Minstrel wesnoth:schema_fixes 6f47abd47f7c / data/gui/window/statistics_dialog.cfg: Remove redundant unused column in stats https://github.com/wesnoth/wesnoth/commit/6f47abd47f7c2c04d65a5353e59f9e3797d18f3c
20180519 20:26:11< irker007> wesnoth: ln-zookeeper wesnoth:schema_fixes a565e9259faa / data/campaigns/Under_the_Burning_Suns/_main.cfg: UtBS: Re-added compatibility code to load old saves using the new elves https://github.com/wesnoth/wesnoth/commit/a565e9259faa84d8d96b5aed0ab40f299e714f7c
20180519 20:26:13< irker007> wesnoth: Charles Dang wesnoth:schema_fixes 4c9ba39a7600 / src/gui/dialogs/drop_down_menu.cpp: Drop Down Menu: allow right clicks to dismiss the window (fixes #2910) https://github.com/wesnoth/wesnoth/commit/4c9ba39a76006792c912d47169a13bc067b556ad
20180519 20:26:16< irker007> wesnoth: Severin Glöckner wesnoth:schema_fixes abc6b797be1f / data/campaigns/Under_the_Burning_Suns/ (5 files in 3 dirs): finish renaming of the Horseman to Pathfinder https://github.com/wesnoth/wesnoth/commit/abc6b797be1f1a34791b0a03510e5d041970318a
20180519 20:26:18< irker007> wesnoth: Charles Dang wesnoth:schema_fixes 2ff68304ff03 / changelog.md src/units/unit.cpp: Utilized 2x xBRZ scaling for portraitless units in game dialog https://github.com/wesnoth/wesnoth/commit/2ff68304ff035da54af74e2d22cc742ebb031c72
20180519 20:26:21< irker007> wesnoth: Charles Dang wesnoth:schema_fixes 122621fd7bd0 / changelog.md: Changelog entry for 4c9ba39 https://github.com/wesnoth/wesnoth/commit/122621fd7bd0c2dee086d5599a965c20f46b72fe
20180519 20:26:24< irker007> wesnoth: Jyrki Vesterinen wesnoth:schema_fixes 77b9bc39695e / data/lua/wml/heal_unit.lua: [heal_unit]: ensure that heal amount is an integer https://github.com/wesnoth/wesnoth/commit/77b9bc39695eabe9202ec44e71688523974dcdc1
20180519 20:26:26< irker007> wesnoth: Charles Dang wesnoth:schema_fixes fab229b5e85e / src/ (scripting/lua_unit.cpp units/unit.cpp): Fixup 601c67d970c2eac https://github.com/wesnoth/wesnoth/commit/fab229b5e85e0b1c00d7f5223c3b2241cf6ba61c
20180519 20:26:29< irker007> wesnoth: Iris Morelle wesnoth:schema_fixes e6b17f88cbcc / src/campaign_server/ (campaign_server.cpp campaign_server.hpp): campaignd: Refactor add-on deletion code into its own method https://github.com/wesnoth/wesnoth/commit/e6b17f88cbcc8a3d0ace43cddab603fa1cd90b91
20180519 20:26:32< irker007> wesnoth: Iris Morelle wesnoth:schema_fixes 180995f46422 / src/campaign_server/campaign_server.cpp: campaignd: Add 'delete' control FIFO command https://github.com/wesnoth/wesnoth/commit/180995f46422661f0e1afd01a7b84cb3dafa3f24
20180519 20:26:35< irker007> wesnoth: Iris Morelle wesnoth:schema_fixes 83afa195215d / src/campaign_server/campaign_server.cpp: campaignd: Add 'hide'/'unhide' control FIFO commands and hidden= attribute https://github.com/wesnoth/wesnoth/commit/83afa195215dc35a3cb892a6be836980c413b88f
20180519 20:26:38< irker007> wesnoth: Iris Morelle wesnoth:schema_fixes 4d90a77aa8b1 / src/campaign_server/campaign_server.cpp: campaignd: Remove last remaining trace of the master_password functionality https://github.com/wesnoth/wesnoth/commit/4d90a77aa8b1431d00c0ecea40b73a1ef97e2711
20180519 20:26:41< irker007> wesnoth: Charles Dang wesnoth:schema_fixes 5e136419fec4 / changelog.md src/scripting/lua_unit.cpp: Revert "Utilized 2x xBRZ scaling for portraitless units in game dialog" https://github.com/wesnoth/wesnoth/commit/5e136419fec40b28df59747114f8b7eb37eaafcf
20180519 20:26:42<+discordbot> <Pentarctagon> alright, I'll merge it then.
20180519 20:26:44< irker007> wesnoth: Jyrki Vesterinen wesnoth:schema_fixes 8a0027691363 / / (9 files in 5 dirs): Implement saving MP chat message history (#1194, #2802) https://github.com/wesnoth/wesnoth/commit/8a0027691363c05fa06657f8c4e466054a530fda
20180519 20:26:46< irker007> wesnoth: Jyrki Vesterinen wesnoth:schema_fixes 9646434bc10c / changelog.md players_changelog.md: Changelog entry for commit 8a00276913 https://github.com/wesnoth/wesnoth/commit/9646434bc10cb68177dc8864a1ed9ede426cac8f
20180519 20:26:47< celticminstrel> Hm?
20180519 20:26:48< irker007> wesnoth: Iris Morelle wesnoth:schema_fixes 1e67b2616fad / changelog.md src/preferences/credentials.cpp: Fix segfault when trying to log into the MP server with an empty password https://github.com/wesnoth/wesnoth/commit/1e67b2616fadf1d16135cb3a800070377656f161
20180519 20:26:50< celticminstrel> Oh right, the units.
20180519 20:26:51< irker007> wesnoth: Charles Dang wesnoth:schema_fixes cd036961f68b / src/gui/widgets/chatbox.cpp: Fix tests https://github.com/wesnoth/wesnoth/commit/cd036961f68b23a4a03aa6d93386e8b17dd1834a
20180519 20:26:54< irker007> wesnoth: Martin Hrubý (hrubymar10) wesnoth:schema_fixes b2883cb0f70e / projectfiles/Xcode/Wesnoth.xcodeproj/project.pbxproj: Fix Xcode project after a02100a0f15bd015c2322b7b528b0b9b60a1c678 https://github.com/wesnoth/wesnoth/commit/b2883cb0f70e8188c8522bfc95730b9ba0c99618
20180519 20:26:56< irker007> wesnoth: Nils Kneuper wesnoth:schema_fixes 5ffd7470816a / / (8 files in 7 dirs): updated Slovak translation https://github.com/wesnoth/wesnoth/commit/5ffd7470816a0580d39008b0db4e2282aed7706a
20180519 20:26:58< irker007> wesnoth: Iris Morelle wesnoth:schema_fixes 91de2a4c9812 / changelog.md src/gui/dialogs/title_screen.cpp: gui2/title_screen: Make Version label formatted and translatable https://github.com/wesnoth/wesnoth/commit/91de2a4c9812d0cb0c963e85565e23778c071e32
20180519 20:27:01< irker007> wesnoth: Charles Dang wesnoth:schema_fixes 3cb1641d07ab / data/campaigns/Under_the_Burning_Suns/images/units/quenoth/flagbearer.png: UtBS: improved the Quenoth Flagbearer's flag https://github.com/wesnoth/wesnoth/commit/3cb1641d07ab3f744307316d9368aa9ce02f2c4f
20180519 20:27:04< irker007> wesnoth: Charles Dang wesnoth:schema_fixes 12495f9070af / data/campaigns/Under_the_Burning_Suns/images/units/quenoth/ (rider.png stalwart.png vanguard.png): UtBS: fixed some opaque shadows on rider units due to indexed pngs https://github.com/wesnoth/wesnoth/commit/12495f9070afef4441fddaa1fd3341556a985756
20180519 20:27:07< irker007> wesnoth: Nils Kneuper wesnoth:schema_fixes 57f773aa5a6b / changelog.md players_changelog.md po/wesnoth/de.po: updated German translation https://github.com/wesnoth/wesnoth/commit/57f773aa5a6be107df0bfcc08a8aea6c7cc47744
20180519 20:27:09< irker007> wesnoth: Martin Hrubý (hrubymar10) wesnoth:schema_fixes ee500f57ece6 / players_changelog.md projectfiles/Xcode/Wesnoth.xcodeproj/project.pbxproj: Update macOS user dir path https://github.com/wesnoth/wesnoth/commit/ee500f57ece60900060c606679a140a76b622944
20180519 20:27:11< irker007> wesnoth: Martin Hrubý (hrubymar10) wesnoth:schema_fixes 4ba1811f03bf / data/themes/default.cfg: Fix MP label for #2855 https://github.com/wesnoth/wesnoth/commit/4ba1811f03bfd6b9706a281e05c316be86cbe97c
20180519 20:27:13< irker007> wesnoth: Martin Hrubý (hrubymar10) wesnoth:schema_fixes 47bd5ade3726 / data/themes/default.cfg: Fix for defense label which I broke in 4ba1811f03bfd6b9706a281e05c316be86cbe97c https://github.com/wesnoth/wesnoth/commit/47bd5ade3726675c0d6e4e68af82004a01ddb63d
20180519 20:27:15< irker007> wesnoth: Nils Kneuper wesnoth:schema_fixes 9a59c9627be0 / / (7 files in 6 dirs): updated Scottish Gaelic translation https://github.com/wesnoth/wesnoth/commit/9a59c9627be0aa7d84dc8098d650dba0c9fa08ae
20180519 20:27:17< irker007> wesnoth: Charles Dang wesnoth:schema_fixes 37f3c1c86941 / data/campaigns/Under_the_Burning_Suns/ (42 files in 2 dirs): UtBS: added new Quenoth faction portraits by LordBob https://github.com/wesnoth/wesnoth/commit/37f3c1c869412f1c2e487f066919edd59aa7c55c
20180519 20:27:18< celticminstrel> Someone should probably mute irker because I'm gonna force-push and overwrite everything it's posting anyway.
20180519 20:27:20<+discordbot> <shadowm> Had to fix a few translations myself.
20180519 20:27:20< irker007> wesnoth: Charles Dang wesnoth:schema_fixes 49b0dc7254f7 / data/campaigns/Under_the_Burning_Suns/ (6 files in 3 dirs): UtBS: removed unused Quenoth Moon Singer and Quenoth Moon Shyde units https://github.com/wesnoth/wesnoth/commit/49b0dc7254f7ef33dea047b9d5c57c5df121a9dd
20180519 20:27:23< irker007> wesnoth: Charles Dang wesnoth:schema_fixes 367c8b3703a1 / data/campaigns/Under_the_Burning_Suns/ (30 files in 3 dirs): UtBS: renamed the Quenoth Sun Sylph's unit and image files to match her type https://github.com/wesnoth/wesnoth/commit/367c8b3703a17a111e910f56b164ebc7cdc4c3d2
20180519 20:27:26< irker007> wesnoth: Charles Dang wesnoth:schema_fixes 0e96a281420c / data/campaigns/Under_the_Burning_Suns/ (4 files in 3 dirs): UtBS: wmlindent pass https://github.com/wesnoth/wesnoth/commit/0e96a281420c7f7616ffe0d1c9357fbd853b741b
20180519 20:27:30-!- mode/#wesnoth-dev [+q *!*@uruz.ai0867.net] by ChanServ
20180519 20:27:32-!- mode/#wesnoth-dev [+o shadowm] by ChanServ
20180519 20:27:33-!- mode/#wesnoth-dev [+z] by shadowm
20180519 20:28:43< mattsc> Yay!
20180519 20:32:35<@shadowm> For how long should I expect it to keep going?
20180519 20:32:46< celticminstrel> I actually don't know.
20180519 20:33:10< celticminstrel> I think it's something like all commits since 1.14.0 or something.
20180519 20:34:37<+discordbot> <shadowm> Good grief.
20180519 20:34:42<+discordbot> <shadowm> Well, I'll be back later then.
20180519 20:34:52< mattsc> Blargh.  I am too stupid to understand Alarantalara’s recruiting logic!
20180519 20:34:53<@shadowm> (it's still going)
20180519 20:39:26< celticminstrel> So now that the dunefolk extras are added, how about the elvish hunter line?
20180519 20:42:44<+discordbot> <shadowm> (And still going.)
20180519 20:42:55<+discordbot> <shadowm> Wait.
20180519 20:43:04<+discordbot> <shadowm> These are commits to the 1.14 branch.
20180519 20:43:17<+discordbot> <shadowm> Ohhhhh I see.
20180519 20:43:33< celticminstrel> Hmm?
20180519 20:43:38<+discordbot> <shadowm> YOUR COMMITS.
20180519 20:43:44< celticminstrel> What?
20180519 20:43:52<+discordbot> <shadowm> You can't see it but I thought it was obvious.
20180519 20:43:56<+discordbot> <shadowm> irker is still flooding me with commits.
20180519 20:44:04<+discordbot> <shadowm> Oh, there it goes, that was the last one.
20180519 20:44:06< celticminstrel> I imagine it should be almost done now.
20180519 20:44:10< celticminstrel> Or done, even, sure.
20180519 20:44:25-!- mode/#wesnoth-dev [-qzo *!*@uruz.ai0867.net shadowm] by shadowm
20180519 20:44:56<+discordbot> <shadowm> I assume turns=-1 is still valid, just not recommended?
20180519 20:45:27< celticminstrel> Yeah/
20180519 20:45:37-!- irker007 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20180519 20:46:10<+discordbot> <shadowm> For the record, since side= doesn't make sense (AFAIK, or otherwise it can be safely omitted) in unit definitions in a [side] tag, I normally omit it and use an empty string in macros that mandate it.
20180519 20:46:31< celticminstrel> There's no particular problem with that.
20180519 20:49:16-!- gfgtdf [~chatzilla@x4e36362b.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.93 [Firefox 52.8.0/20180430140610]]
20180519 21:34:33-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20180519 21:35:59-!- travis-ci [~travis-ci@ec2-54-82-78-251.compute-1.amazonaws.com] has joined #wesnoth-dev
20180519 21:36:00< travis-ci> wesnoth/wesnoth#18227 (master - 16bfab0 : Pentarctagon): The build passed.
20180519 21:36:01< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/381167948
20180519 21:36:01-!- travis-ci [~travis-ci@ec2-54-82-78-251.compute-1.amazonaws.com] has left #wesnoth-dev []
20180519 21:41:14-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20180519 21:43:58-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20180519 21:55:40-!- travis-ci [~travis-ci@ec2-54-82-78-251.compute-1.amazonaws.com] has joined #wesnoth-dev
20180519 21:55:41< travis-ci> wesnoth/wesnoth#18229 (schema_fixes - c1179d9 : Celtic Minstrel): The build was broken.
20180519 21:55:42< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/381169393
20180519 21:55:42-!- travis-ci [~travis-ci@ec2-54-82-78-251.compute-1.amazonaws.com] has left #wesnoth-dev []
20180519 22:20:29-!- Bhoren [~Bhoren_wh@2a01:e0a:c:2150:29d8:1ad5:8780:274c] has quit [Remote host closed the connection]
20180519 22:27:28-!- irker006 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20180519 22:27:28< irker006> wesnoth/wesnoth:master Jyrki Vesterinen a388c2d891 Fix build with -Werror=unused-variable AppVeyor: All builds passed
20180519 23:15:20< irker006> wesnoth: gfgtdf wesnoth:master a10287c5c2a4 / src/ (game_initialization/create_engine.cpp saved_game.cpp saved_game.hpp): fix require_scenario=yes not working with map_generation https://github.com/wesnoth/wesnoth/commit/a10287c5c2a49ff248f218c11f4061e472090089
20180519 23:15:22<+discordbot> <Vultraz> forward-ported
20180519 23:18:49< celticminstrel> Oh hey, is the new Travis stuff available now? I see a "checks" tab on PRs but it says 0.
20180519 23:19:42<+discordbot> <Vultraz> I tried setting us up but it seemsnot yet
20180519 23:20:18<+discordbot> <Vultraz> your schema validator is on master, right?
20180519 23:21:04< celticminstrel> Not yet.
20180519 23:21:10<+discordbot> <Vultraz> what?
20180519 23:21:14< celticminstrel> It's not on master yet.
20180519 23:21:22<+discordbot> <Vultraz> :/
20180519 23:21:25< celticminstrel> It'd still on the schema branch which is against 1.14 ATM.
20180519 23:21:29< celticminstrel> I haven't finished it.
20180519 23:22:16<+discordbot> <Vultraz> still?
20180519 23:22:35<+discordbot> <Vultraz> oh well, I guess I'm in no position to speak on this matter...
20180519 23:22:54< celticminstrel> Still haven't gotten back to it since the 1.14.0 release, as I was focusing more on my campaign.
20180519 23:26:10< irker006> wesnoth: Charles Dang wesnoth:master 91150f250433 / data/campaigns/The_Hammer_of_Thursagan/scenarios/02_Reclaiming_the_Past.cfg: THoT S2: fixed misspelled event name (fixes #3131) https://github.com/wesnoth/wesnoth/commit/91150f25043386454d62f1956da0df134ab1ce86
20180519 23:26:50< irker006> wesnoth: Charles Dang wesnoth:1.14 61d2f936ed8c / data/campaigns/The_Hammer_of_Thursagan/scenarios/02_Reclaiming_the_Past.cfg: THoT S2: fixed misspelled event name (fixes #3131) https://github.com/wesnoth/wesnoth/commit/61d2f936ed8c12caa52a7444d3594e49ff876d3b
20180519 23:27:04< celticminstrel> I like how you can push two branches simultaneously though.
20180519 23:27:09< celticminstrel> "git push origin master 1.14"
20180519 23:28:11<+discordbot> <Vultraz> you can?
20180519 23:28:18<+discordbot> <Vultraz> huh
20180519 23:28:43< celticminstrel> I mean it doesn't matter or anything.
20180519 23:28:59< celticminstrel> There's probably no disadvantage in pushing the branches separately.
20180519 23:41:54<+discordbot> <shadowm> @Vultraz Did you see Ivanovic's message by the way?
20180519 23:43:07<+discordbot> <Vultraz> what message?
20180519 23:43:26<+discordbot> <Vultraz> oh that
20180519 23:43:30<+discordbot> <Vultraz> just saw it now
20180519 23:44:08<+discordbot> <Vultraz> i know
20180519 23:44:22<+discordbot> <shadowm> celticminstrel: Still no fix for those deprecation errors?
20180519 23:44:29< celticminstrel> Which ones?
20180519 23:44:31<+discordbot> <Vultraz> that's why I'm not asking them to push a patch this weekend
20180519 23:46:05<+discordbot> <Vultraz> celmin: presumably the ones that pop up when you use MENU_IMG_TXT
20180519 23:46:15<+discordbot> <Vultraz> since #deprecated does't work for key value macros
20180519 23:46:16< celticminstrel> ?
20180519 23:46:20< celticminstrel> Oh that.
20180519 23:46:36<+discordbot> <Vultraz> t'is a blocker
20180519 23:52:57< celticminstrel> So it happens when you start a campaign, or something like that?
20180519 23:53:28<+discordbot> <Vultraz> the error pops up immediately on start
20180519 23:53:32<+discordbot> <Vultraz> a preprocessor error
20180519 23:53:37< celticminstrel> Uh. I don't see it?
20180519 23:53:50< celticminstrel> There were no errors on startup when I added that command-line option.
20180519 23:53:52<+discordbot> <Vultraz> because you don't have a campaign installed that uses the old macros
20180519 23:53:57< celticminstrel> Ohhh.
20180519 23:55:42<+discordbot> <shadowm> When he says start he means Wesnoth launch btw.
20180519 23:55:50< celticminstrel> Yeah I gathered that.
20180519 23:57:42< irker006> wesnoth/wesnoth:master Pentarctagon d68cb2b6ad Add new units as discussed on the forums AppVeyor: All builds passed
--- Log closed Sun May 20 00:00:29 2018